DOM: 4.4. Interface Node

From aa4c06d30b67a396f62c4888e9d80442e65dd656 Mon Sep 17 00:00:00 2001 From: "rniwa@webkit.org" Date: Sat, 30 Apr 2016 21:58:41 +0000 Subject: [PATCH] Node.prototype.rootNode is not Web compatible https://bugs.webkit.org/show_bug.cgi?id=157233 Reviewed by Chris Dumez. Source/WebCore: Turns out that the name rootNode is not Web compatible. Remove the method for now until we can come up with a better name in https://github.com/whatwg/dom/issues/241. No new tests since we're just removing a method. * dom/Node.idl: LayoutTests: Removed tests for Node.prototype.rootNode. * fast/dom/Node/rootNode-expected.txt: Removed. * fast/dom/Node/rootNode.html: Removed. * fast/shadow-dom/Node-interface-rootNode-expected.txt: Removed. * fast/shadow-dom/Node-interface-rootNode.html: Removed. * js/dom/dom-static-property-for-in-iteration-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@200297 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 15 +++ LayoutTests/fast/dom/Node/rootNode-expected.txt | 7 -- LayoutTests/fast/dom/Node/rootNode.html | 94 ---------------- .../Node-interface-rootNode-expected.txt | 12 -- .../fast/shadow-dom/Node-interface-rootNode.html | 121 --------------------- ...m-static-property-for-in-iteration-expected.txt | 1 - Source/WebCore/ChangeLog | 14 +++ Source/WebCore/dom/Node.idl | 2 - 8 files changed, 29 insertions(+), 237 deletions(-) delete mode 100644 LayoutTests/fast/dom/Node/rootNode-expected.txt delete mode 100644 LayoutTests/fast/dom/Node/rootNode.html delete mode 100644 LayoutTests/fast/shadow-dom/Node-interface-rootNode-expected.txt delete mode 100644 LayoutTests/fast/shadow-dom/Node-interface-rootNode.html diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 51e46b6..ef97fb8 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,18 @@ +2016-04-30 Ryosuke Niwa + + Node.prototype.rootNode is not Web compatible + https://bugs.webkit.org/show_bug.cgi?id=157233 + + Reviewed by Chris Dumez. + + Removed tests for Node.prototype.rootNode. + + * fast/dom/Node/rootNode-expected.txt: Removed. + * fast/dom/Node/rootNode.html: Removed. + * fast/shadow-dom/Node-interface-rootNode-expected.txt: Removed. + * fast/shadow-dom/Node-interface-rootNode.html: Removed. + * js/dom/dom-static-property-for-in-iteration-expected.txt: + 2016-04-30 Nan Wang AX: @aria-label attribute should work on element diff --git a/LayoutTests/fast/dom/Node/rootNode-expected.txt b/LayoutTests/fast/dom/Node/rootNode-expected.txt deleted file mode 100644 index ee0805e..0000000 --- a/LayoutTests/fast/dom/Node/rootNode-expected.txt +++ /dev/null @@ -1,7 +0,0 @@ - -PASS rootNode attribute must be defined on Node interface -PASS rootNode attribute must return the context object when it does not have any parent -PASS rootNode attribute must return the parent node of the context object when the context object has a single ancestor not in a document -PASS rootNode attribute must return the document when a node is in document -PASS rootNode attribute must return a document fragment when a node is in the fragment - diff --git a/LayoutTests/fast/dom/Node/rootNode.html b/LayoutTests/fast/dom/Node/rootNode.html deleted file mode 100644 index 9702c0e..0000000 --- a/LayoutTests/fast/dom/Node/rootNode.html +++ /dev/null @@ -1,94 +0,0 @@ - - - -DOM: 4.4. Interface Node - - - - - - - - -

- - - diff --git a/LayoutTests/fast/shadow-dom/Node-interface-rootNode-expected.txt b/LayoutTests/fast/shadow-dom/Node-interface-rootNode-expected.txt deleted file mode 100644 index 521f1ff2..0000000 --- a/LayoutTests/fast/shadow-dom/Node-interface-rootNode-expected.txt +++ /dev/null @@ -1,12 +0,0 @@ - -PASS rootNode attribute must be defined on ShadowRoot interface -PASS rootNode attribute must return the context object when it does not have any parent -PASS rootNode attribute must return the parent node of the context object when the context object has a single ancestor not in a document -PASS rootNode attribute must return the document when a node is in document and not in a shadow tree -PASS rootNode attribute must return the open shadow root of the context object when the shadow host is in a document -PASS rootNode attribute must return the closed shadow root of the context object when the shadow host is in a document -PASS rootNode attribute must return the root node of the context object when the context object is inside a open shadow root whose shadow host is in another open shadow root -PASS rootNode attribute must return the root node of the context object when the context object is inside a closed shadow root whose shadow host is in another open shadow root -PASS rootNode attribute must return the root node of the context object when the context object is inside a open shadow root whose shadow host is in another closed shadow root -PASS rootNode attribute must return the root node of the context object when the context object is inside a closed shadow root whose shadow host is in another closed shadow root - diff --git a/LayoutTests/fast/shadow-dom/Node-interface-rootNode.html b/LayoutTests/fast/shadow-dom/Node-interface-rootNode.html deleted file mode 100644 index e77634f..0000000 --- a/LayoutTests/fast/shadow-dom/Node-interface-rootNode.html +++ /dev/null @@ -1,121 +0,0 @@ - - - -Shadow DOM: Extensions to Node interface - - - - - - - - -

- - - diff --git a/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt b/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt index 10b9b1e..424a099 100644 --- a/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt +++ b/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt @@ -143,7 +143,6 @@ PASS a["lastChild"] is [object Text] PASS a["previousSibling"] is [object Text] PASS a["nextSibling"] is [object Text] PASS a["ownerDocument"] is [object HTMLDocument] -PASS a["rootNode"] is [object HTMLDocument] PASS a["namespaceURI"] is http://www.w3.org/1999/xhtml PASS a["prefix"] is null PASS a["localName"] is a diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 7ce95be..f6529d6 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,17 @@ +2016-04-30 Ryosuke Niwa + + Node.prototype.rootNode is not Web compatible + https://bugs.webkit.org/show_bug.cgi?id=157233 + + Reviewed by Chris Dumez. + + Turns out that the name rootNode is not Web compatible. Remove the method for now + until we can come up with a better name in https://github.com/whatwg/dom/issues/241. + + No new tests since we're just removing a method. + + * dom/Node.idl: + 2016-04-30 Darin Adler Try to fix GTK build. diff --git a/Source/WebCore/dom/Node.idl b/Source/WebCore/dom/Node.idl index a3764c6..be0879b 100644 --- a/Source/WebCore/dom/Node.idl +++ b/Source/WebCore/dom/Node.idl @@ -61,8 +61,6 @@ readonly attribute Node nextSibling; readonly attribute Document ownerDocument; - readonly attribute Node rootNode; - // FIXME: newChild should not be nullable. [ObjCLegacyUnnamedParameters, Custom, RaisesException] Node insertBefore([CustomReturn] Node? newChild, Node? refChild); -- 1.8.3.1