WebKit.git
14 years ago2008-06-14 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 14 Jun 2008 22:13:18 +0000 (22:13 +0000)]
2008-06-14  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - initialize local vars as side effect of call instead of in bytecode
        1.004x speedup on SunSpider.

        This removes just the dispatch overhead for these loads - in the
        future, dead store elimination might be able to eliminate them
        entirely.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator): For function blocks, don't
        emit loads of undefined for var initialization.
        * VM/Machine.cpp:
        (KJS::slideRegisterWindowForCall): Instead, initialize locals
        as part of the call.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Jun 2008 19:33:38 +0000 (19:33 +0000)]
2008-06-14  Adam Barth  <abarth@webkit.org>

        Reviewed by David Kilzer.

        Fix typo.

        * dom/XMLTokenizer.cpp:
        (WebCore::shouldAllowExternalLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 14 Jun 2008 09:56:04 +0000 (09:56 +0000)]
2008-06-14  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Remove helper functions in the parser that are no longer needed.

        * kjs/grammar.y:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-14 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 14 Jun 2008 09:18:14 +0000 (09:18 +0000)]
2008-06-14  Darin Adler  <darin@apple.com>

        - fix build

        * plugins/PluginStream.h: Move functions back into public section.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-14 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 14 Jun 2008 08:47:31 +0000 (08:47 +0000)]
2008-06-14  Darin Adler  <darin@apple.com>

        * Scripts/do-webcore-rename: Fixed obvious typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sat, 14 Jun 2008 08:46:51 +0000 (08:46 +0000)]
WebCore:

2008-06-14  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * WebCore.base.exp:
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::multiply):
        (WebCore::JSSVGMatrix::inverse):
        (WebCore::JSSVGMatrix::translate):
        (WebCore::JSSVGMatrix::scale):
        (WebCore::JSSVGMatrix::scaleNonUniform):
        (WebCore::JSSVGMatrix::rotate):
        (WebCore::JSSVGMatrix::rotateFromVector):
        (WebCore::JSSVGMatrix::flipX):
        (WebCore::JSSVGMatrix::flipY):
        (WebCore::JSSVGMatrix::skewX):
        (WebCore::JSSVGMatrix::skewY):
        * bindings/js/JSSVGPODTypeWrapper.h:
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
        (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
        (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::finishGetter):
        (WebCore::finishSetter):
        (WebCore::finishSetterReadOnlyResult):
        (WebCore::JSSVGPointList::clear):
        (WebCore::JSSVGPointList::initialize):
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        (WebCore::JSSVGPointList::appendItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::finishGetter):
        (WebCore::finishSetter):
        (WebCore::finishSetterReadOnlyResult):
        (WebCore::JSSVGTransformList::clear):
        (WebCore::JSSVGTransformList::initialize):
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        (WebCore::JSSVGTransformList::appendItem):
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::CSSFontSelector):
        (WebCore::CSSFontSelector::~CSSFontSelector):
        * css/CSSFontSelector.h:
        (WebCore::CSSFontSelector::create):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::applyProperty):
        * dom/Attribute.cpp:
        (WebCore::Attribute::clone):
        * dom/Attribute.h:
        (WebCore::Attribute::create):
        (WebCore::Attribute::Attribute):
        * dom/BeforeTextInsertedEvent.h:
        (WebCore::BeforeTextInsertedEvent::create):
        * dom/BeforeUnloadEvent.h:
        (WebCore::BeforeUnloadEvent::create):
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::dispatchModifiedEvent):
        * dom/ClipboardEvent.cpp:
        (WebCore::ClipboardEvent::ClipboardEvent):
        * dom/ClipboardEvent.h:
        (WebCore::ClipboardEvent::create):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChild):
        (WebCore::dispatchChildInsertionEvents):
        (WebCore::dispatchChildRemovalEvents):
        * dom/Document.cpp:
        (WebCore::Document::createTextNode):
        (WebCore::Document::createComment):
        (WebCore::Document::createCDATASection):
        (WebCore::Document::createProcessingInstruction):
        (WebCore::Document::createEntityReference):
        (WebCore::Document::createEditingTextNode):
        (WebCore::Document::createEvent):
        (WebCore::Document::createAttributeNS):
        (WebCore::Document::finishedParsing):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::createAttribute):
        * dom/Element.h:
        * dom/Event.cpp:
        (WebCore::Event::Event):
        * dom/Event.h:
        (WebCore::Event::create):
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
        (WebCore::EventTargetNode::dispatchWindowEvent):
        (WebCore::EventTargetNode::dispatchUIEvent):
        (WebCore::EventTargetNode::dispatchKeyEvent):
        (WebCore::EventTargetNode::dispatchMouseEvent):
        (WebCore::EventTargetNode::dispatchWheelEvent):
        (WebCore::EventTargetNode::dispatchHTMLEvent):
        (WebCore::EventTargetNode::dispatchProgressEvent):
        (WebCore::EventTargetNode::dispatchStorageEvent):
        * dom/KeyboardEvent.h:
        (WebCore::KeyboardEvent::create):
        * dom/MappedAttribute.cpp:
        (WebCore::MappedAttribute::clone):
        * dom/MappedAttribute.h:
        (WebCore::MappedAttribute::create):
        (WebCore::MappedAttribute::setDecl):
        (WebCore::MappedAttribute::MappedAttribute):
        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        * dom/MessageEvent.h:
        (WebCore::MessageEvent::create):
        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::MouseEvent):
        (WebCore::MouseEvent::initMouseEvent):
        * dom/MouseEvent.h:
        (WebCore::MouseEvent::create):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
        * dom/MouseRelatedEvent.h:
        * dom/MutationEvent.cpp:
        (WebCore::MutationEvent::MutationEvent):
        (WebCore::MutationEvent::initMutationEvent):
        * dom/MutationEvent.h:
        (WebCore::MutationEvent::create):
        * dom/OverflowEvent.h:
        (WebCore::OverflowEvent::create):
        * dom/ProgressEvent.h:
        (WebCore::ProgressEvent::create):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::getMappedAttributeDecl):
        (WebCore::StyledElement::setMappedAttributeDecl):
        (WebCore::StyledElement::removeMappedAttributeDecl):
        (WebCore::StyledElement::createAttribute):
        * dom/StyledElement.h:
        * dom/TextEvent.cpp:
        (WebCore::TextEvent::TextEvent):
        (WebCore::TextEvent::initTextEvent):
        * dom/TextEvent.h:
        (WebCore::TextEvent::create):
        * dom/UIEvent.cpp:
        (WebCore::UIEvent::UIEvent):
        (WebCore::UIEvent::initUIEvent):
        * dom/UIEvent.h:
        (WebCore::UIEvent::create):
        * dom/UIEventWithKeyState.h:
        (WebCore::UIEventWithKeyState::ctrlKey):
        (WebCore::UIEventWithKeyState::shiftKey):
        (WebCore::UIEventWithKeyState::altKey):
        (WebCore::UIEventWithKeyState::metaKey):
        (WebCore::UIEventWithKeyState::UIEventWithKeyState):
        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        (WebCore::WheelEvent::initWheelEvent):
        * dom/WheelEvent.h:
        (WebCore::WheelEvent::create):
        * editing/AppendNodeCommand.cpp:
        (WebCore::AppendNodeCommand::AppendNodeCommand):
        * editing/AppendNodeCommand.h:
        (WebCore::AppendNodeCommand::create):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        * editing/ApplyStyleCommand.h:
        (WebCore::ApplyStyleCommand::create):
        * editing/BreakBlockquoteCommand.h:
        (WebCore::BreakBlockquoteCommand::create):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::applyStyle):
        (WebCore::CompositeEditCommand::applyStyledElement):
        (WebCore::CompositeEditCommand::removeStyledElement):
        (WebCore::CompositeEditCommand::insertParagraphSeparator):
        (WebCore::CompositeEditCommand::insertLineBreak):
        (WebCore::CompositeEditCommand::insertNodeBefore):
        (WebCore::CompositeEditCommand::appendNode):
        (WebCore::CompositeEditCommand::removeNode):
        (WebCore::CompositeEditCommand::removeNodePreservingChildren):
        (WebCore::CompositeEditCommand::splitTextNode):
        (WebCore::CompositeEditCommand::splitElement):
        (WebCore::CompositeEditCommand::mergeIdenticalElements):
        (WebCore::CompositeEditCommand::wrapContentsInDummySpan):
        (WebCore::CompositeEditCommand::splitTextNodeContainingElement):
        (WebCore::CompositeEditCommand::joinTextNodes):
        (WebCore::CompositeEditCommand::inputText):
        (WebCore::CompositeEditCommand::insertTextIntoNode):
        (WebCore::CompositeEditCommand::deleteTextFromNode):
        (WebCore::CompositeEditCommand::replaceTextInNode):
        (WebCore::CompositeEditCommand::deleteSelection):
        (WebCore::CompositeEditCommand::removeCSSProperty):
        (WebCore::CompositeEditCommand::removeNodeAttribute):
        (WebCore::CompositeEditCommand::setNodeAttribute):
        (WebCore::CompositeEditCommand::appendBlockPlaceholder):
        (WebCore::CompositeEditCommand::insertBlockPlaceholder):
        (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
        (WebCore::CompositeEditCommand::moveParagraphs):
        (WebCore::CompositeEditCommand::splitTreeToNode):
        * editing/CompositeEditCommand.h:
        (WebCore::CompositeEditCommand::isFirstCommand):
        * editing/CreateLinkCommand.h:
        (WebCore::CreateLinkCommand::create):
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::deleteTarget):
        * editing/DeleteFromTextNodeCommand.cpp:
        (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
        * editing/DeleteFromTextNodeCommand.h:
        (WebCore::DeleteFromTextNodeCommand::create):
        * editing/DeleteSelectionCommand.h:
        (WebCore::DeleteSelectionCommand::create):
        * editing/EditCommand.h:
        (WebCore::SimpleEditCommand::SimpleEditCommand):
        * editing/Editor.cpp:
        (WebCore::Editor::deleteSelectionWithSmartDelete):
        (WebCore::Editor::replaceSelectionWithFragment):
        (WebCore::Editor::removeFormattingAndStyle):
        (WebCore::Editor::clearLastEditCommand):
        (WebCore::Editor::dispatchCPPEvent):
        (WebCore::Editor::applyStyle):
        (WebCore::Editor::applyParagraphStyle):
        (WebCore::Editor::indent):
        (WebCore::Editor::outdent):
        (WebCore::dispatchEditableContentChangedEvents):
        * editing/Editor.h:
        * editing/EditorCommand.cpp:
        (WebCore::executeInsertFragment):
        (WebCore::executeCreateLink):
        (WebCore::executeFormatBlock):
        (WebCore::executeIndent):
        (WebCore::executeInsertOrderedList):
        (WebCore::executeInsertUnorderedList):
        (WebCore::executeOutdent):
        (WebCore::executeUnlink):
        * editing/FormatBlockCommand.h:
        (WebCore::FormatBlockCommand::create):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion):
        (WebCore::IndentOutdentCommand::outdentParagraph):
        * editing/IndentOutdentCommand.h:
        (WebCore::IndentOutdentCommand::create):
        * editing/InsertIntoTextNodeCommand.cpp:
        (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
        * editing/InsertIntoTextNodeCommand.h:
        (WebCore::InsertIntoTextNodeCommand::create):
        * editing/InsertLineBreakCommand.h:
        (WebCore::InsertLineBreakCommand::create):
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply):
        * editing/InsertListCommand.h:
        (WebCore::InsertListCommand::create):
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
        * editing/InsertNodeBeforeCommand.h:
        (WebCore::InsertNodeBeforeCommand::create):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.h:
        (WebCore::InsertParagraphSeparatorCommand::create):
        * editing/InsertTextCommand.h:
        (WebCore::InsertTextCommand::create):
        * editing/JoinTextNodesCommand.cpp:
        (WebCore::JoinTextNodesCommand::JoinTextNodesCommand):
        * editing/JoinTextNodesCommand.h:
        (WebCore::JoinTextNodesCommand::create):
        * editing/MergeIdenticalElementsCommand.cpp:
        (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
        * editing/MergeIdenticalElementsCommand.h:
        (WebCore::MergeIdenticalElementsCommand::create):
        * editing/ModifySelectionListLevel.cpp:
        (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply):
        * editing/MoveSelectionCommand.h:
        (WebCore::MoveSelectionCommand::create):
        * editing/RemoveCSSPropertyCommand.cpp:
        (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
        * editing/RemoveCSSPropertyCommand.h:
        (WebCore::RemoveCSSPropertyCommand::create):
        * editing/RemoveFormatCommand.h:
        (WebCore::RemoveFormatCommand::create):
        * editing/RemoveNodeAttributeCommand.cpp:
        (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
        * editing/RemoveNodeAttributeCommand.h:
        (WebCore::RemoveNodeAttributeCommand::create):
        * editing/RemoveNodeCommand.cpp:
        (WebCore::RemoveNodeCommand::RemoveNodeCommand):
        * editing/RemoveNodeCommand.h:
        (WebCore::RemoveNodeCommand::create):
        * editing/RemoveNodePreservingChildrenCommand.cpp:
        (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
        (WebCore::RemoveNodePreservingChildrenCommand::doApply):
        * editing/RemoveNodePreservingChildrenCommand.h:
        (WebCore::RemoveNodePreservingChildrenCommand::create):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::):
        (WebCore::ReplacementFragment::hasInterchangeNewlineAtStart):
        (WebCore::ReplacementFragment::hasInterchangeNewlineAtEnd):
        (WebCore::ReplacementFragment::ReplacementFragment):
        * editing/ReplaceSelectionCommand.h:
        (WebCore::ReplaceSelectionCommand::create):
        * editing/SetNodeAttributeCommand.cpp:
        (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand):
        * editing/SetNodeAttributeCommand.h:
        (WebCore::SetNodeAttributeCommand::create):
        * editing/SplitElementCommand.cpp:
        (WebCore::SplitElementCommand::SplitElementCommand):
        * editing/SplitElementCommand.h:
        (WebCore::SplitElementCommand::create):
        * editing/SplitTextNodeCommand.cpp:
        (WebCore::SplitTextNodeCommand::SplitTextNodeCommand):
        * editing/SplitTextNodeCommand.h:
        (WebCore::SplitTextNodeCommand::create):
        * editing/SplitTextNodeContainingElementCommand.cpp:
        (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
        * editing/SplitTextNodeContainingElementCommand.h:
        (WebCore::SplitTextNodeContainingElementCommand::create):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteSelection):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        (WebCore::TypingCommand::insertText):
        (WebCore::TypingCommand::insertLineBreak):
        (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
        (WebCore::TypingCommand::insertParagraphSeparator):
        (WebCore::TypingCommand::insertTextRunWithoutNewlines):
        * editing/TypingCommand.h:
        (WebCore::TypingCommand::create):
        (WebCore::TypingCommand::smartDelete):
        * editing/UnlinkCommand.h:
        (WebCore::UnlinkCommand::create):
        * editing/WrapContentsInDummySpanCommand.cpp:
        (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
        * editing/WrapContentsInDummySpanCommand.h:
        (WebCore::WrapContentsInDummySpanCommand::create):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
        (WebCore::HTMLTableElement::addSharedCellBordersDecl):
        (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
        (WebCore::HTMLTableElement::addSharedGroupDecls):
        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createContainingTable):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        (WebCore::HTMLViewSourceDocument::addLine):
        (WebCore::HTMLViewSourceDocument::addLink):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didOpenURL):
        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::callListener):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/DOMWindow.cpp:
        (WebCore::PostMessageTimer::PostMessageTimer):
        (WebCore::PostMessageTimer::fired):
        (WebCore::DOMWindow::postMessage):
        * page/DragController.cpp:
        (WebCore::DragController::concludeDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchDragEvent):
        (WebCore::EventHandler::keyEvent):
        (WebCore::EventHandler::handleTextInputEvent):
        * page/Frame.cpp:
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::shouldClose):
        * page/FrameView.cpp:
        (WebCore::FrameView::updateOverflowStatus):
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::currentKeyboardEvent):
        * page/mac/FrameMac.mm:
        * platform/DeprecatedValueListImpl.cpp:
        (WebCore::DeprecatedValueListImpl::Private::Private):
        (WebCore::DeprecatedValueListImpl::DeprecatedValueListImpl):
        (WebCore::DeprecatedValueListImpl::copyOnWrite):
        * platform/graphics/FontSelector.h:
        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage):
        * platform/graphics/GlyphPageTreeNode.h:
        (WebCore::GlyphPage::create):
        (WebCore::GlyphPage::GlyphPage):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):
        (WebCore::RenderLayer::updateOverflowStatus):
        (WebCore::RenderLayer::updateReflectionStyle):
        * rendering/style/RenderStyle.h:
        (WebCore::TransformOperation::~TransformOperation):
        (WebCore::ScaleTransformOperation::create):
        (WebCore::ScaleTransformOperation::ScaleTransformOperation):
        (WebCore::RotateTransformOperation::create):
        (WebCore::RotateTransformOperation::RotateTransformOperation):
        (WebCore::SkewTransformOperation::create):
        (WebCore::SkewTransformOperation::operator==):
        (WebCore::SkewTransformOperation::SkewTransformOperation):
        (WebCore::TranslateTransformOperation::create):
        (WebCore::TranslateTransformOperation::operator==):
        (WebCore::TranslateTransformOperation::TranslateTransformOperation):
        (WebCore::MatrixTransformOperation::create):
        (WebCore::MatrixTransformOperation::MatrixTransformOperation):
        (WebCore::StyleReflection::create):
        (WebCore::StyleReflection::StyleReflection):
        * storage/StorageEvent.cpp:
        (WebCore::StorageEvent::StorageEvent):
        (WebCore::StorageEvent::initStorageEvent):
        * storage/StorageEvent.h:
        (WebCore::StorageEvent::create):
        (WebCore::StorageEvent::StorageEvent):
        * svg/SVGAngle.cpp:
        (WebCore::SVGAngle::SVGAngle):
        * svg/SVGAngle.h:
        (WebCore::SVGAngle::create):
        * svg/SVGAnimatedTemplate.h:
        (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
        (WebCore::lookupOrCreateWrapper):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::sendSVGLoadEventIfPossible):
        * svg/SVGElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::SVGMarkerElement):
        (WebCore::SVGMarkerElement::parseMappedAttribute):
        (WebCore::SVGMarkerElement::setOrientToAngle):
        * svg/SVGMarkerElement.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::createSVGAngle):
        * svg/SVGSVGElement.h:
        * svg/SVGZoomEvent.h:
        (WebCore::SVGZoomEvent::create):
        * svg/graphics/SVGImage.cpp:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):
        (WebCore::XMLHttpRequest::dispatchProgressEvent):
        * xml/XMLHttpRequestProgressEvent.cpp:
        * xml/XMLHttpRequestProgressEvent.h:
        (WebCore::XMLHttpRequestProgressEvent::create):
        (WebCore::XMLHttpRequestProgressEvent::position):
        (WebCore::XMLHttpRequestProgressEvent::totalSize):
        (WebCore::XMLHttpRequestProgressEvent::XMLHttpRequestProgressEvent):

WebKit/mac:

2008-06-14  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * WebView/WebFrame.mm:
        (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 14 Jun 2008 07:52:27 +0000 (07:52 +0000)]
2008-06-14  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19484: More instructions needs to use temporary registers
        <https://bugs.webkit.org/show_bug.cgi?id=19484>

        Make code generation for AddNode and SubNode use temporaries when
        necessary.

        JavaScriptCore:

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::AddNode::emitCode):
        (KJS::SubNode::emitCode):
        * kjs/nodes.h:
        (KJS::AddNode::):
        (KJS::SubNode::):

        LayoutTests:

        * fast/js/codegen-temporaries-expected.txt:
        * fast/js/resources/codegen-temporaries.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Sat, 14 Jun 2008 05:40:24 +0000 (05:40 +0000)]
WebCore:

2008-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=19199

        Prevent external entities from loading across origins.

        Test: http/tests/security/xss-DENIED-xsl-external-entity.xml

        * dom/XMLTokenizer.cpp:
        (WebCore::shouldAllowExternalLoad):
        (WebCore::openFunc):

LayoutTests:

2008-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Test that an XSL style sheet can't include an external entity from
        another origin.

        * http/tests/security/resources/xsl-using-external-entity.xsl: Added.
        * http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
        * http/tests/security/xss-DENIED-xsl-external-entity.xml: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Sat, 14 Jun 2008 05:40:10 +0000 (05:40 +0000)]
WebCore:

2008-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19450

        Allow loads of same-origin documents only.

        Test: http/tests/security/xss-DENIED-xsl-document.xml

        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):

LayoutTests:

2008-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Test that the XSL document() function doesn't load a document from a
        foreign origin.

        * http/tests/security/resources/target.xml: Added.
        * http/tests/security/resources/xsl-using-document.xsl: Added.
        * http/tests/security/xss-DENIED-xsl-document-expected.txt: Added.
        * http/tests/security/xss-DENIED-xsl-document.xml: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Jun 2008 05:39:55 +0000 (05:39 +0000)]
2008-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=15100>:
          XMLHttpRequest::urlMatchesDocumentDomain raises error if port
          information does not match exactly

        Refactor our security check for XMLHttpRequest into SecurityOrigin so
        we can reuse it in other places.  This leverages our default port
        technology in SecurityOrigin.

        I wasn't sure how to write a test for this because the LayoutTests run
        on non-default ports.

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canRequest):
        * platform/SecurityOrigin.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::willSendRequest):
        * xml/XMLHttpRequest.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Jun 2008 05:39:44 +0000 (05:39 +0000)]
2008-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Test whether we permit XMLHttpRequest once document.domain is set.

        * http/tests/xmlhttprequest/document-domain-set-expected.txt: Added.
        * http/tests/xmlhttprequest/document-domain-set.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 14 Jun 2008 05:39:10 +0000 (05:39 +0000)]
2008-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Removed unnecessary dependencies.

        * platform/SecurityOrigin.cpp:
        * platform/SecurityOrigin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 14 Jun 2008 05:06:21 +0000 (05:06 +0000)]
2008-06-13  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Combine TrueNode and FalseNode to make BooleanNode, and remove the
        unused class PlaceholderTrueNode.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::BooleanNode::emitCode):
        * kjs/nodes.h:
        (KJS::BooleanNode::):
        (KJS::BooleanNode::precedence):
        * kjs/nodes2string.cpp:
        (KJS::BooleanNode::streamTo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 14 Jun 2008 04:40:45 +0000 (04:40 +0000)]
2008-06-13  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Eliminate the use of temporaries to store the left hand side of an
        expression when the right hand side is a constant. This slightly
        improves the generated bytecode for a few SunSpider tests, but it is
        mostly in preparation for fixing

        Bug 19484: More instructions needs to use temporary registers
        <https://bugs.webkit.org/show_bug.cgi?id=19484>

        * VM/CodeGenerator.h:
        (KJS::CodeGenerator::leftHandSideNeedsCopy):
        (KJS::CodeGenerator::emitNodeForLeftHandSide):
        * kjs/nodes.cpp:
        (KJS::BracketAccessorNode::emitCode):
        (KJS::ReadModifyResolveNode::emitCode):
        (KJS::AssignDotNode::emitCode):
        (KJS::ReadModifyDotNode::emitCode):
        (KJS::AssignBracketNode::emitCode):
        (KJS::ReadModifyBracketNode::emitCode):
        * kjs/nodes.h:
        (KJS::ExpressionNode::):
        (KJS::FalseNode::):
        (KJS::TrueNode::):
        (KJS::NumberNode::):
        (KJS::StringNode::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 14 Jun 2008 04:12:45 +0000 (04:12 +0000)]
2008-06-13  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - prettify opcode stats output

        I changed things to be a bit more aligned, also there is a new
        section listing most common opcodes and most common sequences that
        include them.

        * VM/Opcode.cpp:
        (KJS::):
        (KJS::OpcodeStats::~OpcodeStats):
        * VM/Opcode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit/gtk:
darin@apple.com [Fri, 13 Jun 2008 23:35:36 +0000 (23:35 +0000)]
WebKit/gtk:

2008-06-13  Darin Adler  <darin@apple.com>

        - try to fix build

        * WebCoreSupport/FrameLoaderClientGtk.h: Add missing argument.

WebKit/qt:

2008-06-13  Darin Adler  <darin@apple.com>

        - try to fix build

        * WebCoreSupport/FrameLoaderClientQt.h: Add missing argument.

WebKit/wx:

2008-06-13  Darin Adler  <darin@apple.com>

        - try to fix build

        * WebKitSupport/FrameLoaderClientWx.h: Add missing argument.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Fri, 13 Jun 2008 22:32:13 +0000 (22:32 +0000)]
2008-06-13  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Add a test for existing loader behaviour in preparation for:

        Bug 19422: Distinct redirects from the same link do not create distinct history items
        <https://bugs.webkit.org/show_bug.cgi?id=19422>

        * http/tests/navigation/redirect-cycle-expected.txt: Added.
        * http/tests/navigation/redirect-cycle.html: Added.
        * http/tests/navigation/resources/redirect-cycle-1.pl: Added.
        * http/tests/navigation/resources/redirect-cycle-2.pl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 13 Jun 2008 22:05:58 +0000 (22:05 +0000)]
2008-06-13  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - enable a bunch of disabled layout tests which now run ok
        https://bugs.webkit.org/show_bug.cgi?id=19540

        I also made a minor change to selftxhtml.js to handle the case
        where the body is a frameset properly, and to frame.xhtml to match
        the HTML version of that file, and what the tests expect.

        * dom/html/level2/html/HTMLFormElement10-expected.txt: Added.
        * dom/html/level2/html/HTMLFormElement10.html: Copied from dom/html/level2/html/HTMLFormElement10.html-disabled.
        * dom/html/level2/html/HTMLFormElement10.html-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFormElement10-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFormElement10.xhtml: Copied from dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement01-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement02-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement03-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement03.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement04-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement04.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement05-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement05.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement06-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement06.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement07-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement07.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement08-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement08.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement09-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameSetElement01-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/HTMLFrameSetElement02-expected.txt: Added.
        * dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled.
        * dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled: Removed.
        * dom/xhtml/level2/html/resources/frame.xhtml:
        * dom/xhtml/level2/html/selfxhtml.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Fri, 13 Jun 2008 21:47:30 +0000 (21:47 +0000)]
WebCore:

2008-06-13  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - added FormState argument to action policy functions

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkNewWindowPolicy):
        (WebCore::FrameLoader::checkNavigationPolicy):
        * loader/FrameLoaderClient.h:
        * svg/graphics/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/gtk:

2008-06-13  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - updated for addition of FormState argument to action policy functions

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKit/mac:

2008-06-13  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - updated for addition of FormState argument to action policy functions
        - added WebActionFormKey

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
        (WebFrameLoaderClient::actionDictionary):
        * WebKit.exp:
        * WebView/WebPolicyDelegate.mm:
        * WebView/WebPolicyDelegatePrivate.h:

WebKit/qt:

2008-06-13  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - updated for addition of FormState argument to action policy functions

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
        (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

WebKit/win:

2008-06-13  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - updated for addition of FormState argument to action policy functions
        - added WebActionFormKey

        * Interfaces/IWebPolicyDelegate.idl:
        * WebActionPropertyBag.cpp:
        (WebActionPropertyBag::WebActionPropertyBag):
        (WebActionPropertyBag::createInstance):
        (WebActionPropertyBag::AddRef):
        (WebActionPropertyBag::Release):
        (WebActionPropertyBag::Read):
        * WebActionPropertyBag.h:
        * WebFrame.cpp:
        (WebFrame::dispatchDecidePolicyForNewWindowAction):
        (WebFrame::dispatchDecidePolicyForNavigationAction):

WebKit/wx:

2008-06-13  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - updated for addition of FormState argument to action policy functions

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction):
        (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 13 Jun 2008 18:23:03 +0000 (18:23 +0000)]
2008-06-13  Darin Adler  <darin@apple.com>

        * Scripts/make-js-test-wrappers: Added three more exceptions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 13 Jun 2008 17:45:05 +0000 (17:45 +0000)]
2008-06-13  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        profiler.
        - Remove recursion from exclude().  This leaves only focus() to fix.

        * JavaScriptCore.exp: Change the signatures of the exported functions.
        * profiler/Profile.cpp:
        (KJS::Profile::forEach): I added a traverseNextNodePreOrder() function
        and so needed to distinguish the other function by labeling it
        traverseNextNodePostOrder().
        (KJS::Profile::exclude): All new exclude that iteratively walks the tree
        * profiler/Profile.h:
        (KJS::Profile::focus): Add a null check for m_head.
        * profiler/ProfileNode.cpp:
        (KJS::ProfileNode::traverseNextNodePostOrder): Renamed
        (KJS::ProfileNode::traverseNextNodePreOrder): Walks the tree in pre-
        order, where the parent is processed before the children.
        (KJS::ProfileNode::setTreeVisible): Iterate over the sub-tree and set
        all of the nodes visible value.  This changes another function that used
        recursion.
        (KJS::ProfileNode::exclude): Remove recursion from this function.
        Because we now check for m_visible and we are walking the tree in pre-
        order we do not need to check if an excluded node is in an excluded
        sub-tree.
        * profiler/ProfileNode.h: Added specific selfTime functions to
        facilitate exclude().
        (KJS::ProfileNode::setSelfTime):
        (KJS::ProfileNode::setActualSelfTime):
        (KJS::ProfileNode::setVisibleSelfTime):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-13 Justin Garcia <justin.garcia@apple.com>
justin.garcia@apple.com [Fri, 13 Jun 2008 17:42:31 +0000 (17:42 +0000)]
2008-06-13  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Jess.

        <rdar://problem/5702248> Crash on Copy Image from the contextual menu on a broken image in Mail

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage): Check to see the image loaded successfully
        before trying to put data for it on the Pasteboard.  Mail shouldn't really
        include the Copy Image menu item, but if it does and the user selects it,
        we shouldn't crash.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-11 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
hausmann@webkit.org [Fri, 13 Jun 2008 12:51:35 +0000 (12:51 +0000)]
2008-06-11  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>
        With help from Siraj Razick  <siraj.razick@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=19367
        [Qt] Plugins are drawn over the scrollbars

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-12 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 13 Jun 2008 04:53:56 +0000 (04:53 +0000)]
2008-06-12  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - https://bugs.webkit.org/show_bug.cgi?id=19434
          speed up SunSpider by avoiding some string boxing

        Speeds up SunSpider by 1.1%.

        Optimized code path for getting built-in properties from strings -- avoid
        boxing with a string object in that case. We can make further changes to avoid
        even more boxing, but this change alone is a win.

        * API/JSCallbackObjectFunctions.h:
        (KJS::JSCallbackObject::staticValueGetter): Use isObject instead of inherits
        in asssert, since the type of slotBase() is now JSValue, not JSObject.
        (KJS::JSCallbackObject::staticFunctionGetter): Ditto.
        (KJS::JSCallbackObject::callbackGetter): Ditto.

        * kjs/internal.cpp:
        (KJS::StringImp::getPrimitiveNumber): Updated for change of data member name.
        (KJS::StringImp::toBoolean): Ditto.
        (KJS::StringImp::toNumber): Ditto.
        (KJS::StringImp::toString): Ditto.
        (KJS::StringInstance::create): Added; avoids a bit of cut and paste code.
        (KJS::StringImp::toObject): Use StringInstance::create.
        (KJS::StringImp::toThisObject): Ditto.
        (KJS::StringImp::lengthGetter): Added. Replaces the getter that used to live in
        the StringInstance class.
        (KJS::StringImp::indexGetter): Ditto.
        (KJS::StringImp::indexNumericPropertyGetter): Ditto.
        (KJS::StringImp::getOwnPropertySlot): Added. Deals with built in properties of
        the string class without creating a StringInstance.

        * kjs/internal.h:
        (KJS::StringImp::getStringPropertySlot): Added. To be used by both the string
        and string object getOwnPropertySlot function.

        * kjs/lookup.h:
        (KJS::staticFunctionGetter): Updated since slotBase() is now a JSValue rather
        than a JSObject.

        * kjs/object.h: Removed PropertySlot::slotBase() function, which can now move
        back into property_slot.h where it belongs since it doesn't have to cast to
        JSObject*.

        * kjs/property_slot.cpp:
        (KJS::PropertySlot::functionGetter): Updated since slot.slotBase() is now a JSValue*
        instead of JSObject*. setGetterSlot still guarantees the base is a JSObject*.
        * kjs/property_slot.h:
        (KJS::PropertySlot::PropertySlot): Changed base to JSValue* intead of JSCell*.
        (KJS::PropertySlot::setStaticEntry): Ditto.
        (KJS::PropertySlot::setCustom): Ditto.
        (KJS::PropertySlot::setCustomIndex): Ditto.
        (KJS::PropertySlot::setCustomNumeric): Ditto.
        (KJS::PropertySlot::slotBase): Moved inline here since it no longer involves a
        downcast to JSObject*.
        (KJS::PropertySlot::setBase): Changed to JSValue*.

        * kjs/string_object.cpp:
        (KJS::StringInstance::getOwnPropertySlot): Changed to use getStringPropertySlot
        instead of coding the properties here. This allows sharing the code with StringImp.

        * kjs/string_object.h: Removed inlineGetOwnPropertySlot, lengthGetter, and indexGetter.
        Made one of the constructors protected.

        * kjs/value.h: Made getOwnPropertySlot private in the JSCell class -- this is better
        since it's not the real JSObject getOwnPropertySlot semantic and most callers shouldn't
        use it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-12 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Fri, 13 Jun 2008 04:19:06 +0000 (04:19 +0000)]
2008-06-12  John Sullivan  <sullivan@apple.com>

        Reviewed by Dan and Darin

        Clear up the confusion about _close (older private method) vs -close (newer public method).

        * WebView/WebView.mm:
        (-[WebView _isClosed]):
        simplified style
        (-[WebView _close]):
        added a comment about how clients and subclasses should use -close instead
        (-[WebView dealloc]):
        call -close instead of _close, so subclasses that override the public method will have the intended behavior
        (-[WebView close]):
        added a comment
        (-[WebView _windowWillClose:]):
        call -close instead of _close, so subclasses that override the public method will have the intended behavior

        * WebView/WebViewPrivate.h:
        added a comment about how clients and subclasses should use -close instead

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-12 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 13 Jun 2008 03:28:35 +0000 (03:28 +0000)]
2008-06-12  Darin Adler  <darin@apple.com>

        - try to fix no-SVG build

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a case for
        CSSPropertyWebkitMask.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-12 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 13 Jun 2008 03:10:54 +0000 (03:10 +0000)]
2008-06-12  Darin Adler  <darin@apple.com>

        - try to fix Windows build

        * dom/Element.idl: Turn off ElementTraversal functions when generating COM.
        Not sure why they're failing, but turning them off for now seems OK.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap@webkit.org [Thu, 12 Jun 2008 14:34:38 +0000 (14:34 +0000)]
    Reviewed by Maciej.

        Preparation to making JavaScript heap per-thread.

        * kjs/collector.cpp:
        (KJS::Collector::collect):
        * kjs/collector.h:
        (KJS::Collector::markListSet):
        The collector now holds the list of protected lists itself, to be made per-instance.

        * kjs/list.h: Changed to hold a pointer to a mark set this list is in, if any.
        (KJS::List::List): Explicitly initialize m_size with zero, as m_vector.size() is
        guaranteed to be such anyway.
        (KJS::List::append): Changed the fast case to only be executed as long as inline buffer
        is used, because otherwise, we now do more expensive checks.

        * kjs/list.cpp:
        (KJS::List::markLists): Renamed from markProtectedListsSlowCase, made it take the list set
        as a parameter.
        (KJS::List::slowAppend): If a non-immediate value is appended, the list needs to be added
        to an appropriate Heap's protected list. For now, a static Collector::markListSet() is
        used, but the code is layed out in preparation to making the switch to multiple heaps.

        * JavaScriptCore.exp: Updated export list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Thu, 12 Jun 2008 10:40:37 +0000 (10:40 +0000)]
WebCore:

2008-06-12  Adam Barth  <abarth@webkit.org>

        Rubberstamped by Maciej.

        Roll 34504 back in.

        Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::toString):

LayoutTests:

2008-06-12  Adam Barth  <abarth@webkit.org>

        Rubberstamped by Maciej.

        Add the data url test back and set more agressive Cache-Control headers.

        * http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt.
        * http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html.
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoContinue backout of 34504.
abarth@webkit.org [Thu, 12 Jun 2008 10:02:10 +0000 (10:02 +0000)]
Continue backout of 34504.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoPartial backout of 34504. I know this will regress the *-data-url.html test, but...
abarth@webkit.org [Thu, 12 Jun 2008 09:35:28 +0000 (09:35 +0000)]
Partial backout of 34504.  I know this will regress the *-data-url.html test, but I'd like to see if it fixes the broken test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 12 Jun 2008 09:03:41 +0000 (09:03 +0000)]
2008-06-12  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 19510: CodeBlock::needsFullScopeChain not always set for global code
        <https://bugs.webkit.org/show_bug.cgi?id=19510>

        This fixes the symptoms by using CodeGenerator::m_codeType to determine
        when to use temporaries instead of CodeBlock::needsFullScopeChain, but
        it does not fix the problem itself.

        JavaScriptCore:

        * VM/CodeGenerator.h:
        (KJS::CodeGenerator::leftHandSideNeedsCopy):

        LayoutTests:

        * fast/js/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
        * fast/js/codegen-temporaries-multiple-global-blocks.html: Added.
        * fast/js/resources/codegen-temporaries-multiple-global-blocks-1.js: Added.
        * fast/js/resources/codegen-temporaries-multiple-global-blocks-2.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 12 Jun 2008 09:00:05 +0000 (09:00 +0000)]
2008-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej.

        Prevent caching of this resource so we always see the up-to-date value
        of the Access-Control-Origin header.

        * http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReverting changes I accidently made in r34507.
mitz@apple.com [Thu, 12 Jun 2008 06:52:14 +0000 (06:52 +0000)]
Reverting changes I accidently made in r34507.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Thu, 12 Jun 2008 06:44:20 +0000 (06:44 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5876370> Safari 3.1.1 bad rendering of pages from http://www.legifrance.gouv.fr/

        Tests: fast/parser/p-in-scope-strict.html
               fast/parser/p-in-scope.html

        * html/HTMLParagraphElement.h:
        (WebCore::HTMLParagraphElement::endTagRequirement): Changed to require
        an end tag. The explicit closing of one P element by another is now
        done in error checking, and therefore takes scope into account, allowing
        for <p><button><p>, for example.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser): Initialize m_hasPElementInScope.
        (WebCore::isScopingTag): Added. Returns whether the given tag represents
        a scoping element as defined in HTML 5 section 8.2.3.2.
        (WebCore::HTMLParser::formCreateErrorCheck): Added a call to
        pCloserCreateErrorCheck().
        (WebCore::HTMLParser::ddCreateErrorCheck): Ditto.
        (WebCore::HTMLParser::dtCreateErrorCheck): Ditto.
        (WebCore::HTMLParser::nestedPCloserCreateErrorCheck): Added for use with
        <li>, which both closes P elements in scope and any previous LI.
        (WebCore::HTMLParser::pCloserCreateErrorCheck): Added. If there is a P
        element in scope, acts as if a </p> tag was seen.
        (WebCore::HTMLParser::pCloserStrictCreateErrorCheck): Ditto, but only
        in strict mode. Used for <table>.
        (WebCore::HTMLParser::getNode): Added entries for tags that close a P
        element in scope.
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Added
        code to reset m_hasPElementInScope.
        (WebCore::HTMLParser::pushBlock): Added code to update
        m_hasPElementInScope.
        (WebCore::HTMLParser::popOneBlockCommon): Ditto.
        (WebCore::HTMLParser::checkIfHasPElementInScope): Added. Updates
        m_hasPElementInScope.

        * html/HTMLParser.h:
        (WebCore::HTMLParser::hasPElementInScope): Added. Calls
        checkIfHasPElementInScope() if needed and returns whether there
        is a P element in scope.

LayoutTests:

        Reviewed by Dave Hyatt.

        - tests, updated tests and updated results for
          <rdar://problem/5876370> Safari 3.1.1 bad rendering of pages from http://www.legifrance.gouv.fr/

        * fast/block/basic/001.html:
        * fast/block/positioning/absolute-in-inline-ltr-2.html:
        * fast/block/positioning/absolute-in-inline-ltr-3.html:
        * fast/block/positioning/absolute-in-inline-ltr.html:
        * fast/block/positioning/absolute-in-inline-rtl-2.html:
        * fast/block/positioning/absolute-in-inline-rtl-3.html:
        * fast/block/positioning/absolute-in-inline-rtl.html:
        * fast/block/positioning/absolute-in-inline-short-ltr.html:
        * fast/block/positioning/absolute-in-inline-short-rtl.html:
        * fast/block/positioning/auto/006.html:
        * fast/inline/continuation-outlines-with-layers.html:
        * fast/inline/continuation-outlines.html:
        * fast/parser/p-in-scope-expected.txt: Added.
        * fast/parser/p-in-scope-strict-expected.txt: Added.
        * fast/parser/p-in-scope-strict.html: Added.
        * fast/parser/p-in-scope.html: Added.
        * fast/parser/resources/p-in-scope.css: Added.
        * fast/parser/resources/p-in-scope.js: Added.
        * fast/repaint/subtree-root-clip-2.html:
        * platform/mac/fast/block/basic/001-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-ltr-2-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-ltr-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-rtl-2-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-rtl-3-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-rtl-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
        * platform/mac/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
        * platform/mac/fast/block/positioning/auto/006-expected.txt:
        * platform/mac/fast/inline/continuation-outlines-expected.txt:
        * platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
        * platform/mac/fast/repaint/subtree-root-clip-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Thu, 12 Jun 2008 06:41:53 +0000 (06:41 +0000)]
WebCore:

008-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=19460

        Update the security context of a document after calling document.open
        or document.write.  Basically, when a script open()s a document, the
        document gains the security context of the script.  Our implementation
        now matches Firefox 3 on all these tests.

        Tests: http/tests/security/aboutBlank/security-context-alias.html
               http/tests/security/aboutBlank/security-context-grandchildren-alias.html
               http/tests/security/aboutBlank/security-context-grandchildren.html
               http/tests/security/aboutBlank/security-context-window-open.html
               http/tests/security/aboutBlank/security-context-with-base-tag.html
               http/tests/security/aboutBlank/security-context-write.html
               http/tests/security/aboutBlank/security-context-writeln.html
               http/tests/security/aboutBlank/security-context.html
               http/tests/security/cookies/document-open.html

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::createWindow):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::open):
        (WebCore::JSHTMLDocument::write):
        (WebCore::JSHTMLDocument::writeln):
        * dom/Document.cpp:
        (WebCore::Document::open):
        (WebCore::Document::write):
        (WebCore::Document::writeln):
        * dom/Document.h:

LayoutTests:

008-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Tests for the security context of about:blank documents.  These test
        results all match Firefox 3.

        * fast/dom/resource-locations-in-created-html-document.html:
        * http/tests/security/aboutBlank/resources/iframe-with-about-blank-children.html: Added.
        * http/tests/security/aboutBlank/security-context-alias-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-alias.html: Added.
        * http/tests/security/aboutBlank/security-context-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-grandchildren-alias-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-grandchildren-alias.html: Added.
        * http/tests/security/aboutBlank/security-context-grandchildren-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-grandchildren.html: Added.
        * http/tests/security/aboutBlank/security-context-window-open-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-window-open.html: Added.
        * http/tests/security/aboutBlank/security-context-with-base-tag-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-with-base-tag.html: Added.
        * http/tests/security/aboutBlank/security-context-write-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-write.html: Added.
        * http/tests/security/aboutBlank/security-context-writeln-expected.txt: Added.
        * http/tests/security/aboutBlank/security-context-writeln.html: Added.
        * http/tests/security/aboutBlank/security-context.html: Added.
        * http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
        * http/tests/security/cookies/document-open-expected.txt: Added.
        * http/tests/security/cookies/document-open.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Thu, 12 Jun 2008 06:41:36 +0000 (06:41 +0000)]
WebCore:

2008-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=19460

        Compute the cookie context at the same time as the SecurityOrigin.

        Tests: http/tests/security/cookies/create-document.html
               http/tests/security/cookies/xmlhttprequest.html

        * dom/Document.cpp:
        (WebCore::Document::cookie):
        (WebCore::Document::initSecurityOrigin):
        * dom/Document.h:
        * platform/SecurityOrigin.cpp:
        * platform/SecurityOrigin.h:

LayoutTests:

2008-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=19460

        Test esoteric cookie contexts.

        * http/tests/security/cookies/create-document-expected.txt: Added.
        * http/tests/security/cookies/create-document.html: Added.
        * http/tests/security/cookies/resources/simple.xml: Added.
        * http/tests/security/cookies/xmlhttprequest-expected.txt: Added.
        * http/tests/security/cookies/xmlhttprequest.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Thu, 12 Jun 2008 05:15:27 +0000 (05:15 +0000)]
WebCore:

2008-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed and tweaked by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19242
        Data URLs should set an Access-Control-Origin of "null"

        Correctly generate "null" as the value of the Access-Control-Origin
        header for cross-site XMLHttpRequests for data URLs.

        Test: http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::toString):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::accessControlOrigin):
        (WebCore::XMLHttpRequest::crossSiteAccessRequest):
        (WebCore::XMLHttpRequest::handleAsynchronousMethodCheckResult):
        * xml/XMLHttpRequest.h:

LayoutTests:

2008-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed and tweaked by Sam Weinig.

        Test for https://bugs.webkit.org/show_bug.cgi?id=19242
        Data URLs should set an Access-Control-Origin of "null"

        Test that we correctly generate "null" as the value for the
        Access-Control-Origin header when making requests from a data URL.

        * http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-access-control-origin-header-data-url.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd missing newline
weinig@apple.com [Thu, 12 Jun 2008 02:51:47 +0000 (02:51 +0000)]
Add missing newline

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 12 Jun 2008 02:26:28 +0000 (02:26 +0000)]
2008-06-11  Sam Weinig  <sam@webkit.org>

        Update results on non-leopard platforms to fix the buildbot.

        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSet executable bit
weinig@apple.com [Thu, 12 Jun 2008 02:19:27 +0000 (02:19 +0000)]
Set executable bit

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 12 Jun 2008 00:33:48 +0000 (00:33 +0000)]
2008-06-11  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 19498: REGRESSION (r34497): crash while loading GMail
        <https://bugs.webkit.org/show_bug.cgi?id=19498>

        JavaScriptCore:

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJumpIfTrueOptimized):
        (KJS::CodeGenerator::emitJumpIfTrue):
        * VM/CodeGenerator.h:
        * kjs/nodes.cpp:
        (KJS::DoWhileNode::emitCode):
        (KJS::WhileNode::emitCode):
        (KJS::ForNode::emitCode):
        (KJS::CaseBlockNode::emitCodeForBlock):

        LayoutTests:

        * fast/js/logical-or-jless-expected.txt: Added.
        * fast/js/logical-or-jless.html: Added.
        * fast/js/resources/logical-or-jless.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-11 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 11 Jun 2008 22:01:40 +0000 (22:01 +0000)]
2008-06-11  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - a little bit of cleanup and prep for some upcoming optimizations

        * JavaScriptCore.exp: Re-sorted this file (with sort command line tool).
        * VM/CodeBlock.cpp:
        (KJS::CodeBlock::dump): Fixed printf to avoid warnings -- to use %lu we
        need to make sure the type is unsigned long.
        * kjs/object.cpp:
        (KJS::Error::create): Eliminated unused error names array, and also put
        the strings into the code since there was already a switch statment.
        This also avoids having to contemplate a hypothetical access past the
        end of the array.
        * kjs/object.h: Got rid of errorNames.
        * kjs/property_slot.cpp: Deleted unused ungettableGetter.
        * kjs/property_slot.h: Ditto.
        * wtf/AlwaysInline.h: Added LIKELY alongside UNLIKELY.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Wed, 11 Jun 2008 19:55:07 +0000 (19:55 +0000)]
WebCore:

2008-06-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Add support for "*" wildcarding for Access-Control.

        Test: http/tests/xmlhttprequest/access-control-basic-allow-star.html

        * xml/AccessItem.cpp:
        (WebCore::AccessItem::AccessItem):
        (WebCore::AccessItem::parseAccessItem):
        (WebCore::AccessItem::matches):

LayoutTests:

2008-06-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Add basic test for "*" wildcarding for Access-Control.

        * http/tests/xmlhttprequest/access-control-basic-allow-star-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-basic-allow-star.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 11 Jun 2008 19:48:15 +0000 (19:48 +0000)]
2008-06-11  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19457: Create fused opcodes for tests and conditional jumps
        <https://bugs.webkit.org/show_bug.cgi?id=19457>

        Add a new jless instruction, and modify the code generator to emit it
        instead of the pair (less, jtrue).

        Gives a 3.6% improvement on SunSpider.

        * VM/CodeBlock.cpp:
        (KJS::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator):
        (KJS::CodeGenerator::emitOpcode):
        (KJS::CodeGenerator::retrieveLastBinaryOp):
        (KJS::CodeGenerator::rewindBinaryOp):
        (KJS::CodeGenerator::emitJump):
        (KJS::CodeGenerator::emitJumpIfTrue):
        (KJS::CodeGenerator::emitJumpIfFalse):
        (KJS::CodeGenerator::emitMove):
        (KJS::CodeGenerator::emitNot):
        (KJS::CodeGenerator::emitEqual):
        (KJS::CodeGenerator::emitNotEqual):
        (KJS::CodeGenerator::emitStrictEqual):
        (KJS::CodeGenerator::emitNotStrictEqual):
        (KJS::CodeGenerator::emitLess):
        (KJS::CodeGenerator::emitLessEq):
        (KJS::CodeGenerator::emitPreInc):
        (KJS::CodeGenerator::emitPreDec):
        (KJS::CodeGenerator::emitPostInc):
        (KJS::CodeGenerator::emitPostDec):
        (KJS::CodeGenerator::emitToJSNumber):
        (KJS::CodeGenerator::emitNegate):
        (KJS::CodeGenerator::emitAdd):
        (KJS::CodeGenerator::emitMul):
        (KJS::CodeGenerator::emitDiv):
        (KJS::CodeGenerator::emitMod):
        (KJS::CodeGenerator::emitSub):
        (KJS::CodeGenerator::emitLeftShift):
        (KJS::CodeGenerator::emitRightShift):
        (KJS::CodeGenerator::emitUnsignedRightShift):
        (KJS::CodeGenerator::emitBitAnd):
        (KJS::CodeGenerator::emitBitXOr):
        (KJS::CodeGenerator::emitBitOr):
        (KJS::CodeGenerator::emitBitNot):
        (KJS::CodeGenerator::emitInstanceOf):
        (KJS::CodeGenerator::emitTypeOf):
        (KJS::CodeGenerator::emitIn):
        (KJS::CodeGenerator::emitLoad):
        (KJS::CodeGenerator::emitNewObject):
        (KJS::CodeGenerator::emitNewArray):
        (KJS::CodeGenerator::emitResolve):
        (KJS::CodeGenerator::emitGetScopedVar):
        (KJS::CodeGenerator::emitPutScopedVar):
        (KJS::CodeGenerator::emitResolveBase):
        (KJS::CodeGenerator::emitResolveWithBase):
        (KJS::CodeGenerator::emitResolveFunction):
        (KJS::CodeGenerator::emitGetById):
        (KJS::CodeGenerator::emitPutById):
        (KJS::CodeGenerator::emitPutGetter):
        (KJS::CodeGenerator::emitPutSetter):
        (KJS::CodeGenerator::emitDeleteById):
        (KJS::CodeGenerator::emitGetByVal):
        (KJS::CodeGenerator::emitPutByVal):
        (KJS::CodeGenerator::emitDeleteByVal):
        (KJS::CodeGenerator::emitPutByIndex):
        (KJS::CodeGenerator::emitNewFunction):
        (KJS::CodeGenerator::emitNewRegExp):
        (KJS::CodeGenerator::emitNewFunctionExpression):
        (KJS::CodeGenerator::emitCall):
        (KJS::CodeGenerator::emitReturn):
        (KJS::CodeGenerator::emitEnd):
        (KJS::CodeGenerator::emitConstruct):
        (KJS::CodeGenerator::emitPushScope):
        (KJS::CodeGenerator::emitPopScope):
        (KJS::CodeGenerator::emitDebugHook):
        (KJS::CodeGenerator::emitComplexJumpScopes):
        (KJS::CodeGenerator::emitJumpScopes):
        (KJS::CodeGenerator::emitNextPropertyName):
        (KJS::CodeGenerator::emitGetPropertyNames):
        (KJS::CodeGenerator::emitCatch):
        (KJS::CodeGenerator::emitThrow):
        (KJS::CodeGenerator::emitNewError):
        (KJS::CodeGenerator::emitJumpSubroutine):
        (KJS::CodeGenerator::emitSubroutineReturn):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Opcode.cpp:
        (KJS::):
        * VM/Opcode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-11 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 11 Jun 2008 19:37:44 +0000 (19:37 +0000)]
2008-06-11  Darin Adler  <darin@apple.com>

        Reviewed by Alexey.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19442
          JavaScript array implementation doesn't maintain m_numValuesInVector when sorting

        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::checkConsistency): Added. Empty inline version for when
        consistency checks are turned off.
        (KJS::ArrayInstance::ArrayInstance): Check consistency after construction.
        (KJS::ArrayInstance::~ArrayInstance): Check consistency before destruction.
        (KJS::ArrayInstance::put): Check consistency before and after.
        (KJS::ArrayInstance::deleteProperty): Ditto.
        (KJS::ArrayInstance::setLength): Ditto.
        (KJS::compareByStringPairForQSort): Use typedef for clarity.
        (KJS::ArrayInstance::sort): Check consistency before and after. Also broke the loop
        to set up sorting into two separate passes. Added FIXMEs about various exception
        safety issues. Added code to set m_numValuesInVector after sorting.
        (KJS::ArrayInstance::compactForSorting): Ditto.

        * kjs/array_instance.h: Added a definition of an enum for the types of consistency
        check and a declaration of the consistency checking function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Wed, 11 Jun 2008 18:30:22 +0000 (18:30 +0000)]
WebCore:

2008-06-11  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19455>
        Crash at RenderObject::childAt during JustifyCenter

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Added a FIXME.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): If we're removing a line
        break that consists of a single '\n' in a text node by itself, remove
        the whole text node instead of just emptying it out.
        * editing/Selection.cpp:
        (WebCore::Selection::validate): Added a FIXME about canonicalizing
        to positions that aren't candidates.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved): When the base and/or
        extent are about to be removed but the start and end aren't, change the
        base and extent to the start and end, but don't re-validate the selection,
        since doing so could move the start and end into the node that is about
        to be removed.

LayoutTests:

2008-06-11  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19455>
        Crash at RenderObject::childAt during JustifyCenter

        * editing/execCommand/19455-expected.txt: Added.
        * editing/execCommand/19455.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMark...
cfleizach@apple.com [Wed, 11 Jun 2008 18:27:44 +0000 (18:27 +0000)]
<rdar://problem/5990049> AXTextMarker bytes getting messed up when getting AXTextMarkerRangeForUnorderedTextMarkersParameterizedAttribute

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-11 Adriaan de Groot <groot@kde.org>
hausmann@webkit.org [Wed, 11 Jun 2008 15:19:55 +0000 (15:19 +0000)]
2008-06-11  Adriaan de Groot  <groot@kde.org>

        Reviewed by Simon.

        Fix compilation with Sun Studio 12

        It seems like the compiler instantiates a different template version. I.e.,
        instead of parseUASheet<char [nnnn]>, it's probably instantiating
        parseUASheet<char *>, which then passes 4 or 8 as the size value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 11 Jun 2008 15:10:29 +0000 (15:10 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Fixed a crash when a slot connect to QWebPage::unsupportedContent would show a
modal dialog with an event loop.

We have a queued connection to various signals in the QNetworkReply, for which
it can happen that after releasing the QNetworkReply and disconnecting from it
a slot connected to one of the signals may still be called due to a posted
MetaCall event due to the queued connections. This patch removes the posted
events explicitly, fixes the coding style a bit and makes sure the same happens
when abort() is called.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 11 Jun 2008 15:10:08 +0000 (15:10 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix left-click and middle-click mouse event are not properly accepted.

When copying or pasting text using left or middle-click, the event must be
accepted so that it will not be potentially processed further by the parent
and/or sub-classed widget.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAriya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 11 Jun 2008 14:56:52 +0000 (14:56 +0000)]
Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix input element does not accept character typed in using AltGr.

EditorClient is modified to catch AltGr and Ctrl+Alt key combination.
This fixes http://trolltech.com/developer/task-tracker/index_html?id=207050&method=entry

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.
kevino@webkit.org [Wed, 11 Jun 2008 05:51:50 +0000 (05:51 +0000)]
wx Linux build fix. Only use -undefined dynamic_lookup flag under Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears...
kevino@webkit.org [Wed, 11 Jun 2008 05:18:49 +0000 (05:18 +0000)]
wx build fix. Reorder include dirs so that WebCore/html/HTMLElementFactory.h appears before WebCore/DerivedSources/HTMLElementFactory.h. (See note in commit for more details. This is probably not the right fix, but this will get us buildinguntil the right fix is in place.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agowx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.
kevino@webkit.org [Wed, 11 Jun 2008 05:16:17 +0000 (05:16 +0000)]
wx build fix. Link against libedit on Mac since HAVE(READLINE) is defined there.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix the text encoding in this test
mitz@apple.com [Tue, 10 Jun 2008 21:31:37 +0000 (21:31 +0000)]
    - fix the text encoding in this test

        * editing/selection/move-left-right.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by mjs.
eric@webkit.org [Tue, 10 Jun 2008 21:06:54 +0000 (21:06 +0000)]
    Reviewed by mjs.

        Fix disconnected event listener crasher
        m_disconnectedNodesWithEventListeners not updated when nodes adopted
        https://bugs.webkit.org/show_bug.cgi?id=19451

        I failed to find a way to make this crash DRT, I can crash Debug Safari consistently.

        * dom/EventTarget.cpp:
        (WebCore::EventTarget::willMoveToNewOwnerDocument):
        (WebCore::EventTarget::didMoveToNewOwnerDocument):
        * dom/EventTarget.h:
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::willMoveToNewOwnerDocument):
        (WebCore::EventTargetNode::didMoveToNewOwnerDocument):
        * dom/EventTargetNode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
jchaffraix@webkit.org [Tue, 10 Jun 2008 20:49:27 +0000 (20:49 +0000)]
WebCore:

2008-06-10  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        Move more parameters to the XML files.

        * dom/make_names.pl:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * svg/svgattrs.in:
        * svg/svgtags.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 10 Jun 2008 16:56:15 +0000 (16:56 +0000)]
2008-06-10  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed.

        - tweak newly added markup.

        * blog/wp-content/themes/webkit/header.php:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-10 Joerg Bornemann <joerg.bornemann@trolltech.com>
hausmann@webkit.org [Tue, 10 Jun 2008 16:54:17 +0000 (16:54 +0000)]
2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>

        Reviewed by Simon.

        For the qmake based build make it possible to build against makespecs where
        QMAKE_CC is defined in a configuration file included from qmake.conf.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-05-26 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>
hausmann@webkit.org [Tue, 10 Jun 2008 16:47:27 +0000 (16:47 +0000)]
2008-05-26  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=19323

        Implemented the QWebPage::editable property.

        Small documentation fixes by Simon.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Tue, 10 Jun 2008 14:54:39 +0000 (14:54 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=16503
        match limit takes at least 13% of the time on the SunSpider regexp-dna test

        Make the limit test slightly more efficient. It is not clear how much of a win it is,
        as the improvement on regexp-dna varies from 2.3% to 0.6% depending on what revision I
        apply the patch to. Today, the win on regexp-dna was minimal, but the total win was whopping
        0.5%, due to random code generation changes.

        * pcre/pcre_exec.cpp: (match): Avoid loading a constant on each iteration.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-10 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 10 Jun 2008 14:22:10 +0000 (14:22 +0000)]
2008-06-10  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Adele.

        - add short title and multisize icon

        * blog/wp-content/themes/webkit/header.php:
        * images/surfin-safari.icns: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 10 Jun 2008 08:58:00 +0000 (08:58 +0000)]
2008-06-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Make sure web action in context menus have the right enablement,
        while not messing up other web actions not included in the menu.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoApply GTK coding style to WebKit Gtk public headers
christian@webkit.org [Tue, 10 Jun 2008 07:48:46 +0000 (07:48 +0000)]
Apply GTK coding style to WebKit Gtk public headers

https://bugs.webkit.org/show_bug.cgi?id=16676

Reviewed by Alp Toker and Darin Adler.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-09 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 10 Jun 2008 05:42:48 +0000 (05:42 +0000)]
2008-06-09  Alp Toker  <alp@nuanti.com>

        gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
        each of the tools since these are no longer set globally.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Tue, 10 Jun 2008 04:58:09 +0000 (04:58 +0000)]
WebCore:

        Reviewed by Justin Garcia.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19443
          <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character

        Tests added to editing/selection/move-left-right.html

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): When falling
        back from visual to logical movement, restart at the original position
        rather than an intermediate position.
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.

LayoutTests:

        Reviewed by Justin Garcia.

        - update test for https://bugs.webkit.org/show_bug.cgi?id=19443
          <rdar://problem/5994544> REGRESSION (r32531-r32652): Moving the insertion point past a newline inserted in a text area skips the next character

        * editing/selection/move-left-right-expected.txt:
        * editing/selection/move-left-right.html:
        * platform/mac/editing/selection/move-left-right-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-07 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Mon, 9 Jun 2008 22:54:50 +0000 (22:54 +0000)]
2008-06-07  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Maciej.

        Windows build fix.

        * platform/graphics/win/QTMovieWin.cpp:
        (initializeSupportedTypes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 21:02:23 +0000 (21:02 +0000)]
2008-06-09  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Sam.

        Add an include for readline/history.h to fix the build for Darwin users
        with the GNU readline library installed. Also, clean up the style of
        the HAVE(READLINE) check.

        * kjs/testkjs.cpp:
        (runInteractive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 17:10:27 +0000 (17:10 +0000)]
2008-06-09  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 17531: Add interactive mode to testkjs
        <https://bugs.webkit.org/show_bug.cgi?id=17531>

        This is a cleaned up version of Sam's earlier patch to add an
        interactive mode to testkjs.

        Readline support is only enabled on Darwin platforms for now, but
        other ports can enable it by defining HAVE_READLINE in kjs/config.h.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/config.h:
        * kjs/testkjs.cpp:
        (Options::Options):
        (runWithScripts):
        (runInteractive):
        (printUsageStatement):
        (parseArguments):
        (kjsmain):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-09 Benjamin C Meyer <ben@meyerhome.net>
hausmann@webkit.org [Mon, 9 Jun 2008 14:58:10 +0000 (14:58 +0000)]
2008-06-09  Benjamin C Meyer  <ben@meyerhome.net>

        Reviewed by Simon

       Add Shift-Space shortcut to go up one screen, the opposite of Space
       which goes down one screen.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 9 Jun 2008 12:55:31 +0000 (12:55 +0000)]
2008-06-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Use the text color from QStyle when styling form elements.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
jchaffraix@webkit.org [Mon, 9 Jun 2008 10:59:57 +0000 (10:59 +0000)]
WebCore:

2008-06-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Added a parameters hash that will hold the parameters we used to give in the
        command line.

        - Added "tags" / "attrs" XML tag parsing to fill the parameters hash.

        - Moved namespace, namespaceURI, namespacePrefix and cppNamespace in the *.in
        files.

        * dom/make_names.pl:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * svg/svgattrs.in:
        * svg/svgtags.in:
        * svg/xlinkattrs.in:
        * xml/xmlattrs.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-09 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 9 Jun 2008 07:56:07 +0000 (07:56 +0000)]
2008-06-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Darin.

        Incorporated Darin's comments to bug 18965.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBackout 34464. The build bot didn't like the new tests.
abarth@webkit.org [Mon, 9 Jun 2008 07:30:57 +0000 (07:30 +0000)]
Backout 34464.  The build bot didn't like the new tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 9 Jun 2008 06:26:30 +0000 (06:26 +0000)]
2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Alder.

        https://bugs.webkit.org/show_bug.cgi?id=16631

        Improve coverage of our frame navigation test cases.  This revealed a
        bug in plugin navigation (we aren't setting the opener properly), but
        that's probably better addressed in a separate patch.

        * http/tests/security/frameNavigation/navigation-ALLOWED-child-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-child.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-descendant-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-descendant.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-not-opener-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-not-opener.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-opener-child-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-opener-child.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-popup-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-popup.html: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-ALLOWED-sibling-same-parent.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-form-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-form.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-hyperlink.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-location-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-location.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-open-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-open.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-popup-child-plugin.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-form-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-form.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-hyperlink.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-location-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-location.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-open-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-open.html: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin-expected.txt: Added.
        * http/tests/security/frameNavigation/navigation-DENIED-sibling-plugin.html: Added.
        * http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Removed.
        * http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Removed.
        * http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Removed.
        * http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Removed.
        * http/tests/security/frameNavigation/resources/iframe.html: Added.
        * http/tests/security/frameNavigation/resources/lib.js: Added.
        * http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Removed.
        * http/tests/security/frameNavigation/resources/navigation-happened.html: Removed.
        * http/tests/security/frameNavigation/resources/open.html: Added.
        * http/tests/security/frameNavigation/resources/ready.html: Added.
        * http/tests/security/frameNavigation/resources/target.html: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Removed.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Removed.
        * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 9 Jun 2008 06:26:09 +0000 (06:26 +0000)]
2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=16856

        Fix tests not to rely on broken javascript URL behavior.

        * fast/events/event-listener-html-non-html-confusion.html:
        * fast/replaced/image-map-bug16782-expected.txt: Added.
        * fast/replaced/image-map-bug16782.html: Added.
        * fast/replaced/image-map.html:
        * svg/custom/prevent-default.svg:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 05:20:32 +0000 (05:20 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 17931: Incorrect decompilation with |new|
        <https://bugs.webkit.org/show_bug.cgi?id=17931>

        This bug was fixed by SquirrelFish, but we should add a test.

        * fast/js/function-toString-parentheses-expected.txt:
        * fast/js/resources/function-toString-parentheses.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 04:47:05 +0000 (04:47 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 17932: "ASSERTION FAILED: type != Continue" with do/while and try/finally
        <https://bugs.webkit.org/show_bug.cgi?id=17932>

        This bug was fixed by SquirrelFish, but we should add a test, as well
        as tests for related issues found while developing SquirrelFish.

        * fast/js/continue-break-multiple-labels-expected.txt:
        * fast/js/continue-break-multiple-labels.html:
        * fast/js/resources/continue-break-multiple-labels.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
abarth@webkit.org [Mon, 9 Jun 2008 04:37:49 +0000 (04:37 +0000)]
WebCore:

2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Inherit document.URL from parent's document.URL, not document.baseURI.

        https://bugs.webkit.org/show_bug.cgi?id=19257

        Tests: http/tests/security/cookies/assign-document-url.html
               http/tests/security/cookies/base-about-blank.html
               http/tests/security/cookies/base-tag.html
               http/tests/security/cookies/basic.html

        * dom/Document.cpp:
        (WebCore::Document::open):

LayoutTests:

2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Alder.

        Add a number of tests for document.cookie access.

        https://bugs.webkit.org/show_bug.cgi?id=19257

        * http/tests/security/cookies: Added.
        * http/tests/security/cookies/assign-document-url-expected.txt: Added.
        * http/tests/security/cookies/assign-document-url.html: Added.
        * http/tests/security/cookies/base-about-blank-expected.txt: Added.
        * http/tests/security/cookies/base-about-blank.html: Added.
        * http/tests/security/cookies/base-tag-expected.txt: Added.
        * http/tests/security/cookies/base-tag.html: Added.
        * http/tests/security/cookies/basic-expected.txt: Added.
        * http/tests/security/cookies/basic.html: Added.
        * http/tests/security/cookies/resources: Added.
        * http/tests/security/cookies/resources/set-a-cookie.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Darin Adler.
kevino@webkit.org [Mon, 9 Jun 2008 03:39:46 +0000 (03:39 +0000)]
Reviewed by Darin Adler.

Fix font asserts in wx port. Our computeHash function should generate the same hash for two identical fonts which are different objects, which it wasn't doing before.

https://bugs.webkit.org/show_bug.cgi?id=19310

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 9 Jun 2008 02:12:21 +0000 (02:12 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

        Test: fast/multicol/content-height-zero-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutColumns): Changed to not keep creating
        overflow columns that have zero height, because they do not help with
        fitting content in.

LayoutTests:

        - test for <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

        Reviewed by Darin Adler.

        * fast/multicol/content-height-zero-crash-expected.txt: Added.
        * fast/multicol/content-height-zero-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 00:57:28 +0000 (00:57 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19346: REGRESSION: Mootools 1.2 Class inheritance broken in post-SquirrelFish merge
        <https://bugs.webkit.org/show_bug.cgi?id=19346>

        A check for whether a function's caller is eval code accidentally included
        the case where the caller's caller is native code. Add a CodeType field to
        CodeBlock and use this for the eval caller test instead.

        JavaScriptCore:

        * VM/CodeBlock.h:
        (KJS::CodeBlock::CodeBlock):
        (KJS::ProgramCodeBlock::ProgramCodeBlock):
        (KJS::EvalCodeBlock::EvalCodeBlock):
        * VM/Machine.cpp:
        (KJS::getCallerFunctionOffset):
        * kjs/nodes.cpp:
        (KJS::FunctionBodyNode::generateCode):
        (KJS::ProgramNode::generateCode):

        LayoutTests:

        * fast/js/function-dot-arguments-and-caller-expected.txt:
        * fast/js/function-dot-arguments-and-caller.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Bug 18837: Database panel fails to display tables if any value is NULL
aroben@apple.com [Sun, 8 Jun 2008 20:57:48 +0000 (20:57 +0000)]
    Fix Bug 18837: Database panel fails to display tables if any value is NULL

        <https://bugs.webkit.org/show_bug.cgi?id=18837>

        Reviewed by Darin Adler.

        Test: manual-tests/inspector/display-sql-null.html

        * manual-tests/inspector/display-sql-null.html: Added.
        * page/inspector/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all
        objects to strings before operating on them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Bug 19438: Transaction errors are never displayed in database query view
aroben@apple.com [Sun, 8 Jun 2008 20:57:11 +0000 (20:57 +0000)]
    Fix Bug 19438: Transaction errors are never displayed in database query view

        <https://bugs.webkit.org/show_bug.cgi?id=19438>

        Reviewed by Darin Adler.

        Test: manual-tests/inspector/display-sql-transaction-error.html

        * manual-tests/inspector/display-sql-transaction-error.html: Added.
        * page/inspector/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): Use
        _executeSqlError as the error callback for executeSql.
        (WebInspector.DatabaseQueryView.prototype._queryError): Changed to
        only take two parameters. This matches what we'll be passed if
        db.transaction fails.
        (WebInspector.DatabaseQueryView.prototype._executeSqlError): Added.
        Calls through to _queryError.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Dirk Schulze <vbs85@gmx.de>
darin@apple.com [Sun, 8 Jun 2008 20:36:24 +0000 (20:36 +0000)]
2008-06-08  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18840
        [CAIRO] Clipping-support for SVG

        Support for clipping in SVG/Cairo and fixes transformation of paths.

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::transform):
        * svg/graphics/cairo/SVGResourceClipperCairo.cpp:
        (WebCore::SVGResourceClipper::applyClip):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Dirk Schulze <vbs85@gmx.de>
darin@apple.com [Sun, 8 Jun 2008 20:33:27 +0000 (20:33 +0000)]
2008-06-08  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18663
        Add text-stroke support to Cairo.

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 20:30:50 +0000 (20:30 +0000)]
WebCore:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=16489
        WebKit does not support ElementTraversal specification

        Tests: fast/dom/Element/element-traversal.html

        * dom/Element.cpp:
        (WebCore::Element::firstElementChild):
        (WebCore::Element::lastElementChild):
        (WebCore::Element::previousElementSibling):
        (WebCore::Element::nextElementSibling):
        (WebCore::Element::childElementCount):
        * dom/Element.h:
        * dom/Element.idl:

LayoutTests:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        test cases for https://bugs.webkit.org/show_bug.cgi?id=16489
        WebKit does not support ElementTraversal specification

        * fast/dom/Element/element-traversal-expected.txt: Added.
        * fast/dom/Element/element-traversal.html: Added.
        * fast/dom/Element/resources/element-traversal.js: Added.

        * fast/dom/domListEnumeration-expected.txt: Updated since Element now has 5
        new properties. It would be good to rewrite this test so it doesn't have to
        be updated every time we add a property to Node or Element.
        * fast/dom/resources/domListEnumeration.js: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 20:01:19 +0000 (20:01 +0000)]
WebCore:

2008-06-08  Bradley Meck  <genisis329@gmail.com>

        Reviewed by Darin.

        - fix https://bugs.webkit.org/show_bug.cgi?id=17051
          safari should treat "url()" as a valid CSS value

        Test: fast/css/invalid-cursor-property-crash.html

        Changed check for empty url() to be a check for null since url() is valid
        CSS even if it is empty.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseBorderImage):

LayoutTests:

2008-06-08  Bradley Meck  <genisis329@gmail.com>

        Reviewed and tweaked by Darin.

        - test for https://bugs.webkit.org/show_bug.cgi?id=17051
          safari should treat "url()" as a valid CSS value

        We should really add some more tests for this. One text-only test each for the
        four different sites that handle URLs (cursor image, list style image, fill image,
        border image) that were fixed. Currently this covers only the cursor image.

        * fast/css/invalid-cursor-property-crash.html: Updated test to expect the
        url() to be expanded into the URL of the document itself. The text of the test
        is now a bit misleading, but it still tests that it's not a crash, and now it
        also doubles as a check that url() is handled properly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:41:25 +0000 (19:41 +0000)]
WebCore:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        Bug 18041: DOMNodeRemoved events are sent twice

        Test: fast/dom/Node/DOMNodeRemovedEvent.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChild):

LayoutTests:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        Test case for
        Bug 18041: DOMNodeRemoved events are sent twice

        * fast/dom/Node/DOMNodeRemovedEvent-expected.txt: Added.
        * fast/dom/Node/DOMNodeRemovedEvent.html: Added.
        * fast/dom/Node/resources/DOMNodeRemovedEvent.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:31:59 +0000 (19:31 +0000)]
WebCore:

2008-06-08  Tony Chang  <idealisms@gmail.com>

        Reviewed by Eric Seidel.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18167
          there should be no text-drag delay on any platform except for Mac

        Move the drag text delay value into the platform specific files.

        Test: editing/selection/drag-text-delay.html

        * page/EventHandler.cpp:
        * page/EventHandler.h:
        * page/gtk/EventHandlerGtk.cpp:
        * page/mac/EventHandlerMac.mm:
        * page/qt/EventHandlerQt.cpp:
        * page/win/EventHandlerWin.cpp:
        * page/wx/EventHandlerWx.cpp:

LayoutTests:

2008-06-08  Tony Chang  <idealisms@gmail.com>

        Reviewed by Eric Seidel.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18167
          there should be no text-drag delay on any platform except for Mac

        Also updated two tests which depend on the drag text delay to be greater
        than 0 by making them no longer select text before the mouse down.

        * editing/selection/drag-text-delay-expected.txt: Added.
        * editing/selection/drag-text-delay.html: Added.
        * platform/mac/editing/selection/drag-text-delay-expected.txt: Added.

        * fast/events/autoscroll.html:
        * fast/forms/input-readonly-autoscroll.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:21:35 +0000 (19:21 +0000)]
WebCore:

2008-06-08  Rob Buis  <buis@kde.org>

        Reviewed by Darin.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18512
          getPresentationAttribute returns a shared object

        Test: svg/custom/getPresentationAttribute-modify.svg

        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::getPresentationAttribute): Unshare the mapped style
        declaration if it is shared before returning the presentation attribute.

LayoutTests:

2008-06-08  Rob Buis  <buis@kde.org>

        Reviewed by Darin.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18512
          getPresentationAttribute returns a shared object

        * svg/custom/getPresentationAttribute-modify-expected.txt: Added.
        * svg/custom/getPresentationAttribute-modify.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Eric Roman <minatoar@gmail.com>
darin@apple.com [Sun, 8 Jun 2008 19:08:53 +0000 (19:08 +0000)]
2008-06-08  Eric Roman  <minatoar@gmail.com>

        Reviewed by Adam Roben.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18550
          cross-frame-access-call.html doesn't really test window.open(), since popups are blocked

        * http/tests/security/cross-frame-access-call.html: Enable popups for this layout test.
        The test checks that window.open is returns undefined (same-domain enforcement), however
        unless popups are enabled it returns undefined regardless.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 8 Jun 2008 19:04:23 +0000 (19:04 +0000)]
2008-06-08  Alp Toker  <alp@nuanti.com>

        autotools/GTK+ build system cleanup. Don't include WebKit API in the
        WebCore build as it's no longer needed since r34426.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Jonathan Haas <myrdred@gmail.com>
darin@apple.com [Sun, 8 Jun 2008 18:39:44 +0000 (18:39 +0000)]
2008-06-08  Jonathan Haas <myrdred@gmail.com>

        Reviewed by Eric Seidel.
        Tweaked by Darin while landing to make it compile.

        - fix http://bugs.webkit.org/show_bug.cgi?id=19128
          SVG fonts don't work with medial Arabic characters

        Haven't figured out a way to make an automated test for this.

        * svg/SVGGlyphElement.h: Made arabicForm unsigned so it fits into
        its 3-bit field. Did the same for orientation's 2-bit field.

        * svg/SVGFont.cpp: Did a bit of minor tweaking.
        (WebCore::isCompatibleArabicForm): Added a cast to avoid a warning
        since the type is now different.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Eric Carlson <eric.carlson@apple.com>
darin@apple.com [Sun, 8 Jun 2008 18:22:45 +0000 (18:22 +0000)]
2008-06-08  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19299
          <rdar://problem/5969392>

        Generate the media MIME type list dynamically.

        * platform/graphics/win/QTMovieWin.cpp:
        (initializeSupportedTypes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Christian Persch <chpe@gnome.org>
darin@apple.com [Sun, 8 Jun 2008 18:16:38 +0000 (18:16 +0000)]
2008-06-08  Christian Persch  <chpe@gnome.org>

        Reviewed by Darin.

        - https://bugs.webkit.org/show_bug.cgi?id=19309
          uninitialised variable in PluginView

        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView): Initialise the NPP's pdata member to 0.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 8 Jun 2008 18:07:11 +0000 (18:07 +0000)]
2008-06-08  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - https://bugs.webkit.org/show_bug.cgi?id=19435
          fix warning in PluginDebug.h

        * plugins/PluginDebug.h: Don't compile the errorStrings array if LOG_DISABLED is set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
mitz@apple.com [Sun, 8 Jun 2008 17:44:41 +0000 (17:44 +0000)]
    Reviewed by Adam Roben.

        - update trac URL in PrettyPatch

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-08 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 8 Jun 2008 16:10:16 +0000 (16:10 +0000)]
2008-06-08  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Mark Rowe.

        Bring back -fstrict-aliasing for JavaScriptCore which was removed in
        r31821, since aliasing issues have now been fixed.

        Use -O3, not -O2 for the JavaScriptCore build.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34440 268f45cc-cd09-0410-ab3c-d52691b4dbfc