jorlow@chromium.org [Fri, 4 Feb 2011 23:43:19 +0000 (23:43 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
* storage/indexeddb/error-causes-abort-by-default.html: Added.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
(WebCore::IDBEvent::dispatch):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore::IDBTransaction::backend):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Fri, 4 Feb 2011 23:36:37 +0000 (23:36 +0000)]
2011-02-04 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727
For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.
No new tests because no new functionality.
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createReadable):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::create):
* platform/chromium/PlatformBridge.h:
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::create):
(WebCore::ReadableDataObject::ReadableDataObject):
(WebCore::ReadableDataObject::getData):
(WebCore::ReadableDataObject::urlTitle):
(WebCore::ReadableDataObject::htmlBaseUrl):
(WebCore::ReadableDataObject::filenames):
(WebCore::ReadableDataObject::ensureTypeCacheInitialized):
* platform/chromium/ReadableDataObject.h:
2011-02-04 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727
For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.
* public/WebFrameClient.h:
(WebKit::WebFrameClient::clipboard):
* src/PlatformBridge.cpp:
(WebCore::getClipboard):
(WebCore::PlatformBridge::clipboardReadAvailableTypes):
(WebCore::PlatformBridge::clipboardReadData):
(WebCore::PlatformBridge::clipboardReadFilenames):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::fromFrame):
* src/WebFrameImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::dragTargetDragEnterNew):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 23:34:45 +0000 (23:34 +0000)]
[Chromium] Remove Chromium-specific baselines that we no longer need.
* platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.png: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 23:33:25 +0000 (23:33 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Revert https://bugs.webkit.org/show_bug.cgi?id=53795
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt: Removed.
* storage/indexeddb/error-causes-abort-by-default.html: Removed.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Revert https://bugs.webkit.org/show_bug.cgi?id=53795
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 23:19:11 +0000 (23:19 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Marked test, added in r77680 as failing due to lighttpd.
* platform/chromium/test_expectations.txt: Marked.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 23:08:55 +0000 (23:08 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Update Leopard baselines for fast/blockflow, this time correctly.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/mac-leopard/fast/blockflow/fieldsets-expected.png:
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 22:54:52 +0000 (22:54 +0000)]
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Merge in some GPU expectations that got dropped in r77666, get lint to pass.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 22:49:13 +0000 (22:49 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Add Leopard-specific pixel results for fast/ruby.
* platform/mac-leopard/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/mac-leopard/fast/ruby/nested-ruby-expected.png: Added.
* platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Added.
* platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.png:
* platform/mac-leopard/fast/ruby/ruby-length-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-length-expected.png:
* platform/mac-leopard/fast/ruby/ruby-run-break-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-run-break-expected.png:
* platform/mac-leopard/fast/ruby/ruby-runs-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-runs-expected.png:
* platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.png:
* platform/mac-leopard/fast/ruby/ruby-simple-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-simple-expected.png:
* platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.png:
* platform/mac-leopard/fast/ruby/ruby-trailing-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-trailing-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Feb 2011 22:41:55 +0000 (22:41 +0000)]
2011-02-04 Martin Galpin <martin@66laps.com>
Reviewed by David Levin.
CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773
* http/tests/xmlhttprequest/cross-origin-preflight-get-expected.txt: Added.
* http/tests/xmlhttprequest/cross-origin-preflight-get.html: Added.
* http/tests/xmlhttprequest/resources/cross-origin-preflight-get.php: Added.
2011-02-04 Martin Galpin <martin@66laps.com>
Reviewed by David Levin.
CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773
Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::preflightSuccess):
Explicitly set the request origin after a preflight request succeeds.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 22:38:12 +0000 (22:38 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
* storage/indexeddb/error-causes-abort-by-default.html: Added.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
(WebCore::IDBEvent::dispatch):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore::IDBTransaction::backend):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 4 Feb 2011 22:37:06 +0000 (22:37 +0000)]
2011-02-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit
https://bugs.webkit.org/show_bug.cgi?id=53810
<rdar://problem/
8946085>
If WebKit2WebProcess.exe is in a different directory from the client process, and that
client process uses CreateProcess to launch WebKit2WebProcess, the DLL search path may
end up excluding the directory containing WebKit. To address this, we use SetDllDirectory
to explicitly include the WebKit directory in the DLL search path.
* win/MainWin.cpp:
(wWinMain): Use SetDllDirectory and LoadLibrary to load WebKit.dll from WebKit2WebProcess.exe
* win/WebKit2WebProcessCommon.vsprops: Don't link directly to WebKit. Link against shlwapi.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 4 Feb 2011 22:31:00 +0000 (22:31 +0000)]
2011-02-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Bump Windows minimum system requirement to XPSP2
https://bugs.webkit.org/show_bug.cgi?id=53807
* win/tools/vsprops/common.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 22:29:28 +0000 (22:29 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Updated Win and Linux baselines after r77665.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Fri, 4 Feb 2011 22:08:35 +0000 (22:08 +0000)]
2011-02-04 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline chromium after r77654.
text-align attribute in <select> is ignored both in button text and drop-down
items.
* platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
* platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
* platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.checksum:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 22:05:51 +0000 (22:05 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Add Leopard-specific pixel results for fast/blockflow.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/block-level-images-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/block-level-images-expected.png: Added.
* platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.png: Added.
* platform/mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 21:53:36 +0000 (21:53 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Remove platform-specific baselines, since we match platform/mac here.
* platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 21:50:48 +0000 (21:50 +0000)]
Add a test case for encode/decode of FormData/FormDataElement
If the fix made in r77401 is broken, this new test will crash.
Fixes <http://webkit.org/b/53616> <rdar://problem/
8949883>.
Reviewed by Sam Weinig.
Tools:
* TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
* TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
(TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
(TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
form, an return the session state data.
(TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
and restore it into another WKPage.
* TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/copy-resources.cmd:
Added new files.
Source/WebKit2:
Allow passing a null filter callback to WKPageCopySessionState
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Check if the filter is null
before calling it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 21:50:09 +0000 (21:50 +0000)]
Move code to run JavaScript tests into its own files
This will allow other tests to use this mechanism.
Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
world
Reviewed by Sam Weinig.
* TestWebKitAPI/JavaScriptTest.cpp: Added.
* TestWebKitAPI/JavaScriptTest.h: Added.
Moved code here...
* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Added the new files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 21:48:29 +0000 (21:48 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Update mac expectations.
* platform/chromium/test_expectations.txt: Updated.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 21:43:24 +0000 (21:43 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Csaba Osztrogonác.
[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674
* platform/qt/Skipped:
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Csaba Osztrogonác.
[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674
* css/mediaControlsQt.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 4 Feb 2011 21:27:35 +0000 (21:27 +0000)]
2011-02-04 Mihai Parparita <mihaip@chromium.org>
Unreviewed GTK expectations update.
Unskip fast/history/timed-refresh-in-cached-frame.html, it should pass
with http://trac.webkit.org/changeset/77559.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 4 Feb 2011 21:25:21 +0000 (21:25 +0000)]
WebKit2: DidInitiateLoadForResource needs to know if the resource is being loaded by a committed or provisional frame
https://bugs.webkit.org/show_bug.cgi?id=53794
Reviewed by John Sullivan.
When we navigate from one page to another, there can be multiple subresource requests between when
the new page has started its provisional load and when it has committed the load.
There can be:
- The main resource load of the provisional page
- Synchronous XHR from the unload event of the loaded page.
WebKit clients need to be able to differentiate between these loads.
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didInitiateLoadForResource): Pass whether or not the page is provisionally loading
to the client.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Add a new parameter to DidInitiateLoadForResource.
* UIProcess/WebResourceLoadClient.cpp:
(WebKit::WebResourceLoadClient::didInitiateLoadForResource): a new parameter to didInitiateLoadForResource.
* UIProcess/WebResourceLoadClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Pass whether or not the page is currently
in a provisional load (checked by seeing if the DocumentLoader matches the FrameLoader's provisionalDocumentLoader)
to the UI Process.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 21:21:58 +0000 (21:21 +0000)]
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
merge test expectations for chromium, chromium-gpu. From
now on, we will track GPU-specific expectations with the
"GPU" modifier in the main file, rather than in a separate
file (and non-GPU-specific expectations with the "CPU"
modifier.
https://bugs.webkit.org/show_bug.cgi?id=53562
* platform/chromium-gpu/test_expectations.txt: Removed.
* platform/chromium/test_expectations.txt:
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
merge test expectations for chromium, chromium-gpu. The
chromium-gpu port will no longer maintain its own
test expectations file.
Also add in a graphics_type() call on the port object to
determine what graphics type to use in the test configuration,
and log the configuration as a config setting.
https://bugs.webkit.org/show_bug.cgi?id=53562
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Feb 2011 21:18:24 +0000 (21:18 +0000)]
<rdar://problem/
8902704> Make ruby text size 50% by default
https://bugs.webkit.org/show_bug.cgi?id=53723
Reviewed by Darin Adler and Dave Hyatt.
Source/WebCore:
* css/html.css:
(ruby > rt): Changed the font-size from 60% to 50%.
LayoutTests:
* fast/text/emphasis-avoid-ruby-expected.checksum:
* fast/text/emphasis-avoid-ruby-expected.png:
* fast/text/emphasis-avoid-ruby-expected.txt:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/ruby/nested-ruby-expected.checksum:
* platform/mac/fast/ruby/nested-ruby-expected.png:
* platform/mac/fast/ruby/nested-ruby-expected.txt:
* platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
* platform/mac/fast/ruby/ruby-beforeafter-expected.png:
* platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
* platform/mac/fast/ruby/ruby-empty-rt-expected.checksum:
* platform/mac/fast/ruby/ruby-empty-rt-expected.png:
* platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
* platform/mac/fast/ruby/ruby-length-expected.checksum:
* platform/mac/fast/ruby/ruby-length-expected.png:
* platform/mac/fast/ruby/ruby-length-expected.txt:
* platform/mac/fast/ruby/ruby-run-break-expected.checksum:
* platform/mac/fast/ruby/ruby-run-break-expected.png:
* platform/mac/fast/ruby/ruby-run-break-expected.txt:
* platform/mac/fast/ruby/ruby-runs-expected.checksum:
* platform/mac/fast/ruby/ruby-runs-expected.png:
* platform/mac/fast/ruby/ruby-runs-expected.txt:
* platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
* platform/mac/fast/ruby/ruby-runs-spans-expected.png:
* platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
* platform/mac/fast/ruby/ruby-simple-expected.checksum:
* platform/mac/fast/ruby/ruby-simple-expected.png:
* platform/mac/fast/ruby/ruby-simple-expected.txt:
* platform/mac/fast/ruby/ruby-simple-rp-expected.checksum:
* platform/mac/fast/ruby/ruby-simple-rp-expected.png:
* platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
* platform/mac/fast/ruby/ruby-trailing-expected.checksum:
* platform/mac/fast/ruby/ruby-trailing-expected.png:
* platform/mac/fast/ruby/ruby-trailing-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 4 Feb 2011 21:16:12 +0000 (21:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53610
Regression: adjacent sibling selector not working as expected
<rdar://problem/
8960033>
Reviewed by Dimitri Glazkov.
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/
8948643>
Test for additional conditions in parent style that prevent sharing.
Tests: fast/selectors/style-sharing-adjacent-selector.html
fast/selectors/style-sharing-last-child.html
* css/CSSStyleSelector.cpp:
(WebCore::parentStylePreventsSharing):
(WebCore::CSSStyleSelector::locateSharedStyle):
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/
8948643>
* fast/selectors/style-sharing-adjacent-selector-expected.txt: Added.
* fast/selectors/style-sharing-adjacent-selector.html: Added.
* fast/selectors/style-sharing-last-child-expected.txt: Added.
* fast/selectors/style-sharing-last-child.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 21:11:39 +0000 (21:11 +0000)]
2011-02-04 Mark Mentovai <mark@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium GYP build fix.
When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.
Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.
The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.
https://bugs.webkit.org/show_bug.cgi?id=53630
* WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into
direct_dependent_settings as needed, add the check_objc_rename
postbuild step.
* WebCore.gyp/mac/check_objc_rename.sh: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 4 Feb 2011 21:09:44 +0000 (21:09 +0000)]
BUILD FIX: REALLY remove the last vestiges of JSVALUE32!
<rdar://problem/
8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>
* DerivedSources.make: Removed dependency on
JavaScriptCore.JSVALUE32.exp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 4 Feb 2011 21:04:36 +0000 (21:04 +0000)]
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Mac WebKit2 should use the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53802
<rdar://problem/
7881419>
<rdar://problem/
7881447>
<rdar://problem/
8252632>
<rdar://problem/
8479422>
<rdar://problem/
8633813>
<rdar://problem/
8734512>
<rdar://problem/
8787660>
* UIProcess/API/mac/WKView.mm:
(useNewDrawingArea):
Return true. Eventually this function should be removed, but let's keep it for now so
we can go back to the old drawing area if necessary.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Fri, 4 Feb 2011 20:49:24 +0000 (20:49 +0000)]
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file.
https://bugs.webkit.org/show_bug.cgi?id=52594
* platform/qt/Skipped: Unskip plugins/iframe-shims.html
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594
Move Chromium code for identifying and cutting out
iframe shims from plugins to cross-platform utility file
IFrameShimSupport.cpp.
Amend PluginViewQt to use this code to handle shims correctly.
* WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
* WebCore.pro: Add Qt support for IFrameShimSupport.cpp
* plugins/IFrameShimSupport.cpp: Added.
(WebCore::getObjectStack):
(WebCore::iframeIsAbovePlugin):
(WebCore::getPluginOcclusions):
* plugins/IFframeShimSupport.h: Added.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594
* src/WebPluginContainerImpl.cpp: Move code to WebCore/plugin/IFrameShimSupport.cpp
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 4 Feb 2011 20:47:07 +0000 (20:47 +0000)]
2011-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Crash in WebPageProxy::setPendingAPIRequestURL after web process crashed
https://bugs.webkit.org/show_bug.cgi?id=53799
<rdar://problem/
8943956>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reload):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 4 Feb 2011 20:45:19 +0000 (20:45 +0000)]
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Fix a shared memory leak
https://bugs.webkit.org/show_bug.cgi?id=53800
Move the send right representing the shared memory.
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::encode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 4 Feb 2011 20:38:44 +0000 (20:38 +0000)]
<rdar://problem/
8636239> and https://bugs.webkit.org/show_bug.cgi?id=53785
WebKit2: Pages with dynamically inserted iframes can add extraneous back/forward items.
Reviewed by Anders Carlsson.
Source/WebKit2:
WebCore doesn't gracefully handle the case where the decidePolicyForNavigationAction callback
does not occur synchronously. Let's make it synchronous.
Change WebPageProxy to handle this message reply synchronously:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Make the navigation policy action message be synchronous.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Add a 6-argument varient
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the message synchronously.
LayoutTests:
* fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt: Added.
* fast/loader/dynamic-iframe-extra-back-forward-item.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 4 Feb 2011 20:35:42 +0000 (20:35 +0000)]
Windows build fix.
Correct prebuild build-stopping rule to allow project only rebuilds.
* win/WebKit2WebProcessPreBuild.cmd:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 4 Feb 2011 20:33:01 +0000 (20:33 +0000)]
Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup
window, or when running regression tests.
https://bugs.webkit.org/show_bug.cgi?id=53798
<rdar://problem/
8814364>
Reviewed by Adam Roben.
Only assert about the state of m_inspectorWindow and m_inspectorView if the inspector is visible.
Also, only call ::DestroyWindow if the HWND is non-null, just to be safe.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformClose):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Fri, 4 Feb 2011 20:30:20 +0000 (20:30 +0000)]
2011-02-04 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Override as true.
* src/WebViewImpl.cpp: Remove directionality hint from autofill drop-down setting.
2011-02-04 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
added in r76983.
* platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from
<select> drop-down setting.
(WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint
items in drop-down and pass-in bidi override flag when creating text run.
* platform/chromium/PopupMenuChromium.h: Remove directionalityHint from
PopupContainerSettings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 20:23:04 +0000 (20:23 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Add platform/mac-leopard baselines for tests added in r77639. The text rendering is
different enough for them to be different from mac-snowleopard.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 20:10:25 +0000 (20:10 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Build fix from merge mistake.
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::ensureEventTargetData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Fri, 4 Feb 2011 19:57:41 +0000 (19:57 +0000)]
2011-02-04 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Remove unneeded function declarations in comments in EditorClient.h
https://bugs.webkit.org/show_bug.cgi?id=53745
Removing unused commented out function declarations. No tests since this is just cleanup.
* page/EditorClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 19:50:24 +0000 (19:50 +0000)]
2011-02-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Refactor IDBRequest and IDBTransaction a bit
https://bugs.webkit.org/show_bug.cgi?id=53565
There were a lot of subtle issues with the way IDBTransaction
and IDBRequest used to be written. This cleans a lot of them up
and largely simplifies the logic. Using EventQueue rather than
timers is one example of the simplification.
* bindings/scripts/CodeGeneratorV8.pm:
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::dispatchEvent):
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::continueFunction):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::eventTargetData):
(WebCore::IDBRequest::ensureEventTargetData):
* storage/IDBRequest.h:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::onTimeout):
(WebCore::IDBTransaction::canSuspend):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):
(WebCore::IDBTransaction::eventTargetData):
(WebCore::IDBTransaction::ensureEventTargetData):
* storage/IDBTransaction.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 19:38:01 +0000 (19:38 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Add baselines for tests, added in r77644.
* platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 19:31:52 +0000 (19:31 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Temporarily add tests added in r77639 as failing, because
we can't see the baselines for these tests (they are in platform/mac-snowleopard).
* platform/chromium/test_expectations.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 19:22:50 +0000 (19:22 +0000)]
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
* storage/indexeddb/tutorial.html:
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
Remove timeout and ontimeout from IDBTransaction per the spec.
* WebCore.gypi:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBTimeoutEvent.cpp: Removed.
* storage/IDBTimeoutEvent.h: Removed.
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
* storage/IDBTransactionBackendImpl.h:
* storage/IDBTransactionCallbacks.h:
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
* public/WebIDBTransactionCallbacks.h:
* src/IDBDatabaseProxy.cpp:
(WebCore::IDBDatabaseProxy::transaction):
* src/IDBDatabaseProxy.h:
* src/IDBTransactionCallbacksProxy.cpp:
* src/IDBTransactionCallbacksProxy.h:
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::transaction):
* src/WebIDBDatabaseImpl.h:
* src/WebIDBTransactionCallbacksImpl.cpp:
* src/WebIDBTransactionCallbacksImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 19:16:05 +0000 (19:16 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Add baselines for tests, added in r77639.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 4 Feb 2011 18:47:41 +0000 (18:47 +0000)]
AX: Can't set accessibility overridden attributes on web objects
https://bugs.webkit.org/show_bug.cgi?id=53725
Reviewed by Darin Adler.
accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 18:42:30 +0000 (18:42 +0000)]
2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
* fast/repaint/slider-thumb-drag-release.html: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
Test: fast/repaint/slider-thumb-drag-release.html
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
that the thumb is repainted.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 4 Feb 2011 18:32:41 +0000 (18:32 +0000)]
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add "show more" data grid node and waiting message UI components.
https://bugs.webkit.org/show_bug.cgi?id=53763
- "show more" data grid node is used for on-demand population of
data grid contents (similar to DOM tree capability for limiting
displayed nodes count);
- waiting message is used for informing user about long lasting
operations (with a possibility to cancel them).
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/PleaseWaitMessage.js: Added.
(WebInspector.PleaseWaitMessage):
* inspector/front-end/ShowMoreDataGridNode.js: Added.
(WebInspector.ShowMoreDataGridNode):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.data-grid button):
(.please-wait-msg):
* inspector/front-end/inspector.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 18:32:20 +0000 (18:32 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Update mac baselines. They pixel-rotted.
* platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png:
* platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
* platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
* platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.checksum:
* platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
* platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
* platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
* platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
* platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 4 Feb 2011 18:27:06 +0000 (18:27 +0000)]
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
https://bugs.webkit.org/show_bug.cgi?id=53781
* Scripts/check-inspector-strings:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 4 Feb 2011 18:25:28 +0000 (18:25 +0000)]
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Go out of accelerated compositing mode when the drawing area is destroyed
https://bugs.webkit.org/show_bug.cgi?id=53788
This fixes a crash in the UI process if a web process crashes while in accelerated compositing mode.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 4 Feb 2011 18:18:30 +0000 (18:18 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/
8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused
Reviewed by Dan Bernstein.
Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html
* html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Add a check for shouldShowPlaceholderWhenFocused.
* html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):
Whenever the value is updated, we should also update placeholder visibility.
* rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):
Make the default the same as the existing behavior.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
Show placeholder when appropriate.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 4 Feb 2011 18:13:02 +0000 (18:13 +0000)]
<rdar://problem/
8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>
Reviewed by Darin Adler.
Support for JSVALUE32 was originaly removed in r70111.
* Configurations/JavaScriptCore.xcconfig: Changed armv6 to use
JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.
* DerivedSources.make: Removed rule for
JavaScriptCore.JSVALUE32.exp.
* JavaScriptCore.JSVALUE32only.exp: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed references
to JavaScriptCore.JSVALUE32only.exp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 18:02:54 +0000 (18:02 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Tweak expectations for passing tests.
* platform/chromium/test_expectations.txt: More tweakage.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 18:01:25 +0000 (18:01 +0000)]
Include the crashing function in the link to a crash log on Mac
Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
function that crashed on Mac
Reviewed by David Kilzer.
* Scripts/old-run-webkit-tests:
(crashLocation): Moved all the Windows code inside an if instead of using an early return,
but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
the crash log.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 4 Feb 2011 17:31:35 +0000 (17:31 +0000)]
Use static_cast and other style cleanup in YarrInterpreter.cpp
<http://webkit.org/b/53772>
Reviewed by John Sullivan.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 17:20:10 +0000 (17:20 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Remove more passing tests.
* platform/chromium/test_expectations.txt: Even more passages removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 17:07:47 +0000 (17:07 +0000)]
Link to Mac crash logs from results.html
Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html
Reviewed by David Kilzer.
* Scripts/old-run-webkit-tests:
(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 17:05:57 +0000 (17:05 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Removed passing tests.
* platform/chromium/test_expectations.txt: Passages removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 4 Feb 2011 16:38:34 +0000 (16:38 +0000)]
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: evaluate on hover does not work on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=53768
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._mouseHover):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 4 Feb 2011 16:28:13 +0000 (16:28 +0000)]
2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765
It broke Windows builds (Requested by Ossy_ on #webkit).
* Android.jscbindings.mk:
* CMakeLists.txt:
* ForwardingHeaders/pcre/pcre.h: Added.
* ForwardingHeaders/yarr/Yarr.h: Removed.
* ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
* ForwardingHeaders/yarr/YarrPattern.h: Removed.
* WebCore.gyp/WebCore.gyp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::regexp):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::~Private):
(WebCore::RegularExpression::match):
2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77625 and r77626.
http://trac.webkit.org/changeset/77625
http://trac.webkit.org/changeset/77626
https://bugs.webkit.org/show_bug.cgi?id=53765
It broke Windows builds (Requested by Ossy_ on #webkit).
* JavaScriptCore.exp:
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.xcodeproj/project.pbxproj:
* create_regex_tables:
* runtime/RegExp.cpp:
* wtf/Platform.h:
* yarr/Yarr.h:
* yarr/YarrJIT.cpp:
* yarr/YarrJIT.h:
* yarr/YarrParser.h:
* yarr/YarrPattern.h:
* yarr/YarrSyntaxChecker.h:
* yarr/yarr.pri: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 4 Feb 2011 15:51:28 +0000 (15:51 +0000)]
Windows build fix. Unreviewed.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 4 Feb 2011 15:21:32 +0000 (15:21 +0000)]
[Windows 7 Release Tests] transitions/transition-end-event-multiple-04.html flakey
https://bugs.webkit.org/show_bug.cgi?id=53332
Unreviewed, attempt to get the Windows 7 Release bots uniformly green.
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Fri, 4 Feb 2011 14:54:39 +0000 (14:54 +0000)]
2011-02-04 Peter Varga <pvarga@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
Speculative windows build fix.
No new tests needed.
* platform/text/RegularExpression.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Fri, 4 Feb 2011 14:29:10 +0000 (14:29 +0000)]
2011-02-04 Peter Varga <pvarga@webkit.org>
Reviewed by Gavin Barraclough.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
* JavaScriptCore.exp:
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.xcodeproj/project.pbxproj:
* create_regex_tables:
* runtime/RegExp.cpp:
* wtf/Platform.h:
* yarr/Yarr.h:
* yarr/YarrJIT.cpp:
* yarr/YarrJIT.h:
* yarr/YarrParser.h:
* yarr/YarrPattern.h:
* yarr/YarrSyntaxChecker.h:
* yarr/yarr.pri: Added.
2011-02-04 Peter Varga <pvarga@webkit.org>
Reviewed by Gavin Barraclough.
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
No new tests needed.
* Android.jscbindings.mk:
* CMakeLists.txt:
* ForwardingHeaders/pcre/pcre.h: Removed.
* ForwardingHeaders/yarr/Yarr.h: Added.
* ForwardingHeaders/yarr/YarrInterpreter.h: Added.
* ForwardingHeaders/yarr/YarrPattern.h: Added.
* WebCore.gyp/WebCore.gyp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::match):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 4 Feb 2011 14:27:57 +0000 (14:27 +0000)]
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Rebaseline. The problem was introduced at r77601.
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 4 Feb 2011 14:22:05 +0000 (14:22 +0000)]
2011-02-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Network panel filtering is broken.
https://bugs.webkit.org/show_bug.cgi?id=53764
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._sortItems):
(WebInspector.NetworkPanel.prototype._sortByTimeline):
(WebInspector.NetworkPanel.prototype._filter):
(WebInspector.NetworkPanel.prototype._updateOffscreenRows):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
(WebInspector.NetworkTotalGridNode.prototype.isFilteredOut):
(WebInspector.NetworkTotalGridNode.prototype.get selectable):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 4 Feb 2011 13:47:26 +0000 (13:47 +0000)]
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Rebaseline image for fast/box-shadow/shadow-tiling-artifact.html
The problem was introduced at r77601.
* platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
* platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
* platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
* platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 4 Feb 2011 13:32:56 +0000 (13:32 +0000)]
2011-02-04 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
New test expectations.
* platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
* platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
* platform/gtk/svg/text/font-size-below-point-five-2-expected.txt: Added.
* platform/gtk/svg/text/font-size-below-point-five-expected.txt: Added.
* platform/gtk/svg/text/scaled-font-expected.txt: Added.
* platform/gtk/svg/text/small-fonts-2-expected.txt: Added.
* platform/gtk/svg/text/small-fonts-3-expected.txt: Added.
* platform/gtk/svg/text/small-fonts-expected.txt: Added.
* platform/gtk/svg/text/small-fonts-in-html5-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 4 Feb 2011 13:25:42 +0000 (13:25 +0000)]
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485
Test: http/tests/inspector/extensions-useragent.html
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::setUserAgentOverride):
(WebCore::InspectorController::userAgentOverride):
* inspector/InspectorController.h:
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::userAgent):
(WebCore::FrameLoader::applyUserAgent):
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: support overriding user agent strings
https://bugs.webkit.org/show_bug.cgi?id=51485
* http/tests/inspector/extensions-useragent-expected.txt: Added.
* http/tests/inspector/extensions-useragent.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 4 Feb 2011 13:03:21 +0000 (13:03 +0000)]
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed rollout two patches r77614 and r77612.
REGRESSION: Snow Leopard Intell Release anumber of failing tests.
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reset):
* runtime/Heap.h:
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 4 Feb 2011 12:40:49 +0000 (12:40 +0000)]
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: scripts panel displays wrong file name after reload.
https://bugs.webkit.org/show_bug.cgi?id=53761
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 4 Feb 2011 11:34:05 +0000 (11:34 +0000)]
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCore.exp.in:
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorClient.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
* inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can
provide platform-specific settings accessor.
(WebCore::InspectorFrontendClientLocal::Settings::Settings):
(WebCore::InspectorFrontendClientLocal::Settings::~Settings):
(WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight):
(WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
* loader/EmptyClients.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCoreSupport/WebInspectorClientCF.cpp:
(populateSetting):
(storeSetting):
(WebInspectorClient::createFrontendSettings):
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorFrontendClient::InspectorFrontendClient):
* WebCoreSupport/InspectorClientGtk.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
* WebCoreSupport/InspectorClientQt.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
* WebCoreSupport/WebInspectorClient.h:
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Fri, 4 Feb 2011 10:32:29 +0000 (10:32 +0000)]
2011-02-04 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Skipping fast/events/pagehide-timeout.html that is failing on GTK
bots. See https://bugs.webkit.org/show_bug.cgi?id=53733
* platform/gtk/Skipped: skip fast/events/pagehide-timeout.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 4 Feb 2011 08:49:32 +0000 (08:49 +0000)]
2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Roll chromium to 73764.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 4 Feb 2011 08:12:42 +0000 (08:12 +0000)]
Try to fix 32bit build.
* runtime/Heap.cpp:
(JSC::Heap::reset): Use an explicit cast to avoid shortening warnings,
since 1.5 is double (64bit), and the result is size_t (32bit).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 4 Feb 2011 07:50:53 +0000 (07:50 +0000)]
2011-02-03 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] frame several more JS code invocations into v8::TryCatch
https://bugs.webkit.org/show_bug.cgi?id=53594
This patch is preemptive and adjusts v8 bindings code to forthcoming small change
in v8::ThrowException---currently sometimes exceptions thrown by this method
do not reach surrounding v8::TryCatch handler (see
http://code.google.com/p/v8/issues/detail?id=1072 and
http://codereview.chromium.org/
6397011/). Therefore the goal of this patch
is to make forthcoming v8 roll as smooth as possible (alas, we'll still need
one rebaseline as of now.)
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction): Ditto
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 4 Feb 2011 07:41:33 +0000 (07:41 +0000)]
2011-02-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Changed MarkedSpace to delegate grow/shrink decisions to Heap
https://bugs.webkit.org/show_bug.cgi?id=53759
SunSpider reports no change.
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reset):
* runtime/Heap.h: Reorganized a few data members for better cache locality.
Added a grow policy.
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::reset): Don't shrink automatically. Instead, wait for
the heap to make an explicit sweep call.
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark): Use a watermark to determine how
many bytes to allocate before failing and giving the heap an opportunity
to collect garbage. This also means that we allocate blocks on demand,
instead of ahead of time.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 4 Feb 2011 07:27:37 +0000 (07:27 +0000)]
2011-02-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/
8898294>
* WebCore.exp.in: Add export now needed by WebKit2
2011-02-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/
8898294>
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
2011-02-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
https://bugs.webkit.org/show_bug.cgi?id=52897
<rdar://problem/
8898294>
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::willSendRequestForFrame):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ike@apple.com [Fri, 4 Feb 2011 07:00:58 +0000 (07:00 +0000)]
2011-02-03 Ivan Krstić <ike@apple.com>
Reviewed by Maciej Stachowiak.
Make WebProcess pass explicit homedir parameter to the sandbox
<rdar://problem/
8405760>
<https://webkit.org/b/53558>
* WebProcess/com.apple.WebProcess.sb:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ike@apple.com [Fri, 4 Feb 2011 06:54:53 +0000 (06:54 +0000)]
2011-02-03 Ivan Krstić <ike@apple.com>
Unreviewed.
Adding myself to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Feb 2011 06:46:41 +0000 (06:46 +0000)]
2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.
[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::SharedValues::SharedValues):
(WebCore::VideoLayerChromium::drawYUV):
* platform/graphics/chromium/VideoLayerChromium.h:
(WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 4 Feb 2011 06:31:21 +0000 (06:31 +0000)]
Add navigator.registerProtocolHandler behind a flag.
https://bugs.webkit.org/show_bug.cgi?id=52609
Patch by James Kozianski <koz@chromium.org> on 2011-02-03
Reviewed by Dimitri Glazkov.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This method is described in the HTML5 specification here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler
This change is largely cribbed from B. Green's 29651 patches. It is
behind a flag so as not to break JS feature detection.
New layout test fast/dom/registerProtocolHandler.html.
* Configurations/FeatureDefines.xcconfig:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::registerProtocolHandler):
* page/Chrome.cpp:
(WebCore::Chrome::registerProtocolHandler):
* page/Chrome.h:
* page/ChromeClient.h:
* page/Navigator.cpp:
(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
* page/Navigator.h:
* page/Navigator.idl:
Source/WebKit/chromium:
* features.gypi:
* public/WebViewClient.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::registerProtocolHandler):
* src/ChromeClientImpl.h:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
Tools:
* Scripts/build-webkit:
WebKitLibraries:
* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
* fast/dom/register-protocol-handler-expected.txt: Added.
* fast/dom/register-protocol-handler.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 4 Feb 2011 06:26:26 +0000 (06:26 +0000)]
2011-02-03 Hayato Ito <hayato@chromium.org>
Reviewed by Eric Seidel.
[NRWT] Remove TestArgs class, which is wrongly used.
https://bugs.webkit.org/show_bug.cgi?id=53063
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Feb 2011 05:45:44 +0000 (05:45 +0000)]
2011-02-03 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Kenneth Russell.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53714
* Scripts/build-webkit: change --3d-canvas build option
to set ENABLE_WEBGL
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Feb 2011 05:38:21 +0000 (05:38 +0000)]
2011-02-03 Brian Ryner <bryner@chromium.org>
Reviewed by Darin Fisher.
Add a field to the ResourceResponse for tracking the socket address
of the host that the resource was fetched from. Patch was originally
by Paul Marks.
https://bugs.webkit.org/show_bug.cgi?id=53699
* platform/network/chromium/ResourceResponse.cpp:
(WebCore::ResourceResponse::doPlatformCopyData):
(WebCore::ResourceResponse::doPlatformAdopt):
* platform/network/chromium/ResourceResponse.h:
(WebCore::ResourceResponse::socketAddress):
(WebCore::ResourceResponse::setSocketAddress):
2011-02-03 Brian Ryner <bryner@chromium.org>
Reviewed by Darin Fisher.
Add a field to the ResourceResponse for tracking the socket address
of the host that the resource was fetched from. Patch was originally
by Paul Marks.
https://bugs.webkit.org/show_bug.cgi?id=53699
* public/WebURLResponse.h:
* src/WebURLResponse.cpp:
(WebKit::WebURLResponse::socketAddress):
(WebKit::WebURLResponse::setSocketAddress):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 4 Feb 2011 05:36:15 +0000 (05:36 +0000)]
2011-02-03 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
[NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
move _run_single_test() and _process_output() functions from
dump_render_tree_thread.py to a single_test_runner.py as an individual module.
This is clean up and acts as a preparation for elimination of test_types/*
classes. These classes will move to the single_test_runner module introduced
in this patch.
https://bugs.webkit.org/show_bug.cgi?id=53004
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
* Scripts/webkitpy/layout_tests/layout_package/test_input.py:
* Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
agl@chromium.org [Fri, 4 Feb 2011 05:30:08 +0000 (05:30 +0000)]
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkIfRunInsecureContent):
* loader/FrameLoaderClient.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* public/WebFrameClient.h:
(WebKit::WebFrameClient::didRunInsecureContent):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didRunInsecureContent):
* src/FrameLoaderClientImpl.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didRunInsecureContent):
* WebCoreSupport/FrameLoaderClientEfl.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::didRunInsecureContent):
* WebCoreSupport/FrameLoaderClientGtk.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::didRunInsecureContent):
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didRunInsecureContent):
* WebCoreSupport/FrameLoaderClientQt.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didRunInsecureContent):
* WebCoreSupport/WebFrameLoaderClient.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::didRunInsecureContent):
* WebCoreSupport/FrameLoaderClientWinCE.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::didRunInsecureContent):
* WebKitSupport/FrameLoaderClientWx.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 4 Feb 2011 05:28:30 +0000 (05:28 +0000)]
2011-02-03 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
REGRESSION: Artifacts on box-shadow corners in some cases
https://bugs.webkit.org/show_bug.cgi?id=53731
Fix overdrawing artifacts in ShadowBlur's tiling code path,
which show up in shadows using a color with alpha.
Test: fast/box-shadow/shadow-tiling-artifact.html
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure
that the inner rect that gets filled does not overlap with any
of the eight tiled areas by having the corner and side dimensions
be the same for contiguous areas.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Feb 2011 05:26:57 +0000 (05:26 +0000)]
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
XSS Auditor is spinning inside decodeURLEscapeSequences() if there are
percent signs in large posted data
https://bugs.webkit.org/show_bug.cgi?id=53405
If the input string contains many non-% characters followed by a %
character that is not a valid URL escape sequence, then the old
algorithm would only advance the initial search by one character
(instead of jumping to just after the % character). That would cause
the algorithm to take N^2 time (in the number of characters before the
first % character). This patch just advances the search past the first
% character so we can start looking for next % character sooner.
* platform/KURL.cpp:
(WebCore::decodeURLEscapeSequences):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Feb 2011 05:20:04 +0000 (05:20 +0000)]
2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
https://bugs.webkit.org/show_bug.cgi?id=52868
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
* src/WebMediaPlayerClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 4 Feb 2011 05:08:03 +0000 (05:08 +0000)]
2011-02-03 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: click on a breakpoint highlights wrong line in source frame.
https://bugs.webkit.org/show_bug.cgi?id=53692
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 4 Feb 2011 05:04:15 +0000 (05:04 +0000)]
2011-02-03 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687
This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.
See http://code.google.com/p/chromium/issues/detail?id=71544
There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.
* bindings/v8/V8Binding.cpp:
(WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
* bindings/v8/V8Binding.h:
(WebCore::V8ParameterBase::prepareBase): Ditto
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joone.hur@collabora.co.uk [Fri, 4 Feb 2011 05:03:08 +0000 (05:03 +0000)]
2011-02-03 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[Gtk] No need to set text encoding in the provisional phase
https://bugs.webkit.org/show_bug.cgi?id=53487
According to changeset 67253, setEncoding could be called multiple times from
committedLoad, finishedLoading, dispatchDidFailLoading, and setMainDocumentError
in FrameLoaderClient. To fix this, the relevant code was removed from
FrameLoaderClient and moved to DocumentLoader::commitData. However, that
code was not removed from FrameLoaderClient::finishedLoading in WebKitGtk+.
Due to this reason, after loading a html document, other ports initialize the
text encoding from FrameLoaderClient::finishedLoading, but WebKitGtk+ sets
the same encoding again, even tries to set encoding in the provisional phase.
This causes unnecessary encoding setting.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::FrameLoaderClient): Set m_hasRepresentation to false.
(WebKit::FrameLoaderClient::makeRepresentation): Set m_hasRepresentation to true.
(WebKit::FrameLoaderClient::revertToProvisionalState): Set m_hasRepresentation to true.
(WebKit::FrameLoaderClient::finishedLoading): Skip the encoding setting when
m_hasRepresentation is false.
* WebCoreSupport/FrameLoaderClientGtk.h: Added m_hasRepresentation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 04:53:55 +0000 (04:53 +0000)]
2011-02-03 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Delete a line that was accidentally missed in r77586; without it
there is still a race between the two threads.
https://bugs.webkit.org/show_bug.cgi?id=51572
* Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 4 Feb 2011 04:32:24 +0000 (04:32 +0000)]
worker-importScriptsOnError needs to allow for the console error to
flush out before calling notifyDone.
Reviewed by Adam Barth.
* http/tests/workers/worker-importScriptsOnError-expected.txt:
* http/tests/workers/worker-importScriptsOnError.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Feb 2011 04:24:29 +0000 (04:24 +0000)]
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
Add another XSSFilter PerformanceTest
https://bugs.webkit.org/show_bug.cgi?id=53750
This PerformanceTest tests the case that was slow in
https://bugs.webkit.org/show_bug.cgi?id=49845
* XSSFilter/large-post-many-inline-scripts-and-events.html: Added.
* XSSFilter/resources: Added.
* XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 04:07:12 +0000 (04:07 +0000)]
2011-02-03 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: handle "broken pipe" notifications from DRT more cleanly.
https://bugs.webkit.org/show_bug.cgi?id=52927
* Scripts/webkitpy/layout_tests/port/server_process.py:
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Feb 2011 04:05:49 +0000 (04:05 +0000)]
2011-02-03 Adam Barth <abarth@webkit.org>
Attempt to fix Chromium build.
* html/parser/XSSFilter.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Feb 2011 04:02:02 +0000 (04:02 +0000)]
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add PerformanceTest for XSSFilter
https://bugs.webkit.org/show_bug.cgi?id=53741
This performance tests covers the case of a large POST data and many
small event handlers.
* XSSFilter: Added.
* XSSFilter/large-post-many-events.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 03:59:26 +0000 (03:59 +0000)]
2011-02-03 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rolling out r77562.
http://trac.webkit.org/changeset/77562
https://bugs.webkit.org/show_bug.cgi?id=53630
broke chromium mac build
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/mac/check_objc_rename.sh: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 4 Feb 2011 03:56:40 +0000 (03:56 +0000)]
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSS Auditor severely affects loading performance after submitting a large form
https://bugs.webkit.org/show_bug.cgi?id=49845
The XSSFilter catches some more cases and has different console
messages than the XSSAuditor. We might want to improve these messages
in the future.
* http/tests/security/xssAuditor/base-href-control-char-expected.txt:
* http/tests/security/xssAuditor/base-href-expected.txt:
* http/tests/security/xssAuditor/base-href-null-char-expected.txt:
* http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
* http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
* http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/embed-tag-expected.txt:
* http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/full-block-base-href-expected.txt:
* http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
* http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-expected.txt:
* http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
* http/tests/security/xssAuditor/object-tag-expected.txt:
* http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
* http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
2011-02-03 Adam Barth <abarth@webkit.org>
Reviewed by Daniel Bates.
XSS Auditor severely affects loading performance after submitting a large form
https://bugs.webkit.org/show_bug.cgi?id=49845
Switch over from the XSSAuditor to the XSSFilter, improving performance
on this example.
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::filterToken):
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::isEnabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc