commit-queue@webkit.org [Thu, 14 Oct 2010 06:58:30 +0000 (06:58 +0000)]
2010-10-13 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Sync tests from html5lib.
https://bugs.webkit.org/show_bug.cgi?id=47627
* html5lib/resources/adoption02.dat: Copied from html5lib.
* html5lib/resources/entities01.dat: Ditto.
* html5lib/resources/pending-spec-changes.dat: Ditto.
* html5lib/resources/tests21.dat: Ditto.
* html5lib/runner-expected.txt: 2 tests now pass.
* platform/chromium/html5lib/runner-expected.txt: Ditto.
* platform/win/html5lib/runner-expected.txt: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Oct 2010 06:55:51 +0000 (06:55 +0000)]
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
beat diff_parser with the ugly stick
https://bugs.webkit.org/show_bug.cgi?id=47626
* Scripts/webkitpy/common/checkout/diff_parser.py:
* Scripts/webkitpy/style/patchreader.py:
* Scripts/webkitpy/style/patchreader_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 06:45:26 +0000 (06:45 +0000)]
2010-10-13 David Goodwin <david_goodwin@apple.com>
Reviewed by Oliver Hunt.
ARMv7 JIT should generated conditional branches when possible
https://bugs.webkit.org/show_bug.cgi?id=47384
Use different jump padding sizes for conditional and unconditional
jumps (12 bytes and 10 bytes respectively). This allows the JIT to
include the IT instruction as part of the conditional jump sequence
which in turn allows it to optimize away the IT using an ARMv7
conditional branch instruction. Use 2-byte B(T1) and 4-byte B(T3) for
conditional branches when displacement is in range. Also use IT/B(T4)
for conditional branch when displacement does not fit in B(T3).
For unconditional jump, instruction selection options are:
B(T2), B(T4), MOVW/MOVT/BX. For conditional jump, instruction selection
options are: B(T1), B(T3), IT/B(T4), ITTT/MOVW/MOVT/BX.
* assembler/ARMv7Assembler.cpp:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::JmpSrc::JmpSrc):
(JSC::ARMv7Assembler::ifThenElse):
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::canCompact):
(JSC::ARMv7Assembler::computeJumpType):
(JSC::ARMv7Assembler::link):
(JSC::ARMv7Assembler::canBeJumpT1):
(JSC::ARMv7Assembler::canBeJumpT3):
(JSC::ARMv7Assembler::canBeJumpT4):
(JSC::ARMv7Assembler::linkJumpT1):
(JSC::ARMv7Assembler::linkJumpT3):
(JSC::ARMv7Assembler::linkJumpT4):
(JSC::ARMv7Assembler::linkConditionalJumpT4):
(JSC::ARMv7Assembler::linkBX):
(JSC::ARMv7Assembler::linkConditionalBX):
(JSC::ARMv7Assembler::linkJumpAbsolute):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::canCompact):
(JSC::MacroAssemblerARMv7::computeJumpType):
(JSC::MacroAssemblerARMv7::jumpSizeDelta):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeJump):
(JSC::MacroAssemblerARMv7::makeBranch):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 06:32:17 +0000 (06:32 +0000)]
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
WebKitGtk+ to use the new API from the imported SoupURILoader code
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
ResourceHandleSoup now does everything via SoupURILoader. This means
that all URLs are handled via the same code path, where WebCore simply
asks libsoup for a WebKitSoupRequest and the request returns an input
stream. Many of ResourceHandleSoup's data members are now PlatformRefPtr
as well, to simplify reference counting
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::restartedCallback):
(WebCore::gotChunkCallback):
(WebCore::parseDataUrl):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::startHttp):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::startGio):
* platform/network/soup/ResourceRequest.h:
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessage):
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
WebKitGtk+ to use the new API from the imported SoupURILoader code
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
ResourceHandleInternal m_msg is now called m_soupMessage.
* webkit/webkitdownload.cpp:
(webkit_download_new_with_handle):
(webkit_download_start):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 06:28:28 +0000 (06:28 +0000)]
2010-10-13 Martin Robinson <mrobinson@igalia.com>
Rebaseline canvas/philip/tests/2d.gradient.radial.negative.html. It seems
that the result for this test is only differing by two newlines. Also skip
a failing test on GTK+.
* canvas/philip/tests/2d.gradient.radial.negative-expected.txt: Rebaseline.
* platform/gtk/Skipped: Skip failing test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Oct 2010 05:54:06 +0000 (05:54 +0000)]
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Break LayoutTestResults out into its own file
https://bugs.webkit.org/show_bug.cgi?id=47637
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:
* Scripts/webkitpy/common/net/layouttestresults.py: Added.
* Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Thu, 14 Oct 2010 05:49:08 +0000 (05:49 +0000)]
2010-10-13 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's test expectations.
* platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
* platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
* platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
* platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
* platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 14 Oct 2010 05:28:53 +0000 (05:28 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Unreviewed.
Chromium port can't run JavaScriptCore tests
https://bugs.webkit.org/show_bug.cgi?id=47654
This lets webkit-patch build-and-test work on Chromium.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/tool/steps/runtests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 14 Oct 2010 05:04:43 +0000 (05:04 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make --port a global option and pass the port information to the commit-queue subprocess
https://bugs.webkit.org/show_bug.cgi?id=47650
This patch paves the way to run the commit-queue on a non-Mac port.
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/steps/options.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/update.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 14 Oct 2010 05:00:17 +0000 (05:00 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce the ChromiumXVFBPort for running commit-queue on EC2
https://bugs.webkit.org/show_bug.cgi?id=47653
I'm not entirely sure this is the best way to do this, but we need to
run the tests under XVFB on EC2 because the EC2 instances don't have a
real monitor hooked up. This patch adds a ChromiumXVFBPort that runs
that way. The idea is that XVFB is like a platform for the Chromium
port, but we don't have a real notion of platform separate from port.
* Scripts/webkitpy/common/config/ports.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 14 Oct 2010 04:55:34 +0000 (04:55 +0000)]
2010-10-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Prevent block logical height of a root inline box from overflowing by clamping it
at INT_MAX. Otherwise, we will not be able to properly dirty the set of lines during
removal a floating object.
https://bugs.webkit.org/show_bug.cgi?id=45611
Test: fast/overflow/overflow-block-logical-height-crash.html
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
2010-10-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that overflowing the block logical height of a root inline box does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=45611
* fast/overflow/overflow-block-logical-height-crash-expected.txt: Added.
* fast/overflow/overflow-block-logical-height-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 14 Oct 2010 04:11:43 +0000 (04:11 +0000)]
Memory smasher in WebKit2 InjectedBundleHitTestResult::absoluteLinkURL
https://bugs.webkit.org/show_bug.cgi?id=47648
Reviewed by Jon Honeycutt.
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::absoluteLinkURL):
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: Return a String instead of
a const String&.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 14 Oct 2010 04:11:05 +0000 (04:11 +0000)]
PlatformMouseEvents need to contain modifier flags
https://bugs.webkit.org/show_bug.cgi?id=47651
Reviewed by Jon Honeycutt.
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
Fill in m_modifierFlags.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 02:16:21 +0000 (02:16 +0000)]
2010-10-13 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Darin Adler.
Don't depend on Windows on sched_yield and sched.h
https://bugs.webkit.org/show_bug.cgi?id=45543
sched.h is part of pthreads and sched_yield is implemented
in pthreads-win32 as Sleep(0). This patch avoids a gratuitous
dependency on pthreads-win32 in this file.
* wtf/TCSpinLock.h:
(TCMalloc_SlowLock):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Oct 2010 02:13:10 +0000 (02:13 +0000)]
2010-09-23 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
Canvas: radialGradient with negative radius should throw exception
https://bugs.webkit.org/show_bug.cgi?id=37176
Remove test from skipped lists now that it passes.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
2010-10-13 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
Throw INDEX_SIZE_ERR exception if createRadialGradient is called with a negative radius
Canvas: radialGradient with negative radius should throw exception
https://bugs.webkit.org/show_bug.cgi?id=37176
This matches the canvas 2d specification, Opera, IE9 beta and our behavior for arc()
and arcTo(). Also fixes some PassRefPtr/RefPtr errors in this file.
Test: canvas/philip/tests/2d.gradient.radial.negative.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createLinearGradient):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::measureText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Oct 2010 02:03:03 +0000 (02:03 +0000)]
2010-10-13 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Darin Adler.
Add WebCore/plugins/win directory to CFLAGS
https://bugs.webkit.org/show_bug.cgi?id=45547
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 01:30:52 +0000 (01:30 +0000)]
2010-10-13 Martin Robinson <mrobinson@igalia.com>
Build fix for older versions of libsoup.
* platform/network/soup/cache/soup-request-file.c:
(webkit_soup_request_file_ensure_file): Access the path member of the SoupURI directly.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 14 Oct 2010 01:08:15 +0000 (01:08 +0000)]
2010-10-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
[Chromium] Enable FILE_SYSTEM by default for chromium
https://bugs.webkit.org/show_bug.cgi?id=47639
* features.gypi: Add FILE_SYSTEM=1. Also remove FILE_READER=1
as it seems to be not used anymore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Thu, 14 Oct 2010 01:01:52 +0000 (01:01 +0000)]
[BREWMP] Port unicode
https://bugs.webkit.org/show_bug.cgi?id=45716
Reviewed by Kent Tamura.
Brew MP port uses only the subset of ICU library to reduce the binary size.
Follow the WinCE's implementation.
* wtf/Platform.h:
* wtf/unicode/Unicode.h:
* wtf/unicode/brew/UnicodeBrew.cpp: Added.
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::foldCase):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isUpper):
(WTF::Unicode::isLower):
(WTF::Unicode::isDigit):
(WTF::Unicode::isPunct):
(WTF::Unicode::isAlphanumeric):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::direction):
(WTF::Unicode::category):
(WTF::Unicode::decompositionType):
(WTF::Unicode::combiningClass):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::digitValue):
(WTF::Unicode::isSpace):
(WTF::Unicode::isLetter):
* wtf/unicode/brew/UnicodeBrew.h: Added.
(WTF::Unicode::isArabicChar):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::hasLineBreakingPropertyComplexContext):
(WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic):
(WTF::Unicode::umemcasecmp):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kseo@webkit.org [Thu, 14 Oct 2010 00:49:09 +0000 (00:49 +0000)]
[BREWMP] Add TextBoundaries and TextBreakIterator
https://bugs.webkit.org/show_bug.cgi?id=46105
Reviewed by Kent Tamura.
Copy the implementation of WinCE port.
* platform/text/brew/TextBoundariesBrew.cpp: Added.
(WebCore::findNextWordFromIndex):
(WebCore::findWordBoundary):
* platform/text/brew/TextBreakIteratorBrew.cpp: Added.
(WebCore::isCharStop):
(WebCore::isLineStop):
(WebCore::isSentenceStop):
(WebCore::TextBreakIterator::reset):
(WebCore::TextBreakIterator::following):
(WebCore::TextBreakIterator::preceding):
(WebCore::WordBreakIterator::first):
(WebCore::WordBreakIterator::next):
(WebCore::WordBreakIterator::previous):
(WebCore::CharBreakIterator::first):
(WebCore::CharBreakIterator::next):
(WebCore::CharBreakIterator::previous):
(WebCore::LineBreakIterator::first):
(WebCore::LineBreakIterator::next):
(WebCore::LineBreakIterator::previous):
(WebCore::SentenceBreakIterator::first):
(WebCore::SentenceBreakIterator::next):
(WebCore::SentenceBreakIterator::previous):
(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):
(WebCore::textBreakFirst):
(WebCore::textBreakNext):
(WebCore::textBreakPreceding):
(WebCore::textBreakFollowing):
(WebCore::textBreakCurrent):
(WebCore::isTextBreak):
(WebCore::cursorMovementIterator):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 14 Oct 2010 00:39:06 +0000 (00:39 +0000)]
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore.html:
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::remove):
* storage/IDBCursor.h:
(WebCore::IDBCursor::continueFunction):
* storage/IDBCursor.idl:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::remove):
* storage/IDBCursorBackendImpl.h:
* storage/IDBCursorBackendInterface.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::removeObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* storage/IDBFactory.h:
(WebCore::IDBFactory::open):
* storage/IDBFactory.idl:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* storage/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndex.idl:
* storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
* storage/IDBIndexBackendImpl.h:
* storage/IDBIndexBackendInterface.h:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::remove):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::removeIndex):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.idl:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::remove):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::removeIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
* storage/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):
* storage/IDBObjectStoreBackendInterface.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
* storage/IDBTransaction.h:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::objectStore):
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
* public/WebIDBCursor.h:
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
* public/WebIDBFactory.h:
(WebKit::WebIDBFactory::open):
* public/WebIDBObjectStore.h:
* public/WebIDBTransactionCallbacks.h:
* src/IDBCursorBackendProxy.cpp:
(WebCore::IDBCursorBackendProxy::update):
(WebCore::IDBCursorBackendProxy::continueFunction):
(WebCore::IDBCursorBackendProxy::remove):
* src/IDBCursorBackendProxy.h:
* src/IDBDatabaseProxy.cpp:
(WebCore::IDBDatabaseProxy::createObjectStore):
(WebCore::IDBDatabaseProxy::removeObjectStore):
(WebCore::IDBDatabaseProxy::setVersion):
(WebCore::IDBDatabaseProxy::transaction):
* src/IDBDatabaseProxy.h:
* src/IDBIndexBackendProxy.cpp:
(WebCore::IDBIndexBackendProxy::openCursor):
(WebCore::IDBIndexBackendProxy::openKeyCursor):
(WebCore::IDBIndexBackendProxy::get):
(WebCore::IDBIndexBackendProxy::getKey):
* src/IDBIndexBackendProxy.h:
* src/IDBObjectStoreProxy.cpp:
(WebCore::IDBObjectStoreProxy::get):
(WebCore::IDBObjectStoreProxy::put):
(WebCore::IDBObjectStoreProxy::remove):
(WebCore::IDBObjectStoreProxy::createIndex):
(WebCore::IDBObjectStoreProxy::index):
(WebCore::IDBObjectStoreProxy::removeIndex):
(WebCore::IDBObjectStoreProxy::openCursor):
* src/IDBObjectStoreProxy.h:
* src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::update):
(WebKit::WebIDBCursorImpl::continueFunction):
(WebKit::WebIDBCursorImpl::remove):
* src/WebIDBCursorImpl.h:
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit::WebIDBDatabaseImpl::removeObjectStore):
(WebKit::WebIDBDatabaseImpl::setVersion):
(WebKit::WebIDBDatabaseImpl::transaction):
* src/WebIDBDatabaseImpl.h:
* src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::openObjectCursor):
(WebKit::WebIDBIndexImpl::openKeyCursor):
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):
* src/WebIDBIndexImpl.h:
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):
(WebKit::WebIDBObjectStoreImpl::put):
(WebKit::WebIDBObjectStoreImpl::remove):
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::removeIndex):
(WebKit::WebIDBObjectStoreImpl::openCursor):
* src/WebIDBObjectStoreImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 14 Oct 2010 00:36:47 +0000 (00:36 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Incorrect use of alternate content inside the <object> element
https://bugs.webkit.org/show_bug.cgi?id=11803
Our current behavior appears to match Firefox and the spec. Opera
seems to do what the bug reporter requests, but our current behavior
seems more sane.
* fast/forms/fallback-content-submission-expected.txt: Added.
* fast/forms/fallback-content-submission.html: Added.
* fast/parser/object-with-textarea-fallback-expected.txt: Added.
* fast/parser/object-with-textarea-fallback.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
brettw@chromium.org [Thu, 14 Oct 2010 00:32:59 +0000 (00:32 +0000)]
2010-10-13 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Save and restore the GraphicsContext around setting the clip rect for
drawing text.
https://bugs.webkit.org/show_bug.cgi?id=47634
* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::drawText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 14 Oct 2010 00:32:37 +0000 (00:32 +0000)]
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
This patch adds HTTP caching support to libsoup networking backend.
This code will eventually be part of libsoup, but has been temporarily
imported into the WebCore tree for testing purposes. All libsoup code
is located in WebCore/platform/network/soup/cache. The webkit prefix
was added to all the symbols to prevent problems when this lands in
libsoup. Some external API was also added under webkit/ directory and
will be used by library clients to enable HTTP caching.
There are two parts to this imported code, the first one is the code
under WebCore/platform/network/soup/cache/ that contains all the
SoupURILoader code that supports the development of the cache. The
second part is the HTTP cache implementation located in
WebCore/platform/network/soup/cache/webkit/.
* GNUmakefile.am:
* platform/network/soup/cache/soup-directory-input-stream.c: Added.
(webkit_soup_directory_input_stream_parse_info):
(webkit_soup_directory_input_stream_read_next_file):
(webkit_soup_directory_input_stream_read):
(webkit_soup_directory_input_stream_close):
(webkit_soup_directory_input_stream_class_init):
(webkit_soup_directory_input_stream_init):
(webkit_soup_directory_input_stream_new):
* platform/network/soup/cache/soup-directory-input-stream.h: Added.
* platform/network/soup/cache/soup-http-input-stream.c: Added.
(webkit_soup_http_input_stream_finalize):
(webkit_soup_http_input_stream_class_init):
(webkit_soup_http_input_stream_seekable_iface_init):
(webkit_soup_http_input_stream_init):
(webkit_soup_http_input_stream_queue_message):
(webkit_soup_http_input_stream_new):
(webkit_soup_http_input_stream_got_headers):
(webkit_soup_http_input_stream_got_chunk):
(webkit_soup_http_input_stream_finished):
(webkit_soup_http_input_stream_cancelled):
(webkit_soup_http_input_stream_prepare_for_io):
(webkit_soup_http_input_stream_done_io):
(set_error_if_http_failed):
(read_from_leftover):
(webkit_soup_http_input_stream_send_internal):
(send_sync_finished):
(webkit_soup_http_input_stream_send):
(webkit_soup_http_input_stream_read):
(webkit_soup_http_input_stream_close):
(wrapper_callback):
(send_async_thread):
(webkit_soup_http_input_stream_send_async_in_thread):
(send_async_finished):
(webkit_soup_http_input_stream_send_async_internal):
(webkit_soup_http_input_stream_send_async):
(webkit_soup_http_input_stream_send_finish):
(read_async_done):
(webkit_soup_http_input_stream_read_async):
(webkit_soup_http_input_stream_read_finish):
(webkit_soup_http_input_stream_close_async):
(webkit_soup_http_input_stream_close_finish):
(webkit_soup_http_input_stream_tell):
(webkit_soup_http_input_stream_can_seek):
(webkit_soup_http_input_stream_seek):
(webkit_soup_http_input_stream_can_truncate):
(webkit_soup_http_input_stream_truncate):
(webkit_soup_http_input_stream_get_message):
* platform/network/soup/cache/soup-http-input-stream.h: Added.
* platform/network/soup/cache/soup-request-data.c: Added.
(webkit_soup_request_data_init):
(webkit_soup_request_data_finalize):
(webkit_soup_request_data_check_uri):
(uri_decoded_copy):
(webkit_soup_request_data_send):
(webkit_soup_request_data_get_content_length):
(webkit_soup_request_data_get_content_type):
(webkit_soup_request_data_class_init):
* platform/network/soup/cache/soup-request-data.h: Added.
* platform/network/soup/cache/soup-request-file.c: Added.
(webkit_soup_request_file_get_file):
(webkit_soup_request_file_init):
(webkit_soup_request_file_finalize):
(webkit_soup_request_file_check_uri):
(webkit_soup_request_file_ftp_main_loop_quit):
(webkit_soup_request_file_ensure_file_ftp):
(webkit_soup_request_file_ensure_file):
(webkit_soup_request_file_send):
(webkit_soup_request_file_send_async_thread):
(webkit_soup_request_file_send_async):
(webkit_soup_request_file_send_finish):
(webkit_soup_request_file_get_content_length):
(webkit_soup_request_file_get_content_type):
(webkit_soup_request_file_class_init):
* platform/network/soup/cache/soup-request-file.h: Added.
* platform/network/soup/cache/soup-request-http.c: Added.
(webkit_soup_request_http_get_message):
(webkit_soup_request_http_init):
(webkit_soup_request_http_check_uri):
(webkit_soup_request_http_finalize):
(webkit_soup_request_http_send):
(sent_async):
(conditional_get_ready_cb):
(send_async_cb):
(webkit_soup_request_http_send_async):
(webkit_soup_request_http_send_finish):
(webkit_soup_request_http_get_content_length):
(webkit_soup_request_http_get_content_type):
(webkit_soup_request_http_class_init):
* platform/network/soup/cache/soup-request-http.h: Added.
* platform/network/soup/cache/soup-request.c: Added.
(webkit_soup_request_init):
(webkit_soup_request_finalize):
(webkit_soup_request_set_property):
(webkit_soup_request_get_property):
(webkit_soup_request_initable_init):
(webkit_soup_request_default_check_uri):
(webkit_soup_request_default_send_async):
(webkit_soup_request_default_send_finish):
(webkit_soup_request_send):
(webkit_soup_request_send_async):
(webkit_soup_request_send_finish):
(webkit_soup_request_class_init):
(webkit_soup_request_initable_interface_init):
(webkit_soup_request_get_uri):
(webkit_soup_request_get_session):
(webkit_soup_request_get_content_length):
(webkit_soup_request_get_content_type):
* platform/network/soup/cache/soup-request.h: Added.
* platform/network/soup/cache/soup-requester.c: Added.
(webkit_soup_requester_init):
(finalize):
(webkit_soup_requester_class_init):
(init_request_types):
(webkit_soup_requester_new):
(webkit_soup_requester_request):
(webkit_soup_requester_request_uri):
(webkit_soup_scheme_is_valid):
(webkit_soup_requester_add_protocol):
(webkit_soup_requester_remove_protocol):
(webkit_soup_error_quark):
* platform/network/soup/cache/soup-requester.h: Added.
* platform/network/soup/cache/webkit/soup-cache-private.h: Added.
* platform/network/soup/cache/webkit/soup-cache.c: Added.
(get_cacheability):
(webkit_soup_cache_entry_free):
(copy_headers):
(update_headers):
(webkit_soup_cache_entry_get_current_age):
(webkit_soup_cache_entry_is_fresh_enough):
(webkit_soup_message_get_cache_key):
(webkit_soup_cache_entry_set_freshness):
(webkit_soup_cache_entry_new):
(webkit_soup_cache_writing_fixture_free):
(close_ready_cb):
(write_ready_cb):
(msg_got_chunk_cb):
(msg_got_body_cb):
(webkit_soup_cache_entry_delete):
(lru_compare_func):
(cache_accepts_entries_of_size):
(make_room_for_new_entry):
(webkit_soup_cache_entry_insert_by_key):
(msg_restarted_cb):
(append_to_ready_cb):
(msg_got_headers_cb):
(webkit_soup_cache_send_response):
(request_started):
(attach):
(webkit_soup_cache_session_feature_init):
(webkit_soup_cache_init):
(webkit_soup_cache_finalize):
(webkit_soup_cache_set_property):
(webkit_soup_cache_get_property):
(webkit_soup_cache_constructed):
(webkit_soup_cache_type_get_type):
(webkit_soup_cache_class_init):
(webkit_soup_cache_new):
(webkit_soup_cache_has_response):
(webkit_soup_cache_get_cacheability):
(force_flush_timeout):
(webkit_soup_cache_flush):
(remove_cache_item):
(webkit_soup_cache_clear):
(webkit_soup_cache_generate_conditional_request):
(pack_entry):
(webkit_soup_cache_dump):
(webkit_soup_cache_load):
(webkit_soup_cache_set_max_size):
(webkit_soup_cache_get_max_size):
* platform/network/soup/cache/webkit/soup-cache.h: Added.
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
Bump the required version of GLib. The serialization/deserialization
code of libsoup caching code uses GVariant, which was added to GLib in
version 2.24.
* GNUmakefile.am: Add paths for soup HTTP cache code.
* autotools/webkit.m4: Increase required glib version.
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
Add include paths for the new soup HTTP cache code.
* GNUmakefile.am: Add paths for the new soup HTTP cache code.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 14 Oct 2010 00:27:59 +0000 (00:27 +0000)]
Chromium build fix.
* bindings/v8/ScriptProfiler.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cevans@google.com [Thu, 14 Oct 2010 00:21:40 +0000 (00:21 +0000)]
2010-10-13 Chris Evans <cevans@google.com>
Reviewed by Jian Li.
Blob / BlobBuilder can be put into bad state with wild integers and strings, due to integer overflows
https://bugs.webkit.org/show_bug.cgi?id=47382
Add test for Blob.slice() integer overflow.
* fast/files/blob-slice-overflow.html: Added.
* fast/files/blob-slice-overflow-expected.txt: Added.
2010-10-13 Chris Evans <cevans@google.com>
Reviewed by Jian Li.
Blob / BlobBuilder can be put into bad state with wild integers and strings, due to integer overflows
https://bugs.webkit.org/show_bug.cgi?id=47382
Fix integer overflow errors in Blob.slice and BlobBuilder.append.
Test: fast/files/blob-slice-overflow.html
* fileapi/Blob.cpp:
(WebCore::Blob::slice): handle integer overflow properly.
* fileapi/BlobBuilder.cpp:
(WebCore::BlobBuilder::append): use correct type for vector length.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 14 Oct 2010 00:16:01 +0000 (00:16 +0000)]
Build fix - remove some redundant references to ScriptString.
* WebCore.gypi:
* WebCore.pro:
* bindings/v8/ScriptProfiler.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 23:58:00 +0000 (23:58 +0000)]
2010-10-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser shows two Url input fields
https://bugs.webkit.org/show_bug.cgi?id=47613
* QtTestBrowser/mainwindow.cpp:
(MainWindow::MainWindow):
(MainWindow::buildUI):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 23:42:55 +0000 (23:42 +0000)]
2010-10-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tony Chang.
[gdb] Add pretty-print supports for UString, Identifier and JSString
https://bugs.webkit.org/show_bug.cgi?id=47601
* gdb/webkit.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 13 Oct 2010 23:34:49 +0000 (23:34 +0000)]
Bug 47621 - Remove bindings/v8/ScriptString
This is now redundant.
Reviewed by Oliver Hunt.
* bindings/v8/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::functionName):
* bindings/v8/ScriptFunctionCall.cpp:
* bindings/v8/ScriptFunctionCall.h:
* bindings/v8/ScriptString.h: Removed.
* bindings/v8/ScriptStringImpl.cpp: Removed.
* bindings/v8/ScriptStringImpl.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 13 Oct 2010 23:12:21 +0000 (23:12 +0000)]
Draw the find overlay holes
https://bugs.webkit.org/show_bug.cgi?id=47631
Reviewed by John Sullivan.
WebCore:
Export symbols needed by WebKit2.
* WebCore.exp.in:
WebKit2:
* WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::drawRect):
Draw the white frames and the holes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 23:10:56 +0000 (23:10 +0000)]
2010-10-13 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Adler.
Implement onreadystatechange event handler for Documents
https://bugs.webkit.org/show_bug.cgi?id=26140
* fast/dom/Document/readystate-expected.txt:
* fast/dom/Document/readystate.html:
2010-10-13 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Adler.
Implement onreadystatechange event handler for Documents
https://bugs.webkit.org/show_bug.cgi?id=26140
Test: fast/dom/Document/readystate.html
* dom/Document.cpp:
(WebCore::Document::setReadyState): Fire readystatechangeevent.
(WebCore::Document::open): Clear event listeners.
* dom/Document.h: Add readystatechange event.
* dom/Document.idl: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 13 Oct 2010 23:07:21 +0000 (23:07 +0000)]
No review. Fix layout test, now that behavior is correct.
AX: accessibilityIsIgnored not respected on ARIA tables
https://bugs.webkit.org/show_bug.cgi?id=47564
* accessibility/aria-hidden-with-elements-expected.txt:
* accessibility/aria-hidden-with-elements.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 23:03:33 +0000 (23:03 +0000)]
Mark these scripts executable
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 13 Oct 2010 22:53:32 +0000 (22:53 +0000)]
AX: accessibilityIsIgnored not respected on ARIA tables
https://bugs.webkit.org/show_bug.cgi?id=47564
Reviewed by Beth Dakin.
WebCore:
For platforms that ignore column headers and header container objects (everything
except Mac) on accessibility tables, that choice needs to be respected in
ARIA tables as well.
GTK is the only open platform doing this, so I'll have to collect the result of this
test. It was copied from table-hierarchy.html, but changed to use ARIA tables.
Test: platform/gtk/accessibility/aria-table-hierarchy.html
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChildren):
LayoutTests:
Will gather the results from GTK after this runs.
* platform/gtk/accessibility/aria-table-hierarchy.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Wed, 13 Oct 2010 22:50:32 +0000 (22:50 +0000)]
No longer ASSERT for LayerRenderer in VideoLayerChromium destructor
https://bugs.webkit.org/show_bug.cgi?id=47432
Patch by Victoria Kirst <vrk@google.com> on 2010-10-13
Reviewed by James Robinson.
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::cleanupResources):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 13 Oct 2010 22:48:37 +0000 (22:48 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add list of Ubuntu packages needed by the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47628
I've been copy/pasting this list between bots, but it's better to have
this checked in.
* EWSTools/ubuntu-ews-packages: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Wed, 13 Oct 2010 22:46:36 +0000 (22:46 +0000)]
2010-10-13 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Build fix.
* WebCoreSupport/FrameLoaderClientEfl.h: Use String instead of
WebCore::String.
2010-10-13 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Build fix.
* CMakeLists.txt: Add ContextShadow.cpp.
* CMakeListsEfl.txt: Add ContextShadowCairo.cpp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 22:39:16 +0000 (22:39 +0000)]
2010-10-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Csaba Osztrogonác.
[EFL] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=47290
* BuildSlaveSupport/build.webkit.org-config/config.json: Add an
entry for a release build of the EFL port.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
flag to build the EFL port.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Wed, 13 Oct 2010 22:25:41 +0000 (22:25 +0000)]
2010-10-13 Zhenyao Mo <zmo@google.com>
Unreviewed, update WebGL test expectations.
* platform/chromium/drt_expectations.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 13 Oct 2010 22:24:58 +0000 (22:24 +0000)]
2010-10-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] r69681 caused some tests to crash
https://bugs.webkit.org/show_bug.cgi?id=47622
Properly initialize m_layerContext on the ContextShadow so that in situations
where beginShadowLayer bails out early with a null return value, it is set
to null. This may happen when the first call to beginShadowLayer on a particular
ContextShadow uses a region which is entirely outside the clip region or which
is empty.
* platform/graphics/cairo/ContextShadow.cpp:
(WebCore::ContextShadow::ContextShadow): Properly initialize m_layerContext.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 13 Oct 2010 21:44:08 +0000 (21:44 +0000)]
Don't set the fill/stroke colorspace before filling/stroking
https://bugs.webkit.org/show_bug.cgi?id=47619
Reviewed by Beth Dakin.
Setting the colorspace has the side-effect of setting the color to black, which is
not what we want. When fill/stroke is called, a fill/stroke color should already have been set.
Pixel tests show no regressions from this change.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 13 Oct 2010 21:29:17 +0000 (21:29 +0000)]
Unreviewed WinCairo build fix.
New ContextShadow class not built for Windows builds.
* WebCore.vcproj/WebCore.vcproj: Add missing files for
building ContextShadow on WinCairo.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
Add missing include for ContextShadow definition.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Wed, 13 Oct 2010 21:19:08 +0000 (21:19 +0000)]
2010-10-13 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium expectations update.
Fix line endings in a couple of inspector test expectations.
* platform/chromium/inspector/console-trace-in-eval-expected.txt:
* platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 13 Oct 2010 20:51:08 +0000 (20:51 +0000)]
Chromium build fix pt1.
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 13 Oct 2010 20:40:57 +0000 (20:40 +0000)]
Use WKSI to get wheel event deltas
https://bugs.webkit.org/show_bug.cgi?id=47617
Reviewed by Darin Adler.
* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent):
Call WKGetWheelEventDeltas.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:]):
Call InitWebCoreSystemInterface.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Use dispatch_once.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Wed, 13 Oct 2010 20:29:40 +0000 (20:29 +0000)]
2010-10-13 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Revert changes to WebViewImpl in r69633
https://bugs.webkit.org/show_bug.cgi?id=47610
Revert change to WebViewImpl.cpp in
http://trac.webkit.org/changeset/69633 which incorrectly used
PassRefPtr for a local variable instead of RefPtr. This was a fix
for changes in http://trac.webkit.org/changeset/69619 and
http://trac.webkit.org/changeset/69624 .
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 13 Oct 2010 20:28:23 +0000 (20:28 +0000)]
Fix the Cairo build
* Shared/cairo/BackingStoreCairo.cpp: Added.
(WebKit::BackingStore::createGraphicsContext):
(WebKit::BackingStore::paint):
Stubbed out.
* win/WebKit2.vcproj: Build BackingStoreCG.cpp in CG builds and
BackingStoreCairo.cpp in Cairo builds.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 13 Oct 2010 20:24:19 +0000 (20:24 +0000)]
Build fix.
* Shared/cg/BackingStoreCG.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 13 Oct 2010 20:20:26 +0000 (20:20 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 13 Oct 2010 20:18:09 +0000 (20:18 +0000)]
Send over find indicator information to the UI process
https://bugs.webkit.org/show_bug.cgi?id=47612
Reviewed by Sam Weinig.
WebCore:
Export symbols needed by WebKit2.
* WebCore.exp.in:
WebKit2:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
Add stub.
* UIProcess/WebPageProxy.messages.in:
Add SetFindIndicator.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::FindController):
Initialize m_isShowingFindIndicator.
(WebKit::FindController::findString):
Update the find indicator if needed.
(WebKit::FindController::updateFindIndicator):
Compute find indicator information, paint the find indicator text into a
backing store and send it over.
(WebKit::FindController::resetFindIndicator):
Send a SetFindIndicator message with a null backing store.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 13 Oct 2010 20:10:37 +0000 (20:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=43987
Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
to construct their internal result string. Remove ScriptString (this is now
redundant).
Reviewed by Oliver Hunt.
WebCore:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::jsOwnedStringOrNull):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::responseText):
* bindings/js/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
* bindings/js/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::functionName):
* bindings/js/ScriptCallStack.h:
* bindings/js/ScriptFunctionCall.cpp:
* bindings/js/ScriptFunctionCall.h:
* bindings/js/ScriptString.h: Removed.
* dom/ScriptExecutionContext.h:
* fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::abort):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::result):
(WebCore::FileReader::convertToText):
(WebCore::FileReader::convertToDataURL):
* fileapi/FileReader.h:
* fileapi/FileReaderSync.cpp:
(WebCore::FileReaderSyncLoader::FileReaderSyncLoader):
(WebCore::FileReaderSyncLoader::didReceiveData):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
(WebCore::FileReaderSync::read):
(WebCore::FileReaderSync::convertToText):
* fileapi/FileReaderSync.h:
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::FileReaderSync):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorController::scriptImported):
* inspector/InspectorController.h:
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::setOverrideContent):
* inspector/InspectorResource.h:
* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoadNotifier.h:
* workers/WorkerScriptLoader.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::responseText):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::dropProtection):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/XMLHttpRequest.h:
WebKit/efl:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidLoadResourceByXMLHttpRequest):
* WebCoreSupport/FrameLoaderClientEfl.h:
WebKit/mac:
* WebCoreSupport/WebFrameLoaderClient.mm:
WebKit/qt:
* WebCoreSupport/FrameLoaderClientQt.cpp:
WebKit/win:
* WebCoreSupport/WebFrameLoaderClient.cpp:
WebKit/wx:
* WebKitSupport/FrameLoaderClientWx.cpp:
WebKit2:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 13 Oct 2010 20:04:26 +0000 (20:04 +0000)]
Add BackingStoreQt.cpp file with stubbed out BackingStore member functions
https://bugs.webkit.org/show_bug.cgi?id=47614
Reviewed by Sam Weinig.
* Shared/BackingStore.h:
Remove unused include.
* Shared/qt/BackingStoreQt.cpp: Added.
(WebKit::BackingStore::createGraphicsContext):
(WebKit::BackingStore::paint):
* WebKit2.pro:
Add BackingStore.cpp, BackingStore.h and BackingStoreQt.cpp
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 13 Oct 2010 20:01:44 +0000 (20:01 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[WTFURL] Add URLQueryCanonicalizer
https://bugs.webkit.org/show_bug.cgi?id=45088
This class canonicalizes the query component of URLs. The main tricky
bit there is the convertCharset function, which I've moved to a
templated dependency. There'll likely be more about that in future
patches.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/url/src/URLEscape.cpp: Added.
* wtf/url/src/URLEscape.h: Added.
(WTF::appendEscapedCharacter):
* wtf/url/src/URLQueryCanonicalizer.h: Added.
(WTF::URLQueryCanonicalizer::canonicalize):
(WTF::URLQueryCanonicalizer::isAllASCII):
(WTF::URLQueryCanonicalizer::appendRaw8BitQueryString):
(WTF::URLQueryCanonicalizer::convertToQueryEncoding):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 13 Oct 2010 19:54:11 +0000 (19:54 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Csaba Osztrogonác.
webkit-patch build shouldn't need --build to actually build!
https://bugs.webkit.org/show_bug.cgi?id=47438
Yeah, requiring --build for the build command is really dumb. We did
this originally because the build step is usually optional in other
commands. We don't have a good way of reversing the default for an
option in one command. This approach is slightly hacky since --build
still shows up as an option on the help page, but at least it makes
progress. Passing --build is harmless, so the EWS bots shouldn't
explode because of this change.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Wed, 13 Oct 2010 19:38:02 +0000 (19:38 +0000)]
2010-10-13 Robert Hogan <robert@webkit.org>
Rubber-stamped by Csaba Osztrogonac.
[Qt] editing/execCommand/move-selection-back-line.html fails in DRT
Unskip test that now passes.
https://bugs.webkit.org/show_bug.cgi?id=35921
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 13 Oct 2010 19:29:14 +0000 (19:29 +0000)]
JavaScriptCore: Bug 43987 - Downloading using XHR is much slower than before
Change StringBuilder to use overcapacity in a StringImpl, rather than a Vector.
Fundamentally this should be the same (copies current contents to expand capacity,
rather than using a rope), but this approach allows the intermadiate state of the
String to be inspected in the buffer without copying to resolve.
Reviewed by Oliver Hunt.
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendQuotedString):
(JSC::Stringifier::Holder::appendNextProperty):
Renamed StringBuilder::size() -> length() (to match other String types).
* runtime/UStringBuilder.h:
(JSC::UStringBuilder::append):
(JSC::UStringBuilder::toUString):
Update for changes in parent class, can just 'using' the append methods.
* wtf/text/StringBuilder.cpp: Added.
(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::length):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::clear):
Class updated to use overcapacity in a StringImpl, rather than a Vector.
* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/wtf.pri:
WebCore: Bug 43987 - Downloading using XHR is much slower than before
Reviewed by Oliver Hunt.
* svg/SVGPathStringBuilder.cpp:
(WebCore::SVGPathStringBuilder::result):
StringBuilder::size() -> StringBuilder::length().
WebKit/chromium: Bug 43987 - Downloading using XHR is much slower than before
Reviewed by Oliver Hunt.
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 19:21:48 +0000 (19:21 +0000)]
2010-10-13 Yong Li <yoli@rim.com>
Reviewed by Oliver Hunt.
Fix potential misaligned memory access in CloneDeserializer::readLittleEndian and readString
that can result crash on ARM (<v6).
https://bugs.webkit.org/show_bug.cgi?id=47594
No new test added, because the crash can be produced by existing tests like:
LayoutTests/fast/events/message-channel-gc-4.html
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 13 Oct 2010 19:18:10 +0000 (19:18 +0000)]
2010-09-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Activate ContextShadow in all places where shadows are drawn
https://bugs.webkit.org/show_bug.cgi?id=46475
Rebaselined tests. All these changes seem reasonable. In some cases, the
new results are much better / closer matches to Chromium.
* platform/gtk/fast/box-shadow/basic-shadows-expected.checksum:
* platform/gtk/fast/box-shadow/basic-shadows-expected.png:
* platform/gtk/fast/box-shadow/inset-expected.checksum:
* platform/gtk/fast/box-shadow/inset-expected.png:
* platform/gtk/fast/css/shadow-multiple-expected.checksum:
* platform/gtk/fast/css/shadow-multiple-expected.png:
* platform/gtk/fast/text/shadow-no-blur-expected.checksum:
* platform/gtk/fast/text/shadow-no-blur-expected.png:
* platform/gtk/fast/text/shadow-translucent-fill-expected.checksum:
* platform/gtk/fast/text/shadow-translucent-fill-expected.png:
* platform/gtk/fast/text/stroking-decorations-expected.checksum:
* platform/gtk/fast/text/stroking-decorations-expected.png:
* platform/gtk/fast/text/stroking-expected.checksum:
* platform/gtk/fast/text/stroking-expected.png:
* platform/gtk/fast/transforms/shadows-expected.checksum:
* platform/gtk/fast/transforms/shadows-expected.png:
* platform/gtk/svg/css/arrow-with-shadow-expected.checksum:
* platform/gtk/svg/css/arrow-with-shadow-expected.png:
* platform/gtk/svg/css/composite-shadow-text-expected.checksum:
* platform/gtk/svg/css/composite-shadow-text-expected.png:
* platform/gtk/svg/css/group-with-shadow-expected.checksum:
* platform/gtk/svg/css/group-with-shadow-expected.png:
* platform/gtk/svg/css/path-with-shadow-expected.checksum:
* platform/gtk/svg/css/path-with-shadow-expected.png:
* platform/gtk/svg/css/shadow-with-large-radius-expected.checksum:
* platform/gtk/svg/css/shadow-with-large-radius-expected.png:
* platform/gtk/svg/css/shadow-with-negative-offset-expected.checksum:
* platform/gtk/svg/css/shadow-with-negative-offset-expected.png:
2010-10-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Activate ContextShadow in all places where shadows are drawn
https://bugs.webkit.org/show_bug.cgi?id=46475
Turn on ContextShadow for the Cairo port and remove all old shadow code.
Shadow tiling optimizations will be added in a followup patch to ContextShadowCairo.
* platform/graphics/GraphicsContext.h: Add a ContextShadow forward declaration for Cairo.
* platform/graphics/cairo/FontCairo.cpp: Switch to using ContextShadow.
(WebCore::prepareContextForGlyphDrawing): Added this helper which sets up the translation
on the specified cairo_t to prepare for drawing glyphs.
(WebCore::drawGlyphsToContext): Added this helper which draws the glyphs to a cairo_t,
while properly handling glyphs with synthetic bold.
(WebCore::Font::drawGlyphs): Removed old shadow code and replaced it with ContextShadow usage.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow): Modified this to use ContextShadow and to take an enum
argument specifying whether to fill or stroke the solid figure for the shadow.
(WebCore::fillCurrentCairoPath): Updated drawPathShadow call.
(WebCore::strokeCurrentCairoPath): Ditto.
(WebCore::GraphicsContext::savePlatformState): Save the ContextShadow.
(WebCore::GraphicsContext::restorePlatformState): Restore the ContextShadow.
(WebCore::GraphicsContext::drawPath): Updated drawPathShadow call.
(WebCore::GraphicsContext::fillRect): Uses ContextShadow now.
(WebCore::GraphicsContext::setPlatformShadow): Uses ContextShadow now.
(WebCore::GraphicsContext::contextShadow): Added.
(WebCore::GraphicsContext::clearPlatformShadow): Clears the ContextShadow member.
(WebCore::GraphicsContext::fillRoundedRect): Updated drawPathShadow call.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::hasShadow): Added.
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw): Updated to use ContextShadow.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 13 Oct 2010 19:15:44 +0000 (19:15 +0000)]
Unreviewed build fixes after r69538.
* UIProcess/WebBackForwardList.h: Add missing include directive
for CoreFoundation.
* UIProcess/cf/WebBackForwardListCF.cpp: Add missing include
directives for RetainPtr.h and CoreFoundation.
* UIProcess/cf/WebPageProxyCF.cpp: Add missing include directive
for RetainPtr.h.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Wed, 13 Oct 2010 18:50:17 +0000 (18:50 +0000)]
2010-10-13 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium test fix.
Move a couple of platform-specific results that were added to the wrong directory.
* platform/chromium/console-trace-in-eval-expected.txt: Removed.
* platform/chromium/console-uncaught-exception-in-eval-expected.txt: Removed.
* platform/chromium/inspector/console-trace-in-eval-expected.txt: Copied from LayoutTests/platform/chromium/console-trace-in-eval-expected.txt.
* platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt: Copied from LayoutTests/platform/chromium/console-uncaught-exception-in-eval-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 13 Oct 2010 18:49:38 +0000 (18:49 +0000)]
Start compiling BackingStore on Windows
Rubber-stamped by Anders Carlsson.
JavaScriptCore:
Export tryFastRealloc for WebKit2's benefit
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added
tryFastRealloc. Removed RegExpObject::info, which is now exported via
JS_EXPORTDATA.
WebKit2:
* win/WebKit2.vcproj: Added BackingStore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 13 Oct 2010 18:49:14 +0000 (18:49 +0000)]
Rename BackingStoreMac.mm to BackingStoreCG.cpp
There's nothing Mac-specific about this file.
Rubber-stamped by Anders Carlsson.
* Shared/cg/BackingStoreCG.cpp: Renamed from WebKit2/Shared/mac/BackingStoreMac.mm.
* WebKit2.xcodeproj/project.pbxproj: Updated for rename.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 13 Oct 2010 18:31:23 +0000 (18:31 +0000)]
2010-10-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69667.
http://trac.webkit.org/changeset/69667
https://bugs.webkit.org/show_bug.cgi?id=47598
"Most of the tests seem to fail in the bots for some reason"
(Requested by xan_ on #webkit).
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 13 Oct 2010 18:12:42 +0000 (18:12 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Tony Chang.
[Chromium] Clean up WebPageSerializerImpl::serialize
https://bugs.webkit.org/show_bug.cgi?id=47577
This patch shouldn't have any behavior change. I'm just trying to
understand what this code does.
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer):
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
(WebKit::WebPageSerializerImpl::serialize):
* src/WebPageSerializerImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 18:10:35 +0000 (18:10 +0000)]
2010-10-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69638.
http://trac.webkit.org/changeset/69638
https://bugs.webkit.org/show_bug.cgi?id=47595
"Broke win and chromium-win bots" (Requested by dglazkov on
#webkit).
* Scripts/webkitpy/common/system/path.py:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 18:01:39 +0000 (18:01 +0000)]
2010-10-13 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
https://bugs.webkit.org/show_bug.cgi?id=47586
* WebCore.gyp/WebCore.gyp:
* platform/chromium/ChromiumBridge.h:
* platform/chromium/GeolocationServiceChromium.cpp:
2010-10-13 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
https://bugs.webkit.org/show_bug.cgi?id=47586
* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
(WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
* src/ChromiumBridge.cpp:
* src/WebGeolocationServiceMock.cpp:
(WebKit::WebGeolocationServiceMock::createWebGeolocationServiceMock):
(WebKit::WebGeolocationServiceMock::setMockGeolocationPermission):
(WebKit::WebGeolocationServiceMock::setMockGeolocationPosition):
(WebKit::WebGeolocationServiceMock::setMockGeolocationError):
2010-10-13 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
https://bugs.webkit.org/show_bug.cgi?id=47586
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 13 Oct 2010 18:01:11 +0000 (18:01 +0000)]
Allow all signals to be delivered to the web process
https://bugs.webkit.org/show_bug.cgi?id=47602
<rdar://problem/
8546399>
Reviewed by Sam Weinig.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 13 Oct 2010 17:40:59 +0000 (17:40 +0000)]
Let WebCore handle scrolling when the spacebar is pressed on Windows
WebCore already has code to do this, and WebKit2 was doing it on
keydown instead of keypress, which caused problems with text fields.
WebCore's spacebar-handling code is currently compiled out on Mac and
Qt, so we continue to handle spacebar in WebKit2 on those platforms.
Fixes <http://webkit.org/b/47544> <rdar://problem/
8540645> REGRESSION:
Pressing spacebar in a text field in WebKit2 does not insert a space,
scrolls the page instead
Test: WebKit2/SpacebarScrolling
Reviewed by Sam Weinig.
WebKit2:
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
Removed handling for spacebar presses. WebCore already does this for
us, and does it better.
WebKitTools:
Test that pressing the spacebar in a text field does not scroll the
document
* TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
* TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/copy-resources.cmd:
Added new files.
* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
We use this to track what the result of calling into JavaScript was.
(TestWebKitAPI::didFinishLoadForFrame): Records when the page
finishes loading.
(TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
event is not handled.
(TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
executing and whether the result matched our expectation.
(TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
(TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
complete, and returns whether we got back the expected result.
(TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
spacebar inside a text field does not scroll the document and that
pressing it outside the text field does scroll the document.
* TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::isKeyDown): Checks the event's type.
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
code from DRT's EventSendingController.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::isKeyDown): Checks the message's type.
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
same messages that get sent when you press spacebar in Notepad.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Wed, 13 Oct 2010 17:26:50 +0000 (17:26 +0000)]
2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531
Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/
3729003/
* public/WebIDBFactory.h:
(WebKit::WebIDBFactory::open):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 13 Oct 2010 17:21:07 +0000 (17:21 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[WTFURL] Add a mechanism for classifying types of characters
https://bugs.webkit.org/show_bug.cgi?id=45085
Various characters have different escaping rules depending on where
they are in URLs. This patch adds a table containing that information.
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/url/src/URLCharacterTypes.cpp: Added.
* wtf/url/src/URLCharacterTypes.h: Added.
(WTF::URLCharacterTypes::isQueryChar):
(WTF::URLCharacterTypes::isIPv4Char):
(WTF::URLCharacterTypes::isHexChar):
(WTF::URLCharacterTypes::isCharOfType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 13 Oct 2010 16:40:21 +0000 (16:40 +0000)]
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[Chromium] Clean up SerializeDomParam
https://bugs.webkit.org/show_bug.cgi?id=47580
This patch just renames a bunch of the members of this struct to be
more sensible. No behavior change, well, except for one struct member
that wasn't initialized. I didn't trace through this code to see if
the uninitialized value was used anywhere, but initializing all the
values seems like a good idea.
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam):
(WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
(WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag):
(WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag):
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
(WebKit::WebPageSerializerImpl::openTagToString):
(WebKit::WebPageSerializerImpl::endTagToString):
(WebKit::WebPageSerializerImpl::buildContentForNode):
* src/WebPageSerializerImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 13 Oct 2010 15:53:48 +0000 (15:53 +0000)]
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Unskip some fast/js tests that seem to be working now.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 13 Oct 2010 15:44:53 +0000 (15:44 +0000)]
Unreviewed fix
Need to check for the existence of DeviceOrientation and DeviceMotion controllers
These features can be disabled at run time, so an enable guard is not sufficient.
This bug was introduced in http://trac.webkit.org/changeset/69646
Tested with existing tests.
* history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 13 Oct 2010 15:39:37 +0000 (15:39 +0000)]
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Csaba Osztrogonác.
Missing parameters for bytecode dump of next_pname
https://bugs.webkit.org/show_bug.cgi?id=47590
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump): add missing parameters to the dump.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 13 Oct 2010 15:24:05 +0000 (15:24 +0000)]
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update test expectation.
* inspector/console-trace-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 13 Oct 2010 14:44:14 +0000 (14:44 +0000)]
2010-10-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add wtf/text/StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47584
Move runtime/StringConcatenate.h to wtf/text, make it work for Strings too.
Add a special runtime/UStringConcatenate.h class that inherits from StringConcatenate, and extends it for use with UString.
Exactly the same design that has been followed while refactoring StringBuilder.
The UString variants can all be removed as soon as WTF::String & JSC::UString converge.
* GNUmakefile.am: Add wtf/text/StringConcatenate.h and runtime/UStringConcatenate.h.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* bytecode/CodeBlock.cpp: s/makeString/makeUString/
(JSC::escapeQuotes):
(JSC::valueToSourceString):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):
* bytecompiler/NodesCodegen.cpp: Ditto.
(JSC::substitute):
* profiler/Profiler.cpp: Ditto.
(JSC::Profiler::createCallIdentifier):
* runtime/ExceptionHelpers.cpp: Ditto.
(JSC::createUndefinedVariableError):
(JSC::createErrorMessage):
(JSC::createInvalidParamError):
* runtime/FunctionConstructor.cpp: Ditto.
(JSC::constructFunction):
* runtime/FunctionPrototype.cpp: Ditto.
(JSC::insertSemicolonIfNeeded):
* runtime/JSONObject.cpp: Ditto.
(JSC::Stringifier::indent):
* runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
* runtime/RegExpConstructor.cpp: Ditto.
(JSC::constructRegExp):
* runtime/RegExpObject.cpp: Ditto.
(JSC::RegExpObject::match):
* runtime/RegExpPrototype.cpp: Ditto.
(JSC::regExpProtoFuncCompile):
* runtime/StringConcatenate.h: Removed.
* runtime/UStringConcatenate.h: Added. Only contains the StringTypeAdapter<JSC::UString> code and the makeUString variants, the rest lives in wtf/text/StringConcatenate.h
(JSC::makeUString):
* wtf/text/StringConcatenate.h: Copied from runtime/StringConcatenate.h.
(WTF::makeString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 13 Oct 2010 14:43:36 +0000 (14:43 +0000)]
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: stack information is inconsistent between console.trace and runtime errors.
https://bugs.webkit.org/show_bug.cgi?id=47252
* console.trace() is now formatted the same way as other stack traces
* If there is //@ sourceURL=url line at the end of eval'ed script source
the url will be shown in the stack traces for script. That is why ScriptCallFrame::sourceURL
type has changed from KURL to String.
Tests: inspector/console-trace-in-eval.html
inspector/console-uncaught-exception-in-eval.html
* bindings/js/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
* bindings/js/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::sourceURL):
* bindings/v8/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
* bindings/v8/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::sourceURL):
* bindings/v8/ScriptCallStack.cpp:
(WebCore::getFrameLocation):
(WebCore::ScriptCallStack::create):
* bindings/v8/ScriptCallStack.h:
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::traceCallback):
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::CallFrame::buildInspectorObject):
(WebCore::ConsoleMessage::ConsoleMessage):
* inspector/ConsoleMessage.h:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._formatMessage):
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::timeEnd):
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: stack information is inconsistent between console.trace and runtime errors.
https://bugs.webkit.org/show_bug.cgi?id=47252
* inspector/console-trace-in-eval-expected.txt: Added.
* inspector/console-trace-in-eval.html: Added.
* inspector/console-uncaught-exception-in-eval-expected.txt: Added.
* inspector/console-uncaught-exception-in-eval.html: Added.
* platform/chromium/console-trace-in-eval-expected.txt: Added.
* platform/chromium/console-uncaught-exception-in-eval-expected.txt: Added.
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: stack information is inconsistent between console.trace and runtime errors.
https://bugs.webkit.org/show_bug.cgi?id=47252
* DEPS: bump up V8 revision
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Wed, 13 Oct 2010 14:42:35 +0000 (14:42 +0000)]
Add ability for WK2 to set domain relaxation forbidden for a URL scheme.
https://bugs.webkit.org/show_bug.cgi?id=47562
Reviewed by Jon Honeycutt.
Add the schemes for which domain relaxation is forbidden to the
WebProcessCreationParameters.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetDomainRelaxationForbiddenForURLScheme):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
Copy over the schemes for which domain relaxation is forbidden to
WebProcessCreationParameters.
(WebKit::WebContext::setDomainRelaxationForbiddenForURLScheme):
Only send a message to the WebProcess if it is valid.
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Set domain relaxation forbidden for the schemes in
WebProcesCreationParameters.urlSchemesForWhichDomainRelaxationIsForbidden.
(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Add the SetDomainRelaxationFobiddenForURLScheme message.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 13 Oct 2010 14:37:40 +0000 (14:37 +0000)]
2010-10-13 Kent Tamura <tkent@chromium.org>
Unreviewed, a trivial change.
Run sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 13 Oct 2010 14:34:36 +0000 (14:34 +0000)]
Fix a couple of issues with the TestWebKitAPI build
* TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
* TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
Fixed a typo.
* TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
to set our output and intermediate directories so that we don't spew
files into the source tree.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 13 Oct 2010 14:08:20 +0000 (14:08 +0000)]
Unreviewed.
* platform/qt/Skipped: Reskip fast/events/spatial-navigation/snav-clipped-overflowed-content.html again, because it still fails.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Wed, 13 Oct 2010 14:07:06 +0000 (14:07 +0000)]
2010-10-13 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
WTR should accept relative paths
https://bugs.webkit.org/show_bug.cgi?id=47486
* WebKitTestRunner/StringFunctions.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL): Moved from StringFunctions.h since it is
used only here. Extend relative paths to absolute.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 13 Oct 2010 13:58:47 +0000 (13:58 +0000)]
Make TestWebKitAPI work on Windows
Fixes <http://webkit.org/b/47552> <rdar://problem/
8541708>.
Reviewed by Sam Weinig.
WebKit/win:
Build TestWebKitAPI on Windows
* WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
TestWebKitAPIGenerated and made them build just after
WebKitTestRunner.
WebKitTools:
* Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
* Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
run on Windows.
(runTest): Added code to run TestWebKitAPI.exe on Windows and to die
on unsupported platforms.
(populateTests): Added code to run TestWebKitAPI.exe on Windows and to
die on other platforms. Extracted some formerly-Mac-specific code to
be cross-platform and made it handle any style of line-endings.
* TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
Links against CFLite.
* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
Contains most properties for the project.
* TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
Added. Links against CoreFoundation.
* TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
section and moved the cross-platform section after the
platform-specific parts.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
(TestWebKitAPI::Util::run): Runs a normal message pump until we're
done.
(TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
(TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
resource path.
(TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
WKURL.
* TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
(TestWebKitAPI::registerWindowClass):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
This was mostly copied from WebKitTestRunner's PlatformWebView.
* TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
build-api-tests script.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
TestWebKitAPI.exe.
* TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
through to copy-resources.cmd.
* TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
or deletes resources from TestWebKitAPI.resources.
* TestWebKitAPI/win/main.cpp: Added.
(main): Calls through to TestsController.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 13 Oct 2010 13:46:37 +0000 (13:46 +0000)]
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Remove more warnings from the g-i scanner run
https://bugs.webkit.org/show_bug.cgi?id=47255
Fixes almost all warnings coming from the g-i scanner.
* GNUmakefile.am: Add missing files and include dirs to the
scanner run.
WebKit/gtk:
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Remove more warnings from the g-i scanner run
https://bugs.webkit.org/show_bug.cgi?id=47255
Fixes almost all warnings coming from the g-i scanner.
* webkit/webkitsecurityorigin.cpp: Rename parameter names in
gtk-doc blurb to the actual name of the parameter.
* webkit/webkitsoupauthdialog.c: ditto.
(webkit_soup_auth_dialog_class_init): Write missing doc for the
'current-toplevel' signal.
* webkit/webkitsoupauthdialog.h: Rename signal parameter to its
actual name.
* webkit/webkitwebdatabase.cpp: Rename parameter names in
gtk-doc blurb to the actual name of the parameter.
* webkit/webkitwebinspector.cpp: ditto.
(webkit_web_inspector_class_init): ditto.
* webkit/webkitwebview.cpp: ditto.
(webkit_web_view_class_init): ditto.
* webkit/webkitwebview.h: Rename the parameter names to be in sync
with the ones we use in the function definition.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Wed, 13 Oct 2010 13:32:44 +0000 (13:32 +0000)]
2010-10-13 Antonio Gomes <agomes@rim.com>
Unreviewed clean up of Spatial Navigation tests listed in Mac, Gtk and Qt's Skipped files.
* platform/qt/Skipped: Unskip fast/events/spatial-navigation/snav-clipped-overflowed-content.html
* platform/gtk/Skipped: Added reference to the respective bug # for the skipped spatial navigation tests.
* platform/mac/Skipped: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 13 Oct 2010 13:09:29 +0000 (13:09 +0000)]
2010-10-13 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Simplify code generation in WebKit2/DerivedSources.pro
https://bugs.webkit.org/show_bug.cgi?id=47543
* DerivedSources.pro: General generator rules added instead of copy/paste code to converge Makefile.DerivedSources.
* WebKit2.pro: PluginProcess' headers and sources added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 13 Oct 2010 12:49:52 +0000 (12:49 +0000)]
2010-10-13 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, build fix.
Bring back the storage/change-version.html CRASH expectation (still crashes on the main waterfall).
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 13 Oct 2010 12:27:51 +0000 (12:27 +0000)]
2010-10-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
Wrong ASSERT when select element has size 0
https://bugs.webkit.org/show_bug.cgi?id=47567
* fast/dom/HTMLSelectElement/click-size-zero-no-crash-expected.txt: Added.
* fast/dom/HTMLSelectElement/click-size-zero-no-crash.html: Added.
2010-10-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
Wrong ASSERT when select element has size 0
https://bugs.webkit.org/show_bug.cgi?id=47567
Keep the ASSERT only if the size of the element list is more than 0
Test: fast/dom/HTMLSelectElement/click-size-zero-no-crash.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::updateListBoxSelection):
(WebCore::SelectElement::listBoxDefaultEventHandler):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 12:14:58 +0000 (12:14 +0000)]
2010-10-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Support viewport configuration and add new arguments for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=47084
Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
needs to be modified according to the changes.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::dispatchViewportDataDidChange):
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(_ewk_view_viewport_attributes_compute):
(ewk_view_viewport_attributes_set):
(ewk_view_viewport_attributes_get):
(ewk_view_device_pixel_ratio_get):
* ewk/ewk_view.h:
2010-10-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Support viewport configuration and add new arguments for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=47084
Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
needs to be modified according to the changes.
* EWebLauncher/main.c:
(on_viewport_changed):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 13 Oct 2010 12:05:01 +0000 (12:05 +0000)]
2010-10-13 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use flag instead of magic word to mark memory map free/used
Original patch by Antti Koivisto.
* Shared/qt/MappedMemory.h:
(WebKit::MappedMemory::mapSize):
(WebKit::MappedMemory::markUsed):
(WebKit::MappedMemory::markFree):
(WebKit::MappedMemory::isFree):
(WebKit::MappedMemory::data):
* Shared/qt/MappedMemoryPool.cpp:
(WebKit::MappedMemoryPool::cleanUp):
* Shared/qt/UpdateChunk.cpp:
(WebKit::mapMemory):
(WebKit::mapFile):
(WebKit::UpdateChunk::data):
(WebKit::UpdateChunk::decode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 11:56:12 +0000 (11:56 +0000)]
2010-10-13 Dinu Jacob <dinu.jacob@nokia.com>
Reviewed by Andreas Kling.
[Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=47540
Updated symbols for Symbian - added viewportAttributesForSize and
made viewportConfigurationForSize absent based on the API change in
47325
* symbian/eabi/QtWebKitu.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 13 Oct 2010 10:17:09 +0000 (10:17 +0000)]
2010-10-13 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Rebaseline some windows tests. Add new expectations for two SVG tests.
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/svg/batik: Added.
* platform/win/svg/batik/masking: Added.
* platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
* platform/win/svg/zoom: Added.
* platform/win/svg/zoom/page: Added.
* platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 13 Oct 2010 10:00:34 +0000 (10:00 +0000)]
2010-10-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Pages using DeviceOrientation and DeviceMotion should not go into the page cache
https://bugs.webkit.org/show_bug.cgi?id=47408
* fast/dom/DeviceMotion/no-page-cache-expected.txt: Added.
* fast/dom/DeviceMotion/no-page-cache.html: Added.
* fast/dom/DeviceMotion/resources: Added.
* fast/dom/DeviceMotion/resources/cached-page-1.html: Added.
* fast/dom/DeviceMotion/resources/cached-page-2.html: Added.
* fast/dom/DeviceMotion/script-tests/no-page-cache.js: Added.
(reportPageOneOnload):
* fast/dom/DeviceOrientation/no-page-cache-expected.txt: Added.
* fast/dom/DeviceOrientation/no-page-cache.html: Added.
* fast/dom/DeviceOrientation/resources: Added.
* fast/dom/DeviceOrientation/resources/cached-page-1.html: Added.
* fast/dom/DeviceOrientation/resources/cached-page-2.html: Added.
* fast/dom/DeviceOrientation/script-tests/no-page-cache.js: Added.
(reportPageOneOnload):
2010-10-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Pages using DeviceOrientation and DeviceMotion should not go into the page cache
https://bugs.webkit.org/show_bug.cgi?id=47408
Tests: fast/dom/DeviceMotion/no-page-cache.html
fast/dom/DeviceOrientation/no-page-cache.html
* dom/DeviceMotionController.h:
(WebCore::DeviceMotionController::isActive):
* dom/DeviceOrientationController.h:
(WebCore::DeviceOrientationController::isActive):
* history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
* page/Page.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 13 Oct 2010 09:24:09 +0000 (09:24 +0000)]
2010-10-13 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, build fix.
Disable printing/simultaneous-position-float-change.html as LayoutTestController::setPrinting()
is not implemented in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=47578
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 13 Oct 2010 09:14:10 +0000 (09:14 +0000)]
2010-10-13 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: Chromium pixel baselines for new ruby test.
Add baselines for the new ruby test introduced in WK r69642.
* platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.checksum: Added.
* platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.txt: Added.
* platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.checksum: Added.
* platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-beforeafter-expected.checksum: Added.
* platform/chromium-win/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 09:03:44 +0000 (09:03 +0000)]
2010-10-13 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
Make resource identifiers unique across pages
https://bugs.webkit.org/show_bug.cgi?id=47002
* http/tests/misc/iframe-reparenting-id-collision-expected.txt: Added.
* http/tests/misc/iframe-reparenting-id-collision.html: Added.
* http/tests/misc/resources/iframe-reparenting-id-collision-page.html: Added.
* http/tests/misc/resources/send-async-xhr.html: Added.
2010-10-13 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
Make resource identifiers unique across pages
https://bugs.webkit.org/show_bug.cgi?id=47002
Test: http/tests/misc/iframe-reparenting-id-collision.html
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::createUniqueIdentifier):
* loader/ProgressTracker.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 13 Oct 2010 07:25:57 +0000 (07:25 +0000)]
2010-10-07 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Davit Hyatt.
Bug 41040 - :before/:after content should not become part of a ruby base
https://bugs.webkit.org/show_bug.cgi?id=41040
Also related to:
https://bugs.webkit.org/show_bug.cgi?id=40895.
https://bugs.webkit.org/show_bug.cgi?id=43722.
Layout tests: verify that generated content is outside of the ruby base.
Also, tests shouldn't crash.
* fast/ruby/after-doesnt-crash-expected.txt:
* fast/ruby/after-doesnt-crash.html: Added.
* fast/ruby/before-doesnt-crash.html:
* fast/ruby/ruby-beforeafter.html: Added.
* platform/gtk/Skipped:
* platform/mac/fast/ruby/ruby-beforeafter-expected.checksum: Added.
* platform/mac/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/mac/fast/ruby/ruby-beforeafter-expected.txt: Added.
* platform/qt/Skipped:
Explicitly handle :before and :after content in the default way.
Test: fast/ruby/ruby-beforeafter.html
fast/ruby/after-doesnt-crash.html
* rendering/RenderObject.h:
(WebCore::RenderObject::isBeforeContent):
* rendering/RenderRuby.cpp:
(WebCore::lastRubyRun):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Wed, 13 Oct 2010 06:52:02 +0000 (06:52 +0000)]
Build fix. Unreviewed.
* win/WebKit2Generated.make:
Copy over WKBundleHitTestResult.h.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Oct 2010 06:34:18 +0000 (06:34 +0000)]
2010-10-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69639.
http://trac.webkit.org/changeset/69639
https://bugs.webkit.org/show_bug.cgi?id=47575
"regressed nav-element.html" (Requested by rniwa on #webkit).
* editing/execCommand/format-block-expected.txt:
* editing/execCommand/format-block-from-range-selection-expected.txt:
* editing/execCommand/format-block-multiple-paragraphs-expected.txt: Removed.
* editing/execCommand/format-block-multiple-paragraphs.html: Removed.
* editing/execCommand/format-block-table-expected.txt: Removed.
* editing/execCommand/format-block-table.html: Removed.
* editing/execCommand/format-block-with-braces-expected.txt:
2010-10-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69639.
http://trac.webkit.org/changeset/69639
https://bugs.webkit.org/show_bug.cgi?id=47575
"regressed nav-element.html" (Requested by rniwa on #webkit).
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::formatSelection):
* editing/EditorCommand.cpp:
(WebCore::executeFormatBlock):
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::formatRange):
* editing/FormatBlockCommand.h:
(WebCore::FormatBlockCommand::editingAction):
* editing/VisiblePosition.cpp:
(WebCore::enclosingBlockFlowElement):
* editing/VisiblePosition.h:
* editing/htmlediting.cpp:
(WebCore::validBlockTag):
* editing/htmlediting.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc