thatcher [Sun, 8 Jan 2006 04:14:06 +0000 (04:14 +0000)]
adding the new Makefiles.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 7 Jan 2006 11:27:17 +0000 (11:27 +0000)]
Reviewed by Darin, landed by ap.
Test: fast/text/atsui-small-caps-punctuation-size.html
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6397
ATSUI small caps use small punctuation
* WebCoreSupport.subproj/WebTextRenderer.m:
(createATSULayoutParameters): Changed the characters for which size must
not change from !u_isbase() to the M* categories.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 7 Jan 2006 10:33:26 +0000 (10:33 +0000)]
2006-01-07 Anders Carlsson <andersca@mac.com>
Reviewed by Maciej.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6373
REGRESSION: JavaScript hang when comparing large array to null
* khtml/ecma/kjs_html.cpp:
Remove toPrimitive.
* khtml/ecma/kjs_html.h:
(KJS::HTMLAllCollection::isEqualToNull):
Implement isEqualToNull and have it return true.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 7 Jan 2006 10:32:25 +0000 (10:32 +0000)]
2006-01-07 Anders Carlsson <andersca@mac.com>
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6373
REGRESSION: JavaScript hang when comparing large array to null
* kjs/object.h:
(KJS::JSObject::isEqualToNull):
Add new function which returns true if an object should be treated as null when
doing comparisons.
* kjs/operations.cpp:
(KJS::equal):
Use isEqualToNull.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 7 Jan 2006 10:22:45 +0000 (10:22 +0000)]
Reviewed by Maciej.
- Fix WebCore development build
http://bugzilla.opendarwin.org/show_bug.cgi?id=6408
* kxmlcore/Assertions.h: Use __VA_ARGS__ in variadic macros.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 7 Jan 2006 02:15:15 +0000 (02:15 +0000)]
Bug #:
4386652
Submitted by: eseidel
Reviewed by: darin
<rdar://problem/
4386652> Crash: SVG filter crash at w3schools.com
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(KCanvasFEDiffuseLightingQuartz::getCIFilter): nil check
(KCanvasFESpecularLightingQuartz::getCIFilter): nil check
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Jan 2006 23:51:00 +0000 (23:51 +0000)]
Reviewed by Darin.
- miscellaneous changes for 4% speedup on the JavaScript iBench
http://bugzilla.opendarwin.org/show_bug.cgi?id=6396
Changes mostly thanks to Maks Orlovich, tweaked a little by me.
* kjs/create_hash_table: Use the same hash as the one used buy Identifier.
* kjs/function.cpp:
(KJS::FunctionImp::processParameters): Use the new List::copyFrom
(KJS::ActivationImp::ActivationImp): track variable while iterating
* kjs/internal.cpp:
(KJS::StringImp::toObject): create StringInstance directly
* kjs/list.cpp:
(KJS::List::copy): implement in terms of copyFrom
(KJS::List::copyFrom): more efficient way to copy in another list
* kjs/list.h:
* kjs/lookup.cpp:
(keysMatch): updated to work with identifier hash
(findEntry): ditto
(Lookup::findEntry): ditto
(Lookup::find): ditto
* kjs/lookup.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Jan 2006 22:49:05 +0000 (22:49 +0000)]
Fix build bustage on Mac.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Jan 2006 22:43:44 +0000 (22:43 +0000)]
Land all the changes to make JSCore build again on windows.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Jan 2006 22:21:06 +0000 (22:21 +0000)]
Check in the remaining project changes for building with VC 2005
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 6 Jan 2006 21:09:54 +0000 (21:09 +0000)]
Reviewed by Vicki Murley (full credit) and Tim Omernick (half credit).
- fixed <rdar://problem/
4401102> REGRESSION (420+): When displaying a PDF, tabbing around stops working after reaching page
* WebView.subproj/WebPDFView.m:
(-[WebPDFView setNextKeyView:]):
Use [PDFSubview documentView] rather than PDFSubview here, since that's the view that we now hand off first-responderhood to.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 6 Jan 2006 20:02:13 +0000 (20:02 +0000)]
Bug #:
Submitted by:
Reviewed by:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 6 Jan 2006 19:24:04 +0000 (19:24 +0000)]
Patch by Mitz, reviwed by Darin, layout tested and landed by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6382
REGRESSION: Repro crash when clicking link with target="_blank"
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::setName):
* manual-tests/empty-link-target.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 6 Jan 2006 18:13:37 +0000 (18:13 +0000)]
LayoutTests:
Rolling out this layout test for now, until we can get plugin testing
working.
* fast/plugins/netscape-back-forward.html: Removed.
WebKitTools:
Temporarily rolling out plugin support from DumpRenderTree because it
caused lots of layout test regressions.
* DumpRenderTree/DumpRenderTree.m:
(main): Remove invisible window added to support plugins.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 6 Jan 2006 15:50:53 +0000 (15:50 +0000)]
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5291
FORM multipart/form-data with GET method issue
Test cases:
* fast/forms/form-get-multipart.html
* fast/forms/form-get-multipart2.html
* fast/forms/form-get-multipart3.html
* fast/forms/form-post-urlencoded.html
* khtml/html/html_formimpl.cpp:
(DOM::HTMLFormElementImpl::submit):
Reset m_multipart to false if not posting.
(DOM::HTMLFormElementImpl::parseEnctype):
multipart/form-data doesn't imply POST method.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 6 Jan 2006 14:35:25 +0000 (14:35 +0000)]
Reviewed by Eric.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5792
Crasher on rendering-shapes from SVG 1.0 testsuite
Test case: fast/parser/entity-ignorable-whitespace.xhtml
* khtml/xml/xml_tokenizer.cpp:
(khtml::XMLTokenizer::finish): install an ignorableWhitespace callback to
work around a libxml2 bug
(khtml::ignorableWhitespaceHandler): no-op
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 6 Jan 2006 11:03:11 +0000 (11:03 +0000)]
Same as the previous checkin, but should be for real now.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 6 Jan 2006 10:47:08 +0000 (10:47 +0000)]
Remove conflict marker
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 6 Jan 2006 10:44:47 +0000 (10:44 +0000)]
- fix development build failure from the previous checkin
* kjs/function.cpp:
(KJS::ActivationImp::put): Use prototype() accessor in assert.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 6 Jan 2006 10:44:17 +0000 (10:44 +0000)]
2006-01-06 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
- update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5142
parseXMLDocumentFragment can't parse fragments correctly
* fast/dom/set-innerHTML-expected.txt:
* fast/dom/set-innerHTML.xhtml:
Update these with the attached test case.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 6 Jan 2006 10:39:55 +0000 (10:39 +0000)]
2006-01-06 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5142
parseXMLDocumentFragment can't parse fragments correctly
* khtml/xml/xml_tokenizer.cpp:
(khtml::balancedStartElementNsHandler):
(khtml::balancedEndElementNsHandler):
(khtml::balancedCharactersHandler):
(khtml::balancedProcessingInstructionHandler):
(khtml::balancedCdataBlockHandler):
(khtml::balancedCommentHandler):
(khtml::balancedWarningHandler):
Add handlers.
(khtml::parseXMLDocumentFragment):
Change back into using xmlParseBalancedChunkMemory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 6 Jan 2006 09:16:38 +0000 (09:16 +0000)]
Bug #: 5969
Submitted by: Alexander Kellett <lypanov@kde.org>
Reviewed by: eseidel
Basic support for <mask> tag.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5969
* svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: updated.
* svg/custom/grayscale-gradient-mask-expected.checksum: Added.
* svg/custom/grayscale-gradient-mask-expected.png: Added.
* svg/custom/grayscale-gradient-mask-expected.txt: Added.
* svg/custom/grayscale-gradient-mask.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 6 Jan 2006 09:10:04 +0000 (09:10 +0000)]
Bug #: 5969
Submitted by: Alexander Kellett <lypanov@kde.org>
Reviewed by: eseidel
Basic support for <mask> tag.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5969
Still missing attribute support for: maskUnits, maskContentUnits.
Mask pixel tests do not work in DumpRenderTree due to:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6327
Added test cases anyway.
This also tickles a (known) gradient update issue:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6052
* WebCore.xcodeproj/project.pbxproj: added Mask files
* kcanvas/KCanvasResources.cpp:
(KCanvasMasker::KCanvasMasker): added.
(KCanvasMasker::~KCanvasMasker): added.
(KCanvasMasker::setMask): added.
(KCanvasMasker::externalRepresentation): added.
(getMaskerById): added.
* kcanvas/KCanvasResources.h:
(KCanvasResource::isMasker): added.
(KCanvasMasker::isMasker): added.
(KCanvasMasker::mask): added.
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
(KCanvasItemQuartz::paint): added mask support
* kcanvas/device/quartz/KCanvasMaskerQuartz.h: Added.
(KCanvasMaskerQuartz::KCanvasMaskerQuartz): added.
* kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Added.
(applyLuminanceToAlphaFilter): added.
(applyExpandAlphatoGrayscaleFilter): added.
(transformImageIntoGrayscaleMask): added.
(KCanvasMaskerQuartz::applyMask): added.
* kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
(KCanvasContainerQuartz::paint): added mask support.
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(KRenderingDeviceQuartz::createResource): added mask support.
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(KRenderingPaintServerRadialGradientQuartz::draw):
* kcanvas/device/quartz/QuartzSupport.h:
* kcanvas/device/quartz/QuartzSupport.mm:
(debugDumpCGImageToFile): added, debug only.
(debugDumpCGLayerToFile): added, debug only.
(debugDumpCIImageToFile): added, debug only.
* ksvg2/css/SVGCSSStyleSelector.cpp:
(KDOM::CSSStyleSelector::applySVGProperty): added mask support.
* ksvg2/css/SVGRenderStyle.cpp:
(SVGRenderStyle::SVGRenderStyle): added mask support.
(SVGRenderStyle::operator==): added mask support.
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/css/SVGRenderStyleDefs.cpp:
(StyleMaskData::StyleMaskData): added mask support.
(StyleMaskData::operator==): added mask support.
* ksvg2/css/SVGRenderStyleDefs.h:
(KSVG::StyleMaskData::operator!=): added mask support.
* ksvg2/ecma/Ecma.cpp:
(Ecma::inheritedGetDOMNode): added mask support.
* ksvg2/svg/SVGMaskElementImpl.cpp: Added.
(KSVG::SVGMaskElementImpl::SVGMaskElementImpl): added.
(KSVG::SVGMaskElementImpl::~SVGMaskElementImpl): added.
(KSVG::SVGMaskElementImpl::x): added.
(KSVG::SVGMaskElementImpl::y): added.
(KSVG::SVGMaskElementImpl::width): added.
(KSVG::SVGMaskElementImpl::height): added.
(KSVG::SVGMaskElementImpl::attributeChanged): added.
(KSVG::SVGMaskElementImpl::childrenChanged): added.
(KSVG::SVGMaskElementImpl::parseMappedAttribute): added.
(KSVG::SVGMaskElementImpl::drawMaskerContent): added.
(KSVG::SVGMaskElementImpl::createRenderer): added.
(KSVG::SVGMaskElementImpl::canvasResource): added.
* ksvg2/svg/SVGMaskElementImpl.h: Added.
(KSVG::SVGMaskElementImpl::isValid): added.
(KSVG::SVGMaskElementImpl::rendererIsNeeded): added.
* ksvg2/svg/svgtags.in: added <mask> support.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Jan 2006 08:32:20 +0000 (08:32 +0000)]
JavaScriptCore:
Reviewed by Eric.
- fix remaining performance regression from Getter/Setter change
http://bugzilla.opendarwin.org/show_bug.cgi?id=6249
- Activation objects should not have __proto__ property
http://bugzilla.opendarwin.org/show_bug.cgi?id=6395
* kjs/function.cpp:
(KJS::ActivationImp::getOwnPropertySlot): Implement directly, thus
skipping getter/setter handling and __proto__ handling, as well
as inlining needed superclass stuff.
(KJS::ActivationImp::put): Implement directly, skipping getter/setter,
__proto__, and do canPut directly in PropertyMap::put since there's no
static property table either.
* kjs/function.h:
* kjs/property_map.cpp:
(KJS::PropertyMap::put): Allow optionally inlining canPut check.
* kjs/property_map.h:
LayoutTests:
Reviewed by Eric.
- test case for 6396: Activation objects should not have __proto__ property
http://bugzilla.opendarwin.org/show_bug.cgi?id=6395
* fast/js/activation-proto-expected.txt: Added.
* fast/js/activation-proto.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Fri, 6 Jan 2006 05:57:25 +0000 (05:57 +0000)]
Reviewed by Geoff.
<rdar://problem/
4400804> Client-side redirect to a non-HTTP URL confuses Safari
* WebView.subproj/WebFrame.m:
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
If we were waiting for a quick redirect, but the policy delegate decided to ignore it, then we
need to report that the client redirect was cancelled.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 6 Jan 2006 00:12:03 +0000 (00:12 +0000)]
* WebView.subproj/WebPDFView.m:
(-[WebPDFView _fakeKeyEventWithFunctionKey:]):
Just added a FIXME comment about how to clean up this minor hack in the future.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Thu, 5 Jan 2006 23:57:11 +0000 (23:57 +0000)]
Reviewed by Tim O.
- fixed these bugs:
<rdar://problem/
3021785> page up/down don't work on frameset pages unless you click
<rdar://problem/
3021788> Page Up/Down moves an unscrollable frame if you click on it first
and the WebKit part of this (need new Safari too for complete fix):
<rdar://problem/
4378905> Page up/down don't work in PDFs when address field is focused
I moved some logic down from Safari that dealt with finding the largest scrollable child frame in a frameset,
and added support for standard scrolling-related selectors to WebPDFView. The latter was needed for
4378905;
the former was needed due to side effects of the Safari part of the change. As long as I was doing the former,
I also used that logic to fix
3021785 and
3021788.
* WebView.subproj/WebFrameViewPrivate.h:
new currently-private methods _hasScrollBars and _largestChildWithScrollBars
* WebView.subproj/WebFrameView.m:
(-[WebFrameView scrollToBeginningOfDocument:]):
if we don't have scroll bars, operate on our largest child with scroll bars instead
(-[WebFrameView scrollToEndOfDocument:]):
ditto
(-[WebFrameView _pageVertically:]):
ditto
(-[WebFrameView _pageHorizontally:]):
ditto
(-[WebFrameView _scrollLineVertically:]):
ditto
(-[WebFrameView _scrollLineHorizontally:]):
ditto
(-[WebFrameView keyDown:]):
where we were bailing out if ![self allowsScrolling], also check for whether there's a
child with scroll bars, and don't bail out if so
(-[WebFrameView _area]):
new helper method used to implement _largestChildWithScrollBars (code moved from Safari)
(-[WebFrameView _hasScrollBars]):
new method, just returns YES if either scroll bar is showing (code moved from Safari)
(-[WebFrameView _largestChildWithScrollBars]):
new method, returns the child with the largest area that is showing at least one scroll bar
(code moved from Safari and tweaked a little)
* WebView.subproj/WebPDFView.m:
(-[WebPDFView _fakeKeyEventWithFunctionKey:]):
new method, hackaround for the fact that PDFView handles key downs from standard scrolling keys
but does not implement the standard responder selectors
(-[WebPDFView scrollPageDown:]):
use _fakeKeyEventWithFunctionKey: to get the PDFView to scroll appropriately
(-[WebPDFView scrollPageUp:]):
ditto
(-[WebPDFView scrollToBeginningOfDocument:]):
ditto
(-[WebPDFView scrollToEndOfDocument:]):
ditto
* WebView.subproj/WebView.m:
add scrollToBeginningOfDocument and scrollToEndOfDocument to the list of responder operations
that we hand off appropriately to the responder chain. These two aren't defined in any header
but are generated by Home and End keys and used by the text system.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 5 Jan 2006 22:23:14 +0000 (22:23 +0000)]
LayoutTests:
Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
REGRESSION: Repro crash in JS called from Flash on bdash.net.nz
* fast/plugins/netscape-back-forward-expected.txt: Added.
* fast/plugins/netscape-back-forward.html: Added.
* fast/plugins/resources/go-back.html: Added.
WebKit:
Reviewed by Darin.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6361
Add plugin support to DumpRenderTree
* WebKit.exp: export WebPluginDatabase class, which DumpRenderTree
needs to add plugins to the runtime.
WebKitTools:
Reviewed by darin.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6361
Add plugin support to DumpRenderTree
Also wrote first test plugin.
* DumpRenderTree/DumpRenderTree.m:
(main):
(1) Put the WebView in an invisible window, because PlugIns are
optimized not to load if there's no parent window.
(2) Tell WebKit to load any PlugIns in the directory from which we
loaded. This means we can build nasty PlugIns alongside DumpRenderTree
and they'll load automagically during layout testing, but they won't be
added to the user's system, hosing apps like Safari.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added new
test PlugIn to project.
PlugIn added to project:
* DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Added.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Added.
(getPluginClass):
(initializeIdentifiers):
(pluginHasProperty):
(pluginHasMethod):
(pluginGetProperty):
(pluginSetProperty):
(pluginInvoke):
(pluginInvokeDefault):
(pluginInvalidate):
(pluginAllocate):
(pluginDeallocate):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Added.
(NP_Initialize):
(NP_GetEntryPoints):
(NP_Shutdown):
(NPP_New):
(NPP_Destroy):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_DestroyStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_StreamAsFile):
(NPP_Print):
(NPP_HandleEvent):
(NPP_URLNotify):
(NPP_GetValue):
(NPP_SetValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 5 Jan 2006 20:48:53 +0000 (20:48 +0000)]
Reviewed by Darin.
Added UTF-8 BOMs to css2.1 tests.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6312
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 5 Jan 2006 17:44:46 +0000 (17:44 +0000)]
Move log message to top of file where it belongs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 5 Jan 2006 06:41:36 +0000 (06:41 +0000)]
WebCore:
Reviewed by Eric.
Based on a patch by Eric.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6180
"text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage)
* khtml/xsl/xslt_processorimpl.cpp:
(DOM::xsltParamArrayFromParameterMap):
(DOM::freeXsltParamArray):
Use fastMalloc/fastFree.
(DOM::createFragmentFromSource):
If the output is "text", just create a text node and add
it to the fragment.
WebKit:
Reviewed by Darin.
- move frame management and finding code from WebKit to WebCore
http://bugzilla.opendarwin.org/show_bug.cgi?id=6368
* Plugins.subproj/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView loadPluginRequest:]): Set frame name straight on the bridge,
instead of having it bubble through the view and frame.
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge initWithFrameName:view:]): don't pass name to frame, we own it now; set it
on ourselves directly
(-[WebBridge findFrameNamed:]): removed
(-[WebBridge createWindowWithURL:frameName:]): set name on bridge, not webview
(-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
(-[WebBridge runModal]): remove excess braces
* WebKit.xcodeproj/project.pbxproj:
* WebView.subproj/WebControllerSets.h: Removed.
* WebView.subproj/WebControllerSets.m: Removed.
* WebView.subproj/WebFrame.m:
(-[WebFramePrivate name]): removed
(-[WebFramePrivate setName:]): removed
(-[WebFramePrivate dealloc]): don't release name, we no longer have one
(-[WebFrame _appendChild:]): removed
(-[WebFrame _removeChild:]): removed
(-[WebFrame _createItem:]): removed stray space
(-[WebFrame _immediateChildFrameNamed:]): Just call the bridge
(-[WebFrame _setName:]): removed
(-[WebFrame _detachFromParent]): remove bridge from parent note self
(-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
(-[WebFrame _addChild:]): Call appendChild: on bridge, not self
(-[WebFrame _nextFrameWithWrap:]): just call bridge (and moved helpers there)
(-[WebFrame _previousFrameWithWrap:]): just call bridge (and moved helpers there)
(-[WebFrame _initWithWebFrameView:webView:bridge:]): don't take a name any more
(-[WebFrame _setFrameNamespace:]): just call bridge
(-[WebFrame _frameNamespace]): just call bridge
(-[WebFrame _hasSelection]): remove excess braces
(-[WebFrame _clearSelection]): ditto
(-[WebFrame initWithName:webFrameView:webView:]): no more name
(-[WebFrame name]): just call bridge
(-[WebFrame findFrameNamed:]): just call bridge (and moved helpers there)
(-[WebFrame parentFrame]): fixed for new style
* WebView.subproj/WebFrameInternal.h:
* WebView.subproj/WebFramePrivate.h:
* WebView.subproj/WebView.m:
* WebView.subproj/WebViewPrivate.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 4 Jan 2006 21:44:25 +0000 (21:44 +0000)]
Patch by kimmo.t.kinnunen@nokia.com, reviewed by darin, tweaked by me.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4921
\u escape sequences in JavaScript identifiers
* kjs/function_object.cpp:
(FunctionObjectImp::construct):
* kjs/lexer.cpp:
(Lexer::shift):
(Lexer::lex):
(Lexer::isWhiteSpace):
(Lexer::isLineTerminator):
(Lexer::isIdentStart):
(Lexer::isIdentPart):
(isDecimalDigit):
(Lexer::scanRegExp):
* kjs/lexer.h:
(KJS::Lexer::):
* tests/mozilla/expected.html: Updated test results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 4 Jan 2006 21:32:38 +0000 (21:32 +0000)]
- added a missing test result
* svg/custom/fractional-rects-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 4 Jan 2006 21:21:49 +0000 (21:21 +0000)]
2006-01-04 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
- update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6180
"text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage)
* fast/xsl/xslt-processer-expected.txt:
Update.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 4 Jan 2006 21:17:55 +0000 (21:17 +0000)]
2006-01-04 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
Based on a patch by Eric.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6180
"text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage)
* khtml/xsl/xslt_processorimpl.cpp:
(DOM::xsltParamArrayFromParameterMap):
(DOM::freeXsltParamArray):
Use fastMalloc/fastFree.
(DOM::createFragmentFromSource):
If the output is "text", just create a text node and add
it to the fragment.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Jan 2006 21:10:38 +0000 (21:10 +0000)]
Reviewed by Darin.
Created by Eric.
Tweaked and tested by me.
New scripts to work with Subversion when the switch happens.
These will replace cvs-apply, cvs-unapply, and cvs-create-patch.
* Scripts/svn-apply: Added.
* Scripts/svn-create-patch: Added.
* Scripts/svn-unapply: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 4 Jan 2006 21:05:25 +0000 (21:05 +0000)]
LayoutTests:
Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6311
document.plugins doesn't exist
* fast/dom/HTMLDocument/document-plugins-expected.txt: Added.
* fast/dom/HTMLDocument/document-plugins.html: Added.
WebCore:
Reviewed by darin.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6311
document.plugins doesn't exist
* khtml/ecma/kjs_html.cpp: Added 'plugins' as synonym for 'embeds'
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 4 Jan 2006 20:01:52 +0000 (20:01 +0000)]
LayoutTests:
Layout test for <rdar://problem/
4214080> document.embeds:
embeds[0].Play() undefined at languageguide.org prevents audio playing
on mouseover
* fast/dom/object-embed-plugin-scripting-expected.txt: Added.
* fast/dom/object-embed-plugin-scripting.html: Added.
* fast/dom/resources/articles.m4a: Added.
WebCore:
Reviewed by darin.
- Fixed <rdar://problem/
4214080> document.embeds: embeds[0].Play()
undefined at languageguide.org prevents audio playing on mouseover
- Layout test: fast/dom/object-embed-plugin-scripting.html
A common idiom the kids like to use these days for plugins is to nest
an <embed> inside an <object>, and assume that IE will honor the first,
Mozilla the second. We happen to honor both, but the rules dictate that
only the outer <object> gets a plugin/renderer. (A plugin is a
renderer.) This is a problem because sites ID us as Mozilla and
therefore attempt to script their plugins through the <embed>, which
has no plugin/renderer. The fix here is to have an <embed> return its
parent node's plugin/renderer when queried, if and only if it has no
renderer of its own and its parent node is an <object>. We may decide
to restrict this further in the future.
One happy consequence of this patch is that all the apple.com Quicktime
websites we had previously broken with TOT are now fixed.
* khtml/html/html_objectimpl.cpp:
(DOM::HTMLEmbedElementImpl::getEmbedInstance): The "if (!r)" clause
implements the logic I just described. The code below it I changed
just for style, to match the style in getObjectInstance().
(DOM::HTMLEmbedElementImpl::rendererIsNeeded): Assert that an <object>
parent has a renderer because we're going to use it later.
(DOM::HTMLObjectElementImpl::rendererIsNeeded): Changed to match style
of HTMLEmbedElementImpl counterpart.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 4 Jan 2006 14:42:23 +0000 (14:42 +0000)]
Reviewed by Darin, landed by ap.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6301
REGRESSION: Border repaint glitch
* khtml/rendering/render_object.cpp:
(RenderObject::repaintAfterLayoutIfNeeded): Repaint parts of the
border that moved.
* manual-tests/border-repaint-glitch.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 4 Jan 2006 08:23:57 +0000 (08:23 +0000)]
Bug #: 4462
Submitted by: kimmo
Reviewed by: eseidel
Updated layout tests after QRect (size & point) to Q*F change
http://bugzilla.opendarwin.org/show_bug.cgi?id=4462
* svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
* svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
* svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
* svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
* svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
* svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
* svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
* svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
* svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
* svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
* svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
* svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
* svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
* svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
* svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
* svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
* svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
* svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
* svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
* svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
* svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
* svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
* svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
* svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
* svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
* svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
* svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
* svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
* svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
* svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
* svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
* svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
* svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
* svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
* svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
* svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
* svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
* svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
* svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
* svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
* svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
* svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
* svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
* svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
* svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
* svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
* svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
* svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
* svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
* svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
* svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
* svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
* svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
* svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
* svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
* svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
* svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
* svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
* svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
* svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
* svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
* svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
* svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
* svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
* svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
* svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
* svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
* svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
* svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
* svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
* svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
* svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
* svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
* svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
* svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
* svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
* svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
* svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
* svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
* svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
* svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
* svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
* svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
* svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
* svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
* svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
* svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
* svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
* svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
* svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
* svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
* svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
* svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
* svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
* svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
* svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
* svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
* svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
* svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
* svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
* svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
* svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
* svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
* svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
* svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
* svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
* svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
* svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
* svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
* svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
* svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
* svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
* svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
* svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
* svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
* svg/custom/control-points-for-S-and-T-expected.txt:
* svg/custom/fractional-rects-expected.checksum: Added.
* svg/custom/fractional-rects-expected.txt: Added.
* svg/custom/fractional-rects.svg: Added.
* svg/custom/path-bad-data-expected.txt:
* svg/custom/path-update-expected.txt:
* svg/custom/use-forward-refs-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 4 Jan 2006 08:20:32 +0000 (08:20 +0000)]
Bug #: 4462
Submitted by: kimmo
Reviewed by: eseidel
Changed use of QRect to QRectF in the points where SVG can have
fractional numbers
http://bugzilla.opendarwin.org/show_bug.cgi?id=4462
Added test cases:
* svg/custom/fractional-rects.svg: copy of rounded-rects.svg with
fractional coordinates.
* WebCore.xcodeproj/project.pbxproj:
* kwq/KWQWMatrix.h:
* kwq/KWQWMatrix.mm:
(QWMatrix::mapRect): mapRect for QRectF
* kwq/KWQRectF.h:
* kwq/KWQRectF.mm: Added. QRectF impl
* kwq/KWQSizeF.h:
* kwq/KWQSizeF.mm: Added.QSizeF impl
* kwq/KWQPointF.h:
* kwq/KWQPointF.mm: Added. QPointF impl
* kcanvas/KCanvasContainer.cpp:
(KCanvasContainer::fillContains):
(KCanvasContainer::strokeContains):
(KCanvasContainer::relativeBBox):
(KCanvasContainer::getAspectRatio): QRect -> QRectF
* kcanvas/KCanvasContainer.h:
* kcanvas/KCanvasFilters.cpp:
(KCanvasFilterEffect::subRegion):
(KCanvasFilterEffect::setSubRegion): QRect -> QRectF
* kcanvas/KCanvasFilters.h:
(KCanvasFilter::filterRect):
(KCanvasFilter::setFilterRect): QRect -> QRectF
(KCanvasFEConvolveMatrix::kernelSize):
(KCanvasFEConvolveMatrix::setKernelSize):
(KCanvasFEConvolveMatrix::targetOffset):
(KCanvasFEConvolveMatrix::setTargetOffset): QSize -> QSizeF
* kcanvas/KCanvasItem.cpp:
(RenderPath::fillContains):
(RenderPath::strokeContains):
(RenderPath::relativeBBox): QRect -> QRectF
* kcanvas/KCanvasItem.h:
* kcanvas/KCanvasResources.cpp:
(KCanvasMarker::draw): QRect -> QRectF
* kcanvas/KCanvasResources.h:
* kcanvas/KCanvasTreeDebug.cpp:
(hasFractions): helper function
(operator<<): QSizeF operator, QRectF operator
* kcanvas/KCanvasTreeDebug.h:
* kcanvas/device/KRenderingPaintServerGradient.cpp:
(KRenderingPaintServerLinearGradient::gradientStart):
(KRenderingPaintServerLinearGradient::setGradientStart):
(KRenderingPaintServerLinearGradient::gradientEnd):
(KRenderingPaintServerLinearGradient::setGradientEnd):
(KRenderingPaintServerRadialGradient::gradientCenter):
(KRenderingPaintServerRadialGradient::setGradientCenter):
(KRenderingPaintServerRadialGradient::gradientFocal):
(KRenderingPaintServerRadialGradient::setGradientFocal): QPoint -> QPointF
* kcanvas/device/KRenderingPaintServerGradient.h:
* kcanvas/device/KRenderingPaintServerPattern.cpp:
(KRenderingPaintServerPattern::Private::Private): x, y, width, height -> QRectF
(KRenderingPaintServerPattern::setBbox): replaced get/set methods
(KRenderingPaintServerPattern::bbox): replaced get/set methods
(KRenderingPaintServerPattern::externalRepresentation):
* kcanvas/device/KRenderingPaintServerPattern.h:
* kcanvas/device/quartz/KCanvasFilterQuartz.h:
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(KCanvasFilterQuartz::prepareFilter):
(KCanvasFilterQuartz::applyFilter): QRect -> QRectF
* kcanvas/device/quartz/KCanvasItemQuartz.h:
(KCanvasItemQuartz::getAbsoluteRepaintRect): QRect -> QRectF
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
(drawMarkerWithData):
(KCanvasItemQuartz::drawMarkersIfNeeded):
(KCanvasItemQuartz::paint): QRect -> QRectF
(KCanvasItemQuartz::nodeAtPoint): QPoint -> QPointF
(KCanvasItemQuartz::bboxForPath) :QRect -> QRectF
(KCanvasItemQuartz::hitsPath):
* kcanvas/device/quartz/KCanvasResourcesQuartz.h:
(KCanvasContainerQuartz::getAbsoluteRepaintRect): QRect -> QRectF
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
(KRenderingPaintServerPatternQuartz::draw): QRect -> QRectF
* khtml/rendering/render_object.h:
(khtml::RenderObject::relativeBBox):QRect -> QRectF
* ksvg2/svg/SVGFilterElementImpl.cpp:
(SVGFilterElementImpl::canvasResource): QRect -> QRectF
* ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp:
(SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
* ksvg2/svg/SVGLengthImpl.cpp:
(SVGLengthImpl::value): QRect -> QRectF
* ksvg2/svg/SVGLinearGradientElementImpl.cpp:
(SVGLinearGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
* ksvg2/svg/SVGLocatableImpl.cpp:
(SVGLocatableImpl::getBBox): Rect -> QRectF
* ksvg2/svg/SVGPatternElementImpl.cpp:
(SVGPatternElementImpl::drawPatternContentIntoTile): QRect -> QRectF
* ksvg2/svg/SVGRadialGradientElementImpl.cpp:
(SVGRadialGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
* ksvg2/svg/SVGSVGElementImpl.cpp:
(SVGSVGElementImpl::checkIntersection): QRect -> QRectF, removed integer conversions
(SVGSVGElementImpl::checkEnclosure): QRect -> QRectF, removed integer conversions
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 4 Jan 2006 02:01:42 +0000 (02:01 +0000)]
Bug #:
Submitted by:
Reviewed by:
Bug #:
Submitted by:
Reviewed by:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 4 Jan 2006 01:02:55 +0000 (01:02 +0000)]
WebCore:
Reviewed by Vicki.
- moved frame traversal code across from bridge, also dropped the children
array
* kwq/WebCoreBridge.h:
* kwq/WebCoreBridge.mm:
(-[WebCoreBridge firstChild]): Moved from WebBridge. Use new _firstChild
pointer.
(-[WebCoreBridge lastChild]): Moved from WebBridge. Use new _lastChild pointer.
(-[WebCoreBridge childCount]): Moved from WebBridge. Use _childCount variable.
(-[WebCoreBridge previousSibling]): Moved from WebBridge.
(-[WebCoreBridge nextSibling]): ditt
(-[WebCoreBridge isDescendantOfFrame:]): ditto
(-[WebCoreBridge traverseNextFrameStayWithin:]): ditto
(-[WebCoreBridge appendChild:]): Moved from WebBridge, maintain count and first/last
pointers.
(-[WebCoreBridge removeChild:]): Moved from WebBridge, maintain count and first/last
pointers.
WebKit:
Reviewed by Vicki.
- moved frame traversal code across from bridge, also dropped the children
array
* WebCoreSupport.subproj/WebBridge.h:
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge dealloc]): Don't release children array, that was moved
down to WebCore.
(-[WebBridge saveDocumentState:]):
- many methods moved to WebCore.
* WebView.subproj/WebFrame.m:
(Frame): New convenience method to get a WebFrame * from a method that
returns WebCoreBridge *.
(-[WebFrame _firstChildFrame]): use Frame()
(-[WebFrame _lastChildFrame]): ditto
(-[WebFrame _previousSiblingFrame]): ditto
(-[WebFrame _nextSiblingFrame]): ditto
(-[WebFrame _traverseNextFrameStayWithin:]): ditto
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Jan 2006 23:21:21 +0000 (23:21 +0000)]
Reviewed by harrison
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
window.getSelection().toString() is undefined (range object
returned from window.getSelection() is useless)
toString was defined as a method on the JS Selection object,
but it didn't return anything.
Added layout test:
* editing/selection/toString.html
* khtml/ecma/kjs_window.cpp:
(KJS::SelectionFunc::callAsFunction):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Jan 2006 23:06:28 +0000 (23:06 +0000)]
Reviewed by harrison
Layout test for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
window.getSelection().toString() is undefined (range object
returned from window.getSelection() is useless)
* editing/selection/toString-expected.txt: Added.
* editing/selection/toString.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 3 Jan 2006 23:03:37 +0000 (23:03 +0000)]
Bug #: 6345
Submitted by: eseidel
Reviewed by: darin
REGRESSION: repro crash w/ invalid charset attribute on <script>
http://bugzilla.opendarwin.org/show_bug.cgi?id=6345
* fast/loader/invalid-charset-on-script-crashes-loader-expected.txt: Added.
* fast/loader/invalid-charset-on-script-crashes-loader.html: Added.
* fast/loader/resources/invalid-charset-on-script-crashes-loader.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 3 Jan 2006 22:42:48 +0000 (22:42 +0000)]
Reviewed by timo.
- Fixed: http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
REGRESSION: Repro crash in JS called from Flash on bdash.net.nz
Since we clear all the plugin data structures in setView, we need to
clear the windowScriptObject as well. I had already done this in my
previous patch, but I didn't realize there are two windowScriptObjects
-- one for Netscape PlugIns, and one for WebKit PlugIns.
* kwq/KWQKHTMLPart.mm:
(KWQKHTMLPart::setView): Clear the Netscape PlugIn windowScriptObject
as well.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 22:34:45 +0000 (22:34 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
- add tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6358
JS objects missing "prototype" properties
* fast/js/test-prototypes-expected.txt: Added.
* fast/js/test-prototypes.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 22:34:20 +0000 (22:34 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6358
JS objects missing "prototype" properties
* khtml/ecma/XSLTProcessor.cpp:
(KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
* khtml/ecma/XSLTProcessor.h:
* khtml/ecma/domparser.cpp:
(KJS::DOMParserConstructorImp::DOMParserConstructorImp):
* khtml/ecma/xmlhttprequest.cpp:
(KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp):
* khtml/ecma/xmlserializer.cpp:
(KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
Add "prototype" property in constructors.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 3 Jan 2006 22:02:29 +0000 (22:02 +0000)]
Bug #: 6345
Submitted by: eseidel
Reviewed by: darin
REGRESSION: repro crash w/ invalid charset attribute on <script>
http://bugzilla.opendarwin.org/show_bug.cgi?id=6345
I also made some small spacing cleanup here.
I did *not* fix the usage in formData, as the move from KCharSet to
QTextCodec actually fixed a bug whereby if the first listed charset
in accept-charsets was invalid, we would assume latin1 instead of
checking for the next valid one before assuming system encoding.
* khtml/html/html_formimpl.cpp:
(DOM::HTMLFormElementImpl::formData): cleanup
* khtml/misc/loader.cpp:
(CachedCSSStyleSheet::CachedCSSStyleSheet): null check
(CachedScript::CachedScript): cleanup
(CachedXSLStyleSheet::CachedXSLStyleSheet): null check
(CachedXBLDocument::CachedXBLDocument): cleanup
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 21:51:45 +0000 (21:51 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Darin.
- Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6357
REGRESSION: iframe and target is broken
* fast/frames/iframe-target-expected.txt: Added.
* fast/frames/iframe-target.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 21:50:19 +0000 (21:50 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Darin.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6357
REGRESSION: iframe and target is broken
* WebView.subproj/WebFrame.m:
(-[WebFrame _descendantFrameNamed:sourceFrame:]):
Return the correct frame.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Jan 2006 12:37:06 +0000 (12:37 +0000)]
New/updated layout tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4904>
Bug with baseOffset and extentOffset in selections (for writely.com)
<rdar://problem/
4259818>
selection object incorrect after double-clicking a word
* editing/selection/anchor-focus1-expected.txt: Added.
* editing/selection/anchor-focus1.html: Added.
* editing/selection/anchor-focus2-expected.txt: Added.
* editing/selection/anchor-focus2.html: Added.
* editing/selection/anchor-focus3-expected.txt: Added.
* editing/selection/anchor-focus3.html: Added.
* editing/selection/getRangeAt-expected.txt: Added.
* editing/selection/getRangeAt.html: Added.
* editing/selection/unrendered-001-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Jan 2006 12:28:25 +0000 (12:28 +0000)]
<bugzilla.opendarwin.org/show_bug.cgi?id=4904>
Bug with baseOffset and extentOffset in selections (for writely.com)
<rdar://problem/
4259818>
selection object incorrect after double-clicking a word
Reviewed by harrison
Changed the Selection object's anchor/focus properties to match
Mozilla's Selection object API, added getRangeAt and outlined the
rest of the API.
Cleaned up the JS Selection object (to do less work in the DOM binding).
Added an updateLayout call to VisiblePosition::init and removed some
updateLayout calls from other parts of the editing code.
Added layout tests:
* editing/selection/getRangeAt.html
* editing/selection/anchor-focus1.html
* editing/selection/anchor-focus2.html
* editing/selection/anchor-focus3.html
Updated expected results:
* editing/selection/unrendered-001-expected.txt
* khtml/ecma/kjs_window.cpp:
(KJS::Selection::getValueProperty):
(KJS::Selection::toString):
(KJS::SelectionFunc::callAsFunction):
* khtml/ecma/kjs_window.h:
(KJS::Selection::):
* khtml/editing/SelectionController.cpp:
(khtml::SelectionController::modify):
(khtml::SelectionController::type):
(khtml::SelectionController::toString):
(khtml::SelectionController::getRangeAt):
(khtml::SelectionController::setBaseAndExtent):
(khtml::SelectionController::setPosition):
(khtml::SelectionController::collapse):
(khtml::SelectionController::collapseToEnd):
(khtml::SelectionController::collapseToStart):
(khtml::SelectionController::empty):
(khtml::SelectionController::extend):
(khtml::SelectionController::validate):
* khtml/editing/SelectionController.h:
(khtml::SelectionController::part):
(khtml::SelectionController::baseNode):
(khtml::SelectionController::extentNode):
(khtml::SelectionController::baseOffset):
(khtml::SelectionController::extentOffset):
(khtml::SelectionController::anchorNode):
(khtml::SelectionController::anchorOffset):
(khtml::SelectionController::focusNode):
(khtml::SelectionController::focusOffset):
(khtml::SelectionController::isCollapsed):
* khtml/editing/visible_position.cpp:
(khtml::VisiblePosition::init):
(khtml::VisiblePosition::isCandidate):
* khtml/khtml_part.cpp:
(KHTMLPart::handleMousePressEventSingleClick):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 10:06:36 +0000 (10:06 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Maciej.
- Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5378
createDocument fails with DOM Exception 5 when passed empty qname
* dom/html/level2/core/createDocument08-expected.txt:
* dom/xhtml/level2/core/createDocument08-expected.txt:
These now fail.
* fast/dom/createDocument-empty-expected.txt: Added.
* fast/dom/createDocument-empty.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 10:05:44 +0000 (10:05 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5378
createDocument fails with DOM Exception 5 when passed empty qname
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMDOMImplementationProtoFunc::callAsFunction):
When passing null to createDocument, pass a null DOMString, and not
a DOMString containing the text "null".
* khtml/xml/dom_docimpl.cpp:
(DOMImplementationImpl::createDocument):
Only validate the qualifiedName if it's not null or empty. Also, do not
create the document element if the qualifiedName is null or empty.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 3 Jan 2006 09:19:17 +0000 (09:19 +0000)]
Bug #: 6109
Submitted by: eseidel
Reviewed by: darin
No functionality changes, no tests possible.
khtml/editing should use RefPtr instead of manual ref/deref
http://bugzilla.opendarwin.org/show_bug.cgi?id=6109
Results in a slight performance gain < 1% on the PLT.
* khtml/editing/SelectionController.cpp:
(khtml::SelectionController::toRange):
* khtml/editing/SelectionController.h:
* khtml/editing/append_node_command.cpp:
(khtml::AppendNodeCommand::AppendNodeCommand):
(khtml::AppendNodeCommand::doApply):
(khtml::AppendNodeCommand::doUnapply):
* khtml/editing/append_node_command.h:
(khtml::AppendNodeCommand::~AppendNodeCommand):
(khtml::AppendNodeCommand::appendChild):
(khtml::AppendNodeCommand::parentNode):
* khtml/editing/apply_style_command.cpp:
(khtml::StyleChange::init):
(khtml::ApplyStyleCommand::removeInlineStyle):
* khtml/editing/apply_style_command.h:
* khtml/editing/composite_edit_command.cpp:
(khtml::CompositeEditCommand::deleteInsignificantText):
* khtml/editing/delete_from_text_node_command.cpp:
(khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
* khtml/editing/delete_from_text_node_command.h:
(khtml::DeleteFromTextNodeCommand::~DeleteFromTextNodeCommand):
(khtml::DeleteFromTextNodeCommand::node):
* khtml/editing/delete_selection_command.cpp:
(khtml::DeleteSelectionCommand::initializePositionData):
(khtml::DeleteSelectionCommand::saveTypingStyleState):
(khtml::DeleteSelectionCommand::handleGeneralDelete):
(khtml::DeleteSelectionCommand::calculateEndingPosition):
(khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
(khtml::DeleteSelectionCommand::clearTransientState):
* khtml/editing/delete_selection_command.h:
* khtml/editing/edit_command.cpp:
(khtml::EditCommand::EditCommand):
(khtml::EditCommand::~EditCommand):
(khtml::EditCommand::setTypingStyle):
(khtml::EditCommand::styleAtPosition):
* khtml/editing/edit_command.h:
(khtml::EditCommand::document):
(khtml::EditCommand::typingStyle):
* khtml/editing/insert_into_text_node_command.cpp:
(khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
* khtml/editing/insert_into_text_node_command.h:
(khtml::InsertIntoTextNodeCommand::~InsertIntoTextNodeCommand):
(khtml::InsertIntoTextNodeCommand::node):
* khtml/editing/insert_node_before_command.cpp:
(khtml::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
(khtml::InsertNodeBeforeCommand::doApply):
(khtml::InsertNodeBeforeCommand::doUnapply):
* khtml/editing/insert_node_before_command.h:
(khtml::InsertNodeBeforeCommand::~InsertNodeBeforeCommand):
(khtml::InsertNodeBeforeCommand::insertChild):
(khtml::InsertNodeBeforeCommand::refChild):
* khtml/editing/insert_paragraph_separator_command.cpp:
(khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):
(khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand):
(khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
(khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
* khtml/editing/insert_paragraph_separator_command.h:
* khtml/editing/join_text_nodes_command.cpp:
(khtml::JoinTextNodesCommand::JoinTextNodesCommand):
(khtml::JoinTextNodesCommand::doApply):
(khtml::JoinTextNodesCommand::doUnapply):
* khtml/editing/join_text_nodes_command.h:
(khtml::JoinTextNodesCommand::~JoinTextNodesCommand):
(khtml::JoinTextNodesCommand::firstNode):
(khtml::JoinTextNodesCommand::secondNode):
* khtml/editing/jsediting.cpp:
* khtml/editing/markup.cpp:
(khtml::createMarkup):
(khtml::createFragmentFromMarkup):
(khtml::createFragmentFromText):
(khtml::createFragmentFromNodeList):
* khtml/editing/markup.h:
* khtml/editing/merge_identical_elements_command.cpp:
(khtml::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
(khtml::MergeIdenticalElementsCommand::doApply):
(khtml::MergeIdenticalElementsCommand::doUnapply):
* khtml/editing/merge_identical_elements_command.h:
(khtml::MergeIdenticalElementsCommand::~MergeIdenticalElementsCommand):
* khtml/editing/move_selection_command.cpp:
(khtml::MoveSelectionCommand::MoveSelectionCommand):
(khtml::MoveSelectionCommand::~MoveSelectionCommand):
(khtml::MoveSelectionCommand::doApply):
* khtml/editing/move_selection_command.h:
* khtml/editing/rebalance_whitespace_command.cpp:
* khtml/editing/rebalance_whitespace_command.h:
(khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand):
* khtml/editing/remove_css_property_command.cpp:
(khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
* khtml/editing/remove_css_property_command.h:
(khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
(khtml::RemoveCSSPropertyCommand::styleDeclaration):
* khtml/editing/remove_node_attribute_command.cpp:
(khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
* khtml/editing/remove_node_attribute_command.h:
(khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand):
(khtml::RemoveNodeAttributeCommand::element):
* khtml/editing/remove_node_command.cpp:
(khtml::RemoveNodeCommand::RemoveNodeCommand):
(khtml::RemoveNodeCommand::doApply):
(khtml::RemoveNodeCommand::doUnapply):
* khtml/editing/remove_node_command.h:
(khtml::RemoveNodeCommand::~RemoveNodeCommand):
(khtml::RemoveNodeCommand::node):
* khtml/editing/remove_node_preserving_children_command.cpp:
(khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
* khtml/editing/remove_node_preserving_children_command.h:
(khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand):
(khtml::RemoveNodePreservingChildrenCommand::node):
* khtml/editing/replace_selection_command.cpp:
(khtml::ReplacementFragment::ReplacementFragment):
(khtml::ReplacementFragment::~ReplacementFragment):
(khtml::ReplacementFragment::enclosingBlock):
(khtml::ReplacementFragment::removeNodePreservingChildren):
(khtml::ReplacementFragment::removeNode):
(khtml::ReplacementFragment::insertFragmentForTestRendering):
(khtml::ReplacementFragment::restoreTestRenderingNodesToFragment):
(khtml::ReplaceSelectionCommand::fixupNodeStyles):
(khtml::computeAndStoreNodeDesiredStyle):
(khtml::NodeDesiredStyle::NodeDesiredStyle):
(khtml::ReplaceSelectionCommand::ReplaceSelectionCommand):
(khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand):
(khtml::ReplaceSelectionCommand::doApply):
(khtml::ReplaceSelectionCommand::completeHTMLReplacement):
(khtml::ReplaceSelectionCommand::updateNodesInserted):
* khtml/editing/replace_selection_command.h:
(khtml::NodeDesiredStyle::node):
(khtml::NodeDesiredStyle::style):
(khtml::ReplacementFragment::root):
* khtml/editing/set_node_attribute_command.cpp:
(khtml::SetNodeAttributeCommand::SetNodeAttributeCommand):
* khtml/editing/set_node_attribute_command.h:
(khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand):
(khtml::SetNodeAttributeCommand::element):
* khtml/editing/split_element_command.cpp:
(khtml::SplitElementCommand::SplitElementCommand):
(khtml::SplitElementCommand::doApply):
(khtml::SplitElementCommand::doUnapply):
* khtml/editing/split_element_command.h:
(khtml::SplitElementCommand::~SplitElementCommand):
* khtml/editing/split_text_node_command.cpp:
(khtml::SplitTextNodeCommand::SplitTextNodeCommand):
(khtml::SplitTextNodeCommand::doApply):
(khtml::SplitTextNodeCommand::doUnapply):
* khtml/editing/split_text_node_command.h:
(khtml::SplitTextNodeCommand::~SplitTextNodeCommand):
(khtml::SplitTextNodeCommand::node):
* khtml/editing/split_text_node_containing_element.cpp:
(khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
(khtml::SplitTextNodeContainingElementCommand::doApply):
* khtml/editing/split_text_node_containing_element_command.h:
(khtml::SplitTextNodeContainingElementCommand::~SplitTextNodeContainingElementCommand):
* khtml/editing/visible_position.cpp:
(khtml::makeRange):
* khtml/editing/visible_position.h:
* khtml/editing/visible_text.cpp:
(khtml::TextIterator::range):
(khtml::SimplifiedBackwardsTextIterator::range):
(khtml::CharacterIterator::range):
(khtml::findPlainText):
* khtml/editing/visible_text.h:
(khtml::WordAwareIterator::range):
* khtml/editing/wrap_contents_in_dummy_span_command.cpp:
(khtml::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
(khtml::WrapContentsInDummySpanCommand::doApply):
(khtml::WrapContentsInDummySpanCommand::doUnapply):
* khtml/editing/wrap_contents_in_dummy_span_command.h:
(khtml::WrapContentsInDummySpanCommand::~WrapContentsInDummySpanCommand):
* kwq/DOMHTML.mm:
(-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
(-[DOMHTMLDocument _createDocumentFragmentWithText:]):
* kwq/WebCoreBridge.mm:
(-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]):
(-[WebCoreBridge documentFragmentWithText:]):
(-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 08:23:38 +0000 (08:23 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Darin.
- Add tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
Javascript cloneNode(deep) does not clone form elements correctly
* fast/dom/clone-node-form-elements-expected.txt: Added.
* fast/dom/clone-node-form-elements.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 3 Jan 2006 08:12:29 +0000 (08:12 +0000)]
2006-01-03 Anders Carlsson <andersca@mac.com>
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
Javascript cloneNode(deep) does not clone form elements correctly
* khtml/html/html_elementimpl.cpp:
(HTMLElementImpl::cloneNode):
Call copyNonAttributeProperties on the new node.
* khtml/html/html_formimpl.cpp:
(DOM::HTMLInputElementImpl::copyNonAttributeProperties):
* khtml/html/html_formimpl.h:
Copy m_value, m_checked and m_indeterminate here.
* khtml/xml/dom_docimpl.cpp:
(DocumentImpl::importNode):
Call copyNonAttributeProperties on the new node.
* khtml/xml/dom_elementimpl.cpp:
(ElementImpl::cloneNode):
Call copyNonAttributeProperties on the new node.
* khtml/xml/dom_elementimpl.h:
(DOM::ElementImpl::copyNonAttributeProperties):
Add function declaration.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 3 Jan 2006 05:15:21 +0000 (05:15 +0000)]
Reviewed by Eric.
- moved frame traversal logic from WebFrame to WebBridge
http://bugzilla.opendarwin.org/show_bug.cgi?id=6341
To do this, I had to invert the ownership so that WebBridge now
owns WebFrame instead of vice versa. As a result, WebView now owns
a WebBridge pointer and does not have a direct WebFrame pointer.
* WebCoreSupport.subproj/WebBridge.h:
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge initWithFrameName:view:]): The initializer is now responsible for creating
the frame, so pass it what it needs to do that.
(-[WebBridge dealloc]): The bridge now owns the frame, so release it.
(-[WebBridge close]): ditto
(-[WebBridge firstChild]): Moved from WebFrame
(-[WebBridge lastChild]): ditto
(-[WebBridge childCount]): ditto
(-[WebBridge previousSibling]): ditto
(-[WebBridge nextSibling]): ditto
(-[WebBridge isDescendantOfFrame:]): ditto
(-[WebBridge traverseNextFrameStayWithin:]): ditto
(-[WebBridge appendChild:]): ditto
(-[WebBridge removeChild:]): ditto
* WebView.subproj/WebFrame.m:
(-[WebFrame _removeChild::]): Call WebBridge version
(-[WebFramePrivate dealloc]): ditto
(-[WebFrame _firstChildFrame]): ditto
(-[WebFrame _lastChildFrame]): ditto
(-[WebFrame _childFrameCount]): ditto
(-[WebFrame _previousSiblingFrame]): ditto
(-[WebFrame _nextSiblingFrame]): ditto
(-[WebFrame _traverseNextFrameStayWithin:]): ditto
(-[WebFrame _appendChild:]): ditto
(-[WebFrame _removeChild:]): ditto
(-[WebFrame _isDescendantOfFrame:]): ditto,
(-[WebFrame _detachFromParent]): reorder a bit to avoid losing our bridge
pointer before the bridge is due to release us, and don't release the
bridge any more since it now owns us
(-[WebFrame _initWithName:webFrameView:webView:bridge:]): new initializer,
we no longer create the bridge, instead it is passed in
(-[WebFrame initWithName:webFrameView:webView:]): Call the new designated
initializer, but this method is no longer viable and should be deprecated.
* WebView.subproj/WebFrameInternal.h:
* WebView.subproj/WebView.m: WebView was changed to hold onto
the WebBridge for the main frame instead of the WebFrame.
(-[WebViewPrivate dealloc]): update for the fact that we hold
a bridge now, not a frame.
(-[WebView _close]): ditto
(-[WebView _createFrameNamed:inParent:allowsScrolling:]): Create
a bridge, not a frame.
(-[WebView _commonInitializationWithFrameName:groupName:]): ditto.
(-[WebView setDefersCallbacks:]): get mainFrame via method
(-[WebView mainFrame]): Update to get the main frame properly
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 3 Jan 2006 03:48:59 +0000 (03:48 +0000)]
Rubber stamped by Eric.
- remove the no longer used QIntDict
* kwq/KWQIntDict.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 3 Jan 2006 02:07:14 +0000 (02:07 +0000)]
Reviewed by Eric.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5609
XSLT document() doesn't handle relative paths
Test case: fast/xsl/xslt-relative-path.xml
* khtml/xsl/xslt_processorimpl.cpp:
(DOM::docLoaderFunc): Renamed from stylesheetLoadFunc. Use base URL when constructing URLs.
(DOM::XSLTProcessorImpl::transformToString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Tue, 3 Jan 2006 00:13:35 +0000 (00:13 +0000)]
Reviewed by Maciej.
- fix for <rdar://problem/
4389622> *Pan EU2* iframe swallows events for overlapping elements (part 2)
We originally added a call to passSubframeEventToSubframe here to fix the hand cursor updating problem
reported in <rdar://problem/
4316201> REGRESSION: cursor and text in status bar is not updated when
mousing over links in a frame (5509). However, when we return early after passSubframeEventToSubframe,
we fail to fire onmouseout events. Since the call to passSubframeEventToSubframe was originally added
to fix the hand cursor updating problem, remove the early return and make cursor updating conditional
on passSubframeEventToSubframe.
* khtml/khtmlview.cpp:
(KHTMLView::viewportMouseMoveEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 31 Dec 2005 00:14:29 +0000 (00:14 +0000)]
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=4557
rename unusual strcmp and strcasecmp for DOMString family
Added new functions named equal and equalIgnoringCase.
* khtml/xml/dom_stringimpl.h: Changed the type of the length parameter to computeHash to unsigned
to match the rest of the interface. Added equal and equalIgnoringCase functions. Added a
version of the hash function that works on char* to CaseInsensitiveHash as preparation for an
atomic string change.
* khtml/xml/dom_stringimpl.cpp: Moved the QT_ALLOC_QCHAR_VEC and QT_DELETE_QCHAR_VEC macros
here, and changed them into inline functions.
(DOM::equal): Implemented.
(DOM::equalIgnoringCase): Implemented.
(DOM::DOMStringImpl::computeHash): Changed parameter type to unsigned to match other similar
functions.
* khtml/dom/dom_string.h: Removed unnecessary friend declarations. Changed operator
overloads for == and != to call through inline to DOMStringImpl. Replaced strcasecmp
with equalIgnoringCase, overloaded for one more combination of parameters. Removed strcmp.
* khtml/dom/dom_string.cpp: Removed functions that are now implemented in DOMStringImpl*.
* khtml/xml/dom_atomicstring.h: Removed a redundant const. Removed unnecessary
friend declarations. Removed AtomicString::equal. Filled out a larger set of == and
!= operator implementations, mostly with inlines calling through to DOMStringImpl.
Renamed equalsIgnoreCase to equalIgnoringCase and filled out a larger set as above.
* khtml/xml/dom_atomicstring.cpp: Renamed AtomicString::equal to just ==.
Removed some implementation of == and equalsIgnoreCase that are replaced by inlines.
* khtml/html/html_listimpl.cpp:
(DOM::HTMLOListElementImpl::parseMappedAttribute):
(DOM::HTMLLIElementImpl::parseMappedAttribute):
Use the "==" operator instead of strcmp.
* khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
Use equalIgnoringCase instead of equalsIgnoreCase.
* khtml/rendering/render_form.cpp:
(RenderSlider::updateFromElement): Fixed bug where a temporary DOMString was put into
a const DOMString&. Changed some DOMString to AtomicString as appropriate, and also
used equalIgnoringCase instead of strcasecmp.
(RenderSlider::slotSliderValueChanged): More of the same.
* khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Replaced use of strcasecmp
with equalIgnoringCase. Added parentheses to fix incorrect operator precedence in one case
(&& binds tighter than ||) which fixes a crash when using a http-equiv pragma when there
is no part (not sure how to reproduce that).
* khtml/khtml_part.cpp:
(updateState):
(KHTMLPart::selectionStartHasStyle):
* khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
* khtml/editing/apply_style_command.cpp:
(khtml::StyleChange::checkForLegacyHTMLStyleChange):
(khtml::StyleChange::currentlyHasStyle):
(khtml::hasTextDecorationProperty):
(khtml::ApplyStyleCommand::extractTextDecorationStyle):
(khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
* khtml/html/html_baseimpl.cpp:
(HTMLBodyElementImpl::parseMappedAttribute):
(HTMLFrameElementImpl::parseMappedAttribute):
* khtml/html/html_blockimpl.cpp:
(HTMLDivElementImpl::parseMappedAttribute):
(HTMLHRElementImpl::parseMappedAttribute):
(HTMLParagraphElementImpl::parseMappedAttribute):
(HTMLMarqueeElementImpl::parseMappedAttribute):
* khtml/html/html_elementimpl.cpp:
(HTMLElementImpl::parseMappedAttribute):
(HTMLElementImpl::addHTMLAlignment):
(HTMLElementImpl::setContentEditable):
* khtml/html/html_formimpl.cpp:
(DOM::HTMLFormElementImpl::parseMappedAttribute):
(DOM::HTMLButtonElementImpl::parseMappedAttribute):
(DOM::HTMLInputElementImpl::setInputType):
(DOM::HTMLInputElementImpl::parseMappedAttribute):
(DOM::HTMLKeygenElementImpl::appendFormData):
(DOM::HTMLTextAreaElementImpl::parseMappedAttribute):
* khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::parseMappedAttribute):
* khtml/html/html_inlineimpl.cpp: (DOM::HTMLBRElementImpl::parseMappedAttribute):
* khtml/html/html_tableimpl.cpp: (DOM::HTMLTablePartElementImpl::parseMappedAttribute):
* khtml/html/htmlparser.cpp: (HTMLParser::handleError):
Use equalIgnoringCase instead of strcasecmp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 30 Dec 2005 22:17:09 +0000 (22:17 +0000)]
Reviewed by Darin, landed by ap.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5461
Text width measured incorrectly when text-align: justify
WebCore:
* khtml/rendering/font.h:
* khtml/rendering/font.cpp:
(khtml::Font::selectionRectForText): Added.
* khtml/rendering/render_text.cpp:
(kthml::InlineTextBox::selectionRect): Use selectionRectForText. This
works for justified text as well, and avoids intermediate rounding which
resulted in selection rects narrower than AppKit's.
(khtml::InlineTextBox::positionForOffset): Use selectionRectForText,
which works for justified text as well.
* kwq/KWQFontMetrics.h:
* kwq/KWQFontMetrics.mm:
(QFontMetrics::selectionRectForText): Added.
* kwq/WebCoreTextRenderer.h:
WebKit:
* WebCoreSupport.subproj/WebTextRenderer.m:
(-[WebTextRenderer selectionRectForRun:style:geometry:]): Added.
(CG_drawHighlight): Use new function CG_selectionRect.
(CG_selectionRect): New function to compute the selection rect.
Eliminated rounding hackery that was required for keeping the highlight
rect within the selection rect computed by
InlineTextBox::selectionRect, since the latter uses this function now.
The new selection rect is wider and matches AppKit more closely,
although the right hand side is roundf()ed instead of cielf()ed for
optimal caret positioning.
(ATSU_drawHighlight): Use new function ATSU_selectionRect.
(ATSU_selectionRect): New function to compute the selection rect.
Much like CG_selectionRect.
LayoutTests:
* fast/text/justified-text-rect-expected.checksum: Added.
* fast/text/justified-text-rect-expected.png: Added.
* fast/text/justified-text-rect-expected.txt: Added.
* fast/text/justified-text-rect.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 30 Dec 2005 21:23:32 +0000 (21:23 +0000)]
- Fix bugzilla.opendarwin.org/show_bug.cgi?id=6289
REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect
* khtml/editing/visible_text.cpp:
(khtml::TextIterator::rangeFromLocationAndLength):
Only special-case (0, 0) ranges for empty documents.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 30 Dec 2005 21:22:18 +0000 (21:22 +0000)]
Forgot to commit this
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 21:16:19 +0000 (21:16 +0000)]
Bug #: 6305
Submitted by: eseidel
Reviewed by: ggaren
Missing CSS Style sheets in one of the XHTML tests in WebCore
http://bugzilla.opendarwin.org/show_bug.cgi?id=6305
* fast/parser/entities-in-xhtml.xhtml: removed <link> to css sheet
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 30 Dec 2005 20:43:09 +0000 (20:43 +0000)]
Remove conflict marker from ChangeLog
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 30 Dec 2005 20:42:15 +0000 (20:42 +0000)]
WebCore:
Added test case for <rdar://problem/
4268278> Submitting a form in onUnload event
handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
* manual-tests/onunload-form-submit-crash.html: Added.
WebKit:
Reviewed by Eric.
Manual testcase added:
WebCore/manual-tests/onunload-form-submit-crash.html
- Fixed <rdar://problem/
4268278> Submitting a form in onUnload event
handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]
The problem is that the form submission in the unload event kicks off
a new load in the midst of the load that caused the unload event to
fire in the first place, so the two loads stomp each other.
The solution is to cancel the first load and let the unload handler's
load win. (Firefox does the same.)
* WebView.subproj/WebFrame.m:
(-[WebFrame _transitionToCommitted:]): Moved call to -closeURL up
the call stack to _continueLoadRequest. (See below.) This has the
side-effect of always firing the unload event, even if the new
datasource never becomes committed, which seems like a good thing.
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
Call -closeURL here, instead of in _transitionToCommitted, so that the
unload handler can fire before we initialize any part of the load.
Check provisionalDataSource for nil to discover if the unload event
kicked off its own load.
Cleared up some coments.
(-[WebFrame _detachFromParent]):
It turns out that if you close the window instead of just navigating
to a new page, you get an alternate assertion failure/crash because
the load kicked off by the unload event handler generates resource
loader callbacks after the associated WebFrame/WebView has disappeared.
The nifty solution here is just to reverse the order of calls to
-stopLoading and -closeURL, thus guaranteeing that -stopLoading has the
last word when you close a window.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 30 Dec 2005 14:53:39 +0000 (14:53 +0000)]
2005-12-30 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
- Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
XMLSerializer should use createMarkup
* fast/dom/XMLSerializer.html:
* fast/dom/XMLSerializer-expected.txt:
Create a document fragment and serialize it.
* fast/dom/dom-parse-serialize.html:
* fast/dom/dom-parse-serialize-expected.txt:
Add some entities to attributes and text nodes.
* fast/xsl/xslt-processer-expected.txt:
Update test results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 30 Dec 2005 14:51:31 +0000 (14:51 +0000)]
2005-12-30 Anders Carlsson <andersca@mac.com>
Reviewed by Eric.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
XMLSerializer should use createMarkup.
* khtml/ecma/xmlserializer.cpp:
(KJS::XMLSerializerProtoFunc::callAsFunction):
Use createMarkup instead of NodeImpl::toString.
* khtml/editing/markup.cpp:
(khtml::startMarkup):
escape attribute values and ignore document fragment nodes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 30 Dec 2005 09:57:22 +0000 (09:57 +0000)]
No review, just test result update.
* tests/mozilla/expected.html: Updated for newly passing test from recent fixes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 09:48:56 +0000 (09:48 +0000)]
Bug #: 6299
Submitted by: eseidel
Reviewed by: mjs
No functional changes, thus no layout test.
Just removes debug NSLog() calls from ksvg2/kcanvas.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6299
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(KCanvasFilterQuartz::prepareFilter):
(KCanvasFilterQuartz::applyFilter):
(KCanvasFilterQuartz::getCIFilterStack):
(KCanvasFilterQuartz::imageForName):
(KCanvasFEBlendQuartz::getCIFilter):
(KCanvasFEColorMatrixQuartz::getCIFilter):
(KCanvasFEGaussianBlurQuartz::getCIFilter):
* kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
(KCanvasClipperQuartz::applyClip):
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(KRenderingDeviceContextQuartz::mapFromVisual):
(KRenderingDeviceContextQuartz::mapToVisual):
(KRenderingDeviceQuartz::createResource):
(KRenderingDeviceQuartz::createFilterEffect):
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(drawShadingWithStyle):
(KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
(KRenderingPaintServerPatternQuartz::draw):
* ksvg2/svg/svgpathparser.cpp:
(SVGPathParser::parseSVG):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 30 Dec 2005 09:44:50 +0000 (09:44 +0000)]
2005-12-30 Anders Carlsson <andersca@mac.com>
Reviewed by Maciej.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6298
Getter setter test is failing
* kjs/object.cpp:
(KJS::JSObject::put):
Rework the getter setter part. We now walk the prototype chain, checking for
getter/setter properties and only take the slow path if any are found.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 09:27:21 +0000 (09:27 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: No review, just adding a couple missing results.
One missing pixel test.
One result which never was updated properly after rounded rect fix:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
* svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
* fast/parser/xhtml-alternate-entities-expected.checksum: Added.
* fast/parser/xhtml-alternate-entities-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 30 Dec 2005 08:51:24 +0000 (08:51 +0000)]
Reviewed by Darin, landed by Maciej.
- land test case documenting wontfix status for certain overflow/table behavior
http://bugzilla.opendarwin.org/show_bug.cgi?id=3505
* fast/overflow/overflow-auto-table-expected.checksum: Added.
* fast/overflow/overflow-auto-table-expected.png: Added.
* fast/overflow/overflow-auto-table-expected.txt: Added.
* fast/overflow/overflow-auto-table.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 08:49:02 +0000 (08:49 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none, just updating stale results
No review, updating stale results.
I went over all the interesting ones with mjs and hyatt.
* css2.1/t040304-c64-uri-00-a-g-expected.checksum:
* css2.1/t040304-c64-uri-00-a-g-expected.png:
* css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
* css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
* css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
* css2.1/t100801-c544-valgn-02-d-agi-expected.png:
* dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum:
* dom/xhtml/level2/html/HTMLBaseElement02-expected.png:
* dom/xhtml/level2/html/frame-expected.checksum:
* dom/xhtml/level2/html/frame-expected.png:
* dom/xhtml/level2/html/iframe-expected.checksum:
* dom/xhtml/level2/html/iframe-expected.png:
* editing/selection/extend-by-word-002-expected.checksum:
* editing/selection/extend-by-word-002-expected.png:
* fast/css/imageTileOpacity-expected.checksum:
* fast/css/imageTileOpacity-expected.png:
* fast/forms/001-expected.checksum:
* fast/forms/001-expected.png:
* fast/frames/empty-frame-src-expected.checksum:
* fast/frames/empty-frame-src-expected.png:
* fast/frames/invalid-expected.checksum:
* fast/frames/invalid-expected.png:
* fast/frames/valid-expected.checksum:
* fast/frames/valid-expected.png:
* svg/custom/conditional-processing-outside-switch-expected.txt:
* svg/custom/control-points-for-S-and-T-expected.txt:
* svg/custom/fill-update-expected.txt:
* svg/custom/junk-data-expected.txt:
* svg/custom/missing-xlink-expected.txt:
* svg/custom/path-bad-data-expected.txt:
* svg/custom/path-update-expected.txt:
* svg/custom/simpleCDF-expected.txt:
* svg/custom/transform-ignore-after-invalid-expected.txt:
* svg/custom/transform-invalid-expected.txt:
* svg/custom/transform-with-ending-space-expected.txt:
* svg/custom/use-forward-refs-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 30 Dec 2005 08:18:47 +0000 (08:18 +0000)]
No review.
- updated test results for Number.toString() fixes:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6259>
* fast/js/kde/Number-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 30 Dec 2005 08:14:12 +0000 (08:14 +0000)]
Reviewed and committed by Maciej.
- Handle negative, FP numbers with non-10 radix in toString
http://bugzilla.opendarwin.org/show_bug.cgi?id=6259
(Merged from KJS, original work by Harri Porten)
* kjs/number_object.cpp:
(NumberProtoFunc::callAsFunction): rewrote Number.toString(radix) to work with
negative numbers, floating point and very large numbers.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 07:38:26 +0000 (07:38 +0000)]
Bug #: 6155
Submitted by: eseidel
Reviewed by: none, just updating pixel results
Updating results, after landing color-matching change.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6155
* svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
* svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
* svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
* svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
* svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
* svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
* svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
* svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
* svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
* svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
* svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
* svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
* svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
* svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
* svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
* svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
* svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
* svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
* svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
* svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
* svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
* svg/custom/conditional-processing-outside-switch-expected.checksum:
* svg/custom/conditional-processing-outside-switch-expected.png:
* svg/custom/control-points-for-S-and-T-expected.checksum:
* svg/custom/control-points-for-S-and-T-expected.png:
* svg/custom/fill-update-expected.checksum:
* svg/custom/fill-update-expected.png:
* svg/custom/junk-data-expected.checksum:
* svg/custom/junk-data-expected.png:
* svg/custom/missing-xlink-expected.checksum:
* svg/custom/missing-xlink-expected.png:
* svg/custom/path-bad-data-expected.checksum:
* svg/custom/path-bad-data-expected.png:
* svg/custom/path-update-expected.checksum:
* svg/custom/path-update-expected.png:
* svg/custom/simpleCDF-expected.checksum:
* svg/custom/simpleCDF-expected.png:
* svg/custom/simpleCDF-expected.txt:
* svg/custom/transform-ignore-after-invalid-expected.checksum:
* svg/custom/transform-ignore-after-invalid-expected.png:
* svg/custom/transform-ignore-after-invalid.svg:
* svg/custom/transform-invalid-expected.checksum:
* svg/custom/transform-invalid-expected.png:
* svg/custom/transform-with-ending-space-expected.checksum:
* svg/custom/transform-with-ending-space-expected.png:
* svg/custom/use-forward-refs-expected.checksum:
* svg/custom/use-forward-refs-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 07:33:03 +0000 (07:33 +0000)]
Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel
WebCore+SVG has some problems with rounded rectangles
http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
* svg/custom/rounded-rects-expected.checksum: Added.
* svg/custom/rounded-rects-expected.png: Added.
* svg/custom/rounded-rects-expected.txt: Added.
* svg/custom/rounded-rects.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 30 Dec 2005 07:05:54 +0000 (07:05 +0000)]
Reviewed by Eric, committed by Maciej.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6288
HEAD build broken 12/29/2005
* WebCoreSupport.subproj/WebTextRenderer.m:
(overrideLayoutOperation): Use previous character from the buffer
instead of ch which may be uninitialized on the first iteration.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 07:04:10 +0000 (07:04 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
Move WebView width/height logic into DumpRenderTree to support
running the W3C SVG 1.1 tests along side other tests. The W3C
SVG 1.1 tests require a 480x360 view.
* DumpRenderTree/DumpRenderTree.m:
(main): don't accept width/height
(dump): override width/height for SVG/W3C
* Scripts/run-webkit-tests: don't pass width/height
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 30 Dec 2005 06:46:57 +0000 (06:46 +0000)]
LayoutTests:
Reviewed and refined by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
In-place style-switching is leaving junk behind, messing up styles
* fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
* fast/css/margin-top-bottom-dynamic-expected.png: Added.
* fast/css/margin-top-bottom-dynamic-expected.txt: Added.
* fast/css/margin-top-bottom-dynamic.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
In-place style-switching is leaving junk behind, messing up styles
* khtml/rendering/render_block.h: (khtml::RenderBlock::initMaxMarginValues):
Set all margin values in all cases.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 06:43:09 +0000 (06:43 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: No review, only removing dead code.
* DumpKCanvasTree/DumpKCanvasTree.m: Removed.
* DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 06:38:53 +0000 (06:38 +0000)]
Bug #: 6155
Submitted by: eseidel
Reviewed by: darin
DumpRenderTree should set a consistent color profile while running
http://bugzilla.opendarwin.org/show_bug.cgi?id=6155
Creates consistent colormatched renderings on every test machine
using the only way possible with Tiger APIs: by setting the
system color profile on the test machine for the duration of the
tests. This will (unfortunately) cause colors to change while
running DumpRenderTree. This can also cause "permanent" color
changes to occur if DRT is to crash (SIGSEGV, etc.) while running.
This is far from ideal, but it's be best way we've found to deal
with the issue for now.
* DumpRenderTree/DumpRenderTree.m:
(restoreColorSpace):
(setDefaultColorProfileToRGB):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 05:51:39 +0000 (05:51 +0000)]
Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs
XML documents with "html" in dtd name use XHTML entities when they shouldn't
http://bugzilla.opendarwin.org/show_bug.cgi?id=6290
* fast/parser/xhtml-alternate-entities-expected.txt: Added.
* fast/parser/xhtml-alternate-entities.xml: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 05:43:23 +0000 (05:43 +0000)]
Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs
XML documents with "html" in dtd name use XHTML entities when they shouldn't
http://bugzilla.opendarwin.org/show_bug.cgi?id=6290
* khtml/xml/xml_tokenizer.cpp:
(khtml::externalSubsetHandler): check for exact xhtml types
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 05:40:07 +0000 (05:40 +0000)]
Bug #: 6295
Submitted by: eseidel
Reviewed by: mjs
Close leak in CollectionInfo due to HashMap migration
http://bugzilla.opendarwin.org/show_bug.cgi?id=6295
* khtml/html/html_miscimpl.cpp:
(DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
* khtml/html/html_miscimpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 05:33:17 +0000 (05:33 +0000)]
Bug #: 6101
Submitted by: eseidel
Reviewed by: mjs
Leaks in XSLTProcessorImpl due to early exit in failure case
http://bugzilla.opendarwin.org/show_bug.cgi?id=6101
* khtml/xsl/xslt_processorimpl.cpp:
(DOM::xmlDocPtrFromNode): add "shouldDelete" argument
(DOM::XSLTProcessorImpl::transformToString): delete new'd xmlDoc
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 30 Dec 2005 05:11:47 +0000 (05:11 +0000)]
WebCore:
Reviewed by Eric.
- finished frame traversal cleanup
http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
* kwq/WebCoreBridge.h: Removed childFrames method from WebCoreBridge protocol
since it is not actually used.
WebKit:
Reviewed by Eric.
- finished frame traversal cleanup
http://bugzilla.opendarwin.org/show_bug.cgi?id=6293
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge childFrames]): Removed (this was unused)
* WebView.subproj/WebFrame.m:
(-[WebFrame _removeChild::]): Moved to FrameTraversal category.
(-[WebFrame _childFrameCount]): New frame traversal method to avoid
getting the count from the array directly.
(-[WebFrame _appendChild:]): Factored out the parts of addChild: that
seem directly relevant to adding a child.
(-[WebFrame _removeChild:]): Moved to FrameTraversal category.
(-[WebFrame _detachChildren]): Don't deallocate children array because
there's no particular need to.
(-[WebFrame _setDataSource:]): make the assert use _childFrameCount
(-[WebFrame _opened]):
(-[WebFrame _checkLoadComplete]): Instead of checking all frames starting
from the main frame, check this frame and all ancestors. If a resource
for a frame completes, that con only possibly finish loading for that
frame and its ancestors, not any other frame in the tree.
(-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed.
(-[WebFrame _childFramesMatchItem:]): Get child frame count in the new
approved way.
(-[WebFrame _internalChildFrames]): removed
(-[WebFrame _addChild:]): Use _appendChild: for most of the work.
(-[WebFrame _generateFrameName]): Get child frame count in the new
approved way.
(-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms,
upon further consideration there's no need to copy part of the frame tree here.
(-[WebFrame findFrameNamed:]): Remove extra braces.
(-[WebFrame childFrames]): Make a new array using the frame traversal methods.
* WebView.subproj/WebFramePrivate.h: Remove some methods.
* WebView.subproj/WebMainResourceLoader.m:
(-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current
frame not the main frame (before there was no difference and now the new version is
what is desired).
* WebView.subproj/WebView.m:
(-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space
(-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces
and update FIXME comment.
(-[WebView _receivedError:fromDataSource:]): Remove stray space
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 04:11:49 +0000 (04:11 +0000)]
Bug #: 6230
Submitted by: eseidel
Reviewed by: build fix only.
File accidentally omitted from previous commit.
Remove QDict from khtml/html
http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
* khtml/ecma/kjs_html.cpp:
(KJS::KJS::HTMLCollection::getNamedItems):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 03:33:54 +0000 (03:33 +0000)]
Bug #: 6230
Submitted by: eseidel
Reviewed by: mjs
Remove QDict from khtml/html
http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
Uses HashMap instead.
* khtml/html/html_miscimpl.cpp:
(DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo):
(DOM::HTMLCollectionImpl::CollectionInfo::reset):
(DOM::HTMLCollectionImpl::namedItem):
(DOM::HTMLCollectionImpl::updateNameCache):
(DOM::HTMLCollectionImpl::namedItems):
(DOM::HTMLCollectionImpl::nextNamedItem):
(DOM::HTMLFormCollectionImpl::nextNamedItemInternal):
(DOM::HTMLFormCollectionImpl::updateNameCache):
* khtml/html/html_miscimpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 03:27:21 +0000 (03:27 +0000)]
Bug #: 6228
Submitted by: eseidel
Reviewed by: mjs
DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString
http://bugzilla.opendarwin.org/show_bug.cgi?id=6228
Added find(), contains(), startsWith() and endsWith() to DOMString
Uses the above functions throughout the code.
Small performance boost.
* khtml/css/css_base.cpp:
(CSSSelector::print):
* khtml/css/css_ruleimpl.cpp:
(DOM::CSSImportRuleImpl::init):
* khtml/css/css_valueimpl.cpp:
(DOM::CSSStyleDeclarationImpl::setProperty):
* khtml/css/cssparser.cpp:
(CSSParser::parseValue):
(CSSParser::parseDeclaration):
(CSSParser::parseContent):
* khtml/css/cssstyleselector.cpp:
(khtml::CSSStyleSelector::CSSStyleSelector):
(khtml::CSSStyleSelector::setEncodedURL):
(khtml::parseUASheet):
(khtml::cleanpath):
(khtml::CSSStyleSelector::checkSelector):
(khtml::CSSStyleSelector::checkOneSelector):
(khtml::CSSRuleSet::addRulesFromSheet):
(khtml::CSSStyleSelector::applyProperty):
* khtml/dom/dom_string.cpp:
* khtml/dom/dom_string.h:
(DOM::DOMString::contains):
(DOM::DOMString::find):
(DOM::DOMString::startsWith):
(DOM::DOMString::endsWith):
* khtml/html/html_formimpl.cpp:
(DOM::HTMLFormElementImpl::parseEnctype):
* khtml/khtml_part.cpp:
(KHTMLPart::requestFrame):
(KHTMLPart::submitForm):
* khtml/misc/decoder.cpp:
(Decoder::decode):
* khtml/xml/dom_atomicstring.h:
(DOM::AtomicString::length):
(DOM::AtomicString::operator []):
(DOM::AtomicString::contains):
(DOM::AtomicString::find):
(DOM::AtomicString::startsWith):
(DOM::AtomicString::endsWith):
* khtml/xml/dom_docimpl.cpp:
(DocumentImpl::processHttpEquiv):
* khtml/xml/dom_stringimpl.cpp:
(DOM::equal):
(DOM::equalCaseInsensitive):
(DOM::DOMStringImpl::find):
(DOM::DOMStringImpl::endsWith):
* khtml/xml/dom_stringimpl.h:
(DOM::DOMStringImpl::startsWith):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 03:23:52 +0000 (03:23 +0000)]
Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel
WebCore+SVG has some problems with rounded rectangles
http://bugzilla.opendarwin.org/show_bug.cgi?id=6157
* ksvg2/svg/SVGRectElementImpl.cpp:
(SVGRectElementImpl::toPathData): fixed round rect calculations
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 30 Dec 2005 02:42:46 +0000 (02:42 +0000)]
Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel
http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
Support HTML entities on pages parsed as XHTML
* fast/parser/entities-in-xhtml-expected.txt: Added.
* fast/parser/entities-in-xhtml.xhtml: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 30 Dec 2005 00:43:11 +0000 (00:43 +0000)]
Updated test results for the last few JavaScriptCore patches
I checked in.
* ChangeLog:
* fast/js/array-float-delete-expected.txt: Added.
* fast/js/kde/Date-expected.txt:
* fast/js/kde/Number-expected.txt:
* fast/js/kde/StringObject-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 30 Dec 2005 00:37:53 +0000 (00:37 +0000)]
Reviewed by Darin.
- abstract frame traversal in WebFrame more
http://bugzilla.opendarwin.org/show_bug.cgi?id=6283
Rewrote most of the frame traversal code in WebFrame to use DOM-style
first/last/next/previous methods, to abstract access better in preparation
for moving it down.
As an added bonus, many formerly recursive methods are now iterative.
* WebKit.xcodeproj/project.pbxproj: Use gnu99 dialect of C, so that
variables can be declared in for loop initializers.
- added new frame traversal methods, to avoid dealing with the children array
directly:
* WebView.subproj/WebFrame.m:
(-[WebFrame _firstChildFrame]): New method.
(-[WebFrame _lastChildFrame]): New method.
(-[WebFrame _previousSiblingFrame]): New method.
(-[WebFrame _nextSiblingFrame]): New method.
(-[WebFrame _traverseNextFrameStayWithin:]): Like traverseNextNode() in the DOM;
uses some of the previous.
- apply the new methods
(-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Rewrite loop
to use new traversal methods.
(-[WebFrame _immediateChildFrameNamed:]): ditto, also added FIXME
(-[WebFrame _setName:]): Improved comment, removed gratuitous brace
(-[WebFrame _isDescendantOfFrame:]): Rewrote to chase parent pointers instead
of looking in child arrays (duh)
(-[WebFrame _detachChildren]): Rewrite loop to use new traversal methods,
still walk backwards for now.
(-[WebFrame _closeOldDataSources]): Rewrite using new traversal methods.
(-[WebFrame _childFramesMatchItem:]): ditto
(-[WebFrame _defersCallbacksChanged]): ditto
(-[WebFrame _viewWillMoveToHostWindow:]): ditto
(-[WebFrame _viewDidMoveToHostWindow]): ditto
(-[WebFrame _addChild:]): don't use childFrames method
(-[WebFrame _removeChild:]): Clear out the sibling pointers after unlinking from the list,
not obvious if anything needs this but it seems like the right thing to do.
(-[WebFrame _generateFrameName]): don't bother to nil-check children array, since
calling count on nil still gives 0.
(-[WebFrame _saveDocumentAndScrollState]): Rewrite to use frame traversal methods
(-[WebFrame _deepLastChildFrame]): renamed from _lastChildFrame, rewrite to use child
traversal methods.
(-[WebFrame _nextFrameWithWrap:]): Use new frame traversal stuff (mostly just
a thin wrapper on _traverseNextFrameStayWithin:
(-[WebFrame _previousFrameWithWrap:]): Use new traversal functions
(-[WebFrame _numPendingOrLoadingRequests:]): Rewrite loop with new tracrsal functions
(-[WebFrame _reloadForPluginChanges]): ditto
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): ditto
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): ditto
(-[WebFrame _documentViews]): ditto
(-[WebFrame _updateDrawsBackground]): ditto
(-[WebFrame _unmarkAllMisspellings]): ditto
(-[WebFrame _atMostOneFrameHasSelection]): ditto
(-[WebFrame _findFrameWithSelection]): ditto
(-[WebFrame _stopLoadingSubframes]): ditto
(-[WebFrame _subframeIsLoading]): ditto
(-[WebFrame _descendantFrameNamed:sourceFrame:]): ditto
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 29 Dec 2005 23:49:04 +0000 (23:49 +0000)]
Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel, ggaren, darin
- http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
Support HTML entities on pages parsed as XHTML
Added layout tests:
* fast/parser/entities-in-xhtml.xhtml
* khtml/xml/xml_tokenizer.cpp:
(khtml::XMLTokenizer::setIsXHTMLDocument): Track whether the XML document is XHTML.
(khtml::XMLTokenizer::isXHTMLDocument): Ditto.
(khtml::externalSubsetHandler): Ditto.
(khtml::XMLTokenizer::finish): Ditto.
(khtml::getXHTMLEntity): Look up the HTML entity.
(khtml::getEntityHandler): Look up the HTML entity if this is an XHTML document.
* khtml/html/kentities.h: Added.
* khtml/html/kentities.gperf: changed entity to Entity
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit.git / log