WebKit.git
11 years agoFix zoom related tests when testing WebKit2.
weinig@apple.com [Sun, 12 Sep 2010 02:15:59 +0000 (02:15 +0000)]
Fix zoom related tests when testing WebKit2.

Reviewed by Maciej Stachowiak.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 12 Sep 2010 02:08:33 +0000 (02:08 +0000)]
2010-09-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Skip some new tests that depend on APIs missing from WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=45607

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
weinig@apple.com [Sun, 12 Sep 2010 01:50:30 +0000 (01:50 +0000)]
Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
<rdar://problem/8359252>
https://bugs.webkit.org/show_bug.cgi?id=45605

Reviewed by Dan Bernstein.

WebKit2:

* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::setStatusText):
* UIProcess/WebPageProxy.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::setStatusText):
* UIProcess/WebUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setStatusbarText):

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(setStatusText):
(contentsSizeChanged):
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(contentsSizeChanged):
(BrowserView::create):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd callback mechanism for the getting the source of a frame
weinig@apple.com [Sun, 12 Sep 2010 01:17:52 +0000 (01:17 +0000)]
Add callback mechanism for the getting the source of a frame
<rdar://problem/8364681>
https://bugs.webkit.org/show_bug.cgi?id=45604

Reviewed by Dan Bernstein.

WebKit2:

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetSourceForFrame):
(callGetSourceForFrameBlockBlockAndDispose):
(WKPageGetSourceForFrame_b):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didGetSourceForFrame):
(WebKit::WebPageProxy::processDidExit):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::source):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getSourceForFrame):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:

WebKitTools:

Add ability to dump the main frame's source to the console.

* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController dumpSourceToConsole:]):
* MiniBrowser/mac/MainMenu.xib:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Sep 2010 23:25:17 +0000 (23:25 +0000)]
2010-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove unneeded Empty Queue messages
        https://bugs.webkit.org/show_bug.cgi?id=45602

        We already have a /gc job to delete these.
        recentstatus.py is already smart enough to use the
        most recent of the workitems last update or the most recent status,
        so removing these should not change the _last_status_date() return
        value more than a few milliseconds.

        These messages just spam the recent status log.

        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
hausmann@webkit.org [Sat, 11 Sep 2010 19:15:45 +0000 (19:15 +0000)]
Unreviewed.

[Qt] Trivial V8 build fix.

* WebCore.pri: Add storage, workers and css to the include paths for the
JS code generator.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 18:28:51 +0000 (18:28 +0000)]
2010-09-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] V8 port: Fix "WTF::String::utf8" returns incomplete type WTF::CString
        https://bugs.webkit.org/show_bug.cgi?id=45157

        Include CString.h where necessary. Chromium builds would get it from
        KURLGooglePrivate.h so this is only an issue for Qt + V8.

        * bindings/v8/V8Proxy.cpp:
        * inspector/InspectorDebuggerAgent.cpp:
        * inspector/InspectorProfilerAgent.cpp:
        * plugins/PluginDatabase.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] V8 port: webkit project files changes
hausmann@webkit.org [Sat, 11 Sep 2010 18:22:14 +0000 (18:22 +0000)]
[Qt] V8 port: webkit project files changes
https://bugs.webkit.org/show_bug.cgi?id=45140

Reviewed by Andreas Kling.

.:

* WebKit.pro: Don't compile JavaScriptCore and jsc when
building with v8.

WebCore:

* WebCore.pro: Removed unecessary common.pri inclusion from earlier patch.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: [Qt] V8 port: webcore project files changes
hausmann@webkit.org [Sat, 11 Sep 2010 18:11:05 +0000 (18:11 +0000)]
JavaScriptCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

* JavaScriptCore.pro: Moved wtf specific files to wtf.pri,
so that they can also be used from WebCore.pro for v8 builds.
* wtf/wtf.pri: Added.

WebCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

Modify webcore project files to include V8 javascript engine. By default disabled.

* WebCore.pri:
* WebCore.pro:
* features.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 18:09:54 +0000 (18:09 +0000)]
2010-09-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        Web Inspector: Include CString.h in generated files

        This is necessary for generated code that uses the CString
        returned by String::utf8() (from generateBackendDispatcher)

        Chromium builds already get CString.h from KURLGooglePrivate.h
        so this issue only occurs when building Qt against V8.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 17:44:17 +0000 (17:44 +0000)]
2010-09-11  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] V8 port for Qt platform: Qt WebCoreSupport changes
        https://bugs.webkit.org/show_bug.cgi?id=45149

        Original patch by Vlad Burlik <volodimir.burlik@nokia.com>

        Implemented the V8 specifics needed in DumpRenderTreeSupportQt and
        FrameLoaderClientQt.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::javaScriptObjectsCount):
        (DumpRenderTreeSupportQt::garbageCollectorCollect):
        (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
        (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::didCreateScriptContextForFrame):
        (WebCore::FrameLoaderClientQt::didDestroyScriptContextForFrame):
        (WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext):
        (WebCore::FrameLoaderClientQt::createDocumentLoader):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 11 Sep 2010 17:42:29 +0000 (17:42 +0000)]
2010-09-11  Martin Robinson  <mrobinson@igalia.com>

        Add a platform-specific result after r67281.

        * platform/gtk/fast/dynamic/first-letter-display-change-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 17:09:07 +0000 (17:09 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Fix Python exception when generating synthetic patch IDs
        https://bugs.webkit.org/show_bug.cgi?id=45592

        Can't concatenate strings and numbers directly.

        * QueueStatusServer/handlers/queuestatus.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Vlad Burlik <volodimir.burlik@nokia.com>
andreas.kling@nokia.com [Sat, 11 Sep 2010 17:06:57 +0000 (17:06 +0000)]
2010-09-11  Vlad Burlik  <volodimir.burlik@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] V8 port for QT platform: QT API implementation changes
        https://bugs.webkit.org/show_bug.cgi?id=45148

        V8 Implementation of QWebFrame::addToJavaScriptWindowObject()
        and QWebFrame::evaluateJavaScript()

        * Api/qwebelement.cpp:
        (setupScriptContext): JSC and V8 variations
        (QWebElement::evaluateJavaScript):
        * Api/qwebelement.h:
        * Api/qwebframe.cpp: QObject injection to V8 world
        (QWebFrame::addToJavaScriptWindowObject):
        (QWebFrame::evaluateJavaScript):
        * Api/qwebpage.cpp: Use ScriptController type definitions instead of direct references to JSC or V8
        (QWebPagePrivate::QWebPagePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 11 Sep 2010 16:25:58 +0000 (16:25 +0000)]
2010-09-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Make introspection work with g-o-i 0.9.5
        https://bugs.webkit.org/show_bug.cgi?id=45590

        Bump required gobject-introspection version to 0.9.5.

        * configure.ac:

WebKit/gtk:

2010-09-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Make introspection work with g-o-i 0.9.5
        https://bugs.webkit.org/show_bug.cgi?id=45590

        Use new type syntax and bump version number of the gir file.

        * JSCore.gir.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Sep 2010 16:19:30 +0000 (16:19 +0000)]
2010-09-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        chromium fast/dom/replaceChild.html regression by r67182
        https://bugs.webkit.org/show_bug.cgi?id=45527

        Turns out this is a progression!  Our new images
        match minefield (and sanity).  The old image had a
        border drawn which should have been removed when the
        iframe was replaced.

        Other platforms may need to update their results as well.

        * platform/mac/fast/dom/replaceChild-expected.checksum:
        * platform/mac/fast/dom/replaceChild-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 11 Sep 2010 16:09:25 +0000 (16:09 +0000)]
2010-09-11  Robert Hogan  <robert@webkit.org>

        Unreviewed, unskip passing test.

        Test fixed by http://trac.webkit.org/changeset/56511

        See https://bugs.webkit.org/show_bug.cgi?id=36492

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 15:04:58 +0000 (15:04 +0000)]
2010-09-11  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Fix EFL build after r67274
        https://bugs.webkit.org/show_bug.cgi?id=45584

        Remove include of ZoomMode.h and change setZoomFactor and zoomFactor
        to proper apis chaged by r67264.

        * ewk/ewk_frame.cpp:
        (ewk_frame_zoom_get):
        (ewk_frame_zoom_set):
        (ewk_frame_zoom_text_only_get):
        (ewk_frame_zoom_text_only_set):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=45587
adele@apple.com [Sat, 11 Sep 2010 13:20:26 +0000 (13:20 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=45587
Move line clamp code to its own function.

Reviewed by Sam Weinig.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutVerticalBox):
(WebCore::RenderFlexibleBox::applyLineClamp):
* rendering/RenderFlexibleBox.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 10:06:21 +0000 (10:06 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        Group statuses in queue status by patch ID
        https://bugs.webkit.org/show_bug.cgi?id=45588

        Group statuses by patch ID so that the status page is easier
        to scan.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/stylesheets/dashboard.css:
        (.status-group):
        (.status-bug):
        (.status-group ul):
        (.status-group ul li):
        (.status-group ul li:hover):
        (.status-cell):
        (.status-cell:hover):
        (.status-cell.pass):
        (.status-cell.fail):
        (.status-cell.pending):
        (.status-cell.error):
        * QueueStatusServer/templates/dashboard.html:
        * QueueStatusServer/templates/queuestatus.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 09:48:54 +0000 (09:48 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=45479

        Remove tests from Chromium expectations that now pass. Add
        Chromium/Linux expectations for the script test, since it reports a
        different MIME type (application/javascript vs.
        application/x-javascript).

        * platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
        * platform/chromium-linux/fast/preloader/script-expected.txt: Added.
        * platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=45479

        Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
        implementation in ResourceLoadDelegate in the Mac port).

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::dumpResourceResponseMIMETypes):
        (LayoutTestController::reset):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
        (LayoutTestController::shouldDumpResourceResponseMIMETypes):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::shouldDumpResourceResponseMIMETypes):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didReceiveResponse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Sat, 11 Sep 2010 09:32:12 +0000 (09:32 +0000)]
2010-09-11  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] remove passing test svg/custom/transform-ignore-after-invalid.svg
        https://bugs.webkit.org/show_bug.cgi?id=45579

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 08:59:57 +0000 (08:59 +0000)]
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        URIs in styles created via innerHTML are not resolved against the document's base URI
        https://bugs.webkit.org/show_bug.cgi?id=45565

        Add test to read back the background image URL from an element that was
        created via innerHTML (reduction of http://crbug.com/55023).

        * fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
        * fast/innerHTML/innerHTML-uri-resolution.html: Added.
2010-09-11  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        URIs in styles created via innerHTML are not resolved against the document's base URI
        https://bugs.webkit.org/show_bug.cgi?id=45565

        The dummy document used for fragment parsing created by
        FragmentParsingContext should use the base URI of the fragment's
        document. Since (HTML)Document doesn't expose a setter for the base URI
        (and shouldn't), we allow it to be set by the constructor/create
        function.

        Also remove some obsolete code that references the legacy tree builder
        from HTMLElement that I happened to notice.

        Test: fast/innerHTML/innerHTML-uri-resolution.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::HTMLDocument):
        * html/HTMLDocument.h:
        (WebCore::HTMLDocument::create):
        * html/HTMLElement.cpp:
        (WebCore::createFragmentFromSource):
        (WebCore::HTMLElement::setInnerHTML):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd NetworkingContext to avoid layer violations https://bugs.webkit.org/show_bug...
diegohcg@webkit.org [Sat, 11 Sep 2010 07:54:15 +0000 (07:54 +0000)]
Add NetworkingContext to avoid layer violations https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-09-10
Reviewed by Darin Adler.

WebCore:

Activate NetworkingContext:

Since the ResourceHandle::create, ResourceHandle::start and
ResourceHandle::loadResourceSynchronously API's were modified,
having their Frame* parameter substituted by a NetworkingContext*,
all implementations of them were also modified.
This patch also modifies all functions that were calling the above
ones.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):
* loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::load):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
* loader/icon/IconFetcher.cpp:
(WebCore::IconFetcher::loadEntry):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::start):

WebKit/chromium:

* src/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

WebKit/gtk:

* webkit/webkitdownload.cpp:
(webkit_download_start):
* webkit/webkitprivate.cpp:
(currentToplevelCallback):

WebKit/win:

* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::blockedError):
* WebCoreSupport/WebFrameNetworkingContext.h:

WebKit2:

* WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:
* WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Sep 2010 07:23:45 +0000 (07:23 +0000)]
2010-09-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queues.webkit.org should expose /remote_api for data upload/download
        https://bugs.webkit.org/show_bug.cgi?id=45559

        * QueueStatusServer/app.yaml:
         - /remote_api is a standard app-engine service which allows use of
           the bulk uploader for data upload/download.  Exposing this
           (for admin access only) allows us to use

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 yi shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 07:07:00 +0000 (07:07 +0000)]
2010-09-10  yi shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] selected text gets deleted when qgraphicswebview losts focus
        https://bugs.webkit.org/show_bug.cgi?id=45539

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNo review; build fix only.
jer.noble@apple.com [Sat, 11 Sep 2010 06:52:42 +0000 (06:52 +0000)]
No review; build fix only.

<CoreGraphics/CGAffineTransform.h> isn't on the build bots either.  Wrap
all references to m_movieTransform in #if USE(ACCELERATED_COMPOSITING) guards.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveAndResetMovieTransform):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd zoom support to WebKit2 API
weinig@apple.com [Sat, 11 Sep 2010 06:45:41 +0000 (06:45 +0000)]
Add zoom support to WebKit2 API
<rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45585

Reviewed by Dan Bernstein.

WebKit2:

- Add UIProcess API for setting zoom factors.
- Change bundle zoom API to be in terms of doubles
  for consistency.

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetTextZoomFactor):
(WKPageSetTextZoomFactor):
(WKPageGetPageZoomFactor):
(WKPageSetPageZoomFactor):
(WKPageSetPageAndTextZoomFactors):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setTextZoomFactor):
(WebKit::WebPageProxy::setPageZoomFactor):
(WebKit::WebPageProxy::setPageAndTextZoomFactors):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::textZoomFactor):
(WebKit::WebPageProxy::pageZoomFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
(WebKit::WebPage::setPageAndTextZoomFactors):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:

WebKitTools:

- Add zoom options to MiniBrowser that mimic Safari's options using
  the new WebKit2 zoom APIs.
- Switch uses of float for the zoom APIs to use double.

* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController validateMenuItem:]):
(-[BrowserWindowController validateUserInterfaceItem:]):
(-[BrowserWindowController currentZoomFactor]):
(-[BrowserWindowController setCurrentZoomFactor:]):
(-[BrowserWindowController canZoomIn]):
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController canZoomOut]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController canResetZoom]):
(-[BrowserWindowController resetZoom:]):
(-[BrowserWindowController toggleZoomMode:]):
* MiniBrowser/mac/MainMenu.xib:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNo review; build fix only.
jer.noble@apple.com [Sat, 11 Sep 2010 06:36:16 +0000 (06:36 +0000)]
No review; build fix only.

<CoreGraphics/CGFloat.h> does not exist on the build bots.  Replace
instances of CGFAbs() with abs().

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 11 Sep 2010 06:24:36 +0000 (06:24 +0000)]
2010-09-10  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
        https://bugs.webkit.org/show_bug.cgi?id=45333

        The rootChild layer must be set as flipped, otherwise transformed movies will appear
        incorrectly rotated.

        * FullscreenVideoController.cpp:
        (FullscreenVideoController::enterFullscreen):
2010-09-10  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

        Test: fast/dynamic/first-letter-display-change.html

        * rendering/RenderBlock.cpp:
        (WebCore::styleForFirstLetter): Factored this helper function out.
        (WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the
        “update style” and “create new” branches use the same terminology. In the
        update case, if the style change requires a new renderer, handle it.
        * rendering/RenderTextFragment.h:
        (WebCore::toRenderTextFragment): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 11 Sep 2010 06:19:18 +0000 (06:19 +0000)]
2010-09-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=45563
        Assertion failure: useTransforms when scrolling to an SVG element

        This has been indirectly fixed in r63633, just adding a test.

        * svg/custom/scroll-to-svg-element-assertion-expected.txt: Added.
        * svg/custom/scroll-to-svg-element-assertion.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix chromium build.
weinig@apple.com [Sat, 11 Sep 2010 05:57:02 +0000 (05:57 +0000)]
Fix chromium build.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 11 Sep 2010 05:55:46 +0000 (05:55 +0000)]
2010-09-10  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix crash in DRT in standalone mode

        https://bugs.webkit.org/show_bug.cgi?id=45454

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating
mitz@apple.com [Sat, 11 Sep 2010 05:55:18 +0000 (05:55 +0000)]
<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

Reviewed by Darin Adler.

WebCore:

Test: fast/dynamic/first-letter-display-change.html

* rendering/RenderBlock.cpp:
(WebCore::styleForFirstLetter): Factored this helper function out.
(WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the
“update style” and “create new” branches use the same terminology. In the
update case, if the style change requires a new renderer, handle it.
* rendering/RenderTextFragment.h:
(WebCore::toRenderTextFragment): Added.

LayoutTests:

* fast/dynamic/first-letter-display-change-expected.checksum: Added.
* fast/dynamic/first-letter-display-change-expected.png: Added.
* fast/dynamic/first-letter-display-change-expected.txt: Added.
* fast/dynamic/first-letter-display-change.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Sep 2010 05:50:54 +0000 (05:50 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, speculative chromium build fix.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setZoomLevel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Sep 2010 05:31:02 +0000 (05:31 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed.

        Added editing/style/style-3690704-fix.html to the gtk's skipped list
        since the test requires editing delegates, which hasn't been implemented in gtk.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Sat, 11 Sep 2010 05:21:17 +0000 (05:21 +0000)]
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        Application cache directory should be checked before sending to the web process
        https://bugs.webkit.org/show_bug.cgi?id=45462

        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::WebProcessProxy): Check the return value of
        m_context->applicationCacheDirectoy() to avoid sending a null string
        to the web process what makes it asserting.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Sep 2010 05:08:40 +0000 (05:08 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html should use runDumpAsTextEditingTest
        https://bugs.webkit.org/show_bug.cgi?id=45578

        Modified insert-3659587-fix.html and style-3690704-fix.html to use runDumpAsTextEditingTest().

        * editing/inserting/insert-3659587-fix-expected.txt: Added.
        * editing/inserting/insert-3659587-fix.html:
        * editing/style/style-3690704-fix-expected.txt: Added.
        * editing/style/style-3690704-fix.html:
        * platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
        * platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.png: Removed.
        * platform/chromium-linux/editing/style/style-3690704-fix-expected.checksum: Removed.
        * platform/chromium-linux/editing/style/style-3690704-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
        * platform/chromium-win/editing/inserting/insert-3659587-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/chromium-win/editing/style/style-3690704-fix-expected.checksum: Removed.
        * platform/chromium-win/editing/style/style-3690704-fix-expected.png: Removed.
        * platform/chromium-win/editing/style/style-3690704-fix-expected.txt: Removed.
        * platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/gtk/editing/style/style-3690704-fix-expected.txt: Removed.
        * platform/mac/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
        * platform/mac/editing/inserting/insert-3659587-fix-expected.png: Removed.
        * platform/mac/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/mac/editing/style/style-3690704-fix-expected.checksum: Removed.
        * platform/mac/editing/style/style-3690704-fix-expected.png: Removed.
        * platform/mac/editing/style/style-3690704-fix-expected.txt: Removed.
        * platform/qt/editing/inserting/insert-3659587-fix-expected.txt: Removed.
        * platform/qt/editing/style/style-3690704-fix-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build.
weinig@apple.com [Sat, 11 Sep 2010 04:11:47 +0000 (04:11 +0000)]
Fix Qt build.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix GTK build.
weinig@apple.com [Sat, 11 Sep 2010 04:09:12 +0000 (04:09 +0000)]
Fix GTK build.

* webkit/webkitwebview.cpp:
(webkit_web_view_set_full_content_zoom):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove unnecessary constraint in WebCore of choosing either text zoom or full page...
weinig@apple.com [Sat, 11 Sep 2010 04:01:43 +0000 (04:01 +0000)]
Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
Precursor to <rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45522

Reviewed by Darin Adler.

WebCore:

* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Remove ZoomMode.h

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
Remove uses of shouldApplyTextZoom(), it had turned into just a compare to 1.0f.

* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Convert these to use the explicit pageZoomFactor() function, it made no sense for text zoom
anyway.

* page/Frame.h:
Remove include of ZoomMode.h

* page/FrameView.cpp:
(WebCore::parentPageZoomFactor):
(WebCore::parentTextZoomFactor):
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setPageZoomFactor):
(WebCore::FrameView::setTextZoomFactor):
(WebCore::FrameView::setPageAndTextZoomFactors):
* page/FrameView.h:
(WebCore::FrameView::pageZoomFactor):
(WebCore::FrameView::textZoomFactor):
Change FrameView to store two values for zoom, one for page zoom and one for text zoom.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
Removed zoom mode.

* page/ZoomMode.h: Removed.

* rendering/RenderView.cpp:
(WebCore::RenderView::zoomFactor):
Remove now unnecessary call to shouldApplyPageZoom since it will be 1 if it should
be ignored.

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setCurrentScale):
Use explicit setPageZoomFactor function.

WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::createPlugin):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setZoomLevel):
* src/WebViewImpl.h:
(WebKit::WebViewImpl::zoomTextOnly):
Move tracking of text only zoom here from WebCore.

WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_get_zoom_level):
(webkit_web_view_apply_zoom_level):
(webkit_web_view_set_full_content_zoom):

WebKit/mac:

* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
(-[WebView _setZoomMultiplier:isTextOnly:]):
(-[WebView _realZoomMultiplierIsTextOnly]):
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
(-[WebViewPrivate init]):
Move tracking of text only zoom here from WebCore.

WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::setTextSizeMultiplier):
(QWebFrame::textSizeMultiplier):
(QWebFrame::setZoomFactor):
(QWebFrame::zoomFactor):
* Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
Move tracking of text only zoom here from WebCore.

WebKit/win:

* WebFrame.cpp:
* WebFrame.h:
Remove dead code.

* WebView.cpp:
(WebView::WebView):
(WebView::setZoomMultiplier):
(WebView::zoomMultiplier):
(WebView::canMakeTextLarger):
(WebView::makeTextLarger):
(WebView::canMakeTextSmaller):
(WebView::makeTextSmaller):
(WebView::notifyPreferencesChanged):
* WebView.h:
Move tracking of text only zoom here from WebCore.

WebKit2:

Now that WebCore doesn't require a mode, change the bundle API for zoom to not
require one either.

* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageStopLoading):
(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
* WebProcess/WebPage/WebPage.h:

WebKitTools:

Update for changes to the Bundle API to allow separate control of page and text zoom
levels.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Sat, 11 Sep 2010 03:59:32 +0000 (03:59 +0000)]
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] Implement port specific part of WebKit::InjectedBundle
        https://bugs.webkit.org/show_bug.cgi?id=45541

        * WebProcess/InjectedBundle/InjectedBundle.h: Typedef PlatformBundle as QLibrary for qt.
        * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
        (WebKit::InjectedBundle::load): Implemented.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Sat, 11 Sep 2010 03:42:09 +0000 (03:42 +0000)]
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        * fast/notifications/notifications-click-event-expected.txt:
        * platform/qt/Skipped:
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        Propagate click events to JavaScript from either the
        platform plugn or from QSystemTrayIcon.
        Also added the method NotificationWrapper::openerPageUrl so that
        if the platform plugin can reopen the page that created the
        notification directly, when the user clicks the notification.

        Added DumpRenderTreeSupportQt::simulateDesktopNotificationClick
        for testing purpose.

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (WebCore::NotificationWrapper::openerPageUrl):
        (WebCore::NotificationWrapper::notificationClicked):
        (WebCore::NotificationPresenterClientQt::displayNotification):
        (WebCore::NotificationPresenterClientQt::notificationClicked):
        * WebCoreSupport/NotificationPresenterClientQt.h:
        * examples/platformplugin/WebNotificationPresenter.cpp:
        (WebNotificationWidget::event):
        * examples/platformplugin/WebNotificationPresenter.h:
        (WebNotificationPresenter::WebNotificationPresenter):
        * examples/platformplugin/qwebkitplatformplugin.h:
2010-09-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Support click event for notifications
        https://bugs.webkit.org/show_bug.cgi?id=44836

        Add support for simulateDesktopNotificationClick by calling
        back to DumpRenderTreeSupportQt.cpp.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::simulateDesktopNotificationClick):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Sat, 11 Sep 2010 03:25:05 +0000 (03:25 +0000)]
2010-09-10  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Andreas Kling.

        Add a define missing when building with glib unicode backend
        https://bugs.webkit.org/show_bug.cgi?id=45544

        * wtf/unicode/glib/UnicodeMacrosFromICU.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 02:47:17 +0000 (02:47 +0000)]
2010-09-10  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Fix warnings because of bad assignments in testatk.c
        https://bugs.webkit.org/show_bug.cgi?id=45538

        Use AtkObject and AtkText instances properly in the code.

        * tests/testatk.c:
        (testWebkitAtkListsOfItems):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Mihai Parparita <mihaip@chromium.org>
abarth@webkit.org [Sat, 11 Sep 2010 02:33:08 +0000 (02:33 +0000)]
2010-09-10  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        Update queue status when patches fail their first land attempt
        https://bugs.webkit.org/show_bug.cgi?id=45583

        Add a few more _update_status calls to make it more obvious if a patch is
        being retried because tests failed.

        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Sep 2010 02:28:20 +0000 (02:28 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Attempt to fix the failign Qt tests.  This patch adapts code from
        Chromium.  The long-term fix is to remove the need for this code, but
        that's a bit too complicated for a buildfix patch.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
        (WebCore::FrameLoaderClientQt::makeRepresentation):
        (WebCore::FrameLoaderClientQt::revertToProvisionalState):
        (WebCore::FrameLoaderClientQt::finishedLoading):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Sat, 11 Sep 2010 02:27:14 +0000 (02:27 +0000)]
2010-09-10  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed build fix for EFL.

        [EFL] REGRESSION(67167) build break because of newly added JSBindingState.cpp
        https://bugs.webkit.org/show_bug.cgi?id=45537

        * CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Sat, 11 Sep 2010 01:56:49 +0000 (01:56 +0000)]
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] MiniBrowser crashes with multiply windows when closing one of them
        https://bugs.webkit.org/show_bug.cgi?id=45536

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::~QWKPage): Do not call WKPageTerminate since this is designed
        to terminate the web process. We are correctly detaching the page without
        this call anyway.
2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Andreas Kling.

        [Qt] MiniBrowser crashes with multiply windows when closing one of them
        https://bugs.webkit.org/show_bug.cgi?id=45536

        * MiniBrowser/qt/BrowserView.cpp:
        (BrowserView::BrowserView): Reference the context instead of adopting it
        because it can be shared across different views.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: Refactor JavaScriptCore memory statistics so that WebKit doesn't...
slewis@apple.com [Sat, 11 Sep 2010 01:40:45 +0000 (01:40 +0000)]
JavaScriptCore: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know
about the JIT and other implementation details of JavaScriptCore.  Necessary
to fix PPC build.

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45528

* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/MemoryStatistics.cpp: Added.
(JSC::memoryStatistics):
* runtime/MemoryStatistics.h: Added.

WebKit/mac: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
other implementation details of JavaScriptCore.  Necessary to fix PPC build.

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45528

* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics memoryStatistics]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 11 Sep 2010 01:28:15 +0000 (01:28 +0000)]
2010-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45582

        * WebKit.xcodeproj/project.pbxproj: Added WebDashboardRegion.h/mm and
        also gave the header private visibility so it will get installed in the
        PrivateHeaders directory.
2010-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45582

        * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::dashboardRegionsChanged): Changed this to call
        -[WebView _dashboardRegions] so we don't have two copies of that code.

        * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
        * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.

        * WebView/WebView.mm:
        (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
2010-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45582

        * WebCore.exp.in: Updated.

        * WebCore.xcodeproj/project.pbxproj: Removed WebDashboardRegion.h/m.
        * page/mac/WebDashboardRegion.h: Removed.
        * page/mac/WebDashboardRegion.m: Removed.

        * page/Frame.h: Removed unneeded #if. Removed dashboardRegionsDictionary function, now
        handled in WebKit. Removed searchForNSLabelsAboveCell function, which had become dead code.
        * page/mac/FrameMac.mm: Ditto. Also tweaked a place that said "int unsigned".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake middle clicks not fire DOM onclick events.
pkasting@chromium.org [Sat, 11 Sep 2010 01:16:12 +0000 (01:16 +0000)]
Make middle clicks not fire DOM onclick events.
https://bugs.webkit.org/show_bug.cgi?id=22382

Reviewed by Darin Adler.

WebCore:

* html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the
computation of what constitutes a link click, since they're no longer
implicitly included.
(WebCore::isLinkClick):
* html/HTMLInputElement.cpp: Removed unneeded checks that click events
are coming from the left mouse button, since they all are now.
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):
* page/EventHandler.cpp: Changed logic to send a click event only for
the left button.
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

* fast/events/mouse-click-events-expected.txt:
* fast/events/script-tests/mouse-click-events.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows Build Fix. Fix some fallout from r67238, currentForm is now off of
bweinstein@apple.com [Sat, 11 Sep 2010 01:07:23 +0000 (01:07 +0000)]
Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
SelectionController instead of frame. Also fix a style issue.

* WebFrame.cpp:
(WebFrame::currentForm):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Sep 2010 01:03:34 +0000 (01:03 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Attempted build fix for Qt Minimal.

        * dom/Element.cpp:
        (WebCore::Element::getBoundingClientRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 11 Sep 2010 00:58:39 +0000 (00:58 +0000)]
2010-09-10  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Need to rebaseline a bunch of files resulting from the SVG change
        in r67200.

        https://bugs.webkit.org/show_bug.cgi?id=45580

        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.txt
        * platform/chromium-win/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt
        * platform/chromium-win/svg/batik/text/textAnchor2-expected.txt
        * platform/chromium-win/svg/batik/text/textAnchor3-expected.txt
        * platform/chromium-win/svg/batik/text/textLayout-expected.txt
        * platform/chromium-win/svg/batik/text/textLayout2-expected.txt
        * platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt
        * platform/chromium-win/svg/batik/text/textPosition-expected.txt
        * platform/chromium-win/svg/batik/text/textPosition2-expected.txt
        * platform/chromium-win/svg/custom/text-letter-spacing-expected.txt
        * platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt
        * platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt
        * platform/chromium-win/svg/text/select-x-list-1-expected.txt
        * platform/chromium-win/svg/text/select-x-list-2-expected.txt
        * platform/chromium-win/svg/text/select-x-list-3-expected.txt
        * platform/chromium-win/svg/text/select-x-list-4-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt
        * platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt
        * platform/chromium-win/svg/text/text-text-04-t-expected.txt
        * platform/chromium-win/svg/text/text-text-05-t-expected.txt
        * platform/chromium-win/svg/text/text-text-06-t-expected.txt
        * platform/chromium-win/svg/text/text-text-07-t-expected.txt
        * platform/chromium-win/svg/text/text-tspan-01-b-expected.txt

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Sat, 11 Sep 2010 00:53:09 +0000 (00:53 +0000)]
2010-09-10  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        Pseudostyle resolution corrupts cached child index values
        https://bugs.webkit.org/show_bug.cgi?id=45574

        Covered by fast/dom/firstline-fixed-crash.html and fast/dom/firstletter-tablecell-crash.html.

        RenderBlock::updateFirstLetter() calls getCachedPseudoStyle() passing as the parent style the
        style of the parent of the first letter, which is not always the parent of the element for
        which we are getting :first-letter style. As a result, style resolution caches childIndex values
        in the wrong element’s style.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::pseudoStyleForElement): Create the new style and inherit from
        the parent style before matching rules, to avoid corrupting the parent style itself.
        (WebCore::CSSStyleSelector::checkSelector): Always pass the element’s parent style as
        the parent style here.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Removed the null check that was added
        in r67183.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak): Removed the null check that was added
        in r67184.
2010-09-10  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        Pseudostyle resolution corrupts cached child index values
        https://bugs.webkit.org/show_bug.cgi?id=45574

        * fast/dom/firstline-fixed-crash-expected.txt: Updated results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNo review; build fix only.
jer.noble@apple.com [Sat, 11 Sep 2010 00:50:59 +0000 (00:50 +0000)]
No review; build fix only.

Touch mediaControlsQuickTime in order to trigger the UserAgentStyleSheet.h to be rebuilt.

* css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Sep 2010 00:49:48 +0000 (00:49 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::committedLoad):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::commitDocumentData):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        This code didn't know that setEncoding can be called multiple times.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
        (WebCore::FrameLoaderClientQt::finishedLoading):
        (WebCore::FrameLoaderClientQt::setMainDocumentError):
        (WebCore::FrameLoaderClientQt::committedLoad):
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
        (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
        * WebCoreSupport/FrameLoaderClientQt.h:
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::committedLoad):
        * WebCoreSupport/WebFrameLoaderClient.h:
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        This code is the most confused, but now should be a bit cleaner.
        There's still a magical fake-setting for creating renderers that needs
        to be cleaned up, but we can do that in a separate patch.

        * WebView/WebFrame.mm:
        (-[WebFrame _commitData:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation receivedData:withDataSource:]):
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        This code didn't know that setEncoding could be called multiple times
        safely.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl):
        (WebCore::FrameLoaderClientEfl::committedLoad):
        (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
        (WebCore::FrameLoaderClientEfl::finishedLoading):
        (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading):
        (WebCore::FrameLoaderClientEfl::setMainDocumentError):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        There's a bunch of code that's copy/pasted (poorly) across all the
        ports that really belongs in WebCore.  This patch moves that logic into
        DocumentLoader.  This patch is a step on the path to having
        DocumentLoader own DocumentWriter.

        * WebCore.exp.in:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::commitData):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        Move code from WebKit-layer to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=45569

        This code looks copy/pasted from Mac.  It's unclear whether whether all
        the complexity is needed here, but I don't have a good way to find out.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::committedLoad):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Sat, 11 Sep 2010 00:47:30 +0000 (00:47 +0000)]
2010-09-10  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Nikolas Zimmermann.

        getBoundingClientRect Broken for SVG Elements
        https://bugs.webkit.org/show_bug.cgi?id=42815

        Added tests for getBoundingClientRect applied to SVG elements.

        * svg/custom/getBoundingClientRect.xhtml: Added
        * svg/custom/getBoundingClientRect-expected.txt: Added
2010-09-10  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Nikolas Zimmermann.

        getBoundingClientRect Broken for SVG Elements
        https://bugs.webkit.org/show_bug.cgi?id=42815

        Use getBBox to retrieve the bounding rectangle for SVG elements.

        Test: svg/dom/getBoundingClientRect.xhtml

        * dom/Element.cpp:
        (Element::getBoundingClientRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-09 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 10 Sep 2010 23:56:16 +0000 (23:56 +0000)]
2010-09-09  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Adopt shared control drawing for <video> controls on Windows
        https://bugs.webkit.org/show_bug.cgi?id=45490

        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:
2010-09-09  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Adopt shared control drawing for <video> controls on Windows
        https://bugs.webkit.org/show_bug.cgi?id=45490

        * DerivedSources.make: Remove the OS check around mediaControlsQuickTime.css.
        * rendering/RenderMediaControls.cpp:
        (WebCore::determineState): Use WKMediaControllerThemeState flags instead of SafariTheme ones.
        (WebCore::getUnzoomedRectAndAdjustCurrentContext): Added. Copied verbatim from RenderMediaMac.mm.
        (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Use wkMeasureMediaUIPart to adjust the thumb size.
        (WebCore::RenderMediaControls::paintMediaControlsPart): Use wkDrawMediaUIPart instead of paintThemePart.
        (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Added. Copied verbatim from RenderMediaMac.mm.
        * rendering/RenderMediaControls.h:
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::adjustSliderThumbSize): Adjust both sliders and volume sliders.
        (WebCore::RenderThemeWin::extraMediaControlsStyleSheet): Added. Returns the mediaControlsQuickTime sheet.
        (WebCore::RenderThemeWin::paintMediaRewindButton): Added. Pass through to RenderMediaControls.
        (WebCore::RenderThemeWin::paintMediaControlsBackground): Added. Pass through to RenderMediaControls.
        (WebCore::RenderThemeWin::paintMediaVolumeSliderContainer): Added. Pass through to RenderMediaControls.
        (WebCore::RenderThemeWin::paintMediaVolumeSliderTrack): Added. Pass through to RenderMediaControls.
        (WebCore::RenderThemeWin::paintMediaVolumeSliderThumb): Added.  Pass through to RenderMediaControls.
        (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Added. Pass through to RenderMediaControls.
        * rendering/RenderThemeWin.h:

2010-09-109  Peter Kasting  <pkasting@google.com>

        Reviewed by Darin Adler.

        Cleanup and simplification in advance of making middle clicks not send a
        click event.
        https://bugs.webkit.org/show_bug.cgi?id=22382

        * editing/DeleteButton.cpp:
        (WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to
        check if the event is a MouseEvent. Any click event will do.
        * html/HTMLAnchorElement.cpp:
        (WebCore::appendServerMapMousePosition): Added. Factors out the
        modifications to the URL to add the mouse position to make the default
        event handler function easier to read.
        (WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make
        the enter key logic separate from the link clicking logic and simplify
        the function.  This makes minor functional changes like not calling
        FrameLoader::urlSelected() for fake "keydown" events constructed from
        JavaScript.
        (WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared
        implementation in treatLinkAsLiveForEventType().
        (WebCore::eventType): Factors out event type calculation (for
        treatLinkAsLiveForEventType()) from the default event handler to make it
        easier to read.
        (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
        Implementation of the portions of isLiveLink() that are common with the
        checks defaultEventHandler() wants to do.
        (WebCore::isEnterKeyKeydownEvent): Added. Shared by the default
        event handlers for all three anchor elements.
        (WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick
        function below and some code in SVG. Later we can make this private to
        this source file once we remove the unneeded SVG code.
        (WebCore::isLinkClick): Added. Shared by the default event handlers for
        all three anchor elements.
        (WebCore::handleLinkClick): Ditto.
        * html/HTMLAnchorElement.h: Added the new functions.
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded
        logic and streamlined the code to more closely match the
        HTMLAnchorElement code and share functions with it.
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::defaultEventHandler): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Sep 2010 23:47:27 +0000 (23:47 +0000)]
2010-09-10  Tony Chang  <tony@chromium.org>

        Unreviewed, fix chromium compile after r67238.

        shouldChangeSelection was removed from Frame.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::selectWordAroundPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate mac/Skipped to include the bug numbers for newly added skip entries.
jianli@chromium.org [Fri, 10 Sep 2010 23:40:28 +0000 (23:40 +0000)]
Update mac/Skipped to include the bug numbers for newly added skip entries.

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Mike Lawther <mikelawther@chromium.org>
commit-queue@webkit.org [Fri, 10 Sep 2010 23:31:20 +0000 (23:31 +0000)]
2010-09-10  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Ojan Vafai.

        [Chromium] Rebaseline transitions/opacity-transition-zindex.html
        https://bugs.webkit.org/show_bug.cgi?id=45515

        Difference was off-by-one on the green channel.

        * platform/chromium-win/transitions/opacity-transition-zindex-expected.checksum: Added.
        * platform/chromium-win/transitions/opacity-transition-zindex-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit2: Set the visible name for the web process
andersca@apple.com [Fri, 10 Sep 2010 22:52:29 +0000 (22:52 +0000)]
WebKit2: Set the visible name for the web process
https://bugs.webkit.org/show_bug.cgi?id=45564
<rdar://problem/8416970>

Reviewed by Mark Rowe and Darin Adler.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::processName):
Add a thread safe implementation of -[NSProcessInfo processName].

(WebKit::ProcessLauncher::launchProcess):
Pass the process name to the child process.

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
Set the visible name.

WebKitLibraries: WebKitSystemInterface part of:
Set the visible name for the web process
https://bugs.webkit.org/show_bug.cgi?id=45564
<rdar://problem/8416970>

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-109 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 10 Sep 2010 22:42:32 +0000 (22:42 +0000)]
2010-09-109  Peter Kasting  <pkasting@google.com>

Reviewed by Darin Adler.

Cleanup and simplification in advance of making middle clicks not send a
click event.
https://bugs.webkit.org/show_bug.cgi?id=22382

* editing/DeleteButton.cpp:
(WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to
check if the event is a MouseEvent. Any click event will do.
* html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition): Added. Factors out the
modifications to the URL to add the mouse position to make the default
event handler function easier to read.
(WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make
the enter key logic separate from the link clicking logic and simplify
the function.  This makes minor functional changes like not calling
FrameLoader::urlSelected() for fake "keydown" events constructed from
JavaScript.
(WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared
implementation in treatLinkAsLiveForEventType().
(WebCore::eventType): Factors out event type calculation (for
treatLinkAsLiveForEventType()) from the default event handler to make it
easier to read.
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
Implementation of the portions of isLiveLink() that are common with the
checks defaultEventHandler() wants to do.
(WebCore::isEnterKeyKeydownEvent): Added. Shared by the default
event handlers for all three anchor elements.
(WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick
function below and some code in SVG. Later we can make this private to
this source file once we remove the unneeded SVG code.
(WebCore::isLinkClick): Added. Shared by the default event handlers for
all three anchor elements.
(WebCore::handleLinkClick): Ditto.
* html/HTMLAnchorElement.h: Added the new functions.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded
logic and streamlined the code to more closely match the
HTMLAnchorElement code and share functions with it.
* wml/WMLAElement.cpp:
(WebCore::WMLAElement::defaultEventHandler): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 10 Sep 2010 22:38:40 +0000 (22:38 +0000)]
2010-09-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Implement HTML5 definition of script for-event neutering
        https://bugs.webkit.org/show_bug.cgi?id=45493

        * fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
        * fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Beef up test with some more cases, change style to be more readable, and remove obsolete comments about supporting for-event.
2010-09-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Implement HTML5 definition of script for-event neutering
        https://bugs.webkit.org/show_bug.cgi?id=45493

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::shouldExecuteAsJavaScript): Same behavior, but reads more like the spec. Removed obsolete comments about supporting for-event.
        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::executeScript): Moved to runScript.
        (WebCore::HTMLScriptRunner::runScript): Checking shouldExecuteAsJavaScript() here means that external scripts which fail the check will never be requested.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Nat Duca <nduca@chromium.org>
darin@chromium.org [Fri, 10 Sep 2010 22:33:14 +0000 (22:33 +0000)]
2010-09-10  Nat Duca  <nduca@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Accelerated Compositing: screen garbage when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=45092

        Split LayerRenderChromium::drawLayers into several different
        functions, responsible for preparing the backbuffer, updating the
        root texture, compositing and performing the final
        swapbuffers. This are then used by the new
        WebViewImpl::composite rendering path.

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::setBounds):
        (WebCore::LayerChromium::setFrame):
        (WebCore::LayerChromium::setNeedsDisplay):
        (WebCore::LayerChromium::resetNeedsDisplay):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::dirtyRect):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::prepareToDrawLayers):
        (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::present):
        * platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 10 Sep 2010 22:26:44 +0000 (22:26 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        execCommand("fontsize") on certain selected html generates too many SPAN tags.
        https://bugs.webkit.org/show_bug.cgi?id=28968

        Added a test to ensure only one font element is added when applying font-size
        to multiple inline nodes.

        * editing/style/apply-font-size-to-multiple-nodes-expected.txt: Added.
        * editing/style/apply-font-size-to-multiple-nodes.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Sep 2010 22:24:01 +0000 (22:24 +0000)]
2010-09-10  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling out r67241.
        http://trac.webkit.org/changeset/67241
        https://bugs.webkit.org/show_bug.cgi?id=44709

        Accidentally committed.

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Sep 2010 22:16:11 +0000 (22:16 +0000)]
2010-09-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        deduplicate-tests should be runnable from any WebKit directory
        https://bugs.webkit.org/show_bug.cgi?id=44709

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 David Holloway <dhollowa@chromium.org>
inferno@chromium.org [Fri, 10 Sep 2010 22:16:07 +0000 (22:16 +0000)]
2010-09-10  David Holloway  <dhollowa@chromium.org>

        Reviewed by Adam Barth.

        Change WebKit::WebFormElement::wasUserSubmitted to use WebCore::HTMLFormElement::submittedByUserGesture
        instead of WebCore::HTMLFormElement::submissionTrigger.
        Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form.  A
        more accurate measure of the user manually submitting a form is via user gesture.
        https://bugs.webkit.org/show_bug.cgi?id=45128

        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::wasUserSubmitted):
2010-09-10  David Holloway  <dhollowa@chromium.org>

        Reviewed by Adam Barth.

        Replace WebCore::HTMLFormElement::submissionTrigger with WebCore::HTMLFormElement::submittedByUserGesture.
        Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form.  A
        more accurate measure of the user manually submitting a form is via user gesture.
        https://bugs.webkit.org/show_bug.cgi?id=45128

        No new tests as this is only used by the Chromium WebKit API.

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::HTMLFormElement):
        (WebCore::HTMLFormElement::prepareSubmit):
        (WebCore::HTMLFormElement::submit):
        (WebCore::HTMLFormElement::submittedByUserGesture):
        * html/HTMLFormElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 10 Sep 2010 22:08:41 +0000 (22:08 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove mention of "part" from Document.cpp
        https://bugs.webkit.org/show_bug.cgi?id=45566

        This is an old KHTML name that's lingering around.

        * dom/Document.cpp:
        (WebCore::Document::parentDocument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-09 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 10 Sep 2010 22:06:47 +0000 (22:06 +0000)]
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::selectionBoundsRect):
        Call functions on selection().
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        * WebView.cpp:
        (WebView::selectionRect):
        (WebView::centerSelectionInVisibleArea):
        Call functions on selection().
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        * WebView/WebFrame.mm:
        (-[WebFrame _selectionGranularity]):
        (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
        (-[WebFrame _typingStyle]):
        (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation currentForm]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView jumpToSelection:]):
        (-[WebHTMLView centerSelectionInVisibleArea:]):
        (-[WebHTMLView _canSmartCopyOrDelete]):
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[WebHTMLView selectionRect]):
        (-[WebHTMLView selectionTextRects]):
        (-[WebHTMLView selectionImageRect]):
        * WebView/WebView.mm:
        (-[WebView setEditable:]):
        Call functions on selection().
2010-09-09  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Move functions from Frame to SelectionController as planned
        https://bugs.webkit.org/show_bug.cgi?id=45508

        Also removed Frame::dragCaretController since it just called Page::dragCaretController.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::modify):
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        (WebCore::SelectionController::selectAll):
        (WebCore::SelectionController::focusedOrActiveStateChanged):
        (WebCore::SelectionController::notifyRendererOfSelectionChange):
        (WebCore::isFrameElement):
        (WebCore::SelectionController::setFocusedNodeIfNeeded):
        (WebCore::SelectionController::paintDragCaret):
        (WebCore::SelectionController::shouldDeleteSelection):
        (WebCore::SelectionController::selectionBounds):
        (WebCore::SelectionController::selectionTextRects):
        (WebCore::scanForForm):
        (WebCore::SelectionController::currentForm):
        (WebCore::SelectionController::revealSelection):
        (WebCore::SelectionController::setSelectionFromNone):
        (WebCore::SelectionController::shouldChangeSelection):
        * editing/SelectionController.h:
        Moved functions here from Frame.

        * page/Frame.cpp:
        * page/Frame.h:
        Moved functions to SelectionController.
        Reorganized header to be easier to read and a bit more logical.

        * WebCore.exp.in: Updated.

        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenWillBeRemoved):
        (WebCore::Document::nodeWillBeRemoved):
        Call Page::dragCaretController directly.

        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance):
        * dom/InputElement.cpp:
        (WebCore::InputElement::updateFocusAppearance):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::editingStyleAtPosition):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        * editing/Editor.cpp:
        (WebCore::Editor::canSmartCopyOrDelete):
        (WebCore::Editor::textDirectionForSelection):
        (WebCore::Editor::appliedEditing):
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::revealSelectionAfterEditingOperation):
        (WebCore::Editor::transpose):
        (WebCore::Editor::changeSelectionAfterCommand):
        (WebCore::Editor::computeAndSetTypingStyle):
        (WebCore::Editor::selectionComputedStyle):
        (WebCore::Editor::styleForSelectionStart):
        (WebCore::Editor::findString):
        * editing/EditorCommand.cpp:
        (WebCore::executeDelete):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::insertTextRunWithoutNewlines):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::updateFocusAppearance):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/DragController.cpp:
        (WebCore::DragController::concludeEditDrag):
        (WebCore::dragLocForSelectionDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectClosestWordFromMouseEvent):
        (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
        (WebCore::EventHandler::handleMousePressEventTripleClick):
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::updateSelectionForMouseDrag):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusInDocumentOrder):
        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::passMousePressEventToSubframe):
        * page/chromium/FrameChromium.cpp:
        (WebCore::Frame::dragImageForSelection):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::selectionImage):
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::writeRange):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):
        Call functions on selection().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Sep 2010 22:04:08 +0000 (22:04 +0000)]
2010-09-10  Simon Fraser  <simon.fraser@apple.com>

        Re-enable some Windows compositing tests that no longer assert.

        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 10 Sep 2010 22:00:28 +0000 (22:00 +0000)]
2010-09-10  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        SVGGElement::rendererIsNeeded should return false when parent isn't SVG
        https://bugs.webkit.org/show_bug.cgi?id=45562

        Test: svg/custom/g-outside-svg.html

        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::rendererIsNeeded):
        * svg/SVGGElement.h:
2010-09-10  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        SVGGElement::rendererIsNeeded should return false when parent isn't SVG
        https://bugs.webkit.org/show_bug.cgi?id=45562

        * svg/custom/g-outside-svg-expected.txt: Added.
        * svg/custom/g-outside-svg.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip file api tests for workers that could crash occasionally before
jianli@chromium.org [Fri, 10 Sep 2010 21:31:08 +0000 (21:31 +0000)]
Skip file api tests for workers that could crash occasionally before
we figure out how to fix them.

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 10 Sep 2010 21:29:44 +0000 (21:29 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Chromium build fix (one hopes!)

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::commitDocumentData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 10 Sep 2010 21:25:13 +0000 (21:25 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
        https://bugs.webkit.org/show_bug.cgi?id=41371

        Drop support for closing comments with "-- >".  This was an attempt to
        be more IE-like in comment parsing, but it turns out to cause problems
        for some high-profile sites.  Firefox 4 is dropping support as well.
        We expect the spec to change soon too.

        * html/parser/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::nextToken):
        * html/parser/HTMLTokenizer.h:
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
        https://bugs.webkit.org/show_bug.cgi?id=41371

        Update test results for new behavior.

        * fast/parser/comments-expected.txt:
        * fast/parser/comments.html:
          - Removed the redundant in-test expectations.
        * html5lib/runner-expected.txt:
          - We now "fail" these two tests.  We'll pass them again once the spec
            changes and HTML5lib updates its expectations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Sep 2010 21:22:41 +0000 (21:22 +0000)]
2010-09-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        compositing/iframes/iframe-src-change.html test fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=45554

        This test had the wrong behavior. It never actually entered compositing mode.
        Now give it a chance to do so (and test for it), and then test that the layers
        disappeared.

        * compositing/iframes/iframe-src-change-expected.txt:
        * compositing/iframes/iframe-src-change.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRestored a Changelog entry for a change that was reverted. I mistakenly thought rever...
cmarrin@apple.com [Fri, 10 Sep 2010 21:10:51 +0000 (21:10 +0000)]
Restored a Changelog entry for a change that was reverted. I mistakenly thought reverted changes should be removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGive expected results files the right names
aroben@apple.com [Fri, 10 Sep 2010 21:04:03 +0000 (21:04 +0000)]
Give expected results files the right names

* platform/win/fast/text/hyphenate-first-word-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-first-word-actual.txt.
* platform/win/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-locale-actual.txt.
* platform/win/html5lib/runner-expected.txt: Renamed from LayoutTests/platform/win/html5lib/runner-actual.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 10 Sep 2010 21:02:52 +0000 (21:02 +0000)]
2010-09-10  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Adding file that should have been in http://trac.webkit.org/changeset/67226 but
        I forgot to svn add.

        * platform/graphics/opengl: Added.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Copied from platform/graphics/mac/GraphicsContext3DMac.mm.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoone more typo fix in Changelog
cmarrin@apple.com [Fri, 10 Sep 2010 20:56:04 +0000 (20:56 +0000)]
one more typo fix in Changelog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agofixed typo in Changelog
cmarrin@apple.com [Fri, 10 Sep 2010 20:54:50 +0000 (20:54 +0000)]
fixed typo in Changelog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Paul Sawaya <psawaya@apple.com>
cmarrin@apple.com [Fri, 10 Sep 2010 20:51:37 +0000 (20:51 +0000)]
2010-09-10  Paul Sawaya  <psawaya@apple.com>

        Reviewed by Chris Marr.

        Refactored non-Mac specific code into GraphicsContext3DOpenGL.

        Moving this file into platform/graphics/mac for now, and only building on Mac.

        https://bugs.webkit.org/show_bug.cgi?id=30625

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoQt build fix.
oliver@apple.com [Fri, 10 Sep 2010 20:28:19 +0000 (20:28 +0000)]
Qt build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 10 Sep 2010 20:01:53 +0000 (20:01 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove useless FrameLoader method
        https://bugs.webkit.org/show_bug.cgi?id=45492

        This method has one caller, and that caller already has a more direct
        way of accessing the correct DocumentLoader.

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::addData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 10 Sep 2010 19:54:10 +0000 (19:54 +0000)]
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        After the MainResourceLoader hands the bytes for the main resource to
        the DocumentLoader, the DocumentLoader hands the bytes to the
        FrameLoaderClient.  The FrameLoaderClient, in turn, returns the bytes
        to WebCore.  Prior to this patch, the FrameLoaderClient returned the
        bytes to the FrameLoader.  However, the FrameLoader was actually adding
        any value.

        In this patch, we change the FrameLoaderClient to return the bytes to
        the DocumentLoader directly.  In a future patch, we'll cut out the
        FrameLoaderClient middleman and handle the bytes internally in the
        DocumentLoader.

        * WebCore.exp.in:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::addData):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument):
        * loader/FrameLoader.h:
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        Also, removed comment about wrong code in the Mac port.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::commitDocumentData):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        Previously, we were checking the document for null.  However, Frame can
        never have a null document, so this check is no longer needed.

        * WebView/WebFrame.mm:
        (-[WebFrame _addData:]):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::receivedData):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::committedLoad):
2010-09-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Main resource bytes shouldn't bounce through FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=45496

        Now return the bytes to the DocumentLoader.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::receivedData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 10 Sep 2010 19:52:53 +0000 (19:52 +0000)]
2010-09-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        Speed up deserialisation of strings
        https://bugs.webkit.org/show_bug.cgi?id=45555

        Rather than building a list of Identifiers for the string pool
        we now build a list of a tuple of UString and JSString*.  This
        doesn't hurt the property name case as ustring->identifier conversion
        is essentially free if the ustring has already been converted to
        an Identifier, but saves an unnecessary Identifier creation for
        strings we only ever use to create JSStrings.  We also reduce
        GC pressure for duplicate strings by caching the JSStrings.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneDeserializer::CachedString::CachedString):
        (WebCore::CloneDeserializer::CachedString::jsString):
        (WebCore::CloneDeserializer::CachedString::ustring):
        (WebCore::CloneDeserializer::readStringData):
        (WebCore::CloneDeserializer::putProperty):
        (WebCore::CloneDeserializer::readFile):
        (WebCore::CloneDeserializer::readTerminal):
        (WebCore::CloneDeserializer::deserialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 10 Sep 2010 19:40:43 +0000 (19:40 +0000)]
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Antonio Gomes.

        REGRESSION(r67176): editing/selection/doubleclick-inline-first-last-contenteditable.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=45525

        The crash was caused by ancestorToRetainStructureAndAppearance not taking into consideration
        the case where there is no common block ancestor. Fixed this by adding a null check.

        Test: editing/pasteboard/copy-without-common-block-crash.html

        * editing/markup.cpp:
        (WebCore::ancestorToRetainStructureAndAppearance): Added a null check.
2010-09-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Antonio Gomes.

        REGRESSION(r67176): editing/selection/doubleclick-inline-first-last-contenteditable.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=45525

        Added a test to ensure WebKit does not crash when copying a region that doesn't have any common block ancestor.
        Also removed doubleclick-inline-first-last-contenteditable.html from the qt's skipped list since
        this test should not crash anymore.

        * editing/pasteboard/copy-without-common-block-crash-expected.txt: Added.
        * editing/pasteboard/copy-without-common-block-crash.html: Added.
        * platform/qt/Skipped: Removed doubleclick-inline-first-last-contenteditable.html from the list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-09 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 10 Sep 2010 18:43:37 +0000 (18:43 +0000)]
2010-09-09  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Dumitru Daniliuc.

        [FileSystem] Do not call EntriesCallback more than once if there're no entries.
        https://bugs.webkit.org/show_bug.cgi?id=45498

        No new tests, layout-tests that confirm the behavior will be added in later patches.

        * fileapi/FileSystemCallbacks.cpp:
        (WebCore::EntriesCallbacks::EntriesCallbacks):
        (WebCore::EntriesCallbacks::didReadDirectoryEntry):
        (WebCore::EntriesCallbacks::didReadDirectoryEntries):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Use String::fromUTF8 instead of UTF8Encoding().decode
cfleizach@apple.com [Fri, 10 Sep 2010 18:34:45 +0000 (18:34 +0000)]
WebCore: Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45488

Patch by Patrick Gansterer <paroga@paroga.com> on 2010-09-10
Reviewed by Darin Adler.

* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::toString):

LayoutTests: Land new expected results for some tests on Windows

Patch by Adam Roben <aroben@apple.com> on 2010-09-10
Rubber-stamped in advance by Simon Fraser.

* platform/win/fast/text/hyphenate-first-word-actual.txt: Added.
* platform/win/fast/text/hyphenate-locale-actual.txt: Added.
Windows doesn't support hyphenation.

* platform/win/html5lib/runner-actual.txt: Added.
We don't implement <keygen> on Windows, so we pass some tests that
expect <keygen> to have no child elements (on Mac, the child elements
are real DOM elements, rather than living in the shadow DOM tree like
HTML5 mandates, so the tests fail).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Sep 2010 18:31:27 +0000 (18:31 +0000)]
2010-09-10  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling out r67216.
        http://trac.webkit.org/changeset/67216
        https://bugs.webkit.org/show_bug.cgi?id=44709

        Broke

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand new expected results for some tests on Windows
aroben@apple.com [Fri, 10 Sep 2010 18:21:31 +0000 (18:21 +0000)]
Land new expected results for some tests on Windows

Rubber-stamped in advance by Simon Fraser.

* platform/win/fast/text/hyphenate-first-word-actual.txt: Added.
* platform/win/fast/text/hyphenate-locale-actual.txt: Added.
Windows doesn't support hyphenation.

* platform/win/html5lib/runner-actual.txt: Added.
We don't implement <keygen> on Windows, so we pass some tests that
expect <keygen> to have no child elements (on Mac, the child elements
are real DOM elements, rather than living in the shadow DOM tree like
HTML5 mandates, so the tests fail).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Sep 2010 18:10:44 +0000 (18:10 +0000)]
2010-09-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        deduplicate-tests should be runnable from any WebKit directory
        https://bugs.webkit.org/show_bug.cgi?id=44709

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 10 Sep 2010 18:04:57 +0000 (18:04 +0000)]
2010-09-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Placement new / manual destructor invocation should be used on private GObject memory
        https://bugs.webkit.org/show_bug.cgi?id=45550

        GLib allocates and deallocates GObject private data structs itself. When
        those structs contain C++ members, their constructors and destructors are not
        called. This is not only dangerous, it makes RefPtr-type smart pointers much
        less useful. We can fix this problem by calling placement new on the private
        data struct during instance initialization and calling the destructor during
        finalization.

        This patch takes that approach and switches plain char* members of
        WebKitWebView (with manual memory allocation) to use CString.

        * webkit/webkitprivate.h: Switch char* members to CString.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_finalize): Manually call the destructor on the private
        data. Remove manual deallocation of members which are now CString.
        (webkit_web_view_query_tooltip): Update to reflect CString change.
        (webkit_web_view_init): Use placement new to initialize C++ members of
        the private data section.
        (webkit_web_view_get_encoding): Update to reflect CString change.
        (webkit_web_view_get_custom_encoding): Ditto.
        (webkit_web_view_add_resource): Ditto.
        (webkit_web_view_get_resource): Ditto.
        (webkit_web_view_clear_resources): Ditto.
        (webkit_web_view_set_tooltip_text): Ditto.
        (webkit_web_view_get_icon_uri): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 10 Sep 2010 17:44:54 +0000 (17:44 +0000)]
2010-09-10  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Use String::fromUTF8 instead of UTF8Encoding().decode
        in the libxml XMLDocumentParser
        https://bugs.webkit.org/show_bug.cgi?id=45488

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::toString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-09 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 10 Sep 2010 17:39:12 +0000 (17:39 +0000)]
2010-09-09  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Andreas Kling.

        Clean Up Some Expected Results for Missing Tests
        https://bugs.webkit.org/show_bug.cgi?id=45489

          Test was removed in r35456 but expected results were missed.

        * http/tests/xmlhttprequest/access-control-basic-exclude-expected.txt: Removed.

          Results were added in r19036 but the test was never added. No record of the test.

        * editing/pasteboard/4944770-expected.txt: Removed.
        * platform/mac/editing/pasteboard/4944770-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/4944770-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Sep 2010 17:15:20 +0000 (17:15 +0000)]
2010-09-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Update Windows LayoutTest/compositing results
        https://bugs.webkit.org/show_bug.cgi?id=45323

        Fix up some windows compositing test results.

        * platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
        * platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
        * platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
        * platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
        * platform/win/compositing/plugins/composited-plugin-expected.txt: Added.
        * platform/win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Copied from LayoutTests/compositing/iframes/leave-compositing-iframe-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-09-10 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Fri, 10 Sep 2010 17:14:44 +0000 (17:14 +0000)]
2010-09-10  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] Google sites do not like WebKitGTK+
        https://bugs.webkit.org/show_bug.cgi?id=39617

        Special-case Google domains, and spoof User-Agent when talking to
        them, to stop being treated as a second-class citizen.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::initializeDomainsList):
        (WebKit::isGoogleDomain):
        (WebKit::FrameLoaderClient::userAgent): If enable-site-specific-quirks
        is enabled, send the standard WebKit User-Agent string, disregarding the
        custom one set by the browser for Google domains.
        * webkit/webkitprivate.h:
        * webkit/webkitwebsettings.cpp:
        (webkitPlatform): Fix style, and simplify.
        (webkitOSVersion): Ditto.
        (webkitUserAgent): Add the Version/x.y string Safari has been
        using since Safari 2.2.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67211 268f45cc-cd09-0410-ab3c-d52691b4dbfc