WebKit.git
8 years agoLayout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing
hamaji@chromium.org [Tue, 27 Sep 2011 09:56:27 +0000 (09:56 +0000)]
Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68852

Unreviewed test_expectations.txt update. We may need GPU-CG, too.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
hamaji@chromium.org [Tue, 27 Sep 2011 09:51:51 +0000 (09:51 +0000)]
[Crhomium] Layout Test compositing/video-page-visibility.html is failing on GPU linux
https://bugs.webkit.org/show_bug.cgi?id=68882

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Reorganize header files
carlosgc@webkit.org [Tue, 27 Sep 2011 09:35:55 +0000 (09:35 +0000)]
[GTK] Reorganize header files
https://bugs.webkit.org/show_bug.cgi?id=65616

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Initialize $libwebkitgtkincludedir to
$(prefix)/include/webkitgtk-<api-version>

Source/JavaScriptCore:

Install header files under $libwebkitgtkincludedir/JavaScriptCore.

* GNUmakefile.am: Use $libwebkitgtkincludedir.
* javascriptcoregtk.pc.in: Use webkitgtk-<api-version> as include dir.

Source/WebKit/gtk:

Install header files under $libwebkitgtkincludedir/webkit.

* GNUmakefile.am: Use $libwebkitgtkincludedir.
* webkit.pc.in: Use webkitgtk-<api-version> as include dir.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
hamaji@chromium.org [Tue, 27 Sep 2011 09:31:07 +0000 (09:31 +0000)]
[Crhomium] Layout Test svg/text/selection-(background-color|styles).xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=68881

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening
philn@webkit.org [Tue, 27 Sep 2011 09:24:24 +0000 (09:24 +0000)]
Unreviewed, GTK gardening

* platform/gtk/Skipped: Skip svg/filters/animate-fill.svg failing
in 32-Bits Release.
* platform/gtk/test_expectations.txt: Mark
media/video-timeupdate-reverse-play.html as flaky because of bug 67407.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEncapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic
rniwa@webkit.org [Tue, 27 Sep 2011 09:00:08 +0000 (09:00 +0000)]
Encapsulate m_firstNodeInserted and m_lastLeafInserted in node insertion logic
https://bugs.webkit.org/show_bug.cgi?id=68875

Reviewed by Kent Tamura.

Added InsertedNode class inside ReplaceSelection to encapsulate m_firstNodeInserted and m_lastLeafInserted.
Deployed it in removeRedundantStylesAndKeepStyleSpanInline, doApply, and insertAsListItems of ReplaceSelectionCommand.

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
* editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::respondToNodeInsertion):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
(WebCore::ReplaceSelectionCommand::InsertedNodes::firstNodeInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::lastLeafInserted):
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
* editing/htmlediting.cpp:
(WebCore::updatePositionForNodeRemoval): Moved from DeleteSelectionCommand.cpp.
* editing/htmlediting.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac...
hamaji@chromium.org [Tue, 27 Sep 2011 08:56:26 +0000 (08:56 +0000)]
[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=68879

Unreviewed test_expectations.txt update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAudio element doesn't emit the 'playing' event every time it starts playing, after...
commit-queue@webkit.org [Tue, 27 Sep 2011 08:33:21 +0000 (08:33 +0000)]
Audio element doesn't emit the 'playing' event every time it starts playing, after it has finished playing.
https://bugs.webkit.org/show_bug.cgi?id=60972

Patch by Arun Patole <bmf834@motorola.com> on 2011-09-27
Reviewed by Philippe Normand.

Source/WebCore:

The paused attribute should be set to true and the media element should emit a 'paused' at the end of playback.
WHATWG revision r6562: http://html5.org/tools/web-apps-tracker?from=6561&to=6562

Test: media/media-element-play-after-eos.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): set m_paused to true and schedule 'pause' event when playback ended.

LayoutTests:

Update media tests as the 'pause' event should be fired
and 'paused' should be set to true at the end of playback.

* media/event-attributes-expected.txt:
* media/event-attributes.html:
* media/media-element-play-after-eos-expected.txt: Added.
* media/media-element-play-after-eos.html: Added.
* media/video-loop-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening.
philn@webkit.org [Tue, 27 Sep 2011 08:21:06 +0000 (08:21 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/Skipped:
Skip outdated canvas/philip/tests/2d.drawImage.outsidesource.html.
* platform/gtk/test_expectations.txt:
media/video-playing-and-pause.html is flaky.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r95845, r95897 and r95857.
philn@webkit.org [Tue, 27 Sep 2011 08:08:27 +0000 (08:08 +0000)]
Unreviewed, GTK rebaseline after r95845, r95897 and r95857.

* platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
* platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
* platform/gtk/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
* platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
alexis.menard@openbossa.org [Tue, 27 Sep 2011 07:55:09 +0000 (07:55 +0000)]
[Qt][WK2] Mark FINAL properties which can't be overridden by a subclass.
https://bugs.webkit.org/show_bug.cgi?id=68848

Reviewed by Andreas Kling.

The presence of the FINAL attribute indicates that the property will not be
overridden by a derived class. This can be used for performance optimizations
by QML.

* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/qwebnavigationcontroller.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<input> with autofocus doesn't lose focus when it has a certain onblur listener
commit-queue@webkit.org [Tue, 27 Sep 2011 07:34:16 +0000 (07:34 +0000)]
<input> with autofocus doesn't lose focus when it has a certain onblur listener
https://bugs.webkit.org/show_bug.cgi?id=68513

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-09-27
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/autofocus-focus-only-once.html

These changes make sure that an element is focused only once when autofocus attribute is used.

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::shouldAutofocus):
(WebCore::HTMLFormControlElement::attach):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::hasAutofocused):
(WebCore::HTMLFormControlElement::setAutofocused):

LayoutTests:

These changes make sure that an element is focused only once when autofocus attribute is used.

* fast/forms/autofocus-focus-only-once-expected.txt: Added.
* fast/forms/autofocus-focus-only-once.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add missing test expecteds after r95924.
reni@webkit.org [Tue, 27 Sep 2011 07:05:21 +0000 (07:05 +0000)]
[Qt] Add missing test expecteds after r95924.

Unreviewed gardening.

* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
* platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html
rniwa@webkit.org [Tue, 27 Sep 2011 06:55:34 +0000 (06:55 +0000)]
dump-as-markup conversion: editing/deleting/delete-to-end-of-paragraph.html
https://bugs.webkit.org/show_bug.cgi?id=68865

Reviewed by Kent Tamura.

Converted the test.

* editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
* editing/deleting/delete-to-end-of-paragraph.html:
* platform/chromium-linux/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
* platform/mac-leopard/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
* platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
* platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Skip two tests because they are failing after r96070.
reni@webkit.org [Tue, 27 Sep 2011 06:43:27 +0000 (06:43 +0000)]
[Qt] Skip two tests because they are failing after r96070.

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic's commit data on summary page should not crowd itself or twitch when...
dglazkov@chromium.org [Tue, 27 Sep 2011 06:32:10 +0000 (06:32 +0000)]
garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
https://bugs.webkit.org/show_bug.cgi?id=68864

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement PopStateEvent.state with SerializedScriptValue and ScriptValue
commit-queue@webkit.org [Tue, 27 Sep 2011 06:27:02 +0000 (06:27 +0000)]
Implement PopStateEvent.state with SerializedScriptValue and ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=68345

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.

Source/WebCore:

Previously, the following test cases fail or crash:

- shouldBe("new PopStateEvent('eventType', { state: object1 }).state", "object1") -> FAIL
- new PopStateEvent('eventType', { state: document }).state -> CRASH in DRT

This is because PopStateEvent.state is implemented not as ScriptValue but as SerializedScriptValue.
However, we cannot simply change the type of PopStateEvent.state to ScriptValue,
since PopStateEvent can be constructed in the context that does not know ScriptValue.
For example, Document.cpp calls PopStateEvent::create() with SerializedScriptValue
popped from HistoryItem, but we cannot deserialize the SerializedScriptValue into
the corresponding ScriptValue here because the deserialization requires ExecState.
In other words, although we want to store PopStateEvent.state by ScriptValue internally,
PopStateEvent still needs to provide an API to construct it with SerializedScriptValue.
With these observations, this patch makes the following changes:

- If PopStateEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
When PopStateEvent.state is called, the ScriptValue is returned.
- If PopStateEvent is constructed with SerializedScriptValue, it is stored as
SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
at this point). When PopStateEvent.state is called, the SerializedScriptValue is
deserialized into the corresponding ScriptValue, and the ScriptValue is returned.

Tests: fast/events/constructors/pop-state-event-constructor.html
       fast/events/fire-popstate-event.html

* GNUmakefile.list.am: Added JSPopStateEventCustom.cpp.
* UseJSC.cmake: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state): Custom getter for PopStateEvent.state.
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter): Custom getter for PopStateEvent.state.
* dom/PopStateEvent.cpp:
(WebCore::PopStateEventInit::PopStateEventInit): Added initialization code for PopStateEvent.m_state.
(WebCore::PopStateEvent::PopStateEvent): Ditto.
(WebCore::PopStateEvent::create): Ditto.
(WebCore::PopStateEvent::initPopStateEvent): Ditto.
* dom/PopStateEvent.h:
(WebCore::PopStateEvent::serializedState): Getter.
(WebCore::PopStateEvent::state): Getter.
* dom/PopStateEvent.idl: Change the type of 'stateArg' and 'state' to DOMObject. Added [CustomGetter] to 'state'.

LayoutTests:

* fast/events/constructors/pop-state-event-constructor-expected.txt:
* fast/events/constructors/pop-state-event-constructor.html: Removed failures and crashes. Added one test case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] One more unreviewed buildfix after r96005.
ossy@webkit.org [Tue, 27 Sep 2011 06:26:14 +0000 (06:26 +0000)]
[Qt][WK2] One more unreviewed buildfix after r96005.

* WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed buildfix after r96005.
ossy@webkit.org [Tue, 27 Sep 2011 06:15:20 +0000 (06:15 +0000)]
[Qt][WK2] Unreviewed buildfix after r96005.

* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPixel result shows that compositing/iframes/repaint-after-losing-scrollbars.html...
simon.fraser@apple.com [Tue, 27 Sep 2011 05:50:02 +0000 (05:50 +0000)]
Pixel result shows that compositing/iframes/repaint-after-losing-scrollbars.html is failing
https://bugs.webkit.org/show_bug.cgi?id=67858

Reviewed by Darin Adler.

When non-overlay scrollbars are hidden on a composited iframe, nothing invalidated
the scrollbar areas or the scroll corner, so the scrollbars appear to remain.

Fix by invalidating the scrollbars and scroll corner when they are removed. Invalidation
on scrollbar creation appears to happen via updating the scrollbar style.

Tested by compositing/iframes/repaint-after-losing-scrollbars.html which no longer shows
stale scrollbars when run manually, even though the green squares are missing from the
pixel result (bug 67878).

* page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner): Pass the corner rect into invalidateScrollCorner().
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Invalidate the scrollbar area if hiding it.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): In the case where both scrollbars are going away,
compute the scroll corner rect while we still have scrollbars, and then invalidate it
explicitly. (updateScrollCorner() doesn't, because it doesn't have access to the old corner
rect.)
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollCorner): Pass the rect in, because we can't
compute it in the case where the scrollbars are going away.
* platform/ScrollableArea.h: Pass in a rect to invalidateScrollCorner(), which matches
invalidateScrollbar().
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer): Pass the corner rect into invalidateScrollCorner().
* rendering/RenderScrollbarPart.cpp: Ditto.
(WebCore::RenderScrollbarPart::imageChanged): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTranslucent scrollbars on composited layers render incorrectly
simon.fraser@apple.com [Tue, 27 Sep 2011 05:12:24 +0000 (05:12 +0000)]
Translucent scrollbars on composited layers render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58515

Source/WebCore:

Reviewed by Sam Weinig.

Scrollbars in composited elements were getting drawn twice,
because r41203 moved the call to paintOverflowControls() out of
RenderLayer::paintLayer(), but forgot to change RenderLayerBacking::paintIntoLayer().

Test: compositing/scrollbar-painting.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):

LayoutTests:

Reviewed by Sam Weinig.

Pixel test with translucent scrollbars, to test whether they get
rendered twice.

* compositing/scrollbar-painting-expected.png: Added.
* compositing/scrollbar-painting-expected.txt: Added.
* compositing/scrollbar-painting.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r95912): Conservative marking doesn't filter out pointers to
ggaren@apple.com [Tue, 27 Sep 2011 03:24:03 +0000 (03:24 +0000)]
REGRESSION (r95912): Conservative marking doesn't filter out pointers to
MarkedBlock metadata
https://bugs.webkit.org/show_bug.cgi?id=68860

Reviewed by Oliver Hunt.

Bencher says no performance change, maybe a 7% speedup on kraken-imaging-darkroom.

* heap/MarkedBlock.h:
(JSC::MarkedBlock::isAtomAligned): Renamed atomMask to atomAlignment mask
because the mask doesn't produce the actual atom number.

(JSC::MarkedBlock::isLiveCell): Testing just for alignment isn't good
enough; we also need to test that a pointer is beyond the metadata section
of a MarkedBlock, to avoid treating random metadata as a JSCell.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix WK2 build after r96014
caio.oliveira@openbossa.org [Tue, 27 Sep 2011 02:36:55 +0000 (02:36 +0000)]
[Qt] Fix WK2 build after r96014
https://bugs.webkit.org/show_bug.cgi?id=68856

Reviewed by Gustavo Noronha Silva.

Commit r96014 added inspectorBaseURL for Qt but removed
inspectorPageURL, adding it back.

* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Make CCThreadProxy draw
jamesr@google.com [Tue, 27 Sep 2011 02:18:14 +0000 (02:18 +0000)]
[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417

Source/WebCore:

Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.

Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.

* platform/graphics/IntRect.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::~LayerRendererChromium):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418

Patch by Nat Duca <nduca@chromium.org> on 2011-09-26
Reviewed by James Robinson.

* tests/CCLayerTreeHostTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPut back all Chromium platform failing expectations for some tests (they
mihaip@chromium.org [Tue, 27 Sep 2011 02:07:46 +0000 (02:07 +0000)]
Put back all Chromium platform failing expectations for some tests (they
still fail on all platforms on the GPU bots).

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[MutationObservers] implement MutationRecord
adamk@chromium.org [Tue, 27 Sep 2011 01:44:36 +0000 (01:44 +0000)]
[MutationObservers] implement MutationRecord
https://bugs.webkit.org/show_bug.cgi?id=68824

Reviewed by Darin Adler.

Implements MutationRecord as specified in the thread at
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html,
including some minor naming changes from the original proposal.

This is a small part of the MutationObserver API, see
https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug covering
this feature.

No new tests as this isn't yet exposed to the platform.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/MutationRecord.cpp: Added.
(WebCore::MutationRecord::createChildList):
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createCharacterData):
(WebCore::MutationRecord::MutationRecord):
(WebCore::MutationRecord::~MutationRecord):
* dom/MutationRecord.h: Added.
(WebCore::MutationRecord::target):
(WebCore::MutationRecord::addedNodes):
(WebCore::MutationRecord::removedNodes):
(WebCore::MutationRecord::previousSibling):
(WebCore::MutationRecord::nextSibling):
(WebCore::MutationRecord::attributeName):
(WebCore::MutationRecord::attributeNamespace):
(WebCore::MutationRecord::oldValue):
(WebCore::MutationRecord::setOldValue):
* dom/MutationRecord.idl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement a CloseEvent constructor for V8
commit-queue@webkit.org [Tue, 27 Sep 2011 01:36:08 +0000 (01:36 +0000)]
Implement a CloseEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68793

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-26
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/close-event-constructor.html

* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::getKey): Just removed an extra space.
(WebCore::OptionsObject::getKeyValue): Returns an unsigned short value corresponding to the given key.
* bindings/v8/OptionsObject.h:
* bindings/v8/custom/V8EventConstructors.cpp: Added the CloseEvent constructor.
* websockets/CloseEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled close-event-constructor.html, since now V8 has the CloseEvent constructor.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up CachedResource::load(). Collapse its
japhet@chromium.org [Tue, 27 Sep 2011 01:29:20 +0000 (01:29 +0000)]
Clean up CachedResource::load(). Collapse its
logic into a single callsite, taking just a
CachedResourceLoader and a ResourceLoaderOptions.

1. Its 'incremental' parameter is redundant.
2. With 'incremental' removed, the SecurityCheckPolicy is the only
   parameter difference between the CachedResource::load() variants.
   Making it a part of ResourceLoaderOptions removes yet another random
   enum that is passed around individually.
3. We currently have to call setResourceLoaderOptions() before load() on a
   new CachedResource, so we should just take the ResourceLoaderOptions in load().

https://bugs.webkit.org/show_bug.cgi?id=67443

Reviewed by Antti Koivisto.

No new tests, refactor only.

* loader/DocumentThreadableLoader.cpp:
* loader/FrameLoaderTypes.h: Move SecurityCheckPolicy to ResourceLoaderOptions.h.
* loader/MainResourceLoader.cpp:
* loader/NetscapePlugInStreamLoader.cpp:
* loader/ResourceLoadScheduler.cpp:
* loader/ResourceLoadScheduler.h:
* loader/ResourceLoader.cpp: Enforce SecurityCheckPolicy here instead of SubresourceLoader.
* loader/ResourceLoaderOptions.h: Store SecurityCheckPolicy on ResourceLoaderOptions.
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::defaultCachedResourceOptions): Define the default ResourceLoaderOptions for
    CachedResource loads here instead of as a default parameter on requestResource().
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData): Remove m_incremental, since its purpose
    is already enforced in the data() implementation of every CachedResource that doesn't want
    incremental loads.
* loader/cache/CachedResourceRequest.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should be pretty in Open Sans.
dglazkov@chromium.org [Tue, 27 Sep 2011 01:27:04 +0000 (01:27 +0000)]
garden-o-matic should be pretty in Open Sans.
https://bugs.webkit.org/show_bug.cgi?id=68845

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium test expectations update.
mihaip@chromium.org [Tue, 27 Sep 2011 01:13:06 +0000 (01:13 +0000)]
Chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoediting/selection/select-bidi-run.html fails on Chromium Windows and Linux
rniwa@webkit.org [Tue, 27 Sep 2011 00:57:51 +0000 (00:57 +0000)]
editing/selection/select-bidi-run.html fails on Chromium Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=68832

Unreviewed; remove the failing test expectation because it started passing after r96016.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip the test added by r95964 on Qt and GTK because it has been failing
rniwa@webkit.org [Tue, 27 Sep 2011 00:55:57 +0000 (00:55 +0000)]
Skip the test added by r95964 on Qt and GTK because it has been failing
on those two platforms. The failure is tracked by the bugs 68854 and 68855.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should not say "Just now" when it doesn't actually know when an event...
dglazkov@chromium.org [Tue, 27 Sep 2011 00:52:19 +0000 (00:52 +0000)]
garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
https://bugs.webkit.org/show_bug.cgi?id=68841

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Second half of IDBFactory.getDatabaseNames implementation
commit-queue@webkit.org [Tue, 27 Sep 2011 00:43:02 +0000 (00:43 +0000)]
IndexedDB: Second half of IDBFactory.getDatabaseNames implementation
https://bugs.webkit.org/show_bug.cgi?id=68818

Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/factory-basics.html

Adds ability to enumerate IndexedDB databases within an origin.

* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* storage/IDBAny.cpp:
(WebCore::IDBAny::domStringList):
(WebCore::IDBAny::set):
* storage/IDBAny.h:
* storage/IDBBackingStore.h:
* storage/IDBCallbacks.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
* storage/IDBFactory.h:
* storage/IDBFactory.idl:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::getIndexes):
* storage/IDBLevelDBBackingStore.h:
* storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeMinKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeStopKeyForOrigin):
* storage/IDBLevelDBCoding.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* storage/IDBRequest.h:
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::getDatabaseNames):
* storage/IDBSQLiteBackingStore.h:

Source/WebKit/chromium:

Adds ability to enumerate IndexedDB databases within an origin.

* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
* src/IDBCallbacksProxy.h:
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
* src/IDBFactoryBackendProxy.h:
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess):
* src/WebIDBCallbacksImpl.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
* src/WebIDBFactoryImpl.h:

LayoutTests:

Adds ability to enumerate IndexedDB databases within an origin.

* storage/indexeddb/factory-basics-expected.txt: Added.
* storage/indexeddb/factory-basics.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove failing Chromium expectations for tests that now pass.
mihaip@chromium.org [Tue, 27 Sep 2011 00:40:40 +0000 (00:40 +0000)]
Remove failing Chromium expectations for tests that now pass.

Rebaseline repaint tests for Chromium Snow Leopard CG after r96005.

* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/inline-block-overflow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-child-outline-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-outline-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/text-shadow-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<animateColor> applied to filtered ellipse does not update
timothy_horton@apple.com [Tue, 27 Sep 2011 00:36:19 +0000 (00:36 +0000)]
<animateColor> applied to filtered ellipse does not update
https://bugs.webkit.org/show_bug.cgi?id=68457
<rdar://problem/10154777>

Reviewed by Darin Adler.

Invalidate the filter's cache when style changes take place so that style changes are respected.

Test: svg/filters/animate-fill.svg

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] [WK2] Fix build after r95982
caio.oliveira@openbossa.org [Tue, 27 Sep 2011 00:35:41 +0000 (00:35 +0000)]
[Qt] [WK2] Fix build after r95982
https://bugs.webkit.org/show_bug.cgi?id=68842

Reviewed by Anders Carlsson.

The patch in r95982 removed the paint() function, because it was doing
nothing (in both implementations). This patch remove the call we had
for it to fix the build.

* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::paintContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved an unnecessary include in WebFrameImpl
fsamuel@chromium.org [Tue, 27 Sep 2011 00:23:31 +0000 (00:23 +0000)]
Removed an unnecessary include in WebFrameImpl
https://bugs.webkit.org/show_bug.cgi?id=68834

Reviewed by Darin Fisher.

* src/WebFrameImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove failing expectations for some ruby tests, since they were
mihaip@chromium.org [Tue, 27 Sep 2011 00:23:09 +0000 (00:23 +0000)]
Remove failing expectations for some ruby tests, since they were
renamed to -disabled with r94327 and thus aren't being run at all.

Add compositing/video-page-visibility.html Windows GPU baselines.

* platform/chromium-gpu-win/compositing/video-page-visibility-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Chromium test expectations update.
mihaip@chromium.org [Tue, 27 Sep 2011 00:06:52 +0000 (00:06 +0000)]
Unreviewed Chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowatchlist: Add parsing for definition section.
levin@chromium.org [Tue, 27 Sep 2011 00:03:07 +0000 (00:03 +0000)]
watchlist: Add parsing for definition section.
https://bugs.webkit.org/show_bug.cgi?id=68850

Reviewed by Adam Barth.

* Scripts/webkitpy/common/watchlist/watchlist.py:
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake JSCell::toBoolean non-virtual
mhahnenberg@apple.com [Mon, 26 Sep 2011 23:53:42 +0000 (23:53 +0000)]
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727

Reviewed by Geoffrey Garen.

JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual.  JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary.  This is part of a larger process of un-virtualizing JSCell.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove failing Chromium test expectations for tests that now pass
mihaip@chromium.org [Mon, 26 Sep 2011 23:29:34 +0000 (23:29 +0000)]
Remove failing Chromium test expectations for tests that now pass
(mainly due to r95751, which implemented Function.prototype.bind for
JSC, resulting in baseline updates that now work for V8 too).

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSet but unused variables cleanup in v8 bindings (gcc 4.6)
commit-queue@webkit.org [Mon, 26 Sep 2011 23:21:42 +0000 (23:21 +0000)]
Set but unused variables cleanup in v8 bindings (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68079

Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-26
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/send-object-tostring-check.html

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):

LayoutTests:

* http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Added.
* http/tests/websocket/tests/hybi/send-object-tostring-check.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoswitch the initial value of flex-order to 0
tony@chromium.org [Mon, 26 Sep 2011 23:07:50 +0000 (23:07 +0000)]
switch the initial value of flex-order to 0
https://bugs.webkit.org/show_bug.cgi?id=68820

Source/WebCore:

The spec changed from having an initial value of 1 to 0.

Reviewed by Ojan Vafai.

* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialFlexOrder):

LayoutTests:

Reviewed by Ojan Vafai.

* css3/flexbox/flex-order.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable requestAnimationFrame on Windows
cmarrin@apple.com [Mon, 26 Sep 2011 23:02:17 +0000 (23:02 +0000)]
Enable requestAnimationFrame on Windows
https://bugs.webkit.org/show_bug.cgi?id=68397

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows

* wtf/Platform.h:

WebKitLibraries:

Enable REQUEST_ANIMATION_FRAME for Windows

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
is still skipped because it uses showModalDialog which is not supported in DRT on Windows

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix WebKitTestRunner builds for Cairo, Windows and Qt.
simon.fraser@apple.com [Mon, 26 Sep 2011 23:00:37 +0000 (23:00 +0000)]
Fix WebKitTestRunner builds for Cairo, Windows and Qt.

* WebKitTestRunner/cairo/TestInvocationCairo.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/win/TestInvocationWin.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOfflineAudioDestinationNode must wait for thread completion in uninitialize()
crogers@google.com [Mon, 26 Sep 2011 22:58:29 +0000 (22:58 +0000)]
OfflineAudioDestinationNode must wait for thread completion in uninitialize()
https://bugs.webkit.org/show_bug.cgi?id=68725

Reviewed by Kenneth Russell.

No new tests.  This fixes internal implementation details.

* webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::uninitialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoediting/selection/select-bidi-run.html timeouts on non-Mac platforms
rniwa@webkit.org [Mon, 26 Sep 2011 22:50:38 +0000 (22:50 +0000)]
editing/selection/select-bidi-run.html timeouts on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=68831

Reviewed by Enrica Casucci.

Click at (0,0) to reset click count instead of a long leapForward.

* editing/selection/select-bidi-run.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r95747): Activating the web inspector causes the web process to be killed
ap@apple.com [Mon, 26 Sep 2011 22:46:28 +0000 (22:46 +0000)]
REGRESSION (r95747): Activating the web inspector causes the web process to be killed
https://bugs.webkit.org/show_bug.cgi?id=68762

Reviewed by Anders Carlsson.

* UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::createInspectorPage):
Tell Web process that loading resources from WebCore resources directory is OK.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
* UIProcess/WebProcessProxy.h:
Renamed willLoadHTMLStringWithBaseURL to more generic assumeReadAccessToBaseURL.

* UIProcess/WebInspectorProxy.h:
* UIProcess/efl/WebInspectorEfl.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::inspectorBaseURL):
Report what base directory Inspector has access to.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update the test expectaion file for media related tests.
imasaki@chromium.org [Mon, 26 Sep 2011 22:45:42 +0000 (22:45 +0000)]
[Chromium] Update the test expectaion file for media related tests.
It includes updating bug numbers, removing
media/video-controls-visible-audio-only.html, and unskipping
media/media-document-audio-repaint.html.
https://bugs.webkit.org/show_bug.cgi?id=68254

Reviewed by David Levin.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/chromium: Fix copy and paste error in r96002.
mihaip@chromium.org [Mon, 26 Sep 2011 22:34:54 +0000 (22:34 +0000)]
Source/WebKit/chromium: Fix copy and paste error in r96002.

* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):

LayoutTests: Remove test that no longer crashes (fixed by r95985).

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
xan@webkit.org [Mon, 26 Sep 2011 22:28:31 +0000 (22:28 +0000)]
[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68837

Reviewed by Martin Robinson.

* bindings/scripts/CodeGeneratorGObject.pm: add getters (but not
setters) for 'Replaceable' attributes. Punt for the future
actually making them settable, since it seems non trivial.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLeopard build fix.
rniwa@webkit.org [Mon, 26 Sep 2011 22:27:19 +0000 (22:27 +0000)]
Leopard build fix.

* testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorTransform):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Null key path gets stored as empty string key path
commit-queue@webkit.org [Mon, 26 Sep 2011 22:22:23 +0000 (22:22 +0000)]
IndexedDB: Null key path gets stored as empty string key path
https://bugs.webkit.org/show_bug.cgi?id=68726

Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.

Store additional flag to indicate if object store key path
is null vs. empty. Added additional runtime tests for integrity
of object store metadata.

* storage/IDBLevelDBBackingStore.cpp:
(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
* storage/IDBLevelDBCoding.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
reed@google.com [Mon, 26 Sep 2011 22:21:04 +0000 (22:21 +0000)]
[skia] need rebaseline after the next skia roll -- improvements to xfermodes on gpu
https://bugs.webkit.org/show_bug.cgi?id=68807

Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRepaint tests don't work in WebKit2
simon.fraser@apple.com [Mon, 26 Sep 2011 22:19:10 +0000 (22:19 +0000)]
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453

Tools:

Reviewed by Sam Weinig.

Convert DumpRenderTree to use use the repaint rects
exposed via WebKit API when generating the repaint test
overlay.

Fix WebKitTestRunner to work with repaint tests, again
using the repaint rects exposed from WK2.

In both cases, layoutTestController.display() now just
forces a display of the web view, and turns on repaint
rect tracking on the main FrameView.

Later, when pixel results are requested, the alpha overlay
that shows the repaint rects is generated using the list
of rects supplied by WebCore.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(resetWebViewToConsistentStateBeforeTesting):
(displayWebView):
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(paintRepaintRectOverlay):
(createBitmapContextFromWebView):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::setRepaintRects):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):
(WTR::InjectedBundlePage::dump):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::display):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

LayoutTests:

Reviewed by Sam Weinig.

Update Mac results to use the new repaint rects. Differences from old results:
        * There are no longer invalidates from scrolling.
        * We no longer see the effects of AppKit rect coalescing.
        * Composting tests show the overlay now, but repaints in compositing layers do not show.

    Bad results in a couple of tests are covered by bugs 68830 and 68829.

* platform/mac/fast/repaint/4774354-expected.png:
* platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
* platform/mac/fast/repaint/border-radius-repaint-expected.png:
* platform/mac/fast/repaint/clipped-relative-expected.png:
* platform/mac/fast/repaint/containing-block-position-change-expected.png:
* platform/mac/fast/repaint/control-clip-expected.png:
* platform/mac/fast/repaint/delete-into-nested-block-expected.png:
* platform/mac/fast/repaint/fixed-and-absolute-position-scrolled-expected.png:
* platform/mac/fast/repaint/fixed-scroll-simple-expected.png:
* platform/mac/fast/repaint/flexible-box-overflow-expected.png:
* platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
* platform/mac/fast/repaint/float-move-during-layout-expected.png:
* platform/mac/fast/repaint/float-overflow-expected.png:
* platform/mac/fast/repaint/float-overflow-right-expected.png:
* platform/mac/fast/repaint/iframe-scroll-repaint-expected.png:
* platform/mac/fast/repaint/inline-block-overflow-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/mac/fast/repaint/layer-child-outline-expected.png:
* platform/mac/fast/repaint/layer-outline-expected.png:
* platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
* platform/mac/fast/repaint/line-overflow-expected.png:
* platform/mac/fast/repaint/nested-iframe-scroll-inner-expected.png:
* platform/mac/fast/repaint/nested-iframe-scroll-outer-expected.png:
* platform/mac/fast/repaint/outline-child-repaint-expected.png:
* platform/mac/fast/repaint/outline-shrinking-expected.png:
* platform/mac/fast/repaint/overflow-delete-line-expected.png:
* platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
* platform/mac/fast/repaint/repaint-during-scroll-expected.png:
* platform/mac/fast/repaint/scale-page-shrink-expected.png:
* platform/mac/fast/repaint/search-field-cancel-expected.png:
* platform/mac/fast/repaint/selection-after-remove-expected.png:
* platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/mac/fast/repaint/static-to-positioned-expected.png:
* platform/mac/fast/repaint/table-cell-move-expected.png:
* platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
* platform/mac/fast/repaint/text-shadow-expected.png:
* platform/mac/fast/repaint/text-shadow-horizontal-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable Chromium gesture recognizer tests that started to fail on the
mihaip@chromium.org [Mon, 26 Sep 2011 22:12:55 +0000 (22:12 +0000)]
Disable Chromium gesture recognizer tests that started to fail on the
Mac bots recently.

* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove DFGAliasTracker.h references from gyp project files
noel.gordon@gmail.com [Mon, 26 Sep 2011 22:10:29 +0000 (22:10 +0000)]
[Chromium] Remove DFGAliasTracker.h references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=68787

Reviewed by Geoffrey Garen.

DFG/DFGAliasTracker.h was removed in r95389.  Cleanup (remove) references
to that file from the gyp project files.

* JavaScriptCore.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix nonpremultiplied webgl toDataURL to jpeg
commit-queue@webkit.org [Mon, 26 Sep 2011 22:07:33 +0000 (22:07 +0000)]
Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366

Source/WebCore:

The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::RGBAtoRGB):

LayoutTests:

Update the premultiplyalpha-test from the WebGL conformance tests.
Also use the correct expected result for toDataURL.jpeg.alpha.html.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-26
Reviewed by Kenneth Russell.

* fast/canvas/webgl/premultiplyalpha-test-expected.txt:
* fast/canvas/webgl/premultiplyalpha-test.html:
* platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit2: Added WKHitTestResult API's.
commit-queue@webkit.org [Mon, 26 Sep 2011 22:00:06 +0000 (22:00 +0000)]
Source/WebKit2: Added WKHitTestResult API's.

WKHitTestResult API's are added. These API's can be used to
get the hover'ed link/image/media URL as well as link lable and
title.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.

* CMakeLists.txt:
* GNUmakefile.am:
* UIProcess/API/C/WKHitTestResult.cpp: Added.
(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):
(WKHitTestResultCopyAbsoluteLinkURL):
(WKHitTestResultCopyAbsoluteMediaURL):
(WKHitTestResultCopyLinkLabel):
(WKHitTestResultCopyLinkTitle):
* UIProcess/API/C/WKHitTestResult.h: Added.
* UIProcess/API/C/WebKit2.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2API.pri:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:

Tools: Get hover'ed element URL from HitTest.

mouseDidMoveOverElement now gets the hover'ed element link using
WKHitTestResult API's.
https://bugs.webkit.org/show_bug.cgi?id=68426

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-09-26
Reviewed by Anders Carlsson.

* MiniBrowser/gtk/BrowserWindow.c:
(mouseDidMoveOverElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Remove FindFreetype.cmake
commit-queue@webkit.org [Mon, 26 Sep 2011 21:47:46 +0000 (21:47 +0000)]
[CMake] Remove FindFreetype.cmake
https://bugs.webkit.org/show_bug.cgi?id=68778

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.

CMake has provided its own FindFreetype.cmake forever, so there is no
need to have another implementation in WebKit.

.:

* Source/cmake/FindCairo.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
* Source/cmake/FindFreetype.cmake: Removed.
* Source/cmake/FindPango.cmake: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS}
instead of Freetype_{LIBRARIES,INCLUDE_DIRS}.
* Source/cmake/OptionsEfl.cmake: Remove minimum required version
check, it has never been checked and Freetype 2.1.10 from 2005 is
already > 9.0.

Source/WebCore:

No new tests, just a buildsystem change.

* CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
Freetype_{LIBRARIES,INCLUDE_DIRS}.

Source/WebKit/efl:

* CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
Freetype_{LIBRARIES,INCLUDE_DIRS}.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix full-page rubber band overhang appearing when gesturing during a slow page load.
commit-queue@webkit.org [Mon, 26 Sep 2011 21:44:26 +0000 (21:44 +0000)]
Fix full-page rubber band overhang appearing when gesturing during a slow page load.
https://bugs.webkit.org/show_bug.cgi?id=68568

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=97243

(This also happens on Safari.)

The problem was that ScrollView::overhangAmount() was returning a full-page overhang due to contentsSize() being 0 briefly during a page load, which was then getting used by ScrollAnimatorChromiumMac.mm to update the overhang on a gesture event. This change makes the relevant logic not return an overhang if the contentsSize() is empty.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-26
Reviewed by Adam Barth.

No new tests, since this is highly timing-related.

* platform/ScrollView.cpp:
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 26 Sep 2011 21:44:11 +0000 (21:44 +0000)]
2011-09-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] pot file is not properly remove during distcheck
        https://bugs.webkit.org/show_bug.cgi?id=68797

        Defined DOMAIN variable before DISTCLEANFILES because we are using
        it there to identify the .pot file.

        Reviewed by Martin Robinson.

        * GNUmakefile.am:

2011-09-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] pot file is not properly remove during distcheck
        https://bugs.webkit.org/show_bug.cgi?id=68797

        DOMAIN is already defined, we just add the value to the variable.

        Reviewed by Martin Robinson.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd skeleton parsing for a WatchList.
levin@chromium.org [Mon, 26 Sep 2011 21:39:02 +0000 (21:39 +0000)]
Add skeleton parsing for a WatchList.
https://bugs.webkit.org/show_bug.cgi?id=68823

Reviewed by Adam Barth.

* Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
Parses the top level watch list sections -- none are defined yet -- and
throws an exception if an invalid one is listed.
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
Verify the exception for an invalid section in a watch list.
* Scripts/webkitpy/common/watchlist/watchlist.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a failing expectation to the test added by r95964 on Chromium Linux and Chromium...
rniwa@webkit.org [Mon, 26 Sep 2011 21:06:44 +0000 (21:06 +0000)]
Add a failing expectation to the test added by r95964 on Chromium Linux and Chromium Windows.
The failure is tracked by the bug 68832.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2]Unreviewed speculative buildfix after r95968.
ossy@webkit.org [Mon, 26 Sep 2011 20:57:06 +0000 (20:57 +0000)]
[Qt][WK2]Unreviewed speculative buildfix after r95968.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Revise zoom animator backend to use full transform instead of just scale.
wjmaclean@chromium.org [Mon, 26 Sep 2011 20:31:12 +0000 (20:31 +0000)]
[chromium] Revise zoom animator backend to use full transform instead of just scale.
https://bugs.webkit.org/show_bug.cgi?id=68535

Reviewed by Kenneth Russell.

Source/WebCore:

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setZoomAnimatorScale):
(WebCore::Settings::zoomAnimatorScale):
(WebCore::Settings::setZoomAnimatorPosition):
(WebCore::Settings::zoomAnimatorPosX):
(WebCore::Settings::zoomAnimatorPosY):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setZoomAnimatorTransform):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorTransform):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

LayoutTests:

* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
* platform/chromium/compositing/zoom-animator-scale-test.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test fast/animation/request-animation-frame-timestamps-advance.html is failing
mihaip@chromium.org [Mon, 26 Sep 2011 20:28:07 +0000 (20:28 +0000)]
Layout Test fast/animation/request-animation-frame-timestamps-advance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68821

Switch test to use finishJSTest(), which handles js-test-post.js loading
after the test is complete better.

* fast/animation/request-animation-frame-timestamps-advance.html:
* fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
(window.webkitRequestAnimationFrame):
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Detect the operating system in a more generic way.
commit-queue@webkit.org [Mon, 26 Sep 2011 20:08:57 +0000 (20:08 +0000)]
[CMake] Detect the operating system in a more generic way.
https://bugs.webkit.org/show_bug.cgi?id=67482

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-26
Reviewed by Adam Barth.

So far the buildsystem only considered Windows, Linux and Mac OS X as
valid operating systems, but any Unix (or at least the BSDs) should also
work fine.

By using the OS values CMake itself defines we can check for Unix
systems in a more generic fashion.

* Source/CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r95926) Assert firing in svg/clip-path/clip-path-on-svg.svg
mitz@apple.com [Mon, 26 Sep 2011 20:08:11 +0000 (20:08 +0000)]
REGRESSION (r95926) Assert firing in svg/clip-path/clip-path-on-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68819

Reviewed by Dave Hyatt.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::scheduleRelayout): Revert to using view() instead of the RenderView**
parameter of isRooted, since only the former returns 0 when the document is detached.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: XMLHttpRequest console logging messages should link to network panel...
vsevik@chromium.org [Mon, 26 Sep 2011 20:06:55 +0000 (20:06 +0000)]
Web Inspector: XMLHttpRequest console logging messages should link to network panel when possible.
https://bugs.webkit.org/show_bug.cgi?id=67399

Reviewed by Pavel Feldman.

* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
* inspector/ConsoleMessage.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showAnchorLocation):
* inspector/front-end/inspector.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.linkifyStringAsFragment):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add virtual method to notify user when wrapping focus
demarchi@webkit.org [Mon, 26 Sep 2011 19:58:24 +0000 (19:58 +0000)]
[EFL] Add virtual method to notify user when wrapping focus
https://bugs.webkit.org/show_bug.cgi?id=68699

Reviewed by Antonio Gomes.

Add a virtual method to ewk_view, so the Chrome gets notified if we
finished focusing all the items and would start over. This way the
browser can decide to handle the subsequent focus changes among its
widgets.

* WebCoreSupport/ChromeClientEfl.cpp: call ewk_view's virtual method to
give it a chance to grab focus
(WebCore::ChromeClientEfl::canTakeFocus):
* ewk/ewk_private.h:
* ewk/ewk_view.cpp: add virtual method
(ewk_view_focus_can_cycle):
* ewk/ewk_view.h: add focus direction enum and virtual method

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove an old DrawingAreaProxy::paint member function
andersca@apple.com [Mon, 26 Sep 2011 19:58:00 +0000 (19:58 +0000)]
Remove an old DrawingAreaProxy::paint member function
https://bugs.webkit.org/show_bug.cgi?id=68825

Reviewed by Dan Bernstein.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
* UIProcess/TiledDrawingAreaProxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports.
mihaip@chromium.org [Mon, 26 Sep 2011 19:57:56 +0000 (19:57 +0000)]
Rebaseline fast/dom/Window/window-resize-contents.html for non-Chromium ports.

Previous expected result was Chromium-specific because console line
numbers were different in JSC.

Additionally, the test doesn't behave as expected for non-Chromium
ports (window size remains at 800x600). Update the baselines to use
that for now, so that we're still aware of regressions/progressions.

* fast/dom/Window/window-resize-contents-expected.txt:
* platform/chromium/fast/dom/Window/window-resize-contents-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-contents-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhite flash when entering full-screen using element.webkitRequestFullScreen()
jer.noble@apple.com [Mon, 26 Sep 2011 19:51:15 +0000 (19:51 +0000)]
White flash when entering full-screen using element.webkitRequestFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=68481

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; covered by existing full screen tests.

During an animation, renderers may try to paint into the FullScreenRenderer's
GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's
background will cause these paints to fail. Remove this optimization in
containsPaintedContent, and taking non-composited elements into full screen will
animate correctly.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):

Source/WebKit2:

Do not re-enable screen updates after exiting compositing mode until a repaint has completed.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
(continueExitCompositingModeAfterRepaintCallback):
(-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r95960.
mihaip@chromium.org [Mon, 26 Sep 2011 19:43:56 +0000 (19:43 +0000)]
Unreviewed, rolling out r95960.
http://trac.webkit.org/changeset/95960
https://bugs.webkit.org/show_bug.cgi?id=58608

Significantly changes table border rendering

Source/WebCore:

* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

* fast/borders/border-groove-expected.png: Removed.
* fast/borders/border-groove-expected.txt: Removed.
* fast/borders/border-groove.html: Removed.
* fast/borders/border-inset-expected.png: Removed.
* fast/borders/border-inset-expected.txt: Removed.
* fast/borders/border-inset.html: Removed.
* fast/borders/border-outset-expected.png: Removed.
* fast/borders/border-outset-expected.txt: Removed.
* fast/borders/border-outset.html: Removed.
* fast/borders/border-ridge-expected.png: Removed.
* fast/borders/border-ridge-expected.txt: Removed.
* fast/borders/border-ridge.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium test expectations update.
mihaip@chromium.org [Mon, 26 Sep 2011 19:09:49 +0000 (19:09 +0000)]
Chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRepaint tests don't work in WebKit2
simon.fraser@apple.com [Mon, 26 Sep 2011 19:01:36 +0000 (19:01 +0000)]
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453

Reviewed by Sam Weinig.

Expose WKBundlePage methods to turn on repaint rect tracking
in WebKit2, for WebKitTestRunner.

As part of the change, expose utility methods on WebPage
to get the main Frame and FrameView, which required renaming
the exisiting method that returns a WebFrame. Fix callers
of that method to handle null when necessary.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetMainFrame):
(WKBundlePageSetTracksRepaints):
(WKBundlePageIsTrackingRepaints):
(WKBundlePageResetTrackedRepaints):
(WKBundlePageCopyTrackedRepaintRects):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::findLargestFrameInFrameSet):
(WebKit::WebChromeClient::closeWindowSoon):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::frameLoadCompleted):
(WebKit::WebFrameLoaderClient::restoreViewState):
(WebKit::WebFrameLoaderClient::provisionalLoadStarted):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebFrameLoaderClient::createPlugin):
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::documentFragmentFromAttributedString):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::isMainFrame):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTracksRepaints):
(WebKit::WebPage::isTrackingRepaints):
(WebKit::WebPage::resetTrackedRepaints):
(WebKit::WebPage::trackedRepaintRects):
(WebKit::WebPage::clearMainFrameName):
(WebKit::WebPage::layoutIfNeeded):
(WebKit::WebPage::mainFrameHasCustomRepresentation):
(WebKit::WebPage::mainFrame):
(WebKit::WebPage::mainFrameView):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::mainWebFrame):
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRepaint tests don't work in WebKit2
simon.fraser@apple.com [Mon, 26 Sep 2011 18:57:14 +0000 (18:57 +0000)]
Repaint tests don't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=68453

Reviewed by Sam Weinig.

Source/WebCore:

Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.

The repaint rects are in WebView coordinates, so we have to
unapply the scroll offset.

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::setTracksRepaints):
* page/FrameView.h:
(WebCore::FrameView::isTrackingRepaints):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::trackedRepaintRects):

Source/WebKit/mac:

Have FrameView keep track of repaint rects when asked to, and
expose this set of repaint rects via private WebKit API for later
use by DumpRenderTree.

* WebView/WebView.mm:
(-[WebView setTracksRepaints:]):
(-[WebView isTrackingRepaints]):
(-[WebView resetTrackedRepaints]):
(-[WebView trackedRepaintRects]):
* WebView/WebViewPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimize matching of common pseudo classes
antti@apple.com [Mon, 26 Sep 2011 18:53:48 +0000 (18:53 +0000)]
Optimize matching of common pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=68633

Reviewed by Dave Hyatt, Darin Adler, Dimitri Glazkov.

:link, :visited and :focus are quite common. They often used as univeral selectors (including in our
default stylesheet) so we try to match them for all elements in the document. They take always the
slow matching path. In addition we match link styles twice due to visited link pseudo style generation
so the overhead is doubled. As a result substantial portion of our style matching time is spent
dealing with these pseudo classes.

This patch adds new lists to RuleSet for common pseudo class rules. The rules on the lists are only checked
if the element has approprate type and stat. ases where the rightmost pseudo class can then be rejected immediately.
We can also enable the fast path checking for the rest of the selector in many cases.

This seems to be >30% progression in selector matching performance with typical style sheets. It saves ~0.9s
when loading the full HTML5 spec.

* css/CSSStyleSelector.cpp:
(WebCore::RuleData::hasRightmostSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleSet::idRules):
(WebCore::RuleSet::classRules):
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::shadowPseudoElementRules):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::RuleSet::visitedPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
(WebCore::RuleSet::pageRules):

    Add a new lists, some stylistic renamings.

(WebCore::CSSStyleSelector::matchRules):

    New link and focus checks.

(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):

    Inline the rightmost selector tag checking, skip if unnecessary.

(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):

    Common pseudo classes now match based on early filtering (though it is not a hash in this case).

(WebCore::RuleData::RuleData):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addRule):

    Sort pseudo classes to new lists.

(WebCore::RuleSet::collectFeatures):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):

    Adopt to expanded fast path (this is used by querySelectorAll).

(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):

    Rightmost selector is now checked differently than the rest. RuleSet based selection in CSSStyleSelector
    is equivalent to fastCheckRightmostSelector().

(WebCore::isFastCheckableRelation):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::isFrameFocused):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::isCommonPseudoClassSelector):
(WebCore::SelectorChecker::linkMatchesVisitedPseudoClass):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
(WebCore::SelectorChecker::tagMatches):

    Refactor a bunch of shared checks into functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt]REGRESSION(r95865): It made 4 tests crash
ggaren@apple.com [Mon, 26 Sep 2011 18:52:00 +0000 (18:52 +0000)]
[Qt]REGRESSION(r95865): It made 4 tests crash
https://bugs.webkit.org/show_bug.cgi?id=68780

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-09-26
Reviewed by Oliver Hunt.

emitJumpSlowCaseIfNotJSCell(...) cannot be moved
away since the next load depends on it.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_val):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r74971): Selection doesn't work correctly in BiDi Text
rniwa@webkit.org [Mon, 26 Sep 2011 18:30:29 +0000 (18:30 +0000)]
REGRESSION(r74971): Selection doesn't work correctly in BiDi Text
https://bugs.webkit.org/show_bug.cgi?id=57340

Reviewed by Eric Seidel.

Source/WebCore:

This patch adds the end point adjustment mechanism at bidi boundaries similar to the one NSTextView implements.

To understand the problem, suppose we have strong RTL letters "ABC" in a LTR block (visually laid out as CBA).

Per NSTextView convention, logical offsets between each letter is placed as (0)C(2)B(1)A(3). In other words,
placing the caret visually on the left of CBA yields the position inside the text node of "ABC" at offset 0.
Likewise, placing it between C and B yields ("ABC", 2), and placing it on the right of CBA yields ("ABC", 3).

Now suppose a user attempts to select the letter A by a mouse drag from the right of CBA to a point between
B and A. First, the initial mouse down places the selection's base at ("ABC", 3). Then as the mouse pointer
moves to a point on the left of A, the selection's extent is set at ("ABC", 1), selecting "BC".

To mitigate this issue, NSTextView adjusts selection base and extent under certain conditions. In the above
example, NSTextView detects user's intent and changes the selection's base to ("ABC", 0) temporarily.

This patch implements a similar trick on WebKit. We adjust the base or the extent when they're at the left
end or at the right end of a bidi run and the other end is inside of the run. In the above example, the
base position on the right of A is the right end of a bidi run and the extent position between B and A is
inside the same run (CBA), so we would adjust the base to be ("ABC", 0) as NSTextView does.

Take another example abcABC. Note offsets are assigned as (0)a(1)b(2)c(3)C(5)B(4)A(6) When the user starts
a mouse drag from the right of A to a point between B and A, we adjust the selection base to be ("abcABC", 3)
because the base is at the right end of a bidi run and the extent is in the same run. We keep the adjustment
when the mouse pointer moves to a point between C and B. However, when the mouser pointer reaches a point
between letters b and c, the selection extent is placed at ("abcABC", 2). Because the extent is outside of
the bidi run started from the selection base, we restore the original base at this point. Had we not done this,
we'll end up selecting just "c".

While this algorithm is implemented in FrameSelection::setNonDirectionalSelectionIfNeeded, this patch adds
various member functions to RenderedPosition to facilitate abstraction around inline boxes and bidi runs.

Test: editing/selection/select-bidi-run.html

* editing/FrameSelection.cpp:
(WebCore::adjustEndpointsAtBidiBoundary): Added. Implements the endpoints adjustment algorithm.
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded): Calls adjustEndpointsAtBidiBoundary, and
restores the original base as needed.
* editing/FrameSelection.h:
* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::prevLeafChild): Added to cache prevLeafChild of the current inline box.
(WebCore::RenderedPosition::nextLeafChild): Ditto for nextLeafChild.
(WebCore::RenderedPosition::isEquivalent): Compares two RenderedPositions considering neighboring inline boxes
so that the rightmost position in a box and the leftmost position in the following box is considered equal.
(WebCore::RenderedPosition::bidiLevelOnLeft): Added. Returns the bidi level of the run on the left. We can't
add a generic bidiLevel to this class because it'll be ambiguous at bidi boundaries.
(WebCore::RenderedPosition::bidiLevelOnRight): Ditto for the run on the right.
(WebCore::RenderedPosition::leftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::rightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::positionAtLeftBoundaryOfBiDiRun): Returns Position at the left edge of a bidi run
if RenderedPosition is at such a position. Asserts atLeftBoundaryOfBidiRun.
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun): Ditto for the right edge.
* editing/RenderedPosition.h:
(WebCore::RenderedPosition::atLeftBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atRightBoundaryOfBidiRun): Added.
(WebCore::RenderedPosition::atLeftmostOffsetInBox): Added.
(WebCore::RenderedPosition::atRightmostOffsetInBox): Added.
(WebCore::RenderedPosition::uncachedInlineBox): Added. We can't use a static const variable because gcc thinks
reinterpret_cast<InlineBox*>(1) is not an integral value.
(WebCore::RenderedPosition::RenderedPosition):
* editing/VisibleSelection.h:
(WebCore::VisibleSelection::visibleBase): Added.
(WebCore::VisibleSelection::visibleExtent): Added.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateSelectionForMouseDrag):

LayoutTests:

* editing/selection/select-bidi-run-expected.txt: Added.
* editing/selection/select-bidi-run.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Mon, 26 Sep 2011 18:00:50 +0000 (18:00 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/fast/dom/Window/window-resize-contents-expected.png: Added after r95897.
* platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Added after r95897.
* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png: Updated after r95897.
* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated  after r95897.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Updated  after r95897.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated  after r95897.
* platform/qt/fast/ruby/ruby-text-before-after-content-expected.png: Added after r95857.
* platform/qt/fast/ruby/ruby-text-before-after-content-expected.txt: Added after r95857.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r95256.
commit-queue@webkit.org [Mon, 26 Sep 2011 17:52:55 +0000 (17:52 +0000)]
Unreviewed, rolling out r95256.
http://trac.webkit.org/changeset/95256
https://bugs.webkit.org/show_bug.cgi?id=68814

Temporary CRASH calls no longer needed (Requested by enne on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::commitTo):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/68809> IconDatabase::syncThreadMainLoop can assert if wakeSyncTh...
mrowe@apple.com [Mon, 26 Sep 2011 17:36:19 +0000 (17:36 +0000)]
<webkit.org/b/68809> IconDatabase::syncThreadMainLoop can assert if wakeSyncThread is called before thread starts executing

If wakeSyncThread is called before syncThreadMainLoop starts executing then m_syncThreadHasWorkToDo would be set
while executing the body of the sync thread loop, causing us to skip blocking on the condition variable. This would
lead to us hitting the assertion failure due to m_disabledSuddenTerminationForSyncThread being false, unless the main
thread happened to call wakeSyncThread a second time while the first loop iteration was executing.

Reviewed by Anders Carlsson.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncThreadMainLoop): Clear m_syncThreadHasWorkToDo to indicate that we're about to perform
all pending work.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGroove/inset/outset borders show solid if the color is black.
simon.fraser@apple.com [Mon, 26 Sep 2011 17:34:08 +0000 (17:34 +0000)]
Groove/inset/outset borders show solid if the color is black.
https://bugs.webkit.org/show_bug.cgi?id=58608

Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2011-09-26
Reviewed by Simon Fraser.

Source/WebCore:

Lightened the border side colors when drawing borders with styles as
Outset/Inset/Groove/Ridge.

Tests: fast/borders/border-groove.html
       fast/borders/border-inset.html
       fast/borders/border-outset.html
       fast/borders/border-ridge.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

* fast/borders/border-groove-expected.png: Added.
* fast/borders/border-groove-expected.txt: Added.
* fast/borders/border-groove.html: Added.
* fast/borders/border-inset-expected.png: Added.
* fast/borders/border-inset-expected.txt: Added.
* fast/borders/border-inset.html: Added.
* fast/borders/border-outset-expected.png: Added.
* fast/borders/border-outset-expected.txt: Added.
* fast/borders/border-outset.html: Added.
* fast/borders/border-ridge-expected.png: Added.
* fast/borders/border-ridge-expected.txt: Added.
* fast/borders/border-ridge.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelete retired custom font data only on document
inferno@chromium.org [Mon, 26 Sep 2011 17:13:09 +0000 (17:13 +0000)]
Delete retired custom font data only on document
destruction, and not on recalc style.
https://bugs.webkit.org/show_bug.cgi?id=68805

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/custom-font-data-crash.html

* dom/Document.cpp:
(WebCore::Document::recalcStyle):

LayoutTests:

* fast/text/custom-font-data-crash-expected.txt: Added.
* fast/text/custom-font-data-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agochrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84b...
rniwa@webkit.org [Mon, 26 Sep 2011 17:00:40 +0000 (17:00 +0000)]
chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-26
Reviewed by Ryosuke Niwa.

Add missing window.layoutTestController.dumpAsText so that test output matches expectation.

* LayoutTests/editing/style/justify-without-enclosing-block.xhtml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update VideoLayerChromium textures after texture resources are reclaimed
enne@google.com [Mon, 26 Sep 2011 16:44:18 +0000 (16:44 +0000)]
[chromium] Update VideoLayerChromium textures after texture resources are reclaimed
https://bugs.webkit.org/show_bug.cgi?id=68742

Reviewed by James Robinson.

Source/WebCore:

If video textures are reclaimed (such as during a visibility change on
a tab), the dirty rect for the layer is empty and it skips out of
updating compositor resources, leaving the video textures invalid.
Instead, check the textures here to make sure they're still valid
first before early out so that they can get reupdated if necessary.

Additionally, fix a small bug in pushPropertiesTo where 1 plane RGB
videos would not get drawn because all 3 planes didn't have valid
textures.

Test: compositing/video-page-visibility.html

* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::texturesValid):
* platform/graphics/chromium/VideoLayerChromium.h:

LayoutTests:

Without this patch, this video texture is invalid.

* compositing/video-page-visibility-expected.png: Added.
* compositing/video-page-visibility-expected.txt: Added.
* compositing/video-page-visibility.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: generic performance UI test for panel switch.
loislo@chromium.org [Mon, 26 Sep 2011 16:31:46 +0000 (16:31 +0000)]
Web Inspector: generic performance UI test for panel switch.
https://bugs.webkit.org/show_bug.cgi?id=68806

Reviewed by Pavel Feldman.

* inspector/performance/resources/show-panel-elements.html: Removed.
* inspector/performance/resources/show-panel-network.html: Removed.
* inspector/performance/resources/show-panel.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up code imported from WebKitAPITest
aroben@apple.com [Mon, 26 Sep 2011 15:55:05 +0000 (15:55 +0000)]
Clean up code imported from WebKitAPITest

Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
TestWebKitAPI conventions

Reviewed by David Levin.

* TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
namespace name.

(TestWebKitAPI::WebViewDestruction::SetUp):
(TestWebKitAPI::WebViewDestruction::webViewCount):
(TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
(TestWebKitAPI::WebViewDestruction::runMessagePump):
(TestWebKitAPI::WebViewDestruction::TearDown):
(TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
Moved functionality from free functions into these new test fixtures.

* TestWebKitAPI/win/HostWindow.cpp:
* TestWebKitAPI/win/HostWindow.h:
Prefixed Win32 API calls with ::. Updated namespace name.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Mon, 26 Sep 2011 15:51:43 +0000 (15:51 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-26

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: introduce protocol backwards compatibility validator.
pfeldman@chromium.org [Mon, 26 Sep 2011 15:29:39 +0000 (15:29 +0000)]
Web Inspector: introduce protocol backwards compatibility validator.
https://bugs.webkit.org/show_bug.cgi?id=68800

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/Inspector.draft-01.json: Copied from Source/WebCore/inspector/Inspector.json.
* inspector/validate-protocol-compatibility: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Qt gardening.
reni@webkit.org [Mon, 26 Sep 2011 14:45:33 +0000 (14:45 +0000)]
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68796

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Qt gardening.
reni@webkit.org [Mon, 26 Sep 2011 14:39:24 +0000 (14:39 +0000)]
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-26

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix documentation generation by specifying the sources
kov@webkit.org [Mon, 26 Sep 2011 13:35:51 +0000 (13:35 +0000)]
Fix documentation generation by specifying the sources
directory with $(top_srcdir).

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-26
Reviewed by Xan Lopez.

* docs/GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unused variable in QNetworkReplyHandler::sendNetworkRequest.
commit-queue@webkit.org [Mon, 26 Sep 2011 13:03:01 +0000 (13:03 +0000)]
[Qt] Unused variable in QNetworkReplyHandler::sendNetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=68798

Patch by Andreas Kling <kling@webkit.org> on 2011-09-26
Reviewed by Noam Rosenthal.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendNetworkRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSecond unreviewed build fix for r95941
loislo@chromium.org [Mon, 26 Sep 2011 12:52:41 +0000 (12:52 +0000)]
Second unreviewed build fix for r95941

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for webkit builds after r95941.
loislo@chromium.org [Mon, 26 Sep 2011 12:48:55 +0000 (12:48 +0000)]
Unreviewed build fix for webkit builds after r95941.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCallFunctionImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95945 268f45cc-cd09-0410-ab3c-d52691b4dbfc