WebKit.git
12 years ago2010-01-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 7 Jan 2010 23:33:57 +0000 (23:33 +0000)]
2010-01-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
        https://bugs.webkit.org/show_bug.cgi?id=33348
        <rdar://problem/7310616>

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): We only want to
        handle file: URLs for the user stylesheet now, so special-case the
        DashboardClient's funky user stylesheet URL by mapping it to the
        equivalent file URL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 7 Jan 2010 22:55:01 +0000 (22:55 +0000)]
2010-01-07  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Generate V8 bindings header declarations for named and indexed accessors.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
        * bindings/v8/custom/V8NodeListCustom.cpp:
        * bindings/v8/custom/V8StorageCustom.cpp:
        * bindings/v8/custom/V8StyleSheetListCustom.cpp:
        * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBetter build fix: use 'this->structure()', since 'structure' is a
ggaren@apple.com [Thu, 7 Jan 2010 22:36:05 +0000 (22:36 +0000)]
Better build fix: use 'this->structure()', since 'structure' is a
PassRefPtr, and therefore null.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix: avoid a name conflict by using the local 'structure' instead
ggaren@apple.com [Thu, 7 Jan 2010 22:27:20 +0000 (22:27 +0000)]
Build fix: avoid a name conflict by using the local 'structure' instead
of the member 'structure()'.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 Jan 2010 22:13:31 +0000 (22:13 +0000)]
2010-01-07  Simon Fraser  <simon.fraser@apple.com>

        Build fix.

        Add RenderEmbeddedObject.h/cpp to all the build systems.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 7 Jan 2010 22:07:36 +0000 (22:07 +0000)]
2010-01-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Safari memory usage skyrockets using new Google AdWords interface
        https://bugs.webkit.org/show_bug.cgi?id=33343

        The memory use was caused by the global object creating too many structures
        as it thrashed between different specific functions.

        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        (JSC::Structure::addPropertyTransition):
        (JSC::Structure::changePrototypeTransition):
        (JSC::Structure::despecifyFunctionTransition):
        (JSC::Structure::addAnonymousSlotsTransition):
        (JSC::Structure::getterSetterTransition):
        (JSC::Structure::toDictionaryTransition):
        (JSC::Structure::addPropertyWithoutTransition):
        (JSC::Structure::despecifyAllFunctions):
        * runtime/Structure.h:
        (JSC::Structure::disableSpecificFunctionTracking): Track a thrash count
        for specific functions. Disable specific function tracking once the
        thrash count has been hit.
2010-01-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Safari memory usage skyrockets using new Google AdWords interface
        https://bugs.webkit.org/show_bug.cgi?id=33343

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function
        tracking for the window object, since there's no way to do direct
        method calls on the window object; they all go through the window shell.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 Jan 2010 21:57:12 +0000 (21:57 +0000)]
2010-01-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Kevin Decker, Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33338
        Create a renderer for <object> and <embed>

        Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
        Instances of RenderPartObject are now only allocated for iframes.

        Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.

        * WebCore.xcodeproj/project.pbxproj:
        Add RenderEmbeddedObject.h/cpp

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject.
        (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case.
        (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject
        (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::addWidgetToUpdate):
        (WebCore::FrameView::removeWidgetToUpdate):
        (WebCore::FrameView::updateWidgets):
        Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.

        * rendering/RenderEmbeddedObject.cpp: Added.
        * rendering/RenderEmbeddedObject.h: Added.
        Most of the code moved from RenderPartObject.

        * rendering/RenderObject.h:
        (WebCore::RenderObject::isEmbeddedObject): New method.

        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
        * rendering/RenderPart.h: Comments.

        * rendering/RenderPartObject.h:
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code.
        (WebCore::RenderPartObject::layout): Removed object/embed-specific code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 7 Jan 2010 21:47:46 +0000 (21:47 +0000)]
2010-01-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=33338
        Create a renderer for <object> and <embed>

        First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
        so we don't need to call it here, and can thus remove the attach() override entirely.

        * html/HTMLIFrameElement.cpp:
        * html/HTMLIFrameElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-01-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 7 Jan 2010 21:36:58 +0000 (21:36 +0000)]
2009-01-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Migrate to canvas-based text viewer / editor that scales.

        https://bugs.webkit.org/show_bug.cgi?id=33001

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/JavaScriptHighlighterScheme.js: Added.
        (WebInspector.JavaScriptHighlighterScheme):
        * inspector/front-end/KeyboardShortcut.js:
        * inspector/front-end/TextEditor.js: Added.
        (WebInspector.TextEditor):
        (WebInspector.TextSelectionModel):
        (WebInspector.TextCursor):
        * inspector/front-end/TextEditorHighlighter.js: Added.
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.highlight):
        (WebInspector.TextEditorHighlighter.prototype._lex):
        * inspector/front-end/TextEditorModel.js: Added.
        (WebInspector.TextRange):
        (WebInspector.TextRange.prototype.clone):
        (WebInspector.TextEditorModel):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Christian Sejersen <christian.webkit@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 21:32:13 +0000 (21:32 +0000)]
2010-01-07  Christian Sejersen  <christian.webkit@gmail.com>

        Reviewed by Darin Adler.

        document.title does not replace or remove space characters
        https://bugs.webkit.org/show_bug.cgi?id=27032

        * fast/dom/Document/document-title-get-expected.txt: Added.
        * fast/dom/Document/document-title-get.html: Added.
        * fast/dom/Document/script-tests/document-title-get.js: Added.
2010-01-07  Christian Sejersen  <christian.webkit@gmail.com>

        Reviewed by Darin Adler.

        document.title does not replace or remove space characters
        https://bugs.webkit.org/show_bug.cgi?id=27032

        Test: fast/dom/Document/document-title-get.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        Initialization of m_rawTitle
        (WebCore::canonicalizedTitle):
        Moved from DocumentLoader.cpp with minor edits
        (WebCore::Document::updateTitle):
        Ensures the title is canonicalized
        (WebCore::Document::setTitle):
        Uses m_rawTitle instaed of m_title
        (WebCore::Document::removeTitle):
        Uses m_rawTitle instead of m_title

        * dom/Document.h:
        Added m_rawTitle that stores the passed in title, m_title now stores the
        canonicalized title

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setTitle):
        The title passed in is now canonicalized in Document.cpp

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Thu, 7 Jan 2010 20:58:14 +0000 (20:58 +0000)]
2010-01-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Allow leading/trailing space for CSS nth-*() and lang().
        https://bugs.webkit.org/show_bug.cgi?id=17248

        For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
        See the bug comments for why we don't allow space at other places.

        * fast/css/css3-space-in-nth-and-lang.html: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
2010-01-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Allow leading/trailing space for CSS nth-*() and lang().
        https://bugs.webkit.org/show_bug.cgi?id=17248

        For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
        See the bug comments for why we don't allow space at other places.

        * css/CSSGrammar.y:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Simon Fraser.
kdecker@apple.com [Thu, 7 Jan 2010 20:26:04 +0000 (20:26 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=33331
        (WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins)

        * Plugins/Hosted/NetscapePluginHostManager.h: Modify method signature for instantiatePlugin to include acceleratedCompositingEnabled bool.
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView createPlugin]): Pass accelerated compositing status to NetscapePluginHostManage

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAX: contentEditable DIVs are not AX accessible
cfleizach@apple.com [Thu, 7 Jan 2010 20:24:53 +0000 (20:24 +0000)]
AX: contentEditable DIVs are not AX accessible
https://bugs.webkit.org/show_bug.cgi?id=33325

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/contenteditable-hidden-div.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::canSetValueAttribute):

LayoutTests:

* accessibility/contenteditable-hidden-div-expected.txt: Added.
* accessibility/contenteditable-hidden-div.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 20:20:37 +0000 (20:20 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        Skip LayoutTests/http/tests/media/video-error-abort.html

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. roll-out r52917, r52932 and r52934.
ossy@webkit.org [Thu, 7 Jan 2010 20:18:23 +0000 (20:18 +0000)]
Unreviewed. roll-out r52917, r52932 and r52934.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 20:08:19 +0000 (20:08 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Resolve merge conflict.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setContextDebugId):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 20:00:38 +0000 (20:00 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        No review, rolling out r52847.
        http://trac.webkit.org/changeset/52847
        https://bugs.webkit.org/show_bug.cgi?id=33232

        Might have caused a perf regression.  I'm rolling this out to see if it
        heals the perf bot.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::haveInterpreter):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertDocumentToV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
        * bindings/v8/V8IsolatedContext.cpp:
        (WebCore::V8IsolatedContext::V8IsolatedContext):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::~V8Proxy):
        (WebCore::V8Proxy::handleOutOfMemory):
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::setInjectedScriptContextDebugId):
        (WebCore::V8Proxy::clearForClose):
        (WebCore::V8Proxy::clearForNavigation):
        (WebCore::V8Proxy::context):
        (WebCore::V8Proxy::mainWorldContext):
        (WebCore::V8Proxy::currentContext):
        (WebCore::V8Proxy::setContextDebugId):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::windowShell):
        * bindings/v8/WorldContextHandle.cpp:
        (WebCore::WorldContextHandle::adjustedContext):
2010-01-07  Adam Barth  <abarth@webkit.org>

        No review, rolling out r52847.
        http://trac.webkit.org/changeset/52847
        https://bugs.webkit.org/show_bug.cgi?id=33232

        Might have caused a perf regression.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed trivial fix.
ossy@webkit.org [Thu, 7 Jan 2010 19:45:58 +0000 (19:45 +0000)]
Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in skiplist by this commit.

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 19:41:23 +0000 (19:41 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        Add executable bit to video-throttled-load cgi.

        * http/tests/media/video-throttled-load.cgi: Added property svn:executable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Fix the Mac bots. Why is there no HTTPD PID file?
ossy@webkit.org [Thu, 7 Jan 2010 19:25:25 +0000 (19:25 +0000)]
Unreviewed. Fix the Mac bots. Why is there no HTTPD PID file?

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix
mitz@apple.com [Thu, 7 Jan 2010 18:48:09 +0000 (18:48 +0000)]
Build fix

* WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoStore HTTPD PID in a variable to fix warnings if for some reason the pidfile gets...
ossy@webkit.org [Thu, 7 Jan 2010 18:33:00 +0000 (18:33 +0000)]
Store HTTPD PID in a variable to fix warnings if for some reason the pidfile gets deleted before httpd terminates.
This should fix the occasional warnings for uninitialized values on the Mac bots.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Alexey Proskuryakov.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded Font::typesettingFeatures() and deployed it
mitz@apple.com [Thu, 7 Jan 2010 18:28:04 +0000 (18:28 +0000)]
Added Font::typesettingFeatures() and deployed it

Reviewed by Sam Weinig.

No change in funcitonality

* WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
* platform/graphics/Font.h:
(WebCore::Font::typesettingFeatures): Added. Determines the typesetting
    features from the text redndering mode.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache): Use typesettingFeatures().
* platform/graphics/SimpleFontData.h:
* platform/graphics/TypesettingFeatures.h: Added.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::disableLigatures): Take TypesettingFeatures instead of
    TextRenderingMode.
(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
    Use typesettingFeatures().
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
    Ditto.
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes): Take
    TypesettingFeatures instead of TextRenderingMode.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 7 Jan 2010 18:08:42 +0000 (18:08 +0000)]
2010-01-07  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r52900.
        http://trac.webkit.org/changeset/52900
        https://bugs.webkit.org/show_bug.cgi?id=30055

        Broke over 30 SVG pixel tests.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Kenneth Rohde Christiansen.
hausmann@webkit.org [Thu, 7 Jan 2010 17:45:59 +0000 (17:45 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] The library version number of the first package release is 4.7.0.

* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Allow the application to override online/offline network status
hausmann@webkit.org [Thu, 7 Jan 2010 17:29:22 +0000 (17:29 +0000)]
[Qt] Allow the application to override online/offline network status
https://bugs.webkit.org/show_bug.cgi?id=32684

Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

WebCore:

Added API to NetworkStateNotifier for forcing network status.

* platform/network/NetworkStateNotifier.h:
* platform/network/qt/NetworkStateNotifierPrivate.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:
(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
(WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):

WebKit/qt:

Add a setting so that applications can overide the network status.
Applications that use this setting still need to block network access
through QNAM.

* Api/qwebsettings.cpp:
(qt_networkAccessAllowed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed typo fix.
ossy@webkit.org [Thu, 7 Jan 2010 17:26:24 +0000 (17:26 +0000)]
Unreviewed typo fix.

* platform/gtk/Skipped: missing "l" suffix added to fast/repaint/subtree-layoutstate-transform.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoprospective bearer management build fix to get the include path correct
hausmann@webkit.org [Thu, 7 Jan 2010 17:14:42 +0000 (17:14 +0000)]
prospective bearer management build fix to get the include path correct

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 16:38:03 +0000 (16:38 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=33323
        Skip new test on Tiger for now.

        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.
ossy@webkit.org [Thu, 7 Jan 2010 16:22:05 +0000 (16:22 +0000)]
[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.

Reviewed by Simon Hausmann.

* JavaScriptCore.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 7 Jan 2010 16:02:50 +0000 (16:02 +0000)]
2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=33272
        'abort' event still fired as a progress event

        rdar://6710625
        Test media/video-error-abort.html doesn't work

        Test: http/tests/media/video-error-abort.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent.
        (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed
        in https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization
        to match spec wording.
        * html/HTMLMediaElement.h: Remove enqueueEvent prototype.

2010-01-07  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=33272
        'abort' event still fired as a progress event

        rdar://6710625
        Test media/video-error-abort.html doesn't work

        * http/tests/media/video-error-abort-expected.txt: Copied from LayoutTests/media/video-error-abort-expected.txt.
        * http/tests/media/video-error-abort.html: Copied from LayoutTests/media/video-error-abort.html.
            Modified to run with slow loading cgi, add test to ensure that 'abort' event is not a
            progress event.
        * media/video-error-abort-expected.txt: Removed.
        * media/video-error-abort.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Thu, 7 Jan 2010 14:37:26 +0000 (14:37 +0000)]
2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Wrong state and TouchLists in TouchEvents
        https://bugs.webkit.org/show_bug.cgi?id=32878

        Touch event tests changed to match the API and semantics of iPhone and
        Android. Each new touch point press dispatches a touchstart event with
        the pressed touch point(s) in the changedTouches list, and a release
        dispatches a touchend event with the released touch point(s) in
        changedTouches. Moved points dispatch a touchmove event, with the moved
        points in changedTouches. Old behaviour emitted only one touchstart when
        the first point was pressed and one touchend when the last point was
        released, and any events in between were touchmoves. New presses or
        releases could only be detected by comparing the lists touches and
        changedTouches.

        * fast/events/basic-touch-events-expected.txt:
        * fast/events/script-tests/basic-touch-events.js:
        (singleTouchSequence):
        (multiTouchSequence):
2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Wrong state and TouchLists in TouchEvents
        https://bugs.webkit.org/show_bug.cgi?id=32878

        Touch events changed to match the API and semantics of iPhone and
        Android. Each new touch point press dispatches a touchstart event with
        the pressed touch point(s) in the changedTouches list, and a release
        dispatches a touchend event with the released touch point(s) in
        changedTouches. Moved points dispatch a touchmove event, with the moved
        points in changedTouches. Old behaviour emitted only one touchstart when
        the first point was pressed and one touchend when the last point was
        released, and any events in between were touchmoves. New presses or
        releases could only be detected by comparing the lists touches and
        changedTouches.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent):
        * page/EventHandler.h:
2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Antti Koivisto.

        Wrong state and TouchLists in TouchEvents
        https://bugs.webkit.org/show_bug.cgi?id=32878

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::touchStart):
        (EventSender::touchEnd):
        (EventSender::clearTouchPoints):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Jan 2010 13:43:28 +0000 (13:43 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Remove COM code generation stuff.
        https://bugs.webkit.org/show_bug.cgi?id=32854

        Remove the followings:
        - CodeGeenratorCOM.pm, COM code generator,
        - "#if !defined(LANGUAGE_COM) || !LANGUAGE_COM" in IDL files, and
        - UUID attributes in IDL files.

        * bindings/scripts/CodeGeneratorCOM.pm: Removed.
        * css/CSSCharsetRule.idl:
        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl:
        * css/CSSMediaRule.idl:
        * css/CSSPageRule.idl:
        * css/CSSPrimitiveValue.idl:
        * css/CSSRule.idl:
        * css/CSSRuleList.idl:
        * css/CSSStyleDeclaration.idl:
        * css/CSSStyleRule.idl:
        * css/CSSStyleSheet.idl:
        * css/CSSUnknownRule.idl:
        * css/CSSValue.idl:
        * css/CSSValueList.idl:
        * css/Counter.idl:
        * css/MediaList.idl:
        * css/RGBColor.idl:
        * css/Rect.idl:
        * css/StyleSheet.idl:
        * css/StyleSheetList.idl:
        * css/WebKitCSSKeyframeRule.idl:
        * css/WebKitCSSKeyframesRule.idl:
        * css/WebKitCSSTransformValue.idl:
        * dom/Attr.idl:
        * dom/CDATASection.idl:
        * dom/CharacterData.idl:
        * dom/Comment.idl:
        * dom/DOMImplementation.idl:
        * dom/Document.idl:
        * dom/DocumentFragment.idl:
        * dom/DocumentType.idl:
        * dom/Element.idl:
        * dom/Entity.idl:
        * dom/EntityReference.idl:
        * dom/Event.idl:
        * dom/EventListener.idl:
        * dom/EventTarget.idl:
        * dom/NamedNodeMap.idl:
        * dom/Node.idl:
        * dom/NodeList.idl:
        * dom/Notation.idl:
        * dom/ProcessingInstruction.idl:
        * dom/Text.idl:
        * html/HTMLAnchorElement.idl:
        * html/HTMLAppletElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLBRElement.idl:
        * html/HTMLBaseElement.idl:
        * html/HTMLBaseFontElement.idl:
        * html/HTMLBlockquoteElement.idl:
        * html/HTMLBodyElement.idl:
        * html/HTMLButtonElement.idl:
        * html/HTMLCanvasElement.idl:
        * html/HTMLCollection.idl:
        * html/HTMLDListElement.idl:
        * html/HTMLDirectoryElement.idl:
        * html/HTMLDivElement.idl:
        * html/HTMLDocument.idl:
        * html/HTMLElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLFieldSetElement.idl:
        * html/HTMLFontElement.idl:
        * html/HTMLFormElement.idl:
        * html/HTMLFrameElement.idl:
        * html/HTMLFrameSetElement.idl:
        * html/HTMLHRElement.idl:
        * html/HTMLHeadElement.idl:
        * html/HTMLHeadingElement.idl:
        * html/HTMLHtmlElement.idl:
        * html/HTMLIFrameElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLIsIndexElement.idl:
        * html/HTMLLIElement.idl:
        * html/HTMLLabelElement.idl:
        * html/HTMLLegendElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLMapElement.idl:
        * html/HTMLMarqueeElement.idl:
        * html/HTMLMenuElement.idl:
        * html/HTMLMetaElement.idl:
        * html/HTMLModElement.idl:
        * html/HTMLOListElement.idl:
        * html/HTMLObjectElement.idl:
        * html/HTMLOptGroupElement.idl:
        * html/HTMLOptionElement.idl:
        * html/HTMLOptionsCollection.idl:
        * html/HTMLParagraphElement.idl:
        * html/HTMLParamElement.idl:
        * html/HTMLPreElement.idl:
        * html/HTMLQuoteElement.idl:
        * html/HTMLScriptElement.idl:
        * html/HTMLSelectElement.idl:
        * html/HTMLStyleElement.idl:
        * html/HTMLTableCaptionElement.idl:
        * html/HTMLTableCellElement.idl:
        * html/HTMLTableColElement.idl:
        * html/HTMLTableElement.idl:
        * html/HTMLTableRowElement.idl:
        * html/HTMLTableSectionElement.idl:
        * html/HTMLTextAreaElement.idl:
        * html/HTMLTitleElement.idl:
        * html/HTMLUListElement.idl:

2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Remove COM code generation files.
        https://bugs.webkit.org/show_bug.cgi?id=32854

        * WebKit.vcproj/DerivedSources.make: Removed.
        * WebKit.vcproj/build-generated-files.sh: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix for Qt on Mac OS X
vestbo@webkit.org [Thu, 7 Jan 2010 13:15:04 +0000 (13:15 +0000)]
Unreviewed build fix for Qt on Mac OS X

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAndroid requires ability to increase layout delay
steveblock@google.com [Thu, 7 Jan 2010 12:16:25 +0000 (12:16 +0000)]
Android requires ability to increase layout delay

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 7 Jan 2010 12:13:53 +0000 (12:13 +0000)]
2010-01-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Holger Freyther.

        [Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
        https://bugs.webkit.org/show_bug.cgi?id=33312

        Using of operator += cause compile error on Mac, so it is changed to
        "= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".

        * wtf/FastMalloc.cpp:
        (WTF::TCMallocStats::realloc):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReworked r52853 after r52876 rolled it out.
ossy@webkit.org [Thu, 7 Jan 2010 12:12:32 +0000 (12:12 +0000)]
Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of https://bugs.webkit.org/show_bug.cgi?id=33153.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 11:50:44 +0000 (11:50 +0000)]
2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Adam Barth.

        Created a module that runs the style package unit tests.

        https://bugs.webkit.org/show_bug.cgi?id=32973

        * Scripts/test-webkitpy:
        * Scripts/webkitpy/style/unittests.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 11:35:40 +0000 (11:35 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Some IDL files lack "," separators for extended attributes.
        https://bugs.webkit.org/show_bug.cgi?id=33190

        To find such mistakes, IDLParser.pm rejects whitespace characters in
        extended attribute names.

        * bindings/scripts/IDLParser.pm:
          parseExtendedAttributes rejects whitespace in a name.
        * css/WebKitCSSTransformValue.idl: Add missing ",".
        * dom/EventTarget.idl: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] need an API to suspend and resume active Javascript DOM objects.
hausmann@webkit.org [Thu, 7 Jan 2010 11:24:15 +0000 (11:24 +0000)]
[Qt] need an API to suspend and resume active Javascript DOM objects.
https://bugs.webkit.org/show_bug.cgi?id=31673

Patch by Yongjun Zhang  <yongjun.zhang@nokia.com>, Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-01-07
Reviewed by Simon Hausmann.

Add suspend and resume DOM objects private API to QWebFrame.

* Api/qwebframe.cpp:
(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 10:52:04 +0000 (10:52 +0000)]
2010-01-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
        WebKitCSSTransformValue.idl correctly.
        https://bugs.webkit.org/show_bug.cgi?id=33193

        CodeGeneratorV8.pm doesn't handle inheritance very well and it
        tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
        which does not exist. Because WebKitCSSTransformValue inherits
        CSSValueList and CSSValueList already has HadIndexGetter, we don't
        need to do anything for WebKitCSSTransformValue about HasIndexGetter.

        * bindings/scripts/CodeGeneratorV8.pm:
          Reset $hasGetter for WebKitCSSTransformValue.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 10:22:40 +0000 (10:22 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Don't print a redundant message when confirming a diff
        https://bugs.webkit.org/show_bug.cgi?id=33315

        Instead of saying "ERROR: User declined" we should just exit because
        the use knows they just declined!

        * Scripts/webkitpy/steps/confirmdiff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 7 Jan 2010 10:19:38 +0000 (10:19 +0000)]
2010-01-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Holger Freyther.

        [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
        https://bugs.webkit.org/show_bug.cgi?id=33312

        Remove pByte (committed in r42344 from #20422), because pByte doesn't
        exist and it is unnecessary.

        * wtf/FastMalloc.cpp:
        (WTF::TCMallocStats::realloc):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 10:12:54 +0000 (10:12 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Check style before uploading a patch
        https://bugs.webkit.org/show_bug.cgi?id=33314

        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/steps/checkstyle.py:
        * Scripts/webkitpy/steps/options.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 09:51:01 +0000 (09:51 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Add prepare and post to webkit-patch main help
        https://bugs.webkit.org/show_bug.cgi?id=33313

        * Scripts/webkitpy/commands/upload.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 08:57:10 +0000 (08:57 +0000)]
2010-01-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
        https://bugs.webkit.org/show_bug.cgi?id=33290

        Add the Chromium builders to our list of core builders and test that our regexps work.
        I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.

        * Scripts/webkitpy/buildbot.py:
        * Scripts/webkitpy/buildbot_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 08:49:25 +0000 (08:49 +0000)]
2010-01-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        bugzilla-tool needs a new name
        https://bugs.webkit.org/show_bug.cgi?id=28459

        Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
        make more sense with the new name.

        * Scripts/bugzilla-tool: Removed.
        * Scripts/webkit-patch: Added.
        * Scripts/webkit-tools-completion.sh:
        * Scripts/webkitpy/bugzilla_unittest.py:
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/download_unittest.py:
        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/queues.py:
        * Scripts/webkitpy/commands/queues_unittest.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/queueengine.py:
        * Scripts/webkitpy/steps/completerollout.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 08:36:52 +0000 (08:36 +0000)]
2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Moved style-related modules to webkitpy.style sub-package.

        https://bugs.webkit.org/show_bug.cgi?id=32971

        * Scripts/check-webkit-style:
          - Updated import statement.

        * Scripts/test-webkitpy:
          - Updated import statements.

        * Scripts/webkitpy/cpp_style.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/cpp_style_unittest.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/style.py: Removed.
          - Moved to webkitpy/style/checker.py.

        * Scripts/webkitpy/style/__init__.py: Added.
          - Added containing webkitpy directory to package search path.

        * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
        * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
          - Updated import statement.

        * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
        * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
          - Update import statement.

        * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
        * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
        * Scripts/webkitpy/style_unittest.py: Removed.
          - Moved to webkitpy/style/checker_unittest.py.

        * Scripts/webkitpy/text_style.py: Removed.
          - Moved to webkitpy/style.

        * Scripts/webkitpy/text_style_unittest.py: Removed.
          - Moved to webkitpy/style.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-07 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 7 Jan 2010 08:22:04 +0000 (08:22 +0000)]
2010-01-07  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        Do not return strings whose handles are in near death state (that means
        they might be GCed) or just empty.
        https://bugs.webkit.org/show_bug.cgi?id=31180

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8ExternalString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 MORITA Hajime <morrita@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 08:06:01 +0000 (08:06 +0000)]
2010-01-06  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Nikolas Zimmermann.

        SVG background color on selected text goes wrong when text has
        gradient stroke.
        https://bugs.webkit.org/show_bug.cgi?id=33069

        Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
        and paint background and foreground in separate subphase.

        * svg/text/selection-background-color.xhtml: Added.
        * platform/mac/svg/text/selection-background-color-expected.checksum: Added.
        * platform/mac/svg/text/selection-background-color-expected.png: Added.
        * platform/mac/svg/text/selection-background-color-expected.txt: Added.

        * platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
        * platform/mac/svg/batik/text/textDecoration2-expected.checksum:
        * platform/mac/svg/batik/text/textDecoration2-expected.png:
        * platform/mac/svg/text/text-deco-01-b-expected.checksum:
        * platform/mac/svg/text/text-deco-01-b-expected.png:
        * platform/mac/svg/text/text-spacing-01-b-expected.checksum:
        * platform/mac/svg/text/text-spacing-01-b-expected.png:
        * platform/mac/svg/text/text-text-03-b-expected.checksum:
        * platform/mac/svg/text/text-text-03-b-expected.png:
        * platform/mac/svg/text/text-text-08-b-expected.checksum:
        * platform/mac/svg/text/text-text-08-b-expected.png:
        Re-baselined due to painting algorithm change.
2010-01-06  MORITA Hajime  <morrita@gmail.com>

        Reviewed by Nikolas Zimmermann.

        SVG background color on selected text goes wrong when text has
        gradient stroke.
        https://bugs.webkit.org/show_bug.cgi?id=33069

        Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
        and paint background and foreground in separate subphase.

        Test: svg/text/selection-background-color.xhtml

        * rendering/SVGCharacterLayoutInfo.h:
        (WebCore::SVGTextChunkWalker::SVGTextChunkWalker):
        Added m_setupBackgroundCallback, m_setupForegroundCallback
        (WebCore::SVGTextChunkWalker::setupBackground):
        (WebCore::SVGTextChunkWalker::setupForeground):
        Added.
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::paintCharacters):
        pass SVGTextPaintInfo instead of SVGPaintServer
        * rendering/SVGInlineTextBox.h:
        (WebCore::SVGTextPaintSubphase):
        (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
        Added.
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::walkTextChunks):
        Invoke setupBackground() and setupForeground()
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer):
        Added.
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback):
        (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
        (WebCore::SVGRootInlineBox::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Thu, 7 Jan 2010 07:07:54 +0000 (07:07 +0000)]
2010-01-06  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout.

        https://bugs.webkit.org/show_bug.cgi?id=33204

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Kinuko Yasuda <kinuko@chromium.org>
tkent@chromium.org [Thu, 7 Jan 2010 06:12:53 +0000 (06:12 +0000)]
2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        Remove fast/events/keydown-numpad-key.html from the Skipped list.
        https://bugs.webkit.org/show_bug.cgi?id=33250

        * platform/qt/Skipped:

2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        Make windowsKeyCodeForKeyEvent() return correct key code for
        numeric-pad arrow keys.
        https://bugs.webkit.org/show_bug.cgi?id=33250

        Test: fast/events/keydown-numpad-keys.html

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::windowsKeyCodeForKeyEvent):

2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        [Qt] Support the 3rd argument of EventSender.keyDown that
        has been recently added to report keyLocation
        (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
        https://bugs.webkit.org/show_bug.cgi?id=33250

        Test: fast/events/keydown-numpad-keys.html

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::keyDown):
        * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 06:00:23 +0000 (06:00 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add long_help for all common commands.
        https://bugs.webkit.org/show_bug.cgi?id=33261

        For now these long_helps are pretty basic.
        These were all written to just explain the steps
        that each command runs.  This style long_help could
        be made easier by using:
        https://bugs.webkit.org/show_bug.cgi?id=33257

        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/queries.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-18 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Thu, 7 Jan 2010 05:30:26 +0000 (05:30 +0000)]
2009-10-18 Patrick Gansterer <paroga@paroga.com>

        Reviewed by Dirk Schulze.

        Improve DOM performance in large SVG files.
        Check the dirty area before painting a path, which prevents unnecessary
        clipping and changes to the GraphicsContext.
        https://bugs.webkit.org/show_bug.cgi?id=30055

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 7 Jan 2010 04:45:10 +0000 (04:45 +0000)]
2010-01-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Use a static HashMap for HTMLElement::tagPriority().
        https://bugs.webkit.org/show_bug.cgi?id=33269

        The prior code compares AtomicStringImpl pointers 18 times at
        worst. This change avoids it.

        No new tests because this is just a refactoring.

        * html/HTMLElement.cpp:
        (WebCore::Empty1IntHashTraits): A HashTraits to return 1 as the empty value.
        (WebCore::initializeTagPriorityMap): Initialization of a static HashMap.
        (WebCore::HTMLElement::tagPriority): Use the static HashMap created by initializeTagPriorityMap().
        * html/HTMLElement.h:
        (WebCore::HTMLElement::HTMLElement): Add an assertion about non-null localName().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Mike Belshe <mike@belshe.com>
eric@webkit.org [Thu, 7 Jan 2010 04:06:25 +0000 (04:06 +0000)]
2010-01-06  Mike Belshe  <mike@belshe.com>

        Add a flag to the ResourceResponse for tracking if a request was
        fetched via SPDY.  This is plumbed through so that we can inform
        a webpage via JavaScript if it was fecthed via the experimental
        SPDY protocol.

        https://bugs.webkit.org/show_bug.cgi?id=33186

        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::wasFetchedViaSpdy):
        (WebCore::ResourceResponse::setWasFetchedViaSpdy):
2010-01-06  Mike Belshe  <mike@belshe.com>

        Add a flag to the ResourceResponse for tracking if a request was
        fetched via SPDY.  This is plumbed through so that we can inform
        a webpage via JavaScript if it was fecthed via the experimental
        SPDY protocol.

        https://bugs.webkit.org/show_bug.cgi?id=33186

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::wasFetchedViaSpdy):
        (WebKit::WebURLResponse::setWasFetchedViaSpdy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Add page zooming support to Qt DumpRenderTree
tonikitoo@webkit.org [Thu, 7 Jan 2010 04:01:26 +0000 (04:01 +0000)]
[Qt] Add page zooming support to Qt DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=32898

Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
         Diego Gonzalez <diego.gonzalez@openbossa.org> and
         Afonso Costa <afonso.costa@openbossa.org> on 2010-01-06
Reviewed by Kenneth Christiansen.

WebKitTools:

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::zoomPageIn):
(EventSender::zoomPageOut):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 03:37:50 +0000 (03:37 +0000)]
2010-01-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Treat.

        [Qt] RenderTheme: Missing support for native sliders

        https://bugs.webkit.org/show_bug.cgi?id=33122

        Implement painting of native slider controls in RenderTheme
        and unskip a couple of layout tests that are passing after
        this change.

        * platform/qt/Skipped:
2010-01-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Treat.

        [Qt] RenderTheme: Missing support for native sliders

        https://bugs.webkit.org/show_bug.cgi?id=33122

        Implement painting of native slider controls in RenderTheme
        and unskip a couple of layout tests that are passing after
        this change.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintSliderTrack):
        (WebCore::RenderThemeQt::adjustSliderTrackStyle):
        (WebCore::RenderThemeQt::paintSliderThumb):
        (WebCore::RenderThemeQt::adjustSliderThumbStyle):
        (WebCore::RenderThemeQt::supportsFocus):
        (WebCore::RenderThemeQt::adjustSliderThumbSize):
        * platform/qt/RenderThemeQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Thu, 7 Jan 2010 03:23:16 +0000 (03:23 +0000)]
2010-01-06  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Darin Adler.

        Adjust incorrect comments after r40534.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::markActiveObjectsForContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix for chromium.
ukai@chromium.org [Thu, 7 Jan 2010 02:57:53 +0000 (02:57 +0000)]
Unreviewed build fix for chromium.
Add "bool V8WorkerContext::WebSocketEnabled()"

* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::WebSocketEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix.
ukai@chromium.org [Thu, 7 Jan 2010 02:45:24 +0000 (02:45 +0000)]
Unreviewed build fix.
remove wrong assertion

* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 7 Jan 2010 02:33:35 +0000 (02:33 +0000)]
2010-01-06  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin

        Add WebSocket feature in Worker
        https://bugs.webkit.org/show_bug.cgi?id=32214

        * websocket/tests/workers/resources/simple_wsh.py: Copied from LayoutTests/websocket/tests/simple_wsh.py.
        * websocket/tests/workers/resources/worker-simple.js: Added.
        * websocket/tests/workers/worker-simple-expected.txt: Added.
        * websocket/tests/workers/worker-simple.html: Added.
2010-01-06  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        Add WebSocket feature in Worker
        https://bugs.webkit.org/show_bug.cgi?id=32214

        Introduce ThreadableWebSocketChannel interface and add
        WorkerThreadableWebSocketChannel for Worker.
        WorkerThreadableWebSocketChannel uses WebSocketChannel in the
        main thread, which is managed by Peer and communicated via Bridge.

        Test: websocket/tests/workers/worker-simple.html

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSWebSocketConstructor.h:
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::webSocket):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        (WebCore::V8Custom::v8WebSocketConstructorCallback):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * platform/CrossThreadCopier.cpp:
        (WebCore::::copy):
        * platform/CrossThreadCopier.h:
        (WebCore::):
        * websockets/ThreadableWebSocketChannel.cpp: Added.
        * websockets/ThreadableWebSocketChannel.h: Added.
        * websockets/ThreadableWebSocketChannelClientWrapper.h: Added.
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):
        (WebCore::WebSocket::didReceiveMessage):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.h:
        (WebCore::WebSocketChannel::refThreadableWebSocketChannel):
        (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
        * websockets/WebSocketChannelClient.h:
        * websockets/WebSocketHandshake.h:
        * websockets/WorkerThreadableWebSocketChannel.cpp: Added.
        * websockets/WorkerThreadableWebSocketChannel.h: Added.
        * workers/WorkerContext.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>
eric@webkit.org [Thu, 7 Jan 2010 02:20:02 +0000 (02:20 +0000)]
2010-01-06  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Darin Adler.

        Modified EventSource event-stream parser to support a single CR as line ending.
        Updated test accordingly.
        https://bugs.webkit.org/show_bug.cgi?id=33207

        * http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
        * http/tests/eventsource/eventsource-parse-event-stream.html:
        * http/tests/eventsource/resources/event-stream.php:
2010-01-06  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Darin Adler.

        Modified EventSource event-stream parser to support a single CR as line ending.
        https://bugs.webkit.org/show_bug.cgi?id=33207

        * page/EventSource.cpp:
        (WebCore::EventSource::EventSource):
        (WebCore::EventSource::parseEventStream):
        * page/EventSource.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Thu, 7 Jan 2010 02:05:01 +0000 (02:05 +0000)]
2010-01-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30883
        [Gtk] Implement AtkText for HTML elements which contain text

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (getInterfaceMaskFromObject):
        (getPangoLayoutForAtk):
        (webkit_accessible_text_get_text):
        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (AccessibilityObject::accessibilityPlatformIncludesObject):
2010-01-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30883
        [Gtk] Implement AtkText for HTML elements which contain text

        * tests/testatk.c
        (test_webkit_atk_get_text_at_offset):
        (test_webkit_atk_get_text_at_offset_forms):
        (test_webkit_atk_get_text_at_offset_newlines):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines...
mitz@apple.com [Thu, 7 Jan 2010 01:41:32 +0000 (01:41 +0000)]
<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines run too long
https://bugs.webkit.org/show_bug.cgi?id=32794

Reviewed by Sam Weinig.

WebCore:

Test: platform/mac/fast/text/line-breaking-with-kerning.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak): When kerning is enabled, include
the trailing space when measuring a word, then subtract its width. This
accounts for kerning between the last glyph of the word and the following space.

LayoutTests:

* platform/mac/fast/text/line-breaking-with-kerning-expected.checksum: Added.
* platform/mac/fast/text/line-breaking-with-kerning-expected.png: Added.
* platform/mac/fast/text/line-breaking-with-kerning-expected.txt: Added.
* platform/mac/fast/text/line-breaking-with-kerning.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
ojan@chromium.org [Thu, 7 Jan 2010 01:33:46 +0000 (01:33 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review.

        REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
        https://bugs.webkit.org/show_bug.cgi?id=33256

        I am unable to reproduce this failure locally, so this fix is only speculative.
        Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

        * platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Simon Fraser.
kdecker@apple.com [Thu, 7 Jan 2010 01:29:55 +0000 (01:29 +0000)]
    Reviewed by Simon Fraser.

        Third step of:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView getVariable:value:]): Add case for WKNVSupportsCompositingCoreAnimationPluginsBool.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 01:14:52 +0000 (01:14 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, just adding Mike Belshe's new bugzilla email at his request.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Simon Fraser
kdecker@apple.com [Thu, 7 Jan 2010 01:01:10 +0000 (01:01 +0000)]
    Reviewed by Simon Fraser

        Second step of:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        * Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView pluginLayer]): Added.
        * Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView pluginLayer]): Added.
        Reviewed by Simon Fraser.

        Second step of:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        * Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView pluginLayer]): Added.
        * Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView pluginLayer]): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix screwed up ChangeLog about screwing up... Sigh.
abarth@webkit.org [Thu, 7 Jan 2010 00:50:06 +0000 (00:50 +0000)]
Fix screwed up ChangeLog about screwing up...  Sigh.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 00:48:13 +0000 (00:48 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review.

        REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
        https://bugs.webkit.org/show_bug.cgi?id=33256

        I am unable to reproduce this failure locally, so this fix is only speculative.
        Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

        * platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 00:47:00 +0000 (00:47 +0000)]
2010-01-06  Adam Barth  <abarth@webkit.org>

        No review, rolling out r52877.
        http://trac.webkit.org/changeset/52877
        https://bugs.webkit.org/show_bug.cgi?id=33243

        I screwedd up landing this patch and only partially applied the patch I
        was trying to land.

        * bindings/ScriptControllerBase.cpp:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::executeScriptInWorld):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::haveInterpreter):
        (WebCore::ScriptController::mainWorldWindowShell):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::clearForClose):
        (WebCore::ScriptController::destroyWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::proxy):
        (WebCore::ScriptController::windowShell):
        (WebCore::ScriptController::existingWindowShell):
        (WebCore::ScriptController::evaluateInWorld):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::create):
        (WebCore::V8DOMWindowShell::V8DOMWindowShell):
        (WebCore::V8DOMWindowShell::initContextIfNeeded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:30:40 +0000 (00:30 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Carlson.

        media/video-seeking.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33273

        Removed setTimeouts from this test. It kind of looks
        like they were intentional, but I don't see how they add
        anything to this test (other than race conditions).

        * media/video-seeking-expected.txt:
        * media/video-seeking.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 7 Jan 2010 00:26:46 +0000 (00:26 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Rolling back in a change I should not have rolled out.

        The original commit http://trac.webkit.org/changeset/52862
        was rolled out again in http://trac.webkit.org/changeset/52871
        but I now believe that rollout to be in error.
        My sincerest apologies for the churn.

        Fix the bug in previous commit: we shouldn't finish
        decoding if "sizeOnly" is true.
        https://bugs.webkit.org/show_bug.cgi?id=33258

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:24:56 +0000 (00:24 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
        https://bugs.webkit.org/show_bug.cgi?id=33270

        These both rely on setTimeouts where they should be using events.

        * fast/css/transition-color-unspecified.html:
        * fast/dom/HTMLObjectElement/object-as-frame.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 7 Jan 2010 00:21:28 +0000 (00:21 +0000)]
2010-01-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        platform/chromium/fast/dom/interval.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33274

        We're seeing the debug bots take >100000 microseconds to stop
        and Interval.

        * platform/chromium/fast/dom/interval.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 7 Jan 2010 00:16:00 +0000 (00:16 +0000)]
2010-01-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [v8] Let ScriptController have more than one windowShell
        https://bugs.webkit.org/show_bug.cgi?id=33243

        This patch lets ScriptController have more than one windowShell.  We're
        currently only using one of them (for the main world), but this patch
        lets us use other ones for isolated worlds soon.

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeScriptInWorld):
        * bindings/js/ScriptController.cpp:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::createWorld):
        (WebCore::ScriptController::initScript):
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::evaluateInIsolatedWorld):
        (WebCore::ScriptController::evaluateInWorld):
        (WebCore::ScriptController::mainWorldWindowShell):
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::clearForClose):
        (WebCore::ScriptController::destroyWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::windowShell):
        (WebCore::ScriptController::existingWindowShell):
        (WebCore::ScriptController::globalObject):
        (WebCore::ScriptController::proxy):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::create):
        (WebCore::V8DOMWindowShell::V8DOMWindowShell):
        (WebCore::V8DOMWindowShell::initContextIfNeeded):
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 23:56:15 +0000 (23:56 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Rolling out r52869 and r52853 due to bot
        and local run-webkit-test failures

        REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
        https://bugs.webkit.org/show_bug.cgi?id=33256

        The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Mac build.
mrowe@apple.com [Wed, 6 Jan 2010 23:20:53 +0000 (23:20 +0000)]
Fix the Mac build.

* WebCore.base.exp: Export symbols WebKit would like to use.
* plugins/PluginWidget.h:
(WebCore::PluginWidget::PluginWidget): Redeclare a constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix non-Snow Leopard Mac build.
weinig@apple.com [Wed, 6 Jan 2010 23:09:28 +0000 (23:09 +0000)]
Attempt to fix non-Snow Leopard Mac build.

* WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:25:27 +0000 (22:25 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Unreviewed "build" fix.  Just adding missing include.

        bugzilla-tool rollout --complete-rollout should make a nicer bug comment
        https://bugs.webkit.org/show_bug.cgi?id=29212

        * Scripts/webkitpy/steps/completerollout.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric Carlson.
kdecker@apple.com [Wed, 6 Jan 2010 22:23:39 +0000 (22:23 +0000)]
    Reviewed by Eric Carlson.

        First step toward:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        Small refactoring moving the PluginWidget class from WebKit to WebCore.
        * WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
        * platform/Widget.h: Added isPluginWidget().
        (WebCore::Widget::isPluginWidget):
        * plugins/PluginWidget.h: Added.
        (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
        * plugins/mac/PluginWidgetMac.mm: Added.
        (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget

        Reviewed by Eric Carlson.

        First step toward:
        <rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

        Small refactoring moving the PluginWidget class from WebKit to WebCore.

        * WebCoreSupport/WebFrameLoaderClient.mm: Use the WebCore version of PluginWidget.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:20:39 +0000 (22:20 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52862.
        http://trac.webkit.org/changeset/52862
        https://bugs.webkit.org/show_bug.cgi?id=33258

        Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
        Leopard Release builder.

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 22:14:10 +0000 (22:14 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool rollout --complete-rollout should make a nicer bug comment
        https://bugs.webkit.org/show_bug.cgi?id=29212

        * Scripts/webkitpy/bugzilla.py:
         - Make reopen_bug robust against the bug already being open.
        * Scripts/webkitpy/commands/download.py:
         - Remove dead code from Rollout.
        * Scripts/webkitpy/steps/completerollout.py:
         - Improve the rollout comment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>
eric@webkit.org [Wed, 6 Jan 2010 22:12:48 +0000 (22:12 +0000)]
2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Set isHttpdOpen to 0 if pidfile does not exist for some reason.
        Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 6 Jan 2010 22:04:06 +0000 (22:04 +0000)]
2010-01-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.

        * Configurations/Base.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-05 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 6 Jan 2010 21:37:09 +0000 (21:37 +0000)]
2010-01-05  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Generate header declarations for V8 binding security checks
        and delete V8CustomBinding.cpp

        * Android.v8bindings.mk: Removed V8CustomBinding.cpp.
        * WebCore.gypi: Removed V8CustomBinding.cpp.
        * bindings/scripts/CodeGeneratorV8.pm: Generate security check declarations.
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::getTargetFrame): Moved from V8CustomBinding.cpp.
        (WebCore::reportUnsafeJavaScriptAccess):
        (WebCore::V8DOMWindowShell::createNewContext):
        (WebCore::V8DOMWindowShell::setLocation): Moved from V8CustomBinding.cpp.
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::downcastSVGPathSeg): Moved from V8CustomBinding.cpp.
        (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object):
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/custom/V8CustomBinding.cpp: Removed.
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::locationAccessorSetter):
        (WebCore::V8DOMWindow::namedSecurityCheck):
        (WebCore::V8DOMWindow::indexedSecurityCheck):
        * bindings/v8/custom/V8DocumentLocationCustom.cpp:
        (WebCore::V8Document::locationAccessorSetter):
        * bindings/v8/custom/V8HistoryCustom.cpp:
        (WebCore::V8History::indexedSecurityCheck):
        (WebCore::V8History::namedSecurityCheck):
        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::V8Location::indexedSecurityCheck):
        (WebCore::V8Location::namedSecurityCheck):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 6 Jan 2010 21:26:59 +0000 (21:26 +0000)]
2010-01-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Rewrite marker code, as it had many issues:
        - Correct refX/refY handling (covered by new marker-referencePoint.svg test)
        - Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
        - Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
        - Fix SVGResource assuming that there is only one resource per resource type per element. Markers
          can have three different resources of the same type (three markers, start/mid/end markers)

        Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

        Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
        Test: svg/custom/marker-referencePoint.svg
              svg/custom/marker-opacity.svg
              svg/custom/marker-strokeWidth-changes.svg

        * Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML.
        (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase.
        (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time.
        (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes.
        (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now.
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
        * rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency.
        (WebCore::RenderPath::path): Inline this accessor.
        * rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
        * rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated.
        (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code).
        (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
        * rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
        * rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights.
        (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo.
        (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker.
        (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout.
        (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values.
        (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method.
        (WebCore::SVGMarkerData::updateOutslope): Ditto.
        (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation.
        (WebCore::SVGMarkerData::updateInslope): Helper method.
        * rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time.
        (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo):
        (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles)
        (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers().
        (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers.
        (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
        * rendering/SVGMarkerLayoutInfo.h: Added.
        (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix.
        (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers.
        (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto.
        (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
        * svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer()
        (WebCore::SVGMarkerElement::~SVGMarkerElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
        (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::~SVGSVGElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
        * svg/SVGUseElement.cpp: Rework buildPendingResource() to remove SVGSVGElement/SVGMarkerElement detach() hacks (called manually from destructors), see below.
        (WebCore::SVGUseElement::buildPendingResource): Always detach() the shadow tree root element, before destructing it - this caused the regression with this patch before.
        * svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources
                                        and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
                                        ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
                                        per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.
        (WebCore::resourceSet): Add global static HashSet<SVGResource*>.
        (WebCore::SVGResource::SVGResource): Add us to the resourceSet.
        (WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
        (WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
        (WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::SVGResourceMarker):
        (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker.
        (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer.
        (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
        * svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values.
        (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker().
        (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef().
        (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 6 Jan 2010 21:10:35 +0000 (21:10 +0000)]
2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        This implements the SVG Filter effect feImage with support of fragment urls.
        It also includes a bug fix for feComposite. feComposite didn't cover values
        bigger than 255 correctly on composite oeprator arithmetic.

        Tests: There are already many feImage tests in trunk. They just needed updated
               pixel test results.
               The feComposite bug is covered by svg/W3C-SVG-1.1/filters-composite-02-b.svg
               and depends on feImage.

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::arithmetic):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGImage.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::requestImageResource):
        (WebCore::SVGFEImageElement::parseMappedAttribute):
        (WebCore::SVGFEImageElement::notifyFinished):
        (WebCore::SVGFEImageElement::build):
        * svg/SVGFEImageElement.h:
        * svg/SVGFEImageElement.idl:
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::transformRect):
        * svg/SVGPreserveAspectRatio.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::FEImage):
        (WebCore::FEImage::create):
        (WebCore::FEImage::apply):
        * svg/graphics/filters/SVGFEImage.h:

2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        The implementation of feImage requires pixel test result updates of the already
        available tests.

        There is also an update for svg/filters/feComposite.svg, since the patch also
        fixed a bug in feComposite.

        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.checksum:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.png:
        * platform/mac/svg/filters/feComposite-expected.checksum:
        * platform/mac/svg/filters/feComposite-expected.png:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
        * platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:

2010-01-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feImage support
        https://bugs.webkit.org/show_bug.cgi?id=31905

        Update SVG status page. We support feDisplacementMap and feImage now.

        * projects/svg/status.xml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded file James Robinson provided to go with his fix for
darin@apple.com [Wed, 6 Jan 2010 20:26:04 +0000 (20:26 +0000)]
Added file James Robinson provided to go with his fix for
https://bugs.webkit.org/show_bug.cgi?id=32295

* platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSome script tests have wrappers that don't match their templates
darin@apple.com [Wed, 6 Jan 2010 20:24:29 +0000 (20:24 +0000)]
Some script tests have wrappers that don't match their templates
https://bugs.webkit.org/show_bug.cgi?id=33239

Reviewed by Eric Seidel.

* fast/dom/StyleSheet/get-stylesheet-byname.html: Updated to use
a standard test wrapper instead of a custom one.
* fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js:
Changed test to not depend on a non-standard wrapper.
* fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Updated
results since I changed the test around.

* platform/mac/editing/selection/script-tests/TEMPLATE.html: Fix
incorrect path in template that broke the test when we called
make-script-test-wrappers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Wed, 6 Jan 2010 20:15:35 +0000 (20:15 +0000)]
2010-01-06  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Fix the bug in previous commit: we shouldn't finish
        decoding if "sizeOnly" is true.
        https://bugs.webkit.org/show_bug.cgi?id=33258

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageReader::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShould be last part of Windows Build fix.
bweinstein@apple.com [Wed, 6 Jan 2010 19:59:57 +0000 (19:59 +0000)]
Should be last part of Windows Build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 6 Jan 2010 19:58:15 +0000 (19:58 +0000)]
2010-01-06  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52855.
        http://trac.webkit.org/changeset/52855
        https://bugs.webkit.org/show_bug.cgi?id=33222

        Caused 6 layout tests to fail on Mac

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQT build fix.
barraclough@apple.com [Wed, 6 Jan 2010 19:51:26 +0000 (19:51 +0000)]
QT build fix.

* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecific):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix part I.
barraclough@apple.com [Wed, 6 Jan 2010 19:45:14 +0000 (19:45 +0000)]
Windows build fix part I.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix
mitz@apple.com [Wed, 6 Jan 2010 19:38:52 +0000 (19:38 +0000)]
Build fix

* runtime/Identifier.cpp:
(JSC::createIdentifierTableSpecificCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=33236
barraclough@apple.com [Wed, 6 Jan 2010 19:33:29 +0000 (19:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString

Reviewed by Sam Weinig.

JavaScriptCore:

Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table.  By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

    - change the API shims to track the identifierTable of the current JSGlobalData.

* API/JSContextRef.cpp:
(JSContextGroupCreate):

    - update creation of JSGlobalData for API usage to use new create method.
    - fix shim instanciation bug in JSGlobalContextCreateInGroup.

* JavaScriptCore.exp:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):

    - add asserts to check the identifierTable is being tracked correctly.

* runtime/Identifier.cpp:
(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):

    - Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
    - Define methods to access the thread specific identifier tables.

* runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

    - Declare methods to access the thread specific identifier tables.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):

    - creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.

* runtime/JSGlobalData.h:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::destroy):

    - destroy() method should be using isIdentifier().

* runtime/UStringImpl.h:
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):

    - replace m_identifierTable with a single m_isIdentifier bit.

* wtf/StringHashFunctions.h:
(WTF::stringHash):

    - change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.

JavaScriptGlue:

Add API shims similar to those used in the JSC API to track the current identifierTable.

* JSBase.cpp:
(JSBase::Release):
* JSUtils.cpp:
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(unprotectGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):
* JSUtils.h:
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
* JavaScriptGlue.cpp:
(JSRunCreate):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):
* JavaScriptGlue.xcodeproj/project.pbxproj:
* UserObjectImp.cpp:
(UserObjectImp::callAsFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-06 Yong Li <yoli@rim.com>
yong.li@torchmobile.com [Wed, 6 Jan 2010 18:25:46 +0000 (18:25 +0000)]
2010-01-06  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Let ReourceLoader deliver segmented data
        when loading resource from a SharedBuffer object.
        https://bugs.webkit.org/show_bug.cgi?id=33222

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::didReceiveData):
        * loader/ResourceLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed trivial Qt build fix.
hausmann@webkit.org [Wed, 6 Jan 2010 11:14:48 +0000 (11:14 +0000)]
Unreviewed trivial Qt build fix.

Prefix the phonon includes with phonon/ to avoid conflicts with the S60
audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ).

* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52854 268f45cc-cd09-0410-ab3c-d52691b4dbfc