WebKit.git
10 years ago2010-07-07 Jesus Sanchez-Palencia <jesus@webkit.org>
jesus@webkit.org [Thu, 8 Jul 2010 05:57:42 +0000 (05:57 +0000)]
2010-07-07  Jesus Sanchez-Palencia  <jesus@webkit.org>

        Reviewed by Antti Koivisto.

        [Qt] Missing include to build QtWebKit with WebKit2 in MediaPlayerPrivatePhonon.cpp
        https://bugs.webkit.org/show_bug.cgi?id=41767

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add Logging.h include

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 8 Jul 2010 05:45:37 +0000 (05:45 +0000)]
2010-07-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Terminate QtWebProcess on exit
        https://bugs.webkit.org/show_bug.cgi?id=41766

        Call WKPageTerminate to terminate QtWebProcess on exit.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::~QWKPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows release build fix.
sfalken@apple.com [Thu, 8 Jul 2010 04:54:44 +0000 (04:54 +0000)]
Windows release build fix.
Don't generate public symbols since this is exceeding address space on our builders.

* win/WebKit2.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 8 Jul 2010 04:37:04 +0000 (04:37 +0000)]
2010-07-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Dumitru Daniliuc.

        VCSUtils.pm complains about uninitialized value $newLine
        https://bugs.webkit.org/show_bug.cgi?id=41333

        Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
        an array when fixing a change log entry that overlaps with an earlier
        entry. In particular, when a patch contains a change log entry inserted
        earlier in the change log file, but after an entry with the same author
        and date.

        * Scripts/VCSUtils.pm:
            - Added for-loop constraint to fixChangeLogPatch() so that it does not
              read off the end of the @overlappingLines array.
        * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Thu, 8 Jul 2010 04:20:58 +0000 (04:20 +0000)]
2010-07-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Move v8-related script offset conversion to DebuggerScript.js
        https://bugs.webkit.org/show_bug.cgi?id=41755

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
2010-07-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: convert script offset to webkit format
        https://bugs.webkit.org/show_bug.cgi?id=41755

        * src/js/DebuggerScript.js:
        ():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Nicolas Weber <thakis@chromium.org>
commit-queue@webkit.org [Thu, 8 Jul 2010 04:07:34 +0000 (04:07 +0000)]
2010-07-07  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Dimitri Glazkov.
        https://bugs.webkit.org/show_bug.cgi?id=41580

        Fix rendering of radial gradients in skia if both points of the
        gradient are the same and r0 > 0.

        * fast/gradients/radial-centered.html: Added.
2010-07-07  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Dimitri Glazkov.
        https://bugs.webkit.org/show_bug.cgi?id=41580

        Fix rendering of radial gradients in skia if both points of the
        gradient are the same and r0 > 0.

        Test: fast/gradients/radial-centered.html

        * platform/graphics/skia/GradientSkia.cpp:
        (WebCore::Gradient::platformGradient):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoComment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
andersca@apple.com [Thu, 8 Jul 2010 03:55:48 +0000 (03:55 +0000)]
Comment out a part of TestNetscapePlugin that caused tests┬áto fail on Tiger and Leopard.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[DRT/Chromium] Support for indeterminate checkbox
tkent@chromium.org [Thu, 8 Jul 2010 03:41:24 +0000 (03:41 +0000)]
[DRT/Chromium] Support for indeterminate checkbox
https://bugs.webkit.org/show_bug.cgi?id=41747

Reviewed by Adam Barth.

Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499

* DumpRenderTree/chromium/WebThemeControlDRT.cpp:
(WebThemeControlDRT::draw):
* DumpRenderTree/chromium/WebThemeControlDRT.h:
(WebThemeControlDRT::):
* DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
(WebThemeEngineDRT::paintButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up MiniBrowser Xcode project.
weinig@apple.com [Thu, 8 Jul 2010 03:37:45 +0000 (03:37 +0000)]
Clean up MiniBrowser Xcode project.

Reviewed by Mark Rowe.

- Use xcconfig files.
- Rename plists to canonical Info.plist
- Remove localizations.

* MiniBrowser/Configurations: Added.
* MiniBrowser/Configurations/Base.xcconfig: Added.
* MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
* MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
* MiniBrowser/Configurations/WebBundle.xcconfig: Added.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/WebBundle-Info.plist: Removed.
* MiniBrowser/mac/BrowserStatisticsWindowController.m:
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
* MiniBrowser/mac/BrowserWindow.xib: Added.
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
* MiniBrowser/mac/English.lproj: Removed.
* MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
* MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
* MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
* MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
* MiniBrowser/mac/MainMenu.xib: Added.
* MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
* MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 8 Jul 2010 03:34:31 +0000 (03:34 +0000)]
2010-07-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Fix two regressions
        https://bugs.webkit.org/show_bug.cgi?id=41745

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):
         Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
         and svg/custom/use-on-g-containing-foreignObject-and-image.svg
         though test_shell does it twice. Probably DRT needs it because
         DRT delays painting as possible.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 8 Jul 2010 03:32:51 +0000 (03:32 +0000)]
2010-07-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        [DRT/Chromium] DumpRenderTree should depend on ImageDiff
        https://bugs.webkit.org/show_bug.cgi?id=41749

        We usually use DumpRenderTree with ImageDiff.  So ImageDiff should
        be built with DumpRenderTree. Without this change, ImageDiff is not
        built in a case of Chromium tree build.
        test_shell in Chromium tree also depends on image_diff.

        * WebKit.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix build.
andersca@apple.com [Thu, 8 Jul 2010 03:13:24 +0000 (03:13 +0000)]
Try to fix build.

* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_destroy_stream):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the GTK+ and Qt test failures by merging the newly added code from TestNet...
andersca@apple.com [Thu, 8 Jul 2010 03:07:39 +0000 (03:07 +0000)]
Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp

* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_stream):
(webkit_test_plugin_destroy_stream):
(webkit_test_plugin_write_ready):
(webkit_test_plugin_write):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't hard code the Mac OS X 10.6 SDK for MiniBrowser.
weinig@apple.com [Thu, 8 Jul 2010 03:04:12 +0000 (03:04 +0000)]
Don't hard code the Mac OS X 10.6 SDK for MiniBrowser.

Reviewed by Mark Rowe.

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse the correct XP_MACOSX define instead of XP_MAC. This was causing test failures...
andersca@apple.com [Thu, 8 Jul 2010 02:58:42 +0000 (02:58 +0000)]
Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
(NPP_HandleEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Thu, 8 Jul 2010 02:49:40 +0000 (02:49 +0000)]
2010-07-07  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add a few more methods to WebPlugin so that Pepper v2 plugins can support copy/zoom/find
        https://bugs.webkit.org/show_bug.cgi?id=41649

        * public/WebPlugin.h:
        (WebKit::WebPlugin::hasSelection):
        (WebKit::WebPlugin::selectionAsText):
        (WebKit::WebPlugin::selectionAsMarkup):
        (WebKit::WebPlugin::setZoomFactor):
        (WebKit::WebPlugin::supportsFind):
        (WebKit::WebPlugin::startFind):
        (WebKit::WebPlugin::selectFindResult):
        (WebKit::WebPlugin::stopFind):
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::pluginContainerFromFrame):
        (WebKit::ChromePluginPrintContext::end):
        (WebKit::ChromePluginPrintContext::computePageRects):
        (WebKit::ChromePluginPrintContext::spoolPage):
        (WebKit::WebFrameImpl::executeCommand):
        * src/WebFrameImpl.h:
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::copy):
        (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
        * src/WebPluginContainerImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setZoomLevel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed to have a way to specify different results for Windows XP and 7
bweinstein@apple.com [Thu, 8 Jul 2010 02:26:50 +0000 (02:26 +0000)]
Need to have a way to specify different results for Windows XP and 7
https://bugs.webkit.org/show_bug.cgi?id=41776

Reviewed by Adam Roben.

Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
subdirectories, so we can have different results for tests on Windows XP, Windows
Vista, and Windows 7.

Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
Windows 7 will try the order: win-7, win, mac-snowleopard, mac.

This matches the behavior of the mac.

* Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
    or Vista, try looking in other win-* subdirectories before win.
* Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
    we are running.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-06-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 8 Jul 2010 02:13:47 +0000 (02:13 +0000)]
2010-06-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        https://bugs.webkit.org/show_bug.cgi?id=26526
        Add support for input events (oninput) to contentEditable elements

        * fast/events/event-input-contentEditable-expected.txt: Added.
        * fast/events/event-input-contentEditable.html: Added.
        * fast/events/script-tests/event-input-contentEditable.js: Added.
2010-06-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        https://bugs.webkit.org/show_bug.cgi?id=26526
        Add support for input events (oninput) to contentEditable elements

        Made a default event handler on the Node to dispatch an input event when
        webkitEditableContentChanged arrived.

        Test: fast/events/event-input-contentEditable.html

        * dom/Node.cpp:
        (WebCore::Node::defaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
tkent@chromium.org [Thu, 8 Jul 2010 01:52:10 +0000 (01:52 +0000)]
[DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
https://bugs.webkit.org/show_bug.cgi?id=41753

Reviewed by Dimitri Glazkov.

The original code of the following functions in
test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
ASSERT_NOT_REACHED(). The program shouldn't stop at these
functions.

* DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::activateWindow):
(DRTDevToolsClient::closeWindow):
(DRTDevToolsClient::dockWindow):
(DRTDevToolsClient::undockWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTest that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
andersca@apple.com [Thu, 8 Jul 2010 01:47:59 +0000 (01:47 +0000)]
Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
https://bugs.webkit.org/show_bug.cgi?id=41821

Reviewed by Sam Weinig.

WebKitTools:

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginGetProperty):
(pluginSetProperty):
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
Add and initialize the returnNegativeOneFromWrite property.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_NewStream):
Set the stream type to NP_NORMAL so we'll get write callbacks.

(NPP_DestroyStream):
Treat the onstreamdestroy attribute as a function name and not a string.

(NPP_WriteReady):
Have this return a nonzero value.

(NPP_Write):
If returnNegativeOneFromWrite is true return -1.

LayoutTests:

* plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html:
Update for changes to onstreamdestroy.

* plugins/return-negative-one-from-write-expected.txt: Added.
* plugins/return-negative-one-from-write.html: Added.
Add new test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r62676.
andersca@apple.com [Thu, 8 Jul 2010 01:46:29 +0000 (01:46 +0000)]
Unreviewed build fix after r62676.

Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-07-07
[EFL] Fix build after Page constructor has changed. By now, the
introduced BackForwardControllerClient is not used.
https://bugs.webkit.org/show_bug.cgi?id=41825

* efl/ewk/ewk_view.cpp:
(_ewk_view_priv_new): Add missing parameter to WebCore::Page
constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
kevino@webkit.org [Thu, 8 Jul 2010 01:22:20 +0000 (01:22 +0000)]
[wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
latest version is selected by default, and allows the version to be specified.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 8 Jul 2010 01:19:36 +0000 (01:19 +0000)]
2010-07-07  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Fix adoptRef assertion failures caused by stack-allocated ResourceHandle objects
        https://bugs.webkit.org/show_bug.cgi?id=41823

        * platform/network/android/ResourceHandleAndroid.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously): Use adoptRef and new instead
        of allocating an object on the stack.
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously): Ditto.
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously): Ditto.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously): Use create instead of
        allocating an object on the stack.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not...
cfleizach@apple.com [Thu, 8 Jul 2010 01:04:01 +0000 (01:04 +0000)]
WebCore: AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
https://bugs.webkit.org/show_bug.cgi?id=41810

WebKitTools: AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
https://bugs.webkit.org/show_bug.cgi?id=41810

Reviewed by Darin Adler.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::selectedTextRange):

LayoutTests: AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
https://bugs.webkit.org/show_bug.cgi?id=41810

Reviewed by Darin Adler.

* platform/mac/accessibility/selected-text-range-for-empty-textarea-expected.txt: Added.
* platform/mac/accessibility/selected-text-range-for-empty-textarea.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed build in configurations like PowerPC.
darin@apple.com [Thu, 8 Jul 2010 00:17:15 +0000 (00:17 +0000)]
Fixed build in configurations like PowerPC.

* runtime/RegExpConstructor.cpp: Added include of PassOwnPtr.h.
* runtime/RegExpObject.cpp: Ditto.
* wtf/SizeLimits.cpp: Changed compile time assertion to work
even on platforms where two bool members do not end up taking
the same size as one int member!

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 41806 - AX: Data table heuristics: assume data table if at least one row or colum...
cfleizach@apple.com [Thu, 8 Jul 2010 00:16:39 +0000 (00:16 +0000)]
Bug 41806 - AX: Data table heuristics: assume data table if at least one row or column of TH cells exist
https://bugs.webkit.org/show_bug.cgi?id=41806

No review. Fixing skipped layout test name.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Martin Robinson <mrobinson@igalia.com>
ojan@chromium.org [Thu, 8 Jul 2010 00:12:19 +0000 (00:12 +0000)]
2010-07-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Build fix after r62700.

        * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
        source file locations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 8 Jul 2010 00:09:39 +0000 (00:09 +0000)]
2010-07-07  Joseph Pecoraro  <joepeck@webkit.org>

        Rubber-stamped by Pavel Feldman.

        Web Inspector: All RefPtr arguments and return values should be changed to PassRefPtr according to common practice.
        https://bugs.webkit.org/show_bug.cgi?id=41759

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 8 Jul 2010 00:03:44 +0000 (00:03 +0000)]
2010-07-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Build fix after r62700.

        * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
        source file locations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 7 Jul 2010 23:48:47 +0000 (23:48 +0000)]
2010-07-07  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        add --exit-after-n-crashes to run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=41811

        Change the bots at build.webkit.org to use --exit-after-n-crashes
        instead of --exit-after-n-failures since we want to be able to have
        more than 20 failures on those bots, but more than 20 crashes means
        something should be rolled out.

        * Scripts/old-run-webkit-tests:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 7 Jul 2010 23:27:57 +0000 (23:27 +0000)]
2010-07-07  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Lazy mode of parser allows invalid syntax in object literals.
        https://bugs.webkit.org/show_bug.cgi?id=41809

        Make the parser itself validate getter and setter syntax rather
        than offloading it to the AST builder.

        * parser/ASTBuilder.h:
        (JSC::ASTBuilder::createGetterOrSetterProperty):
        * parser/JSParser.cpp:
        (JSC::JSParser::parseProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Chromium test expectation update.
pkasting@chromium.org [Wed, 7 Jul 2010 22:46:26 +0000 (22:46 +0000)]
Not reviewed.  Chromium test expectation update.

Mark as passing a test which has not failed in a while.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
bweinstein@apple.com [Wed, 7 Jul 2010 22:41:49 +0000 (22:41 +0000)]
Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
TestNetscapePlugin project, because this was removed from the tree.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: Data table heuristics: assume data table if at least one row or column of TH...
cfleizach@apple.com [Wed, 7 Jul 2010 22:36:34 +0000 (22:36 +0000)]
AX: Data table heuristics: assume data table if at least one row or column of TH cells exist
https://bugs.webkit.org/show_bug.cgi?id=41806

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/table-with-row-col-of-headers.html

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):

LayoutTests:

* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/mac/accessibility/table-with-row-col-of-headers-expected.txt: Added.
* platform/mac/accessibility/table-with-row-col-of-headers.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed. Chromium test expectation update.
pkasting@chromium.org [Wed, 7 Jul 2010 22:21:13 +0000 (22:21 +0000)]
Not reviewed.  Chromium test expectation update.

Remove erroneously-added platform-specific expectations and instead mark
the tests as failing.

* platform/chromium-mac/fast/js/function-apply-expected.txt: Removed.
* platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Removed.
* platform/chromium-win/fast/js/function-apply-expected.txt: Removed.
* platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Revert r62689.
dumi@chromium.org [Wed, 7 Jul 2010 22:20:40 +0000 (22:20 +0000)]
JavaScriptCore: Revert r62689.
https://bugs.webkit.org/show_bug.cgi?id=41804

Reviewed by Adam Roben.

* runtime/Collector.cpp:
(JSC::Heap::freeBlocks):

WebKitLibraries: Disable MSVC warning 4288.
https://bugs.webkit.org/show_bug.cgi?id=41804

Reviewed by Adam Roben.

MSVC has a non-standard extension that allows variables declared
in for-loops to remain visible in the same scope even after
exiting the for-loop
(http://msdn.microsoft.com/en-us/library/bk5hc10s.aspx). The /Ze
option (turned on by default) enables all MSVC extensions, and
/Zc:forScope- tells the compiler to issue a C4288 warning when the
same variable is declared in the for-loop and re-declared later in
the same scope.

There seems to be a bug in VS2005 that erroneously enables
/Zc:forScope- even when that option is not specified
(http://connect.microsoft.com/VisualStudio/feedback/details/338010/bogus-compiler-warning-c4288). Looks
like our build got hit by that bug, so we need to disable warning
4288 to fix it.

* win/tools/vsprops/common.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build.
mrowe@apple.com [Wed, 7 Jul 2010 22:18:34 +0000 (22:18 +0000)]
Fix the build.

Xcode decided to change the reference type from "Relative to Build Product" to "Relative to Group"
when I moved the file between folders. That's incredibly confusing so I'll file a bug against Xcode.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the MathML build.
mrowe@apple.com [Wed, 7 Jul 2010 22:13:17 +0000 (22:13 +0000)]
Fix the MathML build.

* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Fix a typo in a variable name.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Wed, 7 Jul 2010 22:00:27 +0000 (22:00 +0000)]
2010-07-07  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add setSuggestedValue to WebInputElement
        https://bugs.webkit.org/show_bug.cgi?id=41785

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::setSuggestedValue):
        (WebKit::WebInputElement::suggestedValue):
2010-07-07  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Dimitri Glazkov.

        Move setSuggestedValue() and suggestedValue() back to public as it's
        now used by WebInputElement.
        https://bugs.webkit.org/show_bug.cgi?id=41785

        No new tests, as the method is only being used by Chromium's WebKit
        API.

        * html/HTMLInputElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRequested by Mark Rowe.
mitz@apple.com [Wed, 7 Jul 2010 21:53:54 +0000 (21:53 +0000)]
Requested by Mark Rowe.

Reverted the part of r62675 in which Snow Leopard-and-earlier results for a mac-only
test were mistakenly removed.

* platform/mac-snowleopard/platform: Copied from platform/mac-snowleopard/platform.
* platform/mac-snowleopard/platform/mac: Copied from platform/mac-snowleopard/platform/mac.
* platform/mac-snowleopard/platform/mac/fast: Copied from platform/mac-snowleopard/platform/mac/fast.
* platform/mac-snowleopard/platform/mac/fast/loader: Copied from platform/mac-snowleopard/platform/mac/fast/loader.
* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up the project file slightly.
mrowe@apple.com [Wed, 7 Jul 2010 21:52:53 +0000 (21:52 +0000)]
Clean up the project file slightly.

Rubber-stamped by Sam Weinig.

Remove obsolete .exp files, add the new .exp.in file, and move ExportFileGenerator.cpp in to the Exports collection.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 James Robinson <jamesr@chromium.org> and Vincent Scheib <schieb@chromium...
jamesr@google.com [Wed, 7 Jul 2010 21:48:57 +0000 (21:48 +0000)]
2010-07-07  James Robinson  <jamesr@chromium.org> and Vincent Scheib <schieb@chromium.org>

        Reviewed by Dimitri Glazkov.

        WebCore::GLES2Context should allow creating onscreen and offscreen contexts
        https://bugs.webkit.org/show_bug.cgi?id=41492

        You should be able to create a GLES2Context for rendering both on screen
        and off screen (to a texture).  Currently WebGL does the latter by side
        stepping the WebCore::GLES2Context API completely.  Longer term it should
        move over to using this.

        * src/GLES2Context.cpp:
        (WebCore::GLES2ContextInternal::initializeOnscreen):
        (WebCore::GLES2ContextInternal::initializeOffscreen):
        (WebCore::GLES2Context::createOnscreen):
        (WebCore::GLES2Context::createOffscreen):
2010-07-07  James Robinson  <jamesr@chromium.org> and Vincent Scheib <schieb@chromium.org>

        Reviewed by Dimitri Glazkov.

        WebCore::GLES2Context should allow creating onscreen and offscreen contexts
        https://bugs.webkit.org/show_bug.cgi?id=41492

        You should be able to create a GLES2Context for rendering both on screen
        and off screen (to a texture).  Chromium's layer renderer (used for compositing)
        does the former.  Currently WebGL does the latter by side stepping the
        WebCore::GLES2Context API completely.  Longer term it should move over to using this.

        * platform/chromium/GLES2Context.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::initGL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Jul 2010 21:42:28 +0000 (21:42 +0000)]
2010-07-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Document::ownerElement() should return an HTMLFrameOwnerElement
        https://bugs.webkit.org/show_bug.cgi?id=41789

        Change return type of RenderLayerCompositor::enclosingIFrameElement() to
        HTMLFrameOwnerElement*. No behavioral changes.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
        (WebCore::RenderLayerCompositor::enclosingIFrameElement):
        * rendering/RenderLayerCompositor.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnify Mac and Windows TestNetscapePlugin main.cpp files
andersca@apple.com [Wed, 7 Jul 2010 21:36:37 +0000 (21:36 +0000)]
Unify Mac and Windows TestNetscapePlugin main.cpp files
https://bugs.webkit.org/show_bug.cgi?id=41798

Reviewed by Simon Fraser.

* DumpRenderTree/DumpRenderTree.sln:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(strcasecmp):
(NP_Initialize):
(NP_GetEntryPoints):
(NP_Shutdown):
(NPP_New):
(NPP_Destroy):
(NPP_HandleEvent):
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Jul 2010 21:21:08 +0000 (21:21 +0000)]
2010-07-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Add reverseFind to Vector and deploy in HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=41778

        This method seems generally useful.  I'm slightly surprised we don't
        have it already.

        * wtf/Vector.h:
        (WTF::::reverseFind):
2010-07-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Add reverseFind to Vector and deploy in HTML5 parser
        https://bugs.webkit.org/show_bug.cgi?id=41778

        This patch moves reverseFind from begin an
        HTMLFormattingElementList-specific concept to begin a general Vector
        concept.  Also, instead of using Entry as the type for operator==, we
        now use elements directly.  The old code compiled because the Entry
        constructor wasn't explicit, which means we were churning refs on every
        comparison!

        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::find):
        (WebCore::HTMLFormattingElementList::bookmarkFor):
        (WebCore::HTMLFormattingElementList::insertAt):
        (WebCore::HTMLFormattingElementList::remove):
        * html/HTMLFormattingElementList.h:
        (WebCore::HTMLFormattingElementList::Entry::operator==):
        (WebCore::HTMLFormattingElementList::Entry::operator!=):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 7 Jul 2010 20:55:37 +0000 (20:55 +0000)]
2010-07-07  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Turn on adoptRef assertion for RefCounted
        https://bugs.webkit.org/show_bug.cgi?id=41547

        * wtf/CrossThreadRefCounted.h: Fixed include style. Includes of other
        WTF headers should use "" includes; consistent in most WTF headers.
        Added a call to relaxAdoptionRequirement.

        * wtf/RefCounted.h: Fixed include style. Removed LOOSE_REF_COUNTED.
        Added relaxAdoptionRequirement.
2010-07-07  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Turn on adoptRef assertion for RefCounted
        https://bugs.webkit.org/show_bug.cgi?id=41547

        The WebCore part of this fixes all the assertions I saw in testing.

        * html/FileReader.cpp:
        (WebCore::FileReader::readAsBinaryString): Added null checks.
        Callers from JavaScript can pass the wrong type, which becomes null.
        (WebCore::FileReader::readAsText): Ditto.
        (WebCore::FileReader::readAsDataURL): Ditto.

        * html/FileStreamClient.h: Removed unneeded include.

        * html/FileStreamProxy.cpp:
        (WebCore::FileStreamProxy::FileStreamProxy): Made inline and moved
        some of the code, including the ref, into the create function.
        (WebCore::FileStreamProxy::create): Moved some of the code from
        the constructor here. It's safe to ref once the object has been
        created and adopted.

        * html/FileStreamProxy.h: Changed create function to no longer be
        inlined. Also removed an unneeded include.

        * page/EventSource.cpp:
        (WebCore::EventSource::EventSource): Made inline, changed arguments
        and moved code that involves the need to ref this object into the
        create function. Also moved failure handling out there since it's
        cleaner to have a function that fails than a constructor. For
        example, the function can return 0.
        (WebCore::EventSource::create): Moved some of the code from the
        constructor here.

        * page/EventSource.h: Removed unneeded includes. Made the
        creation function non-inline. Changed the arguments to the constructor.

        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync): Made inline. Moved
        code that requires ref'ing this object out to the create function.
        (WebCore::StorageAreaSync::create): Moved some of the code from the
        constructor here.

        * storage/StorageAreaSync.h: Removed unneeded includes. Changed
        the type of one of the constructor arguments from String to
        const String&.

        * workers/SharedWorker.cpp:
        (WebCore::SharedWorker::SharedWorker): Made inline. Moved most of
        the setup code out of here into the create function.
        (WebCore::SharedWorker::create): Moved the code here.

        * workers/SharedWorker.h: Removed unneeded includes. Made the
        create function non-inline. Marked the toSharedWorker override private
        to catch people doing an unnecessary virtual function call if they
        already have a SharedWorker*.

        * workers/Worker.cpp:
        (WebCore::Worker::Worker): Made inline. Moved most of the setup code
        out of here into the create function.
        (WebCore::Worker::create): Moved the code here.

        * workers/Worker.h: Made the create function non-inline. Changed
        the arguments to the constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix. pageProperty needs to return a value.
kevino@webkit.org [Wed, 7 Jul 2010 20:32:43 +0000 (20:32 +0000)]
[wx] Build fix. pageProperty needs to return a value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: when a node's role changes, the AX tree might need to be updated
cfleizach@apple.com [Wed, 7 Jul 2010 20:26:13 +0000 (20:26 +0000)]
AX: when a node's role changes, the AX tree might need to be updated
https://bugs.webkit.org/show_bug.cgi?id=41784

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/update-children-when-aria-role-changes.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):

LayoutTests:

* platform/mac/accessibility/update-children-when-aria-role-changes-expected.txt: Added.
* platform/mac/accessibility/update-children-when-aria-role-changes.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Jul 2010 20:04:32 +0000 (20:04 +0000)]
2010-07-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Document::ownerElement() should return an HTMLFrameOwnerElement
        https://bugs.webkit.org/show_bug.cgi?id=41789

        Change the return type of Document::ownerElement() to an HTMLFrameOwnerElement, for better
        type checking. No behavioral changes.

        * accessibility/mac/AccessibilityObjectWrapper.mm:
        * dom/Document.cpp:
        (WebCore::Document::ownerElement):
        * dom/Document.h:
        * editing/SelectionController.cpp:
        * rendering/RenderBoxModelObject.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderView.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked...
ddkilzer@apple.com [Wed, 7 Jul 2010 20:02:09 +0000 (20:02 +0000)]
<webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git

Reviewed by Anders Carlsson.

For both svn and git, commit-log-editor is invoked from the root
of the working directory.  Unlike svn, git returns a list of
changed files that are relative to the directory where the
command was invoked.  This caused the ChangeLog file in the root
directory to be read instead of the ChangeLog in the current
directory.

The fix is to use $ENV{PWD} as the base directory when fixing
the path to the ChangeLog files.  With svn, this has no net
effect since $ENV{PWD} is the root of the working directory and
the ChangeLog paths are already relative to that directory.
With git, $ENV{PWD} is the directory that the commit was invoked
from, which fixes the ChangeLog paths so that the correct files
are read when creating the commit log entry.

Note that the call to makeFilePathRelative() was supposed to
address this issue, but it doesn't because (a) it does nothing
with svn working directories by design, and (b) it does nothing
with git working directories because it's invoked when the
current directory is the root of the working directory, thus
giving no relative path.

* Scripts/commit-log-editor: Removed call to
makeFilePathRelative() since since it does nothing.  Moved code
to fix up $changeLog path so that it's fixed before trying to
open the file, and use $ENV{PWD} as the base path.  Also use
canonicalizePath() to clean up paths with "../" in them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: when an element uses role="text" but no aria-label, it should default to textUnde...
cfleizach@apple.com [Wed, 7 Jul 2010 19:47:56 +0000 (19:47 +0000)]
AX: when an element uses role="text" but no aria-label, it should default to textUnderElement()
https://bugs.webkit.org/show_bug.cgi?id=41780

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/static-text-role-uses-text-under-element.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
   Fallback to textUnderElement() if text() does not return any explicitly set text.
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
   Remove erroneous check to ignore text elements that didn't have a explicit text value.

LayoutTests:

* platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt: Added.
* platform/mac/accessibility/static-text-role-uses-text-under-element.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix after change in Page constructor.
kevino@webkit.org [Wed, 7 Jul 2010 19:38:49 +0000 (19:38 +0000)]
[wx] Build fix after change in Page constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Windows build.
andersca@apple.com [Wed, 7 Jul 2010 19:27:16 +0000 (19:27 +0000)]
Try to fix the Windows build.

* runtime/Collector.cpp:
(JSC::Heap::freeBlocks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother attempt at fixing the Qt build.
andersca@apple.com [Wed, 7 Jul 2010 18:51:45 +0000 (18:51 +0000)]
Another attempt at fixing the Qt build.

* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Jul 2010 18:51:26 +0000 (18:51 +0000)]
2010-07-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION: GMail becomes blank after closing other tabs
        https://bugs.webkit.org/show_bug.cgi?id=40421

        RenderLayerCompositor's attach/detachRootPlatformLayer methods use
        setNeedsStyleRecalc() in order to trigger acclerated compositing layers
        to be hooked together across iframe boundaries. However, it was possible
        for these to get called while inside of Document::recalcStyle(), which
        is bad because it can cause the recalc to fail to get processed.

        Fix this by using the existing queuePostAttachCallback() functionality
        to delay the call to setNeedsStyleRecalc() if post-attach callbacks
        are suspended (indicating that we're inside recalcStyle()).

        No new tests because I wasn't able to make a test that shows the problem.

        * dom/ContainerNode.h: Make queuePostAttachCallback() public.
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::postAttachCallbacksAreSuspended): Added; returns
        whether s_attachDepth is non-zero.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::attachRootPlatformLayer): Call scheduleNeedsStyleRecalc()
        instead of setNeedsStyleRecalc().
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer): Ditto.
        (WebCore::needsStyleRecalcCallback): Here we call setNeedsStyleRecalc().
        (WebCore::RenderLayerCompositor::scheduleNeedsStyleRecalc):
        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
        * rendering/RenderLayerCompositor.h: Add scheduleNeedsStyleRecalc().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix Qt build.
andersca@apple.com [Wed, 7 Jul 2010 18:50:25 +0000 (18:50 +0000)]
Try to fix Qt build.

* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename TestNetscapePlugin.subproj and move platform specific files to subdirectories
andersca@apple.com [Wed, 7 Jul 2010 18:42:18 +0000 (18:42 +0000)]
Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
https://bugs.webkit.org/show_bug.cgi?id=41781

Reviewed by Simon Fraser.

WebKit/win:

* WebKit.vcproj/WebKit.sln:

WebKitTools:

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
* DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
* DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
* DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
* DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
* DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Not reviewed, just updating test expectations.
ap@apple.com [Wed, 7 Jul 2010 18:25:05 +0000 (18:25 +0000)]
    Not reviewed, just updating test expectations.

        https://bugs.webkit.org/show_bug.cgi?id=41156
        Cross origin XMLHttpRequest should log the reason why connection failed

        Synchronous resource loader on Tiger doesn't return a response if authentication failed.
        It only returns an error, so WebKit cannot find out that the cross origin 401 response can
        be passed to caller.

        Observable behavior is still the same (failure ot load), but an incorrect error is logged
        to console.

        * platform/mac-tiger/http/tests/xmlhttprequest/cross-origin-authorization-with-embedder-expected.txt: Copied from http/tests/xmlhttprequest/cross-origin-authorization-with-embedder-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Jul 2010 17:48:45 +0000 (17:48 +0000)]
2010-07-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Incorrect compositing order with negative z-index
        https://bugs.webkit.org/show_bug.cgi?id=38959

        When painting the contents of compositing layers whose phase is "GraphicsLayerPaintBackground"
        (indicating that they are used for the background of elements with negative z-index children),
        we need to paint the non-composited negative-z-order descendants at the end of the background phase, so
        they appear behind composited negative-z-order descendants.

        Test: compositing/z-order/negative-z-index.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 7 Jul 2010 17:48:38 +0000 (17:48 +0000)]
2010-07-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Incorrect compositing order with negative z-index
        https://bugs.webkit.org/show_bug.cgi?id=38959

        Prerequisite: adopt new paintList() method that was added when painting compositing layer contents.
        No behavioral changes.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Jul 2010 17:35:03 +0000 (17:35 +0000)]
2010-07-07  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Fix ASSERT in Eric's previous patch.  I think he tested his patch in
        Release and not Debug.

        * html/HTMLFormattingElementList.h:
        (WebCore::HTMLFormattingElementList::Entry::Entry):
        (WebCore::HTMLFormattingElementList::findIndex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Wed, 7 Jul 2010 17:15:17 +0000 (17:15 +0000)]
2010-07-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Grease the TreeBuilder's lightning
        https://bugs.webkit.org/show_bug.cgi?id=41756

        Brings the new TreeBuilder from 7s to 3s on the parser benchmark.
        This makes performance comparable to the old parser.

        We have not begun to fight!  There is so much fat left on these bones.

        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::find):
        (WebCore::HTMLFormattingElementList::bookmarkFor):
        (WebCore::HTMLFormattingElementList::insertAt):
        (WebCore::HTMLFormattingElementList::remove):
        * html/HTMLFormattingElementList.h:
        (WebCore::HTMLFormattingElementList::findIndex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange requestURL to a KURL.
andersca@apple.com [Wed, 7 Jul 2010 17:11:47 +0000 (17:11 +0000)]
Change requestURL to a KURL.
https://bugs.webkit.org/show_bug.cgi?id=41775

Reviewed by Sam Weinig.

* Plugins/WebNetscapePluginStream.h:
(WebNetscapePluginStream::setRequestURL):
* Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::pluginCancelledConnectionError):
(WebNetscapePluginStream::errorForReason):
(WebNetscapePluginStream::startStream):
(WebNetscapePluginStream::didReceiveResponse):
(WebNetscapePluginStream::destroyStream):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Wed, 7 Jul 2010 17:11:28 +0000 (17:11 +0000)]
2010-07-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder is way too slow
        https://bugs.webkit.org/show_bug.cgi?id=41754

        This takes us from 14s to 7s on our parsing benchmark.
        That's still much slower than the old tree builder, but there
        is a huge amount of fat left to trim.

        Vector<T> wasn't able to inline all the Entry functions when
        they were buried in the cpp.  Turns out the active formatting elements
        list is very hot.

        I'm not sure Vector<T> is going to be the right data structure for us
        in the end, but it has done alright for bring-up.

        * html/HTMLFormattingElementList.cpp:
        * html/HTMLFormattingElementList.h:
        (WebCore::HTMLFormattingElementList::Entry::Entry):
        (WebCore::HTMLFormattingElementList::Entry::~Entry):
        (WebCore::HTMLFormattingElementList::Entry::isMarker):
        (WebCore::HTMLFormattingElementList::Entry::element):
        (WebCore::HTMLFormattingElementList::Entry::replaceElement):
        (WebCore::HTMLFormattingElementList::Entry::operator==):
        (WebCore::HTMLFormattingElementList::Entry::operator!=):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 7 Jul 2010 16:53:49 +0000 (16:53 +0000)]
2010-07-07  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        More OwnPtr work
        https://bugs.webkit.org/show_bug.cgi?id=41727

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObjectData::setPrivateProperty): Use adoptPtr.
        * API/JSCallbackObjectFunctions.h:
        (JSC::JSCallbackObject::JSCallbackObject): Ditto.
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::CodeBlock): Ditto.
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::createRareDataIfNecessary): Ditto.
        * parser/Nodes.cpp:
        (JSC::ScopeNode::ScopeNode): Ditto.
        * parser/ParserArena.cpp:
        (JSC::ParserArena::ParserArena): Ditto.
        * runtime/Arguments.h:
        (JSC::Arguments::Arguments): Ditto.
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compile): Ditto.
        (JSC::ProgramExecutable::compile): Ditto.
        (JSC::FunctionExecutable::compileForCall): Ditto.
        (JSC::FunctionExecutable::compileForConstruct): Ditto.
        (JSC::FunctionExecutable::reparseExceptionInfo): Ditto.
        (JSC::EvalExecutable::reparseExceptionInfo): Ditto.
        * runtime/JSArray.cpp:
        (JSC::JSArray::sort): Ditto.
        * runtime/RegExpConstructor.cpp:
        (JSC::RegExpConstructor::RegExpConstructor): Ditto.
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::RegExpObject): Ditto.
        * runtime/SmallStrings.cpp:
        (JSC::SmallStrings::createSingleCharacterString): Ditto.
        (JSC::SmallStrings::singleCharacterStringRep): Ditto.

        * wtf/unicode/icu/CollatorICU.cpp:
        (WTF::Collator::userDefault): Use adoptPtr.
        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::ByteCompiler::ByteCompiler): Ditto.
        (JSC::Yarr::ByteCompiler::compile): Ditto.
        (JSC::Yarr::ByteCompiler::regexBegin): Ditto.
        (JSC::Yarr::byteCompileRegex): Ditto.
        * yarr/RegexInterpreter.h:
        (JSC::Yarr::BytecodePattern::BytecodePattern): Ditto.
2010-07-06  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        More OwnPtr work, including making clear set the pointer to 0 before deletion
        https://bugs.webkit.org/show_bug.cgi?id=41727

        * WebCore.exp.in: Updated.

        * css/CSSSelector.h:
        (WebCore::CSSSelector::RareData::RareData): Use adoptPtr.
        (WebCore::CSSSelector::createRareData): Ditto.
        * dom/SpaceSplitString.h:
        (WebCore::SpaceSplitString::SpaceSplitString): Ditto.
        (WebCore::SpaceSplitString::set): Ditto.
        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::CachedFrame): Ditto.
        (WebCore::CachedFrame::setCachedFramePlatformData): Ditto.

        * history/CachedFrame.h: Use PassOwnPtr.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::CallCacheListenerTask::create): Use adoptPtr.
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::storeCopyOfCache): Ditto.
        * platform/PurgeableBuffer.h:
        (WebCore::PurgeableBuffer::create): Ditto.
        * platform/graphics/GlyphMetricsMap.h:
        (WebCore::::locatePageSlowCase): Ditto.
        * platform/graphics/GraphicsLayer.h:
        (WebCore::AnimationValue::AnimationValue): Ditto.
        (WebCore::TransformAnimationValue::TransformAnimationValue): Ditto.
        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayer::create): Ditto.
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::boundsForGlyph): Ditto.
        * platform/mac/PurgeableBufferMac.cpp:
        (WebCore::PurgeableBuffer::create): Ditto.
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::setHorizontalOverflowPositions): Ditto.
        (WebCore::InlineFlowBox::setVerticalOverflowPositions): Ditto.
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::floats): Ditto.
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::inheritAnimations): Ditto.
        (WebCore::InheritedFlags::inheritTransitions): Ditto.

        * rendering/style/SVGRenderStyleDefs.h: Use PassOwnPtr.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=41772
weinig@apple.com [Wed, 7 Jul 2010 16:44:07 +0000 (16:44 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
Add basic piping for BackForwardControllerClient.

Reviewed by Anders Carlsson.

WebCore:

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* history/BackForwardController.cpp:
(WebCore::BackForwardController::BackForwardController):
* history/BackForwardControllerClient.h:
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):

WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_init):

WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):

WebKit/win:

* WebView.cpp:
(WebView::initWithFrame):

WebKit2:

- Add very basic WebBackForwardControllerClient.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp: Added.
(WebKit::WebBackForwardControllerClient::backForwardControllerDestroyed):
(WebKit::WebBackForwardControllerClient::createBackForwardList):
* WebProcess/WebCoreSupport/WebBackForwardControllerClient.h: Added.
(WebKit::WebBackForwardControllerClient::WebBackForwardControllerClient):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* win/WebKit2.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove current Mac results from platform/mac-snowleopard to platform/mac,
mitz@apple.com [Wed, 7 Jul 2010 16:43:30 +0000 (16:43 +0000)]
Move current Mac results from platform/mac-snowleopard to platform/mac,
move Leopard results from platform/mac to platform/mac-leopard, and remove
stray files and directories from platform/mac-snowleopard.

Reviewed by Sam Weinig.

* platform/mac-leopard/svg/custom/use-font-face-crash-expected.txt: Copied from platform/mac/svg/custom/use-font-face-crash-expected.txt.
* platform/mac-snowleopard/platform: Removed.
* platform/mac-snowleopard/platform/mac: Removed.
* platform/mac-snowleopard/platform/mac/fast: Removed.
* platform/mac-snowleopard/platform/mac/fast/loader: Removed.
* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Removed.
* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Removed.
* platform/mac-snowleopard/svg: Removed.
* platform/mac-snowleopard/svg/custom: Removed.
* platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.txt: Removed.
* platform/mac-snowleopard/tables: Removed.
* platform/mac-snowleopard/tables/mozilla: Removed.
* platform/mac-snowleopard/tables/mozilla/images: Removed.
* platform/mac/svg/custom/use-font-face-crash-expected.txt: Replaced with platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake clear set the pointer to 0 before deletion
darin@apple.com [Wed, 7 Jul 2010 16:07:29 +0000 (16:07 +0000)]
Make clear set the pointer to 0 before deletion
https://bugs.webkit.org/show_bug.cgi?id=41727

Reviewed by Adam Barth.

* wtf/OwnArrayPtr.h: Changed code so we always set the pointer to its new
value before deleting the old one, including in the set function and the
clear function. This required changing safeDelete.
* wtf/OwnPtr.h: Ditto. Also removed some extra null checks.
* wtf/PassOwnPtr.h: Ditto.

* wtf/PassRefPtr.h: Changed code so we always set the pointer to its new
value before deref'ing the old one in the clear function. Also added a
leakRef function for NonNullPassRefPtr.
* wtf/RefPtr.h: Ditto.

* wtf/gobject/GOwnPtr.h: More of the same.
* wtf/gobject/GRefPtr.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename the WebBaseNetscapePluginStream.cpp and .h files to WebNetscapePluginStream...
andersca@apple.com [Wed, 7 Jul 2010 15:58:41 +0000 (15:58 +0000)]
Rename the WebBaseNetscapePluginStream.cpp and .h files to WebNetscapePluginStream.cpp and .h to match the class name.

Reviewed by Sam Weinig.

WebKit:

* WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

* Plugins/WebNetscapePluginStream.h: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.h.
* Plugins/WebNetscapePluginStream.mm: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.mm.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix after r62577.
tonikitoo@webkit.org [Wed, 7 Jul 2010 15:39:32 +0000 (15:39 +0000)]
Unreviewed build fix after r62577.

Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-07-07
[EFL] build fix after r62577
https://bugs.webkit.org/show_bug.cgi?id=41764

No new functionality so no new tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 7 Jul 2010 15:32:23 +0000 (15:32 +0000)]
2010-07-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Scrollbars sometimes go dead and stop scrolling the view
        https://bugs.webkit.org/show_bug.cgi?id=41711

        Rework the setGtkAdjustment function slightly, make it have an
        early return, and be more readable.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::setGtkAdjustments):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Wed, 7 Jul 2010 15:15:21 +0000 (15:15 +0000)]
2010-07-07  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Update more expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Wed, 7 Jul 2010 15:05:42 +0000 (15:05 +0000)]
2010-07-07  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Update expectations.

        * platform/chromium-mac/html5lib/runner-expected.txt:
        * platform/chromium-win/html5lib/runner-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Kristian Monsen <kristianm@google.com>
commit-queue@webkit.org [Wed, 7 Jul 2010 15:01:10 +0000 (15:01 +0000)]
2010-07-07  Kristian Monsen  <kristianm@google.com>

        Reviewed by Steve Block.

        Updating Android to use the UserGestureIndicator class instead of Android specific code.
        The rest of the changes are in parts of the Android port which are yet to be upstreamed.

        No change in behavior, so no new test.

        * platform/network/android/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::doUpdateResourceRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 7 Jul 2010 14:50:15 +0000 (14:50 +0000)]
2010-07-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add snow-leopard specific result for svg/custom/use-font-face-crash.svg

        * platform/mac-snowleopard/svg: Added.
        * platform/mac-snowleopard/svg/custom: Added.
        * platform/mac-snowleopard/svg/custom/use-font-face-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
commit-queue@webkit.org [Wed, 7 Jul 2010 14:49:12 +0000 (14:49 +0000)]
2010-07-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] EFLWebKit doesn't support viewport meta tag.
        Support viewport meta tag on EFL Port.
        https://bugs.webkit.org/show_bug.cgi?id=40278

        * efl/EWebLauncher/main.c: Process 'viewport,changed' signal.
        (viewport_set):
        (on_viewport_changed): Add a callback function for the 'viewport,changed' signal.
        (browserCreate): Register the callback function for the 'viewport,changed' signal.
        * efl/WebCoreSupport/ChromeClientEfl.cpp: Implement method to process viewport tag.
        (WebCore::ChromeClientEfl::didReceiveViewportArguments):
        * efl/WebCoreSupport/ChromeClientEfl.h: Define method to process viewport tag.
        * efl/WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl): Implement a function to set layout
        when website doesn't contain viewport tag.
        (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
        (WebCore::FrameLoaderClientEfl::dispatchDidFirstLayout):
        * efl/WebCoreSupport/FrameLoaderClientEfl.h:
        (WebCore::FrameLoaderClientEfl::setInitLayoutCompleted):
        (WebCore::FrameLoaderClientEfl::getInitLayoutCompleted):
        * efl/ewk/ewk_private.h: Added internal APIs to process viewport tag.
        * efl/ewk/ewk_view.cpp: Added APIs to process and to handle viewport tag.
        (_ewk_view_priv_new):
        (ewk_view_fixed_layout_size_set):
        (ewk_view_zoom_set):
        (ewk_view_zoom_weak_set):
        (ewk_view_zoom_animated_set):
        (ewk_view_viewport_set): Reports that viewport has changed.
        (ewk_view_viewport_get): Reports that viewport has changed.
        (ewk_view_zoom_range_set): Sets the zoom range.
        (ewk_view_zoom_range_min_get): Gets minimum value of zoom range.
        (ewk_view_zoom_range_max_get): Gets maximum value of zoom range.
        (ewk_view_user_scalable_set): Sets if zoom is enabled.
        (ewk_view_user_scalable_get): Gets if zoom is enabled.
        * efl/ewk/ewk_view.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix for failing Chromium test
steveblock@google.com [Wed, 7 Jul 2010 14:41:27 +0000 (14:41 +0000)]
Unreviewed fix for failing Chromium test

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Andy Estes <aestes@apple.com>
aestes@apple.com [Wed, 7 Jul 2010 14:37:21 +0000 (14:37 +0000)]
2010-07-07  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        Test that loading of images in <object> tags can be cancelled by
        beforeload event handlers.
        https://bugs.webkit.org/show_bug.cgi?id=41027
        <rdar://problem/8120596>

        * fast/dom/beforeload/image-object-before-load-expected.txt: Added.
        * fast/dom/beforeload/image-object-before-load-innerHTML-expected.txt: Added.
        * fast/dom/beforeload/image-object-before-load-innerHTML.html: Added.
        * fast/dom/beforeload/image-object-before-load.html: Added.
2010-07-07  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        Allow a beforeload listener to prevent loading of images in <object> tags.
        https://bugs.webkit.org/show_bug.cgi?id=41027
        <rdar://problem/8120596>

        Tests: fast/dom/beforeload/image-object-before-load-innerHTML.html
               fast/dom/beforeload/image-object-before-load.html

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::attach): Do not call
        RenderImage::setCachedImage() at the end of attach(). Instead, allow
        this to happen conditionally after beforeload is dispatched.
        * loader/ImageLoader.cpp:
        (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): Render fallback
        content if an object's load was cancelled.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Wed, 7 Jul 2010 14:23:50 +0000 (14:23 +0000)]
2010-07-07  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Adam Barth.

        [EFL] Fix cmake build and libsoup detection
        Some changes should be done to cmake build system to fix the detection of libsoup and correct some link paths:
        - LINK_FLAGS should be set using quotes, otherwise some wrong
        substitution takes place;
        - we should use LIBSOUP24_* instead of LIBSOUP_* since this is the
        version we are using;
        - need to set HAVE_LIBSOUP_2_29_90 if we find a version equal or newer
        than that.
        https://bugs.webkit.org/show_bug.cgi?id=41717

        * cmake/OptionsEfl.cmake:
2010-07-07  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Adam Barth.

        [EFL] Fix cmake build and libsoup detection
        Some changes should be done to cmake build system to fix the detection of libsoup and correct some link paths:
        - LINK_FLAGS should be set using quotes, otherwise some wrong
        substitution takes place;
        - we should use LIBSOUP24_* instead of LIBSOUP_* since this is the
        version we are using;
        - need to set HAVE_LIBSOUP_2_29_90 if we find a version equal or newer
        than that.
        https://bugs.webkit.org/show_bug.cgi?id=41717

        * CMakeLists.txt:
        * CMakeListsEfl.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 7 Jul 2010 14:17:27 +0000 (14:17 +0000)]
2010-07-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        <use> on <font-face> causes crashes, if SVGUseElement gets detached
        https://bugs.webkit.org/show_bug.cgi?id=41621

        Do not call removeFromMappedElementSheet() from the SVGFontFaceElement destructor,
        as that can potentially cause the element to be reattached while destructing.

        In order to fix the crash in the testcase, the order of calling the base-class detach
        method in SVGUseElement and the instance/shadow tree destruction has to be reversed,
        matching the order in removedFromDocument().

        Test: svg/custom/use-font-face-crash.svg

        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::~SVGFontFaceElement): Remove removeFromMappedElementSheet() call.
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::detach): Reverse order of calling base-class detach method and instance/shadow tree destruction.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Wed, 7 Jul 2010 14:10:50 +0000 (14:10 +0000)]
2010-07-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Implementation of QScriptValue::isArray()
        https://bugs.webkit.org/show_bug.cgi?id=41713

        Since we don't have access to the [[Class]] internal property of
        builtins (including Array), the solution was to keep the original 'Array'
        (constructor) and 'Array.prototype' objects and use them to identify
        if a given object is an Array.

        Also uncomment some tests and add some tests of newArray() that
        depended on isArray().

        * api/qscriptengine_p.cpp:
        (QScriptEnginePrivate::QScriptEnginePrivate):
        (QScriptEnginePrivate::~QScriptEnginePrivate):
        * api/qscriptengine_p.h:
        (QScriptEnginePrivate::isArray):
        * api/qscriptvalue.cpp:
        (QScriptValue::isArray):
        * api/qscriptvalue.h:
        * api/qscriptvalue_p.h:
        (QScriptValuePrivate::isArray):
        * tests/qscriptengine/tst_qscriptengine.cpp:
        (tst_QScriptEngine::newArray):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
aroben@apple.com [Wed, 7 Jul 2010 14:01:45 +0000 (14:01 +0000)]
Windows build fix

* Interfaces/WebKit.idl: Touched to force a build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 7 Jul 2010 13:58:55 +0000 (13:58 +0000)]
2010-07-07  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        document.createEvent() should support DeviceOrientationEvent
        https://bugs.webkit.org/show_bug.cgi?id=41618

        * fast/dom/DeviceOrientation/create-event-expected.txt: Added.
        * fast/dom/DeviceOrientation/create-event.html: Added.
        * fast/dom/DeviceOrientation/script-tests/create-event.js: Added.
        * platform/gtk/Skipped:
2010-07-07  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        document.createEvent() should support DeviceOrientationEvent
        https://bugs.webkit.org/show_bug.cgi?id=41618

        Tests: fast/dom/DeviceOrientation/create-event.html

        * dom/Document.cpp:
        (WebCore::Document::createEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 7 Jul 2010 13:06:37 +0000 (13:06 +0000)]
2010-07-07  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: show functions from internal browser scripts on the call stack if they
        are there.
        https://bugs.webkit.org/show_bug.cgi?id=41762

        * English.lproj/localizedStrings.js:
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix.
ossy@webkit.org [Wed, 7 Jul 2010 13:04:07 +0000 (13:04 +0000)]
Unreviewed fix.

[Qt] Remove non-existent files from Skipped list, and
add Qt specific expected result for svg/hixie/text/001.xml

* platform/qt/Skipped: Remove non-existent files.
 - svg/hixie/text/001-broken.xml, because it was renamed by r61393.
 - tables/mozilla/images/adforce_imgis_com.html, because it was removed by r61289.
 - inspector/debugger-breakpoints-not-activated-on-reload.html, because it was removed by r62651.
* platform/qt/svg/hixie/text: Added.
* platform/qt/svg/hixie/text/001-expected.checksum: Added.
* platform/qt/svg/hixie/text/001-expected.png: Added.
* platform/qt/svg/hixie/text/001-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 7 Jul 2010 13:01:31 +0000 (13:01 +0000)]
2010-07-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: All RefPtr arguments and return values should be
        changed to PassRefPtr whenever it is possible according to common practice.
        https://bugs.webkit.org/show_bug.cgi?id=41759

        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::pushGCEventRecords):
        (WebCore::InspectorTimelineAgent::didInstallTimer):
        (WebCore::InspectorTimelineAgent::didRemoveTimer):
        (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
        (WebCore::InspectorTimelineAgent::didMarkTimeline):
        (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
        (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
        (WebCore::InspectorTimelineAgent::addRecordToTimeline):
        (WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
        (WebCore::InspectorTimelineAgent::pushCurrentRecord):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createGenericRecord):
        (WebCore::TimelineRecordFactory::createGCEventData):
        (WebCore::TimelineRecordFactory::createFunctionCallData):
        (WebCore::TimelineRecordFactory::createEventDispatchData):
        (WebCore::TimelineRecordFactory::createGenericTimerData):
        (WebCore::TimelineRecordFactory::createTimerInstallData):
        (WebCore::TimelineRecordFactory::createXHRReadyStateChangeData):
        (WebCore::TimelineRecordFactory::createXHRLoadData):
        (WebCore::TimelineRecordFactory::createEvaluateScriptData):
        (WebCore::TimelineRecordFactory::createMarkTimelineData):
        (WebCore::TimelineRecordFactory::createScheduleResourceRequestData):
        (WebCore::TimelineRecordFactory::createResourceSendRequestData):
        (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
        (WebCore::TimelineRecordFactory::createResourceFinishData):
        (WebCore::TimelineRecordFactory::createReceiveResourceData):
        (WebCore::TimelineRecordFactory::createPaintData):
        (WebCore::TimelineRecordFactory::createParseHTMLData):
        * inspector/TimelineRecordFactory.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Wed, 7 Jul 2010 12:41:52 +0000 (12:41 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Add Qt section to the prefix header.

* WebKit2Prefix.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Initial WebKit2 implementation
antti.j.koivisto@nokia.com [Wed, 7 Jul 2010 12:37:55 +0000 (12:37 +0000)]
[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Export some event conversion functions needed for WebKit2.

* platform/PlatformKeyboardEvent.h:
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::keyIdentifierForQtKeyCode):
(WebCore::windowsKeyCodeForKeyEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-06 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 7 Jul 2010 11:51:16 +0000 (11:51 +0000)]
2010-07-06  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        DeviceOrientationEventConstructor should be exposed at window.DeviceOrientationEvent
        https://bugs.webkit.org/show_bug.cgi?id=41685

        Test: fast/dom/Window/window-properties-device-orientation.html
              fast/dom/DeviceOrientation/window-property.txt

        * page/DOMWindow.idl:
2010-07-06  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        DeviceOrientationEventConstructor should be exposed at window.DeviceOrientationEvent
        https://bugs.webkit.org/show_bug.cgi?id=41685

        This required fast/dom/Window/window-properties-on-device-orientation.html to be renamed
        to fast/dom/Window/window-properties-device-orientation.html and updated.

        * fast/dom/DeviceOrientation/script-tests/window-property.js:
        * fast/dom/DeviceOrientation/window-property-expected.txt:
        * fast/dom/Window/window-properties-device-orientation-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-on-device-orientation-expected.txt.
        * fast/dom/Window/window-properties-device-orientation.html: Copied from LayoutTests/fast/dom/Window/window-properties-on-device-orientation.html.
        * fast/dom/Window/window-properties-on-device-orientation-expected.txt: Removed.
        * fast/dom/Window/window-properties-on-device-orientation.html: Removed.
        * fast/dom/Window/window-properties.html:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Marc Mutz <marc.mutz@kdab.com>
commit-queue@webkit.org [Wed, 7 Jul 2010 11:39:21 +0000 (11:39 +0000)]
2010-07-07  Marc Mutz  <marc.mutz@kdab.com>

        Reviewed by Adam Barth.

        [Qt] QWebSettings: Don't leak native pixmaps

        When Q_GLOBAL_STATIC gets around to deleting the QHash with the
        pixmaps in, the QApplication destructor has already been
        completed. This makes it impossible for ~QPixmap to return the
        native pixmap to the OS, thus leaking them.

        This patch adds a post routine (executed as part of ~QApplication)
        that clears the hash so Q_GLOBAL_STATIC's destruction doesn't have
        to execute ~QPixmap's anymore.

        https://bugs.webkit.org/show_bug.cgi?id=41657

        * Api/qwebsettings.cpp:
        (earlyClearGraphics): New. Clears the pixmap hash.
        (graphics): add earlyClearGraphics as a qAddPostRoutine()

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 7 Jul 2010 11:27:02 +0000 (11:27 +0000)]
2010-07-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62645.
        http://trac.webkit.org/changeset/62645
        https://bugs.webkit.org/show_bug.cgi?id=41757

        "Broken inspector tests on several platforms" (Requested by
        eseidel on #webkit).

        * inspector/debugger-breakpoints-not-activated-on-reload-expected.txt: Removed.
        * inspector/debugger-breakpoints-not-activated-on-reload.html: Removed.
2010-07-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62645.
        http://trac.webkit.org/changeset/62645
        https://bugs.webkit.org/show_bug.cgi?id=41757

        "Broken inspector tests on several platforms" (Requested by
        eseidel on #webkit).

        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype._addBreakpoint):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype._breakpointAdded):
        (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._addBreakpoint):
2010-07-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r62645.
        http://trac.webkit.org/changeset/62645
        https://bugs.webkit.org/show_bug.cgi?id=41757

        "Broken inspector tests on several platforms" (Requested by
        eseidel on #webkit).

        * src/js/DebuggerScript.js:
        ():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 7 Jul 2010 10:27:46 +0000 (10:27 +0000)]
2010-07-07  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        JavaInstanceV8 needs to push a local reference frame to avoid table overflow.
        https://bugs.webkit.org/show_bug.cgi?id=41516

        This change is required to help prevent the Java virtual machine from
        running out of local references. The Java virtual machine supports only
        a limited number of local references. Normally, local references are
        cleared when the native method returns.

        This change adds calls to PushLocalFrame() and PopLocalFrame() around
        each invocation of a method on JavaInstance. These calls instruct the
        virtual machine to clear local references when the frame is popped.
        This means that in the case where many calls to JavaInstance methods
        are made within the same native call, local references are cleared as
        soon as they are no longer needed, thus conserving references.

        This change mirrors exactly JavaInstanceJSC.

        No new tests.

        * bridge/jni/v8/JavaInstanceV8.cpp:
        (JavaInstance::virtualBegin):
        (JavaInstance::virtualEnd):
        * bridge/jni/v8/JavaInstanceV8.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 7 Jul 2010 10:20:26 +0000 (10:20 +0000)]
2010-07-07  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Add new debugger test to the skip list on Qt.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
antti.j.koivisto@nokia.com [Wed, 7 Jul 2010 10:19:32 +0000 (10:19 +0000)]
Not reviewed.

Fix build, remove some left over debugging code.

* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-06 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 7 Jul 2010 10:10:11 +0000 (10:10 +0000)]
2010-07-06  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Inspector should remember the size of sidebars set by the user
        https://bugs.webkit.org/show_bug.cgi?id=19207

        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel):
        * inspector/front-end/ConsolePanel.js:
        (WebInspector.ConsolePanel):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.rightSidebarResizerDragEnd):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        (WebInspector.Panel.prototype.get toolbarItemClass):
        (WebInspector.Panel.prototype.show):
        (WebInspector.Panel.prototype.createSidebar):
        (WebInspector.Panel.prototype.get _sidebarWidthSettingName):
        (WebInspector.Panel.prototype._endSidebarDragging):
        (WebInspector.Panel.prototype.updateSidebarWidth):
        (WebInspector.Panel.prototype.restoreSidebarWidth):
        (WebInspector.Panel.prototype.saveSidebarWidth):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._endSidebarResizeDrag):
        (WebInspector.ScriptsPanel.prototype._sidebarResizeDrag):
        (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
        * inspector/front-end/Settings.js:
        (WebInspector.populateApplicationSettings):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-05 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 7 Jul 2010 09:52:32 +0000 (09:52 +0000)]
2010-07-05  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        DeviceOrientation should be renamed to DeviceOrientationController
        https://bugs.webkit.org/show_bug.cgi?id=41608

        No new tests, renaming only.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DeviceOrientation.cpp: Removed.
        * dom/DeviceOrientation.h: Removed.
        * dom/DeviceOrientationController.cpp: Copied from WebCore/dom/DeviceOrientation.cpp.
        (WebCore::DeviceOrientationController::DeviceOrientationController):
        (WebCore::DeviceOrientationController::onDeviceOrientationChange):
        * dom/DeviceOrientationController.h: Copied from WebCore/dom/DeviceOrientation.h.
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::deviceOrientationController):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Pavel Podivilov <podivilov@chromium.org>
yurys@chromium.org [Wed, 7 Jul 2010 09:30:42 +0000 (09:30 +0000)]
2010-07-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not activate all breakpoints on page reload
        https://bugs.webkit.org/show_bug.cgi?id=41461

        * inspector/debugger-breakpoints-not-activated-on-reload-expected.txt: Added.
        * inspector/debugger-breakpoints-not-activated-on-reload.html: Added.
2010-07-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: do not activate all breakpoints on page reload
        https://bugs.webkit.org/show_bug.cgi?id=41461

        Test: inspector/debugger-breakpoints-not-activated-on-reload.html

        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype._addBreakpoint):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._breakpointAdded):
        (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._addBreakpoint):
2010-07-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: if breakpoints were deactivated, add new breakpoints as disabled.
        https://bugs.webkit.org/show_bug.cgi?id=41461

        * src/js/DebuggerScript.js:
        ():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 7 Jul 2010 08:58:17 +0000 (08:58 +0000)]
2010-07-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rollout r62633 - test crashes after some last-minute modifications.

        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::~SVGFontFaceElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Jul 2010 08:52:59 +0000 (08:52 +0000)]
2010-07-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Fix </html> handling in before head mode
        https://bugs.webkit.org/show_bug.cgi?id=41752

        * html5lib/runner-expected-html5.txt:
2010-07-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Fix </html> handling in before head mode
        https://bugs.webkit.org/show_bug.cgi?id=41752

        Covered by html5lib/runner.html.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndTag):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-07-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 7 Jul 2010 08:50:48 +0000 (08:50 +0000)]
2010-07-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        </div> pops too many <div> elements in body
        https://bugs.webkit.org/show_bug.cgi?id=41751

        * html5lib/runner-expected-html5.txt:
2010-07-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        </div> pops too many <div> elements in body
        https://bugs.webkit.org/show_bug.cgi?id=41751

        Another missing return!

        While tracking this down I added some debugging code to both the
        open elements stack and the active formatting elements list.

        I also unwrapped a very long || chain to make it more readable.

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLElementStack::show):
        * html/HTMLElementStack.h:
        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::show):
        * html/HTMLFormattingElementList.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndTagForInBody):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@62642 268f45cc-cd09-0410-ab3c-d52691b4dbfc