dpranke@chromium.org [Fri, 3 Dec 2010 01:13:59 +0000 (01:13 +0000)]
2010-12-02 Sam Weinig <sam@webkit.org>
Fix Qt build.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Fri, 3 Dec 2010 00:38:54 +0000 (00:38 +0000)]
2010-12-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] Fix compilation with !ENABLE(OFFLINE_WEB_APPLICATIONS) and
!ENABLE(TILED_BACKING_STORE) for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50071
Add appropriate guards. No functional change if guards are set.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::setActualVisibleContentsRect):
* UIProcess/TiledDrawingAreaProxy.cpp:
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
* UIProcess/qt/TiledDrawingAreaTileQt.cpp:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 00:38:28 +0000 (00:38 +0000)]
Fix Qt build.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 3 Dec 2010 00:36:15 +0000 (00:36 +0000)]
WebCore: CSS support for the text-emphasis properties
https://bugs.webkit.org/show_bug.cgi?id=48539
Reviewed by Dave Hyatt.
Test: fast/css/parsing-text-emphasis.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added text-emphasis-color,
text-emphasis-position and text-emphasis-style. Left the text-emphasis shorthand unsupported.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Parse the properties.
(WebCore::CSSParser::parseTextEmphasisStyle): Added.
* css/CSSParser.h:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added TextEmphasisPosition, TextEmphasisFill
and TextEmphasisMark mappings.
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition): Added.
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill): Added.
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark): Added.
* css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap): Added the text-emphasis shorthand.
* css/CSSPropertyNames.in: Added -webkit-text-emphasis, -webkit-text-emphasis-color,
-webkit-text-emphasis-position, and -webkit-text-emphasis-style.
* css/CSSStyleSelector.cpp:
(WebCore::isValidVisitedLinkProperty): Added text-emphasis-color.
(WebCore::CSSStyleSelector::applyProperty): Handle the properties.
* css/CSSValueKeywords.in: Added 'over' and 'under' for text-emphasis-position. Added 'dot',
'double-circle', 'triangle', 'sesame', 'filled' and 'open' for text-emphasis-style.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorIncludingFallback): Handle text-emphasis-color.
(WebCore::RenderStyle::textEmphasisMark): Added. Maps the fake 'auto' value to 'dot' or
'sesame' based on writing direction.
* rendering/style/RenderStyle.h: Added accessors.
(WebCore::InheritedFlags::textEmphasisFill):
(WebCore::InheritedFlags::textEmphasisCustomMark):
(WebCore::InheritedFlags::textEmphasisPosition):
(WebCore::InheritedFlags::setTextEmphasisColor):
(WebCore::InheritedFlags::setTextEmphasisFill):
(WebCore::InheritedFlags::setTextEmphasisMark):
(WebCore::InheritedFlags::setTextEmphasisCustomMark):
(WebCore::InheritedFlags::setTextEmphasisPosition):
(WebCore::InheritedFlags::initialTextEmphasisColor):
(WebCore::InheritedFlags::initialTextEmphasisFill):
(WebCore::InheritedFlags::initialTextEmphasisMark):
(WebCore::InheritedFlags::initialTextEmphasisCustomMark):
(WebCore::InheritedFlags::initialTextEmphasisPosition):
(WebCore::InheritedFlags::textEmphasisColor):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
LayoutTests: Test parsing of the text-emphasis CSS properties
https://bugs.webkit.org/show_bug.cgi?id=48539
Reviewed by Dave Hyatt.
* fast/css/parsing-text-emphasis-expected.txt: Added.
* fast/css/parsing-text-emphasis.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Fri, 3 Dec 2010 00:35:26 +0000 (00:35 +0000)]
2010-12-02 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] merge toDataURL-supportedTypes in chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Fri, 3 Dec 2010 00:34:37 +0000 (00:34 +0000)]
2010-12-02 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Replaced GraphicsLayerMac with GraphicsLayerCA. GraphicsLayerCA is essentially
identical to GraphicsLayerMac, but replaces all the CoreAnimation specific calls
with calls to PlatformCALayer and PlatformCAAnimation. This makes GraphicsLayerCA
platform neutral as long as implementations of those two classes are available.
Added implementations in PlatformCALayerMac and PlatformCAAnimationMac. Also got
rid of GraphicsLayer::nativeLayer() and replaced it with GraphicsLayer::platformLayer()
to avoid confusion since both names were used to refer to the same thing.
This patch is only for Mac. Windows implementation has not changed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 00:33:46 +0000 (00:33 +0000)]
Fix Qt.
* UIProcess/API/qt/qwkpreferences.cpp:
(QWKPreferencesPrivate::createPreferences):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 3 Dec 2010 00:30:58 +0000 (00:30 +0000)]
WebKit2 Preferences should be held off the PageGroup, not the Context
https://bugs.webkit.org/show_bug.cgi?id=50414
Reviewed by Anders Carlsson.
WebKit2:
- In addition, this now makes the preference held off the PageGroup have
the identifier of the PageGroup and autosave to disk (only on the mac
for now).
- Adds ability to create an arbitrary preference that can be autosaved
via a new WKPreferencesCreateWithIdentifier function.
* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContext.h:
Remove preference related code.
* UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupSetPreferences):
(WKPageGroupGetPreferences):
* UIProcess/API/C/WKPageGroup.h:
Add getter/setter for preferences.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateWithIdentifier):
* UIProcess/API/C/WKPreferences.h:
Add WKPreferencesCreateWithIdentifier and remove WKPreferencesCreateCopy which is
unused.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
* UIProcess/WebContext.h:
Remove preference related code.
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::addPage):
(WebKit::WebPageGroup::removePage):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):
(WebKit::WebPageGroup::preferencesDidChange):
* UIProcess/WebPageGroup.h:
Add preference and page tracking.
* UIProcess/WebPageNamespace.cpp:
* UIProcess/WebPageNamespace.h:
Remove preference change notification code.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
Add/remove self from page group set.
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::creationParameters):
Get preferences from the pageGroup.
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences):
(WebKit::WebPreferences::addPageGroup):
(WebKit::WebPreferences::removePageGroup):
(WebKit::WebPreferences::update):
* UIProcess/WebPreferences.h:
(WebKit::WebPreferences::create):
Change to track page groups instead of contexts.
* UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey): Add ".WebKit2" prefix for keys.
WebKitTools:
Update for API changes.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 3 Dec 2010 00:30:17 +0000 (00:30 +0000)]
<rdar://problem/
8708730> Objects reported as being leaked due to lack of autorelease pool
Reviewed by Beth Dakin.
* Misc/WebNSFileManagerExtras.m:
(setMetaData): Create an autorelease pool for the duration of the thread body.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Fri, 3 Dec 2010 00:04:16 +0000 (00:04 +0000)]
2010-12-02 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 2 Dec 2010 23:55:31 +0000 (23:55 +0000)]
2010-12-02 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
This change is a bunch of cleanup / refactoring of the file
below. It moves a bunch of free functions to methods on the
TestShellThread class, and restructures other methods to be
closer to the structure we'll need for the multiprocessing
rewrite.
It also makes the logic of --run-singly a *lot* easier to follow
by nestling all of the separate-thread logic into a single
routine.
There should be no semantic changes in this patch, just cleanup.
https://bugs.webkit.org/show_bug.cgi?id=50367
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Thu, 2 Dec 2010 23:49:54 +0000 (23:49 +0000)]
2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Update ResourceLoaderSet Enumeration
https://bugs.webkit.org/show_bug.cgi?id=50405
Use size_t when working with Vectors and when comparing between size_t types.
* loader/DocumentLoader.cpp:
(WebCore::cancelAll):
(WebCore::setAllDefersLoading):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 2 Dec 2010 23:39:41 +0000 (23:39 +0000)]
Integer calculation issues in DataView constructor
https://bugs.webkit.org/show_bug.cgi?id=50354
Reviewed by Kenneth Russell.
WebCore:
Test: fast/canvas/webgl/data-view-crash.html
* html/canvas/DataView.cpp:
(WebCore::DataView::create):
LayoutTests:
* fast/canvas/webgl/data-view-crash-expected.txt: Added.
* fast/canvas/webgl/data-view-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Dec 2010 23:20:33 +0000 (23:20 +0000)]
2010-12-02 Tony Chang <tony@chromium.org>
Unreviewed, rolling out r73164.
http://trac.webkit.org/changeset/73164
https://bugs.webkit.org/show_bug.cgi?id=50359
broke debugger tests on win
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 2 Dec 2010 23:04:40 +0000 (23:04 +0000)]
* wtf/ASCIICType.h: Fix wrong type from last check-in.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 2 Dec 2010 23:01:08 +0000 (23:01 +0000)]
Try to fix certain builds (Qt Windows).
* wtf/ASCIICType.h: Added an overload for unsigned because in obsolete
versions of ICU, UChar32 can be a typedef for unsigned. Adding this
overload should make us compatible with these old ICUs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 2 Dec 2010 22:53:47 +0000 (22:53 +0000)]
2010-11-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Rebaseline server: add updating of baselines
https://bugs.webkit.org/show_bug.cgi?id=50305
Implements updating of baselines, where we copy -actual.* files over
the current -expected.* files. To do this, we need a
_get_actual_result_files method to get test results files and a
_rebaseline_test method to actually do the file copy and SCM operation.
_rebaseline_test logs output into a buffer, this is useful for both
showing result in the UI and for unit tests.
To make passing around of the various test environment properties
(results directory, filesystem, SCM, etc) easier, add a TestConfig
class for them.
Moving of existing baselines is not implemented yet, this patch is big
enough as it is.
* Scripts/webkitpy/common/system/filesystem.py:
* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
* Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Thu, 2 Dec 2010 22:49:27 +0000 (22:49 +0000)]
2010-12-02 Xiaomei Ji <xji@chromium.org>
Unreviewed.
2nd try on rebaseline vertical-scrollbar-in-rtl.
* platform/chromium-mac/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
* platform/chromium-win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
* platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 2 Dec 2010 22:45:36 +0000 (22:45 +0000)]
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Add AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=45594
Unicode::calculateStringHashFromUTF8 creates a StringHash out of UTF8 input data and
calculates the required length for the UTF16 conversation in one step.
This is then used in a specialized translator for the string table of AtomicString.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::equal):
(WTF::HashAndUTF8CharactersTranslator::hash):
(WTF::HashAndUTF8CharactersTranslator::equal):
(WTF::HashAndUTF8CharactersTranslator::translate):
(WTF::AtomicString::add):
(WTF::AtomicString::addSlowCase):
(WTF::AtomicString::find):
(WTF::AtomicString::fromUTF8):
* wtf/text/AtomicString.h:
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::readUTF8Sequence):
(WTF::Unicode::convertUTF8ToUTF16):
(WTF::Unicode::calculateStringHashFromUTF8):
(WTF::Unicode::equalUTF16WithUTF8):
* wtf/unicode/UTF8.h:
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Add AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=45594
Use AtomicString::fromUTF8 directly in the libxml2 parser.
* dom/XMLDocumentParserLibxml2.cpp:
(WebCore::toAtomicString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 2 Dec 2010 22:33:04 +0000 (22:33 +0000)]
2010-12-02 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium test expectations for failed canvas toDataURL test.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 2 Dec 2010 22:09:47 +0000 (22:09 +0000)]
2010-12-02 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] add vertical-scrollbar-in-rtl back to test expectations for mac.
The test does not putput consistent y-scroll position with HOME keydown.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 22:07:47 +0000 (22:07 +0000)]
Added a little hardening to OSAllocator.
Reviewed by Sam Weinig.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::release):
* wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release): CRASH() if the OS's virtual memory system
reports an error.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 2 Dec 2010 21:56:54 +0000 (21:56 +0000)]
Fix the Qt Linux Release minimal build.
* html/HTMLMarqueeElement.cpp: Include ExceptionCode.h
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 2 Dec 2010 21:55:28 +0000 (21:55 +0000)]
2010-12-02 Xan Lopez <xlopez@igalia.com>
Third attempt to fix the build.
* autotools/symbols.filter: be more liberal in one more symbol.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 2 Dec 2010 21:49:11 +0000 (21:49 +0000)]
Flash videos on YouTube flicker
https://bugs.webkit.org/show_bug.cgi?id=50409
<rdar://problem/
8668757>
Reviewed by Sam Weinig.
When painting from a backing store, we need to add the source location
to the destination point.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Thu, 2 Dec 2010 21:47:30 +0000 (21:47 +0000)]
Unreviewed build fix after vcproj updates.
* DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
that WIN_CAIRO is defined for this build.
* DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
(these were previously 'Debug_Cairo' and 'Release_Cairo'
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 2 Dec 2010 21:35:25 +0000 (21:35 +0000)]
2010-12-02 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Fine-tune chromium WebKit API for loading audio resources
https://bugs.webkit.org/show_bug.cgi?id=50406
* public/WebAudioBus.h:
(WebKit::WebAudioBus::~WebAudioBus):
* public/WebKitClient.h:
(WebKit::WebKitClient::loadAudioResource):
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::decodeAudioFileData):
* src/WebAudioBus.cpp:
(WebKit::WebAudioBus::reset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 2 Dec 2010 21:23:43 +0000 (21:23 +0000)]
2010-12-02 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium test expectations for failed svg tests.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
* platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
* platform/chromium-win/svg/carto.net/selectionlist-expected.png:
* platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
* platform/chromium-win/svg/custom/image-small-width-height-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Thu, 2 Dec 2010 21:22:42 +0000 (21:22 +0000)]
2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Update ResourceLoaderSet Enumeration
https://bugs.webkit.org/show_bug.cgi?id=50405
* loader/DocumentLoader.cpp:
(WebCore::cancelAll): instead of copying the HashSet, use copyToVector.
(WebCore::setAllDefersLoading): instead of copying the HashSet, use copyToVector.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 2 Dec 2010 21:18:57 +0000 (21:18 +0000)]
2010-12-02 Darin Fisher <darin@chromium.org>
Fix the Windows multi-dll build. Do not export functions that are
implemented inline!
* public/WebFormControlElement.h:
(WebKit::WebFormControlElement::assign):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 2 Dec 2010 21:14:08 +0000 (21:14 +0000)]
Implement (non-EventListener) marquee IDL attributes from HTML5.
https://bugs.webkit.org/show_bug.cgi?id=49786
Reviewed by Darin Adler.
WebCore:
Test: fast/html/marquee-element.html
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::scrollAmount): If the content attribute
can be converted to a signed integer and is >= 0, return it.
Otherwise, return the default scrollAmount value.
(WebCore::HTMLMarqueeElement::setScrollAmount): Update the content
attribute if it is >= 0. Otherwise, raise INDEX_SIZE_ERR.
(WebCore::HTMLMarqueeElement::scrollDelay): Same as scrollAmount.
(WebCore::HTMLMarqueeElement::setScrollDelay): Same as setScrollAmount.
(WebCore::HTMLMarqueeElement::loop): If the content attribute can be
converted to a signed integer and is greater than 0 or equal to -1,
return it. Otherwise, return the default loop value.
(WebCore::HTMLMarqueeElement::setLoop): Update the content attribute if
it is greater than 0 or equal to -1. Otherwise, raise INDEX_SIZE_ERR.
* html/HTMLMarqueeElement.h:
* html/HTMLMarqueeElement.idl: Update the IDL to match what is in HTML5.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::initialMarqueeSpeed):
LayoutTests:
* fast/html/marquee-element-expected.txt: Added.
* fast/html/marquee-element.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 2 Dec 2010 21:10:25 +0000 (21:10 +0000)]
2010-12-02 Xan Lopez <xlopez@igalia.com>
Another attempt to fix the GTK+ build.
* autotools/symbols.filter: try to be more liberal with the
mangled names of some symbols.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Dec 2010 20:55:19 +0000 (20:55 +0000)]
WebKit2 needs API to turn on popup blocking
https://bugs.webkit.org/show_bug.cgi?id=50407
Reviewed by Anders Carlsson.
WebKit2:
Pipe-through a preference for javascript being able to open
windows without user gesture.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetJavaScriptCanOpenWindowsAutomatically):
(WKPreferencesGetJavaScriptCanOpenWindowsAutomatically):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
WebKitTools:
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Thu, 2 Dec 2010 20:49:31 +0000 (20:49 +0000)]
2010-12-02 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline vertical-scrollbar-in-rtl after r73063.
Enable truncation-rtl after r73087.
https://bugs.webkit.org/show_bug.cgi?id=50352
* platform/chromium-mac/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
* platform/chromium-win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 2 Dec 2010 20:43:25 +0000 (20:43 +0000)]
2010-12-02 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 2 Dec 2010 20:41:30 +0000 (20:41 +0000)]
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[OpenVG] Remove "current path" of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=50294
* platform/graphics/GraphicsContext.h:
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::PainterOpenVG):
(WebCore::PainterOpenVG::~PainterOpenVG):
(WebCore::PainterOpenVG::drawPath):
* platform/graphics/openvg/PainterOpenVG.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 2 Dec 2010 20:36:04 +0000 (20:36 +0000)]
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[WINCE] Remove "current path" of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=50284
* platform/graphics/GraphicsContext.h:
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 2 Dec 2010 20:27:33 +0000 (20:27 +0000)]
2010-12-02 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium test expectations.
These svg tests need to rebaseline on win and linux.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jnd@chromium.org [Thu, 2 Dec 2010 20:17:06 +0000 (20:17 +0000)]
2010-12-02 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right gesture status for URL redirections.
https://bugs.webkit.org/show_bug.cgi?id=47817
* fast/frames/location-redirect-user-gesture-expected.txt: Added.
* fast/frames/location-redirect-user-gesture.html: Added.
* fast/frames/meta-refresh-user-gesture-expected.txt: Added.
* fast/frames/meta-refresh-user-gesture.html: Added.
* fast/frames/resources/meta-refresh-target.html: Added.
* platform/gtk/Skipped:
* platform/win/Skipped:
2010-12-02 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right gesture status for URL redirections.
https://bugs.webkit.org/show_bug.cgi?id=47817
Tests: fast/frames/location-redirect-user-gesture.html
fast/frames/meta-refresh-user-gesture.html
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledNavigation::clearUserGesture):
(WebCore::ScheduledRedirect::ScheduledRedirect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 2 Dec 2010 20:16:44 +0000 (20:16 +0000)]
2010-12-02 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
* autotools/symbols.filter: add missing ';'.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 2 Dec 2010 20:09:27 +0000 (20:09 +0000)]
2010-12-02 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Geoffrey Garen.
[Qt] Make platform managing of OSAllocator better than r73106
https://bugs.webkit.org/show_bug.cgi?id=50385
* wtf/OSAllocatorPosix.cpp: Remove platform specific guard.
* wtf/OSAllocatorSymbian.cpp: Remove platform specific guard.
* wtf/OSAllocatorWin.cpp: Remove platform specific guard.
* wtf/wtf.pri: Add the correct platform specific source file instead of all of them.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 2 Dec 2010 19:57:36 +0000 (19:57 +0000)]
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[WINCE] Use GetTickCount() for srand()
https://bugs.webkit.org/show_bug.cgi?id=50338
time() is not a native function on WinCE, so use GetTickCount() instead.
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Dec 2010 19:53:28 +0000 (19:53 +0000)]
2010-12-02 Eric Seidel <eric@webkit.org>
Unreviewed.
animations/stop-animation-on-suspend.html sometimes fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49182
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 2 Dec 2010 19:48:39 +0000 (19:48 +0000)]
2010-12-02 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
AudioContext needs createBuffer() method from ArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=50343
No new tests since audio API is not yet implemented.
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createBuffer):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 19:42:52 +0000 (19:42 +0000)]
2010-12-02 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Add canvas.toDataURL("image/jpeg", quality) support
https://bugs.webkit.org/show_bug.cgi?id=49365
Chromium window/linux layout try results now match the default test result, so
remove this platform-specific test exception file.
* platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.
2010-12-02 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Add canvas.toDataURL("image/jpeg", quality) support
https://bugs.webkit.org/show_bug.cgi?id=49365
Adds a libjpeg-based image encoder for Skia bitmaps. Default encoding quality
is 92 to match Mozilla, also Safari, though the actual value used by Safari is
undocumented, and it appears to pre-blur images prior to compression.
The preMultipliedBGRAtoRGB() routine restores the un-premultiplied RGB colors
where there is non-zero alpha. Again, this matches Firefox and Safari, but no
browser conforms to the HTML5 canvas standard here, I believe, considering the
result of canvas/philip/tests/toDataURL.jpeg.alpha.html; that test ignores the
alpha channel when extracting an "image/jpeg".toDataURL(). The correct answer
needs more investigation, bug http://webkit.org/b/40147.
Canvas toDataURL is covered by existing tests canvas/philip/tests/toDataURL.*,
and fast/canvas/*toDataURL* tests.
* WebCore.gypi:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback): don't set encoding quality
here, just pass the toDataURL parameters through to the canvas layer.
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): implement
the supported mimeTypes for encoding in-place.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL): add jpeg encoding and quality support.
* platform/image-encoders/skia/JPEGImageEncoder.cpp: Added.
(WebCore::prepareOutput):
(WebCore::writeOutput):
(WebCore::finishOutput):
(WebCore::handleError):
(WebCore::preMultipliedBGRAtoRGB): FIXME: bug 40147.
(WebCore::JPEGImageEncoder::encode):
* platform/image-encoders/skia/JPEGImageEncoder.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 19:30:51 +0000 (19:30 +0000)]
2010-12-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73152.
http://trac.webkit.org/changeset/73152
https://bugs.webkit.org/show_bug.cgi?id=50401
the patch has broken chromium win layout tests (Requested by
loislo on #webkit).
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/report-protocol-errors-expected.txt:
* inspector/report-protocol-errors.html:
2010-12-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73152.
http://trac.webkit.org/changeset/73152
https://bugs.webkit.org/show_bug.cgi?id=50401
the patch has broken chromium win layout tests (Requested by
loislo on #webkit).
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/front-end/Callback.js:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
* inspector/front-end/inspector.js:
(WebInspector.loaded.WebInspector.socket.onmessage):
(WebInspector.dispatch):
(WebInspector_syncDispatch):
(WebInspector.reportProtocolError):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 19:23:55 +0000 (19:23 +0000)]
2010-12-02 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.checksum: Added.
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.png: Added.
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Added.
* platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
* platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
* platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Added.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Added.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/svg/custom/image-rescale-expected.checksum: Added.
* platform/mac-leopard/svg/custom/image-rescale-expected.png: Added.
* platform/mac-leopard/svg/custom/image-rescale-expected.txt: Added.
* platform/mac/svg/custom/image-rescale-clip-expected.checksum: Added.
* platform/mac/svg/custom/image-rescale-clip-expected.png: Added.
* platform/mac/svg/custom/image-rescale-clip-expected.txt: Added.
* platform/mac/svg/custom/image-rescale-expected.checksum: Added.
* platform/mac/svg/custom/image-rescale-expected.png: Added.
* platform/mac/svg/custom/image-rescale-expected.txt: Added.
* platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Added.
* platform/mac/svg/custom/image-rescale-scroll-expected.png: Added.
* platform/mac/svg/custom/image-rescale-scroll-expected.txt: Added.
* svg/custom/image-rescale-clip.html: Added.
* svg/custom/image-rescale-scroll.html: Added.
* svg/custom/image-rescale.svg: Added.
* svg/custom/resources/image-rescale.jpg: Added.
2010-12-02 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370
This patch modifies ImageSkia.cpp to fix the calculation of resampled
bitmap sizes so as to include the transform matrix of the canvas.
Includes new tests to catch a scrolling regression and a clipping regression.
Tests: svg/custom/image-rescale-clip.html
svg/custom/image-rescale-scroll.html
svg/custom/image-rescale.svg
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::computeResamplingMode):
(WebCore::drawResampledBitmap):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Thu, 2 Dec 2010 19:21:48 +0000 (19:21 +0000)]
2010-12-02 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Missing DOM property for incremental input attribute
https://bugs.webkit.org/show_bug.cgi?id=50335
* fast/forms/incremental-dom-property-expected.txt: Added.
* fast/forms/incremental-dom-property.html: Added.
* fast/forms/script-tests/incremental-dom-property.js: Added.
2010-12-02 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Missing DOM property for incremental input attribute
https://bugs.webkit.org/show_bug.cgi?id=50335
Test: fast/forms/incremental-dom-property.html
* html/HTMLInputElement.idl: Added attribute
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 2 Dec 2010 19:17:50 +0000 (19:17 +0000)]
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Attempt to fix the GTK+ build. Add missing symbol the
list of unfiltered symbols for the linker.
* autotools/symbols.filter: Add symbol used in DumpRenderTree.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Dec 2010 19:00:08 +0000 (19:00 +0000)]
2010-12-01 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] force NRWT to use DRT
https://bugs.webkit.org/show_bug.cgi?id=50359
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 18:59:07 +0000 (18:59 +0000)]
2010-12-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Move requestGeolocationPermissionForFrame to GeolocationClient
https://bugs.webkit.org/show_bug.cgi?id=50061
This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.
* page/Chrome.h:
* page/ChromeClient.h:
* page/Geolocation.cpp:
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::requestPermission):
* page/GeolocationClient.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::requestPermission):
(WebCore::GeolocationController::cancelPermissionRequest):
* page/GeolocationController.h:
* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPermission):
(WebCore::GeolocationClientMock::requestPermission):
(WebCore::GeolocationClientMock::cancelPermissionRequest):
(WebCore::GeolocationClientMock::asyncUpdatePermission):
(WebCore::GeolocationClientMock::permissionTimerFired):
(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::stopUpdating):
(WebCore::GeolocationClientMock::asyncUpdateController):
(WebCore::GeolocationClientMock::controllerTimerFired):
* platform/mock/GeolocationClientMock.h:
2010-12-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Move requestGeolocationPermissionForFrame to GeolocationClient
https://bugs.webkit.org/show_bug.cgi?id=50061
This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.
Move method ChromeClient::requestGeolocationPermissionForFrame to
GeolocationClient::requestPermission, and supporting class
WebGeolocationPolicyListener. The moved code is unchanged except
that requestPermission now takes only one argument (Geolocation*)
and the Frame parameter is retrieved from the Geolocation object.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
* WebCoreSupport/WebGeolocationClient.h:
(WebGeolocationClient::cancelPermissionRequest):
* WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::requestPermission):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
2010-12-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Move requestGeolocationPermissionForFrame to GeolocationClient
https://bugs.webkit.org/show_bug.cgi?id=50061
This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.
Move method ChromeClient::requestGeolocationPermissionForFrame to
GeolocationClient::requestPermission. The moved code is unchanged
except that requestPermission now takes only one argument (Geolocation*),
the Frame parameter is retrieved from the Geolocation object and we need to
call m_webView.get() as it is a COMPtr in GeolocationClient.
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebGeolocationClient.cpp:
(WebGeolocationClient::requestPermission):
* WebCoreSupport/WebGeolocationClient.h:
(WebGeolocationClient::cancelPermissionRequest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 2 Dec 2010 18:41:38 +0000 (18:41 +0000)]
Plug-ins should be able to update the mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=50399
Reviewed by Sam Weinig.
WebKit2:
Call WKEnableSettingCursorWhenInBackground.
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
WebKitLibraries:
Add WKEnableSettingCursorWhenInBackground.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Dec 2010 18:33:14 +0000 (18:33 +0000)]
2010-12-02 Tony Chang <tony@chromium.org>
Unreviewed, update DRT crash on mac.
* platform/chromium/test_expectations.txt:
2010-12-02 Tony Chang <tony@chromium.org>
Unreviewed, roll chromium deps to r67980.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Dec 2010 18:30:05 +0000 (18:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50368
Overhaul WebKit2 preferences code
Reviewed by Anders Carlsson.
- Reduces the number of places you have to touch to add a new preference
(From 9 down to 4, but with a bit of elbow grease, we should get that
down to 2 or 3).
- Add hooks so that platforms can initialize the preferences based on an
identifier. This is currently only used on the Mac to initialize a
preference store from NSUserDefaults and autosave the changes to disk.
It is not yet enabled due to no way to set the identifier from client
code.
* Shared/WebPageCreationParameters.cpp:
Add necessary #include of WebCoreArgumentCoders.h which is now needed
due to cleanup in WebPreferencesStore.h.
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
(WebKit::defaultValueForKey):
(WebKit::setValueForKey):
(WebKit::valueForKey):
(WebKit::WebPreferencesStore::setStringValueForKey):
(WebKit::WebPreferencesStore::getStringValueForKey):
(WebKit::WebPreferencesStore::setBoolValueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):
(WebKit::WebPreferencesStore::setUInt32ValueForKey):
(WebKit::WebPreferencesStore::getUInt32ValueForKey):
* Shared/WebPreferencesStore.h:
Complete overhaul of this class to store the preferences as
a set of HashMaps and use macros to define the keys and default
values.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetFontSmoothingLevel):
Add cast to keep conversion function working.
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences): Add identifier constructor.
(WebKit::WebPreferences::updateStringValueForKey):
(WebKit::WebPreferences::updateBoolValueForKey):
(WebKit::WebPreferences::updateUInt32ValueForKey):
Add type based updaters. These currently give hooks to the platform and
call the generic update, but in the future, we can use this to optimize
updating preferences to not send the entire store for each change.
* UIProcess/WebPreferences.h:
Generate the getters and setters via macro instantiation.
* UIProcess/cf/WebPreferencesCF.cpp: Added.
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Stubbed out.
* UIProcess/mac/WebPreferencesMac.mm: Added.
(WebKit::makeKey):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Use the platform hooks to initialize and update the store from
NSUserDefaults.
* UIProcess/qt/WebPreferencesQt.cpp: Added.
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Stubbed out.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
Update to pull the value using the new type based getters.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 2 Dec 2010 18:22:16 +0000 (18:22 +0000)]
2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task.
The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
https://bugs.webkit.org/show_bug.cgi?id=50337
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/front-end/inspector.js:
(WebInspector_syncDispatch):
2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task.
The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
https://bugs.webkit.org/show_bug.cgi?id=50337
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/report-protocol-errors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 2 Dec 2010 18:14:33 +0000 (18:14 +0000)]
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DumpRenderTree has two copies of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=49877
Prevent the need to compile JSC into DumpRenderTree twice, by adjusting
the symbol visibility rules for libwebkit. Make all JSC symbols visible,
while hiding WebCore/WebKit symbols.
* GNUmakefile.am: Move the symbol visibility flags to the WebKit build.
* autotools/symbols.filter: Update the symbol filter list with the real
mangled names of the symbols and include other symbols that DRT needs.
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DumpRenderTree has two copies of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=49877
Keep WebKit/WebCore symbols hidden.
* GNUmakefile.am: Move the symbol visibility rules here, because
now JSC symbols are visible, but WebCore/WebKit symbols are hidden.
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DumpRenderTree has two copies of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=49877
* GNUmakefile.am: Remove the second copy of JavaScriptCore from the
LDADD list for DumpRenderTree.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Thu, 2 Dec 2010 18:07:24 +0000 (18:07 +0000)]
2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Eric Carlson.
Style Fixes in WebPluginController
https://bugs.webkit.org/show_bug.cgi?id=50397
* Plugins/WebPluginController.mm:
(-[WebPluginController startAllPlugins]):
(-[WebPluginController stopAllPlugins]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 2 Dec 2010 17:55:40 +0000 (17:55 +0000)]
Mac build fix.
* WebProcess/WebKitMain.cpp:
(enableDataExecutionPrevention):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Dec 2010 17:45:27 +0000 (17:45 +0000)]
2010-12-02 Tony Chang <tony@chromium.org>
Unreviewed, add back fast/overflow/hit-test-overflow-controls.html
to chromium test_expectations.txt. It's failing on the main
waterfall. Thanks to victorw for notifying me.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 2 Dec 2010 17:42:03 +0000 (17:42 +0000)]
2010-12-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Re-implementing HAR export functionality that used to be in Resources
tab in Network tab.
https://bugs.webkit.org/show_bug.cgi?id=45663
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._createTable):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
(WebInspector.NetworkPanel.prototype._contextMenu):
(WebInspector.NetworkPanel.prototype._exportAll):
(WebInspector.NetworkPanel.prototype._exportResource):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
* inspector/front-end/networkPanel.css:
(.data-grid table.data tr.revealed.network-item):
(.data-grid.filter-other table.data tr.revealed.network-category-other):
2010-12-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Enable resource export to HAR for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45663
* src/js/DevTools.js: Preferences.resourceExportEnabled = true
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Thu, 2 Dec 2010 17:39:26 +0000 (17:39 +0000)]
Slightly speculative fix for:
Reviewed by Adam Roben.
<rdar://problem/
8712674>
<https://bugs.webkit.org/show_bug.cgi?id=50393>
setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
* Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
If the realm is nil, use @"" instead.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 17:34:02 +0000 (17:34 +0000)]
2010-11-30 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] Implement RunLoop, WorkQueue, Connection classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48507
* Platform/CoreIPC/Connection.h: UNIX_X11 specific changes for GTK port.
(CoreIPC::Connection::messageProcessingCompleted):
* Platform/CoreIPC/gtk: Added.
* Platform/CoreIPC/gtk/ConnectionGtk.cpp: Added. Connection class implementation for GTK port (UNIX_X11 specific).
(CoreIPC::readBytesFromSocket):
(CoreIPC::writeBytesToSocket):
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::processCompletedMessage):
(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::platformCanSendOutgoingMessages):
(CoreIPC::Connection::sendOutgoingMessage):
* Platform/PlatformProcessIdentifier.h: UNIX_X11 specific changes for GTK port.
* Platform/RunLoop.h: GTK port specific changes.
* Platform/WorkQueue.h: GTK port specific changes.
* Platform/gtk/RunLoopGtk.cpp: Added. Runs an event loop using GMainLoop and handles the incoming messages.
(RunLoop::RunLoop):
(RunLoop::~RunLoop):
(RunLoop::run):
(RunLoop::mainLoop):
(RunLoop::stop):
(RunLoop::queueWork):
(RunLoop::wakeUp):
(RunLoop::TimerBase::TimerBase):
(RunLoop::TimerBase::~TimerBase):
(RunLoop::TimerBase::resetTimerSource):
(RunLoop::TimerBase::oneShotTimerFired):
(RunLoop::TimerBase::repeatingTimerFired):
(RunLoop::TimerBase::start):
(RunLoop::TimerBase::stop):
(RunLoop::TimerBase::isActive):
* Platform/gtk/WorkQueueGtk.cpp: Added. Creates a thread and polls on a given fd using GIOChannel.
Dispatches the obtained messages to RunLoop's GMainLoop.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::dispatchSource):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::startWorkQueueThread):
(WorkQueue::workQueueThreadBody):
(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):
(WorkQueue::scheduleWork):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Dec 2010 17:33:18 +0000 (17:33 +0000)]
2010-12-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing tests.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 2 Dec 2010 17:24:52 +0000 (17:24 +0000)]
2010-12-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Move enableExecutionPrevention to WebKitMain
https://bugs.webkit.org/show_bug.cgi?id=50392
* WebProcess/WebKitMain.cpp:
(enableDataExecutionPrevention):
(WebKitMain):
* WebProcess/win/WebProcessMainWin.cpp:
(WebKit::WebProcessMain):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 17:11:07 +0000 (17:11 +0000)]
2010-12-02 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Reject named colors, accept only #rrggbb in <input type=color />
https://bugs.webkit.org/show_bug.cgi?id=50308
* fast/forms/ValidityState-typeMismatch-color-expected.txt:
* fast/forms/script-tests/ValidityState-typeMismatch-color.js: Changed to reject English color names.
2010-12-02 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Reject named colors, accept only #rrggbb in <input type=color />
https://bugs.webkit.org/show_bug.cgi?id=50308
* html/ColorInputType.cpp: Modified to accept only simple colors like #xxxxxx.
(WebCore::isValidColorString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 2 Dec 2010 17:10:29 +0000 (17:10 +0000)]
2010-12-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Enable DEP at runtime to allow for compatibility with older versions of ATL
https://bugs.webkit.org/show_bug.cgi?id=50378
* WebProcess/win/WebProcessMainWin.cpp:
(WebKit::enableDataExecutionPrevention):
(WebKit::WebProcessMain):
* win/WebKit2WebProcessCommon.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 16:33:11 +0000 (16:33 +0000)]
2010-12-02 Vincent Scheib <scheib@chromium.org>
Reviewed by Darin Fisher.
[chromium] histograms api updated in WebKitClient and added to ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=50285
Test by loading "about:histograms" after navigating to accelerated pages.
* platform/chromium/ChromiumBridge.h: api update.
2010-12-02 Vincent Scheib <scheib@chromium.org>
Reviewed by Darin Fisher.
[chromium] histograms api updated in WebKitClient/ChromiumBridge and histogram "GPU.setIsAcceleratedCompositingActive" added.
https://bugs.webkit.org/show_bug.cgi?id=50285
Test by loading "about:histograms" after navigating to accelerated pages.
* public/WebKitClient.h:
(WebKit::WebKitClient::histogramCustomCounts): api update.
(WebKit::WebKitClient::histogramEnumeration): api update.
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::histogramCustomCounts): api update.
(WebCore::ChromiumBridge::histogramEnumeration): api update.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive): "GPU.setIsAcceleratedCompositingActive" added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Dec 2010 16:23:33 +0000 (16:23 +0000)]
2010-12-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing test.
* platform/gtk/Skipped: Skip media/video-volume.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Dec 2010 16:14:56 +0000 (16:14 +0000)]
2010-12-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskip passing media tests on GTK.
* platform/gtk/Skipped: Unskip fullscreen video tests, now passing.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 2 Dec 2010 16:13:15 +0000 (16:13 +0000)]
Unreviewed. Add Qt specific expected files after r73063.
Make scrolling work properly with writing modes
https://bugs.webkit.org/show_bug.cgi?id=46645
* platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/fast/dom/horizontal-scrollbar-in-rtl-expected.txt.
* platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 2 Dec 2010 16:12:35 +0000 (16:12 +0000)]
2010-12-02 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt][V8] Fix linking of generated sources.
No new tests needed.
* WebCore.pro: add missing V8ImageDataCustom.cpp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 2 Dec 2010 15:55:33 +0000 (15:55 +0000)]
Remove a test that we were only skipping to see if it would fix other tests
It didn't.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 2 Dec 2010 15:51:34 +0000 (15:51 +0000)]
Add some new tests to the mac-wk2 Skipped file
All of the tests depend on EventSender.keyDown.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 2 Dec 2010 15:19:03 +0000 (15:19 +0000)]
2010-12-02 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben.
Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedString/SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=50383
Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(STRING|ENUMERATION) / DEFINE_ANIMATED_(STRING|ENUMERATION).
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
No functional changes, thus no new tests.
* svg/SVGAElement.cpp:
* svg/SVGAElement.h:
(WebCore::SVGAElement::isValid):
(WebCore::SVGAElement::target):
* svg/SVGAltGlyphElement.cpp:
* svg/SVGAltGlyphElement.h:
* svg/SVGAnimatedEnumeration.h:
* svg/SVGAnimatedString.h:
* svg/SVGClipPathElement.cpp:
* svg/SVGClipPathElement.h:
* svg/SVGComponentTransferFunctionElement.cpp:
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGCursorElement.cpp:
* svg/SVGCursorElement.h:
* svg/SVGFEBlendElement.cpp:
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
* svg/SVGFECompositeElement.h:
* svg/SVGFEConvolveMatrixElement.cpp:
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
* svg/SVGFEImageElement.h:
* svg/SVGFELightElement.cpp:
* svg/SVGFEMergeNodeElement.cpp:
* svg/SVGFEMergeNodeElement.h:
* svg/SVGFEMorphologyElement.cpp:
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETileElement.cpp:
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
* svg/SVGFETurbulenceElement.h:
* svg/SVGFilterElement.cpp:
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/SVGForeignObjectElement.cpp:
* svg/SVGForeignObjectElement.h:
* svg/SVGGradientElement.cpp:
* svg/SVGGradientElement.h:
* svg/SVGImageElement.cpp:
* svg/SVGImageElement.h:
* svg/SVGMPathElement.cpp:
* svg/SVGMPathElement.h:
* svg/SVGMarkerElement.cpp:
* svg/SVGMarkerElement.h:
* svg/SVGMaskElement.cpp:
* svg/SVGMaskElement.h:
* svg/SVGPatternElement.cpp:
* svg/SVGPatternElement.h:
* svg/SVGScriptElement.cpp:
* svg/SVGScriptElement.h:
* svg/SVGStyledElement.cpp:
* svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::hasRelativeLengths):
(WebCore::SVGStyledElement::supportsMarkers):
(WebCore::SVGStyledElement::style):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
(WebCore::SVGStyledElement::selfHasRelativeLengths):
(WebCore::SVGStyledElement::isStyled):
* svg/SVGTRefElement.cpp:
* svg/SVGTRefElement.h:
* svg/SVGTextContentElement.cpp:
* svg/SVGTextContentElement.h:
* svg/SVGTextPathElement.cpp:
* svg/SVGTextPathElement.h:
* svg/SVGUseElement.cpp:
* svg/SVGUseElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 2 Dec 2010 14:28:31 +0000 (14:28 +0000)]
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[WX] Remove "current path" of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=50286
* platform/graphics/GraphicsContext.h:
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 2 Dec 2010 14:11:23 +0000 (14:11 +0000)]
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Text input controls do not react properly to CSS styling
https://bugs.webkit.org/show_bug.cgi?id=40855
Update tests which have changed after fixes to text field layout.
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/basic-textareas-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
* platform/gtk/fast/forms/encoding-test-expected.txt:
* platform/gtk/fast/forms/fieldset-align-expected.txt:
* platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
* platform/gtk/fast/forms/form-element-geometry-expected.txt:
* platform/gtk/fast/forms/input-align-expected.txt:
* platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-disabled-color-expected.txt:
* platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
* platform/gtk/fast/forms/input-paste-undo-expected.txt:
* platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
* platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
* platform/gtk/fast/forms/input-readonly-empty-expected.txt:
* platform/gtk/fast/forms/input-spaces-expected.txt:
* platform/gtk/fast/forms/input-table-expected.txt:
* platform/gtk/fast/forms/input-text-click-inside-expected.txt:
* platform/gtk/fast/forms/input-text-click-outside-expected.txt:
* platform/gtk/fast/forms/input-text-double-click-expected.txt:
* platform/gtk/fast/forms/input-text-drag-down-expected.txt:
* platform/gtk/fast/forms/input-text-option-delete-expected.txt:
* platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
* platform/gtk/fast/forms/input-type-change2-expected.txt:
* platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/forms/input-width-expected.txt:
* platform/gtk/fast/forms/isindex-placeholder-expected.txt:
* platform/gtk/fast/forms/minWidthPercent-expected.txt:
* platform/gtk/fast/forms/password-placeholder-expected.txt:
* platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
* platform/gtk/fast/forms/placeholder-set-value-expected.txt:
* platform/gtk/fast/forms/placeholder-stripped-expected.txt:
* platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/search-transformed-expected.txt:
* platform/gtk/fast/forms/search-zoomed-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/text-control-intrinsic-widths-expected.txt:
* platform/gtk/fast/forms/text-style-color-expected.txt:
* platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
* platform/gtk/fast/forms/textarea-align-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
* platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
* platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
* platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
* platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
* platform/gtk/fast/forms/textarea-width-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/fast/forms/textfield-overflow-expected.txt:
* platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
2010-10-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Text input controls do not react properly to CSS styling
https://bugs.webkit.org/show_bug.cgi?id=40855
Improve text input control rendering. Instead of using the GTK+ border
attributes of the control modify the padding, they modify the border.
Make this same choice for search inputs and text area inputs.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::setTextInputBorders): Added this helper which sets text input control
borders based on GTK+ theme settings.
(WebCore::RenderThemeGtk::adjustTextFieldStyle): Use the setTextInputBorders helper.
(WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
(WebCore::RenderThemeGtk::adjustSearchFieldStyle): Ditto.
* platform/gtk/RenderThemeGtk.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vitalyr@chromium.org [Thu, 2 Dec 2010 14:00:49 +0000 (14:00 +0000)]
2010-12-02 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Updating test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 13:58:13 +0000 (13:58 +0000)]
2010-12-02 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Reintroduce compiler optimizations for JSC
https://bugs.webkit.org/show_bug.cgi?id=50270
Add compiler optimization (symbian ARM target) which was lost after split from WebCore.
Tested via Sunspider and V8 - both of which show significant performance improvement.
* JavaScriptCore.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 13:39:21 +0000 (13:39 +0000)]
2010-12-02 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::strokeRect() taints the context's lineWidth
https://bugs.webkit.org/show_bug.cgi?id=50269
* fast/canvas/canvas-lineWidth-intact-after-strokeRect-expected.txt: Added.
* fast/canvas/canvas-lineWidth-intact-after-strokeRect.html: Added.
* fast/canvas/script-tests/canvas-lineWidth-intact-after-strokeRect.js: Added.
2010-12-02 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::strokeRect() taints the context's lineWidth
https://bugs.webkit.org/show_bug.cgi?id=50269
Test: fast/canvas/canvas-lineWidth-intact-after-strokeRect.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokeRect): Restore the context's
original stroke thickness after painting.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 2 Dec 2010 13:36:45 +0000 (13:36 +0000)]
2010-12-02 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Move regex parsing and fallback handling to runtime/RegExp.cpp
https://bugs.webkit.org/show_bug.cgi?id=50015
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::printTraceData):
* runtime/RegExp.h:
(JSC::RegExp::pattern):
* yarr/RegexInterpreter.cpp:
* yarr/RegexInterpreter.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::compile):
(JSC::Yarr::jitCompileRegex):
* yarr/RegexJIT.h:
(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::setFallBack):
(JSC::Yarr::RegexCodeBlock::isFallBack):
(JSC::Yarr::executeRegex):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Thu, 2 Dec 2010 12:38:13 +0000 (12:38 +0000)]
[Qt] GraphicsContext::clip(path) should clip using winding fill
https://bugs.webkit.org/show_bug.cgi?id=49912
Patch by Renata Hodovan <reni@webkit.org> on 2010-12-02
Reviewed by Andreas Kling.
GraphicsContext::clip(path) now uses winding fill and this function is called by
GraphicsContext::canvasClip(path).
No new test is needed.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 2 Dec 2010 12:33:05 +0000 (12:33 +0000)]
2010-12-02 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, build fix.
* http/tests/inspector/inspect-iframe-from-different-domain.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 2 Dec 2010 11:25:26 +0000 (11:25 +0000)]
2010-12-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove obsolete CSS backend API from InspectorDOMAgent
https://bugs.webkit.org/show_bug.cgi?id=50318
WebCore:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.idl:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCSSStore.cpp: Removed.
* inspector/InspectorCSSStore.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::unbind):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
LayoutTests:
* inspector/styles-iframe.html:
* inspector/styles-source-lines.html:
* inspector/styles-source-offsets-expected.txt:
* inspector/styles-source-offsets.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 2 Dec 2010 10:50:33 +0000 (10:50 +0000)]
Unreviewed trivial buildfix after r73117.
* page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 10:40:07 +0000 (10:40 +0000)]
2010-12-02 Yuqiang Xian <yuqiang.xian@intel.com>
Reviewed by Pavel Feldman.
[V8] Speed up data property access for ImageData.
https://bugs.webkit.org/show_bug.cgi?id=49999
We create a normal V8 object which has a PixelArray as the backing storage,
and set the "data" property of the ImageData object to it.
This way "data" becomes a pure JS property and we don't need to call through
the C++ bindings for ImageData "data" access.
This eliminates big overhead in switching between JavaScript and native
contexts and performing object bindings.
No new tests. Relying on existing Canvas tests.
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp: Added.
(WebCore::toV8):
* html/ImageData.idl:
* html/canvas/CanvasPixelArray.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 2 Dec 2010 10:23:38 +0000 (10:23 +0000)]
2010-12-02 Kent Tamura <tkent@chromium.org>
Unreviewed. Run sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 10:12:27 +0000 (10:12 +0000)]
2010-12-02 Mike Lawther <mikelawther@chromium.org>
Reviewed by David Hyatt.
Clean up of iframe scrollbar mode code
https://bugs.webkit.org/show_bug.cgi?id=47797
Pull setChildNeedsLayout/setNeedsLayout calls out of scrollbar mode
calculation method and put back into main layout function.
Early exit from the scrollbar calc when scrollbars are turned off.
* page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 09:54:24 +0000 (09:54 +0000)]
2010-12-02 Hironori Bono <hbono@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Fix possible crashes in FontFallbackFont::determinePitch().
https://bugs.webkit.org/show_bug.cgi?id=25770
When all of "Arial", "Courier New", and "Times New Roman" fonts are corrupted,
FontCache::getLastResortFallbackFont() returns 0 and it causes this crash. To
avoid this crash, this change falls back to system fonts (Windows ensures they
are sane) as Win Safari does. Unfortunately, I don't have any ideas how I can
write a layout test for this issue because this crash happens on a PC some of
its system fonts are corrupted.
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Thu, 2 Dec 2010 09:39:19 +0000 (09:39 +0000)]
2010-12-02 Sergio Villar Senin <svillar@igalia.com>
Unreviewed: Added myself to list of Committers.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 2 Dec 2010 09:15:00 +0000 (09:15 +0000)]
2010-12-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Provide means to store shadow DOM nodes on Element
https://bugs.webkit.org/show_bug.cgi?id=48697
Adds shadow DOM awareness to the standard Node attach/detach,
document and tree insertion and removal cycle.
No new tests, because the code is not yet used.
* dom/Element.cpp:
(WebCore::Element::insertedIntoDocument): Added logic to cascade down to shadow DOM, if present.
(WebCore::Element::removedFromDocument): Ditto.
(WebCore::Element::insertedIntoTree): Ditto.
(WebCore::Element::removedFromTree): Ditto.
(WebCore::Element::attach): Ditto.
(WebCore::Element::detach): Ditto.
(WebCore::Element::recalcStyle):
(WebCore::Element::shadowRoot): Added.
(WebCore::Element::setShadowRoot): Added.
(WebCore::Element::clearShadowRoot): Added.
* dom/Element.h: Added decls.
* dom/ElementRareData.h: Added a member to hold a RefPtr to the shadow DOM root for the element.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 2 Dec 2010 08:18:24 +0000 (08:18 +0000)]
2010-12-02 Daniel Bates <dbates@rim.com>
Add autotools generated files to svn:ignore so that these
files do not show up in an svn stat.
* .: Modified property svn:ignore.
* autotools: Added property svn:ignore.
2010-12-02 Daniel Bates <dbates@rim.com>
Ignore WebKit/gtk/docs/GNUmakefile.in and WebKit/gtk/po/*.pot so that
these files do not appear in an svn stat. This change makes SVN
consistent with the current Git ignore behavior for these files.
* docs: Added property svn:ignore.
* po: Added property svn:ignore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 2 Dec 2010 08:05:30 +0000 (08:05 +0000)]
2010-12-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Gray-scale JPEG images with a color profile are stretched horizonally
https://bugs.webkit.org/show_bug.cgi?id=49950
Turns out gray-scale JPEGs with color profiles have the same issue as
PNGs. As with PNGs, we suppress now suppress the color profile for
gray-scale JPEGs. Most importantly, this patch adds a test.
Test: fast/images/gray-scale-jpeg-with-color-profile.html
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
2010-12-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Gray-scale JPEG images with a color profile are stretched horizonally
https://bugs.webkit.org/show_bug.cgi?id=49950
Test that we properly render gray-scale JPEGs with embedded color
profiles.
* fast/images/gray-scale-jpeg-with-color-profile.html: Added.
* fast/images/resources/flowchart.jpg: Added.
* platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 2 Dec 2010 07:01:58 +0000 (07:01 +0000)]
2010-12-01 Daniel Bates <dbates@rim.com>
Remove file LayoutTests/platform/gtk/Skipped.rej which was
inadvertently committed in changeset 72675 <http://trac.webkit.org/changeset/72675>.
* platform/gtk/Skipped.rej: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 04:38:58 +0000 (04:38 +0000)]
Try to fix the GTK build.
* GNUmakefile.am: Use a full path to OSAllocator*.cpp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 04:28:23 +0000 (04:28 +0000)]
Try to fix the EFL Linux build.
* CMakeListsEfl.txt: Added OSAllocator to the project.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Dec 2010 04:27:58 +0000 (04:27 +0000)]
2010-12-01 Eric Seidel <eric@webkit.org>
Unreviewed.
compositing/iframes/overlapped-nested-iframes.html is ridiculously flaky
https://bugs.webkit.org/show_bug.cgi?id=50255
Skipping it to stop the madness.
* platform/mac-snowleopard/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 04:04:55 +0000 (04:04 +0000)]
Try to fix the Qt build: Include all OS files for Qt's sake, and then
use #ifdefs in the files to exclude things based on OS.
This is a pretty bad way to manage platforms -- hopefully we can
fix the Qt build system and move away from this in the future.
* wtf/OSAllocatorPosix.cpp:
* wtf/OSAllocatorSymbian.cpp:
* wtf/OSAllocatorWin.cpp:
* wtf/wtf.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 03:50:59 +0000 (03:50 +0000)]
Try to fix the Chromium build.
* JavaScriptCore.gypi: This is a Windows build file, so use OSAllocatorWin.cpp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 03:39:01 +0000 (03:39 +0000)]
Try to fix the GTK build.
* GNUmakefile.am: Added OSAllocator to another project.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 2 Dec 2010 03:31:25 +0000 (03:31 +0000)]
2010-12-01 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium image test expectations.
* platform/chromium-mac/platform/mac/editing: Added.
* platform/chromium-mac/platform/mac/editing/spelling: Added.
* platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
* platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
* platform/chromium-win/platform/mac/editing/spelling: Added.
* platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
* platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc