WebKit.git
8 years agoFix the test failing with run-perf-tests.
alexis.menard@openbossa.org [Thu, 15 Mar 2012 18:24:01 +0000 (18:24 +0000)]
Fix the test failing with run-perf-tests.

Rubber stamped by Ryosuke Niwa.

* CSS/CSSPropertySetterGetter.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Run unit tests with --verbose in the bots
carlosgc@webkit.org [Thu, 15 Mar 2012 17:37:48 +0000 (17:37 +0000)]
[GTK] Run unit tests with --verbose in the bots
https://bugs.webkit.org/show_bug.cgi?id=81230

Reviewed by Martin Robinson.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests): Add --verbose to run-gtk-test command.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agomigrate Yang Guo's expectations from chromium to webkit
caryclark@google.com [Thu, 15 Mar 2012 17:32:08 +0000 (17:32 +0000)]
migrate Yang Guo's expectations from chromium to webkit
https://bugs.webkit.org/show_bug.cgi?id=81026

Unreviewed test_expectations.

Patch by Elliot Poger <epoger@google.com> on 2012-03-15

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix typos in ChangeLog dates.
kevino@webkit.org [Thu, 15 Mar 2012 17:28:53 +0000 (17:28 +0000)]
Unreviewed. Fix typos in ChangeLog dates.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove wx port to using export macros
kevino@webkit.org [Thu, 15 Mar 2012 17:25:01 +0000 (17:25 +0000)]
Move wx port to using export macros
https://bugs.webkit.org/show_bug.cgi?id=77279

Reviewed by Hajime Morita.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed. Build fixes for Mac and DOM bindings.
kevino@webkit.org [Thu, 15 Mar 2012 17:14:35 +0000 (17:14 +0000)]
[wx] Unreviewed. Build fixes for Mac and DOM bindings.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extract CompilerScriptMapping from RawSourceCode.
podivilov@chromium.org [Thu, 15 Mar 2012 16:55:38 +0000 (16:55 +0000)]
Web Inspector: extract CompilerScriptMapping from RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=81088

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js: Added.
(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodeList):
(WebInspector.CompilerScriptMapping.prototype.addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.addScript):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocss3/filters/custom/custom-filter-property-computed-style.html passes in browser...
jberlin@webkit.org [Thu, 15 Mar 2012 16:52:21 +0000 (16:52 +0000)]
css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT.
https://bugs.webkit.org/show_bug.cgi?id=81029

Land expected passing results for WKTR.

* platform/mac-wk2/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Move all includes behind ENABLE(INSPECTOR) guards
yurys@chromium.org [Thu, 15 Mar 2012 16:44:09 +0000 (16:44 +0000)]
Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards
https://bugs.webkit.org/show_bug.cgi?id=81132

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-15
Reviewed by Yury Semikhatsky.

Include directives are moved several lines down in .cpp files and in
generator templates.

* inspector/CodeGeneratorInspector.py:
* inspector/ContentSearchUtils.cpp:
* inspector/DOMEditor.cpp:
* inspector/DOMNodeHighlighter.cpp:
* inspector/DOMPatchSupport.cpp:
* inspector/IdentifiersFactory.cpp:
* inspector/InjectedScript.cpp:
* inspector/InjectedScriptHost.cpp:
* inspector/InjectedScriptManager.cpp:
* inspector/InspectorAgent.cpp:
* inspector/InspectorApplicationCacheAgent.cpp:
* inspector/InspectorBaseAgent.cpp:
* inspector/InspectorCSSAgent.cpp:
* inspector/InspectorClient.cpp:
* inspector/InspectorConsoleAgent.cpp:
* inspector/InspectorController.cpp:
* inspector/InspectorCounters.cpp:
* inspector/InspectorDOMAgent.cpp:
* inspector/InspectorDOMDebuggerAgent.cpp:
* inspector/InspectorDOMStorageAgent.cpp:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseResource.cpp:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorFileSystemAgent.cpp:
* inspector/InspectorFrontendClientLocal.cpp:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorHistory.cpp:
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorInstrumentation.cpp:
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorResourceAgent.cpp:
* inspector/InspectorRuntimeAgent.cpp:
* inspector/InspectorState.cpp:
* inspector/InspectorStyleSheet.cpp:
* inspector/InspectorStyleTextEditor.cpp:
* inspector/InspectorTimelineAgent.cpp:
* inspector/InspectorValues.cpp:
* inspector/InstrumentingAgents.cpp:
* inspector/NetworkResourcesData.cpp:
* inspector/PageConsoleAgent.cpp:
* inspector/PageDebuggerAgent.cpp:
* inspector/PageRuntimeAgent.cpp:
* inspector/TimelineRecordFactory.cpp:
* inspector/WorkerConsoleAgent.cpp:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerRuntimeAgent.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: improve HeapSnapshot._buildReversIndex performance
yurys@chromium.org [Thu, 15 Mar 2012 16:39:47 +0000 (16:39 +0000)]
Web Inspector: improve HeapSnapshot._buildReversIndex performance
https://bugs.webkit.org/show_bug.cgi?id=81224

Caching node indexes and node count in local variables instead of
calling getters each time reduces the method run time by
factor of 1.5

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
leviw@chromium.org [Thu, 15 Mar 2012 16:35:52 +0000 (16:35 +0000)]
Unreviewed gardening.

Updating slightly changed SVG animation text expectations post-110545.

* platform/chromium-linux-x86/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
* platform/chromium-linux-x86/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.txt: Added.
* platform/chromium-mac/svg/css/stars-with-shadow-expected.txt: Added.
* platform/chromium-win-vista/fast/repaint: Removed.
* platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Added.
* platform/chromium/fast/repaint/moving-shadow-on-path-expected.txt: Replaced.
* platform/chromium/svg/css/stars-with-shadow-expected.txt: Replaced.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 15 Mar 2012 16:03:49 +0000 (16:03 +0000)]
2012-03-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        SVG Animations update baseVal instead of animVal
        https://bugs.webkit.org/show_bug.cgi?id=12437

        Rubber-stamped by Rob Buis.

        Rename constructFromCopy to constructFromVariant, and currentBaseValue to currentBaseValueVariant, to clarify what it actually does.

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::resetToBaseValue):
        * svg/SVGAnimatedLength.cpp:
        (WebCore::SVGAnimatedLengthAnimator::constructFromVariant):
        * svg/SVGAnimatedLength.h:
        (SVGAnimatedLengthAnimator):
        * svg/SVGAnimatedLengthList.cpp:
        (WebCore::SVGAnimatedLengthListAnimator::constructFromVariant):
        * svg/SVGAnimatedLengthList.h:
        (SVGAnimatedLengthListAnimator):
        * svg/SVGAnimatedNumber.cpp:
        (WebCore::SVGAnimatedNumberAnimator::constructFromVariant):
        * svg/SVGAnimatedNumber.h:
        (SVGAnimatedNumberAnimator):
        * svg/SVGAnimatedNumberList.cpp:
        (WebCore::SVGAnimatedNumberListAnimator::constructFromVariant):
        * svg/SVGAnimatedNumberList.h:
        (SVGAnimatedNumberListAnimator):
        * svg/SVGAnimatedTransformList.cpp:
        (WebCore::SVGAnimatedTransformListAnimator::constructFromVariant):
        * svg/SVGAnimatedTransformList.h:
        (SVGAnimatedTransformListAnimator):
        * svg/SVGAnimatedTypeAnimator.h:
        (WebCore::SVGAnimatedTypeAnimator::constructFromVariant):
        * svg/properties/SVGAnimatedListPropertyTearOff.h:
        (WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
        * svg/properties/SVGAnimatedProperty.h:
        (SVGAnimatedProperty):
        * svg/properties/SVGAnimatedPropertyTearOff.h:
        (WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
        * svg/properties/SVGAnimatedStaticPropertyTearOff.h:
        (WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix bounce-back behaviour for panning
abecsi@webkit.org [Thu, 15 Mar 2012 15:58:45 +0000 (15:58 +0000)]
[Qt][WK2] Fix bounce-back behaviour for panning
https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

Move the content back to boundaries immediately
in response to a tap gesture during the bounce-back
animation after panning.

* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtViewportInteractionEngine.h:
Make the ensureContentWithinViewportBoundary function public.
(QtViewportInteractionEngine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Thu, 15 Mar 2012 15:36:06 +0000 (15:36 +0000)]
[chromium] Unreviewed gardening.

Updated Lion baselines for css3/filters.  Skipped all custom tests,
and removed all baselines, since support is not currently compiled in.

* platform/chromium-mac-leopard/css3/filters/custom: Removed.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-expected.png: Removed.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/composited-during-transition-layertree-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/custom: Removed.
* platform/chromium-mac-snowleopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Removed.
* platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-brightness-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-brightness-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-combined-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-combined-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-contrast-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-contrast-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-grayscale-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-grayscale-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-invert-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-invert-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-invert-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-opacity-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-opacity-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-saturate-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-saturate-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-sepia-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-sepia-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-with-transform-expected.png: Added.
* platform/chromium-mac/css3/filters/nested-filter-expected.png: Added.
* platform/chromium-mac/css3/filters/nested-filters-expected.png: Added.
* platform/chromium-mac/css3/filters/regions-expanding-expected.png: Added.
* platform/chromium-win/css3/filters/custom: Removed.
* platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
* platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Removed.
* platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Removed.
* platform/chromium/css3/filters/custom: Removed.
* platform/chromium/css3/filters/custom/effect-custom-combined-missing-expected.txt: Removed.
* platform/chromium/css3/filters/custom/effect-custom-disabled-expected.txt: Removed.
* platform/chromium/css3/filters/custom/effect-custom-expected.txt: Removed.
* platform/chromium/css3/filters/custom/effect-custom-parameters-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable animVal support for SVGNumberList
zimmermann@webkit.org [Thu, 15 Mar 2012 15:27:21 +0000 (15:27 +0000)]
Enable animVal support for SVGNumberList
https://bugs.webkit.org/show_bug.cgi?id=81219

Reviewed by Rob Buis.

Source/WebCore:

Enable animVal support for SVGNumberList. Easy patch, we just need to add the missing
constructFromCopy() method to SVGAnumatedNumberListAnimator and report AnimatedNumberList
as supporting animVal.

Covered by existing tests.

* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::constructFromCopy):
(WebCore):
* svg/SVGAnimatedNumberList.h:
(WebCore):
(SVGAnimatedNumberListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):

LayoutTests:

Extend SVGNumberList tests to cover animVal/baseVal at the same time.

* platform/chromium/test_expectations.txt:
* svg/animations/script-tests/svgnumberlist-animation-1.js:
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/svgnumberlist-animation-2.js:
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/svgnumberlist-animation-1-expected.txt:
* svg/animations/svgnumberlist-animation-2-expected.txt:
* svg/filters/feColorMatrix-invalid-animation-expected.txt: We no longer mutate the DOM, thus the dump is now correct.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK build fix attempt after r110845.
philn@webkit.org [Thu, 15 Mar 2012 15:12:54 +0000 (15:12 +0000)]
Unreviewed, GTK build fix attempt after r110845.

* Scripts/run-gtk-tests: Added --release and --debug options.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoParametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
kubo@profusion.mobi [Thu, 15 Mar 2012 14:58:55 +0000 (14:58 +0000)]
Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
https://bugs.webkit.org/show_bug.cgi?id=79673

Preparatory work for bringing jhbuild enabled build to EFL port.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-15
Reviewed by Philippe Normand.

* Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
* Scripts/update-webkitgtk-libs:
* gtk/run-with-jhbuild:
* jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
(top_level_path):
(jhbuild_installed):
(jhbuild_cloned):
(jhbuild_at_expected_revision):
(update_jhbuild):
(clone_jhbuild):
(install_jhbuild):
(update_webkit_libs_jhbuild):
(determine_platform):
(ensure_jhbuild):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add command line options to run-gtk-tests script
carlosgc@webkit.org [Thu, 15 Mar 2012 14:44:26 +0000 (14:44 +0000)]
[GTK] Add command line options to run-gtk-tests script
https://bugs.webkit.org/show_bug.cgi?id=81218

Reviewed by Philippe Normand.

Following command line options have been added:

-v, --verbose: to run gtester with --verbose. That would be used
by the bots to make it easier to know which test case it failing.

--display: to use a different display for Xvfb

It's also possible to pass one or more tests as arguments.

* Scripts/run-gtk-tests:
(TestRunner.__init__): Receive command line arguments.
(TestRunner._get_tests): Get all the tests or the ones passed by
command line arguments.
(TestRunner._ensure_accessibility_daemon_is_running): Use display
command line argument.
(TestRunner.run): Pas command line options.
(TestRunner.run.run_tests): Pass command line arguments.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix cast-align GCC warnings
rwlbuis@webkit.org [Thu, 15 Mar 2012 14:34:16 +0000 (14:34 +0000)]
Fix cast-align GCC warnings
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Nikolas Zimmermann.

* platform/graphics/WOFFFileFormat.cpp:
(WebCore::writeUInt32):
(WebCore::writeUInt16):
(WebCore::convertWOFFToSfnt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 15 Mar 2012 14:17:50 +0000 (14:17 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 15 Mar 2012 14:15:52 +0000 (14:15 +0000)]
2012-03-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Forgot to preserve copyrights, per reviewer comment.

        * svg/SVGAnimatedTransformList.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable animVal support for SVGNumber
zimmermann@webkit.org [Thu, 15 Mar 2012 14:12:58 +0000 (14:12 +0000)]
Enable animVal support for SVGNumber
https://bugs.webkit.org/show_bug.cgi?id=81212

Reviewed by Rob Buis.

Source/WebCore:

Enable animVal support for SVGNumber. This aligns SVGAnimatedStaticPropertyTearOff,
with the other SVGListPropertyTearOff & SVGPropertyTearOff, as all support animVal now.
Converting the rest of the types can be done in small patches now.

Test: svg/animations/svgnumber-animation-4.html

* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::constructFromCopy):
(WebCore):
* svg/SVGAnimatedNumber.h:
(WebCore):
(SVGAnimatedNumberAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):
* svg/properties/SVGAnimatedProperty.h:
(SVGAnimatedProperty):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::animVal):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentAnimatedValue):
(SVGAnimatedStaticPropertyTearOff):
(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):

LayoutTests:

Add new test covering animVal support for SVGNumber.

* svg/animations/script-tests/svgnumber-animation-4.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgnumber-animation-4-expected.txt: Added.
* svg/animations/svgnumber-animation-4.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKit2APITests/TestPrinting timeout in the bots
carlosgc@webkit.org [Thu, 15 Mar 2012 14:00:03 +0000 (14:00 +0000)]
[GTK] WebKit2APITests/TestPrinting timeout in the bots
https://bugs.webkit.org/show_bug.cgi?id=81211

Reviewed by Philippe Normand.

Add gtk+ patch to fix timeout in the bots. A similar patch has
already landed in updatream gtk+, see
http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f

* gtk/jhbuild.modules:
* gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-03-15 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 15 Mar 2012 13:34:14 +0000 (13:34 +0000)]
2012-03-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix typo introduced in my last patch leading to flakiness.

        * svg/animations/script-tests/animateTransform-pattern-transform.js:
        (executeTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable animVal support for SVGTransformList
zimmermann@webkit.org [Thu, 15 Mar 2012 13:09:28 +0000 (13:09 +0000)]
Enable animVal support for SVGTransformList
https://bugs.webkit.org/show_bug.cgi?id=80758

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGTransformList. SVGTransformLists are only animatable
via <animateTransform>, not via <animate> directly. Still we can handle it in the
same framework as all other types used for <animate>, as we also need proper animVal
support for <animateTransform>.

This patch removes the special <animateTransform> implementation, and lets
SVGAnimateTransformElement inherit from SVGAnimateElement, just like its done
for SVGAnimateColorElement & SVGSetElement.

All existing code (calculateFromAndToValues/FromAndByValues/etc..) are moved from
SVGAnimateTransform right into the SVGAnimatedTransformListAnimator.

This doesn't change <animateTransform> behavior, it just simplies the code
and enables animVal support for SVGTransformLists - all covered by existing tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::hasValidAttributeType):
(WebCore::SVGAnimateTransformElement::parseAttribute):
* svg/SVGAnimateTransformElement.h:
(WebCore::SVGAnimateTransformElement::transformType):
(SVGAnimateTransformElement):
* svg/SVGAnimatedTransformList.cpp: Added.
(WebCore):
(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::constructFromString):
(WebCore::SVGAnimatedTransformListAnimator::constructFromCopy):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedTransformListAnimator::calculateDistance):
* svg/SVGAnimatedTransformList.h:
(WebCore):
(SVGAnimatedTransformListAnimator):
(WebCore::SVGAnimatedTransformListAnimator::~SVGAnimatedTransformListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createTransformList):
(WebCore):
(WebCore::SVGAnimatedType::transformList):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):
* svg/SVGAnimatedType.h:
(WebCore):
(SVGAnimatedType):
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::parseAttribute):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::parseAttribute):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::parseAttribute):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::parseAttribute):
* svg/SVGTransform.cpp:
(WebCore::SVGTransform::transformTypePrefixForParsing):
(WebCore):
(WebCore::SVGTransform::valueAsString):
* svg/SVGTransform.h:
(SVGTransform):
* svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::parse):
(WebCore):
* svg/SVGTransformList.h:
(SVGTransformList):
* svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::parseTransformType):
* svg/SVGTransformable.h:
(WebCore):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::setTransform):

LayoutTests:

Rebaseline tests after enabling animVal support SVGAnimateTransformElement/SVGTransformList.

* svg/animations/animate-gradient-transform-expected.txt:
* svg/animations/animateTransform-pattern-transform-expected.txt:
* svg/animations/script-tests/animate-gradient-transform.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animateTransform-pattern-transform.js:
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosheriffbot should also be addressable with a comma in addition to colon
kov@webkit.org [Thu, 15 Mar 2012 12:50:24 +0000 (12:50 +0000)]
sheriffbot should also be addressable with a comma in addition to colon
https://bugs.webkit.org/show_bug.cgi?id=81101

Reviewed by Adam Barth.

* Scripts/webkitpy/common/net/irc/ircbot.py:
(IRCBot.on_pubmsg):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] MiniBrowser scroll indicators should not scroll out of view https://bugs.webkit...
ahf@0x90.dk [Thu, 15 Mar 2012 12:06:47 +0000 (12:06 +0000)]
[Qt] MiniBrowser scroll indicators should not scroll out of view https://bugs.webkit.org/show_bug.cgi?id=81131

Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/qml/ScrollIndicator.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable animVal support for SVGLengthList
zimmermann@webkit.org [Thu, 15 Mar 2012 10:00:04 +0000 (10:00 +0000)]
Enable animVal support for SVGLengthList
https://bugs.webkit.org/show_bug.cgi?id=80750

Reviewed by Zoltan Herczeg.

Source/WebCore:

Introduce animVal support for generic SVGList types. This aligns SVGListProperty with SVGProperty
in terms of animVal/baseVal support. Use this to turn on animVal support for SVGLengthList.

Extend all existing SVGLengthList tests to correctly differentiate between baseVal/animVal.

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::resetToBaseValue):
(WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
(WebCore::SVGAnimateTransformElement::applyResultsToTarget):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::constructFromCopy):
(WebCore):
* svg/SVGAnimatedLengthList.h:
(WebCore):
(SVGAnimatedLengthListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
(WebCore::SVGAnimatedType::setVariantValue):
* svg/SVGAnimatedType.h:
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::applyAnimatedValue):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animationValueDidChange):
* svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
* svg/properties/SVGAnimatedProperty.h:
(WebCore::SVGAnimatedProperty::isAnimating):
(SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::animationValueWillChange):
(WebCore::SVGAnimatedProperty::animationValueDidChange):
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(SVGAnimatedPropertyTearOff):
(WebCore::SVGAnimatedPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPropertyTearOff::animVal):
(WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedPropertyTearOff::animationValueWillChange):
(WebCore::SVGAnimatedPropertyTearOff::animationValueDidChange):
(WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff):
* svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):
* svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::detachListWrappers):
(SVGListProperty):
(WebCore::SVGListProperty::setValuesAndWrappers):
(WebCore::SVGListProperty::clearValues):
(WebCore::SVGListProperty::clearValuesAndWrappers):
(WebCore::SVGListProperty::numberOfItems):
(WebCore::SVGListProperty::initializeValues):
(WebCore::SVGListProperty::initializeValuesAndWrappers):
(WebCore::SVGListProperty::canGetItem):
(WebCore::SVGListProperty::getItemValues):
(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::canReplaceItem):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(WebCore::SVGListProperty::canRemoveItem):
(WebCore::SVGListProperty::removeItemValues):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):
(WebCore::SVGListProperty::appendItemValues):
(WebCore::SVGListProperty::appendItemValuesAndWrappers):
(WebCore::SVGListProperty::values):
(WebCore::SVGListProperty::wrappers):
(WebCore::SVGListProperty::SVGListProperty):
* svg/properties/SVGListPropertyTearOff.h:
(SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::create):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
(WebCore::SVGListPropertyTearOff::clear):
(WebCore::SVGListPropertyTearOff::initialize):
(WebCore::SVGListPropertyTearOff::insertItemBefore):
(WebCore::SVGListPropertyTearOff::replaceItem):
(WebCore::SVGListPropertyTearOff::appendItem):
(WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::commitChange):
* svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::getItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItem):
* svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::create):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::appendItem):
(WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::commitChange):
* svg/properties/SVGPropertyInfo.h:
* svg/properties/SVGStaticListPropertyTearOff.h:
(SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::clear):
(WebCore::SVGStaticListPropertyTearOff::initialize):
(WebCore::SVGStaticListPropertyTearOff::getItem):
(WebCore::SVGStaticListPropertyTearOff::insertItemBefore):
(WebCore::SVGStaticListPropertyTearOff::replaceItem):
(WebCore::SVGStaticListPropertyTearOff::removeItem):
(WebCore::SVGStaticListPropertyTearOff::appendItem):
(WebCore::SVGStaticListPropertyTearOff::SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::commitChange):
* svg/properties/SVGTransformListPropertyTearOff.h:
(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):
(WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):

LayoutTests:

Update test expectations after turning on animVal support for SVGLengthList.

* svg/animations/script-tests/svglengthlist-animation-1.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-2.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-3.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-4.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svglengthlist-animation-5.js:
(sample1):
(sample2):
(sample3):
* svg/animations/svglengthlist-animation-1-expected.txt:
* svg/animations/svglengthlist-animation-2-expected.txt:
* svg/animations/svglengthlist-animation-3-expected.txt:
* svg/animations/svglengthlist-animation-4-expected.txt:
* svg/animations/svglengthlist-animation-5-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty
carlosgc@webkit.org [Thu, 15 Mar 2012 09:08:57 +0000 (09:08 +0000)]
[WK2] WebPageProxy::activeURL should return unreachableURL() when it's not empty
https://bugs.webkit.org/show_bug.cgi?id=75465

Reviewed by Philippe Normand.

* UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::replaceContent): Return the main frame
unreachableURL if it's not empty.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a new perf test to benchmark setting and reading CSS properties from JS.
alexis.menard@openbossa.org [Thu, 15 Mar 2012 08:57:19 +0000 (08:57 +0000)]
Add a new perf test to benchmark setting and reading CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=81155

Reviewed by Ryosuke Niwa.

This benchmark read and set CSS properties from JS. It contains a list
of common CSS properties.

* CSS/CSSPropertySetterGetter.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK baselines for new fast/css test.
morrita@google.com [Thu, 15 Mar 2012 08:04:49 +0000 (08:04 +0000)]
Unreviewed, GTK baselines for new fast/css test.

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-15

* platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK baselines for new fast/css test.
philn@webkit.org [Thu, 15 Mar 2012 07:44:22 +0000 (07:44 +0000)]
Unreviewed, GTK baselines for new fast/css test.

* platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update.
morrita@google.com [Thu, 15 Mar 2012 07:30:47 +0000 (07:30 +0000)]
Unreviewed expectations update.

* platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Added.
* platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectations update.
morrita@google.com [Thu, 15 Mar 2012 07:04:59 +0000 (07:04 +0000)]
Unreviewed expectations update.

* platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: AXDescription for HTML5 footer
cfleizach@apple.com [Thu, 15 Mar 2012 06:32:13 +0000 (06:32 +0000)]
Source/WebCore: AXDescription for HTML5 footer
https://bugs.webkit.org/show_bug.cgi?id=78967

Return a unique role description for the footer element.

Reviewed by Beth Dakin.

Test: platform/mac/accessibility/footer-roledescription.html

* English.lproj/Localizable.strings:+
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
* platform/LocalizedStrings.cpp:
(WebCore::AXFooterRoleDescriptionText):
(WebCore):
* platform/LocalizedStrings.h:
(WebCore):
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXFooterRoleDescriptionText):
(WebCore):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXFooterRoleDescriptionText):
(WebCore):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXFooterRoleDescriptionText):
(WebCore):

Source/WebKit/chromium: AXDescription for HTML5 footer and ARIA role contentinfo incorrect
https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

* src/LocalizedStrings.cpp:

LayoutTests: AXDescription for HTML5 footer and ARIA role contentinfo incorrect
https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

* platform/mac/accessibility/footer-roledescription-expected.txt: Added.
* platform/mac/accessibility/footer-roledescription.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectation update for Chrome-Lion.
morrita@google.com [Thu, 15 Mar 2012 06:31:12 +0000 (06:31 +0000)]
Unreviewed expectation update for Chrome-Lion.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/81193> Ensure libWebCoreTestSupport.dylib's library identifier...
mrowe@apple.com [Thu, 15 Mar 2012 06:19:41 +0000 (06:19 +0000)]
<webkit.org/b/81193> Ensure libWebCoreTestSupport.dylib's library identifier is set appropriately for all configurations.

Reviewed by Dan Bernstein.

* Configurations/WebCoreTestSupport.xcconfig: Switch to setting DYLIB_INSTALL_NAME_BASE
rather than LD_DYLIB_INSTALL_NAME. The latter is derived from the former. Ensure that
DYLIB_INSTALL_NAME_BASE is also set for the Production configuration.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAXDescription for ARIA role contentinfo incorrect
cfleizach@apple.com [Thu, 15 Mar 2012 06:01:42 +0000 (06:01 +0000)]
AXDescription for ARIA role contentinfo incorrect
https://bugs.webkit.org/show_bug.cgi?id=78967

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/aria-grouping-roles.html

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::AXARIAContentGroupText):

LayoutTests:

* platform/mac/accessibility/aria-grouping-roles-expected.txt:
* platform/mac/accessibility/aria-grouping-roles.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed expectation update.
morrita@google.com [Thu, 15 Mar 2012 05:19:58 +0000 (05:19 +0000)]
Unreviewed expectation update.

* platform/chromium-win-xp/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
* platform/chromium/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Renamed from LayoutTests/platform/chromium-win/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt.
* platform/win/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: ARIA tables need to support selected rows attribute/select rows changed notification
cfleizach@apple.com [Thu, 15 Mar 2012 05:12:37 +0000 (05:12 +0000)]
AX: ARIA tables need to support selected rows attribute/select rows changed notification
https://bugs.webkit.org/show_bug.cgi?id=79821

Reviewed by Beth Dakin.

Source/WebCore:

Test: platform/mac/accessibility/selected-rows-table.html

* accessibility/AccessibilityARIAGrid.h:
(WebCore::AccessibilityARIAGrid::isMultiSelectable):
(AccessibilityARIAGrid):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::observableObject):
(WebCore):
* accessibility/AccessibilityTableRow.h:
(AccessibilityTableRow):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

Tools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(rowAtIndexCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
* DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
(AccessibilityUIElement::rowAtIndex):
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::rowAtIndex):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::rowAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::rowAtIndex):

LayoutTests:

* platform/mac/accessibility/selected-rows-table-expected.txt: Added.
* platform/mac/accessibility/selected-rows-table.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid StringImpl::getData16SlowCase() when sorting array
benjamin@webkit.org [Thu, 15 Mar 2012 05:10:06 +0000 (05:10 +0000)]
Avoid StringImpl::getData16SlowCase() when sorting array
https://bugs.webkit.org/show_bug.cgi?id=81070

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-14
Reviewed by Geoffrey Garen.

The function codePointCompare() is used intensively when sorting strings.
This patch improves its performance by:
-Avoiding character conversion.
-Inlining the function.

This makes Peacekeeper's arrayCombined test 30% faster.

* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
(WTF):
(WTF::codePointCompare):
(WTF::codePointCompare8):
(WTF::codePointCompare16):
(WTF::codePointCompare8To16):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPlatforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query...
jamesr@google.com [Thu, 15 Mar 2012 05:07:20 +0000 (05:07 +0000)]
Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID
https://bugs.webkit.org/show_bug.cgi?id=81187

Reviewed by Simon Fraser.

* dom/Document.cpp:
(WebCore::Document::webkitRequestAnimationFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agojava/java-and-plugins.html test failing
andersca@apple.com [Thu, 15 Mar 2012 04:39:37 +0000 (04:39 +0000)]
java/java-and-plugins.html test failing
https://bugs.webkit.org/show_bug.cgi?id=81188
<rdar://problem/11048657>

Reviewed by Sam Weinig.

Source/WebKit/mac:

When we're marshaling JSObjects that wrap plug-in objects, make sure to check that the
current plug-in instance is the same as the plug-in instance the object came from and don't
pass the unwrapped object ID if that is the case.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::getObjectID):
(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
* Plugins/Hosted/ProxyInstance.h:
(ProxyInstance):
(WebKit::ProxyInstance::instanceProxy):

Source/WebKit2:

When we're marshaling NPObjects that wrap plug-in objects, make sure to check that the
current plug-in instance is the same as the plug-in instance the object came from and don't
pass the unwrapped object ID if that is the case.

* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::remoteNPObjectID):
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):

LayoutTests:

Remove part of this test that tested trying to call a java method on an NPObject; on Snow Leopard
and newer the Java plug-in is also a NPAPI plug-in so the two removed tests would fail.

* java/java-and-plugins-expected.txt:
* java/java-and-plugins.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: embedded attachments do not report their parents correctly
cfleizach@apple.com [Thu, 15 Mar 2012 04:18:30 +0000 (04:18 +0000)]
AX: embedded attachments do not report their parents correctly
https://bugs.webkit.org/show_bug.cgi?id=80132

When a WebHTMLView has embedded attachments in it, the AXParent of those attachments is wrong.
It usually points to the AXScrollView of the web area. That's because there has been no way for WebCore to
communicate that this attachment view should actually make believe that it's parent is within the WebCore AX tree.

We can fix that by overriding the AXParent in overriden attributes for items that are attachments.

Reviewed by Beth Dakin.

Not able to construct a layout test because the problem only manifests itself when an AX client connects to WebKit
through the IPC mechanism.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::detachFromParent):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::overrideAttachmentParent):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::overrideAttachmentParent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove ContainerNode's collectNodes() performance
rniwa@webkit.org [Thu, 15 Mar 2012 03:51:19 +0000 (03:51 +0000)]
Improve ContainerNode's collectNodes() performance
https://bugs.webkit.org/show_bug.cgi?id=80706

Reviewed by Antti Koivisto.

Bump up the size of stack allocated buffer from 1 to 11. According to the rough study I conducted,
this would cover 99.5% of all node collection.

Note: the actual code change was made in r110797 but I somehow mangled my patches.

* dom/ContainerNode.cpp:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup semicolons in IDLs
commit-queue@webkit.org [Thu, 15 Mar 2012 03:43:33 +0000 (03:43 +0000)]
Cleanup semicolons in IDLs
https://bugs.webkit.org/show_bug.cgi?id=81129

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-03-14
Reviewed by Kentaro Hara.

No tests. No change in behavior.

* svg/SVGAnimateColorElement.idl:
* svg/SVGAnimateElement.idl:
* svg/SVGAnimateTransformElement.idl:
* svg/SVGAnimatedRect.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac rebaseline after r110667.
jberlin@webkit.org [Thu, 15 Mar 2012 03:29:07 +0000 (03:29 +0000)]
Mac rebaseline after r110667.

* platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] More compositing baseline updates. Unreviewed.
jamesr@google.com [Thu, 15 Mar 2012 03:11:49 +0000 (03:11 +0000)]
[chromium] More compositing baseline updates. Unreviewed.

* platform/chromium-mac-snowleopard/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-size-change-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/reflection-ordering-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/reflection-positioning-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/reflection-positioning2-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png: Added.
* platform/chromium-mac/compositing/culling/filter-occlusion-blur-expected.png:
* platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
* platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.png:
* platform/chromium-mac/compositing/repaint/opacity-between-absolute-expected.png:
* platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png:
* platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac Intel WebKit2 Release Tests] canvas/philip/tests/2d.text.draw.fontface.notinpage...
jberlin@webkit.org [Thu, 15 Mar 2012 03:08:37 +0000 (03:08 +0000)]
[Mac Intel WebKit2 Release Tests] canvas/philip/tests/2d.text.draw.fontface.notinpage.html
failing since r83550
https://bugs.webkit.org/show_bug.cgi?id=58332

Add expected failing results to get the bots green.

* platform/mac-wk2/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline some mac canvas philip expected failing results to get the bots green.
jberlin@webkit.org [Thu, 15 Mar 2012 03:08:29 +0000 (03:08 +0000)]
Rebaseline some mac canvas philip expected failing results to get the bots green.

* platform/mac/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocanvas/philip/tests/2d.gradient.interpolate.colouralpha failing on Lion Intel Debug...
jberlin@webkit.org [Thu, 15 Mar 2012 03:08:22 +0000 (03:08 +0000)]
canvas/philip/tests/2d.gradient.interpolate.colouralpha failing on Lion Intel Debug (WK1 and WK2)
https://bugs.webkit.org/show_bug.cgi?id=81185

Land some expected failing results to get the bots green.

* platform/mac/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ShadowRoot.activeElement return null if it does not contain a focused element.
hayato@chromium.org [Thu, 15 Mar 2012 03:06:49 +0000 (03:06 +0000)]
Make ShadowRoot.activeElement return null if it does not contain a focused element.
https://bugs.webkit.org/show_bug.cgi?id=81097

Reviewed by Dimitri Glazkov.

Source/WebCore:

* dom/TreeScope.cpp:
(WebCore::TreeScope::activeElement):

LayoutTests:

* fast/dom/shadow/shadow-root-activeElement-expected.txt:
* fast/dom/shadow/shadow-root-activeElement.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove nodesFromRect tests from the skip list
commit-queue@webkit.org [Thu, 15 Mar 2012 02:49:30 +0000 (02:49 +0000)]
[EFL] Remove nodesFromRect tests from the skip list
https://bugs.webkit.org/show_bug.cgi?id=81116

Support for internals.nodesFromRect was recently added for the EFL
port. These tests are now fine.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-14
Reviewed by Kenneth Rohde Christiansen.

* platform/efl/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow per-script font settings to be specified in layout tests
commit-queue@webkit.org [Thu, 15 Mar 2012 02:12:28 +0000 (02:12 +0000)]
Allow per-script font settings to be specified in layout tests
https://bugs.webkit.org/show_bug.cgi?id=78184

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-14
Reviewed by Hajime Morita.

This adds per-script font settings to InternalSettings, so it can be used in layout tests instead of
the per-script font settings support in DumpRenderTree overridePreference, which has only been implemented
for Chromium so far.

.:

* Source/autotools/symbols.filter: Added symbols.

Source/WebCore:

Test: changed fast/text/international/locale-sensitive-fonts.html to use InternalSettings
instead of overridePreference.

* WebCore.exp.in: Added symbols.
* platform/text/LocaleToScriptMapping.h: Added scriptNameToCode used by InternalSettings.
(WebCore):
* platform/text/LocaleToScriptMappingDefault.cpp:
(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):
* platform/text/LocaleToScriptMappingICU.cpp:
(WebCore::scriptNameToCode):
(WebCore):
* testing/InternalSettings.cpp: Added per-script font settings.
(WebCore):
(WebCore::setFontFamily):
(WebCore::InternalSettings::setStandardFontFamily):
(WebCore::InternalSettings::setSerifFontFamily):
(WebCore::InternalSettings::setSansSerifFontFamily):
(WebCore::InternalSettings::setFixedFontFamily):
(WebCore::InternalSettings::setCursiveFontFamily):
(WebCore::InternalSettings::setFantasyFontFamily):
(WebCore::InternalSettings::setPictographFontFamily):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

* win/WebKit2.def: Added symbols.
* win/WebKit2CFLite.def: Added symbols.

LayoutTests:

* fast/text/international/locale-sensitive-fonts-expected.html: Added. Changed test to a reftest.
* fast/text/international/locale-sensitive-fonts.html: Changed to use InternalSettings.
* platform/chromium-win/fast/text/international/locale-sensitive-fonts-expected.png: Removed.
* platform/chromium/fast/text/international/locale-sensitive-fonts-expected.png: Removed.
* platform/chromium/fast/text/international/locale-sensitive-fonts-expected.txt: Removed.
* platform/efl/Skipped: Removed locale-sensitive-fonts.html since it no longer relies on overridePreference.
* platform/gtk-wk2/Skipped: Ditto.
* platform/gtk/Skipped: Ditto.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.
* platform/wincairo/Skipped: Ditto.
* platform/wk2/Skipped: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove obsolete constructors of CSSPrimitiveValue class.
commit-queue@webkit.org [Thu, 15 Mar 2012 02:09:26 +0000 (02:09 +0000)]
Remove obsolete constructors of CSSPrimitiveValue class.
https://bugs.webkit.org/show_bug.cgi?id=80971

Remove constructors of CSSPrimitiveValue that can't be
reached.

Patch by Kwonjin Jeong <gram@company100.net> on 2012-03-14
Reviewed by Andreas Kling.

* css/CSSPrimitiveValueMappings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Make sure WebPage and BackingStore don't crash without a Window
commit-queue@webkit.org [Thu, 15 Mar 2012 01:48:25 +0000 (01:48 +0000)]
[BlackBerry] Make sure WebPage and BackingStore don't crash without a Window
https://bugs.webkit.org/show_bug.cgi?id=81099

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-14
Reviewed by Rob Buis.

Also rename the "compositing/blitting to main window" variables to
instead refer to OpenGL compositing. The code paths it triggers are
related to the BackingStore using OpenGL compositing, and can be useful
even when there's no window.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::isOpenGLCompositing):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToBackSurfaceOfWindow):
(BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
(BlackBerry::WebKit::BackingStorePrivate::blendCompositingSurface):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::checkerWindow):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
(BlackBerry::WebKit::BackingStorePrivate::drawSubLayers):
(BlackBerry::WebKit::BackingStorePrivate::surfaceSize):
(BlackBerry::WebKit::BackingStorePrivate::buffer):
* Api/BackingStore_p.h:
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didPluginEnterFullScreen):
(BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
(BlackBerry::WebKit::WebPagePrivate::drawLayersOnCommit):
(BlackBerry::WebKit::WebPagePrivate::drawSubLayers):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::windowRect):
(WebCore::ChromeClientBlackBerry::screenToWindow):
(WebCore::ChromeClientBlackBerry::windowToScreen):
* WebKitSupport/GLES2Context.cpp:
(BlackBerry::WebKit::GLES2Context::GLES2Context):
* WebKitSupport/TouchEventHandler.h:
* WebKitSupport/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::setBackingStoreUsesOpenGL):
(BlackBerry::WebKit::WebPageCompositor::drawLayers):
* WebKitSupport/WebPageCompositor.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix memory allocation failed by fastmalloc
commit-queue@webkit.org [Thu, 15 Mar 2012 01:30:40 +0000 (01:30 +0000)]
Fix memory allocation failed by fastmalloc
https://bugs.webkit.org/show_bug.cgi?id=79614

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-14
Reviewed by Geoffrey Garen.

Memory allocation failed even if the heap grows successfully.
It is wrong to get the span only from the large list after the heap grows,
because new span could be added in the normal list.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::New):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple...
msaboff@apple.com [Thu, 15 Mar 2012 01:28:18 +0000 (01:28 +0000)]
REGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple tests to "crash" on the Lion Intel Debug Bots
https://bugs.webkit.org/show_bug.cgi?id=80993

Reviewed by Mark Rowe.

Moved $(BUILT_PRODUCTS_DIR)/usr/local/include to the front of HEADER_SEARCH_PATH
to fix builds given the wtf move.

Source/WebKit/mac:

* Configurations/WebKit.xcconfig:

Source/WebKit2:

* Configurations/BaseTarget.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop shadowing the argument to drawRect: with a local variable.
aestes@apple.com [Thu, 15 Mar 2012 01:20:59 +0000 (01:20 +0000)]
Stop shadowing the argument to drawRect: with a local variable.

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit the extra logic out of RenderBlock::updateFirstLetter
igor.o@sisa.samsung.com [Thu, 15 Mar 2012 01:18:52 +0000 (01:18 +0000)]
Split the extra logic out of RenderBlock::updateFirstLetter
https://bugs.webkit.org/show_bug.cgi?id=80772

Reviewed by Julien Chaffraix.

No change in behavior expected.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
(WebCore::RenderBlock::updateFirstLetter):
(WebCore):
* rendering/RenderBlock.h:
(RenderBlock):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout/floats.html should be runnable by run-perf-tests
achicu@adobe.com [Thu, 15 Mar 2012 01:07:27 +0000 (01:07 +0000)]
Layout/floats.html should be runnable by run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=77051

Reviewed by Ryosuke Niwa.

I've split Layout/floats.html into multiple tests for each button in the original manual test.
Some tests take longer to run and I've changed the number of iterations, so that each tests finishes under 30s per run.

* DOM/resources/dom-perf.js:
* Layout/floats.html: Removed.
* Layout/floats_100_100.html: Added.
* Layout/floats_100_100_nested.html: Added.
* Layout/floats_20_100.html: Added.
* Layout/floats_20_100_nested.html: Added.
* Layout/floats_2_100.html: Added.
* Layout/floats_2_100_nested.html: Added.
* Layout/floats_50_100.html: Added.
* Layout/floats_50_100_nested.html: Added.
* Layout/resources/floats.css: Added.
(.container):
(.float):
(.big):
(.float-end):
* Layout/resources/floats.js: Added.
(.):
* Skipped:
* resources/runner.js:
(PerfTestRunner.resetRandomSeed):
(PerfTestRunner.random):
(Math.random):
    Moved the Math.random to runner.js to be used by all tests.
    Added resetRandomSeed to bring the randomizer back to initial seed.
    It is useful to get the same results at every run and minimize the
    differences between runs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build.
andersca@apple.com [Thu, 15 Mar 2012 00:44:21 +0000 (00:44 +0000)]
Fix build.

* html/track/TextTrackList.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofullscreen/video-controls-drag.html failing on Mac
jberlin@webkit.org [Thu, 15 Mar 2012 00:34:36 +0000 (00:34 +0000)]
fullscreen/video-controls-drag.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=81176

Land expected failing results to get the bots green.

* platform/mac/fullscreen/video-controls-drag-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
rniwa@webkit.org [Thu, 15 Mar 2012 00:26:28 +0000 (00:26 +0000)]
Build fix.

* dom/DynamicNodeList.h:
(DynamicSubtreeNodeList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago(register|unregister)DynamicSubtreeNodeList should be called only for labels and...
rniwa@webkit.org [Thu, 15 Mar 2012 00:10:55 +0000 (00:10 +0000)]
(register|unregister)DynamicSubtreeNodeList should be called only for labels and regions node lists
https://bugs.webkit.org/show_bug.cgi?id=80900

Reviewed by Antti Koivisto.

Cleaned up invalidation code for dynamic node lists. It seems like the existing code was utterly confused
about the lifetime of node lists and caches within them. First, register/unregsiterDynamicSubtreeNodeList
are called for all dynamic node lists even though it's only useful for labels and region node lists since
it's a mechanism to allow node lists to be invalidated at a node to which the node list doesn't belong.

Second, some node lists had dedicated member functions on Node to explicitly invalidate caches in
parsedAttribute. However, this is redundant because invalidateNodeListsCacheAfterAttributeChanged should be
able to invalidate caches when the attribute value changes. This patch gets rid of the last instance of such
function in HTMLLabelElement.

And finally, this patch restricts the callers of DynamicSubtreeNodeList::invalidateCache to be member
functions of NodeListsNodeData (now friends of DynamicSubtreeNodeList) to allow futher refactoring.

* dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Don't register the node list since it's only
useful for labels and region node lists.
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList): Ditto.
* dom/DynamicNodeList.h:
(DynamicSubtreeNodeList):
* dom/Node.cpp:
(WebCore):
(WebCore::Node::registerDynamicSubtreeNodeList): The comment about now we have to invalidate caches
when there had no caches is incorrect because registerDynamicSubtreeNodeList is called when a node list
is initially created. Also, if the tree scope didn't have any caches, then this is the first node list
to be added to the list, so there's no point in calling InvalidateCaches (no-op).
(WebCore::Node::unregisterDynamicSubtreeNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Take care of "for" content attribute.
Also remove the redundant call to removeNodeListCacheIfPossible since we only invalidates node lists
and never remove entries from NodeListsNodeData in this function.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): The call to removeNodeListCacheIfPossible
is also redundant here. Also removed the invalidation of m_listsWithCaches since it's already done in
invalidateCaches via invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCaches): Removed the invalidation of m_labelsNodeListCache. It's
done in invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Invalidate
m_listsInvalidatedAtDocument, which is renamed from m_listsWithCaches.
(WebCore::NodeListsNodeData::isEmpty):
* dom/Node.h:
(Node):
* dom/NodeRareData.h:
(NodeListsNodeData):
* html/HTMLLabelElement.cpp:
(WebCore): Removed parseAttribute since the invalidation labels node list is now done by
invalidateNodeListsCacheAfterAttributeChanged and invalidateNodeListsCacheAfterChildrenChanged.
* html/HTMLLabelElement.h:
(HTMLLabelElement):
* html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::LabelsNodeList):
(WebCore::LabelsNodeList::~LabelsNodeList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore fun with repainting-after-animation-element-removal. These
abarth@webkit.org [Thu, 15 Mar 2012 00:10:30 +0000 (00:10 +0000)]
More fun with repainting-after-animation-element-removal.  These
results differ by only one pixel.

* platform/chromium-linux/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNRWT should respect --additional-platform-directory's Skipped list
timothy_horton@apple.com [Thu, 15 Mar 2012 00:10:02 +0000 (00:10 +0000)]
NRWT should respect --additional-platform-directory's Skipped list
https://bugs.webkit.org/show_bug.cgi?id=81172

Reviewed by Timothy Hatcher.

Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
from said path are already used, but the Skipped file is ignored.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(test_skipped_file_search_paths):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix a few more compositing baselines. Unreviewed.
jamesr@google.com [Thu, 15 Mar 2012 00:08:34 +0000 (00:08 +0000)]
[chromium] Fix a few more compositing baselines. Unreviewed.

* platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
* platform/chromium-win/compositing/culling/filter-occlusion-blur-expected.png:
* platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd some chromium-mac-leopard overrides for tests I rebaselined earlier.
abarth@webkit.org [Thu, 15 Mar 2012 00:07:49 +0000 (00:07 +0000)]
Add some chromium-mac-leopard overrides for tests I rebaselined earlier.

* platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRun cacheFlush page by page to assure of flushing all the requested ranges
commit-queue@webkit.org [Thu, 15 Mar 2012 00:06:07 +0000 (00:06 +0000)]
Run cacheFlush page by page to assure of flushing all the requested ranges
https://bugs.webkit.org/show_bug.cgi?id=77712

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-14
Reviewed by Geoffrey Garen.

Current MetaAllocator concept, always coalesces adjacent free spaces,
doesn't meet memory management of Linux kernel.
In a certain case Linux kernel doesn't regard contiguous virtual memory areas as one but two.
Therefore cacheFlush page by page guarantees a flush-requested range.

* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing image baselines for new test added in <http://trac.webkit.org/changeset...
abarth@webkit.org [Thu, 15 Mar 2012 00:02:54 +0000 (00:02 +0000)]
Add missing image baselines for new test added in <trac.webkit.org/changeset/110769>.

* platform/chromium-linux/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/chromium-mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/chromium-win/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/chromium/fast/css/pseudo-first-line-border-width-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110565.
commit-queue@webkit.org [Thu, 15 Mar 2012 00:02:18 +0000 (00:02 +0000)]
Unreviewed, rolling out r110565.
http://trac.webkit.org/changeset/110565
https://bugs.webkit.org/show_bug.cgi?id=81173

chromium deps are now far enough along that the original cl
should work (Requested by thakis on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

* WebCore.gyp/mac/adjust_visibility.sh:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110783.
ojan@chromium.org [Thu, 15 Mar 2012 00:01:55 +0000 (00:01 +0000)]
Unreviewed, rolling out r110783.
http://trac.webkit.org/changeset/110783
https://bugs.webkit.org/show_bug.cgi?id=81054

Caused existing test expectation lines to expand to one for
each test configuration.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.has_warnings):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_macro_overrides):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._save_baseline):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_tests_to_update):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110641.
abarth@webkit.org [Wed, 14 Mar 2012 23:57:19 +0000 (23:57 +0000)]
Unreviewed, rolling out r110641.
http://trac.webkit.org/changeset/110641
https://bugs.webkit.org/show_bug.cgi?id=81170

Causes an ASAN failure (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

Source/WebCore:

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Copied from Source/WebCore/bindings/v8/custom/V8StyleSheetCustom.cpp.
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
(WebCore):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.cpp:
* html/track/TextTrackList.idl:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed. Update many compositing baselines and expectations now that...
jamesr@google.com [Wed, 14 Mar 2012 23:54:07 +0000 (23:54 +0000)]
[chromium] Unreviewed. Update many compositing baselines and expectations now that one major cause of flake is
fixed by r110741.

Filelist trimmed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate chromium-mac-lion expectations after <http://trac.webkit.org/changeset/110763>.
abarth@webkit.org [Wed, 14 Mar 2012 23:48:26 +0000 (23:48 +0000)]
Update chromium-mac-lion expectations after <trac.webkit.org/changeset/110763>.

* platform/chromium-mac/media/audio-repaint-expected.png: Added.
* platform/chromium-mac/media/audio-repaint-expected.txt: Added.
* platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSeparate NOTIFICATIONS and LEGACY_NOTIFICATIONS
jonlee@apple.com [Wed, 14 Mar 2012 23:41:04 +0000 (23:41 +0000)]
Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
https://bugs.webkit.org/show_bug.cgi?id=80922
<rdar://problem/11035082>

Reviewed by Jian Li.

You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
new API. Therefore, APIs that are common between the two will have:
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)

This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.

Source/WebCore:

* bindings/scripts/InFilesCompiler.pm: Update the script to handle the "|" flag in a conditional.
(preferredConditional):
(conditionalStringFromAttributeValue):
(generateInterfacesHeader):
(generateHeadersHeader):

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCore.exp.in:
* bindings/cpp/WebDOMEventTarget.cpp:
(toWebKit):
* bindings/js/JSDesktopNotificationsCustom.cpp:
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
* dom/EventTargetFactory.in:
* notifications/Notification.cpp:
* notifications/Notification.h:
* notifications/Notification.idl:
* notifications/NotificationCenter.cpp:
* notifications/NotificationCenter.h:
* notifications/NotificationCenter.idl:
* notifications/NotificationContents.h:
* notifications/NotificationController.cpp:
* notifications/NotificationController.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore):
* page/DOMWindow.h:
(DOMWindow):
* page/DOMWindow.idl:
* page/Frame.cpp:
(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::~WorkerContext):
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
* workers/WorkerThread.h:
(WorkerThread):

Source/WebKit/blackberry:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/NotificationPresenterImpl.cpp:
* WebCoreSupport/NotificationPresenterImpl.h:

Source/WebKit/chromium:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* src/AssertMatchingEnums.cpp:
* src/NotificationPresenterImpl.cpp:
* src/NotificationPresenterImpl.h:
* src/WebNotification.cpp:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableNotifications):
(WebKit::WebRuntimeFeatures::isNotificationsEnabled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

Source/WebKit/efl:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* WebCoreSupport/NotificationPresenterClientEfl.cpp:
* WebCoreSupport/NotificationPresenterClientEfl.h:

Source/WebKit/mac:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/WebNotificationClient.h:
* WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::notificationControllerDestroyed):
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):
* WebView/WebNotification.mm:
(-[WebNotification title]):
(-[WebNotification body]):
(-[WebNotification replaceID]):
(-[WebNotification origin]):
(-[WebNotification notificationID]):
(-[WebNotification dispatchShowEvent]):
(-[WebNotification dispatchCloseEvent]):
(-[WebNotification dispatchClickEvent]):
(-[WebNotification dispatchErrorEvent]):
* WebView/WebNotificationInternal.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):
(QWebPage::setFeaturePermission):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::dumpNotification):
(DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore):
(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::openerPageUrl):
(WebCore::NotificationWrapper::notificationClicked):
(WebCore::NotificationWrapper::notificationClosed):
* WebCoreSupport/NotificationPresenterClientQt.h:
(WebCore):

Source/WebKit/win:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
* WebCoreSupport/WebDesktopNotificationsDelegate.h:

Source/WebKit/wince:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):

Source/WebKit2:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit):
(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::cancelRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit):
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):
(WebKit::WebNotificationManager::didCloseNotifications):
* WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
* WebProcess/WebCoreSupport/WebNotificationClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
(WebProcess):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):
* DumpRenderTree/chromium/NotificationPresenter.cpp:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetTestController):
* DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
(DRTDesktopNotificationPresenter::checkNotificationPermission):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHave webkit-patch rebaseline-test update test_expectations.txt
ojan@chromium.org [Wed, 14 Mar 2012 23:36:53 +0000 (23:36 +0000)]
Have webkit-patch rebaseline-test update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81054

Reviewed by Dirk Pranke.

This will allow us to use the All Failures tab in garden-o-matic
to rebaseline tests without making test_expectations.txt stale.

It's conservative and only removes lines if the test is
not flaky and fails in a way the rebaseline would fix (e.g.
CRASH/TIMEOUT will not be touched).

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.remove_configuration_from_test):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._is_supported_port):
(RebaselineTest):
(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r110744.
abarth@webkit.org [Wed, 14 Mar 2012 23:34:13 +0000 (23:34 +0000)]
Unreviewed, rolling out r110744.
http://trac.webkit.org/changeset/110744
https://bugs.webkit.org/show_bug.cgi?id=81168

Causes many WebAudio tests to crash in debug (Requested by
abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

* platform/audio/Biquad.cpp:
(WebCore::Biquad::process):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Move code common to both ProxyAuthentication and Authentication context...
commit-queue@webkit.org [Wed, 14 Mar 2012 23:29:08 +0000 (23:29 +0000)]
[Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class
https://bugs.webkit.org/show_bug.cgi?id=80627

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-14
Reviewed by Kenneth Rohde Christiansen.

No impact to QML API.

* UIProcess/qt/QtDialogRunner.cpp:
(BaseAuthenticationContextObject):
(BaseAuthenticationContextObject::BaseAuthenticationContextObject):
(HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::HttpAuthenticationDialogContextObject):
(HttpAuthenticationDialogContextObject::realm):
(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(QtDialogRunner::initForAuthentication):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWith tiled drawing enabled, clicking a link to a PDF causes a cross-fade
andersca@apple.com [Wed, 14 Mar 2012 23:27:17 +0000 (23:27 +0000)]
With tiled drawing enabled, clicking a link to a PDF causes a cross-fade
https://bugs.webkit.org/show_bug.cgi?id=79247
<rdar://problem/10910808>

Reviewed by Sam Weinig.

Instead of creating a new CALayer for the WKView when we're in tiled mode, re-use the existing layer that AppKit makes for us.
This way, we won't get any implicit animations when we change layer properties (such as sublayers in this case).

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView wantsUpdateLayer]):
(-[WKView updateLayer]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed. Update a few compositing baselines for tests that were marked...
jamesr@google.com [Wed, 14 Mar 2012 23:25:41 +0000 (23:25 +0000)]
[chromium] Unreviewed. Update a few compositing baselines for tests that were marked flaky.

* platform/chromium-mac-snowleopard/compositing/masks/masked-ancestor-expected.png: Added.
* platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-mac/compositing/reflections/masked-reflection-on-composited-expected.png:
* platform/chromium-mac/compositing/reflections/reflection-positioning2-expected.png:
* platform/chromium-win/compositing/masks/masked-ancestor-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPromote a number of chromium-mac-snowleopard results to chromium-mac.
abarth@webkit.org [Wed, 14 Mar 2012 23:21:07 +0000 (23:21 +0000)]
Promote a number of chromium-mac-snowleopard results to chromium-mac.
Also, fix a wrong chromium-mac-leopard expectation.  (The new
expectation show the drop shadow, like other platforms.)

* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Removed.
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png: Added.
* platform/chromium-mac/css3/filters/filtered-compositing-descendant-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
jberlin@webkit.org [Wed, 14 Mar 2012 23:14:14 +0000 (23:14 +0000)]
Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
https://bugs.webkit.org/show_bug.cgi?id=81167

Reviewed by Sam Weinig.

Do not use 0 as a key in a HashMap.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
cacheLayoutTestControllerCallback uses the enum as keys for the callback map.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/11045584> and https://bugs.webkit.org/show_bug.cgi?id=81166 Repro...
beidson@apple.com [Wed, 14 Mar 2012 23:08:51 +0000 (23:08 +0000)]
<rdar://problem/11045584> and https://bugs.webkit.org/show_bug.cgi?id=81166 Repro crash in compositing/iframes/page-cache-layer-tree.html

Reviewed by Sam Weinig.

No new tests. (Discovered from and covered by existing test)

ScriptCachedFrameData doesn't need to keep a DOMWindow:
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
* bindings/js/ScriptCachedFrameData.h:
(ScriptCachedFrameData):

CachedFrame should grab it off the Frame directly and store it locally:
* history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
* history/CachedFrame.h:
(WebCore::CachedFrameBase::domWindow):
(CachedFrameBase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoI've already updated the baselines for this test.
abarth@webkit.org [Wed, 14 Mar 2012 23:01:05 +0000 (23:01 +0000)]
I've already updated the baselines for this test.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate baselines for a number of svg/repaint tests and for some
abarth@webkit.org [Wed, 14 Mar 2012 22:58:38 +0000 (22:58 +0000)]
Update baselines for a number of svg/repaint tests and for some
tables/mozilla tests.  These results all appear to be correct.

* platform/chromium-linux-x86/tables/mozilla: Removed.
* platform/chromium-linux/svg/repaint/filter-repaint-expected.png: Added.
* platform/chromium-linux/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-linux/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/chromium-mac-leopard/svg/repaint/image-href-change-expected.png: Added.
* platform/chromium-mac-leopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-mac-leopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug53690-1-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
* platform/chromium-mac/svg/repaint/image-href-change-expected.png: Added.
* platform/chromium-mac/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Added.
* platform/chromium-mac/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-mac/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug53690-1-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Added.
* platform/chromium-win-vista/tables/mozilla/bugs: Removed.
* platform/chromium-win/svg/repaint/filter-repaint-expected.png: Added.
* platform/chromium-win/svg/repaint/filter-repaint-expected.txt: Added.
* platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.png: Added.
* platform/chromium-win/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
* platform/chromium-win/svg/repaint/repainting-after-animation-element-removal-expected.png: Added.
* platform/chromium-win/tables/mozilla/bugs/bug86708-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug86708-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt: Added.
* platform/mac-snowleopard/svg/repaint/image-href-change-expected.png: Removed.
* platform/mac/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Added.
* svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphi...
jamesr@google.com [Wed, 14 Mar 2012 22:58:18 +0000 (22:58 +0000)]
[chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
https://bugs.webkit.org/show_bug.cgi?id=80523

Reviewed by Darin Fisher.

* public/WebViewClient.h:
(WebViewClient):
(WebKit::WebViewClient::createGraphicsContext3D):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofix negative flexing in auto sized columns
tony@chromium.org [Wed, 14 Mar 2012 22:56:15 +0000 (22:56 +0000)]
fix negative flexing in auto sized columns
https://bugs.webkit.org/show_bug.cgi?id=80069

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/columns-auto-size.html.

* rendering/RenderFlexibleBox.cpp:
(WebCore):
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Properly compute this for auto sizing columns. Previously, we would always return 0.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm): Drop an unnecessary check against undefined. isSpecified covers this for us.
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/columns-auto-size-expected.txt:
* css3/flexbox/columns-auto-size.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate baselines for these URL tests. These tests exist to document
abarth@webkit.org [Wed, 14 Mar 2012 22:44:28 +0000 (22:44 +0000)]
Update baselines for these URL tests.  These tests exist to document
differnces in behavior between KURL and GURL.

* platform/chromium-linux/fast/url/file-http-base-expected.txt: Added.
* platform/chromium-linux/fast/url/segments-expected.txt:
* platform/chromium-linux/fast/url/segments-from-data-url-expected.txt:
* platform/chromium-win/fast/url/file-http-base-expected.txt: Added.
* platform/chromium-win/fast/url/segments-expected.txt:
* platform/chromium-win/fast/url/segments-from-data-url-expected.txt:
* platform/chromium/fast/url/anchor-expected.txt: Added.
* platform/chromium/fast/url/file-http-base-expected.txt: Added.
* platform/chromium/fast/url/ipv4-expected.txt: Added.
* platform/chromium/fast/url/segments-expected.txt: Added.
* platform/chromium/fast/url/segments-from-data-url-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThese baselines all either look very similar to their expectations or
abarth@webkit.org [Wed, 14 Mar 2012 22:39:41 +0000 (22:39 +0000)]
These baselines all either look very similar to their expectations or
like improvements.

* platform/chromium-linux/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-mac-leopard/css1/box_properties/acid_test-expected.png: Added.
* platform/chromium-mac-leopard/css1/font_properties/font_family-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t1503-c522-font-family-00-b-expected.png: Added.
* platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-mac-leopard/fast/xsl/mozilla-tests-expected.txt: Added.
* platform/chromium-mac-snowleopard/css1/box_properties/acid_test-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/font_properties/font_family-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t09-c5526c-display-00-e-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png:
* platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-mac/css1/box_properties/acid_test-expected.png: Added.
* platform/chromium-mac/css1/font_properties/font_family-expected.png: Added.
* platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
* platform/chromium-mac/css1/text_properties/text_transform-expected.txt: Added.
* platform/chromium-mac/css2.1/t09-c5526c-display-00-e-expected.png: Added.
* platform/chromium-mac/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-win/css3/unicode-bidi-isolate-aharon-failing-expected.png: Added.
* platform/chromium-win/fast/xsl/transform-xhr-doc-expected.txt: Removed.
* platform/chromium/fast/xsl/transform-xhr-doc-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncorrect handling of sizes in "em" when first-line changes font size
commit-queue@webkit.org [Wed, 14 Mar 2012 22:24:38 +0000 (22:24 +0000)]
Incorrect handling of sizes in "em" when first-line changes font size
https://bugs.webkit.org/show_bug.cgi?id=79526

Patch by Grace Ku <gracek@codeaurora.org> on 2012-03-14
Reviewed by Eric Seidel.

Source/WebCore:

When a first-line pseudo class changes the font size, the "em" unit is handled incorrectly.
It uses the paragraph's original font size (the size of the rest of the paragraph) rather than
the font-size of the first-line of the paragraph.

This was corrected by checking if the InlineFlowBox was the first line using the existing
InlineFlowBox::isFirstLineStyle() function. The corrected behaviour matches Gecko and Presto.
Trident seems to get it half-wrong in the use case we are testing, painting the correct width for
the border but leaving the wrong amount of space.

The CSS specification doc at the time of this patch specifies that ':first-line' should only support
certain properties, though UAs may choose to apply more properties. Furthermore, the spec does not
define the exact rendering of all cases of ':first-line'. It notes that a more precise definition
may appear in future revisions.

Test: fast/css/pseudo-first-line-border-width.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):
(WebCore::RenderBoxModelObject::borderObscuresBackgroundEdge):
(WebCore::RenderBoxModelObject::borderObscuresBackground):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):

LayoutTests:

Checks that the width of the left-border of the span is the desired 10px
rather than 100px. The expect file is somewhat misleading since the computed
border width is still printed as 100px. The true test is in the position of the
RenderText box beside the left-border.

* fast/css/pseudo-first-line-border-width.html: Added.
* fast/css/pseudo-first-line-border-width-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate some compositing baselines. These look correct. They just differ in scrollba...
abarth@webkit.org [Wed, 14 Mar 2012 22:17:36 +0000 (22:17 +0000)]
Update some compositing baselines.  These look correct.  They just differ in scrollbars, etc.

* platform/chromium-mac-leopard/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac/compositing/direct-image-compositing-expected.png:
* platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
* platform/chromium-win/compositing/direct-image-compositing-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitTestRunner needs layoutTestController.displayInvalidatedRegion
jberlin@webkit.org [Wed, 14 Mar 2012 22:13:59 +0000 (22:13 +0000)]
WebKitTestRunner needs layoutTestController.displayInvalidatedRegion

Add a test that uses it to the wk2 Skipped list.

* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd results for transforms/3d/general/background-visibility-layers.html.
abarth@webkit.org [Wed, 14 Mar 2012 22:06:25 +0000 (22:06 +0000)]
Add results for transforms/3d/general/background-visibility-layers.html.

* platform/chromium-mac/transforms/3d: Added.
* platform/chromium-mac/transforms/3d/general: Added.
* platform/chromium-mac/transforms/3d/general/background-visibility-layers-expected.png: Added.
* platform/chromium-win/transforms/3d/general: Added.
* platform/chromium-win/transforms/3d/general/background-visibility-layers-expected.png: Added.
* platform/chromium/transforms: Added.
* platform/chromium/transforms/3d: Added.
* platform/chromium/transforms/3d/general: Added.
* platform/chromium/transforms/3d/general/background-visibility-layers-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the TextureMapper build for GTK+.
mrobinson@webkit.org [Wed, 14 Mar 2012 22:05:55 +0000 (22:05 +0000)]
Fix the TextureMapper build for GTK+.

No new tests. This is just a build fix.

* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/texmap/TextureMapper.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisplay attribute for video controls changed from display:block
commit-queue@webkit.org [Wed, 14 Mar 2012 22:05:07 +0000 (22:05 +0000)]
Display attribute for video controls changed from display:block
to display:-webkit-box. Tests need to be rebaselined.

https://bugs.webkit.org/show_bug.cgi?id=80727

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-03-14
Reviewed by Eric Carlson.

* platform/chromium-linux-x86/media/video-empty-source-expected.txt:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.txt:
* platform/chromium-mac-leopard/media/audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/video-empty-source-expected.txt:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt:
* platform/chromium-mac/fast/layers/video-layer-expected.txt:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/audio-repaint-expected.png: Added.
* platform/chromium-mac/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium/media/audio-repaint-expected.txt.
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-layout-direction-expected.png: Added.
* platform/chromium-mac/media/controls-strict-expected.png: Added.
* platform/chromium-mac/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-strict-expected.txt.
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.png: Added.
* platform/chromium-mac/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/controls-without-preload-expected.txt.
* platform/chromium-mac/media/media-controls-clone-expected.txt:
* platform/chromium-mac/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.txt.
* platform/chromium-mac/media/video-controls-rendering-expected.png: Added.
* platform/chromium-mac/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.txt.
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-playing-and-pause-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.png: Added.
* platform/chromium-mac/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/media/video-volume-slider-expected.txt.
* platform/chromium-mac/media/video-zoom-controls-expected.txt:
* platform/chromium-win-vista/media/video-empty-source-expected.txt:
* platform/chromium-win-xp/media/video-empty-source-expected.txt:
* platform/chromium-win/fast/layers/video-layer-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/audio-repaint-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/media-controls-clone-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-playing-and-pause-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/video-zoom-controls-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Menulist buttons have separators even when the theme turns them off
mrobinson@webkit.org [Wed, 14 Mar 2012 22:04:50 +0000 (22:04 +0000)]
[GTK] Menulist buttons have separators even when the theme turns them off
https://bugs.webkit.org/show_bug.cgi?id=80668

Reviewed by Daniel Bates.

No new tests. GTK+ theme differences are notoriously difficult
to test, because consistent results depend on having certain themes
and certain versions of themes installed.

Instead of using the GTK_TYPE_BUTTON and GTK_TYPE_SEPARATOR tags to get the
style context, use GTK_TYPE_COMBO_BOX which should provide more accurate theme settings.

* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::getComboBoxMetrics): Get metrics from a GTK_TYPE_COMBO_BOX style context.
(WebCore::RenderThemeGtk::paintMenuList): Get separator settings from the GTK_TYPE_COMBO_BOX style context.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement proper sub-pixel support in RenderFileUploadControl
leviw@chromium.org [Wed, 14 Mar 2012 22:02:00 +0000 (22:02 +0000)]
Implement proper sub-pixel support in RenderFileUploadControl
https://bugs.webkit.org/show_bug.cgi?id=80881

Reviewed by Dimitri Glazkov.

Correcting improper usage of LayoutUnits when interacting with the graphics context
and platform code. Specifically:
- pixel snapping the clip rect and paint offsets before sending values to the
  graphics context in paintObject.
- using on-screen (pixel snapped) values to pass off to platform code to determine
  the max length of the filename to be drawn.

No new tests. No change in behavior.

* rendering/RenderFileUploadControl.cpp:
(WebCore::nodeWidth):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Web Inspector: CRASH running $0, $1, etc before they are set
commit-queue@webkit.org [Wed, 14 Mar 2012 21:56:46 +0000 (21:56 +0000)]
[JSC] Web Inspector: CRASH running $0, $1, etc before they are set
https://bugs.webkit.org/show_bug.cgi?id=81082

Source/WebCore:

Don't return an invalid JSValue. Check if the ScriptValue
has no value and return undefined in that case.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.

Updated test: inspector/console/command-line-api.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject):

LayoutTests:

Test for an undefined inspectedObject.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-14
Reviewed by Pavel Feldman.

* inspector/console/command-line-api-expected.txt:
* inspector/console/command-line-api.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@110760 268f45cc-cd09-0410-ab3c-d52691b4dbfc