WebKit.git
9 years ago2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>
hamaji@chromium.org [Thu, 30 Dec 2010 09:25:40 +0000 (09:25 +0000)]
2010-12-30  Shinichiro Hamaji  <shinichiro.hamaji@gmail.com>

        Chromium test expectation update for media/video-element-other-namespace-crash.html

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-30 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 30 Dec 2010 08:29:04 +0000 (08:29 +0000)]
2010-12-30  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Skip media/video-element-other-namespace-crash.html, like other media tests on qt platform.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-30 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 30 Dec 2010 08:12:40 +0000 (08:12 +0000)]
2010-12-30  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
        https://bugs.webkit.org/show_bug.cgi?id=51692

        * svg/SVGLength.cpp:
        (WebCore::stringToLengthType):
        (WebCore::SVGLength::setValueAsString):
2010-12-30  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        Adding long float string to improve test coverage.
        https://bugs.webkit.org/show_bug.cgi?id=51692

        * svg/dom/length-list-parser.html:
        * svg/dom/length-list-parser-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-30 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 30 Dec 2010 08:02:08 +0000 (08:02 +0000)]
2010-12-30  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Create a helper function for finding descendent video elements for a node.
        https://bugs.webkit.org/show_bug.cgi?id=51696

        Test: media/video-element-other-namespace-crash.html

        * html/MediaDocument.cpp:
        (WebCore::descendentVideoElement): helper function.
        (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
        (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
2010-12-30  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests that we do not crash when trying to find video elements in the media document.
        https://bugs.webkit.org/show_bug.cgi?id=51696

        * media/video-element-other-namespace-crash-expected.txt: Added.
        * media/video-element-other-namespace-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 30 Dec 2010 07:55:26 +0000 (07:55 +0000)]
2010-12-29  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Add 'PASS' to layout test since test failing on chromium due to empty expectations.
        Filed webkit bug 51734 to track gtk test failure and skipping test for now.

        * fast/multicol/span/double-merge-anonymous-block-crash-expected.txt:
        * fast/multicol/span/double-merge-anonymous-block-crash.html:
        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 30 Dec 2010 07:41:53 +0000 (07:41 +0000)]
2010-12-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
        https://bugs.webkit.org/show_bug.cgi?id=51707

        This change brushes up storage agents + removes redundant InspectorBackend class.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::databaseForId):
        (WebCore::InjectedScriptHost::selectDatabase):
        (WebCore::InjectedScriptHost::selectDOMStorage):
        (WebCore::InjectedScriptHost::inspectorDOMAgent):
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp: Removed.
        * inspector/InspectorBackend.h: Removed.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::releaseFrontendLifetimeAgents):
        (WebCore::InspectorController::didUseDOMStorage):
        (WebCore::InspectorController::setInjectedScriptSource):
        (WebCore::InspectorController::dispatchOnInjectedScript):
        (WebCore::InspectorController::releaseWrapperObjectGroup):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMStorageAgent.cpp: Added.
        (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
        (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
        (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
        (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
        (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
        (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
        (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
        * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
        (WebCore::InspectorDOMStorageAgent::create):
        (WebCore::InspectorDOMStorageAgent::frontend):
        * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
        (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
        (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
        (WebCore::InspectorDatabaseAgent::executeSQL):
        (WebCore::InspectorDatabaseAgent::databaseForId):
        (WebCore::InspectorDatabaseAgent::selectDatabase):
        (WebCore::InspectorDatabaseAgent::clearFrontend):
        (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
        * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
        (WebCore::InspectorDatabaseAgent::create):
        (WebCore::InspectorDatabaseAgent::frontend):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
        (WebInspector.ScriptsPanel.prototype._toggleDebugging):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 30 Dec 2010 07:20:22 +0000 (07:20 +0000)]
2010-12-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE buildfix.

        * WinCELauncher/main.cpp: Add missing include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 30 Dec 2010 07:00:46 +0000 (07:00 +0000)]
2010-12-29  Dirk Schulze  <krit@webkit.org>

        Unreviewed fix of the misspelled email address in commit 74782.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Dirk Schulze <krit@wbekit.org>
krit@webkit.org [Thu, 30 Dec 2010 06:49:44 +0000 (06:49 +0000)]
2010-12-29  Dirk Schulze  <krit@wbekit.org>

        Reviewed by Darin Adler.

        Cleanup SVG code according to the webkit style rules 3
        https://bugs.webkit.org/show_bug.cgi?id=51490

        Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
        Just one file can't be fixed for check-webkit-style.
        * SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning

        No changes of functionality, so no new tests.

        * svg/SVGAllInOne.cpp:
        * svg/SVGImage.cpp:
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::setValue):
        * svg/SVGPolygonElement.h:
        * svg/SVGPolylineElement.h:
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
        (WebCore::SVGPreserveAspectRatio::transformRect):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::viewport):
        * svg/SVGSetElement.h:
        * svg/SVGStylable.h:
        (WebCore::SVGStylable::~SVGStylable):
        * svg/SVGStyledLocatableElement.h:
        (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
        (WebCore::SVGStyledLocatableElement::isStyledLocatable):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::isKnownAttribute):
        * svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::childShouldCreateRenderer):
        * svg/SVGTests.cpp:
        (WebCore::SVGTests::parseMappedAttribute):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::isKnownAttribute):
        * svg/SVGTextPathElement.cpp:
        * svg/SVGTextPathElement.h:
        * svg/SVGTitleElement.h:
        (WebCore::SVGTitleElement::rendererIsNeeded):
        * svg/SVGTransformDistance.cpp:
        (WebCore::SVGTransformDistance::SVGTransformDistance):
        (WebCore::SVGTransformDistance::scaledDistance):
        (WebCore::SVGTransformDistance::addSVGTransforms):
        (WebCore::SVGTransformDistance::addSVGTransform):
        (WebCore::SVGTransformDistance::addToSVGTransform):
        (WebCore::SVGTransformDistance::isZero):
        * svg/SVGTransformList.cpp:
        * svg/SVGURIReference.cpp:
        (WebCore::SVGURIReference::getTarget):
        * svg/SVGVKernElement.h:
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::parseViewSpec):
        * svg/SVGZoomAndPan.h:
        (WebCore::SVGZoomAndPan::SVGZoomAndPan):
        (WebCore::SVGZoomAndPan::~SVGZoomAndPan):
        (WebCore::SVGZoomAndPan::zoomAndPan):
        * svg/SVGZoomEvent.h:
        (WebCore::SVGZoomEvent::create):
        * svg/animation/SMILTime.cpp:
        (WebCore::operator*):
        * svg/animation/SMILTime.h:
        (WebCore::SMILTime::SMILTime):
        (WebCore::SMILTime::unresolved):
        (WebCore::SMILTime::indefinite):
        (WebCore::SMILTime::operator=):
        (WebCore::SMILTime::value):
        (WebCore::SMILTime::isFinite):
        (WebCore::SMILTime::isIndefinite):
        (WebCore::SMILTime::isUnresolved):
        (WebCore::operator==):
        (WebCore::operator!): new operator checks for 0 or infinite values.
        (WebCore::operator!=):
        (WebCore::operator>):
        (WebCore::operator<):
        (WebCore::operator>=):
        (WebCore::operator<=):
        * svg/animation/SMILTimeContainer.h:
        (WebCore::SMILTimeContainer::create):
        (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::ConditionEventListener::operator==):
        (WebCore::SVGSMILElement::repeatingDuration):
        (WebCore::SVGSMILElement::resolveInterval):
        (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
        * svg/animation/SVGSMILElement.h:
        (WebCore::SVGSMILElement::timeContainer):
        (WebCore::SVGSMILElement::intervalBegin):
        (WebCore::SVGSMILElement::intervalEnd):
        (WebCore::SVGSMILElement::previousIntervalBegin):
        (WebCore::SVGSMILElement::documentOrderIndex):
        (WebCore::SVGSMILElement::setDocumentOrderIndex):
        * svg/graphics/SVGImage.h:
        (WebCore::SVGImage::create):
        (WebCore::SVGImage::destroyDecodedData):
        (WebCore::SVGImage::decodedSize):
        (WebCore::SVGImage::frameAtIndex):
        * svg/graphics/filters/SVGFilterBuilder.h:
        (WebCore::SVGFilterBuilder::create):
        (WebCore::SVGFilterBuilder::lastEffect):
        (WebCore::SVGFilterBuilder::getEffectReferences):
        (WebCore::SVGFilterBuilder::addBuiltinEffects):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 30 Dec 2010 06:36:30 +0000 (06:36 +0000)]
2010-12-29  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        ASSERT(oldchild->parent() == owner) fails.
        https://bugs.webkit.org/show_bug.cgi?id=50480

        In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
        is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
        assertion failure when removeChildNode executes on the child(equal to prev or next).
        Fix a typo in canMergeContiguousAnonymousBlocks.

        Test: fast/multicol/span/double-merge-anonymous-block-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
        (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
2010-12-29  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Tests that we do not crash when merging anonymous blocks.
        https://bugs.webkit.org/show_bug.cgi?id=50480

        * fast/multicol/span/double-merge-anonymous-block-crash-expected.txt: Added.
        * fast/multicol/span/double-merge-anonymous-block-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 30 Dec 2010 06:03:56 +0000 (06:03 +0000)]
2010-12-29  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        svn-apply updates date of wrong change log entry for a change log diff that
        contains two consecutive entries with the same author and date
        https://bugs.webkit.org/show_bug.cgi?id=46061

        Fixes an issue where the date of the wrong change log entry may be modified.
        Moreover, changes fixChangeLogPatch() to move entries inserted earlier
        in a ChangeLog file to the top of the file.

        Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
        diff when it detects that the diff inserts a change log entry earlier in a
        ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
        change. With the advent of the commit-queue this functionality of bailing out
        and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
        Instead, we should always move the change log entry to the top of the ChangeLog file.

        A side-effect of this change is that setChangeLogDateAndReviewer() now updates
        the date line of the correct change log entry in a ChangeLog diff.

        * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.

        * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
          Updated the following unit tests now that we move entries inserted earlier to the top:
          - "fixChangeLogPatch: New entry inserted in middle."
            (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")

          - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
            (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")

        * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 30 Dec 2010 05:43:31 +0000 (05:43 +0000)]
2010-12-29  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Check SVG element type in FrameView::scrollToAnchor
        https://bugs.webkit.org/show_bug.cgi?id=51718

        Test: svg/custom/scroll-to-anchor-in-symbol.svg

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollToAnchor):
2010-12-29  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Check SVG element type in FrameView::scrollToAnchor
        https://bugs.webkit.org/show_bug.cgi?id=51718

        * svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
        * svg/custom/scroll-to-anchor-in-symbol.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Thu, 30 Dec 2010 04:07:01 +0000 (04:07 +0000)]
2010-12-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by Eric Seidel.

        [v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
        https://bugs.webkit.org/show_bug.cgi?id=51704

        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWindowShell.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 30 Dec 2010 03:54:50 +0000 (03:54 +0000)]
2010-12-29  Zhenyao Mo  <zmo@google.com>

        Reviewed by Eric Seidel.

        drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
        https://bugs.webkit.org/show_bug.cgi?id=51726

        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
        * fast/canvas/webgl/draw-elements-out-of-bounds.html: Add test cases to verify the behavior.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Konstantin Tokarev <annulen@yandex.ru>
commit-queue@webkit.org [Thu, 30 Dec 2010 03:16:59 +0000 (03:16 +0000)]
2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>

        Reviewed by Eric Seidel.

        [Qt] Fixed compatibility with gold linker on X11 platforms
        https://bugs.webkit.org/show_bug.cgi?id=51700

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        Linked TestNetscapePlugin with libX11 on Unix platforms

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Kenichi Ishibashi <bashi@google.com>
commit-queue@webkit.org [Thu, 30 Dec 2010 03:16:05 +0000 (03:16 +0000)]
2010-12-29  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Darin Adler.

        Use a HashMap for m_continuation to save memory
        https://bugs.webkit.org/show_bug.cgi?id=43716

        Saving memory consumption by applying a HashMap convention to
        continuation pointers of RenderInline and RenderBlock classes.

        * rendering/RenderBlock.cpp: Removed m_continuation.
        (WebCore::RenderBlock::RenderBlock):
        (WebCore::RenderBlock::destroy):
        (WebCore::RenderBlock::inlineElementContinuation):
        (WebCore::RenderBlock::blockElementContinuation):
        * rendering/RenderBlock.h: Removed m_continuation.
        * rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
        (WebCore::RenderBoxModelObject::destroy): Added an assertion.
        (WebCore::RenderBoxModelObject::continuation): Added.
        (WebCore::RenderBoxModelObject::setContinuation): Added.
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderInline.cpp: Removed m_continuation.
        (WebCore::RenderInline::RenderInline):
        (WebCore::RenderInline::destroy):
        (WebCore::RenderInline::inlineElementContinuation):
        * rendering/RenderInline.h: Removed m_continuation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Thu, 30 Dec 2010 02:08:39 +0000 (02:08 +0000)]
2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Darin Adler.

        Circular dependency in webkitpy.common.checkout.changelog module
        https://bugs.webkit.org/show_bug.cgi?id=50475

        Remove automatic import of api.Checkout module when any checkout/
        submodule is imported (e.g.: when checkout.scm.Git is imported).

        * Scripts/webkitpy/common/checkout/__init__.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 30 Dec 2010 01:16:51 +0000 (01:16 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Remove failing expectations for three Mac tests that no longer fail.
        Remove failing expectations for two canvas tests that no longer crash
        (r74561, which caused the failing assert, was rolled out with r74587).

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 30 Dec 2010 01:05:53 +0000 (01:05 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.
        fast/js/numeric-escapes-in-string-literals.html fails because V8 does
        not support ECMAScript strict mode.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 30 Dec 2010 01:00:07 +0000 (01:00 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Mark two more inspector tests
        as flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 30 Dec 2010 00:44:58 +0000 (00:44 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Mark a few more tests as flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 30 Dec 2010 00:14:49 +0000 (00:14 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        fast/canvas/shadow-offset-* are flaky when run in the GPU suite too.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 30 Dec 2010 00:11:19 +0000 (00:11 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Make expectation for http/tests/media/reload-after-dialog.html not
        trigger a duplication error for the debug Linux builder.

        Remove expectation for platform/gtk/fast/text/emphasis-overlap.html, it
        was removed in r74346.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.
barraclough@apple.com [Thu, 30 Dec 2010 00:00:24 +0000 (00:00 +0000)]
Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.

Reviewed by Sam Weinig.

JavaScriptCore:

* parser/Lexer.cpp:
(JSC::Lexer::parseString):

LayoutTests:

* fast/js/numeric-escapes-in-string-literals-expected.txt: Added.
* fast/js/numeric-escapes-in-string-literals.html: Added.
* fast/js/script-tests/numeric-escapes-in-string-literals.js: Added.
(test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatl...
mrobinson@webkit.org [Wed, 29 Dec 2010 23:46:42 +0000 (23:46 +0000)]
2010-12-27  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>

        Reviewed by Martin Robinson.

        [GTK] Enable building whatever already exists of WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=37369

        No new functionality added or deleted. Only makefile change. Hence, no tests added.

        * GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
        added them to WebKit/gtk/GNUmakefile.am
        * platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
        and declare WEBKIT_API directly
2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>

        Reviewed by Martin Robinson.

        [GTK] Enable building whatever already exists of WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=37369

        * GNUmakefile.am: Added.
        * WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header
        file for WebKit2 sources files.
        * gtk: Added.
        * gtk/webkit2.pc.in: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 29 Dec 2010 22:58:39 +0000 (22:58 +0000)]
2010-12-29  Martin Robinson  <mrobinson@igalia.com>

        Build fix for GTK+.

        * webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 29 Dec 2010 22:57:28 +0000 (22:57 +0000)]
2010-12-29  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        Simplify make-hash-tools.pl
        https://bugs.webkit.org/show_bug.cgi?id=49922

        Added HashTools.h to the project file now that its not autogenerated.
        I also sorted the project file using sort-xcode-project-file

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 22:56:45 +0000 (22:56 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update. Mark another test as flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 29 Dec 2010 22:34:37 +0000 (22:34 +0000)]
2010-12-29  Martin Robinson  <mrobinson@igalia.com>

        [GTK] GSettings warning is concealing real warnings on the build bots
        https://bugs.webkit.org/show_bug.cgi?id=51691

        Reviewed by Xan Lopez.

        Do not print the GSettings warning message when running in DumpRenderTree.

        * webkit/webkitwebinspector.cpp:
        (inspectorGSettings): Do not print the GSettings warning if we are running
        in DumpRenderTree. This should clean up the test results page a great deal.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 29 Dec 2010 22:22:10 +0000 (22:22 +0000)]
2010-12-29  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: revert r74755 and 74757.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 29 Dec 2010 22:20:51 +0000 (22:20 +0000)]
2010-12-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Sam Weinig.

        JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
        https://bugs.webkit.org/show_bug.cgi?id=51722

        Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
        methods the fastcall calling convention, which leads to runtime errors when they are
        called from C++. Also remove a bit of unnecessary code duplication.

        No new tests. This is covered by fast/canvas/webgl/data-view-test.html.

        * bindings/js/JSDataViewCustom.cpp:
        (WebCore::getDataViewMember): Remove duplicated code.
        (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
        (WebCore::JSDataView::getUint8): Ditto.
        (WebCore::JSDataView::getFloat32): Ditto.
        (WebCore::JSDataView::getFloat64): Ditto.
        (WebCore::setDataViewMember): Remove duplicated code.
        (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
        (WebCore::JSDataView::setUint8): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
mitz@apple.com [Wed, 29 Dec 2010 22:18:42 +0000 (22:18 +0000)]
A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681

Reviewed by Kenneth Russel.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
attach-type style recalc.
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
(WebCore::CanvasRenderingContext2D::accessFont): Added a call to
Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
and update the font if it is invalid.
* platform/graphics/Font.h:
(WebCore::Font::loadingCustomFonts): Made this private.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 21:43:04 +0000 (21:43 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        fast/canvas/webgl/tex-image-with-format-and-type.html is flaky in
        the GPU suite too.

        * platform/chromium/test_expectations.txt:
        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 29 Dec 2010 21:39:14 +0000 (21:39 +0000)]
2010-12-29  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Qt build fix.

        * inspector/InspectorController.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 21:38:32 +0000 (21:38 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Remove failure expectations for tests that no longer fail:
        - fast/images/svg-as-background.html has not timed out for as long as
          the flakiness dashboard has history
        - svg/W3C-SVG-1.1/animate-elem-03-t.svg has not failed for as long as
          the flakiness dashboard has history

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 29 Dec 2010 21:30:47 +0000 (21:30 +0000)]
2010-12-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract Database & DOM Storage
        agents; remove InspectorBackend.
        https://bugs.webkit.org/show_bug.cgi?id=51707

        This change brushes up storage agents + removes redundant
        InspectorBackend class.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::databaseForId):
        (WebCore::InjectedScriptHost::selectDatabase):
        (WebCore::InjectedScriptHost::selectDOMStorage):
        (WebCore::InjectedScriptHost::inspectorDOMAgent):
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp: Removed.
        * inspector/InspectorBackend.h: Removed.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::releaseFrontendLifetimeAgents):
        (WebCore::InspectorController::didUseDOMStorage):
        (WebCore::InspectorController::setInjectedScriptSource):
        (WebCore::InspectorController::dispatchOnInjectedScript):
        (WebCore::InspectorController::releaseWrapperObjectGroup):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMStorageAgent.cpp: Added.
        (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
        (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
        (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
        (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
        (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
        (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
        (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
        * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
        (WebCore::InspectorDOMStorageAgent::create):
        (WebCore::InspectorDOMStorageAgent::frontend):
        * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
        (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
        (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
        (WebCore::InspectorDatabaseAgent::executeSQL):
        (WebCore::InspectorDatabaseAgent::databaseForId):
        (WebCore::InspectorDatabaseAgent::selectDatabase):
        (WebCore::InspectorDatabaseAgent::clearFrontend):
        (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
        * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
        (WebCore::InspectorDatabaseAgent::create):
        (WebCore::InspectorDatabaseAgent::frontend):
        * inspector/InspectorFrontendClientLocal.cpp:
        * inspector/InspectorFrontendClientLocal.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 21:24:27 +0000 (21:24 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.
        Add recent upstream expectations Chromium changes.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 20:49:13 +0000 (20:49 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.
        Mark http/tests/incremental/split-hex-entities.pl as flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 29 Dec 2010 20:39:58 +0000 (20:39 +0000)]
2010-12-29  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
        https://bugs.webkit.org/show_bug.cgi?id=51067

        * fast/dom/HTMLScriptElement/move-in-beforeload-expected.txt: Added.
        * fast/dom/HTMLScriptElement/move-in-beforeload.html: Added.
        * fast/dom/HTMLScriptElement/remove-in-beforeload-expected.txt: Added.
        * fast/dom/HTMLScriptElement/remove-in-beforeload.html: Added.
2010-12-29  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
        https://bugs.webkit.org/show_bug.cgi?id=51067

        Typically when a script element is removed from the document, the cached script
        client is removed. However, during the before load event, the cached script client
        hasn't been created yet so it can't be removed.

        This patch handles that case by explicitly checking if the script element was
        removed during the beforeload event. Also, it avoids caching the Document references
        over the arbitrary script execution in the before load event.

        Test: fast/dom/HTMLScriptElement/move-in-beforeload.html
              fast/dom/HTMLScriptElement/remove-in-beforeload.html

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::requestScript):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in...
mitz@apple.com [Wed, 29 Dec 2010 20:02:10 +0000 (20:02 +0000)]
<rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
https://bugs.webkit.org/show_bug.cgi?id=51717

Reviewed by Ada Chan.

Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.

* WebView/WebDocumentInternal.h:
* WebView/WebHTMLView.mm:
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
(-[WebHTMLView _findString:options:]):
* WebView/WebView.mm:
(findString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 19:20:05 +0000 (19:20 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed, rolling out r74748.
        http://trac.webkit.org/changeset/74748

        r74735 was rolled out with r74749, the expectations update
        should be rolled out too

        * platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Added.
        * platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Added.
        * platform/chromium/fast/events/ime-composition-events-001-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 29 Dec 2010 19:13:20 +0000 (19:13 +0000)]
2010-12-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74735.
        http://trac.webkit.org/changeset/74735
        https://bugs.webkit.org/show_bug.cgi?id=51715

        assert failures on fast/forms/input-maxlength-ime-
        completed.html (Requested by mihaip on #webkit).

        * platform/chromium/test_expectations.txt:
2010-12-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74735.
        http://trac.webkit.org/changeset/74735
        https://bugs.webkit.org/show_bug.cgi?id=51715

        assert failures on fast/forms/input-maxlength-ime-
        completed.html (Requested by mihaip on #webkit).

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::setMarkedText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 18:17:51 +0000 (18:17 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium baselines. Update Chromium baselines for
        fast/events/ime-composition-events-001.html after r74735 (the
        new baselines are closer to the upstream Mac ones).

        * platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
        * platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
        * platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 29 Dec 2010 18:12:47 +0000 (18:12 +0000)]
2010-12-29  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium baselines. Add Chromium baselines for the
        layout test added by r74743.

        * platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
        * platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
        * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
        * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 29 Dec 2010 18:03:20 +0000 (18:03 +0000)]
2010-12-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ojan Vafai.

        prepare-ChangeLog should support the -g option for specifying the git-commit
        https://bugs.webkit.org/show_bug.cgi?id=51708

        Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
        webkit-patch, though the exact meaning of the two options remain different.

        * Scripts/prepare-ChangeLog: Add -g.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 29 Dec 2010 18:01:39 +0000 (18:01 +0000)]
2010-12-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
        https://bugs.webkit.org/show_bug.cgi?id=51703

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::drawElementTitle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
yael.aharon@nokia.com [Wed, 29 Dec 2010 16:00:48 +0000 (16:00 +0000)]
[HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=29071

Reviewed by Kent Tamura.

WebCore:

Use InputType::rangeUnderflow() and InputType::rangeOverflow()
to determine if a control is in-range or out-of-range.

Tests: fast/css/pseudo-in-range-invalid-value.html
       fast/css/pseudo-in-range.html
       fast/css/pseudo-out-of-range.html

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/Element.h:
(WebCore::Element::isInRange):
(WebCore::Element::isOutOfRange):
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):
* html/BaseDateAndTimeInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::supportsRangeLimitation):
* html/InputType.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::supportsRangeLimitation):
* html/NumberInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::supportsRangeLimitation):
* html/RangeInputType.h:

LayoutTests:

* fast/css/pseudo-in-range-expected.txt: Added.
* fast/css/pseudo-in-range-invalid-value-expected.txt: Added.
* fast/css/pseudo-in-range-invalid-value.html: Added.
* fast/css/pseudo-in-range.html: Added.
* fast/css/pseudo-out-of-range-expected.txt: Added.
* fast/css/pseudo-out-of-range.html: Added.
* fast/css/script-tests/pseudo-in-range-invalid-value.js: Added.
* fast/css/script-tests/pseudo-in-range.js: Added.
* fast/css/script-tests/pseudo-out-of-range.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 29 Dec 2010 15:50:15 +0000 (15:50 +0000)]
2010-12-29  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        When cloning an anonymous block, make sure to set the childrenInline flag based
        on the state of the block to be cloned.
        https://bugs.webkit.org/show_bug.cgi?id=51489

        Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks.
        (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().
2010-12-29  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests that cloning an anonymous block with non inline children does not crash.
        https://bugs.webkit.org/show_bug.cgi?id=51489

        * fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html: Added.
        * platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
        * platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
        * platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 29 Dec 2010 15:38:17 +0000 (15:38 +0000)]
2010-12-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for WinCE after r73802.

        Reapply parts from r72585:
        Port ContextMenuWin.cpp to WinCE
        https://bugs.webkit.org/show_bug.cgi?id=48408

        * CMakeLists.txt:
        * platform/ContextMenu.h:
        * platform/win/ContextMenuWin.cpp:
        (WebCore::ContextMenu::getContextMenuItems):
        (WebCore::ContextMenu::createNativeMenuFromItems):
2010-12-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for WinCE after r73802.

        * WebCoreSupport/ContextMenuClientWinCE.cpp:
        (WebKit::ContextMenuClientWinCE::customizeMenu):
        * WebCoreSupport/ContextMenuClientWinCE.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Kent Hansen <kent.hansen@nokia.com>
kent.hansen@nokia.com [Wed, 29 Dec 2010 13:39:37 +0000 (13:39 +0000)]
2010-12-29  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with Qt in namespace
        https://bugs.webkit.org/show_bug.cgi?id=51701

        * QtTestBrowser/webview.h:

2010-12-29  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with Qt in namespace
        https://bugs.webkit.org/show_bug.cgi?id=51701

        * platform/graphics/ContextShadow.h:
        * platform/graphics/GraphicsContext3D.h:
        * platform/network/NetworkingContext.h:
        * platform/network/qt/QtNAMThreadSafeProxy.h:
        * plugins/PluginView.h:

2010-12-29  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with Qt in namespace
        https://bugs.webkit.org/show_bug.cgi?id=51701

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/InspectorServerQt.h:
        * tests/hybridPixmap/widget.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 29 Dec 2010 11:53:48 +0000 (11:53 +0000)]
2010-12-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: A disabled style property should get enabled when edited
        https://bugs.webkit.org/show_bug.cgi?id=51679

        * inspector/styles-disable-then-change-expected.txt: Added.
        * inspector/styles-disable-then-change.html: Added.
2010-12-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: A disabled style property should get enabled when edited
        https://bugs.webkit.org/show_bug.cgi?id=51679

        Test: inspector/styles-disable-then-change.html

        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSProperty.prototype.setText):
        (WebInspector.CSSProperty.prototype.setText.callback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 29 Dec 2010 11:35:13 +0000 (11:35 +0000)]
2010-12-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. Use gcc as default preprocessor.

        * Sources/cmake/OptionsCommon.cmake:
2010-12-29  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Remove WebKitGenerators
        https://bugs.webkit.org/show_bug.cgi?id=50445

        * CMakeLists.txt: Pass preprocessor to generate-bindings.pl.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Juha Savolainen <juha.savolainen@weego.fi>
commit-queue@webkit.org [Wed, 29 Dec 2010 11:22:45 +0000 (11:22 +0000)]
2010-12-29  Juha Savolainen  <juha.savolainen@weego.fi>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] Added more webattributes to the qwkpreferences
        https://bugs.webkit.org/show_bug.cgi?id=51697

        Added PrivateBrowsingEnabled, DeveloperExtrasEnabled, DnsPrefetchEnabled attributes

        * UIProcess/API/qt/qwkpreferences.cpp:
        (QWKPreferences::testAttribute):
        (QWKPreferences::setAttribute):
        * UIProcess/API/qt/qwkpreferences.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Wed, 29 Dec 2010 09:32:12 +0000 (09:32 +0000)]
2010-12-29  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        <VT> and <FF> are not valid JSON whitespace characters
        https://bugs.webkit.org/show_bug.cgi?id=51671

        Vertical Tab and Form Feed are not allowed white spaces by the JSON
        RFC 4627: http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

        Tests: ietestcenter/Javascript/15.12.1.1-0-2.html
               ietestcenter/Javascript/15.12.1.1-0-3.html

        * runtime/LiteralParser.cpp:
        (JSC::isJSONWhiteSpace):
        (JSC::LiteralParser::Lexer::lex):
2010-12-29  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        <VT> and <FF> are not valid JSON whitespace characters
        https://bugs.webkit.org/show_bug.cgi?id=51671

        Vertical Tab and Form Feed are not allowed white spaces by the JSON
        RFC 4627: http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

        * ietestcenter/Javascript/15.12.1.1-0-2-expected.txt:
        * ietestcenter/Javascript/15.12.1.1-0-3-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 29 Dec 2010 09:30:43 +0000 (09:30 +0000)]
2010-12-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test on GTK.

        [GTK] editing/selection/extend-by-character-004.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=51699

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 Zhe Su <suzhe@chromium.org>
commit-queue@webkit.org [Wed, 29 Dec 2010 09:22:19 +0000 (09:22 +0000)]
2010-12-29  Zhe Su  <suzhe@chromium.org>

        Reviewed by Eric Seidel.

        Remove entry for editing/input/ime-composition-clearpreedit.html test.
        https://bugs.webkit.org/show_bug.cgi?id=51693

        * platform/chromium/test_expectations.txt:
2010-12-29  Zhe Su  <suzhe@chromium.org>

        Reviewed by Eric Seidel.

        Fix editing/input/ime-composition-clearpreedit.html test in chromium
        by removing the line "editor->confirmComposition(text);" from
        WebFrameImpl::setMarkedText() method, because that line will insert the
        text into the focused node, which is apparently wrong.

        https://bugs.webkit.org/show_bug.cgi?id=51693

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::setMarkedText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Pratik Solanki <psolanki@apple.com>
commit-queue@webkit.org [Wed, 29 Dec 2010 07:45:28 +0000 (07:45 +0000)]
2010-12-28  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=51522
        Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()

        * page/win/FrameCGWin.cpp:
        (WebCore::imageFromRect):
        * platform/graphics/cg/GradientCG.cpp:
        (WebCore::Gradient::platformGradient):
        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        (WebCore::GraphicsContext3D::paintToCanvas):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/gstreamer/ImageGStreamerCG.mm:
        (ImageGStreamer::ImageGStreamer):
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::CGContextWithHDC):
        (WebCore::GraphicsContext::releaseWindowsContext):
        (WebCore::GraphicsContext::drawWindowsBitmap):
        * platform/graphics/win/ImageCGWin.cpp:
        (WebCore::BitmapImage::create):
        (WebCore::BitmapImage::getHBITMAPOfSize):
        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::createColorSpace):
        * platform/win/DragImageCGWin.cpp:
        (WebCore::allocImage):
        (WebCore::createCgContextFromBitmap):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 29 Dec 2010 00:59:23 +0000 (00:59 +0000)]
2010-12-28  Daniel Bates  <dbates@rim.com>

        Reviewed by Sam Weinig.

        Substitute // MARK: for compiler-specific #pragma mark
        https://bugs.webkit.org/show_bug.cgi?id=51657

        For consistency, we should substitute "// MARK:" for compiler-
        specific "#pragma mark" in the source files for the Mac port.

        * History/WebHistory.mm:
        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebNetscapePluginView.mm:
        * WebCoreSupport/WebInspectorClient.mm:
        * WebCoreSupport/WebSecurityOrigin.mm:
        * WebView/WebPDFView.mm:
        * WebView/WebVideoFullscreenController.mm:
        * WebView/WebVideoFullscreenHUDWindowController.mm:
2010-12-28  Daniel Bates  <dbates@rim.com>

        Reviewed by Sam Weinig.

        Substitute // MARK: for compiler-specific #pragma mark
        https://bugs.webkit.org/show_bug.cgi?id=51657

        Fix compilation warnings about "#pragma mark" on GTK+ bots by
        substituting  "// MARK:" for "#pragma mark", which provides
        analogous code-bookmarking functionality under Xcode.

        * platform/graphics/cg/PathCG.cpp:
        * platform/graphics/mac/WebLayer.mm:
2010-12-28  Daniel Bates  <dbates@rim.com>

        Reviewed by Sam Weinig.

        Substitute // MARK: for compiler-specific #pragma mark
        https://bugs.webkit.org/show_bug.cgi?id=51657

        Fix future compilation warnings about "#pragma mark" on GTK+ bots by
        substituting  "// MARK:" for "#pragma mark", which provides
        analogous code-bookmarking functionality under Xcode.

        Also, for consistency, we should substitute "// MARK:" for compiler-
        specific "#pragma mark" in the source files for the Mac port.

        * DumpRenderTree/AccessibilityTextMarker.cpp:
        * DumpRenderTree/cf/WebArchiveDumpSupport.h:
        * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
        * DumpRenderTree/mac/ObjCController.m:
        * MiniBrowser/mac/AppDelegate.m:
        * MiniBrowser/mac/BrowserWindowController.m:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 29 Dec 2010 00:56:40 +0000 (00:56 +0000)]
2010-12-28  Daniel Bates  <dbates@rim.com>

        Reviewed by Antonio Gomes.

        Add comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
        to clarify caret browsing disabled
        https://bugs.webkit.org/show_bug.cgi?id=51633

        Add a comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
        that explains that this test is only applicable when caret browsing is disabled.

        * fast/repaint/no-caret-repaint-in-non-content-editable-element.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 29 Dec 2010 00:39:42 +0000 (00:39 +0000)]
2010-12-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Closing a window during an onload event can trigger serious GLib warnings
        https://bugs.webkit.org/show_bug.cgi?id=51686

        Don't emit the close-web-view signal immediately during execution of closeWindowSoon.
        The signal handler may choose to destroy the web view while handling that signal,
        which may remove the last reference to the web view. FrameLoaderClient depends on the
        view still existing though. Instead, let the caller finish executing and emit the signal
        after a 0 length timeout. This matches the behavior on the Windows and Mac ports.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::ChromeClient): Initialize the timer id.
        (WebKit::emitCloseWebViewSignalLater): Callback for the timer.
        (WebKit::ChromeClient::closeWindowSoon): Do the actual signal invocation after
        the caller finishes its tasks.
        * WebCoreSupport/ChromeClientGtk.h: Add a new member for the timer id. We
        can use this to prevent emitting the close-web-view signal twice.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 28 Dec 2010 23:39:15 +0000 (23:39 +0000)]
2010-12-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Clean up usage of NULL in webkitwebframe.cpp
        https://bugs.webkit.org/show_bug.cgi?id=51685

        Replace occurrences of NULL with 0, in webkitwebframe.cpp. Not all
        uses of NULL have been changed, as certain GLib functions require
        an explicit NULL as a sentinel.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_get_data_source_from_core_loader):
        (webkit_web_frame_class_init):
        (webkit_web_frame_new):
        (webkit_web_frame_get_title):
        (webkit_web_frame_get_uri):
        (webkit_web_frame_get_web_view):
        (webkit_web_frame_get_name):
        (webkit_web_frame_get_parent):
        (webkit_web_frame_load_string):
        (webkit_web_frame_load_alternate_string):
        (webkit_web_frame_find_frame):
        (webkit_web_frame_get_global_context):
        (webkit_web_frame_get_data_source):
        (webkit_web_frame_get_provisional_data_source):
        (webkit_web_frame_print_full):
        (webkit_web_frame_get_security_origin):
        (webkit_web_frame_get_network_response):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 28 Dec 2010 23:16:19 +0000 (23:16 +0000)]
2010-12-28  Kenneth Russell  <kbr@google.com>

        Reviewed by Eric Seidel.

        Make fast/canvas/canvas-save-restore-with-path.js more robust
        https://bugs.webkit.org/show_bug.cgi?id=51665

        * fast/canvas/canvas-save-restore-with-path-expected.txt:
        * fast/canvas/canvas-save-restore-with-path.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Tue, 28 Dec 2010 22:56:01 +0000 (22:56 +0000)]
2010-12-28  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Eric Seidel.

        [Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
        https://bugs.webkit.org/show_bug.cgi?id=51687

        Use a const reference instead of a copy of QPainter::combinedTransform()
        in GraphicsContext::getCTM()

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getCTM):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 28 Dec 2010 22:45:20 +0000 (22:45 +0000)]
2010-12-28  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        JSON.stringify must exist as a function taking 3 parameters
        https://bugs.webkit.org/show_bug.cgi?id=51667

        The reported function length is 1 instead.

        Test: ietestcenter/Javascript/15.12.3-0-2.html

        * runtime/JSONObject.cpp:
2010-12-28  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        JSON.stringify must exist as a function taking 3 parameters
        https://bugs.webkit.org/show_bug.cgi?id=51667

        The reported function length is 1 instead.

        * ietestcenter/Javascript/15.12.3-0-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Xan Lopez <xlopez@igalia.com>
commit-queue@webkit.org [Tue, 28 Dec 2010 22:20:24 +0000 (22:20 +0000)]
2010-12-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        Add --no-build option to run-sunspider
        https://bugs.webkit.org/show_bug.cgi?id=51658

        * Scripts/run-sunspider: add --no-build flag to skip building
        phase.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Takashi Toyoshima <toyoshim@google.com>
commit-queue@webkit.org [Tue, 28 Dec 2010 22:14:38 +0000 (22:14 +0000)]
2010-12-28  Takashi Toyoshima  <toyoshim@google.com>

        Reviewed by Eric Seidel.

        gcc detected 'control reaches end of non-void function' with
        -finstrument-functions option.
        https://bugs.webkit.org/show_bug.cgi?id=51669

        No new tests. These fixes are trivial.

        * dom/Element.cpp:
        (WebCore::Element::childTypeAllowed):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::cachedResourceTypeString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 28 Dec 2010 21:57:47 +0000 (21:57 +0000)]
2010-12-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Remove unused member of PendingScript
        https://bugs.webkit.org/show_bug.cgi?id=51684

        This was used when HTMLScriptRunner::runScript created a PendingScript
        for inline scripts. But now it just calls executeScript() directly.
        External scripts always have the minimum starting line number.

        No new tests because no changed functionality.

        * dom/PendingScript.cpp:
        (WebCore::PendingScript::releaseElementAndClear):
        * dom/PendingScript.h:
        (WebCore::PendingScript::PendingScript):
        (WebCore::PendingScript::operator=):
        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::sourceFromPendingScript):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-20 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 28 Dec 2010 21:57:11 +0000 (21:57 +0000)]
2010-12-20  Antonio Gomes  <agomes@rim.com>

        Reviewed by Daniel Bates.

        Spatial Navigation: code clean up (Part VI)
        https://bugs.webkit.org/show_bug.cgi?id=50666

        No new tests needed.

        * page/FocusController.cpp:
        (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and
        isElementNode() now that we are bailing out earlier in both the
        FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
        * page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection
        and virtualRectForAreaElementAndDirection functions.
        (WebCore::FocusController::findFocusCandidateInContainer):
        (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted call sites
        of canScrollInDirection(), and added an early return if !isElementNode().
        (WebCore::FocusController::advanceFocusDirectionally): Adjusted call site of
        virtualRectForAreaElementAndDirection().
        * page/SpatialNavigation.cpp:
        (WebCore::FocusCandidate::FocusCandidate): Assert if node is not an Element node.
        (WebCore::isScrollableNode): Renamed from isScrollableContainerNode.
        (WebCore::scrollInDirection): Adjusted call site after function name change;
        (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is
        a Document node.
        (WebCore::canScrollInDirection): Signature changed.
        (WebCore::canBeScrolledIntoView): Ditto.
        (WebCore::virtualRectForAreaElementAndDirection): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Adrienne Walker <enne@google.com>
enne@google.com [Tue, 28 Dec 2010 21:53:52 +0000 (21:53 +0000)]
2010-12-28  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Fix tiled compositor assertion after GPU process recovery.
        https://bugs.webkit.org/show_bug.cgi?id=51682

        After the GPU process recovers, the layer size is set to IntSize(),
        but IntRect::unite() has a special case for empty rects.  This
        behavior was causing the layer size to be too small, causing an
        out-of-bounds array access elsewhere.

        No new tests.

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::growLayerToContain):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 28 Dec 2010 21:36:54 +0000 (21:36 +0000)]
2010-12-28  Helder Correia  <helder@sencha.com>

        Reviewed by Sam Weinig.

        JSON.parse must exist as a function taking 2 parameters
        https://bugs.webkit.org/show_bug.cgi?id=51666

        Support for revivers was introduced in bug 26591, but the function
        length has since remained unchanged.

        Test: ietestcenter/Javascript/15.12.2-0-2.html

        * runtime/JSONObject.cpp:
2010-12-28  Helder Correia  <helder@sencha.com>

        Reviewed by Sam Weinig.

        JSON.parse must exist as a function taking 2 parameters
        https://bugs.webkit.org/show_bug.cgi?id=51666

        Support for revivers was introduced in bug 26591, but the function
        length has since remained unchanged.

        * ietestcenter/Javascript/15.12.2-0-2-expected.txt: Change expected
          result to success.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-23 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 28 Dec 2010 21:35:20 +0000 (21:35 +0000)]
2010-12-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Initialize to 0 for undefined values in CopyTexImage2D
        https://bugs.webkit.org/show_bug.cgi?id=51421

        * src/GraphicsContext3DChromium.cpp: Implement getInternalFramebufferSize().
        (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize):
        * src/GraphicsContext3DInternal.h:
2010-12-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Initialize to 0 for undefined values in CopyTexImage2D
        https://bugs.webkit.org/show_bug.cgi?id=51421

        * html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer.
        (WebCore::WebGLFramebuffer::WebGLFramebuffer):
        (WebCore::WebGLFramebuffer::setAttachment):
        (WebCore::WebGLFramebuffer::getWidth):
        (WebCore::WebGLFramebuffer::getHeight):
        (WebCore::WebGLFramebuffer::getColorBufferFormat):
        * html/canvas/WebGLFramebuffer.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0.
        (WebCore::WebGLRenderingContext::copyTexSubImage2D):
        (WebCore::WebGLRenderingContext::framebufferTexture2D):
        (WebCore::WebGLRenderingContext::renderbufferStorage):
        (WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
        (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level.
        (WebCore::WebGLTexture::getInternalFormat):
        (WebCore::WebGLTexture::getWidth):
        (WebCore::WebGLTexture::getHeight):
        (WebCore::WebGLTexture::mapTargetToIndex):
        (WebCore::WebGLTexture::getLevelInfo):
        * html/canvas/WebGLTexture.h:
        (WebCore::WebGLTexture::isTexture):
        * platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::getInternalFramebufferSize):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::getInternalFramebufferSize):
2010-12-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Initialize to 0 for undefined values in CopyTexImage2D
        https://bugs.webkit.org/show_bug.cgi?id=51421

        * fast/canvas/webgl/uninitialized-test-expected.txt: Add test cases for copyTexImage2D.
        * fast/canvas/webgl/uninitialized-test.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-23 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 28 Dec 2010 21:26:58 +0000 (21:26 +0000)]
2010-12-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=39855

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long.
        (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
        (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
        (WebCore::WebGLRenderingContext::scissor): Ditto.
        (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.
        (WebCore::WebGLRenderingContext::texImage2D): Ditto.
        (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
        (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
        (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
        (WebCore::WebGLRenderingContext::viewport): Ditto.
        (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
2010-12-28  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=39855

        * fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for negative offset/width/height.
        * fast/canvas/webgl/invalid-passed-params.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 28 Dec 2010 20:01:14 +0000 (20:01 +0000)]
2010-12-28  Kenneth Russell  <kbr@google.com>

        Unreviewed, Chromium test expectations update. Mark
        fast/forms/input-text-paste-maxlength.html as a flaky crash on
        Linux Release as well as Debug.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 28 Dec 2010 19:36:52 +0000 (19:36 +0000)]
2010-12-28  Kenneth Russell  <kbr@google.com>

        Unreviewed, Chromium test expectations update.

        Marked inspector/styles-source-lines.html as a flaky failure on
        Win Debug and
        http/tests/inspector/extensions-resources-redirect.html as a flaky
        timeout on Win Release.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 28 Dec 2010 19:18:36 +0000 (19:18 +0000)]
2010-12-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Kenneth Russell.

        Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
        process of loading.
        https://bugs.webkit.org/show_bug.cgi?id=51681

        Test: canvas/philip/tests/2d.text-custom-font-load-crash.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
        * platform/graphics/Font.cpp:
        (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts()
        (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts()
        (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
        * platform/graphics/Font.h:
        (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.
2010-12-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Kenneth Russell.

        Tests that we do not crash when drawing text during custom font load.
        https://bugs.webkit.org/show_bug.cgi?id=51681

        * canvas/philip/tests/2d.text-custom-font-load-crash-expected.txt: Added.
        * canvas/philip/tests/2d.text-custom-font-load-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 28 Dec 2010 18:55:42 +0000 (18:55 +0000)]
2010-12-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Combine setShadowRoot and clearShadowRoot into a simpler API
        https://bugs.webkit.org/show_bug.cgi?id=50971

        No change in behavior, and API is not used yet.

        * dom/Element.cpp:
        (WebCore::Element::setShadowRoot): Combined clearing and setting of
            the shadowRoot, also hooked up with setting and clearing of the
            corresponding shadowHost values.
        * dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it
            private.
        * dom/Node.h: Made shadow host-related functions public so that
            Element::setShadowRoot can access setShadowHost. It seems logical
            to make shadowHost public as well to keep the defs together.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 28 Dec 2010 18:11:13 +0000 (18:11 +0000)]
2010-12-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
        Do not request content for resources with non-numeric identifiers.
        https://bugs.webkit.org/show_bug.cgi?id=49727

        Test: http/tests/inspector/extensions-resources-redirect.html

        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype._appendRedirect):

2010-12-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
        Do not request content for resources with non-numeric identifiers.
        https://bugs.webkit.org/show_bug.cgi?id=49727

        * http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
        * http/tests/inspector/extensions-resources-redirect.html: Added.
        * http/tests/inspector/extensions-resources-test.js: Added.
        (extension_getResourceByUrl.onHAR):
        (extension_getResourceByUrl):
        * inspector/extensions-resources-expected.txt:
        * inspector/extensions-resources.html:
        * platform/mac-leopard/inspector/extensions-resources-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 28 Dec 2010 17:58:44 +0000 (17:58 +0000)]
2010-12-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix for Qt.

        ResourceTreeModel.js was added.

        * inspector/front-end/WebKit.qrc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 28 Dec 2010 17:24:06 +0000 (17:24 +0000)]
2010-12-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.

        https://bugs.webkit.org/show_bug.cgi?id=51680

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 28 Dec 2010 15:55:55 +0000 (15:55 +0000)]
2010-12-28  Kenneth Russell  <kbr@google.com>

        Unreviewed, Chromium test expectations update. Coalesce WebGL
        expectations for chromium-gpu platform and fix duplicate
        expectation for gl-object-get-calls.html accidentally introduced
        on Windows Debug.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-28 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 28 Dec 2010 15:32:33 +0000 (15:32 +0000)]
2010-12-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
        https://bugs.webkit.org/show_bug.cgi?id=51663

        * inspector/elements-tests2.js:
        (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
        * inspector/resources/styles-url-linkify-iframe.html: Added.
        * inspector/resources/styles-url-linkify.css: Added.
        (#local):
        * inspector/styles-url-linkify-expected.txt: Added.
        * inspector/styles-url-linkify.html: Added.
2010-12-28  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
        https://bugs.webkit.org/show_bug.cgi?id=51663

        The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
        optional quotes/apostrophes and spaces are now allowed inside uri(...).

        Test: inspector/styles-url-linkify.html

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-21 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 28 Dec 2010 15:11:26 +0000 (15:11 +0000)]
2010-12-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.

        Domain was changed for Resources, FileSystem etc. related methods.
        ResourcesManager was renamed to NetworkManager.
        ResourceTreeModel was extracted as separate file.
        FileSystem, Database, DOMStorage and ApplicationCache methods were
        removed from NetworkManager and added to corresponding classes.

        https://bugs.webkit.org/show_bug.cgi?id=51334

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.addMessage):
        (WebInspector.ConsoleView.prototype.clearMessages):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.ApplicationCache.updateApplicationCacheStatus):
        (WebInspector.ApplicationCache.updateNetworkState):
        * inspector/front-end/DOMStorage.js:
        (WebInspector.DOMStorage.addDOMStorage):
        (WebInspector.DOMStorage.selectDOMStorage):
        (WebInspector.DOMStorage.updateDOMStorage):
        * inspector/front-end/Database.js:
        (WebInspector.Database.prototype.executeSql):
        (WebInspector.Database.addDatabase):
        (WebInspector.Database.selectDatabase):
        (WebInspector.Database.sqlTransactionSucceeded):
        (WebInspector.Database.sqlTransactionFailed):
        * inspector/front-end/FileSystemView.js:
        (WebInspector.FileSystem.didGetFileSystemPath):
        (WebInspector.FileSystem.didGetFileSystemError):
        (WebInspector.FileSystem.didGetFileSystemDisabled):
        * inspector/front-end/NetworkItemView.js:
        (WebInspector.NetworkItemView):
        * inspector/front-end/NetworkManager.js: Added.
        (WebInspector.NetworkManager):
        (WebInspector.NetworkManager.prototype._createResource):
        (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
        (WebInspector.NetworkManager.prototype.willSendRequest):
        (WebInspector.NetworkManager.prototype._updateResourceWithRequest):
        (WebInspector.NetworkManager.prototype._appendRedirect):
        (WebInspector.NetworkManager.prototype.markResourceAsCached):
        (WebInspector.NetworkManager.prototype.didReceiveResponse):
        (WebInspector.NetworkManager.prototype._updateResourceWithResponse):
        (WebInspector.NetworkManager.prototype.didReceiveContentLength):
        (WebInspector.NetworkManager.prototype.didFinishLoading):
        (WebInspector.NetworkManager.prototype.didFailLoading):
        (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource):
        (WebInspector.NetworkManager.prototype.setInitialContent):
        (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
        (WebInspector.NetworkManager.prototype.frameDetachedFromParent):
        (WebInspector.NetworkManager.prototype.didCreateWebSocket):
        (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
        (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.NetworkManager.prototype.didCloseWebSocket):
        (WebInspector.NetworkManager.prototype._processCachedResources):
        (WebInspector.NetworkManager.prototype._addFramesRecursively):
        (WebInspector.NetworkManager.requestContent):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.refreshResource):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._innerRequestContent):
        * inspector/front-end/ResourceManager.js: Removed.
        * inspector/front-end/ResourceTreeModel.js: Added.
        (WebInspector.ResourceTreeModel):
        (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame):
        (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
        (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent):
        (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
        (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
        (WebInspector.ResourceTreeModel.prototype._clearResources):
        (WebInspector.ResourceTreeModel.prototype.forAllResources):
        (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
        (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages):
        (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
        (WebInspector.ResourceTreeModel.prototype.resourceForURL):
        (WebInspector.ResourceTreeModel.prototype.bindResourceURL):
        (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
        (WebInspector.ResourceTreeModel.createResource):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.createResourceView):
        (WebInspector.ResourceView.resourceViewTypeMatchesResource):
        (WebInspector.ResourceView.resourceViewForResource):
        (WebInspector.ResourceView.recreateResourceView):
        (WebInspector.ResourceView.existingResourceViewForResource):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
        (WebInspector.ResourcesPanel.prototype.showSourceLine):
        (WebInspector.ResourcesPanel.prototype.showResource):
        (WebInspector.ResourcesPanel.prototype.get searchableViews.callback):
        (WebInspector.ResourcesPanel.prototype.get searchableViews):
        (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
        (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addScript):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.forAllResources):
        (WebInspector.resourceForURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 28 Dec 2010 05:33:07 +0000 (05:33 +0000)]
2010-12-27  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        ContextShadow should use AffineTransform instead of TransformationMatrix
        https://bugs.webkit.org/show_bug.cgi?id=51661

        ContextShadow needs the CTM to make sure shadows are not affected by
        transformations when drawing on a canvas. AffineTransform is sufficient
        in this case.

        Existing tests: fast/canvas/canvas*shadow*html

        * platform/graphics/ContextShadow.cpp:
        (WebCore::ContextShadow::mustUseContextShadow):
        (WebCore::ContextShadow::adjustBlurDistance):
        (WebCore::ContextShadow::calculateLayerBoundingRect):
        * platform/graphics/ContextShadow.h:
        * platform/graphics/cairo/ContextShadowCairo.cpp:
        (WebCore::ContextShadow::getTransformationMatrixFromContext):
        * platform/graphics/qt/ContextShadowQt.cpp:
        (WebCore::ContextShadow::getTransformationMatrixFromContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 28 Dec 2010 05:15:57 +0000 (05:15 +0000)]
2010-12-27  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by David Levin.

        [EFL] Change path of eflsymbols.filter
        https://bugs.webkit.org/show_bug.cgi?id=51659

        * Sources/cmake/OptionsEfl.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 28 Dec 2010 02:05:01 +0000 (02:05 +0000)]
2010-12-27  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Martin Robinson.

        Append the directory Tools/DumpRenderTree to the list of directories that
        do-webcore-rename should search so that it can rename DRT files and
        source code.

        * Scripts/do-webcore-rename:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 28 Dec 2010 01:40:09 +0000 (01:40 +0000)]
2010-12-27  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        Try to fix my previous commit for Mac by stepping up the precision of pi even more
        using Math.PI.

        * fast/canvas/canvas-save-restore-with-path.js: Use Math.PI instead of a
        hard-coded estimation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 snapshots should contain accelerated content
weinig@apple.com [Tue, 28 Dec 2010 01:39:28 +0000 (01:39 +0000)]
WebKit2 snapshots should contain accelerated content
<rdar://problem/8807393>
https://bugs.webkit.org/show_bug.cgi?id=51660

Reviewed by Anders Carlsson.

When creating a snapshot, flatten the layer tree for painting so that
accelerated content is included in the snapshot.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 28 Dec 2010 01:03:13 +0000 (01:03 +0000)]
2010-12-27  Daniel Bates  <dbates@rim.com>

        Attempt to fix the WebKit2 Windows build after changeset 74698
        <http://trac.webkit.org/changeset/74698> (bug #51656).

        Add "..\Shared\API\c\WKImage.h" to WebKit2Generated.make.

        * win/WebKit2Generated.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 28 Dec 2010 00:50:04 +0000 (00:50 +0000)]
2010-12-27  Kenneth Russell  <kbr@google.com>

        Unreviewed, Chromium test expectations update. Generalize
        suppressions for Chromium bugs 67732 and 67139 to cover Linux
        Debug.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 28 Dec 2010 00:44:33 +0000 (00:44 +0000)]
2010-12-27  Daniel Bates  <dbates@rim.com>

        Fix the first sentence of the change log message for changeset 74700
        <http://trac.webkit.org/changeset/74700> (bug #51634).

        As pointed out by Dan Bernstein, it should read: "Rename HTMLFrameElementBase::getMarginWidth()
        and HTMLFrameElementBase::getMarginHeight() to HTMLFrameElementBase::marginWidth() and
        HTMLFrameElementBase::marginHeight(), respectively."

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 28 Dec 2010 00:21:23 +0000 (00:21 +0000)]
2010-12-27  Daniel Bates  <dbates@rim.com>

        Reviewed by Antonio Gomes.

        Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
        https://bugs.webkit.org/show_bug.cgi?id=51634

        Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
        to HTMLFrameElementBase::marginHeight() and HTMLFrameElementBase::marginHeight(), respectively.
        This will make the names of these getters consistent with the naming convention we use for
        getters.

        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::insertedIntoDocument):
        * html/HTMLFrameElementBase.h:
        (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth().
        (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::loadSubframe):
        * page/FrameView.cpp:
        (WebCore::FrameView::init):
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh
        to marginWidth and marginHeight, respectively. This makes the names of these variables
        consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
        * rendering/RenderFrame.cpp:
        (WebCore::RenderFrame::viewCleared): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 28 Dec 2010 00:17:25 +0000 (00:17 +0000)]
2010-12-27  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [Cairo] fast/canvas/canvas-save-restore-with-path.html fails with some versions of Cairo
        https://bugs.webkit.org/show_bug.cgi?id=51655

        Increase the precision of pi used in this test case. It appears that
        some Cairo versions or processors are sensitive to rounding errors here.

        * fast/canvas/canvas-save-restore-with-path.js: Increase pi precision.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Add API for getting snapshots
weinig@apple.com [Tue, 28 Dec 2010 00:01:08 +0000 (00:01 +0000)]
WebKit2: Add API for getting snapshots
https://bugs.webkit.org/show_bug.cgi?id=51656

Reviewed by Anders Carlsson.

* Shared/API/c/WKBase.h:
* Shared/API/c/WKImage.cpp: Added.
(WKImageGetTypeID):
(WKImageCreate):
(WKImageGetSize):
* Shared/API/c/WKImage.h: Added.
* Shared/WebImage.cpp: Added.
(WebKit::WebImage::create):
(WebKit::WebImage::size):
* Shared/WebImage.h: Added.
(WebKit::WebImage::backingStore):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::type):
Add a general purpose API image class.

* Shared/API/c/cg: Added.
* Shared/API/c/cg/WKImageCG.cpp: Added.
(WKImageCreateCGImage):
* Shared/API/c/cg/WKImageCG.h: Added.
Add function to convert a WKImageRef to a CGImageRef for platforms that use CG.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toFloatRect):
(WebKit::toIntSize):
(WebKit::toIntPoint):
(WebKit::toIntRect):
(WebKit::toImageOptions):
Make conversion functions that are ambiguous more explicit.

* Shared/APIObject.h:
* Shared/BackingStore.h:
(WebKit::BackingStore::isBackedBySharedMemory):
* Shared/ImageOptions.h: Added.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Allow a WKImageRef to be passed in user messages.  Right now, it only
works if the image is sharable.

* UIProcess/API/C/WKPage.cpp:
(WKPageScaleWebView):
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::windowFrame):
Use the more explicit conversion function name.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlaySetNeedsDisplay):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):
Add function to take the snapshot.

* WebProcess/WebPage/WebPage.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 27 Dec 2010 22:48:21 +0000 (22:48 +0000)]
2010-12-27  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ryosuke Niwa.

        [GTK] EditorClient::generateEditorCommands queues up "null string" commands
        https://bugs.webkit.org/show_bug.cgi?id=51569

        Prevent adding "null string" editor commands by first checking whether or not
        the command string is null in generateEditorCommands before appending it to the
        list of pending editor command strings.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::generateEditorCommands): Check for the null string (no
        command for this key combination) before appending a command string to the list of
        pending editor commands.
        (WebKit::EditorClient::executePendingEditorCommands): Add an ASSERT which detects
        null command strings.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 27 Dec 2010 22:37:15 +0000 (22:37 +0000)]
2010-12-27  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
        https://bugs.webkit.org/show_bug.cgi?id=51654

        Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
        on some debug configurations.

        No new tests. This is already covered by current slider tests. It isn't crashing on
        the bots, but it does crash locally.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Jake Helfert <jake@jakeonthenet.com>
darin@apple.com [Mon, 27 Dec 2010 21:41:39 +0000 (21:41 +0000)]
2010-12-27  Jake Helfert  <jake@jakeonthenet.com>

        Reviewed and reworked by Darin Adler.

        Building WebKit with Visual Studio 2010 fails due
        to ambiguous assignment operator errors.
        https://bugs.webkit.org/show_bug.cgi?id=51116

        * wtf/NullPtr.h: Added a HAVE(NULLPTR) definition for use with
        Platform.h HAVE macro, and included the Visual Studio 2010 compiler
        as one of the ones that has nullptr.
        * wtf/NullPtr.cpp: Updated condition to match.

        * wtf/PassOwnArrayPtr.h: Don't include the operator=(nullptr_t)
        overload if we are compiling in loose mode and the compiler has
        nullptr, because assignment of 0 will otherwise encounter
        ambiguitity with this overload and the overload for loose mode
        that takes a raw pointer. The conditional can be removed when we
        get rid of loose mode.
        * wtf/PassOwnPtr.h: Ditto.

        * wtf/PassRefPtr.h: Don't include the operator=(nullptr_t) overload
        if the compiler has nullptr, because assignment of 0 would be
        ambiguous with the overload that takes a raw pointer. The conditional
        can be removed if we ever decide we no longer need to support
        assigning 0, but might need a way to catch that usage on older compilers.
        * wtf/RefPtr.h: Ditto.
        * wtf/RetainPtr.h: Ditto

        * JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.cpp,
        accidentally omitted when the file was first added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 27 Dec 2010 21:13:03 +0000 (21:13 +0000)]
2010-12-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        build-webkit should detect missing Java SDK and explain how to install it
        https://bugs.webkit.org/show_bug.cgi?id=51651

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Add additional API for managing databases
weinig@apple.com [Mon, 27 Dec 2010 21:04:45 +0000 (21:04 +0000)]
WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629

Reviewed by Anders Carlsson.

- Adds client for the database manager to get notifications
  of changes to databases.

* UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerSetClient):
* UIProcess/API/C/WKDatabaseManager.h:
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):
* UIProcess/WebDatabaseManagerProxy.h:
* UIProcess/WebDatabaseManagerProxy.messages.in:
* UIProcess/WebDatabaseManagerProxyClient.cpp: Added.
(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):
* UIProcess/WebDatabaseManagerProxyClient.h: Added.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::~WebDatabaseManager):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
* win/WebKit2.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Makefile based build.
weinig@apple.com [Mon, 27 Dec 2010 19:41:35 +0000 (19:41 +0000)]
Fix Makefile based build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-27 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 27 Dec 2010 19:21:08 +0000 (19:21 +0000)]
2010-12-27  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Remove unneeded includes from our headers.

        * WebCoreSupport/PasteboardHelperGtk.h: ditto.
        * webkit/webkitprivate.h: ditto.
        * webkit/webkitsoupauthdialog.h: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74691 268f45cc-cd09-0410-ab3c-d52691b4dbfc