WebKit.git
10 years agoMove JavaScriptGlue into Sources
abarth@webkit.org [Fri, 24 Dec 2010 09:01:54 +0000 (09:01 +0000)]
Move JavaScriptGlue into Sources
https://bugs.webkit.org/show_bug.cgi?id=51583

Rubber-stamped by Eric Seidel.

Actually perform the move.

* JavaScriptGlue: Removed.
* JavaScriptGlue/Configurations: Removed.
* JavaScriptGlue/Configurations/Base.xcconfig: Removed.
* JavaScriptGlue/Configurations/DebugRelease.xcconfig: Removed.
* JavaScriptGlue/Configurations/JavaScriptGlue.xcconfig: Removed.
* JavaScriptGlue/Configurations/Version.xcconfig: Removed.
* JavaScriptGlue/English.lproj: Removed.
* JavaScriptGlue/English.lproj/InfoPlist.strings: Removed.
* JavaScriptGlue/ForwardingHeaders: Removed.
* JavaScriptGlue/ForwardingHeaders/masm: Removed.
* JavaScriptGlue/ForwardingHeaders/masm/X86Assembler.h: Removed.
* JavaScriptGlue/ForwardingHeaders/profiler: Removed.
* JavaScriptGlue/ForwardingHeaders/profiler/Profiler.h: Removed.
* JavaScriptGlue/ForwardingHeaders/runtime: Removed.
* JavaScriptGlue/ForwardingHeaders/runtime/CallFrame.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ASCIICType.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/AlwaysInline.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Assertions.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Atomics.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Bitmap.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/BumpPointerAllocator.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/CurrentTime.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/DateInstanceCache.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/DateMath.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FastAllocBase.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FixedArray.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Forward.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashCountedSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashFunctions.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashMap.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashTraits.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ListHashSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ListRefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Locker.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/MainThread.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/MathExtras.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Noncopyable.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/NotFound.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OSAllocator.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnPtrCommon.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageAllocation.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageAllocationAligned.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageBlock.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageReservation.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassOwnArrayPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassOwnPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Platform.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PossiblyNull.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RandomNumber.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StackBounds.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StringHasher.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadSpecific.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Threading.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadingPrimitives.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/UnusedParam.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/VMTags.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ValueCheck.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Vector.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/VectorTraits.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/CString.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringHash.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringImpl.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringImplBase.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/TextPosition.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/WTFString.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/Unicode.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed.
* JavaScriptGlue/Info.plist: Removed.
* JavaScriptGlue/JSBase.cpp: Removed.
* JavaScriptGlue/JSBase.h: Removed.
* JavaScriptGlue/JSObject.cpp: Removed.
* JavaScriptGlue/JSObject.h: Removed.
* JavaScriptGlue/JSRun.cpp: Removed.
* JavaScriptGlue/JSRun.h: Removed.
* JavaScriptGlue/JSUtils.cpp: Removed.
* JavaScriptGlue/JSUtils.h: Removed.
* JavaScriptGlue/JSValueWrapper.cpp: Removed.
* JavaScriptGlue/JSValueWrapper.h: Removed.
* JavaScriptGlue/JavaScriptGlue.cpp: Removed.
* JavaScriptGlue/JavaScriptGlue.exp: Removed.
* JavaScriptGlue/JavaScriptGlue.h: Removed.
* JavaScriptGlue/JavaScriptGlue.xcodeproj: Removed.
* JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj: Removed.
* JavaScriptGlue/LICENSE: Removed.
* JavaScriptGlue/Makefile: Removed.
* JavaScriptGlue/UserObjectImp.cpp: Removed.
* JavaScriptGlue/UserObjectImp.h: Removed.
* JavaScriptGlue/config.h: Removed.
* JavaScriptGlue/icu: Removed.
* JavaScriptGlue/icu/LICENSE: Removed.
* JavaScriptGlue/icu/README: Removed.
* JavaScriptGlue/icu/unicode: Removed.
* JavaScriptGlue/icu/unicode/platform.h: Removed.
* JavaScriptGlue/icu/unicode/putil.h: Removed.
* JavaScriptGlue/icu/unicode/uchar.h: Removed.
* JavaScriptGlue/icu/unicode/ucnv.h: Removed.
* JavaScriptGlue/icu/unicode/ucnv_err.h: Removed.
* JavaScriptGlue/icu/unicode/uconfig.h: Removed.
* JavaScriptGlue/icu/unicode/uenum.h: Removed.
* JavaScriptGlue/icu/unicode/uiter.h: Removed.
* JavaScriptGlue/icu/unicode/umachine.h: Removed.
* JavaScriptGlue/icu/unicode/urename.h: Removed.
* JavaScriptGlue/icu/unicode/ustring.h: Removed.
* JavaScriptGlue/icu/unicode/utf.h: Removed.
* JavaScriptGlue/icu/unicode/utf16.h: Removed.
* JavaScriptGlue/icu/unicode/utf8.h: Removed.
* JavaScriptGlue/icu/unicode/utf_old.h: Removed.
* JavaScriptGlue/icu/unicode/utypes.h: Removed.
* JavaScriptGlue/icu/unicode/uversion.h: Removed.
* JavaScriptGlue/testjsglue.cpp: Removed.
* Makefile:
* Sources: Added.
* Sources/JavaScriptGlue: Copied from JavaScriptGlue.
* Sources/Makefile: Added.

Tools:

These tools refer to JavaScriptGlue and need to be updated to its new
location.

* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/webkitpy/common/config/build.py:
* Scripts/webkitpy/common/config/build_unittest.py:

Websites/bugs.webkit.org:

PrettyPatch keeps a list of the top-level directories that exist in
trac.

* PrettyPatch/PrettyPatch.rb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 24 Dec 2010 08:06:49 +0000 (08:06 +0000)]
2010-12-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        [WINCE] Add CPU(MIPS) detection
        https://bugs.webkit.org/show_bug.cgi?id=51342

        WinCE usually defines MIPS and _MIPS_.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Fri, 24 Dec 2010 06:14:39 +0000 (06:14 +0000)]
2010-12-23  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Eric Seidel.

        Bug 51539 - update iexploder scripts to point to new location

        * Scripts/run-iexploder-tests:
        * Scripts/update-iexploder-cssproperties:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake dragging work again after r74591.
mitz@apple.com [Fri, 24 Dec 2010 06:11:19 +0000 (06:11 +0000)]
Make dragging work again after r74591.

Reviewed by Sam Weinig.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Fixed a typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Dec 2010 06:05:13 +0000 (06:05 +0000)]
2010-12-23  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Update GTK's Skipped file.

        [GTK] http/tests/inspector/console-websocket-error.html hangs
        https://bugs.webkit.org/show_bug.cgi?id=51380

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed GTK fix after r74609: put the right file name in the Skipped file.
ariya@webkit.org [Fri, 24 Dec 2010 05:26:28 +0000 (05:26 +0000)]
Unreviewed GTK fix after r74609: put the right file name in the Skipped file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Dec 2010 04:59:58 +0000 (04:59 +0000)]
2010-12-23  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Update Chromium test expectations.

        Mark http/tests/inspector/console-websocket-error.html as SLOW on WIN DEBUG.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Dec 2010 04:50:00 +0000 (04:50 +0000)]
2010-12-22  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Alexey Proskuryakov.

        [GTK] http/tests/inspector/console-websocket-error.html hangs
        https://bugs.webkit.org/show_bug.cgi?id=51380

        The test should call dumpConsoleMessages() even if WebSocket is not supported
        or a WebSocket object goes to an unexpected state.

        * http/tests/inspector/console-websocket-error.html:
        * platform/gtk/Skipped:
        * platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
        * platform/mac/http/tests/inspector/console-websocket-error-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 24 Dec 2010 04:31:50 +0000 (04:31 +0000)]
2010-12-23  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        ViewportArguments.h uses an enum to intialize a bool
        https://bugs.webkit.org/show_bug.cgi?id=50982

        Initialize userScalable to true, rather than -1.
        No tests; fixes a compiler warning.

        * dom/ViewportArguments.h:
        (WebCore::ViewportArguments::ViewportArguments):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] User name/password stripped from URLs
ariya@webkit.org [Fri, 24 Dec 2010 04:06:26 +0000 (04:06 +0000)]
[Qt] User name/password stripped from URLs
https://bugs.webkit.org/show_bug.cgi?id=36232

Patch by Jan Erik Hanssen <jhanssen@sencha.com> on 2010-12-23
Reviewed by Adam Barth.

WebCore:

If a username but no password or no username but a password is present
in a URL, QtWebKit won't send any authentication information down to Qt
as it should.

Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html
       http/tests/xmlhttprequest/basic-auth-nouser.html

* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

LayoutTests:

Test authentication cases where a username but no password and
no username but a password is present.

* http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* http/tests/xmlhttprequest/basic-auth-nopassword.html: Added.
* http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
* http/tests/xmlhttprequest/basic-auth-nouser.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth-nouserpass/basic-auth-nouserpass.php: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/mac-snowleopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/mac-tiger/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 03:40:54 +0000 (03:40 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt rebaseline for r74593.

        Added the forgotten blank line at the end.

        * platform/qt/editing/pasteboard/copy-in-password-field-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 03:18:27 +0000 (03:18 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt rebaseline for r74593.

        * platform/qt/editing/pasteboard/copy-in-password-field-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:56:45 +0000 (02:56 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        More unreviewed Chromium rebaselines for r74593.

        * platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
        * platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 02:53:41 +0000 (02:53 +0000)]
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Alexey Proskuryakov.

        [Qt] Composition text is not removed from the editor when composition is cancelled
        https://bugs.webkit.org/show_bug.cgi?id=29391

        Ensure that the composition text is cleared when an empty QInputMethodEvent
        is received and the editor is in composition mode.

        * editing/input/ime-composition-clearpreedit-expected.txt: Added.
        * editing/input/ime-composition-clearpreedit.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Alexey Proskuryakov.

        [Qt] Composition text is not removed from the editor when composition is cancelled
        https://bugs.webkit.org/show_bug.cgi?id=29391

        Ensure that the composition text is cleared when an empty QInputMethodEvent
        is received and the editor is in composition mode.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Benjamin Kalman <kalman@chromium.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:38:21 +0000 (02:38 +0000)]
2010-12-23  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Selection becomes stale when CharacterData is manipulated directly
        https://bugs.webkit.org/show_bug.cgi?id=51389

        Rebaseline GTK tests.

        * platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-and-undo-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/gtk/editing/deleting/delete-br-007-expected.txt:
        * platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
        * platform/gtk/editing/deleting/delete-tab-002-expected.txt:
        * platform/gtk/editing/deleting/delete-tab-004-expected.txt:
        * platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/gtk/editing/deleting/forward-delete-expected.txt:
        * platform/gtk/editing/deleting/smart-delete-003-expected.txt:
        * platform/gtk/editing/deleting/smart-delete-004-expected.txt:
        * platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
        * platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/gtk/editing/inserting/insert-div-003-expected.txt:
        * platform/gtk/editing/inserting/insert-div-024-expected.txt:
        * platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/gtk/editing/inserting/typing-001-expected.txt:
        * platform/gtk/editing/inserting/typing-002-expected.txt:
        * platform/gtk/editing/inserting/typing-003-expected.txt:
        * platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
        * platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
        * platform/gtk/editing/pasteboard/4076267-2-expected.txt:
        * platform/gtk/editing/pasteboard/4076267-3-expected.txt:
        * platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
        * platform/gtk/editing/pasteboard/paste-xml-expected.txt:
        * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * platform/gtk/editing/spelling/spelling-expected.txt:
        * platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
        * platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
        * platform/gtk/editing/style/typing-style-001-expected.txt:
        * platform/gtk/editing/style/typing-style-002-expected.txt:
        * platform/gtk/editing/style/unbold-in-bold-expected.txt:
        * platform/gtk/editing/undo/4063751-expected.txt:
        * platform/gtk/editing/undo/redo-typing-001-expected.txt:
        * platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-combined-delete-expected.txt:
        * platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-delete-expected.txt:
        * platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-forward-delete-expected.txt:
        * platform/gtk/editing/undo/undo-misspellings-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:33:40 +0000 (02:33 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue("FormatBlock") does not respect editing boundaries
        https://bugs.webkit.org/show_bug.cgi?id=51219

        Added test cases to ensure queryCommandValue("FormatBlock") respects editing boundaries.

        * editing/execCommand/query-format-block-expected.txt:
        * editing/execCommand/script-tests/query-format-block.js:
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue("FormatBlock") does not respect editing boundaries
        https://bugs.webkit.org/show_bug.cgi?id=51219

        Fixed the bug by checking the element we found in elementForFormatBlockCommand
        does not contain the editable root.

        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::elementForFormatBlockCommand):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:17:57 +0000 (02:17 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines for r74593.

        * platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
        * platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
        * platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
        * platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
        * platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
        * platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/chromium-win/editing/deleting/delete-block-table-expected.txt:
        * platform/chromium-win/editing/deleting/delete-br-007-expected.txt:
        * platform/chromium-win/editing/deleting/delete-character-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-hr-expected.txt:
        * platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
        * platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/chromium-win/editing/deleting/forward-delete-expected.txt:
        * platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
        * platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
        * platform/chromium-win/editing/deleting/smart-delete-003-expected.txt:
        * platform/chromium-win/editing/deleting/smart-delete-004-expected.txt:
        * platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
        * platform/chromium-win/editing/inserting/4278698-expected.txt:
        * platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
        * platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-009-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
        * platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/chromium-win/editing/inserting/insert-tab-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * platform/chromium-win/editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/chromium-win/editing/inserting/typing-001-expected.txt:
        * platform/chromium-win/editing/inserting/typing-002-expected.txt:
        * platform/chromium-win/editing/inserting/typing-003-expected.txt:
        * platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
        * platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
        * platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
        * platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
        * platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
        * platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/chromium-win/editing/spelling/spelling-expected.txt:
        * platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
        * platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
        * platform/chromium-win/editing/style/style-boundary-002-expected.txt:
        * platform/chromium-win/editing/style/style-boundary-005-expected.txt:
        * platform/chromium-win/editing/style/typing-style-001-expected.txt:
        * platform/chromium-win/editing/style/typing-style-002-expected.txt:
        * platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
        * platform/chromium-win/editing/undo/4063751-expected.txt:
        * platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
        * platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
        * platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
        * platform/chromium-win/editing/undo/undo-delete-expected.txt:
        * platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
        * platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
        * platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
        * platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
        * platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
        * platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
        * platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:14:28 +0000 (02:14 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        FormatBlock doesn't preserve typing style but it should
        https://bugs.webkit.org/show_bug.cgi?id=51140

        Added a test to type text after bolding the typing style and executing a FormatBlock command.
        Because FormatBlock command preserves typing style, the typed text should be in bold.

        * editing/execCommand/format-block-typing-style.html: Added.
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        FormatBlock doesn't preserve typing style but it should
        https://bugs.webkit.org/show_bug.cgi?id=51140

        Fixed the bug by making preserveTypingStyle return true.

        Test: editing/execCommand/format-block-typing-style.html

        * editing/FormatBlockCommand.h:
        (WebCore::FormatBlockCommand::preservesTypingStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename RegexCompiler.cpp to RegexPattern.cpp.
barraclough@apple.com [Fri, 24 Dec 2010 01:40:54 +0000 (01:40 +0000)]
Rename RegexCompiler.cpp to RegexPattern.cpp.
Implicitly call compileRegex from RegexPattern's constructor.

Reviewed by Sam Weinig.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
* yarr/RegexCompiler.cpp: Removed.
* yarr/RegexCompiler.h: Removed.
* yarr/RegexInterpreter.cpp:
* yarr/RegexJIT.cpp:
* yarr/RegexPattern.cpp: Copied from JavaScriptCore/yarr/RegexCompiler.cpp.
(JSC::Yarr::compileRegex):
(JSC::Yarr::RegexPattern::RegexPattern):
* yarr/RegexPattern.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 01:36:39 +0000 (01:36 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt rebaselines for r74593.

        * platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
        * platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
        * platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
        * platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/qt/editing/deleting/delete-character-001-expected.txt:
        * platform/qt/editing/deleting/delete-hr-expected.txt:
        * platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/qt/editing/deleting/delete-selection-001-expected.txt:
        * platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
        * platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/qt/editing/deleting/non-smart-delete-expected.txt:
        * platform/qt/editing/deleting/smart-delete-001-expected.txt:
        * platform/qt/editing/deleting/smart-delete-003-expected.txt:
        * platform/qt/editing/deleting/smart-delete-004-expected.txt:
        * platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/qt/editing/inserting/insert-br-003-expected.txt:
        * platform/qt/editing/inserting/insert-br-006-expected.txt:
        * platform/qt/editing/inserting/insert-br-007-expected.txt:
        * platform/qt/editing/inserting/insert-br-008-expected.txt:
        * platform/qt/editing/inserting/insert-br-009-expected.txt:
        * platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * platform/qt/editing/inserting/insert-div-003-expected.txt:
        * platform/qt/editing/inserting/insert-div-006-expected.txt:
        * platform/qt/editing/inserting/insert-div-008-expected.txt:
        * platform/qt/editing/inserting/insert-div-024-expected.txt:
        * platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * platform/qt/editing/inserting/typing-001-expected.txt:
        * platform/qt/editing/inserting/typing-002-expected.txt:
        * platform/qt/editing/inserting/typing-003-expected.txt:
        * platform/qt/editing/inserting/typing-around-br-001-expected.txt:
        * platform/qt/editing/inserting/typing-around-image-001-expected.txt:
        * platform/qt/editing/pasteboard/4076267-3-expected.txt:
        * platform/qt/editing/pasteboard/cut-text-001-expected.txt:
        * platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-1-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-2-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-4-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-list-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-table-expected.txt:
        * platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-019-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/qt/editing/pasteboard/pasting-object-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt:
        * platform/qt/editing/undo/redo-style-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 24 Dec 2010 01:19:00 +0000 (01:19 +0000)]
2010-12-23  Evan Martin  <evan@chromium.org>

        Reviewed by Ryosuke Niwa.

        [chromium] LayoutTestController warning in float->int conversion
        https://bugs.webkit.org/show_bug.cgi?id=51553

        Rather than reading an int, converting to a float, then getting a compiler
        warning on passing the float to something that expects an int, instead
        just pass around ints.

        No tests, fixes a compiler warning.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (parsePageSizeParameters):
        (LayoutTestController::pageNumberForElementById):
        (LayoutTestController::numberOfPages):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed WebKit2 API to create a SecurityOrigin from protocol, host, and port
jberlin@webkit.org [Fri, 24 Dec 2010 01:16:19 +0000 (01:16 +0000)]
Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
https://bugs.webkit.org/show_bug.cgi?id=51563

Reviewed by Sam Weinig.

WebCore:

Add SecurityOrigin::create(const String& protocol, const String& host, int port).

* WebCore.exp.in:
Export the symbols for WebCore::SecurityOrigin::create(String, String, int).

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
Use the constant MaxAllowedPort.
(WebCore::SecurityOrigin::create):
Sanitizing based off of that done in createFromDatabaseIdentifier.
* page/SecurityOrigin.h:

WebKit2:

Add WKSecurityOriginCreate(WKStringRef protocol, WKStringRef host, int port).

* Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCreateFromIdentifier):
Renamed so as not to clash with the new WKSecurityOriginCreate.
(WKSecurityOriginCreate):
* Shared/API/c/WKSecurityOrigin.h:
* Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 24 Dec 2010 01:11:04 +0000 (01:11 +0000)]
2010-12-23  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for WinCE after r73802.

        Reapply r70812:
        Port ContextMenuItemWin.cpp to WinCE
        https://bugs.webkit.org/show_bug.cgi?id=48407

        * platform/win/ContextMenuItemWin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 24 Dec 2010 01:03:23 +0000 (01:03 +0000)]
2010-12-23  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for WinCE after r74360.

        Move the OS(WINDOWS) section after the OS(WINCE) section
        and add missing argument to the getStackMax call.

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 24 Dec 2010 00:55:48 +0000 (00:55 +0000)]
2010-12-23  Adam Barth  <abarth@webkit.org>

        Remove include of non-existant file.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 00:22:00 +0000 (00:22 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Selection becomes stale when CharacterData is manipulated directly
        https://bugs.webkit.org/show_bug.cgi?id=51389

        The bug was caused by SelectionController's not adjusting selection when CharacterData's
        m_data is modified by its API.

        Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
        CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
        textWillBeReplaced because inserting, replacing, or removing data may require moving
        the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).

        Also fixed the condition for determining whether or not a node intersects the selection
        in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
        failed to recognize certain cases when selection started and ended with non-zero offsets.

        Tests: editing/selection/character-data-mutation-crash.html
               editing/selection/character-data-mutation.html

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate.
        (WebCore::CharacterData::appendData): Ditto.
        (WebCore::CharacterData::insertData): Ditto.
        (WebCore::CharacterData::deleteData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.
        (WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list,
        and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
        * dom/CharacterData.h:
        * editing/SelectionController.cpp:
        (WebCore::removingNodeRemovesPosition): Removed indentations from blank lines.
        (WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved.
        (WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved;
        fixed the logic to figure out whether a node is inside the range or not.
        (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added.
        (WebCore::SelectionController::textWillBeReplaced): Added.
        * editing/SelectionController.h:
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Selection becomes stale when CharacterData is manipulated directly
        https://bugs.webkit.org/show_bug.cgi?id=51389

        Added tests to ensure WebKit adjusts or clears selection when the start container
        or the end container of the selection's first range is modified by CharacterData's API.

        Many editing tests had to be rebaselined due to different editing delegate dumps
        caused by WebKit's properly adjusting selection's offsets as editing commands modify the DOM.

        * editing/deleting/delete-by-word-001-expected.txt:
        * editing/deleting/delete-by-word-002-expected.txt:
        * editing/deleting/delete-ligature-001-expected.txt:
        * editing/deleting/delete-ligature-002-expected.txt:
        * editing/deleting/delete-ligature-003-expected.txt:
        * editing/deleting/skip-virama-001-expected.txt:
        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/hilitecolor-expected.txt:
        * editing/execCommand/unlink-expected.txt:
        * editing/inserting/insert-thai-characters-001-expected.txt:
        * editing/pasteboard/copy-in-password-field-expected.txt:
        * editing/pasteboard/paste-into-anchor-text-expected.txt:
        * editing/selection/character-data-mutation-crash-expected.txt: Added.
        * editing/selection/character-data-mutation-crash.html: Added.
        * editing/selection/character-data-mutation-expected.txt: Added.
        * editing/selection/character-data-mutation.html: Added.
        * editing/style/remove-underline-from-stylesheet-expected.txt:
        * editing/style/typing-style-003-expected.txt:
        * editing/undo/redo-style-expected.txt:
        * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
        * platform/mac/editing/deleting/delete-and-undo-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/mac/editing/deleting/delete-block-table-expected.txt:
        * platform/mac/editing/deleting/delete-br-007-expected.txt:
        * platform/mac/editing/deleting/delete-character-001-expected.txt:
        * platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-hr-expected.txt:
        * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-listitem-001-expected.txt:
        * platform/mac/editing/deleting/delete-selection-001-expected.txt:
        * platform/mac/editing/deleting/delete-tab-001-expected.txt:
        * platform/mac/editing/deleting/delete-tab-002-expected.txt:
        * platform/mac/editing/deleting/delete-tab-003-expected.txt:
        * platform/mac/editing/deleting/delete-tab-004-expected.txt:
        * platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/mac/editing/deleting/forward-delete-expected.txt:
        * platform/mac/editing/deleting/non-smart-delete-expected.txt:
        * platform/mac/editing/deleting/smart-delete-001-expected.txt:
        * platform/mac/editing/deleting/smart-delete-002-expected.txt:
        * platform/mac/editing/deleting/smart-delete-003-expected.txt:
        * platform/mac/editing/deleting/smart-delete-004-expected.txt:
        * platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
        * platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
        * platform/mac/editing/input/text-input-controller-expected.txt:
        * platform/mac/editing/inserting/4278698-expected.txt:
        * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
        * platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/mac/editing/inserting/insert-br-003-expected.txt:
        * platform/mac/editing/inserting/insert-br-006-expected.txt:
        * platform/mac/editing/inserting/insert-br-007-expected.txt:
        * platform/mac/editing/inserting/insert-br-008-expected.txt:
        * platform/mac/editing/inserting/insert-br-009-expected.txt:
        * platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * platform/mac/editing/inserting/insert-div-003-expected.txt:
        * platform/mac/editing/inserting/insert-div-006-expected.txt:
        * platform/mac/editing/inserting/insert-div-008-expected.txt:
        * platform/mac/editing/inserting/insert-div-024-expected.txt:
        * platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/mac/editing/inserting/insert-tab-003-expected.txt:
        * platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/mac/editing/inserting/typing-001-expected.txt:
        * platform/mac/editing/inserting/typing-002-expected.txt:
        * platform/mac/editing/inserting/typing-003-expected.txt:
        * platform/mac/editing/inserting/typing-around-br-001-expected.txt:
        * platform/mac/editing/inserting/typing-around-image-001-expected.txt:
        * platform/mac/editing/pasteboard/4076267-2-expected.txt:
        * platform/mac/editing/pasteboard/4076267-3-expected.txt:
        * platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
        * platform/mac/editing/pasteboard/cut-text-001-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
        * platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-1-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-2-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-4-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-list-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-table-expected.txt:
        * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-019-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/mac/editing/pasteboard/paste-xml-expected.txt:
        * platform/mac/editing/pasteboard/pasting-object-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * platform/mac/editing/spelling/spelling-expected.txt:
        * platform/mac/editing/style/style-3681552-fix-001-expected.txt:
        * platform/mac/editing/style/style-3681552-fix-002-expected.txt:
        * platform/mac/editing/style/style-boundary-002-expected.txt:
        * platform/mac/editing/style/style-boundary-005-expected.txt:
        * platform/mac/editing/style/typing-style-001-expected.txt:
        * platform/mac/editing/style/typing-style-002-expected.txt:
        * platform/mac/editing/style/unbold-in-bold-expected.txt:
        * platform/mac/editing/undo/4063751-expected.txt:
        * platform/mac/editing/undo/redo-typing-001-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-expected.txt:
        * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-delete-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-expected.txt:
        * platform/mac/editing/undo/undo-misspellings-expected.txt:
        * platform/mac/editing/undo/undo-typing-001-expected.txt:
        * platform/mac/editing/unsupported-content/list-type-after-expected.txt:
        * platform/mac/editing/unsupported-content/list-type-before-expected.txt:
        * platform/mac/editing/unsupported-content/table-type-after-expected.txt:
        * platform/mac/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 24 Dec 2010 00:00:38 +0000 (00:00 +0000)]
2010-12-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove unneeded V8 bindings files
        https://bugs.webkit.org/show_bug.cgi?id=51570

        * WebCore.gypi:
        * bindings/generic/BindingDOMWindow.h: Removed.
        * bindings/v8/specialization/V8BindingDOMWindow.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 23:55:41 +0000 (23:55 +0000)]
2010-12-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Ensure that we are not getting too many mouse move events
        https://bugs.webkit.org/show_bug.cgi?id=51568
        <rdar://problem/7881470>
        <rdar://problem/8735512>

        Implement throttling of mouse move events.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize m_processingMouseMoveEvent to false.

        (WebKit::WebPageProxy::handleMouseEvent):
        If we're already processing a mouse move events, just update
        m_nextMouseMoveEvent and return.

        (WebKit::WebPageProxy::didReceiveEvent):
        If we received a mouse move event, send the next mouse move event if there is one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mitz@apple.com [Thu, 23 Dec 2010 23:43:15 +0000 (23:43 +0000)]
Build fix.

* editing/EditorCommand.cpp:
(WebCore::enabledDismissCorrectionPanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix crash seen on GTK bot.
darin@apple.com [Thu, 23 Dec 2010 23:42:11 +0000 (23:42 +0000)]
Try to fix crash seen on GTK bot.

* editing/EditorCommand.cpp:
(WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.

* WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion when loading www.yahoo.com in WebKit2 under decodeResourceRequest
bweinstein@apple.com [Thu, 23 Dec 2010 23:36:16 +0000 (23:36 +0000)]
Assertion when loading yahoo.com in WebKit2 under decodeResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=51562

Reviewed by Anders Carlsson.

Don't assert that our data reference isn't empty when we try to get the data from it.
If it is empty, just return 0.

All callers are safe with this function returning 0.

* Platform/CoreIPC/DataReference.h:
(CoreIPC::DataReference::data): Change the assert to an early return.
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode): Add an assert, and remove a ternarny operator because the function now does
    this for us (if the data is empty, return 0).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Sheriff Bot <webkit.review.bot@gmail.com>
kbr@google.com [Thu, 23 Dec 2010 23:15:32 +0000 (23:15 +0000)]
2010-12-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74561.
        http://trac.webkit.org/changeset/74561
        https://bugs.webkit.org/show_bug.cgi?id=51565

        "Broke Chromium UI tests on Vista" (Requested by kbr_google on
        #webkit).

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
2010-12-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74561.
        http://trac.webkit.org/changeset/74561
        https://bugs.webkit.org/show_bug.cgi?id=51565

        "Broke Chromium UI tests on Vista" (Requested by kbr_google on
        #webkit).

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 23:10:45 +0000 (23:10 +0000)]
2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Darin Adler.

        WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
        https://bugs.webkit.org/show_bug.cgi?id=38535

        WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
        if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
        WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
        call frame from this stack when an exception throws because the saved top frame could be invalid.

        To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
        callEvent and returnEvent.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::willExecuteProgram):
        (WebScriptDebugger::didExecuteProgram):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 23 Dec 2010 23:08:37 +0000 (23:08 +0000)]
2010-12-23  Kenneth Russell  <kbr@google.com>

        Unreviewed Chromium test expectations update. Fix botched update
        of fast/css/box-shadow.html expectation; needed to be FAIL, not
        IMAGE+TEXT IMAGE.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix incorrect assertion causing all pages with subframes to crash.
weinig@apple.com [Thu, 23 Dec 2010 22:49:10 +0000 (22:49 +0000)]
Fix incorrect assertion causing all pages with subframes to crash.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::appendChild):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed out-of-order ChangeLog.
darin@apple.com [Thu, 23 Dec 2010 22:40:19 +0000 (22:40 +0000)]
Fixed out-of-order ChangeLog.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Darin Adler <darin@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 22:34:52 +0000 (22:34 +0000)]
2010-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WKView should not try to do asynchronous validation for selectors that are not editor commands
        https://bugs.webkit.org/show_bug.cgi?id=51555

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking.
        Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation
        for commands that are supported. Tweaked comments and added some bug numbers.
        (-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added
        bug number.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 22:23:58 +0000 (22:23 +0000)]
2010-12-23  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
        https://bugs.webkit.org/show_bug.cgi?id=51507

        Adds WebThemeEngine for the Mac (it already has parallel definitions for
        Windows and Linux) so that scrollbar thumb rendering can be overridden
        for the DRT (to be consistent with the NSScroller-based rendering
        used by the Mac port).

        No new tests since the functionality is not exposed yet. Eventually will
        result in the Chromium/Mac port being able to use the same pixel
        baselines for layout tests as the Mac port.

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
2010-12-23  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
        https://bugs.webkit.org/show_bug.cgi?id=51507

        Adds WebThemeEngine for the Mac (it already has parallel definitions for
        Windows and Linux) so that scrollbar thumb rendering can be overridden
        for the DRT (to be consistent with the NSScroller-based rendering
        used by the Mac port).

        * public/mac/WebThemeEngine.h: Added.
        (WebKit::WebThemeEngine::paintScrollbarThumb):
        * src/AssertMatchingEnums.cpp:
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::paintScrollbarThumb):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Dec 2010 22:20:43 +0000 (22:20 +0000)]
2010-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WKView should not try to do asynchronous validation for selectors that are not editor commands
        https://bugs.webkit.org/show_bug.cgi?id=51555

        * WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
        * editing/Editor.h: Reordered arguments in the Editor::Command constructor
        and the data members too so the frame is last. Added
        commandIsSupportedFromMenuOrKeyBinding.

        * editing/EditorCommand.cpp:
        (WebCore::supported): Removed the EditorCommandSource argument. These
        functions are now only used when called from DOM.
        (WebCore::supportedFromMenuOrKeyBinding): Ditto.
        (WebCore::supportedCopyCut): Ditto.
        (WebCore::supportedPaste): Ditto.
        (WebCore::enabledDismissCorrectionPanel): Changed the supported function to
        an enabled function. It was incorrect to say that this is "supported" only
        when the correction panel is up. Correct to say that it is "enabled" only
        then. And also probably OK to enable it even when the selection is not in
        editable text, as long as the panel is up.
        (WebCore::createCommandMap): Moved conditional commands out of the main
        array into a separate section at the end.
        (WebCore::internalCommand): Added.
        (WebCore::Editor::command): Changed to use the new internalCommand function
        and simplified by relying on the null check in the Command constructor.
        (WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added.
        (WebCore::Editor::Command::Command): Removed unneeded initialization of
        m_source, which is never looked at if m_command is 0. Added feature of
        passing a null command pointer to the non-default constructor.
        (WebCore::Editor::Command::isSupported): Changed to only call the
        per-command isSupported function when the command source is DOM.
        Accordingly that function is now called isSupportedFromDOM.
2010-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WKView should not try to do asynchronous validation for selectors that are not editor commands
        https://bugs.webkit.org/show_bug.cgi?id=51555

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking.
        Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation
        for commands that are supported. Tweaked comments and added some bug numbers.
        (-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added
        bug number.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 23 Dec 2010 22:15:12 +0000 (22:15 +0000)]
2010-12-23  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
        https://bugs.webkit.org/show_bug.cgi?id=51560

        No new tests.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setAcceleratesDrawing):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Chromium layout test expectations update.
ajwong@chromium.org [Thu, 23 Dec 2010 21:28:25 +0000 (21:28 +0000)]
Unreviewed. Chromium layout test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=51500

Rebaseline media control layout tests due to pixel diff from r74535

* platform/chromium-linux/media/audio-controls-rendering-expected.checksum:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.checksum:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.checksum:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.checksum:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.checksum:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.checksum:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.checksum:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.checksum:
* platform/chromium-linux/media/video-empty-source-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.checksum:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.checksum:
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/controls-after-reload-expected.checksum:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-strict-expected.checksum:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-strict-expected.txt:
* platform/chromium-mac/media/controls-styling-expected.checksum:
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.checksum:
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.txt:
* platform/chromium-mac/media/video-display-toggle-expected.checksum:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.checksum:
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.checksum:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.checksum:
* platform/chromium-mac/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.checksum:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.checksum:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.checksum:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.checksum:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.checksum:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.checksum:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.checksum:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.checksum:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.checksum:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.checksum:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 21:08:12 +0000 (21:08 +0000)]
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
        https://bugs.webkit.org/show_bug.cgi?id=35635

        Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
        tag informing the OS that the data is in UTF-8 format.

        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeSelection):
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
        https://bugs.webkit.org/show_bug.cgi?id=35635

        Test that QClipboard contains the charset information and unicode data
        after copying unicode text.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::macCopyUnicodeToClipboard):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 23 Dec 2010 21:02:57 +0000 (21:02 +0000)]
2010-12-23  Kenneth Russell  <kbr@google.com>

        Unreviewed Chromium expectations update. Suppress crashes seen on
        Windows with fast/canvas/webgl/canvas-test.html and
        fast/canvas/webgl/gl-pixelstorei.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8799032>
weinig@apple.com [Thu, 23 Dec 2010 20:58:47 +0000 (20:58 +0000)]
<rdar://problem/8799032>
REGRESSION(r74436) Crash opening many pages with WebKit2

Reviewed by Anders Carlsson.

* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
Fix paste-o. Decode into a CFDataRef not a CFDictionaryRef
when decoding CFDataRefs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 23 Dec 2010 20:38:09 +0000 (20:38 +0000)]
2010-12-23  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Eric Seidel.

        CSSCursorImageValue destructor should clear referenced element.
        https://bugs.webkit.org/show_bug.cgi?id=51417

        Calls correct method to clear image and renames method to avoid future confusion.

        Test: svg/css/cursor-image-replace.svg

        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::cursorImageValueRemoved):
        * svg/SVGElement.h:
2010-12-23  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Eric Seidel.

        CSSCursorImageValue destructor should clear referenced element.
        https://bugs.webkit.org/show_bug.cgi?id=51417

        * svg/css/cursor-image-replace-expected.txt: Added.
        * svg/css/cursor-image-replace.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 23 Dec 2010 20:22:07 +0000 (20:22 +0000)]
2010-12-23  Kenneth Russell  <kbr@google.com>

        Unreviewed Chromium expectations update. Allow
        fast/css/box-shadow.html to fail with IMAGE as well as IMAGE+TEXT.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
weinig@apple.com [Thu, 23 Dec 2010 20:11:16 +0000 (20:11 +0000)]
Fix build.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didSaveToPageCache):
(WebKit::FrameLoaderClientImpl::didRestoreFromPageCache):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 needs to mirror the frame tree in the UIProcess
weinig@apple.com [Thu, 23 Dec 2010 20:10:01 +0000 (20:10 +0000)]
WebKit2 needs to mirror the frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=51546

Reviewed by Darin Adler.

WebCore:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
* history/CachedFrame.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didSaveToPageCache):
(WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache):
* loader/FrameLoaderClient.h:

WebKit/chromium:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* src/FrameLoaderClientImpl.cpp:
(WebKit::WebFrameLoaderClientImpl::didSaveToPageCache):
(WebKit::WebFrameLoaderClientImpl::didRestoreFromPageCache):
* src/FrameLoaderClientImpl.h:

WebKit/efl:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didSaveToPageCache):
(WebCore::FrameLoaderClientEfl::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::didSaveToPageCache):
(WebKit::FrameLoaderClient::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::didSaveToPageCache):
(WebCore::FrameLoaderClientHaiku::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::didSaveToPageCache):
(WebFrameLoaderClient::didRestoreFromPageCache):

WebKit/qt:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didSaveToPageCache):
(WebCore::FrameLoaderClientQt::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didSaveToPageCache):
(WebFrameLoaderClient::didRestoreFromPageCache):
* WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wince:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::didSaveToPageCache):
(WebKit::FrameLoaderClientWinCE::didRestoreFromPageCache):
* WebCoreSupport/FrameLoaderClientWinCE.h:

WebKit/wx:

- Add client functions to notify that a frame has been added or
  removed from the page cache.

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::didSaveToPageCache):
(WebCore::FrameLoaderClientWx::didRestoreFromPageCache):
* WebKitSupport/FrameLoaderClientWx.h:

WebKit2:

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
* UIProcess/API/C/WKFrame.h:
Add API to get the child frames of a frame.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):
(WebKit::WebFrameProxy::appendChild):
(WebKit::WebFrameProxy::removeChild):
(WebKit::WebFrameProxy::isDescendantOf):
(WebKit::WebFrameProxy::dumpFrameTree):
(WebKit::WebFrameProxy::didRemoveFromHierarchy):
(WebKit::WebFrameProxy::childFrames):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::parentFrame): Add getter.
(WebKit::WebFrameProxy::nextSibling): Add getter.
(WebKit::WebFrameProxy::previousSibling): Add getter.
(WebKit::WebFrameProxy::firstChild): Add getter.
(WebKit::WebFrameProxy::lastChild): Add getter.
Make frames keep track of their subframes.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateSubframe):
Use the now passed parentID to insert the frame into the hierarchy

(WebKit::WebPageProxy::didSaveFrameToPageCache):
When a frame is added to the page cache, remove it from the hierarchy.

(WebKit::WebPageProxy::didRestoreFrameFromPageCache):
When a frame is restored from the page cache, add it back to the hierarchy.

(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
Detached frames should also be removed from the hierarchy.

* UIProcess/WebPageProxy.h:
Add new declarations for didSaveFrameToPageCache and didRestoreFrameFromPageCache.

* UIProcess/WebPageProxy.messages.in:
Add messages for DidSaveFrameToPageCache and DidRestoreFrameFromPageCache.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Remove notImplemented, there is no work we need to do here.

(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
Send message to UIProcess to indicate this happened.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):
Send parent frameID in addition to our own in the message to UIProcess.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 23 Dec 2010 19:57:15 +0000 (19:57 +0000)]
2010-12-22  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
        This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE)
        https://bugs.webkit.org/show_bug.cgi?id=51279

        * html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc
        * html/canvas/CanvasRenderingContext2D.cpp: Use new flag
        * platform/graphics/ImageBuffer.h: Use new flag
        * platform/graphics/cg/ImageBufferCG.cpp: Use new flag
2010-12-22  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
        https://bugs.webkit.org/show_bug.cgi?id=51279

        * platform/mac-snowleopard/platform/mac/compositing: Added.
        * platform/mac-snowleopard/platform/mac/compositing/canvas: Added.
        * platform/mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
        * platform/mac/compositing/canvas: Added.
        * platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
        * platform/mac/compositing/canvas/accelerated-canvas-compositing.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 19:33:41 +0000 (19:33 +0000)]
2010-12-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        New popup windows open disproportionately big
        https://bugs.webkit.org/show_bug.cgi?id=51547
        <rdar://problem/8637029>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::createNewPage):
        Pass the correct size back to the UI process.

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::pageRect):
        Implement this and return the size of the page.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-20 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 23 Dec 2010 19:16:59 +0000 (19:16 +0000)]
2010-12-20  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Tile root layer of the compositor.
        https://bugs.webkit.org/show_bug.cgi?id=49947

        Refactor root layer update and drawing from LayerRendererChromium into
        LayerTilerChromium.  The root layer is now drawn as multiple tiles
        rather than as one single large texture.  Scrollbars are now drawn
        separately rather than as part of the root layer.

        Test: LayoutTests/compositing/

        * WebCore.gypi:
        * page/FrameView.cpp:
        (WebCore::FrameView::repaintContentRectangle):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::setClipsRepaints):
        * platform/ScrollView.h:
        (WebCore::ScrollView::clipsRepaints):
        * platform/graphics/chromium/LayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::~LayerRendererChromium):
        (WebCore::LayerRendererChromium::useShader):
        (WebCore::LayerRendererChromium::verticalScrollbarRect):
        (WebCore::LayerRendererChromium::horizontalScrollbarRect):
        (WebCore::LayerRendererChromium::invalidateRootLayerRect):
        (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::setRootLayer):
        (WebCore::LayerRendererChromium::initializeSharedObjects):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp: Added.
        (WebCore::LayerTilerChromium::create):
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::~LayerTilerChromium):
        (WebCore::LayerTilerChromium::layerRendererContext):
        (WebCore::LayerTilerChromium::setTileSize):
        (WebCore::LayerTilerChromium::reset):
        (WebCore::LayerTilerChromium::createTile):
        (WebCore::LayerTilerChromium::invalidateTiles):
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::contentRectToLayerRect):
        (WebCore::LayerTilerChromium::layerRectToContentRect):
        (WebCore::LayerTilerChromium::tileIndex):
        (WebCore::LayerTilerChromium::tileContentRect):
        (WebCore::LayerTilerChromium::tileLayerRect):
        (WebCore::LayerTilerChromium::invalidateRect):
        (WebCore::LayerTilerChromium::invalidateEntireLayer):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::setLayerPosition):
        (WebCore::LayerTilerChromium::draw):
        (WebCore::LayerTilerChromium::resizeLayer):
        (WebCore::LayerTilerChromium::growLayerToContain):
        (WebCore::LayerTilerChromium::Tile::~Tile):
        (WebCore::LayerTilerChromium::Tile::releaseTextureId):
        * platform/graphics/chromium/LayerTilerChromium.h: Added.
        (WebCore::LayerTilerChromium::Tile::Tile):
        (WebCore::LayerTilerChromium::Tile::textureId):
        (WebCore::LayerTilerChromium::Tile::dirty):
        (WebCore::LayerTilerChromium::Tile::clearDirty):
        (WebCore::LayerTilerChromium::layerRenderer):
2010-12-20  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Tile root layer of the compositor.
        https://bugs.webkit.org/show_bug.cgi?id=49947

        Refactor root layer logic out of WebViewImpl and into
        LayerTilerChromium.  The painting is now done through an interface
        rather than directly in WebViewImpl.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::scrollRootLayerRect):
        (WebKit::WebViewImpl::invalidateRootLayerRect):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImplTilePaintInterface::WebViewImplTilePaintInterface):
        (WebKit::WebViewImplTilePaintInterface::paint):
        (WebKit::WebViewImplScrollbarPaintInterface::WebViewImplScrollbarPaintInterface):
        (WebKit::WebViewImplScrollbarPaintInterface::paint):
        (WebKit::WebViewImpl::doComposite):
        * src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 23 Dec 2010 19:06:08 +0000 (19:06 +0000)]
2010-12-23  Kenneth Russell  <kbr@google.com>

        Unreviewed Chromium expectations update. Fix incorrect syntax for
        fast/css/box-shadow.html suppression and state that
        fast/events/touch/touch-target.html may timeout.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Dec 2010 18:59:52 +0000 (18:59 +0000)]
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Renamed SelectionController::EDirection to SelectionDirection.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::executeCommand):
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Renamed SelectionController::EDirection to SelectionDirection.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Renamed SelectionController::EDirection to SelectionDirection.

        * WebView/WebFrame.mm:
        (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
        Takes SelectionDirection instead of SelectionController::EDirection.
        * WebView/WebFrameInternal.h:
        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Renamed SelectionController::EDirection to SelectionDirection.

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::handleKeyboardEvent):
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Renamed SelectionController::EDirection to SelectionDirection.

        * WebCoreSupport/EditorClientWinCE.cpp:
        (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Renamed SelectionController::EDirection to SelectionDirection.

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Editor.h doesn't need to include SelectionController.h
        https://bugs.webkit.org/show_bug.cgi?id=51441

        Removed #include <Selection.h> from Editor.h.
        Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
        to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h

        * WebCore.exp.in: Signature changes.
        * WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
        * editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
        * editing/Editor.cpp:
        (WebCore::Editor::deleteWithDirection): Change due to SelectionDirection.
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
        (WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
        * editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h
        and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
        * editing/EditorCommand.cpp:
        (WebCore::executeDeleteBackward): Change due to SelectionDirection.
        (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
        (WebCore::executeDeleteForward): Ditto.
        (WebCore::executeDeleteToBeginningOfLine): Ditto.
        (WebCore::executeDeleteToBeginningOfParagraph): Ditto.
        (WebCore::executeDeleteToEndOfLine): Ditto.
        (WebCore::executeDeleteToEndOfParagraph): Ditto.
        (WebCore::executeDeleteWordBackward): Ditto.
        (WebCore::executeDeleteWordForward): Ditto.
        (WebCore::executeForwardDelete): Ditto.
        (WebCore::executeMoveBackward): Ditto.
        (WebCore::executeMoveBackwardAndModifySelection): Ditto.
        (WebCore::executeMoveDown): Ditto.
        (WebCore::executeMoveDownAndModifySelection): Ditto.
        (WebCore::executeMoveForward): Ditto.
        (WebCore::executeMoveForwardAndModifySelection): Ditto.
        (WebCore::executeMoveLeft): Ditto.
        (WebCore::executeMoveLeftAndModifySelection): Ditto.
        (WebCore::executeMoveRight): Ditto.
        (WebCore::executeMoveRightAndModifySelection): Ditto.
        (WebCore::executeMoveToBeginningOfDocument): Ditto.
        (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
        (WebCore::executeMoveToBeginningOfLine): Ditto.
        (WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
        (WebCore::executeMoveToBeginningOfParagraph): Ditto.
        (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
        (WebCore::executeMoveToBeginningOfSentence): Ditto.
        (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
        (WebCore::executeMoveToEndOfDocument): Ditto.
        (WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
        (WebCore::executeMoveToEndOfSentence): Ditto.
        (WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
        (WebCore::executeMoveToEndOfLine): Ditto.
        (WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
        (WebCore::executeMoveToEndOfParagraph): Ditto.
        (WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
        (WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
        (WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
        (WebCore::executeMoveUp): Ditto.
        (WebCore::executeMoveUpAndModifySelection): Ditto.
        (WebCore::executeMoveWordBackward): Ditto.
        (WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
        (WebCore::executeMoveWordForward): Ditto.
        (WebCore::executeMoveWordForwardAndModifySelection): Ditto.
        (WebCore::executeMoveWordLeft): Ditto.
        (WebCore::executeMoveWordLeftAndModifySelection): Ditto.
        (WebCore::executeMoveWordRight): Ditto.
        (WebCore::executeMoveWordRightAndModifySelection): Ditto.
        (WebCore::executeMoveToLeftEndOfLine): Ditto.
        (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
        (WebCore::executeMoveToRightEndOfLine): Ditto.
        (WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection.
        (WebCore::SelectionController::modify): Ditto.
        * editing/SelectionController.h: Change due to SelectionDirection.
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed): Ditto.
        (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
        * editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection
        in SelectionController.h
        * editing/WritingDirection.h: Added.
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::modify): Change due to SelectionDirection.
        (WebCore::DOMSelection::deleteFromDocument): Ditto.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
        * page/Frame.h: Includes SelectionController.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Thu, 23 Dec 2010 18:17:38 +0000 (18:17 +0000)]
2010-12-23  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Darin Adler.

        Bug 51537 - iexploder needs cleanup

        * iExploder/htdocs: Removed.
        * iExploder/htdocs/config.rb: Removed.
        * iExploder/htdocs/cssproperties.in: Removed.
        * iExploder/htdocs/cssvalues.in: Removed.
        * iExploder/htdocs/htmlattrs.in: Removed.
        * iExploder/htdocs/htmltags.in: Removed.
        * iExploder/htdocs/htmlvalues.in: Removed.
        * iExploder/htdocs/iexploder.cgi: Removed.
        * iExploder/htdocs/iexploder.rb: Removed.
        * iExploder/htdocs/index.html: Removed.
        * iExploder/htdocs/webserver.rb: Removed.
        * iExploder/iexploder-1.7.2/output: Removed.
        * iExploder/tools: Removed.
        * iExploder/tools/lasthit.rb: Removed.
        * iExploder/tools/osx_last_crash.rb: Removed.
        * iExploder/tools/showtest.rb: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 18:16:02 +0000 (18:16 +0000)]
2010-12-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Nothing happens clicking "launch live player" on live.cnn.com
        https://bugs.webkit.org/show_bug.cgi?id=51540
        <rdar://problem/8791086>

        Implement NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState.

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_PushPopupsEnabledState):
        Call NetscapePlugin::pushPopupsEnabledState.

        (WebKit::NPN_PopPopupsEnabledState):
        Call NetscapePlugin::popPopupsEnabledState.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::pushPopupsEnabledState):
        Append the boolean to the vector.

        (WebKit::NetscapePlugin::popPopupsEnabledState):
        Remove the last boolean from the vector.

        (WebKit::NetscapePlugin::allowPopups):
        Return the last boolean from the vector.

        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::performJavaScriptURLRequest):
        Update the "allowPopupsFromPlugin" state.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 23 Dec 2010 17:45:08 +0000 (17:45 +0000)]
2010-12-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Move V8 to WebCore's implementation of showModalDialog
        https://bugs.webkit.org/show_bug.cgi?id=51527

        This code is basically verbatim translation from the JavaScriptCore
        bindings.  The only intentional difference is in the world selection
        for the dialog's frame.  I suspect JavaScriptCore's bindings have a
        subtle bug there.

        In this patch, I also remove a bunch of now-unneeded code in the
        generic bindings.

        * bindings/generic/BindingDOMWindow.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::DialogHandler::dialogCreated):
        (WebCore::setUpDialog):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::DialogHandler::DialogHandler):
        (WebCore::DialogHandler::dialogCreated):
        (WebCore::DialogHandler::returnValue):
        (WebCore::setUpDialog):
        (WebCore::V8DOMWindow::showModalDialogCallback):
        (WebCore::V8DOMWindow::openCallback):
        * bindings/v8/specialization/V8BindingDOMWindow.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 23 Dec 2010 17:26:16 +0000 (17:26 +0000)]
2010-12-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Can't backspace from CSS value to CSS key field
        https://bugs.webkit.org/show_bug.cgi?id=51476

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.):
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 16:56:36 +0000 (16:56 +0000)]
2010-12-23  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
2010-12-23  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated.

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows-XP-specific (failing) expected results for
jberlin@webkit.org [Thu, 23 Dec 2010 16:53:35 +0000 (16:53 +0000)]
Add Windows-XP-specific (failing) expected results for
fast/profiler/throw-exception-from-eval-expected.html in order to get the Windows XP Debug
test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=49801

* platform/win-xp/fast/profiler: Added.
* platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 16:39:57 +0000 (16:39 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Make 'single' the default backing store in EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=51534

        'single' is the simplest backing store and the one intended to be the
        default in the test browser. By mistake the tiled backing store was
        left as default in r72617.

        * EWebLauncher/main.c:
        (browserCreate): ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Dawit Alemayehu <adawit@kde.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 16:23:24 +0000 (16:23 +0000)]
2010-12-23  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add a 'hasSelection' function to QWebView and QWebPage.
        https://bugs.webkit.org/show_bug.cgi?id=48722

        This is a convenience API that optimizes the case where checking for
        the presence of selected content and accessing the selected content
        are two separate actions in the client. See comment #12 in the above
        bug report link for details.

        * Api/qwebpage.cpp:
        (QWebPage::hasSelection):
        * Api/qwebpage.h:
        * Api/qwebview.cpp:
        (QWebView::hasSelection):
        * Api/qwebview.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::textSelection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Thu, 23 Dec 2010 14:45:45 +0000 (14:45 +0000)]
2010-12-23  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed new Chromium baselines and test expectations update.

        * platform/chromium-linux/fast/layers/video-layer-expected.checksum:
        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.checksum:
        * platform/chromium-mac/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-win/fast/layers/video-layer-expected.checksum:
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium-win/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 14:41:31 +0000 (14:41 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Fix ContextMenu removal
        https://bugs.webkit.org/show_bug.cgi?id=51530

        Fix ContextMenu removal

        In r74207 the support for ContextMenu was removed from EFL while the
        code is being ported to the new CROSS_PLATFORM_MENUS due to build
        breakage.  However there were some missing removals in the shutdown
        logic that introduced a bug, leading to a segmentation fault when
        ContexController was destroyed.

        The best way to effectively disable the ContextMenu is to conditionally
        compile the meaningful stuff by surrounding with "#if
        ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.

        * cmake/OptionsEfl.cmake: Disable ContextMenu and don't pretend we
        implement CROSS_PLATFORM_MENUS yet.
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Fix ContextMenu removal
        https://bugs.webkit.org/show_bug.cgi?id=51530

        Fix ContextMenu removal

        In r74207 the support for ContextMenu was removed from EFL while the
        code is being ported to the new CROSS_PLATFORM_MENUS due to build
        breakage.  However there were some missing removals in the shutdown
        logic that introduced a bug, leading to a segmentation fault when
        ContexController was destroyed.

        The best way to effectively disable the ContextMenu is to conditionally
        compile the meaningful stuff by surrounding with "#if
        ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.

        * ewk/ewk_contextmenu.cpp: surround need parts with #if
        ENABLE(CONTEXT_MENUS).
        (ewk_context_menu_destroy): ditto.
        (ewk_context_menu_item_select): ditto.
        * ewk/ewk_private.h: ditto.
        * ewk/ewk_view.cpp: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 14:24:50 +0000 (14:24 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Fix check by undefined macro
        https://bugs.webkit.org/show_bug.cgi?id=51531

        Fix check by undefined macro

        When building EFL port with libsoup, BUILDING_GTK__ is not defined,
        leading to warnings during compile. We actually have to use an #ifdef
        instead of an #if.

        No change in functionality so no new tests.

        * platform/network/soup/cache/webkit/soup-cache.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 14:08:31 +0000 (14:08 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Clean warnings in Tiled Backing Store
        https://bugs.webkit.org/show_bug.cgi?id=51529

        Tiled backing store in EFL was giving the following warnings that are
        gone now:

        - Static function defined but not used;
        - Comparison between signed and unsigned integer expressions;

        * ewk/ewk_tiled_backing_store.c:
        (_ewk_tiled_backing_store_item_fill):
        (_ewk_tiled_backing_store_smart_calculate):
        * ewk/ewk_tiled_matrix.c:
        (_ewk_tile_matrix_slicer_setup):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Jonathan Dixon <joth@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 13:49:46 +0000 (13:49 +0000)]
2010-12-23  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Steve Block.

        TouchEvents does not support multi-touch on a page with multiple touch targets
        https://bugs.webkit.org/show_bug.cgi?id=51258

        * fast/events/touch/multi-touch-grouped-targets-expected.txt: Added.
        * fast/events/touch/multi-touch-grouped-targets.html: Added.
        * fast/events/touch/script-tests/multi-touch-grouped-targets.js: Added.
        (declareTouchHandler.return.shouldBe):
        (declareTouchHandler):
        (touchEndHandler):
        Added new test that ensures both test targets receive events when hit by multiple
        touch points from the same platform event.

        * fast/events/touch/script-tests/touch-target-limited.js:
        (declareTouchStart.return.touchStartHandler):
        (declareTouchStart):
        (declareTouchMove.return.touchMoveHandler):
        (declareTouchMove):
        * fast/events/touch/script-tests/touch-target.js:
        (declareTouchStart.return.touchStartHandler):
        (declareTouchStart):
        (declareTouchMove.return.touchMoveHandler):
        (declareTouchMove):
        * fast/events/touch/touch-target-expected.txt:
        * fast/events/touch/touch-target-limited-expected.txt:
        Updated & rebaselined existing tests to reflect new expectations.
2010-12-23  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Steve Block.

        TouchEvents does not support multi-touch on a page with multiple touch targets
        https://bugs.webkit.org/show_bug.cgi?id=51258

        Test: fast/events/touch/multi-touch-grouped-targets.html

        * page/EventHandler.cpp:
        (WebCore::eventNameForTouchPointState):
        (WebCore::EventHandler::handleTouchEvent):
        Redesigned event handler to ensure all event targets involved in a given
        multitouch event get the appropriate event(s) fired.

        * platform/PlatformTouchPoint.h: Added end-stop marker for State enum.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Thu, 23 Dec 2010 13:23:04 +0000 (13:23 +0000)]
2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
        https://bugs.webkit.org/show_bug.cgi?id=51533

        There's no point in concatenating env("HOME") with "blah", so remove
        option from EWebLauncher.

        * EWebLauncher/main.c:
        (main): ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 23 Dec 2010 13:14:48 +0000 (13:14 +0000)]
2010-12-23  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] media/audio-data-url.html fails since r75504
        https://bugs.webkit.org/show_bug.cgi?id=51525

        Make the GStreamer media-player advertize 3gpp mime-types as
        supported if the 3gp caps are in the typefind factories.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Thu, 23 Dec 2010 13:09:42 +0000 (13:09 +0000)]
2010-12-23  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed test expectations update.

        Fix duplicate expectation warning for media/video-controls-rendering.html introduced in r74535.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
tkent@chromium.org [Thu, 23 Dec 2010 12:56:55 +0000 (12:56 +0000)]
Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=51093

Reviewed by Dimitri Glazkov.

Move BeforeTextInserted and Wheel event handling, event forwarding to
renderers, and the isindex form submission quirk code to InputTypes.
Also, change the return types of InputType event handlers from 'bool'
to 'void'. We use Event::defaultHandled() to decide whether event
handling should be stopped.

No new tests because this is just a refactoring.

* html/BaseButtonInputType.cpp: bool->void changes
(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):
* html/BaseButtonInputType.h: ditto.
* html/BaseCheckableInputType.cpp: ditto.
(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):
* html/BaseCheckableInputType.h: ditto.
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton().
* html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition.
* html/CheckboxInputType.cpp: bool->void change
(WebCore::CheckboxInputType::handleKeyupEvent):
* html/CheckboxInputType.h: ditto.
* html/FileInputType.cpp: ditto.
(WebCore::FileInputType::handleDOMActivateEvent):
* html/FileInputType.h: ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
 - Change return-value handling of InputType event handlers
 - Move out beforeTextInserted/wheel event handling and isindex form quirk.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
 Added so that InputType can call InputElement::handleBeforeTextInsertedEvent().
* html/ImageInputType.cpp: bool->void change
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/ImageInputType.h: ditto.
* html/InputType.cpp: ditto.
(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
(WebCore::InputType::handleBeforeTextInsertedEvent):
(WebCore::InputType::handleWheelEvent): Added default implementation.
(WebCore::InputType::forwardEvent): ditto.
(WebCore::InputType::formForSubmission): ditto.
* html/InputType.h:
* html/IsIndexInputType.cpp:
(WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp.
* html/IsIndexInputType.h:
* html/NumberInputType.cpp:
(WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp.
(WebCore::NumberInputType::handleKeydownEvent): bool->void change.
(WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp.
(WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton().
* html/NumberInputType.h:
* html/RadioInputType.cpp: bool->void changes.
(WebCore::RadioInputType::handleClickEvent):
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):
* html/RadioInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp.
* html/RangeInputType.h:
* html/ResetInputType.cpp: bool->void change.
(WebCore::ResetInputType::handleDOMActivateEvent):
* html/ResetInputType.h: ditto.
* html/SubmitInputType.cpp: ditto.
(WebCore::SubmitInputType::handleDOMActivateEvent):
* html/SubmitInputType.h: ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent): bool->void change.
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp.
(WebCore::TextFieldInputType::forwardEvent): ditto.
* html/TextFieldInputType.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 23 Dec 2010 11:12:09 +0000 (11:12 +0000)]
2010-12-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style
        https://bugs.webkit.org/show_bug.cgi?id=51390

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update Qt specific expected file after r74539.
ossy@webkit.org [Thu, 23 Dec 2010 10:38:19 +0000 (10:38 +0000)]
Unreviewed. Update Qt specific expected file after r74539.

* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 10:20:53 +0000 (10:20 +0000)]
2010-12-23  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Eric Seidel.

        QT linux has RTL line movement bug that causes editing/selection/extend-to-line-boundary.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=51514

        Add different baseline to editing/selection/extend-to-line-boundary.html for qt-linux that
        takes into account the RTL bug.

        * platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
antti@apple.com [Thu, 23 Dec 2010 09:54:13 +0000 (09:54 +0000)]
Not reviewed.

Another attempt.

* http/tests/local/slow-css-pass.cgi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 23 Dec 2010 09:20:42 +0000 (09:20 +0000)]
2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Eric Seidel.

        Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).

        Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
        I just discovered that we have two additional GC runs per each WebViewHost.
        Test_shell had no such calls.
        These gc runs eat 15% of cpu time.

        https://bugs.webkit.org/show_bug.cgi?id=51479

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::~WebViewHost):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed.
antti@apple.com [Thu, 23 Dec 2010 09:18:03 +0000 (09:18 +0000)]
Not reviewed.

Flaky Test: http/tests/local/stylesheet-and-script-load-order-media-print.html

Try to fix flakiness.

* http/tests/local/slow-css-pass.cgi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Thu, 23 Dec 2010 08:17:10 +0000 (08:17 +0000)]
2010-12-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build warning fix.

        [EFL] Remove warning messages during the webkit efl compiling
        https://bugs.webkit.org/show_bug.cgi?id=51520

        Remove build warning messages.

        * ewk/ewk_view.cpp:
        (_ewk_view_smart_show):
        (_ewk_view_smart_hide):
        * ewk/ewk_view.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 08:00:26 +0000 (08:00 +0000)]
2010-12-23  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Adam Barth.

        [chromium] Reduce canvas.toDataURL("image/png") run-time costs 300%
        https://bugs.webkit.org/show_bug.cgi?id=51455

        Chromium uses the libpng compression defaults.  Good compression results,
        but at much larger run-time cost compared to other browsers.  Chrome is 2
        times slower than Mozilla 3.6.12 and 3-4 times slower than Safari 5.0.3.

        libpng has supported alternative compression methods for some time, they
        better meet the dual goals of good compression and run-time cost for the
        on-line case, and are well-documented.  Here use Huffman encoding.  It's
        2-20% faster than other encodings (Z_RLE, Z_FILTERED) and the compressed
        size is within 1% of the Safari 5.0.3 result independent of image size.

        No change in behaviour, so no new tests.

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::PNGImageEncoder::encode): Apply Huffman image encoding.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 07:43:45 +0000 (07:43 +0000)]
2010-12-22  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Darin Fisher.

        [chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
        https://bugs.webkit.org/show_bug.cgi?id=51321

        Follow on from r73890, unroll the SkUnPreMultiply::PMColorToColor() call for
        the "image/png" encoder case viz., compute the unpremultiplication in-place.
        See https://bugs.webkit.org/show_bug.cgi?id=50804 for reference.

        No new tests: canvas.toDataURL() is covered by existing tests.

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::preMultipliedBGRAtoRGBA):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Thu, 23 Dec 2010 06:55:52 +0000 (06:55 +0000)]
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        Implement skewX() and skewY() for CSSMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=38335

        * fast/dom/Window/window-properties-expected.txt: Adjusted.
        * transforms/cssmatrix-2d-interface.xhtml: Added tests for skewX() and skewY().
        * transforms/cssmatrix-2d-interface-expected.txt: Adjusted.
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        Implement skewX() and skewY() for CSSMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=38335

        * css/WebKitCSSMatrix.cpp:
        (WebCore::WebKitCSSMatrix::skew): Implemented skewX() and skewY().
        * css/WebKitCSSMatrix.h: Added skewX() and skewY().
        * css/WebKitCSSMatrix.idl: Added skewX() and skewY().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Dec 2010 05:45:56 +0000 (05:45 +0000)]
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Support unprefixed box-shadow property
        https://bugs.webkit.org/show_bug.cgi?id=51448

        Add support for the box-shadow CSS property. We'll currently render this
        similarly to -webkit-box-shadow, but a later fix will adjust the blur radius
        handling to match the spec.

        Test: fast/css/box-shadow.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implement getComputedStyle
        for box-shadow

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::ShadowParseContext::ShadowParseContext):
        (WebCore::ShadowParseContext::commitValue):
        (WebCore::ShadowParseContext::commitLength):
        (WebCore::ShadowParseContext::commitColor): Support CSSPropertyBoxShadow

        * css/CSSPropertyNames.in: add box-shadow

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Add CSSPropertyBoxShadow, and
        store in the ShadowData if this is -webkit-box-shadow or not. We'll use this
        to adjust radii later.

        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty): Add CSSPropertyBoxShadow.

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        (WebCore::PropertyWrapperShadow::blend):
        (WebCore::AnimationBase::ensurePropertyMap): Support animations of box-shadow.

        * rendering/style/ShadowData.cpp: Store a flag to say if this is a -webkit-box-shadow.
        (WebCore::ShadowData::ShadowData):
        (WebCore::ShadowData::operator==):
        * rendering/style/ShadowData.h:
        (WebCore::ShadowData::ShadowData):
        (WebCore::ShadowData::isWebkitBoxShadow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 23 Dec 2010 05:39:21 +0000 (05:39 +0000)]
2010-12-22  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Can't shadow/overwrite window.constructor
        (causes TypeError exception)
        https://bugs.webkit.org/show_bug.cgi?id=48953

        Added code in the javascript code generator to create a setter for
        a constructor if the new extended attribute ReplaceableConstructor
        is present for the interface.

        * bindings/scripts/CodeGeneratorJS.pm:
        * page/DOMWindow.idl:
2010-12-22  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION: Can't shadow/overwrite window.constructor
        (causes TypeError exception)
        https://bugs.webkit.org/show_bug.cgi?id=48953

        Changed cross-frame-access-put test results to reflect that setting
        the window constructor will be disallowed due to cross frame security
        checking.
        Added a new test to check that we can change window.constructor.

        * fast/dom/Window/window-constructor-settable-expected.txt: Added.
        * fast/dom/Window/window-constructor-settable.html: Added.
        * http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 05:27:15 +0000 (05:27 +0000)]
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed test expectations update. fast/canvas/fillText-shadow.html
        fails with Skia in the GPU suite too.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Thu, 23 Dec 2010 05:25:36 +0000 (05:25 +0000)]
2010-12-22  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        Change css for chromium media controls to deal with the timeline
        not expanding when the current time disappears. This happens when
        the width of the control drops below 240px.

        This change results in a minor pixel difference - the timebar now
        aligns better with the time and when the time is not displayed is
        now perfectly centered. Disabling the affected tests for now
        and will rebaseline.

        https://bugs.webkit.org/show_bug.cgi?id=51500

        * platform/chromium/test_expectations.txt:
2010-12-22  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        Change css for chromium media controls to deal with the timeline
        not expanding when the current time disappears. This happens when
        the width of the control drops below 240px.

        This change results in a minor pixel difference - the timebar now
        aligns better with the time and when the time is not displayed is
        now perfectly centered. Disabling the affected tests for now
        and will rebaseline.

        https://bugs.webkit.org/show_bug.cgi?id=51500

        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 05:05:20 +0000 (05:05 +0000)]
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed test expectations update. fast/canvas/fillText-shadow.html
        fails with Skia.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows-specific (failing) expected results for media/audio-data-url.html in...
jberlin@webkit.org [Thu, 23 Dec 2010 04:01:05 +0000 (04:01 +0000)]
Add Windows-specific (failing) expected results for media/audio-data-url.html in order to get
the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51518

* platform/win/media/audio-data-url-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 03:25:35 +0000 (03:25 +0000)]
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        the shadow direction is negated in canvas context shadowOffsetY.
        https://bugs.webkit.org/show_bug.cgi?id=25619

        Add test to verify that shadowOffsetY is handled correctly.

        * fast/canvas/fillText-shadow-expected.txt: Added.
        * fast/canvas/fillText-shadow.html: Added.
2010-12-22  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        the shadow direction is negated in canvas context shadowOffsetY.
        https://bugs.webkit.org/show_bug.cgi?id=25619

        Invert shadow offset Y direction in 0-blur path in FontMac::drawGlyps
        if we're not transforming shadows (i.e. are rendering in a canvas). Also
        use CG shadows if there's a non-translate/flip transform applied
        (shadow offsets are supposed to ignore transforms, but the naive/simple
        implementation was taking them into account).

        Also does the equivalent changes to FontCGWin.

        Test: fast/canvas/fillText-shadow.html

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::shadowsIgnoreTransforms):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 02:59:41 +0000 (02:59 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Webkit2: WebProcess crashes when Private browsing is turned on on yahoo.com
        https://bugs.webkit.org/show_bug.cgi?id=51516
        <rdar://problem/8766995>

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::NPP_SetValue):
        Add a null check for NPP_SetValue.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 02:53:44 +0000 (02:53 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (WK2): Plugins swallow CMD-W, CMD-Q, and probably other shortcuts
        https://bugs.webkit.org/show_bug.cgi?id=51515
        <rdar://problem/8740926>

        Always return false for keyboard events where the command key is down.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::platformHandleKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Thu, 23 Dec 2010 02:44:16 +0000 (02:44 +0000)]
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74503.
        http://trac.webkit.org/changeset/74503
        https://bugs.webkit.org/show_bug.cgi?id=51513

        breaks chromium mac debug compile (Requested by tonyg-cr on
        #webkit).

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74503.
        http://trac.webkit.org/changeset/74503
        https://bugs.webkit.org/show_bug.cgi?id=51513

        breaks chromium mac debug compile (Requested by tonyg-cr on
        #webkit).

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebProcess should be terminated if invalid frameIDs are
weinig@apple.com [Thu, 23 Dec 2010 01:57:42 +0000 (01:57 +0000)]
WebProcess should be terminated if invalid frameIDs are
passed to the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=51508

Reviewed by Darin Adler.

- Introduce a mechanism to mark a messages as invalid due to
  reasons other than in ability to decode the message, eg. an
  invalid frameID is passed in a message.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
(CoreIPC::Connection::markCurrentlyDispatchedMessageAsInvalid): Sets
the m_didReceiveInvalidMessage bit so that it can be picked up in
(CoreIPC::Connection::dispatchMessages): Check for m_didReceiveInvalidMessage in
addition to tainted arguments.
* Platform/CoreIPC/Connection.h:
Add base macro for others to extend, that calls markCurrentlyDispatchedMessageAsInvalid()
ASSERTs, and returns.

* UIProcess/WebPageProxy.cpp:
Add Message checks for all WebFrameProxy's gotten from frameIDs passed
over the wire.
* UIProcess/WebProcessProxy.cpp:
(WebKit::isGoodMapKey):
Checks that the key can be inserted safely into a map (eg. not the empty or deleted value).

(WebKit::WebProcessProxy::webFrame):
Return null for bad keys (eg. 0 or -1).

(WebKit::WebProcessProxy::canCreateFrame):
Added. Checks that the ID is good and not in the map yet. Used
as a consistency check before creating frames.

(WebKit::WebProcessProxy::frameCreated):
ASSERT that the key is good, in addition to not in the map yet.

(WebKit::WebProcessProxy::didDestroyFrame):
ASSERT that the key is good.

* UIProcess/WebProcessProxy.h:
Move WebFrameProxy HashMap type into a typedef.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Dec 2010 01:45:58 +0000 (01:45 +0000)]
2010-12-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        WebKit2 needs a way to return the main resource data
        https://bugs.webkit.org/show_bug.cgi?id=51510

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetMainResourceData): Added.
        (callGetMainResourceDataBlockAndDispose): Added.
        (WKFrameGetMainResourceData_b): Added.
        * UIProcess/API/C/WKFrame.h: Added WKFrameGetMainResourceData.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::getMainResourceData): Added.
        * UIProcess/WebFrameProxy.h: Ditto.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::getMainResourceDataOfFrame): Added.
        (WebKit::WebPageProxy::dataCallback): Replaced the individual callbacks
        with just these two.
        (WebKit::WebPageProxy::stringCallback): Ditto.
        * UIProcess/WebPageProxy.h: Ditto.
        * UIProcess/WebPageProxy.messages.in: Ditto.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::runJavaScriptInMainFrame): Send the string callback
        message instead of a specific one.
        (WebKit::WebPage::getContentsAsString): Ditto.
        (WebKit::WebPage::getRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPage::getSelectionOrContentsAsString): Ditto.
        (WebKit::WebPage::getSourceForFrame): Ditto.
        (WebKit::WebPage::getMainResourceDataOfFrame): Added.
        (WebKit::WebPage::getWebArchiveOfFrame): Send the data callback message
        instead of a specific one.
        * WebProcess/WebPage/WebPage.h: Added getMainResourceDataOfFrame.
        * WebProcess/WebPage/WebPage.messages.in: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace runtime checks for hyphenation API availability with compile-time checks.
mitz@apple.com [Thu, 23 Dec 2010 01:35:51 +0000 (01:35 +0000)]
Replace runtime checks for hyphenation API availability with compile-time checks.

Reviewed by Darin Adler.

* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForNullKey): Changed to use CFLocaleCopyCurrent() instead of using the
search locale, which is empty on Windows. On Mac, this is equivalent to using the search locale.
(WebCore::canHyphenate): Added this implementation for when the hyphenation API is not available.
It is identical to the implementation in Hyphenation.cpp.
(WebCore::lastHyphenLocation): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 23 Dec 2010 01:26:29 +0000 (01:26 +0000)]
2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        This change splits out the TestRunner class into its own file.
        When we fork the code for message passing, we will create a new
        TestRunner, and this change will allow that to be more modular.

        While we're at it, split out TestInput and ResultSummary into
        their own files, to reduce the size of run_webkit_tests to
        something more managable.

        https://bugs.webkit.org/show_bug.cgi?id=51092

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

 2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt multiprocessing - start over, prepare to fork the code

        This code cleans up the signatures and implementation of the
        TestRunner class so we can easily fork it to run either the
        stable implementation or the new, unstable message-passing
        implementation. The two variants will have different
        implementations of the run_tests() method. We will switch
        between the two based on the setting for the '--worker-model'
        switch. We rename the two currently valid values to 'old-inline'
        and 'old-threads'.

        https://bugs.webkit.org/show_bug.cgi?id=51081

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Dec 2010 01:17:45 +0000 (01:17 +0000)]
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Cache snapshots of plug-ins before painting, to avoid script running during painting
        https://bugs.webkit.org/show_bug.cgi?id=51493

        When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
        or when printing), plug-ins which otherwise use the CA rendering model
        are sent a paint event. Some plug-ins may run script while handling this event,
        or out of process plug-ins may process queued requests at this time. Running
        script while inside layout or painting can have bad consequences, because it
        can result in arbitrary changes to the render tree.

        This patch avoids sending plug-ins paint events inside of painting. Instead,
        we ask the plug-ins to cache a snapshot before we paint, and then the software
        paint simply draws that snapshot.

        Requires manual test, because the bug happens when Safari does
        a page snapshot. It's not possible to tell the Test Netscape Plug-in
        to paint without laying out, making an automated test impossible.

        * manual-tests/plugins/plugin-paint-causes-layout.html: Added.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::paintContents): Notify all enclosed widgets
        that a flattening paint is going to happen.
        (WebCore::FrameView::notifyWidgetsInAllFrames): Utility method
        that tells the RenderView in all subframes to notify their widgets.

        * platform/Widget.h:
        (WebCore::Widget::notifyWidget): Generic method that can be used
        to send messages to widgets. Current messages are just 'before flattening paint'
        and 'after flattening paint'. Message has no payload.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::getRetainedWidgets):
        (WebCore::RenderView::releaseWidgets): Factor code out of updateWidgetPositions(),
        since we use it in two places now.

        (WebCore::RenderView::updateWidgetPositions): Use getRetainedWidgets() etc.
        (WebCore::RenderView::notifyWidgets): Retain all the widgets, then send
        them all the message.

        * rendering/RenderWidget.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::notifyWidget): Pass the message to the widget.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
        draw it. Also only send the snapshot message to the plugin proxy if we
        know we're snapshotting, since even if creating the snapshot image failed,
        we still don't want to call to the plug-in.

        * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
        (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
        to cache and clear the snapshots.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 23 Dec 2010 00:55:07 +0000 (00:55 +0000)]
2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt multiprocessing - start over, prepare to fork the code

        This code cleans up the signatures and implementation of the
        TestRunner class so we can easily fork it to run either the
        stable implementation or the new, unstable message-passing
        implementation. The two variants will have different
        implementations of the run_tests() method. We will switch
        between the two based on the setting for the '--worker-model'
        switch. We rename the two currently valid values to 'old-inline'
        and 'old-threads'.

        https://bugs.webkit.org/show_bug.cgi?id=51081

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.
darin@apple.com [Thu, 23 Dec 2010 00:50:06 +0000 (00:50 +0000)]
* WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Dec 2010 00:44:56 +0000 (00:44 +0000)]
2010-12-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Make Speech menu items work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51504

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetWebArchive): Updated to use new-named typedef.
        * UIProcess/API/C/WKPage.cpp:
        (WKPageRunJavaScriptInMainFrame): Ditto.
        (WKPageRenderTreeExternalRepresentation): Ditto.
        (WKPageGetSourceForFrame): Ditto.
        (WKPageGetContentsAsString): Ditto.

        * UIProcess/API/mac/WKView.mm:
        (menuItem): Added. Helper function to make it easy to call menu item
        functions on arbitrary user interface items.
        (toolbarItem): Ditto.
        (-[WKView validateUserInterfaceItem:]): Added validation for startSpeaking
        and stopSpeaking commands. Reworked the code to fix a bug where
        toggleContinuousSpellChecking would always be enabled even when it should
        be disabled. Reworked the asynchronous validation code so it works for
        items other than menu items and can also handle more than one item for the
        same command. Added some comments.
        (speakString): Added. Helper function to be used as a callback when we
        get the selection or contents to speak.
        (-[WKView startSpeaking:]): Added. Uses getSelectionOrContentsAsString.
        (-[WKView stopSpeaking:]): Added.
        (-[WKView _setUserInterfaceItemState:enabled:state:]): Reworked to work
        with the changes to validateUserInterfaceItem above.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::isDisplayingMarkupDocument): Added a FIXME about
        a problem I noticed.
        (WebKit::WebFrameProxy::didCommitLoad): Tweaked argument name.
        (WebKit::WebFrameProxy::getWebArchive): Changed to use new-named typedef.
        * UIProcess/WebFrameProxy.h: Changed WebArchiveCallback to DataCallaback.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Invalidate the two callback maps since
        we only have two now.
        (WebKit::WebPageProxy::runJavaScriptInMainFrame): Changed to use merged
        maps and typedefs so we don't need a separate callback map for each function.
        (WebKit::WebPageProxy::getRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPageProxy::getSourceForFrame): Ditto.
        (WebKit::WebPageProxy::getContentsAsString): Ditto.
        (WebKit::WebPageProxy::getSelectionOrContentsAsString): Added.
        (WebKit::WebPageProxy::getWebArchiveOfFrame): Ditto.
        (WebKit::WebPageProxy::didGetContentsAsString): Ditto.
        (WebKit::WebPageProxy::didGetSelectionOrContentsAsString): Ditto.
        (WebKit::WebPageProxy::didRunJavaScriptInMainFrame): Ditto.
        (WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPageProxy::didGetSourceForFrame): Ditto.
        (WebKit::WebPageProxy::didGetWebArchiveOfFrame): Ditto.
        (WebKit::WebPageProxy::processDidCrash): Ditto.

        * UIProcess/WebPageProxy.h: Updated for changes above.

        * UIProcess/WebPageProxy.messages.in: Added DidGetSelectionOrContentsAsString,
        GetIsSpeaking, Speak, and StopSpeaking.

        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::getIsSpeaking): Added.
        (WebKit::WebPageProxy::speak): Added.
        (WebKit::WebPageProxy::stopSpeaking): Added.

        * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
        (WebKit::WebContextMenuClient::isSpeaking): Call WebPage instead of doing
        the work directly, so it can run in the UI process.
        (WebKit::WebContextMenuClient::speak): Ditto.
        (WebKit::WebContextMenuClient::stopSpeaking): Ditto.
        (WebKit::WebContextMenuClient::searchWithSpotlight): Added FIXME comment and
        changed code to avoid a C-style cast.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::selectionAsString): Added.
        * WebProcess/WebPage/WebFrame.h: Ditto.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeAcceleratedCompositingMode): Use sendSync in the
        modern way instead of explicitly calling WebProcess.
        (WebKit::WebPage::getSelectionOrContentsAsString): Added.
        (WebKit::WebPage::isSpeaking): Added.
        (WebKit::WebPage::speak): Added.
        (WebKit::WebPage::stopSpeaking): Added.
        * WebProcess/WebPage/WebPage.h: Added functions.

        * WebProcess/WebPage/WebPage.messages.in: Added GetSelectionOrContentsAsString.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 23 Dec 2010 00:39:13 +0000 (00:39 +0000)]
2010-12-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Symbian] Make sure OSAllocatorSymbian builds

        This patch only addresses the build problem.

        https://bugs.webkit.org/show_bug.cgi?id=51128 tracks the full
        (re)implementation of the Symbian allocator.

        * wtf/OSAllocatorSymbian.cpp:
        (WTF::OSAllocator::reserveUncommitted):
        (WTF::OSAllocator::reserveAndCommit):
        (WTF::OSAllocator::commit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Thu, 23 Dec 2010 00:36:07 +0000 (00:36 +0000)]
Fix build.

* Platform/mac/MachUtilities.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74518 268f45cc-cd09-0410-ab3c-d52691b4dbfc