WebKit.git
10 years ago2010-12-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Dec 2010 07:00:42 +0000 (07:00 +0000)]
2010-12-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move cmake into Sources
        https://bugs.webkit.org/show_bug.cgi?id=51631

        * PrettyPatch/PrettyPatch.rb:
2010-12-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move cmake into Sources
        https://bugs.webkit.org/show_bug.cgi?id=51631

        * CMakeLists.txt:
        * Sources/cmake: Copied from cmake.
        * cmake: Removed.
        * cmake/FindCFLite.cmake: Removed.
        * cmake/FindCairo.cmake: Removed.
        * cmake/FindEFL.cmake: Removed.
        * cmake/FindFontconfig.cmake: Removed.
        * cmake/FindFreetype.cmake: Removed.
        * cmake/FindGDK-PixBuf.cmake: Removed.
        * cmake/FindGDK.cmake: Removed.
        * cmake/FindGIO.cmake: Removed.
        * cmake/FindGStreamer-App.cmake: Removed.
        * cmake/FindGStreamer-Base.cmake: Removed.
        * cmake/FindGStreamer-Interfaces.cmake: Removed.
        * cmake/FindGStreamer-Pbutils.cmake: Removed.
        * cmake/FindGStreamer-Plugins-Base.cmake: Removed.
        * cmake/FindGStreamer-Video.cmake: Removed.
        * cmake/FindGStreamer.cmake: Removed.
        * cmake/FindGlib.cmake: Removed.
        * cmake/FindGperf.cmake: Removed.
        * cmake/FindGthread.cmake: Removed.
        * cmake/FindICU.cmake: Removed.
        * cmake/FindLibSoup2.cmake: Removed.
        * cmake/FindLibXlst.cmake: Removed.
        * cmake/FindPango.cmake: Removed.
        * cmake/FindSqlite.cmake: Removed.
        * cmake/LibFindMacros.cmake: Removed.
        * cmake/OptionsCommon.cmake: Removed.
        * cmake/OptionsEfl.cmake: Removed.
        * cmake/OptionsWinCE.cmake: Removed.
        * cmake/OptionsWindows.cmake: Removed.
        * cmake/WebKitEfl.cmake: Removed.
        * cmake/WebKitFS.cmake: Removed.
        * cmake/WebKitFeatures.cmake: Removed.
        * cmake/WebKitHelpers.cmake: Removed.
        * cmake/WebKitMacros.cmake: Removed.
        * cmake/WebKitPackaging.cmake: Removed.
        * cmake/eflsymbols.filter: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 27 Dec 2010 06:11:22 +0000 (06:11 +0000)]
2010-12-26  Adam Barth  <abarth@webkit.org>

        Fix some references to the old location of the WebKit website in git
        metadata files.

        * .gitattributes:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove ANGLE to Sources/ThirdParty
abarth@webkit.org [Mon, 27 Dec 2010 05:51:00 +0000 (05:51 +0000)]
Move ANGLE to Sources/ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=51605

Reviewed by Eric Seidel.

Actually move ANGLE and update the Makefile.

* ANGLE: Removed.
* ANGLE/ANGLE.xcodeproj: Removed.
* ANGLE/ANGLE.xcodeproj/project.pbxproj: Removed.
* ANGLE/Configurations: Removed.
* ANGLE/Configurations/ANGLE.xcconfig: Removed.
* ANGLE/Configurations/Base.xcconfig: Removed.
* ANGLE/Configurations/DebugRelease.xcconfig: Removed.
* ANGLE/Makefile: Removed.
* ANGLE/include: Removed.
* ANGLE/include/EGL: Removed.
* ANGLE/include/EGL/egl.h: Removed.
* ANGLE/include/EGL/eglext.h: Removed.
* ANGLE/include/EGL/eglplatform.h: Removed.
* ANGLE/include/GLES2: Removed.
* ANGLE/include/GLES2/gl2.h: Removed.
* ANGLE/include/GLES2/gl2ext.h: Removed.
* ANGLE/include/GLES2/gl2platform.h: Removed.
* ANGLE/include/GLSLANG: Removed.
* ANGLE/include/GLSLANG/ShaderLang.h: Removed.
* ANGLE/include/KHR: Removed.
* ANGLE/include/KHR/khrplatform.h: Removed.
* ANGLE/src: Removed.
* ANGLE/src/build_angle.xcodeproj: Removed.
* ANGLE/src/build_angle.xcodeproj/project.pbxproj: Removed.
* ANGLE/src/common: Removed.
* ANGLE/src/common/angleutils.h: Removed.
* ANGLE/src/common/debug.cpp: Removed.
* ANGLE/src/common/debug.h: Removed.
* ANGLE/src/compiler: Removed.
* ANGLE/src/compiler/BaseTypes.h: Removed.
* ANGLE/src/compiler/CodeGenGLSL.cpp: Removed.
* ANGLE/src/compiler/CodeGenHLSL.cpp: Removed.
* ANGLE/src/compiler/Common.h: Removed.
* ANGLE/src/compiler/ConstantUnion.h: Removed.
* ANGLE/src/compiler/InfoSink.cpp: Removed.
* ANGLE/src/compiler/InfoSink.h: Removed.
* ANGLE/src/compiler/Initialize.cpp: Removed.
* ANGLE/src/compiler/Initialize.h: Removed.
* ANGLE/src/compiler/InitializeDll.cpp: Removed.
* ANGLE/src/compiler/InitializeDll.h: Removed.
* ANGLE/src/compiler/InitializeGlobals.h: Removed.
* ANGLE/src/compiler/InitializeParseContext.h: Removed.
* ANGLE/src/compiler/IntermTraverse.cpp: Removed.
* ANGLE/src/compiler/Intermediate.cpp: Removed.
* ANGLE/src/compiler/MMap.h: Removed.
* ANGLE/src/compiler/OutputGLSL.cpp: Removed.
* ANGLE/src/compiler/OutputGLSL.h: Removed.
* ANGLE/src/compiler/OutputHLSL.cpp: Removed.
* ANGLE/src/compiler/OutputHLSL.h: Removed.
* ANGLE/src/compiler/ParseHelper.cpp: Removed.
* ANGLE/src/compiler/ParseHelper.h: Removed.
* ANGLE/src/compiler/PoolAlloc.cpp: Removed.
* ANGLE/src/compiler/PoolAlloc.h: Removed.
* ANGLE/src/compiler/QualifierAlive.cpp: Removed.
* ANGLE/src/compiler/QualifierAlive.h: Removed.
* ANGLE/src/compiler/RemoveTree.cpp: Removed.
* ANGLE/src/compiler/RemoveTree.h: Removed.
* ANGLE/src/compiler/ShHandle.h: Removed.
* ANGLE/src/compiler/ShaderLang.cpp: Removed.
* ANGLE/src/compiler/SymbolTable.cpp: Removed.
* ANGLE/src/compiler/SymbolTable.h: Removed.
* ANGLE/src/compiler/TranslatorGLSL.cpp: Removed.
* ANGLE/src/compiler/TranslatorGLSL.h: Removed.
* ANGLE/src/compiler/TranslatorHLSL.cpp: Removed.
* ANGLE/src/compiler/TranslatorHLSL.h: Removed.
* ANGLE/src/compiler/Types.h: Removed.
* ANGLE/src/compiler/UnfoldSelect.cpp: Removed.
* ANGLE/src/compiler/UnfoldSelect.h: Removed.
* ANGLE/src/compiler/debug.cpp: Removed.
* ANGLE/src/compiler/debug.h: Removed.
* ANGLE/src/compiler/glslang.l: Removed.
* ANGLE/src/compiler/glslang.y: Removed.
* ANGLE/src/compiler/intermOut.cpp: Removed.
* ANGLE/src/compiler/intermediate.h: Removed.
* ANGLE/src/compiler/localintermediate.h: Removed.
* ANGLE/src/compiler/osinclude.h: Removed.
* ANGLE/src/compiler/ossource_posix.cpp: Removed.
* ANGLE/src/compiler/ossource_win.cpp: Removed.
* ANGLE/src/compiler/parseConst.cpp: Removed.
* ANGLE/src/compiler/preprocessor: Removed.
* ANGLE/src/compiler/preprocessor/atom.c: Removed.
* ANGLE/src/compiler/preprocessor/atom.h: Removed.
* ANGLE/src/compiler/preprocessor/compile.h: Removed.
* ANGLE/src/compiler/preprocessor/cpp.c: Removed.
* ANGLE/src/compiler/preprocessor/cpp.h: Removed.
* ANGLE/src/compiler/preprocessor/cppstruct.c: Removed.
* ANGLE/src/compiler/preprocessor/memory.c: Removed.
* ANGLE/src/compiler/preprocessor/memory.h: Removed.
* ANGLE/src/compiler/preprocessor/parser.h: Removed.
* ANGLE/src/compiler/preprocessor/preprocess.h: Removed.
* ANGLE/src/compiler/preprocessor/scanner.c: Removed.
* ANGLE/src/compiler/preprocessor/scanner.h: Removed.
* ANGLE/src/compiler/preprocessor/slglobals.h: Removed.
* ANGLE/src/compiler/preprocessor/symbols.c: Removed.
* ANGLE/src/compiler/preprocessor/symbols.h: Removed.
* ANGLE/src/compiler/preprocessor/tokens.c: Removed.
* ANGLE/src/compiler/preprocessor/tokens.h: Removed.
* ANGLE/src/compiler/tools: Removed.
* ANGLE/src/compiler/unistd.h: Removed.
* ANGLE/src/libEGL: Removed.
* ANGLE/src/libEGL/Config.cpp: Removed.
* ANGLE/src/libEGL/Config.h: Removed.
* ANGLE/src/libEGL/Display.cpp: Removed.
* ANGLE/src/libEGL/Display.h: Removed.
* ANGLE/src/libEGL/Surface.cpp: Removed.
* ANGLE/src/libEGL/Surface.h: Removed.
* ANGLE/src/libEGL/libEGL.cpp: Removed.
* ANGLE/src/libEGL/libEGL.def: Removed.
* ANGLE/src/libEGL/libEGL.vcproj: Removed.
* ANGLE/src/libEGL/main.cpp: Removed.
* ANGLE/src/libEGL/main.h: Removed.
* ANGLE/src/libGLESv2: Removed.
* ANGLE/src/libGLESv2/Blit.cpp: Removed.
* ANGLE/src/libGLESv2/Blit.h: Removed.
* ANGLE/src/libGLESv2/Buffer.cpp: Removed.
* ANGLE/src/libGLESv2/Buffer.h: Removed.
* ANGLE/src/libGLESv2/Context.cpp: Removed.
* ANGLE/src/libGLESv2/Context.h: Removed.
* ANGLE/src/libGLESv2/Framebuffer.cpp: Removed.
* ANGLE/src/libGLESv2/Framebuffer.h: Removed.
* ANGLE/src/libGLESv2/Program.cpp: Removed.
* ANGLE/src/libGLESv2/Program.h: Removed.
* ANGLE/src/libGLESv2/RefCountObject.cpp: Removed.
* ANGLE/src/libGLESv2/RefCountObject.h: Removed.
* ANGLE/src/libGLESv2/Renderbuffer.cpp: Removed.
* ANGLE/src/libGLESv2/Renderbuffer.h: Removed.
* ANGLE/src/libGLESv2/ResourceManager.cpp: Removed.
* ANGLE/src/libGLESv2/ResourceManager.h: Removed.
* ANGLE/src/libGLESv2/Shader.cpp: Removed.
* ANGLE/src/libGLESv2/Shader.h: Removed.
* ANGLE/src/libGLESv2/Texture.cpp: Removed.
* ANGLE/src/libGLESv2/Texture.h: Removed.
* ANGLE/src/libGLESv2/geometry: Removed.
* ANGLE/src/libGLESv2/geometry/IndexDataManager.cpp: Removed.
* ANGLE/src/libGLESv2/geometry/IndexDataManager.h: Removed.
* ANGLE/src/libGLESv2/geometry/VertexDataManager.cpp: Removed.
* ANGLE/src/libGLESv2/geometry/VertexDataManager.h: Removed.
* ANGLE/src/libGLESv2/geometry/backend.cpp: Removed.
* ANGLE/src/libGLESv2/geometry/backend.h: Removed.
* ANGLE/src/libGLESv2/geometry/dx9.cpp: Removed.
* ANGLE/src/libGLESv2/geometry/dx9.h: Removed.
* ANGLE/src/libGLESv2/geometry/vertexconversion.h: Removed.
* ANGLE/src/libGLESv2/libGLESv2.cpp: Removed.
* ANGLE/src/libGLESv2/libGLESv2.def: Removed.
* ANGLE/src/libGLESv2/libGLESv2.vcproj: Removed.
* ANGLE/src/libGLESv2/main.cpp: Removed.
* ANGLE/src/libGLESv2/main.h: Removed.
* ANGLE/src/libGLESv2/mathutil.h: Removed.
* ANGLE/src/libGLESv2/utilities.cpp: Removed.
* ANGLE/src/libGLESv2/utilities.h: Removed.
* Makefile:
* Sources/ThirdParty: Added.
* Sources/ThirdParty/ANGLE: Copied from ANGLE.

Tools:

* Scripts/build-webkit:
  - Point to the new ANGLE location.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 27 Dec 2010 04:42:01 +0000 (04:42 +0000)]
2010-12-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Dan Bernstein.

        For box-shadow, non-primary shadows should have specified radii.
        https://bugs.webkit.org/show_bug.cgi?id=51386

        * fast/box-shadow/spread-multiple-normal-expected.txt: Added.
        * fast/box-shadow/spread-multiple-normal.html: Added.
        * fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
        * fast/box-shadow/spread-multiple-normal-expected.png: Added.
2010-12-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Dan Bernstein.

        For box-shadow, non-primary shadows should have specified radii.
        https://bugs.webkit.org/show_bug.cgi?id=51386

        On paintBoxShadow(), the spread value accidentally accumulated accidentally
        during the loop, which should be applied individually for radius of each shadow.
        This change makes the radii for rects computed for each shadow.

        Test: fast/box-shadow/spread-multiple-normal.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 Xan Lopez <xlopez@igalia.com>
commit-queue@webkit.org [Sun, 26 Dec 2010 22:13:16 +0000 (22:13 +0000)]
2010-12-26  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Add standalone target for JSC
        https://bugs.webkit.org/show_bug.cgi?id=51607

        * GNUmakefile.am: add convenience target to only build jsc and its
        dependencies.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 26 Dec 2010 22:00:33 +0000 (22:00 +0000)]
2010-12-26  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Improve output of HTML parser benchmark
        https://bugs.webkit.org/show_bug.cgi?id=51611

        Calculate and show median, min and max values.

        * benchmarks/parser/html-parser.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 David Levin <levin@chromium.org>
levin@chromium.org [Sun, 26 Dec 2010 20:27:49 +0000 (20:27 +0000)]
2010-12-26  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style should be able to parse function declaration parameters.
        https://bugs.webkit.org/show_bug.cgi?id=51451

        * Scripts/webkitpy/style/checkers/cpp.py:
        (Position.__init__): Holds simple position information (row, column).
        (Parameter.__init__): Holds information about a parameter.
        (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
        (SingleLineView.convert_column_to_row): Returns the original row given a column.
        (create_skeleton_parameters): Simplifies a parameter list for easier searching.
        (find_parameter_name_index): Finds where the parameter name is.
        (parameter_list): Generates the list of parameters for a function.
        (_FunctionState.begin): Added information to allow determining the parameters
        on demand.
        (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
        (detect_functions): Improve function detection for operator functions and
        determine where the parameters end and pass that to _FunctionState.begin.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
        (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
        (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
        (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
        (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
        Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
        (FunctionDetectionTest.perform_function_detection): Added support for verifying
        the parameters found.
        (FunctionDetectionTest.test_function_declaration_detection): Added more function
        detection test to verify that we catch the operator functions.
        (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
        (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
        (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
        because the error. The test is about the bad function name. Fixing the name makes the test exactly like
        test_function_length_check_definition_severity1_for_test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename DrawingAreaMessage and DrawingAreaLegacyMessage and
andersca@apple.com [Sun, 26 Dec 2010 19:41:17 +0000 (19:41 +0000)]
Rename DrawingAreaMessage and DrawingAreaLegacyMessage and
DrawingAreaProxyMessage to DrawingAreaProxyLegacyMessage.

Reviewed by Dan Bernstein.

* Platform/CoreIPC/MessageID.h:
* Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
* Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::sizeDidChange):
(WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
(WebKit::LayerBackedDrawingAreaProxy::update):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::didReceiveMessage):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::setSize):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::setSize):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
(WebKit::LayerBackedDrawingArea::attachCompositingContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDrawing area cleanup. Remove a bunch of redundant functions that just ended
andersca@apple.com [Sun, 26 Dec 2010 19:26:36 +0000 (19:26 +0000)]
Drawing area cleanup. Remove a bunch of redundant functions that just ended
up calling setNeedsDisplay.

Reviewed by Sam Weinig.

* UIProcess/DrawingAreaProxy.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateWindow):
(WebKit::WebChromeClient::invalidateContentsAndWindow):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/TiledDrawingArea.cpp:
* WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 Kenneth Russell <kbr@google.com>
kbr@google.com [Sun, 26 Dec 2010 16:57:40 +0000 (16:57 +0000)]
2010-12-26  Kenneth Russell  <kbr@google.com>

        Unreviewed, Chromium expectations fix. Fix broken (duplicate)
        expectations for
        canvas/philip/tests/2d.gradient.radial.cone.top.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sun, 26 Dec 2010 16:04:58 +0000 (16:04 +0000)]
2010-12-26  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer.
        https://bugs.webkit.org/show_bug.cgi?id=48772

        Test: fast/multicol/renderer-positioned-assert-crash.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintPaginatedChildLayer):
        (WebCore::RenderLayer::hitTestPaginatedChildLayer):
2010-12-26  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Tests passes if it does not crash.
        https://bugs.webkit.org/show_bug.cgi?id=48772

        * fast/multicol/renderer-positioned-assert-crash-expected.txt: Added.
        * fast/multicol/renderer-positioned-assert-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 26 Dec 2010 10:04:26 +0000 (10:04 +0000)]
2010-12-26  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE buildfix after r74626.

        * cmake/OptionsWinCE.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-25 Kenneth Russell <kbr@google.com>
kbr@google.com [Sun, 26 Dec 2010 05:05:27 +0000 (05:05 +0000)]
2010-12-25  Kenneth Russell  <kbr@google.com>

        Unreviewed, Chromium test expectations update.

        * platform/chromium-gpu/test_expectations.txt:
          Win Debug:
          Marked compositing/tiling/huge-layer-img.html as TIMEOUT.
          Marked fast/canvas/webgl/gl-object-get-calls.html as a flaky crash.
        * platform/chromium/test_expectations.txt:
          Adjusted expectations for the following tests:
          fast/canvas/shadow-offset-7.html
          svg/batik/paints/gradientLimit.svg
          fast/events/touch/touch-target.html
          canvas/philip/tests/2d.gradient.radial.cone.top.html
          fast/css/box-shadow.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-25 Peter Rybin <peter.rybin@gmail.com>
commit-queue@webkit.org [Sun, 26 Dec 2010 01:49:06 +0000 (01:49 +0000)]
2010-12-25  Peter Rybin  <peter.rybin@gmail.com>

        Reviewed by Adam Barth.

        Adds currentColumn (and currentLine) to SegmentedString. Switches
        HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
        needs position for a <script> tag.

        SegmentedString should provide column position
        https://bugs.webkit.org/show_bug.cgi?id=51311

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::textPosition):
        * html/parser/HTMLInputStream.h:
        (WebCore::HTMLInputStream::current):
        (WebCore::InsertionPointRecord::InsertionPointRecord):
        (WebCore::InsertionPointRecord::~InsertionPointRecord):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
        (WebCore::HTMLTreeBuilder::processScriptStartTag):
        * html/parser/HTMLTreeBuilder.h:
        (WebCore::HTMLTreeBuilder::create):
        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::operator=):
        (WebCore::SegmentedString::numberOfCharactersConsumedSlow):
        (WebCore::SegmentedString::advanceSlowCase):
        (WebCore::SegmentedString::currentLine):
        (WebCore::SegmentedString::currentColumn):
        (WebCore::SegmentedString::setCurrentPosition):
        * platform/text/SegmentedString.h:
        (WebCore::SegmentedString::SegmentedString):
        (WebCore::SegmentedString::advancePastNewline):
        (WebCore::SegmentedString::advance):
        (WebCore::SegmentedString::numberOfCharactersConsumed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-25 Andreas Kling <kling@webkit.org>
commit-queue@webkit.org [Sun, 26 Dec 2010 00:38:09 +0000 (00:38 +0000)]
2010-12-25  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        GraphicsContext: Don't pass StrokeStyle (enum) as const reference
        https://bugs.webkit.org/show_bug.cgi?id=51608

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setStrokeStyle):
        (WebCore::GraphicsContext::setPlatformStrokeStyle):
        (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::setPlatformStrokeStyle):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::setPlatformStrokeStyle):
        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::setPlatformStrokeStyle):
        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PainterOpenVG::setStrokeStyle):
        * platform/graphics/openvg/PainterOpenVG.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::setPlatformStrokeStyle):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformStrokeStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFill in some more preferences for WebKit2
weinig@apple.com [Sat, 25 Dec 2010 20:53:44 +0000 (20:53 +0000)]
Fill in some more preferences for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51610

Reviewed by Dan Bernstein.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAuthorAndUserStylesEnabled):
(WKPreferencesGetAuthorAndUserStylesEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
(WKPreferencesSetLocalFileContentSniffingEnabled):
(WKPreferencesGetLocalFileContentSniffingEnabled):
(WKPreferencesSetPageCacheEnabled):
(WKPreferencesGetPageCacheEnabled):
(WKPreferencesSetPaginateDuringLayoutEnabled):
(WKPreferencesGetPaginateDuringLayoutEnabled):
(WKPreferencesSetDOMPasteAllowedEnabled):
(WKPreferencesGetDOMPasteAllowedEnabled):
* UIProcess/API/C/WKPreferences.h:
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe through some more preferences.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-25 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 25 Dec 2010 20:21:06 +0000 (20:21 +0000)]
2010-12-25  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE buildfix after r74334.

        * CMakeListsWinCE.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-25 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Sat, 25 Dec 2010 09:52:47 +0000 (09:52 +0000)]
2010-12-25  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip another GTK media test reporting wrong duration,
        see bug 50518.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Kenneth Russell <kbr@google.com>
kbr@google.com [Sat, 25 Dec 2010 06:00:19 +0000 (06:00 +0000)]
2010-12-24  Kenneth Russell  <kbr@google.com>

        Unreviewed, Chromium test expectations update.
        svg/batik/paints/gradientLimit.svg fails on Linux Debug as well.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r74648): XHR layout test failures
mitz@apple.com [Sat, 25 Dec 2010 01:52:13 +0000 (01:52 +0000)]
REGRESSION (r74648): XHR layout test failures
https://bugs.webkit.org/show_bug.cgi?id=51603

Reviewed by Alexey Proskuryakov.

Reverted r74648.

WebCore:

* WebCore.exp.in:

WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 24 Dec 2010 22:33:19 +0000 (22:33 +0000)]
2010-12-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing media test on GTK.

        * platform/gtk/Skipped: Skip media/controls-after-reload.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Sheriff Bot <webkit.review.bot@gmail.com>
philn@webkit.org [Fri, 24 Dec 2010 21:43:33 +0000 (21:43 +0000)]
2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74632.
        http://trac.webkit.org/changeset/74632
        https://bugs.webkit.org/show_bug.cgi?id=51600

        makes test-webkitpy hang forever on GTK (Requested by philn-tp
        on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 24 Dec 2010 21:26:05 +0000 (21:26 +0000)]
2010-12-24  Simon Fraser  <simon.fraser@apple.com>

        Fix the Qt build after r74650.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Andrei Popescu <andreip@google.com>
andreip@google.com [Fri, 24 Dec 2010 21:24:22 +0000 (21:24 +0000)]
2010-12-24  Andrei Popescu  <andreip@google.com>

        Unreviewed, build fix.

        [Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac, Windows and Linux specific test expectations
        https://bugs.webkit.org/show_bug.cgi?id=51589

        * platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
        * platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Qt build after r74648.
mitz@apple.com [Fri, 24 Dec 2010 21:13:40 +0000 (21:13 +0000)]
Try to fix the Qt build after r74648.

* WebCore.gypi:
* WebCore.pro:
* platform/network/qt/CredentialStorageQt.cpp: Added.
(WebCore::CredentialStorage::getFromPersistentStorage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 24 Dec 2010 20:57:13 +0000 (20:57 +0000)]
2010-12-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, updated GTK media tests baselines after r74643.

        * platform/gtk/media/audio-controls-rendering-expected.txt:
        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-controls-rendering-expected.txt:
        * platform/gtk/media/video-display-toggle-expected.txt:
        * platform/gtk/media/video-empty-source-expected.txt:
        * platform/gtk/media/video-no-audio-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Benjamin Poulain <ikipou@gmail.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 20:55:32 +0000 (20:55 +0000)]
2010-12-24  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Darin Adler.

        [Qt] [WK2] WebKit 2 does not build on mac, missing reference to RetainPtr
        https://bugs.webkit.org/show_bug.cgi?id=51598

        Fix the build, add the missing header.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 24 Dec 2010 20:46:53 +0000 (20:46 +0000)]
2010-12-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        CSSStyleSelector cleanup
        https://bugs.webkit.org/show_bug.cgi?id=51597

        Make some methods const. Add assertion to checkOneSelector, with the
        intention of later removing the if (!e) check (this is hot code).

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::locateCousinList):
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::locateSharedStyle):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        (WebCore::CSSStyleSelector::mmLength):
        (WebCore::CSSStyleSelector::inchLength):
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        (WebCore::CSSStyleSelector::hasSelectorForAttribute):
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::fontSelector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8758386> The web process uses its own credential storage
mitz@apple.com [Fri, 24 Dec 2010 20:24:37 +0000 (20:24 +0000)]
<rdar://problem/8758386> The web process uses its own credential storage
https://bugs.webkit.org/show_bug.cgi?id=51599

Reviewed by Anders Carlsson.

WebCore:

* WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),
and Credential::isEmpty().

WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge): Try to answer the challenge using
the UI process’s credential storage first.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Prevent the web process from using
its own credential storage.
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebased Leopard to expect the same kind of stack failure
darin@apple.com [Fri, 24 Dec 2010 19:36:29 +0000 (19:36 +0000)]
Rebased Leopard to expect the same kind of stack failure
as Windows, rather than the success expected on Snow Leopard
and many other platforms.

* platform/mac-leopard/fast/js/large-expressions-expected.txt:
Copied from platform/win/fast/js/large-expressions-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 24 Dec 2010 19:36:03 +0000 (19:36 +0000)]
2010-12-24  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Darin Adler.

        [V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
        https://bugs.webkit.org/show_bug.cgi?id=51595

        * WebCore.gypi:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp.
        (WebCore::V8EventListener::V8EventListener):
        (WebCore::V8EventListener::getListenerFunction):
        (WebCore::V8EventListener::callListenerFunction):
        * bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h.
        (WebCore::V8EventListener::create):
        * bindings/v8/V8EventListenerList.h:
        * bindings/v8/V8WorkerContextEventListener.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8NodeCustom.cpp:
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows-specific (failing) expected results for
jberlin@webkit.org [Fri, 24 Dec 2010 19:26:52 +0000 (19:26 +0000)]
Add Windows-specific (failing) expected results for
http/tests/xmlhttprequest/basic-auth-nouser.html and basic-auth-nopassword.html in order to
get the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51596

* platform/win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated makefiles used by Apple engineers to fix build with the
darin@apple.com [Fri, 24 Dec 2010 19:26:23 +0000 (19:26 +0000)]
Updated makefiles used by Apple engineers to fix build with the
new JavaScriptGlue location.

* Makefile: Told this to build JavaScriptGlue. Some day we might
want it to descend into Sources instead and use the Makefile there,
but there are problems with sequencing the project builds, so that
can wait.
* Sources/Makefile.shared: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 19:02:25 +0000 (19:02 +0000)]
2010-12-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Show current time / total in media player
        https://bugs.webkit.org/show_bug.cgi?id=51535

        * css/mediaControlsGtk.css:
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime):
        (WebCore::RenderThemeGtk::paintMediaCurrentTime):
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 18:55:35 +0000 (18:55 +0000)]
2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Eric Seidel.

        Clean up CSSRuleData in CSSStyleSelector.h
        https://bugs.webkit.org/show_bug.cgi?id=27753

        Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleData::CSSRuleData):
        (WebCore::CSSRuleData::~CSSRuleData):
        (WebCore::CSSRuleData::position):
        (WebCore::CSSRuleData::rule):
        (WebCore::CSSRuleData::selector):
        (WebCore::CSSRuleData::next):
        (WebCore::CSSRuleDataList::CSSRuleDataList):
        (WebCore::CSSRuleDataList::~CSSRuleDataList):
        (WebCore::CSSRuleDataList::first):
        (WebCore::CSSRuleDataList::last):
        (WebCore::CSSRuleDataList::append):
        * css/CSSStyleSelector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip the new editing/input/ime-composition-clearpreedit.html test since textInputCont...
jberlin@webkit.org [Fri, 24 Dec 2010 18:54:17 +0000 (18:54 +0000)]
Skip the new editing/input/ime-composition-clearpreedit.html test since textInputController
is unimplemented in the DRT for Windows. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=32021

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 18:43:36 +0000 (18:43 +0000)]
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Screen doesn't be rendered when changing size of EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=43528

        Remove on_resize because ewk_view_fixed_layout_size_set should not be
        called on callback of EVAS_CALLBACK_RESIZE. As it change size of
        FrameView, rendering was ignored when _ewk_view_smart_calculate was
        called.

        * EWebLauncher/main.c:
        (browserCreate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 24 Dec 2010 18:21:28 +0000 (18:21 +0000)]
2010-12-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
        https://bugs.webkit.org/show_bug.cgi?id=28291

        This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
        We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
        to strings with find in the diff.
        Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/diff_parser.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
        * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 24 Dec 2010 18:20:32 +0000 (18:20 +0000)]
2010-12-24  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix compilation on Windows.

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
        * inspector/InspectorStyleSheet.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 24 Dec 2010 17:51:25 +0000 (17:51 +0000)]
2010-12-24  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Darin Adler.

        inspector/debugger-step-out.html crashing intermittently in the bots
        https://bugs.webkit.org/show_bug.cgi?id=50868

        Use RefPtr rather instead of raw pointers when keeping references
        to refcounted objects.

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode2):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::create):
        (WebCore::InspectorStyle::InspectorStyle):
        (WebCore::InspectorStyle::buildObjectForStyle):
        (WebCore::InspectorStyle::setPropertyText):
        (WebCore::InspectorStyle::toggleProperty):
        (WebCore::InspectorStyle::styleText):
        (WebCore::InspectorStyle::populateAllProperties):
        (WebCore::InspectorStyle::replacePropertyInStyleText):
        (WebCore::InspectorStyleSheet::create):
        (WebCore::InspectorStyleSheet::InspectorStyleSheet):
        (WebCore::InspectorStyleSheetForInlineStyle::create):
        (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
        (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
        * inspector/InspectorStyleSheet.h:
        (WebCore::InspectorStyle::cssStyle):
        (WebCore::InspectorStyleSheet::pageStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 24 Dec 2010 17:31:15 +0000 (17:31 +0000)]
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Nikolas Zimmermann.

        SVGElementInstance::m_useElement should be cleared when use element is removed from document
        https://bugs.webkit.org/show_bug.cgi?id=51486

        Test: svg/custom/use-instanceRoot-with-use-removed.svg

        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
        * svg/SVGElementInstance.h:
        (WebCore::SVGElementInstance::clearUseElement):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::removedFromDocument):
        (WebCore::ShadowTreeUpdateBlocker::if):
        (WebCore::SVGUseElement::detachInstance):
        (WebCore::SVGUseElement::detach):
        * svg/SVGUseElement.h:
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Nikolas Zimmermann.

        SVGElementInstance::m_useElement should be cleared when use element is removed from document
        https://bugs.webkit.org/show_bug.cgi?id=51486

        * svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
        * svg/custom/use-instanceRoot-with-use-removed.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Joseph Pecoraro <joepeck@webkit.org>
yurys@chromium.org [Fri, 24 Dec 2010 17:01:04 +0000 (17:01 +0000)]
2010-12-23  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Missing Localized Strings
        https://bugs.webkit.org/show_bug.cgi?id=51542

        Added missing strings: "WebSocket",  "Frames", "Text", "Transfer",
        "Preserve Log upon Navigation", and "Go to Line".

        * English.lproj/localizedStrings.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 24 Dec 2010 16:39:32 +0000 (16:39 +0000)]
2010-12-24  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
        https://bugs.webkit.org/show_bug.cgi?id=51478

        Now the element attribute modifications (including "style") are tracked, which results in the
        source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
        on the "style" attribute modification through the Elements tree. Also, it appears that
        a complete "style" attribute removal destroys the inline style declaration
        (StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).

        Test: inspector/elements-delete-inline-style.html

        WebCore:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::didModifyDOMAttr):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::didModifyDOMAttr):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
        (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
        (WebCore::InspectorStyleSheetForInlineStyle::text):
        (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
        (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

        LayoutTests:
        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.addResults):
        (initialize_InspectorTest.InspectorTest.createKeyEvent):
        * inspector/elements-delete-inline-style-expected.txt: Added.
        * inspector/elements-delete-inline-style.html: Added.
        * inspector/elements-tests2.js: Added.
        (initialize_ElementTest.InspectorTest.expandDOMSubtree.processChildren):
        (initialize_ElementTest.InspectorTest.expandDOMSubtree):
        (initialize_ElementTest.InspectorTest.expandDOMSubtreeAndRun):
        (initialize_ElementTest.InspectorTest.nodeForId):
        (initialize_ElementTest.InspectorTest.selectElementAndRun):
        (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
        (initialize_ElementTest.InspectorTest.getSelectedElementStyles):
        (initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
        (initialize_ElementTest.InspectorTest.dumpStyleTreeOutline):
        (initialize_ElementTest.InspectorTest.dumpStyleTreeItem):
        (initialize_ElementTest):
        * inspector/styles-add-blank-property.html: Remove unnecessary function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Fri, 24 Dec 2010 12:18:04 +0000 (12:18 +0000)]
2010-12-24  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        editing/selection/caret-* tests need rebaseline for gtk
        https://bugs.webkit.org/show_bug.cgi?id=51578

        Rebaseline editing/selection/caret-* tests for gtk.

        * platform/gtk/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-2-expected.txt: Added.
        * platform/gtk/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-2-left-expected.txt: Added.
        * platform/gtk/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-expected.txt: Added.
        * platform/gtk/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-right-expected.txt: Added.
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.txt: Added.
        * platform/gtk/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/gtk/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 24 Dec 2010 12:12:30 +0000 (12:12 +0000)]
2010-12-24  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kenneth Russell.

        Modify new-run-webkit-tests to shut up and exit when all the threads
        are wedged so that test runs complete faster and we don't end up
        w/ enormous log files.

        https://bugs.webkit.org/show_bug.cgi?id=51572

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 12:05:55 +0000 (12:05 +0000)]
2010-12-24  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Andreas Kling.

        [chromium] Fix a style nit in the JPEG encoder
        https://bugs.webkit.org/show_bug.cgi?id=51574

        * platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 24 Dec 2010 12:02:31 +0000 (12:02 +0000)]
2010-12-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Maciej Stachowiak.

        Web Inspector: CSS shorthand properties expand unnecessarily
        https://bugs.webkit.org/show_bug.cgi?id=36304

        "border-radius" is a shorthand property that has a "non-standard" format and longhands, see
        http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
        standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
        This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
        appropriately when adding implicit longhands, thus they were added as normal properties
        found in the CSS (neither implicit, nor longhands). This is now fixed.

        WebCore:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseBorderRadius):

        LayoutTests:
        * inspector/elements-panel-styles-expected.txt:
        * inspector/resources/elements-panel-styles.css:
        (.foo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 24 Dec 2010 11:54:24 +0000 (11:54 +0000)]
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
        https://bugs.webkit.org/show_bug.cgi?id=51576

        * svg/custom/animate-disallowed-use-element-expected.txt: Added.
        * svg/custom/animate-disallowed-use-element.svg: Added.
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
        https://bugs.webkit.org/show_bug.cgi?id=51576

        Disallowed elements may be pruned from the shadow tree, leaving a null
        shadowTreeElement. We should check for that before setting attributes.

        Test: svg/custom/animate-disallowed-use-element.svg

        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 24 Dec 2010 11:50:34 +0000 (11:50 +0000)]
2010-12-24  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        TextMetrics::width is an integer, but the member is a float
        https://bugs.webkit.org/show_bug.cgi?id=51566

        Change the return type to a float.

        No tests, fixing a compiler warning.
        (I was unable to produce a difference in the values exposed to pages
        with a float versus the previous conversion to an integer.)

        * html/TextMetrics.h:
        (WebCore::TextMetrics::width):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Andrei Popescu <andreip@google.com>
andreip@google.com [Fri, 24 Dec 2010 11:47:27 +0000 (11:47 +0000)]
2010-12-24  Andrei Popescu  <andreip@google.com>

        Unreviewed build fix.

        Add Chromium-mac test expectation for the layout test below.
        [Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac specific test expectations
        https://bugs.webkit.org/show_bug.cgi?id=51589

        * platform/chromium-mac/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 11:27:55 +0000 (11:27 +0000)]
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add option to enable Touch Events.
        https://bugs.webkit.org/show_bug.cgi?id=49125

        Add ENABLE_TOUCH_EVENTS option.

        * cmake/OptionsEfl.cmake:
        * cmakeconfig.h.cmake:
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add option to enable Touch Events.
        https://bugs.webkit.org/show_bug.cgi?id=49125

        Add files for EFL to support TOUCH_EVENTS.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:
        * platform/PlatformTouchEvent.h: Add EFL related constructor.
        * platform/PlatformTouchPoint.h: ditto.
        * platform/efl/PlatformTouchEventEfl.cpp: Added.
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
        * platform/efl/PlatformTouchPointEfl.cpp: Added.
        (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add option to enable Touch Events.
        https://bugs.webkit.org/show_bug.cgi?id=49125

        Implement ewk_frame_feed_touch_event to feed touch events. Because EFL
        doesn't have touch events, Application should generate and pass it.

        * WebCoreSupport/ChromeClientEfl.h:
        (WebCore::ChromeClientEfl::needTouchEvents):
        * ewk/ewk_frame.cpp:
        (ewk_frame_feed_touch_event):
        * ewk/ewk_frame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 24 Dec 2010 11:23:17 +0000 (11:23 +0000)]
2010-12-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
        https://bugs.webkit.org/show_bug.cgi?id=51457

        WebKit EFL can't play html5 audio because of wrong mime type checking.
        So, 'application/octet-stream' is changed with an empty string.

        * platform/efl/MIMETypeRegistryEfl.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        Returns an empty string instead of application/octet-stream when it can't find proper mime type.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Andrei Popescu <andreip@google.com>
andreip@google.com [Fri, 24 Dec 2010 11:09:12 +0000 (11:09 +0000)]
2010-12-24  Andrei Popescu  <andreip@google.com>

        Unreviewed. Update Chromium test expectations.

        Mark editing/input/ime-composition-clearpreedit.html.html as TEXT.
        This test was added in http://trac.webkit.org/changeset/74605 and
        fails in Chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 24 Dec 2010 11:05:21 +0000 (11:05 +0000)]
2010-12-24  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        commit-queue should better explain how it will re-open bugs and follow duplicate chains
        https://bugs.webkit.org/show_bug.cgi?id=51549

        I've had multiple people ask me about the commit-queue's behavior
        regarding reporting flaky tests.  I figured it would be best to just
        have the queue explain itself in the bugs it files.

        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 24 Dec 2010 10:38:53 +0000 (10:38 +0000)]
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        SVGFontFaceElement::rebuildFontFace() should exit when not in document
        https://bugs.webkit.org/show_bug.cgi?id=51571

        * svg/custom/use-invalid-font-face-expected.txt: Added.
        * svg/custom/use-invalid-font-face.svg: Added.
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        SVGFontFaceElement::rebuildFontFace() should exit when not in document
        https://bugs.webkit.org/show_bug.cgi?id=51571

        We were hitting a NULL deref crash. Since most of the callers checked
        inDocument() anyway, I moved it into the start of rebuildFontFace.

        Test: svg/custom/use-invalid-font-face.svg

        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::parseMappedAttribute):
        (WebCore::SVGFontFaceElement::rebuildFontFace):
        (WebCore::SVGFontFaceElement::childrenChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 24 Dec 2010 10:19:04 +0000 (10:19 +0000)]
2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
        https://bugs.webkit.org/show_bug.cgi?id=51467

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 24 Dec 2010 10:12:24 +0000 (10:12 +0000)]
2010-12-21  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] minimal build with --database fails
        https://bugs.webkit.org/show_bug.cgi?id=51394

        * webkit/webkitprivate.cpp:
        (webkit_init): Use cacheStorage() only if the
        OFFLINE_WEB_APPLICATIONS feature is enabled.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 24 Dec 2010 10:00:08 +0000 (10:00 +0000)]
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
        https://bugs.webkit.org/show_bug.cgi?id=51564

        This check was duplicating an ASSERT for a case fixed in r73927.
        Now that the bug is fixed the check is no longer necessary.

        Removing dead code, so no new tests needed.

        * css/CSSCanvasValue.cpp:
        (WebCore::CSSCanvasValue::canvasDestroyed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove JavaScriptGlue into Sources
abarth@webkit.org [Fri, 24 Dec 2010 09:01:54 +0000 (09:01 +0000)]
Move JavaScriptGlue into Sources
https://bugs.webkit.org/show_bug.cgi?id=51583

Rubber-stamped by Eric Seidel.

Actually perform the move.

* JavaScriptGlue: Removed.
* JavaScriptGlue/Configurations: Removed.
* JavaScriptGlue/Configurations/Base.xcconfig: Removed.
* JavaScriptGlue/Configurations/DebugRelease.xcconfig: Removed.
* JavaScriptGlue/Configurations/JavaScriptGlue.xcconfig: Removed.
* JavaScriptGlue/Configurations/Version.xcconfig: Removed.
* JavaScriptGlue/English.lproj: Removed.
* JavaScriptGlue/English.lproj/InfoPlist.strings: Removed.
* JavaScriptGlue/ForwardingHeaders: Removed.
* JavaScriptGlue/ForwardingHeaders/masm: Removed.
* JavaScriptGlue/ForwardingHeaders/masm/X86Assembler.h: Removed.
* JavaScriptGlue/ForwardingHeaders/profiler: Removed.
* JavaScriptGlue/ForwardingHeaders/profiler/Profiler.h: Removed.
* JavaScriptGlue/ForwardingHeaders/runtime: Removed.
* JavaScriptGlue/ForwardingHeaders/runtime/CallFrame.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ASCIICType.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/AlwaysInline.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Assertions.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Atomics.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Bitmap.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/BumpPointerAllocator.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/CurrentTime.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/DateInstanceCache.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/DateMath.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FastAllocBase.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/FixedArray.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Forward.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashCountedSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashFunctions.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashMap.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/HashTraits.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ListHashSet.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ListRefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Locker.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/MainThread.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/MathExtras.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Noncopyable.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/NotFound.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OSAllocator.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/OwnPtrCommon.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageAllocation.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageAllocationAligned.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageBlock.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PageReservation.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassOwnArrayPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassOwnPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Platform.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PossiblyNull.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RandomNumber.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StackBounds.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/StringHasher.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadSpecific.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Threading.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ThreadingPrimitives.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/UnusedParam.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/VMTags.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/ValueCheck.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/Vector.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/VectorTraits.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/CString.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringHash.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringImpl.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/StringImplBase.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/TextPosition.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/text/WTFString.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/Unicode.h: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu: Removed.
* JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed.
* JavaScriptGlue/Info.plist: Removed.
* JavaScriptGlue/JSBase.cpp: Removed.
* JavaScriptGlue/JSBase.h: Removed.
* JavaScriptGlue/JSObject.cpp: Removed.
* JavaScriptGlue/JSObject.h: Removed.
* JavaScriptGlue/JSRun.cpp: Removed.
* JavaScriptGlue/JSRun.h: Removed.
* JavaScriptGlue/JSUtils.cpp: Removed.
* JavaScriptGlue/JSUtils.h: Removed.
* JavaScriptGlue/JSValueWrapper.cpp: Removed.
* JavaScriptGlue/JSValueWrapper.h: Removed.
* JavaScriptGlue/JavaScriptGlue.cpp: Removed.
* JavaScriptGlue/JavaScriptGlue.exp: Removed.
* JavaScriptGlue/JavaScriptGlue.h: Removed.
* JavaScriptGlue/JavaScriptGlue.xcodeproj: Removed.
* JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj: Removed.
* JavaScriptGlue/LICENSE: Removed.
* JavaScriptGlue/Makefile: Removed.
* JavaScriptGlue/UserObjectImp.cpp: Removed.
* JavaScriptGlue/UserObjectImp.h: Removed.
* JavaScriptGlue/config.h: Removed.
* JavaScriptGlue/icu: Removed.
* JavaScriptGlue/icu/LICENSE: Removed.
* JavaScriptGlue/icu/README: Removed.
* JavaScriptGlue/icu/unicode: Removed.
* JavaScriptGlue/icu/unicode/platform.h: Removed.
* JavaScriptGlue/icu/unicode/putil.h: Removed.
* JavaScriptGlue/icu/unicode/uchar.h: Removed.
* JavaScriptGlue/icu/unicode/ucnv.h: Removed.
* JavaScriptGlue/icu/unicode/ucnv_err.h: Removed.
* JavaScriptGlue/icu/unicode/uconfig.h: Removed.
* JavaScriptGlue/icu/unicode/uenum.h: Removed.
* JavaScriptGlue/icu/unicode/uiter.h: Removed.
* JavaScriptGlue/icu/unicode/umachine.h: Removed.
* JavaScriptGlue/icu/unicode/urename.h: Removed.
* JavaScriptGlue/icu/unicode/ustring.h: Removed.
* JavaScriptGlue/icu/unicode/utf.h: Removed.
* JavaScriptGlue/icu/unicode/utf16.h: Removed.
* JavaScriptGlue/icu/unicode/utf8.h: Removed.
* JavaScriptGlue/icu/unicode/utf_old.h: Removed.
* JavaScriptGlue/icu/unicode/utypes.h: Removed.
* JavaScriptGlue/icu/unicode/uversion.h: Removed.
* JavaScriptGlue/testjsglue.cpp: Removed.
* Makefile:
* Sources: Added.
* Sources/JavaScriptGlue: Copied from JavaScriptGlue.
* Sources/Makefile: Added.

Tools:

These tools refer to JavaScriptGlue and need to be updated to its new
location.

* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/webkitpy/common/config/build.py:
* Scripts/webkitpy/common/config/build_unittest.py:

Websites/bugs.webkit.org:

PrettyPatch keeps a list of the top-level directories that exist in
trac.

* PrettyPatch/PrettyPatch.rb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-24 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 24 Dec 2010 08:06:49 +0000 (08:06 +0000)]
2010-12-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        [WINCE] Add CPU(MIPS) detection
        https://bugs.webkit.org/show_bug.cgi?id=51342

        WinCE usually defines MIPS and _MIPS_.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Fri, 24 Dec 2010 06:14:39 +0000 (06:14 +0000)]
2010-12-23  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Eric Seidel.

        Bug 51539 - update iexploder scripts to point to new location

        * Scripts/run-iexploder-tests:
        * Scripts/update-iexploder-cssproperties:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake dragging work again after r74591.
mitz@apple.com [Fri, 24 Dec 2010 06:11:19 +0000 (06:11 +0000)]
Make dragging work again after r74591.

Reviewed by Sam Weinig.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Fixed a typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Dec 2010 06:05:13 +0000 (06:05 +0000)]
2010-12-23  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Update GTK's Skipped file.

        [GTK] http/tests/inspector/console-websocket-error.html hangs
        https://bugs.webkit.org/show_bug.cgi?id=51380

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed GTK fix after r74609: put the right file name in the Skipped file.
ariya@webkit.org [Fri, 24 Dec 2010 05:26:28 +0000 (05:26 +0000)]
Unreviewed GTK fix after r74609: put the right file name in the Skipped file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Dec 2010 04:59:58 +0000 (04:59 +0000)]
2010-12-23  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Update Chromium test expectations.

        Mark http/tests/inspector/console-websocket-error.html as SLOW on WIN DEBUG.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-22 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Dec 2010 04:50:00 +0000 (04:50 +0000)]
2010-12-22  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Alexey Proskuryakov.

        [GTK] http/tests/inspector/console-websocket-error.html hangs
        https://bugs.webkit.org/show_bug.cgi?id=51380

        The test should call dumpConsoleMessages() even if WebSocket is not supported
        or a WebSocket object goes to an unexpected state.

        * http/tests/inspector/console-websocket-error.html:
        * platform/gtk/Skipped:
        * platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
        * platform/mac/http/tests/inspector/console-websocket-error-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 24 Dec 2010 04:31:50 +0000 (04:31 +0000)]
2010-12-23  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        ViewportArguments.h uses an enum to intialize a bool
        https://bugs.webkit.org/show_bug.cgi?id=50982

        Initialize userScalable to true, rather than -1.
        No tests; fixes a compiler warning.

        * dom/ViewportArguments.h:
        (WebCore::ViewportArguments::ViewportArguments):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] User name/password stripped from URLs
ariya@webkit.org [Fri, 24 Dec 2010 04:06:26 +0000 (04:06 +0000)]
[Qt] User name/password stripped from URLs
https://bugs.webkit.org/show_bug.cgi?id=36232

Patch by Jan Erik Hanssen <jhanssen@sencha.com> on 2010-12-23
Reviewed by Adam Barth.

WebCore:

If a username but no password or no username but a password is present
in a URL, QtWebKit won't send any authentication information down to Qt
as it should.

Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html
       http/tests/xmlhttprequest/basic-auth-nouser.html

* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

LayoutTests:

Test authentication cases where a username but no password and
no username but a password is present.

* http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* http/tests/xmlhttprequest/basic-auth-nopassword.html: Added.
* http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
* http/tests/xmlhttprequest/basic-auth-nouser.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth-nouserpass/basic-auth-nouserpass.php: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/mac-snowleopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/mac-tiger/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 03:40:54 +0000 (03:40 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt rebaseline for r74593.

        Added the forgotten blank line at the end.

        * platform/qt/editing/pasteboard/copy-in-password-field-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 03:18:27 +0000 (03:18 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt rebaseline for r74593.

        * platform/qt/editing/pasteboard/copy-in-password-field-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:56:45 +0000 (02:56 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        More unreviewed Chromium rebaselines for r74593.

        * platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
        * platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Fri, 24 Dec 2010 02:53:41 +0000 (02:53 +0000)]
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Alexey Proskuryakov.

        [Qt] Composition text is not removed from the editor when composition is cancelled
        https://bugs.webkit.org/show_bug.cgi?id=29391

        Ensure that the composition text is cleared when an empty QInputMethodEvent
        is received and the editor is in composition mode.

        * editing/input/ime-composition-clearpreedit-expected.txt: Added.
        * editing/input/ime-composition-clearpreedit.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Alexey Proskuryakov.

        [Qt] Composition text is not removed from the editor when composition is cancelled
        https://bugs.webkit.org/show_bug.cgi?id=29391

        Ensure that the composition text is cleared when an empty QInputMethodEvent
        is received and the editor is in composition mode.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Benjamin Kalman <kalman@chromium.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:38:21 +0000 (02:38 +0000)]
2010-12-23  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Selection becomes stale when CharacterData is manipulated directly
        https://bugs.webkit.org/show_bug.cgi?id=51389

        Rebaseline GTK tests.

        * platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/gtk/editing/deleting/delete-and-undo-expected.txt:
        * platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/gtk/editing/deleting/delete-br-007-expected.txt:
        * platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
        * platform/gtk/editing/deleting/delete-tab-002-expected.txt:
        * platform/gtk/editing/deleting/delete-tab-004-expected.txt:
        * platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/gtk/editing/deleting/forward-delete-expected.txt:
        * platform/gtk/editing/deleting/smart-delete-003-expected.txt:
        * platform/gtk/editing/deleting/smart-delete-004-expected.txt:
        * platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
        * platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/gtk/editing/inserting/insert-div-003-expected.txt:
        * platform/gtk/editing/inserting/insert-div-024-expected.txt:
        * platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/gtk/editing/inserting/typing-001-expected.txt:
        * platform/gtk/editing/inserting/typing-002-expected.txt:
        * platform/gtk/editing/inserting/typing-003-expected.txt:
        * platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
        * platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
        * platform/gtk/editing/pasteboard/4076267-2-expected.txt:
        * platform/gtk/editing/pasteboard/4076267-3-expected.txt:
        * platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
        * platform/gtk/editing/pasteboard/paste-xml-expected.txt:
        * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * platform/gtk/editing/spelling/spelling-expected.txt:
        * platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
        * platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
        * platform/gtk/editing/style/typing-style-001-expected.txt:
        * platform/gtk/editing/style/typing-style-002-expected.txt:
        * platform/gtk/editing/style/unbold-in-bold-expected.txt:
        * platform/gtk/editing/undo/4063751-expected.txt:
        * platform/gtk/editing/undo/redo-typing-001-expected.txt:
        * platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-combined-delete-expected.txt:
        * platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-delete-expected.txt:
        * platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/gtk/editing/undo/undo-forward-delete-expected.txt:
        * platform/gtk/editing/undo/undo-misspellings-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:33:40 +0000 (02:33 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue("FormatBlock") does not respect editing boundaries
        https://bugs.webkit.org/show_bug.cgi?id=51219

        Added test cases to ensure queryCommandValue("FormatBlock") respects editing boundaries.

        * editing/execCommand/query-format-block-expected.txt:
        * editing/execCommand/script-tests/query-format-block.js:
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue("FormatBlock") does not respect editing boundaries
        https://bugs.webkit.org/show_bug.cgi?id=51219

        Fixed the bug by checking the element we found in elementForFormatBlockCommand
        does not contain the editable root.

        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::elementForFormatBlockCommand):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:17:57 +0000 (02:17 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines for r74593.

        * platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
        * platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
        * platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
        * platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
        * platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
        * platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/chromium-win/editing/deleting/delete-block-table-expected.txt:
        * platform/chromium-win/editing/deleting/delete-br-007-expected.txt:
        * platform/chromium-win/editing/deleting/delete-character-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-hr-expected.txt:
        * platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
        * platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
        * platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/chromium-win/editing/deleting/forward-delete-expected.txt:
        * platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
        * platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
        * platform/chromium-win/editing/deleting/smart-delete-003-expected.txt:
        * platform/chromium-win/editing/deleting/smart-delete-004-expected.txt:
        * platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
        * platform/chromium-win/editing/inserting/4278698-expected.txt:
        * platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
        * platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-009-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
        * platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
        * platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/chromium-win/editing/inserting/insert-tab-003-expected.txt:
        * platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * platform/chromium-win/editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/chromium-win/editing/inserting/typing-001-expected.txt:
        * platform/chromium-win/editing/inserting/typing-002-expected.txt:
        * platform/chromium-win/editing/inserting/typing-003-expected.txt:
        * platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
        * platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
        * platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
        * platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
        * platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
        * platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
        * platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/chromium-win/editing/spelling/spelling-expected.txt:
        * platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
        * platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
        * platform/chromium-win/editing/style/style-boundary-002-expected.txt:
        * platform/chromium-win/editing/style/style-boundary-005-expected.txt:
        * platform/chromium-win/editing/style/typing-style-001-expected.txt:
        * platform/chromium-win/editing/style/typing-style-002-expected.txt:
        * platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
        * platform/chromium-win/editing/undo/4063751-expected.txt:
        * platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
        * platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
        * platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
        * platform/chromium-win/editing/undo/undo-delete-expected.txt:
        * platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
        * platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
        * platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
        * platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
        * platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
        * platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
        * platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 02:14:28 +0000 (02:14 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        FormatBlock doesn't preserve typing style but it should
        https://bugs.webkit.org/show_bug.cgi?id=51140

        Added a test to type text after bolding the typing style and executing a FormatBlock command.
        Because FormatBlock command preserves typing style, the typed text should be in bold.

        * editing/execCommand/format-block-typing-style.html: Added.
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        FormatBlock doesn't preserve typing style but it should
        https://bugs.webkit.org/show_bug.cgi?id=51140

        Fixed the bug by making preserveTypingStyle return true.

        Test: editing/execCommand/format-block-typing-style.html

        * editing/FormatBlockCommand.h:
        (WebCore::FormatBlockCommand::preservesTypingStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename RegexCompiler.cpp to RegexPattern.cpp.
barraclough@apple.com [Fri, 24 Dec 2010 01:40:54 +0000 (01:40 +0000)]
Rename RegexCompiler.cpp to RegexPattern.cpp.
Implicitly call compileRegex from RegexPattern's constructor.

Reviewed by Sam Weinig.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
* yarr/RegexCompiler.cpp: Removed.
* yarr/RegexCompiler.h: Removed.
* yarr/RegexInterpreter.cpp:
* yarr/RegexJIT.cpp:
* yarr/RegexPattern.cpp: Copied from JavaScriptCore/yarr/RegexCompiler.cpp.
(JSC::Yarr::compileRegex):
(JSC::Yarr::RegexPattern::RegexPattern):
* yarr/RegexPattern.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 01:36:39 +0000 (01:36 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt rebaselines for r74593.

        * platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
        * platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
        * platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
        * platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/qt/editing/deleting/delete-character-001-expected.txt:
        * platform/qt/editing/deleting/delete-hr-expected.txt:
        * platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/qt/editing/deleting/delete-selection-001-expected.txt:
        * platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
        * platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/qt/editing/deleting/non-smart-delete-expected.txt:
        * platform/qt/editing/deleting/smart-delete-001-expected.txt:
        * platform/qt/editing/deleting/smart-delete-003-expected.txt:
        * platform/qt/editing/deleting/smart-delete-004-expected.txt:
        * platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/qt/editing/inserting/insert-br-003-expected.txt:
        * platform/qt/editing/inserting/insert-br-006-expected.txt:
        * platform/qt/editing/inserting/insert-br-007-expected.txt:
        * platform/qt/editing/inserting/insert-br-008-expected.txt:
        * platform/qt/editing/inserting/insert-br-009-expected.txt:
        * platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * platform/qt/editing/inserting/insert-div-003-expected.txt:
        * platform/qt/editing/inserting/insert-div-006-expected.txt:
        * platform/qt/editing/inserting/insert-div-008-expected.txt:
        * platform/qt/editing/inserting/insert-div-024-expected.txt:
        * platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * platform/qt/editing/inserting/typing-001-expected.txt:
        * platform/qt/editing/inserting/typing-002-expected.txt:
        * platform/qt/editing/inserting/typing-003-expected.txt:
        * platform/qt/editing/inserting/typing-around-br-001-expected.txt:
        * platform/qt/editing/inserting/typing-around-image-001-expected.txt:
        * platform/qt/editing/pasteboard/4076267-3-expected.txt:
        * platform/qt/editing/pasteboard/cut-text-001-expected.txt:
        * platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-1-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-2-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-4-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-list-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-table-expected.txt:
        * platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-019-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/qt/editing/pasteboard/pasting-object-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt:
        * platform/qt/editing/undo/redo-style-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Evan Martin <evan@chromium.org>
evan@chromium.org [Fri, 24 Dec 2010 01:19:00 +0000 (01:19 +0000)]
2010-12-23  Evan Martin  <evan@chromium.org>

        Reviewed by Ryosuke Niwa.

        [chromium] LayoutTestController warning in float->int conversion
        https://bugs.webkit.org/show_bug.cgi?id=51553

        Rather than reading an int, converting to a float, then getting a compiler
        warning on passing the float to something that expects an int, instead
        just pass around ints.

        No tests, fixes a compiler warning.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (parsePageSizeParameters):
        (LayoutTestController::pageNumberForElementById):
        (LayoutTestController::numberOfPages):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNeed WebKit2 API to create a SecurityOrigin from protocol, host, and port
jberlin@webkit.org [Fri, 24 Dec 2010 01:16:19 +0000 (01:16 +0000)]
Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
https://bugs.webkit.org/show_bug.cgi?id=51563

Reviewed by Sam Weinig.

WebCore:

Add SecurityOrigin::create(const String& protocol, const String& host, int port).

* WebCore.exp.in:
Export the symbols for WebCore::SecurityOrigin::create(String, String, int).

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
Use the constant MaxAllowedPort.
(WebCore::SecurityOrigin::create):
Sanitizing based off of that done in createFromDatabaseIdentifier.
* page/SecurityOrigin.h:

WebKit2:

Add WKSecurityOriginCreate(WKStringRef protocol, WKStringRef host, int port).

* Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCreateFromIdentifier):
Renamed so as not to clash with the new WKSecurityOriginCreate.
(WKSecurityOriginCreate):
* Shared/API/c/WKSecurityOrigin.h:
* Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 24 Dec 2010 01:11:04 +0000 (01:11 +0000)]
2010-12-23  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for WinCE after r73802.

        Reapply r70812:
        Port ContextMenuItemWin.cpp to WinCE
        https://bugs.webkit.org/show_bug.cgi?id=48407

        * platform/win/ContextMenuItemWin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 24 Dec 2010 01:03:23 +0000 (01:03 +0000)]
2010-12-23  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for WinCE after r74360.

        Move the OS(WINDOWS) section after the OS(WINCE) section
        and add missing argument to the getStackMax call.

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 24 Dec 2010 00:55:48 +0000 (00:55 +0000)]
2010-12-23  Adam Barth  <abarth@webkit.org>

        Remove include of non-existant file.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Dec 2010 00:22:00 +0000 (00:22 +0000)]
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Selection becomes stale when CharacterData is manipulated directly
        https://bugs.webkit.org/show_bug.cgi?id=51389

        The bug was caused by SelectionController's not adjusting selection when CharacterData's
        m_data is modified by its API.

        Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
        CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
        textWillBeReplaced because inserting, replacing, or removing data may require moving
        the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).

        Also fixed the condition for determining whether or not a node intersects the selection
        in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
        failed to recognize certain cases when selection started and ended with non-zero offsets.

        Tests: editing/selection/character-data-mutation-crash.html
               editing/selection/character-data-mutation.html

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate.
        (WebCore::CharacterData::appendData): Ditto.
        (WebCore::CharacterData::insertData): Ditto.
        (WebCore::CharacterData::deleteData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.
        (WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list,
        and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
        * dom/CharacterData.h:
        * editing/SelectionController.cpp:
        (WebCore::removingNodeRemovesPosition): Removed indentations from blank lines.
        (WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved.
        (WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved;
        fixed the logic to figure out whether a node is inside the range or not.
        (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added.
        (WebCore::SelectionController::textWillBeReplaced): Added.
        * editing/SelectionController.h:
2010-12-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Selection becomes stale when CharacterData is manipulated directly
        https://bugs.webkit.org/show_bug.cgi?id=51389

        Added tests to ensure WebKit adjusts or clears selection when the start container
        or the end container of the selection's first range is modified by CharacterData's API.

        Many editing tests had to be rebaselined due to different editing delegate dumps
        caused by WebKit's properly adjusting selection's offsets as editing commands modify the DOM.

        * editing/deleting/delete-by-word-001-expected.txt:
        * editing/deleting/delete-by-word-002-expected.txt:
        * editing/deleting/delete-ligature-001-expected.txt:
        * editing/deleting/delete-ligature-002-expected.txt:
        * editing/deleting/delete-ligature-003-expected.txt:
        * editing/deleting/skip-virama-001-expected.txt:
        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/hilitecolor-expected.txt:
        * editing/execCommand/unlink-expected.txt:
        * editing/inserting/insert-thai-characters-001-expected.txt:
        * editing/pasteboard/copy-in-password-field-expected.txt:
        * editing/pasteboard/paste-into-anchor-text-expected.txt:
        * editing/selection/character-data-mutation-crash-expected.txt: Added.
        * editing/selection/character-data-mutation-crash.html: Added.
        * editing/selection/character-data-mutation-expected.txt: Added.
        * editing/selection/character-data-mutation.html: Added.
        * editing/style/remove-underline-from-stylesheet-expected.txt:
        * editing/style/typing-style-003-expected.txt:
        * editing/undo/redo-style-expected.txt:
        * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
        * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
        * platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
        * platform/mac/editing/deleting/delete-and-undo-expected.txt:
        * platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
        * platform/mac/editing/deleting/delete-block-table-expected.txt:
        * platform/mac/editing/deleting/delete-br-007-expected.txt:
        * platform/mac/editing/deleting/delete-character-001-expected.txt:
        * platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-hr-expected.txt:
        * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-listitem-001-expected.txt:
        * platform/mac/editing/deleting/delete-selection-001-expected.txt:
        * platform/mac/editing/deleting/delete-tab-001-expected.txt:
        * platform/mac/editing/deleting/delete-tab-002-expected.txt:
        * platform/mac/editing/deleting/delete-tab-003-expected.txt:
        * platform/mac/editing/deleting/delete-tab-004-expected.txt:
        * platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
        * platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
        * platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
        * platform/mac/editing/deleting/forward-delete-expected.txt:
        * platform/mac/editing/deleting/non-smart-delete-expected.txt:
        * platform/mac/editing/deleting/smart-delete-001-expected.txt:
        * platform/mac/editing/deleting/smart-delete-002-expected.txt:
        * platform/mac/editing/deleting/smart-delete-003-expected.txt:
        * platform/mac/editing/deleting/smart-delete-004-expected.txt:
        * platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
        * platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
        * platform/mac/editing/input/text-input-controller-expected.txt:
        * platform/mac/editing/inserting/4278698-expected.txt:
        * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
        * platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
        * platform/mac/editing/inserting/insert-br-003-expected.txt:
        * platform/mac/editing/inserting/insert-br-006-expected.txt:
        * platform/mac/editing/inserting/insert-br-007-expected.txt:
        * platform/mac/editing/inserting/insert-br-008-expected.txt:
        * platform/mac/editing/inserting/insert-br-009-expected.txt:
        * platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * platform/mac/editing/inserting/insert-div-003-expected.txt:
        * platform/mac/editing/inserting/insert-div-006-expected.txt:
        * platform/mac/editing/inserting/insert-div-008-expected.txt:
        * platform/mac/editing/inserting/insert-div-024-expected.txt:
        * platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
        * platform/mac/editing/inserting/insert-tab-003-expected.txt:
        * platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
        * platform/mac/editing/inserting/typing-001-expected.txt:
        * platform/mac/editing/inserting/typing-002-expected.txt:
        * platform/mac/editing/inserting/typing-003-expected.txt:
        * platform/mac/editing/inserting/typing-around-br-001-expected.txt:
        * platform/mac/editing/inserting/typing-around-image-001-expected.txt:
        * platform/mac/editing/pasteboard/4076267-2-expected.txt:
        * platform/mac/editing/pasteboard/4076267-3-expected.txt:
        * platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
        * platform/mac/editing/pasteboard/cut-text-001-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
        * platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-1-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-2-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-4-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-list-expected.txt:
        * platform/mac/editing/pasteboard/merge-end-table-expected.txt:
        * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-019-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/mac/editing/pasteboard/paste-xml-expected.txt:
        * platform/mac/editing/pasteboard/pasting-object-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
        * platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * platform/mac/editing/spelling/spelling-expected.txt:
        * platform/mac/editing/style/style-3681552-fix-001-expected.txt:
        * platform/mac/editing/style/style-3681552-fix-002-expected.txt:
        * platform/mac/editing/style/style-boundary-002-expected.txt:
        * platform/mac/editing/style/style-boundary-005-expected.txt:
        * platform/mac/editing/style/typing-style-001-expected.txt:
        * platform/mac/editing/style/typing-style-002-expected.txt:
        * platform/mac/editing/style/unbold-in-bold-expected.txt:
        * platform/mac/editing/undo/4063751-expected.txt:
        * platform/mac/editing/undo/redo-typing-001-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-combined-delete-expected.txt:
        * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-delete-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
        * platform/mac/editing/undo/undo-forward-delete-expected.txt:
        * platform/mac/editing/undo/undo-misspellings-expected.txt:
        * platform/mac/editing/undo/undo-typing-001-expected.txt:
        * platform/mac/editing/unsupported-content/list-type-after-expected.txt:
        * platform/mac/editing/unsupported-content/list-type-before-expected.txt:
        * platform/mac/editing/unsupported-content/table-type-after-expected.txt:
        * platform/mac/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 24 Dec 2010 00:00:38 +0000 (00:00 +0000)]
2010-12-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove unneeded V8 bindings files
        https://bugs.webkit.org/show_bug.cgi?id=51570

        * WebCore.gypi:
        * bindings/generic/BindingDOMWindow.h: Removed.
        * bindings/v8/specialization/V8BindingDOMWindow.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 23:55:41 +0000 (23:55 +0000)]
2010-12-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Ensure that we are not getting too many mouse move events
        https://bugs.webkit.org/show_bug.cgi?id=51568
        <rdar://problem/7881470>
        <rdar://problem/8735512>

        Implement throttling of mouse move events.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize m_processingMouseMoveEvent to false.

        (WebKit::WebPageProxy::handleMouseEvent):
        If we're already processing a mouse move events, just update
        m_nextMouseMoveEvent and return.

        (WebKit::WebPageProxy::didReceiveEvent):
        If we received a mouse move event, send the next mouse move event if there is one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mitz@apple.com [Thu, 23 Dec 2010 23:43:15 +0000 (23:43 +0000)]
Build fix.

* editing/EditorCommand.cpp:
(WebCore::enabledDismissCorrectionPanel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix crash seen on GTK bot.
darin@apple.com [Thu, 23 Dec 2010 23:42:11 +0000 (23:42 +0000)]
Try to fix crash seen on GTK bot.

* editing/EditorCommand.cpp:
(WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.

* WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion when loading www.yahoo.com in WebKit2 under decodeResourceRequest
bweinstein@apple.com [Thu, 23 Dec 2010 23:36:16 +0000 (23:36 +0000)]
Assertion when loading yahoo.com in WebKit2 under decodeResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=51562

Reviewed by Anders Carlsson.

Don't assert that our data reference isn't empty when we try to get the data from it.
If it is empty, just return 0.

All callers are safe with this function returning 0.

* Platform/CoreIPC/DataReference.h:
(CoreIPC::DataReference::data): Change the assert to an early return.
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode): Add an assert, and remove a ternarny operator because the function now does
    this for us (if the data is empty, return 0).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Sheriff Bot <webkit.review.bot@gmail.com>
kbr@google.com [Thu, 23 Dec 2010 23:15:32 +0000 (23:15 +0000)]
2010-12-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74561.
        http://trac.webkit.org/changeset/74561
        https://bugs.webkit.org/show_bug.cgi?id=51565

        "Broke Chromium UI tests on Vista" (Requested by kbr_google on
        #webkit).

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
2010-12-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74561.
        http://trac.webkit.org/changeset/74561
        https://bugs.webkit.org/show_bug.cgi?id=51565

        "Broke Chromium UI tests on Vista" (Requested by kbr_google on
        #webkit).

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 23:10:45 +0000 (23:10 +0000)]
2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Darin Adler.

        WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
        https://bugs.webkit.org/show_bug.cgi?id=38535

        WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
        if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
        WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
        call frame from this stack when an exception throws because the saved top frame could be invalid.

        To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
        callEvent and returnEvent.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::willExecuteProgram):
        (WebScriptDebugger::didExecuteProgram):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 23 Dec 2010 23:08:37 +0000 (23:08 +0000)]
2010-12-23  Kenneth Russell  <kbr@google.com>

        Unreviewed Chromium test expectations update. Fix botched update
        of fast/css/box-shadow.html expectation; needed to be FAIL, not
        IMAGE+TEXT IMAGE.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix incorrect assertion causing all pages with subframes to crash.
weinig@apple.com [Thu, 23 Dec 2010 22:49:10 +0000 (22:49 +0000)]
Fix incorrect assertion causing all pages with subframes to crash.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::appendChild):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed out-of-order ChangeLog.
darin@apple.com [Thu, 23 Dec 2010 22:40:19 +0000 (22:40 +0000)]
Fixed out-of-order ChangeLog.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Darin Adler <darin@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 22:34:52 +0000 (22:34 +0000)]
2010-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WKView should not try to do asynchronous validation for selectors that are not editor commands
        https://bugs.webkit.org/show_bug.cgi?id=51555

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking.
        Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation
        for commands that are supported. Tweaked comments and added some bug numbers.
        (-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added
        bug number.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 23 Dec 2010 22:23:58 +0000 (22:23 +0000)]
2010-12-23  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
        https://bugs.webkit.org/show_bug.cgi?id=51507

        Adds WebThemeEngine for the Mac (it already has parallel definitions for
        Windows and Linux) so that scrollbar thumb rendering can be overridden
        for the DRT (to be consistent with the NSScroller-based rendering
        used by the Mac port).

        No new tests since the functionality is not exposed yet. Eventually will
        result in the Chromium/Mac port being able to use the same pixel
        baselines for layout tests as the Mac port.

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
2010-12-23  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
        https://bugs.webkit.org/show_bug.cgi?id=51507

        Adds WebThemeEngine for the Mac (it already has parallel definitions for
        Windows and Linux) so that scrollbar thumb rendering can be overridden
        for the DRT (to be consistent with the NSScroller-based rendering
        used by the Mac port).

        * public/mac/WebThemeEngine.h: Added.
        (WebKit::WebThemeEngine::paintScrollbarThumb):
        * src/AssertMatchingEnums.cpp:
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::paintScrollbarThumb):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Dec 2010 22:20:43 +0000 (22:20 +0000)]
2010-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WKView should not try to do asynchronous validation for selectors that are not editor commands
        https://bugs.webkit.org/show_bug.cgi?id=51555

        * WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
        * editing/Editor.h: Reordered arguments in the Editor::Command constructor
        and the data members too so the frame is last. Added
        commandIsSupportedFromMenuOrKeyBinding.

        * editing/EditorCommand.cpp:
        (WebCore::supported): Removed the EditorCommandSource argument. These
        functions are now only used when called from DOM.
        (WebCore::supportedFromMenuOrKeyBinding): Ditto.
        (WebCore::supportedCopyCut): Ditto.
        (WebCore::supportedPaste): Ditto.
        (WebCore::enabledDismissCorrectionPanel): Changed the supported function to
        an enabled function. It was incorrect to say that this is "supported" only
        when the correction panel is up. Correct to say that it is "enabled" only
        then. And also probably OK to enable it even when the selection is not in
        editable text, as long as the panel is up.
        (WebCore::createCommandMap): Moved conditional commands out of the main
        array into a separate section at the end.
        (WebCore::internalCommand): Added.
        (WebCore::Editor::command): Changed to use the new internalCommand function
        and simplified by relying on the null check in the Command constructor.
        (WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added.
        (WebCore::Editor::Command::Command): Removed unneeded initialization of
        m_source, which is never looked at if m_command is 0. Added feature of
        passing a null command pointer to the non-default constructor.
        (WebCore::Editor::Command::isSupported): Changed to only call the
        per-command isSupported function when the command source is DOM.
        Accordingly that function is now called isSupportedFromDOM.
2010-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WKView should not try to do asynchronous validation for selectors that are not editor commands
        https://bugs.webkit.org/show_bug.cgi?id=51555

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking.
        Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation
        for commands that are supported. Tweaked comments and added some bug numbers.
        (-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added
        bug number.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 23 Dec 2010 22:15:12 +0000 (22:15 +0000)]
2010-12-23  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
        https://bugs.webkit.org/show_bug.cgi?id=51560

        No new tests.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setAcceleratesDrawing):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Chromium layout test expectations update.
ajwong@chromium.org [Thu, 23 Dec 2010 21:28:25 +0000 (21:28 +0000)]
Unreviewed. Chromium layout test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=51500

Rebaseline media control layout tests due to pixel diff from r74535

* platform/chromium-linux/media/audio-controls-rendering-expected.checksum:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.checksum:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.checksum:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.checksum:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.checksum:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.checksum:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.checksum:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.checksum:
* platform/chromium-linux/media/video-empty-source-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.checksum:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.checksum:
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/controls-after-reload-expected.checksum:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-strict-expected.checksum:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-strict-expected.txt:
* platform/chromium-mac/media/controls-styling-expected.checksum:
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.checksum:
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.txt:
* platform/chromium-mac/media/video-display-toggle-expected.checksum:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.checksum:
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.checksum:
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.checksum:
* platform/chromium-mac/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.checksum:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.checksum:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.checksum:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.checksum:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.checksum:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.checksum:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.checksum:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.checksum:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.checksum:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.checksum:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 21:08:12 +0000 (21:08 +0000)]
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
        https://bugs.webkit.org/show_bug.cgi?id=35635

        Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
        tag informing the OS that the data is in UTF-8 format.

        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeSelection):
2010-12-23  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
        https://bugs.webkit.org/show_bug.cgi?id=35635

        Test that QClipboard contains the charset information and unicode data
        after copying unicode text.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::macCopyUnicodeToClipboard):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74577 268f45cc-cd09-0410-ab3c-d52691b4dbfc