WebKit.git
10 years ago2011-01-21 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 22 Jan 2011 04:57:16 +0000 (04:57 +0000)]
2011-01-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Geoffrey Garen.

        Humor the WebKit2 buildbot in its continuing hatred of forms tests
        https://bugs.webkit.org/show_bug.cgi?id=52944

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated the results after r76414 fixed text justification in this test.
mitz@apple.com [Sat, 22 Jan 2011 04:30:47 +0000 (04:30 +0000)]
Updated the results after r76414 fixed text justification in this test.

Rubber-stamped by Mark Rowe.

* platform/mac/fast/text/justified-text-rect-expected.checksum:
* platform/mac/fast/text/justified-text-rect-expected.png:
* platform/mac/fast/text/justified-text-rect-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 22 Jan 2011 04:27:18 +0000 (04:27 +0000)]
2011-01-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Maciej Stachowiak.

        Cleaned up some conservative marking code.
        https://bugs.webkit.org/show_bug.cgi?id=52946

        SunSpider reports no change.

        * interpreter/RegisterFile.h: No need for a special marking function,
        since we already expose a start() and end().

        * runtime/Heap.cpp:
        (JSC::Heap::registerFile):
        (JSC::Heap::markRoots):
        * runtime/Heap.h:
        (JSC::Heap::contains): Migrated markConservatively() to the machine stack
        marker class. Now, Heap just provides a contains() function, which the
        machine stack marker uses for checking whether a pointer points into the heap.

        * runtime/MachineStackMarker.cpp:
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        (JSC::isPointerAligned):
        (JSC::MachineStackMarker::markConservatively):
        * runtime/MachineStackMarker.h: Move the conservative marking code here.

        * runtime/MarkStack.h:
        (JSC::ConservativeSet::add):
        (JSC::ConservativeSet::mark): Changed to using a vector instead of hash
        set. Vector seems to be a bit faster, and it generates smaller code.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::containsSlowCase):
        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::isCellAligned):
        (JSC::MarkedSpace::isPossibleCell):
        (JSC::MarkedSpace::contains): Kept the code for determining whether a
        pointer pointed into marked space, and moved the code for marking
        a set of conservative pointers into the machine stack marker.

        * wtf/HashSet.h:
        (WTF::::add): Added two missing inlines that I noticed while testing
        vector vs hash set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 22 Jan 2011 04:00:52 +0000 (04:00 +0000)]
2011-01-21  James Robinson  <jamesr@chromium.org>

        Update chromium test expectations. fast/animation tests should now pass on all chromium configurations.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Sat, 22 Jan 2011 03:31:45 +0000 (03:31 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix test failure.
mitz@apple.com [Sat, 22 Jan 2011 03:22:52 +0000 (03:22 +0000)]
Fix test failure.

* fast/text/justify-nbsp.html: Removed a contenteditable attribute
that was added after generating results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 22 Jan 2011 02:51:15 +0000 (02:51 +0000)]
2011-01-21  Andreas Kling  <kling@webkit.org>

        Unreviewed, removing the Qt result for r76414 since the test
        was actually broken beyond the usual off-by-one metrics.

        * platform/qt/fast/text/justify-nbsp-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 22 Jan 2011 02:11:36 +0000 (02:11 +0000)]
2011-01-21  Andreas Kling  <kling@webkit.org>

        Unreviewed, add Qt-specific result for test added in r76414.

        * platform/qt/fast/text/justify-nbsp-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Sat, 22 Jan 2011 02:08:37 +0000 (02:08 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=52943
        Objective-C files should use #import, not #include

        * UIProcess/API/C/WebKit2.h: This is an interesting one, because it's cross-platform, and
        there is more than one WKView.h.

        * Platform/mac/ModuleMac.mm:
        * Platform/mac/RunLoopMac.mm:
        * PluginProcess/mac/PluginControllerProxyMac.mm:
        * PluginProcess/mac/PluginProcessMac.mm:
        * PluginProcess/mac/PluginProcessMainMac.mm:
        * Shared/API/c/mac/WKCertificateInfoMac.mm:
        * Shared/API/c/mac/WKURLRequestNS.mm:
        * Shared/API/c/mac/WKURLResponseNS.mm:
        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        * Shared/mac/PlatformCertificateInfo.mm:
        * Shared/mac/SandboxExtensionMac.mm:
        * Shared/mac/WebCoreArgumentCodersMac.mm:
        * Shared/mac/WebMemorySampler.mac.mm:
        * Shared/mac/WebURLRequestMac.mm:
        * Shared/mac/WebURLResponseMac.mm:
        * UIProcess/API/mac/FindIndicatorWindow.mm:
        * UIProcess/API/mac/WKTextInputWindowController.mm:
        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
        * UIProcess/Launcher/mac/ThreadLauncherMac.mm:
        * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
        * UIProcess/mac/BackingStoreMac.mm:
        * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
        * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
        * UIProcess/mac/TextCheckerMac.mm:
        * UIProcess/mac/WebContextMac.mm:
        * UIProcess/mac/WebContextMenuProxyMac.mm:
        * UIProcess/mac/WebPageProxyMac.mm:
        * UIProcess/mac/WebPopupMenuProxyMac.mm:
        * UIProcess/mac/WebPreferencesMac.mm:
        * WebProcess/Downloads/mac/DownloadMac.mm:
        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
        * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
        * WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm:
        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
        * WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        * WebProcess/WebPage/mac/WebPageMac.mm:
        * WebProcess/mac/WebProcessMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the WebKit2 build with clang.
mrowe@apple.com [Sat, 22 Jan 2011 01:46:39 +0000 (01:46 +0000)]
Fix the WebKit2 build with clang.

Reviewed by Sam Weinig.

* Scripts/webkit2/messages.py: Add some more structs to the list.
* UIProcess/DrawingAreaProxy.h: Forward-declare UpdateInfo as a class.
* UIProcess/TextChecker.h: Forward-declare TextCheckerState as a struct.
* UIProcess/WebPageProxy.h: Forward-declare ContextMenuState as a struct.
* UIProcess/mac/TextCheckerMac.mm: Fix the type of the string constants so that they can be passed to
functions expecting NSString* without generating warnings.
* WebProcess/WebPage/DrawingArea.h: Forward-declare WebPageCreationParameters as a struct.
* WebProcess/WebPage/DrawingAreaImpl.h: Forward-declare UpdateInfo as a class.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getResourceDataFromFrame): Add parens around the assignment in the condition of
the if statement to suppress a warning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build when using Clang by removing some unused variables.
mrowe@apple.com [Sat, 22 Jan 2011 01:46:14 +0000 (01:46 +0000)]
Fix the build when using Clang by removing some unused variables.

Rubber-stamped by Jon Honeycutt.

* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView updateAndSetWindow]):
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 22 Jan 2011 01:45:14 +0000 (01:45 +0000)]
2011-01-21  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Always set composition mode through GraphicsContext
        https://bugs.webkit.org/show_bug.cgi?id=52940

        GraphicsContext tracks the current composition mode so we should
        never call through to the QPainter directly.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::toQtCompositionMode): Changed this method to a static inline
        since it's only used by GraphicsContextQt.cpp now.

        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        (WebCore::BitmapImage::draw):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInconsistent handling of no-break space in justification logic
mitz@apple.com [Sat, 22 Jan 2011 01:31:05 +0000 (01:31 +0000)]
Inconsistent handling of no-break space in justification logic
https://bugs.webkit.org/show_bug.cgi?id=52938

Reviewed by Adele Peterson.

Source/WebCore:

Test: fast/text/justify-nbsp.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
space when computing the distribution of space between text boxes on the line.

LayoutTests:

* fast/text/justify-nbsp-expected.checksum: Added.
* fast/text/justify-nbsp-expected.png: Added.
* fast/text/justify-nbsp-expected.txt: Added.
* fast/text/justify-nbsp.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 22 Jan 2011 01:29:59 +0000 (01:29 +0000)]
2011-01-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Fix bug introduced in r76322 that caused NRWT to not actually
        read the Skipped files properly.

        https://bugs.webkit.org/show_bug.cgi?id=52771

        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Chris Rogers <crogers@google.com>
crogers@google.com [Sat, 22 Jan 2011 01:19:27 +0000 (01:19 +0000)]
2011-01-21  Chris Rogers  <crogers@google.com>

        Unreviewed

        define HAS_WEBAUDIO_RUNTIMEFEATURES for synchronization with chromium patch landing
        https://bugs.webkit.org/show_bug.cgi?id=52941

        * public/WebRuntimeFeatures.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Chris Rogers <crogers@google.com>
crogers@google.com [Sat, 22 Jan 2011 01:07:55 +0000 (01:07 +0000)]
2011-01-21  Chris Rogers  <crogers@google.com>

        Unreviewed

        Add HAS_WEBAUDIO_FEATURE_ENABLE define to synchronize with chromium-side patch
        https://bugs.webkit.org/show_bug.cgi?id=52939

        * public/WebSettings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Kenji Imasaki <imasaki@chromium.org>
commit-queue@webkit.org [Sat, 22 Jan 2011 00:54:24 +0000 (00:54 +0000)]
2011-01-21  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by David Levin.

        Remove resolved BUG13907 from test expectation file and added
        newly filed BUGCR70252 for media/video-zoom.html to keep track
        of the issue.

        Also, remove non-flaky test (media/audio-only-video-intrinsic-size.htm).

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWork around a Clang bug <rdar://problem/8876150> that leads to it incorrectly emittin...
mrowe@apple.com [Sat, 22 Jan 2011 00:38:11 +0000 (00:38 +0000)]
Work around a Clang bug <rdar://problem/8876150> that leads to it incorrectly emitting an access
control warning when a client tries to use operator bool exposed above via "using PageBlock::operator bool".

Reviewed by Sam Weinig.

* wtf/PageAllocation.h:
(WTF::PageAllocation::operator bool):
* wtf/PageReservation.h:
(WTF::PageReservation::operator bool):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 22 Jan 2011 00:16:34 +0000 (00:16 +0000)]
2011-01-21  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline tests that use menulists. Also unskip a non-existent test.

        * platform/gtk/Skipped: Remove non-existent test.
        * platform/gtk/editing/selection/select-box-expected.checksum:
        * platform/gtk/editing/selection/select-box-expected.png:
        * platform/gtk/editing/selection/select-box-expected.txt:
        * platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
        * platform/gtk/transforms/2d/zoom-menulist-expected.png:
        * platform/gtk/transforms/2d/zoom-menulist-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 21 Jan 2011 23:52:29 +0000 (23:52 +0000)]
2011-01-21  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        [RegexFuzz] Hang with forward assertion
        https://bugs.webkit.org/show_bug.cgi?id=52825
        <rdar://problem/8894332>

        The backtrackTo label from the first term in a list of terms is
        being overwritten by processing of subsequent terms.  Changed
        copyBacktrackToLabel() to check for an existing bcaktrackTo label
        before copying and renamed it to propagateBacktrackToLabel() since
        it no longer copies.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::BacktrackDestination::propagateBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
2011-01-21  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        [RegexFuzz] Hang with forward assertion
        https://bugs.webkit.org/show_bug.cgi?id=52825
        <rdar://problem/8894332>

        New tests to check for functionality and future regression.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Charlie Reis <creis@chromium.org>
commit-queue@webkit.org [Fri, 21 Jan 2011 23:47:01 +0000 (23:47 +0000)]
2011-01-21  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        Crash in WebCore::HistoryController::itemsAreClones
        https://bugs.webkit.org/show_bug.cgi?id=52819

        Adds sanity checks to help diagnose the crash.

        * loader/HistoryController.cpp:
2011-01-21  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        Crash in WebCore::HistoryController::itemsAreClones
        https://bugs.webkit.org/show_bug.cgi?id=52819

        Adds sanity checks to help diagnose the crash.

        * src/WebFrameImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 21 Jan 2011 23:45:26 +0000 (23:45 +0000)]
2011-01-21  Andreas Kling  <kling@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] Let QPainter decide whether a composition mode is supported or not

        Lacking Porter-Duff support in the paint engine shouldn't exclude the
        Source and Source-Over modes (and has nothing to do with the blend
        and raster-op modes.)

        Delegate this decision to QPainter instead (this will cause warnings
        if an unsupported mode is used, but that's a good thing.)

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clearRect):
        (WebCore::GraphicsContext::setPlatformCompositeOperation):
        * platform/graphics/qt/TransparencyLayer.h:
        (WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 21 Jan 2011 23:43:02 +0000 (23:43 +0000)]
2011-01-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adele Peterson.

        Skip a test that's sporadically crashing on the buildbots
        https://bugs.webkit.org/show_bug.cgi?id=52932

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Need API to stop loading a WKFrame
bweinstein@apple.com [Fri, 21 Jan 2011 23:42:00 +0000 (23:42 +0000)]
WebKit2: Need API to stop loading a WKFrame
https://bugs.webkit.org/show_bug.cgi?id=52925

Reviewed by Adam Roben.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameStopLoading): Call through to WebFrameProxy::stopLoading.
* UIProcess/API/C/WKFrame.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::stopLoading): Send a message to the WebProcess to stop loading the frame
    with the passed in ID.
* UIProcess/WebFrameProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::stopLoadingFrame): Call stopForUserCancel on the passed-in frame.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add StopLoadingFrame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 21 Jan 2011 23:41:07 +0000 (23:41 +0000)]
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        fix audio build: header file should be "Noncopyable.h" and not "NonCopyable.h"
        https://bugs.webkit.org/show_bug.cgi?id=52933

        No new tests since this just fixes the build

        * webaudio/RealtimeAnalyser.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner needs the HOME environment variable to be set.
weinig@apple.com [Fri, 21 Jan 2011 23:32:33 +0000 (23:32 +0000)]
WebKitTestRunner needs the HOME environment variable to be set.
<rdar://problem/8896573>

Reviewed by Geoffrey Sean Garen and Mark Rowe.

* Scripts/old-run-webkit-tests: Set the HOME environment variable if
it exists.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 21 Jan 2011 23:28:06 +0000 (23:28 +0000)]
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Fix audio build: change ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52928

        No new tests since audio API is not yet implemented.

        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::AudioBus::loadPlatformResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 21 Jan 2011 23:24:07 +0000 (23:24 +0000)]
2011-01-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Moved the mark stack from global data to the heap, since it pertains
        to the heap, and not the virtual machine as a whole.
        https://bugs.webkit.org/show_bug.cgi?id=52930

        SunSpider reports no change.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::markRoots):
        * runtime/Heap.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 21 Jan 2011 23:23:49 +0000 (23:23 +0000)]
2011-01-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Suppress a few remaining integration tests so that none of the
        layout_test unit tests ever read from the filesystem or launch
        subprocesses that aren't part of the unit tests.

        Also fix a minor bug in the printing unit tests that was
        incorrectly relying on sys.argv.

        https://bugs.webkit.org/show_bug.cgi?id=52863

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 21 Jan 2011 23:06:52 +0000 (23:06 +0000)]
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add FFTFrameStub to avoid link errors during bringup on platforms without an FFT implementation
        https://bugs.webkit.org/show_bug.cgi?id=52922

        No new tests since audio API is not yet implemented.

        * WebCore.gypi:
        * platform/audio/FFTFrameStub.cpp: Added.
        (WebCore::FFTFrame::FFTFrame):
        (WebCore::FFTFrame::~FFTFrame):
        (WebCore::FFTFrame::multiply):
        (WebCore::FFTFrame::doFFT):
        (WebCore::FFTFrame::doInverseFFT):
        (WebCore::FFTFrame::cleanup):
        (WebCore::FFTFrame::realData):
        (WebCore::FFTFrame::imagData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 21 Jan 2011 22:52:09 +0000 (22:52 +0000)]
2011-01-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Skip some newly added tests that use DRT APIs that are not yet available for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=52924

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 Jan 2011 22:32:15 +0000 (22:32 +0000)]
2011-01-21  Tony Chang  <tony@chromium.org>

        Reviewed by Sam Weinig.

        reduce number of FrameLoaderClient::didChangeScrollOffset calls
        https://bugs.webkit.org/show_bug.cgi?id=52915

        Only notify of changes in scroll offset when there actually is a change.
        This regressed in r76291.

        Covered by Chromium browser_tests.

        * platform/ScrollAnimator.cpp:
        (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8894125> and https://bugs.webkit.org/show_bug.cgi?id=52916
beidson@apple.com [Fri, 21 Jan 2011 22:12:17 +0000 (22:12 +0000)]
<rdar://problem/8894125> and https://bugs.webkit.org/show_bug.cgi?id=52916
Expose "suggested filename" for a resource based on its resource response.

Reviewed by Adam Roben.

API pieces:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopySuggestedFilenameForResourceURL):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Implementation:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::suggestedFilenameForResourceURL): See if the DocumentLoader has
  a resource for this URL and, if so, return the response's suggested filename.
* WebProcess/WebPage/WebFrame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 21 Jan 2011 22:09:19 +0000 (22:09 +0000)]
2011-01-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        DrawingAreaProxyImpl::paint should return the unpainted region
        https://bugs.webkit.org/show_bug.cgi?id=52918

        * UIProcess/API/mac/WKView.mm:
        (-[WKView drawRect:]):
        Add unpaintedRegion parameter.

        * UIProcess/BackingStore.h:
        (WebKit::BackingStore::size):
        Add a size getter.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::paint):
        Initialize the unpainted region to the dirty region, then subtract the painted region.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 21 Jan 2011 22:00:52 +0000 (22:00 +0000)]
2011-01-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: ~InspectorResourceAgent crashes on closing inspected page.
        https://bugs.webkit.org/show_bug.cgi?id=52900

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/8896057>
andersca@apple.com [Fri, 21 Jan 2011 21:58:11 +0000 (21:58 +0000)]
Fix for <rdar://problem/8896057>

Reviewed by Dan Bernstein and Maciej Stachowiak.

Give the Web Process access to the PubSub agent.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 21 Jan 2011 21:43:03 +0000 (21:43 +0000)]
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add run-time enable support for the web audio API
        https://bugs.webkit.org/show_bug.cgi?id=52741

        * public/WebRuntimeFeatures.h:
        * public/WebSettings.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableWebAudio):
        (WebKit::WebRuntimeFeatures::isWebAudioEnabled):
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setWebAudioEnabled):
        * src/WebSettingsImpl.h:
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add run-time enable support for the web audio API
        https://bugs.webkit.org/show_bug.cgi?id=52741

        * WebPreferenceKeysPrivate.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add run-time enable support for the web audio API
        https://bugs.webkit.org/show_bug.cgi?id=52741

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (-[WebPreferences webAudioEnabled]):
        (-[WebPreferences setWebAudioEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add run-time enable support for the web audio API
        https://bugs.webkit.org/show_bug.cgi?id=52741

        No new tests since audio API is not yet implemented.

        * WebCore.exp.in:
        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled):
        (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
        * page/DOMWindow.idl:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setWebAudioEnabled):
        * page/Settings.h:
        (WebCore::Settings::webAudioEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix windows build.
weinig@apple.com [Fri, 21 Jan 2011 21:33:40 +0000 (21:33 +0000)]
Fix windows build.

* WebScrollBar.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 21 Jan 2011 21:33:07 +0000 (21:33 +0000)]
2011-01-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Menulist text often collides with separator
        https://bugs.webkit.org/show_bug.cgi?id=51155

        Rebaseline tests that have different affected by the metrics of
        the menulist.

        * platform/gtk/fast/forms/001-expected.checksum:
        * platform/gtk/fast/forms/001-expected.png:
        * platform/gtk/fast/forms/001-expected.txt:
        * platform/gtk/fast/forms/003-expected.checksum:
        * platform/gtk/fast/forms/003-expected.png:
        * platform/gtk/fast/forms/003-expected.txt:
        * platform/gtk/fast/forms/004-expected.checksum:
        * platform/gtk/fast/forms/004-expected.png:
        * platform/gtk/fast/forms/004-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
        * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
        * platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
        * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
        * platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
        * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
        * platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
        * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
        * platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
        * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
        * platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
        * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
        * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
        * platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
        * platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
        * platform/gtk/fast/forms/control-clip-overflow-expected.png:
        * platform/gtk/fast/forms/control-clip-overflow-expected.txt:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.png:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
        * platform/gtk/fast/forms/disabled-select-change-index-expected.png:
        * platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
        * platform/gtk/fast/forms/form-element-geometry-expected.checksum:
        * platform/gtk/fast/forms/form-element-geometry-expected.png:
        * platform/gtk/fast/forms/form-element-geometry-expected.txt:
        * platform/gtk/fast/forms/input-file-re-render-expected.checksum: Added.
        * platform/gtk/fast/forms/input-file-re-render-expected.png: Added.
        * platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
        * platform/gtk/fast/forms/menulist-deselect-update-expected.png:
        * platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
        * platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
        * platform/gtk/fast/forms/menulist-narrow-width-expected.png:
        * platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
        * platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
        * platform/gtk/fast/forms/menulist-no-overflow-expected.png:
        * platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
        * platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
        * platform/gtk/fast/forms/menulist-separator-painting-expected.png:
        * platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
        * platform/gtk/fast/forms/menulist-style-color-expected.checksum:
        * platform/gtk/fast/forms/menulist-style-color-expected.png:
        * platform/gtk/fast/forms/menulist-style-color-expected.txt:
        * platform/gtk/fast/forms/menulist-width-change-expected.checksum:
        * platform/gtk/fast/forms/menulist-width-change-expected.png:
        * platform/gtk/fast/forms/menulist-width-change-expected.txt:
        * platform/gtk/fast/forms/option-script-expected.checksum:
        * platform/gtk/fast/forms/option-script-expected.png:
        * platform/gtk/fast/forms/option-script-expected.txt:
        * platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
        * platform/gtk/fast/forms/option-strip-whitespace-expected.png:
        * platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
        * platform/gtk/fast/forms/option-text-clip-expected.checksum:
        * platform/gtk/fast/forms/option-text-clip-expected.png:
        * platform/gtk/fast/forms/option-text-clip-expected.txt:
        * platform/gtk/fast/forms/select-align-expected.checksum:
        * platform/gtk/fast/forms/select-align-expected.png:
        * platform/gtk/fast/forms/select-align-expected.txt:
        * platform/gtk/fast/forms/select-baseline-expected.checksum:
        * platform/gtk/fast/forms/select-baseline-expected.png:
        * platform/gtk/fast/forms/select-baseline-expected.txt:
        * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
        * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
        * platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
        * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
        * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
        * platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
        * platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
        * platform/gtk/fast/forms/select-disabled-appearance-expected.png:
        * platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
        * platform/gtk/fast/forms/select-initial-position-expected.checksum:
        * platform/gtk/fast/forms/select-initial-position-expected.png:
        * platform/gtk/fast/forms/select-initial-position-expected.txt:
        * platform/gtk/fast/forms/select-selected-expected.checksum:
        * platform/gtk/fast/forms/select-selected-expected.png:
        * platform/gtk/fast/forms/select-selected-expected.txt:
        * platform/gtk/fast/forms/select-size-expected.checksum:
        * platform/gtk/fast/forms/select-size-expected.png:
        * platform/gtk/fast/forms/select-size-expected.txt:
        * platform/gtk/fast/forms/select-style-expected.checksum:
        * platform/gtk/fast/forms/select-style-expected.png:
        * platform/gtk/fast/forms/select-style-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.png:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
        * platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
        * platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
        * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
        * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
        * platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
2011-01-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Menulist text often collides with separator
        https://bugs.webkit.org/show_bug.cgi?id=51155

        Move menulist rendering to RenderThemeGtk and correct padding code
        for separators in menulists.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::RenderThemeGtk): Initialize new widget members.
        (WebCore::RenderThemeGtk::getComboBoxSeparatorWidth): Added.
        (WebCore::RenderThemeGtk::comboBoxArrowSize): Added.
        (WebCore::getButtonInnerBorder): Added.
        (WebCore::RenderThemeGtk::getComboBoxPadding): Do this manually instead of using
        Mozilla code.
        (WebCore::RenderThemeGtk::paintMenuList): Ditto.
        (WebCore::setupWidget): Abstracted this part of the setupWidgetAndAddToContainer
        out to handle child widgets of comboboxes.
        (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Abstracted out setupWidget.
        (WebCore::RenderThemeGtk::gtkContainer): Added.
        (WebCore::getGtkComboBoxButton): Added.
        (WebCore::getGtkComboBoxPieces): Added.
        (WebCore::RenderThemeGtk::gtkComboBox): Call setupWidget here.
        (WebCore::RenderThemeGtk::refreshComboBoxChildren): Added.
        (WebCore::RenderThemeGtk::gtkComboBoxButton): Added.
        (WebCore::RenderThemeGtk::gtkComboBoxArrow): Added.
        (WebCore::RenderThemeGtk::gtkComboBoxSeparator): Added.
        * platform/gtk/RenderThemeGtk.h: Added new members and methods.
        * platform/gtk/WidgetRenderingContext.h: Added new members and methods.
        * platform/gtk/WidgetRenderingContextGtk2.cpp:
        (WebCore::WidgetRenderingContext::gtkPaintArrow):
        (WebCore::WidgetRenderingContext::gtkPaintVLine):
        * platform/gtk/WidgetRenderingContextGtk3.cpp:
        (WebCore::WidgetRenderingContext::gtkPaintArrow):
        (WebCore::WidgetRenderingContext::gtkPaintVLine):
        * platform/gtk/gtk2drawing.c: Removed code for drawing menulists and buttons.
        (moz_gtk_init):
        (moz_gtk_get_widget_border):
        (moz_gtk_widget_paint):
        * platform/gtk/gtk3drawing.c:
        (moz_gtk_init):
        (moz_gtk_get_widget_border):
        (moz_gtk_widget_paint):
        * platform/gtk/gtkdrawing.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix chromium mac build.
weinig@apple.com [Fri, 21 Jan 2011 21:17:01 +0000 (21:17 +0000)]
Fix chromium mac build.

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial fix.
ossy@webkit.org [Fri, 21 Jan 2011 21:10:12 +0000 (21:10 +0000)]
Unreviewed trivial fix.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

* platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Updated after r76357.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the windows build.
weinig@apple.com [Fri, 21 Jan 2011 21:08:45 +0000 (21:08 +0000)]
Fix the windows build.

* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip transitions/transition-end-event-destroy-iframe.html on Windows in order to...
jberlin@webkit.org [Fri, 21 Jan 2011 21:02:27 +0000 (21:02 +0000)]
Skip transitions/transition-end-event-destroy-iframe.html on Windows in order to get the
Windows 7 Release bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52913

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 21 Jan 2011 20:54:26 +0000 (20:54 +0000)]
2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; another Chromium build fix attempt for r76378.

        * src/WebScrollbarImpl.cpp:
        (WebKit::WebScrollbar::create):
        (WebKit::WebScrollbarImpl::WebScrollbarImpl):
        (WebKit::WebScrollbarImpl::setValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 21 Jan 2011 20:42:06 +0000 (20:42 +0000)]
2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium build fix attempt for r76378.

        * src/WebScrollbarImpl.cpp:
        (WebKit::WebScrollbar::create):
        (WebKit::WebScrollbarImpl::WebScrollbarImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 21 Jan 2011 20:34:38 +0000 (20:34 +0000)]
2011-01-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Skip another test that is failing sporadically on the buildbots
        https://bugs.webkit.org/show_bug.cgi?id=52908

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 21 Jan 2011 20:29:33 +0000 (20:29 +0000)]
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add chromium bundled audio spatialization resources to WebAudio.grd
        https://bugs.webkit.org/show_bug.cgi?id=52651

        * WebKit.grd:
2011-01-21  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add chromium bundled audio spatialization resources to WebAudio.grd
        https://bugs.webkit.org/show_bug.cgi?id=52651

        No new tests since audio API is not yet implemented.

        * WebCore.gyp/WebCore.gyp:
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::AudioBus::loadPlatformResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Xiyuan Xia <xiyuan@chromium.org>
commit-queue@webkit.org [Fri, 21 Jan 2011 20:26:01 +0000 (20:26 +0000)]
2011-01-21  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        Update chromium/linux baselines after drawing code moved into
        WebThemeEngine.
        https://bugs.webkit.org/show_bug.cgi?id=52826

        * platform/chromium-linux/css1/box_properties/acid_test-expected.checksum:
        * platform/chromium-linux/css1/box_properties/acid_test-expected.png:
        * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
        * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
        * platform/chromium-linux/fast/block/basic/011-expected.checksum:
        * platform/chromium-linux/fast/block/basic/011-expected.png:
        * platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
        * platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
        * platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.checksum:
        * platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
        * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
        * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
        * platform/chromium-linux/fast/forms/basic-inputs-expected.checksum:
        * platform/chromium-linux/fast/forms/basic-inputs-expected.png:
        * platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
        * platform/chromium-linux/fast/forms/basic-selects-expected.png:
        * platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
        * platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
        * platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.checksum:
        * platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png:
        * platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
        * platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
        * platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
        * platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
        * platform/chromium-linux/fast/forms/formmove-expected.checksum:
        * platform/chromium-linux/fast/forms/formmove-expected.png:
        * platform/chromium-linux/fast/forms/formmove2-expected.checksum:
        * platform/chromium-linux/fast/forms/formmove2-expected.png:
        * platform/chromium-linux/fast/forms/indeterminate-expected.checksum:
        * platform/chromium-linux/fast/forms/indeterminate-expected.png:
        * platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
        * platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
        * platform/chromium-linux/fast/forms/input-value-expected.checksum:
        * platform/chromium-linux/fast/forms/input-value-expected.png:
        * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
        * platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
        * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
        * platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added property svn:mime-type.
        * platform/chromium-linux/fast/forms/radio-attr-order-expected.checksum:
        * platform/chromium-linux/fast/forms/radio-attr-order-expected.png:
        * platform/chromium-linux/fast/forms/radio-nested-labels-expected.checksum:
        * platform/chromium-linux/fast/forms/radio-nested-labels-expected.png:
        * platform/chromium-linux/fast/forms/radio_checked-expected.checksum:
        * platform/chromium-linux/fast/forms/radio_checked-expected.png:
        * platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.checksum:
        * platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png:
        * platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
        * platform/chromium-linux/fast/forms/select-baseline-expected.png:
        * platform/chromium-linux/fast/inline/positionedLifetime-expected.checksum:
        * platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
        * platform/chromium-linux/fast/parser/bad-xml-slash-expected.checksum:
        * platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
        * platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
        * platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
        * platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.checksum:
        * platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
        * platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
        * platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
        * platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
        * platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added property svn:mime-type.
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
2011-01-21  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
        https://bugs.webkit.org/show_bug.cgi?id=52826

        * platform/chromium/ChromiumBridge.h:
        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::getWebThemeState):
        (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
        (WebCore::RenderThemeChromiumLinux::paintCheckbox):
        (WebCore::RenderThemeChromiumLinux::setCheckboxSize):
        (WebCore::RenderThemeChromiumLinux::paintRadio):
        (WebCore::RenderThemeChromiumLinux::setRadioSize):
        (WebCore::RenderThemeChromiumLinux::paintButton):
        (WebCore::RenderThemeChromiumLinux::paintTextField):
        (WebCore::RenderThemeChromiumLinux::paintMenuList):
        (WebCore::RenderThemeChromiumLinux::paintSliderTrack):
        (WebCore::RenderThemeChromiumLinux::paintSliderThumb):
        (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
        (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
        (WebCore::RenderThemeChromiumLinux::paintProgressBar):
        * rendering/RenderThemeChromiumLinux.h:
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::setCheckboxSize):
        (WebCore::RenderThemeChromiumSkia::setSizeIfAuto):
        (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
        * rendering/RenderThemeChromiumSkia.h:
2011-01-21  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
        https://bugs.webkit.org/show_bug.cgi?id=52826

        * WebKit.gyp:
        * src/ChromiumBridge.cpp:
        (WebCore::WebThemePart):
        (WebCore::GetWebThemeExtraParams):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
weinig@apple.com [Fri, 21 Jan 2011 20:15:04 +0000 (20:15 +0000)]
Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Anders Carlsson.

Rename ScrollbarClient -> ScrollableArea.

Source/WebCore:

- Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea
  since that was its only use case.

* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* page/FrameView.h:
* platform/PopupMenuClient.h:
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::notityPositionChanged):
* platform/ScrollAnimator.h:
* platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):
* platform/ScrollAnimatorWin.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::~ScrollableArea):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
* platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::isWindowActive):
(WebCore::Scrollbar::invalidateRect):
(WebCore::Scrollbar::convertToContainingView):
(WebCore::Scrollbar::convertFromContainingView):
* platform/Scrollbar.h:
(WebCore::Scrollbar::disconnectFromScrollableArea):
(WebCore::Scrollbar::scrollableArea):
* platform/ScrollbarClient.cpp: Removed.
* platform/ScrollbarClient.h: Removed.
* platform/ScrollbarThemeComposite.cpp:
* platform/chromium/FramelessScrollView.h:
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* platform/efl/ScrollbarEfl.cpp:
(Scrollbar::createNativeScrollbar):
(ScrollbarEfl::ScrollbarEfl):
(scrollbarEflEdjeMessage):
* platform/efl/ScrollbarEfl.h:
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::create):
(MainFrameScrollbarGtk::MainFrameScrollbarGtk):
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/gtk/MainFrameScrollbarGtk.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h:
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
* platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::paint):
* rendering/RenderDataGrid.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::scroll):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::destroyScrollbar):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar):
* rendering/RenderMenuList.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):
* rendering/RenderScrollbar.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createScrollbar):
* rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

* src/AutoFillPopupMenuClient.cpp:
(WebKit::AutoFillPopupMenuClient::createScrollbar):
* src/AutoFillPopupMenuClient.h:
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
* src/WebScrollbarImpl.h:
* tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::createScrollbar):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

Source/WebKit/win:

* WebScrollBar.cpp:
(WebScrollBar::scroll):
* WebScrollBar.h:

Source/WebKit2:

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
* UIProcess/win/WebPopupMenuProxyWin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Sailesh Agrawal <sail@chromium.org>
commit-queue@webkit.org [Fri, 21 Jan 2011 20:13:23 +0000 (20:13 +0000)]
2011-01-21  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Ryosuke Niwa.

        [chromium] Notify WebFrameClient when spellcheck state changes
        https://bugs.webkit.org/show_bug.cgi?id=52680

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
        * src/WebFrameImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Peter Gal <galpeter@inf.u-szeged.hu>
commit-queue@webkit.org [Fri, 21 Jan 2011 20:01:11 +0000 (20:01 +0000)]
2011-01-21  Peter Gal  <galpeter@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        REGRESSION(r76177): All JavaScriptCore tests fail on ARM
        https://bugs.webkit.org/show_bug.cgi?id=52814

        Get the approximateByteSize value before releasing the OwnPtr.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseFunctionInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Leopard build.
darin@apple.com [Fri, 21 Jan 2011 19:51:53 +0000 (19:51 +0000)]
Fix Leopard build.

* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 21 Jan 2011 19:44:27 +0000 (19:44 +0000)]
2011-01-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        GraphicsLayer should be non-copyable
        https://bugs.webkit.org/show_bug.cgi?id=52909

        Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
        on that and KeyframeValueList.

        * platform/graphics/GraphicsLayer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Fri, 21 Jan 2011 19:40:02 +0000 (19:40 +0000)]
2011-01-21  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
        https://bugs.webkit.org/show_bug.cgi?id=52901

        * fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added.
        * fast/dom/htmlcollection-conversion-throws-exception.html: Added.
2011-01-21  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
        https://bugs.webkit.org/show_bug.cgi?id=52901

        Test: fast/dom/htmlcollection-conversion-throws-exception.html

        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        (WebCore::getItem):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSeparate flushing layer changes from rendering in CACFLayerTreeHost
aroben@apple.com [Fri, 21 Jan 2011 19:35:43 +0000 (19:35 +0000)]
Separate flushing layer changes from rendering in CACFLayerTreeHost

Old model:
  1) A change is made to a GraphicsLayer.
  2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the
     render timer.
  3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the
     flush and then renders.

New model:
  1) A change is made to a GraphicsLayer.
  2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new
     LayerChangesFlusher singleton that this host has changes that need to be flushed.
  3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration
     of the message loop.
  4) LayerChangesFlusher's hook is called, which calls through to
     CACFLayerTreeHost::flushPendingLayerChangesNow.
  5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes
     that were just flushed to the context will be rendered.

When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
(e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
scheduling the flush.

This change has three advantages:
  1) Whenever we flush layer changes, we first update layout. This can cause the page to
     leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
     to be dropped. By separating flushing (and thus updating layout) from rendering, we no
     longer have to worry about this happen during rendering.
  2) The new model is much more similar to how things work on the Mac, so will hopefully
     reduce the number of platform-specific bugs.
  3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a
     layout was pending, is no longer needed. It actually hasn't been needed since at least
     r75987, but removing it before now would have resulted in a crash whenever a page came
     out of compositing mode due to (1).

Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing
 #includes.
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
finished.
(WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
fixed a bug where we'd fail to clear the context's layer.
(WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
is no longer needed. Moved code to flush layer changes from here to
flushPendingLayerChangesNow, which is called via the above-described mechanism.
(WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
code to schedule a render, which now happens after we've flushed.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
schedule a render so that the changes will be rendered to the screen.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Removed
CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
m_isFlushingLayerChanges.

* platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared):
(WebCore::LayerChangesFlusher::LayerChangesFlusher):
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookCallback):
(WebCore::LayerChangesFlusher::hookFired):
(WebCore::LayerChangesFlusher::setHook):
(WebCore::LayerChangesFlusher::removeHook):

* platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared): Returns the singleton.
(WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
hosts with changes that need to be flushed, and set up our hook if we haven't already.
(WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
we're currently in the process of calling out to our hosts, in which case we'll take care of
the hook once we're done calling out.
(WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
our hook fires. Just calls through to hookFired on the singleton.
(WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
flushed that it's time to flush. If no hosts re-added themselves to our set during this
process, remove our hook.
(WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
(WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.

* platform/graphics/ca/win/LayerChangesFlusher.h: Added.

Source/WebKit/win:

Update for CACFLayerTreeHost changes

* WebView.cpp:
(WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
to our own flushing function if needed.

* WebView.h: Removed shouldRender, which is no longer used or needed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 21 Jan 2011 19:33:41 +0000 (19:33 +0000)]
2011-01-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Report the sized used by canvases and types arrays
        https://bugs.webkit.org/show_bug.cgi?id=52856

        Report the memory cost associated with canvas elements,
        and typed arrays to JavaScript as extraCost, so that it
        can figure this into its GC behavior.

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::toJSArrayBufferView): New templatized function, similar
        to getDOMObjectWrapper() but calls reportExtraMemoryCost() with
        the byteLength of the array.

        * bindings/js/JSFloat32ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSInt16ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSInt32ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSInt8ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSUint16ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSUint32ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSUint8ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost()
        with the size of the canvas backing store.

        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::byteLength): byteLength needs to
        be public.

        * platform/graphics/ImageBuffer.h: Add dataSize() method.

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/haiku/ImageBufferHaiku.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/wince/ImageBufferWinCE.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/wx/ImageBufferWx.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]
aroben@apple.com [Fri, 21 Jan 2011 19:32:59 +0000 (19:32 +0000)]
Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]

Also renamed a few functions and data members to match.

Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.

* WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include
path.

* WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Updated for renames.

Source/WebKit/win:

Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename

Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.

* WebPreferences.cpp:
* WebView.cpp:
(WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
host before we get rid of the layer tree host itself.
* WebView.h:

Source/WebKit2:

Update for WKCACFLayerRenderer -> CACFLayerView rename

* WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary
 #includes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 21 Jan 2011 19:32:27 +0000 (19:32 +0000)]
2011-01-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Remove unnecessary <stdio.h> include
        https://bugs.webkit.org/show_bug.cgi?id=52884

        * jit/JIT.cpp: remove unnecessary include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 21 Jan 2011 19:27:49 +0000 (19:27 +0000)]
2011-01-21  Patrick Gansterer  <paroga@paroga.com>

        Original patch from Fran├žois Sausset  <sausset@gmail.com>

        Reviewed by Darin Adler.

        Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52201

        Replace unneeded doubles by floats and remove unneeded casts.

        * rendering/mathml/RenderMathMLFraction.cpp:
        (WebCore::RenderMathMLFraction::paint):
        * rendering/mathml/RenderMathMLFraction.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProposal: Require cross-organizational seconds for reviewer nominations
levin@chromium.org [Fri, 21 Jan 2011 19:20:45 +0000 (19:20 +0000)]
Proposal: Require cross-organizational seconds for reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=47597

Reviewed by Darin Adler.

This changes the committer/reviewer policy to require an additional
reviewer supporting a reviewer nomination to work for a different
company and different project affiliation from the nominee.

This means reviewer nominations would require four supporting reviewers,
one of which knows the reviewer through the community (irc, email, bugs)
ensuring that the nominee has the open-source collaboration skills
we so highly value here in WebKit.

* coding/commit-review-policy.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 21 Jan 2011 19:20:05 +0000 (19:20 +0000)]
2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r73618): Clicking on a search input causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=52905

        * fast/dom/search-shadow-host-crash-expected.txt: Added.
        * fast/dom/search-shadow-host-crash.html: Added.
2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r73618): Clicking on a search input causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=52905

        The problem is caused by TextControlInnerElement being used both as
        shadow root and an element in a shadow subtree. The code assumed it is
        only used as a shadow root.

        Since this code is all just workaround for in-progress conversion to
        new shadow DOM, I am just adding a check. This code will disappear
        completely once bug 52788 is fixed.

        Test: fast/dom/search-shadow-host-crash.html

        * dom/Node.cpp:
        (WebCore::Node::setShadowHost): Added an ASSERT for early detection
            of attempting to stomp on the parentNode.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::detach): Added a check to only
            clear shadow host if we have one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 21 Jan 2011 19:05:01 +0000 (19:05 +0000)]
2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated slider expectations after r76147.

        * platform/chromium/test_expectations.txt: Removed test that will start passing.
        * platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 21 Jan 2011 19:00:54 +0000 (19:00 +0000)]
2011-01-21  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Rebaseline for leopard after r76319.

        * platform/mac-leopard/fast/dom/52776-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 Jan 2011 18:50:59 +0000 (18:50 +0000)]
2011-01-21  Tony Chang  <tony@chromium.org>

        Unreviewed, updating chromium DEPS so we can pull in linux theme changes.

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fix Mac build.
darin@apple.com [Fri, 21 Jan 2011 18:44:42 +0000 (18:44 +0000)]
   Fix Mac build.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Implement showModalDialog
darin@apple.com [Fri, 21 Jan 2011 18:41:32 +0000 (18:41 +0000)]
WebKit2: Implement showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=52855

Reviewed by Dan Bernstein.

Source/WebKit2:

* Shared/WebPageCreationParameters.h: Added canRunModal.

* UIProcess/API/C/WKPage.h: Added a runModal function pointer to
WKPageUIClient. Also removed a lot of redundant typedefs and added
a new one, WKPageCallback, for callbacks without arguments or return
values.

* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage): Added a runModal function pointer of 0.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters): Set canRunModal
based on return value of WebUIClient::canRunModal.

* UIProcess/WebPageProxy.h: Added runModal.
Calls WebUIClient::runModal.

* UIProcess/WebPageProxy.messages.in: Added RunModal message.
Also removed the periods from the phrases in the comments
as Maciej requested a while back.

* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canRunModal): Added. Returns true or false
based on whether a runModal function was supplied in the
WKPageUIClient structure.
(WebKit::WebUIClient::runModal): Added. Calls the runModal
function from the WKPageUIClient structure.
* UIProcess/WebUIClient.h: Declared the above functions.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canRunModal): Call through to WebPage.
(WebKit::WebChromeClient::runModal): Ditto.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
creation parameters. Initialize m_isRunningModal to false.
(WebKit::WebPage::close): Stop the nested run loop if we are running modal.
(WebKit::WebPage::runModal): Send a message to ask the UI process to run
modal and then start a nested run loop. It gets stopped when the page is closed.
* WebProcess/WebPage/WebPage.h: Defined the canRunModal function
and declared the runModal function.

Tools:

This fixes WebKitTestRunner to compile, but more work is probably
needed to get it to pass the tests.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runModal): Added. Calls through to the
platform-specific version of runModal.
(WTR::TestController::createOtherPage): Changed to be a private
static member function so it can refer to runModal, which is
a private static member function.
(WTR::TestController::initialize): Pass 0 for the runModal
function since we don't need to run the main window modal.
I suspect this is wrong and will need to change.
* WebKitTestRunner/TestController.h: Added declarations for
the functions added above.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::runModal): Added. Untested implementation.
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::runModal): Added.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::runModal): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Kenji Imasaki <imasaki@chromium.org>
commit-queue@webkit.org [Fri, 21 Jan 2011 18:41:15 +0000 (18:41 +0000)]
2011-01-21  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by David Levin.

        remove non-flaky tests from test expectation file
        https://bugs.webkit.org/show_bug.cgi?id=52746

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace some "sync compositing state" terminology with "flush pending GraphicsLayer...
aroben@apple.com [Fri, 21 Jan 2011 18:31:45 +0000 (18:31 +0000)]
Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"

This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.

Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing

Reviewed by Simon Fraser.

Source/WebCore:

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
Updated for renames.

(WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
syncCompositingStateSoon, and updated for other renames.

* platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
* m_shouldFlushPendingGraphicsLayerChanges.
(WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
syncCompositingState.

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.

* WebView.cpp:
(WebView::paint): Updated for rename.
(WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
(WebView::notifySyncRequired): Updated for rename.
(WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.

* WebView.h: Did the renames.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up PlatformCAAnimationWin
aroben@apple.com [Fri, 21 Jan 2011 18:31:02 +0000 (18:31 +0000)]
Clean up PlatformCAAnimationWin

Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient

Reviewed by Simon Fraser.

* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFFillModeType):
(fromCACFFillModeType):
(toCACFValueFunctionType):
(fromCACFValueFunctionType):
Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
so we can later convert back to CFStringRef.

(toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
results of CACFTimingFunctionCreate.
(PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().

(PlatformCAAnimation::setFillMode):
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setValueFunction):
(PlatformCAAnimation::setTimingFunctions):
Updated for changes to the above conversion functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Charlie Reis <creis@chromium.org>
commit-queue@webkit.org [Fri, 21 Jan 2011 18:26:42 +0000 (18:26 +0000)]
2011-01-21  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
        https://bugs.webkit.org/show_bug.cgi?id=48812

        Test that we avoid updating back/forward list on a canceled navigation
        if a new navigation is already in process.  Also update forward-and-cancel
        to go forward, ensuring back/forward state is reset if user clicks stop.

        * http/tests/navigation/back-twice-without-commit-expected.txt: Added.
        * http/tests/navigation/back-twice-without-commit.html: Added.
        * http/tests/navigation/forward-and-cancel-expected.txt:
        * http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
        * http/tests/navigation/resources/back-twice-page-2.html: Added.
        * http/tests/navigation/resources/back-twice-page-3.html: Added.
        * http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.
2011-01-21  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
        https://bugs.webkit.org/show_bug.cgi?id=48812

        Most calls to stopAllLoaders now clear the history's provisional item(s).
        We can now avoid resetting the back/forward state if a new navigation
        is in progress.

        Test: http/tests/navigation/back-twice-without-commit.html
        Test: http/tests/navigation/forward-and-cancel.html

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/FrameLoaderTypes.h:
        * WebCore.exp.in: Update stopAllLoaders signature.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 21 Jan 2011 18:09:38 +0000 (18:09 +0000)]
2011-01-20  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
        https://bugs.webkit.org/show_bug.cgi?id=52860

        The test hasn't had a timeout in a while, remove that expectation so
        that we can more easily see if this re-occurs.

        Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
        like chromium-gpu-win and -linux, for some reason the mac expectation
        has it as 17,128,4).

        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 21 Jan 2011 17:51:13 +0000 (17:51 +0000)]
2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Reverted the last change to the text expectation.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 21 Jan 2011 17:39:05 +0000 (17:39 +0000)]
2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 21 Jan 2011 17:33:49 +0000 (17:33 +0000)]
2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines for 76319.

        * platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
        * platform/chromium-linux/fast/dom/52776-expected.png: Added.
        * platform/chromium-linux/fast/dom/52776-expected.txt: Added.
        * platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
        * platform/chromium-mac/fast/dom/52776-expected.png: Added.
        * platform/chromium-mac/fast/dom/52776-expected.txt: Added.
        * platform/chromium-win/fast/dom/52776-expected.checksum: Added.
        * platform/chromium-win/fast/dom/52776-expected.png: Added.
        * platform/chromium-win/fast/dom/52776-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 Jan 2011 17:26:10 +0000 (17:26 +0000)]
2011-01-21  Tony Chang  <tony@chromium.org>

        Unreviewed, these tests were fixed in r76330.  Still one unknown
        failure.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 21 Jan 2011 17:21:51 +0000 (17:21 +0000)]
2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Show caps lock indicator in password fields
        https://bugs.webkit.org/show_bug.cgi?id=52878

        Test: manual-tests/password-caps-lock.html

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement
        currentCapsLockState() using GDK API.
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon
        in the password field when the caps lock modifier is locked.
        * platform/gtk/RenderThemeGtk.h:
2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Show caps lock indicator in password fields
        https://bugs.webkit.org/show_bug.cgi?id=52878

        Test: manual-tests/password-caps-lock.html

        * webkit/webkitwebview.cpp:
        (webkit_web_view_key_release_event): Call
        capsLockStateMayHaveChanged() when caps lock key is pressed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoModify the Windows-specific results after http://trac.webkit.org/changeset/76208...
jberlin@webkit.org [Fri, 21 Jan 2011 16:36:54 +0000 (16:36 +0000)]
Modify the Windows-specific results after trac.webkit.org/changeset/76208 in order to
get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52557

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed.
jberlin@webkit.org [Fri, 21 Jan 2011 16:22:08 +0000 (16:22 +0000)]
Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776

* platform/win/fast/dom/52776-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 21 Jan 2011 16:08:45 +0000 (16:08 +0000)]
2011-01-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
        https://bugs.webkit.org/show_bug.cgi?id=52874

        This is the first step of debugger api refactoring (see bug 52879).
        JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
        The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.

        * inspector/Inspector.idl:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
        (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebugger):
        (WebCore::InspectorController::resume):
        (WebCore::InspectorController::inspectedURL):
        * inspector/InspectorController.h:
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Fri, 21 Jan 2011 15:51:14 +0000 (15:51 +0000)]
2011-01-21  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Turn off uninitialized errors for ARM linux build.
        https://bugs.webkit.org/show_bug.cgi?id=52893

        Fix ARM compiler breakage.

        * WebCore.gyp/WebCore.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 21 Jan 2011 15:00:08 +0000 (15:00 +0000)]
2011-01-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Add layout test for the CPU profiler.

        This test replaces DevToolsSanityTest.TestProfilerTab from
        Chromium's interactive_ui_tests.

        https://bugs.webkit.org/show_bug.cgi?id=52634

        * inspector/cpu-profiler-profiling-expected.txt: Added.
        * inspector/cpu-profiler-profiling.html: Added.

[Relanding, this time the test should work in Chromium]

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 21 Jan 2011 14:41:54 +0000 (14:41 +0000)]
2011-01-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] REGRESSION: Using the "Back" button
        while profiling causes renderer crash.

        https://bugs.webkit.org/show_bug.cgi?id=52808

        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
        (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 21 Jan 2011 12:30:56 +0000 (12:30 +0000)]
2011-01-20  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

        There are some places in WebCore where we still using direct InspectorController calls.
        The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
        Inspector facade for WebCore.

        https://bugs.webkit.org/show_bug.cgi?id=52869

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addProfileImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addProfile):
        (WebCore::InspectorInstrumentation::profilerEnabled):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Fri, 21 Jan 2011 12:16:20 +0000 (12:16 +0000)]
Unreviewed.

[Qt] editing/selection/rtl-move-selection-right-left.html fails
https://bugs.webkit.org/show_bug.cgi?id=52883

* platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 21 Jan 2011 12:08:13 +0000 (12:08 +0000)]
2011-01-21  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        [GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
        https://bugs.webkit.org/show_bug.cgi?id=52882

        Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 21 Jan 2011 11:59:29 +0000 (11:59 +0000)]
2011-01-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: breakpoints are restored incorrectly when reverting live edit.
        https://bugs.webkit.org/show_bug.cgi?id=52300

        Fix breakpoints restoring when reverting to old revision by using text diff.
        Move live edit logic from ScriptsPanel to DebuggerModel.
        Eliminate unnecessary editLine delegate in TextViewer.

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._updateScriptSource):
        (WebInspector.DebuggerModel.prototype.get callFrames):
        (WebInspector.DebuggerModel.prototype.pausedScript):
        (WebInspector.DebuggerModel.prototype.resumedScript):
        * inspector/front-end/Script.js:
        (WebInspector.Script.prototype.get source):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
        (WebInspector.SourceFrame.prototype._doubleClick.didEditLine):
        (WebInspector.SourceFrame.prototype._doubleClick):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype._handleKeyDown):
        (WebInspector.TextViewer.prototype.editLine.finishEditing):
        (WebInspector.TextViewer.prototype.editLine):
        (WebInspector.TextChunk.prototype._createRow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Fri, 21 Jan 2011 11:31:15 +0000 (11:31 +0000)]
2011-01-21  Adam Klein  <adamk@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Rename ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52471

        No tests added as this is a rename; no change in behavior.

        * WebCore.gypi:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::reportFatalErrorInV8):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::isLinkVisited):
        * platform/android/PlatformBridge.h:
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::createBusFromInMemoryAudioFile):
        * platform/chromium/ChromiumBridge.h: Removed.
        * platform/chromium/ChromiumDataObjectLegacy.cpp:
        (WebCore::ChromiumDataObjectLegacy::getData):
        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
        * platform/chromium/FileSystemChromium.cpp:
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::revealFolderInOS):
        (WebCore::directoryName):
        (WebCore::pathByAppendingComponent):
        (WebCore::makeAllDirectories):
        (WebCore::fileExists):
        (WebCore::openFile):
        (WebCore::closeFile):
        (WebCore::seekFile):
        (WebCore::truncateFile):
        (WebCore::readFromFile):
        (WebCore::writeToFile):
        * platform/chromium/LanguageChromium.cpp:
        (WebCore::platformDefaultLanguage):
        * platform/chromium/LinkHashChromium.cpp:
        (WebCore::visitedLinkHash):
        * platform/chromium/MIMETypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PlatformBridge.h:
        * platform/chromium/PlatformScreenChromium.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/chromium/ReadableDataObject.cpp:
        (WebCore::ReadableDataObject::getData):
        (WebCore::ReadableDataObject::urlTitle):
        (WebCore::ReadableDataObject::htmlBaseUrl):
        (WebCore::ReadableDataObject::filenames):
        (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
        * platform/chromium/SSLKeyGeneratorChromium.cpp:
        (WebCore::signedPublicKeyAndChallengeString):
        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
        (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumWin::paintButton):
        (WebCore::ScrollbarThemeChromiumWin::paintThumb):
        (WebCore::ScrollbarThemeChromiumWin::buttonSize):
        * platform/chromium/SharedTimerChromium.cpp:
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):
        * platform/chromium/SuddenTerminationChromium.cpp:
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):
        * platform/chromium/SystemTimeChromium.cpp:
        (WebCore::currentTime):
        * platform/chromium/WritableDataObject.cpp:
        (WebCore::WritableDataObject::setData):
        * platform/graphics/chromium/CrossProcessFontLoading.mm:
        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::fontContainsCharacter):
        (WebCore::FillLogFont):
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::scriptFontProperties):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::querySystemForRenderStyle):
        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillBMPGlyphs):
        * platform/graphics/chromium/ImageChromium.cpp:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/ImageChromiumMac.mm:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
        (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        * platform/network/chromium/DNSChromium.cpp:
        (WebCore::prefetchDNS):
        * platform/qt/PlatformBridge.h:
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
        (WebCore::SQLiteFileSystem::deleteDatabaseFile):
        (WebCore::SQLiteFileSystem::getDatabaseFileSize):
        * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
        (chromiumOpen):
        (chromiumDelete):
        (chromiumAccess):
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
        * plugins/chromium/PluginDataChromium.cpp:
        (WebCore::PluginCache::plugins):
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumWin::systemColor):
        (WebCore::RenderThemeChromiumWin::paintButton):
        (WebCore::RenderThemeChromiumWin::paintSliderTrack):
        (WebCore::menuListButtonWidth):
        (WebCore::RenderThemeChromiumWin::paintMenuList):
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
        (WebCore::IDBFactoryBackendInterface::create):
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBKeyPathBackendImpl.cpp:
        (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2011-01-21  Adam Klein  <adamk@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Rename ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52471

        * WebKit.gyp:
        * src/AssertMatchingEnums.cpp:
        * src/PlatformBridge.cpp:
        (WebCore::toChromeClientImpl):
        (WebCore::toWebWidgetClient):
        (WebCore::getCookieJar):
        (WebCore::PlatformBridge::cacheMetadata):
        (WebCore::PlatformBridge::clipboardIsFormatAvailable):
        (WebCore::PlatformBridge::clipboardReadPlainText):
        (WebCore::PlatformBridge::clipboardReadHTML):
        (WebCore::PlatformBridge::clipboardWriteSelection):
        (WebCore::PlatformBridge::clipboardWritePlainText):
        (WebCore::PlatformBridge::clipboardWriteURL):
        (WebCore::PlatformBridge::clipboardWriteImage):
        (WebCore::PlatformBridge::clipboardWriteData):
        (WebCore::PlatformBridge::clipboardReadAvailableTypes):
        (WebCore::PlatformBridge::clipboardReadData):
        (WebCore::PlatformBridge::clipboardReadFilenames):
        (WebCore::PlatformBridge::setCookies):
        (WebCore::PlatformBridge::cookies):
        (WebCore::PlatformBridge::cookieRequestHeaderFieldValue):
        (WebCore::PlatformBridge::rawCookies):
        (WebCore::PlatformBridge::deleteCookie):
        (WebCore::PlatformBridge::cookiesEnabled):
        (WebCore::PlatformBridge::prefetchDNS):
        (WebCore::PlatformBridge::fileExists):
        (WebCore::PlatformBridge::deleteFile):
        (WebCore::PlatformBridge::deleteEmptyDirectory):
        (WebCore::PlatformBridge::getFileSize):
        (WebCore::PlatformBridge::revealFolderInOS):
        (WebCore::PlatformBridge::getFileModificationTime):
        (WebCore::PlatformBridge::directoryName):
        (WebCore::PlatformBridge::pathByAppendingComponent):
        (WebCore::PlatformBridge::makeAllDirectories):
        (WebCore::PlatformBridge::getAbsolutePath):
        (WebCore::PlatformBridge::isDirectory):
        (WebCore::PlatformBridge::filePathToURL):
        (WebCore::PlatformBridge::openFile):
        (WebCore::PlatformBridge::closeFile):
        (WebCore::PlatformBridge::seekFile):
        (WebCore::PlatformBridge::truncateFile):
        (WebCore::PlatformBridge::readFromFile):
        (WebCore::PlatformBridge::writeToFile):
        (WebCore::PlatformBridge::ensureFontLoaded):
        (WebCore::PlatformBridge::getFontFamilyForCharacters):
        (WebCore::PlatformBridge::getRenderStyleForStrike):
        (WebCore::PlatformBridge::loadFont):
        (WebCore::PlatformBridge::databaseOpenFile):
        (WebCore::PlatformBridge::databaseDeleteFile):
        (WebCore::PlatformBridge::databaseGetFileAttributes):
        (WebCore::PlatformBridge::databaseGetFileSize):
        (WebCore::PlatformBridge::idbFactory):
        (WebCore::PlatformBridge::idbShutdown):
        (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
        (WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
        (WebCore::PlatformBridge::computedDefaultLanguage):
        (WebCore::PlatformBridge::layoutTestMode):
        (WebCore::PlatformBridge::isSupportedImageMIMEType):
        (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
        (WebCore::PlatformBridge::isSupportedNonImageMIMEType):
        (WebCore::PlatformBridge::mimeTypeForExtension):
        (WebCore::PlatformBridge::mimeTypeFromFile):
        (WebCore::PlatformBridge::preferredExtensionForMIMEType):
        (WebCore::PlatformBridge::plugins):
        (WebCore::PlatformBridge::pluginScriptableObject):
        (WebCore::PlatformBridge::loadPlatformImageResource):
        (WebCore::PlatformBridge::loadPlatformAudioResource):
        (WebCore::PlatformBridge::decodeAudioFileData):
        (WebCore::PlatformBridge::sandboxEnabled):
        (WebCore::PlatformBridge::setSharedTimerFiredFunction):
        (WebCore::PlatformBridge::setSharedTimerFireTime):
        (WebCore::PlatformBridge::stopSharedTimer):
        (WebCore::PlatformBridge::decrementStatsCounter):
        (WebCore::PlatformBridge::incrementStatsCounter):
        (WebCore::PlatformBridge::histogramCustomCounts):
        (WebCore::PlatformBridge::histogramEnumeration):
        (WebCore::PlatformBridge::suddenTerminationChanged):
        (WebCore::PlatformBridge::currentTime):
        (WebCore::PlatformBridge::paintButton):
        (WebCore::PlatformBridge::paintMenuList):
        (WebCore::PlatformBridge::paintScrollbarArrow):
        (WebCore::PlatformBridge::paintScrollbarThumb):
        (WebCore::PlatformBridge::paintScrollbarTrack):
        (WebCore::PlatformBridge::paintSpinButton):
        (WebCore::PlatformBridge::paintTextField):
        (WebCore::PlatformBridge::paintTrackbar):
        (WebCore::PlatformBridge::paintProgressBar):
        (WebCore::WebThemePart):
        (WebCore::WebThemeState):
        (WebCore::GetWebThemeExtraParams):
        (WebCore::PlatformBridge::getThemePartSize):
        (WebCore::PlatformBridge::paintThemePart):
        (WebCore::PlatformBridge::traceEventBegin):
        (WebCore::PlatformBridge::traceEventEnd):
        (WebCore::PlatformBridge::visitedLinkHash):
        (WebCore::PlatformBridge::isLinkVisited):
        (WebCore::PlatformBridge::notifyJSOutOfMemory):
        (WebCore::PlatformBridge::memoryUsageMB):
        (WebCore::PlatformBridge::actualMemoryUsageMB):
        (WebCore::PlatformBridge::screenDepth):
        (WebCore::PlatformBridge::screenDepthPerComponent):
        (WebCore::PlatformBridge::screenIsMonochrome):
        (WebCore::PlatformBridge::screenRect):
        (WebCore::PlatformBridge::screenAvailableRect):
        (WebCore::PlatformBridge::popupsAllowed):
        (WebCore::WorkerContextProxy::create):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandle::cacheMetadata):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::WebFrameImpl):
        (WebKit::WebFrameImpl::~WebFrameImpl):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 21 Jan 2011 11:23:39 +0000 (11:23 +0000)]
2011-01-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Split Host object off from WebKitPatch for easier re-use
        https://bugs.webkit.org/show_bug.cgi?id=52284

        new-run-webkit-tests and other tools are eventually going to want one of these.
        Basically you need to inherit from this class if you want to pretend to be a
        self.tool object for Steps/Commands.

        * Scripts/webkitpy/common/host.py: Added.
        * Scripts/webkitpy/tool/main.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Fri, 21 Jan 2011 11:14:52 +0000 (11:14 +0000)]
2011-01-21  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] svg/css/text-gradient-shadow.svg needs expected results
        https://bugs.webkit.org/show_bug.cgi?id=52724

        * platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
        * platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Fri, 21 Jan 2011 10:06:52 +0000 (10:06 +0000)]
2011-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76335.
        http://trac.webkit.org/changeset/76335
        https://bugs.webkit.org/show_bug.cgi?id=52875

        profiler tests were broken (Requested by loislo on #webkit).

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
        (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 21 Jan 2011 09:34:29 +0000 (09:34 +0000)]
2011-01-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
        https://bugs.webkit.org/show_bug.cgi?id=52870

        Call setTimeout from "load" event listener to make sure exception in the setTimeout
        callback happens after the one in the listener.

        * platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
        * platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
        * userscripts/window-onerror-for-isolated-world-1-expected.txt:
        * userscripts/window-onerror-for-isolated-world-1.html:
        * userscripts/window-onerror-for-isolated-world-2-expected.txt:
        * userscripts/window-onerror-for-isolated-world-2.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-21 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 21 Jan 2011 09:24:44 +0000 (09:24 +0000)]
2011-01-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

        There are some places in WebCore where we still using direct InspectorController calls.
        The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
        Inspector facade for WebCore.

        https://bugs.webkit.org/show_bug.cgi?id=52869

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addProfileImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addProfile):
        (WebCore::InspectorInstrumentation::profilerEnabled):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 21 Jan 2011 06:10:42 +0000 (06:10 +0000)]
2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Maciej Stachowiak.

        Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.

        * wtf/OwnArrayPtr.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 21 Jan 2011 05:25:44 +0000 (05:25 +0000)]
2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Skip a few more tests that are failing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=52865

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 21 Jan 2011 04:58:20 +0000 (04:58 +0000)]
2011-01-20  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Oliver Hunt.

        [WINCE] Remove obsolete JSVALUE32 code
        https://bugs.webkit.org/show_bug.cgi?id=52450

        Remove the "offset hack" in create_jit_stubs, since we
        only support JSVALUE32_64 in the meantime.

        * create_jit_stubs: Removed offset argument
        * jit/JITStubs.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 21 Jan 2011 04:07:38 +0000 (04:07 +0000)]
2011-01-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        When marking conservatively, guard against reviving dead objects.
        https://bugs.webkit.org/show_bug.cgi?id=52840

        SunSpider and v8 say no change.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.

        * runtime/Heap.cpp:
        (JSC::Heap::recordExtraCost): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        (JSC::Heap::markConservatively):
        (JSC::Heap::markProtectedObjects):
        (JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
        marking function. We want to establish a separation of concerns between
        visiting roots and draining the mark stack.

        (JSC::Heap::markRoots): Gather the set of conservative references before
        clearning mark bits, because conservative marking now uses the mark bits
        to determine if a reference is valid, and avoid reviving dead objects.

        (JSC::Heap::collectAllGarbage): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        * runtime/Heap.h: Updated to use the ConservativeSet API.

        * runtime/MachineStackMarker.cpp:
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markCurrentThreadConservatively):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        (JSC::MachineStackMarker::markMachineStackConservatively):
        * runtime/MachineStackMarker.h: Ditto.

        * runtime/MarkStack.h:
        (JSC::ConservativeSet::add):
        (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the
        set of conservative references. This is different from MarkStack, since
        we don't mark the set until it is completely gathered.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::freeBlock):
        (JSC::MarkedSpace::resizeBlocks):
        (JSC::MarkedSpace::markConservatively):
        * runtime/MarkedSpace.h: When marking conservatively, guard against
        reviving dead objects.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix failing tests from r76291.
weinig@apple.com [Fri, 21 Jan 2011 03:46:13 +0000 (03:46 +0000)]
Fix failing tests from r76291.

Reviewed by Gavin Barraclough.

* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::updateScrollbars):
Take the scroll origin into account in more places.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 21 Jan 2011 03:41:11 +0000 (03:41 +0000)]
2011-01-20  Kent Tamura  <tkent@chromium.org>

        Unreviewed, sorting an Xcode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 21 Jan 2011 03:34:27 +0000 (03:34 +0000)]
2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Fix the review tool for image diffs. We would get a javascript error
        because image diffs don't have line numbers.

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Not reviewed, add a bug number to disabled test.
dimich@chromium.org [Fri, 21 Jan 2011 03:29:44 +0000 (03:29 +0000)]
[Chromium] Not reviewed, add a bug number to disabled test.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76327 268f45cc-cd09-0410-ab3c-d52691b4dbfc