WebKit.git
9 years agoExclude scrollbars from the dirty rect passed to the document
mitz@apple.com [Fri, 22 Apr 2011 18:13:24 +0000 (18:13 +0000)]
Exclude scrollbars from the dirty rect passed to the document
https://bugs.webkit.org/show_bug.cgi?id=59206

Reviewed by Sam Weinig.

No test added because functionality is unchanged.

* platform/ScrollView.cpp:
(WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
with it. If the result is empty, avoid calling paintContents().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 18:03:04 +0000 (18:03 +0000)]
2011-04-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Allow MediaPlayerPrivateAVFoundation to be disabled via a preference.
        https://bugs.webkit.org/show_bug.cgi?id=59179

        Add API to allow the WebCore Settings preference to be called from the UIProcess.

        * Shared/WebPreferencesStore.h: Added new preference definition macro.
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetAVFoundationEnabled): Added.
        (WKPreferencesGetAVFoundationEnabled): Added.
        * UIProcess/API/C/WKPreferences.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences): Pass new preference along to WebCore
            Settings.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 18:00:03 +0000 (18:00 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting .checksum files in platform/mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 17:51:00 +0000 (17:51 +0000)]
2011-04-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=59147

        Add a new isAVFoundationEnabled setting and check it before adding
        MediaPlayerPrivateAVFoundationObjC to the media engine registry.

        * WebCore.exp.in:
        * page/Settings.cpp:
        * page/Settings.h:
        (WebCore::Settings::setAVFoundationEnabled): Added.
        (WebCore::Settings::isAVFoundationEnabled): Added.
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::installedMediaEngines): Check the settings added above.
2011-04-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=59147

        Add a new user default preference, and plumb that preference down to WebCore
        Settings. Allow the fullScreenEnabled preference to override the new
        isAVFoundationEnabled preference, so that clients of the legacy full screen
        mode will continue to use that mode normally.

        * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Set the default value of new
            preference.
        (-[WebPreferences setAVFoundationEnabled:]): Added.
        (-[WebPreferences isAVFoundationEnabled]): Added.
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChanged:]): Update the WebCore settings with the
            new values from WebPreferences.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.
ap@apple.com [Fri, 22 Apr 2011 17:49:52 +0000 (17:49 +0000)]
    Reviewed by Ojan Vafai. Bugzilla JavaScript changes by Adam Barth.

        Bugzilla autocomplete should support frequent contributors who are not committers
        https://bugs.webkit.org/show_bug.cgi?id=59209

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix qt build.
weinig@apple.com [Fri, 22 Apr 2011 17:49:11 +0000 (17:49 +0000)]
Fix qt build.

* Api/qwebelement.cpp:
(setupScriptContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
bweinstein@apple.com [Fri, 22 Apr 2011 17:47:21 +0000 (17:47 +0000)]
WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=59210

Reviewed by Sam Weinig.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Stop the responsiveness timer.
(WebKit::WebPageProxy::processDidCrash): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows test result.
weinig@apple.com [Fri, 22 Apr 2011 17:40:37 +0000 (17:40 +0000)]
Fix windows test result.

* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 22 Apr 2011 17:37:23 +0000 (17:37 +0000)]
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * fast/dom/prototype-inheritance-2-expected.txt:
        Add new passing results since we now use the correct global object. The remaining
        failures are pure JS objects (Array, Boolean, String, Number, Function).
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shadowRoot):
        (DumpRenderTreeSupportGtk::ensureShadowRoot):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * DOM/WebDOMOperations.mm:
        (-[DOMElement _shadowRoot:]):
        (-[DOMElement _ensureShadowRoot:]):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Remove remaining uses of deprecated version of toJS
        https://bugs.webkit.org/show_bug.cgi?id=59170

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toJS):
        (WebCore::JSCanvasRenderingContext2D::strokeStyle):
        (WebCore::JSCanvasRenderingContext2D::fillStyle):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::profiles):
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMMimeTypeArrayCustom.cpp:
        (WebCore::JSDOMMimeTypeArray::nameGetter):
        * bindings/js/JSDOMPluginArrayCustom.cpp:
        (WebCore::JSDOMPluginArray::nameGetter):
        * bindings/js/JSDOMPluginCustom.cpp:
        (WebCore::JSDOMPlugin::nameGetter):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::namedItemGetter):
        (WebCore::JSDOMWindow::event):
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        Propagate stored global object down access chain.

        (WebCore::InjectedScriptHost::nodeAsScriptValue):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.

        (WebCore::JSInjectedScriptHost::currentCallFrame):
        (WebCore::JSInjectedScriptHost::inspectedNode):
        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMap::nameGetter):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::callNodeList):
        (WebCore::JSNodeList::nameGetter):
        * bindings/js/JSScriptProfileNodeCustom.cpp:
        (WebCore::JSScriptProfileNode::children):
        * bindings/js/JSStyleSheetListCustom.cpp:
        (WebCore::JSStyleSheetList::nameGetter):
        * bindings/js/JSXSLTProcessorCustom.cpp:
        (WebCore::JSXSLTProcessor::transformToFragment):
        (WebCore::JSXSLTProcessor::transformToDocument):
        * bindings/scripts/CodeGeneratorJS.pm:
        Propagate stored global object down access chain.

        * css/MediaQueryListListener.cpp:
        (WebCore::MediaQueryListListener::queryChanged):
        Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype,
        we will want refactor this to match other callbacks so we can remove this.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 17:25:50 +0000 (17:25 +0000)]
2011-04-22  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Eric Seidel.

        [Chromium]Mac UI polish to add left/right padding space for autofill popup window.
        https://bugs.webkit.org/show_bug.cgi?id=58960
        http://code.google.com/p/chromium/issues/detail?id=51077

        No new test because Chromium Autofill popup window doesn't have any test framework.
        This assumes only AutofillPopupMenuClient gives TexFieldPart appearance.
        Only if Autofill popup window has right/left padding.
        The code should be removed after Autofill popup window logic is separated from WebKit to Chromium.

        * rendering/RenderThemeChromiumMac.h: Add popupInternalPaddingRight() and popupInternalPaddingLeft().
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::popupInternalPaddingLeft): Return padding size only if TextFieldPart is specified.
        (WebCore::RenderThemeChromiumMac::popupInternalPaddingRight): Return padding size only if TextFieldPart is specified.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 16:51:59 +0000 (16:51 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting .checksum files in platform/gtk and platform/qt*.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGive windowless plugins' context menus an owner window in the same thread as the...
aroben@apple.com [Fri, 22 Apr 2011 16:48:35 +0000 (16:48 +0000)]
Give windowless plugins' context menus an owner window in the same thread as the plugin

In some cases, plugins pass the WKView's HWND to the ::TrackPopupMenu API. ::TrackPopupMenu
fails in this case because the WKView's HWND is owned by another process/thread. We work
around this by hooking the ::TrackPopupMenu API and providing our own window that's in the
same thread as the plugin instead.

I couldn't figure out how to write a test for this. :-(

Fixes <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No context
menu appears when right-clicking on windowless Flash plugin

Reviewed by Brian Weinstein, and looked at suspiciously by Jeff Miller.

* Platform/Module.h: Added installIATHook on Windows.

* Platform/win/ModuleWin.cpp:
(WebKit::overwriteReadOnlyMemory): New helper function. Basically a wrapper around memcpy,
but uses ::VirtualProtect to allow writing to otherwise-read-only memory.
(WebKit::findFunctionPointerAddress): New helper function. The first overload iterates over
the imported modules and functions looking for the given one. If found, returns the address
of the function pointer that is used when calling that function. The second overload calls
the first, first passing it an enumerator for the image's imported modules, then passing it
an iterator for the image's delay-loaded modules.
(WebKit::Module::installIATHook): Added. Finds the address of the function pointer that's
used when code in this module calls the given function, then overwrites the function pointer
with the passed-in one. Future calls to the given function made by code in this module
should then end up calling to the passed-in function instead of the original one.

* Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit::NetscapePluginModule::module): Added this simple getter.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Added some new Windows-only members.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::CurrentPluginSetter::CurrentPluginSetter):
(WebKit::CurrentPluginSetter::~CurrentPluginSetter):
This RAII class sets/unsets the currentPlugin global.

(WebKit::registerPluginView): Changed to use instanceHandle() instead of the mysterious
gInstance.
(WebKit::NetscapePlugin::platformPostInitialize): For windowless plugins, hook the
::TrackPopupMenu API and create a window to be used as the owner for context menus created
by this plugin. (Also changed the ::CreateWindowExW call for windowed plugins to pass an
instance handle so that the window will be associated with WebKit.dll instead of
WebKit2WebProcess.exe. This should have no visible effect, but is more correct.)
(WebKit::NetscapePlugin::platformDestroy): For windowless plugins, destroy the context menu
owner window we created above.

(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set ourselves as the current plugin.

(WebKit::NetscapePlugin::hookedTrackPopupMenu): Added. This is the function that actually
gets called when windowless plugins call ::TrackPopupMenu. If the passed-in owner window is
owned by the current thread, we have nothing to do; ::TrackPopupMenu should work just fine.
Otherwise, we use the current plugin's context menu owner window as the context menu's
owner. We also set focus to the new owner window because otherwise weird behavior results
(e.g., it's possible to scroll the WKView while the context menu is up).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 22 Apr 2011 16:45:50 +0000 (16:45 +0000)]
2011-04-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        * DumpRenderTree/gtk/EventSender.cpp:
        (scalePageByCallback): scalePageBy() support.

2011-04-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Unskipped tests that should pass now that
        eventSender.scalePageBy() is supported in GTK.

        * platform/gtk/Skipped:
        * platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.

2011-04-22  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Added support in DRT for webview scaling.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::scale):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd code to enumerate all the functions imported by a particular Windows binary
aroben@apple.com [Fri, 22 Apr 2011 16:45:49 +0000 (16:45 +0000)]
Add code to enumerate all the functions imported by a particular Windows binary

PEImage is where all the logic starts. It represents a single Portable Executable (PE)
binary. The various enumerator classes are used in conjunction with PEImage to enumerate the
modules and functions imported by that image.

I couldn't figure out how to write a test for this. :-(

Part of <http://webkit.org/b/51063> <rdar://problem/8769281> REGRESSION (WebKit2): No
context menu appears when right-clicking on windowless Flash plugin

Reviewed by Sam Weinig, and given a good once-over by Jeff Miller.

* WebCore.vcproj/WebCore.vcproj: Added the new files.

* platform/win/PEImage.cpp: Added.
(WebCore::PEImage::PEImage): Checks that the module contains the expected magic numbers,
then initializes m_ntHeaders using the module.
(WebCore::PEImage::convertRVAToAddress): Converts a relative virtual address (RVA) to a
non-relative address, which can then be dereferenced. (The PE format uses RVAs in lots of
places.)
(WebCore::PEImage::dataDirectoryEntryAddress): Returns the address of the data associated
with the given entry in the image's DataDirectory.

* platform/win/PEImage.h: Added.
(WebCore::PEImage::isValid): We're a valid image if the validation code in our constructor
succeeded, in which case m_ntHeaders will be set.

* platform/win/ImportedFunctionsEnumerator.cpp: Added. This class enumerates all the
functions imported by the image from a single module by walking the Import Name Table (INT)
and Import Address Table (IAT).
(WebCore::ImportedFunctionsEnumerator::ImportedFunctionsEnumerator): Initialize our members.
(WebCore::ImportedFunctionsEnumerator::isAtEnd): The INT and IAT are both 0-terminated
arrays.
(WebCore::ImportedFunctionsEnumerator::next): Step to the next entries in the INT and IAT.
(WebCore::ImportedFunctionsEnumerator::currentFunctionName): Gets the address of the
function's name, if possible, using the INT.
(WebCore::ImportedFunctionsEnumerator::addressOfCurrentFunctionPointer): Returns the address
of the function pointer for the current function. This function pointer is used whenever
code in m_image calls the current function. (A future patch will take advantage of this by
overwriting this function pointer with another, thereby redirecting calls to that function.)

* platform/win/ImportedFunctionsEnumerator.h: Added.

* platform/win/ImportedModulesEnumeratorBase.h: Added. This base class is used by
ImportedModulesEnumerator and DelayLoadedModulesEnumerator, and allows code to be written
that works with either one.

* platform/win/ImportedModulesEnumerator.cpp: Added. This class enumerates all the
non-delay-loaded modules imported by the image by walking the image's import array.
(WebCore::ImportedModulesEnumerator::ImportedModulesEnumerator): Module import information
is stored in the IMAGE_DIRECTORY_ENTRY_IMPORT entry of the image's DataDirectory.
(WebCore::ImportedModulesEnumerator::isAtEnd): The import array is 0-terminated.
(WebCore::ImportedModulesEnumerator::next): Steps along the import array.
(WebCore::ImportedModulesEnumerator::currentModuleName): Gets the address of the module's
name.
(WebCore::ImportedModulesEnumerator::functionsEnumerator): Get's the addresses of the INT
and IAT for this module and wraps them in an ImportedFunctionsEnumerator.

* platform/win/ImportedModulesEnumerator.h: Added.

* platform/win/DelayLoadedModulesEnumerator.cpp: Added. This class enumerates all the
delay-loaded modules that are imported by the given PEImage by walking the image's
ImageDelayDescr array.
(WebCore::DelayLoadedModulesEnumerator::DelayLoadedModulesEnumerator): Delay-load
information is stored in the IMAGE_DIRECTORY_ENTRY_DELAY_IMPORT entry of the image's
DataDirectory.
(WebCore::DelayLoadedModulesEnumerator::isAtEnd): The delay-loaded modules array is
0-terminated.
(WebCore::DelayLoadedModulesEnumerator::next): Steps along the delay-loaded modules array.
(WebCore::DelayLoadedModulesEnumerator::currentModuleName): Gets the address of the module's
name out of the descriptor.
(WebCore::DelayLoadedModulesEnumerator::functionsEnumerator): Gets the INT and IAT for the
current module out of the descriptor and makes an ImportedFunctionsEnumerator from them.
(WebCore::DelayLoadedModulesEnumerator::convertPotentialRVAToAddress): Pre-VC7.0 images
stored non-relative addresses in the ImageDelayDescr structures, while VC7.0 and later
images store RVAs. This function abstracts away the difference.

* platform/win/DelayLoadedModulesEnumerator.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a shared do-nothing window class that anyone can use
aroben@apple.com [Fri, 22 Apr 2011 16:44:57 +0000 (16:44 +0000)]
Add a shared do-nothing window class that anyone can use

Fixes <http://webkit.org/b/59102> WebKit has too many dummy window classes

Reviewed by Anders Carlsson.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Added DefWndProcWindowClass.{cpp,h}. Moved Arena.cpp out of
platform/win and into platform. Let VS reorder other files.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Changed to use the shared
dummy window class instead of creating our own.

* platform/win/DefWndProcWindowClass.cpp: Added.
(WebCore::registerClass): Register it!
(WebCore::defWndProcWindowClassName): Register it and return it!

* platform/win/DefWndProcWindowClass.h: Added.

Source/WebKit2:

Use WebCore's do-nothing window class instead of creating our own

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::createDummyWindow): Less code!

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 22 Apr 2011 16:39:47 +0000 (16:39 +0000)]
2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Cannot play flash with NSPluginWrapper
        https://bugs.webkit.org/show_bug.cgi?id=59125

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_GetValue): Handle the case when we have been
        called with a null plugin instance.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Apr 2011 16:25:11 +0000 (16:25 +0000)]
2011-04-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        LayoutTestResults should know how to handle NRWT json files
        https://bugs.webkit.org/show_bug.cgi?id=59168

        LayoutTestResults was originally created to be a parallel
        to existing NRWT architecture for dealing with results files.
        But then it turns out that NRWT has no such architecture. :(
        So this patch writes the necessary code to handle reading
        full_results.json and unexpected_results.json files from
        NRWT layout-test-results directories.

        LayoutTestResults has thus morphed from being ORWT-only to
        supporting both ORWT and NRWT.  It's possible at some future
        point that other pieces of the NRWT architecture will learn
        how to read JSON files in which case this can go away.

        This is all done for making it possible for the commit-queue
        to run the tests using NWRT and be able to understand the results
        (for flaky test reporting, etc.)

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
        * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 22 Apr 2011 16:13:22 +0000 (16:13 +0000)]
2011-04-21  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Content of <details> should be forwarded through the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59055

        * fast/html/details-add-child-1.html: Added.
        * fast/html/details-add-child-2.html: Added.
        * fast/html/details-remove-child-1.html: Added.
        * fast/html/details-remove-child-2.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/html/details-add-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-add-child-1-expected.png: Added.
        * platform/mac/fast/html/details-add-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-add-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-add-child-2-expected.png: Added.
        * platform/mac/fast/html/details-add-child-2-expected.txt: Added.
        * platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-1-expected.txt:
        * platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-10-expected.txt:
        * platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-2-expected.txt:
        * platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-3-expected.txt:
        * platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-4-expected.txt:
        * platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-5-expected.txt:
        * platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-6-expected.txt:
        * platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-7-expected.txt:
        * platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-8-expected.txt:
        * platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-9-expected.txt:
        * platform/mac/fast/html/details-add-summary-child-1-expected.txt:
        * platform/mac/fast/html/details-add-summary-child-2-expected.txt:
        * platform/mac/fast/html/details-no-summary1-expected.txt:
        * platform/mac/fast/html/details-no-summary2-expected.txt:
        * platform/mac/fast/html/details-no-summary3-expected.txt:
        * platform/mac/fast/html/details-no-summary4-expected.txt:
        * platform/mac/fast/html/details-open-javascript-expected.txt:
        * platform/mac/fast/html/details-open1-expected.txt:
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-open3-expected.txt:
        * platform/mac/fast/html/details-open4-expected.txt:
        * platform/mac/fast/html/details-open5-expected.txt:
        * platform/mac/fast/html/details-open6-expected.txt:
        * platform/mac/fast/html/details-position-expected.txt:
        * platform/mac/fast/html/details-remove-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-child-1-expected.png: Added.
        * platform/mac/fast/html/details-remove-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-remove-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-child-2-expected.png: Added.
        * platform/mac/fast/html/details-remove-child-2-expected.txt: Added.
        * platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-1-expected.txt:
        * platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-2-expected.txt:
        * platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-3-expected.txt:
        * platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-4-expected.txt:
        * platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-5-expected.txt:
        * platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-6-expected.txt:
        * platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
        * platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
        * platform/mac/fast/html/details-writing-mode-expected.txt:
2011-04-21  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Content of <details> should be forwarded through the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59055

        - Made ShadowContentElement abstract and added shouldInclude() pure virtual method.
        - Added SummaryContentElement, DetailsContentElement, DetailsSummaryElement as
          subclasses of ShadowContentElement.
        - Gave two shadow children for HTMLDetailsElement. One is DetailsContentElement, that
          handles non-summary contents of <details>. Another is SummaryContentElement, that
          handles the main summary element.
        - Removed most of RenderDetails custom layout mechanism, which is replaced by
          ShadowContentElement subclasses.

        Tests: fast/html/details-add-child-1.html
               fast/html/details-add-child-2.html
               fast/html/details-remove-child-1.html
               fast/html/details-remove-child-2.html

        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::contentContainerFor):
        (WebCore::ShadowRoot::hostChildrenChanged):
        (WebCore::ShadowRoot::hasContentElement):
        * dom/ShadowRoot.h:
        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsContentElement::DetailsContentElement):
        (WebCore::DetailsContentElement::create):
        (WebCore::DetailsContentElement::shouldInclude):
        (WebCore::DetailsSummaryElement::DetailsSummaryElement):
        (WebCore::DetailsSummaryElement::create):
        (WebCore::DetailsSummaryElement::shouldInclude):
        (WebCore::HTMLDetailsElement::create):
        (WebCore::HTMLDetailsElement::HTMLDetailsElement):
        (WebCore::HTMLDetailsElement::ensureShadowSubtreeOf):
        (WebCore::findSummaryFor):
        (WebCore::HTMLDetailsElement::ensureMainSummary):
        (WebCore::HTMLDetailsElement::refreshMainSummary):
        (WebCore::HTMLDetailsElement::createShadowSubtree):
        * html/HTMLDetailsElement.h:
        * html/HTMLSummaryElement.cpp:
        (WebCore::SummaryContentElement::SummaryContentElement):
        (WebCore::SummaryContentElement::shouldInclude):
        (WebCore::SummaryContentElement::create):
        (WebCore::HTMLSummaryElement::createShadowSubtree):
        * html/shadow/ShadowContentElement.h:
        * rendering/RenderDetails.cpp:
        (WebCore::RenderDetails::RenderDetails):
        (WebCore::RenderDetails::addChild):
        * rendering/RenderDetails.h:
        * rendering/RenderSummary.cpp:
        * rendering/RenderSummary.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 22 Apr 2011 15:51:24 +0000 (15:51 +0000)]
2011-04-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Extra GraphicsContext::save() in InlineTextBox::paintDecoration()
        https://bugs.webkit.org/show_bug.cgi?id=59109

        Remove an extraneous GraphicsContext::save() in InlineTextBox::paintDecoration().

        Add an assertion that fires when a GraphicsContext() is destroyed with a non-
        empty state stack. Fix canvas to avoid this assertion, since bad content might
        trigger it.

        Also add an assertion that fires for mismatched begin/endTransparencyLayers.

        Test: fast/text/multiple-text-shadow-alpha.html

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
        Make sure that the CanvasRenderingContext goes away before the ImageBuffer,
        so that CanvasRenderingContext2D has a chance to unwind the state stack in
        the ImageBuffer's GraphicsContext.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
        Balance unmatched state saves in the canvas context.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::~GraphicsContext):
        Assert that the stack is empty.

        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
        (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
        Changes to allow for asserting for unmatched transparency layer begin/ends.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDecoration):
        Remove an unbalanced save().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows DRT needs an implementation of shadowRoot.
jberlin@webkit.org [Fri, 22 Apr 2011 15:39:45 +0000 (15:39 +0000)]
Windows DRT needs an implementation of shadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=59081

Add media/audio-controls-do-not-fade-out.html, which uses layoutTestController.shadowRoot
to the win Skipped list to get the bots green.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 22 Apr 2011 15:34:21 +0000 (15:34 +0000)]
2011-04-22  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add Save As context menu item to the TextViewer.
        https://bugs.webkit.org/show_bug.cgi?id=59196

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceSourceFrame.prototype.requestContent):
        (WebInspector.ResourceSourceFrame.prototype.suggestedFileName):
        (WebInspector.RevisionSourceFrame.prototype.requestContent):
        (WebInspector.RevisionSourceFrame.prototype.suggestedFileName):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.SourceFrameDelegateForScriptsPanel):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._initializeTextViewer):
        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
        (WebInspector.SourceFrame.prototype.suggestedFileName):
        (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
        (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._contextMenu):
        (WebInspector.TextViewerDelegate.prototype.cancelEditing):
        (WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
        (WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
        (WebInspector.TextViewerDelegate.prototype.suggestedFileName):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate the Windows-specific results after r84558.
jberlin@webkit.org [Fri, 22 Apr 2011 15:21:45 +0000 (15:21 +0000)]
Update the Windows-specific results after r84558.

* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Fri, 22 Apr 2011 14:43:07 +0000 (14:43 +0000)]
2011-04-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Upstream Symbian platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=58435

        Upstream Symbian platform plugin.

        * Source/WebKit.pro: Add platformplugin path to the SUBDIRS.
2011-04-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Upstream Symbian platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=58435

        Upstream Symbian platform plugin.

        * QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
        * symbian/platformplugin: Added.
        * symbian/platformplugin/WebPlugin.cpp: Added.
        (ItemListDelegate::ItemListDelegate):
        (ItemListDelegate::paint):
        (Popup::Popup):
        (Popup::resizeEvent):
        (Popup::populateList):
        (Popup::onItemSelected):
        (Popup::updateSelectionsBeforeDialogClosing):
        (Popup::updateAndClose):
        (WebPopup::WebPopup):
        (WebPopup::~WebPopup):
        (WebPopup::createSingleSelectionPopup):
        (WebPopup::createMultipleSelectionPopup):
        (WebPopup::createPopup):
        (WebPopup::show):
        (WebPopup::hide):
        (WebPopup::popupClosed):
        (WebPopup::itemClicked):
        (SingleSelectionPopup::SingleSelectionPopup):
        (MultipleSelectionPopup::MultipleSelectionPopup):
        (WebNotificationPresenter::showNotification):
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * symbian/platformplugin/WebPlugin.h: Added.
        (Popup::preSelectedIndices):
        (Popup::listWidget):
        (WebNotificationPresenter::WebNotificationPresenter):
        (WebNotificationPresenter::~WebNotificationPresenter):
        * symbian/platformplugin/platformplugin.pro: Added.
        * symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
        (QWebSelectData::~QWebSelectData):
        (QWebSelectMethod::~QWebSelectMethod):
        (QWebNotificationData::~QWebNotificationData):
        (QWebNotificationPresenter::QWebNotificationPresenter):
        (QWebNotificationPresenter::~QWebNotificationPresenter):
        (QWebTouchModifier::~QWebTouchModifier):
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
        (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
2011-04-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Upstream Symbian platform plugin
        https://bugs.webkit.org/show_bug.cgi?id=58435

        Exempting directory WebKit/qt/symbian/platformplugin from style guide.

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 22 Apr 2011 13:52:13 +0000 (13:52 +0000)]
2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59094

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * gyp/streamline-inspector-source.sh:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype.dispose):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
        (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        (MixInSnapshotNodeFunctions):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.dispose):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.searchCancelled):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder):
        (WebInspector.DetailedHeapshotView.prototype.dispose):
        (WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
        (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotLoader):
        (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
        (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
        (WebInspector.HeapSnapshot.prototype.pushBaseIds):
        (WebInspector.HeapSnapshot.prototype.createDiff):
        (WebInspector.HeapSnapshot.prototype._parseFilter):
        (WebInspector.HeapSnapshot.prototype.createEdgesProvider):
        (WebInspector.HeapSnapshot.prototype.createNodesProvider):
        (WebInspector.HeapSnapshot.prototype.createPathFinder):
        (WebInspector.HeapSnapshot.prototype.updateStaticData):
        (WebInspector.HeapSnapshotPathFinder):
        (WebInspector.HeapSnapshotPathFinder.prototype.updateRoots):
        (WebInspector.HeapSnapshotPathFinder.prototype._reset):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotRealWorker):
        (WebInspector.HeapSnapshotRealWorker.prototype._messageReceived):
        (WebInspector.HeapSnapshotRealWorker.prototype.postMessage):
        (WebInspector.HeapSnapshotRealWorker.prototype.terminate):
        (WebInspector.HeapSnapshotFakeWorker):
        (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
        (WebInspector.HeapSnapshotFakeWorker.prototype.terminate):
        (WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):
        (WebInspector.HeapSnapshotWorker):
        (WebInspector.HeapSnapshotWorker.prototype.createObject):
        (WebInspector.HeapSnapshotWorker.prototype.dispose):
        (WebInspector.HeapSnapshotWorker.prototype.disposeObject):
        (WebInspector.HeapSnapshotWorker.prototype.callGetter):
        (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod.wrapCallback):
        (WebInspector.HeapSnapshotWorker.prototype.callFactoryMethod):
        (WebInspector.HeapSnapshotWorker.prototype.callMethod):
        (WebInspector.HeapSnapshotWorker.prototype._findFunction):
        (WebInspector.HeapSnapshotWorker.prototype._messageReceived):
        (WebInspector.HeapSnapshotWorker.prototype._postMessage):
        (WebInspector.HeapSnapshotProxyObject):
        (WebInspector.HeapSnapshotProxyObject.prototype._callWorker):
        (WebInspector.HeapSnapshotProxyObject.prototype.dispose):
        (WebInspector.HeapSnapshotProxyObject.prototype.disposeWorker):
        (WebInspector.HeapSnapshotProxyObject.prototype.callFactoryMethod):
        (WebInspector.HeapSnapshotProxyObject.prototype.callGetter):
        (WebInspector.HeapSnapshotProxyObject.prototype.callMethod):
        (WebInspector.HeapSnapshotLoaderProxy):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
        (WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
        (WebInspector.HeapSnapshotProxy):
        (WebInspector.HeapSnapshotProxy.prototype.aggregates):
        (WebInspector.HeapSnapshotProxy.prototype.createDiff):
        (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.createPathFinder):
        (WebInspector.HeapSnapshotProxy.prototype.dispose):
        (WebInspector.HeapSnapshotProxy.prototype.finishLoading):
        (WebInspector.HeapSnapshotProxy.prototype.get loaded):
        (WebInspector.HeapSnapshotProxy.prototype.get nodeCount):
        (WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex):
        (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotProxy.prototype.get rootNodeIndex):
        (WebInspector.HeapSnapshotProxy.prototype.updateStaticData):
        (WebInspector.HeapSnapshotProxy.prototype.startLoading):
        (WebInspector.HeapSnapshotProxy.prototype.get totalSize):
        (WebInspector.HeapSnapshotProxy.prototype.get uid):
        (WebInspector.HeapSnapshotProviderProxy):
        (WebInspector.HeapSnapshotProviderProxy.prototype.isEmpty):
        (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
        (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotPathFinderProxy):
        (WebInspector.HeapSnapshotPathFinderProxy.prototype.findNext):
        (WebInspector.HeapSnapshotPathFinderProxy.prototype.updateRoots):
        (WebInspector.HeapSnapshotsDiffProxy):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.calculate):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
        * inspector/front-end/HeapSnapshotWorker.js: Added.
        (WebInspector.UIString):
        (postMessageWrapper):
        * inspector/front-end/HeapSnapshotWorkerDispatcher.js: Added.
        (WebInspector.HeapSnapshotWorkerDispatcher):
        (WebInspector.HeapSnapshotWorkerDispatcher.prototype._findFunction):
        (WebInspector.HeapSnapshotWorkerDispatcher.prototype.dispatchMessage):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59094

        * WebKit.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 22 Apr 2011 13:49:04 +0000 (13:49 +0000)]
2011-04-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix de-obfuscation of scripts inlined in html.
        https://bugs.webkit.org/show_bug.cgi?id=58538

        * inspector/debugger/resources/obfuscated.js:
        * inspector/debugger/script-formatter-expected.txt:
        * inspector/debugger/script-formatter.html: Renamed from LayoutTests/inspector/debugger/script-formatter.html-disabled.
2011-04-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix de-obfuscation of scripts inlined in html.
        https://bugs.webkit.org/show_bug.cgi?id=58538

        Use html tokenizer to find script boundaries instead of relying on scriptParsed events.

        Test: inspector/debugger/script-formatter.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/JavaScriptFormatter.js: Renamed from Source/WebCore/inspector/front-end/UglifyJS/JavaScriptFormatter.js.
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter):
        (WebInspector.ScriptFormatter.prototype.formatContent):
        (WebInspector.ScriptFormatter.prototype._didFormatContent):
        * inspector/front-end/ScriptFormatterWorker.js:
        (onmessage):
        (formatScript):
        (HTMLScriptFormatter):
        (HTMLScriptFormatter.prototype.format):
        (HTMLScriptFormatter.prototype.scriptStarted):
        (HTMLScriptFormatter.prototype.scriptEnded):
        (HTMLScriptFormatter.prototype.styleSheetStarted):
        (HTMLScriptFormatter.prototype.styleSheetEnded):
        * inspector/front-end/SourceFile.js:
        (WebInspector.FormattedSourceFile.prototype._didRequestContent):
        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer.prototype.scriptStarted):
        (WebInspector.SourceHTMLTokenizer.prototype.scriptEnded):
        (WebInspector.SourceHTMLTokenizer.prototype.styleSheetStarted):
        (WebInspector.SourceHTMLTokenizer.prototype.styleSheetEnded):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:
        * inspector/front-end/WebKit.qrc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 22 Apr 2011 13:36:51 +0000 (13:36 +0000)]
2011-04-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] misc API cleanup
        https://bugs.webkit.org/show_bug.cgi?id=59194

        * inspector/front-end/ExtensionAPISchema.json:
        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionSidebarPane.prototype._setObject):

2011-04-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] misc API cleanup
        https://bugs.webkit.org/show_bug.cgi?id=59194

        * src/js/DevTools.js:
        (WebInspector.platformExtensionAPI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 22 Apr 2011 13:18:13 +0000 (13:18 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: group content scripts in the scripts panel drop down.
        https://bugs.webkit.org/show_bug.cgi?id=59108

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Mike West <mkwst@google.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 12:38:56 +0000 (12:38 +0000)]
2011-04-22  Mike West  <mkwst@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Tiny improvement to UI for adding an XHR breakpoint
        https://bugs.webkit.org/show_bug.cgi?id=59100

        Improve web inspector UI around adding XHR breakpoints by adding
        a textual label to the input-like `span` used to specify which
        XHR requests the breakpoint ought to target.

        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
        (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
        * inspector/front-end/inspector.css:
        (#breakpoint-condition-input):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Apr 2011 12:35:29 +0000 (12:35 +0000)]
2011-04-22  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. Build fix for ENABLE(INTERPRETER) after r84556.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitAggregate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 22 Apr 2011 12:34:33 +0000 (12:34 +0000)]
2011-04-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: js formatter should never insert new tokens or remove existing tokens and comments.
        https://bugs.webkit.org/show_bug.cgi?id=59191

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
        (WebInspector.ScriptFormatter.prototype.formatContent):
        * inspector/front-end/ScriptFormatterWorker.js:
        (onmessage):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype._loadResourceContent):
        (WebInspector.FormattedSourceFile.prototype._didRequestContent):
        (WebInspector.FormattedSourceMapping):
        (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
        (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):
        (WebInspector.FormattedSourceMapping.prototype._convertPosition):
        * inspector/front-end/UglifyJS/JavaScriptFormatter.js: Added.
        (FormattedContentBuilder): Helper class for building formatted script content.
        (FormattedContentBuilder.prototype.addToken):
        (FormattedContentBuilder.prototype.addSpace):
        (FormattedContentBuilder.prototype.addNewLine):
        (FormattedContentBuilder.prototype.increaseNestingLevel):
        (FormattedContentBuilder.prototype.decreaseNestingLevel):
        (FormattedContentBuilder.prototype.content):
        (FormattedContentBuilder.prototype.mapping):
        (Tokenizer): Wrapper class for UglifyJS tokenizer.
        (Tokenizer.prototype.content):
        (Tokenizer.prototype.next):
        (Tokenizer.prototype._convertUglifyToken):
        (JavaScriptFormatter): New formatter based on UglifyJS tokenizer.
        (JavaScriptFormatter.prototype.format):
        * inspector/front-end/UglifyJS/process.js: Removed.
        * inspector/front-end/WebKit.qrc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 22 Apr 2011 12:32:14 +0000 (12:32 +0000)]
2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59189

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/BinarySearch.js: Added.
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
        (WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
        (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
        (WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
        (WebInspector.HeapSnapshotDiffNode.prototype.get data):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.sort):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
        (WebInspector.HeapSnapshotContainmentDataGrid):
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.setDataSource):
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
        (WebInspector.HeapSnapshotDominatorsDataGrid):
        (WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
        (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._performSorting):
        (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
        (WebInspector.DetailedHeapshotView.prototype._changeBase):
        (WebInspector.DetailedHeapshotView.prototype._changeView):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshot.prototype.dispose):
        (WebInspector.HeapSnapshot.prototype.pushBaseNodeIds):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):
        (WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
        (WebInspector.HeapSnapshotsDiff.prototype.calculate):
        (WebInspector.HeapSnapshotsDiff.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotsDiff.prototype.pushBaseSelfSizes):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
        (WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotProviderProxy):
        (WebInspector.HeapSnapshotProviderProxy.prototype.serializeNextItems):
        (WebInspector.HeapSnapshotProviderProxy.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
        (WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
        * inspector/front-end/PleaseWaitMessage.js:
        (WebInspector.PleaseWaitMessage.prototype.showAndWaitFor):
        (WebInspector.PleaseWaitMessage.prototype.unlistenAndHide):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/utilities.js:

2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor code prior to moving detailed heap snapshots into workers.
        https://bugs.webkit.org/show_bug.cgi?id=59189

        * inspector/profiler/detailed-heapshots-comparison-sorting.html:
        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest):
        (initialize_DetailedHeapshotTest.):
        * inspector/profiler/heap-snapshot-expected.txt:
        * inspector/profiler/heap-snapshot.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 22 Apr 2011 12:18:09 +0000 (12:18 +0000)]
2011-04-22  Mikhail Naganov  <mnaganov@chromium.org>

        Unreviewed fix after r84484 -- conditional statement was inverted incorrectly.

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.handleShortcut):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Fri, 22 Apr 2011 12:10:21 +0000 (12:10 +0000)]
2011-04-22  Csaba Osztrogonác  <ossy@webkit.org>

        [WK2] CSP reporting doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=59192

        * platform/mac-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt]fast/url/idna tests fail
ossy@webkit.org [Fri, 22 Apr 2011 11:24:29 +0000 (11:24 +0000)]
[Qt]fast/url/idna tests fail
https://bugs.webkit.org/show_bug.cgi?id=59187

* platform/qt/Skipped: Add fast/url/idna2003.html and fast/url/idna2008.html.
* platform/qt/fast/url/path-expected.txt: Update after r84606.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 22 Apr 2011 10:39:30 +0000 (10:39 +0000)]
2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] Qt should use the mac-wk2 skipped list
        https://bugs.webkit.org/show_bug.cgi?id=58536

        * Scripts/old-run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Fri, 22 Apr 2011 10:04:50 +0000 (10:04 +0000)]
2011-04-22  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Timeline is too narrow
        https://bugs.webkit.org/show_bug.cgi?id=58399

        Changed Network Panel widths so that Timeline is 50%.
        Added titles to the values in the other columns, so that a tooltip will show the value if the column is too narrow.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._createTable):  Changed column widths.
        (WebInspector.NetworkPanel.prototype._toggleGridMode): Changed column widths.
        (WebInspector.NetworkDataGridNode.prototype.refreshResource): Added titles to column values.
        (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): Ditto
        (WebInspector.NetworkDataGridNode.prototype._refreshSizeCell): Ditto
        (WebInspector.NetworkDataGridNode.prototype._refreshTimeCell): Ditto
        * inspector/front-end/utilities.js:
        (Element.prototype.setTextAndTitle): Added new method to set the textContent and title of an Element at the same time, so that it can have a tooltip.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Fri, 22 Apr 2011 09:34:21 +0000 (09:34 +0000)]
2011-04-22  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Sam Weinig.

        [Qt][WK2] Implement DrawingAreaImpl for Qt.
        https://bugs.webkit.org/show_bug.cgi?id=59171

        * WebKit2.pro: Build files necessary for DrawingAreaImpl.
        * DerivedSources.pro: Build message receivers for DrawingArea and DrawingAreaProxy.

        * Shared/qt/LayerTreeContextQt.cpp:
        (WebKit::LayerTreeContext::LayerTreeContext): Stub.
        (WebKit::LayerTreeContext::~LayerTreeContext): Stub.
        (WebKit::LayerTreeContext::encode): Stub.
        (WebKit::LayerTreeContext::decode): Stub.
        (WebKit::LayerTreeContext::isEmpty): Stub.
        (WebKit::operator==): Stub.

        * Shared/qt/ShareableBitmapQt.cpp:
        (WebKit::ShareableBitmap::paint): Don't translate the painter to accomodate the
        source rect. The rect is already adjusted at the call site.

        * UIProcess/API/qt/qgraphicswkview.h: Add "Impl" to QGraphicsWKView::BackingStoreType.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::createDrawingAreaProxy): Create DrawingAreaProxyImpl if requested.
        (QWKPagePrivate::paint): Call the correct paint() method for DrawingAreaProxyImpl,
        since this drawing area will simple ASSERT_NOT_REACHED() in the "normal" paint().

        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create): Allow creation of DrawingAreaImpl for Qt.

        * UIProcess/BackingStore.h: Add Qt-specific types and backing store.

        * UIProcess/qt/BackingStoreQt.cpp:
        (WebKit::BackingStore::paint): Implemented.
        (WebKit::BackingStore::incorporateUpdate): Implemented.
        (WebKit::BackingStore::scroll): Implemented using QPixmap::scroll().

        * UIProcess/DrawingAreaProxy.h: Enable drawing area message receivers for Qt.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage): Ditto.
        * WebProcess/WebPage/DrawingArea.h: Ditto.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didReceiveMessage): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWinCairo build fix. Unreviewed.
jhoneycutt@apple.com [Fri, 22 Apr 2011 09:10:54 +0000 (09:10 +0000)]
WinCairo build fix. Unreviewed.

* WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::useCredential):
Stubbed.
(WebKit::Download::continueWithoutCredential):
Stubbed.
(WebKit::Download::cancelAuthenticationChallenge):
Stubbed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing...
mitz@apple.com [Fri, 22 Apr 2011 08:31:42 +0000 (08:31 +0000)]
<rdar://problem/9322486> REGRESSION (r83397): Default controls fade out when playing audio-only media
https://bugs.webkit.org/show_bug.cgi?id=59180

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/audio-controls-do-not-fade-out.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Only start fading out the controls if there is
a video track.

LayoutTests:

* media/audio-controls-do-not-fade-out-expected.txt: Added.
* media/audio-controls-do-not-fade-out.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to support authentication for downloads in WebKit2 on Windows
jhoneycutt@apple.com [Fri, 22 Apr 2011 07:40:51 +0000 (07:40 +0000)]
Need to support authentication for downloads in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=59175
<rdar://problem/9206151>
<rdar://problem/8958280>

Reviewed by Maciej Stachowiak.

* WebProcess/Downloads/Download.cpp:
Include DownloadAuthenticationClient.h.

* WebProcess/Downloads/Download.h:
Declare a function to get or create the authentication client, a member
var to hold it, and functions that the client can call to use a
credential, continue without a credential, or cancel an auth challenge.

* WebProcess/Downloads/DownloadAuthenticationClient.cpp: Added.
(WebKit::DownloadAuthenticationClient::DownloadAuthenticationClient):
(WebKit::DownloadAuthenticationClient::receivedCredential):
Tell the Download to use the credential.
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
Tell the Download to continue with credentials.
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Tell the Download to cancel the challenge.

* WebProcess/Downloads/DownloadAuthenticationClient.h: Added.
(WebKit::DownloadAuthenticationClient::create):
Return a new DownloadAuthenticationClient.
(WebKit::DownloadAuthenticationClient::detach):
Clear the Download.
(WebKit::DownloadAuthenticationClient::refAuthenticationClient):
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient):

* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
Create a CFURLCredentialRef from the WebCore credential, and tell
CFNetwork to use it for the auth challenge.
(WebKit::Download::continueWithoutCredential):
Call CFURLDownloadUseCredential with a null credential.
(WebKit::Download::cancelAuthenticationChallenge):
Cancel the download, and clear m_download.
(WebKit::Download::authenticationClient):
Create if needed and return a DownloadAuthenticationClient.
(WebKit::Download::platformInvalidate):
Detach the DownloadAuthenticationClient.
(WebKit::didReceiveAuthenticationChallengeCallback):
Call Download::didReceiveAuthenticationChallenge(), passing a
WebCore::AuthenticationChallenge with our DownloadAuthenticationClient.
(WebKit::Download::receivedCredential):
Get the client from the auth challenge, and call through to it.
(WebKit::Download::receivedRequestToContinueWithoutCredential):
Ditto.
(WebKit::Download::receivedCancellation):
Ditto.

* win/WebKit2.vcproj:
Add new files to project.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Fri, 22 Apr 2011 07:40:32 +0000 (07:40 +0000)]
2011-04-22  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Add FontItalics and FontSmallCaps enums to be used instead of boolean values.
        https://bugs.webkit.org/show_bug.cgi?id=59080

        No new tests as no new functionality added.

        * css/CSSPrimitiveValueMappings.h:
        Add casts to/from FontItalics and FontSmallCaps
        * css/CSSStyleSelector.cpp:
        Use new casts defined in PrimitiveValueMappings.h
        * platform/graphics/Font.h:
        Use FontItalics enum.
        * platform/graphics/FontDescription.h:
        Define and use FontItalics and FontSmallCaps enums.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 22 Apr 2011 07:23:12 +0000 (07:23 +0000)]
2011-04-22  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        address maciej's styling feedback for results.html page
        https://bugs.webkit.org/show_bug.cgi?id=59165

        * fast/harness/results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 22 Apr 2011 07:09:30 +0000 (07:09 +0000)]
2011-04-21  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: exception in front-end when user selects resource info for resource that does not have response headers yet
        https://bugs.webkit.org/show_bug.cgi?id=59123

        * inspector/front-end/ResourceCookiesView.js:
        (WebInspector.ResourceCookiesView):
        (WebInspector.ResourceCookiesView.prototype.show):
        (WebInspector.ResourceCookiesView.prototype.get _gotCookies):
        (WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Chris Weber <chris@lookout.net>
commit-queue@webkit.org [Fri, 22 Apr 2011 06:46:13 +0000 (06:46 +0000)]
2011-04-21  Chris Weber  <chris@lookout.net>

        Reviewed by Adam Barth.

        Add more test coverage to fast/url
        https://bugs.webkit.org/show_bug.cgi?id=59142

        The PASS/FAIL results for host, path, and port are set to match
        Chromium.  The PASS/FAIL results for idna2003 and idna2008 are set to
        match those specifications.

        * fast/url/host-expected.txt:
        * fast/url/idna2003-expected.txt: Added.
        * fast/url/idna2003.html: Added.
        * fast/url/idna2008-expected.txt: Added.
        * fast/url/idna2008.html: Added.
        * fast/url/path-expected.txt:
        * fast/url/port-expected.txt:
        * fast/url/script-tests/host.js:
        * fast/url/script-tests/idna2003.js: Added.
        * fast/url/script-tests/idna2008.js: Added.
        * fast/url/script-tests/path.js:
        * fast/url/script-tests/port.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 06:37:57 +0000 (06:37 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Reviewed by Mihai Parparita.

        Remove find-mismatched-layout-test-results since it's not needed in a
        checksum free world.
        https://bugs.webkit.org/show_bug.cgi?id=59156

        * Scripts/find-mismatched-layout-test-results: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=57898
bdakin@apple.com [Fri, 22 Apr 2011 06:29:48 +0000 (06:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57898
REGRESSION (r82185): Scroll position not restored on navigation back to a page in
the page cache
-and corresponding-
<rdar://problem/9226652>

Reviewed by Dan Bernstein.

Source/WebCore:

The original fix for this change broke scroll-position restore for pages that are
*not* in the page cache. This patch fixes both cached and non-cached pages by
using the cachedScrollPosition() only for cached pages.
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

LayoutTests:

* fast/loader/scroll-position-restored-on-back-non-cached-expected.txt: Added.
* fast/loader/scroll-position-restored-on-back-non-cached.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Fri, 22 Apr 2011 06:13:50 +0000 (06:13 +0000)]
2011-04-21  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Remove redundant calls to RenderStyle::setDisplay()
        https://bugs.webkit.org/show_bug.cgi?id=59060

        No new tests / no new functionality added.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Remove redundant calls to RenderStyle::setDisplay()

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 John Bauman <jbauman@chromium.org>
commit-queue@webkit.org [Fri, 22 Apr 2011 06:08:25 +0000 (06:08 +0000)]
2011-04-21  John Bauman  <jbauman@chromium.org>

        Reviewed by Kenneth Russell.

        WebGL context drawing buffer may not be cleared if FBO bound
        https://bugs.webkit.org/show_bug.cgi?id=58956

        Clear the drawing buffer even if it's not currently bound, by
        switching between FBOs around the clear. Also, make sure that we
        handle depth and stencil masks properly.

        No new tests, because testing this under DRT doesn't work.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::initializeNewContext):
        (WebCore::WebGLRenderingContext::clearIfComposited):
        (WebCore::WebGLRenderingContext::depthMask):
        * html/canvas/WebGLRenderingContext.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach build-webkit and update-webkit that the WinCairo port does
bfulgham@webkit.org [Fri, 22 Apr 2011 05:37:07 +0000 (05:37 +0000)]
Teach build-webkit and update-webkit that the WinCairo port does
not need the non-redistributable WebKitSupportLibraries.zip file.
Also append the _Cairo_CFLite label to the build target for the
default (no argument) case when building with '--wincairo'

Reviewed by Martin Robinson.

https://bugs.webkit.org/show_bug.cgi?id=58801

* Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip
  doesn't exist.
* Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default
  'Release' build target when passed the '--wincairo' flag.
* Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip
  doesn't exist.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
cfleizach@apple.com [Fri, 22 Apr 2011 05:01:14 +0000 (05:01 +0000)]
WebKit is erroneously modifying the DOM; adding 'aria-selected' to tables
https://bugs.webkit.org/show_bug.cgi?id=59140

Reviewed by Beth Dakin.

Source/WebCore:

WebKit should not modify the DOM when the screen reader requests certain things be set. There is no
specification that allows this behavior yet, but we are working on something for the future.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::setSelected):
(WebCore::AccessibilityRenderObject::setValue):

LayoutTests:

* accessibility/aria-combobox.html:
* platform/mac/accessibility/aria-combobox-expected.txt:
* platform/mac/accessibility/aria-slider-value-change-expected.txt:
* platform/mac/accessibility/aria-slider-value-change.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 04:54:19 +0000 (04:54 +0000)]
2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84583.
        http://trac.webkit.org/changeset/84583
        https://bugs.webkit.org/show_bug.cgi?id=59173

        "broke
        http://trac.webkit.org/export/84593/trunk/LayoutTests/fast/js
        /Object-create.html" (Requested by ggaren on #webkit).

        * runtime/ObjectConstructor.cpp:
        (JSC::objectConstructorCreate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Minimize synchronous calls during loading
ap@apple.com [Fri, 22 Apr 2011 04:26:17 +0000 (04:26 +0000)]
    Minimize synchronous calls during loading
        https://bugs.webkit.org/show_bug.cgi?id=59169

        <rdar://problem/9320128> REGRESSION(r84526): WK2 windows unresponsive

        * UIProcess/API/mac/WKView.mm:
        (-[WKView resignFirstResponder]):
        (-[WKView _resetTextInputState]):
        Made _resetTextInputState deal with client side state only, letting Editor composition be
        discarded more discriminately.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 03:45:28 +0000 (03:45 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change - new baselines needed as
        a result of r84589.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 03:29:59 +0000 (03:29 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
        https://bugs.webkit.org/show_bug.cgi?id=58758

        Since worker_mixin is now only used by worker, there's no point
        in having it split across two files.

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
        * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
        * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 03:28:23 +0000 (03:28 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
        https://bugs.webkit.org/show_bug.cgi?id=58756

        Since worker_mixin is now only used by worker, there's no point
        in having it split across two files.

        * Scripts/webkitpy/layout_tests/layout_package/worker.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 03:26:50 +0000 (03:26 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
        https://bugs.webkit.org/show_bug.cgi?id=58754

        test_runner hasn't been a great name for some time, since all of
        the test running is actually done in worker and
        single_test_runner. Rename to manager to match the terminology
        elsewhere.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
        * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: order AccessibilityRole alphabetically
cfleizach@apple.com [Fri, 22 Apr 2011 03:13:40 +0000 (03:13 +0000)]
AX: order AccessibilityRole alphabetically
https://bugs.webkit.org/show_bug.cgi?id=31524

Reviewed by Beth Dakin.

Source/WebCore:

* accessibility/AccessibilityObject.h:

Source/WebKit/chromium:

* public/WebAccessibilityRole.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 02:49:05 +0000 (02:49 +0000)]
2011-04-21  Jia Pu  <jpu@apple.com>

        Reviewed by Maciej Stachowiak.

        [Mac] correctionPanelTimerFired() crashes due to rangeToBeReplaced being cleared.
        https://bugs.webkit.org/show_bug.cgi?id=59155
        <rdar://problem/9261698>

        Make sure the range isn't cleared before calling windowRectForRange() on it. Also removed unused functions in Editor.h,
        and fixed a typo in function name.

        * editing/Editor.h:
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::correctionPanelTimerFired):
        (WebCore::SpellingCorrectionController::respondToChangedSelection):
        * editing/SpellingCorrectionController.h:
        (WebCore::SpellingCorrectionController::shouldStartTimerFor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 02:48:49 +0000 (02:48 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: obsolete old threading code, part 2
        https://bugs.webkit.org/show_bug.cgi?id=58753

        This merges the test_runner2 code back into test_runner since
        there's only a single type of test runner now.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 02:41:24 +0000 (02:41 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Triage failure for
        media/video-zoom.html on chromium gpu bots.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 22 Apr 2011 02:30:37 +0000 (02:30 +0000)]
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        * configure.ac:
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        * Configurations/FeatureDefines.xcconfig:
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        * features.gypi:
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        * Configurations/FeatureDefines.xcconfig:
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        No new tests; no behavior change.

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * features.pri:
        * html/HTMLDetailsElement.cpp:
        * html/HTMLSummaryElement.cpp:
        * html/HTMLTagNames.in:
        * html/shadow/DetailsMarkerControl.cpp:
        * rendering/RenderBlock.cpp:
        (WebCore::canMergeContiguousAnonymousBlocks):
        * rendering/RenderDetails.cpp:
        * rendering/RenderDetails.h:
        * rendering/RenderDetailsMarker.cpp:
        * rendering/RenderDetailsMarker.h:
        * rendering/RenderObject.h:
        * rendering/RenderSummary.cpp:
        * rendering/RenderSummary.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::RenderTreeAsText::writeRenderObject):
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        * Configurations/FeatureDefines.xcconfig:
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        * Scripts/build-webkit:
        * Tools.pro:
2011-04-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        Add a feature define to allow <details> and <summary> to be disabled
        https://bugs.webkit.org/show_bug.cgi?id=59118
        <rdar://problem/9257045>

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 02:29:14 +0000 (02:29 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Suppress failures on chromium
        win/linux from bug 59166.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 22 Apr 2011 02:01:25 +0000 (02:01 +0000)]
2011-04-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adele Peterson.

        REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
        https://bugs.webkit.org/show_bug.cgi?id=59053

        * fast/events/shadow-boundary-crossing-expected.txt: Updated expected results.
        * fast/events/shadow-boundary-crossing.html: Added new sub-test.
2011-04-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adele Peterson.

        REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
        https://bugs.webkit.org/show_bug.cgi?id=59053

        Turns out, the relatedTarget of an event could be also an ancestor of an event,
        not just its parent. Duh.

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost
            explicitly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 22 Apr 2011 01:42:11 +0000 (01:42 +0000)]
2011-04-21  Michael Saboff  <msaboff@apple.com>

        Reviewed by Maciej Stachowiak.

        Qualified names used for all TagName access, yet namespace usage is rare
        https://bugs.webkit.org/show_bug.cgi?id=58997

        The methods getElementsByTagName and getElementsByTagNameNS where
        always creating and using QualifiedNames.  QualifiedName::init
        was consistently in the top 3 routines when running the Dromaeo
        DOM-query benchmark.  Split out the functionality so that
        getElementsByTagName uses just the local name, an implied "*"
        namespace and a separate TagNodeListCache keyed by an atomic name
        instead of a QualifiedName.  Access to elements via
        getElementsByTagNameNS that have "*" namespace are forwarded to
        getElementsByTagName as well.  This provides ~10% speed up in that
        Dromaeo test.

        No new tests added, existing tests have coverage.  The changes are
        an optimization of existing functionality.

        * dom/Node.cpp:
        (WebCore::Node::removeCachedTagNodeList):
        (WebCore::Node::getElementsByTagName):
        (WebCore::Node::getElementsByTagNameNS):
        (WebCore::NodeListsNodeData::invalidateCaches):
        (WebCore::NodeListsNodeData::isEmpty):
        * dom/Node.h:
        * dom/NodeRareData.h:
        * dom/TagNodeList.cpp:
        (WebCore::TagNodeList::~TagNodeList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Apr 2011 01:31:10 +0000 (01:31 +0000)]
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        WinCE build fix after r84574.

        * WebCoreSupport/EditorClientWinCE.cpp:
        (WebKit::EditorClientWinCE::canCopyCut):
        (WebKit::EditorClientWinCE::canPaste):
        * WebCoreSupport/EditorClientWinCE.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 22 Apr 2011 01:30:51 +0000 (01:30 +0000)]
2011-04-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: more style- and node-related stuff
        https://bugs.webkit.org/show_bug.cgi?id=59127

        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        (WebCore::JSCanvasRenderingContextOwner::isReachableFromOpaqueRoots):
        (WebCore::JSCanvasRenderingContextOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext): Use opaque roots for marking canvas rendering
        contexts, so JSNode isn't responsible for it.

        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::markChildren):
        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        * bindings/js/JSHTMLLinkElementCustom.cpp:
        * bindings/js/JSHTMLStyleElementCustom.cpp: Removed obsolete marking code.

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::isObservable):
        (WebCore::isReachableFromDOM):
        (WebCore::JSNodeOwner::isReachableFromOpaqueRoots): Removed a bunch of
        CSS object model related special cases, since the CSS object model
        now tracks its own lifetime through the opaque roots system. Removed
        canvas special case, covered above.

        * bindings/js/JSProcessingInstructionCustom.cpp:
        * bindings/js/JSWebKitAnimationListCustom.cpp:
        * dom/ProcessingInstruction.idl:
        * html/HTMLCanvasElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLStyleElement.idl:
        * page/WebKitAnimationList.idl: Removed obsolete marking code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 22 Apr 2011 01:30:50 +0000 (01:30 +0000)]
2011-04-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Object.create creates uncachable objects
        https://bugs.webkit.org/show_bug.cgi?id=59164

        Use the prototype object's inheritorID, as we
        should always have done

        * runtime/ObjectConstructor.cpp:
        (JSC::objectConstructorCreate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Fri, 22 Apr 2011 01:05:42 +0000 (01:05 +0000)]
2011-04-21  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Only update the contents of layers that are going to
        be drawn. Remove individual texture unreserves that happen
        after the layer draw calls with a single unreserve for all the
        textures in the texture manager.
        https://bugs.webkit.org/show_bug.cgi?id=59129

        Tests: No new functionality.  Covered by existing layout tests.

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::paintContentsIfDirty):
        (WebCore::ImageLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::paintLayerContents):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTexture.cpp:
        * platform/graphics/chromium/LayerTexture.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
        (WebCore::RenderSurfaceChromium::drawSurface):
        * platform/graphics/chromium/TextureManager.cpp:
        (WebCore::TextureManager::unprotectAllTextures):
        * platform/graphics/chromium/TextureManager.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
        * platform/graphics/chromium/cc/CCLayerImpl.h:
        (WebCore::CCLayerImpl::owner):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9311103>
ike@apple.com [Fri, 22 Apr 2011 00:49:18 +0000 (00:49 +0000)]
<rdar://problem/9311103>

Reviewed by Maciej Stachowiak.

Remove unnecessary QTKitServer and Apple Events permissions
from the WebProcess sandbox.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Fri, 22 Apr 2011 00:45:27 +0000 (00:45 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Apr 2011 00:43:59 +0000 (00:43 +0000)]
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Windows build fix.

        * WebCoreSupport/WebEditorClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9033535>
ike@apple.com [Fri, 22 Apr 2011 00:42:26 +0000 (00:42 +0000)]
<rdar://problem/9033535>

Reviewed by Maciej Stachowiak.

Mute sandbox violations when attempting to read a temporary
CFNetwork keychain.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 00:34:13 +0000 (00:34 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch upload should assign the bug to you
        https://bugs.webkit.org/show_bug.cgi?id=33699

        This patch only re-assigns the bug if it is currently unassigned.  We
        can be more aggressive in the future if people want us to be more
        agressive.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Apr 2011 00:33:21 +0000 (00:33 +0000)]
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::canCopyCut):
        (WebKit::EditorClientImpl::canPaste):
        * src/EditorClientImpl.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::canCopyCut):
        (WebCore::EditorClientQt::canPaste):
        * WebCoreSupport/EditorClientQt.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::canCopyCut):
        (WebKit::EditorClient::canPaste):
        * WebCoreSupport/EditorClientGtk.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/WebEditorClient.cpp:
        (WebEditorClient::canCopyCut):
        (WebEditorClient::canPaste):
        * WebCoreSupport/WebEditorClient.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebKitSupport/EditorClientWx.cpp:
        (WebCore::EditorClientWx::canCopyCut):
        (WebCore::EditorClientWx::canPaste):
        * WebKitSupport/EditorClientWx.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::canCopyCut):
        (WebEditorClient::canPaste):
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::canCopyCut):
        (WebCore::EditorClientHaiku::canPaste):
        * WebCoreSupport/EditorClientHaiku.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::canCopyCut):
        (WebCore::EditorClientEfl::canPaste):
        * WebCoreSupport/EditorClientEfl.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
        This allows editor client to grant copy/cut and paste permissions per origin.

        * editing/EditorCommand.cpp:
        (WebCore::supportedCopyCut):
        (WebCore::supportedPaste):
        * loader/EmptyClients.h:
        (WebCore::EmptyEditorClient::canCopyCut):
        (WebCore::EmptyEditorClient::canPaste):
        * page/EditorClient.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::canCopyCut):
        (WebKit::WebEditorClient::canPaste):
        * WebProcess/WebCoreSupport/WebEditorClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 00:22:23 +0000 (00:22 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviwed, expecations change. Pick up chromium-win baselines
        for r84522.

        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
        * platform/chromium-win/svg/filters/feDropShadow-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 00:17:34 +0000 (00:17 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Suppress failures possibly caused by bug 59158 on chromium win/linux:
        fast/canvas/canvas-stroke{Path,Rect}-alpha-shadow.html = TEXT

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8774116>
ike@apple.com [Fri, 22 Apr 2011 00:10:02 +0000 (00:10 +0000)]
<rdar://problem/8774116>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should only allow access to the
parts of the Darwin cache directory needed by the Security
framework.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9311053>
ike@apple.com [Fri, 22 Apr 2011 00:06:10 +0000 (00:06 +0000)]
<rdar://problem/9311053>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should not allow opening arbitrary
IOKit user clients. Restrict to a whitelist required for normal
WebProcess operation, including sound and accelerated graphics.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9311037>
ike@apple.com [Fri, 22 Apr 2011 00:03:02 +0000 (00:03 +0000)]
<rdar://problem/9311037>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should not allow modification of the
CoreAudio component cache.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix
ojan@chromium.org [Thu, 21 Apr 2011 23:58:40 +0000 (23:58 +0000)]
fix

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9263428>
ike@apple.com [Thu, 21 Apr 2011 23:58:06 +0000 (23:58 +0000)]
<rdar://problem/9263428>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should only allow outbound networking
to remote destinations and local kernel controls.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhoops, change lost during merge
oliver@apple.com [Thu, 21 Apr 2011 23:54:26 +0000 (23:54 +0000)]
Whoops, change lost during merge

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:49:13 +0000 (23:49 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Update baselines to accomodate the change in r84506. I wonder
        how much having platform/mac in the search path hurts
        chromium-win/-linux.

        * platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 21 Apr 2011 23:44:44 +0000 (23:44 +0000)]
2011-04-21  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Move canvas test set-colors.html expected results out of platform/mac-leopard and into platform/mac
        This test expected result pertains to all of mac, not just leopard.
        https://bugs.webkit.org/show_bug.cgi?id=59139

        * platform/mac-leopard/fast/canvas/set-colors-expected.txt: Removed.
        * platform/mac/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/canvas/set-colors-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 23:36:11 +0000 (23:36 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Embed checksums in more png files.  Not sure how these were missed earlier.

        * animations/missing-values-first-keyframe-expected.png:
        * animations/missing-values-last-keyframe-expected.png:
        * animations/opacity-transform-animation-expected.png:
        * animations/suspend-transform-animation-expected.png:
        * compositing/backface-visibility-expected.png:
        * compositing/checkerboard-expected.png:
        * compositing/geometry/ancestor-overflow-change-expected.png:
        * compositing/geometry/tall-page-composited-expected.png:
        * compositing/iframes/composited-iframe-scroll-expected.png:
        * compositing/iframes/iframe-content-flipping-expected.png:
        * compositing/iframes/nested-iframe-scrolling-expected.png:
        * compositing/images/direct-pdf-image-expected.png:
        * compositing/images/direct-svg-image-expected.png:
        * compositing/overflow/zero-size-overflow-expected.png:
        * compositing/reflections/backface-hidden-reflection-expected.png:
        * compositing/reflections/remove-add-reflection-expected.png:
        * compositing/tiling/constrained-layer-size-expected.png:
        * compositing/z-order/negative-z-index-expected.png:
        * transforms/3d/general/cssmatrix-3d-zoom-expected.png:
        * transforms/3d/general/matrix-with-zoom-3d-expected.png:
        * transitions/suspend-transform-transition-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:29:35 +0000 (23:29 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Unreviewed, expectations change - update chromium SVG baselines
        after r84522.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 23:24:50 +0000 (23:24 +0000)]
2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82052.
        http://trac.webkit.org/changeset/82052
        https://bugs.webkit.org/show_bug.cgi?id=59135

        New full screen api should be opt-in, not opt-out. (Requested
        by jernoble on #webkit).

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82052.
        http://trac.webkit.org/changeset/82052
        https://bugs.webkit.org/show_bug.cgi?id=59135

        New full screen api should be opt-in, not opt-out. (Requested
        by jernoble on #webkit).

        * Shared/WebPreferencesStore.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Adam Barth <abarth@webkit.org>
ojan@chromium.org [Thu, 21 Apr 2011 23:24:13 +0000 (23:24 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ValidateChangeLogs doesn't work on SVN
        https://bugs.webkit.org/show_bug.cgi?id=59115

        svn-create-patch lies about the diff in the working copy by moving
        ChangeLog entries to the top of the diff.  That's fine on most cases,
        but causes problems for ValidateChangeLogs, which is trying validate
        the where the ChangeLog entry appears.

        I haven't added a test for this change because I couldn't figure out
        how to write one.  The issue is more of an integration issue, which
        we're not really set up to test in our unit testing framework.  If this
        patch had worked around the output from svn-create-patch, then I could
        have tested that we behave correctly on sample svn-create-patch output,
        but, in this case, I've removed the dependency on svn-create-patch.  I
        could test that we behave correctly on "svn diff" output, but we
        already have those tests.

        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:22:22 +0000 (23:22 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change - update chromium SVG baselines
        after r84522.

        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
        * platform/chromium-linux/svg/filters/feDropShadow-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-mac/svg/filters/feDropShadow-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a failure seen in fast/dom/prototype-inheritance-2.html due to
ggaren@apple.com [Thu, 21 Apr 2011 23:20:34 +0000 (23:20 +0000)]
Fixed a failure seen in fast/dom/prototype-inheritance-2.html due to
wrong global object use.

Reviewed by Sam Weinig.

Source/WebCore:

* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter): Use the right global object.

LayoutTests:

* fast/dom/prototype-inheritance-2-expected.txt: Expect success!

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:10:08 +0000 (23:10 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change - flaky tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 21 Apr 2011 23:08:15 +0000 (23:08 +0000)]
2011-04-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Start moving to a general visitor pattern for GC traversal
        https://bugs.webkit.org/show_bug.cgi?id=59141

        This is just a rename:
            markChildren -> visitChildren
            markAggregate -> visitAggregate
            markStack -> visitor
            MarkStack -> typedef'd to SlotVisitor

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObjectData::visitChildren):
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):
        (JSC::JSCallbackObject::visitChildren):
        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitStructures):
        (JSC::EvalCodeCache::visitAggregate):
        (JSC::CodeBlock::visitAggregate):
        * bytecode/CodeBlock.h:
        * bytecode/EvalCodeCache.h:
        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::visitAggregate):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::visitAggregate):
        * bytecode/StructureStubInfo.h:
        * debugger/DebuggerActivation.cpp:
        (JSC::DebuggerActivation::visitChildren):
        * debugger/DebuggerActivation.h:
        * heap/HandleHeap.cpp:
        (JSC::WeakHandleOwner::isReachableFromOpaqueRoots):
        (JSC::HandleHeap::markStrongHandles):
        (JSC::HandleHeap::markWeakHandles):
        * heap/HandleHeap.h:
        * heap/HandleStack.cpp:
        (JSC::HandleStack::mark):
        * heap/HandleStack.h:
        * heap/Heap.cpp:
        (JSC::Heap::markProtectedObjects):
        (JSC::Heap::markTempSortVectors):
        (JSC::Heap::markRoots):
        * heap/Heap.h:
        * heap/MarkStack.cpp:
        (JSC::MarkStack::visitChildren):
        (JSC::MarkStack::drain):
        * heap/MarkStack.h:
        (JSC::HeapRootVisitor::HeapRootVisitor):
        (JSC::HeapRootVisitor::mark):
        (JSC::HeapRootVisitor::visitor):
        * heap/MarkedSpace.h:
        * runtime/ArgList.cpp:
        (JSC::MarkedArgumentBuffer::markLists):
        * runtime/ArgList.h:
        * runtime/Arguments.cpp:
        (JSC::Arguments::visitChildren):
        * runtime/Arguments.h:
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::visitChildren):
        (JSC::ProgramExecutable::visitChildren):
        (JSC::FunctionExecutable::visitChildren):
        * runtime/Executable.h:
        * runtime/GetterSetter.cpp:
        (JSC::GetterSetter::visitChildren):
        * runtime/GetterSetter.h:
        (JSC::GetterSetter::createStructure):
        * runtime/JSAPIValueWrapper.h:
        (JSC::JSAPIValueWrapper::createStructure):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::visitChildren):
        * runtime/JSActivation.h:
        * runtime/JSArray.cpp:
        (JSC::JSArray::visitChildren):
        * runtime/JSArray.h:
        (JSC::JSArray::visitDirect):
        * runtime/JSCell.h:
        (JSC::JSCell::JSCell::visitChildren):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::visitChildren):
        * runtime/JSFunction.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::visitIfNeeded):
        (JSC::JSGlobalObject::visitChildren):
        * runtime/JSGlobalObject.h:
        * runtime/JSONObject.cpp:
        * runtime/JSObject.cpp:
        (JSC::JSObject::visitChildren):
        * runtime/JSObject.h:
        (JSC::JSObject::visitDirect):
        * runtime/JSPropertyNameIterator.cpp:
        (JSC::JSPropertyNameIterator::visitChildren):
        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::createStructure):
        * runtime/JSStaticScopeObject.cpp:
        (JSC::JSStaticScopeObject::visitChildren):
        * runtime/JSStaticScopeObject.h:
        * runtime/JSTypeInfo.h:
        (JSC::TypeInfo::TypeInfo):
        (JSC::TypeInfo::overridesVisitChildren):
        * runtime/JSWrapperObject.cpp:
        (JSC::JSWrapperObject::visitChildren):
        * runtime/JSWrapperObject.h:
        * runtime/JSZombie.h:
        (JSC::JSZombie::visitChildren):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::visitChildren):
        * runtime/NativeErrorConstructor.h:
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::visitChildren):
        * runtime/RegExpObject.h:
        * runtime/ScopeChain.cpp:
        (JSC::ScopeChainNode::visitChildren):
        * runtime/ScopeChain.h:
        * runtime/SmallStrings.cpp:
        (JSC::SmallStrings::visitChildren):
        * runtime/SmallStrings.h:
        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        (JSC::Structure::visitChildren):
        * runtime/Structure.h:
        * runtime/StructureChain.cpp:
        (JSC::StructureChain::visitChildren):
        * runtime/StructureChain.h:
        (JSC::StructureChain::createStructure):
2011-04-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Start moving to a general visitor pattern for GC traversal
        https://bugs.webkit.org/show_bug.cgi?id=59141

        This is just a rename:
            markChildren -> visitChildren
            markAggregate -> visitAggregate
            markStack -> visitor
            MarkStack -> typedef'd to SlotVisitor

        * UserObjectImp.cpp:
        (UserObjectImp::visitChildren):
2011-04-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Start moving to a general visitor pattern for GC traversal
        https://bugs.webkit.org/show_bug.cgi?id=59141

        This is just a rename:
            markChildren -> visitChildren
            markAggregate -> visitAggregate
            markStack -> visitor
            MarkStack -> typedef'd to SlotVisitor

        * bindings/js/JSAttrCustom.cpp:
        (WebCore::JSAttr::visitChildren):
        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::JSCSSRule::visitChildren):
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::visitChildren):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::visitActiveObjectsForContext):
        (WebCore::markDOMObjectWrapper):
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::visitChildren):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMImplementationCustom.cpp:
        (WebCore::JSDOMImplementation::visitChildren):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::visitChildren):
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::visitChildren):
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::visitChildren):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::visitChildren):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::markJSFunction):
        * bindings/js/JSEventListener.h:
        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::visitChildren):
        * bindings/js/JSHTMLLinkElementCustom.cpp:
        (WebCore::JSHTMLLinkElement::visitChildren):
        * bindings/js/JSHTMLStyleElementCustom.cpp:
        (WebCore::JSHTMLStyleElement::visitChildren):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::constructImage):
        * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
        (WebCore::JSJavaScriptAudioNode::visitChildren):
        * bindings/js/JSMessageChannelCustom.cpp:
        (WebCore::JSMessageChannel::visitChildren):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::visitChildren):
        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNamedNodeMap::visitChildren):
        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::JSNavigator::visitChildren):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::isObservable):
        (WebCore::isReachableFromDOM):
        (WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNode::visitChildren):
        * bindings/js/JSNodeCustom.h:
        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::visitChildren):
        * bindings/js/JSNodeIteratorCustom.cpp:
        (WebCore::JSNodeIterator::visitChildren):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
        * bindings/js/JSProcessingInstructionCustom.cpp:
        (WebCore::JSProcessingInstruction::visitChildren):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::visitChildren):
        * bindings/js/JSSharedWorkerCustom.cpp:
        (WebCore::JSSharedWorker::visitChildren):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::JSStyleSheet::visitChildren):
        * bindings/js/JSTreeWalkerCustom.cpp:
        (WebCore::JSTreeWalker::visitChildren):
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::visitChildren):
        * bindings/js/JSWebKitAnimationListCustom.cpp:
        (WebCore::JSWebKitAnimationList::visitChildren):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::visitChildren):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::visitChildren):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::visitChildren):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtRuntimeObject::visitChildren):
        (JSC::Bindings::QtInstance::markAggregate):
        * bridge/qt/qt_instance.h:
        * bridge/qt/qt_pixmapruntime.cpp:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
        * bridge/qt/qt_runtime.h:
        * dom/EventListener.h:
        (WebCore::EventListener::visitJSFunction):
        * dom/EventTarget.h:
        (WebCore::EventTarget::visitJSEventListeners):
        * dom/Node.h:
        * dom/NodeFilterCondition.h:
        (WebCore::NodeFilterCondition::visitAggregate):
        * page/DOMWindow.h:
        * workers/WorkerContext.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 23:07:57 +0000 (23:07 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Update test results to show that we're using ogv.  I would have
        preferred to make this test independent of which video codec we have,
        but I didn't see a way to do that.

        * platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
        * platform/chromium/media/csp-blocks-video-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 22:52:08 +0000 (22:52 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting .checksum files in platform/chromium*

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59048
bdakin@apple.com [Thu, 21 Apr 2011 22:49:53 +0000 (22:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59048
Need to track whether overlay scrollbar is currently visible and in lower-
righthand corner
-and corresponding-
<rdar://problem/9211232>

Reviewed by Dan Bernstein.

Source/WebCore:

Whenever we start a new ScrollbarPartAnimation, check if the scrollbar is vertical
and showing (alpha of 1), and if so, call setVisibleScrollerThumbRect with the
knob rect, otherwise with an empty rect. ScrollAnimatorMac has a local rect to
track this value so that it can avoid sending messages across the ChromeClient to
the UIProcess if the rect has not changed.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::setVisibleScrollerThumbRect):

Plumbing for the chrome client.
* page/ChromeClient.h:
(WebCore::ChromeClient::notifyScrollerThumbIsVisibleInRect):
* page/FrameView.cpp:
(WebCore::FrameView::setVisibleScrollerThumbRect):
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVisibleScrollerThumbRect):

New WebCoreSystemInterface function to get the knob rect.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

A new WebSystemInterface is needed for this.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

WebPageProxy now stores an IntRect of the scroller thumb set by WebCore through
the client.

_windowResizeMouseLocationIsInVisibleScrollerThumb tests if the parameter point is
inside the cached scroller thumb rect.
* UIProcess/API/mac/WKView.mm:
(-[WKView _windowResizeMouseLocationIsInVisibleScrollerThumb:]):

Client work to cache the rect.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::notifyScrollerThumbIsVisibleInRect):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::visibleScrollerThumbRect):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::notifyScrollerThumbIsVisibleInRect):
* WebProcess/WebCoreSupport/WebChromeClient.h:

New WebSystemInterface is needed by WebCore for this.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
adamk@chromium.org [Thu, 21 Apr 2011 22:13:46 +0000 (22:13 +0000)]
2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84548.
        http://trac.webkit.org/changeset/84548
        https://bugs.webkit.org/show_bug.cgi?id=59144

        Broke chromium-win build (Requested by aklein on #webkit).

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 22:00:54 +0000 (22:00 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ValidateChangeLogs doesn't work on SVN
        https://bugs.webkit.org/show_bug.cgi?id=59115

        svn-create-patch lies about the diff in the working copy by moving
        ChangeLog entries to the top of the diff.  That's fine on most cases,
        but causes problems for ValidateChangeLogs, which is trying validate
        the where the ChangeLog entry appears.

        I haven't added a test for this change because I couldn't figure out
        how to write one.  The issue is more of an integration issue, which
        we're not really set up to test in our unit testing framework.  If this
        patch had worked around the output from svn-create-patch, then I could
        have tested that we behave correctly on sample svn-create-patch output,
        but, in this case, I've removed the dependency on svn-create-patch.  I
        could test that we behave correctly on "svn diff" output, but we
        already have those tests.

        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Thu, 21 Apr 2011 21:39:46 +0000 (21:39 +0000)]
2011-04-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion
        https://bugs.webkit.org/show_bug.cgi?id=55728

        Enable WTF_MULTIPLE_THREADS for Chromium.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 21:28:05 +0000 (21:28 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files not in LayoutTests/platform.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Thu, 21 Apr 2011 21:22:27 +0000 (21:22 +0000)]
2011-04-21  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Fix artefacts in compositor HUD when resizing
        https://bugs.webkit.org/show_bug.cgi?id=58969

        HUD was using the tiler program and not setting the texture
        transform. The HUD would thus draw with a texture transform based
        on the last tile drawn, leading sometimes to distortion.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::initializeSharedObjects):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::headsUpDisplayProgram):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84546 268f45cc-cd09-0410-ab3c-d52691b4dbfc