cfleizach@apple.com [Wed, 17 Mar 2010 00:10:13 +0000 (00:10 +0000)]
REGRESSION (r53857): Crash when tabbing to <map>
https://bugs.webkit.org/show_bug.cgi?id=36017
Reviewed by Darin Adler.
WebCore:
Test: fast/events/imagemap-norender-crash.html
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
LayoutTests:
Also fix the path to js-test-post.js in tab-imagemap.html.
* fast/events/imagemap-norender-crash-expected.txt: Added.
* fast/events/imagemap-norender-crash.html: Added.
* fast/events/tab-imagemap-expected.txt:
* fast/events/tab-imagemap.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 16 Mar 2010 23:39:05 +0000 (23:39 +0000)]
2010-03-16 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
Temporarily disable WebGL layout tests failing due to multisampling
https://bugs.webkit.org/show_bug.cgi?id=36200
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 16 Mar 2010 23:14:31 +0000 (23:14 +0000)]
Bug 36083 - REGRESSION (r55772-r55834): Crash in JavaScriptCore RegExp code on PowerPC
Reviewed by Oliver Hunt, Darin Adler.
The problem is a bug in our port of PCRE - that a read may take place from the first character in an
empty string. For the time being, revert to using a valid pointer in the data segment rather than
an invalid non-null pointer into the zero-page for the empty string's data pointer. A better fix for
this will be to remove PCRE.
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::empty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Mar 2010 23:05:52 +0000 (23:05 +0000)]
Fix run-webkit-httpd on Windows.
Reviewed by Mark Rowe.
* Scripts/webkitperl/httpd.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 16 Mar 2010 22:33:12 +0000 (22:33 +0000)]
Tiger build fix.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty):
Added more type casts to shut down warnings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 16 Mar 2010 22:30:02 +0000 (22:30 +0000)]
2010-03-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Alexey Proskuryakov.
fix webkit win test failures for smart delete
https://bugs.webkit.org/show_bug.cgi?id=36141
Works around https://bugs.webkit.org/show_bug.cgi?id=36140.
* editing/deleting/smart-delete-004.html:
* editing/pasteboard/smart-paste-002.html:
* editing/pasteboard/smart-paste-005.html:
* editing/pasteboard/smart-paste-007.html:
* platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
* platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 16 Mar 2010 22:26:20 +0000 (22:26 +0000)]
Build fix. No Review.
Correct missing includes in cURL network backend introduced
by recent changes in WebKit.
* platform/network/curl/ResourceHandleCurl.cpp: Add missing
includes for SharedBuffer and PassRefPtr.
(WebCore::ResourceHandle::loadResourceSynchronously): Correct
constructor signature for ResourceHandle to match @r55688.
* platform/network/curl/ResourceHandleManager.cpp: Add missing
include for RetainPtr.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 16 Mar 2010 21:26:20 +0000 (21:26 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins
Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments,
and a lastSetWindowArguments property, which returns a string describing the last NPWindow
passed to NPN_SetWindow.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginGetProperty):
(testResizeTo):
(pluginInvoke):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_SetWindow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 16 Mar 2010 21:07:38 +0000 (21:07 +0000)]
Rolled out r56081 since it broke the Windows build.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 16 Mar 2010 20:58:52 +0000 (20:58 +0000)]
2010-03-16 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Build breakage from 33416
https://bugs.webkit.org/show_bug.cgi?id=36189
No new tests. Built release Chromium.
* src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3DInternal::reshape):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Mar 2010 20:49:55 +0000 (20:49 +0000)]
2010-03-16 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Gustavo Noronha.
Update library version for 1.1.90 release.
* configure.ac:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Mar 2010 20:46:56 +0000 (20:46 +0000)]
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Bump version for 1.1.90 release.
* configure.ac:
WebKit/gtk:
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update for 1.1.90 release.
* NEWS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 16 Mar 2010 20:46:02 +0000 (20:46 +0000)]
Added arrayLength function and used it instead of hand-written code.
Reviewed by Sam Weinig.
* JavaScriptCore.xcodeproj/project.pbxproj:
Removed PtrAndFlags.h. The file was removed long ago.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute): Use arrayLength.
* runtime/Collector.h:
(JSC::CollectorBitmap::count): Remove WTF:: prefix from use
of bitCount. In WTF we inject things into the global namespace
and this is no exception.
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Use arrayLength.
* runtime/JSFunction.h:
(JSC::JSFunction::nativeFunction): Remove WTF:: prefix as above.
(JSC::JSFunction::scopeChain): Ditto.
(JSC::JSFunction::setScopeChain): Ditto.
(JSC::JSFunction::setNativeFunction): Ditto.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset): Use arrayLength.
* runtime/JSImmediate.h:
(JSC::reinterpretDoubleToIntptr): Remove WTF:: prefix as above.
(JSC::reinterpretIntptrToDouble): Ditto.
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendQuotedString): Use arrayLength.
(JSC::Stringifier::toJSON): Ditto.
(JSC::Stringifier::appendStringifiedValue): Ditto.
* runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings): Ditto.
* runtime/UString.cpp:
(JSC::UString::from): Use arrayLength.
* wtf/StdLibExtras.h:
(WTF::bitwise_cast): Marked this inline!
(WTF::arrayLength): Added function template (actually written by Sam).
Added using declarations for public things in WTF namespace defined
in this file.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 20:44:25 +0000 (20:44 +0000)]
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fix one too many empty lines in documentation of
window-obejct-cleared signal, which caused the documentation to be
rendered funny. Thanks to Martin Robinson for noticing.
* webkit/webkitwebview.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 16 Mar 2010 20:40:28 +0000 (20:40 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins
Test: plugins/resize-from-plugin.html
We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
whether the size has changed. But sync and async messages are not necessarily delivered in
order - plug-in host listens only to the former while waiting for a response to a message it
sent (a call to invoke() in this case).
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::resize):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView updateAndSetWindow]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 20:31:14 +0000 (20:31 +0000)]
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Add missing symbol to GeoLocation documentation
section.
* docs/webkitgtk-sections.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 19:35:36 +0000 (19:35 +0000)]
2010-03-16 Matej Urbančič <mateju@svn.gnome.org>
Reviewed by Gustavo Noronha.
Slovenian translation.
* sl.po: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 19:14:42 +0000 (19:14 +0000)]
2010-03-16 António Lima <amrlima@gmail.com>
Reviewed by Gustavo Noronha.
Translation for pt (Portuguese)
https://bugs.webkit.org/show_bug.cgi?id=36148
* pt.po: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 18:56:44 +0000 (18:56 +0000)]
2010-03-16 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35916
* efl/WebCoreSupport/ContextMenuClientEfl.cpp: Added.
* efl/WebCoreSupport/ContextMenuClientEfl.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 16 Mar 2010 18:53:34 +0000 (18:53 +0000)]
2010-03-16 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416
Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
* src/GraphicsContext3D.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Windows.
2010-03-16 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416
Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug.
* platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
* platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
* platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support.
* platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac.
* platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call.
2010-03-16 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Fisher.
Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Added.
* fast/canvas/webgl/context-attributes-expected.txt: WebGL context attributes behavior changed with this fix.
* fast/canvas/webgl/context-attributes.html: Ditto.
* fast/canvas/webgl/gl-get-calls-expected.txt: Stencil buffer is enabled, thus Stencil Bits is no longer 0.
* fast/canvas/webgl/gl-get-calls.html: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 18:18:53 +0000 (18:18 +0000)]
2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
Added layout tests to get the number of rows and columns.
https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables
* platform/gtk/accessibility/table-hierarchy.html:
* platform/gtk/accessibility/table-hierarchy-expected.txt:
2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables
Causes "layout tables" to be exposed as AccessibilityTables for Gtk.
* accessibility/AccessibilityTable.cpp:
(AccessibilityTable::isTableExposableThroughAccessibility):
2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables
Implements rowCount and columnCount for Gtk in DRT.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 16 Mar 2010 17:41:07 +0000 (17:41 +0000)]
2010-03-16 Martin Robinson <mrobinson@webkit.org>
Reviewed by Xan Lopez.
can't input korean into lower all input box except adress input box in webkit gtk launcher
https://bugs.webkit.org/show_bug.cgi?id=32290
Make the GTK+ EditorClient properly handle different types of input module
behavior such as commit and preedit signals that happen outside of key event
filtering and multiple times in a row. Filter keyup events as well as keydown
events and call gtk_im_context_focus_{in/out} when the WebView focus changes.
Added tests for this behavior to the GTK+ unit tests.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::imContextCommitted): Handle this signal properly when it happens outside of
key event filtering.
(WebKit::imContextPreeditChanged): Immediately update the preedit state and do not reject
empty preedits, so that cancellation works properly.
(WebKit::EditorClient::updatePendingComposition): Add this method, which handles the
situation where a commit signal happens when there is still a pending commit.
(WebKit::EditorClient::shouldBeginEditing): Clear pending composition state before editing
starts.
(WebKit::EditorClient::shouldEndEditing): Clear pending composition state before editing ends.
(WebKit::EditorClient::handleKeyboardEvent): No longer special case preedits which happen during
key event filtering. When confirming a pending composition use insertText instead of confirmComposition.
(WebKit::EditorClient::handleInputMethodKeydown):
* WebCoreSupport/EditorClientGtk.h: Make pendingComposition a member, so that multiple WebViews
do not share state.
(WebKit::EditorClient::webView): Added.
(WebKit::EditorClient::treatContextCommitAsKeyEvent): Added.
(WebKit::EditorClient::clearPendingComposition): Added.
* tests/testkeyevents.c:
(test_keypress_events_load_status_cb):
(map_event_cb):
(setup_keyevent_test):
(test_keypress_events):
(element_text_equal_to):
(test_ime_load_status_cb):
(test_ime):
(main):
* webkit/webkitwebview.cpp:
(webkit_web_view_key_release_event):
(webkit_web_view_focus_in_event):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 17:33:52 +0000 (17:33 +0000)]
Unreviewed. Build fix for distcheck.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Tue, 16 Mar 2010 17:26:59 +0000 (17:26 +0000)]
2010-03-15 Darin Fisher <darin@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36152
[chromium] Add support for history.pushState and history.replaceState
This is covered by the existing tests in fast/loader/stateobjects
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 16 Mar 2010 16:58:28 +0000 (16:58 +0000)]
Fix linker warnings when building WebCore on Windows
Rubber-stamped by Steve Falkenburg.
* WebCore.vcproj/WebCore.vcproj: Exclude JSDOMFormData.cpp from the
build, since it's already included in DerivedSources.cpp. Also let VS
sort this file as it saw fit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 16 Mar 2010 16:49:29 +0000 (16:49 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling
Reviewed by Simon Hausmann.
Translate coordinates correctly.
* page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd):
WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling
Reviewed by Simon Hausmann.
- Use the scrollbar overlay (implemented for accelerated compositing) when in tiled mode.
- Make overlay compile unconditionally, enable on demand. This removes bunch of unneeded ifdefs.
- Update the scroll position to the backing store as needed.
- Renamed some methods.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::):
(QGraphicsWebViewPrivate::createOrDeleteOverlay):
(QGraphicsWebViewPrivate::setRootGraphicsLayer):
(QGraphicsWebViewPrivate::updateCompositingScrollPosition):
(QGraphicsWebViewPrivate::scroll):
(QGraphicsWebViewPrivate::update):
(QGraphicsWebViewPrivate::graphicsItemVisibleRect):
(QGraphicsWebView::paint):
(QGraphicsWebView::setPage):
(QGraphicsWebView::updateGeometry):
(QGraphicsWebView::setGeometry):
* Api/qwebframe.cpp:
(QWebFramePrivate::renderFromTiledBackingStore):
* Api/qwebframe_p.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 16 Mar 2010 16:21:39 +0000 (16:21 +0000)]
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector http test fix that migrates it to the new inspector api.
* http/tests/inspector/inspect-iframe-from-different-domain.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Tue, 16 Mar 2010 16:19:50 +0000 (16:19 +0000)]
2010-03-16 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Darin Adler.
Remove extra <new> include and add guards to operator new/delete definitions
https://bugs.webkit.org/show_bug.cgi?id=35967
Remove extra <new> header include from FastAlloc.cpp since it is included in
FastAlloc.h. Add ENABLE(GLOBAL_FASTMALLOC_NEW) macro guard to operator
new/delete/new []/delete [] definitions.
* wtf/FastMalloc.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jwieczorek@webkit.org [Tue, 16 Mar 2010 16:18:56 +0000 (16:18 +0000)]
2010-03-16 Jakub Wieczorek <jwieczorek@webkit.org>
Reviewed by Eric Seidel.
[Qt] MediaPlayerPrivate: Initialize m_mediaPlayerControl to 0 to
avoid crashes when no media services can be found.
https://bugs.webkit.org/show_bug.cgi?id=36142
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 16 Mar 2010 16:09:31 +0000 (16:09 +0000)]
2010-03-16 Adam Barth <abarth@webkit.org>
Unreviewed.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Add missing "!" in plugin code. Should fix plugins/embed-inside-object
on Gtk and Qt.
* plugins/PluginView.cpp:
(WebCore::PluginView::load):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Tue, 16 Mar 2010 16:00:36 +0000 (16:00 +0000)]
2010-03-16 Nate Chapin <japhet@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Delete DerivedSourcesAllInOne.cpp.
https://bugs.webkit.org/show_bug.cgi?id=33048
* Android.v8bindings.mk:
* bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 16 Mar 2010 15:39:02 +0000 (15:39 +0000)]
Roll out r55889, as it breaks the Qt port on Leopard
2010-03-11 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Simon Hausmann.
Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888
Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 14:35:53 +0000 (14:35 +0000)]
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Revert r56006 as it caused functional issues. We will work on a
testcase, and rework the fix, and land when we have this a bit
more testable.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaPlayButton):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 16 Mar 2010 14:19:19 +0000 (14:19 +0000)]
2010-03-15 Robert Hogan <robert@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Fix crash in QWebView::setPage()
tst_qwebpage was crashing on setPage(0)
https://bugs.webkit.org/show_bug.cgi?id=36137
* Api/qwebview.cpp:
(QWebView::setPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 16 Mar 2010 13:58:05 +0000 (13:58 +0000)]
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Errors when inspecting styles of non-renderable elements in XHTML.
https://bugs.webkit.org/show_bug.cgi?id=35025
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getStyles):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype._addAttribute):
(WebInspector.DOMWindow.prototype.Object):
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update.callback):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._update):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 16 Mar 2010 13:37:20 +0000 (13:37 +0000)]
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Unreviewed.
Fix Chromium Mac build: remove unused code.
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Tue, 16 Mar 2010 13:32:10 +0000 (13:32 +0000)]
Spatial Navigation: Add a scrollIntoView call when focusing an element.
https://bugs.webkit.org/show_bug.cgi?id=36020
Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore:
When focusing an element in Spatial Navigation logic, it is desired to make
this element visible in the current viewport. For that to happen, there
could be a call to Element's scrollIntoView method at focusing time. However
for visual aspects, it is preferable to scroll to an inflated rect of |element|
in order to consider the focus outline width.
As Element's scrollIntoView method does not provide this flexibility, patch adds
a custom scrollIntoView method to SpatialNavigation.h .
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
* page/SpatialNavigation.cpp:
(WebCore::scrollIntoView):
* page/SpatialNavigation.h:
LayoutTests:
* platform/gtk/Skipped: Unskip snav-iframe-with-offscreen-element.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 12:10:48 +0000 (12:10 +0000)]
2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
[GStreamer] media/video-played-collapse.html
https://bugs.webkit.org/show_bug.cgi?id=36165
Skip apparently unreliable test. It used to fail locally and pass
on the bots, but the situation is inversed now. We need to
investigate this properly.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 11:57:39 +0000 (11:57 +0000)]
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Normalize timeout priorities through the GStreamer media player as
a whole. This should help avoid that any of them is starved.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::processBufferingStats):
(WebCore::MediaPlayerPrivate::muteChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_render):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 11:45:58 +0000 (11:45 +0000)]
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Use default priority also for parsing data: URIs.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::startData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 16 Mar 2010 11:44:30 +0000 (11:44 +0000)]
2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Seidel.
[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372
Normalize SharedTimers priorities to always be
G_PRIORITY_DEFAULT. As it is currently, timers that should happen
immediately (0 miliseconds delay) end up delayed by a lot of time
due to glib starving lower priority sources.
* platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireTime):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 16 Mar 2010 11:11:51 +0000 (11:11 +0000)]
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add support for Fast Mobile Scrolling in the build system.
* configure.ac:
WebCore:
2010-03-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Add support for Fast Mobile Scrolling in the build system.
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 16 Mar 2010 10:59:47 +0000 (10:59 +0000)]
2010-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* GNUmakefile.am:
* WebCore.Inspector.exp:
* WebCore.base.exp:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
* inspector/ConsoleMessage.h:
* inspector/InspectorClient.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::windowVisible):
(WebCore::InspectorController::frontendReady):
(WebCore::InspectorController::willCloseFrontend):
(WebCore::InspectorController::addConsoleMessage):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::inspectedWindowScriptObjectCleared):
(WebCore::InspectorController::setFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
(WebCore::InspectorController::releaseDOMAgent):
(WebCore::InspectorController::populateScriptObjects):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::getProfile):
(WebCore::InspectorController::enableDebugger):
* inspector/InspectorController.h:
(WebCore::InspectorController::hasInspectorFrontendClient):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::InspectorFrontend):
(WebCore::InspectorFrontend::~InspectorFrontend):
(WebCore::InspectorFrontend::addConsoleMessage):
(WebCore::InspectorFrontend::bringToFront):
(WebCore::InspectorFrontend::inspectedURLChanged):
* inspector/InspectorFrontend.h:
* inspector/InspectorFrontendClient.h: Added.
(WebCore::InspectorFrontendClient::~InspectorFrontendClient):
* inspector/InspectorFrontendClientLocal.cpp: Added.
(WebCore::FrontendMenuProvider::create):
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::FrontendMenuProvider::FrontendMenuProvider):
(WebCore::FrontendMenuProvider::~FrontendMenuProvider):
(WebCore::FrontendMenuProvider::populateContextMenu):
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
(WebCore::FrontendMenuProvider::contextMenuCleared):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::moveWindowBy):
(WebCore::InspectorFrontendClientLocal::showContextMenu):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
* inspector/InspectorFrontendClientLocal.h: Added.
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::InspectorFrontendHost):
(WebCore::InspectorFrontendHost::~InspectorFrontendHost):
(WebCore::InspectorFrontendHost::loaded):
(WebCore::InspectorFrontendHost::attach):
(WebCore::InspectorFrontendHost::detach):
(WebCore::InspectorFrontendHost::closeWindow):
(WebCore::InspectorFrontendHost::bringToFront):
(WebCore::InspectorFrontendHost::inspectedURLChanged):
(WebCore::InspectorFrontendHost::canAttachWindow):
(WebCore::InspectorFrontendHost::setAttachedWindowHeight):
(WebCore::InspectorFrontendHost::moveWindowBy):
(WebCore::InspectorFrontendHost::showContextMenu):
* inspector/InspectorFrontendHost.h:
(WebCore::InspectorFrontendHost::create):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.bringToFront):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
* inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.close):
(WebInspector.bringToFront):
(WebInspector.inspectedURLChanged):
* loader/EmptyClients.h:
(WebCore::EmptyInspectorClient::openInspectorFrontend):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
* page/Page.h:
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
(WebCore::ContextMenu::addInspectElementItem):
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::localizedStringsURL):
(WebInspectorFrontendClient::hiddenPanels):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::inspectedURLChanged):
(WebInspectorFrontendClient::updateWindowTitle):
(-[WebInspectorWindowController dealloc]):
(-[WebInspectorWindowController windowShouldClose:]):
(-[WebInspectorWindowController close]):
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController attach]):
(-[WebInspectorWindowController detach]):
(-[WebInspectorWindowController attached]):
(-[WebInspectorWindowController setFrontendClient:]):
(-[WebInspectorWindowController destroyInspectorView]):
(-[WebNodeHighlighter initWithInspectedWebView:]):
(-[WebNodeHighlighter dealloc]):
(-[WebNodeHighlighter highlightNode:]):
(-[WebNodeHighlighter hideHighlight]):
(-[WebNodeHighlighter didAttachWebNodeHighlight:]):
(-[WebNodeHighlighter willDetachWebNodeHighlight:]):
* WebInspector/WebInspector.mm:
(-[WebInspector attach:]):
(-[WebInspector detach:]):
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::~WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::updateHighlight):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::localizedStringsURL):
(WebInspectorFrontendClient::hiddenPanels):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::inspectedURLChanged):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::showWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
(WebInspectorFrontendClient::updateWindowTitle):
(WebInspectorFrontendClient::onGetMinMaxInfo):
(WebInspectorFrontendClient::onSize):
(WebInspectorFrontendClient::onClose):
(WebInspectorFrontendClient::onSetFocus):
(WebInspectorFrontendClient::onWebViewWindowPosChanging):
(WebInspectorWndProc):
(WebInspectorFrontendClient::windowReceivedMessage):
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::frontendClosing):
* WebInspector.cpp:
(WebInspector::attach):
(WebInspector::detach):
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* Api/qwebinspector.cpp:
(QWebInspector::hideEvent):
(QWebInspector::closeEvent):
* Api/qwebinspector.h:
* Api/qwebpage.h:
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
(WebCore::InspectorFrontendClientQt::frontendLoaded):
(WebCore::InspectorFrontendClientQt::localizedStringsURL):
(WebCore::InspectorFrontendClientQt::hiddenPanels):
(WebCore::InspectorFrontendClientQt::bringToFront):
(WebCore::InspectorFrontendClientQt::closeWindow):
(WebCore::InspectorFrontendClientQt::attachWindow):
(WebCore::InspectorFrontendClientQt::detachWindow):
(WebCore::InspectorFrontendClientQt::setAttachedWindowHeight):
(WebCore::InspectorFrontendClientQt::inspectedURLChanged):
(WebCore::InspectorFrontendClientQt::updateWindowTitle):
* WebCoreSupport/InspectorClientQt.h:
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::notifyWebViewDestroyed):
(WebKit::InspectorClient::InspectorClient):
(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::openInspectorFrontend):
(WebKit::InspectorClient::highlight):
(WebKit::InspectorClient::hideHighlight):
(WebKit::InspectorClient::populateSetting):
(WebKit::InspectorClient::storeSetting):
(WebKit::InspectorFrontendClient::InspectorFrontendClient):
(WebKit::InspectorFrontendClient::~InspectorFrontendClient):
(WebKit::InspectorFrontendClient::destroyInspectorWindow):
(WebKit::InspectorFrontendClient::localizedStringsURL):
(WebKit::InspectorFrontendClient::hiddenPanels):
(WebKit::InspectorFrontendClient::bringToFront):
(WebKit::InspectorFrontendClient::closeWindow):
(WebKit::InspectorFrontendClient::attachWindow):
(WebKit::InspectorFrontendClient::detachWindow):
(WebKit::InspectorFrontendClient::setAttachedWindowHeight):
(WebKit::InspectorFrontendClient::inspectedURLChanged):
* WebCoreSupport/InspectorClientGtk.h:
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::openInspectorFrontend):
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad):
(WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
(WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
* src/WebDevToolsAgentImpl.h:
* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
(WebKit::WebDevToolsFrontendImpl::jsBringToFront):
(WebKit::WebDevToolsFrontendImpl::jsInspectedURLChanged):
* src/WebDevToolsFrontendImpl.h:
* src/js/InjectDispatch.js:
(close):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 16 Mar 2010 10:17:21 +0000 (10:17 +0000)]
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium tests fix.
* src/js/InspectorControllerImpl.js:
(devtools.InspectorBackendImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 16 Mar 2010 09:32:43 +0000 (09:32 +0000)]
2010-03-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: migrate to native styles inspector in
order to inspect styles from foreighn domains.
https://bugs.webkit.org/show_bug.cgi?id=36117
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::getStyles):
(WebCore::InspectorBackend::getInlineStyle):
(WebCore::InspectorBackend::getComputedStyle):
(WebCore::InspectorBackend::applyStyleText):
(WebCore::InspectorBackend::setStyleText):
(WebCore::InspectorBackend::setStyleProperty):
(WebCore::InspectorBackend::toggleStyleEnabled):
(WebCore::InspectorBackend::setRuleSelector):
(WebCore::InspectorBackend::addRule):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getInlineStyle):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):
(WebCore::InspectorDOMAgent::getAttributeStyles):
(WebCore::InspectorDOMAgent::applyStyleText):
(WebCore::InspectorDOMAgent::setStyleText):
(WebCore::InspectorDOMAgent::setStyleProperty):
(WebCore::InspectorDOMAgent::toggleStyleEnabled):
(WebCore::InspectorDOMAgent::setRuleSelector):
(WebCore::InspectorDOMAgent::addRule):
(WebCore::InspectorDOMAgent::bindStyle):
(WebCore::InspectorDOMAgent::bindRule):
(WebCore::InspectorDOMAgent::buildObjectForStyle):
(WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
(WebCore::InspectorDOMAgent::buildObjectForRule):
(WebCore::InspectorDOMAgent::uniqueStyleProperties):
(WebCore::InspectorDOMAgent::longhandProperties):
(WebCore::InspectorDOMAgent::shorthandPriority):
(WebCore::InspectorDOMAgent::ruleAffectsNode):
(WebCore::InspectorDOMAgent::toArray):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::didGetEventListenersForNode):
(WebCore::InspectorFrontend::didGetStyles):
(WebCore::InspectorFrontend::didGetComputedStyle):
(WebCore::InspectorFrontend::didGetInlineStyle):
(WebCore::InspectorFrontend::didApplyStyleText):
(WebCore::InspectorFrontend::didSetStyleText):
(WebCore::InspectorFrontend::didSetStyleProperty):
(WebCore::InspectorFrontend::didToggleStyleEnabled):
(WebCore::InspectorFrontend::didSetRuleSelector):
(WebCore::InspectorFrontend::didAddRule):
* inspector/InspectorFrontend.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.CSSStyleDeclaration):
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/InjectedScript.js:
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype.update):
(WebInspector.MetricsSidebarPane.prototype.editingCommitted):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 16 Mar 2010 08:53:21 +0000 (08:53 +0000)]
Add WebKitTools/TestResultServer/index.yaml to gitattributes to ignore for crlf conversion.
* .gitattributes:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Tue, 16 Mar 2010 07:39:28 +0000 (07:39 +0000)]
2010-03-16 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
RenderText::m_text should be a String, not RefPtr<StringImpl>
https://bugs.webkit.org/show_bug.cgi?id=36010
Refactoring only, so no new tests.
* platform/text/PlatformString.h:
(WebCore::String::makeLower):
(WebCore::String::makeUpper):
(WebCore::String::makeSecure):
(WebCore::String::makeCapitalized):
(WebCore::String::containsOnlyASCII):
* rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::containsOnlyWhitespace):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::setText):
(WebCore::RenderText::previousOffset):
(WebCore::RenderText::previousOffsetForBackwardDeletion):
(WebCore::RenderText::nextOffset):
* rendering/RenderText.h:
(WebCore::RenderText::text):
(WebCore::RenderText::characters):
(WebCore::RenderText::textLength):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 07:27:24 +0000 (07:27 +0000)]
2010-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Test that the noscript element renders when @sandbox disables
JavaScript.
* fast/frames/sandboxed-iframe-noscript-expected.txt: Added.
* fast/frames/sandboxed-iframe-noscript.html: Added.
2010-03-16 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092
Instead of talking to Settings directly to figure out if JavaScript is
enabled in a frame, we need to talk to the ScriptController. The
ScriptController is better at answering that question because it knows
about @sandbox.
Test: fast/frames/sandboxed-iframe-noscript.html
* dom/Document.cpp:
(WebCore::Document::Document):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createRenderer):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsNeeded):
* html/HTMLParser.cpp:
(WebCore::HTMLParser::noscriptCreateErrorCheck):
(WebCore::HTMLParser::isInline):
* plugins/PluginView.cpp:
(WebCore::PluginView::load):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 07:11:32 +0000 (07:11 +0000)]
2010-03-15 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add "what-broke" command for debugging when the tree broke
https://bugs.webkit.org/show_bug.cgi?id=36157
This is another step towards automated sheriffing of the webkit tree.
With this logic our scripts are able to determine what revision broke the
tree. Buildbot should do this for us, but unfortunately buildbot doesn't
expose this kind of aggregate information.
* Scripts/webkitpy/buildbot.py:
- Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used).
- Split out more network logic into _fetch methods which will eventually be their own class for mocking.
- Use XMLRPC to communicate with the buildbot master instead of scraping build pages.
* Scripts/webkitpy/buildbot_unittest.py:
- Test the newly added buildbot classes.
* Scripts/webkitpy/commands/queries.py:
- Add an experimental what-broke command.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 07:08:06 +0000 (07:08 +0000)]
2010-03-15 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=36048
Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.
* Scripts/webkitdirs.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 06:42:30 +0000 (06:42 +0000)]
2010-03-15 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notification object should expose absolute URL of icon
https://bugs.webkit.org/show_bug.cgi?id=35800
Covered by existing tests.
* notifications/Notification.cpp:
(WebCore::Notification::Notification):
* notifications/Notification.h:
(WebCore::Notification::iconURL):
2010-03-15 John Gregg <johnnyg@google.com>
Reviewed by David Levin.
Notification object should expose absolute URL of icon
https://bugs.webkit.org/show_bug.cgi?id=35800
* public/WebNotification.h:
* src/WebNotification.cpp:
(WebKit::WebNotification::iconURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 06:25:07 +0000 (06:25 +0000)]
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35887
* platform/efl/ClipboardEfl.cpp: Added.
* platform/efl/PasteboardEfl.cpp: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 16 Mar 2010 05:56:59 +0000 (05:56 +0000)]
2010-03-15 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Don't submit disabled menu options.
https://bugs.webkit.org/show_bug.cgi?id=35056
* fast/forms/menulist-disabled-selected-option-expected.txt: Added.
* fast/forms/menulist-disabled-selected-option.html: Added.
* fast/forms/menulist-submit-without-selection-expected.txt: Added.
* fast/forms/menulist-submit-without-selection.html: Added.
* fast/forms/script-tests/menulist-disabled-selected-option.js: Added.
* fast/forms/script-tests/menulist-submit-without-selection.js: Added.
2010-03-15 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Don't submit disabled menu options.
https://bugs.webkit.org/show_bug.cgi?id=35056
Test: fast/forms/menulist-disabled-selected-option.html
* dom/OptionElement.h:
* dom/SelectElement.cpp:
(WebCore::SelectElement::appendFormData):
If a selected option is disabled, skip it.
Remove code for non-selected menulist because of compatibility with
other browsers.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 16 Mar 2010 05:55:38 +0000 (05:55 +0000)]
2010-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Let commit-queue land rollout patches even when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=36155
Now the commit-queue will land patches whose name begins with "ROLLOUT "
even if the tree is red. The patches still go through the usual build
and test process, but they can be landed while the tree is on fire.
* Scripts/webkitpy/bugzilla.py:
* Scripts/webkitpy/commands/queues.py:
* Scripts/webkitpy/commands/queues_unittest.py:
* Scripts/webkitpy/commands/queuestest.py:
* Scripts/webkitpy/mock_bugzillatool.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 05:50:16 +0000 (05:50 +0000)]
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35884
* platform/efl/FileSystemEfl.cpp: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 05:33:06 +0000 (05:33 +0000)]
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Holger Freyther.
Add EFL port files to platform/efl.
http://webkit.org/b/35882
* platform/efl/ContextMenuItemEfl.cpp: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 16 Mar 2010 05:32:03 +0000 (05:32 +0000)]
Tweak canvas perf demo.
* demos/canvas-perf/canvas.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 05:15:59 +0000 (05:15 +0000)]
2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText
Simple change to stop tables from implementing AtkText.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(getInterfaceMaskFromObject):
2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText
New test to be sure we do not accidentally implement AtkText for tables
* tests/testatk.c
(testWebkitAtkGetTextInTable):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 04:58:55 +0000 (04:58 +0000)]
2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Adam Barth.
According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only. Updated test accordingly.
https://bugs.webkit.org/show_bug.cgi?id=33210
* http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
* http/tests/eventsource/eventsource-parse-event-stream.html:
* http/tests/eventsource/resources/event-stream.php:
2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Adam Barth.
According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only.
https://bugs.webkit.org/show_bug.cgi?id=33210
* page/EventSource.cpp:
(WebCore::EventSource::parseEventStreamLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 16 Mar 2010 04:43:38 +0000 (04:43 +0000)]
2010-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing
https://bugs.webkit.org/show_bug.cgi?id=36154
This new command is a mashup of prepare-rollout and post. This command
will be used by an experimental bot to post rollouts of patches that
break things to bugs.webkit.org where they can be landed with the
greatest of ease.
* Scripts/webkitpy/commands/download.py:
* Scripts/webkitpy/commands/download_unittest.py:
* Scripts/webkitpy/steps/__init__.py:
* Scripts/webkitpy/steps/postdiffforrevert.py: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 04:41:27 +0000 (04:41 +0000)]
2010-03-15 Valters Svabe <vsvabe@gmail.com>
Reviewed by Darin Adler.
:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288
* fast/css-generated-content/block-after-expected.txt: Added.
* fast/css-generated-content/block-after.html: Added.
2010-03-15 Valters Svabe <vsvabe@gmail.com>
Reviewed by Darin Adler.
:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288
Make sure we don't append things after :after-generated content, if
it's inside an anonymous block.
Test: fast/css-generated-content/block-after.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChild):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 16 Mar 2010 04:15:20 +0000 (04:15 +0000)]
2010-03-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch rollout should error out on conflicts
https://bugs.webkit.org/show_bug.cgi?id=36151
Instead of blindingly plowing ahead, we now throw an exception if there
are conflicts after applying a reverse diff.
* Scripts/webkitpy/scm.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 16 Mar 2010 04:07:00 +0000 (04:07 +0000)]
2010-03-15 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
[BREWMP] Add a function to create a BREW instance without local variable declarations.
https://bugs.webkit.org/show_bug.cgi?id=34705
Add a template function to create a BREW instance in one line.
* wtf/brew/ShellBrew.h: Added.
(WTF::createInstance):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Tue, 16 Mar 2010 03:27:00 +0000 (03:27 +0000)]
2010-03-15 Darin Fisher <darin@chromium.org>
Fix build bustage. We also need to pull down "third_party/tcmalloc"
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 16 Mar 2010 02:36:10 +0000 (02:36 +0000)]
Not reviewed.
Removed a now-incorrect comment I forgot to remove in my last check-in.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::scavenge):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 16 Mar 2010 02:21:30 +0000 (02:21 +0000)]
Fixed a portion of:
<rdar://problem/
7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)
Reviewed by Sam Weinig.
Every few seconds, release a percentage of the minimum unused page count
during that time period.
SunSpider reports no change, command-line or in-browser, Mac or Windows.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMalloc_PageHeap::initializeScavenger): Renamed shouldContinueScavenging
to shouldScavenge, since scavenging is no longer something that we interrupt.
(WTF::TCMalloc_PageHeap::scavenge): The new scavenging algorithm. Fixes
a bug where the old code would release only one item from each size class
per scavenge, potentially leaving large numbers of large-sized objects
unreleased for a long time.
(WTF::TCMalloc_PageHeap::shouldScavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::GrowHeap):
(WTF::TCMalloc_PageHeap::scavengerThread):
(WTF::TCMalloc_PageHeap::periodicScavenge): Updated to track the minimum
value of free_committed_pages_ during a given scavenge period.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Tue, 16 Mar 2010 00:06:11 +0000 (00:06 +0000)]
2010-03-15 Darin Fisher <darin@chromium.org>
Fix build bustage. We also need to pull down "gfx"
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 15 Mar 2010 23:54:04 +0000 (23:54 +0000)]
WebKitTools: Unreviewed layout test fix.
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
GTK needs to implement press for this test to work.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::press):
LayoutTests: Unreviewed.
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
GTK needs to implement press in DRT before this test can work.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 15 Mar 2010 23:28:48 +0000 (23:28 +0000)]
Unreviewed layout test fix.
WebKitTools:
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Windows needs to implement press in DRT.
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::press):
LayoutTests:
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
This test must be skipped until https://bugs.webkit.org/show_bug.cgi?id=36145 is done.
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Mon, 15 Mar 2010 23:28:07 +0000 (23:28 +0000)]
2010-03-15 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=36131
Update include paths for chromium Rect, Point, and Size types.
Update DEPS to pull latest chromium code that reflects the
new location of these headers.
* DEPS:
* public/WebPoint.h:
* public/WebRect.h:
* public/WebSize.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 15 Mar 2010 23:20:24 +0000 (23:20 +0000)]
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Eric Seidel.
Add EFL port files to platform/efl.
http://webkit.org/b/35885
* platform/efl/KURLEfl.cpp: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 15 Mar 2010 23:06:48 +0000 (23:06 +0000)]
Unreviewed. Fix break of layout tests on win and gtk.
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Attempting to implement press action for windows and gtk.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::press):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::press):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 15 Mar 2010 22:59:45 +0000 (22:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=35843
Re-land reverted fix to JSString::getIndex()
Reviewed by Sam Weinig.
Calling getIndex() on a JSString in rope form may result in a JSException being thrown
if there is insuficient memory so value(exec) returns UString() with length zero,
which will be passed to jsSingleCharacterSubstring.
Add a slow case function to trap the error & return a safe null value, until the
exception is handled.
* runtime/JSString.cpp:
(JSC::JSString::getIndexSlowCase):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 15 Mar 2010 22:38:18 +0000 (22:38 +0000)]
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Reviewed by Beth Dakin.
* DumpRenderTree/AccessibilityUIElement.cpp:
(pressCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::press):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::press):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::press):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 15 Mar 2010 22:07:20 +0000 (22:07 +0000)]
VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132
Reviewed by Beth Dakin.
WebCore:
When a label element is used as a click event handler, and it doesn't have any
corresponding control, it should handle the action itself.
Test: accessibility/label-element-press.html
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::accessKeyAction):
LayoutTests:
* accessibility/label-element-press-expected.txt: Added.
* accessibility/label-element-press.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 15 Mar 2010 21:56:13 +0000 (21:56 +0000)]
2010-03-15 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 36135 - GCController::garbageCollectNow() crashes when called from garbage collection
<https://bugs.webkit.org/show_bug.cgi?id=36135>
<rdar://problem/
7752552>
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow): Fail silently if garbage collection is
active rather than hitting the CRASH() reentrancy guard.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 15 Mar 2010 21:47:23 +0000 (21:47 +0000)]
2010-03-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Drop out of compositing mode when no elements need to composite
https://bugs.webkit.org/show_bug.cgi?id=36134
When no more elements on the page need to be composited, drop out of compositing
mode altogether, including removing the layer-backed view that hosts the layers.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): If the list of child layers to attach at
the root is empty, we have no composited layers, and can drop out of compositing mode by calling
willMoveOffscreen().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): In several places,
use willBeComposited rather than calling needsToBeComposited(), because it avoids
recomputing state that we know already (but assert that we're getting it right).
When we're assessing the root layer in post-order, see if we have any child layers that
are compositing, and also whether the root itself needs to composite. If neither are
true, then we can drop out of compositing mode.
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Move the
"inCompositingMode() && layer->isRootLayer()" test out of requiresCompositingLayer()
and into needsToBeComposited() so that we can call requiresCompositingLayer() separately
on the root layer above.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 15 Mar 2010 21:33:47 +0000 (21:33 +0000)]
2010-03-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Add EFL port files to platform/efl.
http://webkit.org/b/35888
* platform/efl/SoundEfl.cpp: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Mon, 15 Mar 2010 21:21:10 +0000 (21:21 +0000)]
Add a long long version of abs() for MSVC.
Reviewed by Adam Roben.
* wtf/MathExtras.h:
(abs):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 15 Mar 2010 21:02:29 +0000 (21:02 +0000)]
Add a new build slave to replace the existing SnowLeopard Leaks build slave which
appears to be suffering a slow and painful death at the hands of its graphics hardware.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 15 Mar 2010 21:01:51 +0000 (21:01 +0000)]
2010-03-15 Simon Fraser <simon.fraser@apple.com>
Rubber-stamped by Dan Bernstein.
Update some pixel results for composting tests; some were incorrect, and others had minor
pixel differences.
* platform/mac/compositing/color-matching/image-color-matching-expected.checksum:
* platform/mac/compositing/color-matching/image-color-matching-expected.png:
* platform/mac/compositing/direct-image-compositing-expected.checksum:
* platform/mac/compositing/direct-image-compositing-expected.png:
* platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
* platform/mac/compositing/overflow/overflow-scroll-expected.png:
* platform/mac/compositing/reflections/animation-inside-reflection-expected.checksum:
* platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
* platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/mac/compositing/reflections/nested-reflection-animated-expected.checksum:
* platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
* platform/mac/compositing/reflections/nested-reflection-transition-expected.checksum:
* platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
* platform/mac/compositing/reflections/reflection-on-composited-expected.checksum:
* platform/mac/compositing/reflections/reflection-on-composited-expected.png:
* platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
* platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
* platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
* platform/mac/compositing/repaint/layer-repaint-rects-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 15 Mar 2010 20:31:04 +0000 (20:31 +0000)]
WebCore: For continuous scrolling devices on the Mac (trackpads and Mighty/Magic
Mice), set the number of wheel ticks equal to the atomic increment of
the device: a pixel. This ensures that any scrolling action will
generate at least one wheel tick, regardless of the speed/length of
the gesture.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/
7453254>
Tests: fast/events/continuous-platform-wheelevent-in-scrolling-div.html
fast/events/platform-wheelevent-in-scrolling-div.html
* platform/mac/WebCoreSystemInterface.h: Modify method signature.
* platform/mac/WebCoreSystemInterface.mm: Ditto.
* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Call into
WebKitSystemInterface to determine both wheelTicksX/Y and deltaX/Y.
WKSI will query the event system for number of wheel ticks and
pixels/lines scrolled based on the device type.
WebKit/mac: Updated call to WKGetWheelEventDeltas() to match new method signature.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/
7453254>
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]):
WebKitLibraries: Added two new output arguments to WKGetWheelEventDeltas() to return
the number of scroll wheel ticks in the x and y directions.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601.
<rdar://problem/
7453254>
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
LayoutTests: These tests verify that scrollwheel events (both continuous and
non-continuous) generate the expected pixel deltas in scrollable
regions, and also generate DOM mousewheel events with expected
wheelDelta values.
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/
7453254>
* fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
* fast/events/continuous-platform-wheelevent-in-scrolling-div.html: Added.
* fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
* fast/events/platform-wheelevent-in-scrolling-div.html: Added.
* fast/events/wheelevent-in-scrolling-div-expected.txt: Rebased
expected results due to change in test output formatting.
* fast/events/wheelevent-in-scrolling-div.html: Modified to use common
js logging and assertion functions.
* platform/gtk/Skipped: DRT support needed by tests not yet implemented
in GTK port. See https://bugs.webkit.org/show_bug.cgi?id=36003.
* platform/mac-tiger/Skipped: DRT support needed by tests not possible
to implement in Tiger.
* platform/qt/Skipped: DRT support for tests not yet implemented in Qt
port. See https://bugs.webkit.org/show_bug.cgi?id=36004.
* platform/win/Skipped: DRT support for tests not yet implemented in
Windows port. See https://bugs.webkit.org/show_bug.cgi?id=36002.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 15 Mar 2010 20:30:17 +0000 (20:30 +0000)]
2010-03-15 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
https://bugs.webkit.org/show_bug.cgi?id=36012
* public/GeolocationServiceBridgeChromium.h:
* src/GeolocationServiceBridgeChromium.cpp:
(WebKit::GeolocationServiceBridgeImpl::startUpdating):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 15 Mar 2010 20:18:47 +0000 (20:18 +0000)]
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] duration query optimizations
https://bugs.webkit.org/show_bug.cgi?id=36116
Don't reattempt duration queries that previously failed and cache
media duration only if it's known.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::durationChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 15 Mar 2010 20:11:55 +0000 (20:11 +0000)]
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] updateStates called for all elements posting a state-change
https://bugs.webkit.org/show_bug.cgi?id=36115
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateMessageCallback): Update player state
only for state-change messages coming from playbin2 directly.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivate::pipeline): public accessor for the
playbin element.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Mon, 15 Mar 2010 20:10:22 +0000 (20:10 +0000)]
-[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
<https://bugs.webkit.org/show_bug.cgi?id=36125>
Reviewed by Adam Roben.
* WebView/WebDynamicScrollBarsView.h:
Added instance variables horizontalScrollingAllowedButScrollerHidden and
verticalScrollingAllowedButScrollerHidden. Renamed instance variables
hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
Added comments.
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Updated for instance variable renaming.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideHorizontalScrolling has been called.
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideVerticalScrolling has been called.
(-[WebDynamicScrollBarsView updateScrollers]):
Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
in the early-return code path, to avoid taking it into account twice in the regular code path.
* WebView/WebFrameView.mm:
(-[WebFrameView _scrollToBeginningOfDocument]):
Use _isScrollable instead of _hasScrollBars.
(-[WebFrameView _scrollToEndOfDocument]):
Ditto.
(-[WebFrameView scrollToBeginningOfDocument:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView scrollToEndOfDocument:]):
Ditto.
(-[WebFrameView _pageVertically:]):
Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
and _largestChildWithScrollBars.
(-[WebFrameView _pageHorizontally:]):
Ditto.
(-[WebFrameView _scrollLineVertically:]):
Ditto.
(-[WebFrameView _scrollLineHorizontally:]):
Ditto.
(-[WebFrameView keyDown:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView _isScrollable]):
New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
-[WebDynamicScrollBarsView verticalScrollingAllowed]
(-[WebFrameView _largestScrollableChild]):
New method, like _largestChildWithScrollBars but uses _isScrollable.
(-[WebFrameView _hasScrollBars]):
Added a comment that this is no longer used by Safari, and can thus probably be
deleted once we no longer want to support it for nightly build compatibility with
old versions of Safari.
(-[WebFrameView _largestChildWithScrollBars]):
Ditto.
* WebView/WebFrameViewPrivate.h:
Declared -_isScrollable and -_largestScrollableChild. Added comments to
_hasScrollBars and _largestChildWithScrollBars saying that they are no longer
used by Safari, and can thus probably be deleted once we no longer want to
support them for nightly build compatibility with old versions of Safari.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Mon, 15 Mar 2010 20:08:33 +0000 (20:08 +0000)]
Clean up more bits of the open-source image decoders. In addition to
simplifying things somewhat, this makes all the decoders the same in
terms of how they construct "image reader" subclasses and init scale
data.
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=36040
No functional change, so no tests.
* platform/image-decoders/ImageDecoder.h: Reorder a few declarations to try and group/order members slightly better.
(WebCore::ImageDecoder::ImageDecoder):
* platform/image-decoders/gif/GIFImageDecoder.cpp: Move reader construction into decode(). Prep scale data in setSize(). Remove useless comment.
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::setSize):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
* platform/image-decoders/gif/GIFImageDecoder.h: Prep scale data in setSize().
* platform/image-decoders/gif/GIFImageReader.cpp: Prep scale data in setSize().
(GIFImageReader::read):
* platform/image-decoders/ico/ICOImageDecoder.cpp: Shorten code.
(WebCore::ICOImageDecoder::setSize):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Fix style. Move reader construction into decode().
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h: Move reader construction into decode().
(WebCore::JPEGImageDecoder::filenameExtension):
* platform/image-decoders/png/PNGImageDecoder.cpp: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize(). Remove useless comment.
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setSize):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):
* platform/image-decoders/png/PNGImageDecoder.h: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize().
(WebCore::PNGImageDecoder::filenameExtension):
(WebCore::PNGImageDecoder::isComplete):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 15 Mar 2010 20:00:53 +0000 (20:00 +0000)]
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] video playback position query flood when mouse over the video element
https://bugs.webkit.org/show_bug.cgi?id=35333
Don't trigger a position query only to know which play/pause
button to display.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaPlayButton):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 15 Mar 2010 19:57:11 +0000 (19:57 +0000)]
2010-03-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix a minor case where we'd deference a null pointer if we tried
to run new-run-webkit-tests on an unsupported platform (e.g.
Cygwin's python version).
https://bugs.webkit.org/show_bug.cgi?id=36076
* Scripts/webkitpy/layout_tests/port/factory.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Mon, 15 Mar 2010 17:27:25 +0000 (17:27 +0000)]
[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026
Reviewed by Nate Chapin.
Test: http/tests/local/send-form-data.html
* Android.v8bindings.mk:
* WebCore.gypi:
* bindings/v8/V8Index.h:
* bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::sendCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Mon, 15 Mar 2010 17:27:16 +0000 (17:27 +0000)]
WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024
Reviewed by Sam Weinig.
The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata
Test: http/tests/local/send-form-data.html
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.jscbindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMFormDataCustom.cpp: Added.
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
* bindings/scripts/CodeGeneratorJS.pm:
* html/DOMFormData.idl: Added.
* page/DOMWindow.idl:
LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024
Reviewed by Sam Weinig.
Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/js/global-constructors-expected.txt:
* http/tests/local/resources/send-form-data.js: Added.
* http/tests/local/send-form-data-expected.txt: Added.
* http/tests/local/send-form-data.html: Added.
* http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 15 Mar 2010 17:14:10 +0000 (17:14 +0000)]
2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32369
Revised test of storage/databases in sandboxed iframes.
Verify that SECURITY_ERR is raised on access to
window.localStorage or window.openDatabase(). Also verify that
window.sessionStorage is now allowed in sandboxed iframes.
WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:
- http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
- http://dev.w3.org/html5/webdatabase/ (section 4.1)
- http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
* fast/frames/resources/sandboxed-iframe-storage-disallowed.html: expect exceptions, not null
* fast/frames/sandboxed-iframe-storage-expected.txt: expect exceptions, not null
2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32369
Revise iframe sandbox behavior to match the updated HTML5 spec.
- Enables window.sessionStorage in sandboxed iframes.
- Raises SECURITY_ERR exceptions when window.localStorage or
window.openDatabase() is blocked by iframe sandboxing.
Note: window.sessionStorage does not raise exceptions.
WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:
http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
* inspector/InspectorController.cpp:
(WebCore::InspectorController::selectDOMStorage): exception handling
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::handleEvent): exception handling
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage): re-enabled in iframe sandbox
(WebCore::DOMWindow::localStorage): raise exception rather than return null
(WebCore::DOMWindow::openDatabase): raise exception rather than return null
* page/DOMWindow.h: added exceptions to interface
* page/DOMWindow.idl: added exceptions to interface
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessLocalStorage): renamed function to reflect its purpose
* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch): exception handling
2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=32369
Revise iframe sandbox behavior to match the updated HTML5 spec.
- Enables window.sessionStorage in sandboxed iframes.
- Raises SECURITY_ERR exceptions when window.localStorage or
window.openDatabase() is blocked by iframe sandboxing.
Note: window.sessionStorage does not raise exceptions.
WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:
http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html
* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::storageEvent): exception handling
* src/StorageEventDispatcherImpl.cpp:
(WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): exception handling
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Mon, 15 Mar 2010 16:41:41 +0000 (16:41 +0000)]
Tell Subversion about more directories that expect to have .pyc files.
* Scripts/webkitpy/layout_tests: Added property svn:ignore.
* Scripts/webkitpy/layout_tests/port: Added property svn:ignore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 15 Mar 2010 16:33:24 +0000 (16:33 +0000)]
2010-03-15 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Combine ctiTrampolines on ARM and Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=36014
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 15 Mar 2010 16:22:24 +0000 (16:22 +0000)]
2010-03-15 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Implement a progress indicator in the Audits panel
when resources are reloading
https://bugs.webkit.org/show_bug.cgi?id=35971
* English.lproj/localizedStrings.js:
* GNUmakefile.am:
* WebCore.gypi:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
(WebInspector.AuditLauncherView.prototype.get totalResources):
(WebInspector.AuditLauncherView.prototype.set totalResources):
(WebInspector.AuditLauncherView.prototype.get loadedResources):
(WebInspector.AuditLauncherView.prototype.set loadedResources):
(WebInspector.AuditLauncherView.prototype._resetResourceCount):
(WebInspector.AuditLauncherView.prototype.resourceStarted):
(WebInspector.AuditLauncherView.prototype.resourceFinished):
(WebInspector.AuditLauncherView.prototype.reset):
(WebInspector.AuditLauncherView.prototype._setAuditRunning):
(WebInspector.AuditLauncherView.prototype._launchButtonClicked):
(WebInspector.AuditLauncherView.prototype._createCategoryElement):
(WebInspector.AuditLauncherView.prototype._createLauncherUI):
(WebInspector.AuditLauncherView.prototype._updateResourceProgress):
(WebInspector.AuditLauncherView.prototype._updateButton):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype.resourceStarted):
(WebInspector.AuditsPanel.prototype.resourceFinished):
(WebInspector.AuditsPanel.prototype.reset):
* inspector/front-end/Images/spinner.gif: Added.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/audits.css:
(.audit-launcher-view .resource-progress > img):
* inspector/front-end/inspector.js:
(WebInspector.updateResource):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 15 Mar 2010 15:54:38 +0000 (15:54 +0000)]
2010-03-15 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108
Remove waitUntilDone/notifyDone from the layout test, it's not needed
and causes timeouts on failure.
* editing/input/option-page-up-down.html:
2010-03-15 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108
* src/EditorClientImpl.cpp:
(WebKit::):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Mon, 15 Mar 2010 15:40:57 +0000 (15:40 +0000)]
Method name and parameter name mistakes from recent SPI addition
<https://bugs.webkit.org/show_bug.cgi?id=36119>
Reviewed by Dan Bernstein.
* WebView/WebDynamicScrollBarsView.h:
Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
Updated for renamed instance variable and method.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Changed parameter name from shouldBeVisible to shouldBeHidden.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView contentViewFrame]):
Updated for renamed instance variable.
(-[WebDynamicScrollBarsView tile]):
Ditto.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
Ditto.
* WebView/WebFrame.mm:
(-[WebFrame setAllowsScrollersToOverlapContent:]):
Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.
* WebView/WebFramePrivate.h:
Renamed method name from "setAllowXXX" to "setAllowsXXX".
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 15 Mar 2010 15:34:47 +0000 (15:34 +0000)]
2010-03-15 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735
Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::volumeChangedTimerFired):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::processBufferingStats):
(WebCore::MediaPlayerPrivate::fillTimerFired):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::muteChangedTimerFired):
(WebCore::MediaPlayerPrivate::muteChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Mon, 15 Mar 2010 15:20:22 +0000 (15:20 +0000)]
2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Eric Carlson.
media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793
Only effectively load, and start buffering when playing, or when
the preload attribute is set.
Test: media/video-preload.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::commitLoad):
(WebCore::MediaPlayerPrivate::prepareToPlay):
(WebCore::MediaPlayerPrivate::setPreload):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Mon, 15 Mar 2010 14:46:56 +0000 (14:46 +0000)]
2010-03-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
[Qt] Build fix if TILED_BACKING_STORE is disabled.
* Api/qwebframe.cpp:
(QWebFramePrivate::renderContentsLayerAbsoluteCoords):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc