WebKit.git
9 years ago[V8] document.all gets confused about its prototype chain
abarth@webkit.org [Mon, 19 Sep 2011 22:57:30 +0000 (22:57 +0000)]
[V8] document.all gets confused about its prototype chain
https://bugs.webkit.org/show_bug.cgi?id=68393

Reviewed by Eric Seidel.

Source/WebCore:

GetRealNamedPropertyInPrototypeChain doesn't call interceptors, so it's
not a good idea to use its return value.  It turns out that all the
callers of the API only cared about whether it returns a null handle.

Test: http/tests/security/document-all.html

* bindings/v8/V8Collection.h:
(WebCore::collectionNamedPropertyGetter):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyDeleter):
(WebCore::V8DOMStringMap::namedPropertySetter):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::namedPropertyGetter):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageSetter):

LayoutTests:

Test how document.all behaves when you change its prototype chain.

* http/tests/security/document-all-expected.txt: Added.
* http/tests/security/document-all.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNamed property confusion with __proto__
abarth@webkit.org [Mon, 19 Sep 2011 22:56:22 +0000 (22:56 +0000)]
Named property confusion with __proto__
https://bugs.webkit.org/show_bug.cgi?id=68221

Reviewed by Eric Seidel.

Source/WebCore:

The __proto__ property is super magical because it's not a real named
property and it has higher precedence than even interceptors.  This
confuses this check, which is meant to detech which names will get
handled by our interceptor.

Test: http/tests/security/window-named-proto.html

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedSecurityCheck):

LayoutTests:

* http/tests/security/resources/innocent-victim-with-iframe.html: Added.
* http/tests/security/window-named-proto-expected.txt: Added.
* http/tests/security/window-named-proto.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
abarth@webkit.org [Mon, 19 Sep 2011 22:54:53 +0000 (22:54 +0000)]
Rename ENABLE(OPENTYPE_SANITIZER) to USE(OPENTYPE_SANITIZER)
https://bugs.webkit.org/show_bug.cgi?id=68292

Reviewed by Eric Seidel.

Source/WebCore:

OpenType Sanitizer is a library for sanitizing type and not a feature.
Therefore this macro should say that we USE the library.

* platform/graphics/WOFFFileFormat.cpp:
* platform/graphics/WOFFFileFormat.h:
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
* platform/graphics/opentype/OpenTypeSanitizer.cpp:
* platform/graphics/opentype/OpenTypeSanitizer.h:
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):

Source/WebKit/chromium:

* features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
abarth@webkit.org [Mon, 19 Sep 2011 22:53:04 +0000 (22:53 +0000)]
Remove APPLICATION_CACHE_DYNAMIC_ENTRIES and associated code
https://bugs.webkit.org/show_bug.cgi?id=68407

Reviewed by Eric Seidel.

As discussed on webkit-dev, no one appears to be using this code.

* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMApplicationCacheCustom.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix after r95310
aroben@apple.com [Mon, 19 Sep 2011 22:32:20 +0000 (22:32 +0000)]
Windows build fix after r95310

* JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops: Added
include\private\JavaScriptCore to the include path so DFGIntrinsic.h can be found.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG speculation failures should act as additional value profiles
fpizlo@apple.com [Mon, 19 Sep 2011 22:27:38 +0000 (22:27 +0000)]
DFG speculation failures should act as additional value profiles
https://bugs.webkit.org/show_bug.cgi?id=68335

Reviewed by Oliver Hunt.

This adds slow-case counters to the old JIT. It also ensures that
negative zero in multiply is handled carefully. The old JIT
previously took slow path if the result of a multiply was zero,
which, without any changes, would cause the DFG to think that
every such multiply produced a double result.

This also fixes a bug in the old JIT's handling of decrements. It
would take the slow path if the result was zero, but not if it
underflowed.

By itself, this would be a 1% slow-down on V8 and Kraken. But then
I wrote optimizations in the DFG that take advantage of this new
information. It's no longer the case that every multiply needs to
do a check for negative zero; it only happens if the negative
zero is ignored.

This results in a 12% speed-up on v8-crypto, for a 1.4% geomean
speed-up in V8. It's mostly neutral on Kraken. I can see an
0.5% slow-down and it appears to be significant.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetRareCaseProfiles):
(JSC::CodeBlock::dumpValueProfiles):
* bytecode/CodeBlock.h:
* bytecode/ValueProfile.h:
(JSC::RareCaseProfile::RareCaseProfile):
(JSC::getRareCaseProfileBytecodeOffset):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::GPRTemporary::GPRTemporary):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JSC::JIT::linkDummySlowCase):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
* jit/JITInlineMethods.h:
(JSC::JIT::addSlowCase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r95385 and r95457.
commit-queue@webkit.org [Mon, 19 Sep 2011 22:26:34 +0000 (22:26 +0000)]
Unreviewed, rolling out r95385 and r95457.
http://trac.webkit.org/changeset/95385
http://trac.webkit.org/changeset/95457
https://bugs.webkit.org/show_bug.cgi?id=68395

Broke chromium browser_tests (Requested by dslomov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

Source/WebCore:

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
* bindings/v8/V8IsolatedContext.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didDestroyScriptContextForFrame):
(WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateIsolatedScriptContext):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didDestroyScriptContextForFrame):
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):
* src/FrameLoaderClientImpl.h:
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
* tests/data/context_notifications_test.html: Removed.
* tests/data/context_notifications_test_frame.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix nonpremultiplied webgl toDataURL to jpeg
commit-queue@webkit.org [Mon, 19 Sep 2011 22:23:28 +0000 (22:23 +0000)]
Fix nonpremultiplied webgl toDataURL to jpeg
https://bugs.webkit.org/show_bug.cgi?id=68366

Source/WebCore:

The canvas spec says that toDataURL to formats without an alpha must
be "composited onto a solid black background using the source-over
operator." Do that.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::RGBAtoRGB):

LayoutTests:

Update the premultiplyalpha-test from the WebGL conformance tests.

Patch by John Bauman <jbauman@chromium.org> on 2011-09-19
Reviewed by Kenneth Russell.

* fast/canvas/webgl/premultiplyalpha-test-expected.txt:
* fast/canvas/webgl/premultiplyalpha-test.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLet Xcode 4 do its thang with ANGLE.xcodeproj
aroben@apple.com [Mon, 19 Sep 2011 22:20:41 +0000 (22:20 +0000)]
Let Xcode 4 do its thang with ANGLE.xcodeproj

* ANGLE.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix after r94575
aroben@apple.com [Mon, 19 Sep 2011 22:20:32 +0000 (22:20 +0000)]
Windows build fix after r94575

* JavaScriptCore.vcproj/JavaScriptCore.sln: Relinearized project dependencies. testRegExp
now builds just before FindSafari.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-19 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Mon, 19 Sep 2011 21:56:23 +0000 (21:56 +0000)]
2011-09-19  Chris Marrin  <cmarrin@apple.com>

        Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction
        https://bugs.webkit.org/show_bug.cgi?id=67510

        Reviewed by Adam Roben.

        Another fix to take care of one last crash when running pause-crash.html.
        CACF can't deal with null valueFunctions, so avoid setting it when it doesn't
        exist.

        This also adds logic to the Windows Hook in LayerChangesFlusher to prevent it
        from catching the null pointer exception generated by the pause-crash.html test
        before this bug was fixed. Windows was ignoring the exception, so the testcase
        would appear to succeed, even though it should have crashed.

        This is a resubmission of http://trac.webkit.org/changeset/95243 with a build fix.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/graphics/ca/win/LayerChangesFlusher.cpp:
        (WebCore::LayerChangesFlusher::hookCallback):
        * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
        (PlatformCAAnimation::copy):
        * platform/win/StructuredExceptionHandlerSupressor.h: Added.
        (WebCore::StructuredExceptionHandlerSupressor::StructuredExceptionHandlerSupressor):
        (WebCore::StructuredExceptionHandlerSupressor::~StructuredExceptionHandlerSupressor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect selection with absolutely positioned div
rniwa@webkit.org [Mon, 19 Sep 2011 21:51:44 +0000 (21:51 +0000)]
Incorrect selection with absolutely positioned div
https://bugs.webkit.org/show_bug.cgi?id=39503

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The bug was caused by a false assumption in RenderBlock::positionForPoint. Because the last child box
can be positioned, floated, invisible, etc..., we can't always trust last child's logicalTop to tell us
whether a given point is inside or below the last child box.

Fixed the bug by using the last hit-test candidate instead.

Test: editing/selection/block-with-positioned-lastchild.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPoint):

LayoutTests:

Added a regression test for placing the caret inside a block with multiple logical lines
with an absolutely positioned last child. WebKit should place the caret on the left of the first line
(instead of after the last line) when the user clicks on the left of the first line.

* editing/selection/block-with-positioned-lastchild-expected.txt: Added.
* editing/selection/block-with-positioned-lastchild.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Chromium Rebaselines for r95461.
inferno@chromium.org [Mon, 19 Sep 2011 21:48:27 +0000 (21:48 +0000)]
Unreviewed. Chromium Rebaselines for r95461.

* platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-before-after-content-around-block-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-before-after-content-around-table-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-before-after-content-around-block-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-before-after-content-around-table-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-before-after-content-around-table-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
* platform/chromium-win/fast/table/table-row-before-after-content-around-block-expected.png: Added.
* platform/chromium-win/fast/table/table-row-before-after-content-around-table-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix crashes when running WebKit1 tests.
andersca@apple.com [Mon, 19 Sep 2011 21:47:01 +0000 (21:47 +0000)]
Fix crashes when running WebKit1 tests.

-[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
equivalent code directly into -[WebHTMLView drawRect:].

* WebView/WebHTMLView.mm:
(-[WebHTMLView drawRect:]):
* WebView/WebViewInternal.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r95466.
commit-queue@webkit.org [Mon, 19 Sep 2011 21:28:06 +0000 (21:28 +0000)]
Unreviewed, rolling out r95466.
http://trac.webkit.org/changeset/95466
https://bugs.webkit.org/show_bug.cgi?id=68389

Incorrect version of the patch. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toPrimitive):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toPrimitive):
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the last remains of viewless WebKit1
andersca@apple.com [Mon, 19 Sep 2011 21:25:40 +0000 (21:25 +0000)]
Remove the last remains of viewless WebKit1
https://bugs.webkit.org/show_bug.cgi?id=68388

Reviewed by Darin Adler.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::forceLayoutForNonHTML):
Remove null check.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove usesDocumentViews parameter and checks.

(-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
Add an assertion that usesDocumentViews is always true.

(-[WebView _isUsingAcceleratedCompositing]):
Remove usesDocumentViews check.

(-[WebView _isSoftwareRenderable]):
Remove usesDocumentViews check.

(-[WebView initWithFrame:frameName:groupName:]):
Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.

(-[WebView initWithCoder:]):
Remove usesDocumentViews parameter.

(-[WebView _frameViewAtWindowPoint:]):
Remove usesDocumentViews check.

* WebView/WebViewData.h:
Remove usesDocumentViews ivar.

* WebView/WebViewPrivate.h:
Remove usesDocumentViews parameters.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Make loading errors API easier to use.
alexis.menard@openbossa.org [Mon, 19 Sep 2011 21:09:56 +0000 (21:09 +0000)]
[Qt][WK2] Make loading errors API easier to use.
https://bugs.webkit.org/show_bug.cgi?id=68357

Reviewed by Tor Arne Vestbø.

Make the API to get loading errors easier to use. 95197 introduced
a QJSValue API that is a bit opaque for the client code. Rather than
using a dedicated object, we can just pass the needed information as
parameters of the slot.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::loadDidFail):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp:
(tst_CommonViewTests::loadNonexistentFileUrl):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::WebViewAbstraction):
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loadDidFail):
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::loadDidFail):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
dimich@chromium.org [Mon, 19 Sep 2011 21:05:28 +0000 (21:05 +0000)]
[Chromium] Crash after magic iframe transfer for Pepper/NaCl plugins.
https://bugs.webkit.org/show_bug.cgi?id=68267
Make adoptNode() to not enable live iframe transfer when the iframe's subtree contains plugins.

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/frames/iframe-reparenting-embed-elements.html

* dom/Document.cpp:
(WebCore::Document::adoptNode):
* html/HTMLFrameElementBase.cpp:
(WebCore::hasPluginElements):
(WebCore::HTMLFrameElementBase::canRemainAliveOnRemovalFromTree):
* html/HTMLFrameElementBase.h:

LayoutTests:

* fast/frames/iframe-reparenting-embed-elements-expected.txt: Added.
* fast/frames/iframe-reparenting-embed-elements.html: Added.
* fast/frames/resources/iframe-reparenting-embed-frame1.html: Added.
* fast/frames/resources/iframe-reparenting-embed-iframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove WebViewEventHandling.mm
andersca@apple.com [Mon, 19 Sep 2011 20:55:48 +0000 (20:55 +0000)]
Remove WebViewEventHandling.mm
https://bugs.webkit.org/show_bug.cgi?id=68387

Reviewed by Adam Roben.

../..:

Remove WebViewEventHandling.mm from the Xcode project.

* WebKit.xcodeproj/project.pbxproj:

../../mac:

WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
we're getting rid of viewless WebKit1.

* WebView/WebView.mm:
(-[WebView _close]):
* WebView/WebViewData.h:
* WebView/WebViewEventHandling.mm: Removed.
* WebView/WebViewInternal.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove -[WebView _selectionChanged] and -[WebView _setTooltip:]
andersca@apple.com [Mon, 19 Sep 2011 20:39:15 +0000 (20:39 +0000)]
Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
https://bugs.webkit.org/show_bug.cgi?id=68385

Reviewed by Adam Roben.

Move these functions back into the respective clients and remove usesDocumentViews checks.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::setToolTip):
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::respondToChangedSelection):
* WebView/WebView.mm:
* WebView/WebViewEventHandling.mm:
* WebView/WebViewInternal.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove toPrimitive from JSCell
mhahnenberg@apple.com [Mon, 19 Sep 2011 20:32:52 +0000 (20:32 +0000)]
Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Reviewed by Geoffrey Garen.

Part of the refactoring process to un-virtualize JSCell.  We move
all of the implicit functionality provided by the virtual toPrimitive method
in JSCell to be explicit in JSValue::toPrimitive and JSCell:toPrimitive while
also de-virtualizing JSCell::toPrimitive.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
(JSC::JSCell::toPrimitive):
* runtime/JSCell.h:

We replace JSNotAnObject::toPrimitive with defaultValue, which it overrides from
JSObject.  This pushes the virtual method further down, enabling us to get rid
of the virtual call in JSCell.  Eventually we'll probably have to deal with this
again, but we'll cross that bridge when we come to it.
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::defaultValue):
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
(JSC::JSValue::toPrimitive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBegin removing -[WebView _usesDocumentCalls] from WebView.mm
andersca@apple.com [Mon, 19 Sep 2011 20:27:42 +0000 (20:27 +0000)]
Begin removing -[WebView _usesDocumentCalls] from WebView.mm
https://bugs.webkit.org/show_bug.cgi?id=68383

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

* WebView/WebView.mm:
(-[WebView selectedFrame]):
(-[WebView setHostWindow:]):
(-[WebView acceptsFirstResponder]):
(-[WebView becomeFirstResponder]):
(-[WebView _webcore_effectiveFirstResponder]):
(-[WebView setNextKeyView:]):
(-[WebView setHoverFeedbackSuspended:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Issues with merging ruby bases.
inferno@chromium.org [Mon, 19 Sep 2011 20:20:13 +0000 (20:20 +0000)]
Source/WebCore: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

1) Change fromBeforeChild to beforeChild to match
webkit rendering naming conventions.
2) Add assert to verify ruby base is indeed emptied
after collecting all children in a single base.
3) Fix condition in mergeBlockChildren to bail out only
when we have no children and there is no work to merge
children to toBase.

Test: fast/ruby/ruby-overhang-crash.html

* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveChildren):
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
(WebCore::RenderRubyBase::mergeBlockChildren):
* rendering/RenderRubyBase.h:
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::removeChild):

LayoutTests: Issues with merging ruby bases.
https://bugs.webkit.org/show_bug.cgi?id=67240

Reviewed by James Robinson.

ASSERTION FAILED: !needsLayout() in RenderRubyRun::getOverhang.

* fast/ruby/ruby-overhang-crash-expected.txt: Added.
* fast/ruby/ruby-overhang-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChild not placed correctly when beforeChild (table part)
inferno@chromium.org [Mon, 19 Sep 2011 20:17:53 +0000 (20:17 +0000)]
Child not placed correctly when beforeChild (table part)
has both :before, :after content.
https://bugs.webkit.org/show_bug.cgi?id=67656

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/table/table-cell-before-after-content-around-table-block.html
       fast/table/table-cell-before-after-content-around-table-row.html
       fast/table/table-cell-before-after-content-around-table.html
       fast/table/table-row-before-after-content-around-block.html
       fast/table/table-row-before-after-content-around-table.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
1. Use the new helper functions findAfterContentRenderer,
   anonymousContainer.
2. Rename anonymousChild to better name - beforeChildAnonymousContainer.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
When adding a new child, if beforeChild is a table part(
Table/TableSection/TableRow), we need to check if both
:before, :after content are shoved in one of the anonymous child.
If yes, we need to split the :before, :after content before adding
newChild. Easiest approach is to destroy the :before content, then add
the newChild and then call updateBeforeAfterContent to recreate the
:before content.
* rendering/RenderObject.h:
(WebCore::RenderObject::findBeforeContentRenderer): same as
beforePseudoElementRenderer, but ignores text childs since they are
sequentially added.
(WebCore::RenderObject::findAfterContentRenderer): same.
(WebCore::RenderObject::anonymousContainer):
(WebCore::objectIsRelayoutBoundary):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): use the new helpers and functionally
correct functions - findAfterContentRenderer, anonymousContainer. previous
implementation was wrong since it would not go inside, if :after content
is embedded deeper than one level.
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): same.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): same.

LayoutTests:

* fast/table/table-cell-before-after-content-around-table-block-expected.png: Added.
* fast/table/table-cell-before-after-content-around-table-block-expected.txt: Added.
* fast/table/table-cell-before-after-content-around-table-block.html: Added.
* fast/table/table-cell-before-after-content-around-table-expected.png: Added.
* fast/table/table-cell-before-after-content-around-table-expected.txt: Added.
* fast/table/table-cell-before-after-content-around-table-row-expected.png: Added.
* fast/table/table-cell-before-after-content-around-table-row-expected.txt: Added.
* fast/table/table-cell-before-after-content-around-table-row.html: Added.
* fast/table/table-cell-before-after-content-around-table.html: Added.
* fast/table/table-row-before-after-content-around-block-expected.png: Added.
* fast/table/table-row-before-after-content-around-block-expected.txt: Added.
* fast/table/table-row-before-after-content-around-block.html: Added.
* fast/table/table-row-before-after-content-around-table-expected.png: Added.
* fast/table/table-row-before-after-content-around-table-expected.txt: Added.
* fast/table/table-row-before-after-content-around-table.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
andersca@apple.com [Mon, 19 Sep 2011 20:07:46 +0000 (20:07 +0000)]
Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
https://bugs.webkit.org/show_bug.cgi?id=68379

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::hasHTMLView):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebFrameLoaderClient::createFrame):
* WebView/WebFrame.mm:
(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
(-[WebFrame _hasSelection]):
(-[WebFrame _clearSelection]):
(-[WebFrame _shouldFlattenCompositingLayers:]):
(-[WebFrame _dragSourceEndedAt:operation:]):
(-[WebFrame frameView]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove calls to -[WebView _usesDocumentViews]
andersca@apple.com [Mon, 19 Sep 2011 19:46:42 +0000 (19:46 +0000)]
Remove calls to -[WebView _usesDocumentViews]
https://bugs.webkit.org/show_bug.cgi?id=68377

Reviewed by Adam Roben.

Remove checks and begin assuming that -[WebView _usesDocumentViews] always
returns true, since viewless WebKit1 has been abandoned.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::windowResizerRect):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::screenToWindow):
(WebChromeClient::windowToScreen):
(WebChromeClient::platformPageClient):
(WebChromeClient::scrollRectIntoView):
(WebChromeClient::print):
* WebView/WebDataSource.mm:
(-[WebDataSource _receivedData:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor95385 broke Chromium. Fix it.
aa@chromium.org [Mon, 19 Sep 2011 19:44:18 +0000 (19:44 +0000)]
r95385 broke Chromium. Fix it.
https://bugs.webkit.org/show_bug.cgi?id=68378

Unreviewed, build fix.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, build fix
jochen@chromium.org [Mon, 19 Sep 2011 19:38:32 +0000 (19:38 +0000)]
Unreviewed, build fix

It's not enough to disable clang plugins.

* gyp_webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
oliver@apple.com [Mon, 19 Sep 2011 19:33:21 +0000 (19:33 +0000)]
Build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Disable clang when building chromium in WebKit
jochen@chromium.org [Mon, 19 Sep 2011 19:19:47 +0000 (19:19 +0000)]
[chromium] Disable clang when building chromium in WebKit
https://bugs.webkit.org/show_bug.cgi?id=68343

Reviewed by Adam Barth.

* DEPS:
* gyp_webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename NewSpace.{h,cpp} to MarkedSpace.{h,cpp}
oliver@apple.com [Mon, 19 Sep 2011 19:14:53 +0000 (19:14 +0000)]
Rename NewSpace.{h,cpp} to MarkedSpace.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=68376

Reviewed by Gavin Barraclough.

Renamed the the MarkedSpace files to match new name, and
updated the relevant references.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.h:
* heap/MarkedSpace.cpp: Renamed from Source/JavaScriptCore/heap/NewSpace.cpp.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):
* heap/MarkedSpace.h: Renamed from Source/JavaScriptCore/heap/NewSpace.h.
(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):
* runtime/JSCell.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Gesture recognizer fires taptype only every other touch
commit-queue@webkit.org [Mon, 19 Sep 2011 19:13:04 +0000 (19:13 +0000)]
[chromium] Gesture recognizer fires taptype only every other touch
down/up sequence https://bugs.webkit.org/show_bug.cgi?id=68368

Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. This change simplifies the logic
and handles all outgoing edges.

* platform/chromium/GestureRecognizerChromium.cpp:
(WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
(WebCore::GestureRecognizerChromium::isInSecondClickTimeWindow):
(WebCore::GestureRecognizerChromium::updateValues):
(WebCore::GestureRecognizerChromium::touchDown):
(WebCore::GestureRecognizerChromium::click):
* platform/chromium/GestureRecognizerChromium.h:

Source/WebKit/chromium:

The addition of doubletap detection to the gesture recognizer missed some of the
outgoing edges in the recognizer state machine. Thsi change simplifies the logic
and handles all outgoing edges.

* tests/InnerGestureRecognizerTest.cpp:
Additional tests added to ensure that all edges in the state
machine are accounted for.
(BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
(SimulateAndTestFirstClick):
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix xssauditor bypass with unterminated closing tag by making the HTMLSourceTracker
commit-queue@webkit.org [Mon, 19 Sep 2011 18:59:21 +0000 (18:59 +0000)]
Fix xssauditor bypass with unterminated closing tag by making the HTMLSourceTracker
and the HTMLParser interact more closely with each other.  HTMLParser should be
setting the end range for the token itself to account for buffering that the
HTMLSourceTracker can't know about, but there are a lot of paths that would need
updating. First step is to cover this one path.
https://bugs.webkit.org/show_bug.cgi?id=68281

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-19
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html

* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::end):
* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::nextToken):

LayoutTests:

* http/tests/security/xssAuditor/resources/echo-intertag.pl:
* http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename NewSpace to MarkedSpace
oliver@apple.com [Mon, 19 Sep 2011 18:54:33 +0000 (18:54 +0000)]
Rename NewSpace to MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=68375

Reviewed by Gavin Barraclough.

Rename NewSpace to a more accurate name, and update all uses.
This patch doesn't rename the files themselves as that will
just make the patch appear bigger than it is.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::tryAllocate):
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
(JSC::Heap::isValidAllocation):
(JSC::Heap::shrink):
* heap/Heap.h:
(JSC::Heap::markedSpace):
(JSC::Heap::sizeClassFor):
(JSC::Heap::allocate):
* heap/NewSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::addBlock):
(JSC::MarkedSpace::removeBlock):
(JSC::MarkedSpace::resetAllocator):
(JSC::MarkedSpace::canonicalizeBlocks):
* heap/NewSpace.h:
(JSC::MarkedSpace::waterMark):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
(JSC::MarkedSpace::sizeClassFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::SizeClass::SizeClass):
(JSC::MarkedSpace::SizeClass::resetAllocator):
(JSC::MarkedSpace::SizeClass::canonicalizeBlock):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes
commit-queue@webkit.org [Mon, 19 Sep 2011 18:45:47 +0000 (18:45 +0000)]
TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes
https://bugs.webkit.org/show_bug.cgi?id=63541

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-09-19
Reviewed by Adam Barth.

Source/JavaScriptCore:

* parser/SourceProvider.h:
(JSC::SourceProvider::startPosition):
* wtf/text/TextPosition.h:
(WTF::OrdinalNumber::fromZeroBasedInt):
(WTF::OrdinalNumber::fromOneBasedInt):
(WTF::OrdinalNumber::OrdinalNumber):
(WTF::OrdinalNumber::zeroBasedInt):
(WTF::OrdinalNumber::oneBasedInt):
(WTF::OrdinalNumber::operator==):
(WTF::OrdinalNumber::operator!=):
(WTF::OrdinalNumber::first):
(WTF::OrdinalNumber::beforeFirst):
(WTF::TextPosition::TextPosition):
(WTF::TextPosition::minimumPosition):
(WTF::TextPosition::belowRangePosition):

Source/WebCore:

No new tests because this patch is not changing behavior.

* bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
* bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::update):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::eventHandlerLineNumber):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
* bindings/js/ScriptDebugServer.h:
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::create):
(WebCore::StringSourceProvider::startPosition):
(WebCore::StringSourceProvider::StringSourceProvider):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::eventHandlerPosition):
* bindings/v8/ScriptController.h:
* bindings/v8/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener):
* bindings/v8/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::startPosition):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
* bindings/v8/V8LazyEventListener.h:
(WebCore::V8LazyEventListener::create):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::compileScript):
(WebCore::V8Proxy::evaluate):
(WebCore::V8Proxy::runScript):
* bindings/v8/V8Proxy.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate):
(WebCore::WorkerContextExecutionProxy::runScript):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
* dom/PendingScript.h:
(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
* dom/ScriptElement.h:
* dom/ScriptableDocumentParser.h:
* dom/ViewportArguments.cpp:
(WebCore::parserLineNumber):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLInputStream.h:
* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::runScript):
* html/parser/HTMLScriptRunner.h:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::uninitializedPositionValue1):
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
* html/parser/HTMLTreeBuilder.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::buildInitiatorObject):
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::currentLine):
(WebCore::SegmentedString::currentColumn):
(WebCore::SegmentedString::setCurrentPosition):
* platform/text/SegmentedString.h:
* svg/SVGDocumentExtensions.cpp:
(WebCore::parserLineNumber):
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):
* xml/XMLErrors.h:
* xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::lineNumber):
* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::processScript):
(WebCore::NewXMLDocumentParser::textPosition):
(WebCore::NewXMLDocumentParser::lineNumber):
* xml/parser/NewXMLDocumentParser.h:
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):
* xml/parser/XMLDocumentParser.h:
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::error):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::lineNumber):
(WebCore::XMLDocumentParser::columnNumber):
(WebCore::XMLDocumentParser::textPosition):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):

Source/WebKit/chromium:

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::executeScript):
(WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
(WebKit::WebFrameImpl::executeScriptAndReturnValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains Objective-C class...
mitz@apple.com [Mon, 19 Sep 2011 18:36:16 +0000 (18:36 +0000)]
Source/JavaScriptCore: JavaScriptCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed WTFMainThreadCaller to JSWTFMainThreadCaller.

* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThreadPlatform):

Source/WebCore: WebCore part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed AccessibilityObjectWrapper to WebAccessibilityObjectWrapper.
Renamed CascadeList to WebCascadeList.
Renamed CookieStorageObjCAdapter to WebCookieStorageObjCAdapter.
Renamed LanguageChangeObserver to WebLanguageChangeObserver.
Renamed ScrollAnimationHelperDelegate to WebScrollAnimationHelperDelegate.
Renamed ScrollbarPainterControllerDelegate to WebScrollbarPainterControllerDelegate.
Renamed ScrollbarPainterDelegate to WebScrollbarPainterDelegate.
Renamed ScrollbarPartAnimation to WebScrollbarPartAnimation.
Renamed ScrollbarPrefsObserver to WebScrollbarPrefsObserver.

* WebCore.gyp/WebCore.gyp: Updated for the renaming of CascadeList to WebCascadeList.
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityObject.h:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
* accessibility/mac/AccessibilityObjectMac.mm:
* accessibility/mac/AccessibilityObjectWrapper.h: Removed.
* accessibility/mac/AccessibilityObjectWrapper.mm: Removed.
* accessibility/mac/WebAccessibilityObjectWrapper.h: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.h.
* accessibility/mac/WebAccessibilityObjectWrapper.mm: Copied from Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm.
(convertToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
* platform/mac/Language.mm:
(WebCore::platformDefaultLanguage):
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
* platform/network/mac/CookieStorageMac.mm:
(WebCore::startObservingCookieChanges):

Source/WebKit: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Updated for the renaming of NonBlockingPanel to WebNonBlockingPanel.

* English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib: Removed.
* English.lproj/WebJavaScriptTextInputPanel.nib/designable.nib: Added.
* English.lproj/WebJavaScriptTextInputPanel.nib/info.nib: Removed.
* English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:

Source/WebKit/mac: WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed NonBlockingPanel to WebNonBlockingPanel.
Renamed ThreadEnabler to WebCocoaThreadingEnabler.
Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.

* Misc/WebIconDatabase.mm:
(+[WebCocoaThreadingEnabler enableThreading]):
(importToWebCoreFormat):
* Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
* Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
* Panels/WebAuthenticationPanel.h:
* Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to
WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
cause nightly builds to log an error message when showing the Safari
HTTP authentication sheet and disable the Quit command while the sheet
is disaplyed.
* WebView/WebPDFView.mm:
(-[WebPDFView initWithFrame:]):
(-[WebPDFView _updatePreferencesSoon]):

Source/WebKit2: WebKit2 part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
https://bugs.webkit.org/show_bug.cgi?id=68323

Reviewed by Sam Weinig.

Renamed FullKeyboardAccessWatcher to WKFullKeyboardAccessWatcher.
Renamed AccessibilityWebPageObject to WKAccessibilityWebPageObject.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Removed.
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Removed.
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.h.
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/AccessibilityWebPageObject.mm.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::accessibilityRemoteObject):
* WebProcess/mac/FullKeyboardAccessWatcher.h: Removed.
* WebProcess/mac/FullKeyboardAccessWatcher.mm: Removed.
* WebProcess/mac/WKFullKeyboardAccessWatcher.h: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.h.
* WebProcess/mac/WKFullKeyboardAccessWatcher.mm: Copied from Source/WebKit2/WebProcess/mac/FullKeyboardAccessWatcher.mm.
(+[WKFullKeyboardAccessWatcher fullKeyboardAccessEnabled]):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::fullKeyboardAccessEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove direct property slot pointers from the instruction stream
oliver@apple.com [Mon, 19 Sep 2011 18:30:07 +0000 (18:30 +0000)]
Remove direct property slot pointers from the instruction stream
https://bugs.webkit.org/show_bug.cgi?id=68373

Reviewed by Gavin Barraclough.

Use an indirect load to access prototype properties rather than directly
storing the property address in the instruction stream.  This should allow
further optimisations in future, and also provides a 0.5% win to sunspider.

* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetDirectOffset):
* runtime/JSObject.h:
(JSC::JSObject::addressOfPropertyStorage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyle checker should not check public Qt WK2 API for parameter_name.
alexis.menard@openbossa.org [Mon, 19 Sep 2011 18:29:27 +0000 (18:29 +0000)]
Style checker should not check public Qt WK2 API for parameter_name.
https://bugs.webkit.org/show_bug.cgi?id=68359

Reviewed by Andreas Kling.

The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
Add an exception in the style checker to disable the check. Also added the test for it.

* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove fontDataForCombiningCharacterSequence to fix Skia on Mac build
caryclark@google.com [Mon, 19 Sep 2011 18:27:34 +0000 (18:27 +0000)]
Move fontDataForCombiningCharacterSequence to fix Skia on Mac build
https://bugs.webkit.org/show_bug.cgi?id=68358

Reviewed by Dan Bernstein.

No new tests.

* platform/graphics/mac/FontMac.mm:
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
This moves the implementation from FontMac.mm to
FontComplexTextMac.cpp, so it is visible to the Skia on Mac
platform as well.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK DRT leaks memory while comparing history items
commit-queue@webkit.org [Mon, 19 Sep 2011 18:18:56 +0000 (18:18 +0000)]
GTK DRT leaks memory while comparing history items
https://bugs.webkit.org/show_bug.cgi?id=68086

Source/WebKit/gtk:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() function returns a g_strdup()'d
string, so it should return "gchar*" instead of "const gchar*".

* webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_get_target): Change return type to "gchar*".
* webkit/webkitwebhistoryitemprivate.h: Ditto.

Tools:

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-19
Reviewed by Martin Robinson.

webkit_web_history_item_get_target() returns a g_strdup()'d string,
so memory must be freed before compareHistoryItems() returns.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(compareHistoryItems): Use GOwnPtr to manage memory automatically.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix paths used by update-po, and avoid changing directory
commit-queue@webkit.org [Mon, 19 Sep 2011 18:16:24 +0000 (18:16 +0000)]
Fix paths used by update-po, and avoid changing directory
unnecessarily.

[GTK] make update-po is b0rked
https://bugs.webkit.org/show_bug.cgi?id=68352

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2011-09-19
Reviewed by Martin Robinson.

* GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline expectations and file WK68372.
dslomov@google.com [Mon, 19 Sep 2011 18:12:08 +0000 (18:12 +0000)]
[Chromium] Rebaseline expectations and file WK68372.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildbot marks a nrwt bot red when tests are missing results
commit-queue@webkit.org [Mon, 19 Sep 2011 18:03:06 +0000 (18:03 +0000)]
Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSites that use history pushState or replaceState are recorded in history in Private...
jberlin@webkit.org [Mon, 19 Sep 2011 18:00:45 +0000 (18:00 +0000)]
Sites that use history pushState or replaceState are recorded in history in Private Browsing
mode.
https://bugs.webkit.org/show_bug.cgi?id=68208

Reviewed by Brady Eidson.

Source/WebCore:

Test: TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.

Add the privateBrowsingEnabled check that is used in other places in HistoryController
before calling addVisitedLink and FrameLoaderClient::updateGlobalHistory.

* loader/HistoryController.cpp:
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

Tools:

Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.

* TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
(TestWebKitAPI::didNavigateWithNavigationData):
This is a context history client callback, so it should not be called when in Private
Browsing. Add a call to FAIL().
(TestWebKitAPI::didSameDocumentNavigationForFrame):
This is a page load client callback that happens after the didNavigateWithNavigationData
callback. End the test.
(TestWebKitAPI::TEST):
Enable Private Browsing and load a page that uses history.pushState.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
* TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
Ditto.
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Ditto.
* TestWebKitAPI/win/copy-resources.cmd:
Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove bump allocator
oliver@apple.com [Mon, 19 Sep 2011 17:41:51 +0000 (17:41 +0000)]
Remove bump allocator
https://bugs.webkit.org/show_bug.cgi?id=68370

Reviewed by Sam Weinig.

Can't do anything with this allocator currently, and it's
increasing the complexity of the GC code.  Slight progression
on SunSpider, slight regression (undoing the original progression)
in V8.

* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
(JSC::NewSpace::allocate):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::~JSObject):
(JSC::JSObject::visitChildrenDirect):
* runtime/StorageBarrier.h:
(JSC::StorageBarrier::set):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago [Chromium] Rebaseline expectations due to r95402.
dslomov@google.com [Mon, 19 Sep 2011 17:34:53 +0000 (17:34 +0000)]
[Chromium] Rebaseline expectations due to r95402.

* platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: ScrollbarThemeMock.cpp is already referenced in the
leandro@webkit.org [Mon, 19 Sep 2011 17:18:07 +0000 (17:18 +0000)]
Unreviewed: ScrollbarThemeMock.cpp is already referenced in the
global CMakeLists.txt.

* CMakeListsEfl.txt: Remove reference to platform/mock/ScrollbarThemeMock.cpp.
* CMakeListsWinCE.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox
caio.oliveira@openbossa.org [Mon, 19 Sep 2011 17:14:19 +0000 (17:14 +0000)]
[Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox
https://bugs.webkit.org/show_bug.cgi?id=67938

Reviewed by Andreas Kling.

Implement a WebPopupMenuProxy that uses QtWebComboBox (a QComboBox subclass we
have for WK1). Then use this WebPopupMenuProxy in QDesktopWebView. The implementation
explicitly avoids running a nested mainloop.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
Since we don't run a nested mainloop, we need to keep the client pointer to call
valueChangedForPopupMenu().

* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp: Added.
(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::~WebPopupMenuProxyQtDesktop):
(WebKit::WebPopupMenuProxyQtDesktop::showPopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::hidePopupMenu):
(WebKit::WebPopupMenuProxyQtDesktop::setSelectedIndex):
(WebKit::WebPopupMenuProxyQtDesktop::onPopupMenuHidden):
(WebKit::WebPopupMenuProxyQtDesktop::populate):
* UIProcess/qt/WebPopupMenuProxyQtDesktop.h: Added.
(WebKit::WebPopupMenuProxyQtDesktop::create):
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::createPopupMenuProxy):
* UIProcess/qt/qdesktopwebpageproxy.h:
* WebKit2.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r95416.
commit-queue@webkit.org [Mon, 19 Sep 2011 16:40:53 +0000 (16:40 +0000)]
Unreviewed, rolling out r95416.
http://trac.webkit.org/changeset/95416
https://bugs.webkit.org/show_bug.cgi?id=68367

Broke chromium-mac (Requested by beverloo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed skip inspector/timeline/timeline-animation-frame.html on win platform.
loislo@chromium.org [Mon, 19 Sep 2011 16:26:28 +0000 (16:26 +0000)]
Unreviewed skip inspector/timeline/timeline-animation-frame.html on win platform.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix distcheck build
commit-queue@webkit.org [Mon, 19 Sep 2011 16:22:01 +0000 (16:22 +0000)]
[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68346

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-09-19
Reviewed by Philippe Normand.

Source/JavaScriptCore:

* GNUmakefile.list.am:

Source/WebKit/gtk:

* tests/testmimehandling.c: Remove ogg tests, since the behavious
has changed in libsoup (https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8)
(server_callback):
(mime_type_policy_decision_requested_cb):
(main):
* webkit/webkitwebplugin.cpp: Fix introspection annotation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Mon, 19 Sep 2011 16:07:22 +0000 (16:07 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-19

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed fix for flaky tests.
loislo@chromium.org [Mon, 19 Sep 2011 15:15:49 +0000 (15:15 +0000)]
Unreviewed fix for flaky tests.

* inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
* inspector/timeline/timeline-dom-content-loaded-event.html:
* inspector/timeline/timeline-load-event-expected.txt:
* inspector/timeline/timeline-load-event.html:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Qt gardening.
kbalazs@webkit.org [Mon, 19 Sep 2011 14:45:37 +0000 (14:45 +0000)]
Unreviewed Qt gardening.
https://bugs.webkit.org/show_bug.cgi?id=68360

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-19

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: dos2unix on bindings/js/JSExceptionBase.h
ademar.reis@openbossa.org [Mon, 19 Sep 2011 14:23:29 +0000 (14:23 +0000)]
Unreviewed: dos2unix on bindings/js/JSExceptionBase.h

Visual Studio is choking on this file when generating packages for
Qt-4.8 on Windows:

"""
Source\WebCore\Bindings\js\JSExceptionBase.h:
error C4335: Mac file format detected: please convert the source file
to either DOS or UNIX format
"""

Since from all .cpp or .h files shared by all ports this is the only
one with CRLF line terminations, I'm assuming this was a mistake.

* bindings/js/JSExceptionBase.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add some pixel baselines.
kbalazs@webkit.org [Mon, 19 Sep 2011 14:09:37 +0000 (14:09 +0000)]
[Qt][WK2] Add some pixel baselines.

Unreviewed expectation update.

These baselines was produced in the same environment where the
Szeged WK2 bot runs. The validity of the results had been checked manually.

* platform/qt-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
* platform/qt-wk2/css2.1/t051202-c24-first-lttr-00-b-expected.png: Added.
* platform/qt-wk2/css2.1/t051202-c26-psudo-nest-00-c-expected.png: Added.
* platform/qt-wk2/css2.1/t060401-c32-cascading-00-b-expected.png: Added.
* platform/qt-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5512-brdr-rw-00-b-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5514-brdr-lw-00-b-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5515-brdr-w-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5516-brdr-c-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5517-brdr-s-00-c-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5519-brdr-r-02-e-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5521-brdr-l-02-e-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5522-brdr-00-b-expected.png: Added.
* platform/qt-wk2/css2.1/t0805-c5522-ibrdr-00-a-expected.png: Added.
* platform/qt-wk2/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.png: Added.
* platform/qt-wk2/css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Added.
* platform/qt-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
* platform/qt-wk2/css2.1/t0905-c5525-fltwrap-00-b-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c414-flt-00-d-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c414-flt-01-b-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c414-flt-ln-00-d-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c414-flt-ln-01-d-g-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c414-flt-ln-02-d-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c414-flt-ln-03-d-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
* platform/qt-wk2/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
* platform/qt-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
* platform/qt-wk2/css2.1/t100801-c544-valgn-00-a-ag-expected.png: Added.
* platform/qt-wk2/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
* platform/qt-wk2/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
* platform/qt-wk2/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
* platform/qt-wk2/css2.1/t1202-counter-08-b-expected.png: Added.
* platform/qt-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
* platform/qt-wk2/css2.1/t1601-c547-indent-01-d-expected.png: Added.
* platform/qt-wk2/css2.1/t1602-c546-txt-align-00-b-expected.png: Added.
* platform/qt-wk2/css3/css3-modsel-33-expected.png: Added.
* platform/qt-wk2/css3/css3-modsel-35-expected.png: Added.
* platform/qt-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
* platform/qt-wk2/fast/backgrounds/size/backgroundSize16-expected.png: Added.
* platform/qt-wk2/fast/block/basic/014-expected.png: Added.
* platform/qt-wk2/fast/block/basic/016-expected.png: Added.
* platform/qt-wk2/fast/block/basic/white-space-pre-wraps-expected.png: Added.
* platform/qt-wk2/fast/block/float/003-expected.png: Added.
* platform/qt-wk2/fast/block/float/020-expected.png: Added.
* platform/qt-wk2/fast/block/float/021-expected.png: Added.
* platform/qt-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
* platform/qt-wk2/fast/block/float/nopaint-after-layer-destruction2-expected.png: Added.
* platform/qt-wk2/fast/block/float/width-update-after-clear-expected.png: Added.
* platform/qt-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
* platform/qt-wk2/fast/block/positioning/auto-height-with-top-and-bottom-expected.png: Added.
* platform/qt-wk2/fast/block/positioning/auto/005-expected.png: Added.
* platform/qt-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
* platform/qt-wk2/fast/borders/border-fit-expected.png: Added.
* platform/qt-wk2/fast/borders/border-image-scale-transform-expected.png: Added.
* platform/qt-wk2/fast/borders/border-radius-inline-flow-expected.png: Added.
* platform/qt-wk2/fast/borders/rtl-border-01-expected.png: Added.
* platform/qt-wk2/fast/borders/rtl-border-02-expected.png: Added.
* platform/qt-wk2/fast/borders/rtl-border-03-expected.png: Added.
* platform/qt-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
* platform/qt-wk2/fast/canvas/arc360-expected.png: Added.
* platform/qt-wk2/fast/canvas/canvas-before-css-expected.png: Added.
* platform/qt-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
* platform/qt-wk2/fast/canvas/canvas-zoom-expected.png: Added.
* platform/qt-wk2/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
* platform/qt-wk2/fast/canvas/drawImage-expected.png: Added.
* platform/qt-wk2/fast/canvas/drawImage-with-globalAlpha-expected.png: Added.
* platform/qt-wk2/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
* platform/qt-wk2/fast/canvas/fillrect_gradient-expected.png: Added.
* platform/qt-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/qt-wk2/fast/canvas/patternfill-repeat-expected.png: Added.
* platform/qt-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
* platform/qt-wk2/fast/canvas/shadow-offset-1-expected.png: Added.
* platform/qt-wk2/fast/canvas/shadow-offset-2-expected.png: Added.
* platform/qt-wk2/fast/canvas/shadow-offset-3-expected.png: Added.
* platform/qt-wk2/fast/canvas/shadow-offset-4-expected.png: Added.
* platform/qt-wk2/fast/canvas/shadow-offset-5-expected.png: Added.
* platform/qt-wk2/fast/canvas/shadow-offset-6-expected.png: Added.
* platform/qt-wk2/fast/canvas/shadow-offset-7-expected.png: Added.
* platform/qt-wk2/fast/css-generated-content/012-expected.png: Added.
* platform/qt-wk2/fast/css-generated-content/013-expected.png: Added.
* platform/qt-wk2/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
* platform/qt-wk2/fast/css-generated-content/after-order-expected.png: Added.
* platform/qt-wk2/fast/css-generated-content/hover-style-change-expected.png: Added.
* platform/qt-wk2/fast/css/004-expected.png: Added.
* platform/qt-wk2/fast/css/005-expected.png: Added.
* platform/qt-wk2/fast/css/MarqueeLayoutTest-expected.png: Added.
* platform/qt-wk2/fast/css/ZeroOpacityLayers-expected.png: Added.
* platform/qt-wk2/fast/css/ZeroOpacityLayers2-expected.png: Added.
* platform/qt-wk2/fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
* platform/qt-wk2/fast/css/begin-end-contain-selector-empty-value-expected.png: Added.
* platform/qt-wk2/fast/css/css1_forward_compatible_parsing-expected.png: Added.
* platform/qt-wk2/fast/css/css3-modsel-22-expected.png: Added.
* platform/qt-wk2/fast/css/css3-nth-child-expected.png: Added.
* platform/qt-wk2/fast/css/first-letter-detach-expected.png: Added.
* platform/qt-wk2/fast/css/first-letter-hover-expected.png: Added.
* platform/qt-wk2/fast/css/font-face-implicit-local-font-expected.png: Added.
* platform/qt-wk2/fast/css/hsl-color-expected.png: Added.
* platform/qt-wk2/fast/css/inline-properties-important-expected.png: Added.
* platform/qt-wk2/fast/css/invalidation-errors-2-expected.png: Added.
* platform/qt-wk2/fast/css/invalidation-errors-expected.png: Added.
* platform/qt-wk2/fast/css/non-standard-checkbox-size-expected.png: Added.
* platform/qt-wk2/fast/css/outline-auto-location-expected.png: Added.
* platform/qt-wk2/fast/css/selector-set-attribute-expected.png: Added.
* platform/qt-wk2/fast/css/text-align-expected.png: Added.
* platform/qt-wk2/fast/css/textCapitalizeEdgeCases-expected.png: Added.
* platform/qt-wk2/fast/css/zoom-font-size-expected.png: Added.
* platform/qt-wk2/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
* platform/qt-wk2/fast/dom/HTMLTableElement/colSpan-expected.png: Added.
* platform/qt-wk2/fast/dom/HTMLTableElement/createCaption-expected.png: Added.
* platform/qt-wk2/fast/dom/children-nodes-expected.png: Added.
* platform/qt-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
* platform/qt-wk2/fast/dom/css-rule-functions-expected.png: Added.
* platform/qt-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
* platform/qt-wk2/fast/dynamic/selection-highlight-adjust-expected.png: Added.
* platform/qt-wk2/fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
* platform/qt-wk2/fast/forms/basic-selects-expected.png: Added.
* platform/qt-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
* platform/qt-wk2/fast/forms/input-placeholder-text-indent-expected.png: Added.
* platform/qt-wk2/fast/forms/minWidthPercent-expected.png: Added.
* platform/qt-wk2/fast/frames/frame-scrolling-attribute-expected.png: Added.
* platform/qt-wk2/fast/gradients/radial-centered-expected.png: Added.
* platform/qt-wk2/fast/html/details-writing-mode-expected.png: Added.
* platform/qt-wk2/fast/inline/continuation-outlines-expected.png: Added.
* platform/qt-wk2/fast/inline/continuation-outlines-with-layers-expected.png: Added.
* platform/qt-wk2/fast/lists/001-vertical-expected.png: Added.
* platform/qt-wk2/fast/lists/007-vertical-expected.png: Added.
* platform/qt-wk2/fast/lists/008-vertical-expected.png: Added.
* platform/qt-wk2/fast/media/mq-relative-constraints-08-expected.png: Added.
* platform/qt-wk2/fast/multicol/client-rects-expected.png: Added.
* platform/qt-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
* platform/qt-wk2/fast/multicol/float-multicol-expected.png: Added.
* platform/qt-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
* platform/qt-wk2/fast/multicol/float-paginate-expected.png: Added.
* platform/qt-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
* platform/qt-wk2/fast/multicol/margin-collapse-expected.png: Added.
* platform/qt-wk2/fast/multicol/max-height-columns-block-expected.png: Added.
* platform/qt-wk2/fast/multicol/nested-columns-expected.png: Added.
* platform/qt-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
* platform/qt-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
* platform/qt-wk2/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
* platform/qt-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
* platform/qt-wk2/fast/multicol/table-margin-collapse-expected.png: Added.
* platform/qt-wk2/fast/multicol/table-vertical-align-expected.png: Added.
* platform/qt-wk2/fast/multicol/unsplittable-inline-block-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/column-rules-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/column-rules-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
* platform/qt-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
* platform/qt-wk2/fast/overflow/line-clamp-expected.png: Added.
* platform/qt-wk2/fast/overflow/overflow-rtl-vertical-expected.png: Added.
* platform/qt-wk2/fast/overflow/table-overflow-float-expected.png: Added.
* platform/qt-wk2/fast/reflections/opacity-reflection-transform-expected.png: Added.
* platform/qt-wk2/fast/repaint/bugzilla-6278-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-1-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-10-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-2-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-3-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-4-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-5-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-6-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-7-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-8-expected.png: Added.
* platform/qt-wk2/fast/repaint/line-flow-with-floats-9-expected.png: Added.
* platform/qt-wk2/fast/repaint/multicol-repaint-expected.png: Added.
* platform/qt-wk2/fast/repaint/outline-repaint-glitch-expected.png: Added.
* platform/qt-wk2/fast/repaint/selected-replaced-expected.png: Added.
* platform/qt-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
* platform/qt-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
* platform/qt-wk2/fast/repaint/text-append-dirty-lines-expected.png: Added.
* platform/qt-wk2/fast/replaced/001-expected.png: Added.
* platform/qt-wk2/fast/replaced/002-expected.png: Added.
* platform/qt-wk2/fast/replaced/003-expected.png: Added.
* platform/qt-wk2/fast/replaced/005-expected.png: Added.
* platform/qt-wk2/fast/replaced/absolute-image-sizing-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: extend UI perf tests coverage. Elements Panel.
loislo@chromium.org [Mon, 19 Sep 2011 13:33:23 +0000 (13:33 +0000)]
Web Inspector: extend UI perf tests coverage. Elements Panel.
https://bugs.webkit.org/show_bug.cgi?id=68263

Reviewed by Pavel Feldman.

* inspector/performance/resources/show-panel-elements.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
loislo@chromium.org [Mon, 19 Sep 2011 13:32:24 +0000 (13:32 +0000)]
Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html
       inspector/timeline/timeline-load-event.html

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

* inspector/timeline/timeline-animation-frame.html:
* inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
* inspector/timeline/timeline-dom-content-loaded-event.html: Added.
* inspector/timeline/timeline-load-event-expected.txt: Added.
* inspector/timeline/timeline-load-event.html: Added.
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUkrainian translation for WebKitGTK+
kov@webkit.org [Mon, 19 Sep 2011 13:04:30 +0000 (13:04 +0000)]
Ukrainian translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=66543

Patch by Yuri Chornoivan  <yurchor@ukr.net> on 2011-08-31
Reviewed by Gustavo Noronha.

* uk.po: updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Mon, 19 Sep 2011 13:04:23 +0000 (13:04 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Updated.
* platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav...
rgabor@webkit.org [Mon, 19 Sep 2011 12:48:48 +0000 (12:48 +0000)]
[Qt] [ARMv5] fast/events/media-element-focus-tab.html fast/spatial-navigation/snav-media-elements.html fail
https://bugs.webkit.org/show_bug.cgi?id=68341

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-19

* platform/qt-arm/Skipped: Skip the failing tests

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-name LayerChromium border functions to reflect that
commit-queue@webkit.org [Mon, 19 Sep 2011 09:19:33 +0000 (09:19 +0000)]
Re-name LayerChromium border functions to reflect that
they are only for debug use.
https://bugs.webkit.org/show_bug.cgi?id=68212

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-19
Reviewed by James Robinson.

Code cleanup towards unit testing.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setDebugBorderColor):
(WebCore::LayerChromium::setDebugBorderWidth):
* platform/graphics/chromium/LayerChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: extend timeline coverage.
loislo@chromium.org [Mon, 19 Sep 2011 08:17:43 +0000 (08:17 +0000)]
Web Inspector: extend timeline coverage.
https://bugs.webkit.org/show_bug.cgi?id=68260

Another place with js function call from native.

Reviewed by Pavel Feldman.

* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-09-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 19 Sep 2011 07:36:12 +0000 (07:36 +0000)]
2011-09-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
        https://bugs.webkit.org/show_bug.cgi?id=67986

        Reviewed by Pavel Feldman.

        Test: inspector/timeline/timeline-animation-frame.html

WebCore:

        * English.lproj/localizedStrings.js:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::callFunction):
        (WebCore::V8Proxy::callFunctionWithoutFrame):
        (WebCore::V8Proxy::instrumentedCallFunction):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/custom/V8CustomVoidCallback.cpp:
        (WebCore::invokeCallback):
        * dom/ScriptedAnimationController.cpp:
        (WebCore::ScriptedAnimationController::registerCallback):
        (WebCore::ScriptedAnimationController::cancelCallback):
        (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl):
        (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
        (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):
        (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::willCallFunction):
        (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback):
        (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback):
        (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent):
        (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
        (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
        (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
        (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
        * inspector/InspectorTimelineAgent.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get _recordStyles):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.prototype._clearPanel):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

        LayoutTests:

        * inspector/timeline/timeline-animation-frame-expected.txt: Added.
        * inspector/timeline/timeline-animation-frame.html: Added.
        * inspector/timeline/timeline-enum-stability-expected.txt:
        * platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
        * platform/qt/Skipped: inspector/timeline/timeline-animation-frame.html was added to the skip list.
        * inspector/timeline/timeline-test.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix distcheck build
carlosgc@webkit.org [Mon, 19 Sep 2011 07:31:19 +0000 (07:31 +0000)]
[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68241

Reviewed by Martin Robinson.

Source/JavaScriptCore:

* GNUmakefile.list.am:

Source/WebCore:

* GNUmakefile.list.am:

Source/WebKit2:

* GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline navigator test for chromium-win-vista.
koz@chromium.org [Mon, 19 Sep 2011 06:50:06 +0000 (06:50 +0000)]
Rebaseline navigator test for chromium-win-vista.
https://bugs.webkit.org/show_bug.cgi?id=68334

Unreviewed. Rebaseline for navigator-detached-no-crash.

* platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: chromium-win: "Save timeline data" does nothing.
loislo@chromium.org [Mon, 19 Sep 2011 05:34:39 +0000 (05:34 +0000)]
Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineModel.prototype._saveToFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved ProfilerServer.
mitz@apple.com [Mon, 19 Sep 2011 01:29:10 +0000 (01:29 +0000)]
Removed ProfilerServer.

Reviewed by Mark Rowe.

* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj:
* profiler/ProfilerServer.h: Removed.
* profiler/ProfilerServer.mm: Removed.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* wscript:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT should inline Math.min, Math.max, and Math.sqrt
fpizlo@apple.com [Sun, 18 Sep 2011 22:29:41 +0000 (22:29 +0000)]
DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318

Reviewed by Gavin Barraclough.

Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.

* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove two files from JavaScriptCore.gypi that were removed in r95240
thakis@chromium.org [Sun, 18 Sep 2011 21:35:46 +0000 (21:35 +0000)]
Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

* JavaScriptCore.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove special case handling of inline storage from the JIT
oliver@apple.com [Sun, 18 Sep 2011 18:38:43 +0000 (18:38 +0000)]
Remove special case handling of inline storage from the JIT
https://bugs.webkit.org/show_bug.cgi?id=68319

Reviewed by Gavin Barraclough.

Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage.  This has no
perf impact.

* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Chromium Mac build after r95391.
mitz@apple.com [Sun, 18 Sep 2011 18:18:26 +0000 (18:18 +0000)]
Try to fix the Chromium Mac build after r95391.

* WebCore.gyp/WebCore.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Chromium Mac build after r95391.
mitz@apple.com [Sun, 18 Sep 2011 18:05:02 +0000 (18:05 +0000)]
Try to fix the Chromium Mac build after r95391.

* WebCore.gyp/WebCore.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Chromium Mac build after r95391.
mitz@apple.com [Sun, 18 Sep 2011 17:27:31 +0000 (17:27 +0000)]
Try to fix the Chromium Mac build after r95391.

* WebCore.gypi: Updated for the renaming of ComplexTextController.cpp.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port.
* platform/graphics/SimpleFontData.h: Ditto.
* platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this
Objective-C++ file to .mm.
* platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSnow Leopard build fix after r95391.
mitz@apple.com [Sun, 18 Sep 2011 17:16:05 +0000 (17:16 +0000)]
Snow Leopard build fix after r95391.

* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLeopard build fix after r95391.
mitz@apple.com [Sun, 18 Sep 2011 17:02:31 +0000 (17:02 +0000)]
Leopard build fix after r95391.

* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Allow Core Text to choose the fallback font for rendering a combining...
mitz@apple.com [Sun, 18 Sep 2011 16:52:31 +0000 (16:52 +0000)]
Source/WebCore: Allow Core Text to choose the fallback font for rendering a combining character sequence

Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

Test: platform/mac/fast/text/combining-character-sequence-fallback.html

* WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++.
I am going to rename this file in a followup patch.

* platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence().

* platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added
a member variable to cache the results of calling this function.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment.
(WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over
characters until the end of a sequence of combining characters, zero-width joiners and zero-width
non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as
a combining character sequence. This stretches the definition a little because the base character
may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered,
true otherwise.
(WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData
variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a
character mapped to the missing glyph. This clarifies that this function does not use glyph IDs.
- Renamed the local variable newC to uppercaseCharacter.
- Changed to use advanceByCombiningCharacterSequence().
- Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter().
  If there are combining marks and none of the fonts in the fallback list can render the sequence alone,
  use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText()
  to allow Core Text to perform its own fallback.
- Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData
  differs from the normal variant.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to
handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function.

* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to
collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font
fallback.

* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData()
by using the primary font data.

* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(-[CascadeList initWithFont:WebCore::character:]): Added.
(-[CascadeList count]): Added.
(-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef
objects based on the font’s fallback list for the character. The list is initialized lazily.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData()
by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback
list and possibly continuing with system fallback.

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character,
calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the
base character (and the system fallback font for that character), returning the first font that can
render the sequence, or 0 if there is none.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::provideStringAndAttributes): Added this Core Text callback.
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render
the sequence using only this font. Caches the result.

LayoutTests: <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

* platform/mac/fast/text/combining-character-sequence-fallback.html: Added.
* platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
* platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated expected results for two tests after r95362.
mitz@apple.com [Sun, 18 Sep 2011 16:21:15 +0000 (16:21 +0000)]
Updated expected results for two tests after r95362.

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT does not have full block-local CSE
fpizlo@apple.com [Sun, 18 Sep 2011 03:47:04 +0000 (03:47 +0000)]
DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316

Reviewed by Oliver Hunt.

This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.

This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.

* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAliasTracker.h: Removed.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomethod_check should repatch itself if it finds that the new structure(s)
fpizlo@apple.com [Sat, 17 Sep 2011 23:33:01 +0000 (23:33 +0000)]
method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294

Reviewed by Gavin Barraclough.

Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.

This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/Structure.h:
(JSC::Structure::transitivelyTransitionedFrom):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrameLoaderClient BackForwardList-related methods are unsued
mihaip@chromium.org [Sat, 17 Sep 2011 23:31:52 +0000 (23:31 +0000)]
FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* history/BackForwardListImpl.cpp:
(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* src/FrameLoaderClientImpl.cpp:
* src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
* WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.order:

Source/WebKit/qt:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientQt.cpp:
* WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
* WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebKitSupport/FrameLoaderClientWx.cpp:
* WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=68307
hyatt@apple.com [Sat, 17 Sep 2011 23:12:16 +0000 (23:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68307

Crash in border image cssText. Make sure to null check all the components, since they're all
optional now.

Reviewed by Sam Weinig.

Source/WebCore:

Added fast/borders/border-image-slice-omission.html

* css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::cssText):

LayoutTests:

* fast/borders/border-image-slice-omission.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRework script context creation/release notifications
aa@chromium.org [Sat, 17 Sep 2011 22:47:09 +0000 (22:47 +0000)]
Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828

Reviewed by Adam Barth.

Source/WebCore:

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
* bindings/v8/V8IsolatedContext.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
* src/FrameLoaderClientImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] fast/events/media-element-focus-tab.html fails
ossy@webkit.org [Sat, 17 Sep 2011 20:10:01 +0000 (20:10 +0000)]
[Qt][WK2] fast/events/media-element-focus-tab.html fails
https://bugs.webkit.org/show_bug.cgi?id=68315

* platform/qt-wk2/Skipped: Skip fast/events/media-element-focus-tab.html until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: file open dialog appears when user clicks on the timeline bar in timel...
loislo@chromium.org [Sat, 17 Sep 2011 17:43:36 +0000 (17:43 +0000)]
Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Pavel Feldman.

       * inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r95372.
jeffm@apple.com [Sat, 17 Sep 2011 15:58:50 +0000 (15:58 +0000)]
Build fix after r95372.

* dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOverride supportsFocus() for HTMLMediaElement.
commit-queue@webkit.org [Sat, 17 Sep 2011 10:57:17 +0000 (10:57 +0000)]
Override supportsFocus() for HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=67190

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-17
Reviewed by Antonio Gomes.

Source/WebCore:

Tests: fast/events/media-element-focus-tab.html
       fast/spatial-navigation/snav-media-elements.html

Return true from supportsFocus() if control's attribute is present or a tabindex is specified.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFocus):
* html/HTMLMediaElement.h:

LayoutTests:

For media elements be able to receive focus without tabindex if
control attribute is present, hence changed
tabindex-focus-blur-all.js and tabindex-focus-blur-all-expected.txt.

* fast/events/media-element-focus-tab-expected.txt: Added.
* fast/events/media-element-focus-tab.html: Added.
* fast/events/resources/tabindex-focus-blur-all.js:
(test):
* fast/events/tabindex-focus-blur-all-expected.txt:
* fast/spatial-navigation/snav-media-elements-expected.txt: Added.
* fast/spatial-navigation/snav-media-elements.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium]The focus of an input field inside an Iframe doesn't get cleared even thoug...
commit-queue@webkit.org [Sat, 17 Sep 2011 09:49:26 +0000 (09:49 +0000)]
[chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.
https://bugs.webkit.org/show_bug.cgi?id=68162

Add a unit-test to check whether the focus of node is get cleared when clearFocusNode called.
This test check for focus of input node inside a frame after clear focus get called.
Patch by chandra shekar vallala <chandra.vallala@motorola.com> on 2011-09-17
Reviewed by Adam Barth.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::clearFocusedNode):
* tests/WebFrameTest.cpp:
(WebKit::TEST_F): Added a unit test to make sure that focus of the node is get cleared.
* tests/data/autofocus_input_field_iframe.html: Added.
* tests/data/iframe_clear_focused_node_test.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Bump minimum requirement for cairo to 1.10.
ryuan.choi@samsung.com [Sat, 17 Sep 2011 09:28:13 +0000 (09:28 +0000)]
[EFL] Bump minimum requirement for cairo to 1.10.
https://bugs.webkit.org/show_bug.cgi?id=68226

Reviewed by Adam Barth.

* Source/cmake/FindCairo.cmake: Check required version.
* Source/cmake/OptionsEfl.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Sat, 17 Sep 2011 09:08:24 +0000 (09:08 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Update after r95335.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed gardening after r95337.
ossy@webkit.org [Sat, 17 Sep 2011 08:59:26 +0000 (08:59 +0000)]
[Qt][WK2] Unreviewed gardening after r95337.

* platform/qt-wk2/Skipped: Skip one more test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
ossy@webkit.org [Sat, 17 Sep 2011 08:06:58 +0000 (08:06 +0000)]
[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
https://bugs.webkit.org/show_bug.cgi?id=68309

* platform/qt-wk2/Skipped: Skip fast/forms/submit-to-blank-multiple-times.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed gardening after r95335.
ossy@webkit.org [Sat, 17 Sep 2011 07:57:56 +0000 (07:57 +0000)]
[Qt][WK2] Unreviewed gardening after r95335.

* platform/qt-wk2/Skipped: Skip new failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Sat, 17 Sep 2011 07:49:33 +0000 (07:49 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip plugins/fullscreen-plugins-dont-reload.html, because ENABLE(FULLSCREEN_API) is disabled on Qt.
* platform/qt/fast/dom/Window/window-properties-expected.png: Updated after r95362.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r95362.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Updated after r95362.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r95362.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename ENABLE(LEVELDB) to USE(LEVELDB)
abarth@webkit.org [Sat, 17 Sep 2011 06:52:28 +0000 (06:52 +0000)]
Rename ENABLE(LEVELDB) to USE(LEVELDB)
https://bugs.webkit.org/show_bug.cgi?id=68290

Reviewed by Darin Adler.

Source/WebCore:

LEVELDB is a library that can be used to implemented INDEXED_DATABASE,
which means it should be a USE not an ENABLE.

* CMakeLists.txt:
* WebCore.gyp/WebCore.gyp:
* platform/leveldb/LevelDBComparator.h:
* platform/leveldb/LevelDBDatabase.cpp:
* platform/leveldb/LevelDBDatabase.h:
* platform/leveldb/LevelDBIterator.h:
* platform/leveldb/LevelDBSlice.h:
* platform/leveldb/LevelDBTransaction.cpp:
* platform/leveldb/LevelDBTransaction.h:
* platform/leveldb/LevelDBWriteBatch.cpp:
* platform/leveldb/LevelDBWriteBatch.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
* storage/IDBLevelDBBackingStore.cpp:
* storage/IDBLevelDBBackingStore.h:
* storage/IDBLevelDBCoding.cpp:
* storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

* features.gypi:
* tests/IDBLevelDBCodingTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce EventTarget memory usage by deferring hash map allocation
commit-queue@webkit.org [Sat, 17 Sep 2011 06:34:05 +0000 (06:34 +0000)]
Reduce EventTarget memory usage by deferring hash map allocation
until there are listeners for more than 1 event type.

http://webkit.org/b/68105

Patch by Andreas Kling <kling@webkit.org> on 2011-09-16
Reviewed by Darin Adler.

Introduce an EventListenerMap class which manages a map of event types that have
one or more listeners connected.

When there is only one event type, it's stored directly on the EventListenerMap
internally, and when more are added it moves to a hash map. It only goes back
from the hash map if all the listeners are removed at once (i.e clear() is called.)

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

    Adding files.

* WebCore.exp.in:

    Export EventListenerMap::contains() for WebKit/mac.

* dom/EventListenerMap.cpp: Added.
(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::~EventListenerMap):
(WebCore::EventListenerMap::isEmpty):
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::eventTypes):
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::nextListener):
* dom/EventListenerMap.h: Added.

* dom/EventTarget.cpp:
(WebCore::EventTargetData::~EventTargetData):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):

* dom/EventTarget.h:
(WebCore::EventTarget::visitJSEventListeners):

    Use EventListenerIterator to visit listeners. (JSC specific.)

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):

    Call EventListenerMap::eventTypes() go get the list of event types
    currently listened for.

* dom/Node.cpp:
(WebCore::Node::removeEventListener):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferEventListenersToShadowTree):

    Move implementations of SVG-specific hacks into EventListenerMap and
    call them from here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't detach elements from the render tree when entering fullscreen mode
koz@chromium.org [Sat, 17 Sep 2011 06:07:42 +0000 (06:07 +0000)]
Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Reviewed by James Robinson.

Test: plugins/fullscreen-plugins-dont-reload.html

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
* rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Reviewed by James Robinson.

* plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
* plugins/fullscreen-plugins-dont-reload.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd non-CG Webkit-Mac builds to flakiness dashboard
commit-queue@webkit.org [Sat, 17 Sep 2011 05:53:51 +0000 (05:53 +0000)]
add non-CG Webkit-Mac builds to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=68265

Patch by Elliot Poger <epoger@google.com> on 2011-09-16
Reviewed by Adam Barth.

As Chromium-on-Mac approaches the switchover from Core Graphics to
Skia, we need to add the Skia version to the flakiness dashboard.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImag...
jochen@chromium.org [Sat, 17 Sep 2011 05:52:07 +0000 (05:52 +0000)]
Source/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame.

Reviewed by Adam Barth.

* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowImage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):

Source/WebKit/chromium: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

* public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowImage):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowImage):
* src/FrameLoaderClientImpl.h:

Tools: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

* DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowImage):
* DumpRenderTree/chromium/WebPermissions.h:

LayoutTests: Add tests for FrameLoaderClient::allowImage.
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

* http/tests/permissionclient/resources/bostin.gif:
* http/tests/permissionclient/resources/redir.php:
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
* platform/http/tests/permissionclient/image-permissions-expected.txt:
* platform/http/tests/permissionclient/image-permissions.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=67733
dslomov@google.com [Sat, 17 Sep 2011 05:30:14 +0000 (05:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67733
[Chromium] Separate WebKit initialization and V8 initialization in chromium port.

Reviewed by Darin Fisher.

* public/WebKit.h:
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95368 268f45cc-cd09-0410-ab3c-d52691b4dbfc