WebKit.git
12 years ago2009-04-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 30 Apr 2009 23:36:38 +0000 (23:36 +0000)]
2009-04-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Gavin Barraclough.

        - Concatenate final three strings in simple replace case at one go

        ~0.2% SunSpider speedup

        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace): Use new replaceRange helper instead of
        taking substrings and concatenating three strings.
        * runtime/UString.cpp:
        (JSC::UString::replaceRange): New helper function.
        * runtime/UString.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 30 Apr 2009 22:58:21 +0000 (22:58 +0000)]
2009-04-30  Geoffrey Garen  <ggaren@apple.com>

        Rubber Stamped by Gavin Barraclough.

        Changed JSValueEncodedAsPtr* => EncodedJSValuePtr to support a non-pointer
        encoding for JSValuePtrs.

        * API/APICast.h:
        (toJS):
        * bytecompiler/BytecodeGenerator.h:
        (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue):
        (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
        * interpreter/Register.h:
        (JSC::Register::):
        * jit/JIT.cpp:
        (JSC::):
        * jit/JIT.h:
        * jit/JITCode.h:
        (JSC::):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_op_add):
        (JSC::JITStubs::cti_op_pre_inc):
        (JSC::JITStubs::cti_op_get_by_id_generic):
        (JSC::JITStubs::cti_op_get_by_id):
        (JSC::JITStubs::cti_op_get_by_id_second):
        (JSC::JITStubs::cti_op_get_by_id_self_fail):
        (JSC::JITStubs::cti_op_get_by_id_proto_list):
        (JSC::JITStubs::cti_op_get_by_id_proto_list_full):
        (JSC::JITStubs::cti_op_get_by_id_proto_fail):
        (JSC::JITStubs::cti_op_get_by_id_array_fail):
        (JSC::JITStubs::cti_op_get_by_id_string_fail):
        (JSC::JITStubs::cti_op_instanceof):
        (JSC::JITStubs::cti_op_del_by_id):
        (JSC::JITStubs::cti_op_mul):
        (JSC::JITStubs::cti_op_call_NotJSFunction):
        (JSC::JITStubs::cti_op_resolve):
        (JSC::JITStubs::cti_op_construct_NotJSConstruct):
        (JSC::JITStubs::cti_op_get_by_val):
        (JSC::JITStubs::cti_op_get_by_val_string):
        (JSC::JITStubs::cti_op_get_by_val_byte_array):
        (JSC::JITStubs::cti_op_sub):
        (JSC::JITStubs::cti_op_lesseq):
        (JSC::JITStubs::cti_op_negate):
        (JSC::JITStubs::cti_op_resolve_base):
        (JSC::JITStubs::cti_op_resolve_skip):
        (JSC::JITStubs::cti_op_resolve_global):
        (JSC::JITStubs::cti_op_div):
        (JSC::JITStubs::cti_op_pre_dec):
        (JSC::JITStubs::cti_op_not):
        (JSC::JITStubs::cti_op_eq):
        (JSC::JITStubs::cti_op_lshift):
        (JSC::JITStubs::cti_op_bitand):
        (JSC::JITStubs::cti_op_rshift):
        (JSC::JITStubs::cti_op_bitnot):
        (JSC::JITStubs::cti_op_mod):
        (JSC::JITStubs::cti_op_less):
        (JSC::JITStubs::cti_op_neq):
        (JSC::JITStubs::cti_op_urshift):
        (JSC::JITStubs::cti_op_bitxor):
        (JSC::JITStubs::cti_op_bitor):
        (JSC::JITStubs::cti_op_call_eval):
        (JSC::JITStubs::cti_op_throw):
        (JSC::JITStubs::cti_op_next_pname):
        (JSC::JITStubs::cti_op_typeof):
        (JSC::JITStubs::cti_op_is_undefined):
        (JSC::JITStubs::cti_op_is_boolean):
        (JSC::JITStubs::cti_op_is_number):
        (JSC::JITStubs::cti_op_is_string):
        (JSC::JITStubs::cti_op_is_object):
        (JSC::JITStubs::cti_op_is_function):
        (JSC::JITStubs::cti_op_stricteq):
        (JSC::JITStubs::cti_op_nstricteq):
        (JSC::JITStubs::cti_op_to_jsnumber):
        (JSC::JITStubs::cti_op_in):
        (JSC::JITStubs::cti_op_del_by_val):
        (JSC::JITStubs::cti_vm_throw):
        * jit/JITStubs.h:
        * runtime/JSValue.h:
        (JSC::JSValuePtr::encode):
        (JSC::JSValuePtr::decode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 22:37:59 +0000 (22:37 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add CHROMIUM guard to unfork Document.cpp

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode): Added guard.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use OwnPtr<HTMLParserQuirks> for m_parserQuirks
ddkilzer@apple.com [Thu, 30 Apr 2009 22:27:22 +0000 (22:27 +0000)]
    Use OwnPtr<HTMLParserQuirks> for m_parserQuirks

        Reviewed by Geoff Garen.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
        * html/HTMLParser.h: Made m_parserQuirks an OwnPtr.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 30 Apr 2009 21:51:57 +0000 (21:51 +0000)]
2009-04-30  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver "Abandon Ship!" Hunt.

        Fix a leak in Yarr.

        All Disjunctions should be recorded in RegexPattern::m_disjunctions,
        so that they can be freed at the end of compilation - copyDisjunction
        is failing to do so.

        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::RegexPatternConstructor::copyDisjunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 30 Apr 2009 21:45:53 +0000 (21:45 +0000)]
2009-04-30  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Fix tests that depend on Mac-specific metrics now that text controls
        are sized according to font metrics (r43007).

        Fixes https://bugs.webkit.org/show_bug.cgi?id=25474.

        * fast/forms/textarea-appearance-wrap-expected.txt:
        * fast/forms/textarea-appearance-wrap.html:
        This test only really cares that a line-wrap character is submitted
        with forms that have the appropriate wrap value and not with other forms.
        So checking that the submit contents have a line-wrap character, instead of
        looking for it in a specific place, is sufficient. This gets around that we
        wrap in a different place in some cases on Mac and Windows.

        * fast/forms/textarea-hard-linewrap-expected.txt: Removed.
        * fast/forms/textarea-hard-linewrap.html: Removed.
        This test is redundant with fast/forms/textarea-appearance-wrap.html.

        * fast/replaced/table-percent-height-expected.txt:
        * fast/replaced/table-percent-height-text-controls-expected.txt: Added.
        * fast/replaced/table-percent-height-text-controls.html: Added.
        * fast/replaced/table-percent-height.html:
        Pulled out the cases in table-percent-height.html that had text controls and moved
        them into their own test. The new test doesn't assert specific metrics, it just
        spits them out. This allows us to have different expected results for Windows and
        Mac without having "FAIL" messages in the expected results. It's not perfect, but
        it seems better than any alternatives I could come up with. We do still print "FAIL"
        if the results don't match any platform.

        * platform/win/Skipped:
        * platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd function to CallFrame for dumping the current JS caller
oliver@apple.com [Thu, 30 Apr 2009 21:38:01 +0000 (21:38 +0000)]
Add function to CallFrame for dumping the current JS caller

Reviewed by Gavin Barraclough.

Added debug only method CallFrame::dumpCaller() that provide the call location
of the deepest currently executing JS function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed ChangeLog entry, added comments.
dglazkov@chromium.org [Thu, 30 Apr 2009 21:28:09 +0000 (21:28 +0000)]
Fixed ChangeLog entry, added comments.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Provide a mechanism to create a quirks delegate for HTMLParser
ddkilzer@apple.com [Thu, 30 Apr 2009 21:26:30 +0000 (21:26 +0000)]
    Provide a mechanism to create a quirks delegate for HTMLParser

        Reviewed by David Hyatt.

WebCore:

        No tests since there is no change in behavior.

        HTMLParserQuirks.h defines an abstract base class that may be
        extended as needed.  The ChromeClient::createHTMLParserQuirks()
        factory method should be used to return an HTMLParserQuirks
        subclassed object when needed.

        * WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks
        using ChromeClient::createHTMLParserQuirks().
        (WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if
        set.
        (WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if
        m_parserQuirks is set.
        (WebCore::HTMLParser::insertNode): Call
        HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set,
        and return early if it returns false.
        (WebCore::HTMLParser::popBlock): Call
        HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and
        return early if it returns false.
        * html/HTMLParser.h: Added m_parserQuirks.
        * html/HTMLParserQuirks.h: Added.
        (WebCore::HTMLParserQuirks::HTMLParserQuirks):
        (WebCore::HTMLParserQuirks::~HTMLParserQuirks):
        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
        * page/ChromeClient.h:
        (WebCore::ChromeClient::createHTMLParserQuirks): Added.

WebKit/gtk:

        * WebCoreSupport/ChromeClientGtk.h:
        (WebKit::ChromeClient::createHTMLParserQuirks): Added.  The
        default implementation of this factory method returns 0.

WebKit/mac:

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::createHTMLParserQuirks): Added.  The default
        implementation of this factory method returns 0.

WebKit/qt:

        * WebCoreSupport/ChromeClientQt.h:
        (WebCore::ChromeClientQt::createHTMLParserQuirks): Added.  The
        default implementation of this factory method returns 0.

WebKit/win:

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::createHTMLParserQuirks): Added.  The default
        implementation of this factory method returns 0.

WebKit/wx:

        * WebKitSupport/ChromeClientWx.h:
        (WebCore::ChromeClientWx::createHTMLParserQuirks): Added.  The
        default implementation of this factory method returns 0.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 21:20:53 +0000 (21:20 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25492
        Add JSC guards around node wrapper cache calls. These are not used by V8.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Added JSC guard.
        * dom/Node.cpp:
        (WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 30 Apr 2009 21:18:31 +0000 (21:18 +0000)]
2009-04-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Geoff Garen.

        - make BaseStrings have themselves as a base, instead of nothing, to remove common branches

        ~0.7% SunSpider speedup

        * runtime/UString.h:
        (JSC::UString::Rep::Rep): For the constructor without a base, set self as base instead of null.
        (JSC::UString::Rep::baseString): Just read m_baseString - no more branching.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
timothy@apple.com [Thu, 30 Apr 2009 21:11:40 +0000 (21:11 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 21:11:25 +0000 (21:11 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25493
        Remove debugger/profiler custom method stubs, catching V8 bindings up to
        http://trac.webkit.org/changeset/43072.

        * bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 30 Apr 2009 21:02:19 +0000 (21:02 +0000)]
2009-04-30  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Two quick improvements to SamplingFlags mechanism.

        SamplingFlags::ScopedFlag class to provide support for automagically
        clearing a flag as it goes out of scope, and add a little more detail
        to the output generated by the tool.

        * bytecode/SamplingTool.cpp:
        (JSC::SamplingFlags::stop):
        * bytecode/SamplingTool.h:
        (JSC::SamplingFlags::ScopedFlag::ScopedFlag):
        (JSC::SamplingFlags::ScopedFlag::~ScopedFlag):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 30 Apr 2009 20:50:16 +0000 (20:50 +0000)]
2009-04-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines

        Use transform-aware quad methods when computing the boundingBoxRect for
        an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().

        Test: accessibility/transformed-element.html

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::boundingBoxRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Restore build event steps that were truncated in r43082
aroben@apple.com [Thu, 30 Apr 2009 20:47:38 +0000 (20:47 +0000)]
    Restore build event steps that were truncated in r43082

        Rubber-stamped by Steve Falkenburg.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
        Re-copied the command lines for the build events from the pre-r43082
        .vcproj files.

        * JavaScriptCore.vcproj/jsc/jsc.vcproj: Removed an unnecessary
        attribute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 30 Apr 2009 20:38:24 +0000 (20:38 +0000)]
2009-04-30  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Unreviewed build GTK build fix

        * configure.ac: typo fix - javascript_debugger should be enable_javascript_debugger

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Move settings from .vcproj files to .vsprops files within the JavaScriptCore...
aroben@apple.com [Thu, 30 Apr 2009 20:24:46 +0000 (20:24 +0000)]
    Move settings from .vcproj files to .vsprops files within the JavaScriptCore directory

        Moving the settings to a .vsprops file means that we will only have to
        change a single setting to affect all configurations, instead of one
        setting per configuration.

        Reviewed by Steve Falkenburg.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
        Moved settings from these files to the new .vsprops files. Note that
        testapi.vcproj had a lot of overrides of default settings that were
        the same as the defaults, which I've removed.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 20:18:09 +0000 (20:18 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, Chromium build fix.

        Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.

        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptGlobalObject::get): Renamed from getObject.
        (WebCore::ScriptGlobalObject::remove): Added.
        * bindings/v8/ScriptObject.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 20:02:58 +0000 (20:02 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25470
        Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

        * WebCore.pro: Fix copy-paste error.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 19:55:03 +0000 (19:55 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25470
        Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

        * GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
        * WebCore.pro: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 19:49:34 +0000 (19:49 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed build fix after r43072.

        * Api/qwebframe.cpp:
        (qt_drt_setJavaScriptProfilingEnabled): Enclose with JAVASCRIPT_DEBUGGER.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 19:49:20 +0000 (19:49 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed build fix after r43063.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::addMessageToConsole):
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 30 Apr 2009 19:48:04 +0000 (19:48 +0000)]
2009-04-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Add a first text iterator test. We'll add more later.
        This test includes some known expected failures. At some point we'll fix those.

        * editing/text-iterator: Added.
        * editing/text-iterator/basic-iteration-expected.txt: Added.
        * editing/text-iterator/basic-iteration.html: Added.
        * editing/text-iterator/resources: Added.
        * editing/text-iterator/resources/TEMPLATE.html: Copied from editing/selection/resources/TEMPLATE.html.
        * editing/text-iterator/resources/basic-iteration.js: Added.

        * platform/gtk/Skipped: Skip editing/text-iterator since only Mac DumpRenderTree has this at the moment.
        * platform/qt/Skipped: Ditto.
        * platform/win/Skipped: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
eric@webkit.org [Thu, 30 Apr 2009 19:40:27 +0000 (19:40 +0000)]
    Reviewed by Darin Adler.

        Change Position to pre-compute the AnchorType and store it.
        Also store a "legacy editing mode" bit on the Position.
        https://bugs.webkit.org/show_bug.cgi?id=24763

        The old Postion(node, offset) constructor creates legacy positions
        but there are new constructors to create explicitly anchored positions
        which the next patch will use.

        Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
        only affect legacy positions, we will be able to distinguish
        between [table, 1] and [table, after] in the code correctly!

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Position.cpp:
        (WebCore::Position::Position):
        (WebCore::Position::moveToPosition):
        (WebCore::Position::moveToOffset):
        (WebCore::Position::anchorTypeForLegacyEditingPosition):
        (WebCore::Position::element):
        * dom/Position.h:
        (WebCore::Position::):
        (WebCore::Position::Position):
        (WebCore::Position::anchorType):
        (WebCore::Position::deprecatedEditingOffset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 19:02:34 +0000 (19:02 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25470
        Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

        * configure.ac: Add autoconfig options, missed in the first commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Thu, 30 Apr 2009 18:57:23 +0000 (18:57 +0000)]
WebCore:

2009-04-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
        collected even if the WorkerContext is still alive.

        Test: fast/workers/worker-context-gc.html

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::mark):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        (WebCore::WorkerContext::completeURL):
        (WebCore::WorkerContext::location):
        * workers/WorkerContext.h:
        (WebCore::WorkerContext::optionalNavigator):
        (WebCore::WorkerContext::optionalLocation):

LayoutTests:

2009-04-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Test for bug where the WorkerLocation and WorkerNavigator wrappers would be
        collected even if the WorkerContext is still alive.

        * fast/workers/worker-context-gc-expected.txt: Added.
        * fast/workers/worker-context-gc.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
dglazkov@chromium.org [Thu, 30 Apr 2009 18:28:12 +0000 (18:28 +0000)]
JavaScriptCore:

2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25470
        Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

        * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.

WebCore:

2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25470
        Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

        * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
        * WebCore.vcproj/build-generated-files.sh: Ditto.
        * bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
        * bindings/js/JSDOMWindowBase.cpp: Ditto.
        * bindings/js/JSInspectorControllerCustom.cpp: Ditto.
        * inspector/InspectorController.cpp: Moved profiler/debugger methods under
            ENABLE(JAVASCRIPT_DEBUGGER) flag.
        * inspector/InspectorController.h: Ditto.
        * inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
        * page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.

WebKit/mac:

2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25470
        Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

        * Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.

WebKitTools:

2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25470
        Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

        * Scripts/build-webkit: Added ENABLE_JAVASCRIPT_DEBUGGER define.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlson.
kdecker@apple.com [Thu, 30 Apr 2009 17:57:27 +0000 (17:57 +0000)]
    Reviewed by Anders Carlson.

        <rdar://problem/6823049>

        Fix an issue where some plug-ins would cause the application icon to constantly bounce
        up and down in the Dock.

        * Plugins/Hosted/NetscapePluginHostProxy.h: Change m_placeholderWindow ivar to be
        a subclass of NSWindow, WebPlaceholderModalWindow.
        * Plugins/Hosted/NetscapePluginHostProxy.mm:  Added WebPlaceholderModalWindow NSWindow subclass.
        (-[WebPlaceholderModalWindow _wantsUserAttention]): Prevent NSApp from calling requestUserAttention:
         when the window is shown modally, even if the app is inactive.
        (WebKit::NetscapePluginHostProxy::beginModal): NSWindow -> WebPlaceholderModalWindow.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 30 Apr 2009 17:27:28 +0000 (17:27 +0000)]
2009-04-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25275
        This patch snuck in a re-definition of a local.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 17:16:17 +0000 (17:16 +0000)]
2009-04-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix a leak introduced yesterday.  Don't allocate a ScheduledAction
        if the toString()ing throws an exception.

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 30 Apr 2009 16:55:02 +0000 (16:55 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25379
        <rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails

        Test: fast/forms/multiple-selected-options-innerHTML.html

        This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
        For normal HTML parsing, it is called immediately after an element is inserted, but for
        innerHTML, it is only called after the whole subtree is inserted into a document.

        It may make sense to harmonize these cases one day, but for now, I only made the minimal
        changes necessary to fix the bug.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
        * html/HTMLSelectElement.h:
        Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide
        which one to keep selected themselves, because their logic assumes normal parsing, with
        insertedIntoTree() called after each element is inserted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dglazkov@chromium.org [Thu, 30 Apr 2009 16:41:14 +0000 (16:41 +0000)]
WebCore:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        Chromium async/out-of-process version of WebInspector is currently not based on
        InspectorController. The reason was that we did not want to interfere with
        the unforking effort, yet wanted to experiment. So we came up with these
        agents concept that basically mimic InspectorController, but separating 'agent'
        nature from the 'transport'. Now that InspectorController is unforked, I am
        planning to bring these concepts into the WebKit land and use what we have in
        Chromium as a proof of concept / experimental playground.

        * loader/EmptyClients.h: added MessageSource and MessageLevel parameters.
        (WebCore::EmptyChromeClient::addMessageToConsole): ditto
        * page/ChromeClient.h: ditto
        * page/Console.cpp: Used new method signature.
        (WebCore::Console::addMessage): ditto

WebKit/gtk:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::addMessageToConsole):
        * WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::addMessageToConsole):

WebKit/win:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::addMessageToConsole):
        * WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2009-04-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25342
        Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

        * WebKitSupport/ChromeClientWx.cpp:
        (WebCore::ChromeClientWx::addMessageToConsole):
        * WebKitSupport/ChromeClientWx.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 30 Apr 2009 16:36:04 +0000 (16:36 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - fix https://bugs.webkit.org/show_bug.cgi?id=25476
          <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
          animation is jittery

        Reverted r42987.

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):

LayoutTests:

        Reviewed by Simon Fraser.

        - updated results for https://bugs.webkit.org/show_bug.cgi?id=25476
          <rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
          animation is jittery

        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        * platform/mac/svg/custom/focus-ring-expected.checksum:
        * platform/mac/svg/custom/focus-ring-expected.png:
        * platform/mac/svg/custom/image-small-width-height-expected.checksum:
        * platform/mac/svg/custom/image-small-width-height-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 30 Apr 2009 16:20:49 +0000 (16:20 +0000)]
WebCore:

2009-04-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
        https://bugs.webkit.org/show_bug.cgi?id=21193

        Some websites use for attributes in script elements to specify events that the script
        should be run for.  One example is greekembassy.org which has the following in their <head>:

        <script for=window event=onresize>
            location.reload(false);
        </script>

        Since we don't support the full for attribute syntax, we would just blissfully ignore the
        condition and execute the code unconditionally.  This caused breakage on multiple real-world
        sites besides greekembassy.org.

        https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
        support for the for attribute in scripts.  In the meantime it's best to not execute them
        unconditionally.

        Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have
          passed, only return true if there is no for attribute in the script element.
        * dom/ScriptElement.h:

        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
        * html/HTMLScriptElement.h:

        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other
          attribute getters do for SVGScriptElement)
        * svg/SVGScriptElement.h:

LayoutTests:

2009-04-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        Test for <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
        https://bugs.webkit.org/show_bug.cgi?id=21193

        * fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt: Added.
        * fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 15:56:17 +0000 (15:56 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skip one more video test that sometimes fails.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add a sometimes-timing-out test to the Windows skipped file
aroben@apple.com [Thu, 30 Apr 2009 15:43:12 +0000 (15:43 +0000)]
    Add a sometimes-timing-out test to the Windows skipped file

        See Bug 25483: http/tests/navigation/redirect-cycle.html sometimes
        times out on Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25483>

        * platform/win/Skipped: Added
        http/tests/navigation/redirect-cycle.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
hausmann@webkit.org [Thu, 30 Apr 2009 15:01:22 +0000 (15:01 +0000)]
2009-04-30  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Implement encloseContentsWith and rename wrap to encloseWith.

Also in encloseWith, make sure that you cannot enclose with
non-enclosable elements.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 14:56:27 +0000 (14:56 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skip two more tests that I had accidentaly generated results for,
        locally.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 14:06:10 +0000 (14:06 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Also disable new tests, and tests that are using stderr.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 13:12:58 +0000 (13:12 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Disabling more video tests that seem to come and go.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 12:06:34 +0000 (12:06 +0000)]
2009-04-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Hopefully last try making the bot green.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 11:09:38 +0000 (11:09 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Rubber-stamped by Simon Hausmann.

        [Qt] Exclude canvas-putImageData.html from the skipped list since
        Canvas's putImageData is implemented in r41355 already.

        * platform/qt/Skipped: Removed canvas-putImageData.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Thu, 30 Apr 2009 10:26:51 +0000 (10:26 +0000)]
2009-04-30  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again

        https://bugs.webkit.org/show_bug.cgi?id=20952

        The QtWebKit port made the mistake of exposing a global history. This broke
        with the addition of PageGroup and LinkHash. This needs to be repaired
        for Qt4.5.

        Add a function to LinkHash.cpp that is resolving a URL. Use this
        function from within CSSStyleSelector to forward the url to the
        QWebHistoryInterface API.

        It is sad that there is a path within visitedLinkHash which is now
        doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
        and using QtWebKit types within WebCore is a layering violation as well.

        PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
        Qt4.6 a second version of the QWebHistoryInterface is going to be
        added which will fix things up.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build.
hausmann@webkit.org [Thu, 30 Apr 2009 10:08:08 +0000 (10:08 +0000)]
Fix the Qt build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 10:04:53 +0000 (10:04 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed build fix, after r43035.

        Temporarily use Position::deprecatedEditingOffset().

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Thu, 30 Apr 2009 10:00:23 +0000 (10:00 +0000)]
2009-04-30  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreview build fix after r43037.

        Use MarkedArgumentBuffer instead of ArgList.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 30 Apr 2009 09:15:36 +0000 (09:15 +0000)]
2009-04-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey Proskuryakov.

        - speed up string concatenation by reorganizing some simple cases

        0.7% SunSpider speedup

        * runtime/UString.cpp:
        (JSC::concatenate): Put fast case for appending a single character
        before the empty string special cases; streamline code a bit to
        delay computing values that are not needed in the fast path.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-30 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 30 Apr 2009 07:52:27 +0000 (07:52 +0000)]
2009-04-30  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Maciej Stachowiak.

        Add SamplingFlags mechanism.

        This mechanism allows fine-grained JSC and JavaScript program aware
        performance measurement.  The mechanism provides a set of 32 flags,
        numbered #1..#32.  Flag #16 is initially set, and all other flags
        are cleared.  Flags may be set and cleared from within

        Enable by setting ENABLE_SAMPLING_FLAGS to 1 in wtf/Platform.h.
        Disabled by default, no performance impact.  Flags may be modified
        by calling SamplingFlags::setFlag() and SamplingFlags::clearFlag()
        from within JSC implementation, or by calling setSamplingFlag() and
        clearSamplingFlag() from JavaScript.

        The flags are sampled with a frequency of 10000Hz, and the highest
        set flag in recorded, allowing multiple events to be measured (with
        the highest flag number representing the highest priority).

        Disabled by default; no performance impact.

        * JavaScriptCore.exp:
        * bytecode/SamplingTool.cpp:
        (JSC::SamplingFlags::sample):
        (JSC::SamplingFlags::start):
        (JSC::SamplingFlags::stop):
        (JSC::SamplingThread::threadStartFunc):
        (JSC::SamplingThread::start):
        (JSC::SamplingThread::stop):
        (JSC::ScopeSampleRecord::sample):
        (JSC::SamplingTool::doRun):
        (JSC::SamplingTool::sample):
        (JSC::SamplingTool::start):
        (JSC::SamplingTool::stop):
        * bytecode/SamplingTool.h:
        (JSC::SamplingFlags::setFlag):
        (JSC::SamplingFlags::clearFlag):
        (JSC::SamplingTool::SamplingTool):
        * jsc.cpp:
        (GlobalObject::GlobalObject):
        (functionSetSamplingFlag):
        (functionClearSamplingFlag):
        (runWithScripts):
        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Thu, 30 Apr 2009 06:47:58 +0000 (06:47 +0000)]
WebCore:

2009-04-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
        setTimeout should stringify non-string/non-function first arguments

        Test: fast/dom/Window/setTimeout-string-argument.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::setTimeout):
        (WebCore::JSWorkerContext::setInterval):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):
        * bindings/js/ScheduledAction.h:

LayoutTests:

2009-04-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=25440
        setTimeout should stringify non-string/non-function first arguments

        * fast/dom/Window/setTimeout-string-argument-expected.txt: Added.
        * fast/dom/Window/setTimeout-string-argument.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore build fixing after r43037.
mrowe@apple.com [Thu, 30 Apr 2009 03:38:57 +0000 (03:38 +0000)]
More build fixing after r43037.

* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 30 Apr 2009 03:03:29 +0000 (03:03 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - WebCore part of <rdar://problem/6609509> Select All and then Delete
          should put Mail editing back into the same state as a new message

        Test: editing/deleting/in-visibly-empty-root.html

        * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
        * editing/SelectionController.h:
        (WebCore::SelectionController::isAll): Added. Calls through to
        VisibleSelection.
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
        of the root editable element the selection is in, other than a
        placeholder. Returns true iff it did anything.
        (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
        visible position in the root editable element, but it has children other
        than a placeholder, remove those children.
        * editing/TypingCommand.h:
        * editing/VisiblePosition.h:
        Added a StayInEditableContent enum and a FIXME.
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::isAll): Added. Returns whether the
        selection encompasses all visible positions, either in the document or
        in the editable root.
        * editing/VisibleSelection.h:

WebKit/mac:

        Reviewed by Simon Fraser.

        - WebKit part of <rdar://problem/6609509> Select All and then Delete
          should put Mail editing back into the same state as a new message

        * WebView/WebView.mm:
        (-[WebView _selectionIsCaret]): Added.
        (-[WebView _selectionIsAll]): Added. Returns whether the selection
        encompasses the entire document.
        * WebView/WebViewPrivate.h:

LayoutTests:

        Reviewed by Simon Fraser.

        - test and updated results for <rdar://problem/6609509> Select All and
          then Delete should put Mail editing back into the same state as a new
          message

        * editing/deleting/in-visibly-empty-root-expected.txt: Added.
        * editing/deleting/in-visibly-empty-root.html: Added.
        * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 02:19:20 +0000 (02:19 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Another attempt to fix the windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 02:12:32 +0000 (02:12 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Fix style nit.

        * editing/visible_units.cpp:
        (WebCore::getLeafBoxesInLogicalOrder):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 30 Apr 2009 02:10:07 +0000 (02:10 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Try and fix the windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 30 Apr 2009 02:02:23 +0000 (02:02 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        For now just drop the deferred layout on the floor, since it causes an infinite hang in mail.  Even
        trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
        assertions.

        Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
        and not do it (which is basically what was happening before).

        * page/FrameView.cpp:
        (WebCore::FrameView::setContentsSize):
        (WebCore::FrameView::needsLayout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Thu, 30 Apr 2009 01:35:07 +0000 (01:35 +0000)]
WebCore:

2009-04-29  Douglas Davidson  <ddavidso@apple.com>

        Reviewed by Justin Garcia.

        <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly

        Updates to the text checking code to enable text checking even if spellchecking is turned off
        and fix an off-by-one error in selection handling.

        * editing/Editor.cpp:
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        * editing/Editor.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::markMisspellingsAfterTyping):

WebKit/mac:

2009-04-29  Douglas Davidson  <ddavidso@apple.com>

        Reviewed by Justin Garcia.

        <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView orderFrontSubstitutionsPanel:]):
        * WebView/WebView.mm:
        (-[WebView validateUserInterfaceItemWithoutDelegate:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 30 Apr 2009 01:34:08 +0000 (01:34 +0000)]
2009-04-29  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver "Peg-Leg" Hunt.

        Coallesce input checking and reduce futzing with the index position
        between alternatives and iterations of the main loop of a regex,
        when run in YARR.

        Consider the following regex:  /foo|bar/

        Prior to this patch, this will be implemented something like this pseudo-code description:

        loop:
            check_for_available_input(3) // this increments the index by 3, for the first alterantive.
                if (available) { test "foo" }
            decrement_index(3)
            check_for_available_input(3) // this increments the index by 3, for the second alterantive.
                if (available) { test "bar" }
            decrement_index(3)
            check_for_available_input(1) // can we loop again?
                if (available) { goto loop }

        With these changes it will look more like this:

            check_for_available_input(3) // this increments the index by 3, for the first alterantive.
            if (!available) { goto fail }
        loop:
            test "foo"
            test "bar"
            check_for_available_input(1) // can we loop again?
                if (available) { goto loop }
        fail:

        This gives about a 5% gain on v8-regex, no change on Sunspider.

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo):
        (JSC::Yarr::RegexGenerator::generateDisjunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean up ArgList to be a trivial type
oliver@apple.com [Thu, 30 Apr 2009 01:21:52 +0000 (01:21 +0000)]
Clean up ArgList to be a trivial type

Reviewed by Gavin Barraclough

Separate out old ArgList logic to handle buffering and marking arguments
into a distinct MarkedArgumentBuffer type.  ArgList becomes a trivial
struct of a pointer and length.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago No review, build fix only.
eric@webkit.org [Thu, 30 Apr 2009 01:16:24 +0000 (01:16 +0000)]
    No review, build fix only.

        Fix m_offset uses added while I wasn't looking.

        * editing/visible_units.cpp:
        (WebCore::logicalStartPositionForLine):
        (WebCore::logicalEndPositionForLine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
eric@webkit.org [Thu, 30 Apr 2009 01:09:57 +0000 (01:09 +0000)]
    Reviewed by Darin Adler.

        Make m_offset private and change all callers to use deprecatedEditingOffset().
        https://bugs.webkit.org/show_bug.cgi?id=25472

        Per Darin's suggestion, this was just a simple search replace
        of .m_offset with .deprecatedEditingOffset().

        There was one change in InsertParagraphSeparatorCommand::doApply to use
        Position::moveToOffset(0) instead of .m_offset = 0;

        * dom/Position.cpp:
        (WebCore::Position::rendersInDifferentPosition):
        (WebCore::Position::leadingWhitespacePosition):
        * dom/Position.h:
        (WebCore::Position::deprecatedEditingOffset):
        (WebCore::Position::moveToOffset):
        (WebCore::operator==):
        * dom/PositionIterator.h:
        (WebCore::PositionIterator::PositionIterator):
        * dom/Range.cpp:
        (WebCore::Range::create):
        (WebCore::Range::compareBoundaryPoints):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::nodeFullySelected):
        (WebCore::ApplyStyleCommand::nodeFullyUnselected):
        (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
        (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
        (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
        (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
        (WebCore::ApplyStyleCommand::joinChildTextNodes):
        * editing/BreakBlockquoteCommand.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        (WebCore::CompositeEditCommand::positionOutsideTabSpan):
        (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
        (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
        (WebCore::CompositeEditCommand::deleteInsignificantText):
        (WebCore::CompositeEditCommand::moveParagraphs):
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForNodeRemoval):
        (WebCore::updatePositionForTextRemoval):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::fixupWhitespace):
        * editing/Editor.cpp:
        (WebCore::Editor::setComposition):
        (WebCore::Editor::advanceToNextMisspelling):
        (WebCore::Editor::getCompositionSelection):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::performTrivialReplace):
        (WebCore::InsertTextCommand::input):
        (WebCore::InsertTextCommand::insertTab):
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::debugRenderer):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter):
        (WebCore::VisiblePosition::debugPosition):
        (WebCore::makeRange):
        (WebCore::setStart):
        (WebCore::setEnd):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::toNormalizedRange):
        (WebCore::makeSearchRange):
        (WebCore::VisibleSelection::debugPosition):
        (WebCore::VisibleSelection::showTreeForThis):
        * editing/htmlediting.cpp:
        (WebCore::comparePositions):
        (WebCore::rangeCompliantEquivalent):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):
        (WebCore::startPositionForLine):
        (WebCore::startOfLine):
        (WebCore::endPositionForLine):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        (WebCore::endOfParagraph):
        (WebCore::logicalStartPositionForLine):
        (WebCore::logicalEndPositionForLine):
        * page/AccessibilityObject.cpp:
        (WebCore::updateAXLineStartForVisiblePosition):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::anchorOffset):
        (WebCore::DOMSelection::focusOffset):
        (WebCore::DOMSelection::baseOffset):
        (WebCore::DOMSelection::extentOffset):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        * page/Frame.cpp:
        (WebCore::Frame::selectionLayoutChanged):
        * page/mac/AccessibilityObjectWrapper.mm:
        (textMarkerForVisiblePosition):
        (visiblePositionForTextMarker):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::indexForVisiblePosition):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeSelection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
eric@webkit.org [Thu, 30 Apr 2009 01:07:41 +0000 (01:07 +0000)]
    Reviewed by Oliver Hunt.

        Re-write image-clipped-hit.svg to be dumpAsText() (and clean up the code to be less insane)

        * platform/mac/svg/custom/image-clipped-hit-expected.checksum: Removed.
        * platform/mac/svg/custom/image-clipped-hit-expected.png: Removed.
        * platform/mac/svg/custom/image-clipped-hit-expected.txt: Removed.
        * platform/qt/svg/custom/image-clipped-hit-expected.txt: Removed.
        * svg/custom/image-clipped-hit.svg:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 30 Apr 2009 00:51:15 +0000 (00:51 +0000)]
2009-04-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Second try at making the bot green.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 30 Apr 2009 00:48:43 +0000 (00:48 +0000)]
WebCore:

2009-04-29  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24168
        RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

        Test: editing/selection/home-end.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary
        (WebCore::SelectionController::modifyExtendingBackward): Change calling
        startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
        to logicalStartOfLine() when granularity is LineBoundary.
        * editing/visible_units.cpp:
        (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
        (WebCore::getLogicalStartBoxAndNode): Added.
        (WebCore::getLogicalEndBoxAndNode): Added.
        (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
        (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
        (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
        (WebCore::inSameLogicalLine): Added.
        (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
        * editing/visible_units.h:

LayoutTests:

2009-04-29  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24168
        RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

        * editing/selection/extend-selection-expected.txt: Added result for extend in
        lineBoundary.
        * editing/selection/extend-selection.html: Added test cases and script for extend
        in lineBoundary.
        * editing/selection/home-end-expected.txt: Added.
        * editing/selection/home-end.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 30 Apr 2009 00:24:57 +0000 (00:24 +0000)]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Fix this test to only use a setTimeout in IE.
        It doesn't need a timeout in WebKit and the
        timeout requires using waitUntilDone/notifyDone,
        which doesn't play nicely with JS tests.

        See https://bugs.webkit.org/show_bug.cgi?id=25471

        * fast/forms/resources/textarea-metrics.js:
        (assertTextareaMetrics):
        * fast/forms/textarea-metrics-expected.txt:
        * platform/win/fast/forms/textarea-metrics-expected.txt:
        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOjan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 29 Apr 2009 23:52:40 +0000 (23:52 +0000)]
Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Put this file in the right place to fix the bot failure.

        * platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/platform/mac-tiger/text-control-intrinsic-widths-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 29 Apr 2009 23:50:11 +0000 (23:50 +0000)]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Skip fast/forms/textarea-metrics.html. It's printing the TEST PASSED
        before the test is finished. There's a race with any JS tests that
        use setTimeout. Fortunately, this test doesn't need the setTimeout,
        so it's easy to fix.

        See https://bugs.webkit.org/show_bug.cgi?id=25471

        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 29 Apr 2009 23:34:26 +0000 (23:34 +0000)]
2009-04-29  Eric Seidel  <eric@webkit.org>

        No review, rolling out a patch.

        Revert http://trac.webkit.org/changeset/43019

        New tests failed because I removed the tabs from them
        when landing (since we avoid tabs in WebKit files).
        I couldn't tell if the new results were correct with
        spaces or not.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingForward):
        (WebCore::SelectionController::modifyMovingForward):
        (WebCore::SelectionController::modifyExtendingBackward):
        (WebCore::SelectionController::modifyMovingBackward):
        * editing/visible_units.cpp:
        * editing/visible_units.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 29 Apr 2009 23:27:29 +0000 (23:27 +0000)]
2009-04-29  Eric Seidel  <eric@webkit.org>

        No review, rolling out a patch.

        Revert 43020 as it caused accessibility/lists.html to fail
        and no one is around to tell me if it's a progression or not.

        * page/AccessibilityObject.h:
        (WebCore::):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::roleValue):
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
        * page/mac/AccessibilityObjectWrapper.mm:
        (RoleEntry::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 29 Apr 2009 23:21:06 +0000 (23:21 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
        when the FrameView is resized.  This bug was exposed by the elimination of the separate WebKit layout
        flag on Mac.

        FrameView now defers setNeedsLayouts during size changes.  Once all of the size changes are finished (including re-entrant ones
        from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::setContentsSize):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::needsLayout):
        (WebCore::FrameView::setNeedsLayout):
        * page/FrameView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 29 Apr 2009 23:20:03 +0000 (23:20 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        Fix a bug in the bounds checking for setNeedsLayout dirtying when a WebView's size changes.  The superview
        of the WebView was being incorrectly checked instead of the WebView itself.

        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix ChangeLog description.
ojan@chromium.org [Wed, 29 Apr 2009 23:09:11 +0000 (23:09 +0000)]
Fix ChangeLog description.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 29 Apr 2009 23:04:50 +0000 (23:04 +0000)]
2009-04-29  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Add expected results for failing tests.

        * platform/win/fast/forms/textarea-metrics-expected.txt:
        Issue with running JS tests that use setTimeout.
        See https://bugs.webkit.org/show_bug.cgi?id=25469

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Antony Sargent <asargent@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 22:48:44 +0000 (22:48 +0000)]
2009-04-29  Antony Sargent  <asargent@chromium.org>

        Reviewed by Dimitri Glazkov and Eric Seidel.

        Use AtomicString to speed up window and document interceptors.
        https://bugs.webkit.org/show_bug.cgi?id=25275

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER):
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::NAMED_PROPERTY_DELETER):
        (WebCore::NAMED_PROPERTY_GETTER):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate build.webkit.org configuration for the addition of the new GTK buildbot.
mrowe@apple.com [Wed, 29 Apr 2009 22:28:21 +0000 (22:28 +0000)]
Update build.webkit.org configuration for the addition of the new GTK buildbot.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
eric@webkit.org [Wed, 29 Apr 2009 22:22:45 +0000 (22:22 +0000)]
2009-04-29  Sankar Aditya Tanguturi  <sankaraditya@gmail.com>

        Reviewed by Jon Honeycutt.

        Add a new accessibility role for list items. Part of
        http://bugs.webkit.org/show_id.cgi?id=20013

        * win/AccessibleBase.cpp:
        (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Xiaomei Ji <xji@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 22:16:38 +0000 (22:16 +0000)]
2009-04-29  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24168
        RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

        Test: editing/selection/home-end.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
        to logicalEndOfLine() when granularity is LineBoundary
        (WebCore::SelectionController::modifyExtendingBackward): Change calling
        startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
        (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
        to logicalStartOfLine() when granularity is LineBoundary.
        * editing/visible_units.cpp:
        (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
        (WebCore::getLogicalStartBoxAndNode): Added.
        (WebCore::getLogicalEndBoxAndNode): Added.
        (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
        (WebCore::logicalStartOfLine): Added. Similar to startOfLine.
        (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
        (WebCore::inSameLogicalLine): Added.
        (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
        * editing/visible_units.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
eric@webkit.org [Wed, 29 Apr 2009 22:14:52 +0000 (22:14 +0000)]
2009-04-29  Sankar Aditya Tanguturi  <sankaraditya@gmail.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=23583
        Populate role attribute for document objects correctly
        on Windows platform.

        * AccessibleDocument.cpp:
        (AccessibleDocument::role): Return ROLE_SYSTEM_DOCUMENT for
        document objects on windows. (Matching Firefox).
        * AccessibleDocument.h: Add the role function prototype in
        header file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIgnore the --use-remote-links-to-tests option for GTK as it leads to
mrowe@apple.com [Wed, 29 Apr 2009 22:11:22 +0000 (22:11 +0000)]
Ignore the --use-remote-links-to-tests option for GTK as it leads to
perl errors being spewed at the end of run-webkit-tests.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement test-result-archive for GTK.
mrowe@apple.com [Wed, 29 Apr 2009 21:54:57 +0000 (21:54 +0000)]
Implement test-result-archive for GTK.

* BuildSlaveSupport/test-result-archive:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-03-27 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
eric@webkit.org [Wed, 29 Apr 2009 21:38:14 +0000 (21:38 +0000)]
2009-03-27  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Simon Hausmann.

        Update the page actions when a finishing loading even if the frame is
        not the top frame such as when browsing inside of a website with frames.
        https://bugs.webkit.org/show_bug.cgi?id=24890

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
        * tests/qwebpage/frametest/frame_a.html: Added.
        * tests/qwebpage/frametest/index.html: Added.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::backActionUpdate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Mike Belshe <mike@belshe.com>
eric@webkit.org [Wed, 29 Apr 2009 21:31:41 +0000 (21:31 +0000)]
2009-04-29  Mike Belshe  <mike@belshe.com>

        Reviewed by Eric Seidel.

        Update location while page is loading.
        https://bugs.webkit.org/show_bug.cgi?id=21597

        Tested by:
        - fast/dom/location-new-window-no-crash
        - fast/dom/Window/window-open-pending-url

        * page/Location.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 29 Apr 2009 21:28:25 +0000 (21:28 +0000)]
2009-04-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Mark Rowe.

        Disable failing tests to make the bot green for its new debut, so
        that we can more easily track regressions.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Feng Qian <feng@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:25:45 +0000 (21:25 +0000)]
2009-04-29  Feng Qian  <feng@chromium.org>

        Reviewed by Darin Adler.

        Add Android port files to WebCore/platform.
        https://bugs.webkit.org/show_bug.cgi?id=23296

        * platform/android: Added.
        * platform/android/ClipboardAndroid.cpp: Added.
        * platform/android/ClipboardAndroid.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Feng Qian <feng@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:23:31 +0000 (21:23 +0000)]
2009-04-29  Feng Qian  <feng@chromium.org>

        Reviewed by Darin Adler.

        Add Android-specific files to the WebCore/page directory.
        https://bugs.webkit.org/show_bug.cgi?id=23295

        * page/android: Added.
        * page/android/DragControllerAndroid.cpp: Added.
        * page/android/EventHandlerAndroid.cpp: Added.
        * page/android/InspectorControllerAndroid.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 21:00:42 +0000 (21:00 +0000)]
2009-04-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Extract PageGroupLoadDeferrer from Chrome.cpp

        * GNUmakefile.am: added PageGroupLoadDeferrer
        * WebCore.pro: ditto
        * WebCore.scons: ditto
        * WebCore.vcproj/WebCore.vcproj: ditto
        * WebCore.xcodeproj/project.pbxproj: ditto
        * WebCoreSources.bkl: ditto
        * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
        * page/PageGroupLoadDeferrer.cpp: Added.
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        * page/PageGroupLoadDeferrer.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlson.
kdecker@apple.com [Wed, 29 Apr 2009 20:55:39 +0000 (20:55 +0000)]
    Reviewed by Anders Carlson.

        Allow WKN_CheckIfAllowedToLoadURL() to take an optional void* context parameter.

        * Plugins/WebNetscapeContainerCheckContextInfo.h:
        * Plugins/WebNetscapeContainerCheckContextInfo.mm:
        (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
        (-[WebNetscapeContainerCheckContextInfo callback]):
        (-[WebNetscapeContainerCheckContextInfo context]):
        * Plugins/WebNetscapeContainerCheckPrivate.h:
        * Plugins/WebNetscapeContainerCheckPrivate.mm:
        (browserContainerCheckFuncs):
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
        (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
        * Plugins/npapi.mm:
        (WKN_CheckIfAllowedToLoadURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 29 Apr 2009 20:43:34 +0000 (20:43 +0000)]
2009-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25334

        Fix Qt build when ENABLE_JIT is explicitly set to 1
        to overrule defaults.

        * JavaScriptCore.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dan Bernstein.
ojan@chromium.org [Wed, 29 Apr 2009 20:31:53 +0000 (20:31 +0000)]
    Reviewed by Dan Bernstein.

        Make textarea and text input metrics more closely match IEs.

        This involves:
        -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
        -set textarea width to cols*avgCharWidth
        -Make default CSS match IEs
        -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.

        Those values for textarea and inputs were derived by doing a ton of manual
        testing of IE's width values for various textareas and fonts. On Windows we match
        IE exactly except for a couple fonts of the ~12 tested.

        To get the average and max character width of a font, we do the following
        for each platform:
        -Win: TextMetrics expose avgCharWidth and maxCharWidth
        -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
            maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
        -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
            maxCharWidth = max of avgCharWidth and m_ascent
        -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
            If either one is non-positive, then calculate the value using the Linux approach.

        Tests: fast/forms/text-control-intrinsic-widths.html
               fast/forms/textarea-metrics.html
               svg/custom/svg-fonts-in-text-controls.html

        * css/html4.css:
        * css/themeWin.css:
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData):
        (WebCore::SimpleFontData::initCharWidths):
        * platform/graphics/SimpleFontData.h:
        (WebCore::SimpleFontData::maxCharWidth):
        (WebCore::SimpleFontData::avgCharWidth):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformCharWidthInit):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::initGDIFont):
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        (WebCore::SimpleFontData::platformCharWidthInit):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::preferredContentWidth):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash in profiler due to incorrect assuming displayName would be a string.
oliver@apple.com [Wed, 29 Apr 2009 20:25:09 +0000 (20:25 +0000)]
Crash in profiler due to incorrect assuming displayName would be a string.

Reviewed by Steve Falkenburg

Fixed by adding a type guard.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Apr 2009 20:23:22 +0000 (20:23 +0000)]
2009-04-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        * bindings/objc/DOMCSS.mm:
        (kitClass):  Added CSS_INITIAL to the switch statement, and changed to use the WebCore
          type and not the binding type.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 John Abd-El-Malek <jam@google.com>
eric@webkit.org [Wed, 29 Apr 2009 20:21:48 +0000 (20:21 +0000)]
2009-04-29  John Abd-El-Malek  <jam@google.com>

        Reviewed by Dimitri Glazkov.

        Reverted my previous change to add resetChromiumPluginCache().
        https://bugs.webkit.org/show_bug.cgi?id=25318

        * plugins/chromium/PluginDataChromium.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 29 Apr 2009 20:21:03 +0000 (20:21 +0000)]
2009-04-29  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail

        Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>

        Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Remove the preload referenced check.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Alpha Lam <hclam@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 20:14:25 +0000 (20:14 +0000)]
2009-04-29  Alpha Lam  <hclam@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25430

        Provide style sheet for UI controls of media elements for Chromium port.

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 John Abd-El-Malek <jam@chromium.org>
eric@webkit.org [Wed, 29 Apr 2009 20:12:54 +0000 (20:12 +0000)]
2009-04-29  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Adler.

        Expose sudden termination to Chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=25457

        * platform/SuddenTermination.h:
        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/SuddenTerminationChromium.cpp: Added.
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 29 Apr 2009 20:00:08 +0000 (20:00 +0000)]
2009-04-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Dimitri Glazkov.

        Remove unused EventListeners.

        * page/DOMWindow.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 29 Apr 2009 18:38:35 +0000 (18:38 +0000)]
2009-04-29  David Hyatt  <hyatt@apple.com>

        Reviewed by John Sullivan.

        Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized.  Make sure
        not to resize the interior views of a WebView in response to its bounds changing when not using
        viewless WebKit.  Auto-resizing rules were already in place to handle size adjustments for us.
        Just mark as needing layout and do nothing else.

        This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
        Safari change (using a new API that will enable clients to define the edges of the content area as offsets
        from the sides of the WebView).

        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-04-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 29 Apr 2009 17:41:11 +0000 (17:41 +0000)]
2009-04-29  Eric Carlson  <eric.carlson@apple.com>

        Disable media/video-zoom-controls.html on Windows for now.

        * platform/win/Skipped: add media/video-zoom-controls.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reveal current execution line once SourceFrame content is loaded.
timothy@apple.com [Wed, 29 Apr 2009 17:38:15 +0000 (17:38 +0000)]
    Reveal current execution line once SourceFrame content is loaded.

        https://bugs.webkit.org/show_bug.cgi?id=25448

        Reviewed by Timothy Hatcher.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._loaded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ariya@webkit.org [Wed, 29 Apr 2009 17:27:14 +0000 (17:27 +0000)]
WebCore:

2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Fraser.

        [Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
        the default values of canvas attributes.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBufferData::ImageBufferData):

LayoutTests:

2009-04-29  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Fraser.

        Updated expected results after Qt's GraphicsContext fixes.

        * platform/qt/fast/canvas/set-colors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42996 268f45cc-cd09-0410-ab3c-d52691b4dbfc