WebKit.git
9 years ago<rdar://problem/9296211> REGRESSION (r83514): Failing fast/repaint/trailing-floats...
mitz@apple.com [Sun, 17 Apr 2011 20:23:14 +0000 (20:23 +0000)]
<rdar://problem/9296211> REGRESSION (r83514): Failing fast/repaint/trailing-floats-root-line-box-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=58745

Reviewed by Joseph Pecoraro.

This is really a regression from r82611, but it went unnoticed due to a mistake in r73385,
which was fixed in r83514.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren): Actually assign the bottom visual overflow to the
variable so named, not the top layout overflow.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-17 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 17 Apr 2011 19:06:34 +0000 (19:06 +0000)]
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Remove WTF_PLATFORM_SGL
        https://bugs.webkit.org/show_bug.cgi?id=58743

        WTF_PLATFORM_SGL and PLATFORM(SGL) are not used in the code anywhere.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 17 Apr 2011 19:03:13 +0000 (19:03 +0000)]
2011-04-17  Geoffrey Garen  <ggaren@apple.com>

        Strongly suggested, but not necessarily reviewed, by
        Sam Weinig and Maciej Stachowiak.

        Renamed DOMObject* => JSDOMWrapper*.

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::isObservable):
        (WebCore::DOMObjectHandleOwner::finalize):
        * bindings/js/DOMWrapperWorld.h:
        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::toJSArrayBufferView):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDOMBinding.h:
        (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
        (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
        (WebCore::DOMConstructorObject::DOMConstructorObject):
        (WebCore::createDOMObjectWrapper):
        (WebCore::getDOMObjectWrapper):
        * bindings/js/JSDOMWrapper.cpp:
        (WebCore::JSDOMWrapper::~JSDOMWrapper):
        * bindings/js/JSDOMWrapper.h:
        (WebCore::JSDOMWrapper::JSDOMWrapper):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        (WebCore::toJS):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSSVGPathSegCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::toJS):
        * bindings/js/ScriptWrappable.h:
        (WebCore::ScriptWrappable::wrapper):
        (WebCore::ScriptWrappable::setWrapper):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-17 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 17 Apr 2011 18:59:57 +0000 (18:59 +0000)]
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CA) to USE(CA)
        https://bugs.webkit.org/show_bug.cgi?id=58742

        * wtf/Platform.h:
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CA) to USE(CA)
        https://bugs.webkit.org/show_bug.cgi?id=58742

        * config.h:
        * platform/graphics/ca/TransformationMatrixCA.cpp:
        * platform/graphics/cg/ImageBufferDataCG.h:
        * platform/graphics/transforms/TransformationMatrix.h:
        * platform/mac/WebCoreSystemInterface.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::containsPaintedContent):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateBacking):
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CA) to USE(CA)
        https://bugs.webkit.org/show_bug.cgi?id=58742

        * WebProcess/WebPage/LayerTreeHost.cpp:
        * WebProcess/WebPage/win/LayerTreeHostWin.cpp:
        (WebKit::LayerTreeHost::supportsAcceleratedCompositing):
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CA) to USE(CA)
        https://bugs.webkit.org/show_bug.cgi?id=58742

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-17 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Sun, 17 Apr 2011 14:29:11 +0000 (14:29 +0000)]
2011-04-17  Young Han Lee  <joybro@company100.net>

        Reviewed by Benjamin Poulain.

        [Texmap] [Qt] Improve readability by using gInVertexAttributeIndex instead of 0.
        https://bugs.webkit.org/show_bug.cgi?id=58739

        gInVertexAttributeIndex is a constant variable to point the location of
        "InVertex" attribute of the vertex shaders.

        * platform/graphics/opengl/TextureMapperGL.cpp:
        (WebCore::TextureMapperGL::drawTexture):
        (WebCore::TextureMapperGL::paintToTarget):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-17 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Sun, 17 Apr 2011 11:04:16 +0000 (11:04 +0000)]
2011-04-17  Kinuko Yasuda  <kinuko@chromium.org>

        Not reviewed: Fix copyright (I had submitted the file with wrong
        copyright line).

        * storage/StorageInfo.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-17 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 17 Apr 2011 10:04:48 +0000 (10:04 +0000)]
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CG) to USE(CG)
        https://bugs.webkit.org/show_bug.cgi?id=58729

        * wtf/Platform.h:
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CG) to USE(CG)
        https://bugs.webkit.org/show_bug.cgi?id=58729

        * config.h:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::toDataURL):
        * html/HTMLCanvasElement.h:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setShadow):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/CanvasStyle.cpp:
        (WebCore::CanvasStyle::applyStrokeColor):
        (WebCore::CanvasStyle::applyFillColor):
        * loader/cache/CachedFont.cpp:
        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::createImage):
        * platform/FloatConversion.h:
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedImageMIMETypes):
        (WebCore::initializeSupportedImageMIMETypesForEncoding):
        * platform/graphics/BitmapImage.h:
        * platform/graphics/Color.h:
        * platform/graphics/DashArray.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setLegacyShadow):
        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/Image.cpp:
        * platform/graphics/Image.h:
        * platform/graphics/ImageBuffer.cpp:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageBufferData.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/ColorCG.cpp:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/ImageCG.cpp:
        * platform/graphics/cg/ImageSourceCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/cg/PDFDocumentImage.cpp:
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/cg/PathCG.cpp:
        * platform/graphics/cg/TransformationMatrixCG.cpp:
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp:
        (WebCore::PlatformCanvas::resize):
        (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
        (WebCore::PlatformCanvas::Painter::Painter):
        * platform/graphics/chromium/PlatformCanvas.h:
        * platform/graphics/chromium/PlatformImage.cpp:
        (WebCore::PlatformImage::updateFromImage):
        * platform/graphics/opentype/OpenTypeUtilities.cpp:
        * platform/graphics/transforms/AffineTransform.h:
        * platform/graphics/transforms/TransformationMatrix.h:
        * platform/graphics/win/DIBPixelData.h:
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::FontCache::platformInit):
        (WebCore::createGDIFont):
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/win/FontPlatformDataWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/win/GraphicsContextWin.cpp:
        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
        * platform/graphics/win/SimpleFontDataWin.cpp:
        * platform/image-decoders/ImageDecoder.cpp:
        * platform/image-decoders/ImageDecoder.h:
        * rendering/RenderObject.h:
        * rendering/svg/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/svg/RenderSVGResourceGradient.cpp:
        (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/svg/RenderSVGResourceGradient.h:
        * rendering/svg/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
        * rendering/svg/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::applyResource):
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CG) to USE(CG)
        https://bugs.webkit.org/show_bug.cgi?id=58729

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
        (WebCore::GraphicsContext3DInternal::reshape):
        * src/GraphicsContext3DInternal.h:
        * src/PlatformBridge.cpp:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CG) to USE(CG)
        https://bugs.webkit.org/show_bug.cgi?id=58729

        * WebFrame.cpp:
        (WebFrame::spoolPages):
        * WebFrame.h:
        * WebPreferences.cpp:
        (WebPreferences::setFontSmoothing):
        (WebPreferences::setFontSmoothingContrast):
        * WebView.cpp:
        (systemParameterChanged):
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CG) to USE(CG)
        https://bugs.webkit.org/show_bug.cgi?id=58729

        * Shared/ShareableBitmap.h:
        * Shared/WebCoreArgumentCoders.cpp:
        * Shared/WebCoreArgumentCoders.h:
        * Shared/WebGraphicsContext.cpp:
        (WebKit::WebGraphicsContext::WebGraphicsContext):
        * Shared/WebGraphicsContext.h:
        * Shared/win/PlatformCertificateInfo.cpp:
        (WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::setFindIndicator):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRectToPDF):
        (WebKit::WebPage::drawPagesToPDF):
        * WebProcess/WebPage/win/WebPageWin.cpp:
        (WebKit::WebPage::platformPreferencesDidChange):
        * config.h:
2011-04-17  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Rename PLATFORM(CG) to USE(CG)
        https://bugs.webkit.org/show_bug.cgi?id=58729

        * DumpRenderTree/PixelDumpSupport.cpp:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintRect):
        * DumpRenderTree/config.h:
        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView):
        * TestWebKitAPI/PlatformWebView.h:
        * WebKitTestRunner/config.h:
        * WebKitTestRunner/win/TestInvocationWin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
commit-queue@webkit.org [Sun, 17 Apr 2011 06:29:25 +0000 (06:29 +0000)]
2011-04-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Autotest got missed in the handover of the QML WebView element
        https://bugs.webkit.org/show_bug.cgi?id=41449

        Importing WebView QML element test cases from Qt repository. I did some
        style modifications and simplifications in the original code but hopefully
        without changing the behavior.

        Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
        issues currently are:

        - pixelCache() test checked the usage of pixel cache by using a subclass of
          QDeclarativeWebView. We can't do that right now because this class is not
          exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want
          this kind of test.
        - elementAtArea() test uses a function that is not exported. But in this case
          I think we should test it's user, the public method "heuristicZoom".

        * tests/qdeclarativewebview/resources/basic.html: Added.
        * tests/qdeclarativewebview/resources/basic.png: Added.
        * tests/qdeclarativewebview/resources/basic.qml: Added.
        * tests/qdeclarativewebview/resources/elements.html: Added.
        * tests/qdeclarativewebview/resources/elements.qml: Added.
        * tests/qdeclarativewebview/resources/forward.html: Added.
        * tests/qdeclarativewebview/resources/forward.png: Added.
        * tests/qdeclarativewebview/resources/javaScript.html: Added.
        * tests/qdeclarativewebview/resources/javaScript.qml: Added.
        * tests/qdeclarativewebview/resources/loadError.qml: Added.
        * tests/qdeclarativewebview/resources/newwindows.html: Added.
        * tests/qdeclarativewebview/resources/newwindows.qml: Added.
        * tests/qdeclarativewebview/resources/propertychanges.qml: Added.
        * tests/qdeclarativewebview/resources/sethtml.qml: Added.
        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
        (tst_QDeclarativeWebView::tmpDir):
        (strippedHtml):
        (fileContents):
        (removeRecursive):
        (tst_QDeclarativeWebView::cleanupTestCase):
        (tst_QDeclarativeWebView::basicProperties):
        (tst_QDeclarativeWebView::elementAreaAt):
        (tst_QDeclarativeWebView::historyNav):
        (callEvaluateJavaScript):
        (tst_QDeclarativeWebView::javaScript):
        (tst_QDeclarativeWebView::loadError):
        (tst_QDeclarativeWebView::multipleWindows):
        (tst_QDeclarativeWebView::newWindowComponent):
        (tst_QDeclarativeWebView::newWindowParent):
        (tst_QDeclarativeWebView::pressGrabTime):
        (tst_QDeclarativeWebView::renderingEnabled):
        (tst_QDeclarativeWebView::setHtml):
        (tst_QDeclarativeWebView::settings):
        (tst_QDeclarativeWebView::checkNoErrors):
        * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 17 Apr 2011 02:25:40 +0000 (02:25 +0000)]
2011-04-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        about:blank documents in new tabs can XHR anywhere
        https://bugs.webkit.org/show_bug.cgi?id=58712

        Empty security origins have supposed to be low-privilege, we should
        mark them as having a unique origin.

        * manual-tests/about-blank-xhr.html: Added.
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        * page/SecurityOrigin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated results for fast/block/float/032.html after r84096. Filed http://webkit.org...
mitz@apple.com [Sun, 17 Apr 2011 00:20:48 +0000 (00:20 +0000)]
Updated results for fast/block/float/032.html after r84096. Filed webkit.org/b/58736 to
track this change.

* platform/chromium-win/fast/block/float/032-expected.txt:
* platform/gtk/fast/block/float/032-expected.txt:
* platform/mac/fast/block/float/032-expected.txt:
* platform/qt/fast/block/float/032-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
kbalazs@webkit.org [Sat, 16 Apr 2011 22:51:49 +0000 (22:51 +0000)]
Unreviewed.

[Qt][WK2] Unskip fast/loader/null-request-after-willSendRequest.html since
it is passing for a long time.

* platform/qt-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9190108> Crash when hiding a float
mitz@apple.com [Sat, 16 Apr 2011 21:59:36 +0000 (21:59 +0000)]
<rdar://problem/9190108> Crash when hiding a float

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/float/overhanging-tall-block.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverhangingFloats): Moved the call to childLogicalTop() out of the loop.
Capped the logical bottom so that we get the correct maximum.
* rendering/RenderBlock.h: Decleared appendFloatingObjectToLastLine().
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendFloatingObjectToLastLine): Added. Ensures correct bookkeeping by
extending the float if needed so that it touches the line.
(WebCore::RenderBlock::layoutInlineChildren): Changed to call appendFloatingObjectToLastLine().
(WebCore::RenderBlock::checkFloatsInCleanLine): Capped the float height so the we mark the right
range of lines as dirty.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::appendFloat): Replaced the floats() accessor with this function, which
allows the creation of the vector to be combined with appending the first float.

LayoutTests:

* fast/block/float/overhanging-tall-block.html: Added.
* platform/mac/fast/block/float/overhanging-tall-block-expected.checksum: Added.
* platform/mac/fast/block/float/overhanging-tall-block-expected.png: Added.
* platform/mac/fast/block/float/overhanging-tall-block-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 16 Apr 2011 21:22:33 +0000 (21:22 +0000)]
2011-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Crash when NPP_Write returns -1 when writing the manual stream
        https://bugs.webkit.org/show_bug.cgi?id=58735
        <rdar://problem/9124993>

        If NPP_Write returns -1 we must cancel the stream.

        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        (WebKit::NetscapePluginStream::deliverDataToPlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 16 Apr 2011 21:19:13 +0000 (21:19 +0000)]
2011-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Windows should use WebCore localized strings
        <rdar://problem/9119405>
        https://bugs.webkit.org/show_bug.cgi?id=58733

        * WebCoreSupport/WebEditorClient.cpp:
        (undoNameForEditAction):
        (WebEditorClient::registerCommandForUndo):
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        * WebURLResponse.cpp:
        (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode):
        (WebURLResponse::localizedStringForStatusCode):
        Change to use WEB_UI_STRING.

        * WebCoreSupport/WebPlatformStrategies.cpp:
        * WebCoreSupport/WebPlatformStrategies.h:
        Remove the localization strategy in favor of using the default one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 16 Apr 2011 21:15:21 +0000 (21:15 +0000)]
2011-04-16  Simon Fraser  <simon.fraser@apple.com>

        Fix border drawing tests to drop -webkit prefix on border-radius, and make the tests compatible with Firefox
        https://bugs.webkit.org/show_bug.cgi?id=58734

        Add result for new test.

        * platform/mac/fast/borders/webkit-border-radius-expected.checksum: Added.
        * platform/mac/fast/borders/webkit-border-radius-expected.png: Added.
        * platform/mac/fast/borders/webkit-border-radius-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 16 Apr 2011 21:13:38 +0000 (21:13 +0000)]
2011-04-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Fix border drawing tests to drop -webkit prefix on border-radius, and make the tests compatible with Firefox
        https://bugs.webkit.org/show_bug.cgi?id=58734

        Drop the -webkit prefix on border-radius in the tests, and remove -moz-border-radius,
        since Firefox supports the unprefixed property now. This avoids the problem where
        -moz-border-radius and -webkit-border-radius had different behaviors when given two values.

        Also unprefix box-sizing for WebKit, and add a -moz prefixed version for Firefox.

        Add a test that compares the behavior of -webkit-border-radius and border-radius with
        two values.

        * fast/borders/border-radius-circle.html:
        * fast/borders/border-radius-constraints.html:
        * fast/borders/border-radius-groove-01.html:
        * fast/borders/border-radius-groove-02.html:
        * fast/borders/border-radius-groove-03.html:
        * fast/borders/border-radius-wide-border-01.html:
        * fast/borders/border-radius-wide-border-02.html:
        * fast/borders/border-radius-wide-border-03.html:
        * fast/borders/border-radius-wide-border-04.html:
        * fast/borders/borderRadiusAllStylesAllCorners.html:
        * fast/borders/borderRadiusArcs01.html:
        * fast/borders/borderRadiusDashed01.html:
        * fast/borders/borderRadiusDashed02.html:
        * fast/borders/borderRadiusDashed03.html:
        * fast/borders/borderRadiusDashed04.html:
        * fast/borders/borderRadiusDashed05.html:
        * fast/borders/borderRadiusDashed06.html:
        * fast/borders/borderRadiusDotted01.html:
        * fast/borders/borderRadiusDotted02.html:
        * fast/borders/borderRadiusDotted03.html:
        * fast/borders/borderRadiusDotted04.html:
        * fast/borders/borderRadiusDotted05.html:
        * fast/borders/borderRadiusDotted06.html:
        * fast/borders/borderRadiusDouble02.html:
        * fast/borders/borderRadiusDouble03.html:
        * fast/borders/borderRadiusDouble04.html:
        * fast/borders/borderRadiusDouble05.html:
        * fast/borders/borderRadiusDouble06.html:
        * fast/borders/borderRadiusDouble07.html:
        * fast/borders/borderRadiusDouble08.html:
        * fast/borders/borderRadiusDouble09.html:
        * fast/borders/borderRadiusGroove01.html:
        * fast/borders/borderRadiusGroove02.html:
        * fast/borders/webkit-border-radius.html: Added.
        * platform/mac/fast/borders/border-radius-groove-01-expected.checksum:
        * platform/mac/fast/borders/border-radius-groove-01-expected.png:
        * platform/mac/fast/borders/border-radius-groove-02-expected.png:
        * platform/mac/fast/borders/border-radius-groove-03-expected.checksum:
        * platform/mac/fast/borders/border-radius-groove-03-expected.png:
        * platform/mac/fast/borders/border-radius-inline-flow-expected.png:
        * platform/mac/fast/borders/border-radius-split-inline-expected.png:
        * platform/mac/fast/borders/border-radius-wide-border-01-expected.png:
        * platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
        * platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum:
        * platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
        * platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum:
        * platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
        * platform/mac/fast/borders/borderRadiusDashed01-expected.png:
        * platform/mac/fast/borders/borderRadiusDashed02-expected.png:
        * platform/mac/fast/borders/borderRadiusDashed03-expected.png:
        * platform/mac/fast/borders/borderRadiusDashed04-expected.png:
        * platform/mac/fast/borders/borderRadiusDashed05-expected.png:
        * platform/mac/fast/borders/borderRadiusDashed06-expected.checksum:
        * platform/mac/fast/borders/borderRadiusDashed06-expected.png:
        * platform/mac/fast/borders/borderRadiusDotted01-expected.png:
        * platform/mac/fast/borders/borderRadiusDotted02-expected.png:
        * platform/mac/fast/borders/borderRadiusDotted03-expected.png:
        * platform/mac/fast/borders/borderRadiusDotted04-expected.png:
        * platform/mac/fast/borders/borderRadiusDotted05-expected.png:
        * platform/mac/fast/borders/borderRadiusDotted06-expected.checksum:
        * platform/mac/fast/borders/borderRadiusDotted06-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble01-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble02-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble03-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble04-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble05-expected.checksum:
        * platform/mac/fast/borders/borderRadiusDouble05-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble06-expected.checksum:
        * platform/mac/fast/borders/borderRadiusDouble06-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble07-expected.checksum:
        * platform/mac/fast/borders/borderRadiusDouble07-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble08-expected.checksum:
        * platform/mac/fast/borders/borderRadiusDouble08-expected.png:
        * platform/mac/fast/borders/borderRadiusDouble09-expected.checksum:
        * platform/mac/fast/borders/borderRadiusDouble09-expected.png:
        * platform/mac/fast/borders/borderRadiusGroove01-expected.png:
        * platform/mac/fast/borders/borderRadiusGroove02-expected.png:
        * platform/mac/fast/borders/borderRadiusInset01-expected.png:
        * platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/mac/fast/borders/borderRadiusOutset01-expected.png:
        * platform/mac/fast/borders/borderRadiusRidge01-expected.png:
        * platform/mac/fast/borders/borderRadiusSolid01-expected.png:
        * platform/mac/fast/borders/borderRadiusSolid02-expected.png:
        * platform/mac/fast/borders/borderRadiusSolid03-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 16 Apr 2011 19:31:42 +0000 (19:31 +0000)]
2011-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Pages in the PageCache don't have the correct visited link coloring after being restored
        https://bugs.webkit.org/show_bug.cgi?id=58721

        * WebCore.exp.in:
        Add export of markPagesForVistedLinkStyleRecalc for use by WebKit2.

        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::restore):
        (WebCore::CachedPage::clear):
        * history/CachedPage.h:
        (WebCore::CachedPage::markForVistedLinkStyleRecalc):
        Add bit, set by calling markForVistedLinkStyleRecalc, which forces a visited link
        style recalc when being restored.

        * history/PageCache.h:
        * history/PageCache.cpp:
        (WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
        Mark all pages in the page cache as requiring visited link style recalc.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::addVisitedLink):
        (WebCore::PageGroup::removeVisitedLinks):
        (WebCore::PageGroup::removeAllVisitedLinks):
        Set dirty bit when changing any visited link information.

2011-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Pages in the PageCache don't have the correct visited link coloring after being restored
        https://bugs.webkit.org/show_bug.cgi?id=58721

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::visitedLinkStateChanged):
        (WebKit::WebProcess::allVisitedLinkStateChanged):
        Mark all pages in the page cache as needing visited link style recalc
        whenever visited link information changes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Leo Yang <leoyang.webkit@gmail.com>
commit-queue@webkit.org [Sat, 16 Apr 2011 18:37:46 +0000 (18:37 +0000)]
2011-04-16  Leo Yang  <leoyang.webkit@gmail.com>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure when svg <use> element changes href
        https://bugs.webkit.org/show_bug.cgi?id=58726

        Test case to verify assertion at line 509 of SVGUseElement.cpp.
        Test passes if no crash occurs in debug mode.

        * svg/custom/use-crash-when-href-change-expected.txt: Added.
        * svg/custom/use-crash-when-href-change.svg: Added.
2011-04-16  Leo Yang  <leoyang.webkit@gmail.com>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure when svg <use> element changes href
        https://bugs.webkit.org/show_bug.cgi?id=58726

        m_resourceId was not empty after the pending resource
        becomes available. This will trigger the assertion at
        line 509 of SVGUseElement.cpp when the <use> element's
        href becomes empty or invalid.

        This patch makes m_resourceId be empty after the pending
        resource becomes available to avoid assertion failure.

        Test: svg/custom/use-crash-when-href-change.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildPendingResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 16 Apr 2011 10:55:49 +0000 (10:55 +0000)]
2011-04-16  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(CAIRO) to USE(CAIRO)
        https://bugs.webkit.org/show_bug.cgi?id=55192

        * Source/cmake/OptionsEfl.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 16 Apr 2011 10:37:01 +0000 (10:37 +0000)]
2011-04-16  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(CAIRO) to USE(CAIRO)
        https://bugs.webkit.org/show_bug.cgi?id=55192

        * wtf/Platform.h:
        * wtf/gobject/GTypedefs.h:
2011-04-16  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(CAIRO) to USE(CAIRO)
        https://bugs.webkit.org/show_bug.cgi?id=55192

        * CMakeListsEfl.txt:
        * config.h:
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedImageMIMETypesForEncoding):
        * platform/graphics/ContextShadow.h:
        * platform/graphics/DashArray.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::isHashTableDeletedValue):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::glyphAt):
        (WebCore::GlyphBuffer::add):
        * platform/graphics/Gradient.cpp:
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/ImageBufferData.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cairo/DrawErrorUnderline.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cairo/ImageCairo.cpp:
        * platform/graphics/gstreamer/ImageGStreamer.h:
        * platform/graphics/transforms/AffineTransform.h:
        * platform/graphics/transforms/TransformationMatrix.h:
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::createGDIFont):
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/win/FontPlatformDataWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/win/GraphicsContextWin.cpp:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::paintWindowedPluginIntoContext):
        * rendering/RenderObject.h:
2011-04-16  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(CAIRO) to USE(CAIRO)
        https://bugs.webkit.org/show_bug.cgi?id=55192

        * WebFrame.cpp:
        (WebFrame::spoolPages):
        * WebFrame.h:
2011-04-16  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(CAIRO) to USE(CAIRO)
        https://bugs.webkit.org/show_bug.cgi?id=55192

        * DumpRenderTree/PixelDumpSupport.cpp:
        * DumpRenderTree/config.h:
        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView):
        * WebKitTestRunner/config.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 16 Apr 2011 10:12:48 +0000 (10:12 +0000)]
2011-04-16  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r84033.

        * platform/win/LocalizedStringsWin.cpp:
        (WebCore::localizedString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Sat, 16 Apr 2011 09:33:04 +0000 (09:33 +0000)]
2011-04-16  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        show diffs+test inline in the results page
        https://bugs.webkit.org/show_bug.cgi?id=58723

        Put each row in it's own tbody and sort based on tbodies. That way
        we can append the results to the tbody inline as another table row.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 16 Apr 2011 09:02:33 +0000 (09:02 +0000)]
2011-04-16  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Tests that we do not crash when adding a list item block child
        as a before child to svg text.
        https://bugs.webkit.org/show_bug.cgi?id=58678

        * svg/text/text-block-child-crash-expected.txt: Added.
        * svg/text/text-block-child-crash.xhtml: Added.
2011-04-16  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Only allow inline child for SVG text since we cannot
        handle block childs.
        https://bugs.webkit.org/show_bug.cgi?id=58678

        Test: svg/text/text-block-child-crash.xhtml

        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::isChildAllowed):
        * rendering/svg/RenderSVGText.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Sat, 16 Apr 2011 08:47:23 +0000 (08:47 +0000)]
2011-04-16  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, new GTK+ test expectations after r84039.

        * platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-1-expected.txt:
        * platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-10-expected.txt:
        * platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-2-expected.txt:
        * platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-3-expected.txt:
        * platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-4-expected.txt:
        * platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-5-expected.txt:
        * platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-6-expected.txt:
        * platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-7-expected.txt:
        * platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-8-expected.txt:
        * platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-9-expected.txt:
        * platform/gtk/fast/html/details-no-summary1-expected.txt:
        * platform/gtk/fast/html/details-no-summary2-expected.txt:
        * platform/gtk/fast/html/details-no-summary3-expected.txt:
        * platform/gtk/fast/html/details-no-summary4-expected.txt:
        * platform/gtk/fast/html/details-open-javascript-expected.txt:
        * platform/gtk/fast/html/details-open1-expected.txt:
        * platform/gtk/fast/html/details-open2-expected.txt:
        * platform/gtk/fast/html/details-open3-expected.txt:
        * platform/gtk/fast/html/details-open4-expected.txt:
        * platform/gtk/fast/html/details-open5-expected.txt:
        * platform/gtk/fast/html/details-open6-expected.txt:
        * platform/gtk/fast/html/details-position-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-1-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-2-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-3-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-4-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-5-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-6-expected.txt:
        * platform/gtk/fast/html/details-writing-mode-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-16 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Sat, 16 Apr 2011 07:28:01 +0000 (07:28 +0000)]
2011-04-16  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        handle new tests in the new results html file
        https://bugs.webkit.org/show_bug.cgi?id=58715

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 16 Apr 2011 06:22:35 +0000 (06:22 +0000)]
2011-04-15  Daniel Bates  <dbates@webkit.org>

        Attempt to fix the Qt Linux Release build after changeset 84064 <http://trac.webkit.org/changeset/84064>
        (https://bugs.webkit.org/show_bug.cgi?id=58686).

        * UIProcess/API/qt/qwkpage_p.h: Remove takeFocus().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Sat, 16 Apr 2011 05:41:56 +0000 (05:41 +0000)]
2011-04-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84067.
        http://trac.webkit.org/changeset/84067
        https://bugs.webkit.org/show_bug.cgi?id=58724

        qt build are failing. (Requested by loislo2 on #webkit).

        * heap/MarkStack.h:
        (JSC::MarkStack::append):
        * runtime/JSValue.h:
        * runtime/WriteBarrier.h:
        (JSC::DeprecatedPtr::DeprecatedPtr):
        (JSC::DeprecatedPtr::get):
        (JSC::DeprecatedPtr::operator*):
        (JSC::DeprecatedPtr::operator->):
        (JSC::DeprecatedPtr::slot):
        (JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
        (JSC::DeprecatedPtr::operator!):
        (JSC::operator==):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sat, 16 Apr 2011 05:32:07 +0000 (05:32 +0000)]
2011-04-15  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
        https://bugs.webkit.org/show_bug.cgi?id=57833

        * http/tests/inspector-enabled/database-open.html:
2011-04-15  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
        https://bugs.webkit.org/show_bug.cgi?id=57833

        * inspector/Inspector.json:
        * inspector/InspectorDatabaseAgent.cpp:
        (WebCore::InspectorDatabaseAgent::didOpenDatabase):
        (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
        (WebCore::InspectorDatabaseAgent::setFrontend):
        (WebCore::InspectorDatabaseAgent::clearFrontend):
        (WebCore::InspectorDatabaseAgent::enable):
        (WebCore::InspectorDatabaseAgent::disable):
        (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
        (WebCore::InspectorDatabaseAgent::executeSQL):
        * inspector/InspectorDatabaseAgent.h:
        * inspector/front-end/inspector.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 John Bates <jbates@google.com>
commit-queue@webkit.org [Sat, 16 Apr 2011 04:40:22 +0000 (04:40 +0000)]
2011-04-15  John Bates  <jbates@google.com>

        Reviewed by Kenneth Russell.

        Change WebGraphicsContext3D virtuals to pure virtuals as intended
        https://bugs.webkit.org/show_bug.cgi?id=58479

        * public/WebGraphicsContext3D.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Sat, 16 Apr 2011 04:35:54 +0000 (04:35 +0000)]
2011-04-15  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
        https://bugs.webkit.org/show_bug.cgi?id=58717

        Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.

        * WebCoreSupport/CorrectionPanel.mm:
        (CorrectionPanel::show):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 16 Apr 2011 04:23:59 +0000 (04:23 +0000)]
2011-04-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP media-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58642

        These tests are adapted from the other media loading tests.

        * http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/media-src-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/media-src-blocked.html: Added.
2011-04-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP media-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58642

        Yay HTMLMediaElement for having the exact hook we need!

        Tests: http/tests/security/contentSecurityPolicy/media-src-allowed.html
               http/tests/security/contentSecurityPolicy/media-src-blocked.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::isSafeToLoadURL):
            - Although it's tempting to add this branch to the previous
              if-block, that results in the wrong error message being logged to
              the console (covered by the "blocked" test).
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowMediaFromSource):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:
            - These changes are routine.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 16 Apr 2011 03:59:35 +0000 (03:59 +0000)]
2011-04-15  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        old-run-webkit-tests: save the list of tests actually run to a file
        https://bugs.webkit.org/show_bug.cgi?id=58692

        * Scripts/old-run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 16 Apr 2011 03:40:05 +0000 (03:40 +0000)]
2011-04-15  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        fix MockFileSystem.abspath() on windows
        https://bugs.webkit.org/show_bug.cgi?id=58713

        The existing code was borked on Windows if a path was passed
        in using a drive letter (e.g., "d:\foo.txt"), and would go
        into an infinite recursive loop. While win paths shouldn't
        normally be passed into the mock filesystem, this just
        bulletproofs things a bit (note that "/foo.txt" is considered
        an absolute path on windows python as well.

        * Scripts/webkitpy/common/system/filesystem_mock.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Sat, 16 Apr 2011 03:02:45 +0000 (03:02 +0000)]
2011-04-15  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        show stderr files and httpd log files
        https://bugs.webkit.org/show_bug.cgi?id=58714

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 16 Apr 2011 02:33:08 +0000 (02:33 +0000)]
2011-04-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP should block string arguments to setTimeout and setInterval unless options eval-script
        https://bugs.webkit.org/show_bug.cgi?id=58610

        Herein lies a four-way testing matrix.

        * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Added.
2011-04-15  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP should block string arguments to setTimeout and setInterval unless options eval-script
        https://bugs.webkit.org/show_bug.cgi?id=58610

        It's somewhat sadness that the JSC and V8 code for setTimeout and
        setInterval are so different.  I struggled for a while with how to
        handle the worker case, but I decided to punt on it for now.

        Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
               http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
               http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
               http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setTimeout):
        (WebCore::JSDOMWindow::setInterval):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::setTimeout):
        (WebCore::JSWorkerContext::setInterval):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):
        * bindings/js/ScheduledAction.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::WindowSetTimeoutImpl):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowEval):
        * page/ContentSecurityPolicy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Shishir Agrawal <shishir@chromium.org>
commit-queue@webkit.org [Sat, 16 Apr 2011 02:26:26 +0000 (02:26 +0000)]
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        Initial draft at:
        http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0175.html

        * configure.ac:
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        * Configurations/FeatureDefines.xcconfig:
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        * Configurations/FeatureDefines.xcconfig:
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        * features.gypi:
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        * Configurations/FeatureDefines.xcconfig:
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        * Configurations/FeatureDefines.xcconfig:
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        * Scripts/build-webkit:
2011-04-15  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by James Robinson.

        Add a flag to guard Page Visibility API changes.
        https://bugs.webkit.org/show_bug.cgi?id=58464

        * win/tools/vsprops/FeatureDefines.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Sat, 16 Apr 2011 02:06:44 +0000 (02:06 +0000)]
2011-04-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Make plugins compile during WebKit GTK Windows build.
        Ifdef properly relevant parts so that the PluginViewGtk compiles on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=58580

        * plugins/PluginView.cpp:
        (WebCore::PluginView::stop):
        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::platformGetValue):
        (WebCore::PluginView::platformStart):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Sat, 16 Apr 2011 01:53:00 +0000 (01:53 +0000)]
2011-04-15  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        When a message with url embedded is added to console, the "file:" scheme
        and path should be stripped.
        https://bugs.webkit.org/show_bug.cgi?id=58665

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-04-15  Chang Shu  <cshu@webkit.org>

        Reviewed by Alexey Proskuryakov.

        When a message with url embedded is added to console, the "file:" scheme
        and path should be stripped.
        https://bugs.webkit.org/show_bug.cgi?id=58665

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::lastFileURLPathComponent):
        (WTR::InjectedBundlePage::willAddMessageToConsole):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoErrrk! - build fix from !x86-64.
barraclough@apple.com [Sat, 16 Apr 2011 01:19:27 +0000 (01:19 +0000)]
Errrk! - build fix from !x86-64.

* dfg/DFGNode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert of r83974.
levin@chromium.org [Sat, 16 Apr 2011 01:16:37 +0000 (01:16 +0000)]
Revert of r83974.

JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=58716

* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/tests/RunAllWtfTests.cpp: Removed.
* wtf/tests/StringTests.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Sat, 16 Apr 2011 01:11:49 +0000 (01:11 +0000)]
2011-04-15  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Remove DeprecatedPtr
        https://bugs.webkit.org/show_bug.cgi?id=58718

        As simple as it sounds.

        * heap/MarkStack.h:
        (JSC::MarkStack::append):
        * runtime/JSValue.h:
        * runtime/WriteBarrier.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 MORITA Hajime <morrita@google.com>
morrita@google.com [Sat, 16 Apr 2011 00:49:25 +0000 (00:49 +0000)]
2011-04-15  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower
        https://bugs.webkit.org/show_bug.cgi?id=58512

        Manually rolled out r72367 at which mayCauseFlashOfUnstyledContent() was introduced.
        This change keeps an small refactoring on
        FrameView::shouldUpdate(), which doesn't affect on the behavior.

        * dom/Document.cpp:
        * dom/Document.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateRect):
        (WebCore::FrameView::shouldUpdate):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintContents):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Chris Rogers <crogers@google.com>
crogers@google.com [Sat, 16 Apr 2011 00:42:55 +0000 (00:42 +0000)]
2011-04-15  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Reduce default kernel size of SincResampler to favor better speed over quality
        https://bugs.webkit.org/show_bug.cgi?id=58710

        No new tests since audio API is not yet implemented.

        * platform/audio/SincResampler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Sat, 16 Apr 2011 00:38:05 +0000 (00:38 +0000)]
2011-04-15  Jeff Miller  <jeffm@apple.com>

        Reviewed by Sam Weinig.

        Add takeFocus callback to WKPageUIClient
        https://bugs.webkit.org/show_bug.cgi?id=58686

        On Windows, we need to handle moving focus out of the web view in the client, so add a takeFocus callback to WKPageUIClient
        and stop handling taking focus in the framework in WKView.mm on the Mac.

        * UIProcess/API/C/WKPage.h: Added WKFocusDirection enum and takeFocus to WKPageUIClient.
        * UIProcess/API/mac/PageClientImpl.h: Removed takeFocus().
        * UIProcess/API/mac/PageClientImpl.mm: Removed takeFocus().
        * UIProcess/API/mac/WKView.mm: Removed _takeFocus().
        * UIProcess/API/mac/WKViewInternal.h: Removed _takeFocus().
        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_takeFocus): Added.
        * UIProcess/API/qt/ClientImpl.h: Added qt_wk_takeFocus.
        * UIProcess/API/qt/qwkpage.cpp: Remove takeFocus().
        (QWKPage::QWKPage): Added takeFocus() callback.
        * UIProcess/PageClient.h: Removed takeFocus().
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::takeFocus): Call m_uiClient to take focus.
        * UIProcess/WebPageProxy.h: Pass FocusDirection as a uint32_t to takeFocus().
        * UIProcess/WebPageProxy.messages.in: Pass FocusDirection as a uint32_t in TakeFocus message.
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::takeFocus): Added.
        * UIProcess/WebUIClient.h: Added takeFocus().
        * UIProcess/win/WebView.cpp: Removed takeFocus(), which was never implemented on Windows.
        * UIProcess/win/WebView.h: Removed takeFocus().
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::takeFocus): Pass FocusDirection as a uint32_t in TakeFocus message.
2011-04-15  Jeff Miller  <jeffm@apple.com>

        Reviewed by Sam Weinig.

        Add takeFocus callback to WKPageUIClient
        https://bugs.webkit.org/show_bug.cgi?id=58686

        Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create): Added empty takeFocus entry.
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage): Added empty takeFocus entry.
        (WTR::TestController::initialize): Added empty takeFocus entry.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a simple tool to gather statistics on whether functions
barraclough@apple.com [Sat, 16 Apr 2011 00:37:09 +0000 (00:37 +0000)]
Add a simple tool to gather statistics on whether functions
are completed through the new or old JIT.

Reviewed by Oliver Hunt.

* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Sam Weinig.
ap@apple.com [Sat, 16 Apr 2011 00:33:32 +0000 (00:33 +0000)]
    Reviewed by Sam Weinig.

        WebKit2: Stop using deprecated NSInputManager
        https://bugs.webkit.org/show_bug.cgi?id=58709

        Changed all mouse related functions to give NSInputContext a chance to handle the event,
        added logging. Removed -rightMouseMoved: method, which was added by accident.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView mouseMoved:]):
        (-[WKView mouseDown:]):
        (-[WKView mouseUp:]):
        (-[WKView mouseDragged:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Sat, 16 Apr 2011 00:26:36 +0000 (00:26 +0000)]
2011-04-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Expand the ntohs, ntohl, htons and htonl defines for OS(WINDOWS)
        These have to be defined for Windows in general, since win32 API
        does not provide them.
        https://bugs.webkit.org/show_bug.cgi?id=58582

        * platform/graphics/WOFFFileFormat.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Sat, 16 Apr 2011 00:21:16 +0000 (00:21 +0000)]
2011-04-15  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Adam Barth.

        Show a console message when X-Frame-Options blocks a load
        https://bugs.webkit.org/show_bug.cgi?id=39087

        Added console message when X-Frame-Options headers block resource loading

        * http/tests/inspector/network/x-frame-options-deny-expected.txt:
        * http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
        * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
2011-04-15  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Adam Barth.

        Show a console message when X-Frame-Options blocks a load
        https://bugs.webkit.org/show_bug.cgi?id=39087

        Added console message when X-Frame-Options headers block resource loading

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveResponse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Sat, 16 Apr 2011 00:17:33 +0000 (00:17 +0000)]
2011-04-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Evaluate PLATFORM(GTK) before the all-encompassing OS(WINDOWS)
        test. This allows Windows build of WebKit GTK to chose the right
        path.
        https://bugs.webkit.org/show_bug.cgi?id=58576

        * platform/FileSystem.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPotential crash getting a JS wrapper.
jhoneycutt@apple.com [Sat, 16 Apr 2011 00:14:57 +0000 (00:14 +0000)]
Potential crash getting a JS wrapper.

<rdar://problem/8988741>

Reviewed by Brian Weinstein.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsWrapperForWorld):
Ensure that we have a valid m_coreFrame, because it can be cleared by
invalidate().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QWebPage MIME type handling inconsistency with other web browsers
luiz@webkit.org [Sat, 16 Apr 2011 00:05:36 +0000 (00:05 +0000)]
[Qt] QWebPage MIME type handling inconsistency with other web browsers
https://bugs.webkit.org/show_bug.cgi?id=46968

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.

* WebCore.pro:
* platform/network/MIMESniffing.cpp: Added.
(MagicNumbers::dataSizeNeededForImageSniffing):
(MagicNumbers::maskedCompare):
(MagicNumbers::checkSpaceOrBracket):
(MagicNumbers::compare):
(MagicNumbers::findMIMEType):
(MagicNumbers::findSimpleMIMEType):
(MagicNumbers::textOrBinaryTypeSniffingProcedure):
(MagicNumbers::unknownTypeSniffingProcedure):
(MagicNumbers::imageTypeSniffingProcedure):
(MagicNumbers::checkText):
(MagicNumbers::checkRDF):
(MagicNumbers::skipTag):
(MagicNumbers::feedTypeSniffingProcedure):
(MIMESniffer::MIMESniffer):
* platform/network/MIMESniffing.h: Added.
(MIMESniffer::dataSize):
(MIMESniffer::sniff):
(MIMESniffer::isValid):
* platform/network/NetworkingContext.h:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::sendNetworkRequest):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::advertisedMIMEType):
(WebCore::QNetworkReplyWrapper::mimeType):
* platform/network/qt/QtMIMETypeSniffer.cpp: Added.
(QtMIMETypeSniffer::QtMIMETypeSniffer):
(QtMIMETypeSniffer::sniff):
(QtMIMETypeSniffer::trySniffing):
* platform/network/qt/QtMIMETypeSniffer.h: Added.
(QtMIMETypeSniffer::mimeType):
(QtMIMETypeSniffer::isFinished):

Source/WebKit/qt:

Reviewed by Kenneth Rohde Christiansen.

Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createNetworkingContext):
* WebCoreSupport/FrameNetworkingContextQt.cpp:
(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
* WebCoreSupport/FrameNetworkingContextQt.h:
* tests/MIMESniffing/MIMESniffing.pro: Added.
* tests/MIMESniffing/TestData.h: Added.
* tests/MIMESniffing/resources.qrc: Added.
* tests/MIMESniffing/resources/application_atom+xml: Added.
* tests/MIMESniffing/resources/application_ogg: Added.
* tests/MIMESniffing/resources/application_pdf: Added.
* tests/MIMESniffing/resources/application_postscript: Added.
* tests/MIMESniffing/resources/application_rdf+xml: Added.
* tests/MIMESniffing/resources/application_rss+xml: Added.
* tests/MIMESniffing/resources/application_x-gzip: Added.
* tests/MIMESniffing/resources/application_x-rar-compressed: Added.
* tests/MIMESniffing/resources/application_zip: Added.
* tests/MIMESniffing/resources/audio_x-wave: Added.
* tests/MIMESniffing/resources/image_bmp: Added.
* tests/MIMESniffing/resources/image_gif: Added.
* tests/MIMESniffing/resources/image_jpeg: Added.
* tests/MIMESniffing/resources/image_png: Added.
* tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
* tests/MIMESniffing/resources/image_webp: Added.
* tests/MIMESniffing/resources/text_html: Added.
* tests/MIMESniffing/resources/text_xml: Added.
* tests/MIMESniffing/resources/video_webm: Added.
* tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
(tst_MIMESniffing::tst_MIMESniffing):
(errorText):
(tst_MIMESniffing::testCase1):
* tests/tests.pro:

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen.

Implementing mime type sniffing based on
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.

* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::MIMESniffingEnabled):
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:

LayoutTests:

Rubberstamped by Andreas Kling.

Unskipping http/tests/loading/text-content-type-with-binary-extension.html.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Sat, 16 Apr 2011 00:03:05 +0000 (00:03 +0000)]
2011-04-15  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        input field with focus makes appendChild operation ~42x slower
        https://bugs.webkit.org/show_bug.cgi?id=57059

        Add performance test for cloneNode when an input field has focus.

        * perf/clone-with-focus-expected.txt: Added.
        * perf/clone-with-focus.html: Added.
2011-04-15  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        input field with focus makes appendChild operation ~42x slower
        https://bugs.webkit.org/show_bug.cgi?id=57059

        Change ContainerNode::cloneChildNodes to only disable the
        deleteButtonController if the container itself (or any of its children)
        is being edited. Thus avoiding a reflow in cases where it's not.

        Test: perf/clone-with-focus.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::cloneChildNodes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Charlie Reis <creis@chromium.org>
commit-queue@webkit.org [Sat, 16 Apr 2011 00:01:18 +0000 (00:01 +0000)]
2011-04-15  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=44079

        Remove an assert whose invariant doesn't hold.

        * platform/chromium/test_expectations.txt: Re-enable test.
2011-04-15  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=44079

        Remove an assert whose invariant doesn't hold.

        * src/FrameLoaderClientImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 15 Apr 2011 23:59:57 +0000 (23:59 +0000)]
2011-04-15  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        only show pretty-diff/wdiff if they were generated
        https://bugs.webkit.org/show_bug.cgi?id=58682

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 15 Apr 2011 23:58:43 +0000 (23:58 +0000)]
2011-04-15  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Expose unified Quota API if QUOTA build flag is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58648

        * src/AssertMatchingEnums.cpp: Added enum assertions.
        * src/StorageInfoChromium.cpp: Made a build fix.
2011-04-15  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Expose unified Quota API if QUOTA build flag is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58648

        Test: storage/storageinfo-query-usage.html

        * CMakeLists.txt: Added new file entries.
        * DerivedSources.cpp: Added new file entries.
        * DerivedSources.make: Added new file entries.
        * GNUmakefile.am: Added new file entries.
        * WebCore.gypi: Added new file entries.
        * WebCore.vcproj/WebCore.vcproj: Added new file entries.
        * WebCore.xcodeproj/project.pbxproj: Added new file entries.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitStorageInfo): Added.
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * storage/StorageInfo.h: Added storage type enum.
        * storage/StorageInfo.idl: Added.
        * storage/StorageInfoErrorCallback.idl: Added.
        * storage/StorageInfoUsageCallback.idl: Added.
2011-04-15  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Expose unified Quota API if QUOTA build flag is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58648

        Added a layout test, also added skipped entries on platforms
        where the QUOTA flag is not enabled.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * storage/script-tests/TEMPLATE.html: Added.
        * storage/script-tests/storageinfo-query-usage.js: Added.
        * storage/storageinfo-query-usage-expected.txt: Added.
        * storage/storageinfo-query-usage.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 15 Apr 2011 23:55:42 +0000 (23:55 +0000)]
2011-04-15  Oliver Hunt  <oliver@apple.com>

        GC allocate Structure
        https://bugs.webkit.org/show_bug.cgi?id=58483

        Rolling r83894 r83827 r83810 r83809 r83808 back in with
        a workaround for the gcc bug seen by the gtk bots

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHang underneath ApplicationCacheStorage::writeDataToUniqueFileInDirectory when loading
jberlin@webkit.org [Fri, 15 Apr 2011 23:51:03 +0000 (23:51 +0000)]
Hang underneath ApplicationCacheStorage::writeDataToUniqueFileInDirectory when loading
http://www.webkit.org/demos/calendar.
https://bugs.webkit.org/show_bug.cgi?id=58698

Reviewed by Brian Weinstein.

* platform/win/FileSystemWin.cpp:
(WebCore::openFile):
Add breaks to the case statement.
(WebCore::directoryName):
Remove any trailing slash in directoryName. After closer inspection of all callers, it
appears the that callers do not need the trailing slash, and those that use the length do
so only to change the direction of the slashes throughout the length of the path.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 15 Apr 2011 23:47:24 +0000 (23:47 +0000)]
2011-04-15  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
        https://bugs.webkit.org/show_bug.cgi?id=52963

        .) Change base class of ShadowRoot from DocumentFragment to TreeScope.
        .) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
        .) Merged setTreeScope() with setTreeScopeRecursively()
        .) Call setTreeScopeRecursively in DOM manipulation functions where applicable.

        No new tests. (refactoring)

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::takeAllChildrenFrom):
        (WebCore::ContainerNode::removeBetween):
        (WebCore::ContainerNode::removeChildren):
        (WebCore::ContainerNode::parserAddChild):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::setDocType):
        * dom/Element.h:
        * dom/Node.cpp:
        (WebCore::Node::treeScope):
        (WebCore::Node::setTreeScopeRecursively):
        * dom/Node.h:
        (WebCore::Node::document):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::ShadowRoot):
        (WebCore::ShadowRoot::~ShadowRoot):
        (WebCore::ShadowRoot::nodeType):
        (WebCore::ShadowRoot::cloneNode):
        (WebCore::ShadowRoot::childTypeAllowed):
        * dom/ShadowRoot.h:
        (WebCore::toShadowRoot):
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::TreeScope):
        (WebCore::TreeScope::setParentTreeScope):
        * dom/TreeScope.h:
        * rendering/RenderSlider.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 15 Apr 2011 23:38:04 +0000 (23:38 +0000)]
2011-04-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        DOM object handles are never removed from cache
        https://bugs.webkit.org/show_bug.cgi?id=58707

        We were trying to remove hash table items by value instead of by key.

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::JSNodeHandleOwner::finalize): Changed to work more like
        DOMObjectHandleOwner::finalize because I'm going to merge them.

        (WebCore::DOMObjectHandleOwner::finalize): Remove hash table items
        by key, not value. (Oops!) Use a helper function to make sure we get
        this right.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::cacheDOMObjectWrapper): Store the hash table key as our weak
        handle context, so we can use it at destruction time.

        * bindings/js/JSDOMBinding.h: Removed unnecessary include.

        * bindings/js/JSNodeCustom.h:
        (WebCore::cacheDOMNodeWrapper): Store the hash table key as our weak
        handle context, so we can use it at destruction time.

        * bindings/js/ScriptWrappable.h:
        (WebCore::ScriptWrappable::setWrapper): Forward context parameter, to
        support the above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Fri, 15 Apr 2011 23:35:48 +0000 (23:35 +0000)]
2011-04-15  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Gavin Barraclough.

        Correctly prefix symbols. Since gcc 4.5.0, Windows x64 symbols
        are not prefixed by underscore anymore. This is consistent with
        what MSVC does.
        https://bugs.webkit.org/show_bug.cgi?id=58573

        * jit/JITStubs.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 15 Apr 2011 23:10:43 +0000 (23:10 +0000)]
2011-04-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * configure.ac: bump to 1.5.0, 1.4.0 will be released from a
        branch and was already cut off.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 15 Apr 2011 23:03:02 +0000 (23:03 +0000)]
2011-04-15  Kenneth Russell  <kbr@google.com>

        Unreviewed. Chromium Linux Release build fix due to unused variables.

        * platform/audio/mkl/FFTFrameMKL.cpp:
        (WebCore::FFTFrame::doFFT):
        (WebCore::FFTFrame::doInverseFFT):
        (WebCore::FFTFrame::cleanup):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 58705 - DFG JIT Add support for flow control (branch, jump).
barraclough@apple.com [Fri, 15 Apr 2011 23:02:09 +0000 (23:02 +0000)]
Bug 58705 - DFG JIT Add support for flow control (branch, jump).

Reviewed by Geoff Garen.

Add support for control flow by breaking the CodeBlock up into multiple
basic blocks, generating code for each basic block in turn through the
speculative JIT & then the non-speculative JIT.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeOffset):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
(JSC::DFG::JITCodeGenerator::addBranch):
(JSC::DFG::JITCodeGenerator::linkBranches):
(JSC::DFG::JITCodeGenerator::BranchRecord::BranchRecord):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::isJump):
(JSC::DFG::Node::isBranch):
(JSC::DFG::Node::takenBytecodeOffset):
(JSC::DFG::Node::notTakenBytecodeOffset):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build change after r83945.
bfulgham@webkit.org [Fri, 15 Apr 2011 22:56:34 +0000 (22:56 +0000)]
Unreviewed build change after r83945.

New 'PlatformPathCairo.cpp' was not added to the WinCairo build.

* WebCore.vcproj/WebCore.vcproj: Add missing file to WinCairo
  build.  Exclude for standard Apple build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd API to get the bundle page overlay fade in fraction.
andersca@apple.com [Fri, 15 Apr 2011 22:54:49 +0000 (22:54 +0000)]
Add API to get the bundle page overlay fade in fraction.

Reviewed by Sam Weinig.

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlayFractionFadedIn):
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 15 Apr 2011 22:31:29 +0000 (22:31 +0000)]
2011-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Fade the find page overlay
        https://bugs.webkit.org/show_bug.cgi?id=58697

        Add a symbol that WebKit2 needs.

        * WebCore.exp.in:
2011-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Fade the find page overlay
        https://bugs.webkit.org/show_bug.cgi?id=58697

        * WebProcess/WebPage/FindController.cpp:
        Make the color components floats.

        (WebKit::overlayBackgroundColor):
        (WebKit::holeShadowColor):
        (WebKit::holeFillColor):
        Add helper functions for returning the colors given the fraction faded in.

        (WebKit::FindController::drawRect):
        Use the new helper functions.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::installPageOverlay):
        Start the fade animation unless we're replacing an already existing page overlay
        with another.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 58701 - DFG JIT - add GetLocal/SetLocal nodes
barraclough@apple.com [Fri, 15 Apr 2011 22:30:06 +0000 (22:30 +0000)]
Bug 58701 - DFG JIT - add GetLocal/SetLocal nodes

Reviewed by Geoff Garen.

Use these for both access to arguments & local variables, adds ability
to set locals, such that values will persist between basic blocks.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::VariableRecord::VariableRecord):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::derefChildren):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::local):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 15 Apr 2011 22:17:20 +0000 (22:17 +0000)]
2011-04-15  Andreas Kling  <kling@webkit.org>

        Unreviewed, remove a Qt-specific expectation that's no longer needed.

        * platform/qt/Skipped:
        * platform/qt/fast/loader/onload-policy-ignore-for-frame-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 15 Apr 2011 21:56:48 +0000 (21:56 +0000)]
2011-04-15  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        RenderDetailsMarker should belong to shadow element.
        https://bugs.webkit.org/show_bug.cgi?id=58591

        * Render tree structure has changed.
        * Changed style rule on details-writing-mode.html to avoid to hit shadow CSS leak bug.

        * fast/html/details-writing-mode.html:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-1-expected.checksum:
        * platform/mac/fast/html/details-add-summary-1-expected.png:
        * platform/mac/fast/html/details-add-summary-1-expected.txt:
        * platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-10-expected.checksum:
        * platform/mac/fast/html/details-add-summary-10-expected.png:
        * platform/mac/fast/html/details-add-summary-10-expected.txt:
        * platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-2-expected.checksum:
        * platform/mac/fast/html/details-add-summary-2-expected.png:
        * platform/mac/fast/html/details-add-summary-2-expected.txt:
        * platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-3-expected.checksum:
        * platform/mac/fast/html/details-add-summary-3-expected.png:
        * platform/mac/fast/html/details-add-summary-3-expected.txt:
        * platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-4-expected.checksum:
        * platform/mac/fast/html/details-add-summary-4-expected.png:
        * platform/mac/fast/html/details-add-summary-4-expected.txt:
        * platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-5-expected.checksum:
        * platform/mac/fast/html/details-add-summary-5-expected.png:
        * platform/mac/fast/html/details-add-summary-5-expected.txt:
        * platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-6-expected.checksum:
        * platform/mac/fast/html/details-add-summary-6-expected.png:
        * platform/mac/fast/html/details-add-summary-6-expected.txt:
        * platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-7-expected.checksum:
        * platform/mac/fast/html/details-add-summary-7-expected.png:
        * platform/mac/fast/html/details-add-summary-7-expected.txt:
        * platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-8-expected.checksum:
        * platform/mac/fast/html/details-add-summary-8-expected.png:
        * platform/mac/fast/html/details-add-summary-8-expected.txt:
        * platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
        * platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
        * platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
        * platform/mac/fast/html/details-add-summary-9-expected.checksum:
        * platform/mac/fast/html/details-add-summary-9-expected.png:
        * platform/mac/fast/html/details-add-summary-9-expected.txt:
        * platform/mac/fast/html/details-no-summary1-expected.checksum:
        * platform/mac/fast/html/details-no-summary1-expected.png:
        * platform/mac/fast/html/details-no-summary1-expected.txt:
        * platform/mac/fast/html/details-no-summary2-expected.checksum:
        * platform/mac/fast/html/details-no-summary2-expected.png:
        * platform/mac/fast/html/details-no-summary2-expected.txt:
        * platform/mac/fast/html/details-no-summary3-expected.checksum:
        * platform/mac/fast/html/details-no-summary3-expected.png:
        * platform/mac/fast/html/details-no-summary3-expected.txt:
        * platform/mac/fast/html/details-no-summary4-expected.checksum:
        * platform/mac/fast/html/details-no-summary4-expected.png:
        * platform/mac/fast/html/details-no-summary4-expected.txt:
        * platform/mac/fast/html/details-open-javascript-expected.checksum:
        * platform/mac/fast/html/details-open-javascript-expected.png:
        * platform/mac/fast/html/details-open-javascript-expected.txt:
        * platform/mac/fast/html/details-open1-expected.checksum:
        * platform/mac/fast/html/details-open1-expected.png:
        * platform/mac/fast/html/details-open1-expected.txt:
        * platform/mac/fast/html/details-open2-expected.checksum:
        * platform/mac/fast/html/details-open2-expected.png:
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-open3-expected.checksum:
        * platform/mac/fast/html/details-open3-expected.png:
        * platform/mac/fast/html/details-open3-expected.txt:
        * platform/mac/fast/html/details-open4-expected.checksum:
        * platform/mac/fast/html/details-open4-expected.png:
        * platform/mac/fast/html/details-open4-expected.txt:
        * platform/mac/fast/html/details-open5-expected.checksum:
        * platform/mac/fast/html/details-open5-expected.png:
        * platform/mac/fast/html/details-open5-expected.txt:
        * platform/mac/fast/html/details-open6-expected.checksum:
        * platform/mac/fast/html/details-open6-expected.png:
        * platform/mac/fast/html/details-open6-expected.txt:
        * platform/mac/fast/html/details-position-expected.checksum:
        * platform/mac/fast/html/details-position-expected.png:
        * platform/mac/fast/html/details-position-expected.txt:
        * platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
        * platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-1-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-1-expected.png:
        * platform/mac/fast/html/details-remove-summary-1-expected.txt:
        * platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
        * platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-2-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-2-expected.png:
        * platform/mac/fast/html/details-remove-summary-2-expected.txt:
        * platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
        * platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-3-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-3-expected.png:
        * platform/mac/fast/html/details-remove-summary-3-expected.txt:
        * platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
        * platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-4-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-4-expected.png:
        * platform/mac/fast/html/details-remove-summary-4-expected.txt:
        * platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
        * platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-5-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-5-expected.png:
        * platform/mac/fast/html/details-remove-summary-5-expected.txt:
        * platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
        * platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
        * platform/mac/fast/html/details-remove-summary-6-expected.checksum:
        * platform/mac/fast/html/details-remove-summary-6-expected.png:
        * platform/mac/fast/html/details-remove-summary-6-expected.txt:
        * platform/mac/fast/html/details-writing-mode-expected.checksum:
        * platform/mac/fast/html/details-writing-mode-expected.png:
        * platform/mac/fast/html/details-writing-mode-expected.txt:
2011-04-15  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        RenderDetailsMarker should belong to shadow element.
        https://bugs.webkit.org/show_bug.cgi?id=58591

        - Introduced DetailsMarkerControl element, which is a shadow element of <summary>, creates RenderDetailsMarker.
        - Removed custom layout code from RenderDetails, RenderDetailsMarker, which is now done by usual CSS layout.
          Note that marker size is given via style for -webkit-details-marker pseudo class.
        - Converted default summary implementation from pure-renderer style to shadow of HTMLDetailsElement.
          Now RenderDetails knows nothing about default summary.
        - Moved event handling code from HTMLDetailsElement to HTMLSummaryElement because now the marker is always child of
          <summary>, and the clickable area is now <summary> itself.

        - Note that the rendering result is changed due to the conversion from custom layout code to usual CSS styling.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/html.css:
        (summary::-webkit-details-marker):
        * dom/Element.cpp:
        (WebCore::Element::attach):
        * dom/Node.cpp:
        (WebCore::shouldCreateRendererFor):
        * dom/Node.h:
        (WebCore::Node::canHaveLightChildRendererWithShadow):
        * html/HTMLDetailsElement.cpp:
        (WebCore::HTMLDetailsElement::findSummaryFor):
        (WebCore::HTMLDetailsElement::findMainSummary):
        (WebCore::HTMLDetailsElement::refreshMainSummary):
        (WebCore::HTMLDetailsElement::createShadowSubtree):
        (WebCore::HTMLDetailsElement::childrenChanged):
        (WebCore::HTMLDetailsElement::finishParsingChildren):
        (WebCore::HTMLDetailsElement::toggleOpen):
        * html/HTMLDetailsElement.h:
        (WebCore::HTMLDetailsElement::canHaveLightChildRendererWithShadow):
        * html/HTMLSummaryElement.cpp:
        (WebCore::HTMLSummaryElement::create):
        (WebCore::HTMLSummaryElement::createShadowSubtree):
        (WebCore::HTMLSummaryElement::detailsElement):
        (WebCore::HTMLSummaryElement::isMainSummary):
        (WebCore::HTMLSummaryElement::defaultEventHandler):
        * html/HTMLSummaryElement.h:
        (WebCore::HTMLSummaryElement::canHaveLightChildRendererWithShadow):
        * html/shadow/DetailsMarkerControl.cpp: Added.
        (WebCore::DetailsMarkerControl::DetailsMarkerControl):
        (WebCore::DetailsMarkerControl::createRenderer):
        (WebCore::DetailsMarkerControl::rendererIsNeeded):
        (WebCore::DetailsMarkerControl::shadowPseudoId):
        (WebCore::DetailsMarkerControl::summaryElement):
        * html/shadow/DetailsMarkerControl.h: Added.
        (WebCore::DetailsMarkerControl::create):
        * rendering/RenderDetails.cpp:
        (WebCore::RenderDetails::RenderDetails):
        (WebCore::RenderDetails::styleDidChange):
        (WebCore::RenderDetails::moveSummaryToContents):
        (WebCore::RenderDetails::checkMainSummary):
        (WebCore::RenderDetails::layout):
        * rendering/RenderDetails.h:
        * rendering/RenderDetailsMarker.cpp:
        (WebCore::RenderDetailsMarker::RenderDetailsMarker):
        (WebCore::RenderDetailsMarker::isOpen):
        (WebCore::RenderDetailsMarker::getPath):
        (WebCore::RenderDetailsMarker::paint):
        (WebCore::RenderDetailsMarker::details):
        * rendering/RenderDetailsMarker.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 58696 - DFG JIT split handling of vars/temporaries
barraclough@apple.com [Fri, 15 Apr 2011 21:45:42 +0000 (21:45 +0000)]
Bug 58696 - DFG JIT split handling of vars/temporaries

Reviewed by Sam Weinig.

Presently all callee registers are treated as having single block scope,
since the DFG JIT can only compile single block functions. In order to
expand the JIT to support control flow we will need to change to retaining
locals (but not temporaries) across basic block boundaries.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getTemporary):
(JSC::DFG::ByteCodeParser::setTemporary):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::getInt32Constant):
(JSC::DFG::ByteCodeParser::getDoubleConstant):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::constantUndefined):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
* dfg/DFGNode.h:
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Fri, 15 Apr 2011 21:44:35 +0000 (21:44 +0000)]
Fix Windows build.

* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::fadeAnimationTimerFired):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 15 Apr 2011 21:44:14 +0000 (21:44 +0000)]
2011-04-15  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, update baselines for compositing changes.
        https://bugs.webkit.org/show_bug.cgi?id=57113

        * platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
        * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium-gpu-mac/compositing/tiling/huge-layer-img-expected.png: Added.
        * platform/chromium-gpu-mac/compositing/tiling/huge-layer-img-expected.txt: Added.
        * platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
        * platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
        * platform/chromium-gpu-win/compositing/tiling/huge-layer-img-expected.png: Added.
        * platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
        * platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 15 Apr 2011 21:36:13 +0000 (21:36 +0000)]
2011-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add the ability for PageOverlays to fade in and out
        https://bugs.webkit.org/show_bug.cgi?id=58694

        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageUninstallPageOverlay):
        WebPage::uninstallPageOverlay now takes a boolean. Default to false for now.

        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::findString):
        Pass false to uninstallPageOverlay.

        (WebKit::FindController::hideFindUI):
        Pass true to uninstallPageOverlay.

        * WebProcess/WebPage/PageOverlay.cpp:
        (WebKit::PageOverlay::PageOverlay):
        Initialize new member variables.

        (WebKit::PageOverlay::bounds):
        Get rid of an unnecessary webPage() getter.

        (WebKit::PageOverlay::setPage):
        Stop the animation timer.

        (WebKit::PageOverlay::startFadeInAnimation):
        Update m_fractionFadedIn and call startFadeAnimation.

        (WebKit::PageOverlay::startFadeOutAnimation):
        Ditto.

        (WebKit::PageOverlay::startFadeAnimation):
        Initialize m_fadeAnimationStartTime and start the fade animation timer.

        (WebKit::PageOverlay::fadeAnimationTimerFired):
        Update m_fractionFadedIn and call setNeedsDisplay().

        * WebProcess/WebPage/PageOverlay.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::uninstallPageOverlay):
        If fadeOut is true, tell the page overlay to start the fade out animation.
        When the fade animation is complete, the page overlay will uninstall itself.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 15 Apr 2011 21:18:20 +0000 (21:18 +0000)]
2011-04-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Implement localize strings for windows WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=58688

        * platform/win/LocalizedStringsWin.cpp:
        (WebCore::createWebKitBundle):
        (WebCore::webKitBundle):
        (WebCore::localizedString):
        Add implementation of localizedString for Windows.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Fixing build.
msaboff@apple.com [Fri, 15 Apr 2011 21:13:30 +0000 (21:13 +0000)]
Fixing build.

    Inadvertantly checked in
    Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
    instead of Source/JavaScriptCore/JavaScriptCore.exp

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 15 Apr 2011 20:56:18 +0000 (20:56 +0000)]
2011-04-15  Andreas Kling  <kling@webkit.org>

        Skip failing tests after r84010 and r84012.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 15 Apr 2011 20:51:24 +0000 (20:51 +0000)]
2011-04-15  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        globalObject moved to JSObjectWithGlobalObject.cpp inhibits inlining
        https://bugs.webkit.org/show_bug.cgi?id=58677

        Moved JSObjectWithGlobalObject::globalObject() to
        runtime/JSObjectWithGlobalObject.h to allow the compiler to inline
        it for a performance benefit.  An equivalent instance had been in
        a header file before r60057.

        * JavaScriptCore.exp:
        * runtime/JSObjectWithGlobalObject.cpp:
        * runtime/JSObjectWithGlobalObject.h:
        (JSC::JSObjectWithGlobalObject::globalObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 15 Apr 2011 20:47:54 +0000 (20:47 +0000)]
2011-04-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Some mechanical DOM wrapper cleanup
        https://bugs.webkit.org/show_bug.cgi?id=58689

        * WebCore.exp.in: Export!

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::isReachableFromDOM): Inverted the inDocument test to make the
        relationship of the special cases to the normal case clearer.

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::toJSArrayBufferView):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::getCachedDOMObjectWrapper):
        (WebCore::cacheDOMObjectWrapper):
        * bindings/js/JSDOMBinding.h:
        (WebCore::createDOMObjectWrapper):
        (WebCore::getDOMObjectWrapper):
        (WebCore::createDOMNodeWrapper):
        (WebCore::getDOMNodeWrapper): Changed DOM wrapper functions to operate
        in terms of DOMWrapperWorlds instead of ExecStates. This is clearer,
        and ever-so-slightly faster.

        Removed hasCachedXXX functions, now that they're unused.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::history):
        (WebCore::JSDOMWindow::location):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        (WebCore::toJS):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapperInline):
        * bindings/js/JSNodeCustom.h:
        (WebCore::getCachedDOMNodeWrapper):
        (WebCore::cacheDOMNodeWrapper):
        (WebCore::toJS):
        * bindings/js/JSSVGPathSegCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::toJS): Updated for changes above.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::dropProtection): Removed use of hasCachedDOMObjectWrapper
        because XHR is almost always created and used by JavaScript, so it's
        simpler to just always report extra cost.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r81262): plugins/refcount-leaks.html failing on Windows
bweinstein@apple.com [Fri, 15 Apr 2011 20:45:46 +0000 (20:45 +0000)]
REGRESSION(r81262): plugins/refcount-leaks.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=56478

Unskip plugins/refcount-leaks.html on Windows because it is now
passing on release and debug.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 15 Apr 2011 20:33:56 +0000 (20:33 +0000)]
2011-04-15  James Robinson  <jamesr@chromium.org>

        Add chromium linux expectations for direct-image-compositing.html

        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.checksum:
        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 15 Apr 2011 20:25:40 +0000 (20:25 +0000)]
2011-04-15  Chris Rogers  <crogers@google.com>

        Unreviewed.

        Update test_expectations.txt with more failing fast/borders tests
        https://bugs.webkit.org/show_bug.cgi?id=58685

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 15 Apr 2011 20:11:31 +0000 (20:11 +0000)]
2011-04-15  Andreas Kling  <kling@webkit.org>

        Rolling out accidental part of r84010.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
        (WebCore::RenderThemeQt::setButtonPadding):
2011-04-15  Andreas Kling  <kling@webkit.org>

        Rolling out accidental part of r84010.

        * fast/forms/button-line-break.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoForgot windows build fix.
oliver@apple.com [Fri, 15 Apr 2011 20:07:10 +0000 (20:07 +0000)]
Forgot windows build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 15 Apr 2011 20:01:50 +0000 (20:01 +0000)]
2011-04-15  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Yury Semikhatsky.

        Frontend Part of Web Inspector: Remote Web Inspector - Cross Platform InspectorServer
        https://bugs.webkit.org/show_bug.cgi?id=51364

        The front end should not use a transparent background when
        loaded as a web page (remote debugging) but should when loaded
        regularly in a custom window. This adds a "remote" style class
        onto the document body when the page is loaded remotely.

        * inspector/front-end/inspector.css:
        (body.detached.platform-mac-snowleopard:not(.remote) #toolbar): respect the "remote" class.
        * inspector/front-end/inspector.js: add a "remote" class on the body when loaded remotely.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 15 Apr 2011 20:01:33 +0000 (20:01 +0000)]
2011-04-15  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        JSLock ASSERT seen often when using the inspector for long
        periods of time. We should take the JSLock whenever we
        might allocate memory in the JavaScript Heap.

        JSC InjectedScriptHost::nodeAsScriptValue should take JSLock before possible JavaScript Allocations
        https://bugs.webkit.org/show_bug.cgi?id=58674

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::nodeAsScriptValue): take the JSLock.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-14 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 15 Apr 2011 19:55:54 +0000 (19:55 +0000)]
2011-04-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make JSNodeFilterCondition handle its lifetime correctly
        https://bugs.webkit.org/show_bug.cgi?id=58622

        Add export

        * JavaScriptCore.exp:
2011-04-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make JSNodeFilterCondition handle its lifetime correctly
        https://bugs.webkit.org/show_bug.cgi?id=58622

        Switch over to a WeakHandle and external roots to keep the
        condition value live.

        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
        (WebCore::JSNodeFilterCondition::markAggregate):
        (WebCore::JSNodeFilterCondition::acceptNode):
        (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
        * bindings/js/JSNodeFilterCondition.h:
        (WebCore::JSNodeFilterCondition::create):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoViews should be made visible before painting in WM_PRINTCLIENT messages
bweinstein@apple.com [Fri, 15 Apr 2011 19:46:49 +0000 (19:46 +0000)]
Views should be made visible before painting in WM_PRINTCLIENT messages
https://bugs.webkit.org/show_bug.cgi?id=58676
<rdar://problem/9279211>

Reviewed by Adam Roben.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::onPrintClientEvent): If our view isn't currently visible set it to visible
    before painting, then reset it back to not visible after painting.
(WebKit::WebView::onShowWindowEvent): Call setIsVisible instead of duplicating logic.
(WebKit::WebView::setIsVisible): Set the m_isVisible flag and call viewStateDidChange.
* UIProcess/win/WebView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QNetworkReplyHandler refactoring: some adjustments
luiz@webkit.org [Fri, 15 Apr 2011 19:42:04 +0000 (19:42 +0000)]
[Qt] QNetworkReplyHandler refactoring: some adjustments
https://bugs.webkit.org/show_bug.cgi?id=57092

Reviewed by Andreas Kling.

- Removing flag m_redirected from QNetworkReplyHandler and using m_redirectionTargetUrl.isValid() instead.
- Moving flag m_responseContainsData from QNetworkReplyHandler to the reply wrapper and removing the connection of
signal metaDataChanged for m_responseContainsData to be consistent.
- Using an OwnPtr to keep the reference to the QNetworkReplyWrapper.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveReadyRead):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::release):
(WebCore::shouldIgnoreHttpError):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::redirect):
(WebCore::QNetworkReplyHandler::forwardData):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyWrapper::responseContainsData):
(WebCore::QNetworkReplyWrapper::redirected):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Jon Lee <jonlee@apple.com>
andersca@apple.com [Fri, 15 Apr 2011 19:37:39 +0000 (19:37 +0000)]
2011-04-15  Jon Lee  <jonlee@apple.com>

        Reviewed by Anders Carlsson.

        onClick does not function with <select> elements in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=57904
        <rdar://problem/9217757>

        Reviewed by Anders Carlsson.

        * Shared/NativeWebMouseEvent.h: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h.
        (WebKit::NativeWebMouseEvent::nativeEvent):
        * Shared/mac/NativeWebMouseEventMac.mm: Added.
        (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
        * Shared/qt/NativeWebMouseEventQt.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h.
        (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
        * Shared/win/NativeWebMouseEventWin.cpp: Copied from Source/WebKit2/UIProcess/WebPopupMenuProxy.h.
        (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView mouseMoved:]):
        (-[WKView _mouseHandler:]): Pre-compiler mouse handler calls need to use the new NativeWebMouseEvent class
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::mouseMoveEvent):
        (QWKPagePrivate::mousePressEvent):
        (QWKPagePrivate::mouseReleaseEvent):
        (QWKPagePrivate::mouseDoubleClickEvent):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::handleMouseEvent): keep track of mouse down event in order to be able to send a fake mouse up event on the select element
        (WebKit::WebPageProxy::currentMouseDownEvent): for access by the popup menu proxy to dispatch the fake mouse up event
        (WebKit::WebPageProxy::didReceiveEvent): clear out the cached mouse down event
        (WebKit::WebPageProxy::processDidCrash): clear out the cached events since we assume that didReceiveEvent did not called prior to the crash
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPopupMenuProxy.h:
        * UIProcess/mac/WebPopupMenuProxyMac.mm:
        (WebKit::WebPopupMenuProxyMac::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
        * UIProcess/win/WebPopupMenuProxyWin.cpp:
        (WebKit::WebPopupMenuProxyWin::showPopupMenu): after notifying the popup menu client that the value changed, fake mouse up and mouse move events are posted
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onMouseEvent):
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * win/WebKit2.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Chromium build fix.
ap@apple.com [Fri, 15 Apr 2011 19:34:14 +0000 (19:34 +0000)]
    Chromium build fix.

        * platform/SecureTextInput.h: CARBON_SECURE_INPUT_MODE no longer exists.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Qt build fix.
ap@apple.com [Fri, 15 Apr 2011 19:30:10 +0000 (19:30 +0000)]
    Qt build fix.

        * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::selectionStateChanged): Wrap the variable
        in PLATFORM(MAC), too, as it's unused on other platforms.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 15 Apr 2011 19:25:29 +0000 (19:25 +0000)]
2011-04-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] DRT: Default custom policy delegate decision should be Ignore.

        If layoutTestController.setCustomPolicyDelegate() is called with only
        one argument, the second ("permissive") should default to false.

        * DumpRenderTree/qt/LayoutTestControllerQt.h:
2011-04-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] DRT: Default custom policy delegate decision should be Ignore.

        * platform/qt/Skipped: Unskip now passing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet the right reviewer up in here.
beidson@apple.com [Fri, 15 Apr 2011 19:25:20 +0000 (19:25 +0000)]
Get the right reviewer up in here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9287880> and https://bugs.webkit.org/show_bug.cgi?id=58596
beidson@apple.com [Fri, 15 Apr 2011 19:24:16 +0000 (19:24 +0000)]
<rdar://problem/9287880> and https://bugs.webkit.org/show_bug.cgi?id=58596
WK2: Past searches not remembered for <input type=search results="5" autosave="foo">

Reviewed by Sam Weinig.

Add SaveRecentSearches and LoadRecentSearches messages:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPageProxy.h:

Message up to the UIProcess for the save/load operations:
* WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
* WebProcess/WebCoreSupport/WebPopupMenu.h:
(WebKit::WebPopupMenu::page):

Save the values to disk CFPreference-style:
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

Stubbed out for non-CF platforms:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 15 Apr 2011 19:22:34 +0000 (19:22 +0000)]
2011-04-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] DRT: Block access to external URLs.

        * platform/qt/Skipped: Unskip now passing tests.
2011-04-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] DRT: Block access to external URLs.

        Implement the "Blocked access to external URL" behavior for Qt's DRT,
        based on what other ports are doing.

        Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Mike Reed <reed@google.com>
commit-queue@webkit.org [Fri, 15 Apr 2011 18:45:07 +0000 (18:45 +0000)]
2011-04-15  Mike Reed  <reed@google.com>

        Reviewed by Darin Fisher.

        hide unused static function when SKIA_GPU is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58670

        No new tests. Just fixes a warning (treated as an error) when SKIA_GPU is enabled

        * platform/graphics/skia/ImageSkia.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 15 Apr 2011 18:43:06 +0000 (18:43 +0000)]
2011-04-15  James Robinson  <jamesr@chromium.org>

        Fix duplicate expectation for compositing/tiling/huge-layer-img.html on chromium mac.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 15 Apr 2011 18:39:23 +0000 (18:39 +0000)]
2011-04-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Beth Dakin.

        Some borders with border-radius do not have rounded inner edges
        https://bugs.webkit.org/show_bug.cgi?id=58457

        Improve the logic used to compute the inner radii on curved
        borders, to maintain borders of even thickness around the curve.

        Tests: fast/borders/mixed-border-styles-radius.html
               fast/borders/mixed-border-styles.html

        * rendering/RenderBoxModelObject.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::computeBorderOuterRect):
        (WebCore::RenderBoxModelObject::computeBorderInnerRect):
        Two new utility functions to share some code that was in both paintBorder()
        and paintBoxShaadow().
        getRoundedInnerBorderWithBorderWidths() now takes the outer border box
        as well as the inner box.

        (WebCore::RenderBoxModelObject::paintBorder): Call new methods.
        (WebCore::RenderBoxModelObject::paintBoxShadow): Ditto.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        getRoundedInnerBorderWithBorderWidths() now takes the outer border box
        as well as the inner box.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
        * rendering/style/RenderStyle.h:
        Compute the inner radii by starting with teh radii used for the
        outer box, and then shrinking them down based on the border thickness.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Dan Bernstein.
ap@apple.com [Fri, 15 Apr 2011 18:38:46 +0000 (18:38 +0000)]
    Reviewed by Dan Bernstein.

        WebKit2: Password field input does not switch to ASCII-compatible source
        https://bugs.webkit.org/show_bug.cgi?id=58583
        <rdar://problem/9059651>

        The implementation is more modern than what we have in WK1. Instead of returning a null
        input context (as in non-editable content), we now set page context's properties.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 15 Apr 2011 18:31:27 +0000 (18:31 +0000)]
2011-04-13  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        Continue (3rd) experiment with moving caret by word in visual order.
        https://bugs.webkit.org/show_bug.cgi?id=58294

        * editing/selection/move-by-word-visually-expected.txt:
        * editing/selection/move-by-word-visually.html:
2011-04-13  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        Continue (3rd) experiment with moving caret by word in visual order.
        https://bugs.webkit.org/show_bug.cgi?id=58294

        This patch along with r82588 and r83483 implements moving caret by
        word in visual order.

        The overall algorithm is:
        1. First get the InlineBox and offset of the pass-in VisiblePosition.
        2. Based on the position (left boundary, middle, right boundary) of the offset and the
           direction of the movement, look for visually adjacent word breaks.
        2.1 If the offset is the minimum offset of the box,
            return the rightmost word boundary in previous boxes if moving left.
            return the leftmost word boundary in box and next boxes if moving right.
        2.2 Similar for the case when offset is at the maximum offset of the box.
        2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition
            or nextWordPosition based on the directionality of the box. If this word break position
            is also inside the same box, return it. Otherwise (the nextWordPosition or
            previousWordPosition is not in the same box or is at the box boundary), collect all the
            word breaks in the box and search for the one closest to the input "offset" based on
            box directionality, block directionality, and movement direction. Continue search in
            adjacent boxes if needed.

        Notes:
        1. Word boundaries are collected one box at a time. Only when a boundary that is closest to
           the input position (in the moving direction) is not available in current box, word
           boundaries in adjacent box will be collected. So, there is no need to save InlineBox in
           word boundaries. Instead, the word boundaries are saved as a pair
           (VisiblePosition, offset) to avoid recomputing VisiblePosition.

        2. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block
           and right boundary of a word in RTL block). And word boundaries are collected using
           previousWordPosition() and nextWordPosition(). So when box directionality is the same as
           block directionality, word boundaries are collected from right to left visually in a LTR
           box, and word boundaries are collected from left to right visually in a RTL box. It is
           the other way around when box directionality is different from block directionality.

        3. To find the right kinds of word boundaries, we must move back and forth between words
           in some situations. For example, if we're moving to the right in a LTR box in LTR block,
           we cannot simply return nextWordPosition() because it would return the right boundary
           of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().

        4. When collecting word breaks inside a box, it first computes a start position, then
           collect the right kind of word breaks until it reaches the end of (or beyond) the box.
           In the meanwhile, it might need special handling on the rightmost or leftmost position
           based on the directionality of the box and block. These computations do not consider the
           box's bidi level.

        * editing/visible_units.cpp:
        (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
        (WebCore::collectWordBreaksInBox):
        (WebCore::previousWordBoundaryInBox):
        (WebCore::nextWordBoundaryInBox):
        (WebCore::visuallyLastWordBoundaryInBox):
        (WebCore::leftWordBoundary):
        (WebCore::rightWordBoundary):
        (WebCore::leftWordPosition):
        (WebCore::rightWordPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83996 268f45cc-cd09-0410-ab3c-d52691b4dbfc