WebKit.git
9 years agoBuild fix.
mitz@apple.com [Thu, 28 Jul 2011 16:26:50 +0000 (16:26 +0000)]
Build fix.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] New expectations after r91924
tonyg@chromium.org [Thu, 28 Jul 2011 15:33:53 +0000 (15:33 +0000)]
[chromium] New expectations after r91924
https://bugs.webkit.org/show_bug.cgi?id=65320

Unreviewed expectations update.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
beidson@apple.com [Thu, 28 Jul 2011 15:32:40 +0000 (15:32 +0000)]
<rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView

Source/WebCore:

Move the heavy lifting done in StorageTracker::initializeTracker() until when the global tracker is actually
accessed, therefore deferring it until a web page actually uses LocalStorage or the app uses the API.

Reviewed by Maciej Stachowiak.

No new tests. (Not possible to test this API implementation detail)

* WebCore.exp.in:

* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::StorageAreaImpl): Access the global StorageTracker to indicate that a web page
  is actually using the storage APIs.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker): Moved the potentially hefty work from here...
(WebCore::StorageTracker::internalInitialize): ...to here.
(WebCore::StorageTracker::tracker): If the global tracker hasn't had internalInitialize() called, do so.
(WebCore::StorageTracker::StorageTracker):
* storage/StorageTracker.h:

Source/WebKit/mac:

Reviewed by Maciej Stachowiak.

* Storage/WebStorageManager.mm:
(WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().

Source/WebKit2:

Reviewed by Maciej Stachowiak.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Pass a null client pointer in the new form of initializeTracker()

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Thu, 28 Jul 2011 15:25:03 +0000 (15:25 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: My last attempt to paint Qt-Mac bot green.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Copy and paste is broken in WebKit2
carlosgc@webkit.org [Thu, 28 Jul 2011 15:22:37 +0000 (15:22 +0000)]
[GTK] Copy and paste is broken in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=65252

Reviewed by Martin Robinson.

Use gtk_clipboard_get_for_display() instead of
gtk_widget_get_clipboard(), using the the default display when
there's no page client widget, which is the case of WebKit2.

* platform/gtk/PasteboardHelper.cpp:
(WebCore::displayFromFrame): Return the display of the current
frame widget or the default display if there's no widget.
(WebCore::PasteboardHelper::getClipboard):
(WebCore::PasteboardHelper::getPrimarySelectionClipboard):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Add resource initiator column to network panel.
vsevik@chromium.org [Thu, 28 Jul 2011 15:13:34 +0000 (15:13 +0000)]
Web Inspector: Add resource initiator column to network panel.
https://bugs.webkit.org/show_bug.cgi?id=65105

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-initiator.html

* English.lproj/localizedStrings.js:
* dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):
* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculationImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculation):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::willRecalculateStyle):
(WebCore::InspectorResourceAgent::didRecalculateStyle):
(WebCore::InspectorResourceAgent::didScheduleStyleRecalculation):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._toggleGridMode):
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.InitiatorComparator):
* inspector/front-end/networkLogView.css:
(.initiator-column a):

LayoutTests:

* http/tests/inspector/network/network-initiator-expected.txt: Added.
* http/tests/inspector/network/network-initiator.html: Added.
* http/tests/inspector/network/resources/initiator.css: Added.
(.image-background):
(.image-background-2):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] New expectations for r91915
tonyg@chromium.org [Thu, 28 Jul 2011 14:39:17 +0000 (14:39 +0000)]
[chromium] New expectations for r91915
https://bugs.webkit.org/show_bug.cgi?id=65317

Unreviewed expections update.

* platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.png: Added.
* platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Thu, 28 Jul 2011 14:27:27 +0000 (14:27 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: One more attempt to paint Qt-Mac bot green.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUncomment some suppressions we'll need for the upcoming skia roll.
senorblanco@chromium.org [Thu, 28 Jul 2011 14:25:41 +0000 (14:25 +0000)]
Uncomment some suppressions we'll need for the upcoming skia roll.

Unreviewed; chromium test_expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-28 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Thu, 28 Jul 2011 14:24:32 +0000 (14:24 +0000)]
2011-07-28  Rob Buis  <rbuis@rim.com>

        Use styling test from ietestcenter fails
        https://bugs.webkit.org/show_bug.cgi?id=62147

        Reviewed by Nikolas Zimmermann.

        Make sure CSS selectors are applied to the DOM tree referenced by <use>, not the internal shadow tree. In order to quickly
        find the corresponding DOM tree element store this info in SVGElementRareData.

        Test: svg/W3C-SVG-1.1-SE/struct-use-11-f.svg

        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeContainerElement::styleForRenderer):
        * rendering/svg/SVGShadowTreeElements.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::correspondingElement):
        (WebCore::SVGElement::setCorrespondingElement):
        (WebCore::SVGElement::styleForRenderer):
        * svg/SVGElement.h:
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
        * svg/SVGElementRareData.h:
        (WebCore::SVGElementRareData::SVGElementRareData):
        (WebCore::SVGElementRareData::correspondingElement):
        (WebCore::SVGElementRareData::setCorrespondingElement):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::removedFromDocument):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
        * svg/SVGUseElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThis fixes build without video enabled.
commit-queue@webkit.org [Thu, 28 Jul 2011 14:12:40 +0000 (14:12 +0000)]
This fixes build without video enabled.
https://bugs.webkit.org/show_bug.cgi?id=65084

Patch by Denis Oliver Kropp <dok@directfb.org> on 2011-07-28
Reviewed by Philippe Normand.

Test with --disable-video.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 28 Jul 2011 14:07:35 +0000 (14:07 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
* platform/qt/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Thu, 28 Jul 2011 13:34:50 +0000 (13:34 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: Paint the bot green with skipping all failing and crashing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
ossy@webkit.org [Thu, 28 Jul 2011 13:15:26 +0000 (13:15 +0000)]
Unreviewed gardening.

[Qt][WK2]REGRESSION(r91863): It made 388 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=65310

[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
https://bugs.webkit.org/show_bug.cgi?id=65266

REGRESSION (r91125): Google Drawings is broken
https://bugs.webkit.org/show_bug.cgi?id=65257

* platform/qt-wk2/Skipped: Skip two failing fast test.
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Updated.
* platform/qt/Skipped:
 - Typo fix: Add missing bugzilla link - https://bugs.webkit.org/show_bug.cgi?id=65266
 - Skip svg/custom/zero-path-square-cap-rendering2.svg until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Pass the value of useHixie76Protocol flag to WebSocket object
yutak@chromium.org [Thu, 28 Jul 2011 12:21:04 +0000 (12:21 +0000)]
WebSocket: Pass the value of useHixie76Protocol flag to WebSocket object
https://bugs.webkit.org/show_bug.cgi?id=65250

Reviewed by Alexey Proskuryakov.

Add useHixie76Protocol() method to WebSocketChannel and its family. To implement hybi-specific
attributes in WebSocket object, WebSocket class needs to be able to get the value of
useHixie76Protocol flag of WebSocketChannel.

If the WebSocket object is created in a worker thread, the flag value must be obtained from
WebSocketChannel which resides in the loader thread (through WorkerThreadableWebSocketChannel).
Since the value does not change after creation of WebSocketChannel, it can be cached in
the worker thread.

There is no change in behavior, thus no new tests.

* websockets/ThreadableWebSocketChannel.h:
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::useHixie76Protocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setUseHixie76Protocol):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::useHixie76Protocol):
* websockets/WebSocketChannel.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::useHixie76Protocol):
(WebCore::WorkerThreadableWebSocketChannel::Peer::useHixie76Protocol):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
* websockets/WorkerThreadableWebSocketChannel.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2]REGRESSION(r91863): It made 388 editing tests fail
ossy@webkit.org [Thu, 28 Jul 2011 12:19:13 +0000 (12:19 +0000)]
[Qt][WK2]REGRESSION(r91863): It made 388 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=65310

* platform/qt-wk2/Skipped: Skip failing editing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline pixel tests for file upload controls on chromium-win.
commit-queue@webkit.org [Thu, 28 Jul 2011 12:06:55 +0000 (12:06 +0000)]
Rebaseline pixel tests for file upload controls on chromium-win.
https://bugs.webkit.org/show_bug.cgi?id=65245

Patch by Patrick Dubroy <dubroy@chromium.org> on 2011-07-28
Reviewed by Gustavo Noronha Silva.

r91759 changed the appearance of file upload controls on gtk,
chromium-win and chromium-linux. New baselines were already committed
for chromium-linux (same changeset) and gtk (r91759).

* platform/chromium-win/fast/forms/box-shadow-override-expected.png:
* platform/chromium-win/fast/forms/file-input-direction-expected.png:
* platform/chromium-win/fast/forms/file-input-disabled-expected.png:
* platform/chromium-win/fast/forms/form-element-geometry-expected.png:
* platform/chromium-win/fast/forms/input-appearance-height-expected.png:
* platform/chromium-win/fast/forms/input-file-re-render-expected.png:
* platform/chromium-win/fast/forms/input-value-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add platform specific expected result for a new test.
ossy@webkit.org [Thu, 28 Jul 2011 12:03:53 +0000 (12:03 +0000)]
[Qt] Add platform specific expected result for a new test.

* platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
* platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-28 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Thu, 28 Jul 2011 11:42:29 +0000 (11:42 +0000)]
2011-07-28  Rob Buis  <rbuis@rim.com>

        REGRESSION (r91125): Google Drawings is broken
        https://bugs.webkit.org/show_bug.cgi?id=65257

        Reviewed by Darin Adler.

        Only consider zero-length path rendering code path when a stroke is defined.

        Test: svg/custom/zero-path-square-cap-rendering2.svg

        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::shouldStrokeZeroLengthSubpath):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Cairo] Switch from ContextShadow to ShadowBlur
mrobinson@webkit.org [Thu, 28 Jul 2011 08:13:23 +0000 (08:13 +0000)]
[Cairo] Switch from ContextShadow to ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=64744

Source/WebCore:

Use ShadowBlur in the Cairo backend instead of ContextShadow. This allows us
to share shadowing code with Qt and Mac ports and to correct some broken
shadow rendering.

Reviewed by Dirk Schulze.

* CMakeLists.txt: Remove ContextShadow from the build.
* CMakeListsEfl.txt: Ditto.
* GNUmakefile.list.am: Add ShadowBlur source files and remove ContextShadow
source files.
* platform/graphics/GraphicsContext.cpp:Add #ifdefs to support ShadowBlur for Cairo.
* platform/graphics/GraphicsContext.h: Remove Cairo ContextShadow code.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::drawInsetShadowWithTiling): Since the ShadowBlur is a property
of the GraphicsContext, we cannot clear the GraphicsContext shadow until we have
finished using properties like m_offset. If we clear the GrahpicsContext shadow
before using these properties, they will be zero when we try to use them.
(WebCore::ShadowBlur::drawRectShadowWithTiling):Ditto.
(WebCore::ShadowBlur::drawLayerPieces): Ditto.
(WebCore::ShadowBlur::beginShadowLayer):Cairo is the first port to keep ShadowBlur
as a persistent property of GraphicsContext and use drawRectShadow and drawInsetShadow.
Thus, we must manually clear the cached tiling values so that ShadowBlur does not
try to reuse the scratch buffer for rectangular shadows after using beginShadowLayer
and endShadowLayer.
(WebCore::ShadowBlur::mustUseShadowBlur): Moved this method from the Qt port to
this cross-platform location.
* platform/graphics/ShadowBlur.h: Added new method declaration.
* platform/graphics/cairo/ContextShadowCairo.cpp: Removed.
* platform/graphics/cairo/FontCairo.cpp: Switched to using ShadowBlur.
(WebCore::drawGlyphsShadow):Ditto.
* platform/graphics/cairo/GraphicsContextCairo.cpp: Switch to using ShadowBlur.
(WebCore::drawPathShadow): ShadowBlur has slightly different semantics than
ContextShadow. When filling the shadow layer, we do not need to use the fill
alpha. We also need to restore the Cairo path to the target context after
endShadowLayer as it destroys the current path.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Switch to using ShadowBlur.
* platform/graphics/cairo/ImageCairo.cpp: Ditto.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):Ditto.
(WebCore::PlatformContextCairo::prepareForStroking): Add a mode ignoring alpha.
* platform/graphics/cairo/PlatformContextCairo.h: Ditto.
(WebCore::PlatformContextCairo::shadowBlur):Added.
* platform/graphics/gtk/FontGtk.cpp: Update to use ShadowBlur.
* platform/graphics/qt/GraphicsContextQt.cpp: Switch to using the new version of mustUseShadowBlur.

LayoutTests:

Update test results, which are now correct after switch to ShadowBlur.

Reviewed by Dirk Schulze.

* fast/box-shadow/box-shadow-radius-expected.png: Added.
* fast/box-shadow/box-shadow-transformed-expected.png: Added.
* fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
* fast/box-shadow/inset-shadow-large-offset-expected.png:
* fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
* fast/box-shadow/scaled-box-shadow-expected.png: Added.
* fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
* fast/box-shadow/spread-multiple-inset-expected.png: Added.
* fast/box-shadow/spread-multiple-normal-expected.png: Added.
* platform/gtk/Skipped: Skip a test, which now has a bug revealed.
* platform/gtk/fast/box-shadow/basic-shadows-expected.png:
* platform/gtk/fast/box-shadow/border-radius-big-expected.png:
* platform/gtk/fast/box-shadow/inset-box-shadows-expected.png:
* platform/gtk/fast/box-shadow/inset-expected.png:
* platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/gtk/fast/box-shadow/spread-expected.png:
* platform/gtk/fast/box-shadow/transform-fringing-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
tkent@chromium.org [Thu, 28 Jul 2011 07:38:23 +0000 (07:38 +0000)]
Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace().
https://bugs.webkit.org/show_bug.cgi?id=65300

Reviewed by Darin Adler.

r91837 had performance regression of StringImpl::stripWhiteSpace()
and simplifyWhiteSpace(). This changes the code so that compilers
generates code equivalent to r91836 or piror.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripMatchedCharacters):
A template member function for stripWhiteSpace(). This function takes a functor.
(WTF::UCharPredicate):
A functor for generic predicate for single UChar argument.
(WTF::SpaceOrNewlinePredicate):
A special functor for isSpaceOrNewline().
(WTF::StringImpl::stripWhiteSpace):
Use stripmatchedCharacters().
(WTF::StringImpl::simplifyMatchedCharactersToSpace):
A template member function for simplifyWhiteSpace().
(WTF::StringImpl::simplifyWhiteSpace):
Use simplifyMatchedCharactersToSpace().
* wtf/text/StringImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium Windows test expectations after r91897.
rniwa@webkit.org [Thu, 28 Jul 2011 06:46:33 +0000 (06:46 +0000)]
Fix Chromium Windows test expectations after r91897.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyle bot complains about EFL-specific forward declaration naming.
ryuan.choi@samsung.com [Thu, 28 Jul 2011 06:19:42 +0000 (06:19 +0000)]
Style bot complains about EFL-specific forward declaration naming.
https://bugs.webkit.org/show_bug.cgi?id=64680

Exclude EFL-specific forward declarations from indentifiers with underscores checks.

Reviewed by Adam Barth.

* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add dummy NotificationPresenterClientEfl
gyuyoung.kim@samsung.com [Thu, 28 Jul 2011 06:05:03 +0000 (06:05 +0000)]
[EFL] Add dummy NotificationPresenterClientEfl
https://bugs.webkit.org/show_bug.cgi?id=64064

Source/WebCore:

Add two files to CMakeLists.txt for HTML5 Notification.

Reviewed by Antonio Gomes.

* CMakeLists.txt:

Source/WebKit/efl:

Add dummy files for HTML5 Notification. And also, notificationPresenter() is added to
ChromeClientEfl. Without this function implemented, there would be a build break when
ENABLE_NOTIFICATION is enabled.

Reviewed by Antonio Gomes.

* CMakeListsEfl.txt:
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::notificationPresenter):
* WebCoreSupport/ChromeClientEfl.h:
* WebCoreSupport/NotificationPresenterClientEfl.cpp: Added.
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::show):
(WebCore::NotificationPresenterClientEfl::cancel):
(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
* WebCoreSupport/NotificationPresenterClientEfl.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline extra test for bug 61369 (skia drawConvexPolygon antialiasing)
commit-queue@webkit.org [Thu, 28 Jul 2011 05:59:13 +0000 (05:59 +0000)]
Rebaseline extra test for bug 61369 (skia drawConvexPolygon antialiasing)
https://bugs.webkit.org/show_bug.cgi?id=65299

Patch by Ben Wells <benwells@chromium.org> on 2011-07-27
Reviewed by James Robinson.

* platform/chromium-linux/fast/layers/opacity-transforms-expected.png:
* platform/chromium-win/fast/layers/opacity-transforms-expected.png: Added.
* platform/chromium-win/fast/layers/opacity-transforms-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCalling window.find immediately after mutating the document crashes WebKit.
rniwa@webkit.org [Thu, 28 Jul 2011 05:24:41 +0000 (05:24 +0000)]
Calling window.find immediately after mutating the document crashes WebKit.
https://bugs.webkit.org/show_bug.cgi?id=65296

Reviewed by Darin Adler.

Source/WebCore:

Don't forget to layout first.

Test: editing/text-iterator/find-after-mutation.html

* editing/TextIterator.cpp:
(WebCore::findPlainText):

LayoutTests:

Added a test to ensure WebKit doesn't crash when searching for string after mutating the document.

* editing/text-iterator/find-after-mutation-expected.txt: Added.
* editing/text-iterator/find-after-mutation.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove skia special case for outline rendering code
commit-queue@webkit.org [Thu, 28 Jul 2011 05:22:51 +0000 (05:22 +0000)]
Remove skia special case for outline rendering code
https://bugs.webkit.org/show_bug.cgi?id=65295

Patch by Ben Wells <benwells@chromium.org> on 2011-07-27
Reviewed by James Robinson.

Source/WebCore:

The fix for bug 58999 (outlines with alpha channels showed artifacts in the corners) was
excluded from skia builds until bug 61369 (skia drawConvexPoly didn't pay attention to
shouldAntialias) was fixed. That bug is fixed so now the #if's can be removed.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintOutline):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Turn on WTF_MULTIPLE_THREADS.
dslomov@google.com [Thu, 28 Jul 2011 05:16:23 +0000 (05:16 +0000)]
[chromium] Turn on WTF_MULTIPLE_THREADS.
https://bugs.webkit.org/show_bug.cgi?id=61017
The patch turns on WTF_MULTIPLE_THREADS in chromium and
pushes some relevant initializations from JSC::initializeThreading
to WTF::initializeThreading.

Reviewed by David Levin.

* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/FastMalloc.cpp:
(WTF::isForbidden):
(WTF::fastMallocForbid):
(WTF::fastMallocAllow):
* wtf/Platform.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading):
* wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrypto.idl doesn't need legacy optional arguments
abarth@webkit.org [Thu, 28 Jul 2011 05:11:46 +0000 (05:11 +0000)]
Crypto.idl doesn't need legacy optional arguments
https://bugs.webkit.org/show_bug.cgi?id=65298

Reviewed by Darin Adler.

This API is relatively new and useless to call without its only argument.

* page/Crypto.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove operator new from JSCell
commit-queue@webkit.org [Thu, 28 Jul 2011 04:59:12 +0000 (04:59 +0000)]
Remove operator new from JSCell
https://bugs.webkit.org/show_bug.cgi?id=64999

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-27
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link.  Also removed any remaining uses of operator new.

* API/JSContextRef.cpp:
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::create):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::createExceptionScope):
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::create):
(JSC::JSStaticScopeObject::JSStaticScopeObject):
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):

Source/JavaScriptGlue:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link.  Also removed any remaining uses of operator new.

* JSRun.cpp:
(JSRun::JSRun):
* JSRun.h:
(JSGlueGlobalObject::create):
* JSUtils.cpp:
(JSObjectKJSValue):
(getThreadGlobalObject):
* UserObjectImp.h:
(UserObjectImp::create):

Source/WebCore:

No new tests.

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link.  Also removed any remaining uses of operator new.

* bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::create):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::newRuntimeObject):
(JSC::Bindings::CRuntimeMethod::create):
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CInstance::getMethod):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::newRuntimeObject):
(JavaRuntimeMethod::create):
(JavaRuntimeMethod::JavaRuntimeMethod):
(JavaInstance::getMethod):
* bridge/jni/jsc/JavaRuntimeObject.h:
(JSC::Bindings::JavaRuntimeObject::create):
* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
* bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::fallbackObject):
* bridge/objc/objc_instance.mm:
(ObjcInstance::newRuntimeObject):
(ObjCRuntimeMethod::create):
(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjcInstance::getMethod):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::create):

Source/WebKit/mac:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link.  Also removed any remaining uses of operator new.

* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::newRuntimeObject):
(WebKit::ProxyRuntimeMethod::create):
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyInstance::getMethod):
* Plugins/Hosted/ProxyRuntimeObject.h:
(WebKit::ProxyRuntimeObject::create):
* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame scopeChain]):

Source/WebKit2:

Removed the implementation of operator new in JSCell, so any further uses
will not successfully link.  Also removed any remaining uses of operator new.

* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::create):
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::methodGetter):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(WebKit::JSNPObject::create):
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Network panel sidebar should have width saved in preferences when...
vsevik@chromium.org [Thu, 28 Jul 2011 04:57:15 +0000 (04:57 +0000)]
Web Inspector: Network panel sidebar should have width saved in preferences when resource is selected.
https://bugs.webkit.org/show_bug.cgi?id=65256

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._toggleViewingResourceMode):
(WebInspector.NetworkPanel.prototype.restoreSidebarWidth):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.preferredSidebarWidth):
(WebInspector.Panel.prototype.get restoreSidebarWidth):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
vsevik@chromium.org [Thu, 28 Jul 2011 04:34:10 +0000 (04:34 +0000)]
Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::open):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Remove unused m_isWeak member of V8AbstractEventListener
adamk@chromium.org [Thu, 28 Jul 2011 04:32:39 +0000 (04:32 +0000)]
[V8] Remove unused m_isWeak member of V8AbstractEventListener
https://bugs.webkit.org/show_bug.cgi?id=65273

Reviewed by Adam Barth.

m_isWeak is set to true in the constructor and never changed,
so the one if statement that tests it always executes; the
code has been updated to make this clear.

No behavior change, thus no tests.

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):
* bindings/v8/V8AbstractEventListener.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse wacky !svn/bc URLs consistently in Leaks Viewer
aroben@apple.com [Thu, 28 Jul 2011 04:23:06 +0000 (04:23 +0000)]
Use wacky !svn/bc URLs consistently in Leaks Viewer

This ensures that any resources loaded via relative URLs will still get pulled from the same
revision of Subversion.

Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
!svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
from Subversion.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
commit-queue@webkit.org [Thu, 28 Jul 2011 04:08:40 +0000 (04:08 +0000)]
[EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
https://bugs.webkit.org/show_bug.cgi?id=65269

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-07-27
Reviewed by Kent Tamura.

WorkQueueItemEfl.h was being included by efl's
LayoutTestControllerEfl.cpp, however the top-level
LayoutTestController still included WorkQueueItem.h, causing a lot of
type mismatches when running the WorkQueueItem code.

We can stick to the original WorkQueueItem header by making a few
changes to EFL's LayoutTestController.

This should make tests such as
fast/loader/non-deferred-substitute-load.html stop crashing.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::queueLoad):
* DumpRenderTree/efl/WorkQueueItemEfl.cpp:
(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):
* DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[skia] fix clipping of some glyphs on windows
reed@google.com [Thu, 28 Jul 2011 03:56:00 +0000 (03:56 +0000)]
[skia] fix clipping of some glyphs on windows
https://bugs.webkit.org/show_bug.cgi?id=65262

Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Popups on Chromium now check the minimum row height set through the...
fsamuel@chromium.org [Thu, 28 Jul 2011 03:55:58 +0000 (03:55 +0000)]
Source/WebCore: Popups on Chromium now check the minimum row height set through the Chromium WebKit API when
computing the height of a row in a popup listbox.
https://bugs.webkit.org/show_bug.cgi?id=64897

Reviewed by Darin Fisher.

No new tests.

* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::getRowHeight):
* platform/chromium/PopupMenuChromium.h:
(WebCore::PopupMenuChromium::minimumRowHeight):
(WebCore::PopupMenuChromium::setMinimumRowHeight):

Source/WebKit/chromium: Added a Chromium WebKit API method to set the minimum row height of a popup listbox.
https://bugs.webkit.org/show_bug.cgi?id=64897

Reviewed by Darin Fisher.

* public/WebPopupMenu.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenu::setMinimumRowHeight):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Inconsistent state of TreeScope reference.
morrita@google.com [Thu, 28 Jul 2011 03:44:57 +0000 (03:44 +0000)]
Source/WebCore: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

The tree scope pointers on shadow tree nodes didn't cleared.
even when the tree scope (shadow root) is destroyed.
This change clear these poitners before detaching the shadow root.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/tree-scope-crash.html

* dom/Element.cpp:
(WebCore::Element::removeShadowRoot):

LayoutTests: Inconsistent state of TreeScope reference.
https://bugs.webkit.org/show_bug.cgi?id=65235

Reviewed by Dimitri Glazkov.

* fast/dom/shadow/tree-scope-crash-expected.txt: Added.
* fast/dom/shadow/tree-scope-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG graph has no notion of double prediction.
commit-queue@webkit.org [Thu, 28 Jul 2011 03:25:19 +0000 (03:25 +0000)]
DFG graph has no notion of double prediction.
https://bugs.webkit.org/show_bug.cgi?id=65234

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-27
Reviewed by Gavin Barraclough.

Added the notion of PredictDouble, and PredictNumber, which is the least
upper bound of PredictInt32 and PredictDouble.  Least upper bound is
defined as the bitwise-or of two predictions.  Bottom is defined as 0,
and Top is defined as all bits being set.  Added the ability to explicitly
distinguish between a node having had a prediction associated with it,
and that prediction still being valid (i.e. no conflicting predictions
have also been added).  Used this to guard the speculative JIT from
speculating Int32 in cases where the graph knows that the value is
double, which currently only happens for GetLocal nodes on arguments
which were double at compile-time.

* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement sizes attribute for link tag from HTML5
commit-queue@webkit.org [Thu, 28 Jul 2011 03:00:54 +0000 (03:00 +0000)]
Implement sizes attribute for link tag from HTML5
https://bugs.webkit.org/show_bug.cgi?id=37674

Patch by Rachel Blum <groby@chromium.org> on 2011-07-27
Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/dom/icon-size-property.html

* WebCore.gypi:
* WebCore.pro:
* bindings/js/JSHTMLLinkElementCustom.cpp:
(WebCore::JSHTMLLinkElement::sizes):
(WebCore::JSHTMLLinkElement::setSizes):
* bindings/v8/custom/V8HTMLLinkElementCustom.cpp: Added.
(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
(WebCore::V8HTMLLinkElement::sizesAccessorSetter):
* html/HTMLAttributeNames.in:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::sizes):
(WebCore::HTMLLinkElement::setSizes):
* html/HTMLLinkElement.h:
* html/HTMLLinkElement.idl:

LayoutTests:

* fast/dom/icon-size-property-expected.txt: Added.
* fast/dom/icon-size-property.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more text input types for chromium
commit-queue@webkit.org [Thu, 28 Jul 2011 02:57:21 +0000 (02:57 +0000)]
Add more text input types for chromium
https://bugs.webkit.org/show_bug.cgi?id=64937

Patch by Peng Huang <penghuang@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

* public/WebTextInputType.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium test expectations for http://crbug.com/88911
rniwa@webkit.org [Thu, 28 Jul 2011 02:31:39 +0000 (02:31 +0000)]
Fix Chromium test expectations for crbug.com/88911

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd sfntly library to the Chromium DEPS file.
rniwa@webkit.org [Thu, 28 Jul 2011 01:45:17 +0000 (01:45 +0000)]
Add sfntly library to the Chromium DEPS file.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Thu, 28 Jul 2011 01:24:43 +0000 (01:24 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaseline after r91879.
rniwa@webkit.org [Thu, 28 Jul 2011 01:02:06 +0000 (01:02 +0000)]
Chromium rebaseline after r91879.

* platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
* platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
* platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect arguments passed to LOG statement
psolanki@apple.com [Thu, 28 Jul 2011 00:13:12 +0000 (00:13 +0000)]
Incorrect arguments passed to LOG statement
https://bugs.webkit.org/show_bug.cgi?id=65293

Reviewed by Oliver Hunt.

* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-add unit tests I accidentally zapped in r91878.
dglazkov@chromium.org [Wed, 27 Jul 2011 23:52:44 +0000 (23:52 +0000)]
Re-add unit tests I accidentally zapped in r91878.

* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=65294
barraclough@apple.com [Wed, 27 Jul 2011 23:48:56 +0000 (23:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=65294
DFG JIT - may speculate based on wrong arguments.

Reviewed by Oliver Hunt

In the case of a DFG compiled function calling to and compiling a second function that
also compiles through the DFG JIT (i.e. compilation triggered with DFGOperations.cpp),
we call compileFor passing the caller functions exec state, rather than the callee's.
This may lead to mis-optimization, since the DFG compiler will example the exec state's
arguments on the assumption that these will be passed to the callee - it is wanting the
callee exec state, not the caller's exec state.

Fixing this for all cases of compilation is tricksy, due to the way the numeric sort
function is compiled, & the structure of the calls in the Interpreter::execute methods.
Only fix for compilation from the JIT, in other calls don't speculate based on arguments
for now.

* dfg/DFGOperations.cpp:
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
(JSC::tryDFGCompileFunction):
(JSC::FunctionExecutable::compileForCallInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileFor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Marking leviw's new unicode-bidi-plaintext test as failing
enne@google.com [Wed, 27 Jul 2011 23:40:36 +0000 (23:40 +0000)]
[chromium] Marking leviw's new unicode-bidi-plaintext test as failing

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark another flaky crasher.
enne@google.com [Wed, 27 Jul 2011 23:28:06 +0000 (23:28 +0000)]
[chromium] Mark another flaky crasher.
https://bugs.webkit.org/show_bug.cgi?id=65155

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch transform operations to FloatSize
leviw@chromium.org [Wed, 27 Jul 2011 23:18:34 +0000 (23:18 +0000)]
Switch transform operations to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=64301

Reviewed by Simon Fraser.

Changing TransformOperation and its progeny to operate on FloatSizes instead of IntSizes.

* platform/graphics/transforms/IdentityTransformOperation.h:
(WebCore::IdentityTransformOperation::apply):
* platform/graphics/transforms/Matrix3DTransformOperation.cpp:
(WebCore::Matrix3DTransformOperation::blend):
* platform/graphics/transforms/Matrix3DTransformOperation.h:
(WebCore::Matrix3DTransformOperation::apply):
* platform/graphics/transforms/MatrixTransformOperation.cpp:
(WebCore::MatrixTransformOperation::blend):
* platform/graphics/transforms/MatrixTransformOperation.h:
(WebCore::MatrixTransformOperation::apply):
* platform/graphics/transforms/PerspectiveTransformOperation.h:
(WebCore::PerspectiveTransformOperation::apply):
* platform/graphics/transforms/RotateTransformOperation.h:
(WebCore::RotateTransformOperation::apply):
* platform/graphics/transforms/ScaleTransformOperation.h:
(WebCore::ScaleTransformOperation::apply):
* platform/graphics/transforms/SkewTransformOperation.h:
(WebCore::SkewTransformOperation::apply):
* platform/graphics/transforms/TransformOperation.h:
* platform/graphics/transforms/TransformOperations.h:
(WebCore::TransformOperations::apply):
* platform/graphics/transforms/TranslateTransformOperation.h:
(WebCore::TranslateTransformOperation::x):
(WebCore::TranslateTransformOperation::y):
(WebCore::TranslateTransformOperation::z):
(WebCore::TranslateTransformOperation::apply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agounicode-bidi:-webkit-plaintext does not work on <textarea>
leviw@chromium.org [Wed, 27 Jul 2011 23:16:25 +0000 (23:16 +0000)]
unicode-bidi:-webkit-plaintext does not work on <textarea>
https://bugs.webkit.org/show_bug.cgi?id=65074

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixing unicode-bidi style propagation into text control shadow trees.

Test: fast/text/international/unicode-bidi-plaintext-in-textarea.html

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::adjustInnerTextStyle):

LayoutTests:

Fixing unicode-bidi propagation into text controls.

* fast/text/international/unicode-bidi-plaintext-in-textarea.html: Added.
* platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
* platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace SpecificityCalculator with TestConfiguration-driven logic.
dglazkov@chromium.org [Wed, 27 Jul 2011 23:11:01 +0000 (23:11 +0000)]
Replace SpecificityCalculator with TestConfiguration-driven logic.
https://bugs.webkit.org/show_bug.cgi?id=65206

Use our newly-acquired ability to expand modifiers into a set of
matching TestConfiguration instances to calculate specificity and
determine whether expectation applies to a given test configuration.

Also, store bug modifier on TestExpectationsLine.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
    test configuration matching, removed a bunch of code.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow ports to specify their own test expectation specifier macros.
dglazkov@chromium.org [Wed, 27 Jul 2011 22:42:34 +0000 (22:42 +0000)]
Allow ports to specify their own test expectation specifier macros.
https://bugs.webkit.org/show_bug.cgi?id=65291

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
* Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
* Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
* Scripts/webkitpy/layout_tests/port/test.py: Added test macros.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for Symbian after r91800
mahesh.kulkarni@nokia.com [Wed, 27 Jul 2011 22:35:47 +0000 (22:35 +0000)]
Build fix for Symbian after r91800

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark another webgl flaky test.
enne@google.com [Wed, 27 Jul 2011 22:33:46 +0000 (22:33 +0000)]
[chromium] Mark another webgl flaky test.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow TestConfigurationConverter report conversion errors.
dglazkov@chromium.org [Wed, 27 Jul 2011 22:16:41 +0000 (22:16 +0000)]
Allow TestConfigurationConverter report conversion errors.
https://bugs.webkit.org/show_bug.cgi?id=65287

Also, fix a few miscellaneous testing issues.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
    was created. 'default' is not a valid build type.
* Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline absolute-child-with-percent-etc-etc-etc.
enne@google.com [Wed, 27 Jul 2011 22:10:01 +0000 (22:10 +0000)]
[chromium] Rebaseline absolute-child-with-percent-etc-etc-etc.

Unreviewed gardening.

* platform/chromium-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
* platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
* platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-27 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 27 Jul 2011 22:01:02 +0000 (22:01 +0000)]
2011-07-27  Eric Carlson  <eric.carlson@apple.com>

        Load delegate not consulted before loading some poster images
        https://bugs.webkit.org/show_bug.cgi?id=65270

        Reviewed by Darin Adler.

        Test: media/video-poster-blocked-by-willsendrequest.html

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::setDisplayMode): Don't ask media engine to set poster if
            willLoadMediaElementURL returns false.

2011-07-27  Eric Carlson  <eric.carlson@apple.com>

        Load delegate not consulted before loading some poster images
        https://bugs.webkit.org/show_bug.cgi?id=65270

        Reviewed by Darin Adler.

        * media/video-poster-blocked-by-willsendrequest-expected.txt: Added.
        * media/video-poster-blocked-by-willsendrequest.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle callback oriented JSONP
oliver@apple.com [Wed, 27 Jul 2011 21:55:40 +0000 (21:55 +0000)]
Handle callback oriented JSONP
https://bugs.webkit.org/show_bug.cgi?id=65271

Reviewed by Gavin Barraclough.

Handle the callback oriented versions of JSONP.  The Literal parser
now handles <Identifier> (. <Identifier>)* (jsonData).

* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::Lexer::lex):
* runtime/LiteralParser.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for printing with accelerated <canvas>
senorblanco@chromium.org [Wed, 27 Jul 2011 21:50:57 +0000 (21:50 +0000)]
Fix for printing with accelerated <canvas>
https://bugs.webkit.org/show_bug.cgi?id=62406

Reviewed by James Robinson.

The platform-independent side of this should be covered by existing
tests.  Printing itself in Chrome has few tests, sadly.  :(

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::draw):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert http://trac.webkit.org/changeset/90415.
slewis@apple.com [Wed, 27 Jul 2011 21:44:49 +0000 (21:44 +0000)]
Revert http://trac.webkit.org/changeset/90415.
Caused a 5% sunspider regression in-browser.

Unreviewed rollout.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
* heap/MarkStack.h:
(JSC::MarkStack::MarkStack):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::releaseExecutableMemory):
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::invalidateCode):
* runtime/RegExp.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach all ports about their test configurations.
dglazkov@chromium.org [Wed, 27 Jul 2011 21:06:56 +0000 (21:06 +0000)]
Teach all ports about their test configurations.
https://bugs.webkit.org/show_bug.cgi?id=65278

Each Port object should return a valid set of all TestConfiguration instances,
available for this port.

Reviewed by Philippe Normand.

* Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
    since it is different for each port.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
    all test configurations as a param.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
* Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
* Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
* Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
* Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
* Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
* Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
* Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaselines for r89627 and r91497.
rniwa@webkit.org [Wed, 27 Jul 2011 19:44:03 +0000 (19:44 +0000)]
Chromium rebaselines for r89627 and r91497.

* platform/chromium-linux/editing/selection/extend-inside-transforms-backward-expected.png: Added.
* platform/chromium-linux/editing/selection/extend-inside-transforms-forward-expected.png: Added.
* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png:
* platform/chromium-linux/fast/multicol/single-line-expected.png:
* platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/single-line-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-margin-collapsing-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
* platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/single-line-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
* platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
* platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.png: Added.
* platform/chromium-win/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
* platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.png: Added.
* platform/chromium-win/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.png:
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt:
* platform/chromium-win/fast/multicol/single-line-expected.png:
* platform/chromium-win/fast/multicol/single-line-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/chromium-win/fast/multicol/span/span-margin-collapsing-expected.txt:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoediting/selection/move-by-word-visually* tests timing out
xji@chromium.org [Wed, 27 Jul 2011 19:26:08 +0000 (19:26 +0000)]
editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Split the 2 tests into 4 tests. But need to find a way to improve
performance eventually.

* editing/selection/move-by-word-visually-multi-line-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
* editing/selection/move-by-word-visually-multi-line.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
* editing/selection/move-by-word-visually-multi-space-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-others-expected.txt.
* editing/selection/move-by-word-visually-multi-space.html: Copied from LayoutTests/editing/selection/move-by-word-visually-others.html.
* editing/selection/move-by-word-visually-others-expected.txt: Removed.
* editing/selection/move-by-word-visually-others.html: Removed.
* editing/selection/move-by-word-visually-single-space-inline-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
* editing/selection/move-by-word-visually-single-space-inline-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
* editing/selection/move-by-word-visually-single-space-one-element-expected.txt: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt.
* editing/selection/move-by-word-visually-single-space-one-element.html: Copied from LayoutTests/editing/selection/move-by-word-visually-single-space-sigle-line.html.
* editing/selection/move-by-word-visually-single-space-sigle-line-expected.txt: Removed.
* editing/selection/move-by-word-visually-single-space-sigle-line.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][Qt] Move from QGraphicsView to Qt Scene Graph
benjamin.poulain@nokia.com [Wed, 27 Jul 2011 19:21:45 +0000 (19:21 +0000)]
[WK2][Qt] Move from QGraphicsView to Qt Scene Graph
https://bugs.webkit.org/show_bug.cgi?id=62969

Reviewed by Andreas Kling.

Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>

Source/WebKit/qt:

Add the declarative dependency to link WebKit.

* QtWebKit.pro:

Source/WebKit2:

This patch change the base of WebKit2 from QGraphicsWidget
to scenegraph based items.

QTouchWebView becomes a QSGItem with the only role of clipping
child items.
QTouchWebPage becomes a QSGPaintedItem in order to render the content
of the flattened page. This is a temporary work around to get
something running without deep changes on the drawing area proxy.

QDesktopWebView become a QSGPaintedItem and behave as before
regarding rendering. The drawing area proxy is used to render
the full item.

The event delivery had to be adapted because the scenegraph does not
follow regular delivery of QEvents. Instead, each event type is
delivered directly to a specific virtual function.
In this patch, the events are forwarded to the classic QObject::event().

For the features that cannot be implemented on scenegraph (tooltip, menus, etc),
a temporary workaround was added: the parent canvas is used as the widget for
providing the feature. This assumes the web views alone in the canvas and
take its full size. This will have to be fixed in the scenegraph for us to
implement those features.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::drawingAreaSize):
(QDesktopWebViewPrivate::isActive):
(QDesktopWebViewPrivate::startDrag):
(QDesktopWebViewPrivate::didChangeToolTip):
(QDesktopWebViewPrivate::didChangeCursor):
(QDesktopWebViewPrivate::showContextMenu):
(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::init):
(paintCrashedPage):
(QDesktopWebView::keyPressEvent):
(QDesktopWebView::keyReleaseEvent):
(QDesktopWebView::inputMethodEvent):
(QDesktopWebView::focusInEvent):
(QDesktopWebView::focusOutEvent):
(QDesktopWebView::mousePressEvent):
(QDesktopWebView::mouseMoveEvent):
(QDesktopWebView::mouseReleaseEvent):
(QDesktopWebView::mouseDoubleClickEvent):
(QDesktopWebView::wheelEvent):
(QDesktopWebView::touchEvent):
(QDesktopWebView::hoverEnterEvent):
(QDesktopWebView::hoverMoveEvent):
(QDesktopWebView::hoverLeaveEvent):
(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragExitEvent):
(QDesktopWebView::dragDropEvent):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::paint):
(QDesktopWebView::event):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::paint):
(QTouchWebPage::event):
(QTouchWebPage::keyPressEvent):
(QTouchWebPage::keyReleaseEvent):
(QTouchWebPage::inputMethodEvent):
(QTouchWebPage::focusInEvent):
(QTouchWebPage::focusOutEvent):
(QTouchWebPage::touchEvent):
(QTouchWebPage::geometryChanged):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::scroll):
(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/testwindow.h:
(TestWindow::TestWindow):
(TestWindow::resizeEvent):
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::panGestureRequestScroll):
(WebKit::TouchViewInterface::pinchGestureRequestUpdate):
(WebKit::TouchViewInterface::drawingAreaSize):
(WebKit::TouchViewInterface::contentSizeChanged):
(WebKit::TouchViewInterface::isActive):
* UIProcess/qt/ViewInterface.cpp: Removed.
* UIProcess/qt/ViewInterface.h:
* WebKit2.pro:

Tools:

With the scene graph, the interface to have a window on screen is
QSGCanvas. QGraphicsView is not used, and openGL is an enforced
dependency.

Both the BrowserView and the WebKitTest runner are changed from
QGraphicsView to QSGCanvas.

* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::view):
* MiniBrowser/qt/BrowserView.h:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::urlChanged):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/main.cpp:
(main):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WebView::WebView):
(WTR::PlatformWebView::PlatformWebView):
* WebKitTestRunner/qt/WebKitTestRunner.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWrong image height in absolutely positioned div in relatively positioned parent with...
rniwa@webkit.org [Wed, 27 Jul 2011 18:54:54 +0000 (18:54 +0000)]
Wrong image height in absolutely positioned div in relatively positioned parent with bottom padding
https://bugs.webkit.org/show_bug.cgi?id=64046

Reviewed by David Hyatt.

Add pixel test results.

* platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac pixel rebaselines after r91497.
rniwa@webkit.org [Wed, 27 Jul 2011 18:39:36 +0000 (18:39 +0000)]
Mac pixel rebaselines after r91497.

* platform/mac/fast/multicol/float-multicol-expected.png:
* platform/mac/fast/multicol/scrolling-overflow-expected.png:
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/mac/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
mihaip@chromium.org [Wed, 27 Jul 2011 18:34:07 +0000 (18:34 +0000)]
[Chromium] Add better WebKit API for chrome.tabs.insertCSS extension API
https://bugs.webkit.org/show_bug.cgi?id=65158

Reviewed by David Hyatt.

Source/WebCore:

Add per-Document instance user stylesheets (as opposed to the page
group user styles and the global page stylesheet).

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/CSSStyleSelector.h:
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createStyleSelector):
(WebCore::Document::addUserSheet):
* dom/Document.h:

Source/WebKit/chromium:

Add WebDocument::insertUserStyleSheet which inserts a user stylesheet,
instead of forcing extensions to use insertStyleText which manipulates
the DOM of the page and results in compatibility issues (see
http://crbug.com/82220).

* public/WebDocument.h:
* src/WebDocument.cpp:
(WebKit::WebDocument::insertUserStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark data-view-test.html as flaky in non-debug configs too.
enne@google.com [Wed, 27 Jul 2011 18:32:45 +0000 (18:32 +0000)]
[chromium] Mark data-view-test.html as flaky in non-debug configs too.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Disable cache option should only clear memory cache, not disable it.
vsevik@chromium.org [Wed, 27 Jul 2011 18:30:18 +0000 (18:30 +0000)]
Web Inspector: Disable cache option should only clear memory cache, not disable it.
https://bugs.webkit.org/show_bug.cgi?id=65184

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/InspectorClient.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
* src/InspectorClientImpl.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:

LayoutTests:

* http/tests/inspector/network/network-disable-cache-memory-expected.txt:
* http/tests/inspector/network/network-disable-cache-memory.html:
* http/tests/inspector/network/resources/random-script.php: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.
ossy@webkit.org [Wed, 27 Jul 2011 17:45:41 +0000 (17:45 +0000)]
[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

* platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/qt-4.8/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
* platform/qt-wk2/Skipped: Skip failing test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add baselines for struct-dom-11-f.svg.
enne@google.com [Wed, 27 Jul 2011 17:43:06 +0000 (17:43 +0000)]
[chromium] Add baselines for struct-dom-11-f.svg.

Unreviewed gardening.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtWebkit never finishes loading sites when they are loaded after an initial...
caio.oliveira@openbossa.org [Wed, 27 Jul 2011 17:40:57 +0000 (17:40 +0000)]
[Qt] QtWebkit never finishes loading sites when they are loaded after an initial QUrl fails to load.
https://bugs.webkit.org/show_bug.cgi?id=61328

Reviewed by Andreas Kling.

Change the hooks in FrameLoaderClient we use for emitting signals. Instead of
emitting signals in the progress notification functions, we use the
dispatchDid{Start,Finish,Fail}* functions. The main reason behind this change is
that loading code is prepared to handle load() when inside those functions.

The crash was being caused by setUrl() (and load()) being called when
loadFinished(false) was emitted. The problem here is that when
postProgressFinishedNotification the FrameLoader wasn't ready for taking a load()
call again, because it was still the ProvisionalLoadState but with the
provisionalDocumentLoader already removed.

To emulate the same behavior that QtWebKit had when using
postProgressFinishedNotification, we now keep track of the frame originating the
load, and emit the signals when this frame's client is called.

The patch keeps the existing semantics for QWebPage signals, but we now emit the
QWebFrame signals everytime, not only when they are the originating frame for
loading.

* Api/qwebframe.cpp:
(clearCoreFrame): Document our assumption that activeDocumentLoader will exist.

* WebCoreSupport/FrameLoaderClientQt.h: Remove m_loadError, add a boolean to keep
track whether the frame is originating the load. Remove the signals from
FrameLoaderClientQt since we will emit QWebFrame and QWebPage signals directly.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Initialize m_isOriginatingLoad.

(WebCore::FrameLoaderClientQt::setFrame): Do not connect QWebFrame and QWebPage
signals to our signals for load/finished, signal emission will be done manually.

(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): Emit
loadStarted() signal and make the first notification of estimation change, that
Qt API tests expect to exist and notify 10%.

(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): Remove reference to
m_loadError and emit loadFinished() signal.

(WebCore::FrameLoaderClientQt::postProgressStartedNotification): Remove signal
emission and mark the originating load as true, since only the originating frame
gets this call in its client.

(WebCore::FrameLoaderClientQt::postProgressFinishedNotification): Remove signal
emission.

(WebCore::FrameLoaderClientQt::callErrorPageExtension): Return whether the call
was successful or not. This wasn't necessary before because a successful call for
error page would lead to a load(), that cleared the m_loadError.
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): Remove reference
to m_loadError and emit finished signal indicating error if ErrorPage extension
doesn't handle it.
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad): Ditto.

(WebCore::FrameLoaderClientQt::emitLoadStarted): Emit the loadStarted() signal
for the QWebFrame, and if the originating load also do for the QWebPage.

(WebCore::FrameLoaderClientQt::emitLoadFinished): Same as before but for
loadFinished(). Take care to reset the originating load flag before the signals
are emitted, since they might want to set it back again.

* tests/qwebframe/tst_qwebframe.cpp:
(URLSetter::URLSetter): Object that sets the url using either load() or setUrl()
when a certain signal is emitted in the frame.

(URLSetter::execute):
(tst_QWebFrame::loadInSignalHandlers_data):
(tst_QWebFrame::loadInSignalHandlers): New test inspired by the bug test case. This test
crashes without this patch applied.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Mark more tests as being flaky.
enne@google.com [Wed, 27 Jul 2011 17:20:34 +0000 (17:20 +0000)]
[Chromium] Mark more tests as being flaky.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
ossy@webkit.org [Wed, 27 Jul 2011 17:09:29 +0000 (17:09 +0000)]
[Qt] svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg fails
https://bugs.webkit.org/show_bug.cgi?id=65266

[Qt] Unreviewed gardening. Update Qt 4.8 specific expected files.

* platform/qt-4.8/fast/css/font-face-opentype-expected.png: Added.
* platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Added.
* platform/qt-4.8/fast/css/font-family-pictograph-expected.png: Added.
* platform/qt-4.8/fast/css/font-family-pictograph-expected.txt: Added.
* platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
* platform/qt-4.8/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
* platform/qt-4.8/svg/custom/tref-own-content-removal-expected.png: Added.
* platform/qt-4.8/svg/custom/tref-own-content-removal-expected.txt: Added.
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Remove window.XSLTProcessor entries.
* platform/qt/Skipped: Skip a failing test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg.
* platform/qt/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added after r91850.
* platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added after r91850.
* platform/qt/svg/custom/tref-own-content-removal-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 27 Jul 2011 16:20:46 +0000 (16:20 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-wk2/Skipped: Skip failing tests after migration to Qt5.
* platform/qt/test_expectations.txt: Mark fast/js/array-sort-modifying-tostring.html as TIMEOUT PASS flakey test in debug mode.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Unreviewed gardening.
ossy@webkit.org [Wed, 27 Jul 2011 16:06:18 +0000 (16:06 +0000)]
[WK2] Unreviewed gardening.

* platform/qt-wk2/Skipped: Skip new failing tests.
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt: Update after r91300.
* platform/wk2/Skipped: Skip tests because of missing layoutTestController implementation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-27 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 27 Jul 2011 15:58:40 +0000 (15:58 +0000)]
2011-07-27  Rob Buis  <rbuis@rim.com>

        Implement getIntersectionList(), getEnclosureList(), checkIntersection() and checkEnclosure() in SVGSVGElement
        https://bugs.webkit.org/show_bug.cgi?id=11274

        Reviewed by Nikolas Zimmermann.

        Implement checkIntersection/checkEnclosure and use it to implement getIntersectionList and getEnclosureList as well.
        The referenceElement is used to provide a DOM subtree to find matches in. Also we do not allow elements that specify
        pointer-events=none in the list.

        Tests: svg/W3C-SVG-1.1-SE/struct-dom-11-f.svg
               svg/custom/intersection-list-clipping.svg
               svg/custom/intersection-list-nested-svg.svg

        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::getElementCTM):
        (WebCore::intersectsAllowingEmpty):
        (WebCore::isGraphicsElement):
        (WebCore::RenderSVGModelObject::checkIntersection):
        (WebCore::RenderSVGModelObject::checkEnclosure):
        * rendering/svg/RenderSVGModelObject.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::checkIntersection):
        (WebCore::SVGSVGElement::checkEnclosure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTighten up some chromium test expectations to green up the bots.
senorblanco@chromium.org [Wed, 27 Jul 2011 15:56:28 +0000 (15:56 +0000)]
Tighten up some chromium test expectations to green up the bots.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline one Chromium GPU test on Linux after
senorblanco@chromium.org [Wed, 27 Jul 2011 15:45:52 +0000 (15:45 +0000)]
Rebaseline one Chromium GPU test on Linux after
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

* platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPass on the suggested name for download file to the client.
commit-queue@webkit.org [Wed, 27 Jul 2011 15:36:31 +0000 (15:36 +0000)]
Pass on the suggested name for download file to the client.
https://bugs.webkit.org/show_bug.cgi?id=65181

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-27
Reviewed by Darin Fisher.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::startDownload):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew chromium-linux baselines after skia change
senorblanco@chromium.org [Wed, 27 Jul 2011 15:25:36 +0000 (15:25 +0000)]
New chromium-linux baselines after skia change
http://code.google.com/p/skia/source/detail?r=1924.

Unreviewed.

* platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/fast/transforms/transform-on-inline-expected.png:
* platform/chromium-linux/fast/transforms/transform-table-row-expected.png:
* platform/chromium-linux/fast/transforms/transformed-document-element-expected.png:
* platform/chromium-linux/fonts/cursive-expected.txt: Added.
* platform/chromium-linux/fonts/fantasy-expected.txt:
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
* platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPath2-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPath3-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-linux/svg/custom/focus-ring-expected.png:
* platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png:
* platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
* platform/chromium-linux/svg/custom/text-linking-expected.png:
* platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
* platform/chromium-linux/svg/custom/text-rotation-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
* platform/chromium-linux/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
* platform/chromium-linux/svg/custom/use-on-non-svg-namespaced-element-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
* platform/chromium-linux/svg/text/text-path-01-b-expected.png:
* platform/chromium-linux/svg/text/text-path-middle-align-expected.png:
* platform/chromium-linux/svg/text/text-text-07-t-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-linux/svg/zoom/text/zoom-foreignObject-expected.png:
* platform/chromium-linux/transforms/2d/compound-transforms-vs-containers-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build in Qt 5 of QDeclarativeWebView
caio.oliveira@openbossa.org [Wed, 27 Jul 2011 15:20:43 +0000 (15:20 +0000)]
[Qt] Fix build in Qt 5 of QDeclarativeWebView
https://bugs.webkit.org/show_bug.cgi?id=65258

Reviewed by Andreas Kling.

In Qt 5, the QGraphicsView-based classes for QtQuick are in the
qtquick1 module, including QDeclarativeItem and QDeclarativeView.

.:

* Source/WebKit.pro:

Source/WebKit/qt:

* declarative/qdeclarativewebview_p.h:
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
* tests/tests.pri:
* tests/tests.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][V8] Fix the build.
abecsi@webkit.org [Wed, 27 Jul 2011 14:37:26 +0000 (14:37 +0000)]
[Qt][V8] Fix the build.

Unreviewed build fix.

No new tests needed.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Add missing CString.h include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed build fix for mac.
alexis.menard@openbossa.org [Wed, 27 Jul 2011 14:20:07 +0000 (14:20 +0000)]
[Qt] Unreviewed build fix for mac.

QtKit is now our default media player, the define is WTF_USE_QTKIT and it's not part
of the options passed to build-webkit, therefore DerivedSources should now generate the
includes when it's mac.

* DerivedSources.pro:
* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared...
ossy@webkit.org [Wed, 27 Jul 2011 14:12:12 +0000 (14:12 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

* platform/qt/Skipped: Skip a new failing test: svg/custom/image-with-transform-clip-filter.svg

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeculative win build fix after r91835
tonyg@chromium.org [Wed, 27 Jul 2011 13:56:16 +0000 (13:56 +0000)]
Speculative win build fix after r91835
https://bugs.webkit.org/show_bug.cgi?id=65255

Unreviewed build fix.

* src/WebFontImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Clean WKPageLoaderClient
commit-queue@webkit.org [Wed, 27 Jul 2011 13:55:06 +0000 (13:55 +0000)]
[Qt][WK2] Clean WKPageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=65246

Patch by Benjamin Poulain <benjamin@webkit.org> on 2011-07-27
Reviewed by Andreas Kling.

Remove the empty functions from Qt's WKPageLoaderClient.

* UIProcess/qt/ClientImpl.cpp:
(qt_wk_didSameDocumentNavigationForFrame): Move the function to
have all the implementations in the same order as the definitions.
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInspector should support cd(window) in the command line
yurys@chromium.org [Wed, 27 Jul 2011 13:37:03 +0000 (13:37 +0000)]
Inspector should support cd(window) in the command line
https://bugs.webkit.org/show_bug.cgi?id=19872

Source/WebCore:

Added dropdown list with all iframes to allow selecting current evaluation context for console expressions.

Reviewed by Pavel Feldman.

Test: http/tests/inspector/console-cd.html

* WebCore.gypi:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
* inspector/WorkerInspectorController.cpp:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.addContext):
(WebInspector.ConsoleView.prototype.removeContext):
(WebInspector.ConsoleView.prototype._contextUpdated):
(WebInspector.ConsoleView.prototype.get _currentEvaluationContextId):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
* inspector/front-end/ContextManager.js: Added.
(WebInspector.ContextManager):
(WebInspector.ContextManager.prototype._frameAdded):
(WebInspector.ContextManager.prototype._frameNavigated):
(WebInspector.ContextManager.prototype._frameDetached):
(WebInspector.FrameEvaluationContext):
(WebInspector.FrameEvaluationContext.prototype._frameNavigated):
(WebInspector.FrameEvaluationContext.prototype.get id):
(WebInspector.FrameEvaluationContext.prototype.get url):
(WebInspector.FrameEvaluationContext.prototype.get displayName):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

Added a test for console evaluation in an iframe.

Reviewed by Pavel Feldman.

* http/tests/inspector/console-cd-expected.txt: Added.
* http/tests/inspector/console-cd.html: Added.
* http/tests/inspector/resources/console-cd-iframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt (and possibly Gtk) WebKit2 build after addition of -webkit-pictograph
caio.oliveira@openbossa.org [Wed, 27 Jul 2011 13:34:41 +0000 (13:34 +0000)]
Fix Qt (and possibly Gtk) WebKit2 build after addition of -webkit-pictograph
https://bugs.webkit.org/show_bug.cgi?id=65253

Reviewed by Andreas Kling.

The -webkit-pictograph generic family was added by bug 65197.

* Shared/WebPreferencesStore.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
commit-queue@webkit.org [Wed, 27 Jul 2011 13:07:42 +0000 (13:07 +0000)]
Source/JavaScriptCore: Added an interface to take IsWhiteSpaceFunctionPtr.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::stripWhiteSpace):
  Added an interface to take IsWhiteSpaceFunctionPtr.
(WTF::StringImpl::simplifyWhiteSpace): ditto.
* wtf/text/StringImpl.h:
* wtf/text/WTFString.cpp:
(WTF::String::stripWhiteSpace): ditto.
(WTF::String::simplifyWhiteSpace): ditto.
* wtf/text/WTFString.h:

Source/WebCore: Uses isHTMLSpace to normalize white spaces.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

Test: fast/forms/option-strip-unicode-spaces.html

* dom/OptionElement.cpp:
(WebCore::OptionElement::normalizeText):
  Uses isHTMLSpace to trim and replace white spaces.

LayoutTests: Added a test to normalize option.text.
https://bugs.webkit.org/show_bug.cgi?id=57746

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-27
Reviewed by Kent Tamura.

* fast/forms/option-strip-unicode-spaces-expected.txt: Added.
* fast/forms/option-strip-unicode-spaces.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Qt specific expected result for a new test introduced in r91777.
ossy@webkit.org [Wed, 27 Jul 2011 13:01:00 +0000 (13:01 +0000)]
Add Qt specific expected result for a new test introduced in r91777.

* platform/qt/fast/css/font-family-pictograph-expected.png: Added.
* platform/qt/fast/css/font-family-pictograph-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove include of skia/ext/platform_canvas.h
zecke@webkit.org [Wed, 27 Jul 2011 12:38:37 +0000 (12:38 +0000)]
[chromium] Remove include of skia/ext/platform_canvas.h
https://bugs.webkit.org/show_bug.cgi?id=60852

Reviewed by Hajime Morita.

In https://bugs.webkit.org/show_bug.cgi?id=57563 the usage of the
skia::PlatformCanvas was eliminated in favor of directly using
SkCanvas directly. The include of platform_canvas.h was not removed
leaving the dependency on Chromium in the header files. Remove
that dependency now.

* platform/graphics/skia/PlatformContextSkia.h: Remove platform_canvas.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, forgotten GTK pixel test results for
philn@webkit.org [Wed, 27 Jul 2011 11:22:58 +0000 (11:22 +0000)]
    Unreviewed, forgotten GTK pixel test results for
        fast/forms/input-file-re-render.html after r91833.

        * platform/gtk/fast/forms/input-file-re-render-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK pixel tests rebaseline after r91759.
philn@webkit.org [Wed, 27 Jul 2011 10:51:30 +0000 (10:51 +0000)]
    Unreviewed, GTK pixel tests rebaseline after r91759.

        * platform/gtk/fast/forms/box-shadow-override-expected.png:
        * platform/gtk/fast/forms/file-input-direction-expected.png:
        * platform/gtk/fast/forms/file-input-disabled-expected.png:
        * platform/gtk/fast/forms/form-element-geometry-expected.png:
        * platform/gtk/fast/forms/input-appearance-height-expected.png:
        * platform/gtk/fast/forms/input-value-expected.png:
        * platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Simplify the PageUIClient
benjamin.poulain@nokia.com [Wed, 27 Jul 2011 10:24:08 +0000 (10:24 +0000)]
[Qt][WK2] Simplify the PageUIClient
https://bugs.webkit.org/show_bug.cgi?id=65198

Reviewed by Andreas Kling.

The only function of WKPageLoaderClient with a complete implementation
is qt_wk_setStatusText(). The other functions were what is left from
before the refactoring of QWKPage.

This patch removes the unused functions to simplify the client. Since the dependency
on QtWebPageProxy is removed from that client, it now calls the ViewInterface directly.

* UIProcess/qt/ClientImpl.cpp:
(toViewInterface):
(qt_wk_setStatusText):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::init):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r91792.
commit-queue@webkit.org [Wed, 27 Jul 2011 10:03:00 +0000 (10:03 +0000)]
Unreviewed, rolling out r91792.
http://trac.webkit.org/changeset/91792
https://bugs.webkit.org/show_bug.cgi?id=65242

It broke NRWT on Qt and GTK (Requested by Ossy_night on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-27

* Scripts/webkitpy/layout_tests/models/test_configuration.py:
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTra...
mnaganov@chromium.org [Wed, 27 Jul 2011 10:01:51 +0000 (10:01 +0000)]
Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
https://bugs.webkit.org/show_bug.cgi?id=65213

Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoediting/selection/move-by-word-visually* tests timing out
tonyg@chromium.org [Wed, 27 Jul 2011 09:49:49 +0000 (09:49 +0000)]
editing/selection/move-by-word-visually* tests timing out
https://bugs.webkit.org/show_bug.cgi?id=65241

Unreviewed build fix.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91828 268f45cc-cd09-0410-ab3c-d52691b4dbfc