WebKit.git
11 years ago2010-03-20 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 20 Mar 2010 08:12:18 +0000 (08:12 +0000)]
2010-03-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        Fix a bunch of HTML5 validation errors on various pages.
        https://bugs.webkit.org/show_bug.cgi?id=36409

        * building/build.html:
        * building/checkout.html:
        * building/debug.html:
        * building/run.html:
        * building/tools.html:
        * coding/coding-style.html:
        * coding/contributing.html:
        * coding/major-objects.html:
        * css/main.css:
        (.asciiart):
        * demos/index.html:
        * header.inc:
        * projects/compat/index.html:
        * projects/css/index.html:
        * projects/documentation/index.html:
        * projects/goals.html:
        * projects/index.html:
        * projects/mathml/index.html:
        * quality/bugpriorities.html:
        * quality/bugwriting.html:
        * quality/crashlogs.html:
        * quality/lifecycle.html:
        * quality/testing.html:
        * quality/testwriting.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 20 Mar 2010 07:24:31 +0000 (07:24 +0000)]
2010-03-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        webkit.org should use the HTML5 doctype
        https://bugs.webkit.org/show_bug.cgi?id=36407

        * header.inc:
        * misc/drosera/index.html:
        * perf/slickspeed/system/index.php:
        * perf/slickspeed/system/template.php:
        * specs/index.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 20 Mar 2010 06:42:55 +0000 (06:42 +0000)]
2010-03-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        http://webkit.org/ has an HTML5 validation error
        https://bugs.webkit.org/show_bug.cgi?id=36406

        * nav.inc:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sat, 20 Mar 2010 05:29:01 +0000 (05:29 +0000)]
2010-03-19  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
        https://bugs.webkit.org/show_bug.cgi?id=34641

        * fast/css/first-letter-block-form-controls-crash-expected.txt: Added.
        * fast/css/first-letter-block-form-controls-crash.html: Added.
2010-03-19  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
        https://bugs.webkit.org/show_bug.cgi?id=34641

        Don't dig into buttons and menu lists when finding which element
        should be modified by :first-letter pseudo class.  Even before
        this change, we didn't dig into inline buttons and menu lists as
        they are replaced so this issue wasn't found long time.

        Test: fast/css/first-letter-block-form-controls-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand a test result that should have been added along with the test in r56286.
mrowe@apple.com [Sat, 20 Mar 2010 04:29:48 +0000 (04:29 +0000)]
Land a test result that should have been added along with the test in r56286.

* transitions/transition-end-event-destroy-iframe-expected.txt: Copied from LayoutTests/transitions/transition-end-event-destroy-renderer-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 20 Mar 2010 03:55:13 +0000 (03:55 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Change XSSAuditor block syntax
        https://bugs.webkit.org/show_bug.cgi?id=34436

        Update tests to account for the new blocking syntax.  Added test for
        disabling the XSS filter.

        * http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
        * http/tests/security/xssAuditor/malformed-xss-protection-header.html:
        * http/tests/security/xssAuditor/no-protection-script-tag-expected.txt: Added.
        * http/tests/security/xssAuditor/no-protection-script-tag.html: Added.
        * http/tests/security/xssAuditor/resources/echo-head-base-href.pl:
        * http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl:
        * http/tests/security/xssAuditor/resources/echo-intertag.pl:
        * http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt: Added.
        * http/tests/security/xssAuditor/xss-protection-parsing-01.html: Added.
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Change XSSAuditor block syntax
        https://bugs.webkit.org/show_bug.cgi?id=34436

        Update our blocking syntax to something more reasonable.  Also,
        implemented a way for a web site to disable the filter.

        Tests: http/tests/security/xssAuditor/no-protection-script-tag.html
               http/tests/security/xssAuditor/xss-protection-parsing-01.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::xssProtection):
        (WebCore::XSSAuditor::findInRequest):
        * page/XSSAuditor.h:
        * platform/network/HTTPParsers.cpp:
        (WebCore::skipToken):
        (WebCore::parseXSSProtectionHeader):
        * platform/network/HTTPParsers.h:
        (WebCore::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Kenneth Russell <kbr@google.com>
eric@webkit.org [Sat, 20 Mar 2010 03:35:07 +0000 (03:35 +0000)]
2010-03-19  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Add GraphicsContext3D abstraction to WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=36262

        Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
        GraphicsContext3D implementation to use it. All of the OpenGL calls have
        been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
        WebGraphicsContext3D implementation. GraphicsContext3D is still
        responsible for the transfer of rendered output from the
        WebGraphicsContext3D to the HTMLCanvasElement.

        The GraphicsContext3DInternal class, which is a data member of
        GraphicsContext3D for the Chromium port, remains. It is possible to
        eliminate this class and thereby one level of delegation, but this is
        being deferred.

        The needed entry point for a Chrome implementation of
        WebGraphicsContext3D has been added to WebKitClient, but it is not being
        called yet by GraphicsContext3D. It will be once this patch lands and
        Chromium is rolled forward to support this entry point.

        This is a large patch, but the transformation is almost entirely
        mechanical and there is no change in functionality. Nearly all of
        GraphicsContext3D and GraphicsContext3DInternal has been moved to
        WebGraphicsContext3DDefaultImpl. The only area where the splitting of
        logic is less than mechanical is GraphicsContext3D::beginPaint() and its
        callees.

        Ran all WebGL layout tests and demos from Khronos site in Chromium.

        * WebKit.gyp:
        * public/WebGraphicsContext3D.h: Added.
        (WebKit::WebGraphicsContext3D::Attributes::Attributes):
        (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
        * public/WebKitClient.h:
        (WebKit::WebKitClient::createGraphicsContext3D):
        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::initialize):
        (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D):
        (WebCore::GraphicsContext3DInternal::platformTexture):
        (WebCore::GraphicsContext3DInternal::beginPaint):
        (WebCore::GraphicsContext3DInternal::endPaint):
        (WebCore::GraphicsContext3DInternal::reshape):
        (WebCore::GraphicsContext3DInternal::bindAttribLocation):
        (WebCore::GraphicsContext3DInternal::bindTexture):
        (WebCore::GraphicsContext3DInternal::bufferData):
        (WebCore::GraphicsContext3DInternal::bufferSubData):
        (WebCore::GraphicsContext3DInternal::getActiveAttrib):
        (WebCore::GraphicsContext3DInternal::getActiveUniform):
        (WebCore::GraphicsContext3DInternal::getAttribLocation):
        (WebCore::GraphicsContext3DInternal::getContextAttributes):
        (WebCore::GraphicsContext3DInternal::getProgramInfoLog):
        (WebCore::GraphicsContext3DInternal::getShaderInfoLog):
        (WebCore::GraphicsContext3DInternal::getShaderSource):
        (WebCore::GraphicsContext3DInternal::getString):
        (WebCore::GraphicsContext3DInternal::getUniformLocation):
        (WebCore::GraphicsContext3DInternal::readPixels):
        (WebCore::GraphicsContext3DInternal::shaderSource):
        (WebCore::GraphicsContext3DInternal::texImage2D):
        (WebCore::GraphicsContext3DInternal::texSubImage2D):
        (WebCore::GraphicsContext3DInternal::uniform1fv):
        (WebCore::GraphicsContext3DInternal::uniform1iv):
        (WebCore::GraphicsContext3DInternal::uniform2fv):
        (WebCore::GraphicsContext3DInternal::uniform2iv):
        (WebCore::GraphicsContext3DInternal::uniform3fv):
        (WebCore::GraphicsContext3DInternal::uniform3iv):
        (WebCore::GraphicsContext3DInternal::uniform4fv):
        (WebCore::GraphicsContext3DInternal::uniform4iv):
        (WebCore::GraphicsContext3DInternal::uniformMatrix2fv):
        (WebCore::GraphicsContext3DInternal::uniformMatrix3fv):
        (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        (WebCore::GraphicsContext3D::~GraphicsContext3D):
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::platformGraphicsContext3D):
        (WebCore::GraphicsContext3D::platformTexture):
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):
        * src/WebGraphicsContext3D.cpp: Added.
        (WebKit::WebGraphicsContext3D::createDefault):
        * src/WebGraphicsContext3DDefaultImpl.cpp: Added.
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection):
        (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState):
        (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
        (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
        (WebKit::WebGraphicsContext3DDefaultImpl::width):
        (WebKit::WebGraphicsContext3DDefaultImpl::height):
        (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes):
        (WebKit::createTextureObject):
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
        (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically):
        (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture):
        (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray):
        (WebKit::WebGraphicsContext3DDefaultImpl::drawElements):
        (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray):
        (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap):
        (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib):
        (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform):
        (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes):
        (WebKit::WebGraphicsContext3DDefaultImpl::getError):
        (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog):
        (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog):
        (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource):
        (WebKit::WebGraphicsContext3DDefaultImpl::getString):
        (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset):
        (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler):
        (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource):
        (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer):
        (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::createProgram):
        (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::createTexture):
        (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram):
        (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
        (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture):
        (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
        * src/WebGraphicsContext3DDefaultImpl.h: Added.
        (WebKit::WebGraphicsContext3DDefaultImpl::):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext):
        (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Sat, 20 Mar 2010 03:03:37 +0000 (03:03 +0000)]
2010-03-19  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Dmitry Titov.

        Refactor DatabaseTracker.cpp for thread safety
        https://bugs.webkit.org/show_bug.cgi?id=34991

        This enables calling into DatabaseTracker from multiple context threads,
        as will happen once Workers can access the Database.  It required a fair
        amount of reshuffling of locks.  I ended up splitting the public
        interface [calls that take locks and call private functions] from the
        implementations [calls that assert that locks are already held] in order
        to avoid lock conflicts.  I also had to make sure we weren't sharing
        Strings or SecurityOrigins across threads.

        No new tests.

        Allow access to database handles from multiple threads IFF SQLite is new enough and the user requests it.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::SQLiteDatabase):
        (WebCore::SQLiteDatabase::disableThreadingChecks):
        * platform/sql/SQLiteDatabase.h:
        (WebCore::SQLiteDatabase::sqlite3Handle):
        (WebCore::SQLiteDatabase::disableThreadingChecks):

        Remove an asynchronous call from Database::close back to the execution thread, so that cleanup can be more deterministic.

        * storage/Database.cpp:
        (WebCore::Database::markAsDeletedAndClose):
        (WebCore::Database::close):
        * storage/Database.h:
        (WebCore::Database::):
        * storage/DatabaseDetails.h:
        (WebCore::DatabaseDetails::DatabaseDetails):
        (WebCore::DatabaseDetails::thread):
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseCloseTask::doPerformTask):
        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::databaseThread):

        Any Strings that get stored in DatabaseTracker, and any Strings returned from DatabaseTracker, are now threadsafeCopies.
        Public functions now take all needed locks, then generally call only private functions [there are a few exceptions: deletion functions and origins()].
        Private functions no longer take locks.
        m_quotaMapGuard becomes m_databaseGuard, and now protects m_database, m_quotaMap, m_proposedDatabases, m_databaseDirectoryPath, m_originsBeingDeleted, m_beingCreated, and m_beingDeleted.
        m_proposedDatabases replaces m_proposedDatabase, to account for reentrancy.

        * storage/DatabaseTracker.h:
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::originQuotaManagerNoLock):
        (WebCore::DatabaseTracker::originQuotaManager):
        (WebCore::DatabaseTracker::DatabaseTracker):
        (WebCore::DatabaseTracker::setDatabaseDirectoryPath):
        (WebCore::DatabaseTracker::databaseDirectoryPath):
        (WebCore::DatabaseTracker::trackerDatabasePath):
        (WebCore::DatabaseTracker::openTrackerDatabase):
        (WebCore::DatabaseTracker::canEstablishDatabase):
        (WebCore::DatabaseTracker::hasEntryForOriginNoLock):
        (WebCore::DatabaseTracker::hasEntryForOrigin):
        (WebCore::DatabaseTracker::hasEntryForDatabase):
        (WebCore::DatabaseTracker::originPath):
        (WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
        (WebCore::DatabaseTracker::fullPathForDatabase):
        (WebCore::DatabaseTracker::populateOrigins):
        (WebCore::DatabaseTracker::origins):
        (WebCore::DatabaseTracker::databaseNamesForOriginNoLock):
        (WebCore::DatabaseTracker::databaseNamesForOrigin):
        (WebCore::DatabaseTracker::detailsForNameAndOrigin):
        (WebCore::DatabaseTracker::setDatabaseDetails):
        (WebCore::DatabaseTracker::usageForDatabase):
        (WebCore::DatabaseTracker::addOpenDatabase):
        (WebCore::DatabaseTracker::removeOpenDatabase):
        (WebCore::DatabaseTracker::usageForOriginNoLock):
        (WebCore::DatabaseTracker::usageForOrigin):
        (WebCore::DatabaseTracker::quotaForOriginNoLock):
        (WebCore::DatabaseTracker::quotaForOrigin):
        (WebCore::DatabaseTracker::setQuota):
        (WebCore::DatabaseTracker::addDatabase):
        (WebCore::DatabaseTracker::deleteAllDatabases):
        (WebCore::DatabaseTracker::deleteOrigin):
        (WebCore::DatabaseTracker::deleteDatabase):
        (WebCore::DatabaseTracker::deleteDatabaseFile):
        (WebCore::DatabaseTracker::setClient):
        (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
        (WebCore::DatabaseTracker::notifyDatabasesChanged):

        These functions keep track of in-progress deletions and creations, so that we can make sure nobody every deletes a database file while a live database is using it.
        (WebCore::DatabaseTracker::canCreateDatabase):
        (WebCore::DatabaseTracker::recordCreatingDatabase):
        (WebCore::DatabaseTracker::doneCreatingDatabase):
        (WebCore::DatabaseTracker::creatingDatabase):
        (WebCore::DatabaseTracker::canDeleteDatabase):
        (WebCore::DatabaseTracker::recordDeletingDatabase):
        (WebCore::DatabaseTracker::doneDeletingDatabase):
        (WebCore::DatabaseTracker::deletingDatabase):
        (WebCore::DatabaseTracker::canDeleteOrigin):
        (WebCore::DatabaseTracker::deletingOrigin):
        (WebCore::DatabaseTracker::recordDeletingOrigin):
        (WebCore::DatabaseTracker::doneDeletingOrigin):

        Any SecurityOrigins stored in OriginQuotaManager are now threadsafeCopies of inputs.  There's a new tryLock() function in addition to the existing lock().

        * storage/OriginQuotaManager.cpp:
        (WebCore::OriginQuotaManager::tryLock):
        (WebCore::OriginQuotaManager::trackOrigin):
        * storage/OriginQuotaManager.h:

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::databaseIdentifier):
        Removed DEFINE_STATIC_LOCAL wrapper on a local variable; it appears to have been a small optimization, but it's not thread-safe.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Sat, 20 Mar 2010 02:35:01 +0000 (02:35 +0000)]
2010-03-19  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        Multiselect popups - rendering
        https://bugs.webkit.org/show_bug.cgi?id=36006

        The objective of this patch is to create a compile time flag that can be used
        to force all <select> elements to be rendered as menu lists.

        Theme stylesheet mechanism has been used to change the appearance of the elements.

        Class QtStyleOptionWebComboBox has been introduced to provide to QStyle objects
        the needed information to render <select multiple> comboboxes.

        * WebCore.pri:
        * WebCore.pro:
        * css/themeQtNoListboxes.css: Added.
        (select[size][multiple]):
        * dom/SelectElement.h:
        (WebCore::SelectElementData::usesMenuList):
        * platform/qt/QtStyleOptionWebComboBox.h: Added.
        (WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox):
        (WebCore::QtStyleOptionWebComboBox::multiple):
        (WebCore::QtStyleOptionWebComboBox::checkMultiple):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::extraDefaultStyleSheet):
        (WebCore::RenderThemeQt::paintMenuList):
        (WebCore::RenderThemeQt::paintMenuListButton):
        * platform/qt/RenderThemeQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Sat, 20 Mar 2010 01:58:11 +0000 (01:58 +0000)]
2010-03-19  Zhenyao Mo  <zmo@google.com>

        Reviewed by Oliver Hunt.

        Update WebGLArray.slice() to new spec
        https://bugs.webkit.org/show_bug.cgi?id-35612

        * fast/canvas/webgl/array-unit-tests-expected.txt: Changed tests to reflect the new slice parameters; add new test cases for default inputs for slice.
        * fast/canvas/webgl/array-unit-tests.html: Ditto.
        * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Changed tests to reflect the new slice parameters.
        * fast/canvas/webgl/webgl-array-invalid-ranges.html: Ditto.
2010-03-19  Zhenyao Mo  <zmo@google.com>

        Reviewed by Oliver Hunt.

        Update WebGLArray.slice() to new spec
        https://bugs.webkit.org/show_bug.cgi?id-35612

        * bindings/js/JSWebGLArrayCustom.cpp: Adding support for default inputs.
        (WebCore::JSWebGLArray::slice):
        * bindings/v8/custom/V8WebGLArrayCustom.cpp: Ditto.
        (WebCore::V8WebGLArray::sliceCallback):
        * html/canvas/WebGLArray.cpp: Map start/end to offset/length.
        (WebCore::WebGLArray::calculateOffsetAndLength):
        * html/canvas/WebGLArray.h: Modified slice parameters.
        * html/canvas/WebGLArray.idl: Define custom binding for slice().
        * html/canvas/WebGLByteArray.cpp: Modified slice parameters.
        (WebCore::WebGLByteArray::slice):
        * html/canvas/WebGLByteArray.h: Ditto.
        * html/canvas/WebGLFloatArray.cpp: Ditto.
        (WebCore::WebGLFloatArray::slice):
        * html/canvas/WebGLFloatArray.h: Ditto.
        * html/canvas/WebGLIntArray.cpp: Ditto.
        (WebCore::WebGLIntArray::slice):
        * html/canvas/WebGLIntArray.h: Ditto.
        * html/canvas/WebGLShortArray.cpp: Ditto.
        (WebCore::WebGLShortArray::slice):
        * html/canvas/WebGLShortArray.h: Ditto.
        * html/canvas/WebGLUnsignedByteArray.cpp: Ditto.
        (WebCore::WebGLUnsignedByteArray::slice):
        * html/canvas/WebGLUnsignedByteArray.h: Ditto.
        * html/canvas/WebGLUnsignedIntArray.cpp: Ditto.
        (WebCore::WebGLUnsignedIntArray::slice):
        * html/canvas/WebGLUnsignedIntArray.h: Ditto.
        * html/canvas/WebGLUnsignedShortArray.cpp: Ditto.
        (WebCore::WebGLUnsignedShortArray::slice):
        * html/canvas/WebGLUnsignedShortArray.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 20 Mar 2010 01:39:10 +0000 (01:39 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Freeze sandbox attributes on creation
        https://bugs.webkit.org/show_bug.cgi?id=34184

        Test that allow-forms is frozen on document creation.

        * fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
        * fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
        * fast/frames/sandboxed-iframe-forms-dynamic.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Yong Li <yong.li@torchmobile.com> and Andy Estes <aestes@apple.com>
eric@webkit.org [Sat, 20 Mar 2010 01:20:50 +0000 (01:20 +0000)]
2010-03-19  Yong Li <yong.li@torchmobile.com> and Andy Estes <aestes@apple.com>

        Reviewed by Darin Adler.

        Ensure the segments inside SharedBuffer are merged before constructing
        a CFData with it.

        https://bugs.webkit.org/show_bug.cgi?id=50843

        * manual-tests/WebKitSite.webarchive: Added.
        * manual-tests/webarchive-test.html: Added.
        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::createCFData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Justin Schuh <jschuh@chromium.org>
oliver@apple.com [Sat, 20 Mar 2010 00:45:42 +0000 (00:45 +0000)]
2010-03-19  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Oliver Hunt.

        Security: ReadAV@NULL for negative feMorphology filter radius
        https://bugs.webkit.org/show_bug.cgi?id=34566

        Prevents building the filter if either radius is negative.
        Catches negative radii resulting from conversions.

        Test: svg/filters/feMorphology-invalid-radius.svg

        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::build):
        * svg/graphics/filters/SVGFEMorphology.cpp:
        (WebCore::FEMorphology::apply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 20 Mar 2010 00:41:19 +0000 (00:41 +0000)]
2010-03-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Disable the downstream override expectations temporarily to allow
        us to test that we've upstreamed everything correctly. Also, stop
        looking at the downstream baselines at all (now you will only be
        able to update baselines upstream). In theory this should work, but
        if we need to we can always add the downstream dirs back in.

        https://bugs.webkit.org/show_bug.cgi?id=36396

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed a crash with AnimationController getting deleted out from under itself.
cmarrin@apple.com [Sat, 20 Mar 2010 00:28:12 +0000 (00:28 +0000)]
    Fixed a crash with AnimationController getting deleted out from under itself.

        It's possible for the Frame that owns an AnimationController to get deleted
        in the EndTransitionEvent (or other animation events) to get deleted in the
        event handler. Normally this case is protected against by preventing the Frame
        from getting deleted until the end of the runloop. But native uses of the
        WebView can subvert this protection. So I added a protector to the
        animation event dispatcher to protect it in those cases.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Sat, 20 Mar 2010 00:08:32 +0000 (00:08 +0000)]
2010-03-19  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        Multiselect Popup - PopupMenuClient extension
        https://bugs.webkit.org/show_bug.cgi?id=36178

        PopupMenuClient class is the interface used by combobox popup implementations.
        It needs to be extended to handle <select multiple> needs.

        A new interface named ListPopupMenuClient that inherits from PopupMenuClient was created.
        The use of this new class instead of adding methods to PopupMenuClient avoids changes
        in other non related implementations of PopupMenuClient.

        RenderMenuList has changed to inherit ListPopupMenuClient instead of PopupMenuClient
        and to have the new methods implemented.

        * platform/PopupMenuClient.h:
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::listBoxSelectItem):
        (WebCore::RenderMenuList::multiple):
        * rendering/RenderMenuList.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 19 Mar 2010 23:42:04 +0000 (23:42 +0000)]
2010-03-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=36387
        REGRESSION: Can "uncheck" radio buttons by clicking on them

        My change in r56174 caused radio buttons and checkboxes to go down the same code path by virtue
        of allowsIndeterminate(), but this broke save/restore behavior on radio buttons.

        Fix by saving and restoring both the intermediate and checked state for radio buttons
        and checkboxes, as well as the "current radio button" state.

        Test: fast/forms/radio-checkbox-restore-indeterminate.html

        * html/HTMLInputElement.cpp:
        (WebCore::EventHandlingState::EventHandlingState): New struct to hold state between preDispatchEventHandler()
        and postDispatchEventHandler().
        (WebCore::HTMLInputElement::preDispatchEventHandler): Store intermedate and checked state
        and the current radio button.
        (WebCore::HTMLInputElement::postDispatchEventHandler): Restore state as appropriate.
        * html/HTMLInputElement.h: Add a comment to clarify how 'intermediate' interacts with 'checked', according
        to the spec.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 23:38:06 +0000 (23:38 +0000)]
2010-03-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        fix typo in chromium test expectations overrides routine
        https://bugs.webkit.org/show_bug.cgi?id=36397

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 19 Mar 2010 23:09:16 +0000 (23:09 +0000)]
2010-03-19  Darin Fisher  <darin@chromium.org>

        Temporarily suppress fast/loader/frame-src-change-added-to-history.html
        for Tiger to make the bot green.

        https://bugs.webkit.org/show_bug.cgi?id=36382

        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 23:06:16 +0000 (23:06 +0000)]
2010-03-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed change.

        Add in missing test_expectations.txt file that didn't actually
        make it into the commit.

        https://bugs.webkit.org/show_bug.cgi?id=36326

        * LayoutTests/platform/chromium/test_expectations.txt

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Fri, 19 Mar 2010 23:05:15 +0000 (23:05 +0000)]
2010-03-19  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: caret moves past prompt in javascript console
        https://bugs.webkit.org/show_bug.cgi?id=26602

        Having noticed any Element children besides a leading <br> (which are empty
        text nodes), WebCore editing facility thinks it should delete the <br>,
        thus clearing away the text prompt contents.

        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt.prototype.clearAutoComplete):
        (WebInspector.TextPrompt.prototype._completionsReady):
        * inspector/front-end/utilities.js:
        (Element.prototype.pruneEmptyTextNodes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 23:02:48 +0000 (23:02 +0000)]
2010-03-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Flip the Chromium ports to look first for the test expectations
        in LayoutTests/platform/chromium and only afterwards look in the
        Chromium repo downstream for overrides.

        https://bugs.webkit.org/show_bug.cgi?id=36326

        * WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:
        * LayoutTests/platform/chromium/test_expectations.txt

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 22:52:55 +0000 (22:52 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.
        Land remaining chromium-linux LayoutTest baselines
        (file list omitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 22:43:18 +0000 (22:43 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-linux/fast/{block,css,forms,text} LayoutTest baselines
        (file list omitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-linux/fast/block : Added.
        * platform/chromium-linux/fast/css : Added.
        * platform/chromium-linux/fast/forms : Added.
        * platform/chromium-linux/fast/text : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 22:35:18 +0000 (22:35 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-linux/editing LayoutTest baselines
        (file list omitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-linux/editing : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Fri, 19 Mar 2010 22:33:45 +0000 (22:33 +0000)]
2010-03-19  James Hawkins  <jhawkins@chromium.org>

        Unreviewed.

        Add myself to the committers list.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 22:29:37 +0000 (22:29 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-linux/tables LayoutTest baselines
        (file list omitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-linux/tables : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 22:18:40 +0000 (22:18 +0000)]
010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-linux/svg LayoutTest baselines
        (file list omitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-linux/svg : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 22:09:48 +0000 (22:09 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-linux/css* LayoutTest baselines
        (file list omitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-linux/css* : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 22:00:06 +0000 (22:00 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land remaining chromium-win/* LayoutTest baselines
        (file list omitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win/* : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 21:50:01 +0000 (21:50 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-win/css* LayoutTest baselines
        (file list ommitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win/css* : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Back-forward list dumping is incorrect
ossy@webkit.org [Fri, 19 Mar 2010 21:38:46 +0000 (21:38 +0000)]
[Qt] Back-forward list dumping is incorrect
https://bugs.webkit.org/show_bug.cgi?id=36392

* platform/qt/Skipped: fast/loader/frame-src-change-added-to-history.html skipped until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 21:34:38 +0000 (21:34 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-win/fast/[l-z]* LayoutTest baselines
        (file list ommitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win/fast/[l-z]* : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 21:24:56 +0000 (21:24 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land chromium-win/fast/{a,c,d,e,f,g,h,i,j}* LayoutTest baselines
        (file list ommitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win/fast/{a,c,d,e,f,g,h,i,j}* : Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 19 Mar 2010 21:14:57 +0000 (21:14 +0000)]
2010-03-19  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Gustavo Noronha.

        r56188 removed lastPosition from the Geolocation code, but the the
        geolocation window properties wasn't updated to reflect this. It's
        only failing on the GTK+ port, since the other ports have it on
        their Skipped list.

        * fast/dom/Window/window-properties-geolocation-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm...
ossy@webkit.org [Fri, 19 Mar 2010 21:11:06 +0000 (21:11 +0000)]
   [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
       https://bugs.webkit.org/show_bug.cgi?id=36386

* platform/qt/Skipped: fast/media/print-restores-previous-mediatype.html skipped until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 21:04:43 +0000 (21:04 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land the first part of chromium-win/fast LayoutTest baselines
        (file list ommitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win/fast: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 21:01:03 +0000 (21:01 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Fix SheriffBot exception lock when we can't retrieve the first build
        from buildbot.  (I'll ask Eric to review this change after the fact,
        but he's at lunch and I want to get the bot unlocked.)

        * Scripts/webkitpy/buildbot.py:
        * Scripts/webkitpy/buildbot_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 19 Mar 2010 20:21:51 +0000 (20:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=36380
        websocket/tests/frame-lengths.html times out on Tiger bot

        https://bugs.webkit.org/show_bug.cgi?id=35041
        websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot

        Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
        sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
        timing out than to detect it early.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setWaitToDump):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::waitUntilDone):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 19 Mar 2010 20:20:14 +0000 (20:20 +0000)]
2010-03-19  Xan Lopez  <xlopez@igalia.com>

        Unreviewed, land new expected result for test.

        * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 19 Mar 2010 20:15:51 +0000 (20:15 +0000)]
2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        Buildfix for Qt v4.5.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewOverlay::q):

2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed.

        Buildfix for Qt v4.5.

        * QtLauncher/main.cpp:
        (LauncherWindow::LauncherWindow):
        (LauncherWindow::applyZoom):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 20:10:04 +0000 (20:10 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land the chromium-win/tables LayoutTest baselines (file list
        ommitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win/tables: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, build fix.
dglazkov@chromium.org [Fri, 19 Mar 2010 20:09:45 +0000 (20:09 +0000)]
Unreviewed, build fix.

Rename enqueueStorageEvent to enqueueEvent to match changes in
http://trac.webkit.org/changeset/56249.

* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::storageEvent): Renamed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 20:05:30 +0000 (20:05 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Operational tweaks to SheriffBot
        https://bugs.webkit.org/show_bug.cgi?id=36385

        These changes aren't pretty, but they're helpful to make SheriffBot
        work operationally.  I plan to iterate in these areas, but I wanted to
        get this patch landed so I could be running the bot against TOT.

        * Scripts/webkitpy/commands/sheriffbot.py:
        * Scripts/webkitpy/irc/ircbot.py:
        * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows clean build fix after r56192
aroben@apple.com [Fri, 19 Mar 2010 20:01:43 +0000 (20:01 +0000)]
Windows clean build fix after r56192

* WebCore.vcproj/WebCore.vcproj: Copy headers from
platform/graphics/cg to $WebKitOutputDir as part of the post-build
event so that WebKit can use them. (The only one we currently require
is FontPlatformData.h.)

* platform/graphics/win/FontPlatformDataCGWin.cpp: Touched to force a
build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 19:56:25 +0000 (19:56 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land the chromium-win/svg LayoutTest baselines (file list
        ommitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win/svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Eric Seidel.
beidson@apple.com [Fri, 19 Mar 2010 19:54:07 +0000 (19:54 +0000)]
Rubberstamped by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=35594

* fast/loader/api-test-new-window-data-load-base-url.html: Removed.
* fast/loader/api-test-new-window-data-load-base-url.html-disabled: Copied from fast/loader/api-test-new-window-data-load-base-url.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 19:41:19 +0000 (19:41 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land the chromium-win-vista LayoutTest baselines (file list
        ommitted due to length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win-vista: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 19:40:10 +0000 (19:40 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land the chromium-win-xp LayoutTest baselines (file list ommitted due to
        length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-win-xp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 19:38:07 +0000 (19:38 +0000)]
2010-03-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Land the chromium-mac LayoutTest baselines (file list ommitted due to
        length).

        https://bugs.webkit.org/show_bug.cgi?id=28397

        * platform/chromium-mac: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 19 Mar 2010 18:37:43 +0000 (18:37 +0000)]
2010-03-19  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        Assertion failure in media/video-controls-with-mutation-event-handler.html
        https://bugs.webkit.org/show_bug.cgi?id=36376

        Fix crashing test. Underlying the media element's volume slider is a
        range input, which sanitizes values before expected on the media control.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::createVolumeSlider):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago3 of the new HTML5 loading events need to be asynchronous.
beidson@apple.com [Fri, 19 Mar 2010 18:25:21 +0000 (18:25 +0000)]
3 of the new HTML5 loading events need to be asynchronous.

Reviewed by Darin Adler.

Laying the groundwork for:
https://bugs.webkit.org/show_bug.cgi?id=36201
https://bugs.webkit.org/show_bug.cgi?id=36202
https://bugs.webkit.org/show_bug.cgi?id=36334
https://bugs.webkit.org/show_bug.cgi?id=36335

Document already had an asynchronous event delivery mechanism for storage events, so
we can repurpose that for all async events.

No new tests. (No change in behavior)

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::implicitClose): Use Document::schedule* for the related events.
(WebCore::Document::enqueueEvent): Renamed from enqueueStorageEvent
(WebCore::Document::pendingEventTimerFired): Renamed from "storageEventTimerFired"
(WebCore::Document::statePopped): Use Document::schedulePopstateEvent
(WebCore::Document::enqueuePageshowEvent): All Pageshow events are piped through here.
  This will be made asynchronous in a separate patch.
(WebCore::Document::enqueueHashchangeEvent): All Hashchange events are piped through here.
  This will be made asynchronous in a separate patch.
(WebCore::Document::enqueuePopstateEvent): All Popstate events are piped through here.
  This will be made asynchronous in a separate patch.
* dom/Document.h:
(WebCore::):

* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Use Document::enqueuePageshowEvent

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument): Use Document::enqueueHashchangeEvent

* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch): Use Document::enqueueEvent

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 19 Mar 2010 18:23:57 +0000 (18:23 +0000)]
2010-03-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
        https://bugs.webkit.org/show_bug.cgi?id=36354

        * Scripts/webkitpy/buildbot.py:
         - Make Build creation easier to Mock and test
        * Scripts/webkitpy/buildbot_unittest.py:
         - Test finding green to red transitions and suspect revisions
        * Scripts/webkitpy/commands/queries.py:
         - Make what-broke note when builders have only failed once.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 19 Mar 2010 18:19:12 +0000 (18:19 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=36337
        Log an error when an OOP plug-in sends an unknown object id

        Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
        temporary or redundant.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::invokeDefault):
        (WebKit::NetscapePluginInstanceProxy::construct):
        (WebKit::NetscapePluginInstanceProxy::getProperty):
        (WebKit::NetscapePluginInstanceProxy::setProperty):
        (WebKit::NetscapePluginInstanceProxy::removeProperty):
        (WebKit::NetscapePluginInstanceProxy::hasProperty):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):
        (WebKit::NetscapePluginInstanceProxy::enumerate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler and Brady Eidson.
kdecker@apple.com [Fri, 19 Mar 2010 18:16:55 +0000 (18:16 +0000)]
    Reviewed by Darin Adler and Brady Eidson.

        First step toward:
        https://bugs.webkit.org/show_bug.cgi?id=36328

        This is the first step torward eliminating the WebKit WebNullPluginView class. The responsibility for this will soon
        be in platform-independent code in WebCore. The plan is to change RenderEmbeddedObject and give it the capability of
        drawing the missing plug-in text.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestObject): Renamed the renderer parameter to requestEmbeddedObject and made it
        a RenderEmbeddedObject.
        (WebCore::FrameLoader::loadPlugin): Likewise.
        * loader/FrameLoader.h: Updated loadPlugin() and requestObject() method signatures accordingly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 19 Mar 2010 18:01:08 +0000 (18:01 +0000)]
2010-03-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix the rebaselining tool, which was broken by r36324 when I
        added the concept of overridding expectations.

        https://bugs.webkit.org/show_bug.cgi?id=36374

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 19 Mar 2010 17:30:12 +0000 (17:30 +0000)]
2010-03-19  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] querying the current history item during a back/forward
        navigation should not clobber the scroll offset, etc.
        https://bugs.webkit.org/show_bug.cgi?id=36347

        We should only allow the current history item to be modified if we are
        no longer loading or if the load is a new navigation (i.e., not a
        back/forward/reload variant).

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::currentHistoryItem):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 19 Mar 2010 16:41:49 +0000 (16:41 +0000)]
2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
        https://bugs.webkit.org/show_bug.cgi?id=36348

        Backing store implementation for QtWebKit requires at least Qt
        version 4.6.

        No new tests as there is no new functionality.

        * WebCore.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 19 Mar 2010 16:16:16 +0000 (16:16 +0000)]
2010-03-19  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        <input type=range> does not validate correctly without a renderer and the tests are incorrect
        https://bugs.webkit.org/show_bug.cgi?id=36259

        Setting value attribute on an <input type=range> to an out-of-range value fires oninput
        https://bugs.webkit.org/show_bug.cgi?id=16990

        Part 2 of 2: When setting the range element's value, overflows and underflows
        are automatically sanitized to valid values. Moved the general case
        sanitization code out of the Renderer into HTMLInputElement::sanitizeValue.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::value): when getting a default value on reset() ensure the defaultValue is provided
        (WebCore::HTMLInputElement::sanitizeValue): clamp the value within the max/min/step range constraints
        * html/StepRange.cpp:
        (WebCore::StepRange::StepRange): allow const element in the constructor
        (WebCore::StepRange::clampValue): clamp from a String value
        * html/StepRange.h:
        (WebCore::StepRange::defaultValue): easy calculation of the default value for max/min/step range constraints
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::updateFromElement): no longer handle the general case sanitization in the renderer

2010-03-19  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        <input type=range> does not validate correctly without a renderer and the tests are incorrect
        https://bugs.webkit.org/show_bug.cgi?id=36259

        Setting value attribute on an <input type=range> to an out-of-range value fires oninput
        https://bugs.webkit.org/show_bug.cgi?id=16990

        When setting the range element's value, overflows and underflows are
        automatically sanitized to valid values. Fixed the behavior and removed
        tests that were testing for improper behavior.

        * fast/forms/ValidityState-rangeOverflow-expected.txt:
        * fast/forms/ValidityState-rangeUnderflow-expected.txt:
        * fast/forms/input-stepup-stepdown-expected.txt:
        * fast/forms/script-tests/ValidityState-rangeOverflow.js:
        * fast/forms/script-tests/ValidityState-rangeUnderflow.js:
        * fast/forms/script-tests/input-stepup-stepdown.js:
        * fast/forms/script-tests/validationMessage.js:
        * fast/forms/validationMessage-expected.txt:

          Added test verifying that bug 16990 was fixed as well.

        * fast/forms/range-input-dynamic-oninput-expected.txt: Added.
        * fast/forms/range-input-dynamic-oninput.html Added.

          Improved test because handling of this case changed.

        * fast/forms/range-reset-expected.txt:
        * fast/forms/range-reset.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 19 Mar 2010 16:16:03 +0000 (16:16 +0000)]
2010-03-19  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        <input type=range> does not validate correctly without a renderer and the tests are incorrect
        https://bugs.webkit.org/show_bug.cgi?id=36259

        Part 1 of 2: Refactoring the SliderRange struct out of RenderSlider
        into a more appropriate place. Changed the named to StepRange. Changed
        from a struct to a class.

          Added new files to the build.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:

          Renamed and moved class SliderRange to StepRange.

        * html/StepRange.cpp: Added.
        (WebCore::StepRange::StepRange):
        (WebCore::StepRange::clampValue):
        (WebCore::StepRange::valueFromElement):
        (WebCore::sliderPosition):
        * html/StepRange.h: Added.
        (WebCore::StepRange::proportionFromValue):
        (WebCore::StepRange::valueFromProportion):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::updateFromElement): updated to use StepRange
        (WebCore::RenderSlider::setValueForPosition): updated to use StepRange

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 19 Mar 2010 15:33:07 +0000 (15:33 +0000)]
2010-03-19  Darin Fisher  <darin@chromium.org>

        Fix expected results for fast/loader/frame-src-change-added-to-history.html

        * fast/loader/frame-src-change-added-to-history-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=36366
hausmann@webkit.org [Fri, 19 Mar 2010 15:27:59 +0000 (15:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36366
Repaint loop when painting using scaled CTMs with different translations

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-03-19
Reviewed by Simon Hausmann.

The code in RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality
tests if the scaling has changed from the previous value by comparing the
transformations. The test fails if the scale is the same but the translation
changes. This can lead to infinite repaint loop if the document is painted
in pieces using different translations (for example for tiling).

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 19 Mar 2010 15:03:16 +0000 (15:03 +0000)]
2010-03-19  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Need a layout test for finding yensign from documents with Japanese encodings
        https://bugs.webkit.org/show_bug.cgi?id=36288

        * editing/selection/find-yensign-and-backslash-expected.txt: Added.
        * editing/selection/find-yensign-and-backslash.html: Added.
        * platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Added.
        * platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Added.
        * platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 19 Mar 2010 13:35:09 +0000 (13:35 +0000)]
2010-03-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: editing shorthands does not always work.

        https://bugs.webkit.org/show_bug.cgi?id=36362

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::applyStyleText):
        (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
        (WebCore::InspectorDOMAgent::shorthandValue):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/inspector.css:
        (.section .properties li.disabled .enabled-button):
        * inspector/front-end/inspector.js:
        (WebInspector.startEditing.editingCommitted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Don't replace clip when drawing complex text
vestbo@webkit.org [Fri, 19 Mar 2010 13:10:14 +0000 (13:10 +0000)]
[Qt] Don't replace clip when drawing complex text

Reviewed by Simon Hausmann.

* platform/graphics/qt/FontQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 10:05:04 +0000 (10:05 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Misc bug fixes to make the SheriffBot actually work
        https://bugs.webkit.org/show_bug.cgi?id=36355

        With these changes, I can actually run the sheriff-bot from start to
        finish.

        * Scripts/webkitpy/irc/ircproxy.py:
        * Scripts/webkitpy/patch/patcher.py:
        * Scripts/webkitpy/statusserver.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 09:51:52 +0000 (09:51 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Actually import the sheriff-bot command so we can run it.  Also, move
        the bot to #webkit-test so it doesn't cause a ruckus while we test it.

        * Scripts/webkitpy/patch/patcher.py:
        * Scripts/webkitpy/irc/ircbot.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 09:44:25 +0000 (09:44 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Second cut at SheriffBot
        https://bugs.webkit.org/show_bug.cgi?id=36353

        This patch should contain a complete SheriffBot that's capable of
        saying reasonable things on IRC.  I had to refactor the use of
        CommitInfo to make the SheriffBot testable, but I did the minimum
        necessary.  We should grow webkitcheckout over time to contain the
        knowledge of ChangeLogs from scm.

        * Scripts/webkitpy/commands/sheriffbot.py:
        * Scripts/webkitpy/commands/sheriffbot_unittest.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/patch/patcher.py:
        * Scripts/webkitpy/webkitcheckout.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 08:44:22 +0000 (08:44 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Fix Hyatt's IRC nickname.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 19 Mar 2010 08:42:16 +0000 (08:42 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Add IRC nicknames for the non-reviewer committers.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 08:10:54 +0000 (08:10 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Add IRC nicknames for the non-reviewer committers.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 07:59:01 +0000 (07:59 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        More reviewer IRC nicknames.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 07:53:38 +0000 (07:53 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Add a bunch of IRC nicknames for reviewers.

        * Scripts/webkitpy/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Fri, 19 Mar 2010 07:47:12 +0000 (07:47 +0000)]
2010-03-19  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Oliver Hunt.

        Added USE_SYSTEM_MALLOC flag to build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=21272

        Add system-alloc flag to build-webkit. It makes easy to switch
        between system allocator and TCmalloc.

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 07:44:09 +0000 (07:44 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Unreviewed "build" fix.

        Of course, I caused a regression in the file that isn't tested.  :(

        * Scripts/webkitpy/statusserver.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 19 Mar 2010 07:37:35 +0000 (07:37 +0000)]
2010-03-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Simplify BuildBot core builder code for easier re-use
        https://bugs.webkit.org/show_bug.cgi?id=36350

        I simply couldn't see anything through all this Yak-hair.

        * Scripts/webkitpy/buildbot.py:
        * Scripts/webkitpy/commands/queries.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 07:33:39 +0000 (07:33 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        committers.py should know IRC nicknames
        https://bugs.webkit.org/show_bug.cgi?id=36349

        I'll add the actual nicknames in another patch.

        * Scripts/webkitpy/committers.py:
        * Scripts/webkitpy/committers_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 19 Mar 2010 07:31:48 +0000 (07:31 +0000)]
2010-03-18  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        If a frame is already in the document, then setting its "src" attribute
        should add the resultant navigation to history.

        https://bugs.webkit.org/show_bug.cgi?id=9166

        This behavior is specified in section 4.8.2 of the HTML5 spec.

        Test: fast/loader/frame-src-change-added-to-history.html

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::openURL):
        (WebCore::HTMLFrameElementBase::setLocation):
        * html/HTMLFrameElementBase.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestFrame):
        * loader/FrameLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=36318
hausmann@webkit.org [Fri, 19 Mar 2010 07:20:01 +0000 (07:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36318

Patch by Anders Bakken  <Anders Bakken <agbakken@gmail.com>> on 2010-03-18
Reviewed by Simon Hausmann.

QtLauncher runs as a GuiClient by default in Qt Embedded which will
make it try to connect to an existing GuiServer. This patch makes it
run like a stand-alone app.

* QtLauncher/main.cpp:
(LauncherApplication::LauncherApplication):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
ossy@webkit.org [Fri, 19 Mar 2010 07:18:16 +0000 (07:18 +0000)]
Unreviewed.

[Qt] Platform specific expected file updated after r56195

* platform/qt/fast/dom/Window/window-properties-expected.txt: updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Eric Seidel <eric@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 07:15:32 +0000 (07:15 +0000)]
2010-03-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
        https://bugs.webkit.org/show_bug.cgi?id=36345

        * Scripts/webkitpy/buildbot.py:
        * Scripts/webkitpy/commands/queries.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 07:04:57 +0000 (07:04 +0000)]
2010-03-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Adam Barth.

        Actually pass the IRC password to the IRC object
        https://bugs.webkit.org/show_bug.cgi?id=36346

        I wanted to do this before, but both patches were in flight.  This
        patch finally closes the loop and makes the IRCProxy system complete.

        * Scripts/webkitpy/patch/patcher.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 06:58:21 +0000 (06:58 +0000)]
2010-03-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a StatusServer front end to the SVNRevision table on QueueStatusServer
        https://bugs.webkit.org/show_bug.cgi?id=36344

        No test because Browser was too hard to mock.  :(  I couldn't figure
        out how to make Mock be a dictionary as well as an object.

        * Scripts/webkitpy/statusserver.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Philip Chimento <philip.chimento@gmail.com>
eric@webkit.org [Fri, 19 Mar 2010 06:46:42 +0000 (06:46 +0000)]
2010-03-18  Philip Chimento  <philip.chimento@gmail.com>

        Reviewed by Oliver Hunt.

        Setting the GObject WebKitWebView property 'window-features' to NULL
        causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=36144

        * tests/testwebview.c: Add unit test for this bug.
        * webkit/webkitwebview.cpp: Don't allow the 'window-features' property
        to be set to NULL.
        * webkit/webkitwebwindowfeatures.cpp:
        (webkit_web_window_features_equal): Don't examine the members of either
        web_window_features argument if either is NULL, just return that they
        are not equal. Additionally, if they are the same object, return that
        they are equal.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 19 Mar 2010 06:46:10 +0000 (06:46 +0000)]
2010-03-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Split out CommitInfo class and add unit tests
        https://bugs.webkit.org/show_bug.cgi?id=36343

        Move more logic out of "what-broke" into a shared CommitInfo
        class so that it can be used by other commands and unit tested.

        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commitinfo.py: Added.
        * Scripts/webkitpy/commitinfo_unittest.py: Added.
        * Scripts/webkitpy/unittests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Tom Callaway <tcallawa@redhat.com>
eric@webkit.org [Fri, 19 Mar 2010 06:29:21 +0000 (06:29 +0000)]
2010-03-18  Tom Callaway  <tcallawa@redhat.com>

        Reviewed by Darin Adler.

        Bug 35429: Fix compile on SPARC64
        https://bugs.webkit.org/show_bug.cgi?id=35429

        * wtf/Platform.h: Set WTF_USE_JSVALUE64 for SPARC64

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Fix a minor crash with mismatched array sizes in SVG animation
oliver@apple.com [Fri, 19 Mar 2010 06:24:19 +0000 (06:24 +0000)]
WebCore: Fix a minor crash with mismatched array sizes in SVG animation
elements.

Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=35606

Test: svg/animations/keypoints-mismatch.svg

* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
Globally apply validations relevant to all animation types.

LayoutTests: Add test for minor SVG animation crashers.
See https://bugs.webkit.org/show_bug.cgi?id=35606

Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.

* svg/animations/keypoints-mismatch.svg: Added.
* svg/animations/keypoints-mismatch-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Ojan Vafai <ojan@chromium.org>
eric@webkit.org [Fri, 19 Mar 2010 06:03:34 +0000 (06:03 +0000)]
2010-03-18  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        add new results for failing win/linux test after http://trac.webkit.org/changeset/56175
        https://bugs.webkit.org/show_bug.cgi?id=36329

        Missed this test in r56175 since it does a drag on win/linux, but not a mac.
        The new results correctly do the smart-drag behavior of doing a smart-delete
        on drag regardless of whether the selection granularity is word granularity.

        * platform/win/editing/selection/drag-text-delay-expected.checksum: Added.
        * platform/win/editing/selection/drag-text-delay-expected.png: Added.
        * platform/win/editing/selection/drag-text-delay-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Fri, 19 Mar 2010 05:46:15 +0000 (05:46 +0000)]
2010-03-18  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Adam Barth.

        Implement software composited graphics layers in Chromium using the Skia library.
        https://bugs.webkit.org/show_bug.cgi?id=35557
        This is an initial step in the implementation. Layer compositing is functioning
        but not optimized in any way. Subsesquent check-ins will be necessary to fine tune
        it.

        Test: No new exposed functionality so no new tests.

        * WebCore.gypi:
          Added new source files to the chromium build
        * platform/graphics/GraphicsLayer.h:
          Added necessary typedef's and forward declarations for Chromium.
        * platform/graphics/skia/GraphicsLayerSkia.cpp: Added.
        * platform/graphics/skia/GraphicsLayerSkia.h: Added.
          Declaration and implementation of the platform-specific GraphicsLayer class.
        * platform/graphics/skia/LayerRendererSkia.cpp: Added.
        * platform/graphics/skia/LayerRendererSkia.h: Added.
          Declaration and implementation of the Skia-based software compositor.
        * platform/graphics/skia/LayerSkia.cpp: Added.
        * platform/graphics/skia/LayerSkia.h: Added.
          Declaration and implementation of a compositable layer that uses a Skia canvas
          for backing store.
2010-03-18  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Adam Barth.

        Adding support for the ACCELERATED_COMPOSITING render path to Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=35557
        Currently compositing of layers is performed via s/w compositor which relies on Skia. This is an initial check-in
        and it's only been tested on Windows. Compiling the code requires seting "use_accelerated_compositing=1"
        to GYP_DEFINES. The update of layer contents and compositing is fairly inefficient but this will be fixed in
        subsequent check-ins.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
        (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
        * src/ChromeClientImpl.h:
        (WebKit::ChromeClientImpl::setNeedsOneShotDrawingSynchronization):
         Added methods required by the RenderLayerCompositor

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::paintWithContext):
        (WebKit::WebFrameImpl::paint):
        * src/WebFrameImpl.h:
        Split WebFrameImpl::paint() into two methods to make it possible to call the paint
        routine with an existing GraphicsContext, which is necessary for painting the root layer into
        its own backing surface.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::paint):
        Modified method to handle the accelerated compositing path. Now, when doing accelerated compositing,
        paint() results in repainting the contents of the root layer and then doing a composite operation.
        (WebKit::WebViewImpl::setRootGraphicsLayer):
        (WebKit::WebViewImpl::setAcceleratedCompositing):
        (WebKit::WebViewImpl::updateRootLayerContents):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::isAcceleratedCompositing):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 19 Mar 2010 05:32:21 +0000 (05:32 +0000)]
2010-03-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix LayoutTests/http/tests/appcache/max-size.html
        https://bugs.webkit.org/show_bug.cgi?id=36207

        * platform/qt/Skipped:

2010-03-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix LayoutTests/http/tests/appcache/max-size.html
        https://bugs.webkit.org/show_bug.cgi?id=36207

        Implement setAppCacheMaximumSize() for Qt.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setAppCacheMaximumSize):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Mar 2010 05:13:37 +0000 (05:13 +0000)]
2010-03-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        QueueStatusServer should be able to log broken bots
        https://bugs.webkit.org/show_bug.cgi?id=36341

        We need to add a new table to the QueueStatusServer to store persistent
        information for the SheriffBot.  The new table will keep track of which
        bots each SVN revision broke.

        * QueueStatusServer/handlers/__init__.py:
        * QueueStatusServer/handlers/svnrevision.py: Added.
        * QueueStatusServer/handlers/updatebase.py: Added.
        * QueueStatusServer/handlers/updatestatus.py:
        * QueueStatusServer/handlers/updatesvnrevision.py: Added.
        * QueueStatusServer/index.yaml:
        * QueueStatusServer/main.py:
        * QueueStatusServer/model/__init__.py:
        * QueueStatusServer/model/svnrevision.py: Added.
        * QueueStatusServer/templates/updatesvnrevision.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Fri, 19 Mar 2010 05:11:09 +0000 (05:11 +0000)]
2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Darin Adler.

        Add a new test for testing whether the media type is restores
        properly after printing a page (changing media type to 'print').

        Add expected result and skip the test for platform that do not
        implement setMediaType().

        * fast/media/print-restores-previous-mediatype-expected.txt: Added.
        * fast/media/print-restores-previous-mediatype.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:
2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Darin Adler.

        Make setPrinting() with printing=false, restore the previous
        media type in use.

        Test: fast/media/print-restores-previous-mediatype.html

        * page/Frame.cpp:
        (WebCore::Frame::setPrinting):
        * page/FrameView.cpp:
        (WebCore::FrameView::adjustMediaTypeForPrinting):
        * page/FrameView.h:
2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Darin Adler.

        Make it possible for the Qt DRT to set the media type from
        the LayoutTestController.

        * Api/qwebframe.cpp:
        (qt_drt_setMediaType):
2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Darin Adler.

        Add a new method to the Qt LayoutTestController for
        changing media type and make the DRT support dry-run printing.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::dryRunPrint):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setMediaType):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Joe Ligman <joseph.ligman@nokia.com>
eric@webkit.org [Fri, 19 Mar 2010 04:51:35 +0000 (04:51 +0000)]
2010-03-18  Joe Ligman  <joseph.ligman@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] New API scrollRecursively has several problems.
        https://bugs.webkit.org/show_bug.cgi?id=35873

        Remove scrollRecursively from the Qt 4.7 API
        Update the internal API to accept a hit test position
        for nested scrolling

        * Api/qwebframe.cpp:
        (webframe_scrollOverflow):
        (qtwebkit_webframe_scrollRecursively):
        * Api/qwebframe.h:
        * Api/qwebframe_p.h:
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate test results after r56182. "background-color: rgba(0, 0, 0, 0)" is now report...
mrowe@apple.com [Fri, 19 Mar 2010 03:58:55 +0000 (03:58 +0000)]
Update test results after r56182.  "background-color: rgba(0, 0, 0, 0)" is now reported as "background-color: transparent".

Rubber-stamped by Samuel Weinig.

* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<http://webkit.org/b/36338> Remove unused RenderReplaced::adjustOverflowForBoxShadowA...
ddkilzer@apple.com [Fri, 19 Mar 2010 01:33:43 +0000 (01:33 +0000)]
<webkit.org/b/36338> Remove unused RenderReplaced::adjustOverflowForBoxShadowAndReflect() declaration

Rubber-stamped by Darin Adler.

This declaration should have been removed in r47440.

* rendering/RenderReplaced.h:
(WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDragging a PDF image triggers assertion in DragController::startDrag()
jianli@chromium.org [Fri, 19 Mar 2010 01:05:58 +0000 (01:05 +0000)]
Dragging a PDF image triggers assertion in DragController::startDrag()
https://bugs.webkit.org/show_bug.cgi?id=36247

Reviewed by Dmitry Titov.

WebCore:

Test: fast/images/drag-pdf-as-image.html

* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::filenameExtension):
* platform/graphics/cg/PDFDocumentImage.h:

LayoutTests:

* fast/images/drag-pdf-as-image-expected.txt: Added.
* fast/images/drag-pdf-as-image.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-03-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 19 Mar 2010 00:21:26 +0000 (00:21 +0000)]
2010-03-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Avoid taking a reference to a String owned by a temporary AtomicString.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::RareData::parseNth):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand new expected results.
hyatt@apple.com [Fri, 19 Mar 2010 00:17:46 +0000 (00:17 +0000)]
Land new expected results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd missing file from r56186.
mitz@apple.com [Thu, 18 Mar 2010 23:23:09 +0000 (23:23 +0000)]
Add missing file from r56186.

* fast/dynamic/float-remove-above-line-2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChromium interface change to support Blob.slice.
jianli@chromium.org [Thu, 18 Mar 2010 23:03:36 +0000 (23:03 +0000)]
Chromium interface change to support Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=35318

Reviewed by Darin Fisher.

* features.gypi:
* public/WebHTTPBody.h:
* public/WebKitClient.h:
(WebKit::WebKitClient::getFileModificationTime):
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::getFileModificationTime):
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFile):
(WebKit::WebHTTPBody::appendFileRange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56201 268f45cc-cd09-0410-ab3c-d52691b4dbfc