WebKit.git
10 years ago2010-04-05 Chris Jerdonek <cjerdonek@webkit.org>
hamaji@chromium.org [Tue, 6 Apr 2010 03:59:15 +0000 (03:59 +0000)]
2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Fixed check-webkit-style issue where the script was prematurely
        exiting when encountering deleted files in patches.

        https://bugs.webkit.org/show_bug.cgi?id=37122

        * Scripts/webkitpy/style/checker.py:
          - Changed non-existent file message from ERROR to WARN.
          - StyleChecker.check_file() no longer raises an exception when
            a file is not found.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Updated unit tests as necessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Tue, 6 Apr 2010 03:50:46 +0000 (03:50 +0000)]
2010-04-05  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL-specific code to platform/graphics/*.h.
        http://webkit.org/b/36308

        * platform/graphics/Icon.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/IntPoint.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Robert Hogan <robert@webkit.org>
eric@webkit.org [Tue, 6 Apr 2010 03:33:32 +0000 (03:33 +0000)]
2010-04-05  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix infinite redirection loop in QNetworkReplyHandler

        Put a maximum on consecutive redirections so we don't have to
        worry about whether it's the same url or not.

        Tolerate up to 10 consecutive redirections, anything beyond
        that is considered a potentially infinite recursion in the
        redirection requests. This is the same behaviour as Firefox.

        https://bugs.webkit.org/show_bug.cgi?id=37097

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
        * platform/network/qt/QNetworkReplyHandler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Dimitri Glazkov <dglazkov@chromium.org> and James Robinson <jamesr@chrom...
jamesr@google.com [Tue, 6 Apr 2010 03:08:45 +0000 (03:08 +0000)]
2010-04-05  Dimitri Glazkov  <dglazkov@chromium.org> and James Robinson <jamesr@chromium.org>

        Reviewed by Darin Adler and Dimitri Glazkov.

        Style update done due to mutation event dispatching in textarea can be
        used to corrupt the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=36864

        Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
               fast/forms/select-change-popup-to-listbox-roundtrip.html
               fast/forms/textarea-and-mutation-events.html

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing): Added updateStyleIfNeeded()
            call to ensure that object loads start before firing window load.
        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent): Removed invocation of
            Document::updateStyleForAllDocuments
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
            recalc to ensure accuracy of representation, especially for
            menuList/listBox switches.
2010-04-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler

        Style update done due to mutation event dispatching in textarea can be
        used to corrupt the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=36864

        Modified listbox-selection.html to correctly set the size during
        creation. Otherwise, options added to it as a menuList, resulting
        in a default selection of the first item.

        Added a few more tests to ensure we capture correct behavior for
        select elements and their default selection, as well as the influence
        of when layout occurs.

        * fast/forms/listbox-selection.html:
        * fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
        * fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
        * fast/forms/textarea-and-mutation-events.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 6 Apr 2010 03:02:13 +0000 (03:02 +0000)]
2010-04-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        SheriffBot should include blamelist when posting to bugs
        https://bugs.webkit.org/show_bug.cgi?id=37113

        When posting on bugs, we should include the full list of SVN revisions
        that caused the regression to folks have a better sense of whether they
        are to blame.

        * Scripts/webkitpy/tool/bot/sheriff.py:
        * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed after discussion with Adam, Darin, and Eric.
cjerdonek@webkit.org [Tue, 6 Apr 2010 02:32:12 +0000 (02:32 +0000)]
Unreviewed after discussion with Adam, Darin, and Eric.

Deleted the auto-install directory since it is no longer needed in
source control (it is auto-generated).

Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
svn:ignore property.

* Scripts/webkitpy/thirdparty/autoinstalled: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate a test result.
mrowe@apple.com [Tue, 6 Apr 2010 02:24:53 +0000 (02:24 +0000)]
Update a test result.

* platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Tue, 6 Apr 2010 02:03:46 +0000 (02:03 +0000)]
2010-04-05  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Laszlo Gombos.

        Cleaned up spatial-navigation-test-cases.html by removing the wrongly
        used <frameset> tag. Patch also adds a manual-test specifically to
        test Spatial Navigation with framesets.

        * manual-tests/spatial-navigation/frameset.html: Added.
        * manual-tests/spatial-navigation/spatial-navigation-test-cases.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTest case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
mrowe@apple.com [Tue, 6 Apr 2010 01:45:42 +0000 (01:45 +0000)]
Test case for <webkit.org/b/37115> / <rdar://problem/7829331>.
REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI

Reviewed by Adele Peterson.

WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
manually.  This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.

WebKitTools:

Add a JavaScript hook in DRT to call through to WebView's -setEditable:.  This is required in order to reproduce
the crash.

* DumpRenderTree/LayoutTestController.cpp:
(setWebViewEditableCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setWebViewEditable):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setWebViewEditable):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWebViewEditable):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setWebViewEditable):
(LayoutTestController::layerTreeAsText):

LayoutTests:

* platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Added.
* platform/mac/editing/deleting/deletionUI-successful-deletion.html: Added.
* platform/mac/editing/deleting/resources/deletionUI-helpers.js:
(deletionUIDeleteButtonForElement):
(determineDeletionUIExistence):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r56989 as it introduced crashes in Mail.
mrowe@apple.com [Tue, 6 Apr 2010 01:45:31 +0000 (01:45 +0000)]
Roll out r56989 as it introduced crashes in Mail.
<http://webkit.org/b/37115> / <rdar://problem/7829331>

Reviewed by Adele Peterson.

* dom/Position.cpp:
(WebCore::Position::isCandidate):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImages must re-load when an image-holding element moves into a new document
darin@apple.com [Tue, 6 Apr 2010 01:38:15 +0000 (01:38 +0000)]
Images must re-load when an image-holding element moves into a new document
https://bugs.webkit.org/show_bug.cgi?id=37127

Reviewed by Sam Weinig.

WebCore:

Test: fast/images/move-image-to-new-document.html

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willMoveToNewOwnerDocument): Call ImageLoader's
elementWillMoveToNewOwnerDocument function.
* html/HTMLImageElement.h: Added willMoveToNewOwnerDocument.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Ditto.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): Ditto.
* html/HTMLPlugInImageElement.h: Ditto.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::willMoveToNewOwnerDocument): Ditto.
* html/HTMLVideoElement.h: Ditto.
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::willMoveToNewOwnerDocument): Ditto.
* svg/SVGImageElement.h: Ditto.

* html/HTMLMediaElement.h: Made willMoveToNewOwnerDocument protected
so it can be called by HTMLVideoElement.cpp.

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::elementWillMoveToNewOwnerDocument): Added.
Resets the loader by clearing out the cached image.
* loader/ImageLoader.h: Added it.

LayoutTests:

* fast/images/move-image-to-new-document-expected.txt: Added.
* fast/images/move-image-to-new-document.html: Added.
* fast/images/script-tests/move-image-to-new-document.js: Added.

* fast/js/resources/js-test-post.js: Added a feature for doing asynchronous scripting
tests. The caller sets jsTestIsAsync to true and then calls finishJSTest when done.
Used by the above test.

* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
Updated since the old test result relied on an incorrect load of an image.
The relative URL has a different base when moved into the subframe document.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 6 Apr 2010 00:55:17 +0000 (00:55 +0000)]
2010-04-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Symbian] Consolidate Symbian WINSCW environment configuration
        https://bugs.webkit.org/show_bug.cgi?id=37100

        Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
        to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

        PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
        undefining WIN32 takes care of it.

        * wtf/Platform.h:
2010-04-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Symbian] Consolidate Symbian WINSCW environment configuration
        https://bugs.webkit.org/show_bug.cgi?id=37100

        Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
        to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

        No new tests as there is no new functionality.

        * config.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Tue, 6 Apr 2010 00:34:32 +0000 (00:34 +0000)]
2010-04-05  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add missing ClipboardEfl.h to platform/efl.
        http://webkit.org/b/36242

        * platform/efl/ClipboardEfl.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Tue, 6 Apr 2010 00:18:33 +0000 (00:18 +0000)]
2010-04-05  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Adler.

        A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
        https://bugs.webkit.org/show_bug.cgi?id=37077
        https://bugs.webkit.org/show_bug.cgi?id=37098

        * fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
        * fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
        * fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
        * fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
        * fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
        * fast/canvas/webgl/index-validation-copies-indices.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Yuta Kitamura <yutak@chromium.org>
eric@webkit.org [Tue, 6 Apr 2010 00:08:34 +0000 (00:08 +0000)]
2010-04-05  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Darin Adler.

        Escape control characters in CSS string value when it is serialilzed.

        When WebKit serializes a CSS string value that contains binary characters
        ('\0\1\2' for example), it did not escape these characters. As a result,
        users got (invisible) control characters through scripts. This change fixes
        this issue.

        As a side effect, two separate codes for escaping CSS strings are merged, and
        become a public function (quoteCSSString).

        CSS string value is not correctly serialized when it contains binary characters
        https://bugs.webkit.org/show_bug.cgi?id=28938

        * fast/css/script-tests/string-quote-binary.js: Added.
        * fast/css/string-quote-binary-expected.txt: Added.
        * fast/css/string-quote-binary.html: Added.
        * fast/js/resources/js-test-pre.js:
        (shouldBeEqualToString): Considering the case when the argument contains binary characters.
2010-04-05  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Darin Adler.

        Escape control characters in CSS string value when it is serialilzed.

        When WebKit serializes a CSS string value that contains binary characters
        ('\0\1\2' for example), it did not escape these characters. As a result,
        users got (invisible) control characters through scripts. This change fixes
        this issue.

        As a side effect, two separate codes for escaping CSS strings are merged, and
        become a public function (quoteCSSString).

        CSS string value is not correctly serialized when it contains binary characters
        https://bugs.webkit.org/show_bug.cgi?id=28938

        Test: fast/css/string-quote-binary.html

        * css/CSSParser.cpp:
        (WebCore::isCSSTokenizerIdentifier):
        (WebCore::isCSSTokenizerURL):
        (WebCore::quoteCSSString):
        (WebCore::quoteCSSStringIfNeeded):
        (WebCore::quoteCSSURLIfNeeded):
        * css/CSSParser.h:
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):
        * css/FontFamilyValue.cpp:
        (WebCore::FontFamilyValue::cssText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated the ignore property for changes to the contents here.
darin@apple.com [Tue, 6 Apr 2010 00:06:28 +0000 (00:06 +0000)]
Updated the ignore property for changes to the contents here.

* .: Modified property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 John Gregg <johnnyg@google.com>
eric@webkit.org [Mon, 5 Apr 2010 23:54:56 +0000 (23:54 +0000)]
2010-04-05  John Gregg  <johnnyg@google.com>

        Reviewed by Darin Adler.

        Notifications should not resolve an empty icon parameter as a relative URL
        https://bugs.webkit.org/show_bug.cgi?id=36862

        * fast/notifications/notifications-no-icon-expected.txt: Added.
        * fast/notifications/notifications-no-icon.html-disabled: Added.
2010-04-05  John Gregg  <johnnyg@google.com>

        Reviewed by Darin Adler.

        Notifications should not resolve an empty icon parameter as a relative URL
        https://bugs.webkit.org/show_bug.cgi?id=36862

        * notifications/Notification.cpp:
        (WebCore::Notification::Notification):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIgnore more files the Python tools strew about the working directory.
darin@apple.com [Mon, 5 Apr 2010 23:40:35 +0000 (23:40 +0000)]
Ignore more files the Python tools strew about the working directory.

* Scripts/webkitpy: Added property svn:ignore.
* Scripts/webkitpy/common: Added property svn:ignore.
* Scripts/webkitpy/common/checkout: Added property svn:ignore.
* Scripts/webkitpy/common/config: Added property svn:ignore.
* Scripts/webkitpy/common/net: Added property svn:ignore.
* Scripts/webkitpy/common/thread: Added property svn:ignore.
* Scripts/webkitpy/python24: Added property svn:ignore.
* Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
* Scripts/webkitpy/tool/bot: Added property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved some unneeded type casts.
darin@apple.com [Mon, 5 Apr 2010 23:19:02 +0000 (23:19 +0000)]
Removed some unneeded type casts.

Reviewed by Mark Rowe.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText): Removed an unneeded cast.
* page/Location.cpp:
(WebCore::Location::host): Removed unneeded parentheses and cast.
(WebCore::Location::port): Ditto.
* platform/KURLGoogle.cpp:
(WebCore::KURL::setPort): Ditto.
* workers/WorkerLocation.cpp:
(WebCore::WorkerLocation::host): Ditto.
(WebCore::WorkerLocation::port): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Mon, 5 Apr 2010 23:07:32 +0000 (23:07 +0000)]
2010-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57081.
        http://trac.webkit.org/changeset/57081
        https://bugs.webkit.org/show_bug.cgi?id=37121

        We think it triggered two tests to fail on Tiger because of
        race conditions (Requested by abarth on #webkit).

        * fast/forms/listbox-selection.html:
        * fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
        * fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
        * fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
        * fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
        * fast/forms/textarea-and-mutation-events-expected.txt: Removed.
        * fast/forms/textarea-and-mutation-events.html: Removed.
2010-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57081.
        http://trac.webkit.org/changeset/57081
        https://bugs.webkit.org/show_bug.cgi?id=37121

        We think it triggered two tests to fail on Tiger because of
        race conditions (Requested by abarth on #webkit).

        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
beidson@apple.com [Mon, 5 Apr 2010 22:57:06 +0000 (22:57 +0000)]
ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
<rdar://problem/7828420> and https://bugs.webkit.org/show_bug.cgi?id=37120

Reviewed by Oliver Hunt.

No new tests. (No behavior change)

* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::close): Change this invalid ASSERT to an early return.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Updated expected pixel results for missing plug-in, now using text placeholder.
ap@apple.com [Mon, 5 Apr 2010 22:39:52 +0000 (22:39 +0000)]
    Updated expected pixel results for missing plug-in, now using text placeholder.

        * platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
        * platform/mac/plugins/qt-qwidget-plugin-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
yael.aharon@nokia.com [Mon, 5 Apr 2010 22:03:37 +0000 (22:03 +0000)]
Unreviewed.
Separate test results for windows platform because progress element is not implemented for that platform yet.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Added.
* platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
* platform/win/fast/dom/prototype-inheritance-expected.txt: Added.
* platform/win/fast/js: Added.
* platform/win/fast/js/global-constructors-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Mon, 5 Apr 2010 21:52:09 +0000 (21:52 +0000)]
2010-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r57030.
        http://trac.webkit.org/changeset/57030
        https://bugs.webkit.org/show_bug.cgi?id=37114

        Regressed fast/repaint/line-flow-with-floats-9 pixel tests in
        chromium port (Requested by jamesr on #webkit).

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 5 Apr 2010 21:49:05 +0000 (21:49 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=37111
        <rdar://problem/7790327> Draw replacement text when plug-in host crashes

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
cfleizach@apple.com [Mon, 5 Apr 2010 21:16:51 +0000 (21:16 +0000)]
Unreviewed.

Bug 37112 - aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112

Disabling this test on Leopard until further investigation can reveal the answer.
It looks like at this point, any new test added will cause this test to fail on Leopard
release bot, even if it has nothing to do with live regions.

* platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Bug 37040 - AX: need to send selected children change notification when...
cfleizach@apple.com [Mon, 5 Apr 2010 20:41:38 +0000 (20:41 +0000)]
WebCore: Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

When aria-selected is changed in the DOM, it will trigger a selected children change notification.

Test: platform/mac/accessibility/aria-listbox-selectedchildren-change.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::selectedChildrenChanged):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlType):
    Remove extra whitespace before comment (webkit-style).
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::observableObject):
    Allowed a listBox to be an observable object.
(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
    Updated and streamlined existing code.
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):

LayoutTests: Tests for
Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

* platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt: Added.
* platform/mac/accessibility/aria-listbox-selectedchildren-change.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
yael.aharon@nokia.com [Mon, 5 Apr 2010 20:38:57 +0000 (20:38 +0000)]
Unreviewed.
Separate test results for gtk platform because progress element is not implemented for that platform yet.

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
* platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
* platform/gtk/fast/js: Added.
* platform/gtk/fast/js/global-constructors-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Adam Barth <abarth@webkit.org>
ojan@chromium.org [Mon, 5 Apr 2010 19:55:14 +0000 (19:55 +0000)]
2010-04-05  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Add Vitaly Repeshko as a committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 5 Apr 2010 19:33:30 +0000 (19:33 +0000)]
2010-04-05  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Add Vitaly Repeshko as a committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix regression in pixel test for animated svg background images.
treat@webkit.org [Mon, 5 Apr 2010 19:27:48 +0000 (19:27 +0000)]
Fix regression in pixel test for animated svg background images.

Patch by Adam Treat <atreat@rim.com> on 2010-04-05
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37027

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 5 Apr 2010 18:30:36 +0000 (18:30 +0000)]
2010-04-05  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Update kenne's IRC nick to his registered nick.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 5 Apr 2010 18:27:32 +0000 (18:27 +0000)]
2010-04-05  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Update expected results for addition of HTMLProgressElement.  We didn't
        see these errors until later because our dependencies are screwed up.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed layout test fix.
kenneth@webkit.org [Mon, 5 Apr 2010 18:24:29 +0000 (18:24 +0000)]
Unreviewed layout test fix.

Update mac results for iframe flattening.

* platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
* platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
* platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
* platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 5 Apr 2010 17:57:00 +0000 (17:57 +0000)]
2010-04-05  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde-Christiansen.

        [Qt] Fix infinite redirection loop in QNetworkReplyHandler

        Qt enters an infinite loop if a redirect response redirects to itself.

        Fixes http/tests/xmlhttprequest/connection-error-sync.html

        https://bugs.webkit.org/show_bug.cgi?id=37097

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2010-04-05  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde-Christiansen.

        [Qt] Fix infinite redirection loop in QNetworkReplyHandler

        Unskip http/tests/xmlhttprequest/connection-error-sync.html

        https://bugs.webkit.org/show_bug.cgi?id=37097

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 5 Apr 2010 17:55:14 +0000 (17:55 +0000)]
2010-04-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        prepare-ChangeLog should take a merge-base for which git branch to diff against.
        https://bugs.webkit.org/show_bug.cgi?id=36394

        * Scripts/prepare-ChangeLog:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed layout test fix.
kenneth@webkit.org [Mon, 5 Apr 2010 17:36:35 +0000 (17:36 +0000)]
Unreviewed layout test fix.

Update Qt results for iframe flattening.

* platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
* platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
* platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
* platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 5 Apr 2010 17:35:16 +0000 (17:35 +0000)]
2010-04-05  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, revert r57078.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 5 Apr 2010 17:27:18 +0000 (17:27 +0000)]
2010-04-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Style update done due to mutation event dispatching in textarea can be
        used to corrupt the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=36864

        Modified listbox-selection.html to correctly set the size during
        creation. Otherwise, options added to it as a menuList, resulting
        in a default selection of the first item.

        Added a few more tests to ensure we capture correct behavior for
        select elements and their default selection, as well as the influence
        of when layout occurs.

        * fast/forms/listbox-selection.html:
        * fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
        * fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
        * fast/forms/textarea-and-mutation-events.html: Added.
2010-04-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Style update done due to mutation event dispatching in textarea can be
        used to corrupt the render tree.
        https://bugs.webkit.org/show_bug.cgi?id=36864

        Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html
               fast/forms/select-change-popup-to-listbox-roundtrip.html
               fast/forms/textarea-and-mutation-events.html

        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent): Removed invocation of
            Document::updateStyleForAllDocuments
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit
            recalc to ensure accuracy of representation, especially for
            menuList/listBox switches.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoiframe flattening doesn't flatten
kenneth@webkit.org [Mon, 5 Apr 2010 17:18:12 +0000 (17:18 +0000)]
iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

Reviewed by Dave Hyatt.

Fixed to the iframe flattening code so that the iframes on
http://www.samisite.com/test-csb2nf/id43.htm are actually
flattened.

Covered by current tests.

* page/FrameView.cpp: Propagate contents changes of iframes
and subframes in framesets to the parent so that it is relayouted
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scheduleRelayout):
* rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from
HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
the use of inset border values. Avoid a sometimes unnecessary
relayout.
(WebCore::RenderPart::layoutWithFlattening):
* rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth
return the right values, considering scrolling and fixed width/height
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Mon, 5 Apr 2010 17:06:08 +0000 (17:06 +0000)]
2010-04-05  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Yury Semikhatsky.

        [V8] Extend the set of types supported by SerializedScriptValue
        https://bugs.webkit.org/show_bug.cgi?id=37052

        New types include sparse arrays, Uint32, Date, and ImageData.

        Serialization process became more flexible. A state can either
        directly write primitive values (instead of returning them like
        iterator) or construct a new state for serializing complex values
        that will return to the current state when done.

        Deserialization process now avoids exposing the tags using a set
        of factory functions for complex objects instead.

        Internal buffer type changed to uint8_t to be independent of
        whether char is signed or not.

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::):
        (WebCore::Writer::Writer):
        (WebCore::Writer::writeString):
        (WebCore::Writer::writeUint32):
        (WebCore::Writer::writeDate):
        (WebCore::Writer::writeNumber):
        (WebCore::Writer::writeImageData):
        (WebCore::Writer::writeArray):
        (WebCore::Writer::writeObject):
        (WebCore::Writer::writeSparseArray):
        (WebCore::Writer::doWriteUint32):
        (WebCore::Writer::doWriteNumber):
        (WebCore::Writer::append):
        (WebCore::Writer::fillHole):
        (WebCore::Writer::byteAt):
        (WebCore::Serializer::Serializer):
        (WebCore::Serializer::serialize):
        (WebCore::Serializer::writeArray):
        (WebCore::Serializer::writeObject):
        (WebCore::Serializer::writeSparseArray):
        (WebCore::Serializer::StateBase::StateBase):
        (WebCore::Serializer::ErrorState::ErrorState):
        (WebCore::Serializer::ErrorState::advance):
        (WebCore::Serializer::State::composite):
        (WebCore::Serializer::State::State):
        (WebCore::Serializer::ArrayState::ArrayState):
        (WebCore::Serializer::ArrayState::advance):
        (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
        (WebCore::Serializer::AbstractObjectState::advance):
        (WebCore::Serializer::ObjectState::ObjectState):
        (WebCore::Serializer::ObjectState::objectDone):
        (WebCore::Serializer::SparseArrayState::SparseArrayState):
        (WebCore::Serializer::SparseArrayState::objectDone):
        (WebCore::Serializer::push):
        (WebCore::Serializer::pop):
        (WebCore::Serializer::handleError):
        (WebCore::Serializer::checkComposite):
        (WebCore::Serializer::writeString):
        (WebCore::Serializer::writeImageData):
        (WebCore::Serializer::newArrayState):
        (WebCore::Serializer::newObjectState):
        (WebCore::Serializer::doSerialize):
        (WebCore::Reader::Reader):
        (WebCore::Reader::read):
        (WebCore::Reader::readString):
        (WebCore::Reader::readUint32):
        (WebCore::Reader::readDate):
        (WebCore::Reader::readNumber):
        (WebCore::Reader::readImageData):
        (WebCore::Reader::doReadUint32):
        (WebCore::Reader::doReadNumber):
        (WebCore::Deserializer::Deserializer):
        (WebCore::Deserializer::createArray):
        (WebCore::Deserializer::createObject):
        (WebCore::Deserializer::createSparseArray):
        (WebCore::Deserializer::initializeObject):
        (WebCore::Deserializer::doDeserialize):
        (WebCore::Deserializer::stackDepth):
        (WebCore::SerializedScriptValue::deserialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 5 Apr 2010 17:00:02 +0000 (17:00 +0000)]
2010-04-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Refactored error reporting mechanizm on Worker Global Objects.
        Unlike other event listeners which accept single argument(Event)
        onerror handler on worker global object should be a function
        accepting three arguments. This error reporting was implementedas
        EventListener::reportError method which had custom implementations
        for v8 and JSC. This patch removes EventListener::reportError and
        moves its functionality into custom bindings(V8WorkerContextErrorHandler
        and JSWorkerContextErrorHandler) that implement EventListener inerface
        for the onerror handler.

        This patch also makes uncaught exceptions that happen in the onerror
        listener be reported to the Worker's onerror handler.

        https://bugs.webkit.org/show_bug.cgi?id=36375

        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSEventListener.h:
        * bindings/js/JSWorkerContextErrorHandler.cpp: Added.
        (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler):
        (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler):
        (WebCore::JSWorkerContextErrorHandler::handleEvent):
        * bindings/js/JSWorkerContextErrorHandler.h: Added.
        (WebCore::JSWorkerContextErrorHandler::create):
        (WebCore::createJSWorkerContextErrorHandler):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8WorkerContextErrorHandler.cpp: Added.
        (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler):
        (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
        * bindings/v8/V8WorkerContextErrorHandler.h: Added.
        (WebCore::V8WorkerContextErrorHandler::create):
        * bindings/v8/V8WorkerContextEventListener.cpp:
        * bindings/v8/V8WorkerContextEventListener.h:
        * dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        (WebCore::WorkerContext::reportException):

2010-04-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Test that exception which occurs in onerror handler is reported to the Worker object.

        https://bugs.webkit.org/show_bug.cgi?id=36375

        * fast/workers/worker-script-error-expected.txt:
        * fast/workers/worker-script-error.html:
        * workers/WorkerContext.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix some "explicit braces to avoid ambiguous 'else'" warnings
tonikitoo@webkit.org [Mon, 5 Apr 2010 15:53:16 +0000 (15:53 +0000)]
Fix some "explicit braces to avoid ambiguous 'else'" warnings
https://bugs.webkit.org/show_bug.cgi?id=37088

Reviewed by Darin Adler.
Patch by Antonio Gomes (tonikitoo@webkit.org)

* dom/Node.cpp:
(WebCore::Node::dispatchGenericEvent):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 5 Apr 2010 14:28:27 +0000 (14:28 +0000)]
2010-04-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC

        Instead of defining and undefining it later, let's not
        define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.

        No new tests as there is no new functionality.

        * config.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 5 Apr 2010 14:12:07 +0000 (14:12 +0000)]
2010-04-05  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Kenneth-Rohde Christiansen.

        re-login.html and re-login-async.html are now tracked in bugzilla.

        https://bugs.webkit.org/show_bug.cgi?id=37084

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 5 Apr 2010 13:47:35 +0000 (13:47 +0000)]
2010-04-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [Symbian] Remove obsolete build flags for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=37083

        Symbian port of QtWebKit port does not use icu, so it does
        not need U_HAVE_* defines.

        Symbian now has inttypes.h as part of OpenC.

        stdio.h, limits.h and MathExtras.h are already included in
        more appropriate locations.

        No new tests as there is no new functionality.

        * config.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Apr 2010 12:48:45 +0000 (12:48 +0000)]
2010-04-05  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium build fix.

        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::platformCallback):
        (WebCore::V8InspectorFrontendHost::portCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Lucas Lommer <llommer@svn.gnome.org>
kov@webkit.org [Mon, 5 Apr 2010 12:48:44 +0000 (12:48 +0000)]
2010-04-05  Lucas Lommer  <llommer@svn.gnome.org>

        Reviewed by Gustavo Noronha.

        Czech translation for WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=36879

        * cs.po: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Christian Kirbach <Christian.Kirbach@googlemail.com>
kov@webkit.org [Mon, 5 Apr 2010 12:44:50 +0000 (12:44 +0000)]
2010-04-05  Christian Kirbach  <Christian.Kirbach@googlemail.com>

        Reviewed by Gustavo Noronha.

        Updated German translation
        https://bugs.webkit.org/show_bug.cgi?id=36453

        * de.po:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Luca Ferretti <elle.uca@libero.it>
kov@webkit.org [Mon, 5 Apr 2010 12:38:55 +0000 (12:38 +0000)]
2010-04-05  Luca Ferretti  <elle.uca@libero.it>

        Reviewed by Gustavo Noronha.

        Italian translation for 1.1.90
        https://bugs.webkit.org/show_bug.cgi?id=36323

        * it.po:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Apr 2010 12:37:52 +0000 (12:37 +0000)]
2010-04-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] platform detection in Chromium
        has regressed to unknown.

        https://bugs.webkit.org/show_bug.cgi?id=37081

        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        (WebCore::JSInspectorFrontendHost::platform):
        (WebCore::JSInspectorFrontendHost::port):
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::platform):
        (WebCore::V8InspectorFrontendHost::port):
        * inspector/InspectorFrontendHost.cpp:
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Andrey Kosyakov <caseq@chromium.org>
eric@webkit.org [Mon, 5 Apr 2010 11:59:01 +0000 (11:59 +0000)]
2010-04-05  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Remove logging of successful XHR and worker's importScript()
        to inspector console
        https://bugs.webkit.org/show_bug.cgi?id=37078

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::importScripts):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::V8WorkerContext::importScriptsCallback):
        * workers/DedicatedWorkerContext.cpp:
        (WebCore::DedicatedWorkerContext::importScripts):
        * workers/DedicatedWorkerContext.h:
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::importScripts):
        * workers/WorkerContext.h:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Apr 2010 09:27:25 +0000 (09:27 +0000)]
2010-04-05  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium test expectations update for the roll.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Mon, 5 Apr 2010 07:41:03 +0000 (07:41 +0000)]
2010-04-05  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Removed the PatchStyleErrorHandler class and incorporated its
        functionality into the DefaultStyleErrorHandler class.

        https://bugs.webkit.org/show_bug.cgi?id=37067

        * Scripts/webkitpy/style/checker.py:
          - In the StyleChecker class:
            - Added a line_number parameter to the check_file() method.
            - Renamed the handle_style_error parameter to
              mock_handle_style_error to be consistent with the other mock_*
              parameter names.
            - Added a mock_check_file parameter to the check_patch() method
              to facilitate unit testing the changes in this patch.
            - Rewrote the check_patch() method with the patch-parsing logic
              taken from the PatchStyleErrorHandler class.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Added a StyleCheckerCheckFileBase class and sub-classed the
            existing StyleCheckerCheckFileTest class from it.
          - Added a StyleCheckerCheckPatchTest class to unit-test the
            rewritten check_patch() method.
          - Removed the vestigial __main__ code at the bottom of the file.
            This is left over from when check-webkit-style was implemented
            as a module and a wrapper module.

        * Scripts/webkitpy/style/error_handlers.py:
          - Added an optional line_numbers parameter to the
            DefaultStyleErrorHandler class constructor and adjusted the
            __call__() method as necessary.
          - Removed the PatchStyleErrorHandler class.

        * Scripts/webkitpy/style/error_handlers_unittest.py:
          - Removed the PatchStyleErrorHandlerTest class which unit-tested
            the PatchStyleErrorHandler class which is being removed in this
            patch.
          - Added a test_line_numbers() test method to the
            DefaultStyleErrorHandlerTest class to test use of the
            DefaultStyleErrorHandler's new line_numbers attribute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 5 Apr 2010 07:24:43 +0000 (07:24 +0000)]
2010-04-05  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Tighten SheriffBot's flaky test detector
        https://bugs.webkit.org/show_bug.cgi?id=37063

        Instead of just looking for two sequential red builds, look for two
        sequential failures of the same test.  This should reduce sheriffbot
        false positive substantially.

        I'm landing this change unreviewed because I've noticed SheriffBot
        triggering a lot more false positives now that we've expanded the set
        of core builders.  I've tried to take Eric's comments on Bug 37063 into
        account.  I'm happy to iterate on this patch tomorrow once Eric wakes
        up.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:
        * Scripts/webkitpy/tool/commands/queries.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Apr 2010 06:30:04 +0000 (06:30 +0000)]
2010-04-04  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out chromium changes r57028 and r57032
        for breaking chromium layout tests.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/DragImageChromium.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageChromiumMac.cpp: Removed.
        * platform/chromium/DragImageChromiumSkia.cpp: Removed.
        * platform/chromium/DragImageRef.h:

        WebKit/chromium:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::startDragging):
        * src/DragClientImpl.cpp:
        (WebKit::DragClientImpl::startDrag):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::startDragging):
        * src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-04 John Gregg <johnnyg@google.com>
johnnyg@google.com [Mon, 5 Apr 2010 02:28:48 +0000 (02:28 +0000)]
2010-04-04  John Gregg  <johnnyg@google.com>

        Unreviewed, add myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed expected results fix.
tonikitoo@webkit.org [Mon, 5 Apr 2010 02:11:31 +0000 (02:11 +0000)]
Unreviewed expected results fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>

The implementation was fixed, and results were no longer valid.

* fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
* fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Mon, 5 Apr 2010 02:10:56 +0000 (02:10 +0000)]
2010-03-29  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Simon Fraser.
        Patch by Antonio Gomes <tonikitoo@webkit.org>

        Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp

        WebCore::distanceInDirection method was handling much of the logic not
        strictly only related to the distance between nodes acquisition. This
        method was simplified and renamed to 'WebCore::distanceDataForNode'.
        The latter is now responsible for only getting the distance and alignment
        data, while all assignement logic previously in distanceInDirection method
        was moved place to updateFocusCandidateIfCloser.

        Parent document distance and alignment acquisitions, in turn, have also
        changed location: they are both got from deepFindFocusableNodeInDirection,
        and passed in a recursive call to findFocusableNodeInDirection via the
        candidateParent variable (optional parameter). In addition, the need for
        the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
        was removed, making the code much cleaner.

        No behaviour change at this point. Mostly moving code around to the place
        where it should live in.

        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusDirectionally):
        (WebCore::updateFocusCandidateIfCloser):
        (WebCore::FocusController::findFocusableNodeInDirection):
        (WebCore::FocusController::deepFindFocusableNodeInDirection):
        * page/FocusController.h:
        * page/SpatialNavigation.cpp:
        (WebCore::distanceDataForNode):
        (WebCore::renderRectRelativeToRootDocument):
        * page/SpatialNavigation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-04 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Sun, 4 Apr 2010 22:18:38 +0000 (22:18 +0000)]
2010-04-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.

        https://bugs.webkit.org/show_bug.cgi?id=37072

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 4 Apr 2010 22:00:37 +0000 (22:00 +0000)]
2010-04-04  Pavel Feldman  <pfeldman@chromium.org>

        (Not reviewed).

        Adding images for inspector blog post. Previewed by Timothy Hatcher.

        * blog-files/inspector/audits_launcher.png: Added.
        * blog-files/inspector/audits_panel.png: Added.
        * blog-files/inspector/console_panel.png: Added.
        * blog-files/inspector/context_menu.png: Added.
        * blog-files/inspector/css_highlighted_line.png: Added.
        * blog-files/inspector/css_line_number_snippet.png: Added.
        * blog-files/inspector/css_line_numbers.png: Added.
        * blog-files/inspector/deactivate_breakpoints.png: Added.
        * blog-files/inspector/evaluate_on_hover.png: Added.
        * blog-files/inspector/evaluate_on_hover_2.png: Added.
        * blog-files/inspector/inherited_styles.png: Added.
        * blog-files/inspector/large_dom.png: Added.
        * blog-files/inspector/large_resources.png: Added.
        * blog-files/inspector/pseudo_elements.png: Added.
        * blog-files/inspector/redirect_headers.png: Added.
        * blog-files/inspector/redirect_headers_full.png: Added.
        * blog-files/inspector/redirects.png: Added.
        * blog-files/inspector/redirects_full.png: Added.
        * blog-files/inspector/timeline_overview.png: Added.
        * blog-files/inspector/timeline_panel.png: Added.
        * blog-files/inspector/timeline_record_details.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-04 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 4 Apr 2010 11:52:16 +0000 (11:52 +0000)]
2010-04-04  Robert Hogan  <robert@webkit.org>

        Unreviewed, add myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, adding my IRC nickname to committers.py
dumi@chromium.org [Sun, 4 Apr 2010 08:53:58 +0000 (08:53 +0000)]
Unreviewed, adding my IRC nickname to committers.py

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-04 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Sun, 4 Apr 2010 08:26:22 +0000 (08:26 +0000)]
2010-04-04  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Refactored check-webkit-style's option-parsing code.

        https://bugs.webkit.org/show_bug.cgi?id=37064

        * Scripts/check-webkit-style:
          - Moved the "WebKit checkout not found" check from
            ArgumentParser.parse() to the calling code.
          - Moved the --git-commit argument validation from the calling
            code to ArgumentParser.parse().

        * Scripts/webkitpy/style/checker_unittest.py:
          - Updated a unit test as necessary.

        * Scripts/webkitpy/style/optparser.py:
          - Renamed ArgumentParser._exit_with_help() to _parse_error()
            and made its error_message parameter required.
          - Removed the found_checkout parameter from ArgumentParser.parse().
          - Removed the "WebKit checkout not found" check and moved it
            to the calling code.
          - Added --git-commit argument checking.

        * Scripts/webkitpy/style/optparser_unittest.py:
          - Adjusted the import statements to be fully qualified.
          - Changed the ArgumentParserTest class to inherit from
            LoggingTestCase, and updated the class as necessary.
          - Added a unit-test for the --git-commit validation.
          - Added unit tests for the --git-diff and --git-since variants
            of --git-commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=37068
barraclough@apple.com [Sun, 4 Apr 2010 06:53:46 +0000 (06:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37068
Change UString to use a 0 rep for null strings instead of a null object.

Reviewed by Oliver Hunt.

No performance impact.

* JavaScriptCore.exp:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
* runtime/UString.cpp:
(JSC::initializeUString):
* runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::cost):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 Balazs Kelemen <kb@inf.u-szeged.hu>
eric@webkit.org [Sun, 4 Apr 2010 01:17:12 +0000 (01:17 +0000)]
2010-04-03  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Oliver Hunt.

        Fix uninitalised members in CallLinkInfo and BytecodeGenerator.

        https://bugs.webkit.org/show_bug.cgi?id=36816

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::CodeBlock):
        * bytecode/CodeBlock.h:
        (JSC::CallLinkInfo::CallLinkInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Sat, 3 Apr 2010 18:59:19 +0000 (18:59 +0000)]
2010-04-03  Jakub Wieczorek  <jwieczorek@webkit.org>

        Unreviewed.

        [Qt] Skip five XMLHttpRequest tests that are timing out.

        * platform/qt/Skipped: Add a comment on why they are failing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Sat, 3 Apr 2010 17:40:39 +0000 (17:40 +0000)]
2010-04-03  Jakub Wieczorek  <jwieczorek@webkit.org>

        Rubber-stamped by Daniel Bates.

        Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
        failure on the Qt and GTK+ ports.

        Refactor it to not hardcode any metrics (in order to dispatch mouse events)
        but instead calculate them from the offset* properties.

        * fast/events/popup-allowed-from-gesture-initiated-event.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 yael aharon <yael.aharon@nokia.com>
eric@webkit.org [Sat, 3 Apr 2010 17:27:26 +0000 (17:27 +0000)]
2010-04-03  yael aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        Enable HTMLProgressElement for Safari on OSX
        https://bugs.webkit.org/show_bug.cgi?id=36961

        * Configurations/FeatureDefines.xcconfig:
2010-04-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
        https://bugs.webkit.org/show_bug.cgi?id=36574

        Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
        points causing them to throw exceptions rather than synthesize GL
        errors. Fixed the implementations to synthesize INVALID_VALUE
        rather than INVALID_OPERATION to comply to the WebGL spec. Updated
        uniform-location-expected.txt to incorporate the correct error.
        Tested in Safari and Chromium.

        * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
        * fast/canvas/webgl/null-uniform-location.html: Added.
        * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
        (callUniformFunction):
        * fast/canvas/webgl/uniform-location-expected.txt:
2010-04-03  yael aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        Enable HTMLProgressElement for Safari on OSX
        https://bugs.webkit.org/show_bug.cgi?id=36961

        * Configurations/FeatureDefines.xcconfig:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
        (WebCore::RenderThemeMac::animationDurationForProgressBar):
        (WebCore::RenderThemeMac::adjustProgressBarStyle):
        (WebCore::RenderThemeMac::paintProgressBar):
2010-04-03  yael aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        Enable HTMLProgressElement for Safari on OSX
        https://bugs.webkit.org/show_bug.cgi?id=36961

        * Configurations/FeatureDefines.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>
jwieczorek@webkit.org [Sat, 3 Apr 2010 14:34:09 +0000 (14:34 +0000)]
2010-04-03  Jakub Wieczorek  <jwieczorek@webkit.org>

        Unreviewed.

        Fix debug build with GCC >= 4.3.

        * platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 Kenneth Russell <kbr@google.com>
eric@webkit.org [Sat, 3 Apr 2010 07:49:17 +0000 (07:49 +0000)]
2010-04-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
        https://bugs.webkit.org/show_bug.cgi?id=36574

        Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
        points causing them to throw exceptions rather than synthesize GL
        errors. Fixed the implementations to synthesize INVALID_VALUE
        rather than INVALID_OPERATION to comply to the WebGL spec. Updated
        uniform-location-expected.txt to incorporate the correct error.
        Tested in Safari and Chromium.

        * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
        * fast/canvas/webgl/null-uniform-location.html: Added.
        * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
        (callUniformFunction):
        * fast/canvas/webgl/uniform-location-expected.txt:
2010-04-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
        https://bugs.webkit.org/show_bug.cgi?id=36574

        Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
        points causing them to throw exceptions rather than synthesize GL
        errors. Fixed the implementations to synthesize INVALID_VALUE
        rather than INVALID_OPERATION to comply to the WebGL spec. Updated
        uniform-location-expected.txt to incorporate the correct error.
        Tested in Safari and Chromium.

        Test: fast/canvas/webgl/null-uniform-location.html

        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::V8WebGLRenderingContext::getUniformCallback):
        (WebCore::vertexAttribAndUniformHelperf):
        (WebCore::uniformHelperi):
        (WebCore::uniformMatrixHelper):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::uniform1f):
        (WebCore::WebGLRenderingContext::uniform1fv):
        (WebCore::WebGLRenderingContext::uniform1i):
        (WebCore::WebGLRenderingContext::uniform1iv):
        (WebCore::WebGLRenderingContext::uniform2f):
        (WebCore::WebGLRenderingContext::uniform2fv):
        (WebCore::WebGLRenderingContext::uniform2i):
        (WebCore::WebGLRenderingContext::uniform2iv):
        (WebCore::WebGLRenderingContext::uniform3f):
        (WebCore::WebGLRenderingContext::uniform3fv):
        (WebCore::WebGLRenderingContext::uniform3i):
        (WebCore::WebGLRenderingContext::uniform3iv):
        (WebCore::WebGLRenderingContext::uniform4f):
        (WebCore::WebGLRenderingContext::uniform4fv):
        (WebCore::WebGLRenderingContext::uniform4i):
        (WebCore::WebGLRenderingContext::uniform4iv):
        (WebCore::WebGLRenderingContext::uniformMatrix2fv):
        (WebCore::WebGLRenderingContext::uniformMatrix3fv):
        (WebCore::WebGLRenderingContext::uniformMatrix4fv):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe check-webkit-style script now logs an ERROR and exits when
cjerdonek@webkit.org [Sat, 3 Apr 2010 07:46:05 +0000 (07:46 +0000)]
The check-webkit-style script now logs an ERROR and exits when
encountering a file path that does not exist.  Previously, it failed
silently on such paths.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36957

* Scripts/webkitpy/common/system/logtesting.py:
  - Added a FIXME to rename the LoggingTestCase class to
    LoggingTestCaseBase.

* Scripts/webkitpy/style/checker.py:
  - In the StyleChecker.check_file() method:
    - Added a mock_os_path_exists parameter.
    - Renamed the process_file parameter to mock_process_file.
    - Added logic to log an error and exist if the given path does
      not exist.

* Scripts/webkitpy/style/checker_unittest.py:
  - Refactored the StyleCheckerCheckFileTest class slightly to
    inherit from LoggingTestCase.
  - Added a test method to unit-test the case of a file that
    does not exist.
  - Adjusted the other test methods as necessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Apr 2010 07:34:46 +0000 (07:34 +0000)]
2010-04-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
        https://bugs.webkit.org/show_bug.cgi?id=33289

        Add Tiger and SnowLeopard Tests to the core builders.  This is a bit of
        an experiment now that the bots are green.  Hopefully we can keep them
        on the list and have the tree stay greener.

        * Scripts/webkitpy/common/net/buildbot.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-03 Darin Fisher <darin@chromium.org>
darin@chromium.org [Sat, 3 Apr 2010 07:12:52 +0000 (07:12 +0000)]
2010-04-03  Darin Fisher  <darin@chromium.org>

        Add default implementations of WebNotificationPresenter methods to
        repair the downstream Chromium build.

        * public/WebNotificationPresenter.h:
        (WebKit::WebNotificationPresenter::show):
        (WebKit::WebNotificationPresenter::cancel):
        (WebKit::WebNotificationPresenter::objectDestroyed):
        (WebKit::WebNotificationPresenter::checkPermission):
        (WebKit::WebNotificationPresenter::requestPermission):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Andy Estes <aestes@apple.com>
abarth@webkit.org [Sat, 3 Apr 2010 07:05:55 +0000 (07:05 +0000)]
2010-04-02  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=37008.

        * fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
        * fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
        * fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
        * fast/events/popup-blocked-from-fake-button-click.html: Added.
        * fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
        * fast/events/popup-blocked-from-fake-focus.html: Added.
2010-04-02  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        The previous mechanism for testing whether an event was due to a user
        gesture only checked the event type, not the source of the event.  This
        allowed scripts to defeat popup blocking by programatically emitting
        certain types of events.

        Change the user gesture detection to check for a flag that is only set
        when the event in question was generated through the platform and not
        through the DOM.

        https://bugs.webkit.org/show_bug.cgi?id=37008

        Tests: fast/events/popup-allowed-from-gesture-initiated-event.html
               fast/events/popup-blocked-from-fake-button-click.html
               fast/events/popup-blocked-from-fake-focus.html

        * Android.mk: Add UserGestureIndicator.{cpp, h}.
        * GNUmakefile.am: Same.
        * WebCore.gypi: Same.
        * WebCore.pro: Same.
        * WebCore.vcproj/WebCore.vcproj: Same.
        * WebCore.xcodeproj/project.pbxproj: Same.
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture): Check the value of
        UserGesureIndicator::processingUserGesture().
        * dom/Document.cpp:
        (WebCore::Document::createEvent): Remove call to
        Event::setCreatedByDOM().
        * dom/Event.cpp:
        (WebCore::Event::Event): Remove initializers for m_createdByDOM.
        (WebCore::Event::fromUserGesture): Check the value of
        UserGestureIndicator::processingUserGesture().
        * dom/Event.h: Remove m_createdByDOM.
        * dom/UserGestureIndicator.cpp: Added.
        (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous
        value of s_processingUserGesture before setting it to true.
        (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore
        s_processingUserGesture to its previous value.
        * dom/UserGestureIndicator.h: Added.
        (WebCore::UserGestureIndicator::processingUserGesture): Return the value
        of s_processingUserGesture.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent): Instantiate a
        UserGestureIndicator object on the stack to indicate a user gesture is
        being processed.
        (WebCore::EventHandler::handleMouseDoubleClickEvent): Same.
        (WebCore::EventHandler::handleMouseReleaseEvent): Same.
        (WebCore::EventHandler::keyEvent): Same.
        (WebCore::EventHandler::handleTouchEvent): Same.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Apr 2010 06:15:04 +0000 (06:15 +0000)]
2010-04-02  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
        https://bugs.webkit.org/show_bug.cgi?id=36934

        Attempt Alexey's solution of using a non-sniffable MIME type.

        * http/tests/xmlhttprequest/resources/download-with-delay.php:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Apr 2010 05:49:21 +0000 (05:49 +0000)]
2010-04-02  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Disabled fast/workers/worker-terminate.html because it
        randomly fails about 25% of the time.

        https://bugs.webkit.org/show_bug.cgi?id=36646

        * platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Darin Fisher <darin@chromium.org>
darin@chromium.org [Sat, 3 Apr 2010 04:48:22 +0000 (04:48 +0000)]
2010-04-02  Darin Fisher  <darin@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=36647
        Make replacestate-in-frame.html less insane and hopefully no longer flaky.

        * fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
        * fast/loader/stateobjects/replacestate-in-iframe.html:
        * fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
        * fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Justin Schuh <jschuh@chromium.org>
abarth@webkit.org [Sat, 3 Apr 2010 04:20:26 +0000 (04:20 +0000)]
2010-04-02  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Alexey Proskuryakov.

        XHR allows arbitrary XSRF across domains
        https://bugs.webkit.org/show_bug.cgi?id=36843

        Added a one-line change to prevent bypassing the XDC check on
        synchronous preflighted requests. Added layout tests to cover
        variations of this problem.

        * http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
        * http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
        * http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
        * http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.
2010-04-02  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Alexey Proskuryakov.

        XHR allows arbitrary XSRF across domains
        https://bugs.webkit.org/show_bug.cgi?id=36843

        Added a one-line change to prevent bypassing the XDC check on
        synchronous preflighted requests. Added layout tests to cover
        variations of this problem.

        Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html
               http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
               http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
               http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::preflightFailure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Apr 2010 04:09:18 +0000 (04:09 +0000)]
2010-04-02  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Have Eric and Adam watch the SheriffBot
        https://bugs.webkit.org/show_bug.cgi?id=37054

        * Scripts/webkitpy/tool/bot/sheriff.py:
        * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
        * Scripts/webkitpy/tool/commands/sheriffbot.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 3 Apr 2010 01:05:14 +0000 (01:05 +0000)]
2010-04-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Very bad scrolling-performance with the Trackpad at http://www.apple.com/ipad/app-store/
        https://bugs.webkit.org/show_bug.cgi?id=36978

        When we update compositing layers (which can happen on scrolling, when there are fixed position elements
        on the page), we can end up redundantly setting images as layer contents if we have to color-correct
        the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
        every time.

        Avoid this by storing a reference to the original uncorrected image, which is used to then
        avoid work if the image does not change.

        * platform/graphics/mac/GraphicsLayerCA.h:
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setContentsToImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Nayan Kumar K <nayankk@gmail.com>
eric@webkit.org [Sat, 3 Apr 2010 01:03:24 +0000 (01:03 +0000)]
2010-04-02  Nayan Kumar K  <nayankk@gmail.com>

        Reviewed by Eric Seidel.

        Fix for WML enabled build failure.

        https://bugs.webkit.org/show_bug.cgi?id=36648

        * wml/WMLOptionElement.cpp:
        (WebCore::WMLOptionElement::disabled):
        * wml/WMLOptionElement.h:
        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::listBoxSelectItem):
        * wml/WMLSelectElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 MORITA Hajime <morrita@google.com>
eric@webkit.org [Sat, 3 Apr 2010 00:38:27 +0000 (00:38 +0000)]
2010-04-02  MORITA Hajime  <morrita@google.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=37011
        Position::primaryDirection() should not use its own accessor.

        No new tests. This is small clenaup with no behaviour change.

        * dom/Position.cpp:
        (WebCore::Position::primaryDirection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Sat, 3 Apr 2010 00:16:39 +0000 (00:16 +0000)]
2010-04-02  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Brady Eidson.

        window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5.  This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
        https://bugs.webkit.org/show_bug.cgi?id=36671

        No new tests.  Requires testing on Safari on Windows.

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Apr 2010 00:14:45 +0000 (00:14 +0000)]
2010-04-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        commit-queue should ignore builders when landing rollouts
        https://bugs.webkit.org/show_bug.cgi?id=37051

        When we moved the "builders are red" check into the master process, we
        forgot about rollouts.  I thought we had a test covering this case, but
        looking at the test, it was a bit too loose.  I added a new test and
        introduced some new logging technology into MockTool to make the test
        tighter.

        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Michael Nordman <michaeln@google.com>
eric@webkit.org [Sat, 3 Apr 2010 00:06:57 +0000 (00:06 +0000)]
2010-04-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Nate Chapin.

        Set the close policy used by the DatabaseCloseTask in a constructor argument
        instead of hard coding it.
        https://bugs.webkit.org/show_bug.cgi?id=37037

        No new tests, new new functionality.

        * storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior.
        (WebCore::Database::markAsDeletedAndClose):
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseCloseTask::DatabaseCloseTask):
        (WebCore::DatabaseCloseTask::doPerformTask):
        * storage/DatabaseTask.h:
        (WebCore::DatabaseCloseTask::create):
2010-04-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Nate Chapin.

        Set the close policy used by the DatabaseCloseTask at this callsite to
        RemoveDatabaseFromContext. This restores its behavior to what it was prior to
        r56293.
        https://bugs.webkit.org/show_bug.cgi?id=37037

        * src/WebDatabase.cpp:
        (WebKit::WebDatabase::closeDatabaseImmediately):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 2 Apr 2010 23:52:17 +0000 (23:52 +0000)]
2010-04-02  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Remove an ASSERT that sometimes flakes due to time dependent animations
        https://bugs.webkit.org/show_bug.cgi?id=37048

        The outline repaint rectangle for a layer might change between two calls
        if there are animations involved, even if nothing in the DOM has actually
        changed between the calls.

        No change in behavior, no new tests.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Evan Stade <estade@chromium.org>
abarth@webkit.org [Fri, 2 Apr 2010 23:45:19 +0000 (23:45 +0000)]
2010-04-02  Evan Stade  <estade@chromium.org>

        Reviewed by Adam Barth.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Add two files that failed to get added in my previous patch.

        * platform/chromium/DragImageChromiumMac.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):
        * platform/chromium/DragImageChromiumSkia.cpp: Added.
        (WebCore::dragImageSize):
        (WebCore::deleteDragImage):
        (WebCore::scaleDragImage):
        (WebCore::dissolveDragImageToFraction):
        (WebCore::createDragImageFromImage):
        (WebCore::createDragImageIconForCachedImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Jer Noble <jer.noble@apple.com>
eric.carlson@apple.com [Fri, 2 Apr 2010 23:30:31 +0000 (23:30 +0000)]
2010-04-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Configure multi-language movies: when QuickTime has sufficiently loaded
        the movie, call into wkQTMovieSelectPreferredAlternates to select the
        movie's alternate tracks according to the user's language preferences.

        https://bugs.webkit.org/show_bug.cgi?id=36624

        * WebCore.base.exp:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded,
        call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
        * platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
        * platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.

2010-04-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=36624

        Update WebKitSystemInterface

        * WebKitSystemInterface.h: add WKQTMovieSelectPreferredAlternates.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

2010-04-02  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=36624
        Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 2 Apr 2010 23:21:35 +0000 (23:21 +0000)]
2010-04-02  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        Splits RenderBlock::layoutInline into smaller functions
        https://bugs.webkit.org/show_bug.cgi?id=36921

        RenderBlock::layoutInlineChildren is 351 lines long and very difficult
        to comprehend or edit safely. This patch splits it up into a few
        slightly smaller functions.  Most of the code is now in the 241 line
        layoutRunsAndFloats() which is a slight improvement.

        Perf neutral on the page cyclers.  This doesn't introduce any function
        calls into the hottest layout paths inside layoutRunsAndFloats and
        findNextLineBreak.

        No change in behavior, no new tests.

        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutReplacedElements):
        (WebCore::RenderBlock::createLineBoxesForResolver):
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 2 Apr 2010 22:57:27 +0000 (22:57 +0000)]
2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [Symbian] Rebaseline Symbian def file
        https://bugs.webkit.org/show_bug.cgi?id=37038

        Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
        and QWebInspector::closeEvent to match QtWebkit 4.6 branch

        Fix the signature for qt_drt_setFrameFlatteningEnabled
        after r56718.

        Add new QtWebKit API symbols introduced not listed in the file yet.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Evan Stade <estade@chromium.org>
eric@webkit.org [Fri, 2 Apr 2010 22:48:06 +0000 (22:48 +0000)]
2010-04-02  Evan Stade  <estade@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Basic implementation using SkBitmap. Transformations are not supported
        yet. No implementation for mac.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/DragImageChromium.cpp:
        * platform/chromium/DragImageRef.h:
2010-04-02  Evan Stade  <estade@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Use the DragImageRef that the DragController passes to us.

        * public/WebViewClient.h:
        (WebKit::WebViewClient::startDragging):
        * src/DragClientImpl.cpp:
        (WebKit::DragClientImpl::startDrag):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::startDragging):
        * src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Evan Martin <evan@chromium.org>
eric@webkit.org [Fri, 2 Apr 2010 22:23:25 +0000 (22:23 +0000)]
2010-04-02  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] font fallback for generic fonts picks wrong font
        https://bugs.webkit.org/show_bug.cgi?id=37033

        When a page specifies the generic "monospace" font and the user's
        browser-configured monospace font doesn't exist, we previously relied
        on getLastResortFallbackFont to eventually pick a monospace font for us.

        But that doesn't quite work: WebKit first falls back to the user's
        "preferred standard font" before hitting the last resort code path.
        So if the above conditions hold but this font exists, we'll end up
        never hitting the last resort codepath.

        The fix is to allow OS-level font fallback when first attempting to
        resolve monospace.  The existing code tried to do this, but the logic
        was wrong.  We would eventually fall back to the correct font anyway
        so we didn't notice the logic was wrong.

        This code is all handling cases where particular fonts aren't installed,
        so I can't think of a way to test it; existing tests should still pass.

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
eric@webkit.org [Fri, 2 Apr 2010 22:13:57 +0000 (22:13 +0000)]
2010-04-02  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Adam Barth.

        Clean up unused calls after changes to checkPermission and requestPermission argument lists.

        * public/WebNotificationPresenter.h:
        * src/NotificationPresenterImpl.cpp:
        (WebKit::NotificationPresenterImpl::checkPermission):
        (WebKit::NotificationPresenterImpl::requestPermission):
2010-04-02  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Adam Barth.

        Clean up unused calls after changes to checkPermission and requestPermission argument lists.

        * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
        (WebDesktopNotificationsDelegate::requestPermission):
        * WebCoreSupport/WebDesktopNotificationsDelegate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Ruben Van Boxem <vanboxem.ruben@gmail.com>
eric@webkit.org [Fri, 2 Apr 2010 21:53:08 +0000 (21:53 +0000)]
2010-04-02  Ruben Van Boxem  <vanboxem.ruben@gmail.com>

        Reviewed by Eric Seidel.

        Mingw-w64 fixes for JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=35607

        * runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32)
        (JSC::Heap::allocateBlock):
        (JSC::Heap::freeBlockPtr):
        (JSC::currentThreadStackBase):
        (JSC::currentThreadStackBase):
        * wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 2 Apr 2010 21:21:42 +0000 (21:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=37043
        Java regression tests spam stderr about being unable to set status message

        With this change, there is still spam about "Attempt to access JavaScript from destroyed
        applet, type 9." I haven't investigated if that indicates a problem or not.

        * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]):
        Removed check for _documentView. We don't seem to care.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-02 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 2 Apr 2010 21:18:32 +0000 (21:18 +0000)]
2010-04-02  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson and Eric Seidel.

        Don't stop the playback event timer when media resource loading has suspended.
        https://bugs.webkit.org/show_bug.cgi?id=37003

        When a user agent decides to suspend media resource loading and enters the
        NETWORK_IDLE state we are supposed to only stop the progress event timer but
        keep the playback timer running.

        Test: http/tests/media/video-play-suspend.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.

2010-04-02  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson and Eric Seidel.

        Don't stop the playback event timer when media resource loading has suspended.
        https://bugs.webkit.org/show_bug.cgi?id=37003

        When a user agent decides to suspend media resource loading and enters the
        NETWORK_IDLE state we are supposed to only stop the progress event timer but
        keep the playback timer running.

        Currently Chromium is the only platform that fires the suspend event
        hence most platforms skipping this test.

        * http/tests/media/video-play-suspend-expected.txt: Added.
        * http/tests/media/video-play-suspend.html: Added.
        * platform/gtk/Skipped: Doesn't fire a suspend event.
        * platform/mac/Skipped: Ditto.
        * platform/win/Skipped: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix mispelling that broke the build.
darin@apple.com [Fri, 2 Apr 2010 21:01:34 +0000 (21:01 +0000)]
Fix mispelling that broke the build.

* html/canvas/CanvasRenderingContext2D.cpp:
* html/canvas/CanvasRenderingContext2D.h:
Dashbard -> Dashboard.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: updated the .def file.
ggaren@apple.com [Fri, 2 Apr 2010 20:40:04 +0000 (20:40 +0000)]
Build fix: updated the .def file.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago(non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
levin@chromium.org [Fri, 2 Apr 2010 20:31:53 +0000 (20:31 +0000)]
(non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
https://bugs.webkit.org/show_bug.cgi?id=36906

Reviewed by Darin Adler.

WebCore:

* dom/CanvasSurface.cpp: Added methods for items that depended on
CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
can be dealt with in one place.
(WebCore::CanvasSurface::securityOrigin): Only used by methods that are
only run in the document context.
(WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
(WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
the worker context.
(WebCore::CanvasSurface::styleSelector): Ditto.
* dom/CanvasSurface.h:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext): Passing in information into
the CanvasRenderingContext2D constructor to eliminate some uses of document
inside of the CanvasRenderingContext2D class.
* html/HTMLCanvasElement.h:
(WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
two parent class versions of the method.
(WebCore::HTMLCanvasElement::computedStyle): Ditto.
* html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about
removing document usage either by using a bool that is set in the constructor or
by calling one of the new methods added to CanvasSurface.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
(WebCore::CanvasRenderingContext2D::checkOrigin):
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.
(WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox
 as it may become slightly more expensive in the future.
(WebCore::WebGLRenderingContext::reshape): Ditto.

LayoutTests:

* fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test
to create a new canvas after switching to dashboard compatiblity mode, which is
needed now that the compatibility mode is cached in the canvas.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57020 268f45cc-cd09-0410-ab3c-d52691b4dbfc