WebKit.git
6 years agoSome CSS teaks.
rniwa@webkit.org [Wed, 9 Apr 2014 02:54:45 +0000 (02:54 +0000)]
Some CSS teaks.

* public/common.css:
(#title):
* public/index.html:
(#charts .pane):
(#charts .arrow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTurn MSE on by default
jonlee@apple.com [Wed, 9 Apr 2014 02:18:52 +0000 (02:18 +0000)]
Turn MSE on by default
https://bugs.webkit.org/show_bug.cgi?id=131313
<rdar://problem/16525223>

Reviewed by Jer Noble.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* page/Settings.in: Add MEDIA_SOURCE conditional.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set default to true.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferencesStore.h: Set default to true.
* UIProcess/API/C/WKPreferencesRefPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove an unused parameter from loadResource.
andersca@apple.com [Wed, 9 Apr 2014 01:45:43 +0000 (01:45 +0000)]
Remove an unused parameter from loadResource.

Reviewed by Darin Adler.

Since the CachedResourceRequest has the charset in it, we don't need to pass it separately to loadRequest.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
* loader/cache/CachedResourceLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL build fix attempt since r166956
ryuan.choi@samsung.com [Wed, 9 Apr 2014 01:25:35 +0000 (01:25 +0000)]
Unreviewed EFL build fix attempt since r166956

Source/WebCore:

* page/efl/DragControllerEfl.cpp: Rename Clipboard to DataTransfer.
(WebCore::DragController::declareAndWriteDragImage):

Source/WebKit/efl:

* WebCoreSupport/DragClientEfl.cpp: Rename Clipboard to DataTransfer.
(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::startDrag): Ditto.
* WebCoreSupport/DragClientEfl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: REGRESSION (r155998): Elements render at very low resolution with...
simon.fraser@apple.com [Wed, 9 Apr 2014 01:11:52 +0000 (01:11 +0000)]
Source/WebCore: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412
<rdar://problem/16525044>

Reviewed by Tim Horton.

In r155998 we started to compute a root-relative transform in order to choose
a good contentsScale to avoid blurring on scaling.

However, the code failed to update this transform when passing over
GraphicsLayerCAs with no uncommitted changes, which caused us to choose
an incorrect contentsScale sometimes, resulting in blurriness.

Fix by updating the root-relative transform on layers with no uncommitted
changes.

Test: compositing/contents-scale/incremental-change.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

LayoutTests: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412

Reviewed by Tim Horton.

Test that makes an incremental change to a layer property in a tree with
interesting 3d transforms.

* compositing/contents-scale/incremental-change-expected.html: Added.
* compositing/contents-scale/incremental-change.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't call CGPathAddPath with invalid CGAffineTransform objects
andersca@apple.com [Wed, 9 Apr 2014 01:11:15 +0000 (01:11 +0000)]
Don't call CGPathAddPath with invalid CGAffineTransform objects
https://bugs.webkit.org/show_bug.cgi?id=131413
<rdar://problem/16399645>

Reviewed by Darin Adler.

Covered by existing tests.

* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addPath):
Don't try to add the path if the affine transform isn't invertible.

* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::isInvertible):
Handle infinite and NaN determinants.

(WebCore::AffineTransform::inverse):
Handle infinite and NaN determinants.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2014-04-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 9 Apr 2014 00:47:21 +0000 (00:47 +0000)]
2014-04-08  Geoffrey Garen  <ggaren@apple.com>

        Stop linking WTF against bmalloc.

        Reviewed by Enrica Casucci.

        This seems to have broken an iOS buildbot script. Disable it for now
        until we can fix the script.

        * WTF.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build-jsc build
ggaren@apple.com [Wed, 9 Apr 2014 00:40:55 +0000 (00:40 +0000)]
Fix the build-jsc build
https://bugs.webkit.org/show_bug.cgi?id=131410

Reviewed by Michael Saboff.

* Scripts/build-jsc: Make sure to build bmalloc before WTF, since
WTF depends on it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the typo in the previous commit.
rniwa@webkit.org [Wed, 9 Apr 2014 00:38:58 +0000 (00:38 +0000)]
Fix the typo in the previous commit.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
rniwa@webkit.org [Wed, 9 Apr 2014 00:37:57 +0000 (00:37 +0000)]
REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
https://bugs.webkit.org/show_bug.cgi?id=131409

Reviewed by Anders Carlsson.

Create an empty API::InjectedBundle::FormClient to avoid crashing inside
m_mainFrame->coreFrame()->loader().detachFromParent().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Replay: memoize nondeterministic attributes of the Screen interface
burg@cs.washington.edu [Wed, 9 Apr 2014 00:22:46 +0000 (00:22 +0000)]
Web Replay: memoize nondeterministic attributes of the Screen interface
https://bugs.webkit.org/show_bug.cgi?id=131339

Reviewed by Timothy Hatcher.

.:

* ManualTests/inspector/replay-window-screen.html: Added.

Source/WebCore:

The values from the screen interface are nondeterministic. Since we can't
change the physical screen dimensions, instead memoize values of attributes.

Test: ManualTests/inspector/replay-window-screen.html

* page/Screen.idl: Add Nondeterministic attribute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=131408
bdakin@apple.com [Wed, 9 Apr 2014 00:13:43 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=131408
Scrollbars layers don't dynamically update when device scale factor changes
-and corresponding-
<rdar://problem/16503875>

Reviewed by Tim Horton.

The scrollbar layers are not children of the RenderView's layer, so they were
completely skipped over by this function before. We need to start this higher up
the tree in the rootGraphicsLayer(), which will typically return the
m_overflowControlsHostLayer.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Prevent deadlocks receiving WIRPermissionDenied message
commit-queue@webkit.org [Wed, 9 Apr 2014 00:12:11 +0000 (00:12 +0000)]
Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message
https://bugs.webkit.org/show_bug.cgi?id=131406

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-04-08
Reviewed by Timothy Hatcher.

* inspector/remote/RemoteInspector.h:
* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
Provide a way to stop externally and a path to stop when in
the middle of handling a message already with the locked mutex.

* inspector/remote/RemoteInspectorXPCConnection.h:
* inspector/remote/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::closeFromMessage):
Provide a way to close externally and a path to close when in
the middle of handling a message already with a mutex.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
rniwa@webkit.org [Wed, 9 Apr 2014 00:06:09 +0000 (00:06 +0000)]
HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
https://bugs.webkit.org/show_bug.cgi?id=131400

Reviewed by Sam Weinig.

Instead of accumulating attributes from a character node to the highest ancestor,
recursively call aggregatedAttributesForElementAndItsAncestors so that aggregated
attributes are cached on each ancestor to eliminate the old O(n^2) behavior.

* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors): Extracted from aggregatedAttributesForAncestors.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed CMake build fix after r166965.
jinwoo7.song@samsung.com [Tue, 8 Apr 2014 23:53:29 +0000 (23:53 +0000)]
Unreviewed CMake build fix after r166965.

* UseJSC.cmake: Rename JSClipboardCustom.cpp to JSDataTransferCustom.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove the WebKitGTK+ WebKit 1 code
mrobinson@webkit.org [Tue, 8 Apr 2014 23:44:44 +0000 (23:44 +0000)]
[GTK] Remove the WebKitGTK+ WebKit 1 code
https://bugs.webkit.org/show_bug.cgi?id=131399

Reviewed by Anders Carlsson.

.:

* Source/PlatformGTK.cmake: Remove WebKit1 dependency from dist target.
* Source/cmake/OptionsGTK.cmake: Remove option to compile with GTK+2 or with WebKit2 disabled.

Source/WebCore/platform/gtk/po:

* POTFILES.in: Remove references to WebKit1 source files from the list of
files with translatable strings.

Source/WebKit:

* PlatformGTK.cmake: Removed.
* gtk: Remove this entire directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnify and factor out page overlay implementations
timothy_horton@apple.com [Tue, 8 Apr 2014 23:40:43 +0000 (23:40 +0000)]
Unify and factor out page overlay implementations
https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

* WebProcess/WebPage/PageOverlayController.cpp:
(WebKit::PageOverlayController::uninstallPageOverlay):
Don't turn fast scrolling back off unless the last overlay is removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove WebKit1 unit tests
mrobinson@webkit.org [Tue, 8 Apr 2014 23:36:28 +0000 (23:36 +0000)]
[GTK] Remove WebKit1 unit tests
https://bugs.webkit.org/show_bug.cgi?id=131359

Reviewed by Anders Carlsson.

Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
they were inadvertently left in http://trac.webkit.org/changeset/166504.

* CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
* Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
* TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
* TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a WKNavigationAction property indicating whether it resulted from processing...
andersca@apple.com [Tue, 8 Apr 2014 23:19:32 +0000 (23:19 +0000)]
Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
https://bugs.webkit.org/show_bug.cgi?id=131405
<rdar://problem/16535453>

Reviewed by Tim Horton.

* Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::NavigationActionData):
(WebKit::NavigationActionData::encode):
(WebKit::NavigationActionData::decode):
* Shared/NavigationActionData.h:
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnify and factor out page overlay implementations
timothy_horton@apple.com [Tue, 8 Apr 2014 23:09:52 +0000 (23:09 +0000)]
Unify and factor out page overlay implementations
https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

Bring all of the PageOverlay code together in a single cross-platform
PageOverlayController, including hit-testing code from WebPage and painting
and layer-tree manipulation code from the DrawingArea.

This also makes all PageOverlays a single GraphicsLayer tree which can be
flushed and plugged into any DrawingArea in a straightforward manner.
We no longer have to watch for individual layers flipping into/out of tiling,
because they're hidden underneath the root PageOverlay GraphicsLayer.
Additionally, because GraphicsLayer is cross-platform, we can share
all of the fairly trivial but oft-repeated overlay management code.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/PageOverlayController.cpp: Added.
* WebProcess/WebPage/PageOverlayController.h: Added.
(WebKit::PageOverlayController::rootLayer):
Add PageOverlayController.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
Remove PageOverlay-related code from the DrawingAreas.

* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
(WebKit::PageOverlay::clear):
* WebProcess/WebPage/PageOverlay.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
Use PageOverlayController instead of the DrawingArea/WebPage to manipulate page overlays.

* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::pageOverlayController):
Remove PageOverlay-related code from WebPage.

* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWasAdded): Deleted.
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWillBeRemoved): Deleted.
(WebKit::RemoteLayerTreeContext::flushOutOfTreeLayers): Deleted.
Remove the no-longer-necessary out-of-tree layer code.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageInstallPageOverlayWithAnimation):
(WKBundlePageUninstallPageOverlayWithAnimation):
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
(WebKit::WebInspectorClient::hideHighlight):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::hideFindUI):
* WebProcess/WebPage/TelephoneNumberOverlayController.cpp:
(WebKit::TelephoneNumberOverlayController::createOverlayIfNeeded):
(WebKit::TelephoneNumberOverlayController::destroyOverlay):
Make use of the FadeMode enum.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening (Take 2): Prevent users from attempting
bfulgham@apple.com [Tue, 8 Apr 2014 22:59:27 +0000 (22:59 +0000)]
Unreviewed gardening (Take 2): Prevent users from attempting
to build with known invalid cURL.

* Scripts/webkitdirs.pm:
(checkInstalledTools): Check for 7.34.0 (the broken version), not
7.33.0 (the known good version).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove DumpRenderTree and GtkLauncher
mrobinson@webkit.org [Tue, 8 Apr 2014 22:52:26 +0000 (22:52 +0000)]
[GTK] Remove DumpRenderTree and GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=131373

Reviewed by Andreas Kling.

Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
no longer necessary now that WebKit1 GTK+ will be removed.

* CMakeLists.txt:
* DumpRenderTree/PlatformGTK.cmake: Removed.
* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
* DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
* DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
* DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
* DumpRenderTree/gtk/EditingCallbacks.h: Removed.
* DumpRenderTree/gtk/EventSender.cpp: Removed.
* DumpRenderTree/gtk/EventSender.h: Removed.
* DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
* DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
* DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
* DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
* DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
* DumpRenderTree/gtk/TextInputController.cpp: Removed.
* DumpRenderTree/gtk/TextInputController.h: Removed.
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
* GtkLauncher/CMakeLists.txt: Removed.
* GtkLauncher/LauncherInspectorWindow.c: Removed.
* GtkLauncher/LauncherInspectorWindow.h: Removed.
* GtkLauncher/main.c: Removed.
* GtkLauncher/simple.svg: Removed.
* GtkLauncher/text.html: Removed.
* WebKitTestRunner/PlatformGTK.cmake:
* WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
* WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
* WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWTF should link against bmalloc
ggaren@apple.com [Tue, 8 Apr 2014 22:51:27 +0000 (22:51 +0000)]
WTF should link against bmalloc
https://bugs.webkit.org/show_bug.cgi?id=131403

Reviewed by Michael Saboff.

This is required to build successfullly with bmalloc enabled.

* WTF.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Address stale FIXMEs concerning console in JSContext inspection
commit-queue@webkit.org [Tue, 8 Apr 2014 22:46:10 +0000 (22:46 +0000)]
Web Inspector: Address stale FIXMEs concerning console in JSContext inspection
https://bugs.webkit.org/show_bug.cgi?id=131398

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-04-08
Reviewed by Timothy Hatcher.

* inspector/InjectedScriptSource.js:
The console object can be deleted from a page or JSContext,
so keep code that expects that it could have been deleted
to be resilient in those cases.

* inspector/JSGlobalObjectScriptDebugServer.h:
* inspector/agents/JSGlobalObjectDebuggerAgent.h:
* inspector/agents/JSGlobalObjectRuntimeAgent.h:
Change the FIXMEs to NOTEs that explain why these functions
have empty implementations for JSContext inspection.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed iOS build fix.
enrica@apple.com [Tue, 8 Apr 2014 22:44:39 +0000 (22:44 +0000)]
Unreviewed iOS build fix.

Return false instead of nil in a function that returns BOOL.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange WebPageProxy::CreateNewPage to take a NavigationActionData object
andersca@apple.com [Tue, 8 Apr 2014 22:37:19 +0000 (22:37 +0000)]
Change WebPageProxy::CreateNewPage to take a NavigationActionData object
https://bugs.webkit.org/show_bug.cgi?id=131401

Reviewed by Dan Bernstein.

* UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(toWKNavigationType):
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::toWKNavigationType): Deleted.
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNon-empty ranges misdetected as empty ranges, avoiding telephone number detection.
beidson@apple.com [Tue, 8 Apr 2014 22:36:06 +0000 (22:36 +0000)]
Non-empty ranges misdetected as empty ranges, avoiding telephone number detection.
<rdar://problem/16553441> and https://bugs.webkit.org/show_bug.cgi?id=131397

Reviewed by Tim Horton.

No new tests (Only affects a currently untested Mac-only WK2 feature)

* editing/Editor.cpp:
(WebCore::Editor::scanSelectionForTelephoneNumbers): Fix detection of empty ranges so we don’t
  early return erroneously.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SVG] Fix CSS transform handling when zoomed
cavalcantii@gmail.com [Tue, 8 Apr 2014 22:27:37 +0000 (22:27 +0000)]
[SVG] Fix CSS transform handling when zoomed
https://bugs.webkit.org/show_bug.cgi?id=125836

Reviewed by Tim Horton.

Source/WebCore:

Tests: svg/zoom/page/zoom-css-transforms-expected.svg
       svg/zoom/page/zoom-css-transforms.svg

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

* svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::animatedLocalTransform):

LayoutTests:

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

* svg/zoom/page/zoom-css-transforms-expected.svg: Added.
* svg/zoom/page/zoom-css-transforms.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] large corner radius combined with 0 radius does not wrap properly
hmuller@adobe.com [Tue, 8 Apr 2014 22:26:03 +0000 (22:26 +0000)]
[CSS Shapes] large corner radius combined with 0 radius does not wrap properly
https://bugs.webkit.org/show_bug.cgi?id=129739

Reviewed by Bem Jones-Bey.

Source/WebCore:

Corrected special case handling for shape-outside border-box values with border-radius
values that greater than or equal to the box's height.

Tests: fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html
       fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html

* rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedIntervals):

LayoutTests:

* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Rename Clipboard to DataTransfer
ap@apple.com [Tue, 8 Apr 2014 22:06:16 +0000 (22:06 +0000)]
Source/WebCore: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

This is the name used in HTML5, and it's much better than the confusing Clipboard one.

Renamed related enums too, and made DataTransferAccessPolicy an enum class.

* CMakeLists.txt:
* Configurations/WebCore.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSClipboardCustom.cpp: Removed.
* bindings/js/JSDataTransferCustom.cpp: Copied from Source/WebCore/bindings/js/JSClipboardCustom.cpp.
(WebCore::JSDataTransfer::types):
(WebCore::JSClipboard::types): Deleted.
* bindings/js/JSEventCustom.cpp:
* dom/Clipboard.cpp: Removed.
* dom/Clipboard.h: Removed.
* dom/Clipboard.idl: Removed.
* dom/ClipboardAccessPolicy.h: Removed.
* dom/ClipboardEvent.cpp:
(WebCore::ClipboardEvent::ClipboardEvent):
* dom/ClipboardEvent.h:
(WebCore::ClipboardEvent::create):
(WebCore::ClipboardEvent::clipboard): Deleted.
* dom/ClipboardMac.mm: Removed.
* dom/DOMAllInOne.cpp:
* dom/DataTransfer.cpp: Copied from Source/WebCore/dom/Clipboard.cpp.
(WebCore::DataTransfer::DataTransfer):
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy):
(WebCore::DataTransfer::canReadTypes):
(WebCore::DataTransfer::canReadData):
(WebCore::DataTransfer::canWriteData):
(WebCore::DataTransfer::clearData):
(WebCore::DataTransfer::getData):
(WebCore::DataTransfer::setData):
(WebCore::DataTransfer::types):
(WebCore::DataTransfer::files):
(WebCore::DataTransfer::dropEffect):
(WebCore::DataTransfer::setDropEffect):
(WebCore::DataTransfer::effectAllowed):
(WebCore::DataTransfer::setEffectAllowed):
(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::createForDragAndDrop):
(WebCore::DataTransfer::canSetDragImage):
(WebCore::DataTransfer::updateDragImage):
(WebCore::DataTransfer::createDragImage):
(WebCore::DragImageLoader::DragImageLoader):
(WebCore::DragImageLoader::imageChanged):
(WebCore::DataTransfer::sourceOperation):
(WebCore::DataTransfer::destinationOperation):
(WebCore::DataTransfer::setSourceOperation):
(WebCore::DataTransfer::setDestinationOperation):
(WebCore::Clipboard::Clipboard): Deleted.
(WebCore::Clipboard::createForCopyAndPaste): Deleted.
(WebCore::Clipboard::~Clipboard): Deleted.
(WebCore::Clipboard::setAccessPolicy): Deleted.
(WebCore::Clipboard::canReadTypes): Deleted.
(WebCore::Clipboard::canReadData): Deleted.
(WebCore::Clipboard::canWriteData): Deleted.
(WebCore::Clipboard::clearData): Deleted.
(WebCore::Clipboard::getData): Deleted.
(WebCore::Clipboard::setData): Deleted.
(WebCore::Clipboard::types): Deleted.
(WebCore::Clipboard::files): Deleted.
(WebCore::Clipboard::dropEffect): Deleted.
(WebCore::Clipboard::setDropEffect): Deleted.
(WebCore::Clipboard::effectAllowed): Deleted.
(WebCore::Clipboard::setEffectAllowed): Deleted.
(WebCore::Clipboard::setDragImage): Deleted.
(WebCore::Clipboard::createForDragAndDrop): Deleted.
(WebCore::Clipboard::canSetDragImage): Deleted.
(WebCore::Clipboard::updateDragImage): Deleted.
(WebCore::Clipboard::createDragImage): Deleted.
(WebCore::Clipboard::sourceOperation): Deleted.
(WebCore::Clipboard::destinationOperation): Deleted.
(WebCore::Clipboard::setSourceOperation): Deleted.
(WebCore::Clipboard::setDestinationOperation): Deleted.
* dom/DataTransfer.h: Copied from Source/WebCore/dom/Clipboard.h.
* dom/DataTransfer.idl: Copied from Source/WebCore/dom/Clipboard.idl.
* dom/DataTransferAccessPolicy.h: Copied from Source/WebCore/dom/ClipboardAccessPolicy.h.
* dom/DataTransferItemList.h:
* dom/DataTransferMac.mm: Copied from Source/WebCore/dom/ClipboardMac.mm.
(WebCore::DataTransfer::createDragImage):
(WebCore::Clipboard::createDragImage): Deleted.
* dom/Event.h:
(WebCore::Event::clipboardData):
(WebCore::Event::internalDataTransfer):
(WebCore::Event::clipboard): Deleted.
* dom/Event.idl:
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):
* dom/MouseEvent.h:
(WebCore::MouseEvent::dataTransfer):
* dom/MouseEvent.idl:
* dom/WheelEvent.cpp:
* editing/Editor.cpp:
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::selectedTextForDataTransfer):
(WebCore::Editor::selectedTextForClipboard): Deleted.
* editing/Editor.h:
* editing/ios/EditorIOS.mm:
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
* editing/mac/EditorMac.mm:
(WebCore::Editor::takeFindStringFromSelection):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
* loader/EmptyClients.h:
* page/DragClient.h:
* page/DragController.cpp:
(WebCore::DragController::dragExited):
(WebCore::DragController::performDrag):
(WebCore::DragController::tryDHTMLDrag):
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
* page/DragController.h:
* page/DragState.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::hasFileOfType):
(WebCore::hasStringOfType):
(WebCore::hasDropZoneType):
(WebCore::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::freeDataTransfer):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::dispatchDragSrcEvent):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::freeClipboard): Deleted.
* page/EventHandler.h:
* page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::declareAndWriteDragImage):
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* page/mac/DragControllerMac.mm:
(WebCore::DragController::declareAndWriteDragImage):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* page/win/DragControllerWin.cpp:
(WebCore::DragController::declareAndWriteDragImage):
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::createDraggingataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* platform/Pasteboard.h:
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeSelection):
* platform/mac/PasteboardMac.mm:
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):

Source/WebKit/ios: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

* WebView/WebPDFViewPlaceholder.mm:

Source/WebKit/mac: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

* WebCoreSupport/WebDragClient.h:
* WebCoreSupport/WebDragClient.mm:
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
* WebView/WebPDFView.mm:

Source/WebKit2: Fix build.

Patch by Anders Carlsson <andersca@apple.com> on 2014-04-08

* WebKit2Prefix.h:

LayoutTests: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserv...
jer.noble@apple.com [Tue, 8 Apr 2014 21:41:02 +0000 (21:41 +0000)]
Unreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserver:forKeyPath:options:context.

* platform/graphics/ios/TextTrackRepresentationIOS.mm:
(-[WebCoreTextTrackRepresentationIOSHelper setParent:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
andersca@apple.com [Tue, 8 Apr 2014 21:33:37 +0000 (21:33 +0000)]
Fix build.

* WebKit2Prefix.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Generate Optimized WebInspectorUI in Release Build
bfulgham@apple.com [Tue, 8 Apr 2014 21:29:09 +0000 (21:29 +0000)]
[Windows] Generate Optimized WebInspectorUI in Release Build
https://bugs.webkit.org/show_bug.cgi?id=120120

Reviewed by Timothy Hatcher.

* Scripts/copy-user-interface-resources.pl: Copied from Scripts/copy-user-interface-resources.sh.
* Scripts/copy-user-interface-resources.sh: Removed.
* Scripts/remove-console-asserts.pl:
* WebInspectorUI.vcxproj/WebInspectorUI.make: Added.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Switch to Makefile style.
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Ditto.
* WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: More work should
be done in the new build-webinspectorui.sh file.
* WebInspectorUI.vcxproj/build-webinspectorui.sh: Added.
* WebInspectorUI.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse an explicit class when decoding individual bundle parameters
andersca@apple.com [Tue, 8 Apr 2014 21:22:35 +0000 (21:22 +0000)]
Use an explicit class when decoding individual bundle parameters
https://bugs.webkit.org/show_bug.cgi?id=131392
<rdar://problem/16213914>

Reviewed by Dan Bernstein.

* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::setBundleParameter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Unreviewed test gardening.
bfulgham@apple.com [Tue, 8 Apr 2014 21:18:57 +0000 (21:18 +0000)]
[Mac] Unreviewed test gardening.

Rebaseline scrolling tests to remove flakiness introduced by slight differences in
pixel scroll counts between WK1 and WK2 test runners.

* platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt:
* platform/mac/fast/scrolling/scroll-div-latched-div.html:
* platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-div-latched-mainframe.html:
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt:
* platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html:
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html:
* platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-select-latched-mainframe.html:
* platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt:
* platform/mac/fast/scrolling/scroll-select-latched-select.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove a Mountain Lion declaration to the WebKit2 prefix header
andersca@apple.com [Tue, 8 Apr 2014 21:11:31 +0000 (21:11 +0000)]
Move a Mountain Lion declaration to the WebKit2 prefix header
https://bugs.webkit.org/show_bug.cgi?id=131391

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKProcessPool.mm:
* UIProcess/ios/PageClientImplIOS.mm:
* UIProcess/mac/WebContextMac.mm:
* WebKit2Prefix.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove exposedRect from TileController
antti@apple.com [Tue, 8 Apr 2014 20:50:47 +0000 (20:50 +0000)]
Remove exposedRect from TileController
https://bugs.webkit.org/show_bug.cgi?id=131378

Reviewed by Simon Fraser.

Source/WebCore:

Having two separate visible rectangles is confusing. We should compute one on higher level.

* page/FrameView.cpp:
(WebCore::FrameView::setExposedRect):

    Push exposed rect to tile controller by doing a layer flush (like the changed visible rect is normally passed).

* platform/graphics/TiledBacking.h:
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:

    Remove exposedRect and just use visibleRect.

(WebCore::TileController::TileController):
(WebCore::TileController::setTiledScrollingIndicatorPosition):

    Update the scrolling indicator position.

(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::setExposedRect): Deleted.
* platform/graphics/ca/mac/TileGrid.h:
* platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::tilesWouldChangeForVisibleRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::scaledExposedRect): Deleted.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):

    No need to push exposedRect anymore.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

    Integrate exposed rect to visible rect when flushing layers.

Source/WebKit2:

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):

    Update the visible rect for pageOverlayLayers by calling flushCompositingState. This way
    tile controller visible rect updates always happens via compositing flush (we assert
    for this in TileController::setVisibleRect).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded a bmalloc back-end for FastMalloc
ggaren@apple.com [Tue, 8 Apr 2014 20:36:17 +0000 (20:36 +0000)]
Added a bmalloc back-end for FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=131387

Reviewed by Andreas Kling.

We'll need to rethink some things if we adopt this back-end. For example,
fastMallocSize() and fastMallocGoodSize() are no longer real things. But,
this is enough to test for now.

* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastRealloc):
(WTF::fastFree):
(WTF::fastMallocSize):
(WTF::fastMallocGoodSize):
(WTF::tryFastMalloc):
(WTF::tryFastRealloc):
(WTF::tryFastCalloc):
(WTF::releaseFastMallocFreeMemory):
(WTF::fastMallocStatistics):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMade bmalloc more #include friendly
ggaren@apple.com [Tue, 8 Apr 2014 20:36:07 +0000 (20:36 +0000)]
Made bmalloc more #include friendly
https://bugs.webkit.org/show_bug.cgi?id=131386

Reviewed by Andreas Kling.

Marked a bunch of headers private so they can be used from client code
that #includes bmalloc.h.

Renamed ASSERT macros to BASSERT. This matches their header, which already
had to be renamed, and fixes conflicts with WTF's ASSERT macros.

* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/Allocator.cpp:
(bmalloc::Allocator::allocateSlowCase):
* bmalloc/AsyncTask.h:
(bmalloc::Function>::runSlowCase):
* bmalloc/BAssert.h:
* bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::setSize):
* bmalloc/BoundaryTagInlines.h:
(bmalloc::validate):
(bmalloc::BoundaryTag::init):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::splitLarge):
(bmalloc::BoundaryTag::allocate):
* bmalloc/Chunk.h:
* bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSlowCase):
* bmalloc/Deallocator.h:
(bmalloc::Deallocator::deallocateFastCase):
* bmalloc/FixedVector.h:
(bmalloc::Capacity>::operator):
(bmalloc::Capacity>::push):
(bmalloc::Capacity>::pop):
(bmalloc::Capacity>::shrink):
* bmalloc/Heap.cpp:
(bmalloc::Heap::allocateLarge):
* bmalloc/LargeChunk.h:
(bmalloc::LargeChunk::get):
(bmalloc::LargeChunk::endTag):
* bmalloc/Line.h:
(bmalloc::Line<Traits>::concurrentRef):
(bmalloc::Line<Traits>::deref):
* bmalloc/MediumAllocator.h:
(bmalloc::MediumAllocator::allocate):
* bmalloc/ObjectType.h:
(bmalloc::isSmall):
* bmalloc/Page.h:
(bmalloc::Page<Traits>::ref):
(bmalloc::Page<Traits>::deref):
* bmalloc/PerThread.h:
(bmalloc::PerThread<T>::getSlowCase):
* bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::SegregatedFreeList):
(bmalloc::SegregatedFreeList::insert):
* bmalloc/SmallAllocator.h:
(bmalloc::SmallAllocator::allocate):
(bmalloc::SmallAllocator::refill):
* bmalloc/Syscall.h:
* bmalloc/VMAllocate.h:
(bmalloc::vmValidate):
(bmalloc::vmAllocate):
(bmalloc::vmDeallocatePhysicalPagesSloppy):
* bmalloc/Vector.h:
(bmalloc::Vector<T>::operator):
(bmalloc::Vector<T>::pop):
(bmalloc::Vector<T>::shrink):
* bmalloc/XLargeChunk.h:
(bmalloc::XLargeChunk::range):
(bmalloc::XLargeChunk::size):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix corrupt APPLE_IMAGES_LICENSE.rtf after r165676.
timothy@apple.com [Tue, 8 Apr 2014 20:32:36 +0000 (20:32 +0000)]
Fix corrupt APPLE_IMAGES_LICENSE.rtf after r165676.
https://bugs.webkit.org/show_bug.cgi?id=131384

Reviewed by Joseph Pecoraro.

* APPLE_IMAGES_LICENSE.rtf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoXPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched...
mrowe@apple.com [Tue, 8 Apr 2014 20:32:31 +0000 (20:32 +0000)]
XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
<https://webkit.org/b/131388> / <rdar://problem/16291687>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitdirs.pm:
(runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
(execMacWebKitAppForDebugging): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Always do a full GC when simulating memory pressure.
akling@apple.com [Tue, 8 Apr 2014 20:26:54 +0000 (20:26 +0000)]
[Mac] Always do a full GC when simulating memory pressure.
<https://webkit.org/b/129790>

To get more consistent accounting on automated memory testers,
add a synchronous GC as part of the simulated memory pressure event.

Reviewed by Geoffrey Garen.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix a goofy assertion to fix debug.
fpizlo@apple.com [Tue, 8 Apr 2014 20:25:34 +0000 (20:25 +0000)]
Unreviewed, fix a goofy assertion to fix debug.

* bytecode/PolymorphicPutByIdList.h:
(JSC::PutByIdAccess::isSetter):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(JSC::PutByIdAccess::customSetter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed iOS build fix. Pass 0 instead of nil to setRate: when pausing.
jer.noble@apple.com [Tue, 8 Apr 2014 20:24:19 +0000 (20:24 +0000)]
Unreviewed iOS build fix. Pass 0 instead of nil to setRate: when pausing.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded bmalloc to the WebKit workspace.
mitz@apple.com [Tue, 8 Apr 2014 20:05:07 +0000 (20:05 +0000)]
Added bmalloc to the WebKit workspace.
https://bugs.webkit.org/show_bug.cgi?id=131362

Reviewed by Geoff Garen.

* WebKit.xcworkspace/contents.xcworkspacedata:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Unreviewed GTK gardening.
commit-queue@webkit.org [Tue, 8 Apr 2014 20:04:39 +0000 (20:04 +0000)]
[GTK] Unreviewed GTK gardening.

Update text expectations for failing tests:
  accessibility/children-changed-sends-notification.html
  accessibility/notification-listeners.html
  fast/repaint/blend-mode-isolate-stacking-context.html
  fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html

Rebaseline fast/multicol/client-rects-expected.txt after r165991

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-04-08

* platform/gtk/TestExpectations:
* platform/gtk/fast/multicol/client-rects-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFail silently if the LLVM dylib isn't found
fpizlo@apple.com [Tue, 8 Apr 2014 20:03:41 +0000 (20:03 +0000)]
Fail silently if the LLVM dylib isn't found
https://bugs.webkit.org/show_bug.cgi?id=131385

Reviewed by Mark Hahnenberg.

* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* llvm/InitializeLLVM.cpp:
(JSC::initializeLLVM):
* llvm/InitializeLLVM.h:
* llvm/InitializeLLVMPOSIX.cpp:
(JSC::initializeLLVMPOSIX):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild bmalloc on iOS too
ggaren@apple.com [Tue, 8 Apr 2014 19:48:42 +0000 (19:48 +0000)]
Build bmalloc on iOS too
https://bugs.webkit.org/show_bug.cgi?id=131381

Reviewed by Andreas Kling.

.:

* Source/Makefile: Build it.

Tools:

* Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFlagsChanged events are not delivered to input methods when using async text input
ap@apple.com [Tue, 8 Apr 2014 19:42:08 +0000 (19:42 +0000)]
FlagsChanged events are not delivered to input methods when using async text input
https://bugs.webkit.org/show_bug.cgi?id=131383

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm: (-[WKView _interpretKeyEvent:completionHandler:]):
The early return is no longer needed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRepatch should support setters and plant calls to them directly
fpizlo@apple.com [Tue, 8 Apr 2014 19:39:55 +0000 (19:39 +0000)]
Repatch should support setters and plant calls to them directly
https://bugs.webkit.org/show_bug.cgi?id=130750

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

All of the infrastructure was in place so this just enables setter optimization.

This is a 12x speed-up on setter microbenchmarks. This is a 1% speed-up on Octane.

* bytecode/PolymorphicPutByIdList.cpp:
(JSC::PutByIdAccess::visitWeak):
* bytecode/PolymorphicPutByIdList.h:
(JSC::PutByIdAccess::setter):
(JSC::PutByIdAccess::customSetter): Deleted.
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
* jit/Repatch.cpp:
(JSC::toString):
(JSC::kindFor):
(JSC::customFor):
(JSC::generateByIdStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/Lookup.h:
(JSC::putEntry):
* runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::setCacheableSetter):
(JSC::PutPropertySlot::isCacheableSetter):
(JSC::PutPropertySlot::isCacheableCustom):
(JSC::PutPropertySlot::setCacheableCustomProperty): Deleted.
(JSC::PutPropertySlot::isCacheableCustomProperty): Deleted.
* tests/stress/setter.js: Added.
(foo):

LayoutTests:

Reviewed by Geoffrey Garen.

* js/regress/script-tests/setter.js: Added.
* js/regress/setter-expected.txt: Added.
* js/regress/setter.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago2014-04-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 8 Apr 2014 19:26:17 +0000 (19:26 +0000)]
2014-04-08  Geoffrey Garen  <ggaren@apple.com>

        Removed an unused file.

        Unreviewed.

        * bmalloc/AsyncTask.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefactor to make JSMainThreadExecState's constructor and destructor private.
mark.lam@apple.com [Tue, 8 Apr 2014 19:12:37 +0000 (19:12 +0000)]
Refactor to make JSMainThreadExecState's constructor and destructor private.
<https://webkit.org/b/131372>

Reviewed by Mark Hahnenberg.

This is in preparation for subsequent patches to ensure that we don't
exit the VM with an exception still pending.

No new tests required.  This is only a refactor of existing behavior.

* bindings/js/JSDOMGlobalObjectTask.cpp:
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::runTask):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up old protocol JSON files to better match the latest
timothy@apple.com [Tue, 8 Apr 2014 19:07:06 +0000 (19:07 +0000)]
Clean up old protocol JSON files to better match the latest
https://bugs.webkit.org/show_bug.cgi?id=131308

Reviewed by Joseph Pecoraro.

* Versions/Inspector-iOS-6.0.json:
* Versions/Inspector-iOS-7.0.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKit2 View Gestures (Swipe): Swipe-start hysteresis
timothy_horton@apple.com [Tue, 8 Apr 2014 19:00:26 +0000 (19:00 +0000)]
WebKit2 View Gestures (Swipe): Swipe-start hysteresis
https://bugs.webkit.org/show_bug.cgi?id=127393
<rdar://problem/15876822>

Reviewed by Anders Carlsson.

We shouldn't start a swipe immediately upon very small scrolls in the correct direction,
because we don't want to get the user trapped in a swipe when they want to scroll.

We'll accumulate the scroll deltas and wait until the user has scrolled at least 15px horizontally.
In addition, we'll drop the swipe completely if any event has a vertical delta equal to half (or more)
of the horizontal delta.

* UIProcess/mac/ViewGestureController.h:
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::deltaIsSufficientToBeginSwipe):
(WebKit::ViewGestureController::handleScrollWheelEvent):
(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac][WK2] Videos do not have access to session cookies
jer.noble@apple.com [Tue, 8 Apr 2014 18:26:51 +0000 (18:26 +0000)]
[Mac][WK2] Videos do not have access to session cookies
https://bugs.webkit.org/show_bug.cgi?id=129687

Reviewed by Eric Carlson.

Update the CookieStorageShim to track changes in underlying networking stack.

* Shared/mac/CookieStorageShim.mm:
(WebKit::CookieStorageShim::initialize):
(-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][iOS] Consecutive videos in full screen display only black
jer.noble@apple.com [Tue, 8 Apr 2014 18:22:56 +0000 (18:22 +0000)]
[WK2][iOS] Consecutive videos in full screen display only black
https://bugs.webkit.org/show_bug.cgi?id=131316

Reviewed by Eric Carlson.

Update the MediaPlayer's full screen attributes whenever the underlying engine changes,
not just when the engine is initially created. Also, clear the videoLayer out of the
fullscreen layer when destroying the videoLayer.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[New Multicolumn] Child top margin sometimes ignored for column balancing
commit-queue@webkit.org [Tue, 8 Apr 2014 18:19:47 +0000 (18:19 +0000)]
[New Multicolumn] Child top margin sometimes ignored for column balancing
https://bugs.webkit.org/show_bug.cgi?id=122754

Patch by Morten Stenshorne <mstensho@opera.com> on 2014-04-08
Reviewed by David Hyatt.

Source/WebCore:

We need to set zero page logical height in LayoutState when column
height is unknown (when the columns haven't yet been
balanced). There's code that assumes that non-zero page height means
that page height is known. Lying about this makes the pagination code
believe that every top margin is adjacent to a column break, which
makes it eat and ignore all top margins.

This should be cleaned up, but it's easier to wait until the old
multicol code has been removed.

Tests: fast/multicol/break-in-scrollable.html
       fast/multicol/newmulticol/leading-and-trailing-margin.html
       fast/multicol/newmulticol/leading-margin.html

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):
* rendering/RenderFlowThread.h:
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::isPageLogicalHeightKnown):
* rendering/RenderMultiColumnFlowThread.h:

LayoutTests:

* fast/multicol/break-in-scrollable-expected.html: Added.
* fast/multicol/break-in-scrollable.html: Added.
* fast/multicol/newmulticol/leading-and-trailing-margin-expected.html: Added.
* fast/multicol/newmulticol/leading-and-trailing-margin.html: Added.
* fast/multicol/newmulticol/leading-margin-expected.html: Added.
* fast/multicol/newmulticol/leading-margin.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow elements to register for changes in page scale
dino@apple.com [Tue, 8 Apr 2014 18:06:11 +0000 (18:06 +0000)]
Allow elements to register for changes in page scale
https://bugs.webkit.org/show_bug.cgi?id=131319

Reviewed by Eric Carlson.

Some parts of WebCore need to react to changes in the page
scale factor, such as resizing when the user zooms. A followup
patch will enable this for media controls - this simply lays
the groundwork.

At the moment we only allow HTMLMediaElements to register, but if
necessary this could be expanded in the future.

* dom/Document.cpp: New methods to keep a list of HTMLMediaElements that
are interested in updates.
(WebCore::Document::registerForPageScaleFactorChangedCallbacks):
(WebCore::Document::unregisterForPageScaleFactorChangedCallbacks):
(WebCore::Document::pageScaleFactorChanged):
* dom/Document.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument): Add ourselves to the
the document's pageScale callback.
(WebCore::HTMLMediaElement::unregisterWithDocument): Remove ourselves from the
the document's pageScale callback.
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Add/remove ourselves to/from
the callback if necessary.
(WebCore::HTMLMediaElement::pageScaleFactorChanged): The callback function. Empty for now.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaControlsDependOnPageScaleFactor): Accessor.
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor): Tell all documents that the user has zoomed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML...
mitz@apple.com [Tue, 8 Apr 2014 18:04:59 +0000 (18:04 +0000)]
[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element
https://bugs.webkit.org/show_bug.cgi?id=131374

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(-[WKWebProcessPlugInNodeHandle isTextField]): Added this getter. Calls
InjectedBundleNodeHandle::isTextField.
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isTextField): Added. Uses
WebCore::HTMLInputElement::isText, which is consistent with what
WebChromeClient::focusedElementChanged uses to decide whether to call didFocusTextField.
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Add a _certificateChain property to WKWebProcessPlugInFrame
mitz@apple.com [Tue, 8 Apr 2014 17:45:50 +0000 (17:45 +0000)]
[Cocoa] Add a _certificateChain property to WKWebProcessPlugInFrame
https://bugs.webkit.org/show_bug.cgi?id=131370

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame _certificateChain]): Added this getter, which uses the new
WebFrame::certificateInfo.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::certificateInfo): Added this getter.
* WebProcess/WebPage/WebFrame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Add a bundle form delegate method corresponding to textDidChangeInTextField
mitz@apple.com [Tue, 8 Apr 2014 17:36:39 +0000 (17:36 +0000)]
[Cocoa] Add a bundle form delegate method corresponding to textDidChangeInTextField
https://bugs.webkit.org/show_bug.cgi?id=131369

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Declared
new delegate method.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added an override
of API::InjectedBundle::FormClient::textDidChangeInTextField which calls the new delegate
method.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago../WebKit/mac: WebKit part of [Cocoa] Add WKFormDelegate
mitz@apple.com [Tue, 8 Apr 2014 17:17:44 +0000 (17:17 +0000)]
../WebKit/mac: WebKit part of [Cocoa] Add WKFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=131343

Reviewed by Anders Carlsson.

* MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.

../WebKit2: [Cocoa] Add WKFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=131343

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _formDelegate]): Added this accessor.
(-[WKWebView _setFormDelegate:]): Ditto.
* UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared _formDelegate property.

* UIProcess/API/Cocoa/_WKFormDelegate.h: Added.

* UIProcess/API/Cocoa/_WKFormInputSession.h: Added.

* UIProcess/ios/WKContentView.h: Moved _webView ivar into the @interface…
* UIProcess/ios/WKContentView.mm: …from the @implementation.

* UIProcess/ios/WKContentViewInteraction.h: Added _formInputSession ivar and
formAccessoryView property.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession initWithContentView:userObject:]): Added.
(-[WKFormInputSession dealloc]): Added.
(-[WKFormInputSession userObject]): Added.
(-[WKFormInputSession isValid]): Added.
(-[WKFormInputSession accessoryViewCustomButtonTitle]): Added.
(-[WKFormInputSession setAccessoryViewCustomButtonTitle:]): Added.
(-[WKFormInputSession invalidate]): Added.
(-[WKContentView cleanupInteraction]): Invalidate and release the input session.
(-[WKContentView formAccessoryView]): Added this accessor.
(-[WKContentView _startAssistingNode:userObject:]): Create an input session and message the
form delegate.
(-[WKContentView _stopAssistingNode]): Invalidate and release the input session.

* WebKit2.xcodeproj/project.pbxproj: Added references to new files.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Added
comment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening: Prevent users from attempting
bfulgham@apple.com [Tue, 8 Apr 2014 16:47:12 +0000 (16:47 +0000)]
Unreviewed gardening: Prevent users from attempting
to build with known invalid cURL.

* Scripts/webkitdirs.pm:
(checkInstalledTools): Block build attempts with bad
Cygwin tool set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Compile error in TextureMapper.h
commit-queue@webkit.org [Tue, 8 Apr 2014 16:40:04 +0000 (16:40 +0000)]
[WinCairo] Compile error in TextureMapper.h
https://bugs.webkit.org/show_bug.cgi?id=131360

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-04-08
Reviewed by Brent Fulgham.

The TextureMapper class has pure virtual methods, and cannot be instantiated.

* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::platformCreateAccelerated):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebVTT] Begin Enabling W3C VTT Tests
bfulgham@apple.com [Tue, 8 Apr 2014 16:26:24 +0000 (16:26 +0000)]
[WebVTT] Begin Enabling W3C VTT Tests
https://bugs.webkit.org/show_bug.cgi?id=131345

Reviewed by Darin Adler.

Move a number of tests out of 'opera' into a new 'w3c' folder.

* media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks.html: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default.html: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label.html: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState.html: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang.html: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt: Removed.
* media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track.html: Removed.
* media/track/opera/interfaces/TextTrack/addCue-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/addCue.html: Removed.
* media/track/opera/interfaces/TextTrack/constants-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/constants.html: Removed.
* media/track/opera/interfaces/TextTrack/cues-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/cues.html: Removed.
* media/track/opera/interfaces/TextTrack/kind-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/kind.html: Removed.
* media/track/opera/interfaces/TextTrack/label-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/label.html: Removed.
* media/track/opera/interfaces/TextTrack/language-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/language.html: Removed.
* media/track/opera/interfaces/TextTrack/mode-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/mode.html: Removed.
* media/track/opera/interfaces/TextTrack/oncuechange-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/oncuechange.html: Removed.
* media/track/opera/interfaces/TextTrack/removeCue-expected.txt: Removed.
* media/track/opera/interfaces/TextTrack/removeCue.html: Removed.
* media/track/opera/interfaces/TextTrackCue/align-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCue/align.html: Removed.
* media/track/opera/interfaces/TextTrackCue/endTime-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCue/endTime.html: Removed.
* media/track/opera/interfaces/TextTrackCue/id-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCue/id.html: Removed.
* media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCue/pauseOnExit.html: Removed.
* media/track/opera/interfaces/TextTrackCue/startTime-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCue/startTime.html: Removed.
* media/track/opera/interfaces/TextTrackCue/track-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCue/track.html: Removed.
* media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCueList/getCueById.html: Removed.
* media/track/opera/interfaces/TextTrackCueList/length-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackCueList/length.html: Removed.
* media/track/opera/interfaces/TextTrackList/length-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackList/length.html: Removed.
* media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackList/onaddtrack.html: Removed.
* media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Removed.
* media/track/opera/interfaces/TextTrackList/onremovetrack.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/2_tracks-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/2_tracks.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_end-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_end.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_start-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/align_start.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/basic-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/basic.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/media/background.gif: Removed.
* media/track/opera/track/webvtt/rendering/reftest/media/white.mp4: Removed.
* media/track/opera/track/webvtt/rendering/reftest/media/white.webm: Removed.
* media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/size_50-ref.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/size_50.html: Removed.
* media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_completely_move_up.vtt: Removed.
* media/track/opera/track/webvtt/rendering/reftest/support/align_end_long.vtt: Removed.
* media/track/opera/track/webvtt/rendering/reftest/support/foo.vtt: Removed.
* media/track/opera/track/webvtt/rendering/reftest/support/refTestWait.js: Removed.
* media/track/w3c: Added.
* media/track/w3c/interfaces: Added.
* media/track/w3c/interfaces/HTMLMediaElement: Added.
* media/track/w3c/interfaces/HTMLMediaElement/addTextTrack-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt.
* media/track/w3c/interfaces/HTMLMediaElement/addTextTrack.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html.
* media/track/w3c/interfaces/HTMLMediaElement/textTracks-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt.
* media/track/w3c/interfaces/HTMLMediaElement/textTracks.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks.html.
* media/track/w3c/interfaces/HTMLTrackElement: Added.
* media/track/w3c/interfaces/HTMLTrackElement/default-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt.
* media/track/w3c/interfaces/HTMLTrackElement/default.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default.html.
* media/track/w3c/interfaces/HTMLTrackElement/label-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt.
* media/track/w3c/interfaces/HTMLTrackElement/label.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label.html.
* media/track/w3c/interfaces/HTMLTrackElement/readyState-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt.
* media/track/w3c/interfaces/HTMLTrackElement/readyState.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState.html.
* media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt.
* media/track/w3c/interfaces/HTMLTrackElement/srclang.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang.html.
* media/track/w3c/interfaces/HTMLTrackElement/track-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt.
* media/track/w3c/interfaces/HTMLTrackElement/track.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track.html.
* media/track/w3c/interfaces/TextTrack: Added.
* media/track/w3c/interfaces/TextTrack/addCue-expected.txt: Copied from media/track/opera/interfaces/TextTrack/addCue-expected.txt.
* media/track/w3c/interfaces/TextTrack/addCue.html: Copied from media/track/opera/interfaces/TextTrack/addCue.html.
* media/track/w3c/interfaces/TextTrack/constants-expected.txt: Copied from media/track/opera/interfaces/TextTrack/constants-expected.txt.
* media/track/w3c/interfaces/TextTrack/constants.html: Copied from media/track/opera/interfaces/TextTrack/constants.html.
* media/track/w3c/interfaces/TextTrack/cues-expected.txt: Copied from media/track/opera/interfaces/TextTrack/cues-expected.txt.
* media/track/w3c/interfaces/TextTrack/cues.html: Copied from media/track/opera/interfaces/TextTrack/cues.html.
* media/track/w3c/interfaces/TextTrack/kind-expected.txt: Copied from media/track/opera/interfaces/TextTrack/kind-expected.txt.
* media/track/w3c/interfaces/TextTrack/kind.html: Copied from media/track/opera/interfaces/TextTrack/kind.html.
* media/track/w3c/interfaces/TextTrack/label-expected.txt: Copied from media/track/opera/interfaces/TextTrack/label-expected.txt.
* media/track/w3c/interfaces/TextTrack/label.html: Copied from media/track/opera/interfaces/TextTrack/label.html.
* media/track/w3c/interfaces/TextTrack/language-expected.txt: Copied from media/track/opera/interfaces/TextTrack/language-expected.txt.
* media/track/w3c/interfaces/TextTrack/language.html: Copied from media/track/opera/interfaces/TextTrack/language.html.
* media/track/w3c/interfaces/TextTrack/mode-expected.txt: Copied from media/track/opera/interfaces/TextTrack/mode-expected.txt.
* media/track/w3c/interfaces/TextTrack/mode.html: Copied from media/track/opera/interfaces/TextTrack/mode.html.
* media/track/w3c/interfaces/TextTrack/oncuechange-expected.txt: Copied from media/track/opera/interfaces/TextTrack/oncuechange-expected.txt.
* media/track/w3c/interfaces/TextTrack/oncuechange.html: Copied from media/track/opera/interfaces/TextTrack/oncuechange.html.
* media/track/w3c/interfaces/TextTrack/removeCue-expected.txt: Copied from media/track/opera/interfaces/TextTrack/removeCue-expected.txt.
* media/track/w3c/interfaces/TextTrack/removeCue.html: Copied from media/track/opera/interfaces/TextTrack/removeCue.html.
* media/track/w3c/interfaces/TextTrackCue: Added.
* media/track/w3c/interfaces/TextTrackCue/align-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/align-expected.txt.
* media/track/w3c/interfaces/TextTrackCue/align.html: Copied from media/track/opera/interfaces/TextTrackCue/align.html.
* media/track/w3c/interfaces/TextTrackCue/endTime-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/endTime-expected.txt.
* media/track/w3c/interfaces/TextTrackCue/endTime.html: Copied from media/track/opera/interfaces/TextTrackCue/endTime.html.
* media/track/w3c/interfaces/TextTrackCue/id-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/id-expected.txt.
* media/track/w3c/interfaces/TextTrackCue/id.html: Copied from media/track/opera/interfaces/TextTrackCue/id.html.
* media/track/w3c/interfaces/TextTrackCue/pauseOnExit-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt.
* media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html: Copied from media/track/opera/interfaces/TextTrackCue/pauseOnExit.html.
* media/track/w3c/interfaces/TextTrackCue/startTime-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/startTime-expected.txt.
* media/track/w3c/interfaces/TextTrackCue/startTime.html: Copied from media/track/opera/interfaces/TextTrackCue/startTime.html.
* media/track/w3c/interfaces/TextTrackCue/track-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/track-expected.txt.
* media/track/w3c/interfaces/TextTrackCue/track.html: Copied from media/track/opera/interfaces/TextTrackCue/track.html.
* media/track/w3c/interfaces/TextTrackCueList: Added.
* media/track/w3c/interfaces/TextTrackCueList/getCueById-expected.txt: Copied from media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt.
* media/track/w3c/interfaces/TextTrackCueList/getCueById.html: Copied from media/track/opera/interfaces/TextTrackCueList/getCueById.html.
* media/track/w3c/interfaces/TextTrackCueList/length-expected.txt: Copied from media/track/opera/interfaces/TextTrackCueList/length-expected.txt.
* media/track/w3c/interfaces/TextTrackCueList/length.html: Copied from media/track/opera/interfaces/TextTrackCueList/length.html.
* media/track/w3c/interfaces/TextTrackList: Added.
* media/track/w3c/interfaces/TextTrackList/length-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/length-expected.txt.
* media/track/w3c/interfaces/TextTrackList/length.html: Copied from media/track/opera/interfaces/TextTrackList/length.html.
* media/track/w3c/interfaces/TextTrackList/onaddtrack-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt.
* media/track/w3c/interfaces/TextTrackList/onaddtrack.html: Copied from media/track/opera/interfaces/TextTrackList/onaddtrack.html.
* media/track/w3c/interfaces/TextTrackList/onremovetrack-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt.
* media/track/w3c/interfaces/TextTrackList/onremovetrack.html: Copied from media/track/opera/interfaces/TextTrackList/onremovetrack.html.
* media/track/w3c/track: Added.
* media/track/w3c/track/webvtt: Added.
* media/track/w3c/track/webvtt/2_tracks-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/2_tracks-ref.html.
* media/track/w3c/track/webvtt/2_tracks.html: Copied from media/track/opera/track/webvtt/rendering/reftest/2_tracks.html.
* media/track/w3c/track/webvtt/align_end-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_end-ref.html.
* media/track/w3c/track/webvtt/align_end.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_end.html.
* media/track/w3c/track/webvtt/align_middle-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle-ref.html.
* media/track/w3c/track/webvtt/align_middle.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle.html.
* media/track/w3c/track/webvtt/align_middle_position_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50-ref.html.
* media/track/w3c/track/webvtt/align_middle_position_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50.html.
* media/track/w3c/track/webvtt/align_middle_position_gt_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50-ref.html.
* media/track/w3c/track/webvtt/align_middle_position_gt_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50.html.
* media/track/w3c/track/webvtt/align_middle_position_lt_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50-ref.html.
* media/track/w3c/track/webvtt/align_middle_position_lt_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50.html.
* media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size-ref.html.
* media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size.html.
* media/track/w3c/track/webvtt/align_start-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_start-ref.html.
* media/track/w3c/track/webvtt/align_start.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_start.html.
* media/track/w3c/track/webvtt/audio_has_no_subtitles-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles-ref.html.
* media/track/w3c/track/webvtt/audio_has_no_subtitles.html: Copied from media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles.html.
* media/track/w3c/track/webvtt/background.gif: Copied from media/track/opera/track/webvtt/rendering/reftest/media/background.gif.
* media/track/w3c/track/webvtt/basic-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/basic-ref.html.
* media/track/w3c/track/webvtt/basic.html: Copied from media/track/opera/track/webvtt/rendering/reftest/basic.html.
* media/track/w3c/track/webvtt/decode_escaped_entities-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities-ref.html.
* media/track/w3c/track/webvtt/decode_escaped_entities.html: Copied from media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities.html.
* media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size-ref.html.
* media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size.html.
* media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused-ref.html.
* media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused.html.
* media/track/w3c/track/webvtt/dom_override_cue_text-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text-ref.html.
* media/track/w3c/track/webvtt/dom_override_cue_text.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text.html.
* media/track/w3c/track/webvtt/dom_override_cue_text_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused-ref.html.
* media/track/w3c/track/webvtt/dom_override_cue_text_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused.html.
* media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused-ref.html.
* media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused.html.
* media/track/w3c/track/webvtt/media: Added.
* media/track/w3c/track/webvtt/media/white.mp4: Copied from media/track/opera/track/webvtt/rendering/reftest/media/white.mp4.
* media/track/w3c/track/webvtt/media/white.webm: Copied from media/track/opera/track/webvtt/rendering/reftest/media/white.webm.
* media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue-ref.html.
* media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue.html: Copied from media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue.html.
* media/track/w3c/track/webvtt/size_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/size_50-ref.html.
* media/track/w3c/track/webvtt/size_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/size_50.html.
* media/track/w3c/track/webvtt/support: Added.
* media/track/w3c/track/webvtt/support/2_cues_overlapping_completely_move_up.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_completely_move_up.vtt.
* media/track/w3c/track/webvtt/support/align_end_long.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/align_end_long.vtt.
* media/track/w3c/track/webvtt/support/foo.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/foo.vtt.
* media/track/w3c/track/webvtt/support/refTestWait.js: Copied from media/track/opera/track/webvtt/rendering/reftest/support/refTestWait.js.
* platform/eft/TestExpectations: Skip w3c tests.
* platform/gtk/TestExpectations: Skip w3c tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Slow paint path for inlines should snap to device pixels.
zalan@apple.com [Tue, 8 Apr 2014 16:19:56 +0000 (16:19 +0000)]
Subpixel rendering: Slow paint path for inlines should snap to device pixels.
https://bugs.webkit.org/show_bug.cgi?id=131259

Reviewed by Simon Fraser.

InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.

Source/WebCore:

Test: fast/inline/hidpi-slow-path-text-on-subpixel-position.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
* rendering/TextPainter.h: Cleanup. No reason to have them as references here.

LayoutTests:

* fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html: Added.
* fast/inline/hidpi-slow-path-text-on-subpixel-position.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFallback to default storage session when there isn't a valid session ID
dbates@webkit.org [Tue, 8 Apr 2014 16:09:29 +0000 (16:09 +0000)]
Fallback to default storage session when there isn't a valid session ID
https://bugs.webkit.org/show_bug.cgi?id=131326
<rdar://problem/16231679>

Reviewed by Alexey Proskuryakov.

Fixes and issue where we may use the wrong storage session after disabling
a private browsing session.

Currently WebKit1 and WebKit2 without NetworkProcess assume that there
is always a non-null private browsing storage session so long as the page
has a non-default session ID. Instead we should only use the private browsing
storage session when it's non-null and the page has a non-default session ID;
otherwise, we should use the default storage session. This change will make
the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
the behavior in WebKit2 with NetworkProcess.

Source/WebKit/mac:

* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::storageSession):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::storageSession):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoKeep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
bfulgham@apple.com [Tue, 8 Apr 2014 16:01:38 +0000 (16:01 +0000)]
Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
https://bugs.webkit.org/show_bug.cgi?id=131344

Reviewed by Eric Carlson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup) If we decide that captions should
be active (due to user preferences) make sure the 'webkitClosedCaptionsVisible' state
is turned on.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Paint the filter effect result image on device pixel position.
zalan@apple.com [Tue, 8 Apr 2014 14:52:33 +0000 (14:52 +0000)]
Subpixel rendering: Paint the filter effect result image on device pixel position.
https://bugs.webkit.org/show_bug.cgi?id=131255

Reviewed by Simon Fraser.

This patch moves filter effect images from integral to device pixel position. However,
result images are still integral based.

Source/WebCore:

Test: css3/filters/hidpi-filter-is-on-subpixel-position.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect):

LayoutTests:

* css3/filters/hidpi-filter-is-on-subpixel-position-expected.html: Added.
* css3/filters/hidpi-filter-is-on-subpixel-position.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel rendering: Make border images device pixel aware.
zalan@apple.com [Tue, 8 Apr 2014 14:50:38 +0000 (14:50 +0000)]
Subpixel rendering: Make border images device pixel aware.
https://bugs.webkit.org/show_bug.cgi?id=131209

Reviewed by Simon Fraser.

Snap border-image size and position to device pixels. It works both on generated and bitmap images.

Source/WebCore:

Test: fast/borders/hidpi-border-image-gradient-on-subpixels.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

* fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html: Added.
* fast/borders/hidpi-border-image-gradient-on-subpixels.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SOUP] Control cookie management according ResourceRequest.allowCookies()
commit-queue@webkit.org [Tue, 8 Apr 2014 12:09:51 +0000 (12:09 +0000)]
[SOUP] Control cookie management according ResourceRequest.allowCookies()
https://bugs.webkit.org/show_bug.cgi?id=131026

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-04-08
Reviewed by Sergio Villar Senin.

Source/WebCore:

Added per soup-message disabling of cookie jar manager when related ResourceRequest does not allow cookies (e.g. some cross-origin requests).

Patch is covered by unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageMembers): Added disabling of cookie jar manager if cookies are not allowed.

Source/WebKit2:

Added setting of accept cookies policy for the current soup network session cookie jar and all tracked sessions.
Moved the implementation of cookie policy setting from WebCookieManager to WebFrameNetworkingContext.

* WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Moved implementation to WebCookieManager::platformSetHTTPCookieAcceptPolicy.
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Moved implementation from WebCookieManager::platformSetHTTPCookieAcceptPolicy and set the cookie jar accept policy to the cookie jars of all sessions in addition to the default cookie jar.
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Added method prototype.

LayoutTests:

* platform/efl/TestExpectations: Unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html.
* platform/gtk/TestExpectations: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Handle min/max height in the grid element
svillar@igalia.com [Tue, 8 Apr 2014 12:05:33 +0000 (12:05 +0000)]
[CSS Grid Layout] Handle min/max height in the grid element
https://bugs.webkit.org/show_bug.cgi?id=131302

Reviewed by Darin Adler.

Source/WebCore:

Removed a FIXME in the code as we're already handling min/max
height in the code. Added a couple of test cases to improve the
test coverage.

Merged from Blink r161876 by <jchaffraix@chromium.org>

Tests: fast/css-grid-layout/flex-content-sized-columns-resize.html
       fast/css-grid-layout/grid-element-min-max-height.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

Added test coverage for min/max height handling in the grid
item. Also added other test to cover a blind spot in our testing,
resizing of content sized columns with flexible breadths.

Merged from Blink r161876 by <jchaffraix@chromium.org> and r166914 by <rego@igalia.com>.

* fast/css-grid-layout/flex-content-sized-columns-resize-expected.html: Added.
* fast/css-grid-layout/flex-content-sized-columns-resize.html: Added.
* fast/css-grid-layout/grid-element-min-max-height-expected.txt: Added.
* fast/css-grid-layout/grid-element-min-max-height.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Remove unused RenderBox::clearRenderBoxRegionInfo
mihnea@adobe.com [Tue, 8 Apr 2014 09:21:44 +0000 (09:21 +0000)]
[CSSRegions] Remove unused RenderBox::clearRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=131352

Reviewed by Andrei Bucur.

No new tests, code clean-up.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::clearRenderBoxRegionInfo): Deleted.
* rendering/RenderBox.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuildfix after r166917
commit-queue@webkit.org [Tue, 8 Apr 2014 09:15:06 +0000 (09:15 +0000)]
Buildfix after r166917
https://bugs.webkit.org/show_bug.cgi?id=131351

Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-04-08
Reviewed by Andrei Bucur.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix assertions triggered by CSS calc changes in r166860
darin@apple.com [Tue, 8 Apr 2014 08:58:43 +0000 (08:58 +0000)]
Fix assertions triggered by CSS calc changes in r166860
https://bugs.webkit.org/show_bug.cgi?id=131346

Reviewed by Andrei Bucur.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValues): Use isPercentNotCalculated() instead of
type() == Percent; no behavior change.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::lineHeightFromStyle): Use isPercentNotCalculated() before code
that calls percent(), which won't work for a calculated length.

* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue): Use isNegative and isZero rather
than calling value() unconditionally. Should make calculated values work better.

* html/HTMLPlugInImageElement.cpp:
(WebCore::is100Percent): Use isPercentNotCalculated() before code
that calls percent(), which won't work for a calculated length.

* platform/Length.cpp:
(WebCore::CalculationValueMap::deref): Use adoptRef here instead of calling deref
immediately, so the deref will happen after calling remove. This makes the code
work properly even if it's reentered inside the calculation value's destructor.

* platform/Length.h:
(WebCore::Length::percent): Change assert to isPercentNotCalculated, since the
value function this calls only works for non-calculated values anyway.
(WebCore::Length::isPercentNotCalculated): Added.
(WebCore::Length::isPercent): Changed to call isPercentNotCalculated.
(WebCore::Length::isSpecified): Changed to call isPercent.

* platform/graphics/transforms/TranslateTransformOperation.h:
(WebCore::TranslateTransformOperation::apply): Use isPercentNotCalculated()
instead of type() == Percent; no behavior change.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn): Use isPercentNotCalculated()
before code that calls value() or percent(), which won't work for a calculated length.
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths): Ditto.
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth): Ditto.
(WebCore::AutoTableLayout::layout): Ditto.
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout): Ditto.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Ditto.
* rendering/RenderTableSection.cpp:
(WebCore::updateLogicalHeightForCell): Ditto.
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows): Ditto.
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows): Ditto.

* rendering/style/RenderStyle.cpp:
(WebCore::requireTransformOrigin): Use modern for loop. Also marked function static,
since it's private to this file.
(WebCore::RenderStyle::applyTransform): Use isPercentNotCalculated() instead of
type() == Percent; no behavior change. Also use a modern for loop and auto& to avoid
a really long type name.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Use isPercentNotCalculated()
before code that calls percent(), which won't work for a calculated length.

* platform/Length.h:
(WebCore::Length::percent):
(WebCore::Length::isPercentNotCalculated):
(WebCore::Length::isPercent):
(WebCore::Length::isSpecified):
* platform/graphics/transforms/TranslateTransformOperation.h:
(WebCore::TranslateTransformOperation::apply):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
* rendering/RenderTableSection.cpp:
(WebCore::updateLogicalHeightForCell):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
* rendering/style/RenderStyle.cpp:
(WebCore::requireTransformOrigin):
(WebCore::RenderStyle::applyTransform):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove media controls dead code
calvaris@igalia.com [Tue, 8 Apr 2014 08:15:39 +0000 (08:15 +0000)]
[GTK] Remove media controls dead code
https://bugs.webkit.org/show_bug.cgi?id=131300

Reviewed by Eric Carlson.

MediaControlsGtk.cpp is no longer used so we can remove it from
the repo.

No new tests needed.

* PlatformGTK.cmake: Remove html/shadow/MediaControlsGtk.cpp from
compilation.
* html/shadow/MediaControlsGtk.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Fixed positioned elements in named flows have fragmented content
mihnea@adobe.com [Tue, 8 Apr 2014 08:13:11 +0000 (08:13 +0000)]
[CSSRegions] Fixed positioned elements in named flows have fragmented content
https://bugs.webkit.org/show_bug.cgi?id=130595

Reviewed by Darin Adler.

Source/WebCore:

Fixed positioned elements that have the named flow as parent are positioned
and sized relative to the viewport. Because of that, when the named flow
has an associated region chain, the fixed positioned elements should not
be fragmented.

By making a fixed positioned element with a named flow parent unsplittable
for fragmentation, we prevent this wrong behavior.

Test: fast/regions/fixed-pos-content-fragmented.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination):

LayoutTests:

* fast/regions/fixed-pos-content-fragmented-expected.html: Added.
* fast/regions/fixed-pos-content-fragmented.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression: AX: image labels no longer exposed to AX API in SVG test case
cfleizach@apple.com [Tue, 8 Apr 2014 07:59:22 +0000 (07:59 +0000)]
Regression: AX: image labels no longer exposed to AX API in SVG test case
https://bugs.webkit.org/show_bug.cgi?id=131208

Reviewed by Daniel Bates.

Source/WebCore:

accessibleNameForNode should work on any Element, not just HTML elements.

Test: accessibility/svg-labelledby.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):

LayoutTests:

* accessibility/svg-labelledby-expected.txt: Added.
* accessibility/svg-labelledby.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] [EFL] Build fails with GCC < 4.8.x
agomez@igalia.com [Tue, 8 Apr 2014 07:37:37 +0000 (07:37 +0000)]
[GTK] [EFL] Build fails with GCC < 4.8.x
https://bugs.webkit.org/show_bug.cgi?id=130585

Reviewed by Martin Robinson.

The behavior in lower versions of GCC seem to be related to
http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2132.

Provided explicit casts for the failing ambiguous overloads.

Source/WebCore:

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
* platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcChangeState):
(webKitMediaVideoSrcNeedDataCb):
(webKitMediaAudioSrcNeedDataCb):
(webKitMediaVideoSrcEnoughDataCb):
(webKitMediaAudioSrcEnoughDataCb):
(webKitMediaVideoSrcSeekDataCb):
(webKitMediaAudioSrcSeekDataCb):
* platform/gtk/GtkDragAndDropHelper.cpp:
(WebCore::GtkDragAndDropHelper::handleDragLeave):
* platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireInterval):

Source/WTF:

* wtf/gtk/MainThreadGtk.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
* wtf/gtk/RunLoopGtk.cpp:
(WTF::RunLoop::wakeUp): Provided lambda with a RefPtr instead of
ref and de-referring.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange NavigatorContentUtils client ownership from port side to NavigatorContentUtils
gyuyoung.kim@samsung.com [Tue, 8 Apr 2014 07:14:20 +0000 (07:14 +0000)]
Change NavigatorContentUtils client ownership from port side to NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=131299

Reviewed by Darin Adler.

EFL and GTK ports have managed own client of NavigatorContentUtils though it is only passed to
NavigatorContentUtils. The NavigatorContentUtils has used the client to call port functions. So,
there is no reason port implementation needs to manage the ownership. To manage the client is
unnecessary work in current implementation.

Source/WebCore:

No new tests, no behavior changes.

* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::NavigatorContentUtils::create):
(WebCore::provideNavigatorContentUtilsTo):
* Modules/navigatorcontentutils/NavigatorContentUtils.h:
* Modules/navigatorcontentutils/NavigatorContentUtilsClient.h:

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

Source/WebKit/gtk:

* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Fix unused parameter compile warning
gyuyoung.kim@samsung.com [Tue, 8 Apr 2014 06:55:22 +0000 (06:55 +0000)]
[WK2] Fix unused parameter compile warning
https://bugs.webkit.org/show_bug.cgi?id=131260

Reviewed by Darin Adler.

Remove the arguments name without UNUSED_PARAM().

* UIProcess/API/APIDownloadClient.h:
(API::DownloadClient::didReceiveData):
(API::DownloadClient::shouldDecodeSourceDataOfMIMEType):
(API::DownloadClient::decideDestinationWithSuggestedFilename):
(API::DownloadClient::didCreateDestination):
* UIProcess/API/APIFindClient.h:
(API::FindClient::didCountStringMatches):
(API::FindClient::didFindString):
* UIProcess/API/APIHistoryClient.h:
(API::HistoryClient::didPerformClientRedirect):
(API::HistoryClient::didPerformServerRedirect):
(API::HistoryClient::didUpdateHistoryTitle):
* UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didStartProvisionalLoadForFrame):
(API::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(API::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(API::LoaderClient::didCommitLoadForFrame):
(API::LoaderClient::didFinishLoadForFrame):
(API::LoaderClient::didFailLoadWithErrorForFrame):
(API::LoaderClient::didChangeBackForwardList):
* UIProcess/API/APIPolicyClient.h:
(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
(API::PolicyClient::unableToImplementPolicy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Allow com.apple.ViewBridge preferences reading in plug-in sandbox profile
ap@apple.com [Tue, 8 Apr 2014 06:51:51 +0000 (06:51 +0000)]
[Mac] Allow com.apple.ViewBridge preferences reading in plug-in sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=131306
<rdar://problem/16359865>

Reviewed by Sam Weinig.

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Do it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkipped some HighDPI tests for GTK+
mrobinson@webkit.org [Tue, 8 Apr 2014 06:09:32 +0000 (06:09 +0000)]
Skipped some HighDPI tests for GTK+

* platform/gtk/TestExpectations: GTK+ does not yet have HighDPI support.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove WebKit1 test results and merge TestExpectations files
mrobinson@webkit.org [Tue, 8 Apr 2014 06:02:01 +0000 (06:02 +0000)]
[GTK] Remove WebKit1 test results and merge TestExpectations files
https://bugs.webkit.org/show_bug.cgi?id=131342

Merge all WebKit1 test expectations into the gtk directory and also merge the WebKit2
test expectations files into the GTK+ one, removing duplicate lines.

* http/tests/security/resources/drag-drop-allowed-expected.txt: Added.
* platform/gtk-wk1: Removed.
* platform/gtk-wk2: Removed.
* platform/gtk/TestExpectations: Merged in WebKit2 expectations.
* platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/file-upload-button-stringvalue-expected.txt.
* platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt:
* platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt:
* platform/gtk/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt.
* platform/gtk/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt.
* platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/401-alternative-content-expected.txt.
* platform/gtk/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt.
* platform/gtk/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt.
* platform/gtk/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt.
* platform/gtk/http/tests/security/401-logout/401-logout-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/security/401-logout/401-logout-expected.txt.
* platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/xmlhttprequest/failed-auth-expected.txt.
* platform/gtk/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt.
* platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt:
* platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt:
* platform/gtk/plugins/plugin-clip-subframe-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild bmalloc on Mac
ggaren@apple.com [Tue, 8 Apr 2014 05:31:41 +0000 (05:31 +0000)]
Build bmalloc on Mac
https://bugs.webkit.org/show_bug.cgi?id=131333

Reviewed by Mark Rowe.

.:

* Source/Makefile:
* WebKitBuild: Added.
* WebKitBuild/Debug: Added.

Source/bmalloc:

* Makefile: Added. For make clients.

These files are required for building any project in WebKit. I copied
them from WTF:
* Configurations: Added.
* Configurations/Base.xcconfig: Added.
* Configurations/DebugRelease.xcconfig: Added.
* Configurations/bmalloc.xcconfig: Added.
* Configurations/iOS.xcconfig: Added.
* Configurations/mbmalloc.xcconfig: Added.

* bmalloc.xcodeproj/project.pbxproj: I removed per-project-file stuff
from here because everything is in .xcconfig files now.

I had to fix a bunch of minor warnings, since they're enabled in our
.xcconfig files:

* bmalloc/AsyncTask.h:
(bmalloc::Function>::AsyncTask):
* bmalloc/BAssert.h:
* bmalloc/BoundaryTagInlines.h:
(bmalloc::validate):
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
(bmalloc::Heap::allocateLarge):
(bmalloc::Heap::deallocateLarge):
* bmalloc/Mutex.h:
(bmalloc::Mutex::Mutex): Deleted.
* bmalloc/VMAllocate.h:
(bmalloc::vmValidate):
* bmalloc/mbmalloc.cpp:

Tools:

* Scripts/build-webkit: Add the bmalloc target if we're on Mac.
(Note: Just testing Mac is not good enough because in this
script 'Mac' means 'Mac or iOS'.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Simplify the parsing of width arguments for Inset shapes
zoltan@webkit.org [Tue, 8 Apr 2014 04:47:05 +0000 (04:47 +0000)]
[CSS Shapes] Simplify the parsing of width arguments for Inset shapes
https://bugs.webkit.org/show_bug.cgi?id=131305

Reviewed by Andreas Kling.

This code introduces some helper functions for setting the size arguments of inset shapes. This change
also modifies the code to be the same as in Blink, so it helps us to keep the shapes code similar.

No new tests, no behavior change.

* css/CSSBasicShapes.h:
(WebCore::CSSBasicShapeInset::updateShapeSize4Values):
(WebCore::CSSBasicShapeInset::updateShapeSize1Value):
(WebCore::CSSBasicShapeInset::updateShapeSize2Values):
(WebCore::CSSBasicShapeInset::updateShapeSize3Values):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseBasicShapeInset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSetters are just getters that take an extra argument and don't return a value
fpizlo@apple.com [Tue, 8 Apr 2014 03:55:12 +0000 (03:55 +0000)]
Setters are just getters that take an extra argument and don't return a value
https://bugs.webkit.org/show_bug.cgi?id=131336

Reviewed by Geoffrey Garen.

Other than that, they're totally the same thing.

This isn't as dumb as it sounds.

Most of the work in calling an accessor has to do with emitting the necessary checks for
figuring out whether we're calling the accessor we expected, followed by the boilerplate
needed for setting up a call inside of a stub. It makes sense for the code to be totally
common.

* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::storeValue):
(JSC::AssemblyHelpers::moveTrustedValue):
* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupResults):
* jit/Repatch.cpp:
(JSC::kindFor):
(JSC::customFor):
(JSC::generateByIdStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::generateGetByIdStub): Deleted.
(JSC::emitCustomSetterStub): Deleted.
* runtime/JSCJSValue.h:
(JSC::JSValue::asValue):
* runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::cachedOffset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in com.apple.WebKit.Plugin.Development at com.apple.WebKit2: WebKit::PluginCont...
slewis@apple.com [Tue, 8 Apr 2014 03:49:37 +0000 (03:49 +0000)]
Crash in com.apple.WebKit.Plugin.Development at com.apple.WebKit2: WebKit::PluginControllerProxy::pluginInstanceID
<rdar://problem/16479432>
https://bugs.webkit.org/show_bug.cgi?id=131203

Reviewed by Geoff Garen.

pluginController was being removed before accessing the pluginInstanceID.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::removePluginControllerProxy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore Mountain Lion build fix.
mitz@apple.com [Tue, 8 Apr 2014 02:46:49 +0000 (02:46 +0000)]
More Mountain Lion build fix.

* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS][WK2] Implement the update of content offset on animated resize
benjamin@webkit.org [Tue, 8 Apr 2014 02:12:42 +0000 (02:12 +0000)]
[iOS][WK2] Implement the update of content offset on animated resize
https://bugs.webkit.org/show_bug.cgi?id=131329

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-07
Reviewed by Tim Horton.

Compute a reasonable target offset on rotation. This goes in 3 steps:
1) Move the page so that the center does not move during scaling.
2) Limit the range to keep the page in scrollview without rubberbanding.
3) The horizontal content stays the same but the vertical area changes. When on the top or bottom
   edge, stick to the edge.

The code is moved inside _beginAnimatedResizeToSize:obscuredInsets:minimumLayoutSizeOverride: so that we can tell
the WebProcess where the scroll position will be at the end of the animation.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _frameOrBoundsChangedFrom:]):
(-[WKWebView _updateVisibleContentRects]):
(-[WKWebView _beginAnimatedResizeToSize:obscuredInsets:minimumLayoutSizeOverride:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMountain Lion build fix.
mitz@apple.com [Tue, 8 Apr 2014 02:07:14 +0000 (02:07 +0000)]
Mountain Lion build fix.

* UIProcess/ios/PageClientImplIOS.mm:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHandle decoding of nil invocation arguments
andersca@apple.com [Tue, 8 Apr 2014 01:38:09 +0000 (01:38 +0000)]
Handle decoding of nil invocation arguments
https://bugs.webkit.org/show_bug.cgi?id=131335
<rdar://problem/16528449>

Reviewed by Tim Horton.

* Shared/APIArray.h:
Don't crash if the array element is null.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agofast/css3-text/css3-text-decoration/text-decoration-thickness.html fails on GTK
mrobinson@webkit.org [Tue, 8 Apr 2014 01:35:19 +0000 (01:35 +0000)]
fast/css3-text/css3-text-decoration/text-decoration-thickness.html fails on GTK
https://bugs.webkit.org/show_bug.cgi?id=129957

Reviewed by Dean Jackson.

Source/WebCore:

Causes existing tests to pass.

* platform/graphics/cairo/GraphicsContextCG.cpp: Use the now-shared computeLineBoundsAndAntialiasingModeForText.
* platform/graphics/cairo/GraphicsContextCairo.cpp: Align the Cairo version of text underline drawing with the CG version.
* platform/graphics/GraphicsContext.h: Add computeLineBoundsAndAntialiasingModeForText.
* platform/graphics/GraphicsContext.cpp: Ditto.

LayoutTests:

Unskipped tests and modified one test to use the platform-independent Ahem font.

* fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-tall-underlines.html: We
need to use Ahem because Helvetica is not a platform-independent font.
* platform/gtk/TestExpectations: Unskipped tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: test helper files should be under LayoutTests/http/tests/inspector/
burg@cs.washington.edu [Tue, 8 Apr 2014 00:56:37 +0000 (00:56 +0000)]
Web Inspector: test helper files should be under LayoutTests/http/tests/inspector/
https://bugs.webkit.org/show_bug.cgi?id=131324

Reviewed by Joseph Pecoraro.

Rearrange helper files used by full inspector tests. In their previous placement,
they were outside the http server root and couldn't be loaded from http tests.

* http/tests/inspector/debugger/debugger-test.js: Renamed from LayoutTests/inspector/debugger/debugger-test.js.
* http/tests/inspector/dom/shapes-test.js: Renamed from LayoutTests/inspector/dom/shapes-test.js.
* http/tests/inspector/inspector-test.js: Renamed from LayoutTests/inspector/inspector-test.js.
* http/tests/inspector/replay/replay-test.js: Renamed from LayoutTests/inspector/replay/replay-test.js.
* inspector/debugger/probe-manager-add-remove-actions.html:
* inspector/dom/content-flow-content-nodes.html:
* inspector/dom/content-flow-content-removal.html:
* inspector/dom/content-flow-list.html:
* inspector/dom/content-node-region-info.html:
* inspector/dom/highlight-shape-outside-margin.html:
* inspector/dom/highlight-shape-outside.html:
* inspector/page/main-frame-resource.html:
* inspector/replay/javascript-date-now.html:
* inspector/replay/javascript-random-seed.html:
* inspector/test-harness-trivially-works.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd bundle client function corresponding to startAssistingNode
mitz@apple.com [Tue, 8 Apr 2014 00:39:55 +0000 (00:39 +0000)]
Add bundle client function corresponding to startAssistingNode
https://bugs.webkit.org/show_bug.cgi?id=131332

Reviewed by Anders Carlsson.

* UIProcess/PageClient.h: Added userData parameter to startAssistingNode.

* UIProcess/WebPageProxy.h: Added message decoder parameter to startAssistingNode.
* UIProcess/WebPageProxy.messages.in: Added message decoder parameter to StartAssistingNode.

* UIProcess/ios/PageClientImplIOS.h: Updated startAssistingNode override.
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::startAssistingNode): Decode the user data into an NSObject and pass
it on to the content view.

* UIProcess/ios/WKContentViewInteraction.h: Added userObject parameter to
-_startAssitingNode:.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _startAssistingNode:userObject:]): Added userObject parameter. We will pass
it to a future delegate method.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::startAssistingNode): Decode the user data and pass it to the client.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Declared new
delegate method.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added an implementation
of API::InjectedBundle::FormClient::willBeginInputSession which calls the new delegate
method, and encodes the user object into userData.

* WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:
(API::InjectedBundle::FormClient::willBeginInputSession): Added willBeginInputSession.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::elementDidFocus): Call willBeginInputSession and send the user data along
with the StartAssistingNode message to the UI process.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fixing the EFL build.
jinwoo7.song@samsung.com [Tue, 8 Apr 2014 00:24:45 +0000 (00:24 +0000)]
Unreviewed. Fixing the EFL build.

* WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp: Include the Document header from WebCore
to avoid operating on an incomplete type.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agobmalloc: Fixed a leak in the per-thread cache
ggaren@apple.com [Tue, 8 Apr 2014 00:23:38 +0000 (00:23 +0000)]
bmalloc: Fixed a leak in the per-thread cache
https://bugs.webkit.org/show_bug.cgi?id=131330

Reviewed by Andreas Kling.

Remember to deallocate our line caches upon thread exit.

* bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::~Deallocator):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agobmalloc: rolled out the tryLock experiment
ggaren@apple.com [Tue, 8 Apr 2014 00:12:16 +0000 (00:12 +0000)]
bmalloc: rolled out the tryLock experiment
https://bugs.webkit.org/show_bug.cgi?id=131328

Reviewed by Andreas Kling.

It wasn't a speedup.

* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/Allocator.cpp:
(bmalloc::Allocator::processSmallAllocatorLog):
(bmalloc::Allocator::processMediumAllocatorLog):
* bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSlowCase):
(bmalloc::Deallocator::deallocateSmallLine):
(bmalloc::Deallocator::deallocateMediumLine):
* bmalloc/Deallocator.h:
(bmalloc::Deallocator::deallocateFastCase):
* bmalloc/Heap.h:
(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::deallocateMediumLine):
* bmalloc/Line.h:
(bmalloc::Line<Traits>::deref):
* bmalloc/Page.h:
(bmalloc::Page<Traits>::deref):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS WebKit2] WKPDFView fades in tiles, PDFs load very flashily
timothy_horton@apple.com [Tue, 8 Apr 2014 00:07:45 +0000 (00:07 +0000)]
[iOS WebKit2] WKPDFView fades in tiles, PDFs load very flashily
https://bugs.webkit.org/show_bug.cgi?id=131325
<rdar://problem/16382960>

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView scrollViewDidScroll:]):
Forward scroll events to the current custom content provider.

* UIProcess/Cocoa/WKWebViewContentProvider.h:
Make content providers UIScrollViewDelegates (though we only forward didScroll for now).

* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView web_setContentProviderData:suggestedFilename:]):
(-[WKPDFView web_setMinimumSize:]):
(-[WKPDFView web_setScrollView:]):
(-[WKPDFView scrollViewDidScroll:]):
(-[WKPDFView _revalidateViews]):
(-[WKPDFView _computePageAndDocumentFrames]):
(-[WKPDFView layoutViews]): Deleted.
Keep track of each UIPDFPage, UIPDFPageView, and its frame (in unscaled/document coordinates).
Compute all the rects up front (and re-compute upon rotation, loading, etc.).
When scrolling, find all the pages that intersect the view (inflated by 1.5x in each
vertical direction), and ensure that pages that are inside that rect have
UIPDFPageViews installed, and ones that are outside that rect do not.
Use setUseBackingLayer to ensure that we have a low-resolution layer behind the
tiled layer to avoid flashiness.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r163194-r163227): Garbage tiles in overflow of RTL page with
bdakin@apple.com [Tue, 8 Apr 2014 00:04:20 +0000 (00:04 +0000)]
REGRESSION (r163194-r163227): Garbage tiles in overflow of RTL page with
background image
https://bugs.webkit.org/show_bug.cgi?id=131323
-and corresponding-
<rdar://problem/16402013>

Reviewed by Tim Horton.

Returning the TiledBacking::bounds() for the
FrameView::extendedBackgroundRectForPainting() in convenient for ltr pages, but it
is simply incorrect in rtl. There is no easy way to map the rect into the right
coordinate space, so this patch re-works the code to use computations in
RenderView to get the right rect.

Call RenderView::unextendedBackgroundRect() and expand and move it based on the
TiledBacking’s margins.
* page/FrameView.cpp:
(WebCore::FrameView::extendedBackgroundRectForPainting):

The logic that used to be in backgroundRect() has been moved to
unextendedBackgroundRect().
* rendering/RenderView.cpp:
(WebCore::RenderView::unextendedBackgroundRect):
(WebCore::RenderView::backgroundRect):
* rendering/RenderView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166895 268f45cc-cd09-0410-ab3c-d52691b4dbfc