WebKit.git
11 years agoUnreviewed, trivial error in previous commit.
mjs@apple.com [Thu, 15 Jul 2010 07:22:17 +0000 (07:22 +0000)]
Unreviewed, trivial error in previous commit.

Fix mistake in the last commit due to last minute change.

* platform/mac-wk2/Skipped: change extensions from -diffs.txt to .html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-15 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 15 Jul 2010 07:05:01 +0000 (07:05 +0000)]
2010-07-15  Eric Seidel  <eric@webkit.org>

        Unreviewed, just updating expectations.

        * html5lib/runner-expected.txt:
         - I think my changes got out of order with one another.
           The new results here are correct.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 15 Jul 2010 07:01:52 +0000 (07:01 +0000)]
2010-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        WebKit needs a rebaselining tool (finally)
        https://bugs.webkit.org/show_bug.cgi?id=42339

        This is a very basic rebaselining tool.  It's not
        quite as fancy as chromium's as it will only handle
        updating failing results.  It cannot yet handle adding new
        results, or updating results where the results should not
        replace existing results.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/tool/commands/__init__.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/rebaseline.py: Added.
        * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 15 Jul 2010 06:49:28 +0000 (06:49 +0000)]
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63352.
        http://trac.webkit.org/changeset/63352
        https://bugs.webkit.org/show_bug.cgi?id=42341

        Broke plugin-initiate-popup-window.html and plugin-javascript-
        access.html on snow leopard (Requested by abarth on #webkit).

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * plugins/plugin-initiate-popup-window-expected.txt: Removed.
        * plugins/plugin-initiate-popup-window.html: Removed.
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63352.
        http://trac.webkit.org/changeset/63352
        https://bugs.webkit.org/show_bug.cgi?id=42341

        Broke plugin-initiate-popup-window.html and plugin-javascript-
        access.html on snow leopard (Requested by abarth on #webkit).

        * bindings/v8/NPV8Object.cpp:
        (_NPN_EvaluateHelper):
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63352.
        http://trac.webkit.org/changeset/63352
        https://bugs.webkit.org/show_bug.cgi?id=42341

        Broke plugin-initiate-popup-window.html and plugin-javascript-
        access.html on snow leopard (Requested by abarth on #webkit).

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        (pluginAllocate):
        * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New):
        (handleEventCarbon):
        (handleEventCocoa):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 15 Jul 2010 05:44:03 +0000 (05:44 +0000)]
2010-07-14  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Second pass of updating baselines, fixing bad media baselines.

        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-replaces-poster-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 15 Jul 2010 05:35:16 +0000 (05:35 +0000)]
2010-07-14  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just updating expected results.

        Add a test to document WebKit (and Minefield's) HTML5 spec violation related to text node coalescing
        https://bugs.webkit.org/show_bug.cgi?id=42294

        Update results from Qt bot (using my new fancy rebaseline tool).

        * platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/qt/editing/inserting/insert-3907422-fix-expected.txt:
        * platform/qt/editing/pasteboard/4641033-expected.txt:
        * platform/qt/editing/pasteboard/5028447-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-010-expected.txt:
        * platform/qt/editing/pasteboard/select-element-1-expected.txt:
        * platform/qt/fast/canvas/arc360-expected.txt:
        * platform/qt/fast/canvas/canvas-before-css-expected.txt:
        * platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.txt:
        * platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt:
        * platform/qt/fast/canvas/fill-stroke-clip-reset-path-expected.txt:
        * platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.txt:
        * platform/qt/fast/canvas/gradient-add-second-start-end-stop-expected.txt:
        * platform/qt/fast/canvas/shadow-offset-1-expected.txt:
        * platform/qt/fast/canvas/shadow-offset-2-expected.txt:
        * platform/qt/fast/canvas/shadow-offset-3-expected.txt:
        * platform/qt/fast/canvas/shadow-offset-4-expected.txt:
        * platform/qt/fast/canvas/shadow-offset-5-expected.txt:
        * platform/qt/fast/canvas/shadow-offset-6-expected.txt:
        * platform/qt/fast/canvas/shadow-offset-7-expected.txt:
        * platform/qt/fast/css/contentImage-expected.txt:
        * platform/qt/fast/css/pseudo-cache-stale-expected.txt:
        * platform/qt/fast/css/rem-units-on-root-expected.txt:
        * platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
        * platform/qt/fast/dom/attr_dead_doc-expected.txt:
        * platform/qt/fast/dynamic/anchor-lock-expected.txt:
        * platform/qt/fast/dynamic/anonymous-block-layer-lost-expected.txt:
        * platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
        * platform/qt/fast/dynamic/window-scrollbars-test-expected.txt:
        * platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
        * platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
        * platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
        * platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
        * platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
        * platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
        * platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
        * platform/qt/fast/images/image-in-map-expected.txt:
        * platform/qt/fast/multicol/layers-split-across-columns-expected.txt:
        * platform/qt/fast/multicol/nested-columns-expected.txt:
        * platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
        * platform/qt/fast/overflow/line-clamp-expected.txt:
        * platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
        * platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt:
        * platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt:
        * platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt:
        * platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
        * platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
        * platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
        * platform/qt/http/tests/misc/iframe404-expected.txt:
        * platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt:
        * platform/qt/plugins/netscape-dom-access-expected.txt:
        * platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
        * platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 15 Jul 2010 05:05:27 +0000 (05:05 +0000)]
2010-07-14  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Update baselines after text node coalescing changes in r63403.

        * platform/gtk/editing/deleting/delete-line-013-expected.txt:
        * platform/gtk/editing/deleting/delete-line-014-expected.txt:
        * platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
        * platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
        * platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
        * platform/gtk/editing/selection/drag-in-iframe-expected.txt:
        * platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
        * platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt:
        * platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
        * platform/gtk/fast/forms/thumbslider-crash-expected.txt:
        * platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
        * platform/gtk/fast/images/icon-decoding-expected.txt:
        * platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt:
        * platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
        * platform/gtk/fast/multicol/nested-columns-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
        * platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
        * platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
        * platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
        * platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
        * platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-replaces-poster-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 15 Jul 2010 04:30:13 +0000 (04:30 +0000)]
2010-07-14  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make sure that mixed interpreter/jit builds don't try to use the jit if the allocator fails
        https://bugs.webkit.org/show_bug.cgi?id=42310

        Add some null checks to deal with the Fixed VM allocator failing
        to get the requested executable region, delay the creation of the
        JITStubs in JSGlobalData until after we know whether we're using
        the JIT.

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::ExecutableAllocator):
        (JSC::ExecutableAllocator::poolForSize):
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
        (JSC::FixedVMPoolAllocator::alloc):
        (JSC::FixedVMPoolAllocator::free):
        (JSC::FixedVMPoolAllocator::isValid):
        (JSC::ExecutableAllocator::isValid):
        (JSC::ExecutablePool::systemAlloc):
        (JSC::ExecutablePool::systemRelease):
        * jit/ExecutableAllocatorPosix.cpp:
        (JSC::ExecutableAllocator::isValid):
        * jit/ExecutableAllocatorWin.cpp:
        (JSC::ExecutableAllocator::isValid):
        * jit/JIT.cpp:
        (JSC::JIT::linkCall):
        (JSC::JIT::linkConstruct):
        * jit/JIT.h:
        (JSC::JIT::compileCTIMachineTrampolines):
        (JSC::JIT::compileCTINativeCall):
        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_mod):
        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_mod):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::JITThunks::hostFunctionStub):
        * jit/ThunkGenerators.cpp:
        (JSC::charCodeAtThunkGenerator):
        (JSC::charAtThunkGenerator):
        (JSC::fromCharCodeThunkGenerator):
        (JSC::sqrtThunkGenerator):
        (JSC::powThunkGenerator):
        * runtime/Executable.h:
        (JSC::NativeExecutable::create):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::getHostFunction):
        * runtime/JSGlobalData.h:
        (JSC::JSGlobalData::getCTIStub):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::jitCompileRegex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 15 Jul 2010 04:25:04 +0000 (04:25 +0000)]
2010-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a test to document WebKit (and Minefield's) HTML5 spec violation related to text node coalescing
        https://bugs.webkit.org/show_bug.cgi?id=42294

        * html5lib/resources/adoption01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
2010-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make the LegacyHTMLTreeBuilder coalesce text nodes
        https://bugs.webkit.org/show_bug.cgi?id=42314

        This is slightly tricky as we're side-stepping the old
        parsers insertion logic in the cases where we know we can
        safely merge text into an existing text node instead of
        inserting a new one.

        This affects lots of tests (which will need to change for
        the HTML5 TreeBuilder anyway) and causes the LegacyHTMLTreeBuilder
        to now pass a bunch more subtests in html5lib/runner.html.

        The parser benchmark thinks that this is a small speedup.
        I think I happen to have been lucky enough to get the right
        cache alignment, and that this is likely a wash.

        * html/LegacyHTMLTreeBuilder.cpp:
        (WebCore::LegacyHTMLTreeBuilder::parseToken):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 15 Jul 2010 04:19:45 +0000 (04:19 +0000)]
2010-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a test to document WebKit (and Minefield's) HTML5 spec violation related to text node coalescing
        https://bugs.webkit.org/show_bug.cgi?id=42294

        * html5lib/resources/adoption01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 George Yakovlev <georgey@chromium.org>
commit-queue@webkit.org [Thu, 15 Jul 2010 04:05:14 +0000 (04:05 +0000)]
2010-07-14  George Yakovlev  <georgey@chromium.org>

        Reviewed by Darin Fisher.

        Allow Chromium access to Select control choices
        https://bugs.webkit.org/show_bug.cgi?id=41384

        * WebKit.gyp:
        * public/WebOptionElement.h: Added.
        (WebKit::WebOptionElement::WebOptionElement):
        (WebKit::WebOptionElement::operator=):
        (WebKit::WebOptionElement::assign):
        * public/WebSelectElement.h:
        * src/WebOptionElement.cpp: Added.
        (WebKit::WebOptionElement::setValue):
        (WebKit::WebOptionElement::value):
        (WebKit::WebOptionElement::index):
        (WebKit::WebOptionElement::text):
        (WebKit::WebOptionElement::defaultSelected):
        (WebKit::WebOptionElement::setDefaultSelected):
        (WebKit::WebOptionElement::label):
        (WebKit::WebOptionElement::disabled):
        (WebKit::WebOptionElement::WebOptionElement):
        (WebKit::WebOptionElement::operator=):
        (WebKit::WebOptionElement::operator PassRefPtr<HTMLOptionElement>):
        * src/WebSelectElement.cpp:
        (WebKit::WebSelectElement::listItems):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=42315
weinig@apple.com [Thu, 15 Jul 2010 03:45:40 +0000 (03:45 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=42315
<rdar://problem/8185281>
All text in WebKit2 draws with no subpixel antialiasing

Reviewed by Dan Bernstein.

- Change CGBitmapInfo passed to CGBitmapContextCreate and CGImageCreate
  from kCGImageAlphaPremultipliedLast to kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host.

* Shared/mac/UpdateChunk.cpp:
(WebKit::UpdateChunk::createImage):
* UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
(WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
* WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
(WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind...
mjs@apple.com [Thu, 15 Jul 2010 03:37:19 +0000 (03:37 +0000)]
Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.

Reviewed by Mark Rowe.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago- Fix WebKitTestRunner build
mjs@apple.com [Thu, 15 Jul 2010 03:35:00 +0000 (03:35 +0000)]
- Fix WebKitTestRunner build

Reviewed by Mark Rowe.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add stdint.h include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Evan Stade <estade@chromium.org>
estade@chromium.org [Thu, 15 Jul 2010 03:18:42 +0000 (03:18 +0000)]
2010-07-14  Evan Stade  <estade@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Linux scrollbar steppers are "clickable" even when disabled
        https://bugs.webkit.org/show_bug.cgi?id=42231

        Not tested by layout tests.

        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 15 Jul 2010 03:05:35 +0000 (03:05 +0000)]
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63389.
        http://trac.webkit.org/changeset/63389
        https://bugs.webkit.org/show_bug.cgi?id=42311

        It broke the Chromium Linux build. (Requested by dave_levin on
        #webkit).

        * platform/KURLGoogle.cpp:
        (WebCore::decodeURLEscapeSequences):
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63389.
        http://trac.webkit.org/changeset/63389
        https://bugs.webkit.org/show_bug.cgi?id=42311

        It broke the Chromium Linux build. (Requested by dave_levin on
        #webkit).

        * DEPS:
        * WebKit.gyp:
        * public/WebCommon.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Scott Violet <sky@chromium.org>
commit-queue@webkit.org [Thu, 15 Jul 2010 03:00:45 +0000 (03:00 +0000)]
2010-07-14  Scott Violet  <sky@chromium.org>

        Reviewed by David Levin.

        [chromium] Autofill menu shows seperator at the wrong place when an entry is deleted
        https://bugs.webkit.org/show_bug.cgi?id=42210

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): Updates internal data appropriately.
        (WebKit::AutoFillPopupMenuClient::canRemoveSuggestionAtIndex): Now called before removal to see if can remove.
        * src/AutoFillPopupMenuClient.h: Fixed whitespace and added method.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent): Added call to canRemoveSuggestionAtIndex.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-13 Mirko Damiani <mirko@develer.com>
andreas.kling@nokia.com [Thu, 15 Jul 2010 02:56:01 +0000 (02:56 +0000)]
2010-07-13  Mirko Damiani  <mirko@develer.com>

        Reviewed by Simon Hausmann.

        [Qt] CSS border style not cleared for SVG object
        https://bugs.webkit.org/show_bug.cgi?id=42150

        For tests and description see:
        https://bugs.webkit.org/show_bug.cgi?id=25738

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::setLineDash):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 15 Jul 2010 02:40:22 +0000 (02:40 +0000)]
2010-07-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLTreeBuilder shouldn't crash during fast/parser/remove-parser-current-node.html
        https://bugs.webkit.org/show_bug.cgi?id=42312

        We were crashing because of an ASSERT I added to the attach logic in
        the HTMLConstructionSite.  I knew this ASSERT was wrong when I added
        it, I just wanted to make sure we had test coverage of those cases.
        Turns out we do!  :)

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::attach):
        (WebCore::HTMLConstructionSite::attachAtSite):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 15 Jul 2010 02:26:13 +0000 (02:26 +0000)]
2010-07-14  James Robinson  <jamesr@chromium.org>

        Unreviewed. Compile fix, initialization/declaration order mismatch.

        * src/GLES2ContextInternal.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Thu, 15 Jul 2010 02:16:22 +0000 (02:16 +0000)]
2010-07-14  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        [chromium] don't restrict the width of the autofill popup.
        https://bugs.webkit.org/show_bug.cgi?id=42206

        * src/WebViewImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix Windows build.
andersca@apple.com [Thu, 15 Jul 2010 02:02:41 +0000 (02:02 +0000)]
Try to fix Windows build.

* win/WebKit2.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Thu, 15 Jul 2010 02:01:19 +0000 (02:01 +0000)]
2010-07-14  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] update KURLGoogle decodeURLEscapeSequences to
        use googleurl public api so it does not access functions in
        url_canon_internal. This is for chromium multi-dll build.

        https://bugs.webkit.org/show_bug.cgi?id=42177

        Test: (unittest) WebKit\chromium\tests\KURLTest.cpp

        * platform/KURLGoogle.cpp:
        (WebCore::decodeURLEscapeSequences):
2010-07-14  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Chromium webkit dll updates:
        -. Fix WEBKIT_IMPLEMENTATION in WebCommon so
           dllimport works as expected.
        -. Update webkit.gyp so targets that depend on webkit
           has correct macros defined.
        -. Roll forward chromium deps to r52273.

        https://bugs.webkit.org/show_bug.cgi?id=42177

        * DEPS:
        * WebKit.gyp:
        * public/WebCommon.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Thu, 15 Jul 2010 01:21:07 +0000 (01:21 +0000)]
2010-07-14  James Hawkins  <jhawkins@chromium.org>

        UNREVIEWED Build Fix.

        Fix a typo.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::applyAutoFillSuggestions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 15 Jul 2010 01:13:47 +0000 (01:13 +0000)]
2010-07-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Avoid extra memcpy of character tokens
        https://bugs.webkit.org/show_bug.cgi?id=42002

        Eric tells me this patch makes the new tree builder 1% faster than the
        old tree builder on our parser benchmark.

        * html/HTMLToken.h:
        (WebCore::AtomicHTMLToken::AtomicHTMLToken):
        (WebCore::AtomicHTMLToken::characters):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
        (WebCore::convertToOldStyle):
        (WebCore::HTMLTreeBuilder::processFakeCharacters):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 15 Jul 2010 01:06:11 +0000 (01:06 +0000)]
2010-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder foster parents when it should not
        https://bugs.webkit.org/show_bug.cgi?id=42235

        * html5lib/resources/adoption01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
2010-07-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder foster parents when it should not
        https://bugs.webkit.org/show_bug.cgi?id=42235

        Regarding foster parenting of nodes inside tables:
        "Process the token using the rules for the "in body" insertion mode,
        except that if the current node is a table, tbody, tfoot, thead, or
        tr element, then, whenever a node would be inserted into the current
        node, it must instead be foster parented."

        We were forgetting the "when the current node is" part of that check
        and always foster parenting, even if we had just inserted another
        element (which would have just changed the current node).

        This was covered by multiple tests in html5lib/runner.html
        but I wrote a reduction (one which I included) as it makes it
        easier to see what's going on.

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLNames::causesFosterParenting):
        (WebCore::HTMLConstructionSite::attach):
        (WebCore::HTMLConstructionSite::insertHTMLHtmlElement):
        (WebCore::HTMLConstructionSite::insertHTMLHeadElement):
        (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
        (WebCore::HTMLConstructionSite::insertTextNode):
        (WebCore::HTMLConstructionSite::shouldFosterParent):
        * html/HTMLConstructionSite.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore work on plug-in streams
andersca@apple.com [Thu, 15 Jul 2010 01:03:26 +0000 (01:03 +0000)]
More work on plug-in streams
https://bugs.webkit.org/show_bug.cgi?id=42308

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
If the target is null, create a NetscapePluginStream and add it to the m_streams map.

(WebKit::NetscapePlugin::removePluginStream):
Remove the given NetscapePluginStream from the m_streams map.

(WebKit::NetscapePlugin::NPP_NewStream):
(WebKit::NetscapePlugin::NPP_DestroyStream):
Add NPP_ wrappers.

(WebKit::NetscapePlugin::streamFromID):
Return the plug-in stream given a stream ID.

(WebKit::NetscapePlugin::didEvaluateJavaScript):
Find the plug-in stream and call sendJavaScriptStream.

* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize member variables.

(WebKit::NetscapePluginStream::~NetscapePluginStream):
Assert that we aren't started.

(WebKit::NetscapePluginStream::sendJavaScriptStream):
If the JavaScript request was successful, start the stream. Otherwise call stop() which just
ends up calling NPP_URLNotify when the stream isn't started.

(WebKit::NetscapePluginStream::start):
Set up the NPStream object. Call NPP_NewStream. Return false if the call was not successful, or if
the requested stream type is one that we don't yet support.

(WebKit::NetscapePluginStream::stop):
Call NPP_DestroyStream if the stream is started. Call NPP_URLNotify if necessary.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performJavaScriptURLRequest):
Remove unneeded comment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/8131355> Apps load stale versions of pages when initial load happens...
beidson@apple.com [Thu, 15 Jul 2010 00:43:50 +0000 (00:43 +0000)]
<rdar://problem/8131355> Apps load stale versions of pages when initial load happens via back/forward navigation.

Reviewed by Mark Rowe.

No test case is added because DumpRenderTree is not able to test the scenario where the initial load in a WebView
occurs via a back/forward navigation.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::navigateToDifferentDocument): When the first load in a page is a back/forward navigation, we
  shouldn't try to prefer cached data but should do revalidation by default.
(WebCore::FrameLoader::addExtraFieldsToRequest): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 15 Jul 2010 00:36:28 +0000 (00:36 +0000)]
2010-07-14  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Breaks all dependencies on Page from platform/ and cleans up GLES2Context lifetime
        https://bugs.webkit.org/show_bug.cgi?id=42203

        Rather than constructing a GLES2Context from a Page, pass the LayerRendererChromium
        a GLES2Context in from the constructor.  This way the platform/ directory can remain
        ignorant of Page and friends.  Also adds functions on ChromeClientChromium to request
        onscreen and offscreen GLES2Contexts for callers in WebCore that need them.

        * WebKit.gyp:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::getOnscreenGLES2Context):
        (WebKit::ChromeClientImpl::getOffscreenGLES2Context):
        * src/ChromeClientImpl.h:
        * src/GLES2Context.cpp:
        (WebCore::GLES2ContextInternal::create):
        (WebCore::GLES2Context::create):
        (WebCore::GLES2Context::GLES2Context):
        * src/GLES2ContextInternal.cpp: Added.
        (WebCore::GLES2ContextInternal::~GLES2ContextInternal):
        * src/GLES2ContextInternal.h: Added.
        (WebCore::GLES2ContextInternal::getWebGLES2Context):
        (WebCore::GLES2ContextInternal::GLES2ContextInternal):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::getOnscreenGLES2Context):
        (WebKit::WebViewImpl::getOffscreenGLES2Context):
        * src/WebViewImpl.h:
2010-07-14  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Breaks all dependencies on Page from platform/ and cleans up GLES2Context lifetime
        https://bugs.webkit.org/show_bug.cgi?id=42203

        Rather than constructing a GLES2Context from a Page, pass the LayerRendererChromium
        a GLES2Context in from the constructor.  This way the platform/ directory can remain
        ignorant of Page and friends.  Also adds functions on ChromeClientChromium to request
        onscreen and offscreen GLES2Contexts for callers in WebCore that need them.

        * page/chromium/ChromeClientChromium.h:
        * platform/chromium/GLES2Context.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        * platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 15 Jul 2010 00:27:37 +0000 (00:27 +0000)]
2010-07-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Add functions to extract individual RGBA32 components
        https://bugs.webkit.org/show_bug.cgi?id=42305

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::willDraw): Use alphaChannel()
        * platform/graphics/Color.h:
        (WebCore::redChannel):
        (WebCore::greenChannel):
        (WebCore::blueChannel):
        (WebCore::alphaChannel):
        (WebCore::Color::red):
        (WebCore::Color::green):
        (WebCore::Color::blue):
        (WebCore::Color::alpha):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago The same old directory name was present in mac-tiger skipped list.
ap@apple.com [Thu, 15 Jul 2010 00:25:50 +0000 (00:25 +0000)]
    The same old directory name was present in mac-tiger skipped list.

        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Not reviewed.
ap@apple.com [Thu, 15 Jul 2010 00:20:27 +0000 (00:20 +0000)]
    Not reviewed.

        https://bugs.webkit.org/show_bug.cgi?id=42201
        Use ResourceHandle object for synchronous loading

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously): Fix an obvious typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Thu, 15 Jul 2010 00:19:57 +0000 (00:19 +0000)]
2010-07-14  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Use the unique ID instead of the profile label to identify
        the accepted AutoFill suggestion.
        https://bugs.webkit.org/show_bug.cgi?id=42301

        * public/WebView.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
        (WebKit::WebViewClient::didSelectAutoFillSuggestion):
        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::valueChanged):
        (WebKit::AutoFillPopupMenuClient::selectionChanged):
        (WebKit::AutoFillPopupMenuClient::initialize):
        (WebKit::AutoFillPopupMenuClient::setSuggestions):
        (WebKit::AutoFillPopupMenuClient::textFieldStyle):
        * src/AutoFillPopupMenuClient.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::applyAutoFillSuggestions):
        (WebKit::WebViewImpl::applyAutocompleteSuggestions):
        * src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative Qt/Windows build fix.
barraclough@apple.com [Thu, 15 Jul 2010 00:19:39 +0000 (00:19 +0000)]
Speculative Qt/Windows build fix.

* jit/JITStubs.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake Back/Forward work.
weinig@apple.com [Thu, 15 Jul 2010 00:19:27 +0000 (00:19 +0000)]
Make Back/Forward work.

Reviewed by John Sullivan.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goForward): Pass the item ID to avoid roundtrip.
(WebKit::WebPageProxy::goBack): Ditto.
(WebKit::WebPageProxy::didReceiveMessage): Implement WebPageProxyMessage::BackForwardGoToItem.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::goForward): Use m_page->goToItem with the correct type instead of the Page shortcut.
(WebKit::WebPage::goBack): Ditto.
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
Remove unused m_canGoBack and m_canGoForward.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Brady Eidson.
ap@apple.com [Thu, 15 Jul 2010 00:17:28 +0000 (00:17 +0000)]
    Reviewed by Brady Eidson.

        https://bugs.webkit.org/show_bug.cgi?id=42201
        Use ResourceHandle object for synchronous loading

        Fix a Tiger test failure.

        Setting NSURLRequest properties has been moved to createNSURLConnection to share code between
        sync and async cases, but on Tiger, we don't call this function.

        There is more refactoring needed to make this nice, and we need to figure out if some of
        request-tweaking code in createNSURLConnection needs to run on every redirect, as it happens
        with CFNetwork version.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously): Set main document for cookies, which is
        the only thing we've been missing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebCore.xcodeproj/project.pbxproj: Silence rsync.
mrowe@apple.com [Thu, 15 Jul 2010 00:06:26 +0000 (00:06 +0000)]
* WebCore.xcodeproj/project.pbxproj: Silence 

Rubber-stamped by Dan Bernstein.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix warning seen with newer gcc (on Qt buildbot).
darin@apple.com [Wed, 14 Jul 2010 23:56:15 +0000 (23:56 +0000)]
Fix warning seen with newer gcc (on Qt buildbot).

Reviewed by Gavin Barraclough.

* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
Add parentheses around && expression.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoA sputnik test was removed from the Skipped list in r63366 because it was a bogus...
bweinstein@apple.com [Wed, 14 Jul 2010 23:52:58 +0000 (23:52 +0000)]
A sputnik test was removed from the Skipped list in r63366 because it was a bogus filename,
but this was because its directory was renamed. Add it back to the Skipped list with its new
directory name.

* platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 14 Jul 2010 23:44:03 +0000 (23:44 +0000)]
2010-07-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Avoid extra memcpy of character tokens
        https://bugs.webkit.org/show_bug.cgi?id=42002

        This patch is just some cleanup to make fixing this bug easier.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::~ExternalCharacterTokenBuffer):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::isEmpty):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemaining):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::giveRemainingTo):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace):
        (WebCore::HTMLTreeBuilder::processDoctypeToken):
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processComment):
        (WebCore::HTMLTreeBuilder::processCharacter):
        (WebCore::HTMLTreeBuilder::processCharacterBuffer):
        (WebCore::HTMLTreeBuilder::processEndOfFile):
        (WebCore::HTMLTreeBuilder::defaultForInitial):
        (WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
        (WebCore::HTMLTreeBuilder::defaultForBeforeHead):
        (WebCore::HTMLTreeBuilder::defaultForInHead):
        (WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
        (WebCore::HTMLTreeBuilder::defaultForAfterHead):
        (WebCore::HTMLTreeBuilder::defaultForInTableText):
        * html/HTMLTreeBuilder.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 14 Jul 2010 23:34:19 +0000 (23:34 +0000)]
2010-07-14  Simon Fraser  <simon.fraser@apple.com>

        Fix non-ACCELERATED_COMPOSITING build.

        * WebView/WebRenderLayer.mm:
        (+[WebRenderLayer compositingInfoForLayer:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Wed, 14 Jul 2010 23:27:59 +0000 (23:27 +0000)]
2010-07-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Canvas: Don't add shadow rect to dirty region when shadow alpha is 0
        https://bugs.webkit.org/show_bug.cgi?id=42300

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::willDraw):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[CURL] Build fix after request -> firstRequest rename.
kevino@webkit.org [Wed, 14 Jul 2010 23:23:20 +0000 (23:23 +0000)]
[CURL] Build fix after request -> firstRequest rename.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 14 Jul 2010 23:17:20 +0000 (23:17 +0000)]
2010-07-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/8186963> Expose information about compositing layers.

        Expose information about the types of compositing layers via RenderLayerBacking::compositingLayerType().

        * WebCore.exp.in: Export WebCore::SpaceSplitStringData::createVector().
        * WebCore.xcodeproj/project.pbxproj: Make RenderLayerBacking.h a Private header for use by WebKit.
        * platform/graphics/GraphicsLayer.h: Add hasContentsLayer() and usingTiledLayer() methods.
        (WebCore::GraphicsLayer::hasContentsLayer):
        (WebCore::GraphicsLayer::usingTiledLayer):
        * platform/graphics/mac/GraphicsLayerCA.h:
        (WebCore::GraphicsLayerCA::hasContentsLayer): Return true if we have a contents layer.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::compositingLayerType): Return information about the type of composited layer.
        * rendering/RenderLayerBacking.h:

2010-07-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/8186963> Expose information about compositing layers.

        Use RenderLayerBacking::compositingLayerType() to add more information about compositing to
        WebRenderLayer, via a compositingInfo property. Also show element classnames.

        Also add separator items between the various z-order lists.

        * WebView/WebRenderLayer.h:
        * WebView/WebRenderLayer.mm:
        (+[WebRenderLayer nameForLayer:]):
        (+[WebRenderLayer compositingInfoForLayer:]):
        (-[WebRenderLayer initWithRenderLayer:]):
        (-[WebRenderLayer initWithName:]):
        (-[WebRenderLayer initWithWebFrame:]):
        (-[WebRenderLayer dealloc]):
        (-[WebRenderLayer buildDescendantLayers:]):
        (-[WebRenderLayer compositingInfo]):
        (-[WebRenderLayer isComposited]):
        (-[WebRenderLayer isSeparator]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Wed, 14 Jul 2010 23:02:23 +0000 (23:02 +0000)]
2010-07-14  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Don't notify the WebView that the popup has been closed when the
        selection is cleared, as the popup is not gone and would linger
        as a ghost popup.
        https://bugs.webkit.org/show_bug.cgi?id=42180

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::selectionCleared):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* platform/mac-snowleopard/Skipped: Removed a bogus filename for a file that does not
darin@apple.com [Wed, 14 Jul 2010 23:01:02 +0000 (23:01 +0000)]
* platform/mac-snowleopard/Skipped: Removed a bogus filename for a file that does not
exist. Clearly it was OK to not skip this test, because we were not skipping it before.
But if it does need to be skipped, someone can add it back later.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 14 Jul 2010 22:49:39 +0000 (22:49 +0000)]
2010-07-14  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        TreeWalker::previousSibling calls firstChild instead of lastChild when handling FILTER_SKIP
        https://bugs.webkit.org/show_bug.cgi?id=42008

        TreeWalker::previousNode does not handle FILTER_REJECT when processing lastChild
        https://bugs.webkit.org/show_bug.cgi?id=42010

        Tests: fast/dom/TreeWalker/previousNodeLastChildReject.html
               fast/dom/TreeWalker/previousSiblingLastChildSkip.html

        * dom/TreeWalker.cpp:
        (WebCore::TreeWalker::previousSibling): Call lastChild instead of firstChild.
        (WebCore::TreeWalker::previousNode): Fix handling of FILTER_REJECT by exiting
        the lastChild loop when we encounter it.
2010-07-14  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        TreeWalker::previousSibling calls firstChild instead of lastChild when handling FILTER_SKIP
        https://bugs.webkit.org/show_bug.cgi?id=42008

        TreeWalker::previousNode does not handle FILTER_REJECT when processing lastChild
        https://bugs.webkit.org/show_bug.cgi?id=42010

        * fast/dom/TreeWalker/previousNodeLastChildReject-expected.txt: Added.
        * fast/dom/TreeWalker/previousNodeLastChildReject.html: Added.
        * fast/dom/TreeWalker/previousSiblingLastChildSkip-expected.txt: Added.
        * fast/dom/TreeWalker/previousSiblingLastChildSkip.html: Added.
        * fast/dom/TreeWalker/script-tests: Added.
        * fast/dom/TreeWalker/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Element/script-tests/TEMPLATE.html.
        * fast/dom/TreeWalker/script-tests/previousNodeLastChildReject.js: Added.
        * fast/dom/TreeWalker/script-tests/previousSiblingLastChildSkip.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd NetscapePluginStream class
andersca@apple.com [Wed, 14 Jul 2010 22:48:26 +0000 (22:48 +0000)]
Add NetscapePluginStream class
https://bugs.webkit.org/show_bug.cgi?id=42296

Reviewed by Darin Adler.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: Added.
(WebKit::NetscapePluginStream::NetscapePluginStream):
(WebKit::NetscapePluginStream::~NetscapePluginStream):
* WebProcess/Plugins/Netscape/NetscapePluginStream.h: Added.
(WebKit::NetscapePluginStream::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 14 Jul 2010 22:46:35 +0000 (22:46 +0000)]
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63346.
        http://trac.webkit.org/changeset/63346
        https://bugs.webkit.org/show_bug.cgi?id=42295

        Broke lots of tests, some of which probably just need new
        results (Requested by aroben on #webkit).

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (urlSuitableForTestResult):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=42297
weinig@apple.com [Wed, 14 Jul 2010 22:44:08 +0000 (22:44 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=42297
<rdar://problem/8187355>
Make titles in WebBackForwardListItems work.

Reviewed by Darin Adler.

- Make WebBackForwardListItemMap per WebProcessProxy to allow updating
  them separate from a page. They are conceptually per process anyway.
- Add a message to add or update a WebBackForwardListItemMap triggered
  by the WebCore::notifyHistoryItemChanged mechanism.

* Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:
(WebProcessProxyMessage::):
Add AddOrUpdateBackForwardItem message.

* UIProcess/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::setTitle):
Add setters.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
BackForwardAddItem now assumes the item has already been created, so
now just forwards the add message onto the WebBackForwardList.

(WebKit::WebPageProxy::addItemToBackForwardList): Take a WebBackForwardList instead of an ID.
(WebKit::WebPageProxy::goToItemInBackForwardList): Ditto.
* UIProcess/WebPageProxy.h: Ditto.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::webBackForwardItem):
(WebKit::WebProcessProxy::addOrUpdateBackForwardListItem):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
* UIProcess/WebProcessProxy.h:
Have the WebProcessProxy manage the WebBackForwardListItems.

* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
(WebKit::WK2NotifyHistoryItemChanged): Use this to notify UIProcess
of HistoryItem changes (such as the title being added).
(WebKit::WebBackForwardListProxy::WebBackForwardListProxy):
Register the notifyHistoryItemChanged function.
(WebKit::WebBackForwardListProxy::addItem):
Just send the ID as the updateBackForwardItem is already going to have
been called by this time.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix crashing layout test on snowleopard.
weinig@apple.com [Wed, 14 Jul 2010 22:21:06 +0000 (22:21 +0000)]
Fix crashing layout test on snowleopard.

Reviewed by Brady Eidson.

* platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor): Make sure to retain the cursor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCall NPN_URLNotify for frame loads initiated by plug-ins
andersca@apple.com [Wed, 14 Jul 2010 22:12:50 +0000 (22:12 +0000)]
Call NPN_URLNotify for frame loads initiated by plug-ins
https://bugs.webkit.org/show_bug.cgi?id=42291

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
If needed, keep track of the request ID and URL so we can call NPP_URLNotify at a later point.

(WebKit::NetscapePlugin::frameDidFinishLoading):
Get the notification data and the URL from the map and call NPP_URLNotify.

(WebKit::NetscapePlugin::frameDidFail):
Get the notification data and the URL from the map and call NPP_URLNotify.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 14 Jul 2010 22:10:28 +0000 (22:10 +0000)]
2010-07-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        html5lib/runner.html fails after http://trac.webkit.org/changeset/63338/
        https://bugs.webkit.org/show_bug.cgi?id=42290

        * platform/chromium-mac/html5lib/runner-expected.txt:
        * platform/chromium-win/html5lib/runner-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: aria-checked not recognized on image map radio buttons
cfleizach@apple.com [Wed, 14 Jul 2010 22:09:31 +0000 (22:09 +0000)]
AX: aria-checked not recognized on image map radio buttons
https://bugs.webkit.org/show_bug.cgi?id=42055

Reviewed by Darin Adler.

WebCore:

Moves some code from AccessibilityRenderObject to AccessibilityObject so that
elements that do not have render objects, but do have Nodes (like image map links
and list box options) can still make use of certain aria attributes.

Test: platform/mac/accessibility/image-map-link-used-as-radiobutton.html

* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::roleValue):
(WebCore::AccessibilityImageMapLink::accessibilityDescription):
(WebCore::AccessibilityImageMapLink::title):
   Make imageMap use standard AccessibilityObject methods for getAttribute()
* accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::node):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):
(WebCore::AccessibilityListBoxOption::stringValue):
* accessibility/AccessibilityListBoxOption.h:
(WebCore::AccessibilityListBoxOption::node):
       * accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::language):
     Language method doesn't need a node() anymore, it can use the node from AccessibilityObject.
(WebCore::renderListItemContainerForNode):
(WebCore::AccessibilityObject::getAttribute):
(WebCore::AccessibilityObject::intValue):
   Move intValue into AccessibilityObject.
(WebCore::AccessibilityObject::hasIntValue):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isCheckbox):
(WebCore::AccessibilityObject::isRadioButton):
(WebCore::AccessibilityObject::isCheckboxOrRadio):
   Consolidate what defines a checkbox and radio button into AccessibilityObject.
(WebCore::AccessibilityObject::node):
(WebCore::AccessibilityObject::headingLevel):
       (WebCore::AccessibilityObject::isDetached):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::headingLevel):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::hierarchicalLevel):
(WebCore::AccessibilityRenderObject::node):
(WebCore::AccessibilityRenderObject::intValue):
* accessibility/AccessibilityRenderObject.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemAccessibilityText):
    Stop using AccessibilityObjects getAttribute (no reason to use it really).

LayoutTests:

* platform/mac/accessibility/image-map-link-used-as-radiobutton-expected.txt: Added.
* platform/mac/accessibility/image-map-link-used-as-radiobutton.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7759909> Certain text runs measure 1 pixel wider when measured as...
mitz@apple.com [Wed, 14 Jul 2010 21:41:02 +0000 (21:41 +0000)]
<rdar://problem/7759909> Certain text runs measure 1 pixel wider when measured as a whole than when measured piecewise
https://bugs.webkit.org/show_bug.cgi?id=42279

Reviewed by Simon Fraser.

No test because the issue cannot be reproduced with standard fonts.

Word- and run-rounding works by advancing ahead to the nearest integral width. As the total
width accumulated becomes large, the float type’s low precision results in accumulated rounding
error, sometimes crossing an integer. Consequently, word-rounding makes different decisions when
measuring a multi-word run than when measuring its words individually. To work around this,
word- and run-rounding are applied only to the width accumulated since the last rounding
character.

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advance):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 14 Jul 2010 21:39:27 +0000 (21:39 +0000)]
2010-07-14  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Fix enum value names for Navigation.{idl|h}
        https://bugs.webkit.org/show_bug.cgi?id=42282

        This is necessary after https://bugs.webkit.org/show_bug.cgi?id=42250.

        No new tests because no new functionality.

        * page/Navigation.cpp:
        (WebCore::Navigation::type):
        * page/Navigation.h:
        (WebCore::Navigation::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeed up killing of Apache on Windows
aroben@apple.com [Wed, 14 Jul 2010 21:28:20 +0000 (21:28 +0000)]
Speed up killing of Apache on Windows

Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
run-webkit-tests) takes a long time on Windows

Reviewed by Darin Adler and Jon Honeycutt.

* Scripts/webkitperl/httpd.pm:
(closeHTTPD): Use taskkill to kill Apache and its child processes.
Perl's kill seems ineffectual. We were already using taskkill, but
only after trying kill 20 times. Since kill never works, let's just
skip it entirely.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNo review. Make sure Tiger and Leopard don't run this test.
cfleizach@apple.com [Wed, 14 Jul 2010 21:14:10 +0000 (21:14 +0000)]
No review. Make sure Tiger and Leopard don't run this test.

AX: Data table heuristics: consider assuming data table for 'zebra-striped' rows
https://bugs.webkit.org/show_bug.cgi?id=42117

* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=41292
cfleizach@apple.com [Wed, 14 Jul 2010 21:10:50 +0000 (21:10 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=41292
Set right UserGestureIndicator to indicate whether the NPN_Evaluate allows popup window or not.

Patch by Johnny Ding <jnd@chromium.org> on 2010-07-14
Reviewed by Adam Barth.

Test: plugins/plugin-initiate-popup-window.html

* bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):

LayoutTests: Bug 42117 - AX: Data table heuristics: consider assuming data table for 'zebra-striped' rows
https://bugs.webkit.org/show_bug.cgi?id=42117

Reviewed by Darin Adler.

* platform/mac/accessibility/table-with-zebra-rows-expected.txt: Added.
* platform/mac/accessibility/table-with-zebra-rows.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Johnny Ding <jnd@chromium.org>
abarth@webkit.org [Wed, 14 Jul 2010 21:03:03 +0000 (21:03 +0000)]
2010-07-14  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292
        Set right UserGestureIndicator to indicate whether the NPN_Evaluate allows popup window or not.

        Test: plugins/plugin-initiate-popup-window.html

        * bindings/v8/NPV8Object.cpp:
        (_NPN_EvaluateHelper):
2010-07-14  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292
        Add a test to initiate popup windows from plugin during plugin is handling mouse/keyboard event.
        Disable this test on gtk/qt/win since the test plugin in those platforms didn't implement NPP_HandleEvent.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * plugins/plugin-initiate-popup-window-expected.txt: Added.
        * plugins/plugin-initiate-popup-window.html: Added.
2010-07-14  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=41292
        Add a new parameter to the test plugin to allow to specify a script and a
        mouse/keyboard event. The specified script will be evaluated in the browser
        when the specified event is received by the plugin.

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        (pluginAllocate):
        * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NPP_New):
        (handleEventCarbon):
        (handleEventCocoa):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd NetscapePlugin::NPP_ member functions for calling into the plug-in
andersca@apple.com [Wed, 14 Jul 2010 20:49:35 +0000 (20:49 +0000)]
Add NetscapePlugin::NPP_ member functions for calling into the plug-in
https://bugs.webkit.org/show_bug.cgi?id=42287

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NPP_New):
(WebKit::NetscapePlugin::NPP_Destroy):
(WebKit::NetscapePlugin::NPP_SetWindow):
(WebKit::NetscapePlugin::NPP_URLNotify):
(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::initialize):
(WebKit::NetscapePlugin::destroy):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: VoiceOver cannot navigate this page because Safari is taking too long
cfleizach@apple.com [Wed, 14 Jul 2010 20:30:45 +0000 (20:30 +0000)]
AX: VoiceOver cannot navigate this page because Safari is taking too long
https://bugs.webkit.org/show_bug.cgi?id=42219

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the chromium mac build.
weinig@apple.com [Wed, 14 Jul 2010 20:22:36 +0000 (20:22 +0000)]
Fix the chromium mac build.

* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::setCursor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=42280
barraclough@apple.com [Wed, 14 Jul 2010 20:12:51 +0000 (20:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=42280
JIT_STUB_ARGUMENT_VA_LIST is only slowing us down! Remove it!

Reviewed by Oliver Hunt.

* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::restoreArgumentReferenceForTrampoline):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAnother try at fixing the Tiger build.
darin@apple.com [Wed, 14 Jul 2010 20:04:14 +0000 (20:04 +0000)]
Another try at fixing the Tiger build.

Avoid non-ASCII in source files to keep Tiger compiler happy.

* WebView/WebRenderLayer.mm:
(+[WebRenderLayer nameForLayer:]): Use %C for the non-ASCII characters.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake urlSuitableForTestResult work for http: URLs, too
aroben@apple.com [Wed, 14 Jul 2010 19:45:06 +0000 (19:45 +0000)]
Make urlSuitableForTestResult work for http: URLs, too

Fixes <http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows.

Reviewed by Darin Adler.

* DumpRenderTree/win/DumpRenderTree.cpp:
(urlSuitableForTestResult): Don't bail if the URL starts with http://.
We want this function to work for those URLs, too!

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSend JavaScript url request results back to the plug-in
andersca@apple.com [Wed, 14 Jul 2010 19:38:16 +0000 (19:38 +0000)]
Send JavaScript url request results back to the plug-in
https://bugs.webkit.org/show_bug.cgi?id=42277

Reviewed by Sam Weinig.

* WebProcess/Plugins/DummyPlugin.cpp:
(WebKit::DummyPlugin::didEvaluateJavaScript):
* WebProcess/Plugins/DummyPlugin.h:
Add empty stub.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::didEvaluateJavaScript):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add Empty stub.

* WebProcess/Plugins/Plugin.h:
Add didEvaluateJavaScript pure virtual member function.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performJavaScriptURLRequest):
If target is not null, Call Plugin::frameDidFail or Plugin::frameDidFinishLoading.
If target is null, call didEvaluateJavaScript with the result string.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Wed, 14 Jul 2010 19:33:13 +0000 (19:33 +0000)]
2010-07-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Canvas: Fast-path for assigning the same color string as before to fillStyle or strokeStyle
        https://bugs.webkit.org/show_bug.cgi?id=42272

        Always route assignment of color strings via setFillColor() or setStrokeColor()
        where we can check it against the previous value and return early if it's the same.

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toHTMLCanvasStyle):
        (WebCore::JSCanvasRenderingContext2D::strokeStyle):
        (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
        (WebCore::JSCanvasRenderingContext2D::setFillStyle):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setStrokeStyle):
        (WebCore::CanvasRenderingContext2D::setFillStyle):
        (WebCore::CanvasRenderingContext2D::setStrokeColor):
        (WebCore::CanvasRenderingContext2D::setFillColor):
        * html/canvas/CanvasRenderingContext2D.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 14 Jul 2010 19:26:26 +0000 (19:26 +0000)]
2010-07-14  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        Separate line-ending conversion code from BlobItem
        https://bugs.webkit.org/show_bug.cgi?id=40932

        Add common line-ending normalization code under platform/text.
        No new tests as it doesn't change any functionality.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/BlobBuilder.cpp:
        (WebCore::BlobBuilder::appendString):
        * html/FormDataList.cpp:
        (WebCore::FormDataList::appendString):
        * platform/BlobItem.cpp:
        * platform/BlobItem.h:
        * platform/text/LineEnding.cpp: Added.
        * platform/text/LineEnding.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Wed, 14 Jul 2010 19:01:53 +0000 (19:01 +0000)]
2010-07-14  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Darin Adler.

        Implement border-start and border-end properties
        https://bugs.webkit.org/show_bug.cgi?id=41782

        * fast/css/border-start-end-expected.txt: Added.
        * fast/css/border-start-end.html: Added.
        * fast/css/script-tests/border-start-end.js: Added.
        (test):
        (testSame):
        (testWidth):
2010-07-14  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Darin Adler.

        Implement border-start and border-end properties
        https://bugs.webkit.org/show_bug.cgi?id=41782

        Test: fast/css/border-start-end.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSProperty.cpp:
        (WebCore::CSSProperty::resolveDirectionAwareProperty):
        * css/CSSPropertyNames.in:
        * inspector/front-end/SourceCSSTokenizer.js:
        (WebInspector.SourceCSSTokenizer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGuard the CF path of interpreter vs. jit selection with PLATFORM(CF)
oliver@apple.com [Wed, 14 Jul 2010 19:01:15 +0000 (19:01 +0000)]
Guard the CF path of interpreter vs. jit selection with PLATFORM(CF)

RS=Geoff Garen

This allows the code to work on windows as well.  Also unifies the
environment variable with the preference name.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Tiger and Gtk build fixes.
ap@apple.com [Wed, 14 Jul 2010 18:56:58 +0000 (18:56 +0000)]
    Tiger and Gtk build fixes.

        https://bugs.webkit.org/show_bug.cgi?id=42201
        Use ResourceHandle object for synchronous loading

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::createNSURLConnection):
        (WebCore::ResourceHandle::loadResourceSynchronously):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=42232
weinig@apple.com [Wed, 14 Jul 2010 18:54:34 +0000 (18:54 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
Make changing Cursors work in WebKit2.

Reviewed by Darin Adler.

WebCore:

- Converted Mac and Windows Cursor implementations to lazily
  create the platform cursor.
- Add HostWindow function to set the cursor and use it from Widget::setCursor.
- Rework Windows cursor code to use fewer global variables.

* WebCore.exp.in: Updated
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::setCursor):
(WebCore::EmptyChromeClient::setLastSetCursorToCurrentCursor):
Added empty implementations.

* page/Chrome.cpp:
(WebCore::Chrome::setCursor):
* page/Chrome.h:
* page/ChromeClient.h:
Change existing setCursor() function to take a Cursor instead of a
PlatformCursorHandle. Added setLastSetCursorToCurrentCursor.

* platform/Cursor.cpp:
* platform/Cursor.h:
Added Cursor Type and the option of lazily creating the native cursor
(used on Mac and Windows for now).

* platform/HostWindow.h:
Add setCursor.

* platform/mac/CursorMac.mm:
(WebCore::createCustomCursor): This no longer needs to call determineHotSpot
as that is done when on construction of the cursor now and the hotSpot passed
in is correct.
(WebCore::Cursor::ensurePlatformCursor):
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::Cursor::platformCursor):
Convert to lazily creating the native cursor on the first request and
storing the type.

* platform/mac/WidgetMac.mm:
(WebCore::Widget::setCursor):
Use HostWindow::setCursor to set the cursor. This in turn will call the
ChromeClient.

* platform/win/CursorWin.cpp:
(WebCore::createSharedCursor):
(WebCore::loadSharedCursor):
(WebCore::loadCursorByName):
(WebCore::Cursor::ensurePlatformCursor):
(WebCore::SharedCursor::~SharedCursor):
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::Cursor::platformCursor):
Convert to lazily creating the native cursor on the first request and
storing the type.

* platform/win/WidgetWin.cpp:
(WebCore::Widget::setCursor):
Use HostWindow::setCursor to set the cursor. This in turn will call the
ChromeClient.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handleMouseEvent):
Use the new setLastSetCursorToCurrentCursor client function to ensure
the cursor is properly updated when over a plugin.

* platform/chromium/CursorChromium.cpp:
* platform/efl/CursorEfl.cpp:
* platform/gtk/CursorGtk.cpp:
* platform/haiku/CursorHaiku.cpp:
* platform/wince/CursorWince.cpp:
* platform/wx/CursorWx.cpp:
* platform/qt/CursorQt.cpp:
Change m_impl -> m_platformCursor.

WebKit:

* efl/WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::setCursor):
* efl/WebCoreSupport/ChromeClientEfl.h:
Change prototype to match new one.

WebKit/chromium:

* src/ChromeClientImpl.h:
(WebKit::ChromeClientImpl::setCursor):
Change prototype to match new one.

* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::setCursor):
* src/WebPopupMenuImpl.h:
Add empty setCursor function to satisfy the HostWindow interface.

WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::setCursor):
* WebCoreSupport/ChromeClientGtk.h:
Change prototype to match new one.

WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::setCursor):
* WebCoreSupport/ChromeClientHaiku.h:
Change prototype to match new one.

WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::setCursor):
* WebView/WebView.mm:
Implement cursor changing at the WebKit level for the sake of WebKit2.
This functionality is being moved from WidgetMac.mm.
(+[WebView _pointingHandCursor]):
Update to use platformCursor() instead of impl().

WebKit/qt:

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setCursor):
* WebCoreSupport/ChromeClientQt.h:
Change prototype to match new one.

WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::setCursor):
We now need to grab the native cursor out of the WebCore cursor.

(WebChromeClient::setLastSetCursorToCurrentCursor):
Sets the WebView's "last set cursor" to be the current cursor so that
the cursor is set correctly for plugins.
* WebCoreSupport/WebChromeClient.h:
* WebView.cpp:
(WebView::WebView):
(WebView::WebViewWndProc):
* WebView.h:
(WebView::setLastCursor):
Change the "last set cursor" to be stored as a member instead of a global.

WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::setCursor):
* WebKitSupport/ChromeClientWx.h:
Change prototype to match new one.

WebKit2:

* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
Add SetCursor message.

* Shared/WebCoreArgumentCoders.h:
Add encoding/decoding of Cursors. For now we don't support Custom
cursors.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setCursor):
* UIProcess/PageClient.h:
Add pass through functions to get the cursor from the WebPageProxy
to the WKView.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setCursor:]):
* UIProcess/API/mac/WKViewInternal.h:
Implement changing the cursor.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::setCursor):
* UIProcess/WebPageProxy.h:
Decode the cursor.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc):
(WebKit::WebView::WebView):
(WebKit::WebView::onSetCursor):
(WebKit::WebView::setCursor):
* UIProcess/win/WebView.h:
Implement changing the cursor.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setCursor):
(WebKit::WebChromeClient::setLastSetCursorToCurrentCursor):
* WebProcess/WebCoreSupport/WebChromeClient.h:
Encode the cursor when setCursor is called.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 14 Jul 2010 18:49:42 +0000 (18:49 +0000)]
2010-07-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        reconstructActiveFormElements should reconstruct attributes as well
        https://bugs.webkit.org/show_bug.cgi?id=42222

        * html5lib/resources/adoption01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
2010-07-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        reconstructActiveFormElements should reconstruct attributes as well
        https://bugs.webkit.org/show_bug.cgi?id=42222

        The case in question is "<p><b foo='bar'></p>text</b>".
        When the "b" is re-opened to wrap the text it should include
        any attributes from the original (now closed) tag name.

        There are also similar cases for the Adoption Agency algorithm, but since
        the html5lib test suite did not cover those (and it wasn't immediately
        obvious to me how to test those) I've saved fixing that bug for a
        later patch.  For now I've just made the adoption agency use
        HTMLConstructionSite::createHTMLElementFromElementRecord so the
        FIXME can be in one place instead of two.

        In order to cleanly support createHTMLElementFromSavedElement
        I re-factored "attachToCurrent" out from createHTMLElementAndAttachToCurrent
        and changed all callers to use attachToCurrent(createHTMLElement(token)).

        This is covered by two existing tests in html5lib/runner.html
        and I wrote two more.  One to cover the basic case that we now pass
        and a second to cover an evil edge case which we do not.

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::attachToCurrent):
        (WebCore::HTMLConstructionSite::insertHTMLHtmlElement):
        (WebCore::HTMLConstructionSite::insertHTMLHeadElement):
        (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
        (WebCore::HTMLConstructionSite::insertHTMLElement):
        (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
        (WebCore::HTMLConstructionSite::insertScriptElement):
        (WebCore::HTMLConstructionSite::insertForeignElement):
        (WebCore::HTMLConstructionSite::createHTMLElementFromElementRecord):
        (WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
        (WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):
        * html/HTMLConstructionSite.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 14 Jul 2010 18:42:01 +0000 (18:42 +0000)]
2010-07-14  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Delete remaining references to utils3d.js from WebGL layout tests
        https://bugs.webkit.org/show_bug.cgi?id=42275

        * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
        * fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html:
        * fast/canvas/webgl/gl-uniformmatrix4fv.html:
        * fast/canvas/webgl/point-size.html:
        * fast/canvas/webgl/read-pixels.html:
        * fast/canvas/webgl/renderbuffer-initialization.html:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
        * fast/canvas/webgl/tex-image-with-format-and-type.html:
        * fast/canvas/webgl/tex-sub-image-2d.html:
        * fast/canvas/webgl/texture-npot.html:
        * fast/canvas/webgl/texture-transparent-pixels-initialized.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash when trying to enable JIT and Interpreter in a single build.
oliver@apple.com [Wed, 14 Jul 2010 18:33:49 +0000 (18:33 +0000)]
Crash when trying to enable JIT and Interpreter in a single build.

Reviewed by Don Melton.

CFPreferences code added at the last minute failed to account for
the preference not being present and then attempted to CFRelease
a null value.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd support for loading javascript: URLs
andersca@apple.com [Wed, 14 Jul 2010 18:24:26 +0000 (18:24 +0000)]
Add support for loading javascript: URLs
https://bugs.webkit.org/show_bug.cgi?id=42221

Reviewed by Sam Weinig.

WebCore:

* WebCore.exp.in:
Export protocolIsJavaScript and ScriptValue::getString.

WebKit2:

* WebProcess/Plugins/DummyPlugin.cpp:
(WebKit::DummyPlugin::controller):
* WebProcess/Plugins/DummyPlugin.h:
Add stub function.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::destroy):
Set the plug-in controller to 0.

(WebKit::NetscapePlugin::controller):
Return the plug-in controller.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add controller() member function.

* WebProcess/Plugins/Plugin.h:
Add controller() pure virtual member function.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performURLRequest):
If the given URL request has a javascript: protocol, call
performJavaScriptURLRequest.

(WebKit::PluginView::performFrameLoadURLRequest):
Add a security origin check.

(WebKit::PluginView::performJavaScriptURLRequest):
Evaluate the JavaScript code, Get the resulting string.

* WebProcess/Plugins/PluginView.h:
Add performJavaScriptURLRequest.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate the Windows platform specific results to S7.6_A3.1.html, because it is now
bweinstein@apple.com [Wed, 14 Jul 2010 18:20:18 +0000 (18:20 +0000)]
Update the Windows platform specific results to S7.6_A3.1.html, because it is now
passing on Windows.

Rubber-stamped by Adam Roben.

* platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 14 Jul 2010 18:18:23 +0000 (18:18 +0000)]
2010-07-14  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Synchronize webgl-test.js from Khronos repository
        https://bugs.webkit.org/show_bug.cgi?id=42212

        Incorporated latest webgl-test.js from Khronos repository. Deleted
        utils3d.js and removed references to it from tests. Updated those
        tests which were using the create3DDebugContext helper function,
        which has been removed. Rebaselined five tests.

        * fast/canvas/webgl/context-attributes-expected.txt:
        * fast/canvas/webgl/context-attributes.html:
        * fast/canvas/webgl/index-validation-copies-indices-expected.txt:
        * fast/canvas/webgl/index-validation-copies-indices.html:
        * fast/canvas/webgl/index-validation-verifies-too-many-indices-expected.txt:
        * fast/canvas/webgl/index-validation-verifies-too-many-indices.html:
        * fast/canvas/webgl/index-validation-with-resized-buffer.html:
        * fast/canvas/webgl/null-object-behaviour-expected.txt:
        * fast/canvas/webgl/null-object-behaviour.html:
        * fast/canvas/webgl/resources/utils3d.js: Removed.
        * fast/canvas/webgl/resources/webgl-test.js:
        (assertMsg):
        (webglTestLog):
        (create3DContext):
        (create3DContextWithWrapperThatThrowsOnGLError.wrap.getError):
        (create3DContextWithWrapperThatThrowsOnGLError):
        (getGLErrorAsString):
        (shouldGenerateGLError):
        (glErrorShouldBe):
        (createProgram):
        (initWebGL):
        (getShaderSource):
        (loadShader):
        (loadShaderFromFile):
        (loadShaderFromScript):
        (loadProgram):
        (loadStandardVertexShader):
        (loadStandardFragmentShader):
        (makeBox):
        (makeSphere):
        (loadObj.req.onreadystatechange):
        (loadObj):
        (processLoadObj):
        (doLoadObj):
        (loadImageTexture.texture.image.onload):
        (loadImageTexture):
        (doLoadImageTexture):
        (Framerate.fr):
        (Framerate):
        (Framerate.prototype.updateFramerate):
        (Framerate.prototype.snapshot):
        * fast/canvas/webgl/texImage2DImageDataTest.html:
        * fast/canvas/webgl/texture-active-bind.html:
        * fast/canvas/webgl/texture-complete.html:
        * fast/canvas/webgl/triangle.html:
        * fast/canvas/webgl/uniform-location-expected.txt:
        * fast/canvas/webgl/uniform-location.html:
        * fast/canvas/webgl/viewport-unchanged-upon-resize.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 14 Jul 2010 18:09:13 +0000 (18:09 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=42201
        Use ResourceHandle object for synchronous loading

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle): Moved common tasks from create() to constructor.
        (WebCore::ResourceHandle::firstRequest): Renamed from request(). This is not changed with
        redirect, so the old name was quite confusing.

        * platform/network/ResourceHandle.h: Made createNSURLConnection() a member function, since
        it now needs access to both ResourceHandle and ResourceHandleInternal. Added createCFURLConnection().

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal): Renamed m_request to m_firstRequest.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCoreSynchronousLoaderClient): Replaced an Objective C delegate class with a ResourceHandleClient
        subclass. This allows for much better code sharing, with common logic is in ResourceHandle.
        (WebCore::ResourceHandle::createNSURLConnection): Factored out more code that is common
        between sync and async parts.
        (WebCore::ResourceHandle::start): Ditto.
        (WebCore::ResourceHandle::cancel): Updated for firstRequest() renaming.
        (WebCore::ResourceHandle::loadResourceSynchronously): Use ResourceHandle and ResourceHandleClient,
        like a good loader.
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Updated for firstRequest() renaming.
        (WebCore::ResourceHandle::receivedCredential): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::WebCoreSynchronousLoaderClient::create):
        (WebCore::WebCoreSynchronousLoaderClient::setAllowStoredCredentials):
        (WebCore::WebCoreSynchronousLoaderClient::isDone):
        (WebCore::WebCoreSynchronousLoaderClient::data):
        (WebCore::WebCoreSynchronousLoaderClient::WebCoreSynchronousLoaderClient):
        (WebCore::willSendRequest):
        (WebCore::didReceiveResponse):
        (WebCore::didReceiveData):
        (WebCore::shouldUseCredentialStorageCallback):
        (WebCore::didFinishLoading):
        (WebCore::didFail):
        (WebCore::didReceiveChallenge):
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::ResourceHandle::createCFURLConnection):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::loadResourceSynchronously):
        (WebCore::WebCoreSynchronousLoaderClient::willSendRequest):
        (WebCore::WebCoreSynchronousLoaderClient::didReceiveResponse):
        (WebCore::WebCoreSynchronousLoaderClient::didReceiveData):
        (WebCore::WebCoreSynchronousLoaderClient::didFinishLoading):
        (WebCore::WebCoreSynchronousLoaderClient::didFail):
        (WebCore::WebCoreSynchronousLoaderClient::didReceiveAuthenticationChallenge):
        (WebCore::WebCoreSynchronousLoaderClient::shouldUseCredentialStorage):
        Same changes for CFNetwork version. Now it's a more direct copy/paste than before, some
        day we'll share the code.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::createResourceHandle):
        (WebCore::ApplicationCacheGroup::didReceiveResponse):
        (WebCore::ApplicationCacheGroup::didFinishLoading):
        (WebCore::ApplicationCacheGroup::didFail):
        (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::didReceiveResponse):
        (WebCore::IconLoader::didFail):
        (WebCore::IconLoader::didFinishLoading):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::headerCallback):
        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::start):
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::loadResourceSynchronously):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp):
        Updated for request() -> firstRequest renaming.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Wed, 14 Jul 2010 17:58:18 +0000 (17:58 +0000)]
2010-07-14  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Code generator: ensure generated constants match their corresponding enums.
        https://bugs.webkit.org/show_bug.cgi?id=42250

        Specific interfaces can use DontCheckEnums attribute to avoid generating the compile-time check.

        Tests: updated bindings tests. Generated code should compile.

        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        (WebDOMTestObj::):
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::JSTestObjPrototype::getOwnPropertySlot):
        (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
        (WebCore::jsTestObjCONST_VALUE_0):
        (WebCore::jsTestObjCONST_VALUE_1):
        (WebCore::jsTestObjCONST_VALUE_2):
        (WebCore::jsTestObjCONST_VALUE_4):
        (WebCore::jsTestObjCONST_VALUE_8):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::):
        (WebCore::ConfigureV8TestObjTemplate):
        * css/WebKitCSSTransformValue.idl:
        * dom/DOMCoreException.idl:
        * dom/EventException.idl:
        * dom/Node.idl:
        * dom/OverflowEvent.idl:
        * dom/RangeException.idl:
        * html/FileError.idl:
        * html/FileReader.idl:
        * html/canvas/Float32Array.idl:
        * html/canvas/Int16Array.idl:
        * html/canvas/Int32Array.idl:
        * html/canvas/Int8Array.idl:
        * html/canvas/Uint16Array.idl:
        * html/canvas/Uint32Array.idl:
        * html/canvas/Uint8Array.idl:
        * html/canvas/WebGLRenderingContext.idl:
        * inspector/JavaScriptCallFrame.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * storage/SQLException.idl:
        * svg/SVGComponentTransferFunctionElement.idl:
        * svg/SVGException.idl:
        * svg/SVGFEBlendElement.idl:
        * svg/SVGFEColorMatrixElement.idl:
        * svg/SVGFECompositeElement.idl:
        * svg/SVGFEConvolveMatrixElement.idl:
        * svg/SVGFEDisplacementMapElement.idl:
        * svg/SVGFEMorphologyElement.idl:
        * svg/SVGFETurbulenceElement.idl:
        * svg/SVGGradientElement.idl:
        * xml/XMLHttpRequestException.idl:
        * xml/XPathException.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTake out temporary define
jam@chromium.org [Wed, 14 Jul 2010 17:53:04 +0000 (17:53 +0000)]
Take out temporary define

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Wed, 14 Jul 2010 17:47:26 +0000 (17:47 +0000)]
2010-07-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ojan Vafai.

        Unbreak fast/canvas/gradient-add-second-start-end-stop.html

        Assigning the same CanvasGradient or CanvasPattern to fillStyle
        or strokeStyle may not be a no-op since the object could have been
        modified since it was last set.

        Regressed with <http://trac.webkit.org/changeset/63327>

        * html/canvas/CanvasStyle.cpp:
        (WebCore::operator==):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 14 Jul 2010 17:37:43 +0000 (17:37 +0000)]
2010-07-14  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed, build fix for r63326.

        Update platform expectations for r63326
        https://bugs.webkit.org/show_bug.cgi?id=42269

        r63326 added shouldBeGreaterThanOrEqual and updated the root expectations. This patch makes the same change to the platform-specific expectations.

        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Wed, 14 Jul 2010 16:55:03 +0000 (16:55 +0000)]
2010-07-14  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Canvas: Make assigning the same fillStyle or strokeStyle a fast no-op
        https://bugs.webkit.org/show_bug.cgi?id=42267

        Avoid calling into GraphicsContext when setting a style to its current value.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setStrokeStyle): Return early if the
        new style is the same as the current one.
        (WebCore::CanvasRenderingContext2D::setFillStyle): Same.
        * html/canvas/CanvasStyle.cpp:
        (WebCore::operator==): Added operator==(CanvasStyle, CanvasStyle)
        * html/canvas/CanvasStyle.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 14 Jul 2010 16:45:54 +0000 (16:45 +0000)]
2010-07-14  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Fisher.

        Implement Web Timing redirectStart, redirectEnd, redirectCount
        https://bugs.webkit.org/show_bug.cgi?id=42018

        Tests pass with --web-timing. Expectations set to FAIL because disabled by default.

        * fast/dom/script-tests/webtiming.js: Since this is not a redirect, redirect times and count should be zero.
        (checkTimingBeforeLoad):
        (checkWebTimingOnLoad):
        (checkWebTimingAfterLoad):
        * fast/dom/webtiming-expected.txt:
        * fast/js/resources/js-test-pre.js:
        (shouldBeGreaterThanOrEqual): Factored out so that other tests can share this method.
        * http/tests/misc/resources/webtiming-one-redirect.html: Added.
        * http/tests/misc/resources/webtiming-two-redirects.html: Added.
        * http/tests/misc/webtiming-one-redirect-expected.txt: Added.
        * http/tests/misc/webtiming-one-redirect.php: Added.
        * http/tests/misc/webtiming-two-redirects-expected.txt: Added.
        * http/tests/misc/webtiming-two-redirects.php: Added.
2010-07-14  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Fisher.

        Implement Web Timing redirectStart, redirectEnd, redirectCount
        https://bugs.webkit.org/show_bug.cgi?id=42018

        Tests: http/tests/misc/webtiming-one-redirect.php
               http/tests/misc/webtiming-two-redirects.php

        * loader/FrameLoaderTypes.h:
        (WebCore::FrameLoadTimeline::FrameLoadTimeline):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest): This method is called for each request (including server redirects). fetchStart is updated to the current time on each invocation so that it represents fetching of the final document and doesn't include redirect time. For each redirect, redirectCount is incremented and redirectStart to redirectEnd measures the cumulative fetch time for all redirects.
        * page/Navigation.cpp:
        (WebCore::Navigation::redirectCount): http://dev.w3.org/2006/webapi/WebTiming/#nt-redirect-count
        * page/Timing.cpp:
        (WebCore::Timing::redirectStart): http://dev.w3.org/2006/webapi/WebTiming/#nt-redirect-start
        (WebCore::Timing::redirectEnd): http://dev.w3.org/2006/webapi/WebTiming/#nt-redirect-end
        * page/Timing.h:
        * page/Timing.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Wed, 14 Jul 2010 16:21:23 +0000 (16:21 +0000)]
2010-07-14  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Antonio Gomes.

        Generate MathML files with CMake even if MathML is disabled. This
        fixes EFL build after r63274.
        https://bugs.webkit.org/show_bug.cgi?id=42263

        No new functionality, so no new tests.

        * CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 14 Jul 2010 15:39:39 +0000 (15:39 +0000)]
2010-07-14  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Get rid of libWebCoreJS
        https://bugs.webkit.org/show_bug.cgi?id=42083

        * GNUmakefile.am: Remove the libWebCoreJS library from the extra
        link libraries. Add IDL files to the distribution manually, as they
        are no longer included in the header list. This prevents a good deal
        of repetition in the source listings by avoiding listing both the IDL
        files and their final targets.
2010-07-14  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Get rid of libWebCoreJS
        https://bugs.webkit.org/show_bug.cgi?id=42083

        Remove the need to build libWebCoreJS.

        * GNUmakefile.am: List all auto-generated source files for libWebCoreJS
        instead of relying on make to build libWebCoreJS. This is a more autotools-
        -friendly approach.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 14 Jul 2010 15:34:12 +0000 (15:34 +0000)]
2010-07-14  Eric Carlson  <eric.carlson@apple.com>

        One more unreviewed build fix for r63319.

        * html/TimeRanges.cpp:
        (TimeRanges::nearest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Zoltan Herczeg <zherczeg@webkit.org>
zherczeg@webkit.org [Wed, 14 Jul 2010 15:20:56 +0000 (15:20 +0000)]
2010-07-14  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Darin Adler.

        Change indentations in the lexer
        https://bugs.webkit.org/show_bug.cgi?id=41845

        This patch fixes an old, indentation error comes from kjs,
        as webkit has a different style rule for switches, and change
        the indentation of the main switch, which is a temporary
        style error. This change makes easier to see the behavioural
        changes in the follow-up patch.

        No behavioural changes.

        * parser/Lexer.cpp:
        (JSC::singleEscape):
        (JSC::Lexer::lex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 14 Jul 2010 15:17:05 +0000 (15:17 +0000)]
2010-07-14  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Enable toggling of the "Inspect Element" mode from the browser
        https://bugs.webkit.org/show_bug.cgi?id=42169

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype.handleShortcut):
        (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
        * inspector/front-end/inspector.js:
        (WebInspector.toggleSearchingForNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 14 Jul 2010 15:04:09 +0000 (15:04 +0000)]
2010-07-14  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, build fix for r63319.

        * html/TimeRanges.cpp:
        (TimeRanges::nearest): Include math.h and use narrowPrecisionToFloat.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 14 Jul 2010 14:37:56 +0000 (14:37 +0000)]
2010-07-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Update media element's seeking logic
        https://bugs.webkit.org/show_bug.cgi?id=42178
        <rdar://problem/8185817>

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::seek): When asked to seek to an unbuffered time, seek to the
        nearest time instead of generating an exception. Re-order the logic to match spec text.

        * html/TimeRanges.cpp:
        (TimeRanges::nearest): New, return the value closest to the specified time.
        * html/TimeRanges.h:

2010-07-14  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Update media element's seeking logic.
        https://bugs.webkit.org/show_bug.cgi?id=42178
        <rdar://problem/8185817>

        * http/tests/media/video-seekable-stall-expected.txt:
        * http/tests/media/video-seekable-stall.html: Seeking to an unbuffered time no longer
        generates an exception.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
commit-queue@webkit.org [Wed, 14 Jul 2010 14:35:08 +0000 (14:35 +0000)]
2010-07-14  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Introduce QScriptOriginalGlobalObject.

        QtScript exposes more functionality than JSC C API. Sometimes it is
        necessary to take a shortcut in implementation. Really often we have
        to use a standard JS function. These function could be changed or
        even deleted by a script, so a backup of a reference to an object is needed.

        In them same time this is rather a workaround then real fix, so the code
        should be separated and changed easily in future. It is why we need
        the new internal class.

        The patch fixes a few crashes.

        [Qt] QScriptEngine should work correctly even after global object changes
        https://bugs.webkit.org/show_bug.cgi?id=41839

        * api/QtScript.pro:
        * api/qscriptengine_p.cpp:
        (QScriptEnginePrivate::QScriptEnginePrivate):
        (QScriptEnginePrivate::~QScriptEnginePrivate):
        * api/qscriptengine_p.h:
        (QScriptEnginePrivate::isArray):
        (QScriptEnginePrivate::isError):
        (QScriptEnginePrivate::objectHasOwnProperty):
        (QScriptEnginePrivate::objectGetOwnPropertyNames):
        * api/qscriptoriginalglobalobject_p.h: Added.
        (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject):
        (QScriptOriginalGlobalObject::initializeMember):
        (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject):
        (QScriptOriginalGlobalObject::objectHasOwnProperty):
        (QScriptOriginalGlobalObject::objectGetOwnPropertyNames):
        (QScriptOriginalGlobalObject::isArray):
        (QScriptOriginalGlobalObject::isError):
        (QScriptOriginalGlobalObject::isType):
        * api/qscriptvalue_p.h:
        (QScriptValuePrivate::isError):
        (QScriptValuePrivate::hasOwnProperty):
        * api/qscriptvalueiterator_p.h:
        (QScriptValueIteratorPrivate::QScriptValueIteratorPrivate):
        * tests/qscriptvalue/tst_qscriptvalue.cpp:
        (tst_QScriptValue::globalObjectChanges):
        * tests/qscriptvalue/tst_qscriptvalue.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Hans Wennborg <hans@chromium.org>
commit-queue@webkit.org [Wed, 14 Jul 2010 14:22:49 +0000 (14:22 +0000)]
2010-07-14  Hans Wennborg  <hans@chromium.org>

        Reviewed by Steve Block.

        Rename DeviceOrientationController::onOrientationChange to didChangeDeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=42257

        According to convention, we should avoid "on" in favor of "did" in function names.

        * dom/DeviceOrientationController.cpp:
        (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
        * dom/DeviceOrientationController.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Wed, 14 Jul 2010 14:10:29 +0000 (14:10 +0000)]
2010-07-14  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kent Tamura.

        Notify browser about popup being deleted. In EFL and BREW ports, the
        WebCore::Popup object was being deleted leaving the popup in browser
        alive. Popups can be deleted in two ways: either from browser to webcore or
        from webcore to browser. The first path was ok. The problem was when the
        user changed the page with a popup still opened. This would trigger the
        second path and would cause WebCore::Popup to be deleted without
        notifying browser.
        https://bugs.webkit.org/show_bug.cgi?id=41877

        No new functionality so no new tests.

        * platform/brew/PopupMenuBrew.cpp:
        (WebCore::PopupMenu::~PopupMenu): call hide() when object is
        destroyed.
        * platform/efl/PopupMenuEfl.cpp:
        (WebCore::PopupMenu::~PopupMenu): ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Wed, 14 Jul 2010 13:57:48 +0000 (13:57 +0000)]
2010-07-14  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Invoke speech recognition when user clicks on the speech button of input elements.
        http://bugs.webkit.org/show_bug.cgi?id=42047

        No new tests, the relevant LayoutTestController bindings will be added in a subsequent patch.

        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Added click handling.
        (WebCore::InputFieldSpeechButtonElement::speechInput):
        (WebCore::InputFieldSpeechButtonElement::recordingComplete): Callback to indicate recording progress.
        (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Callback to receive recognized text.
        (WebCore::InputFieldSpeechButtonElement::detach):
        * rendering/TextControlInnerElements.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
yurys@chromium.org [Wed, 14 Jul 2010 13:20:30 +0000 (13:20 +0000)]
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63305.
        http://trac.webkit.org/changeset/63305
        https://bugs.webkit.org/show_bug.cgi?id=42256

        "debugger-breakpoints-not-activated-on-reload.html fails on
        GTK" (Requested by yurys on #webkit).

        * http/tests/inspector/debugger-test.js:
        (frontend_completeDebuggerTest):
        * inspector/debugger-breakpoints-not-activated-on-reload-expected.txt: Removed.
        * inspector/debugger-breakpoints-not-activated-on-reload.html: Removed.
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63305.
        http://trac.webkit.org/changeset/63305
        https://bugs.webkit.org/show_bug.cgi?id=42256

        "debugger-breakpoints-not-activated-on-reload.html fails on
        GTK" (Requested by yurys on #webkit).

        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype._addBreakpoint):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype._breakpointAdded):
        (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._addBreakpoint):
2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63305.
        http://trac.webkit.org/changeset/63305
        https://bugs.webkit.org/show_bug.cgi?id=42256

        "debugger-breakpoints-not-activated-on-reload.html fails on
        GTK" (Requested by yurys on #webkit).

        * src/js/DebuggerScript.js:
        ():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 14 Jul 2010 12:59:41 +0000 (12:59 +0000)]
2010-07-14  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test expectations.

        * platform/chromium-linux/svg/custom/recursive-gradient-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/recursive-pattern-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/recursive-filter-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/recursive-filter-expected.png: Added.
        * platform/chromium-win/svg/custom/recursive-filter-expected.checksum: Added.
        * platform/chromium-win/svg/custom/recursive-filter-expected.png: Added.
        * platform/chromium-win/svg/custom/recursive-gradient-expected.checksum: Added.
        * platform/chromium-win/svg/custom/recursive-gradient-expected.png: Added.
        * platform/chromium-win/svg/custom/recursive-mask-expected.checksum: Added.
        * platform/chromium-win/svg/custom/recursive-mask-expected.png: Added.
        * platform/chromium-win/svg/custom/recursive-pattern-expected.checksum: Added.
        * platform/chromium-win/svg/custom/recursive-pattern-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-07-14 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 14 Jul 2010 12:54:49 +0000 (12:54 +0000)]
2010-07-14  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide implementation of DeviceOrientationController and hook into DOMWindow
        https://bugs.webkit.org/show_bug.cgi?id=39588

        Added DeviceOrientationController::addListener() and removeListener()
        to start and stop the client and added calls from DomWindow. Implemented
        DeviceOrientationController::onDeviceOrientationChange() to fire a
        DeviceOrientationEvent on the window object.

        No new tests yet, pending LayoutTestController methods for mock DeviceOrientation.

        * dom/DeviceOrientationClient.h:
        * dom/DeviceOrientationController.cpp:
        (WebCore::DeviceOrientation::addListener):
        (WebCore::DeviceOrientation::removeListener):
        (WebCore::DeviceOrientation::removeAllListeners):
        (WebCore::DeviceOrientationController::onDeviceOrientationChange):
        * dom/DeviceOrientationController.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::addEventListener):
        (WebCore::DOMWindow::removeEventListener):
        (WebCore::DOMWindow::removeAllEventListeners):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63312 268f45cc-cd09-0410-ab3c-d52691b4dbfc