WebKit.git
9 years agoUnreviewed build fix for Qt.
alexis.menard@openbossa.org [Sat, 10 Dec 2011 13:55:21 +0000 (13:55 +0000)]
Unreviewed build fix for Qt.

Build error introduced by r102484.

* Target.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebPImageDecoder progressive decodes fail to decode valid images
noel.gordon@gmail.com [Sat, 10 Dec 2011 09:54:37 +0000 (09:54 +0000)]
WebPImageDecoder progressive decodes fail to decode valid images
https://bugs.webkit.org/show_bug.cgi?id=74062

Reviewed by Adam Barth.

The WEBP header is followed by a so-called P0 header, then some data to
decode.  If a partial P0 header is received during progressive decodes,
WebPIDecGetRGB() returns false; that makes the decoder enter the failed
state, no image appears on the page.

James Zern (webp) recommended the following via e-mail:

WebPIUpdate() validates input data, and will return an error status for
malformed data (bit-stream error, invalid data).  Otherwise, it returns
OK or SUSPENDED.  OK means that decoding is done/complete/no-error, and
SUSPENDED means more input data is needed to complete decoding.  A NULL
return from WebPIDecGetRGB() is valid at this time due to a partial P0,
and should not be interpreted as a decoding failure.

No new tests. Not something DumpRenderTree can easily test.

* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::decode):  A NULL WebPIDecGetRGB() return is
acceptable here.  Return false instead of failing the decoder.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd the FileSystem functions of iOS
benjamin@webkit.org [Sat, 10 Dec 2011 05:34:02 +0000 (05:34 +0000)]
Add the FileSystem functions of iOS
https://bugs.webkit.org/show_bug.cgi?id=74164

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-12-09
Reviewed by David Kilzer.

Two functions are needed on iOS for temporary files and directories.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/FileSystemIOS.h: Added.
* platform/ios/FileSystemIOS.mm: Added.
(WebCore::createTemporaryDirectory):
(WebCore::createTemporaryFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp
commit-queue@webkit.org [Sat, 10 Dec 2011 03:03:29 +0000 (03:03 +0000)]
Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74197

The bufferedData() was removed in r95120.

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-09
Reviewed by Rob Buis.

Trivial fix, so no new tests.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream BlackBerry API backing store files
commit-queue@webkit.org [Sat, 10 Dec 2011 02:46:12 +0000 (02:46 +0000)]
Upstream BlackBerry API backing store files
https://bugs.webkit.org/show_bug.cgi?id=73668

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-09
Reviewed by Daniel Bates.

Contributed by Torch team, the main contributor is Adam Treat
<atreat@rim.com>.

Initial upstream, no new tests.

* blackberry/Api/BackingStore.cpp: Added.
* blackberry/Api/BackingStore.h: Added.
* blackberry/Api/BackingStore_p.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Prevent ASSERT in legitimate out-of-memory case.
commit-queue@webkit.org [Sat, 10 Dec 2011 02:35:35 +0000 (02:35 +0000)]
[chromium] Prevent ASSERT in legitimate out-of-memory case.
https://bugs.webkit.org/show_bug.cgi?id=74215

Patch by Eric Penner <epenner@google.com> on 2011-12-09
Reviewed by James Robinson.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNameNodeListCache should be invalidated when name attribute changes/modified.
commit-queue@webkit.org [Sat, 10 Dec 2011 02:29:51 +0000 (02:29 +0000)]
NameNodeListCache should be invalidated when name attribute changes/modified.
https://bugs.webkit.org/show_bug.cgi?id=70810

Patch by Arko Saha <arko@motorola.com> on 2011-12-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/getelementsbyname-invalidation-cache.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseMappedAttribute):
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::parseMappedAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseMappedAttribute):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::parseMappedAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::parseMappedAttribute):

LayoutTests:

* fast/dom/getelementsbyname-invalidation-cache-expected.txt: Added.
* fast/dom/getelementsbyname-invalidation-cache.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release...
levin@chromium.org [Sat, 10 Dec 2011 02:26:41 +0000 (02:26 +0000)]
REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=70619

Reviewed by Alexey Proskuryakov.

* platform/mac/Skipped: Unskip various worker tests as they should work
now that bug 71695 is fixed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG ArithMul power-of-two case does not check for overflow
fpizlo@apple.com [Sat, 10 Dec 2011 02:15:39 +0000 (02:15 +0000)]
DFG ArithMul power-of-two case does not check for overflow
https://bugs.webkit.org/show_bug.cgi?id=74230

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Disabled power-of-2 peephole optimization for multiplication, because it was wrong,
and any attempt to fix it would likely introduce code bloat and register pressure.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMul):

LayoutTests:

Reviewed by Gavin Barraclough.

* fast/js/dfg-multiply-expected.txt: Added.
* fast/js/dfg-multiply.html: Added.
* fast/js/script-tests/dfg-multiply.js: Added.
(doMultiplyConstant2):
(doMultiplyConstant3):
(doMultiplyConstant4):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r101863-r102042): Assertion hit: m_verifier.isSafeToUse() in RefCountedBas...
levin@chromium.org [Sat, 10 Dec 2011 02:13:02 +0000 (02:13 +0000)]
REGRESSION(r101863-r102042): Assertion hit: m_verifier.isSafeToUse() in RefCountedBase::ref in FunctionCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=73886

Reviewed by Darin Adler.

* runtime/SymbolTable.h:
(JSC::SharedSymbolTable::SharedSymbolTable): Added deprecatedTurnOffVerifier for
another JavaScriptObject, since JavaScriptCore objects allow use on multiple threads.
Bug 58091 is about changing these deprecated calls to something else but that something
else will still need to be in all of these places.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Snow Leopard build some more.
mrowe@apple.com [Sat, 10 Dec 2011 02:06:25 +0000 (02:06 +0000)]
Fix the Snow Leopard build some more.

Move the #if to a location where it will do some good.

* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] Unskip two passing Shadow DOM tests
commit-queue@webkit.org [Sat, 10 Dec 2011 01:59:34 +0000 (01:59 +0000)]
[Gtk] Unskip two passing Shadow DOM tests
https://bugs.webkit.org/show_bug.cgi?id=74186

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-12-09
Reviewed by Martin Robinson.

Unskip two passing tests after bug #59571 was fixed.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary file DissasemblerARM.cpp from build system
commit-queue@webkit.org [Sat, 10 Dec 2011 01:57:24 +0000 (01:57 +0000)]
Remove unnecessary file DissasemblerARM.cpp from build system
https://bugs.webkit.org/show_bug.cgi?id=74184

Patch by Konrad Piascik <kpiascik@rim.com> on 2011-12-09
Reviewed by Daniel Bates.

* PlatformBlackBerry.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Snow Leopard build.
mrowe@apple.com [Sat, 10 Dec 2011 01:54:25 +0000 (01:54 +0000)]
Fix the Snow Leopard build.

Wrap some code that is only applicable to Lion and newer in the appropriate #if's.

* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Lion release build.
andersca@apple.com [Sat, 10 Dec 2011 01:44:06 +0000 (01:44 +0000)]
Fix Lion release build.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] request parameter of QQuickWebView::navigationRequested is not a registered...
commit-queue@webkit.org [Sat, 10 Dec 2011 01:41:36 +0000 (01:41 +0000)]
[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
https://bugs.webkit.org/show_bug.cgi?id=73826

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-09
Reviewed by Tor Arne Vestbø.

.:

* Source/qtwebkit-export.map: Adding QWebNavigationRequest

Source/WebKit/qt:

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes): Registering QWebNavigationRequest

Source/WebKit2:

Adding QWebNavigationRequest by moving NavigationRequest out of QtWebPagePolicyClient.

* Target.pri:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebnavigationrequest.cpp: Added.
(QWebNavigationRequestPrivate::QWebNavigationRequestPrivate):
(QWebNavigationRequestPrivate::~QWebNavigationRequestPrivate):
(QWebNavigationRequest::QWebNavigationRequest):
(QWebNavigationRequest::~QWebNavigationRequest):
(QWebNavigationRequest::setAction):
(QWebNavigationRequest::url):
(QWebNavigationRequest::button):
(QWebNavigationRequest::modifiers):
(QWebNavigationRequest::action):
* UIProcess/API/qt/qwebnavigationrequest_p.h: Added.
* UIProcess/qt/QtWebPagePolicyClient.cpp:
(QtWebPagePolicyClient::decidePolicyForNavigationAction):
(QtWebPagePolicyClient::decidePolicyForResponse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[FileSystem API] Entry.remove successCallback is required
commit-queue@webkit.org [Sat, 10 Dec 2011 01:39:11 +0000 (01:39 +0000)]
[FileSystem API] Entry.remove successCallback is required
https://bugs.webkit.org/show_bug.cgi?id=69639

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-12-09
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/filesystem/simple-required-arguments-remove.html

* fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter

LayoutTests:

* fast/filesystem/resources/simple-required-arguments-remove.js: Added.
(errorCallback):
(successCallback):
* fast/filesystem/simple-required-arguments-remove-expected.txt: Added.
* fast/filesystem/simple-required-arguments-remove.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove forwarding headers for WebLayer APIs
jamesr@google.com [Sat, 10 Dec 2011 01:31:15 +0000 (01:31 +0000)]
[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729

Reviewed by Adam Barth.

These are no longer necessary.

* WebKit.gyp:
* public/WebContentLayer.h: Removed.
* public/WebContentLayerClient.h: Removed.
* public/WebExternalTextureLayer.h: Removed.
* public/WebLayer.h: Removed.
* public/WebLayerClient.h: Removed.
* public/WebLayerTreeView.h: Removed.
* public/WebLayerTreeViewClient.h: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unskip API tests
commit-queue@webkit.org [Sat, 10 Dec 2011 01:28:28 +0000 (01:28 +0000)]
[Qt][WK2] Unskip API tests
https://bugs.webkit.org/show_bug.cgi?id=74180

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-12-09
Reviewed by Tor Arne Vestbø.

Unskip API tests for geolocation and javascript dialogs.

* UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobackground-image transitions trigger between equivalent images
timothy_horton@apple.com [Sat, 10 Dec 2011 01:26:36 +0000 (01:26 +0000)]
background-image transitions trigger between equivalent images
https://bugs.webkit.org/show_bug.cgi?id=74229
<rdar://problem/10558627>

Reviewed by Darin Adler.
Patch by Simon Fraser.

For animation property wrappers around StyleImage properties,
test the equivalence of the image itself, instead of equality of
the StyleImage pointer.

Test: transitions/equivalent-background-image-no-transition.html

* page/animation/AnimationBase.cpp:
(WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
(WebCore::StyleImagePropertyWrapper::equals):
(WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
(WebCore::FillLayerStyleImagePropertyWrapper::equals):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::AnimationBase::ensurePropertyMap):

Add a test ensuring that background-images aren't needlessly transitioned
when they are equivalent.

* transitions/equivalent-background-image-no-transition-expected.txt: Added.
* transitions/equivalent-background-image-no-transition.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/74061> WebProcess and PluginProcess should inherit environment...
mrowe@apple.com [Sat, 10 Dec 2011 01:25:29 +0000 (01:25 +0000)]
<webkit.org/b/74061> WebProcess and PluginProcess should inherit environment variables provided in LC_DYLD_ENVIRONMENT of main executable binary.

Reviewed by Darin Adler.

* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: Added.
* UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: Added.
(WebKit::DynamicLinkerEnvironmentExtractor::DynamicLinkerEnvironmentExtractor):
(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable): Parse out the name
and value from the environment string and add an entry to our variable map if the variable
is one that dyld would respect in LC_DYLD_ENVIRONMENT.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommand): Look for a LC_DYLD_ENVIRONMENT
load command and extract any environment string that we find within.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommands): Iterate over each
load command in the Mach-O file.
(WebKit::DynamicLinkerEnvironmentExtractor::processSingleArchitecture): Determine whether
the Mach-O file is of the correct architecture, and if so then process the load commands
found within.
(WebKit::DynamicLinkerEnvironmentExtractor::processFatFile): Process each architecture of the
Mach-O file in turn.
(WebKit::DynamicLinkerEnvironmentExtractor::getExtractedEnvironmentVariables): Add our
extracted variables to the passed-in EnvironmentVariables object. We skip adding any
variables that already exist so as to allow variables passed in the environment to override
those that we extract from the executable file.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess): Extract the environment variables from the
main binary and add them to the launch environment of our subprocess.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] add accessors to WebDOMMessageEvent
commit-queue@webkit.org [Sat, 10 Dec 2011 01:18:20 +0000 (01:18 +0000)]
[chromium] add accessors to WebDOMMessageEvent
https://bugs.webkit.org/show_bug.cgi?id=73346

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-09
Reviewed by Darin Fisher.

* public/WebDOMMessageEvent.h:
* src/WebDOMMessageEvent.cpp:
(WebKit::WebDOMMessageEvent::data):
(WebKit::WebDOMMessageEvent::origin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] add event methods to WebFrame
commit-queue@webkit.org [Sat, 10 Dec 2011 01:09:09 +0000 (01:09 +0000)]
[chromium] add event methods to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=73259

Patch by Karl Koscher <supersat@chromium.org> on 2011-12-09
Reviewed by Darin Fisher.

* public/WebDOMEventListener.h: Use EventTarget instead of Node
* public/WebFrame.h: Add event methods
* src/WebDOMEventListener.cpp: Use EventTarget instead of Node
(WebKit::WebDOMEventListener::createEventListenerWrapper):
(WebKit::WebDOMEventListener::getEventListenerWrapper):
* src/WebDOMEventListenerPrivate.cpp: Use EventTarget instead of Node
(WebKit::WebDOMEventListenerPrivate::createEventListenerWrapper):
(WebKit::WebDOMEventListenerPrivate::getEventListenerWrapper):
* src/WebDOMEventListenerPrivate.h: Use EventTarget instead of Node
(WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addEventListener): register a listener on a WebFrame
(WebKit::WebFrameImpl::removeEventListener): remove a listener on a WebFrame
(WebKit::WebFrameImpl::dispatchEvent): dispatch an event to a WebFrame
* src/WebFrameImpl.h: Add event methods

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKView implementation for quickLookPreviewItemsAtWindowLocation.
weinig@apple.com [Sat, 10 Dec 2011 01:05:18 +0000 (01:05 +0000)]
Add WKView implementation for quickLookPreviewItemsAtWindowLocation.
<rdar://problem/10472505>

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKView.mm:
(-[WKView quickLookPreviewItemsAtWindowLocation:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Open shared memory files with shm_open.
commit-queue@webkit.org [Sat, 10 Dec 2011 01:01:12 +0000 (01:01 +0000)]
[Qt] Open shared memory files with shm_open.
https://bugs.webkit.org/show_bug.cgi?id=74078

Original patch by Kimmo Kinnunen

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

Open shared memory files with shm_open. This uses mount point that is
intended to host shared memory files. Typically this is /dev/shm.

This fixes crashes when filesystem that hosts QDir::temp() is full.

This is also more well-defined with respect to question whether SHM
writes to temp dir would cause unintended wear if hosted on flash drives.

This also fixes performance problems regarding QDir::temp() and
mkostemp(), both of which appear to be long operations.

* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSmall style fix on DragDataBlackBerry.cpp
commit-queue@webkit.org [Sat, 10 Dec 2011 01:01:02 +0000 (01:01 +0000)]
Small style fix on DragDataBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74171

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-09
Reviewed by Rob Buis.

Style fix, no function impact, no new tests.

* platform/blackberry/DragDataBlackBerry.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix test expectations from r102486: flex-flow returns direction and wrap now.
tony@chromium.org [Sat, 10 Dec 2011 00:47:29 +0000 (00:47 +0000)]
Fix test expectations from r102486: flex-flow returns direction and wrap now.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agochromium win build: revert build_webkit_exes_from_webkit_gyp change
dpranke@chromium.org [Sat, 10 Dec 2011 00:41:40 +0000 (00:41 +0000)]
chromium win build: revert build_webkit_exes_from_webkit_gyp change
https://bugs.webkit.org/show_bug.cgi?id=74225

Source/WebKit/chromium:

Reviewed by Tony Chang.

This change sets build_webkit_exes_from_webkit_gyp back to 1;
the "All.gyp" solution doesn't work on windows.

* gyp_webkit:

Tools:

This change sets build_webkit_exes_from_webkit_gyp back to 1;
the "All.gyp" solution doesn't work on windows.

* Scripts/webkitdirs.pm:
(buildChromium):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG's interpretation of rare case profiles should be frequency-based not count-based
fpizlo@apple.com [Sat, 10 Dec 2011 00:09:55 +0000 (00:09 +0000)]
DFG's interpretation of rare case profiles should be frequency-based not count-based
https://bugs.webkit.org/show_bug.cgi?id=74170

Reviewed by Geoff Garen.

DFG optimizes for rare cases only when the rare case counter is above some threshold
and it also constitutes a large enough fraction of total function executions. Also
added some minor debug logic.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::executionEntryCount):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Click's count is limited to three continuous clicks.
commit-queue@webkit.org [Fri, 9 Dec 2011 23:53:35 +0000 (23:53 +0000)]
[Qt] Click's count is limited to three continuous clicks.
https://bugs.webkit.org/show_bug.cgi?id=45666

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Make Qt recognize "infinite" continuous mouse clicks.
handleMouseDoubleClickEvent merged into handleMousePressEvent.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::handleEvent):
(QtWebPageEventHandler::handleMousePressEvent):
(QtWebPageEventHandler::timerEvent):
* UIProcess/qt/QtWebPageEventHandler.h:

Tools:

Update m_time at every call to leapForward, so double clicks
event are correctly sent by EventSender.

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::leapForward):

LayoutTests:

Enable fast/events/click-count.html for qt and disable for qt-wk1.

* platform/qt-wk1/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Reduce top-level code in prepare-ChangeLog
haraken@chromium.org [Fri, 9 Dec 2011 23:50:58 +0000 (23:50 +0000)]
[Refactoring] Reduce top-level code in prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74172

Reviewed by Ryosuke Niwa.

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.

* Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
(generateFunctionLists):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd css parsing for flex-flow: wrap and wrap-reverse
ojan@chromium.org [Fri, 9 Dec 2011 23:50:16 +0000 (23:50 +0000)]
add css parsing for flex-flow: wrap and wrap-reverse
https://bugs.webkit.org/show_bug.cgi?id=74008

Patch by Tony Chang <tony@chromium.org> on 2011-12-09
Reviewed by Ojan Vafai.

Source/WebCore:

Also save 2 bits in StyleFlexibleBoxData by changing the size of m_flexFlow (there are only 4 enum values).

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Print the wrap value if it exists.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Parse a second token and put the values into a CSSValueList.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyFlexFlow::applyInheritValue): Does not inherit.
(WebCore::ApplyPropertyFlexFlow::applyInitialValue):
(WebCore::ApplyPropertyFlexFlow::applyValue): Special handler for setting two render style values from one
CSS property.
(WebCore::ApplyPropertyFlexFlow::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexWrap):
(WebCore::InheritedFlags::setFlexWrap):
(WebCore::InheritedFlags::initialFlexWrap):
* rendering/style/RenderStyleConstants.h: EFlexWrap to hold flex wrap values.
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h: 2 bits is enough to hold the 4 flexFlow values.

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js: Test call combinations of flex-flow values.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPutByValAlias unnecessarily clobbers GetIndexedPropertyStorage
oliver@apple.com [Fri, 9 Dec 2011 23:47:42 +0000 (23:47 +0000)]
PutByValAlias unnecessarily clobbers GetIndexedPropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=74223

Reviewed by Geoffrey Garen.

Don't clobber GetIndexedPropertyStorage when we see PutByValAlias

* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
weinig@apple.com [Fri, 9 Dec 2011 23:45:49 +0000 (23:45 +0000)]
Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=74218

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WebKit2.WKConnectionTest in TestWebKitAPI

* Shared/WebConnection.cpp:
(WebKit::WebConnection::forwardDidReceiveMessageToClient):
* Shared/WebConnection.h:
Add helper for connection subclasses to dispatch to the client.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::didReceiveMessage):
Handle postMessage messages from the WebProcess.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::processDidFinishLaunching):
Dispatch the notification that a connection to the WebProcess has
been established.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGetApplicationConnection):
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::webConnectionToUIProcess):
* WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit::WebProcess::webConnectionToUIProcess):
Add accessor to get the connection to the UIProcess from
the bundle.

* WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::didReceiveMessage):
Handle postMessage messages from the UIProcess.
* WebProcess/WebProcess.h:

Tools:

Add a test of the WKConnectionRef API.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
(TestWebKitAPI::didCreateConnection):
(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::connectionDidClose):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
(TestWebKitAPI::connectionDidReceiveMessage):
(TestWebKitAPI::WKConnectionTest::WKConnectionTest):
(TestWebKitAPI::WKConnectionTest::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHash* iterators should allow comparison between const and const versions.
levin@chromium.org [Fri, 9 Dec 2011 23:43:52 +0000 (23:43 +0000)]
Hash* iterators should allow comparison between const and const versions.
https://bugs.webkit.org/show_bug.cgi?id=73370

Reviewed by Darin Adler.

Source/JavaScriptCore:

* wtf/HashTable.h: Add the operators needed to do this.
(WTF::HashTableConstIterator::operator==):
(WTF::HashTableConstIterator::operator!=):
(WTF::HashTableIterator::operator==):
(WTF::HashTableIterator::operator!=):
(WTF::operator==):
(WTF::operator!=):

Tools:

* TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
* TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
(TestWebKitAPI::TEST): Add a test for the new functionality.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agochromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
dpranke@chromium.org [Fri, 9 Dec 2011 23:39:45 +0000 (23:39 +0000)]
chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
https://bugs.webkit.org/show_bug.cgi?id=74212

Reviewed by Tony Chang.

The change introduced in r102201 to split the executables out of
WebKit.gyp apparently doesn't work right on Windows, since
WebKit.gyp and Tools.gyp refer to dependent projects by
different relative paths (it appears gyp doesn't normalize the
paths). This change moves Tools.gyp to be in the same directory
as WebKit.gyp (and All.gyp), which should fix this and
conveniently will also solve the problem of how to add Tools.gyp
to the chromium DEPS file.

Source/WebKit/chromium:

* All.gyp:
* Tools.gyp: Renamed from ../../../Tools/Tools.gyp.

Tools:

* Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description...
haraken@chromium.org [Fri, 9 Dec 2011 23:26:42 +0000 (23:26 +0000)]
[Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
https://bugs.webkit.org/show_bug.cgi?id=74173

Reviewed by Ryosuke Niwa.

The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
This requires to remove top-level code. This patch is one of the incremental refactorings
for that.

* Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
(fetchBugDescriptionFromURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add RefPtrEfl specialization for evas_object.
commit-queue@webkit.org [Fri, 9 Dec 2011 23:26:38 +0000 (23:26 +0000)]
[EFL] Add RefPtrEfl specialization for evas_object.
https://bugs.webkit.org/show_bug.cgi?id=73790

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-12-09
Reviewed by Ryosuke Niwa.

As evas_object is also based on reference count, RefPtr is applied for evas_object.

* PlatformEfl.cmake:
* platform/efl/RefPtrEfl.cpp: Added.
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
* platform/efl/RefPtrEfl.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(102234): 2-3% layout regression
tony@chromium.org [Fri, 9 Dec 2011 23:23:23 +0000 (23:23 +0000)]
REGRESSION(102234): 2-3% layout regression
https://bugs.webkit.org/show_bug.cgi?id=74141

Reviewed by David Hyatt.

Don't allocate a RuleSet when there are no regions.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForRegionStyling):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix assertion failure in ScrollAnimatorMac
andersca@apple.com [Fri, 9 Dec 2011 23:21:10 +0000 (23:21 +0000)]
Fix assertion failure in ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74222

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
This can be called with a nil scrollerImp, just return NSZeroPoint when that happens.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] Add test for deliver-at-end-of-task semantics
adamk@chromium.org [Fri, 9 Dec 2011 22:48:16 +0000 (22:48 +0000)]
[MutationObservers] Add test for deliver-at-end-of-task semantics
https://bugs.webkit.org/show_bug.cgi?id=74190

Reviewed by Ojan Vafai.

The addition of eventSender.scheduleAsynchronousKeyDown in r102424
allows testing the code added in r101842 and http://crrev.com/113010.

Added a test using a contentEditable element and an onblur event
handler that asserts it fires after mutations due to editing have been
delivered.

* fast/mutation/end-of-task-delivery-expected.txt: Added.
* fast/mutation/end-of-task-delivery.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove the "is currently drawing into layer" flag out into ScrollbarThemeMac
andersca@apple.com [Fri, 9 Dec 2011 22:48:01 +0000 (22:48 +0000)]
Move the "is currently drawing into layer" flag out into ScrollbarThemeMac
https://bugs.webkit.org/show_bug.cgi?id=74217

Reviewed by Beth Dakin.

There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate layer]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer):
(WebCore::ScrollbarThemeMac::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoYARR: Multi-character read optimization for 8bit strings
msaboff@apple.com [Fri, 9 Dec 2011 22:42:31 +0000 (22:42 +0000)]
YARR: Multi-character read optimization for 8bit strings
https://bugs.webkit.org/show_bug.cgi?id=74191

Reviewed by Oliver Hunt.

Changed generatePatternCharacterOnce to generate
code for 1 to 4 characters in the 8 bit case.
This is worth 29% improvement on SunSpider regexp-dna test.
It provides no benefit to v8-regexp.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generate): Spelling fix in comment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMinor cleanup in ScrollAnimatorMac.mm
andersca@apple.com [Fri, 9 Dec 2011 22:07:08 +0000 (22:07 +0000)]
Minor cleanup in ScrollAnimatorMac.mm
https://bugs.webkit.org/show_bug.cgi?id=74211

Reviewed by Andreas Kling.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
No need to get the scrollbar from the scroll animator anymore.

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegression(r53595): Sync xhr requests in workers aren't terminated on worker close.
levin@chromium.org [Fri, 9 Dec 2011 22:05:12 +0000 (22:05 +0000)]
Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.
https://bugs.webkit.org/show_bug.cgi?id=71695

Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

* wtf/MessageQueue.h:
(WTF::MessageQueue::tryGetMessageIgnoringKilled): Added a way to get messages
even after the queue has been killed. This is useful when one wants to
kill a queue but then go through it to run clean up tasks from it.

Source/WebCore:

Overview: Message loops rely on the message queue being killed in order
to exit. r53595 stopped this from happening because killing a message loop
would also stop it from doing database clean up tasks. The database clean up
tasks needed to be tasks due to ordering issues. (They wanted to run after
certain order tasks were run.) This was solved by once again terminating
the message queue but then still runnning clean-up tasks from the killed
message queue.

* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::run): Added the call to run clean-up tasks.
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks): Loop to simply clear out all clean up tasks.
(WebCore::WorkerRunLoop::Task::performTask): Stop non-clean up tasks
from running after the loop has been terminated.
* workers/WorkerRunLoop.h:
(WebCore::WorkerRunLoop::terminated): Just made it const.
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask): Removed
the terminate clause since it was put back in stop.
(WebCore::WorkerThread::stop): Terminate the run loop so
that all loops will exit and clean up tasks will run. Also removed a comment
about nested workers because nested workers are no longer imminent and the
issue mentioned is one of many that should logically be investigated -- behavior correctness
in the face of different orderings of shutdown between the document and each worker --
when implementing them.

LayoutTests:

* http/tests/workers/resources/worker-util.js: Added.
Copied from fast/workers/resources/worker-util.js
* http/tests/xmlhttprequest/workers/abort-exception-assert.html:
Make the test wait for all workers to exit before finishing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102416.
tony@chromium.org [Fri, 9 Dec 2011 21:41:58 +0000 (21:41 +0000)]
Unreviewed, rolling out r102416.
http://trac.webkit.org/changeset/102416
https://bugs.webkit.org/show_bug.cgi?id=73394

Chromium Win clobber builds are failing.

* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main):
* WebCore.gypi:
* bindings/scripts/generate-bindings.pl:
* page/DOMWindow.idl:
* webaudio/DOMWindowWebAudio.idl: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC wrappers for TextTrack and TextTrackCue should not be collected during event...
eric.carlson@apple.com [Fri, 9 Dec 2011 21:32:02 +0000 (21:32 +0000)]
JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable
https://bugs.webkit.org/show_bug.cgi?id=72179

Reviewed by Geoff Garen.

Source/WebCore:

Tests: media/track/text-track-cue-is-reachable.html
       media/track/text-track-is-reachable.html

* GNUmakefile.list.am: Add JSTextTrackCueCustom.cpp and JSTextTrackCustom.cpp.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto
* bindings/js/JSBindingsAllInOne.cpp: Ditto.

* bindings/js/JSTextTrackCueCustom.cpp: Added.
(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrackCueOwner::visitChildren): New.

* bindings/js/JSTextTrackCustom.cpp: Added.
(WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots): New.
(WebCore::JSTextTrack::visitChildren): New, mark all cues.
* bindings/js/JSTextTrackCustom.h: Added.
(WebCore::root): New.

* bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackList::visitChildren): New, mark all tracks.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWillBeRemoved): TextTracks::remove now takes a TextTrack*.

* html/LoadableTextTrack.h:
(WebCore::LoadableTextTrack::trackElement): New, return the <track>.

* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Initialize m_mediaElement.
* html/TextTrack.h:
(WebCore::TextTrack::setMediaElement): New.
(WebCore::TextTrack::mediaElement): Ditto.

* html/TextTrack.idl: Add CustomIsReachable and CustomMarkFunction.

* html/TextTrackCue.idl: Add CustomIsReachable.

* html/track/TextTrackList.cpp:
(TextTrackList::append): Set track's media element.
(TextTrackList::remove): Clear track's media element. Take a raw ptr, not a PassRefPtr.
* html/track/TextTrackList.h:
* html/track/TextTrackList.idl: Add CustomMarkFunction

LayoutTests:

* media/track/text-track-cue-is-reachable-expected.txt: Added.
* media/track/text-track-cue-is-reachable.html: Added.
* media/track/text-track-is-reachable-expected.txt: Added.
* media/track/text-track-is-reachable.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit should ignore images with @alt matching only whitespace
cfleizach@apple.com [Fri, 9 Dec 2011 21:25:50 +0000 (21:25 +0000)]
WebKit should ignore images with @alt matching only whitespace
https://bugs.webkit.org/show_bug.cgi?id=74189

Reviewed by Darin Adler.

Source/WebCore:

Test: accessibility/img-alt-tag-only-whitespace.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

* accessibility/img-alt-tag-only-whitespace.html: Added.
* platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove NSAnimationContext calls
andersca@apple.com [Fri, 9 Dec 2011 21:25:08 +0000 (21:25 +0000)]
Remove NSAnimationContext calls
https://bugs.webkit.org/show_bug.cgi?id=74207

Reviewed by Sam Weinig.

NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration:
are essentially no-ops. Remove them.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename scrollAnimatorDestroyed to invalidate
andersca@apple.com [Fri, 9 Dec 2011 21:16:46 +0000 (21:16 +0000)]
Rename scrollAnimatorDestroyed to invalidate
https://bugs.webkit.org/show_bug.cgi?id=74206

Reviewed by Sam Weinig.

Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is
destroyed, rename it to something more neutral.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollAnimationHelperDelegate invalidate]):
(-[WebScrollbarPartAnimation invalidate]):
(-[WebScrollbarPainterDelegate invalidate]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the...
andersca@apple.com [Fri, 9 Dec 2011 21:08:10 +0000 (21:08 +0000)]
WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac
https://bugs.webkit.org/show_bug.cgi?id=74204

Reviewed by Sam Weinig.

It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since
painting has nothing to do with animation.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]):
(-[WebScrollbarPainterControllerDelegate invalidate]):
(-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[JSC] Allow cached attributes in bindings that declare a custom mark function
jarred@sencha.com [Fri, 9 Dec 2011 20:52:00 +0000 (20:52 +0000)]
[JSC] Allow cached attributes in bindings that declare a custom mark function
https://bugs.webkit.org/show_bug.cgi?id=74187

Reviewed by Oliver Hunt.

No new tests, current binding tests are sufficient.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch the chromium mac bots to using skia test results
tony@chromium.org [Fri, 9 Dec 2011 20:36:45 +0000 (20:36 +0000)]
Switch the chromium mac bots to using skia test results
https://bugs.webkit.org/show_bug.cgi?id=74201

Reviewed by Ryosuke Niwa.

This is reverting http://trac.webkit.org/changeset/97781 and changing
the name in master.cfg to no longer have cg in the name.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
(RunWebKitTests.start):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate animation ivars
andersca@apple.com [Fri, 9 Dec 2011 20:15:08 +0000 (20:15 +0000)]
Remove duplicate animation ivars
https://bugs.webkit.org/show_bug.cgi?id=74194

Reviewed by Sam Weinig.

Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate
vertical/horizontal animation objects, so get rid of them.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to deflake a repaint test on Chromium. It looks like we're
tony@chromium.org [Fri, 9 Dec 2011 19:48:46 +0000 (19:48 +0000)]
Try to deflake a repaint test on Chromium.  It looks like we're
calling lTC.display() before the inital layout.  Force a layout
before calling lTC.display().

Reviewed by Ojan Vafai.

* fast/replaced/width100percent-textarea.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebScrollbarPartAnimation should only know about the scrollbar it's animating
andersca@apple.com [Fri, 9 Dec 2011 19:34:56 +0000 (19:34 +0000)]
WebScrollbarPartAnimation should only know about the scrollbar it's animating
https://bugs.webkit.org/show_bug.cgi?id=74192

Reviewed by Sam Weinig.

* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here
so we don't have to do it in all the call sites.

(-[WebScrollbarPartAnimation startAnimation]):
Update the scrollbar painter.

(-[WebScrollbarPartAnimation setCurrentProgress:]):
Just invalidate the scrollbar we're animating.

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
Update call sites to use the new designated initializer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix HashMap<..., OwnPtr<...> >::add compilation errors
enne@google.com [Fri, 9 Dec 2011 18:59:21 +0000 (18:59 +0000)]
Fix HashMap<..., OwnPtr<...> >::add compilation errors
https://bugs.webkit.org/show_bug.cgi?id=74159

Reviewed by Darin Adler.

Add a constructor to OwnPtr that takes the empty value (nullptr_t)
from HashTraits so that this function can compile.

* wtf/OwnPtr.h:
(WTF::OwnPtr::OwnPtr):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update test_expectations.txt to match the bots.
tony@chromium.org [Fri, 9 Dec 2011 17:52:23 +0000 (17:52 +0000)]
[chromium] Update test_expectations.txt to match the bots.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update WebGraphicLayer's child content scale in all child binding method.
jocelyn.turcotte@nokia.com [Fri, 9 Dec 2011 17:40:53 +0000 (17:40 +0000)]
[Qt] Update WebGraphicLayer's child content scale in all child binding method.
https://bugs.webkit.org/show_bug.cgi?id=74101

Reviewed by Noam Rosenthal.

setChildren is currently the only method propagating the parent layer's content
scale to its children. This need to be done for addChild* as well.

This fixes the overlay layer not being rendered with the right scale when created
until the contents scale is modified again.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInspector: Don't translate the context when rendering the highlights on a tiled layer.
jocelyn.turcotte@nokia.com [Fri, 9 Dec 2011 17:38:17 +0000 (17:38 +0000)]
Inspector: Don't translate the context when rendering the highlights on a tiled layer.
https://bugs.webkit.org/show_bug.cgi?id=74085

Reviewed by Kenneth Rohde Christiansen.

When the frame view is using fixed layouting, the page overlay is the size of the whole
page and the context shouldn't be translated. The visible rect is still used in that
case to display element titles within the visible rect.

Also:
- Rename overlayRect to visibleRect to reduce confusion in this case.
- Remove the superfluous boundingBox check.

* inspector/DOMNodeHighlighter.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove a wrongly placed ASSERT.
jocelyn.turcotte@nokia.com [Fri, 9 Dec 2011 17:35:12 +0000 (17:35 +0000)]
[Qt] Remove a wrongly placed ASSERT.

Reviewed by Tor Arne Vestbø.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit/chromium: Chromium DEPS roll to pick up new use_skia=1 default on Chrom...
caryclark@google.com [Fri, 9 Dec 2011 16:18:37 +0000 (16:18 +0000)]
Source/WebKit/chromium: Chromium DEPS roll to pick up new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118

Reviewed by Adam Barth.

* DEPS:

Tools: layout_test update to accommodate new use_skia=1 default on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=74118

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(get):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest.test_versions):
(ChromiumMacPortTest.test_graphics_type):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
commit-queue@webkit.org [Fri, 9 Dec 2011 15:19:05 +0000 (15:19 +0000)]
[Qt][WK2] Fix tst_QQuickWebView::scrollRequest() API test
https://bugs.webkit.org/show_bug.cgi?id=73994

Patch by Michael Brüning <michael.bruning@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/html/scroll.html: Corrected html and
added some coloring.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest): Corrected calculation
of expected value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
vestbo@webkit.org [Fri, 9 Dec 2011 14:48:05 +0000 (14:48 +0000)]
[Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake

The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
this failed when moving files in the source tree, as the .d file would contain
stale dependencies on the old source file location. By keeping the object files
(and hence the depdendency files) in a proper tree structure inside the objects
directory we can prevent this failure.

A side benefit is that we can also have objects with the same name inside the
same project.

Reviewed by Simon Hausmann.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update unit test after r102412.
ossy@webkit.org [Fri, 9 Dec 2011 14:01:34 +0000 (14:01 +0000)]
Unreviewed. Update unit test after r102412.

* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed inspector utilities syntax fix.
vsevik@chromium.org [Fri, 9 Dec 2011 11:49:07 +0000 (11:49 +0000)]
Unreviewed inspector utilities syntax fix.

* inspector/front-end/utilities.js:
():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, chromium test expectation update.
bashi@chromium.org [Fri, 9 Dec 2011 10:23:08 +0000 (10:23 +0000)]
Unreviewed, chromium test expectation update.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-09

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Initial implementation of Accelerated Compositing using Clutter
joone.hur@collabora.co.uk [Fri, 9 Dec 2011 09:40:49 +0000 (09:40 +0000)]
[GTK] Initial implementation of Accelerated Compositing using Clutter
https://bugs.webkit.org/show_bug.cgi?id=73319

.:

Reviewed by Gustavo Noronha Silva.

* GNUmakefile.am: Export new compilation macros.
* configure.ac: Add clutter backend for Accelerated Compositing.

Source/WebCore:

Reviewed by Gustavo Noronha Silva.

No new tests added as this feature will be able to reuse the existing
CSS3 transforms layout tests.

* GNUmakefile.am: Include WebCore/platform/graphics/clutter path.
* GNUmakefile.list.am: Add GraphicsLayerClutter.
* platform/clutter/GRefPtrClutter.cpp: Added.
(WTF::adoptGRef):
(WTF::ClutterActor):
* platform/clutter/GRefPtrClutter.h: Added.
* platform/graphics/GraphicsLayer.h: Define PlatformLayer type, which represents ClutterActor.
* platform/graphics/clutter/GraphicsLayerClutter.cpp: Boilerplate implementation.
(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::platformLayer):
* platform/graphics/clutter/GraphicsLayerClutter.h: Boilerplate implementation.

Source/WebKit/gtk:

This patch allows to add a GtkClutterEmbed to embed Clutter Actors in WebKitWebView and
set the root GraphicsLayer to WebKitWebView when Accelerated Compositing needs to be enabled.

Reviewed by Gustavo Noronha Silva.

* GNUmakefile.am:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::attachRootGraphicsLayer): Set the root GraphicsLayer to WebKitWebView.
(WebKit::ChromeClient::allowedCompositingTriggers): Allow to support CSS 3D Transforms only.
* webkit/webkitglobals.cpp:
(webkitInit): Call gtk_clutter_init().
* webkit/webkitwebview.cpp:
(webkit_web_view_size_allocate): Set the size of GtkClutterEmbed when the view is changed.
(webkit_web_view_init)
(webViewSetRootGraphicsLayer): Add the GtkClutterEmbed to the WebKitWebView as a child.
(webViewDetachRootGraphicsLayer): Remove the GtkClutterEmbed from the WebKitWebView.
(webViewSyncLayers): Commit layer changes.
(webViewMarkForSync): Set to call webViewSyncLayers using g_timeout_add.
* webkit/webkitwebviewprivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Introduce a Map class allowing to store values indexed by arbitrary...
vsevik@chromium.org [Fri, 9 Dec 2011 09:25:58 +0000 (09:25 +0000)]
Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects.
https://bugs.webkit.org/show_bug.cgi?id=74084

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/map.html

* inspector/front-end/treeoutline.js:
(TreeOutline):
():
(TreeElement.prototype.collapse):
(TreeElement.prototype.expand):
* inspector/front-end/utilities.js:
():

LayoutTests:

* inspector/map-expected.txt: Added.
* inspector/map.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r102105): run-bindings-tests should output full diff results
haraken@chromium.org [Fri, 9 Dec 2011 09:15:59 +0000 (09:15 +0000)]
REGRESSION(r102105): run-bindings-tests should output full diff results
https://bugs.webkit.org/show_bug.cgi?id=74166

Reviewed by Adam Barth.

Since r102105, the output of run-bindings-tests is truncated to 500 characters.
run-bindings-tests should output full diff results.

* Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix compilation with newly separated Qt 5 QtQuick module
ossy@webkit.org [Fri, 9 Dec 2011 09:11:26 +0000 (09:11 +0000)]
[Qt] Fix compilation with newly separated Qt 5 QtQuick module
https://bugs.webkit.org/show_bug.cgi?id=73990

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-12-09
Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.

Fix QtQuick includes after move from QtDeclarative to QtQuick.

Source/WebKit2:

* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/tests.pri: Tests need symbols from QtQuick, so link library.
* UIProcess/API/qt/tests/testwindow.h:
* UIProcess/qt/QtDialogRunner.cpp:
* UIProcess/qt/QtSGTileNode.cpp:
* UIProcess/qt/QtSGTileNode.h:
* UIProcess/qt/QtSGUpdateQueue.cpp:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
* UIProcess/qt/QtWebPageProxy.cpp:
* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:

Tools:

* MiniBrowser/qt/BrowserWindow.h:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2][gtk] Re-enable running TestWebKitSettings
nayankk@motorola.com [Fri, 9 Dec 2011 09:02:23 +0000 (09:02 +0000)]
[WebKit2][gtk] Re-enable running TestWebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=70135

Reviewed by Martin Robinson.

Re-enable running TestWebKitSettings which was skipped as part
of https://bugs.webkit.org/show_bug.cgi?id=70129 due to the
bug https://bugs.webkit.org/show_bug.cgi?id=70127.

* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Run testWebKitSettings.
(testWebKitSettingsNewWithSettings): Run testWebKitSettingsNewWithSettings.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Add Qt specific expected results.
ossy@webkit.org [Fri, 9 Dec 2011 08:53:24 +0000 (08:53 +0000)]
[Qt] Unreviewed gardening. Add Qt specific expected results.

* platform/qt/animations/cross-fade-background-image-expected.png: Added.
* platform/qt/animations/cross-fade-background-image-expected.txt: Added.
* platform/qt/animations/cross-fade-border-image-source-expected.png: Added.
* platform/qt/animations/cross-fade-border-image-source-expected.txt: Added.
* platform/qt/animations/cross-fade-list-style-image-expected.png: Added.
* platform/qt/animations/cross-fade-list-style-image-expected.txt: Added.
* platform/qt/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
* platform/qt/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/qt/animations/cross-fade-webkit-mask-image-expected.txt: Added.
* platform/qt/transitions/cross-fade-background-image-expected.png: Added.
* platform/qt/transitions/cross-fade-background-image-expected.txt: Added.
* platform/qt/transitions/cross-fade-border-image-expected.png: Added.
* platform/qt/transitions/cross-fade-border-image-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid reloading storage pointer for indexed properties unnecessarily
oliver@apple.com [Fri, 9 Dec 2011 08:45:46 +0000 (08:45 +0000)]
Avoid reloading storage pointer for indexed properties unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=74136

Reviewed by Filip Pizlo.

Add a node to represent loading property storage for indexed properties.
This allows us to reduce code generated for sequential access of arrays,
strings, etc.  This results in up to 5% improvement in code that is
very heavy on indexed reads, such as matrix operations in typed arrays
and 20% faster on microbenchmarks.

Currently this is only supported by GetByVal and other similar indexed reads.

* bytecode/PredictedType.h:
(JSC::isFixedIndexedStorageObjectPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed reviewer name in r102432 changelog entry.
yurys@chromium.org [Fri, 9 Dec 2011 08:43:35 +0000 (08:43 +0000)]
Fixed reviewer name in r102432 changelog entry.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [protocol] generate C++ classes for protocol JSON named types
yurys@chromium.org [Fri, 9 Dec 2011 08:33:02 +0000 (08:33 +0000)]
Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-09
Reviewed by NOBODY.

Extends python generator functionality.
Makes constructor in InspectorObject public.

* inspector/CodeGeneratorInspector.py:
* inspector/InspectorValues.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html
bashi@chromium.org [Fri, 9 Dec 2011 07:26:47 +0000 (07:26 +0000)]
Unreviewed, rebaseline fast/forms/select-listbox-multiple-no-focusring.html

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

* platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Fri, 9 Dec 2011 07:01:50 +0000 (07:01 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deall...
commit-queue@webkit.org [Fri, 9 Dec 2011 06:54:09 +0000 (06:54 +0000)]
[Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated.
https://bugs.webkit.org/show_bug.cgi?id=73591

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-08
Reviewed by Noam Rosenthal.

Source/WebCore:

Implementation of helper function to remove all GL allocated tiles
when QQuickWebView gets removed from canvas.

Tested by new API test in WK2 (tst_QQuickWebView::removeFromCanvas).

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::purgeNodeTexturesRecursive):
* platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Implement deallocation of TextureMapper GL objects when QQuickWebPage paint node deallocated.
Also adds purging GraphicsLayer backing stores on WebProcess side in order to force repainting
when page becomes visible and painting resumes and fixes incorrect initialization of view
visibility state.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::resetPaintNode):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
* UIProcess/API/qt/tests/html/direct-image-compositing.html: Added.
* UIProcess/API/qt/tests/html/resources/simple_image.png: Added.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::showWebView):
(tst_QQuickWebView::removeFromCanvas):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::layerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.h:
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::purgeGLResources):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::purgeGLResources):
* UIProcess/qt/QtWebPageProxy.h:
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::recreateBackingStoreIfNeeded):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::purgeBackingStores):
* WebProcess/WebPage/LayerTreeHost.messages.in:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::purgeBackingStores):
(WebKit::LayerTreeHostQt::recreateBackingStoreIfNeeded):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, chromium test expectation update.
bashi@chromium.org [Fri, 9 Dec 2011 06:53:47 +0000 (06:53 +0000)]
Unreviewed, chromium test expectation update.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and...
leo.yang@torchmobile.com.cn [Fri, 9 Dec 2011 06:43:42 +0000 (06:43 +0000)]
Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=73791

Reviewed by Rob Buis.

Other main contributors:
Joe Mason <jmason@rim.com>
Lianghui Chen <liachen@rim.com>
Charles Wei <charles.wei@torchmobile.com.cn>

Initial upstream, can't be built yet, no new tests.

* platform/network/blackberry/DeferredData.cpp: Added.
* platform/network/blackberry/DeferredData.h: Added.
* platform/network/blackberry/NetworkJob.cpp: Added.
* platform/network/blackberry/NetworkJob.h: Added.
* platform/network/blackberry/NetworkManager.cpp: Added.
* platform/network/blackberry/NetworkManager.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline fast/repaint/textarea-set-disabled.html for
bashi@chromium.org [Fri, 9 Dec 2011 05:36:35 +0000 (05:36 +0000)]
Unreviewed, rebaseline fast/repaint/textarea-set-disabled.html for
Chromium Linux.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

* platform/chromium-linux/fast/repaint/textarea-set-disabled-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIt's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtre...
rniwa@webkit.org [Fri, 9 Dec 2011 05:26:58 +0000 (05:26 +0000)]
It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent
https://bugs.webkit.org/show_bug.cgi?id=74028

Reviewed by Darin Adler.

Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls
to notifyNodeListsAttributeChanged at appropriate places.

Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and
notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to
invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively.

* dom/Attr.cpp:
(WebCore::Attr::childrenChanged):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
* dom/Document.cpp:
(WebCore::Document::updateRangesAfterNodeChanges):
* dom/Document.h:
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::addAttribute):
(WebCore::NamedNodeMap::removeAttribute):
* dom/Node.cpp:
(WebCore::removeNodeListCacheIfPossible):
(WebCore::Node::unregisterDynamicNodeList):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges):
(WebCore::Node::invalidateNodeListsCacheAfterNodeChanges):
(WebCore::Node::dispatchSubtreeModifiedEvent):
* dom/Node.h:
* dom/NodeRareData.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102418.
bashi@chromium.org [Fri, 9 Dec 2011 05:23:18 +0000 (05:23 +0000)]
Unreviewed, rolling out r102418.
http://trac.webkit.org/changeset/102418
https://bugs.webkit.org/show_bug.cgi?id=71870

Caused Chromium build failure.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebKitLoseContext.cpp: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.cpp.
(WebCore::WebKitLoseContext::WebKitLoseContext):
(WebCore::WebKitLoseContext::~WebKitLoseContext):
(WebCore::WebKitLoseContext::getName):
(WebCore::WebKitLoseContext::create):
(WebCore::WebKitLoseContext::loseContext):
(WebCore::WebKitLoseContext::restoreContext):
* html/canvas/WebKitLoseContext.h: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.h.
* html/canvas/WebKitLoseContext.idl: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.idl.

LayoutTests:

* fast/canvas/webgl/WebGLContextEvent.html:
* fast/canvas/webgl/context-destroyed-crash.html:
* fast/canvas/webgl/context-lost-expected.txt:
* fast/canvas/webgl/context-lost-restored.html:
* fast/canvas/webgl/context-lost.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Enable viewport metatag
fsamuel@chromium.org [Fri, 9 Dec 2011 05:15:18 +0000 (05:15 +0000)]
[Chromium] Enable viewport metatag
https://bugs.webkit.org/show_bug.cgi?id=73495

Reviewed by Darin Fisher.

Source/JavaScriptCore:

* wtf/Platform.h: Added ENABLE(VIEWPORT) tag.

Source/WebCore:

Recompute viewpot parameters on frame rect resize.

* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):

Source/WebKit/chromium:

Compute the appropriate fixed layout size, page, and device scale factors,
based on the viewport meta tag parameters.

See http://developer.android.com/guide/webapps/targeting.html for more information.

* features.gypi:
* public/WebView.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::layoutUpdated):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* src/ChromeClientImpl.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::isPageScaleFactorSet):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::observeNewNavigation):
* src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for r102419.
tkent@chromium.org [Fri, 9 Dec 2011 05:00:25 +0000 (05:00 +0000)]
Build fix for r102419.
https://bugs.webkit.org/show_bug.cgi?id=73916

* platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
Remove unused argument names.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rebaselined run-bindings-tests results.
haraken@chromium.org [Fri, 9 Dec 2011 04:51:22 +0000 (04:51 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/JS/JSFloat64Array.cpp:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent
commit-queue@webkit.org [Fri, 9 Dec 2011 04:37:41 +0000 (04:37 +0000)]
Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=73534

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-08
Reviewed by Rob Buis.

Other main contributors:
Mike Fenton <mifenton@rim.com>
Joe Mason <jmason@rim.com>
Max Feil <mfeil@qnx.com>
Lukas Sydorowski <lsydorowski@rim.com>
Crystal Zhang <haizhang@rim.com>

Initial upstream, no new tests.

* platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added.
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added.
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::toWebCorePlatformKeyboardEventType):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::currentCapsLockState):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
(WebCore::PlatformKeyboardEvent::getCurrentModifierState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101619.
commit-queue@webkit.org [Fri, 9 Dec 2011 04:22:14 +0000 (04:22 +0000)]
Unreviewed, rolling out r101619.
http://trac.webkit.org/changeset/101619
https://bugs.webkit.org/show_bug.cgi?id=74158

this patch produces bad behaviour on mac (Requested by
jeremya_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08

Source/WebCore:

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dragSourceEndedAt):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState):

LayoutTests:

* fast/css/hover-active-drag-expected.txt: Removed.
* fast/css/hover-active-drag.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
adamk@chromium.org [Fri, 9 Dec 2011 04:19:48 +0000 (04:19 +0000)]
[MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
https://bugs.webkit.org/show_bug.cgi?id=73492

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/mutation/inline-event-listener.html

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.

Tools:

Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
keypress event without any script on the stack.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::keyDown):
(KeyDownTask::KeyDownTask):
(KeyDownTask::runIfValid):
(EventSender::scheduleAsynchronousKeyDown):
* DumpRenderTree/chromium/EventSender.h:

LayoutTests:

* fast/mutation/inline-event-listener-expected.txt: Added.
* fast/mutation/inline-event-listener.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSuppress rendering of light children when ShadowRoot is dynamically created.
hayato@chromium.org [Fri, 9 Dec 2011 04:16:26 +0000 (04:16 +0000)]
Suppress rendering of light children when ShadowRoot is dynamically created.
https://bugs.webkit.org/show_bug.cgi?id=72441

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html
       fast/dom/shadow/dynamically-created-shadow-root.html

* dom/Element.cpp:
(WebCore::Element::setShadowRoot):

LayoutTests:

* fast/dom/shadow/dynamically-created-shadow-root-expected.html: Added.
* fast/dom/shadow/dynamically-created-shadow-root.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, chromium test rebaseline tests added in r102388. Updates expectations.
bashi@chromium.org [Fri, 9 Dec 2011 04:12:55 +0000 (04:12 +0000)]
Unreviewed, chromium test rebaseline tests added in r102388. Updates expectations.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

* platform/chromium-cg-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-border-image-source-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-linux/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-linux/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-linux/transitions/cross-fade-border-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-mac-leopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-mac-leopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-mac-leopard/transitions/cross-fade-border-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-mac-snowleopard/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-background-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-background-image-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-border-image-source-expected.png: Added.
* platform/chromium-win/animations/cross-fade-border-image-source-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-list-style-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-list-style-image-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.png: Added.
* platform/chromium-win/animations/cross-fade-webkit-mask-image-expected.txt: Added.
* platform/chromium-win/transitions/cross-fade-background-image-expected.png: Added.
* platform/chromium-win/transitions/cross-fade-background-image-expected.txt: Added.
* platform/chromium-win/transitions/cross-fade-border-image-expected.png: Added.
* platform/chromium-win/transitions/cross-fade-border-image-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAccessibility object searching layout tests are incomplete.
commit-queue@webkit.org [Fri, 9 Dec 2011 03:28:25 +0000 (03:28 +0000)]
Accessibility object searching layout tests are incomplete.
https://bugs.webkit.org/show_bug.cgi?id=74130

Patch by Sam White <samuel.white@rochester.edu> on 2011-12-08
Reviewed by Chris Fleizach.

Added a layout test to support visited link searching and removed frame searching
(which was unimplemented) as it's fully covered by the tests in:
platform/mac/accessibility/search-with-frames.html

* platform/mac/accessibility/search-predicate-expected.txt:
* platform/mac/accessibility/search-predicate.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
hayato@chromium.org [Fri, 9 Dec 2011 03:24:30 +0000 (03:24 +0000)]
[gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
https://bugs.webkit.org/show_bug.cgi?id=73980

Reviewed by Tony Chang.

* gdb/webkit.py:
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
(LCharStringPrinter):
(LCharStringPrinter.to_string):
(WTFStringImplPrinter.get_length):
(WTFStringImplPrinter.to_string):
(WTFStringImplPrinter.is_8bit):
(WTFStringPrinter.stringimpl_ptr):
(WTFStringPrinter.get_length):
(WTFStringPrinter.to_string):
(add_pretty_printers.lookup_function):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDrop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
pierre.rossi@gmail.com [Fri, 9 Dec 2011 03:22:18 +0000 (03:22 +0000)]
Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
https://bugs.webkit.org/show_bug.cgi?id=73916

Source/WebCore:

This was needed for Qt since the mobile theme, which can be picked
up at runtime, delegates the rendering of list boxes.

Reviewed by Kent Tamura.

No new tests, there's no functional change.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::usesMenuList):
* html/HTMLSelectElement.h:
* platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem):
(WebCore::PopupMenuClient::multiple):
* platform/qt/RenderThemeQtMobile.h:
(WebCore::RenderThemeQtMobile::delegatesMenuListRendering):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::multiple):
* rendering/RenderMenuList.h:
* rendering/RenderTheme.h:
(WebCore::RenderTheme::delegatesMenuListRendering):

Source/WebKit/chromium:

Reviewed by Kent Tamura.

* src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::didAcceptIndices):
(WebKit::ExternalPopupMenu::getPopupMenuInfo):

Source/WebKit/qt:

Reviewed by Kent Tamura.

* WebCoreSupport/PopupMenuQt.cpp:
(SelectData::multiple):
(WebCore::PopupMenuQt::selectItem):

Tools:

Reviewed by Kent Tamura.

* qmake/mkspecs/features/features.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
kbr@google.com [Fri, 9 Dec 2011 03:07:14 +0000 (03:07 +0000)]
Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
https://bugs.webkit.org/show_bug.cgi?id=71870

Source/WebCore:

Reviewed by James Robinson.

Rename largely done with do-webcore-rename with a couple of
necessary manual fixups. Ran WebGL layout tests.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp.
(WebCore::WebGLLoseContext::WebGLLoseContext):
(WebCore::WebGLLoseContext::~WebGLLoseContext):
(WebCore::WebGLLoseContext::getName):
(WebCore::WebGLLoseContext::create):
(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):
* html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h.
* html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebKitLoseContext.cpp: Removed.
* html/canvas/WebKitLoseContext.h: Removed.
* html/canvas/WebKitLoseContext.idl: Removed.

LayoutTests:

Synchronized context-lost-restored.html and context-lost.html with
Khronos repository; upstream tests must check for multiple vendor
prefixes.

Reviewed by James Robinson.

* fast/canvas/webgl/WebGLContextEvent.html:
* fast/canvas/webgl/context-destroyed-crash.html:
* fast/canvas/webgl/context-lost-expected.txt:
* fast/canvas/webgl/context-lost-restored.html:
* fast/canvas/webgl/context-lost.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html.
bashi@chromium.org [Fri, 9 Dec 2011 02:59:02 +0000 (02:59 +0000)]
Unreviewed chromium rebaseline fast/repaint/textarea-set-disabled.html.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-12-08

* platform/chromium-win/fast/repaint/textarea-set-disabled-expected.png: Added.
* platform/chromium/fast/repaint/textarea-set-disabled-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse the [Supplemental] IDL for webaudio attributes in Chromium
haraken@chromium.org [Fri, 9 Dec 2011 02:49:28 +0000 (02:49 +0000)]
Use the [Supplemental] IDL for webaudio attributes in Chromium
https://bugs.webkit.org/show_bug.cgi?id=73394

Reviewed by Adam Barth.

- Overview: Using the [Supplemental] IDL, this patch moves the attribute
declarations of webaudio from DOMWindow.idl into a new IDL file
webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
feature (aka a module).

- This patch changes the build flow of WebCore.gyp as follows:

    Previous build flow:
        foreach $idl (all IDL files) {
            generate-bindings.pl depends on $idl;
            generate-bindings.pl reads $idl;
            generate-bindings.pl generates .h and .cpp files for $idl;
        }

    New build flow (See the discussions in bug 72138 for more details):
        resolve-supplemental.pl depends on all IDL files;
        resolve-supplemental.pl reads all IDL files;
        resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
        resolve-supplemental.pl outputs supplemental_dependency.tmp;
        foreach $idl (all IDL files) {
            generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
            generate-bindings.pl reads $idl;
            generate-bindings.pl reads supplemental_dependency.tmp;
            generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
        }

- This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
will be removed after build scripts for all platforms support the [Supplemental] IDL.
The motivation for the [Supplemented] IDL is as follows:

In order to support the [Supplemental] IDL, we need to
(1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
(2) and run generate-bindings.pl with the supplemental_dependency.tmp.

This build flow requires a change on the following build scripts,
but changing all the build scripts all at once without any regression is too difficult:

    - DerivedSources.make
    - DerivedSources.pri
    - GNUmakefile.am
    - PlatformBlackBerry.cmake
    - UseJSC.cmake
    - UseV8.cmake
    - WebCore.vcproj/MigrateScripts
    - WebCore.vcproj/WebCore.vcproj
    - bindings/gobject/GNUmakefile.am
    - WebCore.gyp/WebCore.gyp

Thus, we are planning to change the build scripts one by one, which implies that
we need to allow the temporary state in which some build scripts support [Supplemental] IDL
but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
in another IDL file somewhere, like this:

    DOMWindowWebAudio.idl:
        interface [
            Supplemental=DOMWindow
        ] DOMWindowWebAudio {
            attribute attr1;
            attribute attr2;
        };

    DOMWindow.idl:
        interface [
        ] DOMWindow {
            attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL
            attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL.
            attribute attr3;
            attribute attr4;
        };

Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:

    - If a given build script supports the [Supplemental] IDL,
    generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
    - Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL
    as normal attributes and instead ignores all attributes with the [Supplemental] IDL
    (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).

Tests: webaudio/*

* WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
* WebCore.gyp/scripts/action_derivedsourcesallinone.py:
(main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
* WebCore.gypi: Added DOMWindowWebAudio.idl.
* bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
* page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
* webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd test for inline style block in HTML tag
commit-queue@webkit.org [Fri, 9 Dec 2011 02:38:37 +0000 (02:38 +0000)]
Add test for inline style block in HTML tag
https://bugs.webkit.org/show_bug.cgi?id=72360

Patch by Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu> on 2011-12-08
Reviewed by Darin Adler.

* fast/css/parsing-css-block-expected.txt: Added.
* fast/css/parsing-css-block.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102396.
commit-queue@webkit.org [Fri, 9 Dec 2011 02:32:14 +0000 (02:32 +0000)]
Unreviewed, rolling out r102396.
http://trac.webkit.org/changeset/102396
https://bugs.webkit.org/show_bug.cgi?id=74153

over-active-drag test still failing. (Requested by macpherson
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-08

* fast/css/hover-active-drag.html:
* platform/chromium/fast/css/hover-active-drag-expected.txt: Added.
* platform/mac/fast/css/hover-active-drag-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102414 268f45cc-cd09-0410-ab3c-d52691b4dbfc