WebKit.git
9 years agoAdd ASSERTs to avoid querying dirtied z-index or normal flow lists on RenderLayer
jchaffraix@webkit.org [Wed, 2 May 2012 23:56:08 +0000 (23:56 +0000)]
Add ASSERTs to avoid querying dirtied z-index or normal flow lists on RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=84920

Reviewed by Simon Fraser.

Covered by existing tests in Debug (at least several time!).

This change adds some ASSERTs on RenderLayer that prevent any use of its lists if they
are dirtied.

On top of this change, we added an invariant that non-stacking contexts should have their
z-index lists NULL (instead of empty or NULL previously). This is enforced at
updateZOrderLists time as we now ensure that it is called in a timely manner.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds):
Added call to updateLayersIfNeeded as we will query them later and there is no guarantee
that they are not dirty (we recurse in our children as part of calculateLayerBounds).
This was causing the new ASSERTs to trigger on css3/filter/ tests.

(WebCore::RenderLayer::dirtyZOrderLists):
Added a comment as to why we can't ASSERT that we are in a stacking context here.

(WebCore::RenderLayer::rebuildZOrderLists):
Added an ASSERT that we only rebuild z-index lists for dirtied stacking context.

(WebCore::RenderLayer::updateLayerListsIfNeeded):
Updated to ensure that the reflection layer has its layers updated too. This was triggering
the new ASSERTs on fast/runins/run-in-layer-not-removed-crash.html.

(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
Updated to use the new isDirtyStackingContext function.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::isDirtyStackingContext):
New helper function. Also made updateLayerListsIfNeeded() the only way
to update layer. That should prevent any misuse.

(WebCore::RenderLayer::posZOrderList):
(WebCore::RenderLayer::negZOrderList):
(WebCore::RenderLayer::normalFlowList):
ASSERT that we don't query any of the previous lists if they are dirty. Also
enforce the invariant that non-stacking contexts should have NULL z-index lists.

(WebCore::RenderLayer::clearZOrderLists):
New function to clearZOrderLists so that we can enfore the previous invariant.

(WebCore::RenderLayer::updateZOrderLists):
Updated to clear the dirty flag and the z-index lists for non-stacking context.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
Removed the explicit ASSERTs.

(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::canBeComposited):
Disabled compositing on RenderLayer in flow thread. Because flow thread's
RenderLayer are not collected as part of RenderLayer's lists and could be composited,
this was causing the new ASSERTs to trigger (e.g. on fast/regions/webkit-flow-renderer-layer.html).

* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
Updated to use updateLayerListsIfNeeded().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Special-case win32 calls in file_lock and executive.
rakuco@webkit.org [Wed, 2 May 2012 23:48:15 +0000 (23:48 +0000)]
webkitpy: Special-case win32 calls in file_lock and executive.
https://bugs.webkit.org/show_bug.cgi?id=85431

Reviewed by Dirk Pranke.

Simplify accesses to sys.platform by only checking if sys.platform
is "win32" and removing explicit checks for the else case.

* Scripts/webkitpy/common/system/executive.py:
(Executive.check_running_pid):
* Scripts/webkitpy/common/system/file_lock.py:
(FileLock._create_lock):
(FileLock._remove_lock):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline, unreviewed.
zmo@google.com [Wed, 2 May 2012 23:42:58 +0000 (23:42 +0000)]
Rebaseline, unreviewed.

* platform/chromium-linux-x86/http/tests/loading: Added.
* platform/chromium-linux-x86/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
* platform/chromium-linux/http/tests/loading/pdf-commit-load-callbacks-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPDF page does not show up when opened in the background
andersca@apple.com [Wed, 2 May 2012 23:35:57 +0000 (23:35 +0000)]
PDF page does not show up when opened in the background
https://bugs.webkit.org/show_bug.cgi?id=85427
<rdar://problem/11259951>

Reviewed by Sam Weinig.

Ensure that the accelerated hosting view is always the bottom view so it won't obscure subviews that are before it.

* UIProcess/API/mac/WKView.mm:
(-[WKView _enterAcceleratedCompositingMode:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove pink from flakiness dashboard
ojan@chromium.org [Wed, 2 May 2012 23:27:40 +0000 (23:27 +0000)]
Remove pink from flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85422

Reviewed by Dirk Pranke.

The pink indicates that the test doesn't match it's listing in test_expectations.txt.
In practice, this just added noise and confused people.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForSingleTestRow):
(showLegend):
* TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
(#legend-contents *):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(testHtmlForSingleTestRow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused adjustForAbsoluteZoom method in RenderObject.h
leviw@chromium.org [Wed, 2 May 2012 23:26:50 +0000 (23:26 +0000)]
Remove unused adjustForAbsoluteZoom method in RenderObject.h
https://bugs.webkit.org/show_bug.cgi?id=85396

Reviewed by Eric Seidel.

We only want to use the integer adjustForAbsoluteZoom method, so this remnant is both unused
and potentially confusing.

No new tests. Removing unused code.

* rendering/RenderObject.h:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoving line in computeViewportAttributes that enforces a minimum scale factor to...
fsamuel@chromium.org [Wed, 2 May 2012 23:15:41 +0000 (23:15 +0000)]
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Make ViewportAttributes' layoutSize be a FloatRect to avoid rounding
too early, and the occasional off by one fixed layout dimensions.

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
* dom/ViewportArguments.h:
(ViewportAttributes):

Source/WebKit/qt:

* Api/qwebpage.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::layoutSize):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 2 May 2012 23:11:32 +0000 (23:11 +0000)]
Unreviewed gardening.

Rebaselined overflow-delete-line.html and ancestor-overflow.html.

The pixel changes are only text differences.

* fast/repaint/overflow-delete-line-expected.txt: Added.
* platform/chromium-mac-leopard/compositing/overflow/ancestor-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png:
* platform/chromium-mac/compositing/overflow/ancestor-overflow-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/overflow-delete-line-expected.txt: Removed.
* platform/chromium-win/compositing/overflow/ancestor-overflow-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/repaint/overflow-delete-line-expected.txt: Removed.
* platform/gtk/fast/repaint/overflow-delete-line-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed tests for PerfTestRunner.computeStatistics
tomz@codeaurora.org [Wed, 2 May 2012 23:08:48 +0000 (23:08 +0000)]
Need tests for PerfTestRunner.computeStatistics
https://bugs.webkit.org/show_bug.cgi?id=85410

Reviewed by Ryosuke Niwa.

PerformanceTests:

* resources/runner.js:

LayoutTests:

* fast/harness/perftests/perf-runner-compute-statistics-expected.txt: Added.
* fast/harness/perftests/perf-runner-compute-statistics.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix mistake I committed when applying review comments.
kov@webkit.org [Wed, 2 May 2012 23:08:10 +0000 (23:08 +0000)]
Unreviewed. Fix mistake I committed when applying review comments.

* jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
appended to its path, so jhbuild itself was being cloned and
installed in the wrong place when using WEBKITOUTPUTDIR.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: make ServerProcess work on chromium win
dpranke@chromium.org [Wed, 2 May 2012 23:05:52 +0000 (23:05 +0000)]
nrwt: make ServerProcess work on chromium win
https://bugs.webkit.org/show_bug.cgi?id=85333

Reviewed by Ojan Vafai.

This change implements a poor man's select() that will
slow-spin doing non-blocking reads on the stdout and stderr
named pipes connecting the worker to the driver. Seems to work
and I have yet to see much overhead or ill effects but it
probably needs more testing.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._start):
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
(ServerProcess):
(ServerProcess._non_blocking_read_win32):
(ServerProcess._read):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TestServerProcess.test_basic): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Handle generated keys up to 2^53
jsbell@chromium.org [Wed, 2 May 2012 23:03:42 +0000 (23:03 +0000)]
IndexedDB: Handle generated keys up to 2^53
https://bugs.webkit.org/show_bug.cgi?id=85114

Source/WebCore:

The spec defines the behavior for generated keys up to 2^53
(the maximum integer storable as an ECMAScript number) and
the error case when going beyond that. Ensure that we can
handle values up to that point and generate errors beyond.

Reviewed by Tony Chang.

Test: storage/indexeddb/key-generator.html

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

LayoutTests:

Reviewed by Tony Chang.

* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/resources/key-generator.js:
(get defineTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline, unreviewed.
zmo@google.com [Wed, 2 May 2012 23:01:22 +0000 (23:01 +0000)]
Rebaseline, unreviewed.

* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
rakuco@webkit.org [Wed, 2 May 2012 22:55:32 +0000 (22:55 +0000)]
webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
https://bugs.webkit.org/show_bug.cgi?id=85426

Reviewed by Dirk Pranke.

r115880 replaced the direct use of sys.platform with a
PlatformInfo object. Dirk Pranke later told me SystemHost objects
should be preferred, as nothing out of webkitpy.common.system
should create its own PlatformInfo instances.

* Scripts/webkitpy/common/system/systemhost_mock.py:
(MockSystemHost.__init__): Make it possible to specify a custom
filesystem object.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.__init__): Accept a host object instead of a
filesystem one, which is now obtained from host.
(PNGChecker._config_file_path): Retrieve PlatformInfo from
SystemHost.
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
constructor signature.
(PNGCheckerTest.test_check): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline, unreviewed.
zmo@google.com [Wed, 2 May 2012 22:53:26 +0000 (22:53 +0000)]
Rebaseline, unreviewed.

* platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/chromium/media/media-can-play-wav-audio-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
rakuco@webkit.org [Wed, 2 May 2012 22:22:02 +0000 (22:22 +0000)]
webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
https://bugs.webkit.org/show_bug.cgi?id=85424

Reviewed by Tony Chang.

We should reduce direct usage of sys.platform in webkitpy and use
PlatformInfo instead.

* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
checking for 'darwin' directly.
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.__init__): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChildlist mutations in shadow DOM should be observable with MutationObservers
adamk@chromium.org [Wed, 2 May 2012 22:04:15 +0000 (22:04 +0000)]
Childlist mutations in shadow DOM should be observable with MutationObservers
https://bugs.webkit.org/show_bug.cgi?id=85402

Reviewed by Ojan Vafai.

Source/WebCore:

Though Mutation Events are not supported in Shadow DOM,
MutationObservers are supposed to be. Due to a misplacement of the
ChildListMutationScope, they were erroneously getting skipped.

This patch moves code around to properly notify when childlist are
mutated in shadow DOM and covers that change with a new test.

Test: fast/mutation/shadow-dom.html

* dom/ContainerNode.cpp:
(WebCore::willRemoveChild): Handle notification of removal directly.
(WebCore::willRemoveChildren): ditto.
(WebCore::dispatchChildInsertionEvents): Remove notification of insertion.
(WebCore::dispatchChildRemovalEvents): Remove notification of removal.
(WebCore::updateTreeAfterInsertion): Handle notification of insertion directly.

LayoutTests:

Added test covering childList mutations as well as attribute and
characterData mutations (these were already working).

* fast/mutation/shadow-dom-expected.txt: Added.
* fast/mutation/shadow-dom.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in WebCore::TextTrackList::remove
eric.carlson@apple.com [Wed, 2 May 2012 22:01:37 +0000 (22:01 +0000)]
Crash in WebCore::TextTrackList::remove
https://bugs.webkit.org/show_bug.cgi?id=85095

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: media/track/track-remove-quickly.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::willRemoveTrack): Return immediately if the tracks collection
    has not been allocated yet.

LayoutTests:

* media/track/track-remove-quickly-expected.txt: Added.
* media/track/track-remove-quickly.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAfter appending MathML with jquery the table renders with overlaps
commit-queue@webkit.org [Wed, 2 May 2012 22:00:04 +0000 (22:00 +0000)]
After appending MathML with jquery the table renders with overlaps
https://bugs.webkit.org/show_bug.cgi?id=52444

Patch by David Barton <dbarton@mathscribe.com> on 2012-05-02
Reviewed by Julien Chaffraix.

Source/WebCore:

This patch also fixes bugs 72834 and 47781. The main problem is that correct preferred
logical widths are affected by operator stretching. Thus we add a call to
setNeedsLayoutAndPrefWidthsRecalc() after the stretching code in
RenderMathMLOperator.cpp, and change RenderMathMLBlock and RenderMathMLRow to make sure
that stretching of children is done before an <mrow>'s preferred logical widths are
computed.

Test: Added a test to mathml/presentation/mo-stretch.html

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::computePreferredLogicalWidths):
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
(WebCore::RenderMathMLBlock::preferredLogicalHeightAfterSizing):
* rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::unembellishedOperator):
(WebCore::RenderMathMLBlock::isPreferredLogicalHeightDirty):
(WebCore::RenderMathMLBlock::preferredLogicalHeight):
(WebCore::RenderMathMLBlock::setPreferredLogicalHeight):
    - Add m_preferredLogicalHeight and methods to compute and return it.
    - Remove stretchToHeight() from most classes as it no longer needs to be done
      recursively. We just call it on the base of an embellished operator, and that
      calls setNeedsLayoutAndPrefWidthsRecalc() to mark itself and its container
      chain.

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::stretchToHeight):
    - Don't compare an unexpanded height to an expanded one.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
(WebCore::RenderMathMLOperator::updateFromElement):
    - After stretching, call setNeedsLayoutAndPrefWidthsRecalc().
* rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):

* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layout):
* rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
    - Add computePreferredLogicalWidths(), using computeChildrenPreferredLogicalHeights()
      to compute our children's preferred logical heights if necessary, followed by
      operator stretching.

* rendering/mathml/RenderMathMLSubSup.cpp:
* rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
* rendering/mathml/RenderMathMLUnderOver.cpp:
* rendering/mathml/RenderMathMLUnderOver.h:
(RenderMathMLUnderOver):

LayoutTests:

* mathml/presentation/mo-stretch.html:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
rakuco@webkit.org [Wed, 2 May 2012 21:55:19 +0000 (21:55 +0000)]
webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Reviewed by Dirk Pranke.

As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
be created directly, we should should a SystemHost instead.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
object from it instead of creating PlatformInfo directly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLet WebKit parse with clang on windows with -std=c++11
thakis@chromium.org [Wed, 2 May 2012 21:51:50 +0000 (21:51 +0000)]
Let WebKit parse with clang on windows with -std=c++11
https://bugs.webkit.org/show_bug.cgi?id=85398

Reviewed by Ryosuke Niwa.

See http://trac.webkit.org/changeset/85945 for background on the line
I'm changing. With clang, __GXX_EXPERIMENTLAL_CXX0X__ is set in c++11
mode, but MSVC's c++ library doesn't have a tr1/memory header. So also
check for __GLIBCXX__, like it's done in the rest of this file.

* wtf/TypeTraits.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
kov@webkit.org [Wed, 2 May 2012 21:49:31 +0000 (21:49 +0000)]
Unreviewed gardening.

* platform/gtk/test_expectations.txt: remove duplicate annotation
for fast/workers/storage/use-same-database-in-page-and-workers.html,
added comment explaining the ocasional ASSERT that's a
cross-platform problem.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomedia/audio-repaint.html sometimes fails on Lion Debug (Tests)
aestes@apple.com [Wed, 2 May 2012 21:44:08 +0000 (21:44 +0000)]
media/audio-repaint.html sometimes fails on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84357

* platform/mac/Skipped: Skipped the flaky test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate two more Mac baselines.
aestes@apple.com [Wed, 2 May 2012 21:41:23 +0000 (21:41 +0000)]
Update two more Mac baselines.

* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document
jochen@chromium.org [Wed, 2 May 2012 21:40:07 +0000 (21:40 +0000)]
[chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document
https://bugs.webkit.org/show_bug.cgi?id=85201

Reviewed by Adam Barth.

Embedders should use webFrame->document()->referrerPolicy() instead of webFrame->referrerPolicy(). The latter will be removed soon.

* public/WebDocument.h:
(WebDocument):
* src/WebDocument.cpp:
(WebKit::WebDocument::referrerPolicy):
(WebKit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
rakuco@webkit.org [Wed, 2 May 2012 21:32:33 +0000 (21:32 +0000)]
webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Rubber-stamped by Dirk Pranke.

Follow-up patch to r115887 which fixes some capitalization problems
pointed out in comments 2 and 4.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_exception_raised):
(MainTest.test_keyboard_interrupt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
rakuco@webkit.org [Wed, 2 May 2012 21:16:00 +0000 (21:16 +0000)]
webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
https://bugs.webkit.org/show_bug.cgi?id=85419

Reviewed by Dirk Pranke.

Another part of the work towards replacing direct sys.platform
usage with PlatformInfo.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
here. Even though it is costlier, unittest.setUpClass was
introduced in Python 2.7.
(MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
(MainTest.test_child_processes_min): Ditto.
(MainTest.test_exception_raised): Ditto.
(MainTest.test_keyboard_interrupt): Ditto.
(MainTest.test_crash_log): Check for PlatformInfo.is_mac().
(MainTest.test_web_process_crash_log): Ditto, and remove duplicate
check at the end.
(MainTest.test_no_http_tests): Remove check for (cygwin && Python
2.5.2), as we only support Python 2.6+.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Avoid extra Region copies in CCOcclusionTracker
danakj@chromium.org [Wed, 2 May 2012 21:09:44 +0000 (21:09 +0000)]
[chromium] Avoid extra Region copies in CCOcclusionTracker
https://bugs.webkit.org/show_bug.cgi?id=85257

Reviewed by Adrienne Walker.

Instead of making a Region for each layer and then uniting the region
with the current occlusion, directly add the rects for the given layer
to the current occlusion.

When subtracting a region from a rect, just subtract the region
directly instead of computing the intersecting region.

Covered by existing tests.

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::rectSubtractRegion):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate more Mac baselines after r115846.
aestes@apple.com [Wed, 2 May 2012 20:54:50 +0000 (20:54 +0000)]
Update more Mac baselines after r115846.

* platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/mac/fast/block/float/avoiding-float-centered-expected.txt:
* platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/mac/media/audio-controls-rendering-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoblockquote gets clobbered on delete, but the font-tag inside it doesn't
rniwa@webkit.org [Wed, 2 May 2012 20:53:57 +0000 (20:53 +0000)]
blockquote gets clobbered on delete, but the font-tag inside it doesn't
https://bugs.webkit.org/show_bug.cgi?id=19702

Reviewed by Enrica Casucci.

Add a regression test initially authored by Ojan Vafai since this bug appears to have been fixed already.

* editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote-expected.txt: Added.
* editing/execCommand/delete-line-and-insert-text-in-font-inside-blockquote.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Double tap zooming does nothing on small size table
commit-queue@webkit.org [Wed, 2 May 2012 20:53:04 +0000 (20:53 +0000)]
[BlackBerry] Double tap zooming does nothing on small size table
https://bugs.webkit.org/show_bug.cgi?id=85383

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-05-02
Reviewed by George Staikos.

PR: 153232
When we search the best node for block zoom, if the initial node's new
scale exceeds the maximum block zoom scale, we will try to walk through
it's ancestors and pick the acceptable one. But the reality is that the
acceptable ancestor's size can be too close to the size of the actual
contents, we will do nothing for it. As we will still select the
minimum of the new scale and the maximum block zoom scale as block zoom
scale, we can ignore such kind of node and use the initial node instead.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomLimits):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] ASSERT in FontCustomPlatformDataQt.cpp with invalid font in data URI
commit-queue@webkit.org [Wed, 2 May 2012 20:48:04 +0000 (20:48 +0000)]
[Qt] ASSERT in FontCustomPlatformDataQt.cpp with invalid font in data URI
https://bugs.webkit.org/show_bug.cgi?id=85089

Patch by Keith Rosenblatt <keith.rosenblatt@nokia.com> on 2012-05-02
Reviewed by Simon Hausmann.

Source/WebCore:

Do not return data referencing an invalid QRawFont from createFontCustomPlatformData().  Instead
return null.

Test: fast/css/font-face-data-uri-invalid.html

* platform/graphics/qt/FontCustomPlatformDataQt.cpp:
(WebCore::createFontCustomPlatformData):

LayoutTests:

* fast/css/font-face-data-uri-invalid-expected.txt: Added.
* fast/css/font-face-data-uri-invalid.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Set contents texture manager preferred memory limit based on GpuMemoryMana...
commit-queue@webkit.org [Wed, 2 May 2012 20:42:54 +0000 (20:42 +0000)]
[chromium] Set contents texture manager preferred memory limit based on GpuMemoryManager suggestion.
https://bugs.webkit.org/show_bug.cgi?id=84270

Patch by Michal Mocny <mmocny@google.com> on 2012-05-02
Reviewed by Kenneth Russell.

Source/WebCore:

Updates the content texture manager memory limits based on GpuMemoryManager memory allocation suggestions.

The memory allocation size (in bytes) is fed from LayerRendererChromium memory allocation changed callback
handler to CCLayerTreeHost.  At that point we adjust the limits, using the existing notions of preferred and
max limits.

On android, the preferred limit is half the maximum (as it has always been), but on all other platforms the
preferred limit is now equal to max, in order to allow more agressive prepainting.

Finally, android has memory constraints dependant on viewportSize, but that logic has been pushed into
the GpuMemoryManager.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererGpuMemoryAllocationChangedCallbackAdapter::onGpuMemoryAllocationChanged):
(WebCore::LayerRendererChromium::beginDrawingFrame):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromiumClient):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::setMemoryAllocationLimitBytes):
(WebCore):
* platform/graphics/chromium/TextureManager.h:
(TextureManager):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setContentsMemoryAllocationLimitBytes):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImplClient):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
(WebCore):
(WebCore::CCThreadProxy::setContentsMemoryAllocationLimitBytes):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
* tests/LayerRendererChromiumTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Remove direct sys.platform usage in the PNG checker.
rakuco@webkit.org [Wed, 2 May 2012 20:38:04 +0000 (20:38 +0000)]
webkitpy: Remove direct sys.platform usage in the PNG checker.
https://bugs.webkit.org/show_bug.cgi?id=85407

Reviewed by Tony Chang.

Work towards replacing direct sys.platform usage with
PlatformInfo.

* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.__init__): Accept os_name and os_version as
arguments.
* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.__init__): Create a PlatformInfo object instead of
using sys.platform when needed.
(PNGChecker._config_file_path): Check for the current platform via
PlatformInfo.
* Scripts/webkitpy/style/checkers/png_unittest.py:
(PNGCheckerTest.test_check): Update tests after the changes above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Mac baselines after r115846.
aestes@apple.com [Wed, 2 May 2012 20:31:47 +0000 (20:31 +0000)]
Update Mac baselines after r115846.

* platform/mac/fast/clip/008-expected.txt:
* platform/mac/fast/clip/011-expected.txt:
* platform/mac/fast/clip/012-expected.txt:
* platform/mac/fast/forms/input-text-double-click-expected.txt:
* platform/mac/fast/repaint/overflow-delete-line-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:
* platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac/svg/hixie/mixed/003-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix usage of layout types in platform code
eae@chromium.org [Wed, 2 May 2012 20:29:39 +0000 (20:29 +0000)]
Fix usage of layout types in platform code
https://bugs.webkit.org/show_bug.cgi?id=85392

Reviewed by Eric Seidel.

Source/WebCore:

No new tests, no change in functionality.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTap):
Use rounded point for gestures as event handling is still mostly int based.

Source/WebKit/chromium:

* src/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::localPoint):
* src/WebSurroundingText.cpp:
(WebKit::WebSurroundingText::initialize):
Explicitly cast WebPoint to IntPoint to avoid ambiguous conversion error.

Source/WebKit/efl:

* ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_scale_set):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
Use enclosingIntRect to convert visible rect for transform results to
line up with device pixels.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
Use pixelSnapped rect for editor rect calculation as it represents a
device coordinate.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-05-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 2 May 2012 20:27:32 +0000 (20:27 +0000)]
2012-05-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, rebaseline pdf-commit-load-callbacks.html for chromium-linux.

        * platform/chromium-linux/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed, rebaselining after changes in r115846.
ossy@webkit.org [Wed, 2 May 2012 20:17:13 +0000 (20:17 +0000)]
[Qt] Unreviewed, rebaselining after changes in r115846.

REGRESSION(110072): Clipping is not applied on layers that are animated using platform code
https://bugs.webkit.org/show_bug.cgi?id=83954

* platform/qt/animations/combo-transform-translate+scale-expected.txt: Added.
* platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
* platform/qt/compositing/overflow/ancestor-overflow-expected.png:
* platform/qt/compositing/overflow/ancestor-overflow-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
* platform/qt/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/qt/editing/pasteboard/4806874-expected.png:
* platform/qt/editing/pasteboard/4806874-expected.txt:
* platform/qt/editing/pasteboard/input-field-1-expected.png:
* platform/qt/editing/pasteboard/input-field-1-expected.txt:
* platform/qt/editing/selection/3690703-2-expected.png:
* platform/qt/editing/selection/3690703-2-expected.txt:
* platform/qt/editing/selection/3690703-expected.png:
* platform/qt/editing/selection/3690703-expected.txt:
* platform/qt/editing/selection/3690719-expected.png:
* platform/qt/editing/selection/3690719-expected.txt:
* platform/qt/editing/selection/4895428-3-expected.png:
* platform/qt/editing/selection/4895428-3-expected.txt:
* platform/qt/editing/selection/4975120-expected.png:
* platform/qt/editing/selection/4975120-expected.txt:
* platform/qt/editing/selection/drag-select-1-expected.png:
* platform/qt/editing/selection/drag-select-1-expected.txt:
* platform/qt/editing/selection/expanding-selections-expected.png:
* platform/qt/editing/selection/expanding-selections-expected.txt:
* platform/qt/editing/selection/leave-requested-block-expected.png:
* platform/qt/editing/selection/leave-requested-block-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/qt/fast/block/float/032-expected.png:
* platform/qt/fast/block/float/032-expected.txt:
* platform/qt/fast/block/float/033-expected.txt:
* platform/qt/fast/block/float/avoidance-rtl-expected.txt:
* platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.png:
* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
* platform/qt/fast/block/float/in-margin-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/iframe-scroll-repaint-expected.png.
* platform/qt/fast/block/float/in-margin-expected.txt:
* platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png:
* platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
* platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/qt/fast/clip/008-expected.png:
* platform/qt/fast/clip/008-expected.txt:
* platform/qt/fast/clip/011-expected.png:
* platform/qt/fast/clip/011-expected.txt:
* platform/qt/fast/clip/012-expected.png:
* platform/qt/fast/clip/012-expected.txt:
* platform/qt/fast/clip/017-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.png.
* platform/qt/fast/clip/017-expected.txt:
* platform/qt/fast/css/input-search-padding-expected.png:
* platform/qt/fast/css/input-search-padding-expected.txt:
* platform/qt/fast/css/invalidation-errors-2-expected.png:
* platform/qt/fast/css/invalidation-errors-2-expected.txt:
* platform/qt/fast/css/invalidation-errors-expected.png:
* platform/qt/fast/css/invalidation-errors-expected.txt:
* platform/qt/fast/css/line-height-expected.png:
* platform/qt/fast/css/line-height-expected.txt:
* platform/qt/fast/css/nested-layers-with-hover-expected.png:
* platform/qt/fast/css/nested-layers-with-hover-expected.txt:
* platform/qt/fast/css/resize-single-axis-expected.txt: Added.
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.txt:
* platform/qt/fast/dom/isindex-001-expected.png: Added.
* platform/qt/fast/dom/isindex-001-expected.txt:
* platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.png:
* platform/qt/fast/dynamic/subtree-boundary-percent-height-expected.txt:
* platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.png:
* platform/qt/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
* platform/qt/fast/dynamic/subtree-table-cell-height-expected.png:
* platform/qt/fast/dynamic/subtree-table-cell-height-expected.txt:
* platform/qt/fast/events/context-no-deselect-expected.png: Added.
* platform/qt/fast/events/context-no-deselect-expected.txt:
* platform/qt/fast/events/mouse-relative-position-expected.txt: Added.
* platform/qt/fast/forms/basic-inputs-expected.txt:
* platform/qt/fast/forms/date/date-appearance-expected.png: Added.
* platform/qt/fast/forms/date/date-appearance-expected.txt: Added.
* platform/qt/fast/forms/encoding-test-expected.png: Copied from LayoutTests/platform/qt/fast/forms/search-styled-expected.png.
* platform/qt/fast/forms/encoding-test-expected.txt:
* platform/qt/fast/forms/fieldset-align-expected.png: Added.
* platform/qt/fast/forms/fieldset-align-expected.txt:
* platform/qt/fast/forms/floating-textfield-relayout-expected.png: Added.
* platform/qt/fast/forms/floating-textfield-relayout-expected.txt:
* platform/qt/fast/forms/input-align-expected.png: Added.
* platform/qt/fast/forms/input-align-expected.txt:
* platform/qt/fast/forms/input-appearance-bkcolor-expected.png: Added.
* platform/qt/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/qt/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
* platform/qt/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/qt/fast/forms/input-appearance-disabled-expected.png: Added.
* platform/qt/fast/forms/input-appearance-disabled-expected.txt:
* platform/qt/fast/forms/input-appearance-focus-expected.png: Added.
* platform/qt/fast/forms/input-appearance-focus-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.png: Added.
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/qt/fast/forms/input-appearance-readonly-expected.png: Added.
* platform/qt/fast/forms/input-appearance-readonly-expected.txt:
* platform/qt/fast/forms/input-appearance-selection-expected.png: Added.
* platform/qt/fast/forms/input-appearance-visibility-expected.png: Added.
* platform/qt/fast/forms/input-appearance-visibility-expected.txt:
* platform/qt/fast/forms/input-baseline-expected.png: Added.
* platform/qt/fast/forms/input-baseline-expected.txt:
* platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
* platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/qt/fast/forms/input-field-text-truncated-expected.png: Added.
* platform/qt/fast/forms/input-field-text-truncated-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/qt/fast/forms/input-readonly-empty-expected.png: Added.
* platform/qt/fast/forms/input-readonly-empty-expected.txt:
* platform/qt/fast/forms/input-spaces-expected.png: Added.
* platform/qt/fast/forms/input-spaces-expected.txt:
* platform/qt/fast/forms/input-text-click-inside-expected.png: Added.
* platform/qt/fast/forms/input-text-click-inside-expected.txt:
* platform/qt/fast/forms/input-text-double-click-expected.png: Added.
* platform/qt/fast/forms/input-text-double-click-expected.txt:
* platform/qt/fast/forms/input-text-option-delete-expected.png: Added.
* platform/qt/fast/forms/input-text-option-delete-expected.txt:
* platform/qt/fast/forms/input-text-self-emptying-click-expected.png: Added.
* platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/qt/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/qt/fast/forms/input-width-expected.txt:
* platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/qt/fast/forms/placeholder-position-expected.png:
* platform/qt/fast/forms/placeholder-position-expected.txt:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/qt/fast/forms/search-rtl-expected.png:
* platform/qt/fast/forms/search-rtl-expected.txt:
* platform/qt/fast/forms/search-styled-expected.png:
* platform/qt/fast/forms/search-styled-expected.txt:
* platform/qt/fast/forms/search-vertical-alignment-expected.png:
* platform/qt/fast/forms/search-vertical-alignment-expected.txt:
* platform/qt/fast/forms/text-style-color-expected.png: Added.
* platform/qt/fast/forms/text-style-color-expected.txt:
* platform/qt/fast/forms/textfield-focus-ring-expected.png:
* platform/qt/fast/forms/textfield-focus-ring-expected.txt:
* platform/qt/fast/frames/take-focus-from-iframe-expected.png:
* platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
* platform/qt/fast/html/details-no-summary4-expected.png:
* platform/qt/fast/html/details-no-summary4-expected.txt:
* platform/qt/fast/html/details-open-javascript-expected.png:
* platform/qt/fast/html/details-open-javascript-expected.txt:
* platform/qt/fast/html/details-open2-expected.png:
* platform/qt/fast/html/details-open2-expected.txt:
* platform/qt/fast/html/details-open4-expected.png:
* platform/qt/fast/html/details-open4-expected.txt:
* platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt:
* platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.png:
* platform/qt/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/qt/fast/layers/self-painting-outline-expected.txt:
* platform/qt/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/qt/fast/lists/dynamic-marker-crash-expected.txt:
* platform/qt/fast/multicol/layers-split-across-columns-expected.png:
* platform/qt/fast/multicol/layers-split-across-columns-expected.txt:
* platform/qt/fast/overflow/004-expected.png: Added.
* platform/qt/fast/overflow/004-expected.txt:
* platform/qt/fast/overflow/line-clamp-expected.png:
* platform/qt/fast/overflow/line-clamp-expected.txt:
* platform/qt/fast/overflow/overflow-focus-ring-expected.png: Added.
* platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
* platform/qt/fast/repaint/iframe-scroll-repaint-expected.png:
* platform/qt/fast/repaint/iframe-scroll-repaint-expected.txt:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png:
* platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/qt/fast/repaint/overflow-clip-subtree-layout-expected.txt:
* platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/qt/fast/repaint/repaint-resized-overflow-expected.png:
* platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/qt/fast/repaint/search-field-cancel-expected.png:
* platform/qt/fast/repaint/search-field-cancel-expected.txt:
* platform/qt/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
* platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/qt/fast/repaint/subtree-root-clip-2-expected.txt:
* platform/qt/fast/repaint/subtree-root-clip-3-expected.txt:
* platform/qt/fast/repaint/subtree-root-clip-expected.txt:
* platform/qt/fast/repaint/subtree-root-skipped-expected.png:
* platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
* platform/qt/fast/repaint/table-hover-on-link-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/qt/fast/repaint/table-hover-on-link-expected.txt: Added.
* platform/qt/fast/replaced/replaced-breaking-expected.txt:
* platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.png:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/fast/replaced/width100percent-textfield-expected.png:
* platform/qt/fast/replaced/width100percent-textfield-expected.txt:
* platform/qt/fast/speech/input-appearance-searchandspeech-expected.png: Added.
* platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* platform/qt/fast/speech/input-appearance-speechbutton-expected.png: Added.
* platform/qt/fast/speech/input-appearance-speechbutton-expected.txt: Added.
* platform/qt/fast/speech/speech-bidi-rendering-expected.png: Added.
* platform/qt/fast/speech/speech-bidi-rendering-expected.txt: Added.
* platform/qt/fast/table/029-expected.png:
* platform/qt/fast/table/029-expected.txt:
* platform/qt/fast/table/colspanMinWidth-expected.png:
* platform/qt/fast/table/colspanMinWidth-expected.txt:
* platform/qt/fast/table/colspanMinWidth-vertical-expected.png:
* platform/qt/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/qt/fast/table/overflowHidden-expected.png:
* platform/qt/fast/table/overflowHidden-expected.txt:
* platform/qt/fast/table/spanOverlapRepaint-expected.png:
* platform/qt/fast/table/spanOverlapRepaint-expected.txt:
* platform/qt/fast/table/text-field-baseline-expected.png:
* platform/qt/fast/table/text-field-baseline-expected.txt:
* platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
* platform/qt/fast/transforms/transformed-focused-text-input-expected.png:
* platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/qt/plugins/mouse-click-plugin-clears-selection-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/iframe-scroll-repaint-expected.png.
* platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/qt/svg/hixie/mixed/003-expected.png:
* platform/qt/svg/hixie/mixed/003-expected.txt:
* platform/qt/tables/mozilla/bugs/45621-expected.png:
* platform/qt/tables/mozilla/bugs/45621-expected.txt:
* platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
* platform/qt/tables/mozilla/bugs/bug154780-expected.png:
* platform/qt/tables/mozilla/bugs/bug154780-expected.txt:
* platform/qt/tables/mozilla/bugs/bug18359-expected.txt:
* platform/qt/tables/mozilla/bugs/bug24200-expected.png:
* platform/qt/tables/mozilla/bugs/bug24200-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/qt/tables/mozilla/bugs/bug28928-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4382-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4527-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/qt/tables/mozilla/bugs/bug51037-expected.txt:
* platform/qt/tables/mozilla/bugs/bug55545-expected.png:
* platform/qt/tables/mozilla/bugs/bug55545-expected.txt:
* platform/qt/tables/mozilla/bugs/bug7342-expected.txt:
* platform/qt/tables/mozilla/dom/tableDom-expected.txt:
* platform/qt/tables/mozilla/other/move_row-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
* platform/qt/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[watchlist] Update watchlist rules for EFL-related patches.
rakuco@webkit.org [Wed, 2 May 2012 20:12:39 +0000 (20:12 +0000)]
[watchlist] Update watchlist rules for EFL-related patches.
http://bugs.webkit.org/show_bug.cgi?id=85160

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/config/watchlist: Monitor
Source/WTF/wtf/efl and LayoutTests/platform/efl as well.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac media engine doesn't reccognize canPlayType('audio/wav; codecs=1')
eric.carlson@apple.com [Wed, 2 May 2012 20:06:19 +0000 (20:06 +0000)]
Mac media engine doesn't reccognize canPlayType('audio/wav; codecs=1')
https://bugs.webkit.org/show_bug.cgi?id=85409

Not reviewed, new platform results added after r115798.

* platform/mac/media/media-can-play-wav-audio-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed gardening after r115821.
ossy@webkit.org [Wed, 2 May 2012 20:05:34 +0000 (20:05 +0000)]
[Qt][WK2] Unreviewed gardening after r115821.

* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi...
fpizlo@apple.com [Wed, 2 May 2012 20:01:31 +0000 (20:01 +0000)]
Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85408

* platform/mac/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't allocate stencil buffer if stencil flag is false in context creation attributes
kbr@google.com [Wed, 2 May 2012 19:57:45 +0000 (19:57 +0000)]
Don't allocate stencil buffer if stencil flag is false in context creation attributes
https://bugs.webkit.org/show_bug.cgi?id=85317

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make it appear to WebGL application that there is no stencil
buffer even if the underlying GraphicsContext3D allocated one.
Verified intended behavior with test case from Mozilla's bug report.

Updated context-attributes-alpha-depth-stencil-antialias.html test
from Khronos repository. Ran WebGL layout tests on Linux in
Chrome's DRT and on Mac OS in Safari's.

* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::hasStencilBuffer): Added query method.
(WebCore): Changed desired semantics of isValidRenderbuffer.
* html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer): Added hasStencilBuffer.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
    Clear new flag.
(WebCore::WebGLRenderingContext::bindFramebuffer):
    Reset stencil test upon framebuffer change.
(WebCore::WebGLRenderingContext::disable):
    Cache flag; reset stencil test.
(WebCore::WebGLRenderingContext::enable):
    Cache flag; reset stencil test.
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
    Reset stencil test upon renderbuffer change.
(WebCore::WebGLRenderingContext::getContextAttributes):
    Force depth and stencil to false if false was requested.
(WebCore::WebGLRenderingContext::isEnabled):
    Return cached flag.
(WebCore::WebGLRenderingContext::renderbufferStorage):
    Reset stencil test upon renderbuffer reallocation.
(WebCore::WebGLRenderingContext::applyStencilTest):
    Enable or disable stencil test based on request and availability.
(WebCore::WebGLRenderingContext::enableOrDisable):
    Helper function.
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
    Added cache of STENCIL_TEST flag. Deleted unused m_stencilBits.

LayoutTests:

* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDrag and drop text into table is pasting the text in the next <td> element
rniwa@webkit.org [Wed, 2 May 2012 19:50:30 +0000 (19:50 +0000)]
Drag and drop text into table is pasting the text in the next <td> element
https://bugs.webkit.org/show_bug.cgi?id=75004

Reviewed by Darin Adler.

The bug was caused by ReplaceSelectionCommand adjusting the insertion position to be before
of the block element containing the insertion position even when the block element is a table cell.

Fixed the bug by not moving the insertion position before the table cell in this case.

Test: editing/pasteboard/paste-into-table-cell.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=85309
bdakin@apple.com [Wed, 2 May 2012 19:47:20 +0000 (19:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=85309
supportsExpandedScrollbars() should check for the method we actually call rather
than a related method

Reviewed by Anders Carlsson.

Missing colon.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::supportsExpandedScrollbars):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix GCC X86 build error
commit-queue@webkit.org [Wed, 2 May 2012 19:47:11 +0000 (19:47 +0000)]
Fix GCC X86 build error
https://bugs.webkit.org/show_bug.cgi?id=85379

Patch by Yong Li <yoli@rim.com> on 2012-05-02
Reviewed by Rob Buis.

Always explicitly claim ".text" to make sure
functions defined with inline assembly will be
created in the correct section.

* dfg/DFGOperations.cpp:
(JSC):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaselining after changes in r115846.
zandobersek@gmail.com [Wed, 2 May 2012 19:46:34 +0000 (19:46 +0000)]
Unreviewed, rebaselining after changes in r115846.

* fast/repaint/table-hover-on-link-expected.txt:
* platform/gtk/editing/inserting/before-after-input-element-expected.txt:
* platform/gtk/editing/pasteboard/4806874-expected.txt:
* platform/gtk/editing/pasteboard/input-field-1-expected.txt:
* platform/gtk/editing/selection/3690703-2-expected.txt:
* platform/gtk/editing/selection/3690703-expected.txt:
* platform/gtk/editing/selection/3690719-expected.txt:
* platform/gtk/editing/selection/4895428-3-expected.txt:
* platform/gtk/editing/selection/4975120-expected.txt:
* platform/gtk/editing/selection/drag-select-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/gtk/editing/spelling/inline_spelling_markers-expected.txt:
* platform/gtk/fast/block/float/032-expected.txt:
* platform/gtk/fast/block/float/033-expected.txt:
* platform/gtk/fast/block/float/avoidance-rtl-expected.txt:
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
* platform/gtk/fast/block/float/in-margin-expected.txt:
* platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/gtk/fast/block/margin-collapse/103-expected.txt:
* platform/gtk/fast/clip/008-expected.txt:
* platform/gtk/fast/clip/011-expected.txt:
* platform/gtk/fast/clip/012-expected.txt:
* platform/gtk/fast/clip/017-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/invalidation-errors-2-expected.txt:
* platform/gtk/fast/css/invalidation-errors-expected.txt:
* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/dom/isindex-001-expected.txt:
* platform/gtk/fast/dom/isindex-002-expected.txt:
* platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
* platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
* platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
* platform/gtk/fast/events/autoscroll-expected.txt:
* platform/gtk/fast/events/context-no-deselect-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/encoding-test-expected.txt:
* platform/gtk/fast/forms/fieldset-align-expected.txt:
* platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/gtk/fast/forms/input-readonly-empty-expected.txt:
* platform/gtk/fast/forms/input-table-expected.txt:
* platform/gtk/fast/forms/input-text-click-inside-expected.txt:
* platform/gtk/fast/forms/input-text-click-outside-expected.txt:
* platform/gtk/fast/forms/input-text-double-click-expected.txt:
* platform/gtk/fast/forms/input-text-drag-down-expected.txt:
* platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/gtk/fast/forms/input-width-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/fast/forms/textfield-overflow-expected.txt:
* platform/gtk/fast/forms/validation-message-appearance-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-javascript-expected.txt:
* platform/gtk/fast/html/details-open2-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/self-painting-outline-expected.txt:
* platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
* platform/gtk/fast/overflow/004-expected.txt:
* platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
* platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
* platform/gtk/fast/repaint/layer-outline-expected.txt:
* platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt:
* platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt:
* platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/gtk/fast/table/003-expected.txt:
* platform/gtk/fast/table/029-expected.txt:
* platform/gtk/fast/table/colspanMinWidth-expected.txt:
* platform/gtk/fast/table/overflowHidden-expected.txt:
* platform/gtk/fast/table/text-field-baseline-expected.txt:
* platform/gtk/fast/text/selection-painted-separately-expected.txt:
* platform/gtk/fast/text/selection-rect-rounding-expected.txt:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
* platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/gtk/tables/mozilla/bugs/45621-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi...
fpizlo@apple.com [Wed, 2 May 2012 19:41:18 +0000 (19:41 +0000)]
Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85404

* platform/mac/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-05-02 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 2 May 2012 19:37:09 +0000 (19:37 +0000)]
2012-05-02  Nate Chapin  <japhet@chromium.org>

        Unreviewed, expectations updates after r115774.

        * platform/chromium-win/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.
        * platform/gtk/test_expectations.txt:
        * platform/qt/Skipped:
        * platform/qt/http/tests/loading/pdf-commit-load-callbacks-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi...
fpizlo@apple.com [Wed, 2 May 2012 19:28:28 +0000 (19:28 +0000)]
Unreviewed, changing test expectations due to https://bugs.webkit.org/show_bug.cgi?id=85401

* platform/mac/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert r115191 - "Make the web view's url property follow the active url"
vestbo@webkit.org [Wed, 2 May 2012 19:19:24 +0000 (19:19 +0000)]
Revert r115191 - "Make the web view's url property follow the active url"

It uncovered/caused issues in the icon-implementation that can't be
easily fixed, so rolling out instead.

https://bugs.webkit.org/show_bug.cgi?id=77554

Rubber-stamped by Simon Hausmann.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r115388.
oliver@apple.com [Wed, 2 May 2012 19:18:28 +0000 (19:18 +0000)]
Unreviewed, rolling out r115388.
http://trac.webkit.org/changeset/115388
https://bugs.webkit.org/show_bug.cgi?id=85011

This caused many weird performance problems, and needs to be
landed in pieces.

Source/JavaScriptCore:

* dfg/DFGOperations.cpp:
* heap/Heap.cpp:
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::dumpCaller):
(JSC):
* interpreter/CallFrame.h:
(JSC::ExecState::init):
(ExecState):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC::Interpreter::execute):
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::growSlowCase):
(JSC::RegisterFile::gatherConservativeRoots):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::end):
(JSC::RegisterFile::size):
(JSC::RegisterFile::addressOfEnd):
(RegisterFile):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink):
(JSC::RegisterFile::grow):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):
* llint/LowLevelInterpreter.asm:
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):

LayoutTests:

* fast/js/global-recursion-on-full-stack-expected.txt:
* fast/js/stack-trace-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove title and media queries from StyleSheetInternal to CSSStyleSheet
antti@apple.com [Wed, 2 May 2012 19:05:31 +0000 (19:05 +0000)]
Move title and media queries from StyleSheetInternal to CSSStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=85387

Reviewed by Anders Carlsson.

Stylesheet title and media queries are determined by the owner, not by the stylesheet itself.
The fields belong to CSSStyleSheet.

This will make it easier to share StyleSheetInternal instances between documents.

* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::isCacheable):
(WebCore):
(WebCore::CSSStyleSheet::setDisabled):

    Invalidate the document style directly instead of ping-ponging through StyleSheetInternal.

(WebCore::CSSStyleSheet::setMediaQueries):
(WebCore::CSSStyleSheet::media):
* css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::hasCharsetRule):
(WebCore::CSSStyleSheet::mediaQueries):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::setTitle):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::collectMatchingRulesForList):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createCSSStyleSheet):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::parseAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen viewing a PDF, the Safari Status Bar shows other text
andersca@apple.com [Wed, 2 May 2012 19:01:32 +0000 (19:01 +0000)]
When viewing a PDF, the Safari Status Bar shows other text
https://bugs.webkit.org/show_bug.cgi?id=85395
<rdar://problem/11297250>

Reviewed by Beth Dakin.

Set the layer contents placement for the WKView so that its layer will get masksToBounds set.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, removing recent test expectations for changes in r115846
zandobersek@gmail.com [Wed, 2 May 2012 18:53:49 +0000 (18:53 +0000)]
Unreviewed, removing recent test expectations for changes in r115846
to get proper new baselines from the buildbots.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Qt build fix with GCC 4.7.0.
alexis.menard@openbossa.org [Wed, 2 May 2012 18:52:49 +0000 (18:52 +0000)]
Unreviewed Qt build fix with GCC 4.7.0.

* platform/qt/DeviceMotionProviderQt.h:
(DeviceMotionProviderQt):
* platform/qt/DeviceOrientationProviderQt.cpp:
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore):
* platform/qt/DeviceOrientationProviderQt.h:
(DeviceOrientationProviderQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium gardening.
jchaffraix@webkit.org [Wed, 2 May 2012 18:50:23 +0000 (18:50 +0000)]
Unreviewed Chromium gardening.

* platform/chromium-mac-leopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-mac/fast/forms/input-value-expected.txt:
* platform/chromium-mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
Rebaselined the previous tests.

* platform/chromium/test_expectations.txt:
Tweaked the expectation files to cover the failures on Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap] Enable css filters in TextureMapperGL
noam.rosenthal@nokia.com [Wed, 2 May 2012 18:26:58 +0000 (18:26 +0000)]
[Texmap] Enable css filters in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=75778

Unreviewed build fix to greenify the Qt Minimal bot.

* platform/graphics/texmap/TextureMapperShaderManager.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectation updates after r115846.
jchaffraix@webkit.org [Wed, 2 May 2012 18:22:33 +0000 (18:22 +0000)]
Unreviewed expectation updates after r115846.

* platform/gtk/test_expectations.txt:
* platform/qt/test_expectations.txt:
Added more files after triaging the diffs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReftest mismatches are providing undefined diff percent in results.html
zandobersek@gmail.com [Wed, 2 May 2012 18:01:27 +0000 (18:01 +0000)]
Reftest mismatches are providing undefined diff percent in results.html
https://bugs.webkit.org/show_bug.cgi?id=85283

Reviewed by Ojan Vafai.

When writing test results for a reftest mismatch, also take into account the
difference percent that is produced when generating image diff. This value is
then used when creating test results in the form of dictionaries, stored under
the 'image_diff_percent' key. It ultimately ends up in JSON results data,
providing additional information about the reftest difference.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(interpret_test_failures): Store the diff percent for reftest failure under the
'image_diff_percent' key.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result): Also set the new diff_percent attribute of the reftest
mismatch failure to the value of the difference percent ImageDiff outputs.
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(FailureReftestMismatch.__init__): Add the new diff_percent attribute with the
default value of None.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Compilation warnings in RenderTheme
philn@webkit.org [Wed, 2 May 2012 17:57:34 +0000 (17:57 +0000)]
[GTK] Compilation warnings in RenderTheme
https://bugs.webkit.org/show_bug.cgi?id=85286

Reviewed by Martin Robinson.

Removed un-needed code and refactored fileListNameForWidth
accordingly to avoid un-used variable warnings during compilation.

* platform/gtk/RenderThemeGtk.cpp:
(WebCore):
(WebCore::RenderThemeGtk::fileListNameForWidth):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNULL ptr in WebCore::AppendNodeCommand::AppendNodeCommand
rniwa@webkit.org [Wed, 2 May 2012 17:45:14 +0000 (17:45 +0000)]
NULL ptr in WebCore::AppendNodeCommand::AppendNodeCommand
https://bugs.webkit.org/show_bug.cgi?id=75843

Reviewed by Tony Chang.

Source/WebCore:

The crash was caused by indentIntoBlockquote's passing a bad outerBlock to moveParagraphsWithClone.

When the position is created after blockquote in the following DOM:
BODY
* BLOCKQUOTE style=margin: 0 0 0 40px; border: none; padding: 0px;
    E
        #text "\nx\n"
VisiblePosition's constructor (of startOfContents) turns the position into a legacy position (blockquote, 0).
The crash occurs because this position doesn't belong in the same paragraph as E, which is the paragraph
we're trying to move into the blockquote.

Fixed bug by calling positionInParentAfterNode instead of positionAfterNode for now. We should eventually be
able to use positionAfterNode here once VisiblePosition's constructor starts handling before/after positions
properly.

Test: editing/execCommand/indent-with-after-content-crash.html

* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentIntoBlockquote):

LayoutTests:

Add a regression test.

* editing/execCommand/indent-with-after-content-crash-expected.txt: Added.
* editing/execCommand/indent-with-after-content-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebWindowFadeAnimation ignores "duration" parameter. https://bugs.webkit.org/show_bug...
jer.noble@apple.com [Wed, 2 May 2012 17:42:07 +0000 (17:42 +0000)]
WebWindowFadeAnimation ignores "duration" parameter. https://bugs.webkit.org/show_bug.cgi?id=85386

Reviewed by Brady Eidson.

Ignoring the "duration" parameter causes the full screen fade and scale animations
to get out of sync.

* platform/mac/WebWindowAnimation.mm:
(-[WebWindowFadeAnimation initWithDuration:window:initialAlpha:finalAlpha:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(110072): Clipping is not applied on layers that are animated using platfor...
jchaffraix@webkit.org [Wed, 2 May 2012 17:17:14 +0000 (17:17 +0000)]
REGRESSION(110072): Clipping is not applied on layers that are animated using platform code
https://bugs.webkit.org/show_bug.cgi?id=83954

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html
       fast/layers/no-clipping-overflow-hidden-added-after-transform.html
       fast/layers/no-clipping-overflow-hidden-added-after-transition-expected.html
       fast/layers/no-clipping-overflow-hidden-added-after-transition.html
       fast/layers/no-clipping-overflow-hidden-hardware-acceleration-expected.html
       fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html
       (and all the tests that will need to be rebaselined)

r110072 changed the way we create layers to lazily allocate overflow: hidden ones
based on layout overflow. However with hardware acceleration, certain operations
do cause overflow without actually calling layout (the test cases added as part
of this change are using transition / animation). This means that those cases
wouldn't properly clip.

Due to the above issue and the other regressions from r110072, the easiest fix is
to just to roll it out.

* rendering/RenderBox.h:
Changed to allocate a layer whenever we have an overflow clip.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrolledContentOffset):
(WebCore::RenderBox::cachedSizeForOverflowClip):
Reverted those 2 to avoid using the cached size logic.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::layout):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.h:
(RenderTableRow):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layout):
Removed the previous scaffolding code and reverted some functions to
being private (as they were prior to r110072).

LayoutTests:

* fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html: Added.
* fast/layers/no-clipping-overflow-hidden-added-after-transform.html: Added.
* fast/layers/no-clipping-overflow-hidden-added-after-transition-expected.html: Added.
* fast/layers/no-clipping-overflow-hidden-added-after-transition.html: Added.
* fast/layers/no-clipping-overflow-hidden-hardware-acceleration-expected.html: Added.
* fast/layers/no-clipping-overflow-hidden-hardware-acceleration.html: Added.

* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/qt/test_expectations.txt:
Disabled some tests for those platforms.

* platform/efl/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/Skipped:
* platform/win/Skipped:
Re-enabled those tests on the premises that r11072 / bug 75568 got rolled out.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAddition of a contributor to committers.py
commit-queue@webkit.org [Wed, 2 May 2012 17:13:35 +0000 (17:13 +0000)]
Addition of a contributor to committers.py
https://bugs.webkit.org/show_bug.cgi?id=85324

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-02
Reviewed by Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Build fix for Qt port on mac.
mahesh.kulkarni@nokia.com [Wed, 2 May 2012 17:03:49 +0000 (17:03 +0000)]
Unreviewed. Build fix for Qt port on mac.

* UIProcess/API/qt/qwebnavigationhistory_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] EFL's LayoutTestController overridePreference implementation
commit-queue@webkit.org [Wed, 2 May 2012 16:52:02 +0000 (16:52 +0000)]
[EFL] EFL's LayoutTestController overridePreference implementation
https://bugs.webkit.org/show_bug.cgi?id=83007

Tools:

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(toBool): aux function converting JSStringRef to bool
(toInt): aux function converting JSStringRef to int
(LayoutTestController::overridePreference): added implementation

LayoutTests:

Unskip tescases depending on LayoutTestController overridePreference method.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

* platform/efl/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake ShareableSurface's ref-counting thread-safe
vestbo@webkit.org [Wed, 2 May 2012 16:15:24 +0000 (16:15 +0000)]
Make ShareableSurface's ref-counting thread-safe

Fixes assert when threaded rendering is enabled for the Qt scene-graph.

https://bugs.webkit.org/show_bug.cgi?id=85381

Reviewed by Noam Rosenthal.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Refining expectations for passing tests.
caseq@chromium.org [Wed, 2 May 2012 15:49:20 +0000 (15:49 +0000)]
Unreviewed. Refining expectations for passing tests.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, EFL rebaseline after r115415 and r115294.
rakuco@webkit.org [Wed, 2 May 2012 15:32:06 +0000 (15:32 +0000)]
Unreviewed, EFL rebaseline after r115415 and r115294.

* platform/efl/fast/images/support-broken-image-delegate-expected.txt:
* platform/efl/http/tests/loading/simple-subframe-expected.txt:
* platform/efl/security/block-test-expected.txt:
* platform/efl/security/block-test-no-port-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap] Enable css filters in TextureMapperGL
noam.rosenthal@nokia.com [Wed, 2 May 2012 15:30:29 +0000 (15:30 +0000)]
[Texmap] Enable css filters in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=75778

Source/WebCore:

Reviewed by Jocelyn Turcotte.

Added support for color filters in TextureMapperGL. Blur and shadow would be done in a
different patch.

Modified BitmapTexture::applyFilters to return a texture, since GL cannot paint a texture
into itself.
Created a shader map for standard filters, since all of them work more or less the same way
with a single uniform. Added the colorization shaders based on the W3C filter spec, as
already implemented in FEFilterRenderer.cpp and FEColorMatrix.cpp.
We use two swapping textures to render the filters.

Covered by tests in css3/filters.

* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::applyFilters):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
(WebCore):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
(WebCore::BitmapTextureGL::bind):
* platform/graphics/texmap/TextureMapperGL.h:
(TextureMapperGL):
(BitmapTextureGL):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::applyFilters):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
* platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderManager::~TextureMapperShaderManager):
(WebCore):
(WebCore::StandardFilterProgram::~StandardFilterProgram):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::StandardFilterProgram::create):
(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):
* platform/graphics/texmap/TextureMapperShaderManager.h:
(WebCore):
(StandardFilterProgram):
(WebCore::StandardFilterProgram::vertexAttrib):
(WebCore::StandardFilterProgram::texCoordAttrib):
(WebCore::StandardFilterProgram::textureUniform):
(TextureMapperShaderManager):

Source/WebKit2:

Add the plumbing in the ui-side compositing code in Qt to support filters.
Serialize the filter operations for a layer when it's changed.

Reviewed by Jocelyn Turcotte.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
(WebCore):
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit):
(WebKit::LayerTreeHostProxy::setCompositingLayerFilters):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.messages.in:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit):
(WebKit::WebLayerTreeRenderer::setLayerFilters):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore):
(WebCore::WebGraphicsLayer::didChangeFilters):
(WebCore::WebGraphicsLayer::setFilters):
(WebCore::WebGraphicsLayer::syncFilters):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebGraphicsLayer):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit):
(WebKit::LayerTreeHostQt::syncLayerFilters):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r115825.
philn@webkit.org [Wed, 2 May 2012 15:29:55 +0000 (15:29 +0000)]
Unreviewed, GTK rebaseline after r115825.

* platform/gtk/fast/lists/drag-into-marker-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, EFL rebaseline after r113885.
rakuco@webkit.org [Wed, 2 May 2012 15:20:04 +0000 (15:20 +0000)]
Unreviewed, EFL rebaseline after r113885.

* platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r115829.
philn@webkit.org [Wed, 2 May 2012 15:17:50 +0000 (15:17 +0000)]
Unreviewed, GTK rebaseline after r115829.

* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Hyperlink auditing ewk_view setting
commit-queue@webkit.org [Wed, 2 May 2012 15:17:13 +0000 (15:17 +0000)]
[EFL] Hyperlink auditing ewk_view setting
https://bugs.webkit.org/show_bug.cgi?id=84451

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-02
Reviewed by Antonio Gomes.

Exporting new ewk_view setting:  hyperlinkAuditingEnabled - enbles/disables hyperlink auditing.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_setting_enable_hyperlink_auditing_get):
(ewk_view_setting_enable_hyperlink_auditing_set):
* ewk/ewk_view.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Fix sys.platform check in find_files_unittest.
rakuco@webkit.org [Wed, 2 May 2012 15:13:35 +0000 (15:13 +0000)]
webkitpy: Fix sys.platform check in find_files_unittest.
https://bugs.webkit.org/show_bug.cgi?id=85339

Reviewed by Ryosuke Niwa.

Follow-up to r101618 -- 'win' is not a valid sys.platform value,
'win32' should be used instead. The check always returned false
due to this, so assert_normalize() was never called.

* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.test_win): Add the missing import for the
FileSystem class and fix the sys.platform check.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Pass page-height to PrintContext::begin to fix print layouting
commit-queue@webkit.org [Wed, 2 May 2012 15:08:03 +0000 (15:08 +0000)]
[Qt] Pass page-height to PrintContext::begin to fix print layouting
https://bugs.webkit.org/show_bug.cgi?id=84864

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-05-02
Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::print):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix vkb showing incorrect flags/keys when content changes
hausmann@webkit.org [Wed, 2 May 2012 14:55:40 +0000 (14:55 +0000)]
[Qt] Fix vkb showing incorrect flags/keys when content changes

Reviewed by Tor Arne Vestbø.

When the editor state changes we have to inform the input method about changed
properties so that it can issue a new input method query. Otherwise it may use old values
from other QQuickItems or other incorrectly initialized data.

Also use isActiveFocus() instead of hasFocus() to detect whether we're actively focused.
This is also what QQuick uses internally to determine whether it can make calls to the input method
or not.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::updateTextInputState):
(WebKit::QtWebPageEventHandler::doneWithGestureEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add initial QML documentation
kenneth@webkit.org [Wed, 2 May 2012 14:37:41 +0000 (14:37 +0000)]
[Qt] Add initial QML documentation
https://bugs.webkit.org/show_bug.cgi?id=85370

Reviewed by Simon Hausmann.

Source/WebKit/qt:

* docs/qtwebkit.qdocconf: Add WebKit2 dirs.

Source/WebKit2:

Add initial documentation which also serves as an example on how it
should be done.

* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qwebloadrequest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
philn@webkit.org [Wed, 2 May 2012 14:19:34 +0000 (14:19 +0000)]
[GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
https://bugs.webkit.org/show_bug.cgi?id=84378

Reviewed by Eric Carlson.

Source/WebCore:

Fix positioning of the controls panel back to relative, as it is
in the parent CSS. Also remove some duplicate CSS attributes.

* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-controls-clone-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-playing-and-pause-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:
* platform/gtk/test_expectations.txt: Unflag fixed test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Buildfix after r115812 for !ENABLE(DEVICE_ORIENTATION) builds.
ossy@webkit.org [Wed, 2 May 2012 14:18:55 +0000 (14:18 +0000)]
[Qt] Buildfix after r115812 for !ENABLE(DEVICE_ORIENTATION) builds.
https://bugs.webkit.org/show_bug.cgi?id=64595

Reviewed by Kenneth Rohde Christiansen.

* Api/qwebpage.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: TypeError: Cannot call method 'createLiveLocation' of undefined
yurys@chromium.org [Wed, 2 May 2012 14:10:01 +0000 (14:10 +0000)]
Web Inspector: TypeError: Cannot call method 'createLiveLocation' of undefined
https://bugs.webkit.org/show_bug.cgi?id=85371

Standard extension scripts injected to the Chromium background page should have
correct script data which means that context debug id should be already set on
the context where they are compiled before the compilation. This patch moves
assignment of context debug id earlier where it is known that no scripts have
been evaluated in the context.

Reviewed by Pavel Feldman.

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld):
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didCreateScriptContext):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
* src/WebDevToolsAgentPrivate.h:
(WebDevToolsAgentPrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed prospective QtMobility build fix.
hausmann@webkit.org [Wed, 2 May 2012 14:09:49 +0000 (14:09 +0000)]
[Qt] Unreviewed prospective QtMobility build fix.

* Source/api.pri: The Qt 4 equivalent of QT += sensors should be handled by
WebCore.pri, but somehow it isn't.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] drag&drop related failures
zandobersek@gmail.com [Wed, 2 May 2012 14:08:30 +0000 (14:08 +0000)]
[GTK] drag&drop related failures
https://bugs.webkit.org/show_bug.cgi?id=84675

Reviewed by Philippe Normand.

Tools:

Rather than checking options to see whether we're running pixel tests
the pixel_tests argument passed to GtkDriver._start should be used as
it also covers cases when pixel tests should be run because of testing
reftests. This again creates different Xvfb processes with proper
display IDs for a worker that's performing both ordinary and pixel
tests, as was the case before changes made in r114788.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):

LayoutTests:

Remove test cases from expectations that are now passing.

* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Removed entries for 4 media tests that pass now.
caseq@chromium.org [Wed, 2 May 2012 14:01:50 +0000 (14:01 +0000)]
Unreviewed. Removed entries for 4 media tests that pass now.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=85309
bdakin@apple.com [Wed, 2 May 2012 13:41:29 +0000 (13:41 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=85309
supportsExpandedScrollbars() should check for the method we actually call rather
than a related method
-and corresponding-
<rdar://problem/11065691>

Reviewed by Anders Carlsson.

* platform/mac/ScrollbarThemeMac.mm:
(WebCore::supportsExpandedScrollbars):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Wed, 2 May 2012 13:37:24 +0000 (13:37 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt:
http/tests/loading/pdf-commit-load-callbacks.html is failing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Enable device orientation/motion with Qt 5
hausmann@webkit.org [Wed, 2 May 2012 13:19:51 +0000 (13:19 +0000)]
[Qt] Enable device orientation/motion with Qt 5

Reviewed by Tor Arne Vestbø.

Enable device orientation/motion features with Qt 5 if Qt Sensors is available.

* qmake/mkspecs/features/features.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][DRT] Gardening failure cases on EFL port
commit-queue@webkit.org [Wed, 2 May 2012 13:17:17 +0000 (13:17 +0000)]
[EFL][DRT] Gardening failure cases on EFL port
https://bugs.webkit.org/show_bug.cgi?id=85365

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-02

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [Qt] Remove redundant updateViewportArguments() call from HTMLBodyEle...
commit-queue@webkit.org [Wed, 2 May 2012 13:00:47 +0000 (13:00 +0000)]
Source/WebCore: [Qt] Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions()
https://bugs.webkit.org/show_bug.cgi?id=84241

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

No need to update viewport arguments when the body element is inserted into the Document.
Viewport arguments are updated first when the Document is set on the Frame, and later
on any subsequent occurence of the viewport meta tag in the document.
It is sufficient to dispatch viewport update once per main frame, if no viewport meta tag is present.

Also add a flag to be able to track viewport argument update dispatch.

No tests. Currrent viewport tests cover this behaviour.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::documentWillSuspendForPageCache):
* dom/Document.h:
(Document):
(WebCore::Document::didDispatchViewportPropertiesChanged):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::didNotifyDescendantInseretions):

Source/WebKit2: [Qt][WK2] Remove redundant updateViewportArguments() call from HTMLBodyElement::didNotifyDescendantInseretions()
https://bugs.webkit.org/show_bug.cgi?id=84241

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

Add ASSERT to ensure at least one viewport argument change call is dispatched to WebPage per main frame.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] Skip new failing tests and one crashing test to paint the bot green.
ossy@webkit.org [Wed, 2 May 2012 12:13:57 +0000 (12:13 +0000)]
[Qt][Mac] Skip new failing tests and one crashing test to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Cannot read property 'length' of undefined TextEditorModel.js:467
pfeldman@chromium.org [Wed, 2 May 2012 12:07:34 +0000 (12:07 +0000)]
Web Inspector: Cannot read property 'length' of undefined TextEditorModel.js:467
https://bugs.webkit.org/show_bug.cgi?id=85360

Reviewed by Yury Semikhatsky.

Added the undo/redo stack length checks.

* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, skipping failing test
ossy@webkit.org [Wed, 2 May 2012 12:04:46 +0000 (12:04 +0000)]
[Qt] Unreviewed gardening, skipping failing test

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-02

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebInspector: Scripts panel editor dirty state is cleared when the tab with editor...
pfeldman@chromium.org [Wed, 2 May 2012 12:03:48 +0000 (12:03 +0000)]
WebInspector: Scripts panel editor dirty state is cleared when the tab with editor is closed.
https://bugs.webkit.org/show_bug.cgi?id=85361

Reviewed by Yury Semikhatsky.

Added content validation upon script show.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: breakpoints are de-activated only upon the second click.
pfeldman@chromium.org [Wed, 2 May 2012 12:01:31 +0000 (12:01 +0000)]
Web Inspector: breakpoints are de-activated only upon the second click.
https://bugs.webkit.org/show_bug.cgi?id=85359

Reviewed by Yury Semikhatsky.

Initial value for activated state is set.

* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: live edit fails to report error
pfeldman@chromium.org [Wed, 2 May 2012 11:56:34 +0000 (11:56 +0000)]
Web Inspector: live edit fails to report error
https://bugs.webkit.org/show_bug.cgi?id=85357

Reviewed by Yury Semikhatsky.

ProtocolError is now a string, not an error object.

* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._queryError):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.didEditContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make DeviceMotion and DeviceOrientation work with WebKit2
commit-queue@webkit.org [Wed, 2 May 2012 11:51:32 +0000 (11:51 +0000)]
[Qt] Make DeviceMotion and DeviceOrientation work with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64595

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-05-02
Reviewed by Kenneth Rohde Christiansen.

.:

Moving DeviceMotion and DeviceOrientation clients and providers
to WebCore.  This is done to allow clean dependencies when
statically linking WK2.

* Source/api.pri:

Source/WebCore:

No new tests added.  This change adds support for WK2
what was in WK1.

Also moving DeviceMotion and DeviceOrientation clients and
providers to WebCore.  This is done to allow clean dependencies
when statically linking WK2.

* Target.pri:
* WebCore.pri:
* platform/qt/DeviceMotionClientQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionClientQt.cpp.
(WebCore):
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::deviceMotionControllerDestroyed):
(WebCore::DeviceMotionClientQt::setController):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):
* platform/qt/DeviceMotionClientQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionClientQt.h.
(WebCore):
(DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
* platform/qt/DeviceMotionProviderQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionProviderQt.cpp.
(WebCore):
(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::~DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::setController):
(WebCore::DeviceMotionProviderQt::start):
(WebCore::DeviceMotionProviderQt::stop):
(WebCore::DeviceMotionProviderQt::filter):
* platform/qt/DeviceMotionProviderQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceMotionProviderQt.h.
(WebCore):
(DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::currentDeviceMotion):
* platform/qt/DeviceOrientationClientQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp.
(WebCore):
(WebCore::DeviceOrientationClientQt::deviceOrientationControllerDestroyed):
(WebCore::DeviceOrientationClientQt::setController):
(WebCore::DeviceOrientationClientQt::startUpdating):
(WebCore::DeviceOrientationClientQt::stopUpdating):
(WebCore::DeviceOrientationClientQt::lastOrientation):
* platform/qt/DeviceOrientationClientQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.h.
(WebCore):
(DeviceOrientationClientQt):
* platform/qt/DeviceOrientationProviderQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp.
(WebCore):
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::setController):
(WebCore::DeviceOrientationProviderQt::start):
(WebCore::DeviceOrientationProviderQt::stop):
(WebCore::DeviceOrientationProviderQt::filter):
* platform/qt/DeviceOrientationProviderQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.h.
(WebCore):
(DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::isActive):
(WebCore::DeviceOrientationProviderQt::lastOrientation):
(WebCore::DeviceOrientationProviderQt::hasAlpha):

Source/WebKit2:

Adding support for DeviceOrientation in WK2 WebPage

* Target.pri:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: exception in console when there are watch expressions
yurys@chromium.org [Wed, 2 May 2012 10:43:10 +0000 (10:43 +0000)]
Web Inspector: exception in console when there are watch expressions
https://bugs.webkit.org/show_bug.cgi?id=85351

Check if script execution is still paused before trying to resolve an
object for script popover because execution may be resumed after popover
showing is scheduled but before we start resolving the object under
the cursor in which case there is no selected call frame any more and
we should hide the popover.

Reviewed by Pavel Feldman.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API: Changing webkitGetUserMedia to take an object instead of a string
tommyw@google.com [Wed, 2 May 2012 10:31:53 +0000 (10:31 +0000)]
MediaStream API: Changing webkitGetUserMedia to take an object instead of a string
https://bugs.webkit.org/show_bug.cgi?id=84850

Reviewed by Dimitri Glazkov.

Source/WebCore:

The standard changed a while back to use an object as a dictionary but since JSC
didn't support the Dictionary class until just recently we have not updated the API until now.

Change covered by existing, and edited, tests.

* Modules/mediastream/NavigatorMediaStream.cpp:
(WebCore::NavigatorMediaStream::webkitGetUserMedia):
* Modules/mediastream/NavigatorMediaStream.h:
(WebCore):
(NavigatorMediaStream):
* Modules/mediastream/NavigatorMediaStream.idl:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
* Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):
* platform/mediastream/MediaStreamSourcesQueryClient.h:
(MediaStreamSourcesQueryClient):

Source/WebKit/chromium:

* public/WebUserMediaRequest.h:
(WebUserMediaRequest):
* src/WebUserMediaRequest.cpp:

LayoutTests:

Also took the opportunity to update the peerconnection-Attributes test
to test PeerConnection00 instead.

* fast/mediastream/argument-types-expected.txt:
* fast/mediastream/peerconnection-Attributes-expected.txt:
* fast/mediastream/script-tests/argument-types.js:
(emptyFunction):
* fast/mediastream/script-tests/peerconnection-Attributes.js:
* platform/chromium/media/video-capture-preview.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix typo introduced in r115800.
commit-queue@webkit.org [Wed, 2 May 2012 10:14:59 +0000 (10:14 +0000)]
[EFL] Fix typo introduced in r115800.
https://bugs.webkit.org/show_bug.cgi?id=85354

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-05-02
Reviewed by Nikolas Zimmermann.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data): Assign 1 bit to the boolean attribute, webAudio.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115809 268f45cc-cd09-0410-ab3c-d52691b4dbfc