WebKit.git
12 years agowxPython bindings build fixes after recent changes.
kevino@webkit.org [Thu, 17 Sep 2009 02:57:43 +0000 (02:57 +0000)]
wxPython bindings build fixes after recent changes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert "2009-09-16 Albert J. Wong <ajwong@chromium.org>"
brettw@chromium.org [Thu, 17 Sep 2009 02:33:24 +0000 (02:33 +0000)]
Revert "2009-09-16  Albert J. Wong  <ajwong@chromium.org>"
This change did not compile.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-15 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 17 Sep 2009 02:13:49 +0000 (02:13 +0000)]
2009-09-15  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        <input maxlength=> should restrict only values specified by users.
        https://bugs.webkit.org/show_bug.cgi?id=21271

        * fast/forms/input-appearance-maxlength-expected.txt:
        * fast/forms/input-appearance-maxlength.html:
        * fast/forms/input-maxlength-expected.txt:
        * fast/forms/input-maxlength.html:
        * fast/forms/input-text-maxlength-expected.txt: Added.
        * fast/forms/input-text-maxlength.html:
        * fast/forms/input-text-paste-maxlength-expected.txt: Added.
        * fast/forms/input-text-paste-maxlength.html:
        * platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Removed.
        * platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Removed.
        * platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Removed.
        * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Removed.
        * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Removed.
        * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
        * platform/mac/fast/forms/input-text-maxlength-expected.txt: Removed.
        * platform/mac/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
        * platform/qt/fast/forms/input-text-maxlength-expected.txt: Removed.
        * platform/qt/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
        * platform/win/fast/forms/input-text-maxlength-expected.txt: Removed.
        * platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Removed.
2009-09-15  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        <input maxlength=> should restrict only values specified by users.
        https://bugs.webkit.org/show_bug.cgi?id=21271

        * dom/InputElement.cpp:
        (WebCore::InputElement::setValueFromRenderer):
        (WebCore::InputElement::sanitizeValue):
        (WebCore::InputElement::sanitizeUserInputValue): Rename from constrainValue().
        (WebCore::InputElement::handleBeforeTextInsertedEvent):
        (WebCore::InputElement::updateValueIfNeeded):
        * dom/InputElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        (WebCore::HTMLInputElement::value):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::sanitizeValue):
        * html/HTMLInputElement.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::constrainValue):
        * wml/WMLInputElement.h:
        (WebCore::WMLInputElement::sanitizeValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Enrica Casucci <enrica@apple.com>
eric@webkit.org [Thu, 17 Sep 2009 01:58:55 +0000 (01:58 +0000)]
2009-09-16  Enrica Casucci  <enrica@apple.com>

        Reviewed by Eric Seidel.

        Reorganizing helper functions in htmlediting.h to group them by type of object they return/operate upon.
        https://bugs.webkit.org/show_bug.cgi?id=29319

        * editing/IndentOutdentCommand.cpp:
        Removed implementation of isAtUnsplittableElement.

        * editing/IndentOutdentCommand.h:
        Removed member function isAtUnsplittableElement, because it was not class specific and belonged logically among the helper functions.

        * editing/htmlediting.cpp:
        (WebCore::isAtUnsplittableElement): added. The code was taken from IndentOutdentCommand.

        * editing/htmlediting.h:
        Reordered functions to group them by type of object returned or operate upon.
        Added comments.
        Added isAtUnsplittableElement declaration.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Removed some vestigial and potentially crashy code that makes consolidating
ggaren@apple.com [Wed, 16 Sep 2009 23:27:42 +0000 (23:27 +0000)]
WebCore: Removed some vestigial and potentially crashy code that makes consolidating
event listeners hard.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig and Anders Carlsson.

* dom/Node.cpp:
(WebCore::Node::addEventListener): No need to limit when event listeners
can be added. Other EventTargets don't do this.

Also, check for null when accessing document(). Technically, the JS bindings
do this check for us, but let's not rely on that.

LayoutTests: Added a test for a potential crash when adding an event listener to a
doctype node.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-16
Reviewed by Sam Weinig.

* fast/dom/doctype-event-listener-crash-expected.txt: Added.
* fast/dom/doctype-event-listener-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7155710>
andersca@apple.com [Wed, 16 Sep 2009 23:25:58 +0000 (23:25 +0000)]
<rdar://problem/7155710>
HTML selects on windows cause containing window to become inactive when opened

Reviewed by Adam Roben.

Redo the way we handle events when a popup menu is shown, based on
http://blogs.msdn.com/oldnewthing/archive/2004/08/20/217684.aspx

Since a non-active window can't capture the mouse, we use the owning window
(the WebView) as the capture window. We then run a recursive message pump that
forwards all mouse and keyboard events to the popup menu.

* platform/PopupMenu.h:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::PopupMenu):
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::hide):
(WebCore::PopupMenu::wndProc):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Gabor Loki <loki@inf.u-szeged.hu>
eric@webkit.org [Wed, 16 Sep 2009 23:23:00 +0000 (23:23 +0000)]
2009-09-16  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Fix GCC warnings on ARM_THUMB2 platform

        * assembler/ARMv7Assembler.h:
        (JSC::ARMThumbImmediate::countLeadingZerosPartial):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
eric@webkit.org [Wed, 16 Sep 2009 23:14:03 +0000 (23:14 +0000)]
2009-09-16  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Eric Seidel.

        Detect and add Windows7 properly to the user agent.

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative fix for
mitz@apple.com [Wed, 16 Sep 2009 23:06:27 +0000 (23:06 +0000)]
Speculative fix for
<rdar://problem/6937089> Crashes at RenderWidget::destroy()

Reviewed by Ada Chan.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::destroy): Avoid calling renderArena() if node()
is null. Add two assertions that can help determine how this crash
happens (in particular, whether node() becomes null during destroy() or
it is null before destroy() is called).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative build fix.
bdakin@apple.com [Wed, 16 Sep 2009 22:17:33 +0000 (22:17 +0000)]
Speculative build fix.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for <rdar://problem/7083741> Implement a CSS extension to
bdakin@apple.com [Wed, 16 Sep 2009 22:08:20 +0000 (22:08 +0000)]
WebCore: Fix for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29291

Reviewed by Darin Adler.

Added tests:
* fast/css/font-smoothing.html: Added.
* fast/css/parsing-webkit-font-smoothing.html: Added.

This patch adds a new CSS property called -webkit-font-smoothing
that accepts the following as valid input: auto | none |
antialiased | subpixel-antialiased

Return appropriate computed style for -webkit-font-smoothing
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Add a case for CSSPropertyWebkitFontSmoothing, and accept valid
input.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

Add mappings for FontSmoothing to the right CSS values.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontSmoothing):

Add -webkit-font-smoothing
* css/CSSPropertyNames.in:

Set fontSmoothing on the FontDescription.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

Add antialiased and subpixel-antialiased as possible new CSS
values.
* css/CSSValueKeywords.in:
Store the font smoothing CSS value in the FontDescription.
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::fontSmoothing):
(WebCore::FontDescription::setFontSmoothing):
(WebCore::FontDescription::operator==):

Call setShouldAntialias() and setShouldUseSmoothing() appropriately
based on the CSS fontSmoothing() value.
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):

New function fontSmoothing()
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::fontSmoothing):

New enum FontSmoothing.
* rendering/style/RenderStyleConstants.h:
(WebCore::):

LayoutTests: Tests for <rdar://problem/7083741> Implement a CSS extension to
adjust sub-pixel anti-aliasing for text

Reviewed by Darin Adler.

New tests:
* fast/css/font-smoothing.html: Added.
* fast/css/parsing-webkit-font-smoothing-expected.txt: Added.
* fast/css/parsing-webkit-font-smoothing.html: Added.
* fast/css/resources/parsing-webkit-font-smoothing.js: Added.
(test):
* platform/mac/fast/css/font-smoothing-expected.checksum: Added.
* platform/mac/fast/css/font-smoothing-expected.png: Added.
* platform/mac/fast/css/font-smoothing-expected.txt: Added.

These tests have updated results now that -webkit-font-smoothing is
reported with computed style.
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a UI delegate callback to let the delegate draw a WebView's background
aroben@apple.com [Wed, 16 Sep 2009 21:52:28 +0000 (21:52 +0000)]
Add a UI delegate callback to let the delegate draw a WebView's background

Fixes <http://webkit.org/b/29315>.

Reviewed by Dave Hyatt.

* Interfaces/IWebUIDelegatePrivate.idl: Added
IWebUIDelegatePrivate2::drawBackground.

* WebView.cpp:
(WebView::paintIntoBackingStore): After clearing or filling with
white, let the delegate draw whatever background it wants. Also added
an assertion that the dirty rect is within our bounds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrevent WebView from painting over sibling windows
aroben@apple.com [Wed, 16 Sep 2009 21:47:43 +0000 (21:47 +0000)]
Prevent WebView from painting over sibling windows

Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
paint over sibling windows

Reviewed by Darin Adler.

* WebView.cpp:
(WebView::initWithFrame): Create the WebView's HWND with the
WS_CLIPSIBLINGS style.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Albert J. Wong <ajwong@chromium.org>
ajwong@chromium.org [Wed, 16 Sep 2009 21:46:24 +0000 (21:46 +0000)]
2009-09-16  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by David Levin.

        Reimplement default media UI for Mac Chromium to match the style
        of the Windows and Linux versions.  Also breaks the dependency
        on the internal wk* functions that were previously used to
        render the media controller widgets.
        https://bugs.webkit.org/show_bug.cgi?id=29161

        No media layout tests are currently enabled in Mac Chromium, so
        nothing needs rebaselineing, etc.

        * css/mediaControlsChromium.css:
        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::mediaElementParent):
        (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):
        (WebCore::mediaSliderThumbImage):
        (WebCore::mediaVolumeSliderThumbImage):
        (WebCore::RenderThemeChromiumMac::paintSliderTrack):
        (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize):
        (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal):
        (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
        (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
        (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Wed, 16 Sep 2009 21:38:57 +0000 (21:38 +0000)]
2009-09-16  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        Remove style property if empty string is entered.

        https://bugs.webkit.org/show_bug.cgi?id=29163

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._onmouseout): fixed null pointer exception
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.applyStyleText): if styletext to apply is empty it will return an array to confirm the property removal
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.):
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Wed, 16 Sep 2009 21:31:41 +0000 (21:31 +0000)]
2009-09-16  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        Added a test that checks that margin property shorthand has correct value
        when there is background-repeat property in the style declaration.

        https://bugs.webkit.org/show_bug.cgi?id=28973

        * fast/backgrounds/repeat/margin-shorthand-expected.txt: Added.
        * fast/backgrounds/repeat/margin-shorthand.html: Added.
        * fast/backgrounds/repeat/resources/TEMPLATE.html: Added.
        * fast/backgrounds/repeat/resources/margin-shorthand.css: Added.
        * fast/backgrounds/repeat/resources/margin-shorthand.js: Added.
        (iconMarginValue):
2009-09-16  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        Always reset m_implicitShorthand to false after parsing
        background-repeat style property otherwise properties
        following after it may be erroneously marked as implicit.

        https://bugs.webkit.org/show_bug.cgi?id=28972
        https://bugs.webkit.org/show_bug.cgi?id=28973

        Test: fast/backgrounds/repeat/margin-shorthand.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 16 Sep 2009 21:05:23 +0000 (21:05 +0000)]
2009-09-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Oliver Hunt.

        Work around a bug in AppKit on Leopard which causes compositing layers to jitter, and
        become misplaced when the WebHTMLView is resized or scrolled sometimes.
        <rdar://problem/7071636>

        We call an internal AppKit method to make sure the layer geometry is updated correctly.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateLayerHostingViewPosition]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix to support monolithic builds on Windows.
kevino@webkit.org [Wed, 16 Sep 2009 20:40:36 +0000 (20:40 +0000)]
wx build fix to support monolithic builds on Windows.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Wed, 16 Sep 2009 20:36:45 +0000 (20:36 +0000)]
2009-09-16  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Alexey Proskuryakov.

        Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and XMLHttpRequest::getResponseHeader in the
        HEADERS_RECEIVED readyState.
        https://bugs.webkit.org/show_bug.cgi?id=29121

        * http/tests/xmlhttprequest/getAllResponseHeaders-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt.
        * http/tests/xmlhttprequest/getAllResponseHeaders.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html.
        * http/tests/xmlhttprequest/getResponseHeader-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt.
        * http/tests/xmlhttprequest/getResponseHeader.html: Copied from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html.
        * http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Removed.
        * http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Removed.
        * http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Removed.
        * http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Removed.
        Modified xmlhttprequest-InvalidStateException-getAllRequestHeaders and xmlhttprequest-InvalidStateException-getRequestHeader to match the current spec and code behavior.
        Extended the first test to cover other aspects of the getAllResponseHeaders method and planning the same extension for the second test.
        The extension for the second test is to be submitted with the patch for bug 29140.
        Renamed the 2 tests to a shorter more accurate name, given their new intended scope.
2009-09-16  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Alexey Proskuryakov.

        Incorrect behavior of XMLHttpRequest::getAllResponseHeaders and
        XMLHttpRequest::getResponseHeader in the
        HEADERS_RECEIVED readyState.
        https://bugs.webkit.org/show_bug.cgi?id=29121

        Tests: http/tests/xmlhttprequest/getAllResponseHeaders.html
               http/tests/xmlhttprequest/getResponseHeader.html

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::getAllResponseHeaders):
        (WebCore::XMLHttpRequest::getResponseHeader):
        Changed the minimum valid state from LOADING to HEADERS_RECEIVED.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Wed, 16 Sep 2009 20:23:31 +0000 (20:23 +0000)]
2009-09-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix style violation in V8AbstractEventListener.
        https://bugs.webkit.org/show_bug.cgi?id=29303

        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8AbstractEventListener::operator==):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Patrick Mueller <Patrick_Mueller@us.ibm.com>
eric@webkit.org [Wed, 16 Sep 2009 20:16:04 +0000 (20:16 +0000)]
2009-09-16  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Add Watch Expression support to inspector
        https://bugs.webkit.org/show_bug.cgi?id=27514

        Manual test added.

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
        (WebInspector.ConsoleView.prototype._enterKeyPressed):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection.prototype.update.callback):
        (WebInspector.ObjectPropertiesSection.prototype.update):
        (WebInspector.ObjectPropertiesSection.prototype.updateProperties):
        (WebInspector.ObjectPropertiesSection.CompareProperties):
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
        (WebInspector.ObjectPropertyTreeElement.prototype.update):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        * inspector/front-end/WatchExpressionsSidebarPane.js: Added.
        (WebInspector.WatchExpressionsSidebarPane):
        (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions):
        (WebInspector.WatchExpressionsSection):
        (WebInspector.WatchExpressionsSection.prototype.update):
        (WebInspector.WatchExpressionsSection.prototype.addExpression):
        (WebInspector.WatchExpressionsSection.prototype.updateExpression):
        (WebInspector.WatchExpressionsSection.prototype.findAddedTreeElement):
        (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions):
        (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
        (WebInspector.WatchExpressionsSection.CompareProperties):
        (WebInspector.WatchExpressionTreeElement):
        (WebInspector.WatchExpressionTreeElement.prototype.update):
        (WebInspector.WatchExpressionTreeElement.prototype._deleteButtonClicked):
        (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
        (WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
        (WebInspector.WatchExpressionTreeElement.prototype.applyExpression):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * manual-tests/inspector/debugger-watch-expressions.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd ENABLE(INSPECTOR)
bolsinga@apple.com [Wed, 16 Sep 2009 19:50:58 +0000 (19:50 +0000)]
Add ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=29260

Reviewed by David Kilzer.

JavaScriptCore:

* wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

* DerivedSources.make: Use new WebCore.Inspector.exp file if ENABLE_DRAG_SUPPORT.
* WebCore.base.exp: Move Inspector only exports to WebCore.Inspector.exp.
* WebCore.xcodeproj/project.pbxproj: Add WebCore.Inspector.exp.
* bindings/js/JSDOMWindowBase.cpp: Use ENABLE(INSPECTOR) where applicable.
(WebCore::JSDOMWindowBase::supportsProfiling):
* bindings/js/JSInspectedObjectWrapper.cpp: Wrap entire file in ENABLE(INSPECTOR).
* bindings/js/JSInspectorBackendCustom.cpp: Ditto.
* bindings/js/JSInspectorCallbackWrapper.cpp: Ditto.
* bindings/js/ScriptObject.cpp: Use ENABLE(INSPECTOR) where applicable.
* bindings/js/ScriptObject.h: Ditto.
* bindings/js/ScriptObjectQuarantine.cpp: Wrap entire file in ENABLE(INSPECTOR).
* dom/Document.cpp: Use ENABLE(INSPECTOR) where applicable.
(WebCore::Document::recalcStyle):
(WebCore::Document::addMessage):
(WebCore::Document::resourceRetrievedByXMLHttpRequest):
(WebCore::Document::scriptImported):
* dom/Document.h: Ditto.
* dom/Node.cpp: Ditto.
(WebCore::Node::dispatchGenericEvent):
* dom/ScriptExecutionContext.h: Ditto.
(WebCore::):
* html/HTMLDocument.cpp: Ditto.
(WebCore::HTMLDocument::createTokenizer):
* html/HTMLTokenizer.cpp: Ditto.
(WebCore::HTMLTokenizer::write):
* inspector/ConsoleMessage.cpp: Ditto.
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::isEqual):
* inspector/ConsoleMessage.h: Ditto.
* inspector/DOMDispatchTimelineItem.cpp: Wrap entire file in ENABLE(INSPECTOR).
* inspector/InspectorBackend.cpp: Ditto.
* inspector/InspectorController.cpp: Ditto.
* inspector/InspectorDOMAgent.cpp: Ditto.
* inspector/InspectorDOMStorageResource.cpp: Ditto.
* inspector/InspectorDatabaseResource.cpp: Ditto.
* inspector/InspectorFrontend.cpp: Ditto.
* inspector/InspectorResource.cpp: Ditto.
* inspector/InspectorTimelineAgent.cpp: Ditto.
* inspector/TimelineItem.cpp: Ditto.
* loader/FrameLoader.cpp: Use ENABLE(INSPECTOR) where applicable.
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
(WebCore::FrameLoader::dispatchWindowObjectAvailable):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
(WebCore::FrameLoader::dispatchWillSendRequest):
(WebCore::FrameLoader::dispatchDidReceiveResponse):
(WebCore::FrameLoader::dispatchDidReceiveContentLength):
(WebCore::FrameLoader::dispatchDidFinishLoading):
* page/Chrome.cpp: Ditto.
(WebCore::Chrome::mouseDidMoveOverElement):
* page/Console.cpp: Ditto.
(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupEnd):
* page/ContextMenuController.cpp: Ditto.
(WebCore::ContextMenuController::handleContextMenuEvent):
(WebCore::ContextMenuController::contextMenuItemSelected):
* page/DOMWindow.cpp: Ditto.
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
* page/EventHandler.cpp: Ditto.
(WebCore::EventHandler::handleMousePressEvent):
* page/FrameView.cpp: Ditto.
(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):
* page/FrameView.h: Ditto.
* page/Page.cpp: Ditto.
(WebCore::Page::Page):
(WebCore::Page::~Page):
* page/Page.h: Ditto.
* platform/ContextMenu.cpp: Ditto.
(WebCore::ContextMenu::checkOrEnableIfNeeded):
* platform/ContextMenuItem.h: Ditto.
(WebCore::):
* storage/Database.cpp: Ditto.
(WebCore::Database::openDatabase):
* workers/WorkerContext.cpp: Ditto.
(WebCore::WorkerContext::importScripts):
* xml/XMLHttpRequest.cpp: Ditto.
(WebCore::XMLHttpRequest::didFinishLoading):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd ENABLE(CONTEXT_MENUS)
bolsinga@apple.com [Wed, 16 Sep 2009 19:40:19 +0000 (19:40 +0000)]
Add ENABLE(CONTEXT_MENUS)
https://bugs.webkit.org/show_bug.cgi?id=29225

Reviewed by David Kilzer.

JavaScriptCore:

* wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

* DerivedSources.make: Use new WebCore.ContextMenus.exp file if ENABLE_CONTEXT_MENUS.
* WebCore.base.exp: Move ContextMenu only exports to WebCore.ContextMenus.exp.
* WebCore.xcodeproj/project.pbxproj: Add WebCore.ContextMenus.exp.
* dom/Node.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.
(WebCore::Node::defaultEventHandler):
* loader/EmptyClients.h: Ditto.
* page/ContextMenuController.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
* page/EventHandler.cpp: Use ENABLE(CONTEXT_MENUS) where applicable.
* page/EventHandler.h: Ditto.
* page/Page.cpp: Ditto.
(WebCore::Page::Page):
* page/Page.h: Ditto.
* page/mac/EventHandlerMac.mm: Ditto.
* page/mac/WebCoreViewFactory.h: Ditto.
* platform/ContextMenu.cpp: Wrap entire file in ENABLE(CONTEXT_MENUS).
* platform/LocalizedStrings.h: Use ENABLE(CONTEXT_MENUS) where applicable.
* platform/mac/ContextMenuItemMac.mm: Wrap entire file in ENABLE(CONTEXT_MENUS).
* platform/mac/ContextMenuMac.mm: Ditto.
* platform/mac/LocalizedStringsMac.mm: Use ENABLE(CONTEXT_MENUS) where applicable.
* svg/graphics/SVGImage.cpp: Ditto.
(WebCore::SVGImage::dataChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean up invalidation for repainting. Hoist the dirty rect intersection test in...
hyatt@apple.com [Wed, 16 Sep 2009 19:37:28 +0000 (19:37 +0000)]
Clean up invalidation for repainting.  Hoist the dirty rect intersection test in ScrollViewMac up
into ScrollView so that all platforms do it.

Reviewed by Adam Roben.

Patch deferred repaints in FrameView::repaintContentRectangle to only add the visible portion of
the rectangle for repainting.

* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
* platform/ScrollView.cpp:
(WebCore::ScrollView::repaintContentRectangle):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformRepaintContentRectangle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
eric@webkit.org [Wed, 16 Sep 2009 19:29:54 +0000 (19:29 +0000)]
2009-09-16  Benjamin C Meyer  <benjamin.meyer@torchmobile.com>

        Reviewed by Eric Seidel.

        The webkit stdint and stdbool headers exists because
        the compiler MSVC doesn't include them.  The check
        should not check for PLATFORM(WIN_OS) but for MSVC.

        * os-win32/stdbool.h:
        * os-win32/stdint.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd ENABLE(DRAG_SUPPORT)
bolsinga@apple.com [Wed, 16 Sep 2009 19:10:23 +0000 (19:10 +0000)]
Add ENABLE(DRAG_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=29233

Reviewed by David Kilzer.

JavaScriptCore:

* wtf/Platform.h:

WebCore:

No new tests. (No change in default behavior.)

* DerivedSources.make: Use new WebCore.DragSupport.exp file if ENABLE_DRAG_SUPPORT.
* WebCore.base.exp: Move Drag Support only exports to WebCore.DragSupport.exp.
* WebCore.xcodeproj/project.pbxproj: Add WebCore.DragSupport.exp.
* dom/Clipboard.h: Use ENABLE(DRAG_SUPPORT) where applicable.
* loader/EmptyClients.h: Ditto.
* page/DragController.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
* page/EventHandler.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
* page/EventHandler.h: Ditto.
* page/Page.cpp: Ditto.
(WebCore::Page::Page):
* page/Page.h: Ditto.
* page/mac/DragControllerMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
* page/mac/EventHandlerMac.mm: Use ENABLE(DRAG_SUPPORT) where applicable.
(WebCore::EventHandler::passSubframeEventToSubframe):
* platform/DragData.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
* platform/DragImage.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
* platform/mac/ClipboardMac.h: Use ENABLE(DRAG_SUPPORT) where applicable.
* platform/mac/ClipboardMac.mm: Ditto.
* platform/mac/DragDataMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
* platform/mac/DragImageMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
* rendering/RenderLayer.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.
(WebCore::RenderLayer::autoscroll):
* rendering/RenderObject.cpp: Ditto.
* rendering/RenderObject.h: Ditto.
* svg/graphics/SVGImage.cpp: Ditto.
(WebCore::SVGImage::dataChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowxMSW build fix after adding support for high resolution times in Win.
kevino@webkit.org [Wed, 16 Sep 2009 19:02:16 +0000 (19:02 +0000)]
wxMSW build fix after adding support for high resolution times in Win.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowaf build fix after flag was moved to correct place.
kevino@webkit.org [Wed, 16 Sep 2009 17:55:59 +0000 (17:55 +0000)]
waf build fix after flag was moved to correct place.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Kenneth Christiansen.
kenneth@webkit.org [Wed, 16 Sep 2009 17:25:02 +0000 (17:25 +0000)]
Rubberstamped by Kenneth Christiansen.

Patch by Andras Becsi <andrewbecsi@yahoo.co.uk> on 2009-09-16
[Qt] Build fix for previous changes.

* QGVLauncher/main.cpp:
(MainView::flip):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, improve debug support and 2.9 support on MSW.
kevino@webkit.org [Wed, 16 Sep 2009 16:59:38 +0000 (16:59 +0000)]
wx build fix, improve debug support and 2.9 support on MSW.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed potential Qt < 4.6 build fix.
kenneth@webkit.org [Wed, 16 Sep 2009 16:11:33 +0000 (16:11 +0000)]
Unreviewed potential Qt < 4.6 build fix.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-16
* QGVLauncher/main.cpp:
(MainView::flip):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 16 Sep 2009 15:55:10 +0000 (15:55 +0000)]
2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Blind try at fixing new test failure on Windows.

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::didReceiveTitle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 16 Sep 2009 15:20:18 +0000 (15:20 +0000)]
2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        One more try at rebaselining the tests for those who dump frame
        loader delegates.

        * http/tests/loading/redirect-with-no-location-crash-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Vitaly Repeshko <vitalyr@chromium.org>
dglazkov@chromium.org [Wed, 16 Sep 2009 14:29:46 +0000 (14:29 +0000)]
2009-09-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Added operator==() to event listeners. This fixes V8 bindings
        build broken in http://trac.webkit.org/changeset/48402.
        https://bugs.webkit.org/show_bug.cgi?id=29298

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener): Now
        uses JSEventListenerType.
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8AbstractEventListener::operator==): Only compares
        pointers since we create at most one wrapper for a JS object.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 16 Sep 2009 14:29:26 +0000 (14:29 +0000)]
2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Rebaseline for those who support dumping of frame
        loader delegates, add specific expected result to GTK+

        * http/tests/loading/redirect-with-no-location-crash-expected.txt:
        * platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: Copied from LayoutTests/http/tests/loading/redirect-with-no-location-crash-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a "Flip effect" to our GraphicsView based launcher.
kenneth@webkit.org [Wed, 16 Sep 2009 13:49:58 +0000 (13:49 +0000)]
Add a "Flip effect" to our GraphicsView based launcher.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-16
Reviewed by Simon Hausmann.

* QGVLauncher/main.cpp:
(MainView::resizeEvent):
(MainView::flip):
(MainWindow::flip):
(MainWindow::buildUI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix for 64-bit Qt on Mac OS X
vestbo@webkit.org [Wed, 16 Sep 2009 13:46:06 +0000 (13:46 +0000)]
[Qt] Build fix for 64-bit Qt on Mac OS X

Reviewed by Simon Hausmann.

* wtf/Platform.h: Use JSVALUE64 on DARWIN, not only on MAC

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
zoltan@webkit.org [Wed, 16 Sep 2009 13:40:10 +0000 (13:40 +0000)]
2009-09-16  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Rubber-stamped by Simon Hausmann.

        [Qt] Typo fix. Pass the window object to the Format
        menu. In this way Qt can free its internal graphical
        objects during exit.

        * QtLauncher/main.cpp:
        (MainWindow::setupUI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
kov@webkit.org [Wed, 16 Sep 2009 13:37:57 +0000 (13:37 +0000)]
WebCore:

2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Crash when visiting http://flipper.googlelabs.com/
        https://bugs.webkit.org/show_bug.cgi?id=29293

        Check type for being null or empty before looking it up in the
        hash of supported types.

        Tested by http/tests/loading/redirect-with-no-location-crash.html

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::supportsType):

LayoutTests:

2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Crash when visiting http://flipper.googlelabs.com/
        https://bugs.webkit.org/show_bug.cgi?id=29293

        * http/tests/loading/redirect-with-no-location-crash.html: Added.
        * http/tests/loading/redirect-with-no-location-crash-expected.html: Added.
        * http/tests/loading/resources/redirect-with-no-location-crash.php: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-16 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
zoltan@webkit.org [Wed, 16 Sep 2009 13:18:55 +0000 (13:18 +0000)]
2009-09-16  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Fix wtf/ThreadSpecific.h under Qt to free thread local objects.
        https://bugs.webkit.org/show_bug.cgi?id=29295

        This is an important fix when JavaScript workers are in use, since
        unfreed ThreadGlobalDatas leak a big amount of memory (50-100k each).
        QThreadStorage calls the destructor of a given object, which is the
        ThreadSpecific::Data. Unlike pthread, Qt is object oriented, and does
        not support the calling of a static utility function when the thread
        is about to close. In this patch we call the ThreadSpecific::destroy()
        utility function from the destructor of ThreadSpecific::Data. Moreover,
        since Qt resets all thread local values to 0 before the calling of the
        appropriate destructors, we set back the pointer to its original value.
        This is necessary because the get() method of the ThreadSpecific
        object may be called during the exuction of the destructor.

        * wtf/ThreadSpecific.h:
        (WTF::ThreadSpecific::Data::~Data):
        (WTF::::~ThreadSpecific):
        (WTF::::set):
        (WTF::::destroy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build break fix on gcc ARM.
vestbo@webkit.org [Wed, 16 Sep 2009 11:50:27 +0000 (11:50 +0000)]
[Qt] Build break fix on gcc ARM.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-16
Reviewed by Tor Arne Vestbø.

* Api/qwebgraphicsitem.cpp:
(QWebGraphicsItemPrivate::_q_doLoadProgress):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix a crash in QWebFrame::hasFocus() with a simple null pointer check
hausmann@webkit.org [Wed, 16 Sep 2009 08:58:53 +0000 (08:58 +0000)]
Fix a crash in QWebFrame::hasFocus() with a simple null pointer check
when the focused frame is null. We do the same check in other places
where we call kit().

Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-16
Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::hasFocus):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed a typo found during translation.
hausmann@webkit.org [Wed, 16 Sep 2009 08:56:23 +0000 (08:56 +0000)]
Fixed a typo found during translation.

Patch by Jure Repinc <jlp@holodeck1.com> on 2009-09-16
Reviewed by Simon Hausmann.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::interruptForPolicyChangeError):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton...
cfleizach@apple.com [Wed, 16 Sep 2009 05:20:17 +0000 (05:20 +0000)]
WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

Layout test fix redux.
The paths to the fast/js resources needed to be updated.

* platform/mac/accessibility/aria-slider-value-change.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayout test fix.
cfleizach@apple.com [Wed, 16 Sep 2009 03:39:25 +0000 (03:39 +0000)]
Layout test fix.
This test should only be for Mac, since the other platforms don't support the necessary features.

WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

* accessibility/aria-slider-value-change-expected.txt: Removed.
* accessibility/aria-slider-value-change.html: Removed.
* platform/mac/accessibility/aria-slider-value-change-expected.txt: Copied from LayoutTests/accessibility/aria-slider-value-change-expected.txt.
* platform/mac/accessibility/aria-slider-value-change.html: Copied from LayoutTests/accessibility/aria-slider-value-change.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved the notion of "disconnected nodes with event listeners" because
ggaren@apple.com [Wed, 16 Sep 2009 01:30:00 +0000 (01:30 +0000)]
Removed the notion of "disconnected nodes with event listeners" because
it was vestigial. The reference cycle it tried to solve was solved another
way in https://bugs.webkit.org/show_bug.cgi?id=21260.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

* dom/Document.cpp:
(WebCore::Document::removeAllEventListeners):
* dom/Document.h:
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::insertedIntoDocument):
(WebCore::Node::removedFromDocument):
(WebCore::Node::willMoveToNewOwnerDocument):
(WebCore::Node::didMoveToNewOwnerDocument):
(WebCore::Node::addEventListener):
(WebCore::Node::removeEventListener):
(WebCore::Node::clearAttributeEventListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton...
cfleizach@apple.com [Wed, 16 Sep 2009 00:40:54 +0000 (00:40 +0000)]
WAI-ARIA: add support for ranges, including the progressbar, slider, and spinbutton roles
https://bugs.webkit.org/show_bug.cgi?id=28841

Reviewed by Beth Dakin.

WebCore:

Allow certain ARIA roles to change value with AXIncrement and AXDecrement.
Consolidate increment/decrement/changeValue methods.

Test: accessibility/aria-slider-value-change.html

* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::increment):
(WebCore::AccessibilityRenderObject::decrement):
(WebCore::AccessibilityRenderObject::changeValueByPercent):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySlider.cpp:
* accessibility/AccessibilitySlider.h:
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

* accessibility/aria-slider-value-change-expected.txt: Added.
* accessibility/aria-slider-value-change.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-15 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 15 Sep 2009 23:52:21 +0000 (23:52 +0000)]
2009-09-15  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Steve Falkenburg.

        Add four currently failing tests to the Skipped list so we can figure out what's wrong
        with them and try to get the bot closer to green. Bugs have been filed for each test.

        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow anonymous storage inside JSObject
oliver@apple.com [Tue, 15 Sep 2009 23:17:19 +0000 (23:17 +0000)]
Allow anonymous storage inside JSObject
https://bugs.webkit.org/show_bug.cgi?id=29168

Reviewed by Geoff Garen

Add the concept of anonymous slots to Structures so that it is
possible to store references to values that need marking in the
standard JSObject storage buffer.  This allows us to reduce the
malloc overhead of some objects (by allowing them to store JS
values in the inline storage of the object) and reduce the
dependence of custom mark functions (if all an objects children
are in the standard object property storage there's no need to
mark them manually).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved the jsEventListeners set from JSDOMGlobalObject, to simplify
ggaren@apple.com [Tue, 15 Sep 2009 21:47:15 +0000 (21:47 +0000)]
Removed the jsEventListeners set from JSDOMGlobalObject, to simplify
creation and destruction of JSDOMGlobalObject and event listeners.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-15
Reviewed by Sam Weinig.

Added an abstract operator==() to EventListener, to replace the
jsEventListeners set's role in determining if two event listeners are
equal from the DOM's perspective.

Added a type field to EventListener, and casting operations, to support
operator==() and other abstract operations.

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSEventListener::markJSFunction):
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
(WebCore::JSEventListener::operator==):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::cast):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* bindings/objc/ObjCEventListener.h:
(WebCore::ObjCEventListener::cast):
* bindings/objc/ObjCEventListener.mm:
(WebCore::ObjCEventListener::ObjCEventListener):
(WebCore::ObjCEventListener::operator==):
* dom/EventListener.h:
(WebCore::EventListener::):
(WebCore::EventListener::type):
(WebCore::EventListener::EventListener):
* dom/MessagePort.cpp:
(WebCore::MessagePort::addEventListener):
(WebCore::MessagePort::removeEventListener):
* dom/Node.cpp:
(WebCore::Node::removeEventListener):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::mainFrameDocument):
(WebCore::InspectorDOMAgent::operator==):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::cast):
* loader/ImageDocument.cpp:
(WebCore::ImageEventListener::cast):
(WebCore::ImageEventListener::ImageEventListener):
(WebCore::ImageEventListener::operator==):
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::addEventListener):
(WebCore::DOMApplicationCache::removeEventListener):
* notifications/Notification.cpp:
(WebCore::Notification::removeEventListener):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::removeEventListener):
* page/EventSource.cpp:
(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):
* svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::cast):
(WebCore::ConditionEventListener::ConditionEventListener):
(WebCore::ConditionEventListener::operator==):
(WebCore::ConditionEventListener::handleEvent):
* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::addEventListener):
(WebCore::AbstractWorker::removeEventListener):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::addEventListener):
(WebCore::WorkerContext::removeEventListener):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::addEventListener):
(WebCore::XMLHttpRequest::removeEventListener):
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::addEventListener):
(WebCore::XMLHttpRequestUpload::removeEventListener):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-15 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Sep 2009 21:26:26 +0000 (21:26 +0000)]
2009-09-15  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fixed position elements flash when CSS transforms are applied on page > 2048px tall
        https://bugs.webkit.org/show_bug.cgi?id=27272

        Update the previous workaround for misplaced compositing layers, which used a 4096px
        threshold, to 2048px since that's the GPU max texture size on some older hardware.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateLayerHostingViewPosition]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded ENABLE_MATHML feature define and build-webkit toggle
vestbo@webkit.org [Tue, 15 Sep 2009 20:33:46 +0000 (20:33 +0000)]
Added ENABLE_MATHML feature define and build-webkit toggle

Patch by Alex Milowski <alex@milowski.com> on 2009-09-15
Reviewed by Tor Arne Vestbø.

JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

WebCore:

* Configurations/FeatureDefines.xcconfig:

WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

WebKitTools:

* Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Allow waf build to support Python < 2.6.
kevino@webkit.org [Tue, 15 Sep 2009 19:25:00 +0000 (19:25 +0000)]
wx build fix. Allow waf build to support Python < 2.6.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously...
mrowe@apple.com [Tue, 15 Sep 2009 18:40:11 +0000 (18:40 +0000)]
WebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Use visibleContentRect() instead of boundsRect() when checking hit point bounds on viewport.

* dom/Document.cpp:
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

LayoutTests: Document.elementFromPoint() and Document.caretRangeFromPoint() returning null at points visible only after scrolling.
https://bugs.webkit.org/show_bug.cgi?id=29245

Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
Reviewed by Sam Weinig.

Extend tests to include hits in areas that are not in the initial containing block of the page.

* fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
* fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
* fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
* fast/dom/elementFromPoint-relative-to-viewport.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-15 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Tue, 15 Sep 2009 18:36:44 +0000 (18:36 +0000)]
2009-09-15  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Eric Seidel

        http://bugs.webkit.org/show_bug.cgi?id=26660

        Chromium Windows: When rotated, the baseline for a span of complex
        script is completely misaligned with that of the adjacent
        simple script text. It's fixed by not applying the baseline offset for
        the Skia code path.

        Test: transforms/2d/hindi-rotated.html

        * platform/graphics/chromium/UniscribeHelper.cpp:
        (WebCore::UniscribeHelper::draw):

2009-09-15  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Eric Seidel

        http://bugs.webkit.org/show_bug.cgi?id=26660

        Chromium Windows: When rotated, the baseline for a span of complex
        script is completely misaligned with that of the adjacent simple
        script text.

        * transforms/2d/hindi-rotated.html: Added.
        * platform/mac/transforms/2d/hindi-rotated-expected.checksum: Added.
        * platform/mac/transforms/2d/hindi-rotated-expected.png: Added.
        * platform/mac/transforms/2d/hindi-rotated-expected.txt: Added.
        * platform/win/transforms: Added.
        * platform/win/transforms/2d: Added.
        * platform/win/transforms/2d/hindi-rotated-expected.checksum: Added.
        * platform/win/transforms/2d/hindi-rotated-expected.png: Added.
        * platform/win/transforms/2d/hindi-rotated-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in
andersca@apple.com [Tue, 15 Sep 2009 18:30:41 +0000 (18:30 +0000)]
Pass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in
the WM_CREATE handler. This way we don't have to first create an zero size window and then size it.

Reviewed by Adam Roben.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
(WebCore::PopupMenu::PopupMenuWndProc):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMessageEvent should not be cancelable by default
atwilson@chromium.org [Tue, 15 Sep 2009 18:27:45 +0000 (18:27 +0000)]
MessageEvent should not be cancelable by default
https://bugs.webkit.org/show_bug.cgi?id=27846

Reviewed by Darin Adler.

WebCore:

* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
Changed constructor to set cancelable=false by default, per the HTML5 spec.

LayoutTests:

* fast/events/message-port-expected.txt:
* fast/events/message-port.html:
Added test case to check state of MessageEvent.cancelable attribute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7224378> REGRESSION(r48360): Dragging a tab with a plug-in out of...
mrowe@apple.com [Tue, 15 Sep 2009 18:20:31 +0000 (18:20 +0000)]
<rdar://problem/7224378> REGRESSION(r48360): Dragging a tab with a plug-in out of a window, the plug-in gets slow and confused

Reviewed by Anders Carlsson.

In r48360, the fix for <rdar://problem/7090444>, I neglected to consider the case where the plug-in had already been started and
-start would do an early-return rather than calling -restartTimers and -addWindowObservers itself.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Reinstate the call to -restartTimers and -addWindowObservers, but guard them
with a check that the view is still in the window.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-15 Charles Wei <charles.wei@torchmobile.com.cn>
eric@webkit.org [Tue, 15 Sep 2009 17:52:08 +0000 (17:52 +0000)]
2009-09-15  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos.

        Add a new test case for SVG Path parsing with a default command and starts with dot '.'
        https://bugs.webkit.org/show_bug.cgi?id=29123

        * svg/dom/path-parser-expected.txt:
        * svg/dom/resources/path-parser.js:
2009-09-15  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos.

        Fix SVG path parsing error if a command starts with dot '.'
        https://bugs.webkit.org/show_bug.cgi?id=29123

        * svg/SVGParserUtilities.cpp:
        (WebCore::SVGPathParser::parseSVG):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement conditional breakpoints in the Web Inspector frontend.
rik@webkit.org [Tue, 15 Sep 2009 13:14:50 +0000 (13:14 +0000)]
Implement conditional breakpoints in the Web Inspector frontend.
https://bugs.webkit.org/show_bug.cgi?id=28908

Patch by Alexander Pavlov <apavlov@chromium.org> on 2009-09-15
Reviewed by Timothy Hatcher.

* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint.prototype.set condition):
* inspector/front-end/Popup.js: Added.
(WebInspector.Popup):
(WebInspector.Popup.prototype.show):
(WebInspector.Popup.prototype.hide):
(WebInspector.Popup.prototype.get visible):
(WebInspector.Popup.prototype.set element):
(WebInspector.Popup.prototype.get element):
(WebInspector.Popup.prototype.positionElement):
(WebInspector.Popup.prototype.set anchor):
(WebInspector.Popup.prototype.get anchor):
(WebInspector.Popup.prototype.set autoHide):
(WebInspector.Popup.prototype._checkNotVisible):
(WebInspector.Popup.prototype._keyEventHandler):
(WebInspector.Popup.prototype._mouseDownEventHandler):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._loaded):
(WebInspector.SourceFrame.prototype._documentContextMenu):
(WebInspector.SourceFrame.prototype._documentMouseDown):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
(WebInspector.SourceFrame.prototype._editBreakpointCondition):
(WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
(WebInspector.SourceFrame.prototype._createPopupElement):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
(WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
(WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.set currentFocusElement):
(WebInspector.set currentPanel):
(WebInspector.loaded):
(WebInspector.contextMenu):
(WebInspector.elementDragStart):
(WebInspector.updateResource):
(WebInspector.drawLoadingPieChart):
(WebInspector.linkifyURLAsNode):
(WebInspector.startEditing.getContent):
(WebInspector.startEditing.editingCancelled):
(WebInspector.startEditing.editingCommitted):
* inspector/front-end/utilities.js:
(Element.prototype.positionAt):
(Element.prototype.offsetRelativeToWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix for windows.
vestbo@webkit.org [Tue, 15 Sep 2009 13:03:32 +0000 (13:03 +0000)]
[Qt] Build fix for windows.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

After http://trac.webkit.org/changeset/47795 the MinGW build broke,
because MinGW has __mingw_aligned_malloc instead of _aligned_malloc.

* runtime/Collector.cpp:
(JSC::Heap::allocateBlock): MinGW case added.
(JSC::Heap::freeBlock): MinGW case added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix for Windows/MinGW
vestbo@webkit.org [Tue, 15 Sep 2009 12:51:51 +0000 (12:51 +0000)]
[Qt] Build fix for Windows/MinGW

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-15
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29268

* wtf/Platform.h: JSVALUE32_64 temporarily disabled on PLATFORM(WIN_OS) with COMPILER(MINGW)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Gabor Loki <loki@inf.u-szeged.hu>
zoltan@webkit.org [Tue, 15 Sep 2009 11:29:33 +0000 (11:29 +0000)]
2009-09-14  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Detect VFP at runtime in generic ARM port on Linux platform.
        https://bugs.webkit.org/show_bug.cgi?id=29076

        * JavaScriptCore.pri:
        * assembler/MacroAssemblerARM.cpp: Added.
        (JSC::isVFPPresent):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::supportsFloatingPoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPage cache should support pages with unload handlers as an experiment.
beidson@apple.com [Tue, 15 Sep 2009 04:25:02 +0000 (04:25 +0000)]
Page cache should support pages with unload handlers as an experiment.
<rdar://problem/7196485> and https://bugs.webkit.org/show_bug.cgi?id=29021

Reviewed by Darin Adler.

WebCore:

For the experiment, only allow pages with unload handlers into the Page Cache on
Mac and Windows.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):

LayoutTests:

Disable fast/loader/frames-with-unload-handlers-in-page-cache.html as it doesn't
make sense in the context of this experiment.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUndoing mess: committing test code
kov@webkit.org [Tue, 15 Sep 2009 02:11:40 +0000 (02:11 +0000)]
Undoing mess: committing test code

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 15 Sep 2009 02:11:24 +0000 (02:11 +0000)]
2009-09-14  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez and Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=29134
        [GTK] Add API to access sub resources

        Implement getting subresources, and improve testing of
        main, and sub resources loading.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJava
kov@webkit.org [Tue, 15 Sep 2009 02:08:46 +0000 (02:08 +0000)]
Java

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add LayoutTests infrastructure to enable and disable webgl tests.
cmarrin@apple.com [Tue, 15 Sep 2009 01:28:20 +0000 (01:28 +0000)]
    Add LayoutTests infrastructure to enable and disable webgl tests.
        Also added a webgl test.
        https://bugs.webkit.org/show_bug.cgi?id=29254

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Sep 2009 01:07:46 +0000 (01:07 +0000)]
2009-09-14  Simon Fraser  <simon.fraser@apple.com>

        Fix the change in r48376 to do a null-check to fix a crashing test.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Sep 2009 00:54:15 +0000 (00:54 +0000)]
2009-09-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Add --iterations option to run-webkit-tests to repeat the tests N times
        https://bugs.webkit.org/show_bug.cgi?id=29263

        When run with --iterations N, run-webkit-tests will repeat the tests N times.

        * Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogit-svn-id: http://svn.webkit.org/repository/webkit/trunk@48377 268f45cc-cd09-0410...
beidson@apple.com [Tue, 15 Sep 2009 00:28:00 +0000 (00:28 +0000)]
git-svn-id: svn.webkit.org/repository/webkit/trunk@48377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 15 Sep 2009 00:19:57 +0000 (00:19 +0000)]
2009-09-14  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436

        Avoid a crash when a mouse event handler on a <select> changes the select from a popup
        to a list (by setting the 'size' property) inside the event handler.

        Test: fast/forms/select-change-popup-to-listbox-in-event-handler.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore PopupMenu cleanup.
andersca@apple.com [Mon, 14 Sep 2009 23:52:40 +0000 (23:52 +0000)]
More PopupMenu cleanup.

Reviewed by Jon Honeycutt.

* platform/PopupMenu.h:
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::show):
Call registerClass.

(WebCore::PopupMenu::registerClass):
Make this a private static member function so it can refer to PopupMenuWndProc.

(WebCore::PopupMenu::PopupMenuWndProc):
Try to get the PopupMenu and call its wndProc member function.

(WebCore::PopupMenu::wndProc):
Make this a member function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix more fallout I wrought on myself by not testing the final authentication patch...
beidson@apple.com [Mon, 14 Sep 2009 23:08:44 +0000 (23:08 +0000)]
Fix more fallout I wrought on myself by not testing the final authentication patch on Windows.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGTK build fix.
jhoneycutt@apple.com [Mon, 14 Sep 2009 22:46:38 +0000 (22:46 +0000)]
GTK build fix.

Unreviewed.

* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::setLogScrollingStartEvents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpeculative Qt build fix.
andersca@apple.com [Mon, 14 Sep 2009 22:45:59 +0000 (22:45 +0000)]
Speculative Qt build fix.

* platform/qt/QWebPopup.cpp:
(WebCore::QWebPopup::hidePopup):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Dirk Pranke <dpranke@chromium.org>
eric@webkit.org [Mon, 14 Sep 2009 22:38:38 +0000 (22:38 +0000)]
2009-09-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Darin Fisher.

        Fix RenderThemeChromiumWin::determineClassicState so that classic_state
        matches the state values (and you get a single classic_state value
        for a given {part,state} value. This change will be tested by a
        chromium patch that will land after this.

        This will be tested by code landing downstream on Chromium.org; the
        code does not execute on webkit.org.

        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::determineClassicState):
        (WebCore::RenderThemeChromiumWin::getThemeData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=29138
andersca@apple.com [Mon, 14 Sep 2009 22:14:13 +0000 (22:14 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29138
Simplify popup menu handling.

Reviewed by Adam Roben.

* platform/PopupMenuClient.h:
Rename hidePopup to popupDidHide.

* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
Call popupDidHide instead of hidePopup.

* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenu::menuUnmapped):
Ditto.

* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
Ditto.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::hide):
Call popupDidHide.

(WebCore::PopupWndProc):
Call PopupMenu::hide.

* platform/wx/PopupMenuWx.cpp:
(WebCore::PopupMenu::OnMenuItemSelected):
Call popupDidHide.

* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::hidePopup):
(WebCore::RenderMenuList::popupDidHide):
* rendering/RenderMenuList.h:
Set the "popup is visible" flag in popupDidHide.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::popupDidHide):
* rendering/RenderTextControlSingleLine.h:
Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago- Fix <rdar://problem/7182275>.
andersca@apple.com [Mon, 14 Sep 2009 21:27:08 +0000 (21:27 +0000)]
- Fix <rdar://problem/7182275>.

Reviewed by David Hyatt.

Make sure that the newly created scrollbar's style is up to date.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::~PopupMenu):
Call setParent so that the scrollbar's parts are torn down correctly.

(WebCore::PopupMenu::show):
Call styleChanged.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDRT/test part of
jhoneycutt@apple.com [Mon, 14 Sep 2009 21:25:24 +0000 (21:25 +0000)]
DRT/test part of
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

WebKitTools:

* DumpRenderTree/AccessibilityController.cpp:
(logScrollingStartEventsCallback):
Turn on logging of scrolling start events.
(AccessibilityController::getJSClass):
Add a "logScrollingStartEvents" to the AccessibilityController's JS
class definition.
(AccessibilityController::resetToConsistentState):
Turn off logging of scrolling start events.

* DumpRenderTree/AccessibilityController.h:
Declare setLogScrollingStartEvents(). Add a member for the scrolling
start event hook.

* DumpRenderTree/mac/AccessibilityControllerMac.cpp:
(AccessibilityController::setLogScrollingStartEvents):
Stubbed.

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::AccessibilityController):
Initialize the handle to 0.
(logEventProc):
Renamed from logFocusEventProc; now logs scrolling start events, too.
Removed the assertion that the event is a focus event. Added a switch
to print a message for focus, scrolling start, and other, unknown
events.
(AccessibilityController::setLogFocusEvents):
Changed to use logEventProc.
(AccessibilityController::setLogScrollingStartEvents):
If turning logging off, unhook the scrolling start event hook, and clear
the member holding the handle. If turning on, query for the root
accessible, so that accessibility is enabled for the WebView, and call
SetWinEventHook to setup an event hook using logEventProc as the
callback function.

LayoutTests:

* platform/win/accessibility/scroll-to-anchor-expected.txt: Added.
* platform/win/accessibility/scroll-to-anchor.html:
Added. Turns on scrolling start event logging, then jumps to an
anchor at the bottom of the page.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jhoneycutt@apple.com [Mon, 14 Sep 2009 21:25:08 +0000 (21:25 +0000)]
<rdar://problem/7197644> WebKit should broadcast an MSAA event when
jumping to a named anchor

https://bugs.webkit.org/show_bug.cgi?id=28899

Reviewed by Adam Roben.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::):
Added declaration for handleScrolledToAnchor(). Added a new entry to
the enum of accessibility notifications.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
Code moved from AccessibilityRenderObject::internalLinkElement() and
refactored slightly; walks the tree until it finds a Node (with a
renderer) whose accessibility is not ignored.

* accessibility/AccessibilityObject.h:
Added a declaration for firstAccessibleObjectFromNode().

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::internalLinkElement):
Code moved to AccessibilityObject::firstAccessibleObjectFromNode().

* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
Add a default case that returns early for notifications that Mac
doesn't handle.
(WebCore::AXObjectCache::handleScrolledToAnchor):
Stubbed.

* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
Post an AXScrolledToAnchor notification for the first accessible from
the anchor Node.
(WebCore::AXObjectCache::postPlatformNotification):
If the notification is AXFocusedUIElementChanged, fire an
EVENT_OBJECT_FOCUS. If the notification is AXScrolledToAnchor, fire
EVENT_SYSTEM_SCROLLINGSTART, matching Firefox.
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
Code moved to postPlatformNotification().

* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
Call AXObjectCache::handleScrolledToAnchor().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCookies are not inspectable after reloading a page
rik@webkit.org [Mon, 14 Sep 2009 21:09:04 +0000 (21:09 +0000)]
Cookies are not inspectable after reloading a page
https://bugs.webkit.org/show_bug.cgi?id=29222

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-14
Reviewed by Timothy Hatcher.

Create the cookieTreeElement on initialization instead of when the view is shown.
Reset the selected element of the sidebar on reset.

* inspector/front-end/StoragePanel.js:
(WebInspector.StoragePanel):
(WebInspector.StoragePanel.prototype.show):
(WebInspector.StoragePanel.prototype.reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows DRT build fix.
beidson@apple.com [Mon, 14 Sep 2009 20:32:19 +0000 (20:32 +0000)]
Windows DRT build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix.
beidson@apple.com [Mon, 14 Sep 2009 20:12:51 +0000 (20:12 +0000)]
Windows build fix.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
(WebCore::WebCoreSynchronousLoader::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSafari 4 cannot be used to update firmware on Linksys routers.
beidson@apple.com [Mon, 14 Sep 2009 20:05:30 +0000 (20:05 +0000)]
Safari 4 cannot be used to update firmware on Linksys routers.
<rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160

Reviewed by Alexey Proskuryakov.

WebCore:

In http://trac.webkit.org/changeset/42483, we disabled CFNetwork's session credential storage and
implemented our own in WebCore.

One feature we lost is that CFNetwork would automatically send previously authenticated credentials
with new connections when the paths match, as allowed by RFC 2617 for HTTP Basic and Digest Authentication.

Even though it's optional for User Agents to do this, (some?) Linksys routers rely on this behavior for
HTTP Basic Authentication.  So now WebCore's CredentialStorage will track URL paths for Basic credentials.

We're not making this enhancement for Digest at this time, since we don't know of anything that broke
due to the change in Digest behavior.

Test: http/tests/loading/basic-credentials-sent-automatically.html
      http/tests/loading/basic-auth-resend-wrong-credentials.html

* WebCore.base.exp:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

* platform/network/Credential.cpp:
(WebCore::Credential::isEmpty):
* platform/network/Credential.h:

Add a slightly more full featured CredentialStore that will track URL paths a credential belongs to:
* platform/network/CredentialStorage.cpp: Added.
(WebCore::protectionSpaceToCredentialMap):
(WebCore::originToDefaultCredentialMap):
(WebCore::originStringFromURL):
(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):
(WebCore::CredentialStorage::getDefaultAuthenticationCredential):
* platform/network/CredentialStorage.h: Added.

Allow ProtectionSpace to be a hash key:
* platform/network/ProtectionSpace.cpp:
(WebCore::ProtectionSpace::ProtectionSpace):
* platform/network/ProtectionSpace.h:
(WebCore::ProtectionSpace::ProtectionSpace):
(WebCore::ProtectionSpace::isHashTableDeletedValue):
* platform/network/ProtectionSpaceHash.h: Added.
(WebCore::ProtectionSpaceHash::hash):
(WebCore::ProtectionSpaceHash::equal):

Allow ResourceHandles to remember the initial credential they used:
* platform/network/ResourceHandleInternal.h:

Allow mutable ResourceRequests to update their platform object if HTTP header fields change:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::addHTTPHeaderField):

Remove WebCoreCredentialStorage:
* platform/network/cf/AuthenticationCF.cpp:
* platform/network/cf/AuthenticationCF.h:
* platform/network/mac/AuthenticationMac.h:
* platform/network/mac/AuthenticationMac.mm:

Change ResourceHandleCFNet to try to use stored credentials on new connections, if appropriate:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
  Credential if it does not match the initially used Credential.
(WebCore::ResourceHandle::receivedCredential):
(WebCore::WebCoreSynchronousLoader::didReceiveChallenge): Only try the ProtectionSpace key'ed
  Credential if it does not match the initially used Credential.
(WebCore::WebCoreSynchronousLoader::load):

Change ResourceHandleMac to try to use stored credentials on new connections, if appropriate:
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
  Credential if it does not match the initially used Credential.
(WebCore::ResourceHandle::receivedCredential):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Only try the
  ProtectionSpace key'ed Credential if it does not match the initially used Credential.
(+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):

Add base64-ability to CString:
* platform/text/CString.cpp:
(WebCore::CStringBuffer::base64Encode):
(WebCore::CString::base64Encode):
* platform/text/CString.h:
(WebCore::CStringBuffer::create):
(WebCore::CStringBuffer::CStringBuffer):

WebKit/mac:

Adopt the new WebCore::CredentialStorage in WebKit/Mac.

* Misc/WebDownload.mm:
(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
* Plugins/WebBaseNetscapePluginView.mm:
(WebKit::getAuthenticationInfo):

WebKit/win:

Adopt the new WebCore::CredentialStorage in WebKit/Win.

* WebDownloadCFNet.cpp:
(WebDownload::didReceiveAuthenticationChallenge):

WebKitTools:

Add the ability for DRT to handle authentication challenges.

* DumpRenderTree/LayoutTestController.cpp:
(setAuthenticationPasswordCallback):
(setAuthenticationUsernameCallback):
(setHandlesAuthenticationChallengesCallback):
(LayoutTestController::staticFunctions):

* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::handlesAuthenticationChallenges):
(LayoutTestController::setHandlesAuthenticationChallenges):
(LayoutTestController::authenticationUsername):
(LayoutTestController::setAuthenticationUsername):
(LayoutTestController::authenticationPassword):
(LayoutTestController::setAuthenticationPassword):

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):

* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveAuthenticationChallenge):
* DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:

* http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
* http/tests/loading/basic-auth-resend-wrong-credentials.html: Added.
* http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
* http/tests/loading/basic-credentials-sent-automatically.html: Added.
* http/tests/loading/resources/basic-auth-testing.php: Added.
* http/tests/loading/resources/othersubresources: Added.
* http/tests/loading/resources/othersubresources/protected-resource.php: Added.
* http/tests/loading/resources/protected-resource.php: Added.
* http/tests/loading/resources/subresources: Added.
* http/tests/loading/resources/subresources/protected-resource.php: Added.
* http/tests/loading/resources/test2: Added.
* http/tests/loading/resources/test2/basic-auth-testing.php: Added.
* http/tests/loading/resources/test2/protected-resource.php: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Mon, 14 Sep 2009 19:01:41 +0000 (19:01 +0000)]
2009-09-14  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        Add some tests that fail to the skipped list and rebaseline two tests
        to pass them.

        * platform/gtk/Skipped: Populate with more failing tests.
        * platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaseline.
        * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTest for <rdar://problem/6954546> and <rdar://problem/7090444>.
mrowe@apple.com [Mon, 14 Sep 2009 18:10:32 +0000 (18:10 +0000)]
Test for <rdar://problem/6954546> and <rdar://problem/7090444>.

Reviewed by Dan Bernstein.

WebKitTools:

Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.

* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):

LayoutTests:

* plugins/destroy-during-npp-new-expected.txt: Added.
* plugins/destroy-during-npp-new.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling...
mrowe@apple.com [Mon, 14 Sep 2009 18:10:27 +0000 (18:10 +0000)]
Fix <rdar://problem/7090444> Crashes in-[WebBaseNetscapePluginView stop] handling NSWindowWillCloseNotification.

Reviewed by Anders Carlsson.

It's not valid to call -addWindowObservers when the view is not in a window, but this can happen when -start
initializes a plug-in and the plug-in removes itself from the document during initialization.  -viewDidMoveToWindow
calls -start and then calls -addWindowObservers without ensuring that the view is still in a window.

If -[WebBaseNetscapePluginView addWindowObservers] is incorrectly called when the view is not in a window, it will
observe NSWindowWillCloseNotification on all windows.  This unexpected observer registration is not balanced by an
unregistration so the notification can be delivered after the view is deallocated, causing the crash seen in
<rdar://problem/7090444>.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView start]): Only call -updateAndSetWindow if we still have a current window.
(-[WebBaseNetscapePluginView viewDidMoveToWindow]): Remove unnecessary calls to -restartTimers and -addWindowObservers
from -[WebBaseNetscapePluginView viewDidMoveToWindow].  They are already called from within -start with the extra benefit
of ensuring that the view is still in a window when they are called.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoa...
mrowe@apple.com [Mon, 14 Sep 2009 18:10:23 +0000 (18:10 +0000)]
Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin.

Reviewed by Dan Bernstein.

The calls to FrameLoader::requestObject within RenderPartObject::updateWidget can result in a plug-in
being initialized.  This can run cause arbitrary JavaScript to run and may result in the RenderPartObject
being detached from the render tree and destroyed, causing a crash like <rdar://problem/6954546>.

No test is possible until <rdar://problem/7090444> is fixed

* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget): Ensure that we stay alive for the duration of plug-in initialization.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd RenderWidgetProtector to simplify protecting a RenderWidget from destruction...
mrowe@apple.com [Mon, 14 Sep 2009 18:10:19 +0000 (18:10 +0000)]
Add RenderWidgetProtector to simplify protecting a RenderWidget from destruction for the duration of a function.  Deploy it within RenderWidget.

Reviewed by Dan Bernstein.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition): Use a RefPtr rather than explicitly
ref'ing and deref'ing the node.
* rendering/RenderWidget.h:
* rendering/RenderWidgetProtector.h:
(WebCore::RenderWidgetProtector::RenderWidgetProtector):
(WebCore::RenderWidgetProtector::~RenderWidgetProtector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Mon, 14 Sep 2009 17:26:46 +0000 (17:26 +0000)]
2009-09-14  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] QWebGraphicsItem should check for null QWebPage.
        https://bugs.webkit.org/show_bug.cgi?id=29185

        Don't crash in QWebGraphicsItem when the page is still null, by
        either checking if it's the case or constructing the default one.

        * Api/qwebgraphicsitem.cpp:
        (QWebGraphicsItem::icon):
        (QWebGraphicsItem::setZoomFactor):
        (QWebGraphicsItem::zoomFactor):
        (QWebGraphicsItem::setGeometry):
        (QWebGraphicsItem::load):
        (QWebGraphicsItem::setHtml):
        (QWebGraphicsItem::toHtml):
        (QWebGraphicsItem::setContent):
        (QWebGraphicsItem::history):
        (QWebGraphicsItem::settings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-14 Cameron McCormack <cam@mcc.id.au>
eric@webkit.org [Mon, 14 Sep 2009 17:19:07 +0000 (17:19 +0000)]
2009-09-14  Cameron McCormack  <cam@mcc.id.au>

        Reviewed by Eric Seidel.

        CodeGenerator.pm needs some cleaning up
        https://bugs.webkit.org/show_bug.cgi?id=29238

        * bindings/scripts/CodeGenerator.pm:
        (FindParentsRecursively): Removed; its functionality is now handled in
        AddMethodsConstantsAndAttributesFromParentClasses.
        (ForAllParents): New function that visits an interface's ancestors and
        invokes a callback for each one.
        (AddMethodsConstantsAndAttributesFromParentClasses): Simplified by using
        ForAllParents.
        (GetMethodsAndAttributesFromParentClasses): Ditto.
        (IDLFileForInterface): Factored out previous calls to ScanDirectory into
        this new function, which returns the filename containing a given IDL
        interface definition.
        (ParseInterface): Simplified by using IDLFileForInterface.
        (ScanDirectory): Removed in lieu of IDLFileForInterface.
        * bindings/scripts/CodeGeneratorV8.pm: Drop call to
        FindParentsRecursively and get the list of parents from the
        AddMethodsConstantsAndAttributesFromParentClasses call instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix for non-wxPython builds and a fix for errors when updating swig.py.
kevino@webkit.org [Mon, 14 Sep 2009 17:06:51 +0000 (17:06 +0000)]
wx build fix for non-wxPython builds and a fix for errors when updating swig.py.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Assert hit when dropping a file in QtLauncher
yael.aharon@nokia.com [Mon, 14 Sep 2009 14:46:26 +0000 (14:46 +0000)]
[Qt] Assert hit when dropping a file in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=29242

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-14
Reviewed by Tor Arne Vestbø.

Qt's implementation of DropData::asURL does not return a URL encoded string
as expected.

* platform/qt/DragDataQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Build fix for windows build.
vestbo@webkit.org [Mon, 14 Sep 2009 12:45:27 +0000 (12:45 +0000)]
[Qt] Build fix for windows build.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-14
Reviewed by Tor Arne Vestbø.

JavaScriptCore

* JavaScriptCore.pri: Correct a logic error.
* pcre/dftables: Add missing paranthesis for tmpdir function.

WebKitTools:

* Scripts/bisect-builds: Add missing paranthesis for tmpdir function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, file was missed during TLS.cpp removal.
kevino@webkit.org [Mon, 14 Sep 2009 05:47:33 +0000 (05:47 +0000)]
wx build fix, file was missed during TLS.cpp removal.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Add "New Style Rule" to the localizedStrings
rik@webkit.org [Mon, 14 Sep 2009 02:29:12 +0000 (02:29 +0000)]
Web Inspector: Add "New Style Rule" to the localizedStrings
https://bugs.webkit.org/show_bug.cgi?id=29237

Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-13
Reviewed by Oliver Hunt.

* English.lproj/localizedStrings.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo accidently landed in last commit.
kevino@webkit.org [Mon, 14 Sep 2009 02:03:17 +0000 (02:03 +0000)]
Fix typo accidently landed in last commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, error out if using the wrong Python.
kevino@webkit.org [Mon, 14 Sep 2009 01:52:32 +0000 (01:52 +0000)]
wx build fix, error out if using the wrong Python.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 14 Sep 2009 01:32:47 +0000 (01:32 +0000)]
Reviewed by Kevin Ollivier.

Allow a way to set the cache policy via wx API.

https://bugs.webkit.org/show_bug.cgi?id=29200

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48348 268f45cc-cd09-0410-ab3c-d52691b4dbfc