WebKit.git
10 years ago2011-05-16 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 16 May 2011 21:37:50 +0000 (21:37 +0000)]
2011-05-16  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Sandbox denies Kerberos authentication
        https://bugs.webkit.org/show_bug.cgi?id=60921
        <rdar://problem/9133872>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 16 May 2011 21:34:54 +0000 (21:34 +0000)]
2011-05-16  Chris Rogers  <crogers@google.com>

        Reviewed by senorblanco@chromium.org.

        Add DynamicsCompressorNode implementation
        https://bugs.webkit.org/show_bug.cgi?id=60682

        No new tests since audio API is not yet implemented.

        * DerivedSources.make:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/audio/DynamicsCompressor.cpp: Added.
        (WebCore::DynamicsCompressor::DynamicsCompressor):
        (WebCore::DynamicsCompressor::initializeParameters):
        (WebCore::DynamicsCompressor::parameterValue):
        (WebCore::DynamicsCompressor::setEmphasisStageParameters):
        (WebCore::DynamicsCompressor::setEmphasisParameters):
        (WebCore::DynamicsCompressor::process):
        (WebCore::DynamicsCompressor::reset):
        * platform/audio/DynamicsCompressor.h: Added.
        (WebCore::DynamicsCompressor::isStereo):
        (WebCore::DynamicsCompressor::sampleRate):
        (WebCore::DynamicsCompressor::nyquist):
        * platform/audio/DynamicsCompressorKernel.cpp: Added.
        (WebCore::saturate):
        (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
        (WebCore::DynamicsCompressorKernel::setPreDelayTime):
        (WebCore::DynamicsCompressorKernel::process):
        (WebCore::DynamicsCompressorKernel::reset):
        * platform/audio/DynamicsCompressorKernel.h: Added.
        (WebCore::DynamicsCompressorKernel::latencyFrames):
        (WebCore::DynamicsCompressorKernel::sampleRate):
        * platform/audio/ZeroPole.cpp: Added.
        (WebCore::ZeroPole::process):
        * platform/audio/ZeroPole.h: Added.
        (WebCore::ZeroPole::ZeroPole):
        (WebCore::ZeroPole::reset):
        (WebCore::ZeroPole::setZero):
        (WebCore::ZeroPole::setPole):
        (WebCore::ZeroPole::zero):
        (WebCore::ZeroPole::pole):
        * webaudio/AudioContext.cpp:
        (WebCore::AudioContext::createDynamicsCompressor):
        * webaudio/AudioContext.h:
        * webaudio/AudioContext.idl:
        * webaudio/AudioNode.h:
        * webaudio/DynamicsCompressorNode.cpp: Added.
        (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
        (WebCore::DynamicsCompressorNode::~DynamicsCompressorNode):
        (WebCore::DynamicsCompressorNode::process):
        (WebCore::DynamicsCompressorNode::reset):
        (WebCore::DynamicsCompressorNode::initialize):
        (WebCore::DynamicsCompressorNode::uninitialize):
        * webaudio/DynamicsCompressorNode.h: Added.
        (WebCore::DynamicsCompressorNode::create):
        * webaudio/DynamicsCompressorNode.idl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-added platform-specific result after r86599.
mitz@apple.com [Mon, 16 May 2011 21:26:33 +0000 (21:26 +0000)]
Re-added platform-specific result after r86599.

* platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from platform/mac-leopard/editing/text-iterator/findString-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 16 May 2011 21:17:08 +0000 (21:17 +0000)]
2011-05-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        editing/deleting/5091898.html should be renamed and converted to a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=60920

        Renamed 5091898.html to delete-line-break-before-underlined-content.html and converted it
        to a dump-as-markup test.

        * editing/deleting/5091898.html: Removed.
        * editing/deleting/delete-line-break-before-underlined-content-expected.txt: Added.
        * editing/deleting/delete-line-break-before-underlined-content.html: Copied from LayoutTests/editing/deleting/5091898.html.
        * platform/chromium-linux/editing/deleting/5091898-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5091898-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5091898-expected.txt: Removed.
        * platform/gtk/editing/deleting/5091898-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5091898-expected.png: Removed.
        * platform/mac/editing/deleting/5091898-expected.png: Removed.
        * platform/mac/editing/deleting/5091898-expected.txt: Removed.
        * platform/mac/editing/style/5091898-expected.png: Removed.
        * platform/mac/editing/style/5091898-expected.txt: Removed.
        * platform/qt-arm/Skipped:
        * platform/qt-mac/Skipped:
        * platform/qt/editing/deleting/5091898-expected.png: Removed.
        * platform/qt/editing/deleting/5091898-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 16 May 2011 20:45:23 +0000 (20:45 +0000)]
2011-05-16  Tony Chang  <tony@chromium.org>

        Move chromium-linux-x86_64 results into chromium-linux.  We're making
        x86_64 the default configuration for chromium-linux because that's
        what the devs build and use.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typo pointed out by Dave Levin.
weinig@apple.com [Mon, 16 May 2011 20:35:57 +0000 (20:35 +0000)]
Fix typo pointed out by Dave Levin.

* TestWebKitAPI/PlatformUtilities.h:
(TestWebKitAPI::Util::assertWKStringEqual):
Strig -> String.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 16 May 2011 20:28:20 +0000 (20:28 +0000)]
2011-05-16  Sam Weinig  <sam@webkit.org>

        Reviewed by David Levin.

        Convert api tester over to using gtest expectations directly
        https://bugs.webkit.org/show_bug.cgi?id=60862

        * TestWebKitAPI/PlatformUtilities.cpp:
        (TestWebKitAPI::Util::toSTD):
        * TestWebKitAPI/PlatformUtilities.h:
        (TestWebKitAPI::Util::assertWKStrigEqual):
        Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
        the implementation of the macro simpler.

        * TestWebKitAPI/Test.h:
        Remove TEST_ASSERT forwarder.

        [Test changes elided]

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 16 May 2011 20:24:42 +0000 (20:24 +0000)]
2011-05-16  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Fix for Bug 43704 - Web font is printed as blank if it is not cached
        https://bugs.webkit.org/show_bug.cgi?id=43704

        In setting printing, we should not validate resources already cached
        for the document. If we do, web fonts used for screen are revalidated
        and possiby reloaded. Then the fonts can be shown as blank on print.
        This patch won't save the case where screen and print use different web
        fonts. Nonetheless, this is an improvement.

        No new tests because there seems to be no good way to test print images.

        * editing/Editor.cpp:
        (WebCore::Editor::paste): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
        * loader/cache/CachedResourceLoader.h:
        (WebCore::ResourceCacheValidationSuppressor::ResourceCacheValidationSuppressor): RAII class for allowing/disallowing stale resources.
        (WebCore::ResourceCacheValidationSuppressor::~ResourceCacheValidationSuppressor):
        * page/DragController.cpp:
        (WebCore::DragController::concludeEditDrag): Use ResourceCacheValidationSuppressor instead of explicitly allowing/disallowing stale resources.
        * page/Frame.cpp:
        (WebCore::Frame::setPrinting): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
2011-05-16  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Antti Koivisto.

        Fix for Bug 43704 - Web font is printed as blank if it is not cached
        https://bugs.webkit.org/show_bug.cgi?id=43704

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Mon, 16 May 2011 20:18:24 +0000 (20:18 +0000)]
2011-05-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, de-duplicating media/video-zoom-controls.html expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9446653> REGRESSION (r84750): Moving by word stops at apostrophe...
mitz@apple.com [Mon, 16 May 2011 20:14:15 +0000 (20:14 +0000)]
<rdar://problem/9446653> REGRESSION (r84750): Moving by word stops at apostrophe mid-word
https://bugs.webkit.org/show_bug.cgi?id=60915

Reviewed by Darin Adler.

Source/WebCore:

CFStringTokenizer’s kCFStringTokenizerUnitWord considers “Here’s” as two separate tokens.
Switching to CFStringTokenizer in r84750 was an attempt to address an issue with Japanese word
boundaries for searches with WebFindOptionsAtWordStarts, but it turned out to be insufficient,
and in r86387 the Japanese word issue was addressed independently of text boundaries, so just
revert r84750.

* platform/text/mac/TextBoundaries.mm:
(WebCore::findNextWordFromIndex):

LayoutTests:

* editing/text-iterator/findString-expected.txt:
* editing/text-iterator/findString.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/60913> C++ exceptions should not be enabled when building with...
ddkilzer@apple.com [Mon, 16 May 2011 19:59:34 +0000 (19:59 +0000)]
<webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
<rdar://problem/9446430>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

* Configurations/Base.xcconfig: Fixed typo.

Source/JavaScriptGlue:

* Configurations/Base.xcconfig: Fixed typo.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig: Fixed typo.

Source/WebCore:

* Configurations/Base.xcconfig: Fixed typo.

Source/WebKit/mac:

* Configurations/Base.xcconfig: Fixed typo.

Source/WebKit2:

* Configurations/Base.xcconfig: Fixed typo.

Tools:

* MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
* TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
* WebKitTestRunner/Configurations/Base.xcconfig: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for broken regression tests. Adding null pointer check
jonlee@apple.com [Mon, 16 May 2011 19:25:38 +0000 (19:25 +0000)]
Fix for broken regression tests. Adding null pointer check

* page/FrameView.cpp:
(WebCore::FrameView::didAddHorizontalScrollbar):
(WebCore::FrameView::willRemoveHorizontalScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 16 May 2011 19:04:23 +0000 (19:04 +0000)]
2011-05-16  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Remove unused member variables from LayerRendererChromium
        https://bugs.webkit.org/show_bug.cgi?id=60899

        These should have been removed when tiling was enabled for root
        layers.

        * platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Mon, 16 May 2011 18:58:57 +0000 (18:58 +0000)]
2011-05-16  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86589.
        http://trac.webkit.org/changeset/86589
        https://bugs.webkit.org/show_bug.cgi?id=54670

        Broke chromium inspector tests.

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsole):
        * inspector/console/console-assert.html:
        * inspector/console/console-trace-in-eval.html:
        * inspector/console/console-trace.html:
        * inspector/console/console-uncaught-exception.html:
        * inspector/debugger/debugger-autocontinue-on-syntax-error.html:
        * inspector/styles/styles-iframe.html:
        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
2011-05-16  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r86589.
        http://trac.webkit.org/changeset/86589
        https://bugs.webkit.org/show_bug.cgi?id=54670

        Broke chromium inspector tests.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.show):
        (WebInspector.ConsoleView.prototype.afterShow):
        (WebInspector.ConsoleView.prototype.hide):
        (WebInspector.ConsoleView.prototype.addMessage):
        (WebInspector.ConsoleView.prototype.clearMessages):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.set visibleView):
        (WebInspector.Drawer.prototype.show.animationFinished):
        (WebInspector.Drawer.prototype.show):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 16 May 2011 18:54:40 +0000 (18:54 +0000)]
2011-05-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        JSWeakObjectMap finalisation may occur while gc is in inconsistent state
        https://bugs.webkit.org/show_bug.cgi?id=60908
        <rdar://problem/9409491>

        We need to ensure that we have called all the weak map finalizers while
        the global object (and hence global context) is still in a consistent
        state.  The best way to achieve this is to simply use a weak handle and
        finalizer on the global object.

        * JavaScriptCore.exp:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::WeakMapFinalizer::finalize):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::registerWeakMap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a revision number in the ChangeLog
bweinstein@apple.com [Mon, 16 May 2011 18:08:39 +0000 (18:08 +0000)]
Fix a revision number in the ChangeLog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r86555): Dropping URL onto Desktop creates broken Internet Shortcut file.
bweinstein@apple.com [Mon, 16 May 2011 18:07:20 +0000 (18:07 +0000)]
REGRESSION (r86555): Dropping URL onto Desktop creates broken Internet Shortcut file.

Reviewed by Enrica Casucci.

r86477 fixed this bug by using latin1 as the CString's encoding instead of ascii, but r86555
undid this change.

Change it back to latin1 to fix the bug.

* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writeURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; build fix for non-SnowLeopard builds.
jer.noble@apple.com [Mon, 16 May 2011 18:03:21 +0000 (18:03 +0000)]
Unreviewed; build fix for non-SnowLeopard builds.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Wrap definition
    of layerIsDescendentOf in a #if check.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 May 2011 17:55:52 +0000 (17:55 +0000)]
2011-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        If the root compositing layer changes while we're about to exit compositing mode, make sure to enter compositing mode
        https://bugs.webkit.org/show_bug.cgi?id=60905
        <rdar://problem/9365574>

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setRootCompositingLayer):
        If we have a layer tree host, but haven't yet sent a EnterAcceleratedCompositingMode message (this can happen
        when quickly going in and out of compositing mode), make sure to schedule a notification when the layer tree host
        does it next flush. This will end up sending the EnterAcceleratedCompositingMode message.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 16 May 2011 17:54:22 +0000 (17:54 +0000)]
2011-05-16  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: merge ConsoleView into ConsolePanel.
        https://bugs.webkit.org/show_bug.cgi?id=54670

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsole):
        (initialize_InspectorTest.InspectorTest.waitUntilConsoleMessageAdded):
        * inspector/console/console-assert.html:
        * inspector/console/console-trace-in-eval.html:
        * inspector/console/console-trace.html:
        * inspector/console/console-uncaught-exception.html:
        * inspector/debugger/debugger-autocontinue-on-syntax-error.html:
        * inspector/styles/styles-iframe.html:
        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
2011-05-16  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: merge ConsoleView into ConsolePanel.
        https://bugs.webkit.org/show_bug.cgi?id=54670

        Console view in drawer looks exactly the same as console panel. Merging ConsoleView and ConsolePanel together
        will allow us to reuse panel's functionality (e.g. resizable sidebar) even when console is docked.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsolePanel.prototype.get toolbarItemLabel):
        (WebInspector.ConsolePanel.prototype.show):
        (WebInspector.ConsolePanel.prototype.hide):
        (WebInspector.ConsolePanel.prototype.showInDrawer):
        (WebInspector.ConsolePanel.prototype.afterShowInDrawer):
        (WebInspector.ConsolePanel.prototype.hideInDrawer):
        (WebInspector.ConsolePanel.prototype.addMessage):
        (WebInspector.ConsolePanel.prototype.clearMessages):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.set visibleView):
        (WebInspector.Drawer.prototype.show.animationFinished):
        (WebInspector.Drawer.prototype.show):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-13 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 16 May 2011 17:50:54 +0000 (17:50 +0000)]
2011-05-13  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
        https://bugs.webkit.org/show_bug.cgi?id=60826

        Listen for a WebKitLayerHostChanged notification and, if the affected layer is an
        ancestor layer of the qtMovieLayer, tear down the layer and recreate it the
        next time setVisible(true) is called.

        * dom/Document.cpp:
        (WebCore::Document::webkitDidEnterFullScreenForElement):  Call setFullScreenRootLayer(0)
            before disabling animation on the full screen renderer.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Register an observer for the new
            WebKitLayerHostChanged notification.
        (WebCore::layerIsDescendentOf): Added.
        (WebCore::MediaPlayerPrivateQTKit::layerHostChanged): Added.  If the changed
            layer is an ancestor of the movie layer, tear down rendering and re-
            create the next time setVisible(true) is called.
        (-[WebCoreMovieObserver layerHostChanged:]):  Added ObjC listener wrapper.
2011-05-13  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
        https://bugs.webkit.org/show_bug.cgi?id=60826

        Emit a notification when moving a CALayer from the WebProcess's main
        layer host to a new context.  This allows listeners to invalidate their
        layers which may not support moving between different CAContexts (as is
        the case with QTMovieLayer).  In order to allow listeners to determine if they
        are affected, the notification will pass the root CALayer in a userInfo
        dictionary.

        In WebFullScreenManagerMac, move from storing a pointer to a non-refcounted
        class (GraphicsLayer) to a retainable class (PlatformLayer).

        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): No need to initialize
            m_fullScreenRootLayer now that it is a RetainPtr<>.
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Emit a notification
            after either creating or destroying the full screen layer host.
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 16 May 2011 17:48:17 +0000 (17:48 +0000)]
2011-05-16  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Adam Roben.

        [WK2] Remove some passing tests from the mac-wk2 skipped list
        https://bugs.webkit.org/show_bug.cgi?id=60889

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 17:32:04 +0000 (17:32 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove disable-javascript-urls CSP directive
        https://bugs.webkit.org/show_bug.cgi?id=60874

        No need to test a feature that doesn't exist.

        * http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Removed.
        * http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Removed.
2011-05-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove disable-javascript-urls CSP directive
        https://bugs.webkit.org/show_bug.cgi?id=60874

        After talking this out with various folks in the CSP working group, we
        decided that this syntax isn't the right way to approach this issue.
        If we want to address the use case of enabling JavaScript URLs
        separately from inline script, we'll probably just make

          script-src javascript:

        work that way.

        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Wk2][Symbian] Fix build after r86560
ossy@webkit.org [Mon, 16 May 2011 17:27:12 +0000 (17:27 +0000)]
[Qt][Wk2][Symbian] Fix build after r86560
https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2011-05-16
Rubber-stamped by Csaba Osztrogonác.

Temporarily fix Symbian build by re-enabling compilation
of Qt/Gtk common code (as was the case for Symbian before r55875).
This is a stop gap until the pure Symbian Core IPC and process launching bits land in Bug 55875
As of this revision, only the native SharedMemory implementation is in trunk.

* Platform/CoreIPC/Attachment.h: Compile Qt/Gtk common code for Qt-Symbian too
* Platform/CoreIPC/Connection.h: ditto
* Platform/SharedMemory.h:       ditto
* Platform/qt/SharedMemorySymbian.cpp: stub implementations of attachment handling
(WebKit::SharedMemory::Handle::releaseToAttachment):
(WebKit::SharedMemory::Handle::adoptFromAttachment):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Reviewed by Simon Fraser.
jonlee@apple.com [Mon, 16 May 2011 17:25:02 +0000 (17:25 +0000)]
Source/WebCore:        Reviewed by Simon Fraser.

       Can't horizontally scroll iframes and overflow because wheel events are always accepted
       https://bugs.webkit.org/show_bug.cgi?id=60779

       * dom/Document.cpp:
       (WebCore::Document::Document): Initialize wheel event handler count
       (WebCore::Document::didAddWheelEventHandler): Increment count, and tell the main frame
       to recalculate the total number of wheel event handlers in all of its frames' documents
       (WebCore::Document::didRemoveWheelEventHandler): Reverse of previous method
       * dom/Document.h:
       (WebCore::Document::wheelEventHandlerCount): Access the count
       * dom/Node.cpp:
       (WebCore::tryAddEventListener): If the event listener is a mouse wheel event, then
       tell the document to increment its count
       (WebCore::tryRemoveEventListener): Reverse of previous method

       * page/ChromeClient.h: Two new methods:
 numWheelEventHandlersChanged: WebProcess tells UIProcess to update its cached
   count of total wheel event handlers, which in this case only include horizontal
   scrollbars and mouse wheel JS handlers
 shouldRubberBandInDirection: allow the UIProcess to provide some control over
   whether rubber banding is allowed when scrolling in a particular direction
       * loader/EmptyClients.h:
       (WebCore::EmptyChromeClient::numWheelEventHandlersChanged): Default empty impl
       (WebCore::EmptyChromeClient::shouldRubberBandInDirection): Default empty impl
       * page/EventHandler.cpp:
       (WebCore::EventHandler::handleWheelEvent): Remove a redundant pointer check
       * page/Frame.cpp:
       (WebCore::Frame::setDocument): When the frame's document changes, calculate that
       document's total wheel event handlers, and notify the UIProcess
       (WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged): Performs a crawl
       of the frame tree to aggregate the count
       * page/Frame.h:

       * platform/ScrollableArea.h: Virtualize didAddHorizontalScrollbar and
       willRemoveHorizontalScrollbar for overriding in RenderLayer and FrameView
       (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMinimumPosition): Returns true if there is
       no scrollbar or the scroller position is in the minimum scroll position.
       (WebCore::ScrollableArea::isHorizontalScrollerPinnedToMaximumPosition): Converse of the above.
       (WebCore::ScrollableArea::shouldRubberBandInDirection): Default impl
       * page/FrameView.cpp:
       (WebCore::FrameView::didAddHorizontalScrollbar): Updates the frame's document's count
       (WebCore::FrameView::willRemoveHorizontalScrollbar): Updates the frame's document's
       count
       (WebCore::FrameView::shouldRubberBandInDirection): Connective glue
       * page/FrameView.h: Adding overriding methods from ScrollableArea
       * rendering/RenderLayer.cpp: Similar functionality to FrameView
       (WebCore::RenderLayer::didAddHorizontalScrollbar):
       (WebCore::RenderLayer::willRemoveHorizontalScrollbar):
       * rendering/RenderLayer.h:

       * platform/mac/ScrollAnimatorMac.h: Fix typo of "momentum"
       * platform/mac/ScrollAnimatorMac.mm:
       (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Fix typo of "momentum"
       (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): Fix typo of "coalesced"
       (WebCore::ScrollAnimatorMac::beginScrollGesture): Fix typo of "coalesced"
       (WebCore::ScrollAnimatorMac::snapRubberBand): Fix typo of "momentum"

       (WebCore::ScrollAnimatorMac::handleWheelEvent): New logic for determining whether
       to allow rubber-banding based on the area's scroll position and the wheel event.
       Could prevent accepting the wheel event. Also, fix typo of "momentum"
       (WebCore::isScrollingLeftAndShouldNotRubberBand): Inline helper function for logic
       (WebCore::isScrollingRightAndShouldNotRubberBand): Inline helper function for logic

Source/WebKit/chromium: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* src/ChromeClientImpl.h:
(WebKit::ChromeClientImpl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/efl: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebCoreSupport/ChromeClientEfl.h:
(WebCore::ChromeClientEfl::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientEfl::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/gtk: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/haiku: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebCoreSupport/ChromeClientHaiku.h:
(WebCore::ChromeClientHaiku::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientHaiku::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/mac: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method

Source/WebKit/qt: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebCoreSupport/ChromeClientQt.h:
(WebCore::ChromeClientQt::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientQt::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/win: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wince: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebCoreSupport/ChromeClientWinCE.h:
(WebKit::ChromeClientWinCE::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebKit::ChromeClientWinCE::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit/wx: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebKitSupport/ChromeClientWx.h:
(WebCore::ChromeClientWx::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebCore::ChromeClientWx::numWheelEventHandlersChanged): Default impl of new ChromeClient method

Source/WebKit2: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

We keep track of the number of horizontal scrollbars and mouse wheel event handlers in the
UI process as a means of determining whether horizontal scroll events will be handled
by the web process.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willHandleHorizontalScrollEvents): Return true if there is at least
one wheel event handler
* UIProcess/WebPageProxy.h: Add new variable to cache the count
(WebKit::WebPageProxy::numWheelEventHandlersChanged): Sets the count

The rest just provides all the connections.
* UIProcess/API/C/WKPage.cpp:
(WKPageWillHandleHorizontalScrollEvents):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::shouldRubberBandInDirection):
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldRubberBandInDirection): Forward to injected bundle UI client
(WebKit::WebChromeClient::updateCountWheelEventHandlers): Updates the web page proxy
* WebProcess/WebCoreSupport/WebChromeClient.h:

Tools: Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779

Reviewed by Simon Fraser.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Mon, 16 May 2011 17:16:31 +0000 (17:16 +0000)]
2011-05-16  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Media Stream API: add local stream requests.
        https://bugs.webkit.org/show_bug.cgi?id=60177

        Re-enable the argument-types test as the navigator.getUserMedia options
        are now being parsed and raise the appropriate exceptions.

        * platform/chromium/test_expectations.txt:
2011-05-16  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Media Stream API: add local stream requests.
        https://bugs.webkit.org/show_bug.cgi?id=60177

        Add the code and messages for requesting the generation of local streams and getting the reply back.

        Tests for the Media Stream API will be provided by the bug 56587.
        One test is re-enabled with this patch.

        Test: fast/dom/MediaStream/argument-types.html

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/CallbackTask.h: Added.
        (WebCore::CallbackTask1::create):
        (WebCore::CallbackTask1::performTask):
        (WebCore::CallbackTask1::Scheduler::scheduleCallback):
        (WebCore::CallbackTask1::CallbackTask1):
        * page/MediaStreamClient.h:
        * page/MediaStreamController.cpp:
        (WebCore::MediaStreamController::isClientAvailable):
        (WebCore::MediaStreamController::unregisterFrameController):
        (WebCore::MediaStreamController::registerRequest):
        (WebCore::MediaStreamController::registerStream):
        (WebCore::MediaStreamController::generateStream):
        (WebCore::MediaStreamController::streamGenerated):
        (WebCore::MediaStreamController::streamGenerationFailed):
        * page/MediaStreamController.h:
        * page/MediaStreamFrameController.cpp:
        (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest):
        (WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest):
        (WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest):
        (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort):
        (WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback):
        (WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback):
        (WebCore::::unregisterAll):
        (WebCore::::detachEmbedder):
        (WebCore::MediaStreamFrameController::MediaStreamFrameController):
        (WebCore::MediaStreamFrameController::pageController):
        (WebCore::MediaStreamFrameController::unregister):
        (WebCore::MediaStreamFrameController::enterDetachedState):
        (WebCore::MediaStreamFrameController::isClientAvailable):
        (WebCore::MediaStreamFrameController::disconnectFrame):
        (WebCore::MediaStreamFrameController::parseGenerateStreamOptions):
        (WebCore::MediaStreamFrameController::generateStream):
        (WebCore::MediaStreamFrameController::streamGenerated):
        (WebCore::MediaStreamFrameController::streamGenerationFailed):
        * page/MediaStreamFrameController.h:
        (WebCore::MediaStreamFrameController::ClientBase::ClientBase):
        (WebCore::MediaStreamFrameController::ClientBase::~ClientBase):
        (WebCore::MediaStreamFrameController::ClientBase::mediaStreamFrameController):
        (WebCore::MediaStreamFrameController::ClientBase::clientId):
        (WebCore::MediaStreamFrameController::ClientBase::isStream):
        (WebCore::MediaStreamFrameController::ClientBase::isGeneratedStream):
        (WebCore::MediaStreamFrameController::ClientBase::detachEmbedder):
        (WebCore::MediaStreamFrameController::ClientBase::associateFrameController):
        (WebCore::MediaStreamFrameController::ClientBase::unregisterClient):
        (WebCore::MediaStreamFrameController::StreamClient::StreamClient):
        (WebCore::MediaStreamFrameController::StreamClient::~StreamClient):
        (WebCore::MediaStreamFrameController::StreamClient::isStream):
        (WebCore::MediaStreamFrameController::StreamClient::unregister):
        (WebCore::MediaStreamFrameController::IdGenerator::IdGenerator):
        (WebCore::MediaStreamFrameController::IdGenerator::getNextId):
        (WebCore::MediaStreamFrameController::ClientMapBase::ClientMapBase):
        * page/Navigator.cpp:
        (WebCore::Navigator::webkitGetUserMedia):
        * page/NavigatorUserMediaErrorCallback.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 16 May 2011 17:09:58 +0000 (17:09 +0000)]
2011-05-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
        https://bugs.webkit.org/show_bug.cgi?id=60892

        Don't set the ItemClipsChildrenToShape flag for the root platform layer,
        since that is now the overflow controls layer. The clip layer, which was
        previously the root platform layer, already gets the flag by way of
        the GraphicsLayer mask-to-bounds flag.

        * WebCoreSupport/PageClientQt.cpp:
        (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 16 May 2011 16:58:15 +0000 (16:58 +0000)]
2011-05-16  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: debuggerWasEnabled notification should not be send to front-end on navigation.
        https://bugs.webkit.org/show_bug.cgi?id=60888

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::disableDebugger):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::enable):
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::restore):
        (WebCore::InspectorDebuggerAgent::clearFrontend):
        * inspector/InspectorDebuggerAgent.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 May 2011 16:54:15 +0000 (16:54 +0000)]
2011-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Silverlight: Selection via keyboard selects the entire plugin instead of the contents of a TextBox
        https://bugs.webkit.org/show_bug.cgi?id=60898
        <rdar://problem/9309903>

        Special-case Command-A and always return true, indicating that the plug-in handled the event.
        This matches WebKit1.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::platformHandleKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 16 May 2011 16:52:38 +0000 (16:52 +0000)]
2011-05-16  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: cursors
        https://bugs.webkit.org/show_bug.cgi?id=60804

        This test creates an object store with a few records and exercises
        a variety of cursors going forward, backward, and over key ranges.
        It also updates records from the cursor and checks that the update
        stuck.

        * storage/indexeddb/mozilla/cursors-expected.txt: Added.
        * storage/indexeddb/mozilla/cursors.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 May 2011 16:34:09 +0000 (16:34 +0000)]
2011-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Short-circuit NPRuntime calls made by Flash during plug-in instantiation
        https://bugs.webkit.org/show_bug.cgi?id=60894
        <rdar://problem/8804681>

        During plug-in instantiation, Flash makes a couple of NPRuntime calls to get the
        URL of the current document as well as the URL of the toplevel document. This leads to
        a bunch of IPC traffic that slows down instantiation.

        Since we know what calls Flash is making and what results are expected, we can handle the
        NPRuntime calls directly in the plug-in process and avoid extra IPC overhead.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::PluginControllerProxy):
        Initialize m_pluginCreationParameters.

        (WebKit::PluginControllerProxy::initialize):
        Set m_pluginCreationParameters to point to the creation parameters right before
        calling Plugin::initialize and restore it back afterwards.

        (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
        If the plug-in calling NPN_Invoke has the CanShortCircuitSomeNPRuntimeCallsDuringInitialization
        quirk, and we're being initialized, check for the __flash_getWindowLocation and
        __flash_getTopLocation function calls and return the correct values.

        (WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
        Check if the script string has the definitions of __flash_getWindowLocation or __flash_getTopLocation
        and just ignore them. Note that ignoring them has the effect of not adding them to the window object,
        which could in theory be a backwards compatibility problem if web pages were to assume that these
        functions existed on a page with plug-ins. In practice this is probably not a problem, especially since
        these functions are only used on Mac WebKit.

        * PluginProcess/PluginControllerProxy.h:
        (WebKit::PluginControllerProxy::inInitialize):
        Add helper function.

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::NetscapePluginModule::determineQuirks):
        Add the CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk for Flash on Mac.

        * Shared/Plugins/PluginQuirks.h:
        Add Mac specific CanShortCircuitSomeNPRuntimeCallsDuringInitialization quirk.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 May 2011 16:06:07 +0000 (16:06 +0000)]
2011-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add a returnValue parameter to tryToShortCircuitInvoke
        https://bugs.webkit.org/show_bug.cgi?id=60891

        tryToShortCircuitInvoke needs to be able to indicate that an invoke
        call failed. Add a returnValue parameter and have the real return value
        indicate whether tryToShortCircuitInvoke did short-circuit the invoke or not.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
        * PluginProcess/PluginControllerProxy.h:
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_Invoke):
        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::tryToShortCircuitInvoke):
        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        * WebProcess/Plugins/PluginController.h:
        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::tryToShortCircuitInvoke):
        * WebProcess/Plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Grzegorz Czajkowski <g.czajkowski@samsung.com>
commit-queue@webkit.org [Mon, 16 May 2011 16:05:41 +0000 (16:05 +0000)]
2011-05-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove EAPI macro from functions definition
        https://bugs.webkit.org/show_bug.cgi?id=60754

        This macro should be used in header files only.
        It's not necessary to have it in definitions.

        * ewk/ewk_cookies.cpp:
        (ewk_cookies_file_set):
        (ewk_cookies_clear):
        (ewk_cookies_get_all):
        (ewk_cookies_cookie_del):
        (ewk_cookies_cookie_free):
        (ewk_cookies_policy_set):
        (ewk_cookies_policy_get):
        * ewk/ewk_window_features.cpp:
        (ewk_window_features_unref):
        (ewk_window_features_ref):
        (ewk_window_features_bool_property_get):
        (ewk_window_features_int_property_get):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the failing mac-wk2 expected results for online-fallback-layering.html, since...
jberlin@webkit.org [Mon, 16 May 2011 15:58:37 +0000 (15:58 +0000)]
Remove the failing mac-wk2 expected results for online-fallback-layering.html, since it now
appears to be passing on the SL WK2 bots:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r86545%20(11698)/http/tests/appcache/online-fallback-layering-pretty-diff.html

* platform/mac-wk2/http/tests/appcache/online-fallback-layering-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Wk2][Symbian] Fix build after r86560
ossy@webkit.org [Mon, 16 May 2011 15:23:26 +0000 (15:23 +0000)]
[Qt][Wk2][Symbian] Fix build after r86560
https://bugs.webkit.org/show_bug.cgi?id=60887

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2011-05-16
Reviewed by Csaba Osztrogonác.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::~ArgumentDecoder): guard Unix and Gtk code with USE(UNIX_DOMAIN_SOCKETS)
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::~ArgumentEncoder): ditto

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 May 2011 15:11:45 +0000 (15:11 +0000)]
2011-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke
        https://bugs.webkit.org/show_bug.cgi?id=60886

        Make it possible for a plug-in controller to intercept calls to NPN_Invoke, which
        will be useful for avoiding sync IPC messages during instantiation.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::evaluate):
        Call tryToShortCircuitEvaluate. If it returns true, we don't need to call back to
        the web process to ask it to evaluate the script string.

        (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
        (WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):
        Always return false for now.

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_Invoke):
        Get the plug-in and call tryToShortCircuitInvoke.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::tryToShortCircuitInvoke):
        Call the plug-in controller.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::tryToShortCircuitInvoke):
        Always return false here, since there's no need to short-circuit calls
        for plug-ins that live in the web process.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
ademar.reis@openbossa.org [Mon, 16 May 2011 14:49:17 +0000 (14:49 +0000)]
2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Tools.pro misses include(common.pri)
        https://bugs.webkit.org/show_bug.cgi?id=60883

        It includes features.pri, which depends on common.pri (the build is
        not broken today with the default options, but this is the right
        thing to do).

        * Tools.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip failing tests.
ossy@webkit.org [Mon, 16 May 2011 14:41:47 +0000 (14:41 +0000)]
Unreviewed, skip failing tests.

* platform/mac-wk2/Skipped: Add fast/forms/focus-with-display-block.html because of missing eventSender.keyDown implementation
* platform/qt-wk2/Skipped: Add fast/js/array-sort-modifying-tostring.html to make WK2 bot green to be able to catch new regressions

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 16 May 2011 14:38:58 +0000 (14:38 +0000)]
2011-05-16  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix inspector dom action test flake.

        * inspector/elements/edit-dom-actions.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another new test that relies on parts of EventSender that WTR doesn't support
aroben@apple.com [Mon, 16 May 2011 14:26:58 +0000 (14:26 +0000)]
Skip another new test that relies on parts of EventSender that WTR doesn't support

* platform/mac-wk2/Skipped: Added fast/forms/focus-with-display-block.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a new test that relies on parts of EventSender that WTR doesn't support
aroben@apple.com [Mon, 16 May 2011 14:23:42 +0000 (14:23 +0000)]
Skip a new test that relies on parts of EventSender that WTR doesn't support

* platform/mac-wk2/Skipped: Addd
platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate results for a new Mac dragging test
aroben@apple.com [Mon, 16 May 2011 14:23:14 +0000 (14:23 +0000)]
Update results for a new Mac dragging test

This test has been failing since it was added in r86472. I don't know whether the old
results are wrong or the test is actually showing a bug. <http://webkit.org/b/60882> tracks
the failure.

* platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 16 May 2011 13:44:23 +0000 (13:44 +0000)]
2011-05-16  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Windows build fix.

        * inspector/InspectorConsoleInstrumentation.h:
        (WebCore::InspectorInstrumentation::consoleMarkTimeline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 16 May 2011 13:36:15 +0000 (13:36 +0000)]
2011-05-16  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Build fix.

        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::willStartWorkerContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 16 May 2011 13:27:38 +0000 (13:27 +0000)]
2011-05-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: use InstrumentingAgents to access agents from InspectorInstrumentation
        https://bugs.webkit.org/show_bug.cgi?id=60624

        InspectorInstrumentation retrieves inspector agents from corresponding InstrumentingAgents
        instance. Each agent notifies InstrumentingAgents whenever it wants to receive notifications
        about changes in WebCore.

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::inspectedPageDestroyed):
        * inspector/InspectorAgent.h:
        * inspector/InspectorConsoleInstrumentation.h:
        (WebCore::InspectorInstrumentation::addMessageToConsole):
        (WebCore::InspectorInstrumentation::consoleCount):
        (WebCore::InspectorInstrumentation::startConsoleTiming):
        (WebCore::InspectorInstrumentation::stopConsoleTiming):
        (WebCore::InspectorInstrumentation::consoleMarkTimeline):
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
        (WebCore::InspectorInstrumentation::addProfile):
        (WebCore::InspectorInstrumentation::profilerEnabled):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::didClearWindowObjectInWorld):
        (WebCore::InspectorController::inspectedPage):
        * inspector/InspectorController.h:
        * inspector/InspectorDatabaseInstrumentation.h: FAST_RETURN_IF_NO_FRONTENDS macros
        is used for early return in common case when inspector is not opened. In this
        case inspector instrumentation costs one additional check of a static field.
        (WebCore::InspectorInstrumentation::didOpenDatabase):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::instrumentingAgents):
        (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
        (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
        (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
        (WebCore::InspectorInstrumentation::handleMousePressImpl):
        (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl):
        (WebCore::InspectorInstrumentation::didInstallTimerImpl):
        (WebCore::InspectorInstrumentation::didRemoveTimerImpl):
        (WebCore::InspectorInstrumentation::willCallFunctionImpl):
        (WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl):
        (WebCore::InspectorInstrumentation::willDispatchEventImpl):
        (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
        (WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
        (WebCore::InspectorInstrumentation::willFireTimerImpl):
        (WebCore::InspectorInstrumentation::willLayoutImpl):
        (WebCore::InspectorInstrumentation::willLoadXHRImpl):
        (WebCore::InspectorInstrumentation::willPaintImpl):
        (WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
        (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
        (WebCore::InspectorInstrumentation::willSendRequestImpl):
        (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
        (WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
        (WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
        (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
        (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::scriptImportedImpl):
        (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
        (WebCore::InspectorInstrumentation::loadEventFiredImpl):
        (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        (WebCore::InspectorInstrumentation::willWriteHTMLImpl):
        (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
        (WebCore::InspectorInstrumentation::consoleCountImpl):
        (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
        (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
        (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
        (WebCore::InspectorInstrumentation::addProfileImpl):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
        (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
        (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
        (WebCore::InspectorInstrumentation::didCreateWorkerImpl):
        (WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
        (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
        (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
        (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
        (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
        (WebCore::InspectorInstrumentation::networkStateChangedImpl):
        (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
        (WebCore::InspectorInstrumentation::hasFrontend):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
        (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::bindInstrumentingAgents):
        (WebCore::InspectorInstrumentation::unbindInstrumentingAgents):
        (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
        (WebCore::InspectorInstrumentation::inspectedPageDestroyed):
        (WebCore::InspectorInstrumentation::willInsertDOMNode):
        (WebCore::InspectorInstrumentation::didInsertDOMNode):
        (WebCore::InspectorInstrumentation::willRemoveDOMNode):
        (WebCore::InspectorInstrumentation::willModifyDOMAttr):
        (WebCore::InspectorInstrumentation::didModifyDOMAttr):
        (WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
        (WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
        (WebCore::InspectorInstrumentation::handleMousePress):
        (WebCore::InspectorInstrumentation::characterDataModified):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
        (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
        (WebCore::InspectorInstrumentation::didInstallTimer):
        (WebCore::InspectorInstrumentation::didRemoveTimer):
        (WebCore::InspectorInstrumentation::willCallFunction):
        (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
        (WebCore::InspectorInstrumentation::willDispatchEvent):
        (WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
        (WebCore::InspectorInstrumentation::willEvaluateScript):
        (WebCore::InspectorInstrumentation::willFireTimer):
        (WebCore::InspectorInstrumentation::willLayout):
        (WebCore::InspectorInstrumentation::willLoadXHR):
        (WebCore::InspectorInstrumentation::willPaint):
        (WebCore::InspectorInstrumentation::willRecalculateStyle):
        (WebCore::InspectorInstrumentation::applyUserAgentOverride):
        (WebCore::InspectorInstrumentation::willSendRequest):
        (WebCore::InspectorInstrumentation::continueAfterPingLoader):
        (WebCore::InspectorInstrumentation::markResourceAsCached):
        (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
        (WebCore::InspectorInstrumentation::willReceiveResourceData):
        (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
        (WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
        (WebCore::InspectorInstrumentation::continueWithPolicyDownload):
        (WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
        (WebCore::InspectorInstrumentation::didReceiveContentLength):
        (WebCore::InspectorInstrumentation::didFinishLoading):
        (WebCore::InspectorInstrumentation::didFailLoading):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorInstrumentation::scriptImported):
        (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
        (WebCore::InspectorInstrumentation::loadEventFired):
        (WebCore::InspectorInstrumentation::frameDetachedFromParent):
        (WebCore::InspectorInstrumentation::didCommitLoad):
        (WebCore::InspectorInstrumentation::willWriteHTML):
        (WebCore::InspectorInstrumentation::didUseDOMStorage):
        (WebCore::InspectorInstrumentation::willStartWorkerContext):
        (WebCore::InspectorInstrumentation::didStartWorkerContext):
        (WebCore::InspectorInstrumentation::didCreateWorker):
        (WebCore::InspectorInstrumentation::didDestroyWorker):
        (WebCore::InspectorInstrumentation::didCreateWebSocket):
        (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorInstrumentation::didCloseWebSocket):
        (WebCore::InspectorInstrumentation::networkStateChanged):
        (WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
        (WebCore::InspectorInstrumentation::hasFrontend):
        (WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
        (WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
        (WebCore::InspectorInstrumentation::instrumentingAgentsForFrame):
        (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForFrame):
        (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForPage):
        (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForContext):
        (WebCore::InspectorInstrumentation::instrumentingAgentsWithFrontendForDocument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 16 May 2011 13:18:36 +0000 (13:18 +0000)]
2011-05-16  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: simplify inspector dom actions test.

        * inspector/elements/edit-dom-actions.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Mon, 16 May 2011 12:56:57 +0000 (12:56 +0000)]
2011-05-16  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Move Resources Panel search to backend
        https://bugs.webkit.org/show_bug.cgi?id=59596

        * inspector/Inspector.json:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::decodeMainResource):
        (WebCore::InspectorPageAgent::resourceContent):
        (WebCore::cachedResourcesForFrame):
        (WebCore::InspectorPageAgent::getCookies):
        (WebCore::InspectorPageAgent::deleteCookie):
        (WebCore::createSearchRegexSource):
        (WebCore::countRegularExpressionMatches):
        (WebCore::buildObjectForSearchMatch):
        (WebCore::InspectorPageAgent::searchInResources):
        (WebCore::InspectorPageAgent::domContentEventFired):
        (WebCore::InspectorPageAgent::loadEventFired):
        (WebCore::InspectorPageAgent::frameNavigated):
        (WebCore::InspectorPageAgent::frameDetached):
        (WebCore::InspectorPageAgent::buildObjectForFrameTree):
        * inspector/InspectorPageAgent.h:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._showResourceView):
        (WebInspector.ResourcesPanel.prototype.performSearch.searchInEditedResource):
        (WebInspector.ResourcesPanel.prototype.performSearch.callback):
        (WebInspector.ResourcesPanel.prototype.performSearch):
        (WebInspector.ResourcesPanel.prototype._ensureViewSearchPerformed):
        (WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
        (WebInspector.ResourcesPanel.prototype._showSearchResult):
        (WebInspector.ResourcesPanel.prototype._resetSearchResults):
        (WebInspector.ResourcesPanel.prototype.searchCanceled):
        (WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
        (WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):
        (WebInspector.FrameTreeElement.prototype.resourceByURL):
        (WebInspector.FrameResourceTreeElement.prototype._resetSearchResults):
        (WebInspector.FrameResourceTreeElement.prototype.get searchMatchesCount):
        (WebInspector.FrameResourceTreeElement.prototype.searchMatchesFound):
        (WebInspector.ResourcesSearchController):
        (WebInspector.ResourcesSearchController.prototype.nextSearchResult):
        (WebInspector.ResourcesSearchController.prototype.previousSearchResult):
        (WebInspector.ResourcesSearchController.prototype._searchResult):
        (WebInspector.SearchResultsTreeElementsTraverser):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype.first):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype._elementHasSearchResults):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.createSearchRegex):
        (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
        (WebInspector.SourceFrame.prototype.performSearch):
        (WebInspector.SourceFrame.prototype.hasSearchResults):
        (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult):
        (WebInspector.SourceFrame.prototype.jumpToLastSearchResult):
        (WebInspector.SourceFrame.prototype.jumpToNextSearchResult):
        (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult):
        (WebInspector.SourceFrame.prototype.jumpToSearchResult):
        (WebInspector.SourceFrame.prototype._collectRegexMatches):
        * inspector/front-end/utilities.js:
        ():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 16 May 2011 12:42:32 +0000 (12:42 +0000)]
2011-05-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Darin Adler.

        CSS: Fast path for 'px' lengths should be case-insensitive.
        https://bugs.webkit.org/show_bug.cgi?id=60703

        No new tests, this is an optimization that avoids creating
        a full CSSParser to parse the value.

        * css/CSSParser.cpp:
        (WebCore::parseSimpleLengthValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Mon, 16 May 2011 12:40:59 +0000 (12:40 +0000)]
2011-05-16  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][WK2][Symbian] Shared memory implementation for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=55875

        * wtf/Platform.h: Exclude Symbian OS from USE(UNIX_DOMAIN_SOCKETS) users
2011-05-16  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][WK2][Symbian] Shared memory implementation for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=55875

        Use global chunks for sharing data between processes.
        This is an initial implementation. An outstanding issue
        is the correct way to close() the chunk in the SharedMemory d'tor
        without triggering a delete by the kernel when the ref-count
        temporarily goes to zero.

        * Platform/SharedMemory.h: platform specific handle and chunk name
        * Platform/qt/SharedMemorySymbian.cpp: Added. Native Symbian OS implementation
        using RChunk.CreateGlobal() for named chunks. The chunk name is serialized
        and sent over the IPC channel and opened by the remote process using
        RChunk.OpenGlobal().

        (WebKit::SharedMemory::Handle::Handle):
        (WebKit::SharedMemory::Handle::~Handle):
        (WebKit::SharedMemory::Handle::isNull):
        (WebKit::SharedMemory::Handle::encode):
        (WebKit::SharedMemory::Handle::decode):
        (WebKit::SharedMemory::create):
        (WebKit::SharedMemory::~SharedMemory):
        (WebKit::SharedMemory::createHandle):
        (WebKit::SharedMemory::systemPageSize):
        * Platform/unix/SharedMemoryUnix.cpp: Exclude Qt-Symbian using HAVE(UNIX_DOMAIN_SOCKETS)
        * WebKit2.pro: Add SharedMemorySymbian.cpp

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Naiem Shaik <naiem.shaik@gmail.com>
abecsi@webkit.org [Mon, 16 May 2011 12:05:01 +0000 (12:05 +0000)]
2011-05-16  Naiem Shaik  <naiem.shaik@gmail.com>

        Reviewed by Adam Barth.

        This is for fixing build break in webgl due to https://bugs.webkit.org/show_bug.cgi?id=59861
        The bug raised for fixing this is https://bugs.webkit.org/show_bug.cgi?id=60867

        No new tests. This does not change any functionality.

        * platform/graphics/gtk/GraphicsContext3DGtk.cpp:
        (WebCore::GraphicsContext3D::create):
        * platform/graphics/gtk/GraphicsContext3DInternal.cpp:
        (WebCore::GraphicsContext3DInternal::create):
        * platform/graphics/gtk/GraphicsContext3DInternal.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 May 2011 12:00:10 +0000 (12:00 +0000)]
2011-05-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: parse edited attributes by means of InspectorDOMAgent.
        https://bugs.webkit.org/show_bug.cgi?id=60807

        This change moves attribute parsing from the front-end to the backend.

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setAttribute):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.setAttribute):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 16 May 2011 10:58:27 +0000 (10:58 +0000)]
2011-05-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Switch from Vector<UChar> to StringBuilder in dom/
        https://bugs.webkit.org/show_bug.cgi?id=57843

        Incorporate comment from Darin/Andreas.

        * dom/DatasetDOMStringMap.cpp:
        (WebCore::convertAttributeNameToPropertyName): Use 'character' local, instead of charaters[i].
        (WebCore::convertPropertyNameToAttributeName): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 16 May 2011 10:51:09 +0000 (10:51 +0000)]
2011-05-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
        https://bugs.webkit.org/show_bug.cgi?id=60773

        * inspector/syntax-highlight-javascript-expected.txt:
        * inspector/syntax-highlight-javascript.html:
2011-05-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Fix SourceJavaScriptTokenizer keyword parsing
        https://bugs.webkit.org/show_bug.cgi?id=60773

        * inspector/front-end/SourceJavaScriptTokenizer.js:
        (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
        * inspector/front-end/SourceJavaScriptTokenizer.re2js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 16 May 2011 10:20:34 +0000 (10:20 +0000)]
2011-05-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        Switch from Vector<UChar> to StringBuilder in dom/
        https://bugs.webkit.org/show_bug.cgi?id=57843

        * dom/DatasetDOMStringMap.cpp:
        (WebCore::convertAttributeNameToPropertyName):
        (WebCore::convertPropertyNameToAttributeName):
        * dom/Range.cpp:
        (WebCore::Range::toString):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::scriptContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 16 May 2011 09:53:57 +0000 (09:53 +0000)]
2011-05-05  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move double click handling from TextEditor to SourceFrame.
        https://bugs.webkit.org/show_bug.cgi?id=60271

        It is SourceFrame's responsibility to check if content is editable and
        to configure TextEditor component (e.g. set editable range) when user
        tries to initiate editing.

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceSourceFrame.prototype.doubleClick):
        (WebInspector.RevisionSourceFrame.prototype.doubleClick):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.beforeTextChanged):
        (WebInspector.SourceFrame.prototype.afterTextChanged):
        (WebInspector.SourceFrame.prototype.doubleClick):
        (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
        (WebInspector.SourceFrame.prototype.commitEditing):
        (WebInspector.SourceFrame.prototype.cancelEditing):
        (WebInspector.SourceFrame.prototype._setReadOnly):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.set readOnly):
        (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._doubleClick):
        (WebInspector.TextViewer.prototype._commitEditing):
        (WebInspector.TextViewer.prototype._cancelEditing):
        (WebInspector.TextViewerDelegate.prototype.doubleClick):
        (WebInspector.TextViewerDelegate.prototype.beforeTextChanged):
        (WebInspector.TextViewerDelegate.prototype.afterTextChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Robert Hogan <robert@webkit.org>
loislo@chromium.org [Mon, 16 May 2011 09:50:41 +0000 (09:50 +0000)]
2011-05-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Yury Semikhatsky.

        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=60858

        The client may be gone when sendMessageToBackend() is called.

        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Yury Semikhatsky.

        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=60858

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 09:30:40 +0000 (09:30 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Partial revert of r86537.  FullScreenVideoQt.h can't depend on OwnPtr.h
        because moc_FullScreenVideoQt.cpp fails to include config.h.
        Apparently, having moc_FullScreenVideoQt.cpp properly include config.h
        is hard, so we're going back to manual new and delete for this class.
        Bad times.

        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        * WebCoreSupport/FullScreenVideoQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 16 May 2011 09:27:21 +0000 (09:27 +0000)]
2011-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build after r86489.

        * GNUmakefile.am: Add PluginProcess/PluginCreationParameters.cpp
        and PluginProcess/PluginCreationParameters.h to compilation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Huzaifa Sidhpurwala <huzaifas@redhat.com>
commit-queue@webkit.org [Mon, 16 May 2011 09:17:15 +0000 (09:17 +0000)]
2011-05-16  Huzaifa Sidhpurwala <huzaifas@redhat.com>

       Reviewed by Adam Barth.

       Add Huzaifa Sidhpurwala to the WebKit Security Group site.
       https://bugs.webkit.org/show_bug.cgi?id=60686

       * security/security-group-members.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=60866
barraclough@apple.com [Mon, 16 May 2011 09:08:07 +0000 (09:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60866
Evaluation order broken for empty alternatives in subpatterns

Rubber stamped by Geoff Garen.

Source/JavaScriptCore:

Reverting https://bugs.webkit.org/show_bug.cgi?id=51395

* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):

LayoutTests:

Reverted https://bugs.webkit.org/show_bug.cgi?id=51395, and added
test cases for /(|a)/ and /(a|)/, to test the evaluation order of
subpattern matches with empty alternatives.

* fast/regex/parentheses-expected.txt:
* fast/regex/script-tests/parentheses.js:
* fast/regex/script-tests/slow.js:
* fast/regex/slow-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 16 May 2011 08:25:52 +0000 (08:25 +0000)]
2011-05-16  Alejandro G. Castro  <alex@igalia.com>

        Skipped failing test, the fail already has a bug:

        [Qt][GTK] plugins/get-url-with-javascript-url.html fails
        https://bugs.webkit.org/show_bug.cgi?id=60834

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 16 May 2011 08:05:08 +0000 (08:05 +0000)]
2011-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
        https://bugs.webkit.org/show_bug.cgi?id=58223

        * configure.ac: Add configure option to enable/disable plugin
        process.
2011-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1
        https://bugs.webkit.org/show_bug.cgi?id=58223

        * GNUmakefile.am: Add new files to compilation.
        * PluginProcess/gtk/PluginControllerProxyGtk.cpp: Added.
        (WebKit::PluginControllerProxy::platformInitialize):
        (WebKit::PluginControllerProxy::platformDestroy):
        (WebKit::PluginControllerProxy::platformGeometryDidChange):
        * PluginProcess/gtk/PluginProcessGtk.cpp: Added.
        (WebKit::PluginProcess::platformInitialize):
        * UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp: Added.
        (WebKit::PluginProcessProxy::platformInitializePluginProcess):
        * WebProcess/Plugins/Netscape/gtk/PluginProxyGtk.cpp: Added.
        (WebKit::PluginProxy::needsBackingStore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 08:02:46 +0000 (08:02 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Attempt to fix the Qt build.  (Strict PassOwnPtr fix.)

        * Shared/qt/ShareableBitmapQt.cpp:
        (WebKit::ShareableBitmap::createGraphicsContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 16 May 2011 07:59:37 +0000 (07:59 +0000)]
2011-05-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace direct StringConcatenate usage, by using operator+ (again)
        https://bugs.webkit.org/show_bug.cgi?id=60700

        Oops, forgot to include plugins/ in my previous commit.

        Remove makeString() usage everywhere, instead directly use operator+.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 16 May 2011 07:56:06 +0000 (07:56 +0000)]
2011-05-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Replace direct StringConcatenate usage, by using operator+ (again)
        https://bugs.webkit.org/show_bug.cgi?id=60700

        Remove makeString() usage everywhere, instead directly use operator+.

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::reportUnsafeAccessTo):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::borderSpacingValue):
        * dom/ExceptionBase.cpp:
        (WebCore::ExceptionBase::ExceptionBase):
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::handleError):
        * html/FTPDirectoryDocument.cpp:
        (WebCore::processFileDateString):
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::count):
        (WebCore::InspectorConsoleAgent::didReceiveResponse):
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMDebuggerAgent.cpp:
        (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkIfDisplayInsecureContent):
        (WebCore::FrameLoader::checkIfRunInsecureContent):
        (WebCore::FrameLoader::shouldAllowNavigation):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::createFromSelection):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::printAccessDeniedMessage):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::CSPDirective::CSPDirective):
        (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):
        (WebCore::DOMWindow::crossDomainAccessErrorMessage):
        * page/PageSerializer.cpp:
        (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
        (WebCore::SerializerMarkupAccumulator::appendElement):
        (WebCore::PageSerializer::urlForBlankFrame):
        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageProperty):
        (WebCore::PrintContext::pageSizeAndMarginsInPixels):
        * platform/efl/PlatformKeyboardEventEfl.cpp:
        (WebCore::createKeyMap):
        (WebCore::createWindowsKeyMap):
        * platform/efl/RenderThemeEfl.cpp:
        (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime):
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::animationNameForTransition):
        * platform/graphics/brew/ImageBrew.cpp:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::animationIdentifier):
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::CGImageToDataURL):
        * platform/graphics/gtk/ImageBufferGtk.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/haiku/ImageBufferHaiku.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageToDataURL):
        * platform/network/CredentialStorage.cpp:
        (WebCore::originStringFromURL):
        * platform/network/cf/SocketStreamHandleCFNet.cpp:
        (WebCore::SocketStreamHandle::reportErrorToClient):
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::setSynchronous):
        * platform/text/wince/TextCodecWinCE.cpp:
        (WebCore::LanguageManager::LanguageManager):
        * platform/win/ClipboardUtilitiesWin.cpp:
        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::writeURL):
        * platform/win/FileSystemWin.cpp:
        (WebCore::listDirectory):
        * platform/win/LanguageWin.cpp:
        (WebCore::platformDefaultLanguage):
        * platform/win/PathWalker.cpp:
        (WebCore::PathWalker::PathWalker):
        * platform/win/SystemInfo.cpp:
        (WebCore::osVersionForUAString):
        (WebCore::windowsVersionForUAString):
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream):
        * svg/SVGAngle.cpp:
        (WebCore::SVGAngle::valueAsString):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::valueAsString):
        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::cssText):
        * svg/SVGPointList.cpp:
        (WebCore::SVGPointList::valueAsString):
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::valueAsString):
        * svg/SVGTransform.cpp:
        (WebCore::SVGTransform::valueAsString):
        * svg/SVGTransformList.cpp:
        * svg/SVGUseElement.cpp:
        (WebCore::dumpInstanceTree):
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::connect):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didFail):
        (WebCore::WebSocketChannel::appendToBuffer):
        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readServerHandshake):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 07:51:04 +0000 (07:51 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Sigh.  This code is somewhat crazy.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::openInspectorFrontend):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 07:43:22 +0000 (07:43 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Attempt to fix Qt build.  (Strict PassOwnPtr fix.)

        This patch requires some slightly fancy footwork.

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::openInspectorFrontend):
        (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-12 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 16 May 2011 07:30:04 +0000 (07:30 +0000)]
2011-05-12  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inspector console should be searchable
        https://bugs.webkit.org/show_bug.cgi?id=60711

        Search now works for Console panel. It shows number of matching console entries
        and allows to jump to the next matching console entry. Also the matches count
        is dynamically updated when new messages are added to the console.

        ResourceTreeModel and DebuggerPresentationModel now listen to console events instead
        of being called directly from ConsoleView.

        * inspector/front-end/ConsolePanel.js:
        (WebInspector.ConsolePanel):
        (WebInspector.ConsolePanel.prototype.show):
        (WebInspector.ConsolePanel.prototype.hide):
        (WebInspector.ConsolePanel.prototype.searchCanceled):
        (WebInspector.ConsolePanel.prototype.performSearch):
        (WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
        (WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
        (WebInspector.ConsolePanel.prototype._clearCurrentSearchResultHighlight):
        (WebInspector.ConsolePanel.prototype._jumpToSearchResult):
        (WebInspector.ConsolePanel.prototype._consoleMessageAdded):
        (WebInspector.ConsolePanel.prototype._consoleCleared):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.addMessage):
        (WebInspector.ConsoleView.prototype.clearMessages):
        (WebInspector.ConsoleMessage.prototype.clearHighlight):
        (WebInspector.ConsoleMessage.prototype.highlightSearchResults):
        (WebInspector.ConsoleMessage.prototype.matchesRegex):
        (WebInspector.ConsoleMessage.prototype.toMessageElement):
        (WebInspector.ConsoleCommand.prototype.clearHighlight):
        (WebInspector.ConsoleCommand.prototype.highlightSearchResults):
        (WebInspector.ConsoleCommand.prototype.matchesRegex):
        (WebInspector.ConsoleCommand.prototype.toMessageElement):
        (WebInspector.ConsoleCommand.prototype._formatCommand):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
        (WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
        * inspector/front-end/utilities.js:
        ():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 07:27:51 +0000 (07:27 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        Missing include.

        * WebCoreSupport/PopupMenuQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 07:24:01 +0000 (07:24 +0000)]
2011-05-16  Adam Barth  <abarth@webkit.org>

        [Qt] QtPlatformPlugin create methods should use PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=60873

        This change is slightly more than a build fix because the patch kind of
        spidered a bit while I was trying to fix the build the "right way."
        Hopefully nothing here is controversial.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::adjustPointForClicking):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createSelectPopup):
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        * WebCoreSupport/FullScreenVideoQt.h:
        * WebCoreSupport/NotificationPresenterClientQt.cpp:
        (WebCore::NotificationWrapper::NotificationWrapper):
        (WebCore::NotificationPresenterClientQt::displayNotification):
        * WebCoreSupport/PopupMenuQt.cpp:
        (WebCore::PopupMenuQt::PopupMenuQt):
        (WebCore::PopupMenuQt::~PopupMenuQt):
        (WebCore::PopupMenuQt::show):
        * WebCoreSupport/PopupMenuQt.h:
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createSelectInputMethod):
        (WebCore::QtPlatformPlugin::createNotificationPresenter):
        (WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):
        (WebCore::QtPlatformPlugin::createTouchModifier):
        (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
        * WebCoreSupport/QtPlatformPlugin.h:
        (WebCore::QtPlatformPlugin::QtPlatformPlugin):
2011-05-16  Adam Barth  <abarth@webkit.org>

        [Qt] QtPlatformPlugin create methods should use PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=60873

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::platformStart):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=60860
barraclough@apple.com [Mon, 16 May 2011 07:21:01 +0000 (07:21 +0000)]
Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=60860
Simplify backtracking in YARR JIT

Reviewed by Geoff Garen & Michael Saboff.

YARR JIT currently performs a single pass of code generation over the pattern,
with special handling to allow the code generation for some backtracking code
out of line. We can simplify things by moving to a common mechanism whereby all
forwards matching code is generated in one pass, and all backtracking code is
generated in another. Backtracking code can be generated in reverse order, to
optimized the common fall-through case.

To make it easier to walk over the pattern, we can first convert to a more
byte-code like format before JIT generating. In time we should unify this with
the YARR interpreter to more closely unify the two.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::jumpIfNoAvailableInput):
(JSC::Yarr::YarrGenerator::YarrOp::YarrOp):
(JSC::Yarr::YarrGenerator::BacktrackingState::BacktrackingState):
(JSC::Yarr::YarrGenerator::BacktrackingState::append):
(JSC::Yarr::YarrGenerator::BacktrackingState::fallthrough):
(JSC::Yarr::YarrGenerator::BacktrackingState::link):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkTo):
(JSC::Yarr::YarrGenerator::BacktrackingState::takeBacktracksToJumpList):
(JSC::Yarr::YarrGenerator::BacktrackingState::isEmpty):
(JSC::Yarr::YarrGenerator::BacktrackingState::linkDataLabels):
(JSC::Yarr::YarrGenerator::BacktrackingState::ReturnAddressRecord::ReturnAddressRecord):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::backtrackAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateTerm):
(JSC::Yarr::YarrGenerator::backtrackTerm):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileAlternative):
(JSC::Yarr::YarrGenerator::opCompileBody):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=60860
Add layout tests for some regular expressions that used to crash the compiler.

Reviewed by Geoff Garen & Michael Saboff.

* fast/regex/parentheses-expected.txt:
* fast/regex/script-tests/parentheses.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 16 May 2011 07:07:50 +0000 (07:07 +0000)]
2011-05-06  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        media/video-volume-slider.html causes GTK 64 bit debug bot to time out
        https://bugs.webkit.org/show_bug.cgi?id=60055

        * media/video-volume-slider.html: Use the shadow DOM tree to
        locate the mute button and get its coordinates. This test is now
        more port-agnostic.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 16 May 2011 07:01:28 +0000 (07:01 +0000)]
2011-05-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Darin Adler.

        Move mediaControlsButtonCoordinates() out of video-test.js
        https://bugs.webkit.org/show_bug.cgi?id=60693

        Moved the function to a new js file called media-controls.js. Also
        made the function throw an exception if the button is not found
        and handle the exception in the various tests using the function.

        * media/audio-delete-while-step-button-clicked.html:
        * media/media-controls.js: Added.
        (mediaControlsButtonCoordinates):
        * media/video-controls-transformed.html:
        * media/video-controls-visible-audio-only.html:
        * media/video-controls-zoomed.html:
        * media/video-test.js:
        (isInTimeRanges):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 06:52:23 +0000 (06:52 +0000)]
2011-05-15  Adam Barth  <abarth@webkit.org>

        Attempt to fix the Qt build.  (Strict PassOwnPtr fix.)

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::detachCurrentPage):
        (QGraphicsWebView::setPage):
        * Api/qwebpage.cpp:
        (QWebPage::setView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 06:46:33 +0000 (06:46 +0000)]
2011-05-15  Adam Barth  <abarth@webkit.org>

        Attempt to fix Qt build.  (Strict PassOwnPtr fix.)

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQt::GraphicsLayerQt):
        (WebCore::GraphicsLayer::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 06:41:08 +0000 (06:41 +0000)]
2011-05-15  Adam Barth  <abarth@webkit.org>

        Attempt to fix Qt build.  (Strict PassOwnPtr fix.)

        * platform/text/qt/TextCodecQt.cpp:
        (WebCore::newTextCodecQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 06:36:56 +0000 (06:36 +0000)]
2011-05-15  Adam Barth  <abarth@webkit.org>

        Attempt to fix Qt build.  (Strict PassOwnPtr fix.)

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyWrapper::release):
        (WebCore::QNetworkReplyWrapper::receiveMetaData):
        (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
        (WebCore::QNetworkReplyHandler::release):
        (WebCore::QNetworkReplyHandler::finish):
        (WebCore::QNetworkReplyHandler::redirect):
        (WebCore::QNetworkReplyHandler::start):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 06:30:58 +0000 (06:30 +0000)]
2011-05-15  Adam Barth  <abarth@webkit.org>

        Attempt to fix Qt build.  (Strict PassOwnPtr fix.)

        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::doEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 16 May 2011 06:21:15 +0000 (06:21 +0000)]
2011-05-15  Adam Barth  <abarth@webkit.org>

        Enable strict PassOwnPtr on Qt.  (Build fixes to follow.)

        * wtf/PassOwnPtr.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 16 May 2011 06:15:01 +0000 (06:15 +0000)]
2011-05-15  MORITA Hajime  <morrita@google.com>

        Unreviewed an expectation update.

        * platform/gtk/fast/html/details-add-child-2-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Kenichi Ishibashi <bashi@chromium.org>
commit-queue@webkit.org [Mon, 16 May 2011 05:59:46 +0000 (05:59 +0000)]
2011-05-15  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        <output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
        https://bugs.webkit.org/show_bug.cgi?id=60602

        Add a test that ensures <output>, <meter> and <progress> are not focused.
        Add tabindex attributes to <progress> elements in progressbar.html so that these elements can be focused.

        * fast/forms/focus-with-display-block-expected.txt: Added.
        * fast/forms/focus-with-display-block.html: Added.
        * platform/mac/accessibility/progressbar.html: Added tabindex attributes to progress elements.
2011-05-15  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        <output>, <meter> and <progress> elements with display:block can be focused if you try to tab to it
        https://bugs.webkit.org/show_bug.cgi?id=60602

        HTMLFormControlElement::isFocusable() returns true when the element is
        visible as a block element.  However, for output, meter, and progress
        elements, the function should not return true unless they have
        tabindex attributes.  Override supportsFocus() of these elements to
        apply the result of Node::supportsFocus() because it takes care of
        whether the element has tabindex or not.

        Test: fast/forms/focus-with-display-block.html

        * html/HTMLFormControlElement.h: Made supportsFocus() protected.
        * html/HTMLMeterElement.cpp:
        (WebCore::HTMLMeterElement::supportsFocus): Added.
        * html/HTMLMeterElement.h:
        * html/HTMLOutputElement.cpp:
        (WebCore::HTMLOutputElement::supportsFocus): Added.
        * html/HTMLOutputElement.h:
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::supportsFocus): Added.
        * html/HTMLProgressElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMissing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCor...
jonlee@apple.com [Mon, 16 May 2011 05:44:49 +0000 (05:44 +0000)]
Missing migration from Editor::TextCheckingOptions to TextCheckingType in SpellingCorrectionController.cpp
https://bugs.webkit.org/show_bug.cgi?id=60870

Reviewed by Dan Bernstein.

* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::correctionPanelTimerFired): Migrating to using TextCheckingType

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Mon, 16 May 2011 05:31:12 +0000 (05:31 +0000)]
2011-05-15  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Suboptimal lifetime of BackingStore objects in DrawingAreaProxyImpl
        https://bugs.webkit.org/show_bug.cgi?id=60864

        Implemented reuse of BackingStore's in
        DrawingAreaProxyImpl::didUpdateBackingStoreState when the size needed
        matches the size of the existing BackingStore.
        Also reduced the discardBackingStoreTimer from 5 to 2 seconds.
        These changes reduces memory usage up to 10MB on memory tests.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
        (WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 16 May 2011 05:10:02 +0000 (05:10 +0000)]
2011-05-15  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        https://bugs.webkit.org/show_bug.cgi?id=59699
        Global object is recreated on teardown, for no good reason

        (Another partial fix for <rdar://problem/9417875> REGRESSION: SunSpider
        ~7% slower in browser than on command line (was 17%))

        I'm basically rolling out http://trac.webkit.org/changeset/49786 because

        (a) it created this performance problem

        and

        (b) a more complete fix, which obsoletes http://trac.webkit.org/changeset/49786,
        was committed in http://trac.webkit.org/changeset/53439.

        Tested with the file attached to https://bugs.webkit.org/show_bug.cgi?id=29832.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Don't create a new window every time we destroy
        a frame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 May 2011 03:29:59 +0000 (03:29 +0000)]
2011-05-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Pass the window NPObject identifier in the plug-in creation parameters
        https://bugs.webkit.org/show_bug.cgi?id=60865

        This avoids a synchronous call when the plug-in wants to get the NPObject that
        corresponds to the window.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::initialize):
        Change this to take the PluginCreationParameters. Initialize the window NPObject.

        (WebKit::PluginControllerProxy::windowScriptNPObject):
        Just return the window NPObject; it's already been initialized.

        * PluginProcess/PluginControllerProxy.h:
        * PluginProcess/PluginCreationParameters.cpp:
        (WebKit::PluginCreationParameters::PluginCreationParameters):
        (WebKit::PluginCreationParameters::encode):
        (WebKit::PluginCreationParameters::decode):
        * PluginProcess/PluginCreationParameters.h:
        Add the window NPObject ID.

        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::createPlugin):
        Pass the creation parameters to PluginControllerProxy::initialize.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::initialize):
        Initialize the window NPObject ID.

        * WebProcess/Plugins/PluginProxy.messages.in:
        Remove the GetWindowScriptNPObject message.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-12 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 16 May 2011 02:55:17 +0000 (02:55 +0000)]
2011-05-12  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        ShadowContentElement should affect the order of renderer children
        https://bugs.webkit.org/show_bug.cgi?id=59157

        * fast/html/details-add-details-child-1.html: Added.
        * fast/html/details-add-details-child-2.html: Added.
        * fast/html/details-nested-1.html: Added.
        * fast/html/details-nested-2.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-add-child-2-expected.txt:
        * platform/mac/fast/html/details-add-details-child-1-expected.png: Added.
        * platform/mac/fast/html/details-add-details-child-1-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
        * platform/mac/fast/html/details-add-details-child-2-expected.png: Added.
        * platform/mac/fast/html/details-add-details-child-2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt.
        * platform/mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
        * platform/mac/fast/html/details-add-summary-10-expected.png: Added.
        * platform/mac/fast/html/details-nested-1-expected.png: Added.
        * platform/mac/fast/html/details-nested-1-expected.txt: Added.
        * platform/mac/fast/html/details-nested-2-expected.png: Added.
        * platform/mac/fast/html/details-nested-2-expected.txt: Added.
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/qt/fast/html/details-add-child-2-expected.txt:
        * platform/qt/fast/html/details-open2-expected.txt:
2011-05-12  MORITA Hajime  <morrita@google.com>

        ShadowContentElement should affect the order of renderer children
        https://bugs.webkit.org/show_bug.cgi?id=59157

        Introduced ShadowContentSelector to collect and forward content
        children for each ShadowContentElement. ShadowRoot collects child
        nodes of its host (we call these children "content children"), and
        the descendant ShadowContentElement pulls that these content
        children and put it under its child during
        ShadowContentElement::attach().

        Content children no longer create its renderer during its normal
        attach() phase (called "light" phase). And they create it during
        attach() as a content children instead (called "forwarded phase").
        These phases are detected by NodeRendererFactory and represented
        as NodeRendererFactory::AttachPhase value AttachContentLight and
        AttachContentForwarded.

        Tests: fast/html/details-add-details-child-1.html
               fast/html/details-add-details-child-2.html
               fast/html/details-nested-1.html
               fast/html/details-nested-2.html

        * dom/Element.cpp:
        (WebCore::Element::attach):
        (WebCore::Element::childrenChanged):
        * dom/Node.cpp:
        (WebCore::NodeRendererFactory::NodeRendererFactory):
        (WebCore::NodeRendererFactory::shouldCreateRenderer):
        (WebCore::NodeRendererFactory::nextRenderer):
        (WebCore::NodeRendererFactory::createRendererIfNeeded):
        * dom/ShadowRoot.cpp:
        (WebCore::forceReattach):
        (WebCore::ShadowContentSelector::shadowRoot):
        (WebCore::ShadowContentSelector::activeElement):
        (WebCore::ShadowContentSelector::currentInstance):
        (WebCore::ShadowContentSelector::ShadowContentSelector):
        (WebCore::ShadowContentSelector::~ShadowContentSelector):
        (WebCore::ShadowContentSelector::attachChildrenFor):
        (WebCore::ShadowContentElement::attach):
        (WebCore::ShadowRoot::recalcStyle):
        (WebCore::ShadowRoot::activeContentContainer):
        (WebCore::ShadowRoot::hostChildrenChanged):
        (WebCore::ShadowRoot::attach):
        * dom/ShadowRoot.h:
        * html/shadow/ShadowContentElement.h:
        (WebCore::ShadowContentElement::rendererIsNeeded):
        * rendering/RenderDetails.cpp:
        * rendering/RenderDetails.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-13 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 16 May 2011 02:46:12 +0000 (02:46 +0000)]
2011-05-13  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Editor::TextCheckingOptions should be replaced with TextCheckingType
        https://bugs.webkit.org/show_bug.cgi?id=57088

        Removed Editor::TextCheckingOptions and replaced it with TextCheckingTypeMask
        No new tests, no behavior change.

        * editing/Editor.cpp:
        (WebCore::Editor::replaceSelectionWithFragment):
        (WebCore::Editor::markMisspellingsAfterTypingToWord):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        (WebCore::Editor::resolveTextCheckingTypeMask):
        * editing/Editor.h:
        * platform/text/TextChecking.h: Added TextCheckingTypeShowCorrectionPanel

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 16 May 2011 01:44:22 +0000 (01:44 +0000)]
2011-05-15  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        * platform/chromium-linux/svg/custom/small-rect-scale-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/small-rect-scale-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Mon, 16 May 2011 01:35:35 +0000 (01:35 +0000)]
2011-05-15  Dominic Cooney  <dominicc@chromium.org>

        Unreviewed. Remove expectation of gc-shadow.html flakiness.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Mon, 16 May 2011 01:21:11 +0000 (01:21 +0000)]
2011-05-15  Dominic Cooney  <dominicc@chromium.org>

        Unreviewed: adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 16 May 2011 00:53:59 +0000 (00:53 +0000)]
2011-05-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        Pass the document URL and toplevel document URL when creating a plug-in
        https://bugs.webkit.org/show_bug.cgi?id=60863

        This is the first of a series of patches intended to reduce the IPC traffic
        during plug-in instantiation.

        * WebProcess/Plugins/Plugin.cpp:
        (WebKit::Plugin::Parameters::encode):
        Encode the URLs.

        (WebKit::Plugin::Parameters::decode):
        Decode the URLs.

        * WebProcess/Plugins/Plugin.h:
        Add the document and toplevel document URLs.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::createPlugin):
        Initialize the document and toplevel document URLs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 15 May 2011 23:54:51 +0000 (23:54 +0000)]
2011-05-15  Daniel Bates  <dbates@webkit.org>

        Reviewed by Chris Jerdonek.

        svn-apply can't handle Git diff that only changes executable bit
        https://bugs.webkit.org/show_bug.cgi?id=60848

        Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
        that only has an executable bit change.

        * Scripts/VCSUtils.pm:
          - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
        (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
        fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
        * Scripts/svn-apply:
        (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
        * Scripts/svn-unapply:
        (patch): Ditto.
        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
          - Updated expected results for test cases to account for numTextChunks.
          - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
          - Added test case "Git: file that only has an executable bit change".
        * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
          - Updated expected results for test cases to account for numTextChunks.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Sun, 15 May 2011 23:20:46 +0000 (23:20 +0000)]
2011-05-15  Rob Buis  <rbuis@rim.com>

        Reviewed by Eric Seidel.

        REGERSSION(r26359-26570): Points in SVG kNN correlation model do not appear in ToT
        https://bugs.webkit.org/show_bug.cgi?id=16614

        Include testcase from the bug to prevent future regression (right now we pass both full testcase
        and this reduction).

        * platform/mac/svg/custom/small-rect-scale-expected.png: Added.
        * platform/mac/svg/custom/small-rect-scale-expected.txt: Added.
        * svg/custom/small-rect-scale.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix windows build.
weinig@apple.com [Sun, 15 May 2011 23:02:17 +0000 (23:02 +0000)]
Fix windows build.

* TestWebKitAPI/win/main.cpp:
(main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed typo fix after r86509.
ossy@webkit.org [Sun, 15 May 2011 22:49:51 +0000 (22:49 +0000)]
Unreviewed typo fix after r86509.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 15 May 2011 22:41:22 +0000 (22:41 +0000)]
2011-05-15  Sam Weinig  <sam@webkit.org>

        Reviewed by David Levin.

        Make API tester more gtest friendly
        https://bugs.webkit.org/show_bug.cgi?id=60859

        * Scripts/run-api-tests:
        Numerous changes:
        - Remove logic to run tests one at a time.
        - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to
          the test runner and allow gtest to print it for us.
        - Forward stdout from the test tool to stdout, even in non-verbose runs.
        - Run test tool from the current working directory instead of the root webkit
          directory.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        Move plist to be with other bundle sources.

        * TestWebKitAPI/TestsController.cpp:
        (TestWebKitAPI::TestsController::TestsController):
        (TestWebKitAPI::TestsController::run):
        * TestWebKitAPI/TestsController.h:
        * TestWebKitAPI/mac/main.mm:
        Simplify TestController down to a single run function. We should consider removing the class
        entirely at some point.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPartial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
ggaren@apple.com [Sun, 15 May 2011 22:31:31 +0000 (22:31 +0000)]
Partial fix for <rdar://problem/9417875> REGRESSION: SunSpider ~17% slower
in browser than on command line

Reviewed by Maciej Stachowiak.

This patch fixes a few issues in generated code that could unreasonably
prolong object lifetimes.

* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage): Throw away all function code before doing
a major collection. We want to clear polymorphic caches, since they can
keep alive large object graphs that have gone "stale". For the same reason,
but to a lesser extent, we also want to clear linked functions and other
one-off caches.

This has the side-benefit of reducing memory footprint from run-once
functions, and of allowing predictions and caches that have failed to
re-specialize.

Eventually, if compilation costs rise far enough, we may want a more
limited strategy for de-specializing code without throwing it away
completely, but this works for now, and it's the simplest solution.

* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/JSFunction.cpp: Made the host function stub cache weak --
otherwise it's effectively a memory leak that can seriously fragment the
GC and JIT heaps.

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::visitChildren): Cleared up some comments that confused
me when working with this code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 15 May 2011 18:43:25 +0000 (18:43 +0000)]
2011-05-15  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Just skipping a test.

        * platform/qt/Skipped:
        inspector/console/console-long-eval-crash.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sun, 15 May 2011 17:34:10 +0000 (17:34 +0000)]
2011-05-15  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, just skipping a test.

        New test fails on some of the SnowLeopard bots.

        * platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 15 May 2011 16:57:55 +0000 (16:57 +0000)]
2011-05-15  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: chromium renderer crash at eval in console.

        https://bugs.webkit.org/show_bug.cgi?id=60616
        Renderer of inspected page is crashing when modal dialog
        has been opened via console eval and page is reloaded.

        Test: inspector/console/console-long-eval-crash.html

        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::dispatchMessageFromFrontend):
        * inspector/InspectorController.h:

2011-05-15  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: chromium renderer crash at eval in console.

        https://bugs.webkit.org/show_bug.cgi?id=60616
        Renderer of inspected page is crashing when modal dialog
        has been opened via console eval and page is reloaded.

        * inspector/console/console-long-eval-crash-expected.txt: Added.
        * inspector/console/console-long-eval-crash.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86507 268f45cc-cd09-0410-ab3c-d52691b4dbfc