WebKit.git
11 years ago2010-12-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 23 Dec 2010 01:26:29 +0000 (01:26 +0000)]
2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        This change splits out the TestRunner class into its own file.
        When we fork the code for message passing, we will create a new
        TestRunner, and this change will allow that to be more modular.

        While we're at it, split out TestInput and ResultSummary into
        their own files, to reduce the size of run_webkit_tests to
        something more managable.

        https://bugs.webkit.org/show_bug.cgi?id=51092

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

 2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt multiprocessing - start over, prepare to fork the code

        This code cleans up the signatures and implementation of the
        TestRunner class so we can easily fork it to run either the
        stable implementation or the new, unstable message-passing
        implementation. The two variants will have different
        implementations of the run_tests() method. We will switch
        between the two based on the setting for the '--worker-model'
        switch. We rename the two currently valid values to 'old-inline'
        and 'old-threads'.

        https://bugs.webkit.org/show_bug.cgi?id=51081

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Dec 2010 01:17:45 +0000 (01:17 +0000)]
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Cache snapshots of plug-ins before painting, to avoid script running during painting
        https://bugs.webkit.org/show_bug.cgi?id=51493

        When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
        or when printing), plug-ins which otherwise use the CA rendering model
        are sent a paint event. Some plug-ins may run script while handling this event,
        or out of process plug-ins may process queued requests at this time. Running
        script while inside layout or painting can have bad consequences, because it
        can result in arbitrary changes to the render tree.

        This patch avoids sending plug-ins paint events inside of painting. Instead,
        we ask the plug-ins to cache a snapshot before we paint, and then the software
        paint simply draws that snapshot.

        Requires manual test, because the bug happens when Safari does
        a page snapshot. It's not possible to tell the Test Netscape Plug-in
        to paint without laying out, making an automated test impossible.

        * manual-tests/plugins/plugin-paint-causes-layout.html: Added.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::paintContents): Notify all enclosed widgets
        that a flattening paint is going to happen.
        (WebCore::FrameView::notifyWidgetsInAllFrames): Utility method
        that tells the RenderView in all subframes to notify their widgets.

        * platform/Widget.h:
        (WebCore::Widget::notifyWidget): Generic method that can be used
        to send messages to widgets. Current messages are just 'before flattening paint'
        and 'after flattening paint'. Message has no payload.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::getRetainedWidgets):
        (WebCore::RenderView::releaseWidgets): Factor code out of updateWidgetPositions(),
        since we use it in two places now.

        (WebCore::RenderView::updateWidgetPositions): Use getRetainedWidgets() etc.
        (WebCore::RenderView::notifyWidgets): Retain all the widgets, then send
        them all the message.

        * rendering/RenderWidget.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::notifyWidget): Pass the message to the widget.

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
        draw it. Also only send the snapshot message to the plugin proxy if we
        know we're snapshotting, since even if creating the snapshot image failed,
        we still don't want to call to the plug-in.

        * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
        (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
        to cache and clear the snapshots.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 23 Dec 2010 00:55:07 +0000 (00:55 +0000)]
2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt multiprocessing - start over, prepare to fork the code

        This code cleans up the signatures and implementation of the
        TestRunner class so we can easily fork it to run either the
        stable implementation or the new, unstable message-passing
        implementation. The two variants will have different
        implementations of the run_tests() method. We will switch
        between the two based on the setting for the '--worker-model'
        switch. We rename the two currently valid values to 'old-inline'
        and 'old-threads'.

        https://bugs.webkit.org/show_bug.cgi?id=51081

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.
darin@apple.com [Thu, 23 Dec 2010 00:50:06 +0000 (00:50 +0000)]
* WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Dec 2010 00:44:56 +0000 (00:44 +0000)]
2010-12-22  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Make Speech menu items work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51504

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetWebArchive): Updated to use new-named typedef.
        * UIProcess/API/C/WKPage.cpp:
        (WKPageRunJavaScriptInMainFrame): Ditto.
        (WKPageRenderTreeExternalRepresentation): Ditto.
        (WKPageGetSourceForFrame): Ditto.
        (WKPageGetContentsAsString): Ditto.

        * UIProcess/API/mac/WKView.mm:
        (menuItem): Added. Helper function to make it easy to call menu item
        functions on arbitrary user interface items.
        (toolbarItem): Ditto.
        (-[WKView validateUserInterfaceItem:]): Added validation for startSpeaking
        and stopSpeaking commands. Reworked the code to fix a bug where
        toggleContinuousSpellChecking would always be enabled even when it should
        be disabled. Reworked the asynchronous validation code so it works for
        items other than menu items and can also handle more than one item for the
        same command. Added some comments.
        (speakString): Added. Helper function to be used as a callback when we
        get the selection or contents to speak.
        (-[WKView startSpeaking:]): Added. Uses getSelectionOrContentsAsString.
        (-[WKView stopSpeaking:]): Added.
        (-[WKView _setUserInterfaceItemState:enabled:state:]): Reworked to work
        with the changes to validateUserInterfaceItem above.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::isDisplayingMarkupDocument): Added a FIXME about
        a problem I noticed.
        (WebKit::WebFrameProxy::didCommitLoad): Tweaked argument name.
        (WebKit::WebFrameProxy::getWebArchive): Changed to use new-named typedef.
        * UIProcess/WebFrameProxy.h: Changed WebArchiveCallback to DataCallaback.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Invalidate the two callback maps since
        we only have two now.
        (WebKit::WebPageProxy::runJavaScriptInMainFrame): Changed to use merged
        maps and typedefs so we don't need a separate callback map for each function.
        (WebKit::WebPageProxy::getRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPageProxy::getSourceForFrame): Ditto.
        (WebKit::WebPageProxy::getContentsAsString): Ditto.
        (WebKit::WebPageProxy::getSelectionOrContentsAsString): Added.
        (WebKit::WebPageProxy::getWebArchiveOfFrame): Ditto.
        (WebKit::WebPageProxy::didGetContentsAsString): Ditto.
        (WebKit::WebPageProxy::didGetSelectionOrContentsAsString): Ditto.
        (WebKit::WebPageProxy::didRunJavaScriptInMainFrame): Ditto.
        (WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation): Ditto.
        (WebKit::WebPageProxy::didGetSourceForFrame): Ditto.
        (WebKit::WebPageProxy::didGetWebArchiveOfFrame): Ditto.
        (WebKit::WebPageProxy::processDidCrash): Ditto.

        * UIProcess/WebPageProxy.h: Updated for changes above.

        * UIProcess/WebPageProxy.messages.in: Added DidGetSelectionOrContentsAsString,
        GetIsSpeaking, Speak, and StopSpeaking.

        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::getIsSpeaking): Added.
        (WebKit::WebPageProxy::speak): Added.
        (WebKit::WebPageProxy::stopSpeaking): Added.

        * WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
        (WebKit::WebContextMenuClient::isSpeaking): Call WebPage instead of doing
        the work directly, so it can run in the UI process.
        (WebKit::WebContextMenuClient::speak): Ditto.
        (WebKit::WebContextMenuClient::stopSpeaking): Ditto.
        (WebKit::WebContextMenuClient::searchWithSpotlight): Added FIXME comment and
        changed code to avoid a C-style cast.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::selectionAsString): Added.
        * WebProcess/WebPage/WebFrame.h: Ditto.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeAcceleratedCompositingMode): Use sendSync in the
        modern way instead of explicitly calling WebProcess.
        (WebKit::WebPage::getSelectionOrContentsAsString): Added.
        (WebKit::WebPage::isSpeaking): Added.
        (WebKit::WebPage::speak): Added.
        (WebKit::WebPage::stopSpeaking): Added.
        * WebProcess/WebPage/WebPage.h: Added functions.

        * WebProcess/WebPage/WebPage.messages.in: Added GetSelectionOrContentsAsString.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 23 Dec 2010 00:39:13 +0000 (00:39 +0000)]
2010-12-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Symbian] Make sure OSAllocatorSymbian builds

        This patch only addresses the build problem.

        https://bugs.webkit.org/show_bug.cgi?id=51128 tracks the full
        (re)implementation of the Symbian allocator.

        * wtf/OSAllocatorSymbian.cpp:
        (WTF::OSAllocator::reserveUncommitted):
        (WTF::OSAllocator::reserveAndCommit):
        (WTF::OSAllocator::commit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
andersca@apple.com [Thu, 23 Dec 2010 00:36:07 +0000 (00:36 +0000)]
Fix build.

* Platform/mac/MachUtilities.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 23 Dec 2010 00:27:00 +0000 (00:27 +0000)]
2010-12-22  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Fix null pointer deref when restoring a lost WebGL context.
        https://bugs.webkit.org/show_bug.cgi?id=51494

        No new tests, as context restored events are not currently testable.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::initializeNewContext):
        (WebCore::WebGLRenderingContext::restoreContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Adam Bergkvist <adam.bergkvist@ericsson.com>
commit-queue@webkit.org [Thu, 23 Dec 2010 00:16:33 +0000 (00:16 +0000)]
2010-12-22  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        Reviewed by Martin Robinson.

        [GTK] Building with Blob support fails again
        https://bugs.webkit.org/show_bug.cgi?id=51392

        Build fix.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Dec 2010 00:15:24 +0000 (00:15 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Detect WebProcess crashes sooner, without waiting for ReportCrash to finish
        https://bugs.webkit.org/show_bug.cgi?id=51505

        * Platform/CoreIPC/CoreIPCMessageKinds.h:
        Add SetExceptionPort.

        * Platform/CoreIPC/mac/ConnectionMac.cpp:
        (CoreIPC::Connection::platformInvalidate):
        If we have an exception port, unregister it.

        (CoreIPC::Connection::platformInitialize):
        Set m_exceptionPort to null.

        (CoreIPC::Connection::open):
        If we have an exception port, register an event handler for it and send it over
        to the other side.

        (CoreIPC::Connection::receiveSourceEventHandler):
        Handle the SetExceptionPort message.

        (CoreIPC::Connection::exceptionSourceEventHandler):
        Receive the message, forward it to the real exception handler and call connectionDidClose.

        (CoreIPC::Connection::setShouldCloseConnectionOnMachExceptions):
        Create an exception port.

        * Platform/mac/MachUtilities.cpp:
        (machExceptionPort):
        (setMachExceptionPort):
        * Platform/mac/MachUtilities.h:
        Add helper functions for getting and setting the mach exception port.

        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didFinishLaunching):
        Call setShouldCloseConnectionOnMachExceptions on Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Thu, 23 Dec 2010 00:13:54 +0000 (00:13 +0000)]
2010-12-22  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        canHyphenate() always returns true for the default locale
        https://bugs.webkit.org/show_bug.cgi?id=51506

        No test, since this change only affects performance.

        * platform/text/cf/HyphenationCF.cpp:
        (WebCore::::createValueForNullKey): Return 0 if hyphenation is not supported for the default locale.
        (WebCore::::createValueForKey): Removed whitespace.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Wed, 22 Dec 2010 23:58:31 +0000 (23:58 +0000)]
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        Transform applied via CSSMatrix does not take full page zoom into account
        https://bugs.webkit.org/show_bug.cgi?id=24808

        The bug has been fixed with r74430 and r74451.
        These two are just the tests.

        * transforms/2d/cssmatrix-2d-zoom-expected.checksum: Added.
        * transforms/2d/cssmatrix-2d-zoom-expected.png: Added.
        * transforms/2d/cssmatrix-2d-zoom-expected.txt: Added.
        * transforms/2d/cssmatrix-2d-zoom.html: Added.
        * transforms/3d/general/cssmatrix-3d-zoom-expected.checksum: Added.
        * transforms/3d/general/cssmatrix-3d-zoom-expected.png: Added.
        * transforms/3d/general/cssmatrix-3d-zoom-expected.txt: Added.
        * transforms/3d/general/cssmatrix-3d-zoom.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Wed, 22 Dec 2010 23:47:24 +0000 (23:47 +0000)]
2010-12-22  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Update chromium archive test result url in rebaseline script.

        https://bugs.webkit.org/show_bug.cgi?id=51503

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTests that File.type returns empty string for file with invalid extension.
jianli@chromium.org [Wed, 22 Dec 2010 23:34:57 +0000 (23:34 +0000)]
Tests that File.type returns empty string for file with invalid extension.
https://bugs.webkit.org/show_bug.cgi?id=51501

Reviewed by David Levin.

* editing/pasteboard/file-input-files-access-expected.txt:
* editing/pasteboard/resources/file.invalidext: Added.
* editing/pasteboard/script-tests/file-input-files-access.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Wed, 22 Dec 2010 23:32:15 +0000 (23:32 +0000)]
2010-12-22  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        [chromium] Rebaseline chromium media/controls-styling layout test and re-enable.
        https://bugs.webkit.org/show_bug.cgi?id=51427

        * platform/chromium-linux/media/controls-styling-expected.checksum: Added.
        * platform/chromium-linux/media/controls-styling-expected.png: Added.
        * platform/chromium-mac/media/controls-styling-expected.checksum: Added.
        * platform/chromium-mac/media/controls-styling-expected.png: Added.
        * platform/chromium-mac/media/controls-styling-expected.txt: Added.
        * platform/chromium-win/media/controls-styling-expected.checksum: Added.
        * platform/chromium-win/media/controls-styling-expected.png: Added.
        * platform/chromium-win/media/controls-styling-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 22 Dec 2010 23:30:36 +0000 (23:30 +0000)]
2010-12-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move Mach message receiving code out into a new function
        https://bugs.webkit.org/show_bug.cgi?id=51502

        * Platform/CoreIPC/mac/ConnectionMac.cpp:
        (CoreIPC::readFromMachPort):
        (CoreIPC::Connection::receiveSourceEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Jeff Miller <jeffm@apple.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 23:05:17 +0000 (23:05 +0000)]
2010-12-22  Jeff Miller  <jeffm@apple.com>

        Reviewed by Sam Weinig.

        InjectedBundle methods should  use the relative URL constructor for KURL instead of the ParsedURLStringTag version
        https://bugs.webkit.org/show_bug.cgi?id=51491

        The url passed to various InjectedBundle methods is not from KURL::string(), i.e. it has not already been parsed by KURL,
        so we have to use the relative URL constructor for KURL instead of the ParsedURLStringTag version.

        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::addUserScript):
        (WebKit::InjectedBundle::addUserStyleSheet):
        (WebKit::InjectedBundle::removeUserScript):
        (WebKit::InjectedBundle::removeUserStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 22 Dec 2010 22:39:08 +0000 (22:39 +0000)]
2010-12-22  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: script name gets parsed as HTML in Call stack panel
        https://bugs.webkit.org/show_bug.cgi?id=51468

        * inspector/front-end/Placard.js:
        (WebInspector.Placard.prototype.set subtitle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 22 Dec 2010 22:22:20 +0000 (22:22 +0000)]
2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        * configure.ac: bump version to 1.3.9.

WebKit/gtk:

2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        * NEWS: update for 1.3.9 release.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 22 Dec 2010 22:11:14 +0000 (22:11 +0000)]
2010-12-22  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        MediaPlayer should look for MIME type in data: URL
        https://bugs.webkit.org/show_bug.cgi?id=51195

        If no MIME type is passed from the media element for a data: URL, try to get it from
        the URL itself.

        No new tests are possible because the MIME type is just passed to the media engine.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Wed, 22 Dec 2010 22:03:24 +0000 (22:03 +0000)]
2010-12-22  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
2010-12-22  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
        https://bugs.webkit.org/show_bug.cgi?id=51186

        Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated.

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Shane Stephens <shanestephens@google.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 21:42:13 +0000 (21:42 +0000)]
2010-12-22  Shane Stephens  <shanestephens@google.com>

        Reviewed by David Levin.

        [Chromium] SLOW lines in chromium test_expectations.txt for svg tests which are no longer slow.
        https://bugs.webkit.org/show_bug.cgi?id=51429

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: WAI-ARIA menubar role mapped to AXGroup, should be AXMenuBar
cfleizach@apple.com [Wed, 22 Dec 2010 21:34:01 +0000 (21:34 +0000)]
WebCore: WAI-ARIA menubar role mapped to AXGroup, should be AXMenuBar
https://bugs.webkit.org/show_bug.cgi?id=51488

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-menubar.html

* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):

LayoutTests: Update fast/canvas/webgl/gl-uniform-arrays.html to bring in sync with Khronos
https://bugs.webkit.org/show_bug.cgi?id=51489

Patch by Kenneth Russell <kbr@google.com> on 2010-12-22
Reviewed by David Levin.

* fast/canvas/webgl/gl-uniform-arrays-expected.txt:
* fast/canvas/webgl/gl-uniform-arrays.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove more of WebPageProxy::didCommitLoadForFrame into WebFrameProxy::didCommitLoad.
darin@apple.com [Wed, 22 Dec 2010 21:26:42 +0000 (21:26 +0000)]
Move more of WebPageProxy::didCommitLoadForFrame into WebFrameProxy::didCommitLoad.

Reviewed by Sam Weinig.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad): Added type and certificate info arguments,
and set m_MIMEType, m_isFrameSet, and m_certificateInfo.
* UIProcess/WebFrameProxy.h: Removed setMIMEType and setCertificateInfo and added
arguments to didCommitLoad.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Removed code that is now inside the
WebFrameProxy::didCommitLoad function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 22 Dec 2010 21:13:58 +0000 (21:13 +0000)]
2010-12-22  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Update fast/canvas/webgl/gl-uniform-arrays.html to bring in sync with Khronos
        https://bugs.webkit.org/show_bug.cgi?id=51489

        * fast/canvas/webgl/gl-uniform-arrays-expected.txt:
        * fast/canvas/webgl/gl-uniform-arrays.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Wed, 22 Dec 2010 21:05:15 +0000 (21:05 +0000)]
2010-12-22  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Alice Liu.

        <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
        Verified on Chrome, Safari, and IE.
        With this change, we will record memory from a parent browser window and all child processes.

        * record-memory-win/main.cpp:
        (ProcessArgs):
        (PrintUsage):
        (getMemoryInfo):
        (printProcessInfo):
        (evalProcesses):
        (UseImage):
        (QueryContinuously):
        (ElapsedTime):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 22 Dec 2010 21:05:01 +0000 (21:05 +0000)]
2010-12-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
        https://bugs.webkit.org/show_bug.cgi?id=51423

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::copyTexImage2D): Remove the isGLES2Compliant flag around format compatibility checking.
        (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
        (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat): Helper function to get bound framebuffer's color format; deal with the case of webgl's internal fbo.
        * html/canvas/WebGLRenderingContext.h:
2010-12-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
        https://bugs.webkit.org/show_bug.cgi?id=51423

        * fast/canvas/webgl/tex-input-validation-expected.txt: Add test cases for copying from webgl's internal FBO.
        * fast/canvas/webgl/tex-input-validation.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 22 Dec 2010 20:53:56 +0000 (20:53 +0000)]
2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Compilation fixes with GTK+ 2.91.7
        https://bugs.webkit.org/show_bug.cgi?id=51487

        * configure.ac: depend on GTK+ 2.91.7 when using GTK+ 3.x.

WebCore:

2010-12-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Compilation fixes with GTK+ 2.91.7
        https://bugs.webkit.org/show_bug.cgi?id=51487

        * platform/gtk/GtkVersioning.h: do not define GDK_DISPLAY for
        backwards compatibility, it's now defined again in GTK+ 3.x.
        * platform/gtk/PasteboardHelper.cpp: do not call GDK functions to
        initialize global static variables (!). These are called when the
        .so is loaded, and they now require GType to be initialized and
        will crash. Initialize them once from the ctor, which is a more
        common pattern anyway.
        (WebCore::initGdkAtoms): new method to initialize static variables.
        (WebCore::PasteboardHelper::PasteboardHelper): call it.
        * plugins/gtk/PluginViewGtk.cpp: do not include gdkconfig.h when
        using GTK+ 3.x, since it's no longer installed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Wed, 22 Dec 2010 20:53:15 +0000 (20:53 +0000)]
2010-12-22  Lucas Forschler  <lforschler@apple.com>

        Unreviewed rollout r74489, because it was missing changelog.

        * record-memory-win/main.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 22 Dec 2010 20:22:50 +0000 (20:22 +0000)]
2010-12-21  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson and Sam Weinig.

        Add a way to get a web archive in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51437

        * UIProcess/API/C/WKFrame.cpp:
        (WKFrameGetWebArchive): Added.
        (callGetWebArchiveBlockAndDispose): Added.
        (WKFrameGetWebArchive_b): Added.
        * UIProcess/API/C/WKFrame.h: Added functions above.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Clear out m_webArchiveCallbacks.
        (WebKit::WebPageProxy::getWebArchiveOfFrame): Added.
        (WebKit::WebPageProxy::didGetWebArchiveOfFrame): Added.
        (WebKit::WebPageProxy::processDidCrash): Clear out m_webArchiveCallbacks.
        * UIProcess/WebPageProxy.h: Added functions above.
        * UIProcess/WebPageProxy.messages.in: Added DidGetWebArchiveOfFrame.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::getWebArchiveOfFrame): Added.
        * WebProcess/WebPage/WebPage.h: Added function above.
        * WebProcess/WebPage/WebPage.messages.in: Added GetWebArchiveOfFrame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dirk Schulze <krit@wbekit.org>
krit@webkit.org [Wed, 22 Dec 2010 20:15:51 +0000 (20:15 +0000)]
2010-12-22  Dirk Schulze  <krit@wbekit.org>

        Reviewed by Nikolas Zimmermann.

        Cleanup SVG code according to the webkit style rules 2
        https://bugs.webkit.org/show_bug.cgi?id=51461

        Second patch to fix indention and other style issues according to the WebKit style rules in the SVG code.

        No changes of functionality, so no new tests.

        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::stringToChannel):
        * svg/SVGFEDistantLightElement.h:
        * svg/SVGFEFuncAElement.h:
        * svg/SVGFEFuncBElement.h:
        * svg/SVGFEFuncGElement.h:
        * svg/SVGFEFuncRElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::build):
        * svg/SVGFEMorphologyElement.cpp:
        * svg/SVGFEPointLightElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::findLights):
        * svg/SVGFESpotLightElement.h:
        * svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::parseViewBox):
        (WebCore::SVGFitToViewBox::isKnownAttribute):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::cssPropertyIdForSVGAttributeName):
        * svg/SVGFontFaceElement.h:
        (WebCore::SVGFontFaceElement::associatedFontElement):
        * svg/SVGFontFaceNameElement.h:
        * svg/SVGFontFaceSrcElement.cpp:
        * svg/SVGFontFaceSrcElement.h:
        * svg/SVGFontFaceUriElement.h:
        * svg/SVGForeignObjectElement.h:
        * svg/SVGGlyphElement.cpp:
        (WebCore::parseArabicForm):
        (WebCore::parseOrientation):
        * svg/SVGGlyphElement.h:
        (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
        (WebCore::SVGGlyphIdentifier::inheritedValue):
        (WebCore::SVGGlyphIdentifier::operator==):
        (WebCore::SVGGlyphElement::rendererIsNeeded):
        * svg/SVGGlyphMap.h:
        (WebCore::GlyphMapNode::GlyphMapNode):
        (WebCore::GlyphMapNode::create):
        (WebCore::SVGGlyphMap::SVGGlyphMap):
        (WebCore::SVGGlyphMap::add):
        (WebCore::SVGGlyphMap::compareGlyphPriority):
        (WebCore::SVGGlyphMap::get):
        (WebCore::SVGGlyphMap::clear):
        * svg/SVGGradientElement.cpp:
        * svg/SVGHKernElement.cpp:
        * svg/SVGHKernElement.h:
        (WebCore::SVGHKernElement::rendererIsNeeded):
        * svg/SVGImageElement.h:
        * svg/SVGImageLoader.cpp:
        * svg/SVGImageLoader.h:
        * svg/SVGLangSpace.cpp:
        (WebCore::SVGLangSpace::parseMappedAttribute):
        (WebCore::SVGLangSpace::isKnownAttribute):
        * svg/SVGLangSpace.h:
        (WebCore::SVGLangSpace::xmllang):
        * svg/SVGMetadataElement.h:
        * svg/SVGMissingGlyphElement.h:
        (WebCore::SVGMissingGlyphElement::rendererIsNeeded):
        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::cssText):
        * svg/SVGPaint.h:
        (WebCore::SVGPaint::create):
        (WebCore::SVGPaint::paintType):
        (WebCore::SVGPaint::isSVGPaint):
        * svg/SVGParserUtilities.cpp:
        * svg/SVGParserUtilities.h:
        (WebCore::isWhitespace):
        (WebCore::skipOptionalSpaces):
        (WebCore::skipOptionalSpacesOrDelimiter):
        * svg/SVGPathElement.cpp:
        * svg/SVGPathParserFactory.h:
        * svg/SVGPathSegList.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multilin...
cfleizach@apple.com [Wed, 22 Dec 2010 19:51:19 +0000 (19:51 +0000)]
AX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multiline property
https://bugs.webkit.org/show_bug.cgi?id=51481

WebCore:

Reviewed by Sam Weinig.

Support aria-multiline and use it to change the role of an ARIA "textbox"
from AXTextArea to AXTextField.

Test: platform/mac/accessibility/aria-multiline.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaIsMultiline):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
* accessibility/AccessibilityRenderObject.h:
* html/HTMLAttributeNames.in:

LayoutTests:

Reviewed by Sam Weining.

* platform/mac/accessibility/aria-multiline-expected.txt: Added.
* platform/mac/accessibility/aria-multiline.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 22 Dec 2010 19:19:08 +0000 (19:19 +0000)]
2010-12-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        CSS 2.1 failure: counter-increment-013 fails
        https://bugs.webkit.org/show_bug.cgi?id=51483

        Clamp the counter-increment property to the valid range of signed
        integers.

        Test: fast/css/counters/counter-increment-overflow.html

        * css/CSSParser.cpp:
        (WebCore::clampToSignedInteger):
        (WebCore::CSSParser::parseCounter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Dec 2010 19:11:41 +0000 (19:11 +0000)]
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Adding myself as a reviewer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agogit-svn-id: http://svn.webkit.org/repository/webkit/trunk@74489 268f45cc-cd09-0410...
lforschler@apple.com [Wed, 22 Dec 2010 19:10:06 +0000 (19:10 +0000)]
git-svn-id: svn.webkit.org/repository/webkit/trunk@74489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChanged WebKitTools to Tools.
mitz@apple.com [Wed, 22 Dec 2010 19:03:03 +0000 (19:03 +0000)]
Changed WebKitTools to Tools.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore.sln:

WebKit/win:

* WebKit.vcproj/WebKit.sln:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChanged WebKitTools to Tools in script build phases.
mitz@apple.com [Wed, 22 Dec 2010 18:56:31 +0000 (18:56 +0000)]
Changed WebKitTools to Tools in script build phases.

Rubber-stamped by Mark Rowe.

JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

* JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

* WebCore.xcodeproj/project.pbxproj:

WebKit:

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Wed, 22 Dec 2010 18:50:57 +0000 (18:50 +0000)]
2010-12-22  Chang Shu  <chang.shu@nokia.com>

        Unreviewed layout test fix.

        Revert changeset 74481: http://trac.webkit.org/changeset/74481,
        as it causes regression on layout tests.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 22 Dec 2010 18:41:21 +0000 (18:41 +0000)]
2010-12-22  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        [chromium] console-websocket-error sometimes times out
        https://bugs.webkit.org/show_bug.cgi?id=51482

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Wed, 22 Dec 2010 18:36:04 +0000 (18:36 +0000)]
2010-12-21  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Fixing crash with empty render surfaces.
        https://bugs.webkit.org/show_bug.cgi?id=51432

        Test: platform/chromium/compositing/empty-render-surface-crasher.html

        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
        (WebCore::RenderSurfaceChromium::draw):
2010-12-21  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Enabling layout tests in platform/chromium/compositing
        and adding new layout test to check for crash on empty render surfaces.
        https://bugs.webkit.org/show_bug.cgi?id=51432

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/compositing/empty-render-surface-crasher-expected.txt: Added.
        * platform/chromium/compositing/empty-render-surface-crasher.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 22 Dec 2010 18:16:43 +0000 (18:16 +0000)]
2010-12-22  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed.  Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Wed, 22 Dec 2010 18:12:26 +0000 (18:12 +0000)]
2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        TestNetscapePlugIn should use #if defined
        https://bugs.webkit.org/show_bug.cgi?id=51471

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NP_Initialize):
        (NPP_New):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 16:25:35 +0000 (16:25 +0000)]
2010-12-22  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] LayoutTests/http/tests/appcache/auth.html failed and skipped
        https://bugs.webkit.org/show_bug.cgi?id=36688

        * platform/qt/Skipped: Unskip auth.html which now passes.
        Using Qt4.7.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 22 Dec 2010 16:22:58 +0000 (16:22 +0000)]
2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.

        DevTools window should be closed explicitly because it has custom deinitialization code.

        https://bugs.webkit.org/show_bug.cgi?id=50722

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::closeRemainingWindows):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Windows-specific expected results for fast/js/large-expressions.html in order...
jberlin@webkit.org [Wed, 22 Dec 2010 15:41:28 +0000 (15:41 +0000)]
Add Windows-specific expected results for fast/js/large-expressions.html in order to get
the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51469

* platform/win/fast/js/large-expressions-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agocheck-webkit-style shouldn't complaint about underscores in variables in objective...
levin@chromium.org [Wed, 22 Dec 2010 15:31:47 +0000 (15:31 +0000)]
check-webkit-style shouldn't complaint about underscores in variables in objective C files.
https://bugs.webkit.org/show_bug.cgi?id=51452

Reviewed by Shinichiro Hamaji.

* Scripts/webkitpy/style/checkers/cpp.py:
(_FileState.__init__): Added the information to determine if a file is C or Objective C.
Using the file extension if possible but falling back to the file contents if we have a header file.
(_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
(_FileState.is_c_or_objective_c):
(check_using_std): Changed to using _FileState to determine the file type.
(check_max_min_macros): Ditto.
(check_for_null): Ditto.
(check_style): Changed the parameters to various calls since they now need _FileState
to determine the file type.
(check_language): Added the file_state parameter so it could be passed
to check_identifier_name_in_declaration.
(check_identifier_name_in_declaration): Don't warn about underscores in variables if
this is an Objective C file.
(_process_lines): Added information for the _FileState constructor (and moved the
call to a place that had the information).
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
its functionality.
(WebKitStyleTest.test_names): Add tests for underscores in Objective C files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 22 Dec 2010 14:17:19 +0000 (14:17 +0000)]
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpoint):
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::setStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::restoreBreakpoint):
        (WebCore::InspectorDebuggerAgent::clearForPageNavigation):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.remove):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.DOMBreakpoint.prototype._serializeToJSON):
        (WebInspector.JavaScriptBreakpoint):
        (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        * inspector/front-end/SourceFrame.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=51354
antti@apple.com [Wed, 22 Dec 2010 14:00:55 +0000 (14:00 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=51354
Don't block rendering and script execution on deferred stylesheets

Reviewed by Alexey Proskuryakov.

- Don't add low priority stylesheets to the document pending sheet count.
- Resolve media attribute fully for the link element stylesheet load.

Test: http/tests/local/stylesheet-and-script-load-order-media-print.html

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* html/HTMLLinkElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=51354
Don't block rendering and script execution on deferred stylesheets

Reviewed by Alexey Proskuryakov.

* http/tests/local/link-stylesheet-load-order-expected.txt:
* http/tests/local/link-stylesheet-load-order-preload-expected.txt:
* http/tests/local/resources/check-stylesheet-not-loaded.js: Added.
* http/tests/local/stylesheet-and-script-load-order-media-print-expected.txt: Added.
* http/tests/local/stylesheet-and-script-load-order-media-print.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Wed, 22 Dec 2010 13:34:08 +0000 (13:34 +0000)]
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74473.
        http://trac.webkit.org/changeset/74473
        https://bugs.webkit.org/show_bug.cgi?id=51463

        broke compilation on leopard intel release (Requested by
        podivilov on #webkit).

        * http/tests/inspector/debugger-test2.js:
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2010-12-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74473.
        http://trac.webkit.org/changeset/74473
        https://bugs.webkit.org/show_bug.cgi?id=51463

        broke compilation on leopard intel release (Requested by
        podivilov on #webkit).

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::setStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        (WebCore::InspectorController::breakpointsSettingKey):
        (WebCore::InspectorController::loadBreakpoints):
        (WebCore::InspectorController::saveBreakpoints):
        * inspector/InspectorController.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::formatBreakpointId):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::clearForPageNavigation):
        (WebCore::InspectorDebuggerAgent::md5Base16):
        (WebCore::InspectorDebuggerAgent::loadBreakpoints):
        (WebCore::InspectorDebuggerAgent::saveBreakpoints):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.jsBreakpointId):
        (WebInspector.Breakpoint.prototype.set enabled):
        (WebInspector.Breakpoint.prototype.get id):
        (WebInspector.Breakpoint.prototype.set condition):
        (WebInspector.Breakpoint.prototype.remove):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype._createDOMBreakpoint):
        (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint):
        (WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
        (WebInspector.BreakpointManager.prototype._setNativeBreakpoint):
        (WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled):
        (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint):
        (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
        (WebInspector.BreakpointManager.prototype._projectChanged):
        (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):
        (WebInspector.BreakpointManager.prototype._validateBreakpoints):
        (WebInspector.DOMBreakpoint.prototype._serializeToJSON):
        (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON):
        (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
        (WebInspector.NativeBreakpointView.prototype.set enabled):
        (WebInspector.NativeBreakpointView.prototype.remove):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.setOneTimeBreakpoint):
        (WebInspector.DebuggerModel.prototype.removeOneTimeBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.findBreakpoint):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerModel.prototype._setBreakpoint):
        (WebInspector.DebuggerModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerModel.prototype._setBreakpointOnBackend):
        (WebInspector.DebuggerModel.prototype.breakpointRestored):
        (WebInspector.DebuggerModel.prototype.pausedScript):
        (WebInspector.DebuggerModel.prototype.resumedScript):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.continueToLine):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
        (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
        (WebInspector.SourceFrame.prototype._contextMenu):
        (WebInspector.SourceFrame.prototype._mouseDown):
        (WebInspector.SourceFrame.prototype._continueToLine):
        (WebInspector.SourceFrame.prototype._setBreakpoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Andrei Popescu <andreip@google.com>
andreip@google.com [Wed, 22 Dec 2010 13:23:11 +0000 (13:23 +0000)]
2010-12-22  Andrei Popescu  <andreip@google.com>

        Unreviewed build fix.

        Fix Chromium Linux shared library build.
        [Chromium] r74431 broke the Chromium Linux shared library build
        https://bugs.webkit.org/show_bug.cgi?id=51462

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 22 Dec 2010 13:13:28 +0000 (13:13 +0000)]
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.setBreakpoint):
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2010-12-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist JavaScript breakpoints in frontend settings.
        https://bugs.webkit.org/show_bug.cgi?id=48434

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::setStickyBreakpoints):
        (WebCore::InspectorController::restoreStickyBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::restoreBreakpoint):
        (WebCore::InspectorDebuggerAgent::clearForPageNavigation):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.remove):
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.DOMBreakpoint.prototype._serializeToJSON):
        (WebInspector.JavaScriptBreakpoint):
        (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        * inspector/front-end/SourceFrame.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dirk Schulze <krit@wbekit.org>
krit@webkit.org [Wed, 22 Dec 2010 12:25:23 +0000 (12:25 +0000)]
2010-12-22  Dirk Schulze  <krit@wbekit.org>

        Reviewed by Nikolas Zimmermann.

        Cleanup SVG code according to the webkit style rules 1
        https://bugs.webkit.org/show_bug.cgi?id=51411

        First patch to fix indention and other style issues according to the WebKit style rules in the SVG code.

        No change of functionality.

        * svg/ColorDistance.cpp:
        (WebCore::ColorDistance::isZero):
        * svg/ColorDistance.h:
        * svg/ElementTimeControl.h:
        (WebCore::ElementTimeControl::~ElementTimeControl):
        * svg/LinearGradientAttributes.h:
        (WebCore::LinearGradientAttributes::LinearGradientAttributes):
        (WebCore::LinearGradientAttributes::x1):
        (WebCore::LinearGradientAttributes::y1):
        (WebCore::LinearGradientAttributes::x2):
        (WebCore::LinearGradientAttributes::y2):
        (WebCore::LinearGradientAttributes::setX1):
        (WebCore::LinearGradientAttributes::setY1):
        (WebCore::LinearGradientAttributes::setX2):
        (WebCore::LinearGradientAttributes::setY2):
        (WebCore::LinearGradientAttributes::hasX1):
        (WebCore::LinearGradientAttributes::hasY1):
        (WebCore::LinearGradientAttributes::hasX2):
        (WebCore::LinearGradientAttributes::hasY2):
        * svg/RadialGradientAttributes.h:
        (WebCore::RadialGradientAttributes::RadialGradientAttributes):
        (WebCore::RadialGradientAttributes::cx):
        (WebCore::RadialGradientAttributes::cy):
        (WebCore::RadialGradientAttributes::r):
        (WebCore::RadialGradientAttributes::fx):
        (WebCore::RadialGradientAttributes::fy):
        (WebCore::RadialGradientAttributes::setCx):
        (WebCore::RadialGradientAttributes::setCy):
        (WebCore::RadialGradientAttributes::setR):
        (WebCore::RadialGradientAttributes::setFx):
        (WebCore::RadialGradientAttributes::setFy):
        (WebCore::RadialGradientAttributes::hasCx):
        (WebCore::RadialGradientAttributes::hasCy):
        (WebCore::RadialGradientAttributes::hasR):
        (WebCore::RadialGradientAttributes::hasFx):
        (WebCore::RadialGradientAttributes::hasFy):
        * svg/SVGAngle.cpp:
        * svg/SVGAnimateColorElement.h:
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateMotionElement.cpp:
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimatedNumber.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::parseKeyTimes):
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
        (WebCore::SVGAnimationElement::updateAnimation):
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::svgAttributeChanged):
        * svg/SVGColor.h:
        (WebCore::SVGColor::create):
        (WebCore::SVGColor::createCurrentColor):
        (WebCore::SVGColor::colorType):
        (WebCore::SVGColor::setRGBColor):
        (WebCore::SVGColor::color):
        (WebCore::SVGColor::isSVGColor):
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::svgAttributeChanged):
        * svg/SVGCursorElement.h:
        * svg/SVGDescElement.h:
        (WebCore::SVGDescElement::rendererIsNeeded):
        * svg/SVGDocument.cpp:
        * svg/SVGDocument.h:
        (WebCore::SVGDocument::create):
        (WebCore::SVGDocument::isSVGDocument):
        * svg/SVGElement.h:
        (WebCore::SVGElement::isStyled):
        (WebCore::SVGElement::isStyledTransformable):
        (WebCore::SVGElement::isStyledLocatable):
        (WebCore::SVGElement::isSVG):
        (WebCore::SVGElement::isFilterEffect):
        (WebCore::SVGElement::isGradientStop):
        (WebCore::SVGElement::isTextContent):
        (WebCore::SVGElement::isValid):
        (WebCore::SVGElement::svgAttributeChanged):
        (WebCore::SVGElement::synchronizeProperty):
        (WebCore::SVGElement::supplementalTransform):
        (WebCore::SVGElement::invalidateSVGAttributes):
        (WebCore::SVGElement::rendererIsNeeded):
        (WebCore::SVGElement::needsPendingResourceHandling):
        (WebCore::SVGElement::buildPendingResource):
        * svg/SVGElementInstance.h:
        (WebCore::SVGElementInstance::create):
        (WebCore::SVGElementInstance::correspondingElement):
        (WebCore::SVGElementInstance::correspondingUseElement):
        (WebCore::SVGElementInstance::shadowTreeElement):
        (WebCore::SVGElementInstance::parentNode):
        (WebCore::SVGElementInstance::previousSibling):
        (WebCore::SVGElementInstance::nextSibling):
        (WebCore::SVGElementInstance::firstChild):
        (WebCore::SVGElementInstance::lastChild):
        (WebCore::SVGElementInstance::ownerDocument):
        (WebCore::SVGElementInstance::toNode):
        (WebCore::SVGElementInstance::toSVGElementInstance):
        (WebCore::SVGElementInstance::hasChildNodes):
        (WebCore::SVGElementInstance::setFirstChild):
        (WebCore::SVGElementInstance::setLastChild):
        (WebCore::SVGElementInstance::setNextSibling):
        (WebCore::SVGElementInstance::setPreviousSibling):
        (WebCore::SVGElementInstance::refEventTarget):
        (WebCore::SVGElementInstance::derefEventTarget):
        * svg/SVGElementInstanceList.h:
        (WebCore::SVGElementInstanceList::create):
        * svg/SVGException.h:
        (WebCore::SVGException::create):
        (WebCore::SVGException::SVGException):
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::build):
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::findLights):
        * svg/SVGFont.cpp:
        (WebCore::convertEmUnitToPixel):
        * svg/SVGUseElement.cpp:
        (WebCore::isDirectReference):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Andrei Popescu <andreip@google.com>
andreip@google.com [Wed, 22 Dec 2010 12:17:38 +0000 (12:17 +0000)]
2010-12-22  Andrei Popescu  <andreip@google.com>

        Unreviewed buildfix.

        [v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402
        https://bugs.webkit.org/show_bug.cgi?id=51391

        * platform/chromium-mac/fast/js/large-expressions-expected.txt:
        * platform/chromium-win/fast/js/large-expressions-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 11:38:33 +0000 (11:38 +0000)]
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=51289
        Initial state of checkValidity() and :invalid are incorrect with <select required>

        * fast/css/pseudo-valid-007-expected.txt:
        * fast/css/pseudo-valid-007.html:
        * fast/forms/checkValidity-002-expected.txt:
        * fast/forms/checkValidity-002.html:
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=51289
        Initial state of checkValidity() and :invalid are incorrect with <select required>

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::childrenChanged): setNeedsValidityCheck() after <select>'s children change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 22 Dec 2010 11:05:23 +0000 (11:05 +0000)]
2010-12-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Styles pane fails to display properties from a broken CSS rule correctly
        https://bugs.webkit.org/show_bug.cgi?id=51405

        * inspector/styles-new-API-expected.txt:
        * inspector/styles-new-API.html:
2010-12-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Styles pane fails to display properties from a broken CSS rule correctly
        https://bugs.webkit.org/show_bug.cgi?id=51405

        Invoke markPropertyStart() after the parser has restored after an error.

        * css/CSSGrammar.y:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 22 Dec 2010 08:50:51 +0000 (08:50 +0000)]
2010-12-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Sets default user agent
        https://bugs.webkit.org/show_bug.cgi?id=47903

        Add macros for WebKit EFL and User Agent.

        * cmake/OptionsEfl.cmake:
        * cmakeconfig.h.cmake:
2010-12-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Sets default user agent
        https://bugs.webkit.org/show_bug.cgi?id=47903

        If applcation(e.g EWebLauncher) doesn't set user agent, WebKit EFL doesn't
        set user agent. However, we need to set user agent by default. Because, some
        web sites send different pages according to user agent.

        * ewk/ewk_private.h:
        * ewk/ewk_settings.cpp:
        (_ewk_settings_webkit_platform):
        (_ewk_settings_webkit_os_version):
        (ewk_settings_default_user_agent_get):
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-22 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Wed, 22 Dec 2010 08:37:48 +0000 (08:37 +0000)]
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Assertion failure with <select multiple required>
        https://bugs.webkit.org/show_bug.cgi?id=51260

        * fast/forms/resources/select-live-pseudo-selectors.js:
        * fast/forms/select-live-pseudo-selectors-expected.txt:
2010-12-22  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Assertion failure with <select multiple required>
        https://bugs.webkit.org/show_bug.cgi?id=51260

        Test: fast/css/pseudo-valid-select-click.html

        * dom/SelectElement.cpp: updateValidity() after selecting some options of ListBox-typed <select> elements to update valid() cache.
        (WebCore::SelectElement::updateListBoxSelection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed correction to unreviewed build fix for r74447.
darin@apple.com [Wed, 22 Dec 2010 07:16:32 +0000 (07:16 +0000)]
Unreviewed correction to unreviewed build fix for r74447.

Inappropriate code was left behind in sourceURI function for non-Dashboard platforms.

* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI): Change the logic so all the bug-workaround
logic is inside the #ifdef.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Wed, 22 Dec 2010 06:20:06 +0000 (06:20 +0000)]
2010-12-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74462.
        http://trac.webkit.org/changeset/74462
        https://bugs.webkit.org/show_bug.cgi?id=51449

        broke chromium win (Requested by tonyg-cr on #webkit).

        * JavaScriptCore.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 22 Dec 2010 05:58:31 +0000 (05:58 +0000)]
2010-12-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Include the shadow color space as part of the GraphicsContext state
        https://bugs.webkit.org/show_bug.cgi?id=51420

        Include the ColorSpace for the shadow color as part of the graphics
        state. This will be used later for a shadow implementation that
        does not rely on platform shadow code.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setShadow):
        (WebCore::GraphicsContext::clearShadow):
        (WebCore::GraphicsContext::getShadow):
        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
        (WebCore::Font::drawComplexText):
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleDrawTextShadow):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::drawGDIGlyphs):
        (WebCore::Font::drawGlyphs):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::drawText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 22 Dec 2010 05:56:00 +0000 (05:56 +0000)]
2010-12-21  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        [chromium] Build fix after r74431
        https://bugs.webkit.org/show_bug.cgi?id=51447

        * JavaScriptCore.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 26276 - Need a mechanism to determine stack extent
barraclough@apple.com [Wed, 22 Dec 2010 05:55:02 +0000 (05:55 +0000)]
Bug 26276 - Need a mechanism to determine stack extent

Reviewed by Oliver Hunt.

Correctly measuring available stack increases the size of expression we can handle!

* fast/js/large-expressions-expected.txt:
* fast/js/script-tests/large-expressions.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Siddharth Mathur <siddharth.mathur@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 22 Dec 2010 05:40:36 +0000 (05:40 +0000)]
2010-12-21  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [WK2] Guard gcc-specific syntax

        * WebKit2.pro: Non-gcc based compliers choke on the "-include"
        syntax for preinclude, make sure it has guard around it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Dan Bernstein <mitz@apple.com>
tonyg@chromium.org [Wed, 22 Dec 2010 05:09:14 +0000 (05:09 +0000)]
2010-12-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8668230> REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
        https://bugs.webkit.org/show_bug.cgi?id=51413

        * platform/mac/security/block-test-expected.txt: Reverted r71884.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix.
barraclough@apple.com [Wed, 22 Dec 2010 05:09:09 +0000 (05:09 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix.
barraclough@apple.com [Wed, 22 Dec 2010 04:54:44 +0000 (04:54 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative build fix.
barraclough@apple.com [Wed, 22 Dec 2010 04:39:53 +0000 (04:39 +0000)]
Speculative build fix.

* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::underMemoryPressure):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 26276 - Need a mechanism to determine stack extent
barraclough@apple.com [Wed, 22 Dec 2010 04:29:33 +0000 (04:29 +0000)]
Bug 26276 - Need a mechanism to determine stack extent

Reviewed by Oliver Hunt.

This patch adds accurate stack size calculation for:
    DARWIN, QNX, UNIX
We still need to fix:
    WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE

* wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Geoff Garen.
barraclough@apple.com [Wed, 22 Dec 2010 04:18:58 +0000 (04:18 +0000)]
 Reviewed by Geoff Garen.

<rdar://problem/8765333> CRASH running out of executable memory, loading io9.com
https://bugs.webkit.org/show_bug.cgi?id=51443

The problem here is that each page uses a reasonable amount of memory, (~4Mb),
and that when miultiple pages are open we keep all JIT code for all functions
in all pages alive.

Add a check to detect high memory pressure situations in the executable allocator
(>50% of available memory allocated), and upon a top level entry into JSC (no code
running on the stack) in this situation throw away all JIT code.

* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): stop passing exec to recompile.
* jit/ExecutableAllocator.h:
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutablePool::systemAlloc): Count allocations.
(JSC::ExecutablePool::systemRelease): Count deallocations.
(JSC::ExecutablePool::underMemoryPressure): Check memory pressure.
* jit/ExecutableAllocatorPosix.cpp:
(JSC::ExecutablePool::underMemoryPressure): Stub out; only meaningful with FixedVMPool.
* jit/ExecutableAllocatorWin.cpp:
(JSC::ExecutablePool::underMemoryPressure): Stub out; only meaningful with FixedVMPool.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::recompile): Remove ExecState argument to recompile.
* runtime/Executable.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::recompileAllJSFunctions): throws away all JIT code.
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.h:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): add check / call to throw away.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Wed, 22 Dec 2010 04:10:36 +0000 (04:10 +0000)]
2010-12-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8668230> REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
        https://bugs.webkit.org/show_bug.cgi?id=51413

        71884 was wrong in moving willSendRequest to ResourceLoader::start(). It’s wrong to do all the
        scheduling, which is host-dependent, before calling willSendRequest, because the latter can
        change the host.

        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::create): Check the return value from ResourceLoader::init()
        and return 0 if it is false.
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::init): Made this function return a boolean. Moved the call to willSendRequest()
        from start() into here. Return false if willSendRequest() canceled the request.
        (WebCore::ResourceLoader::start): Moved the call to willSendRequest() from here to init().
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create): Check the return value from ResourceLoader::init()
        and return 0 if it is false.
2010-12-21  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8668230> REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
        https://bugs.webkit.org/show_bug.cgi?id=51413

        * platform/mac/security/block-test-expected.txt: Reverted r71884.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Wed, 22 Dec 2010 03:44:54 +0000 (03:44 +0000)]
2010-12-21  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Darin Adler.

        Shift-End does not select to the end of the line
        https://bugs.webkit.org/show_bug.cgi?id=50610

        Add regression test that shift-end selects to the end of the line for both LTR and RTL text.
        Rebaseline a test which assumed incorrect behaviour of shift-end not selecting to the end of
        the line, but rather moving cursor to the start of the line above.

        * editing/selection/extend-selection-home-end-expected.txt: New baseline.
        * editing/selection/extend-to-line-boundary-expected.txt: Added.
        * editing/selection/extend-to-line-boundary.html: Added.
        * platform/win/editing/selection/extend-selection-home-end-expected.txt: New baseline.
2010-12-21  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Darin Adler.

        Shift-End does not select to the end of the line
        https://bugs.webkit.org/show_bug.cgi?id=50610

        Let the VisiblePosition affinity for end of line selection to be set by
        visibleEnd/visibleStart rather than using end/start and always using UPSTREAM.

        Test: editing/selection/extend-to-line-boundary.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::positionForPlatform): Use visibleStart/visibleEnd rather than
        start/end.
        (WebCore::SelectionController::modifyExtendingForward): Don't explicitly use UPSTREAM affinity.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Jan Erik Hanssen <jhanssen@sencha.com>
ariya@webkit.org [Wed, 22 Dec 2010 03:42:38 +0000 (03:42 +0000)]
2010-12-21  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Simon Fraser.

        matrix3d() must take the zoom factor into account
        https://bugs.webkit.org/show_bug.cgi?id=51408

        * transforms/3d/general/matrix-with-zoom-3d-expected.checksum: Added.
        * transforms/3d/general/matrix-with-zoom-3d-expected.png: Added.
        * transforms/3d/general/matrix-with-zoom-3d-expected.txt: Added.
        * transforms/3d/general/matrix-with-zoom-3d.html: Added.
2010-12-21  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Simon Fraser.

        matrix3d() must take the zoom factor into account
        https://bugs.webkit.org/show_bug.cgi?id=51408

        Test: transforms/3d/general/matrix-with-zoom-3d.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::createTransformOperations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Andy Estes <aestes@apple.com>
aestes@apple.com [Wed, 22 Dec 2010 03:25:34 +0000 (03:25 +0000)]
2010-12-21  Andy Estes  <aestes@apple.com>

        Reviewed by Mark Rowe.

        Do not build non-Intel architectures for WebKit2-related projects.
        https://bugs.webkit.org/show_bug.cgi?id=51440

        * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
        * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
        * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 22 Dec 2010 03:10:05 +0000 (03:10 +0000)]
2010-12-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Move V8 to common implementation of window.open
        https://bugs.webkit.org/show_bug.cgi?id=51385

        I also changed some function names to match WebKit style.  There's a
        bunch of code we can remove in the generic bindings now.  I'll do that
        in the next patch.

        * bindings/generic/BindingDOMWindow.h:
        (WebCore::::open):
        * bindings/generic/BindingFrame.h:
        (WebCore::::navigateIfAllowed):
        * bindings/generic/BindingSecurity.h:
        (WebCore::::canAccessWindow):
        (WebCore::::allowPopUp):
        (WebCore::::shouldAllowNavigation):
        * bindings/generic/GenericBinding.h:
        (WebCore::completeURL):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::toLexicalFrame):
        (WebCore::toDynamicFrame):
        * bindings/js/specialization/JSBindingState.cpp:
        (WebCore::::activeFrame):
        (WebCore::::firstFrame):
        * bindings/js/specialization/JSBindingState.h:
        * bindings/v8/V8Utilities.cpp:
        (WebCore::callingOrEnteredFrame):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::locationAccessorSetter):
        (WebCore::V8DOMWindow::openCallback):
        * bindings/v8/specialization/V8BindingState.cpp:
        (WebCore::::activeWindow):
        (WebCore::::firstWindow):
        (WebCore::::activeFrame):
        (WebCore::::firstFrame):
        * bindings/v8/specialization/V8BindingState.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Dec 2010 02:40:36 +0000 (02:40 +0000)]
2010-12-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed build fix for r74447.

        Call usesDashboardBackwardCompatibilityMode() only if DASHBOARD_SUPPORT is enabled.

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::sourceURI):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: <rdar://problem/8725702> REGRESSION (r68854): Broken image icon seen in...
mitz@apple.com [Wed, 22 Dec 2010 02:19:53 +0000 (02:19 +0000)]
WebCore: <rdar://problem/8725702> REGRESSION (r68854): Broken image icon seen in the Address Book Dashboard widget

Reviewed by John Sullivan.

Test: platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html

The Address Book widget sets the src attribute of an img element to a string that looks like a CSS
URL value. This used to work prior to r68854, because some DOM attribute parsing functions were using
the wrong function to parse URL attributes (last named deprecatedParseURL).

* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::sourceURI): In Dashboard, check if the src attribute begins with 'url("'
and ends with '")', and if so, strip those away.

LayoutTests: <rdar://problem/8725702> REGRESSION(r68854): Broken image icon seen in the Address Book Dashboard widget

Reviewed by John Sullivan.

* platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk-expected.txt: Added.
* platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html: Added.
* platform/mac/fast/dom/HTMLImageElement/resources: Added.
* platform/mac/fast/dom/HTMLImageElement/resources/blue_rect.jpg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Darin Adler.
cwzwarich@webkit.org [Wed, 22 Dec 2010 02:16:06 +0000 (02:16 +0000)]
Reviewed by Darin Adler.

-[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
https://bugs.webkit.org/show_bug.cgi?id=51431
<rdar://problem/8791757>

* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
it doesn't underflow.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 22 Dec 2010 02:01:27 +0000 (02:01 +0000)]
2010-12-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Can't stop QT music on santastreefarm.com
        https://bugs.webkit.org/show_bug.cgi?id=51438
        <rdar://problem/8741152>

        Implement NPN_ConvertPoint.

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_ConvertPoint):
        Call NetscapePlugin::convertPoint.

        (WebKit::initializeBrowserFuncs):
        Only initialize NPN_ConvertPoint and NPN_PopUpContextMenu on Mac.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::convertPoint):
        Implement conversion routines.

        (WebKit::NetscapePlugin::windowAndViewFramesChanged):
        Keep track of the window and view frames, they are needed to do coordinate conversion.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Dec 2010 01:59:09 +0000 (01:59 +0000)]
2010-12-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        CharacterData needs cleanup
        https://bugs.webkit.org/show_bug.cgi?id=51426

        Extracted CharacterData::setDataAndNotify and CharacterData::updateRenderer.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Calls setDataAndUpdate.
        (WebCore::CharacterData::parserAppendData): Ditto.
        (WebCore::CharacterData::appendData): Ditto.
        (WebCore::CharacterData::insertData): Ditto.
        (WebCore::CharacterData::deleteData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.
        (WebCore::CharacterData::setDataAndUpdate): Added.
        (WebCore::CharacterData::updateRenderer): Added.
        (WebCore::CharacterData::dispatchModifiedEvent): Renamed prevValue to oldData.
        * dom/CharacterData.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>
tonyg@chromium.org [Wed, 22 Dec 2010 01:41:04 +0000 (01:41 +0000)]
2010-12-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74420.
        http://trac.webkit.org/changeset/74420
        https://bugs.webkit.org/show_bug.cgi?id=51436

        causes editing/pasteboard/paste-noscript-xhtml.xhtml to crash
        (Requested by tonyg-cr on #webkit).

        * dom/DocumentParser.cpp:
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        * html/parser/HTMLDocumentParser.h:
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 22 Dec 2010 01:34:27 +0000 (01:34 +0000)]
2010-12-21  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Enable extensions used in accelerated 2D canvas implementation
        https://bugs.webkit.org/show_bug.cgi?id=51433

        Call Extensions3D::ensureEnabled() for all supported extensions
        the accelerated 2D Canvas implementation uses. Tested with a few
        layout tests previously failing when run in Chromium due to OpenGL
        INVALID_ENUM and other errors.

        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::create):
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
        (WebCore::SharedGraphicsContext3D::supportsBGRA):
        * platform/graphics/gpu/SharedGraphicsContext3D.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/8241425> JIT executable memory excessive usage due to regex caching
barraclough@apple.com [Wed, 22 Dec 2010 01:30:12 +0000 (01:30 +0000)]
<rdar://problem/8241425> JIT executable memory excessive usage due to regex caching
https://bugs.webkit.org/show_bug.cgi?id=51434

Reviewed by Geoff Garen.

Reduce the amount of memory the RegExpCache can hold on to on iOS.
Currently the RegExpCache can hold 256 RegExp objects. If each falls into a separate
ExecutablePool, with a common size of 16Kb, this means we end up holding onto 4Mb of
memory. Firstly, we can reduce this by simply reducing the size of the cache to 32
entries. Secondly, we can use a separate set of ExecutablePools for JIT code generated
from RegExp objects. This helps in two ways (1) it increases the probability that
RegExps in the cache share the same pool, and (2) it means that a RegExp can't end
up holding on to a large ExecutablePool containing a translation of JS code.
(A RegExp could end up keeping a larger RegExp alive that happened to be sharing the
same pool, but large RegExp patterns are less common).

* runtime/JSGlobalData.h:
* runtime/RegExpCache.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 22 Dec 2010 01:08:31 +0000 (01:08 +0000)]
2010-12-21  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLRenderingContext needs to zero textures and renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=49355

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::texImage2D): Generate an INVALID_VALUE if pixels==null is passed in.
2010-12-21  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLRenderingContext needs to zero textures and renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=49355

        Test: fast/canvas/webgl/uninitialized-test.html

        * html/canvas/WebGLFramebuffer.cpp:
        (WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed.
        (WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
        * html/canvas/WebGLFramebuffer.h: Modify onAccess with an added parameter.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter.
        (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto.
        (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
        (WebCore::WebGLRenderingContext::drawArrays): Ditto.
        (WebCore::WebGLRenderingContext::drawElements): Ditto.
        (WebCore::WebGLRenderingContext::readPixels): Ditto.
        (WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.
        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::texImage2DResourceSafe): Helper function that initialize all pixels to 0.
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
        (WebCore::Canvas2DLayerChromium::updateContentsIfDirty): Use texImage2DResourceSafe.
        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::generateColorTexture): Ditto.
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::prepareToDrawLayers): Ditto.
        * platform/graphics/chromium/TextureManager.cpp:
        (WebCore::TextureManager::requestTexture): Ditto.
        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::allocateTexture): Ditto.
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::reset): Use texImage2DResourceSafe; also, only initialize depth/stencil buffer.
        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
        (WebCore::SharedGraphicsContext3D::texImage2D): Use texImage2DResourceSafe.
        * platform/graphics/gpu/Texture.cpp:
        (WebCore::Texture::create): Ditto.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::texImage2D): Generate an INVALID_VALUE if pixels==null is passed in.
2010-12-21  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLRenderingContext needs to zero textures and renderbuffers
        https://bugs.webkit.org/show_bug.cgi?id=49355

        * fast/canvas/webgl/uninitialized-test-expected.txt: Added.
        * fast/canvas/webgl/uninitialized-test.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 22 Dec 2010 01:06:34 +0000 (01:06 +0000)]
2010-12-21  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add AudioBusChromium for decoding audio file data
        https://bugs.webkit.org/show_bug.cgi?id=51430

        No new tests since audio API is not yet implemented.

        * platform/audio/chromium: Added.
        * platform/audio/chromium/AudioBusChromium.cpp: Added.
        (WebCore::createBusFromInMemoryAudioFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 22 Dec 2010 00:45:29 +0000 (00:45 +0000)]
2010-12-21  Kenneth Russell  <kbr@google.com>

        Unreviewed test expectations update. Remove the following five
        expected text differences from the chromium-gpu test expectations
        file, because these tests are now passing in DumpRenderTree (and
        Chromium with --in-process-webgl --disable-accelerated-compositing):
            canvas/philip/tests/2d.shadow.transform.2.html
            canvas/philip/tests/2d.imageData.get.source.outside.html
            fast/canvas/canvas-scale-fillRect-shadow.html
            fast/canvas/canvas-scale-fillPath-shadow.html
            fast/canvas/canvas-scale-strokePath-shadow.html

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix.
barraclough@apple.com [Wed, 22 Dec 2010 00:43:35 +0000 (00:43 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement encoding/decoding of ResourceRequest and
weinig@apple.com [Wed, 22 Dec 2010 00:37:33 +0000 (00:37 +0000)]
Implement encoding/decoding of ResourceRequest and
ResourceResponse for Windows/CFNetwork.

Reviewed by Anders Carlsson.

* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRebaseline test for r74427.
aestes@apple.com [Wed, 22 Dec 2010 00:11:06 +0000 (00:11 +0000)]
Rebaseline test for r74427.

* http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoEeeep! build fix!
barraclough@apple.com [Wed, 22 Dec 2010 00:04:31 +0000 (00:04 +0000)]
Eeeep! build fix!

* wtf/OSAllocator.h:
(WTF::OSAllocator::decommitAndRelease):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 22 Dec 2010 00:01:34 +0000 (00:01 +0000)]
2010-12-21  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add web audio spatialization resource files
        https://bugs.webkit.org/show_bug.cgi?id=50998

        No new tests since audio API is not yet implemented.

        * platform/audio/HRTFElevation.cpp:
        (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
        * platform/audio/mac/AudioBusMac.mm:
        (WebCore::AudioBus::loadPlatformResource):
        * platform/audio/resources: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T000_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T015_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T030_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T045_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T060_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T075_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T090_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T105_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T120_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T135_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T150_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T165_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T180_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T195_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T210_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T225_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T240_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T255_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T270_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T285_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T300_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T315_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T330_P345.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P000.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P015.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P030.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P045.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P060.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P075.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P090.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P315.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P330.wav: Added.
        * platform/audio/resources/IRC_Composite_C_R0195_T345_P345.wav: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOoops, fixed typo in comment.
barraclough@apple.com [Tue, 21 Dec 2010 23:56:22 +0000 (23:56 +0000)]
Ooops, fixed typo in comment.

* wtf/OSAllocator.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: Added PageAllocationAligned, a cross-platform abstraction for memory...
barraclough@apple.com [Tue, 21 Dec 2010 23:53:25 +0000 (23:53 +0000)]
JavaScriptCore: Added PageAllocationAligned, a cross-platform abstraction for memory allocations with arbitrary alignment requirements
https://bugs.webkit.org/show_bug.cgi?id=51359

Patch by Geoffrey Garen <ggaren@apple.com> on 2010-12-21
Reviewed by Gavin Barraclough & Oliver Hunt.

I think this patch fixes <rdar://problem/8107952> [5.0.1] WER crash in
Heap::allocateBlock (1902752929), and some other leaks and crashes as well.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Updated build files.

* runtime/AlignedMemoryAllocator.h: Removed. Supplanted by
PageAllocationAligned.

* runtime/Collector.cpp:
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::addWeakGCHandle):
* runtime/Collector.h: Switched from AlignedMemoryAllocator to
PageAllocationAligned.

* runtime/GCHandle.cpp:
* runtime/GCHandle.h: Ditto.

* wtf/PageAllocation.h:
(WTF::PageAllocation::PageAllocation): Removed aligned memory allocation
functions. Supplanted by PageAllocationAligned.

* wtf/PageAllocationAligned.cpp: Added.
(WTF::PageAllocationAligned::allocate):
(WTF::PageAllocationAligned::deallocate):
* wtf/PageAllocationAligned.h: Added.
(WTF::PageAllocationAligned::PageAllocationAligned): New cross-platform
class for doing aligned memory allocation. This class properly matches
allocation and deallocation library calls, fixing a long-standing bug
in PageAllocation.

* wtf/Platform.h: Removed some defunction VM platform defines.

* wtf/wtf.pri: Updated build files.

JavaScriptGlue: Added PageAllocationAligned, a cross-platform abstraction for memory allocations with arbitrary alignment requirements
https://bugs.webkit.org/show_bug.cgi?id=51359

Patch by Geoffrey Garen <ggaren@apple.com> on 2010-12-21
Reviewed by Gavin Barraclough & Oliver Hunt.

* ForwardingHeaders/wtf/PageAllocationAligned.h: Added.

WebCore: Added PageAllocationAligned, a cross-platform abstraction for memory allocations with arbitrary alignment requirements
https://bugs.webkit.org/show_bug.cgi?id=51359

Patch by Geoffrey Garen <ggaren@apple.com> on 2010-12-21
Reviewed by Gavin Barraclough & Oliver Hunt.

* ForwardingHeaders/wtf/PageAllocationAligned.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Tue, 21 Dec 2010 23:26:20 +0000 (23:26 +0000)]
2010-12-21  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=49774
        Need to scale translation values in matrix() by the zoom factor.

        * fast/transforms/matrix-with-zoom-expected.checksum: Added.
        * fast/transforms/matrix-with-zoom-expected.png: Added.
        * fast/transforms/matrix-with-zoom-expected.txt: Added.
        * fast/transforms/matrix-with-zoom.html: Added.
2010-12-21  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=49774
        Need to scale translation values in matrix() by the zoom factor.

        Test: fast/transforms/matrix-with-zoom.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::createTransformOperations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd serialization for CFURLRequestRef and CFURLResponseRef.
weinig@apple.com [Tue, 21 Dec 2010 23:19:03 +0000 (23:19 +0000)]
Add serialization for CFURLRequestRef and CFURLResponseRef.

Reviewed by Anders Carlsson.

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 21 Dec 2010 22:54:14 +0000 (22:54 +0000)]
2010-12-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        ASSERTION FAILED: base->index() == m_codeBlock->argumentsRegister() while loading taobao.com
        https://bugs.webkit.org/show_bug.cgi?id=49006

        This problem was caused by having a parameter named 'arguments'.
        The fix is to treat parameters named 'arguments' as shadowing
        the actual arguments property, and so logically turn the function
        into one that doesn't "use" arguments.

        This required a bit of fiddling in the parser to ensure we correctly
        propagate the 'feature' of shadowing is set correctly.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::createArgumentsIfNecessary):
          Change assertion to an early return as we may now reference
          a property named 'arguments' without being in a function that
          has the ArgumentsFeature
        * parser/JSParser.cpp:
        (JSC::JSParser::Scope::Scope):
        (JSC::JSParser::Scope::declareParameter):
        (JSC::JSParser::Scope::shadowsArguments):
        (JSC::JSParser::parseProgram):
        (JSC::JSParser::parseFormalParameters):
        (JSC::JSParser::parseFunctionInfo):
        * parser/Nodes.h:
        (JSC::ScopeNode::usesArguments):
2010-12-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        ASSERTION FAILED: base->index() == m_codeBlock->argumentsRegister() while loading taobao.com
        https://bugs.webkit.org/show_bug.cgi?id=49006

        Add new tests to cover the cases of a parameter named arguments being used.
        Also correct a couple of existing (incorrect) tests.

        * fast/js/arguments-expected.txt:
        * fast/js/script-tests/arguments.js:
        (argumentsVarUndefined):
        (argumentsConstUndefined):
        (shadowedArgumentsLength):
        (shadowedArgumentsCallee):
        (shadowedArgumentsIndex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Jian Li <jianli@chromium.org>
aestes@apple.com [Tue, 21 Dec 2010 22:36:48 +0000 (22:36 +0000)]
2010-12-21  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Adler.

        Fix bug 51366: REGRESSION (r66452): Form data no longer contains
        'Content-Type' header for files with unrecognized extensions
        https://bugs.webkit.org/show_bug.cgi?id=51366

        Test: http/tests/local/formdata/form-data-with-unknown-file-extension.html

        * platform/network/FormData.cpp:
        (WebCore::FormData::appendKeyValuePairItems):
2010-12-21  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Adler.

        Fix bug 51366: REGRESSION (r66452): Form data no longer contains
        'Content-Type' header for files with unrecognized extensions
        https://bugs.webkit.org/show_bug.cgi?id=51366

        * http/tests/local/formdata/form-data-with-unknown-file-extension-expected.txt: Added.
        * http/tests/local/formdata/form-data-with-unknown-file-extension.html: Added.
        * http/tests/local/resources/file.invalid: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 21 Dec 2010 22:24:45 +0000 (22:24 +0000)]
2010-12-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Mac WebKit delivers an extra didCommit when loading web archives
        https://bugs.webkit.org/show_bug.cgi?id=51419

        Could not find a simple way to test this in WebKit1, but in WebKit2
        it leads to an immediate failure when loading a web archive. Tested
        that making the Mac share the same code path with other platforms
        works fine in WebKit1.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument): Removed special case for
        the Mac platform. Also removed the call to isArchiveMimeType since we
        get a 0 from ArchiveFactory::create in that case.

        * loader/archive/ArchiveFactory.cpp:
        (WebCore::ArchiveFactory::isArchiveMimeType): Hardened slightly by
        adding a special case for null and empty strings, since hash tables can't
        handle null strings.
        (WebCore::ArchiveFactory::create): Ditto.
2010-12-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Mac WebKit delivers an extra didCommit when loading web archives
        https://bugs.webkit.org/show_bug.cgi?id=51419

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::didStartProvisionalLoad): Added assertions so we catch
        inconsistencies here instead of at the application level. Later, we will have
        to decide what to do in cases these assertions fail. The right policy is probably
        to consider it a web process failure and do whatever we do for those.
        (WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad): Ditto.
        (WebKit::WebFrameProxy::didFailProvisionalLoad): Ditto.
        (WebKit::WebFrameProxy::didCommitLoad): Ditto.
        (WebKit::WebFrameProxy::didFinishLoad): Ditto.
        (WebKit::WebFrameProxy::didFailLoad): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Snow Leopard build.
andersca@apple.com [Tue, 21 Dec 2010 21:28:31 +0000 (21:28 +0000)]
Fix Snow Leopard build.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-12-21 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 21 Dec 2010 21:22:14 +0000 (21:22 +0000)]
2010-12-21  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel and Darin Adler.

        Deallocate GregorianDateTime.timeZone (if allocated) when copying so that we don't leak memory.
        https://bugs.webkit.org/show_bug.cgi?id=51367

        Inspired by a patch by George Staikos.

        * wtf/DateMath.cpp:
        (JSC::msToGregorianDateTime): Modified to set timeZone to nullptr since timeZone is now
        of type OwnPtrArray<char>.
        * wtf/DateMath.h: Change timeZone to type OwnArrayPtr<char>; Removed destructor since it is no longer needed.
        (JSC::GregorianDateTime::GregorianDateTime): Modified to use OwnPtrArray semantics for timeZone.
        (JSC::GregorianDateTime::operator tm): Ditto.
        (JSC::GregorianDateTime::copyFrom): Ditto.
2010-12-21  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel and Darin Adler.

        Deallocate GregorianDateTime.timeZone (if allocated) when copying so that we don't leak memory.
        https://bugs.webkit.org/show_bug.cgi?id=51367

        Add forwarding header for PassOwnArrayPtr.h.

        * ForwardingHeaders/wtf/PassOwnArrayPtr.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix crash when a Carbon plug-in fails to initialize correctly
andersca@apple.com [Tue, 21 Dec 2010 21:18:56 +0000 (21:18 +0000)]
Fix crash when a Carbon plug-in fails to initialize correctly
https://bugs.webkit.org/show_bug.cgi?id=51415

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Don't claim to support the QuickDraw event model.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformDestroy):
Only try to remove the window from the map if it's not null.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74423 268f45cc-cd09-0410-ab3c-d52691b4dbfc