WebKit.git
9 years ago2011-04-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 13 Apr 2011 23:54:30 +0000 (23:54 +0000)]
2011-04-13  Tony Chang  <tony@chromium.org>

        Ignore files generated from glu.gyp.

        * .gitignore:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
luiz@webkit.org [Wed, 13 Apr 2011 23:54:03 +0000 (23:54 +0000)]
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 13 Apr 2011 23:52:15 +0000 (23:52 +0000)]
2011-04-13  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by David Hyatt.

        Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Test that 'display: block' and 'display: table' on generated :before/:after content
        within <ruby> doesn't crash.

        * fast/ruby/after-block-doesnt-crash-expected.txt: Added.
        * fast/ruby/after-block-doesnt-crash.html: Added.
        * fast/ruby/after-table-doesnt-crash-expected.txt: Added.
        * fast/ruby/after-table-doesnt-crash.html: Added.
        * fast/ruby/before-block-doesnt-crash-expected.txt: Added.
        * fast/ruby/before-block-doesnt-crash.html: Added.
        * fast/ruby/before-table-doesnt-crash-expected.txt: Added.
        * fast/ruby/before-table-doesnt-crash.html: Added.
2011-04-13  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by David Hyatt.

        Bug 55930 - Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Non-inline :before/:after generated content is now wrapped with an anonymous inline block.

        Also, added an additional check in RenderObjectChildList::updateBeforeAfterContent()
        to verify that the created render object is legal under the parent.

        Tests: fast/ruby/after-block-doesnt-crash.html
               fast/ruby/after-table-doesnt-crash.html
               fast/ruby/before-block-doesnt-crash.html
               fast/ruby/before-table-doesnt-crash.html

        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
        * rendering/RenderRuby.cpp:
        (WebCore::isAnonymousRubyInlineBlock):
        (WebCore::rubyBeforeBlock):
        (WebCore::rubyAfterBlock):
        (WebCore::createAnonymousRubyInlineBlock):
        (WebCore::lastRubyRun):
        (WebCore::RenderRubyAsInline::addChild):
        (WebCore::RenderRubyAsInline::removeChild):
        (WebCore::RenderRubyAsBlock::addChild):
        (WebCore::RenderRubyAsBlock::removeChild):
        * rendering/RenderRuby.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 13 Apr 2011 23:49:40 +0000 (23:49 +0000)]
2011-04-13  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        [CG] Refactor get/putImageData routines from ImageBufferCG into a (new) ImageBufferDataCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=58084

        No new tests. Does not affect outward behavior.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageBufferData.h: Added.
        * platform/graphics/cairo/ImageBufferData.h: Removed.
        * platform/graphics/cairo/ImageBufferDataCairo.h: Added.
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        * platform/graphics/cg/ImageBufferDataCG.cpp: Added.
        (WebCore::ImageBufferData::ImageBufferData):
        (WebCore::haveVImageRoundingErrorFix):
        (WebCore::ImageBufferData::getData):
        (WebCore::ImageBufferData::putData):
        * platform/graphics/cg/ImageBufferData.h: Removed.
        * platform/graphics/cg/ImageBufferDataCG.h: Added.
        * platform/graphics/chromium/ImageBufferData.h: Removed.
        * platform/graphics/chromium/ImageBufferDataSkia.h: Added.
        * platform/graphics/haiku/ImageBufferData.h: Removed.
        * platform/graphics/haiku/ImageBufferDataHaiku.h: Added.
        * platform/graphics/qt/ImageBufferData.h: Removed.
        * platform/graphics/qt/ImageBufferDataQt.h: Added.
        * platform/graphics/wince/ImageBufferData.h: Removed.
        * platform/graphics/wince/ImageBufferDataWince.h: Added.
        * platform/graphics/wx/ImageBufferData.h: Removed.
        * platform/graphics/wx/ImageBufferDataWx.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 13 Apr 2011 23:36:35 +0000 (23:36 +0000)]
2011-04-13  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Chris Marrin.

        Update layout test expected result files' locations
        https://bugs.webkit.org/show_bug.cgi?id=58492

        * platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt.
        * platform/mac/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 13 Apr 2011 23:33:08 +0000 (23:33 +0000)]
2011-04-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Remove std:: prefix on some min/max calls
        https://bugs.webkit.org/show_bug.cgi?id=58493

        Remove std:: namespacing on min/max in favor of a 'using' clause.

        * platform/graphics/RoundedIntRect.cpp:
        (WebCore::RoundedIntRect::Radii::expand):
        * rendering/style/RenderStyle.cpp:
        (WebCore::calcConstraintScaleFor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 13 Apr 2011 23:04:01 +0000 (23:04 +0000)]
2011-04-13  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
        https://bugs.webkit.org/show_bug.cgi?id=58489

        r83743 added --additional-platform-directory to old-run-webkit-tests,
        rename the equivalent flag in new-run-webkit-tests to be consistent.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 13 Apr 2011 23:03:34 +0000 (23:03 +0000)]
2011-04-13  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Jian Li.

        [chromium] Remove unnecessary #define now that chrome has rolled to the latest WebKit
        https://bugs.webkit.org/show_bug.cgi?id=58474

        * DEPS:
        * public/WebSpellCheckClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 13 Apr 2011 22:54:25 +0000 (22:54 +0000)]
2011-04-13  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        Rebaseline queue server
        https://bugs.webkit.org/show_bug.cgi?id=57891

        Adds a simple rebaseline queue server (meant to run at
        http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
        builders and their failing tests, and allows those tests to be added to
        a per-builer rebaseline queue.

        A subsequent change will add a mode to NRWT (and/or a wrapper script)
        for pulling the tests to be rebaselined from the server and running them
        with --reset-results (the initial use-case is for the GPU hardware bots,
        which do not have checked-in baselines, therefore there is no need for a
        check-in step yet).

        * RebaselineQueueServer/app.yaml: Added.
        * RebaselineQueueServer/handlers/__init__.py: Added.
        * RebaselineQueueServer/handlers/builderqueue.py: Added.
        * RebaselineQueueServer/handlers/pages.py: Added.
        * RebaselineQueueServer/index.yaml: Added.
        * RebaselineQueueServer/main.py: Added.
        * RebaselineQueueServer/model/__init__.py: Added.
        * RebaselineQueueServer/model/queueentry.py: Added.
        * RebaselineQueueServer/static/builder-frame-empty.html: Added.
        * RebaselineQueueServer/static/styles.css: Added.
        * RebaselineQueueServer/templates/builder-picker.html: Added.
        * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
        * RebaselineQueueServer/templates/builder-queue-list.html: Added.
        * RebaselineQueueServer/templates/home.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, more chromium test expectations update.
jianli@chromium.org [Wed, 13 Apr 2011 22:52:23 +0000 (22:52 +0000)]
Unreviewed, more chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 13 Apr 2011 22:45:36 +0000 (22:45 +0000)]
2011-04-13  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        Replace our own RenderThemeQt::getMediaElementFromRenderObject by
        MediaControlsElement::toParentMediaElement used by every other port.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMediaFullscreenButton):
        (WebCore::RenderThemeQt::paintMediaMuteButton):
        (WebCore::RenderThemeQt::paintMediaPlayButton):
        (WebCore::RenderThemeQt::paintMediaSliderTrack):
        * platform/qt/RenderThemeQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShould not rely on WKEditableLinkBehavior being in synch
enrica@apple.com [Wed, 13 Apr 2011 22:40:10 +0000 (22:40 +0000)]
Should not rely on WKEditableLinkBehavior being in synch
with WebCore::EditableLinkBehavior.
https://bugs.webkit.org/show_bug.cgi?id=58473

Reviewed by Dan Bernstein.

Adding conversion routines.

* UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
(WebKit::toEditableLinkBehavior):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 13 Apr 2011 22:38:23 +0000 (22:38 +0000)]
2011-04-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        After closing the last window, re-opening my last visited website is over 2X slower
        https://bugs.webkit.org/show_bug.cgi?id=58488
        <rdar://problem/9233518>

        Give the web process a 60 second termination timeout.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinspector/debugger/script-formatter.html broken on a bunch of platforms since introdu...
jberlin@webkit.org [Wed, 13 Apr 2011 22:29:04 +0000 (22:29 +0000)]
inspector/debugger/script-formatter.html broken on a bunch of platforms since introduction
in r83748
https://bugs.webkit.org/show_bug.cgi?id=58487

Disable the test until it is fixed to get the bots green.

* inspector/debugger/script-formatter.html: Removed.
* inspector/debugger/script-formatter.html-disabled: Copied from inspector/debugger/script-formatter.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 22:24:44 +0000 (22:24 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change / build fix. The file had
        multiple checksums which confused NRWT.

        * platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 13 Apr 2011 22:24:28 +0000 (22:24 +0000)]
2011-04-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Convert WebProcess over to using disableTermination/enableTermination
        https://bugs.webkit.org/show_bug.cgi?id=58485

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::getSitesWithData):
        (WebKit::PluginProcess::clearSiteData):
        Use the LocalTerminationDisabler RAII class.

        * Shared/ChildProcess.h:
        (WebKit::ChildProcess::LocalTerminationDisabler::LocalTerminationDisabler):
        (WebKit::ChildProcess::LocalTerminationDisabler::~LocalTerminationDisabler):
        Add RAII class for calling disableTermination/enableTermination.

        * WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
        (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
        (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
        (WebKit::WebApplicationCacheManager::deleteAllEntries):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/Cookies/WebCookieManager.cpp:
        (WebKit::WebCookieManager::getHostnamesWithCookies):
        (WebKit::WebCookieManager::deleteCookiesForHostname):
        (WebKit::WebCookieManager::deleteAllCookies):
        (WebKit::WebCookieManager::startObservingCookieChanges):
        (WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
        (WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/Downloads/Download.cpp:
        (WebKit::Download::Download):
        Call disableTermination().

        (WebKit::Download::~Download):
        Call enableTermination().

        * WebProcess/Downloads/DownloadManager.cpp:
        (WebKit::DownloadManager::downloadFinished):
        Remove call to terminateIfPossible.

        * WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
        (WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
        (WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
        (WebKit::WebKeyValueStorageManager::deleteAllEntries):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/MediaCache/WebMediaCacheManager.cpp:
        (WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
        (WebKit::WebMediaCacheManager::clearCacheForHostname):
        (WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/ResourceCache/WebResourceCacheManager.cpp:
        (WebKit::WebResourceCacheManager::getCacheOrigins):
        (WebKit::WebResourceCacheManager::clearCacheForOrigin):
        (WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
        (WebKit::WebDatabaseManager::getDatabasesByOrigin):
        (WebKit::WebDatabaseManager::getDatabaseOrigins):
        (WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
        (WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
        (WebKit::WebDatabaseManager::deleteAllDatabases):
        (WebKit::WebDatabaseManager::setQuotaForOrigin):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::createWebPage):
        Call disableTermination().

        (WebKit::WebProcess::removeWebPage):
        Call enableTermination().

        (WebKit::WebProcess::shouldTerminate):
        Move logic from terminateIfPossible over here.

        (WebKit::WebProcess::terminate):
        Move logic from terminateIfPossible over here.

        (WebKit::WebProcess::getSitesWithPluginData):
        (WebKit::WebProcess::clearPluginSiteData):
        Use the LocalTerminationDisabler RAII class.

        * WebProcess/WebProcess.h:
        Publically inherit from ChildProcess, LocalTerminationDisabler needs to be accessible
        from the WebProcess class.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 13 Apr 2011 22:15:28 +0000 (22:15 +0000)]
2011-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
        https://bugs.webkit.org/show_bug.cgi?id=58482

        This will allow wrappers to make individual decisions about their lifetimes.

        * heap/HandleHeap.h:
        (JSC::HandleHeap::copyWeak): New function for copying a weak handle.
        It's wasn't previously possible to perform this operation using HandleHeap
        API because the HandleHeap doesn't expose its underlying Node structure.

        * heap/Local.h:
        (JSC::::set):
        * heap/Strong.h:
        (JSC::Strong::set): Added ASSERTs to verify that dead objects are not
        resurrected by placement into handles.

        (JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
        is efficient.

        * heap/Weak.h:
        (JSC::Weak::Weak): Fixed a bug where copying a weak pointer would not
        copy its weak callback and context.

        (JSC::Weak::operator=): Added an assignment operator, since the default
        C++ assignment operator did the wrong thing.

        (JSC::Weak::set): Added ASSERTs to verify that dead objects are not
        resurrected by placement into handles.

        (JSC::swap): Added a swap helper, so use of Strong<T> inside a hash table
        is efficient, and can be done without copying, which is illegal during
        the handle finalization phase.
2011-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Switched DOM wrappers to use HashMap of Weak<T> instead of WeakGCMap<T>
        https://bugs.webkit.org/show_bug.cgi?id=58482

        This will allow wrappers to make individual decisions about their lifetimes.

        * bindings/js/DOMWrapperWorld.cpp:
        (WebCore::DOMWrapperWorld::DOMWrapperWorld):
        (WebCore::JSNodeHandleOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNodeHandleOwner::finalize):
        (WebCore::DOMObjectHandleOwner::isReachableFromOpaqueRoots):
        (WebCore::DOMObjectHandleOwner::finalize):
        * bindings/js/DOMWrapperWorld.h:
        (WebCore::JSNodeHandleOwner::JSNodeHandleOwner):
        (WebCore::DOMObjectHandleOwner::DOMObjectHandleOwner):
        (WebCore::DOMWrapperWorld::jsNodeHandleOwner):
        (WebCore::DOMWrapperWorld::domObjectHandleOwner): Added handle owners
        for JSNode and DOMObject, our two hash table values. For now, the owners
        just take care to remove their handles from their respective hash tables.

        Changed the hash table type to be a standard HashMap of weak pointers,
        instead of a WeakGCMap.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::getCachedDOMObjectWrapper):
        (WebCore::cacheDOMObjectWrapper):
        (WebCore::cacheDOMNodeWrapper):
        (WebCore::isObservableThroughDOM):
        (WebCore::markDOMNodesForDocument):
        (WebCore::takeWrappers):
        (WebCore::updateDOMNodeDocument):
        (WebCore::markDOMObjectWrapper):
        (WebCore::markDOMNodeWrapper): Updated wrapper hash table access to
        accomodate its new data type.

        * bindings/js/JSNodeCustom.h:
        (WebCore::getCachedDOMNodeWrapper): Ditto.

        * dom/Document.h: Updated declaration to match the above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 13 Apr 2011 22:11:30 +0000 (22:11 +0000)]
2011-04-13  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Follow-up to: WebKit2 will load two copies of the same plugin, but should not
        https://bugs.webkit.org/show_bug.cgi?id=49075

        Use pathGetFileName instead of Win32 PathFindFileNameW.

        * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
        (WebKit::PluginInfoStore::shouldUsePlugin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Mac builds.
weinig@apple.com [Wed, 13 Apr 2011 21:50:57 +0000 (21:50 +0000)]
Fix Mac builds.

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 doesn't keep overlay scrollers shown while scroll gesture held
weinig@apple.com [Wed, 13 Apr 2011 21:39:12 +0000 (21:39 +0000)]
WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
<rdar://problem/9260518>

Reviewed by Gavin Barraclough.

Source/WebCore:

Notify the scrollbar painter controller when gesture scrolls begin and end.

* WebCore.exp.in:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Initialize new WKSI functions.

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Initialize new WKSI functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 13 Apr 2011 21:38:21 +0000 (21:38 +0000)]
2011-04-13  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Oliver Hunt.

        WebKit2 will load two copies of the same plugin, but should not
        https://bugs.webkit.org/show_bug.cgi?id=49075
        <rdar://problem/8635947>

        * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
        (WebKit::PluginInfoStore::shouldUsePlugin): Don't use a plug-in if we've already allowed a plug-in with the same filename.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHide the dictionary panel when navigating or crashing.
timothy@apple.com [Wed, 13 Apr 2011 21:31:35 +0000 (21:31 +0000)]
Hide the dictionary panel when navigating or crashing.

<rdar://problem/9261202>

Reviewed by Sam Weinig.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::dismissDictionaryLookupPanel): Added. Call WKHideWordDefinitionWindow.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Call PageClient::dismissDictionaryLookupPanel.
(WebKit::WebPageProxy::processDidCrash): Call dismissCorrectionPanel and PageClient::dismissDictionaryLookupPanel.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 13 Apr 2011 21:29:36 +0000 (21:29 +0000)]
2011-04-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add support for disabling/enabling termination to ChildProcess
        https://bugs.webkit.org/show_bug.cgi?id=58476

        Add ChildProcess::disableTermination and ChildProcess::enableTermination and convert
        the PluginProcess class over to using them.

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::PluginProcess):
        The child process now takes a terminationTimeout argument. Get rid of the shutdown timer.

        (WebKit::PluginProcess::removeWebProcessConnection):
        Call enableTermination().

        (WebKit::PluginProcess::shouldTerminate):
        Always return true.

        (WebKit::PluginProcess::createWebProcessConnection):
        Call disableTermination().

        (WebKit::PluginProcess::getSitesWithData):
        Call disableTermination()/enableTermination().

        (WebKit::PluginProcess::clearSiteData):
        Ditto.

        * Shared/ChildProcess.cpp:
        (WebKit::ChildProcess::disableTermination):
        Increment the counter and stop the timer.

        (WebKit::ChildProcess::enableTermination):
        Decrement the counter; if it's zero, start the timer.

        (WebKit::ChildProcess::terminationTimerFired):
        Call shouldTerminate(). If it returns true, call terminate().

        (WebKit::ChildProcess::terminate):
        Call RunLoop::quit().

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::WebProcess):
        Just initialize the termination timeout to 0 for now.

        (WebKit::WebProcess::shouldTerminate):
        Always return true; this isn't used yet.

        * WebProcess/WebProcess.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: Links are clickable when a contentEditable is set to true.
enrica@apple.com [Wed, 13 Apr 2011 21:26:45 +0000 (21:26 +0000)]
REGRESSION: Links are clickable when a contentEditable is set to true.
https://bugs.webkit.org/show_bug.cgi?id=58473
<rdar://problem/9256793>

Reviewed by Dan Bernstein.

Added support for editable link behavior property.

* Shared/WebPreferencesStore.cpp:
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetEditableLinkBehavior):
(WKPreferencesGetEditableLinkBehavior):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 13 Apr 2011 21:24:17 +0000 (21:24 +0000)]
2011-04-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Maciej Stachowiak.

        MediaPlayerPrivateAVFoundationObjC should adopt [AVURLAsset isPlayableExtendedMIMEType:]
        https://bugs.webkit.org/show_bug.cgi?id=58451
        <rdar://problem/9278468>

        No new tests, supported MIME types haven't changed.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Use
        [AVURLAsset isPlayableExtendedMIMEType] instead of just the list of types.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 21:22:49 +0000 (21:22 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        nrwt: enable multiple processes by default on Chromium Win.
        https://bugs.webkit.org/show_bug.cgi?id=55163

        Re-land r79268; it should be more stable now and will hopefully
        work.

        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 13 Apr 2011 21:11:18 +0000 (21:11 +0000)]
2011-04-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        Media engine fallback doesn't always work
        https://bugs.webkit.org/show_bug.cgi?id=58462

        No new tests, this was verified manually with the url noted in the bug.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::networkStateChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 13 Apr 2011 21:08:45 +0000 (21:08 +0000)]
2011-04-13  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Extension3D needs to provide a way to check if an extension is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58410

        Implement isEnabled() in chromium port.

        * src/Extensions3DChromium.cpp:
        (WebCore::Extensions3DChromium::isEnabled):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::isExtensionEnabled):
        * src/GraphicsContext3DInternal.h:
2011-04-13  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Extension3D needs to provide a way to check if an extension is enabled
        https://bugs.webkit.org/show_bug.cgi?id=58410

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::setupFlags): Use isEnabled() instead of supports().
        * platform/graphics/Extensions3D.h: Add isEnabled().
        * platform/graphics/chromium/Extensions3DChromium.h: Ditto.
        * platform/graphics/opengl/Extensions3DOpenGL.cpp: Ditto.
        (WebCore::Extensions3DOpenGL::isEnabled):
        * platform/graphics/opengl/Extensions3DOpenGL.h: Ditto.
        * platform/graphics/qt/Extensions3DQt.cpp: Ditto.
        (WebCore::Extensions3DQt::isEnabled):
        * platform/graphics/qt/Extensions3DQt.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations per change in r83756.
jianli@chromium.org [Wed, 13 Apr 2011 21:04:36 +0000 (21:04 +0000)]
Unreviewed, update chromium test expectations per change in r83756.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 21:01:08 +0000 (21:01 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: configure logging in child processes properly
        https://bugs.webkit.org/show_bug.cgi?id=58296

        Logging propagated properly from manager to worker processes on
        Unix but not on Windows; this fixes that.

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 20:58:13 +0000 (20:58 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: suppress extraneous pretty patch warnings
        https://bugs.webkit.org/show_bug.cgi?id=58295

        NRWT wasn't being careful about when it logged messages from
        PrettyPatch not being available; it should only log during
        check_build(), and be silent otherwise. This was causing us to
        get multiple errors at runtime, which was confusing.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations to work around a bug
jianli@chromium.org [Wed, 13 Apr 2011 20:37:30 +0000 (20:37 +0000)]
Unreviewed, update chromium test expectations to work around a bug
in gpu test expectations handling.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations.
jianli@chromium.org [Wed, 13 Apr 2011 20:13:50 +0000 (20:13 +0000)]
Unreviewed, update chromium test expectations.

Mark compositing/webgl/webgl-reflection.html as failed for all platforms
in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 13 Apr 2011 20:11:41 +0000 (20:11 +0000)]
2011-04-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        compositing/objects/composited-object-alignment.html causing failures in other tests since its introduction in r83518
        https://bugs.webkit.org/show_bug.cgi?id=58323

        Got rid of unnecessary JS from composited-subframe.html. This was mistakenly left in from previous experiments.
        Also moved pixel results to be platform specific. These are for Mac WebKit and WebKit2. There are color diffs
        between the two platforms, so I will make them all platform specific.

        * compositing/framesets/composited-frame-alignment-expected.checksum: Removed.
        * compositing/framesets/composited-frame-alignment-expected.png: Removed.
        * compositing/objects/composited-object-alignment-expected.checksum: Removed.
        * compositing/objects/composited-object-alignment-expected.png: Removed.
        * compositing/objects/resources/composited-subframe.html:
        * platform/mac-wk2/compositing: Added.
        * platform/mac-wk2/compositing/framesets: Added.
        * platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
        * platform/mac-wk2/compositing/framesets/composited-frame-alignment-expected.png: Added.
        * platform/mac-wk2/compositing/objects: Added.
        * platform/mac-wk2/compositing/objects/composited-object-alignment-expected.checksum: Added.
        * platform/mac-wk2/compositing/objects/composited-object-alignment-expected.png: Added.
        * platform/mac/compositing/framesets: Added.
        * platform/mac/compositing/framesets/composited-frame-alignment-expected.checksum: Added.
        * platform/mac/compositing/framesets/composited-frame-alignment-expected.png: Added.
        * platform/mac/compositing/objects: Added.
        * platform/mac/compositing/objects/composited-object-alignment-expected.checksum: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.checksum.
        * platform/mac/compositing/objects/composited-object-alignment-expected.png: Copied from LayoutTests/compositing/objects/composited-object-alignment-expected.png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
ddkilzer@apple.com [Wed, 13 Apr 2011 19:30:34 +0000 (19:30 +0000)]
<webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm

Reviewed by Anders Carlsson.

Fixes the following warning with -Wcast-align enabled:

    Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
                 archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage isNativeLibraryData:]): Added
COMPILE_ASSERT() to make sure our pointer math is valid.
Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
casts with reinterpret_cast.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExclude webkitGetUserMedia from the navigator-detached-no-crash test.
jianli@chromium.org [Wed, 13 Apr 2011 19:08:02 +0000 (19:08 +0000)]
Exclude webkitGetUserMedia from the navigator-detached-no-crash test.
https://bugs.webkit.org/show_bug.cgi?id=58459

Patch by Leandro Gracia Gil <leandrogracia@chromium.org> on 2011-04-13
Reviewed by Jian Li.

Exclude the MediaStream API methods from the test until the feature
is supported by most platforms.

* fast/dom/navigator-detached-no-crash.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rebaseline 2 tests for linux64 in chromium.
jianli@chromium.org [Wed, 13 Apr 2011 18:58:42 +0000 (18:58 +0000)]
Unreviewed, rebaseline 2 tests for linux64 in chromium.

* platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/chromium-linux-x86_64/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 13 Apr 2011 18:52:26 +0000 (18:52 +0000)]
2011-04-13  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Jian Li.

        add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=58461

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 13 Apr 2011 18:48:22 +0000 (18:48 +0000)]
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make PropertyMapEntry use a WriteBarrier for specificValue
        https://bugs.webkit.org/show_bug.cgi?id=58407

        Make PropertyMapEntry use a WriteBarrier for specificValue, and then
        propagate the required JSGlobalData through all the methods it ends
        up being needed.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::prototype):
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        (JSObjectMake):
        (JSObjectSetPrototype):
        * JavaScriptCore.exp:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        * interpreter/Interpreter.cpp:
        (JSC::appendSourceToError):
        (JSC::Interpreter::tryCacheGetByID):
        (JSC::Interpreter::privateExecute):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::DEFINE_STUB_FUNCTION):
        * runtime/BatchedTransitionOptimizer.h:
        (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
        * runtime/InternalFunction.cpp:
        (JSC::InternalFunction::name):
        (JSC::InternalFunction::displayName):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::getOwnPropertySlot):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::name):
        (JSC::JSFunction::displayName):
        (JSC::JSFunction::getOwnPropertySlot):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::putWithAttributes):
        (JSC::JSGlobalObject::reset):
        (JSC::JSGlobalObject::resetPrototype):
        * runtime/JSGlobalObject.h:
        * runtime/JSObject.cpp:
        (JSC::JSObject::put):
        (JSC::JSObject::deleteProperty):
        (JSC::JSObject::defineGetter):
        (JSC::JSObject::defineSetter):
        (JSC::JSObject::lookupGetter):
        (JSC::JSObject::lookupSetter):
        (JSC::JSObject::getPropertySpecificValue):
        (JSC::JSObject::getOwnPropertyNames):
        (JSC::JSObject::seal):
        (JSC::JSObject::freeze):
        (JSC::JSObject::preventExtensions):
        (JSC::JSObject::removeDirect):
        (JSC::JSObject::getOwnPropertyDescriptor):
        (JSC::JSObject::defineOwnProperty):
        * runtime/JSObject.h:
        (JSC::JSObject::getDirect):
        (JSC::JSObject::getDirectLocation):
        (JSC::JSObject::isSealed):
        (JSC::JSObject::isFrozen):
        (JSC::JSObject::setPrototypeWithCycleCheck):
        (JSC::JSObject::setPrototype):
        (JSC::JSObject::inlineGetOwnPropertySlot):
        (JSC::JSObject::putDirectInternal):
        (JSC::JSObject::putDirectWithoutTransition):
        (JSC::JSObject::putDirectFunctionWithoutTransition):
        * runtime/Lookup.cpp:
        (JSC::setUpStaticFunctionSlot):
        * runtime/ObjectConstructor.cpp:
        (JSC::objectConstructorCreate):
        (JSC::objectConstructorSeal):
        (JSC::objectConstructorFreeze):
        (JSC::objectConstructorPreventExtensions):
        (JSC::objectConstructorIsSealed):
        (JSC::objectConstructorIsFrozen):
        * runtime/Operations.h:
        (JSC::normalizePrototypeChain):
        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyMapEntry::PropertyMapEntry):
        (JSC::PropertyTable::PropertyTable):
        (JSC::PropertyTable::copy):
        * runtime/Structure.cpp:
        (JSC::Structure::materializePropertyMap):
        (JSC::Structure::despecifyDictionaryFunction):
        (JSC::Structure::addPropertyTransition):
        (JSC::Structure::removePropertyTransition):
        (JSC::Structure::changePrototypeTransition):
        (JSC::Structure::despecifyFunctionTransition):
        (JSC::Structure::getterSetterTransition):
        (JSC::Structure::toDictionaryTransition):
        (JSC::Structure::toCacheableDictionaryTransition):
        (JSC::Structure::toUncacheableDictionaryTransition):
        (JSC::Structure::sealTransition):
        (JSC::Structure::freezeTransition):
        (JSC::Structure::preventExtensionsTransition):
        (JSC::Structure::isSealed):
        (JSC::Structure::isFrozen):
        (JSC::Structure::addPropertyWithoutTransition):
        (JSC::Structure::removePropertyWithoutTransition):
        (JSC::Structure::copyPropertyTable):
        (JSC::Structure::get):
        (JSC::Structure::despecifyFunction):
        (JSC::Structure::despecifyAllFunctions):
        (JSC::Structure::put):
        (JSC::Structure::getPropertyNames):
        * runtime/Structure.h:
        (JSC::Structure::get):
        (JSC::Structure::materializePropertyMapIfNecessary):
2011-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make PropertyMapEntry use a WriteBarrier for specificValue
        https://bugs.webkit.org/show_bug.cgi?id=58407

        Pass JSGlobalData reference on to APIs that now need them

        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::setWindow):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::all):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 13 Apr 2011 18:04:30 +0000 (18:04 +0000)]
2011-04-12  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Roben.

        make PrettyPatch.rb aware of checksums in png files
        https://bugs.webkit.org/show_bug.cgi?id=58387

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 13 Apr 2011 17:22:58 +0000 (17:22 +0000)]
2011-04-13  Tony Chang  <tony@chromium.org>

        Unreviewed, fix NRWT.  Stack:

            return super(ChromiumPort, self).results_directory(self)
        TypeError: results_directory() takes exactly 1 argument (2 given)

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 13 Apr 2011 16:45:42 +0000 (16:45 +0000)]
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix source mapping for deobfuscated scripts.
        https://bugs.webkit.org/show_bug.cgi?id=58231

        * inspector/debugger/resources/obfuscated.js: Added.
        * inspector/debugger/script-formatter-expected.txt:
        * inspector/debugger/script-formatter.html:
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix source mapping for de-obfuscated scripts.
        https://bugs.webkit.org/show_bug.cgi?id=58231

        * inspector/front-end/ScriptFormatterWorker.js:
        (buildMapping):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceMapping):
        (WebInspector.SourceMapping.prototype.sourceLineToScriptLocation):
        (WebInspector.SourceMapping.prototype._sourceLocationToScriptLocation):
        (WebInspector):
        (WebInspector.FormattedSourceMapping):
        (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLine):
        (WebInspector.FormattedSourceMapping.prototype.sourceLineToScriptLocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 13 Apr 2011 16:33:02 +0000 (16:33 +0000)]
2011-04-13  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Consider editable and non editable nodes when calculating selection offsets
        https://bugs.webkit.org/show_bug.cgi?id=58431

        Use firstPositionInOrBeforeNode() and lastPositionInOrAfterNode().

        This is needed to ensure that getSelectionOffsetsForObject() works
        well when non editable nodes are present in the selection, since
        firstPositionInNode() and lastPositionInNode() don't work in those
        cases (they assume the node is editable).

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (getSelectionOffsetsForObject): Updated calls.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Wed, 13 Apr 2011 16:27:23 +0000 (16:27 +0000)]
2011-04-13  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Missing nullchecks in GTK's a11y wrapper
        https://bugs.webkit.org/show_bug.cgi?id=58429

        Add missing nullchecks for coreObject->document().

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkParentOfRootObject): Add missing nullcheck.
        (getPangoLayoutForAtk): Ditto.
        (webkit_accessible_text_get_caret_offset): Ditto.
        (textExtents): Ditto.
        (webkit_accessible_editable_text_insert_text): Ditto.
        (webkit_accessible_editable_text_delete_text): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Thierry Reding <thierry.reding@avionic-design.de>
mrobinson@webkit.org [Wed, 13 Apr 2011 16:17:37 +0000 (16:17 +0000)]
2011-04-13  Thierry Reding  <thierry.reding@avionic-design.de>

        Gtk+ port fails to build when enabling WebGL
        https://bugs.webkit.org/show_bug.cgi?id=58434

        Fix the GTK+ WebGL build after the introduction of PlatformContextCairo.

        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
        (WebCore::GraphicsContext3D::paintToCanvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 16:15:50 +0000 (16:15 +0000)]
2011-04-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK platform results for full-screen-zIndex.html test.

        [GTK] fullscreen/full-screen-zIndex.html fails
        https://bugs.webkit.org/show_bug.cgi?id=58444

        * platform/gtk/Skipped:
        * platform/gtk/fullscreen/full-screen-zIndex-expected.checksum: Added.
        * platform/gtk/fullscreen/full-screen-zIndex-expected.png: Added.
        * platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach ORWT about extra platform-specific directories to be searched before the defaul...
aroben@apple.com [Wed, 13 Apr 2011 16:12:10 +0000 (16:12 +0000)]
Teach ORWT about extra platform-specific directories to be searched before the default ones

Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
platform-specific results

Reviewed by Anders Carlsson.

* Scripts/old-run-webkit-tests:
(top-level): Added @additionalPlatformDirectories and hooked up
--additional-platform-directories to populate it.
(buildPlatformResultHierarchy): Prepend the additional platform directories to the default
list (after filtering out any of the additional directories that don't exist).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/inspector/extensions-resources-redirect.html and
jberlin@webkit.org [Wed, 13 Apr 2011 15:55:23 +0000 (15:55 +0000)]
http/tests/inspector/extensions-resources-redirect.html and
inspector/extensions/extensions-resources.html sometimes fail on Windows 7 Release (WebKit2
Tests).
https://bugs.webkit.org/show_bug.cgi?id=57491

Add the tests to the win-wk2 Skipped list to get the bots green.

* platform/win-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 15:49:32 +0000 (15:49 +0000)]
2011-04-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        REGRESSION(r83561): doesn't pause in-window playback during fullscreen playback
        https://bugs.webkit.org/show_bug.cgi?id=58312

        Make sure to link the videoValve in all cases, fpsdisplaysink
        being used or not.

        No new test, this patch fixes an internal feature of the player,
        not publicly exposed. Having two video sinks and pausing one while
        the other displays the fullscreen video is an implementation
        detail of the GStreamer player.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 15:45:04 +0000 (15:45 +0000)]
2011-04-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing fullscreen test on GTK.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 13 Apr 2011 15:44:38 +0000 (15:44 +0000)]
2011-04-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: there is a problem if an optional param is not at the end of a params list.
        https://bugs.webkit.org/show_bug.cgi?id=58440

        In InspectorBackend.dispatch method we are converting the message's params object into array of arguments
        for a callback. But in some cases the optional parameter is declared in the middle of the params list.
        That gets us into a problem if this param has been skipped in the message. In that case the tail of the
        event params will be shifted. We can slightly modify dispatcher and it will put the params in right places.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows XP Debug Tests] fast/events/pageshow-pagehide-on-back-cached-with-frames...
jberlin@webkit.org [Wed, 13 Apr 2011 15:33:26 +0000 (15:33 +0000)]
[Windows XP Debug Tests] fast/events/pageshow-pagehide-on-back-cached-with-frames.html
failing since r83699
https://bugs.webkit.org/show_bug.cgi?id=58441

Add the Windows-XP specific expected failing results to get the bots green.

* platform/win-xp/fast/events: Added.
* platform/win-xp/fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 13 Apr 2011 15:02:06 +0000 (15:02 +0000)]
2011-04-13  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of an svg test updated in r83710 and
        skip an http test using unimplemented DRT features.

        * platform/gtk/Skipped:
        * platform/gtk/svg/custom/text-dom-01-f-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:58:55 +0000 (14:58 +0000)]
2011-04-13  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=57337

        Work around a bug in ternary opertions in the Solaris Studio
        12/12.1/12.2 compilers, using an if clause.

        * dom/NodeRenderStyle.h:
        (WebCore::Node::renderStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd /T to TaskKill.exe
lforschler@apple.com [Wed, 13 Apr 2011 14:57:13 +0000 (14:57 +0000)]
Add /T to TaskKill.exe

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort task kill list
lforschler@apple.com [Wed, 13 Apr 2011 14:55:37 +0000 (14:55 +0000)]
Sort task kill list

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Brian Salomon <bsalomon@google.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:33:25 +0000 (14:33 +0000)]
2011-04-13  Brian Salomon  <bsalomon@google.com>

        Reviewed by Kenneth Russell.

        Use new skia API for wrapping DrawingBuffer's FBO/Tex IDs in skia object
        https://bugs.webkit.org/show_bug.cgi?id=58363

        No new tests needed, exercised by all existing canvas2d tests.

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::getGrPlatformSurfaceDesc):
        * platform/graphics/gpu/DrawingBuffer.h:
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Wed, 13 Apr 2011 14:28:06 +0000 (14:28 +0000)]
2011-04-13  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=58384
        Update kill-old-processes to include a few new ones.

        * BuildSlaveSupport/win/kill-old-processes:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 14:26:22 +0000 (14:26 +0000)]
2011-04-13  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Fix chromium clang build problem:
        ApplyPropertyExpandingSuppressValue::applyValue() shadows a virtual method
        with a different signature in base class instead of overriding it.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::ApplyPropertyExpandingSuppressValue::applyValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 14:25:47 +0000 (14:25 +0000)]
2011-04-13  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Rebaselined SVG test expectations following mac expectations change in r83710.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-dom-01-f-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-dom-01-f-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
        * platform/chromium-win/svg/custom/text-dom-01-f-expected.txt:
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
        * platform/chromium-win/svg/text/lengthAdjust-text-metrics-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 13 Apr 2011 14:20:00 +0000 (14:20 +0000)]
2011-04-13  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Add mock implementation and plumbing code for unified Quota API
        https://bugs.webkit.org/show_bug.cgi?id=57927

        Added plumbing code for the quota API, that is based on the
        discussion on public-webapps:
        http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

        * WebKit.gyp: Added new file entries.
        * src/StorageInfoChromium.cpp: Added.
        * src/WebStorageQuotaCallbacksImpl.cpp: Added. An implementation of
        WebStorageQuotaCallbacks.
        * src/WebStorageQuotaCallbacksImpl.h: Added.
2011-04-13  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Add mock implementation and plumbing code for unified Quota API
        https://bugs.webkit.org/show_bug.cgi?id=57927

        Added mock implementation and some plumbing code for the quota API,
        that is based on the discussion on public-webapps:
        http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

        No new tests: tests will be added when we expose the API.

        * CMakeLists.txt: Added new file entries.
        * DerivedSources.cpp: Added new file entries.
        * DerivedSources.make: Added new file entries.
        * GNUmakefile.am: Added new file entries.
        * WebCore.gypi: Added new file entries.
        * WebCore.pro: Added new file entries.
        * WebCore.vcproj/WebCore.vcproj: Added new file entries.
        * WebCore.xcodeproj/project.pbxproj: Added new file entries.
        * storage/StorageInfo.cpp: Added.
        * storage/StorageInfo.h: Added.
        * storage/StorageInfoErrorCallback.h: Added.
        * storage/StorageInfoQuotaCallback.h: Added.
        * storage/StorageInfoUsageCallback.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:05:15 +0000 (14:05 +0000)]
2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
        https://bugs.webkit.org/show_bug.cgi?id=58297

        Make sure we do not load plugins that use symbols of a different
        GTK+ major version to avoid bugs and crashes.

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::moduleMixesGtkSymbols):
        (WebCore::PluginPackage::load):
2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Martin Robinson.

        [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
        https://bugs.webkit.org/show_bug.cgi?id=58297

        Do not disable flash specifically when built with GTK+ 3 -
        PluginPackage should do the right thing while loading plugins.

        * GtkLauncher/main.c:
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 14:04:44 +0000 (14:04 +0000)]
2011-04-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Doxygen documentation for ewk_main, ewk_history and tools
        https://bugs.webkit.org/show_bug.cgi?id=58428

        * ewk/EWebKit.h:
        * ewk/ewk_eapi.h:
        * ewk/ewk_history.h:
        * ewk/ewk_logging.h:
        * ewk/ewk_main.cpp:
        * ewk/ewk_main.h:
        * ewk/ewk_private.h:
        * ewk/ewk_util.cpp:
        * ewk/ewk_util.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 13 Apr 2011 14:01:55 +0000 (14:01 +0000)]
2011-04-13  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by David Levin.

        [chromium] Regression(r80861): fast/dom/Window/window-lookup-precedence.html started failing on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=56608

        Previously the test unintentionally navigated the iframe when setting
        window.location. Instead, now, we just skip setting window.location.

        * fast/dom/Window/window-lookup-precedence.html:
        * platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt: Moved to chromium.
        * platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt: Moved from chromium-win.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Andrey Adaikin <aandrey@google.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 13:39:00 +0000 (13:39 +0000)]
2011-04-13  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Implement undo/redo in text editor
        https://bugs.webkit.org/show_bug.cgi?id=58426

        Native undo/redo does not work because we modify DOM structure (highlights, chunks and etc.)
        Implement it via keyboard shortcuts for now (Cmd/Ctrl+Z and Cmd/Ctrl+Shift+Z).
        FIXME: Do something with the popup's Undo and Redo menu options - they invoke native's undo/redo.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.endEditing):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype.setText):
        (WebInspector.TextEditorModel.prototype._innerSetText):
        (WebInspector.TextEditorModel.prototype._pushUndoableCommand):
        (WebInspector.TextEditorModel.prototype.undo):
        (WebInspector.TextEditorModel.prototype.redo):
        (WebInspector.TextEditorModel.prototype._doUndo):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._textChanged):
        (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._registerShortcuts):
        (WebInspector.TextViewer.prototype._cancelEditing):
        (WebInspector.TextViewer.prototype._handleUndoRedo):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
        (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback):
        (WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
        (WebInspector.TextEditorMainPanel.prototype._restoreSelection):
        (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Apr 2011 13:24:02 +0000 (13:24 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make optional event parameter last to prevent regressions.
        https://bugs.webkit.org/show_bug.cgi?id=58433

        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::willSendRequest):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
ossy@webkit.org [Wed, 13 Apr 2011 13:12:49 +0000 (13:12 +0000)]
LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
http://webkit.org/b/58334

Make same changes in Qt WK2 Skipped list as r83595 in Mac WK2 Skipped list.

* platform/qt-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify
  three other skipped tests with that same bug.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Apr 2011 12:24:48 +0000 (12:24 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: revert Inspector.json change for breaking world.

        * inspector/Inspector.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 13 Apr 2011 12:14:12 +0000 (12:14 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: swap methods in the Inspector.json.

        * inspector/Inspector.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Csaba Osztrogon√°c <ossy@webkit.org>
ossy@webkit.org [Wed, 13 Apr 2011 11:41:14 +0000 (11:41 +0000)]
2011-04-13  Csaba Osztrogon√°c  <ossy@webkit.org>

        Unreviewed, rolling out r83695.
        http://trac.webkit.org/changeset/83695
        https://bugs.webkit.org/show_bug.cgi?id=58375

        [Qt][WK2]It broke http tests

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::start):
        (WebCore::QNetworkReplyHandler::synchronousLoad):
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::WebCoreSynchronousLoader::resourceResponse):
        (WebCore::WebCoreSynchronousLoader::resourceError):
        (WebCore::WebCoreSynchronousLoader::data):
        (WebCore::WebCoreSynchronousLoader::setReplyFinished):
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
        (WebCore::WebCoreSynchronousLoader::didReceiveData):
        (WebCore::WebCoreSynchronousLoader::didFinishLoading):
        (WebCore::WebCoreSynchronousLoader::didFail):
        (WebCore::WebCoreSynchronousLoader::waitForCompletion):
        (WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 13 Apr 2011 11:37:10 +0000 (11:37 +0000)]
2011-04-13  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: inactive style sheets should be read only.
        https://bugs.webkit.org/show_bug.cgi?id=58423

        * inspector/front-end/ResourceView.js:
        (WebInspector.CSSSourceFrame):
        (WebInspector.CSSSourceFrame.prototype.isContentEditable):
        (WebInspector.CSSSourceFrame.prototype._loadStyleSheet.didGetAllStyleSheets.didCreateForId):
        (WebInspector.CSSSourceFrame.prototype._loadStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 13 Apr 2011 11:35:00 +0000 (11:35 +0000)]
2011-04-13  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=58320

        Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest):

2011-04-13  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
        https://bugs.webkit.org/show_bug.cgi?id=58320

        Introduce a proxy object that emulates worker behavior and change UI code to cope with it.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate.sorted):
        (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort.afterPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
        (WebInspector.HeapSnapshotDiffNode.prototype._calculateDiff):
        (WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
        (WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotDominatorObjectNode):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
        (WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
        (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
        (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.baseSnapshotNodeIdsReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.pushBaseSnapshotNodeIds):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.snapshotNodeIdsReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
        (WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
        (WebInspector.HeapSnapshotRetainingPathsList):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
        (WebInspector.DetailedHeapshotView.profileCallback):
        (WebInspector.DetailedHeapshotView):
        (WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
        (WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
        (WebInspector.DetailedHeapshotView.prototype.show.profileCallback1):
        (WebInspector.DetailedHeapshotView.prototype.show.profileCallback2):
        (WebInspector.DetailedHeapshotView.prototype.show):
        (WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
        * inspector/front-end/HeapSnapshot.js:
        * inspector/front-end/HeapSnapshotProxy.js: Added.
        * inspector/front-end/PleaseWaitMessage.js:
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Qt specific expected results after r83710.
ossy@webkit.org [Wed, 13 Apr 2011 10:45:37 +0000 (10:45 +0000)]
Update Qt specific expected results after r83710.

* platform/qt/svg/custom/text-dom-01-f-expected.txt:
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 13 Apr 2011 10:20:35 +0000 (10:20 +0000)]
2011-04-13  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Web Page Performance auditing fails
        https://bugs.webkit.org/show_bug.cgi?id=58322

        * inspector/audits/audits-panel-functional.html:
2011-04-13  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Web Page Performance auditing fails
        https://bugs.webkit.org/show_bug.cgi?id=58322

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 13 Apr 2011 09:51:26 +0000 (09:51 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: enumerate properties in Inspector.json using array, not object keys.
        https://bugs.webkit.org/show_bug.cgi?id=58418

        * inspector/Inspector.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 13 Apr 2011 09:33:25 +0000 (09:33 +0000)]
2011-04-12  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        Chromium: Set ENABLE_LEVELDB=1 and add leveldb and snappy to DEPS
        https://bugs.webkit.org/show_bug.cgi?id=58343

        Set ENABLE_LEVELDB=1 so that code gets compiled by the EWS bots.
        Add the necessary dependencies to the DEPS file.

        * DEPS:
        * features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-06 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 13 Apr 2011 09:32:15 +0000 (09:32 +0000)]
2011-04-06  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add "De-obfuscate Source" item to source frame text area context menu.
        https://bugs.webkit.org/show_bug.cgi?id=57942

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.formatSourceFilesToggled):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.toggleFormatSourceFiles):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._contextMenu):
        (WebInspector.SourceFrame.prototype._populateLineGutterContextMenu):
        (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
        (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
        (WebInspector.SourceFrameDelegate.prototype.toggleFormatSourceFiles):
        (WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 13 Apr 2011 09:22:45 +0000 (09:22 +0000)]
2011-04-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg has different output on Windows
        https://bugs.webkit.org/show_bug.cgi?id=58421

        * platform/win/Skipped: Skip svdgdom-over-01-f.svg test. The test is fine, but its missing a line compared to the mac output.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 09:00:25 +0000 (09:00 +0000)]
2011-04-13  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed.
        Rebaselined expectations following console message format change in V8 bindings.

        * platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
        * platform/chromium/fast/js/recursion-limit-equal-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 13 Apr 2011 08:42:03 +0000 (08:42 +0000)]
2011-04-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGTextContentElements textLength returns 0
        https://bugs.webkit.org/show_bug.cgi?id=52543

        Add proper handling of the SVGTextContentElement textLength property, according to SVG 1.1 2nd edition.

        If the textLength attributes is not explicitely set "textContentElement.textLength.baseVal"
        will return the same as "textContentElement.getComputedTextLength()". If it's set the values
        aren't equal anymore. getComputedTextLength() ignores the textLength attributes as well as the
        lengthAdjust attribute. Adapt all of SVGTextQuery to ignore the lengthAdjust/textLength attributes.
        This is how Opera implements it, and it makes sense to a certain degree, as otherwhise getComputedTextLength()
        and textLength.baseVal.value would always be the same. Nor does the spec mention that textLength is honored
        in the SVG Text DOM API.

        Fixes svg/custom/text-dom-01-f.svg (from SVG 1.1 2nd edition, should be moved into the new W3C-SVG-1.1-SE directory).
        Fixes svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg (last subtest related to textLength now passes).

        Added new svg/dynamic-updates testcases covering dynamic changes of lengthAdjust/textLength and the synchronization
        with getComputedTextLength().

        Tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
               svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html
               svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html
               svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html
               svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html

        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForPoint):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::offsetForPositionInFragment):
        (WebCore::SVGInlineTextBox::selectionRect):
        (WebCore::SVGInlineTextBox::paintSelectionBackground):
        (WebCore::SVGInlineTextBox::paint):
        (WebCore::SVGInlineTextBox::calculateBoundaries):
        * rendering/svg/SVGTextChunkBuilder.cpp:
        (WebCore::SVGTextChunkBuilder::buildTextChunks):
        (WebCore::SVGTextChunkBuilder::layoutTextChunks):
        (WebCore::SVGTextChunkBuilder::addTextChunk):
        (WebCore::SVGTextChunkBuilder::processTextChunk):
        (WebCore::SVGTextChunkBuilder::processTextLengthSpacingCorrection):
        (WebCore::SVGTextChunkBuilder::processTextAnchorCorrection):
        * rendering/svg/SVGTextFragment.h:
        (WebCore::SVGTextFragment::SVGTextFragment):
        (WebCore::SVGTextFragment::buildFragmentTransform):
        (WebCore::SVGTextFragment::transformAroundOrigin):
        (WebCore::SVGTextFragment::buildTransformForTextOnPath):
        (WebCore::SVGTextFragment::buildTransformForTextOnLine):
        * rendering/svg/SVGTextLayoutEngine.cpp:
        (WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
        (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
        (WebCore::dumpTextBoxes):
        (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
        (WebCore::SVGTextLayoutEngine::finishLayout):
        (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
        * rendering/svg/SVGTextQuery.cpp:
        (WebCore::SVGTextQuery::textLengthCallback):
        (WebCore::SVGTextQuery::subStringLengthCallback):
        (WebCore::SVGTextQuery::startPositionOfCharacterCallback):
        (WebCore::SVGTextQuery::endPositionOfCharacterCallback):
        (WebCore::SVGTextQuery::rotationOfCharacterCallback):
        (WebCore::calculateGlyphBoundaries):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::SVGTextContentElement):
        (WebCore::SVGTextContentElement::synchronizeTextLength):
        (WebCore::SVGTextContentElement::textLengthAnimated):
        (WebCore::SVGTextContentElement::parseMappedAttribute):
        (WebCore::SVGTextContentElement::svgAttributeChanged):
        * svg/SVGTextContentElement.h:
        (WebCore::SVGTextContentElement::specifiedTextLength):
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::svgAttributeChanged):
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::svgAttributeChanged):

2011-04-13  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGTextContentElements textLength returns 0
        https://bugs.webkit.org/show_bug.cgi?id=52543

        Add new testcases from SVG 1.1 2nd edition. Correct all existing tests using textLength + SVG DOM Text API,
        as we're not including textLength/lengthAdjust="spacingAndGlyphs" anymore in the SVGTextQuery results.
        This matches Opera and a discussion on www-svg some time ago: http://www.w3.org/2010/05/24-svg-minutes.html.

        * platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.checksum: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
        * platform/mac/svg/custom/text-dom-01-f-expected.checksum:
        * platform/mac/svg/custom/text-dom-01-f-expected.png:
        * platform/mac/svg/custom/text-dom-01-f-expected.txt:
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
        * svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg: Added.
        * svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html: Added.
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-lengthAdjust-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-textLength-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-textLength-prop.js: Added.
        (executeTest):
        * svg/text/lengthAdjust-text-metrics-expected.txt:
        * svg/text/resources/SelectionTestCase.js:
        (transformPoint):
        (transformRect):
        (toAbsoluteCoordinates):
        (selectRange):
        * svg/text/script-tests/lengthAdjust-text-metrics.js:
        (transformPoint):
        (transformRect):
        (numberToString):
        (lengthToString):
        (pointToString):
        (rectToString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Paul Knight <pknight@apple.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 08:14:36 +0000 (08:14 +0000)]
2011-04-13  Paul Knight  <pknight@apple.com>

        Reviewed by Gavin Barraclough.

        BACKTRACE() macro should check for Debug configuration in macro, not WTFReportBacktrace definition
        https://bugs.webkit.org/show_bug.cgi?id=58405

        The BACKTRACE() macro requires JavaScriptCore be built with a Debug
        configuration in order for it to be enabled. Move the NDEBUG check to
        the header so it will be enabled when the calling framework or
        application is built with a Debug configuration, similar to how
        ASSERT() and friends work.

        * wtf/Assertions.cpp:
        * wtf/Assertions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fixed chromium test expectations.
caseq@chromium.org [Wed, 13 Apr 2011 07:52:13 +0000 (07:52 +0000)]
Unreviewed. Fixed chromium test expectations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-13 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 13 Apr 2011 07:22:34 +0000 (07:22 +0000)]
2011-04-13  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: requestDocument can result in race condition in DOMAgent.js
        https://bugs.webkit.org/show_bug.cgi?id=58415

        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
        (WebInspector.DOMAgent.prototype.requestDocument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 13 Apr 2011 07:04:20 +0000 (07:04 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: another pass of protocol renames.
        https://bugs.webkit.org/show_bug.cgi?id=58340

        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getDocument):
        (WebCore::InspectorDOMAgent::performSearch):
        (WebCore::InspectorDOMAgent::setSearchingForNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::evaluate):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._setSearchingForNode):
        (WebInspector.ElementsPanel.prototype.setSearchingForNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 06:54:36 +0000 (06:54 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted chromium test expectations
         - adding WIN crash for webgl-reflection.html

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 06:45:26 +0000 (06:45 +0000)]
2011-04-12  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=58131

        Provide a workaround for an obscure Studio 12 compiler bug, which
        couldn't call src->~T() on a const T *src.

        * wtf/Vector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fixed malformed chromium test expectations line.
caseq@chromium.org [Wed, 13 Apr 2011 06:34:47 +0000 (06:34 +0000)]
Unreviewed. Fixed malformed chromium test expectations line.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 06:05:30 +0000 (06:05 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted chromium test expectations:
         - missing expectations for child-layer-3d-sorting.html
         - adopt-node-crash.html crash of mac debug gpu

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 13 Apr 2011 05:47:47 +0000 (05:47 +0000)]
2011-04-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * platform/chromium/test_expectations.txt:
          Remove validation-message-appearance.html because it becomes non-flaky
          by the DRT change.
2011-04-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * public/WebSettings.h: Declare new function.
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
         Passing the specified value to WebCore::Settings.
        * src/WebSettingsImpl.h: Declare new function.
2011-04-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo): Disable the validation message timer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 13 Apr 2011 05:12:39 +0000 (05:12 +0000)]
2011-04-12  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement remaining Background and Mask css properties in CSSStyleApplyProperty
        https://bugs.webkit.org/show_bug.cgi?id=58390

        No new tests required as no functionality changed.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::ApplyPropertyExpanding): Class to expand one property to 0-4 properties.
        (WebCore::ApplyPropertyExpandingSuppressValue): Expand properties but suppress applyValue.

        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        (WebCore::CSSStyleSelector::applyProperty): Remove implementations that have been moved to CSSStyleApplyProperty.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Sergey Glazunov <serg.glazunov@gmail.com>
commit-queue@webkit.org [Wed, 13 Apr 2011 05:07:59 +0000 (05:07 +0000)]
2011-04-12  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by Dimitri Glazkov.

        Element::setAttribute should check the namespace of an id attribute
        https://bugs.webkit.org/show_bug.cgi?id=58359

        * fast/dom/id-attribute-with-namespace-crash-expected.txt: Added.
        * fast/dom/id-attribute-with-namespace-crash.html: Added.
2011-04-12  Sergey Glazunov  <serg.glazunov@gmail.com>

        Reviewed by Dimitri Glazkov.

        Element::setAttribute should check the namespace of an id attribute
        https://bugs.webkit.org/show_bug.cgi?id=58359

        Test: fast/dom/id-attribute-with-namespace-crash.html

        * dom/Element.cpp:
        (WebCore::Element::setAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Mike Lawther <mikelawther@chromium.org>
commit-queue@webkit.org [Wed, 13 Apr 2011 04:49:52 +0000 (04:49 +0000)]
2011-04-12  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by James Robinson.

        Update boolean operators in RenderStyle to be compatible with check-webkit-style
        https://bugs.webkit.org/show_bug.cgi?id=58409

        No new functionality, so no new tests.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::operator==):
        (WebCore::RenderStyle::inheritedNotEqual):
        (WebCore::positionedObjectMoved):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::applyTransform):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::isOriginalDisplayInlineType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Wed, 13 Apr 2011 04:35:33 +0000 (04:35 +0000)]
2011-04-12  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Oliver Hunt.

        REGRESSION (WebKit2): Input methods are active in non-editable content
        https://bugs.webkit.org/show_bug.cgi?id=58404
        <rdar://problem/9275940>

        * UIProcess/API/mac/WKView.mm:
        (-[WKView insertText:]): Re-add the old variant of this function, because it's not only part
        of deprecated NSTextInput protocol, but it's also part of NSResponder, and it's called when
        the input context in nil.
        (-[WKView inputContext]): Return nil when not in editable content.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 13 Apr 2011 04:31:52 +0000 (04:31 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Added chromium baselines for new tests.

        * platform/chromium/test_expectations.txt:
        * platform/chromium-linux/fast/borders/bidi-002-expected.png: Added.
        * platform/chromium-linux/fast/borders/bidi-004-expected.png: Added.
        * platform/chromium-linux/fast/borders/bidi-009a-expected.png: Added.
        * platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Added.
        * platform/chromium-mac-leopard/fast/borders/bidi-002-expected.png: Added.
        * platform/chromium-mac-leopard/fast/borders/bidi-004-expected.png: Added.
        * platform/chromium-mac-leopard/fast/borders/bidi-009a-expected.png: Added.
        * platform/chromium-win/fast/borders/bidi-002-expected.png: Added.
        * platform/chromium-win/fast/borders/bidi-002-expected.txt: Added.
        * platform/chromium-win/fast/borders/bidi-004-expected.png: Added.
        * platform/chromium-win/fast/borders/bidi-004-expected.txt: Added.
        * platform/chromium-win/fast/borders/bidi-009a-expected.png: Added.
        * platform/chromium-win/fast/borders/bidi-009a-expected.txt: Added.
        * platform/chromium-win/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
        * platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
luiz@webkit.org [Wed, 13 Apr 2011 04:30:11 +0000 (04:30 +0000)]
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375

Reviewed by Andreas Kling.

As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.

Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Wed, 13 Apr 2011 04:13:33 +0000 (04:13 +0000)]
2011-04-12  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Adding layout test for:
        https://bugs.webkit.org/show_bug.cgi?id=58397

        * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.checksum: Added.
        * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
        * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
        * platform/chromium/compositing/child-layer-3d-sorting.html: Added.
        * platform/chromium/test_expectations.txt:
2011-04-12  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Move the calculation of the layer's z coordinate to the
        right spot so that it can be picked up by its sublayers.
        https://bugs.webkit.org/show_bug.cgi?id=58397

        Test: platform/chromium/compositing/child-layer-3d-sorting.html

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Antoine Labour <piman@chromium.org>
commit-queue@webkit.org [Wed, 13 Apr 2011 04:04:01 +0000 (04:04 +0000)]
2011-04-12  Antoine Labour  <piman@chromium.org>

        Reviewed by Kenneth Russell.

        Allow WebView users to recreate dependent contexts after a context lost
        event. Similarly to the startup case, a temporary context gets created,
        that gets used by the layer renderer once it itself gets recreated.
        https://bugs.webkit.org/show_bug.cgi?id=58385

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::reallocateRenderer): use the temporary context to
        recreate the layer renderer if it's valid.
        (WebKit::WebViewImpl::graphicsContext3D): create a temporary context if
        the layer renderer's context is lost.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 James Kozianski <koz@chromium.org>
koz@chromium.org [Wed, 13 Apr 2011 03:55:14 +0000 (03:55 +0000)]
2011-04-12  James Kozianski  <koz@chromium.org>

        Unreviewed.

        Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QNetworkReplyHandler refactoring: signal queue
luiz@webkit.org [Wed, 13 Apr 2011 03:30:32 +0000 (03:30 +0000)]
[Qt] QNetworkReplyHandler refactoring: signal queue
https://bugs.webkit.org/show_bug.cgi?id=57075

Reviewed by Andreas Kling.

The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.

To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.

The new class is named QNetworkReplyHandlerCallQueue.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::flush):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Kenichi Ishibashi <bashi@chromium.org>
tkent@chromium.org [Wed, 13 Apr 2011 03:24:58 +0000 (03:24 +0000)]
2011-04-12  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
        https://bugs.webkit.org/show_bug.cgi?id=58247

        Added tests which ensure calculation of m_associatedElementsAfterIndex
        doesn't get wrong.

        * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1-expected.txt: Added.
        * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html: Added.
        * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2-expected.txt: Added.
        * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html: Added.
2011-04-12  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
        https://bugs.webkit.org/show_bug.cgi?id=58247

        - Increment m_associatedElementsAfterIndex when the form owner and an
        inserted form associated element have the same parent chain.
        - Always iterate over m_associatedElements to decrease indexes when a
        form associated element is removed. This is needed for a case that the
        form associated element is removed from the form element due to
        deleting the 'form' attribute. No behavioral change expected with this
        change.

        Tests: fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html
               fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
        Incremet m_associatedElementsAfterIndex when compareDocumentPosition()
        returns DOCUMENT_POSITION_CONTAINED_BY.
        (WebCore::HTMLFormElement::removeFormElement):
        Always iterate m_associatedElements to adjust indexes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83690 268f45cc-cd09-0410-ab3c-d52691b4dbfc