eric@webkit.org [Wed, 2 Feb 2011 23:32:39 +0000 (23:32 +0000)]
2011-01-27 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.
However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.
* benchmarks/parser/tiny-innerHTML.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Wed, 2 Feb 2011 23:08:21 +0000 (23:08 +0000)]
2011-02-02 Vangelis Kokkevis <vangelis@chromium.org>
[chromium] Adding support for reflections to the accelerated
compositing path.
https://bugs.webkit.org/show_bug.cgi?id=53179
All layout tests in compositing/reflections generate correct
results with the exception of:
1. nested-reflection-anchor-point.html : There appears to be
some issue with the layer transform math that I haven't been
able to track down yet.
2. reflection-opacity.html : The current implementation applies
opacity before doing the reflection which makes this test
produce incorrect results. This will affect reflected layers
with opacity that overlap their original layer. FIXME comment
added in the code.
Tests: Covered by existing layout tests in compositing/reflections.
Please see above for exceptions.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setReplicaLayer):
(WebCore::LayerChromium::replicaLayer):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayersRecursive):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::drawableContentRect):
(WebCore::RenderSurfaceChromium::drawSurface):
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::drawTransform):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 2 Feb 2011 22:45:42 +0000 (22:45 +0000)]
2011-02-02 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Select popup with padding has white strip on right
https://bugs.webkit.org/show_bug.cgi?id=53602
No new tests as this change restores old behavior.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::layout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Feb 2011 22:45:09 +0000 (22:45 +0000)]
Make sure that we don't try to call display() when in accelerated compositing mode
https://bugs.webkit.org/show_bug.cgi?id=53629
Reviewed by Sam Weinig.
When in accelerated compositing mode, the layer tree host should handle all painting, so make sure that display() is never called.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
(WebKit::DrawingAreaImpl::display):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Wed, 2 Feb 2011 22:43:55 +0000 (22:43 +0000)]
Fix for <rdar://problem/
8950343> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebCore:
WebCore::ScrollbarThemeMac::unregisterScrollbar + 22
Reviewed by Mark Rowe.
It is possible for a Scrollbar's ScrollableArea to be null,
so we must null check.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Wed, 2 Feb 2011 22:39:29 +0000 (22:39 +0000)]
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626
* fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
* fast/canvas/webgl/buffer-data-array-buffer.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 2 Feb 2011 22:34:30 +0000 (22:34 +0000)]
Add DerivedSources.make to some Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53607
Patch by Jeff Miller <jeffm@apple.com> on 2011-02-02
Reviewed by Darin Adler and Steve Falkenburg.
Source/JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add DerivedSources.make.
Source/WebCore:
* WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 2 Feb 2011 22:33:55 +0000 (22:33 +0000)]
Assert WebBackForwardList's current index is valid to help catch errors
Hopefully this will help catch a crash I saw once but haven't yet been able to reproduce.
Fixes <http://webkit.org/b/53622>.
Reviewed by Brady Eidson.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
Assert that m_current is valid.
* UIProcess/WebBackForwardList.h: Moved the NoCurrentItemIndex to a static data member so
that it can be used from WebBackForwardListCF.cpp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 2 Feb 2011 22:25:49 +0000 (22:25 +0000)]
2011-02-02 Cris Neckar <cdn@chromium.org>
Reviewed by James Robinson.
Tests for crash when a domwindow is removed within a device orientation event.
https://bugs.webkit.org/show_bug.cgi?id=53623
* fast/events/device-orientation-crash-expected.txt: Added.
* fast/events/device-orientation-crash.html: Added.
2011-02-02 Cris Neckar <cdn@chromium.org>
Reviewed by James Robinson.
Refcount domwindows when dispatching device orientation events.
https://bugs.webkit.org/show_bug.cgi?id=53623
Test: fast/events/device-orientation-crash.html
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::didChangeDeviceMotion):
* dom/DeviceMotionController.h:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::timerFired):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
* dom/DeviceOrientationController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Wed, 2 Feb 2011 22:13:43 +0000 (22:13 +0000)]
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604
* fast/canvas/webgl/object-deletion-behaviour-expected.txt:
* fast/canvas/webgl/object-deletion-behaviour.html: Add test cases for object binding and deletion.
2011-02-02 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram.
(WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound.
(WebCore::WebGLRenderingContext::bindFramebuffer): Ditto.
(WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto.
(WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching.
(WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*.
(WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject.
(WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto.
(WebCore::WebGLRenderingContext::deleteProgram): Ditto.
(WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto.
(WebCore::WebGLRenderingContext::deleteShader): Ditto.
(WebCore::WebGLRenderingContext::deleteTexture): Ditto.
(WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound.
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLTexture.h:
(WebCore::WebGLTexture::getTarget): Accessor to cached target.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 2 Feb 2011 22:06:17 +0000 (22:06 +0000)]
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Unreviewed Efl buildfix after r77399.
* CMakeListsEfl.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 2 Feb 2011 21:59:46 +0000 (21:59 +0000)]
2011-02-02 Adam Klein <adamk@chromium.org>
Reviewed by Tony Chang.
Update new-run-webkit-tests --chromium to put output under Source/...
https://bugs.webkit.org/show_bug.cgi?id=53612
* BuildSlaveSupport/test-result-archive:
* Scripts/webkitpy/layout_tests/port/chromium.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 2 Feb 2011 21:49:53 +0000 (21:49 +0000)]
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Update the NEWS file in preparation for the 1.3.11 release.
* NEWS: Update the NEWS.
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Bump the WebKitGTK+ versions in preparation for development release.
* configure.ac: Bump the library, libtool and user agent version.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Feb 2011 21:49:09 +0000 (21:49 +0000)]
2011-02-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
The drawing area proxy should keep track of the accelerated compositing state
https://bugs.webkit.org/show_bug.cgi?id=53624
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
Initialize m_isInAcceleratedCompositingMode to false.
(WebKit::DrawingAreaProxyImpl::paint):
Don't try to paint if we're in accelerated compositing mode.
(WebKit::DrawingAreaProxyImpl::didSetSize):
Bail if we're in accelerated compositing mode.
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode to true, null out the backing store.
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode back to false.
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Assert that we're not in accelerated compositing mode.
* UIProcess/DrawingAreaProxyImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Wed, 2 Feb 2011 21:37:00 +0000 (21:37 +0000)]
2011-02-02 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618
* fast/canvas/webgl/array-setters.html:
* fast/canvas/webgl/array-unit-tests-expected.txt:
* fast/canvas/webgl/array-unit-tests.html:
* fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
* fast/canvas/webgl/draw-elements-out-of-bounds.html:
* fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
* fast/canvas/webgl/webgl-array-invalid-ranges.html:
2011-02-02 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618
* html/canvas/Float32Array.cpp:
(WebCore::Float32Array::subarray):
* html/canvas/Float32Array.h:
* html/canvas/Float32Array.idl:
* html/canvas/Int16Array.cpp:
(WebCore::Int16Array::subarray):
* html/canvas/Int16Array.h:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.cpp:
(WebCore::Int32Array::subarray):
* html/canvas/Int32Array.h:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.cpp:
(WebCore::Int8Array::subarray):
* html/canvas/Int8Array.h:
* html/canvas/Int8Array.idl:
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::subarrayImpl):
* html/canvas/Uint16Array.cpp:
(WebCore::Uint16Array::subarray):
* html/canvas/Uint16Array.h:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.cpp:
(WebCore::Uint32Array::subarray):
* html/canvas/Uint32Array.h:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.cpp:
(WebCore::Uint8Array::subarray):
* html/canvas/Uint8Array.h:
* html/canvas/Uint8Array.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 2 Feb 2011 21:30:36 +0000 (21:30 +0000)]
2011-02-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add an empty file for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=53573
Posting this as a separate patch because editing the build files is so
painful.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 2 Feb 2011 21:23:27 +0000 (21:23 +0000)]
2011-01-28 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] remove --use-test-shell from NRWT
https://bugs.webkit.org/show_bug.cgi?id=53346
I've already started removing some of the bindings like eventSender so
this already doesn't work isn't useful. Also updated some comments to
refer to DRT instead of test_shell.
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 2 Feb 2011 21:19:59 +0000 (21:19 +0000)]
Give the Web Process access to the Safari RSS preferences.
<rdar://problem/
8916870> Sandbox violation related to RSS during initial
page load with WebKit2 (prevents RSS from working)
Reviewed by Darin Adler.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 2 Feb 2011 21:19:41 +0000 (21:19 +0000)]
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] remove old data: URI handler, fix the SoupRequest-based one
to pass tests
https://bugs.webkit.org/show_bug.cgi?id=50885
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback): Do content-type sniffing here for
non-HTTP requests.
(WebCore::startHTTPRequest): Rename to match WebKit style.
(WebCore::ResourceHandle::start): Pass everything except HTTP to
startNonHTTPRequest, letting the SoupRequester decide whether it's
supported or not.
(WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester
code that was a no-op for file: URIs, but would break some data:
URIs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 21:18:44 +0000 (21:18 +0000)]
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Update even more references to right() and bottom() in Chromium. Sheesh.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 21:12:07 +0000 (21:12 +0000)]
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Update more references to right() and bottom() in Chromium.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas): Replaced bottom/right with maxY/maxX.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 2 Feb 2011 21:03:39 +0000 (21:03 +0000)]
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Unreviewed Gtk3 buildfix after r77286.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintMenuList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Feb 2011 21:01:34 +0000 (21:01 +0000)]
Fix build.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::pinnedInDirection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 20:59:20 +0000 (20:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53619
Reviewed by Dan Bernstein.
Floats should not use physical terminology for their rects. Replace left/top with x/y and right/bottom
with maxX/maxY. This matches IntRect.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 20:54:03 +0000 (20:54 +0000)]
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Update more references to right() and bottom() in Chromium Win.
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX.
(WebCore::TransparencyWin::compositeTextComposite): Ditto.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore::RenderThemeChromiumWin::paintMenuList): Ditto.
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Update more references to right() and bottom() in Chromium Win.
* tests/TransparencyWinTest.cpp:
(WebCore::TEST): Replaced bottom/right with maxY/maxX.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 2 Feb 2011 20:33:51 +0000 (20:33 +0000)]
Encode/decode FormData and FormDataElement objects consistently
Fixes <http://webkit.org/b/53615> <rdar://problem/
8943346> WebKit2: Restoring session state
that contains form data fails (asserts in Debug build)
To prevent this from interfering with WebKit2 testing, it's useful to get this into a build
now, even though we don't have an automated test for it yet. Writing a test is covered by
<http://webkit.org/b/53616>.
Reviewed by Darin Adler.
* history/HistoryItem.cpp: Bump the encoding version, since this patch changes how we encode
FormData objects.
* platform/network/FormData.cpp:
(WebCore::decode): Decode the type from the Decoder, rather than getting it from the
default-constructed FormDataElement. Failing to do this meant that all future uses of the
Decoder would be reading from an unexpected part of the buffer (i.e., the next decode would
start by reading the uint32_t that we forgot to decode here, and so on). We already had code
to correctly set the FormDataElement's type based on this decoded type later in the
function.
(WebCore::FormData::encodeForBackForward): Encode m_identifier as an int64_t, since that
matches its type and how we decode it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Wed, 2 Feb 2011 20:25:58 +0000 (20:25 +0000)]
2011-02-02 Matthew Vosburgh <maf@chromium.org>
Reviewed by Kenneth Russell.
Some favicons not correctly decoded by Chromium/Mac
https://bugs.webkit.org/show_bug.cgi?id=53448
* src/WebImageCG.cpp:
(WebKit::WebImage::fromData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 2 Feb 2011 20:24:39 +0000 (20:24 +0000)]
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747
Use libsoup-based cache/requester API and remove the WebCore version
of this functionality. This has been pushed upstream fully.
No new tests because this should not change functionality.
* GNUmakefile.am: Update for removed files.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal): Update
type names, drop m_requester.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized): Add a SoupRequester to the
session.
(WebCore::parseDataUrl):
(WebCore::startHttp): Get the requester from the session rather
than using m_requester.
(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::readCallback):
(WebCore::startGio): Update type names.
* platform/network/soup/cache/soup-directory-input-stream.c: Removed.
* platform/network/soup/cache/soup-directory-input-stream.h: Removed.
* platform/network/soup/cache/soup-http-input-stream.c: Removed.
* platform/network/soup/cache/soup-http-input-stream.h: Removed.
* platform/network/soup/cache/soup-request-data.c: Removed.
* platform/network/soup/cache/soup-request-data.h: Removed.
* platform/network/soup/cache/soup-request-file.c: Removed.
* platform/network/soup/cache/soup-request-file.h: Removed.
* platform/network/soup/cache/soup-request-http.c: Removed.
* platform/network/soup/cache/soup-request-http.h: Removed.
* platform/network/soup/cache/soup-request.c: Removed.
* platform/network/soup/cache/soup-request.h: Removed.
* platform/network/soup/cache/soup-requester.c: Removed.
* platform/network/soup/cache/soup-requester.h: Removed.
* platform/network/soup/cache/webkit/soup-cache-private.h: Removed.
* platform/network/soup/cache/webkit/soup-cache.c: Removed.
* platform/network/soup/cache/webkit/soup-cache.h: Removed.
2011-02-02 Dan Winship <danw@gnome.org>
Reviewed by Martin Robinson.
[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747
* GNUmakefile.am: Remove old cache files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 20:20:36 +0000 (20:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53520
Reviewed by Darin Adler.
Remove physical accessors from IntRect and FloatRect.
* page/FrameView.cpp:
(WebCore::FrameView::adjustPageHeightDeprecated):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 20:19:22 +0000 (20:19 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53614
Reviewed by Dan Bernstein.
Remove physical terminology from overflow. Replace with minX/maxX/minY/maxY.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::minYLayoutOverflow):
(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::minXLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::minYVisualOverflow):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::minXVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalminYVisualOverflow):
(WebCore::InlineFlowBox::logicalmaxYVisualOverflow):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::maxYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(WebCore::RenderBox::maxXVisualOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
* rendering/RenderOverflow.h:
(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::minYLayoutOverflow):
(WebCore::RenderOverflow::maxYLayoutOverflow):
(WebCore::RenderOverflow::minXLayoutOverflow):
(WebCore::RenderOverflow::maxXLayoutOverflow):
(WebCore::RenderOverflow::minYVisualOverflow):
(WebCore::RenderOverflow::maxYVisualOverflow):
(WebCore::RenderOverflow::minXVisualOverflow):
(WebCore::RenderOverflow::maxXVisualOverflow):
(WebCore::RenderOverflow::setminYVisualOverflow):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::docTop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 20:07:34 +0000 (20:07 +0000)]
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Added GPU fails from bots.
* platform/chromium-gpu/test_expectations.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 19:58:07 +0000 (19:58 +0000)]
2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Dave Hyatt.
Remove remaining references to right() and bottom() from Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=53613
* src/DragScrollTimer.cpp:
(WebKit::distanceToRect): Replaced right/bottom with maxX/maxY.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::doPixelReadbackToCanvas): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 2 Feb 2011 19:56:36 +0000 (19:56 +0000)]
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* configure.ac:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* Scripts/build-webkit:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* Configurations/FeatureDefines.xcconfig:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* Configurations/FeatureDefines.xcconfig:
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* features.pri:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAudioBytesDecoded):
(WebCore::HTMLMediaElement::webkitVideoBytesDecoded):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitDecodedFrames):
(WebCore::HTMLVideoElement::webkitDroppedFrames):
* html/HTMLVideoElement.h:
* html/HTMLVideoElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::decodedFrames):
(WebCore::MediaPlayer::droppedFrames):
(WebCore::MediaPlayer::audioBytesDecoded):
(WebCore::MediaPlayer::videoBytesDecoded):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::decodedFrames):
(WebCore::MediaPlayerPrivateInterface::droppedFrames):
(WebCore::MediaPlayerPrivateInterface::audioBytesDecoded):
(WebCore::MediaPlayerPrivateInterface::videoBytesDecoded):
2011-02-02 Steve Lacey <sjl@chromium.org>
Reviewed by Eric Carlson.
Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322
* Configurations/FeatureDefines.xcconfig:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Wed, 2 Feb 2011 19:40:44 +0000 (19:40 +0000)]
2011-02-02 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by David Hyatt.
More conversion from right()/bottom() to maxX()/maxY().
* page/qt/FrameQt.cpp:
(WebCore::Frame::dragImageForSelection):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 2 Feb 2011 19:34:38 +0000 (19:34 +0000)]
[wx] Build fixes for wxWebKit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 2 Feb 2011 19:21:17 +0000 (19:21 +0000)]
2011-02-01 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more Heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=53577
SunSpider reports no change.
Split out MarkedBlock into its own file / class.
Did the following renames:
isCellMarked => isMarked
checkMarkCell => testAndSetMarked
markCell => setMarked
cellOffset => cellNumber
collectorBlock => blockFor
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Heap.cpp:
(JSC::WeakGCHandlePool::update):
* runtime/Heap.h:
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::setMarked):
* runtime/JSArray.h:
(JSC::MarkStack::markChildren):
(JSC::MarkStack::drain):
* runtime/JSCell.h:
(JSC::JSCell::MarkStack::internalAppend):
* runtime/MarkedBlock.cpp: Added.
* runtime/MarkedBlock.h: Added.
(JSC::MarkedBlock::blockFor):
(JSC::MarkedBlock::cellNumber):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::setMarked):
(JSC::MarkedBlock::isCellAligned):
(JSC::MarkedBlock::isPossibleCell):
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::isMarked):
(JSC::MarkedSpace::testAndSetMarked):
(JSC::MarkedSpace::setMarked):
* runtime/SmallStrings.cpp:
(JSC::isMarked):
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::isValid):
(JSC::::get):
(JSC::::take):
(JSC::::set):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 19:13:09 +0000 (19:13 +0000)]
More right()/bottom() to maxX()/maxY() conversion.
Reviewed by Darin Adler.
* page/chromium/FrameChromium.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 2 Feb 2011 19:00:32 +0000 (19:00 +0000)]
Fix windows clean build.
../JavaScriptCore:
* DerivedSources.make:
../WebCore:
* DerivedSources.make:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 2 Feb 2011 18:56:05 +0000 (18:56 +0000)]
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Unskip a test that just needs platform-specific results. Re-classify
two other failures with more pertinent information.
* platform/gtk/Skipped: Organize the skipped list a bit. Unskip a test.
Remove obsolete comments.
* platform/gtk/editing/inserting/
5994480-2-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 2 Feb 2011 18:55:35 +0000 (18:55 +0000)]
2011-02-02 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.
https://bugs.webkit.org/show_bug.cgi?id=53606
Display progress while taking a snapshot, and hints while loading
and parsing. This is needed because taking detailed heap snapshots
takes time.
* English.lproj/localizedStrings.js:
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype.getProfiles):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
* inspector/front-end/SidebarTreeElement.js:
(WebInspector.SidebarTreeElement.prototype.refreshTitles):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 2 Feb 2011 18:51:57 +0000 (18:51 +0000)]
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=53561
<rdar://problem/
8900228> Stepping through print previews in WebKit2 mode steps in and out of
printing mode a lot
Disable NSView autodisplay, so that -[WKView drawRect:] isn't called (other than when
resizing the window), so that we don't have to switch modes all the time.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setAutodisplay):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setAutodisplay):
* UIProcess/WebPageProxy.h:
Pipe the call from WKPrintingView down to WKView.
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView beginDocument]): Added. We don't want to autodisplay WKView while printing,
because layout is changed to print at the time, and drawing to screen requires relayout.
(-[WKPrintingView endDocument]): When not printing, turn autodisplay back on. Also, call
-[super endDocument] for unknown but definitive good (oops!).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 18:35:41 +0000 (18:35 +0000)]
More conversion from right()/bottom() to maxX()/maxY().
Reviewed by Darin Adler.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 18:32:56 +0000 (18:32 +0000)]
Removal of right()/bottom(). Replace with maxX() and maxY(). Still converting. Haven't removed yet.
Reviewed by Darin Adler.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::layout):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::GLES2Canvas::drawTexturedRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::growLayerToContain):
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::overlappedTileIndices):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/FloatRectSkia.cpp:
(WebCore::FloatRect::operator SkRect):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/graphics/skia/IntRectSkia.cpp:
(WebCore::IntRect::operator SkIRect):
(WebCore::IntRect::operator SkRect):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::clip):
* platform/graphics/win/IntRectWin.cpp:
(WebCore::IntRect::operator RECT):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::roundRect):
(WebCore::mapRect):
(WebCore::TransparentLayerDC::TransparentLayerDC):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::strokeRect):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::paintSliderTrack):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintInnerSpinButton):
(WebCore::RenderThemeWin::paintMenuListButton):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 2 Feb 2011 18:30:59 +0000 (18:30 +0000)]
2011-02-01 Darin Fisher <darin@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Avoid #ifdefs in code that constructs a GraphicsContext by
adding a helper class.
https://bugs.webkit.org/show_bug.cgi?id=53575
* WebKit.gyp:
* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::drawText):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::paint):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::paint):
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::paint):
* src/painting: Added.
* src/painting/GraphicsContextBuilder.h: Added.
(WebKit::GraphicsContextBuilder::GraphicsContextBuilder):
(WebKit::GraphicsContextBuilder::context):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 18:30:27 +0000 (18:30 +0000)]
Removal of right()/bottom(), converting to maxX()/maxY().
Reviewed by Darin Adler.
../WebKit/gtk:
* webkit/webkitwebview.cpp:
(webkit_web_view_popup_menu_handler):
../WebKit/win:
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::rectOnScreen):
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::frameRectsChanged):
* WebFrame.cpp:
(WebFrame::computePageRects):
* WebScrollBar.cpp:
(WebScrollBar::frameRect):
* WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::visibleContentRect):
(WebView::prepareCandidateWindow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 2 Feb 2011 18:29:28 +0000 (18:29 +0000)]
Conversion of right()/bottom() to maxX()/maxY() as part of the removal of those accessors.
Reviewed by Darin Adler.
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::prepareCandidateWindow):
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 2 Feb 2011 18:06:27 +0000 (18:06 +0000)]
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] po files path update after the code moved to Source
https://bugs.webkit.org/show_bug.cgi?id=53599
* POTFILES: Add Source to the path of the files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 2 Feb 2011 18:05:28 +0000 (18:05 +0000)]
2011-02-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add test for OPTIONS requests caused by CORS preflight checking to appear in Network panel
https://bugs.webkit.org/show_bug.cgi?id=53501
* http/tests/inspector/network-preflight-options-expected.txt: Added.
* http/tests/inspector/network-preflight-options.html: Added.
* http/tests/inspector/resources/cors-target.php: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 2 Feb 2011 17:59:24 +0000 (17:59 +0000)]
2011-02-01 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Overflow in WebKit2 argument decoder buffer checking
https://bugs.webkit.org/show_bug.cgi?id=53536
* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::roundUpToAlignment): Tweak code a bit for clarity and to replace
C casts with C++ casts.
(CoreIPC::ArgumentDecoder::alignBufferPosition): Rearrange buffer calculation
so we don't do any math with the passed-in size, because that could overflow.
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 2 Feb 2011 17:00:06 +0000 (17:00 +0000)]
2011-02-02 Martin Robinson <mrobinson@igalia.com>
Skip another test that uses modal dialogs.
* platform/gtk/Skipped: Skip modal dialog test and update bug in the skipped list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 2 Feb 2011 15:00:55 +0000 (15:00 +0000)]
Use Vector instead of a linked list for rules in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=53581
Reviewed by Maciej Stachowiak.
- eliminate CSSRuleDataList, replace with Vector<RuleData>
- rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet
(these are selector internal classes, CSS prefix is better reserved for public ones).
- constify a bit
- shrink the vectors to fit after collecting the rules
* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::getIDRules):
(WebCore::RuleSet::getClassRules):
(WebCore::RuleSet::getTagRules):
(WebCore::RuleSet::getPseudoRules):
(WebCore::RuleSet::getUniversalRules):
(WebCore::RuleSet::getPageRules):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::RuleSet::collectIdsAndSiblingRules):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::addMatchedRule):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 2 Feb 2011 14:08:21 +0000 (14:08 +0000)]
2011-02-02 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Use DIVs instead of TABLE in TextViewer
https://bugs.webkit.org/show_bug.cgi?id=53299
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype._mouseDown):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer):
(WebInspector.TextViewer.prototype.set mimeType):
(WebInspector.TextViewer.prototype.revealLine):
(WebInspector.TextViewer.prototype.addDecoration):
(WebInspector.TextViewer.prototype.removeDecoration):
(WebInspector.TextViewer.prototype.markAndRevealRange):
(WebInspector.TextViewer.prototype.highlightLine):
(WebInspector.TextViewer.prototype.clearLineHighlight):
(WebInspector.TextViewer.prototype.freeCachedElements):
(WebInspector.TextViewer.prototype._handleKeyDown):
(WebInspector.TextViewer.prototype.editLine.finishEditing):
(WebInspector.TextViewer.prototype.editLine):
(WebInspector.TextViewer.prototype.beginUpdates):
(WebInspector.TextViewer.prototype.endUpdates):
(WebInspector.TextViewer.prototype.resize):
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextViewer.prototype._updatePanelOffsets):
(WebInspector.TextViewer.prototype._syncScroll):
(WebInspector.TextViewer.prototype._syncDecorationsForLine):
(WebInspector.TextEditorChunkedPanel):
(WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener):
(WebInspector.TextEditorChunkedPanel.prototype.get textModel):
(WebInspector.TextEditorChunkedPanel.prototype.addDecoration):
(WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
(WebInspector.TextEditorChunkedPanel.prototype.revealLine):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype.textChanged):
(WebInspector.TextEditorChunkedPanel.prototype.beginUpdates):
(WebInspector.TextEditorChunkedPanel.prototype.endUpdates):
(WebInspector.TextEditorChunkedPanel.prototype.resize):
(WebInspector.TextEditorChunkedPanel.prototype._scroll):
(WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
(WebInspector.TextEditorChunkedPanel.prototype._chunkForLine):
(WebInspector.TextEditorGutterPanel):
(WebInspector.TextEditorGutterPanel.prototype.freeCachedElements):
(WebInspector.TextEditorGutterPanel.prototype._createNewChunk):
(WebInspector.TextEditorGutterPanel.prototype._expandChunks):
(WebInspector.TextEditorGutterChunk):
(WebInspector.TextEditorGutterChunk.prototype.get expanded):
(WebInspector.TextEditorGutterChunk.prototype.set expanded):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorGutterChunk.prototype._createRow):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine):
(WebInspector.TextEditorMainPanel.prototype.set mimeType):
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype.highlightLine):
(WebInspector.TextEditorMainPanel.prototype.clearLineHighlight):
(WebInspector.TextEditorMainPanel.prototype.freeCachedElements):
(WebInspector.TextEditorMainPanel.prototype._buildChunks):
(WebInspector.TextEditorMainPanel.prototype._createNewChunk):
(WebInspector.TextEditorMainPanel.prototype._expandChunks):
(WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight):
(WebInspector.TextEditorMainPanel.prototype._getSelection):
(WebInspector.TextEditorMainPanel.prototype._restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._positionToSelection):
(WebInspector.TextEditorMainPanel.prototype._appendTextNode):
(WebInspector.TextEditorMainPanel.prototype._handleDomUpdates):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.set expanded):
(WebInspector.TextEditorMainChunk.prototype.get height):
(WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow):
(WebInspector.TextEditorMainChunk.prototype._createRow):
(WebInspector):
* inspector/front-end/textViewer.css:
(.text-editor-lines):
(.text-editor-contents):
(.text-editor-editable):
(.webkit-line-decorations):
(.webkit-line-number):
(.webkit-execution-line.webkit-line-content):
(.diff-container .webkit-added-line.webkit-line-content):
(.diff-container .webkit-removed-line.webkit-line-content):
(.diff-container .webkit-changed-line.webkit-line-content):
(.webkit-highlighted-line.webkit-line-content):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 2 Feb 2011 13:55:01 +0000 (13:55 +0000)]
2011-02-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Removed some custom Chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 2 Feb 2011 10:10:54 +0000 (10:10 +0000)]
2011-02-02 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421
Layout test for cursor updates.
* storage/indexeddb/cursor-update-expected.txt: Added.
* storage/indexeddb/cursor-update.html: Added.
2011-02-02 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421
Implement support for cursor updates using the same pattern as cursor
deletes: forward the calls to the IDBObjectStoreBackend::put().
The put() function's signature needs to be changed to allow for a
"cursor update mode". This makes the signature more clear anyway,
since it replaces the boolean parameter.
Test: storage/indexeddb/cursor-update.html
* storage/IDBCursor.idl:
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::key):
(WebCore::IDBCursorBackendImpl::update):
* storage/IDBCursorBackendImpl.h:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
* storage/IDBObjectStoreBackendImpl.h:
* storage/IDBObjectStoreBackendInterface.h:
2011-02-02 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421
Mirror the update to the IDBObjectStoreInterface::put() signature in
the WebKit layer wrappers.
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::put):
* src/IDBObjectStoreProxy.cpp:
(WebCore::IDBObjectStoreProxy::put):
* src/IDBObjectStoreProxy.h:
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::put):
* src/WebIDBObjectStoreImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 2 Feb 2011 08:50:41 +0000 (08:50 +0000)]
2011-02-02 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kent Tamura.
Fix popup menu RTL bug introduced by Changeset 75982.
https://bugs.webkit.org/show_bug.cgi?id=53567
PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect().
No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position.
(WebCore::PopupContainer::showPopup): Change the passing parameter.
(WebCore::PopupContainer::refresh): Change the passing parameter.
* platform/chromium/PopupMenuChromium.h: Change the parameter declaration.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 2 Feb 2011 08:49:32 +0000 (08:49 +0000)]
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579
* GNUmakefile.am: Added WriteBarrier.h to the sources, it was
added in r77151
2011-02-02 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579
* GNUmakefile.am: Added FontWidthVariant.h to the sources, it was
added in r77153.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 2 Feb 2011 08:24:08 +0000 (08:24 +0000)]
2011-02-02 Dai Mikurube <dmikurube@google.com>
Reviewed by David Levin.
Make mime type lookup in File::create(path) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=47700
This patch introduces a new function MIMETypeRegistry::getMIMETypeForExtensionThreadSafe().
The function is to be called as a thread-safe version of getMIMETypeForExtension() when
both FILE_SYSTEM and WORKERS are enabled.
No tests for this patch. This patch itself doesn't change the behaviors.
For Chromium, it runs in the same way with getMIMETypeForExtensionThreadSafe().
For the other platforms, it causes compilation error in case of enabled FILE_SYSTEM and WORKERS.
The compilation error would be a signal to implement getMIMETypeForExtensionThreadSafe() in these
platforms. Currently it doesn't happen since FILE_SYSTEM is not available in the other platforms.
* platform/MIMETypeRegistry.cpp: Defined generic getMIMETypeForExtension() calling getMIMETypeForExtensionThreadSafe() for enabled FILE_SYSTEM and WORKERS.
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/MIMETypeRegistry.h: Declared getMIMETypeForExtensionThreadSafe() which should be implemented for each platform.
* platform/android/TemporaryLinkStubs.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/brew/MIMETypeRegistryBrew.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/chromium/MIMETypeRegistryChromium.cpp: Defined getMIMETypeForExtensionThreadSafe() for the case when FILE_SYSTEM and WORKERS are enabled.
(WebCore::MIMETypeRegistry::getMIMETypeForExtensionThreadSafe):
* platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/gtk/MIMETypeRegistryGtk.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/haiku/MIMETypeRegistryHaiku.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/mac/MIMETypeRegistryMac.mm:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/qt/MIMETypeRegistryQt.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/win/MIMETypeRegistryWin.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/wince/MIMETypeRegistryWinCE.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
* platform/wx/MimeTypeRegistryWx.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 2 Feb 2011 08:13:41 +0000 (08:13 +0000)]
2011-02-02 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
[Chromium] Propagate the accurate gesture status when calling into FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=53571
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::loadFrameRequest): FrameLoader might decide the target is a new window, so make such the UserGestureIndicator is fully accurate before calling into it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 2 Feb 2011 08:00:19 +0000 (08:00 +0000)]
2011-02-01 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Improve readability of updateWidget by converting bool parameter to an enum
https://bugs.webkit.org/show_bug.cgi?id=53576
As requested on webkit-dev.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
* html/HTMLEmbedElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateWidget):
* html/HTMLMediaElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
* html/HTMLObjectElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
* html/HTMLPlugInImageElement.h:
* page/FrameView.cpp:
(WebCore::FrameView::updateWidget):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 2 Feb 2011 07:06:51 +0000 (07:06 +0000)]
Unreviewed.
Fix Qt build after r77339.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::enterAcceleratedCompositingMode):
(QWKPagePrivate::exitAcceleratedCompositingMode):
* UIProcess/API/qt/qwkpage_p.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 2 Feb 2011 07:02:52 +0000 (07:02 +0000)]
2011-02-01 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566
Unskip test that we now pass.
* platform/chromium/test_expectations.txt:
2011-02-01 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566
A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html.
Other than being large enough for this one test case, this limit is arbitrary.
* bindings/v8/V8Proxy.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 2 Feb 2011 06:00:17 +0000 (06:00 +0000)]
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
make draft comments focusable
https://bugs.webkit.org/show_bug.cgi?id=53554
Makes frozen draft comments focusable. The ones that are currently being edited are not.
I'm on the fence whether they should be, but this seems good enough for now.
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 2 Feb 2011 05:17:38 +0000 (05:17 +0000)]
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
avoid jitter when loading the comments to a patch
https://bugs.webkit.org/show_bug.cgi?id=53570
* code-review.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77362
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 2 Feb 2011 05:13:39 +0000 (05:13 +0000)]
2011-02-01 Adam Barth <abarth@webkit.org>
Reviewed by Andreas Kling.
Remove useless comment
https://bugs.webkit.org/show_bug.cgi?id=53549
The reason for this parameter is captured in
plugins/netscape-plugin-setwindow-size.html, which is a better place to
capture it than in this comment (which otherwise just re-iterates the
name of the parameter).
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 2 Feb 2011 05:05:55 +0000 (05:05 +0000)]
2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538
caused leopard crashes (Requested by paroga on #webkit).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::fromUTF8):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::calculateStringHashFromUTF8):
* wtf/unicode/UTF8.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77360
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 2 Feb 2011 03:02:04 +0000 (03:02 +0000)]
2011-02-01 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
fast/css/box-shadow.html was removed in r77101 but there was
still a reference to it in the expectations file.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Wed, 2 Feb 2011 02:57:35 +0000 (02:57 +0000)]
2011-02-01 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Gentilcore.
[WebTiming] Remove asserts that verify timestamp order
https://bugs.webkit.org/show_bug.cgi?id=53548
Covered by existing tests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Remove assert.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchTimedEvent): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 02:50:21 +0000 (02:50 +0000)]
2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
Add the 'default_targets' enclosure to the flags.
* WebCore.gyp/WebCore.gyp: Did it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 2 Feb 2011 02:39:31 +0000 (02:39 +0000)]
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Add tests for a scroll event triggered right before a modal dialog is
shown.
* fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
* fast/events/scroll-event-during-modal-dialog.html: Added.
2011-02-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202
Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).
Test: fast/events/scroll-event-during-modal-dialog.html
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/EventQueue.cpp:
(WebCore::EventQueueTimer::EventQueueTimer):
(WebCore::EventQueueTimer::fired):
(WebCore::EventQueue::EventQueue):
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::pendingEventTimerFired):
* dom/EventQueue.h:
(WebCore::EventQueue::create):
* page/SuspendableTimer.cpp:
(WebCore::SuspendableTimer::SuspendableTimer):
(WebCore::SuspendableTimer::suspend):
(WebCore::SuspendableTimer::resume):
* page/SuspendableTimer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77355
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 2 Feb 2011 02:32:22 +0000 (02:32 +0000)]
2011-02-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
new-run-webkit-tests: stop skipping so many tests
r77163 introduced a regression where we weren't resetting test
expectations properly and were skipping too many tests as a
result. This patch fixes that and adds a test for it.
https://bugs.webkit.org/show_bug.cgi?id=53551
* Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
* Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 2 Feb 2011 02:18:20 +0000 (02:18 +0000)]
2011-02-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Change wrong PLATFORM(WIN) to USE(WININET)
https://bugs.webkit.org/show_bug.cgi?id=53547
* platform/network/ResourceHandle.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Wed, 2 Feb 2011 02:05:59 +0000 (02:05 +0000)]
32-bit build fix.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 2 Feb 2011 01:53:27 +0000 (01:53 +0000)]
2011-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563
* platform/chromium/test_expectations.txt:
fast/css/font-weight-1.html is expected to fail.
2011-02-01 Kent Tamura <tkent@chromium.org>
Reviewed by Tony Chang.
[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563
* DEPS: Roll to crrev.com/73378 to have the WebKitWeightWatcher change of webkit_support.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 01:49:59 +0000 (01:49 +0000)]
2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
Marking test, added in r77333 as skipped, because it is
reaching V8 recursion limits faster than those on Document.
* platform/chromium/test_expectations.txt: See above.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Feb 2011 01:45:48 +0000 (01:45 +0000)]
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Attach the layer tree in the UI process
https://bugs.webkit.org/show_bug.cgi?id=53560
* UIProcess/API/mac/WKView.mm:
(-[WKView _enterAcceleratedCompositingMode:]):
Make a render layer and add it as a sublayer of our root layer.
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
Make LayerTreeHostMac a GraphicsLayerClient.
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):
Create a root layer, add the layer subtree as a child of the root layer.
(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
Assert that m_rootLayer is null.
(WebKit::LayerTreeHostMac::invalidate):
Null out m_rootLayer.
(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifySyncRequired):
(WebKit::LayerTreeHostMac::paintContents):
Add stubs.
(WebKit::LayerTreeHostMac::showDebugBorders):
(WebKit::LayerTreeHostMac::showRepaintCounter):
Return the correct settings.
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the root layer changes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 2 Feb 2011 01:31:28 +0000 (01:31 +0000)]
2011-01-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057
* platform/gtk/Skipped: Unskip tests which are no longer crashing.
2011-01-25 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057
Instead of creating synchronous ResourceHandles manually, use the ::create factory.
This ensures that ::start() is not called when there is a scheduled failure and also
reduces code duplication.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 2 Feb 2011 01:16:29 +0000 (01:16 +0000)]
2011-02-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add first stub of test_runner2. This
will add support for the 'inline', 'threads', and 'processes'
flags to --worker-model, but for now the implementatios just
fall back on the old ones.
https://bugs.webkit.org/show_bug.cgi?id=53157
* Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 2 Feb 2011 01:12:45 +0000 (01:12 +0000)]
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
[codereviewtool] extra space at the beginning of lines in side-by-side view
https://bugs.webkit.org/show_bug.cgi?id=53550
The newline between the spans turns into user-visible space in side-by-side mode.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Feb 2011 01:11:14 +0000 (01:11 +0000)]
Fix Windows build.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
* UIProcess/win/WebView.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Feb 2011 01:09:34 +0000 (01:09 +0000)]
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Add a layer backed NSView for accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53555
Rename the current _layerHostingView to _oldLayerHostingView and
add a new _layerHostingView to be used with the new drawing area.
* UIProcess/API/mac/WKView.mm:
(-[WKView hitTest:]):
(-[WKView _startAcceleratedCompositing:]):
(-[WKView _stopAcceleratedCompositing]):
(-[WKView _enterAcceleratedCompositingMode:]):
(-[WKView _exitAcceleratedCompositingMode]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 2 Feb 2011 01:04:53 +0000 (01:04 +0000)]
2011-02-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] GObject DOM bindings do no support the CallWith attribute
https://bugs.webkit.org/show_bug.cgi?id=53331
Disable building GObject DOM bindings for IndexedDB because we do not support
the CallWith attribute at this time.
* bindings/gobject/GNUmakefile.am: Disable building bindings for the IndexedDB API.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 2 Feb 2011 01:01:05 +0000 (01:01 +0000)]
2011-02-01 Darin Adler <darin@apple.com>
Reviewed by Brady Eidson.
Fix a couple loose ends from the back/forward tree encode/decode work
https://bugs.webkit.org/show_bug.cgi?id=53537
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode): Remove extra copy of
original URL string; no need to encode it twice.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.
* history/HistoryItem.h: Removed declaration for function that is no
longer defined nor used.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 2 Feb 2011 00:55:40 +0000 (00:55 +0000)]
2011-02-01 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] disable arm uninitialized variable warnings
https://bugs.webkit.org/show_bug.cgi?id=53553
We just got another error:
third_party/WebKit/Source/WebCore/css/CSSPrimitiveValue.cpp:123:error:
'colorTransparent.unstatic.4879' may be used uninitialized in this
function
* WebCore.gyp/WebCore.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 2 Feb 2011 00:48:26 +0000 (00:48 +0000)]
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Pass enter/exit accelerated compositing mode to the WKView
https://bugs.webkit.org/show_bug.cgi?id=53552
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
* UIProcess/API/mac/WKView.mm:
(-[WKView _enterAcceleratedCompositingMode:]):
(-[WKView _exitAcceleratedCompositingMode]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
* UIProcess/WebPageProxy.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 2 Feb 2011 00:22:52 +0000 (00:22 +0000)]
2011-02-01 chris reiss <christopher.reiss@nokia.com>
Reviewed by Adam Barth.
Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123
* fast/dom/Document/document-close-iframe-load-expected.txt: Added.
* fast/dom/Document/document-close-iframe-load.html: Added.
* fast/dom/Document/document-close-nested-iframe-load-expected.txt: Added.
* fast/dom/Document/document-close-nested-iframe-load.html: Added.
* fast/dom/Document/document-write-recursion-expected.txt: Added.
* fast/dom/Document/document-write-recursion.html: Added.
2011-02-01 chris reiss <christopher.reiss@nokia.com>
Reviewed by Adam Barth.
Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123
Here we are replicating the Firefox safeguard against
recursive document.write( ) 's.
See https://bug197052.bugzilla.mozilla.org/attachment.cgi?id=293907 in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=197052 . Firefox does two things -
a) imposes a recursion limit of 20 on document.write( ) and
b) once that limit is passed, panics all the way the call stack (rather than just returning one level.)
To see why this is necessary, consider the script :
<script>
var t = document.body.innerHTML;
document.write(t);
</script>
This will create a tree both broad and deep as the script keeps appending itself to the text. If
we just return one level after the recursion limit is reached, we still allow millions of copies to
duplicate (and execute).
The recursion is fortunately depth-first, so as soon as we cross this limit, we panic up the callstack
to prevent this situation. (IE apparently does the same thing, with a lower recursion limit.)
Test: fast/dom/Document/document-write-recursion.html
Test: fast/dom/Document/document-close-iframe-load.html
Test: fast/dom/Document/document-close-nested-iframe-load.html
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::write):
* dom/Document.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 2 Feb 2011 00:12:04 +0000 (00:12 +0000)]
2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
Updated text expectations to avoid conflict.
* platform/chromium/test_expectations.txt: Tweaked.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 2 Feb 2011 00:05:19 +0000 (00:05 +0000)]
2011-02-01 Ojan Vafai <ojan@chromium.org>
Increment version number to cache-bust code-review.js.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 2 Feb 2011 00:00:36 +0000 (00:00 +0000)]
2011-01-31 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
Store draft comments in localStorage
https://bugs.webkit.org/show_bug.cgi?id=52866
* code-review.js:
* code-review-test.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jnd@chromium.org [Tue, 1 Feb 2011 23:52:27 +0000 (23:52 +0000)]
2011-02-01 Johnny Ding <jnd@chromium.org>
Reviewed by Darin Adler.
Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424
* fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt: Added.
* fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html: Added.
2011-02-01 Johnny Ding <jnd@chromium.org>
Reviewed by Darin Adler.
Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424
Test: fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html
* html/HTMLAnchorElement.cpp:
(WebCore::handleLinkClick):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 1 Feb 2011 23:50:58 +0000 (23:50 +0000)]
Unreviewed Qt buildfix after r77286.
https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.
Source/WebCore:
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTiles):
Source/WebKit/qt:
* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
Source/WebKit2:
* UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 1 Feb 2011 23:46:41 +0000 (23:46 +0000)]
2011-02-01 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 1 Feb 2011 23:32:46 +0000 (23:32 +0000)]
2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538
caused leopard crashes (Requested by paroga on #webkit).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/AtomicString.cpp:
(WTF::AtomicString::fromUTF8):
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::calculateStringHashFromUTF8):
* wtf/unicode/UTF8.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 1 Feb 2011 23:26:15 +0000 (23:26 +0000)]
2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>
Updated baselines after switching input-derived parts of HTMLMediaElement
to use shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=53314
* platform/chromium-linux/media/video-zoom-controls-expected.checksum: Updated.
* platform/chromium-linux/media/video-zoom-controls-expected.png: Updated.
* platform/chromium-mac/media/video-zoom-controls-expected.checksum: Updated.
* platform/chromium-mac/media/video-zoom-controls-expected.png: Updated.
* platform/chromium-mac/media/video-zoom-controls-expected.txt: Updated.
* platform/chromium-win/media/video-zoom-controls-expected.checksum: Updated.
* platform/chromium-win/media/video-zoom-controls-expected.png: Updated.
* platform/chromium-win/media/video-zoom-controls-expected.txt: Updated.
* platform/chromium/test_expectations.txt: Expectation of failure removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 1 Feb 2011 23:20:09 +0000 (23:20 +0000)]
Fix Mac production builds.
../JavaScriptCore:
* JavaScriptCore.xcodeproj/project.pbxproj:
../WebCore:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollbarThemeMac.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 1 Feb 2011 23:05:34 +0000 (23:05 +0000)]
2011-02-01 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Test not crashing on chromium, was crashing earlier because of
some build issues. Also, rebaselining chromium mac since it matches
rest of chromium and is not same as mac leopard.
https://bugs.webkit.org/show_bug.cgi?id=53516
* platform/chromium-mac/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Tue, 1 Feb 2011 23:04:18 +0000 (23:04 +0000)]
2011-02-01 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[chromium] Remove unnecessary WebCore:: prefixing in a few places and fix-up some indentation.
https://bugs.webkit.org/show_bug.cgi?id=53523
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::inspectNode):
(WebKit::WebDevToolsAgentImpl::inspectorController):
(WebKit::WebDevToolsAgentImpl::mainFrame):
(WebKit::WebDevToolsAgentImpl::identifierForInitialRequest):
(WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
(WebKit::WebDevToolsAgent::interruptAndDispatch):
(WebKit::WebDevToolsAgent::processPendingMessages):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::resize):
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::setLocation):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
(WebKit::WebScrollbarImpl::scrollPosition):
(WebKit::WebScrollbarImpl::setScrollOffset):
(WebKit::WebScrollbarImpl::invalidateScrollbarRect):
(WebKit::WebScrollbarImpl::getTickmarks):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 1 Feb 2011 22:56:36 +0000 (22:56 +0000)]
Fix Qt bustage.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 1 Feb 2011 22:52:02 +0000 (22:52 +0000)]
Fix Qt bustage.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 1 Feb 2011 22:51:45 +0000 (22:51 +0000)]
2011-02-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Send messages when entering/exiting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53534
* Shared/LayerTreeContext.h: Added.
* Shared/mac/LayerTreeContextMac.mm: Added.
Add new LayerTreeContext which holds all information needed to enter
accelerated compositing mode.
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
Add empty stubs.
* UIProcess/DrawingAreaProxy.messages.in:
Add new messgaes.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
* UIProcess/DrawingAreaProxyImpl.h:
Add empty stubs.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):
(WebKit::LayerTreeHostMac::invalidate):
Send messages.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 1 Feb 2011 22:49:01 +0000 (22:49 +0000)]
2011-02-01 Darin Adler <darin@apple.com>
Reviewed by Chris Fleizach.
REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169
Test: fast/images/imagemap-scroll.html
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::setFocus): Added override. Calls the new
RenderImage::areaElementFocusChanged function.
(WebCore::HTMLAreaElement::updateFocusAppearance): Removed the code
here that calls setNeedsLayout on the image's renderer. This was an
attempt to cause repaint of the renderer, but this function does not
need to do that. Also changed this to use the imageElement function
to avoid repeating code.
* html/HTMLAreaElement.h: Updated for above changes.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint): Updated for name change.
(WebCore::RenderImage::paintAreaElementFocusRing): Renamed this from
paintFocusRing, because it only paints area focus rings, and should
not be confused with paintFocusRing functions in other classes. Also
removed the unused style argument. Removed the code that used an
HTMLCollection to see if the focused area element is for this image
and instead just call imageElement on the area element.
(WebCore::RenderImage::areaElementFocusChanged): Added. Calls repaint.
* rendering/RenderImage.h: Added a public areaElementFocusChanged
function for HTMLAreaElement to call. Made the paintFocusRing function
private, renamed it to paintAreaElementFocusRing, and removed its
unused style argument.
2011-02-01 Darin Adler <darin@apple.com>
Reviewed by Chris Fleizach.
REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169
* fast/images/imagemap-scroll-expected.txt: Added.
* fast/images/imagemap-scroll.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit.git / log