alp@webkit.org [Sat, 5 Jan 2008 10:23:01 +0000 (10:23 +0000)]
2008-01-05 Sylvain Pasche <sylvain.pasche@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16736
Allow autogen.sh invocation from a separate build directory.
* autogen.sh:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 5 Jan 2008 08:26:08 +0000 (08:26 +0000)]
2008-01-05 Henry Mason <hmason@mac.com>
Reviewed by Maciej Stachowiak.
http://bugs.webkit.org/show_bug.cgi?id=16738
Bug 16738: Collector block offset could be stored as an cell offset instead of a byte offset
Gives a 0.4% SunSpider boost and prettier code.
* kjs/collector.cpp: Switched to cell offsets from byte offsets
(KJS::Collector::heapAllocate):
(KJS::Collector::sweep):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 5 Jan 2008 08:02:06 +0000 (08:02 +0000)]
Have the two malloc zones print useful diagnostics if their free method are unexpectedly invoked.
Due to <rdar://problem/
5671357> this can happen if an application attempts to free a pointer that
was not allocated by any registered malloc zone on the system.
Reviewed by Maciej Stachowiak.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 5 Jan 2008 05:45:06 +0000 (05:45 +0000)]
- update the list of tests failing on Windows because of font
differences and uncomment a test that has been re-enabled on Mac.
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 5 Jan 2008 05:20:11 +0000 (05:20 +0000)]
Fix bounds computation bugs responsible for bugs.webkit.org/show_bug.cgi?id=16015
and other image repaint bugs.
Reviewed by Beth Dakin.
We now cache the full local bounds for the <image> element, as otherwise certain
combinations of attribute changes could result in incorrect dirty rects.
Additionally we no longer use any of the integer bounds fields on RenderObject for
determining repaint bounds (this was the principle cause of bug #16015).
I also removed the outline painting code as it was both wrong, and not correctly
repainted. I feel safe doing this as no other browser or viewer supports outline
properties on svg elements.
I was unable to make a testcase for this unfortunately, despite seemingly deterministic
behaviour :(
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 5 Jan 2008 05:13:25 +0000 (05:13 +0000)]
WebCore:
Reviewed by Oliver.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
Prevent :enabled and :disabled from applying to input type="hidden"
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkOneSelector): Rather than
allowing :enabled and :disabled to apply to all controls, only
allow it to apply to non-"hidden" controls
* dom/Element.h:
(WebCore::Element::isInputTypeHidden):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isInputTypeHidden):
LayoutTests:
Reviewed by Oliver.
Test for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
type="hidden" matches :enabled/:disabled (Acid3 bug)
* fast/forms/hidden-input-not-enabled-expected.txt: Added.
* fast/forms/hidden-input-not-enabled.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 5 Jan 2008 04:05:30 +0000 (04:05 +0000)]
Add missing expected result.
* fast/images/border-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 5 Jan 2008 04:04:31 +0000 (04:04 +0000)]
WebCore:
Reviewed by Oliver Hunt.
- Match the spec when calling getFloatValue, getStringValue, getCounterValue,
getRectValue and getRGBColorValue of CSSPrimitiveValue by throwing exceptions
if the type of the CSSPrimitiveValue is not the same as the type requested.
- Fix the intermittent assertion failure seen in svg/css/glyph-orientation-rounding-test.xhtml
Test: fast/css/CSSPrimitiveValue-exceptions.html
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getRGBColorValue):
(WebCore::CSSPrimitiveValue::getPairValue):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getFloatValue):
(WebCore::CSSPrimitiveValue::getIntValue):
(WebCore::CSSPrimitiveValue::getCounterValue):
(WebCore::CSSPrimitiveValue::getRectValue):
(WebCore::CSSPrimitiveValue::getDashboardRegionValue):
* css/CSSPrimitiveValue.idl:
LayoutTests:
Reviewed by Oliver Hunt.
Throw exceptions for the CSSPrimitiveValue getters, matching the spec.
* fast/css/CSSPrimitiveValue-exceptions-expected.txt: Added.
* fast/css/CSSPrimitiveValue-exceptions.html: Added.
* fast/css/resources/CSSPrimitiveValue-exceptions.js: Added.
* fast/dom/prototypes.html:
* fast/dom/wrapper-classes.html:
* platform/mac/fast/dom/wrapper-classes-objc.html:
* svg/css/glyph-orientation-rounding-test-expected.txt:
* svg/css/glyph-orientation-rounding-test.xhtml: Pass in a unit so this doesn't throw.
This patch also fixes the associated intermittent failure seen in this test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sat, 5 Jan 2008 02:32:12 +0000 (02:32 +0000)]
Reviewed by Darin.
Windows part of <rdar://problem/
5647034>
Media tests crash if an old version of QuickTime is installed
Check QuickTime version on Windows too.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 5 Jan 2008 01:51:02 +0000 (01:51 +0000)]
Reviewed by Kevin McCullough.
- Splits Objective-C tests out of wrapper-classes.html and into platform specific test.
- Adds tests for .__proto__ and .constructor to JS wrapper tests.
* fast/dom/wrapper-classes.html:
* platform/mac/fast/dom/wrapper-classes-expected.txt:
* platform/mac/fast/dom/wrapper-classes-objc-expected.txt: Added.
* platform/mac/fast/dom/wrapper-classes-objc.html: Copied from fast/dom/wrapper-classes.html.
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Sat, 5 Jan 2008 01:45:31 +0000 (01:45 +0000)]
Move svg/batik/text/smallFonts.svg
to skip list since it is still failing on tiger.
* platform/mac-tiger/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 5 Jan 2008 01:11:12 +0000 (01:11 +0000)]
WebCore:
Reviewed by Maciej and Alice.
- fix <rdar://problem/
4404302> Borders where there should be none (canadasmountains.com)
Test: fast/images/border.html
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute): Change the code that handles cases
where the border value is not a number to use the value "0" for the border width instead
of not setting the border width and style at all. This matches other browsers, and makes
more sense.
LayoutTests:
Reviewed by Maciej and Alice.
- test for <rdar://problem/
4404302> Borders where there should be none (canadasmountains.com)
* fast/images/border.html: Added.
* fast/images/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
* fast/images/resources/border.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Sat, 5 Jan 2008 00:32:52 +0000 (00:32 +0000)]
WebKitTools:
Reviewed by Alexey and Darin.
Adding "home" and "end" to DRT's keydown since
DOM key events can't handle keyIdentifiers at this point.
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:]):
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
LayoutTests:
Reviewed by Alexey and Darin.
* editing/selection/move-begin-end.html:
add a codepath that will test the same kind of functionality for home and end keys
* platform/win/Skipped:
removing section of tests that have been resolved
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sat, 5 Jan 2008 00:28:13 +0000 (00:28 +0000)]
Try to fix 64-bit build
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::isAvailable):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Sat, 5 Jan 2008 00:15:29 +0000 (00:15 +0000)]
Fix another stringImpl leak.
* platform/text/StringImpl.cpp: remove an extra allocation
(WebCore::StringImpl::StringImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 4 Jan 2008 23:34:39 +0000 (23:34 +0000)]
Reviewed by Mitz.
* platform/graphics/win/FontCacheWin.cpp:
fix loop condition that was causing crash
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 4 Jan 2008 22:56:41 +0000 (22:56 +0000)]
Update tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger platform
RS=Adam
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 4 Jan 2008 22:43:44 +0000 (22:43 +0000)]
Reviewed by Adam Roben.
<rdar://problem/
5671059> Always show the Timeline and Console buttons in the Inspector
* page/inspector/inspector.css: Remove styles related to the toggle button
and make the area always visible.
* page/inspector/inspector.html: Remove the toggle button.
* page/inspector/inspector.js: Remove code to toggle the status area.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 4 Jan 2008 22:35:29 +0000 (22:35 +0000)]
Reviewed by Adam Roben.
Restore compatibility with shipping Safari beta.
WebKit:
http://bugs.webkit.org/show_bug.cgi?id=16733
REGRESSION: Crash on Safari Start
* Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.
WebCore:
Temporarily restore BackwardDelete for Windows nightlies to work correctly.
* editing/EditorCommand.cpp: (WebCore::CommandEntry::):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 4 Jan 2008 22:27:34 +0000 (22:27 +0000)]
Reviewed by Darin.
<rdar://problem/
5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)
Enable the fix on Windows.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 4 Jan 2008 22:08:43 +0000 (22:08 +0000)]
Fix build.
* bindings/js/JSHTMLElementWrapperFactory.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 4 Jan 2008 21:44:52 +0000 (21:44 +0000)]
Reviewed by Darin.
Partial fix for <rdar://problem/
5647034>
Media tests crash if an old version of QuickTime is installed
Disable media support if QuickTime is not current enough (>=7.3).
Windows patch coming soon.
* bindings/js/JSHTMLElementWrapperFactory.cpp:
(WebCore::createJSHTMLWrapper):
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty):
* html/HTMLElementFactory.cpp:
(WebCore::audioConstructor):
(WebCore::videoConstructor):
(WebCore::sourceConstructor):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::isAvailable):
* platform/graphics/MediaPlayer.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::isAvailable):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 4 Jan 2008 21:02:16 +0000 (21:02 +0000)]
Reviewed by Darin Adler.
<rdar://problem/
5604409> JavaScript privilege escalation when Web Inspector accesses page unsafely (16011)
Check if the property is a getter before asking for the value.
If the property is a getter, we no longer show the value.
* page/inspector/PropertiesSidebarPane.js:
* page/inspector/inspector.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 20:54:24 +0000 (20:54 +0000)]
2008-01-04 Alp Toker <alp@atoker.com>
Rubber-stamped by Mark Rowe.
Remove AM_MAINTAINER_MODE, as recommended by the automake manual. The
"rebuild rules" will now be enabled by default.
This obviates the need to pass '--enable-maintainer-mode' to
configure.
* configure.ac:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Jan 2008 19:31:37 +0000 (19:31 +0000)]
Fix <rdar://
4968855> Shift-PageUp/Shift-PageDown only select one line of text
WebKit/win:
Fix <rdar://
4968855> Shift-PageUp/Shift-PageDown only select one line of text
Test: platform/win/editing/selection/shift-page-down-up.html
Reviewed by Oliver.
* WebView.cpp: Correct the commands associated with
Shift-PageUp/Shift-PageDown.
LayoutTests:
Added a test for <rdar://
4968855> Shift-PageUp/Shift-PageDown only select one line of text
Reviewed by Oliver.
* platform/win/editing/selection/shift-page-up-down-expected.txt: Added.
* platform/win/editing/selection/shift-page-up-down.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 4 Jan 2008 19:25:37 +0000 (19:25 +0000)]
<rdar://problem/
5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails
Reviewed by Darin
Regenerated expected output as filter elements are no longer generated in a default
build. This wasn't done when filters were turned off earlier due to other (now gone)
layout failures i didn't want to put in the expected output.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Jan 2008 19:23:07 +0000 (19:23 +0000)]
Reviewed by Darin Adler.
- fix synthetic bold and italic on Windows
Covered by an existing test.
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Jan 2008 17:18:24 +0000 (17:18 +0000)]
* platform/win/Skipped: Added some more failures.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 14:52:11 +0000 (14:52 +0000)]
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ autotools build fix. Terminate empty rules.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 14:49:50 +0000 (14:49 +0000)]
fix DRT after the changes to QWebPage.
The great thing is that we actually don't have
any regressions from the QWebPage change :)
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 14:49:32 +0000 (14:49 +0000)]
Remove most dependencies of Widget/ScrollView onto native QWidgets.
This also brings the code closer in line with the Windows code. Seems
to work nicely on first try :)
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 14:48:55 +0000 (14:48 +0000)]
* Remove the todo from QWebPage and move the code to QWebView.
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 14:48:37 +0000 (14:48 +0000)]
* Move the various event methods to QWebPagePrivate. This is similar to
QTextControl as well.
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 14:48:15 +0000 (14:48 +0000)]
* Forward the event from QWebView to QWebPage through QObject::event. This
is similar to the way QTextControl is working.
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 14:47:45 +0000 (14:47 +0000)]
make QWebPage a QObject and get things to compile.
Nothing works currently though.
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 12:26:03 +0000 (12:26 +0000)]
Added some preliminary class documentation for QWebView, fixed a missing const() and some missing Q_PROPERTYs
Signed-off-by: Lars
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 12:25:42 +0000 (12:25 +0000)]
add a viewportSize to QWebPage.
This is required to eventually make it a QObject only.
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 12:25:17 +0000 (12:25 +0000)]
take a QString as identifier in QWebFrame::addToJSWindowObject.
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 12:24:39 +0000 (12:24 +0000)]
Call the frame arguments for the javascript callbacks "originatingFrame"
Signed-off-by: Lars
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 12:24:19 +0000 (12:24 +0000)]
Moved the QWebPage::addToHistory signal into QWebHistoryInterface
Signed-off-by: Lars
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 4 Jan 2008 12:23:57 +0000 (12:23 +0000)]
moved title(), url(), icon() and initialLayoutComplete() from QWebPage to QWebFrame
Signed-off-by: Simon
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 12:19:24 +0000 (12:19 +0000)]
Fix bug URL in ChangeLog entry
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 12:18:22 +0000 (12:18 +0000)]
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/attachment.cgi?bugid=16667&action=enter
make -j is failing with the autotools based system
Support parallel code generation. Nearly every use of explicit
multiple targets was a potential concurrency bug, though in practice
the bison rules were the first to be noticed because they took longer
to complete and broke the build immediately.
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 10:44:18 +0000 (10:44 +0000)]
2008-01-04 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Re-use a single static dummy surface rather than creating and
destroying a surface for each CairoPath.
* platform/graphics/cairo/CairoPath.h:
(WebCore::CairoPath::CairoPath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 4 Jan 2008 08:16:39 +0000 (08:16 +0000)]
Tiger build fix.
* platform/Threading.h: The OSAtomic functions take non-volatile pointers on Tiger.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 08:05:36 +0000 (08:05 +0000)]
2008-01-04 Alp Toker <alp@atoker.com>
GTK+ DRT build fix for breakage introduced in r29149.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::execCommand):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 4 Jan 2008 07:55:49 +0000 (07:55 +0000)]
Use platform-provided atomic operations in place of inline assembly to increase portability.
Reviewed by Maciej Stachowiak.
* platform/Threading.h:
(WebCore::atomicIncrement):
(WebCore::atomicDecrement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 4 Jan 2008 07:31:40 +0000 (07:31 +0000)]
Reviewed by Darin.
<rdar://problem/
5463489> A number of layout tests should be using execCommand instead of textInputController
Added layoutTestController.execCommand to access editor commands that are not available
via document.execCommand.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 4 Jan 2008 07:15:25 +0000 (07:15 +0000)]
Fix <rdar://problem/
5668517> REGRESSION: Major under painting issues in SVG (carto.net dock example)
Revied by Maciej.
We need to cache the absolute bounds of the <image>,
as there's no reliable way to recompute the old bounding
box one we have started layout.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 06:34:56 +0000 (06:34 +0000)]
2008-01-03 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16654
[GTK] Signal "navigation-requested" does not react correctly on
return TRUE from callbacks
* WebView/webkitwebview.cpp: use our own accumulator for signals
returning WebKitNavigationResponse. The emission will be stopped
when any callback returns anything but
WEBKIT_NAVIGATION_RESPONSE_ACCEPT.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 4 Jan 2008 06:23:42 +0000 (06:23 +0000)]
2008-01-03 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Support building in Scratchbox, which has a version of make that fails
on wildcard syntax. Use a vpath to match IDL files instead.
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 4 Jan 2008 06:00:01 +0000 (06:00 +0000)]
- fix Safari build
* WebKit.xcodeproj/project.pbxproj: Mark header private (fixes Safari build).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 4 Jan 2008 05:41:56 +0000 (05:41 +0000)]
Update Tiger library to a G3-friendly version.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Jan 2008 04:38:08 +0000 (04:38 +0000)]
Reviewed by Sam Weinig.
- skip tests that are failing because font fallback results in a
different font being used on Windows than on Mac.
* platform/win/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Fri, 4 Jan 2008 04:22:38 +0000 (04:22 +0000)]
2008-01-03 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Darin.
<rdar://problem/
5504775> PDF page will not load first time after Adobe
Reader install, unless browser is relaunched
Refresh and re-search the plugin database if the MIME type is not
registered.
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabaseWin::isMIMETypeRegistered):
* plugins/win/PluginDatabaseWin.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 4 Jan 2008 04:03:46 +0000 (04:03 +0000)]
Update libraries for <rdar://problem/
4106190> Include "Where from" metadata in drag-and-dropped images
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Jan 2008 02:04:24 +0000 (02:04 +0000)]
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16548
<rdar://problem/
5659452> REGRESSION(r28810): Font style and sizes are weird for Japanese text
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::linkedFontEnumProc): Added. This callback is used to fetch
a valid LOGFONT for a given family.
(WebCore::getLinkedFonts): Added. Returns a vector of font families
linked to the given font family by the Windows registry key
HKLM\Software\...\FontLink\SystemLink. The registry values typically
differ based on the installed language version of Windows.
(WebCore::FontCache::getFontDataForCharacters): Changed to not use MLang
font mapping, which is Windows code page based, except for characters in
the range U+2000..U+200F. Instead, this function gets the font Uniscribe
would use for the character. However, that font might not actually
contain the character, in which case GDI font linking would substitute a
different font. Therefore, this function walks the linked font list
until it finds a font that actually contains the character.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 4 Jan 2008 01:28:27 +0000 (01:28 +0000)]
WebKitTools:
Reviewed by Darin, Mitz.
fixed <rdar://
5130762> mousedowns in different locations increase the clickcount incorrectly
the clickcount should not increase if the last click was at a different location. it's a new click.
* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest):
* DumpRenderTree/mac/EventSendingController.h:
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseDown]):
(-[EventSendingController mouseUp]):
LayoutTests:
Reviewed by Darin, Mitz.
updating expected results after fixing clickcount for
<rdar://
5130762> mousedowns in different locations increase the clickcount incorrectly
* fast/forms/focus-selection-input-expected.txt:
* fast/forms/focus-selection-textarea-expected.txt:
* platform/mac/fast/events/objc-event-api-expected.txt:
* platform/mac/fast/inline/dirtyLinesForInline-expected.txt:
* platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac/svg/custom/pointer-events-image-expected.txt:
* platform/mac/svg/custom/pointer-events-path-expected.txt:
* platform/mac/svg/custom/pointer-events-text-expected.txt:
* platform/mac/svg/custom/text-hit-test-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 4 Jan 2008 01:17:05 +0000 (01:17 +0000)]
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=16723
tables/mozilla/bugs/bug30418.html test failing due to problems updating dynamic border rules
Test: fast/table/border-changes.html
* html/HTMLTableElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseMappedAttribute): Check the border type before and after
parsing attributes, rather than doing this only for the rules attribute.
(WebCore::HTMLTableElement::cellBorders): Added.
(WebCore::HTMLTableElement::getSharedCellDecl): Changed to use cellBorders to factor out the
rule about what type of borders to use.
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=16723
tables/mozilla/bugs/bug30418.html test failing due to problems updating dynamic border rules
* fast/table/border-changes-expected.txt: Added.
* fast/table/border-changes.html: Added.
* fast/table/resources: Added.
* fast/table/resources/TEMPLATE.html: Added.
* fast/table/resources/border-changes.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 4 Jan 2008 01:00:19 +0000 (01:00 +0000)]
Replaced the use of editor command "ForwardDelete" with "DeleteForward" to be consistent
with our use of "DeleteBackward".
Rubber-stamped by Jon.
* WebView.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 4 Jan 2008 00:13:12 +0000 (00:13 +0000)]
Reviewed by Adam.
* Scripts/update-webkit: Make this work a little better for the people at Apple
who have a directory named Internal.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Thu, 3 Jan 2008 22:45:13 +0000 (22:45 +0000)]
Reviewed by Darin.
Fixed: <rdar://problem/
4106190> Include "Where from" metadata in drag-and-dropped images
* Misc/WebNSFileManagerExtras.h:
* Misc/WebNSFileManagerExtras.m:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set
"Where from:" metadata information.
* WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 3 Jan 2008 22:10:34 +0000 (22:10 +0000)]
Reviewed by Darin.
Pass the prototype of WebCore JS objects up the constructor chain
rather than explicitly setting using setPrototype. This removes many
redundant settings of the prototype on construction. To avoid a CG
hazard, the prototype must be constructed before before calling the
constructor of the JS object.
- JS objects that inherit from DOMObject, which all bindings objects
(except Window) do, now can't implicitly have a jsNull prototype, but
must explicitly pass it up the construction chain.
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventTargetNode.cpp:
(WebCore::JSEventTargetNode::JSEventTargetNode):
* bindings/js/JSEventTargetNode.h:
* bindings/js/JSHTMLAllCollection.h:
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
* bindings/js/JSHTMLAudioElementConstructor.cpp:
(WebCore::JSHTMLAudioElementConstructor::JSHTMLAudioElementConstructor):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::toJS):
* bindings/js/JSHTMLElementWrapperFactory.cpp:
(WebCore::createJSHTMLWrapper):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLInputElementBase.cpp:
(WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
* bindings/js/JSHTMLInputElementBase.h:
* bindings/js/JSHTMLOptionElementConstructor.cpp:
(WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
* bindings/js/JSLocation.cpp:
(WebCore::JSLocation::JSLocation):
* bindings/js/JSLocation.h:
* bindings/js/JSNamedNodesCollection.cpp:
(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
* bindings/js/JSNamedNodesCollection.h:
* bindings/js/JSNodeCustom.cpp:
(WebCore::toJS):
* bindings/js/JSSVGElementWrapperFactory.cpp:
(WebCore::createJSSVGWrapper):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
(KJS::JSXMLHttpRequestConstructorImp::construct):
(KJS::JSXMLHttpRequest::JSXMLHttpRequest):
* bindings/js/JSXMLHttpRequest.h:
* bindings/js/JSXSLTProcessor.cpp:
(KJS::JSXSLTProcessor::JSXSLTProcessor):
(KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
(KJS::XSLTProcessorConstructorImp::implementsConstruct):
(KJS::XSLTProcessorConstructorImp::construct):
* bindings/js/JSXSLTProcessor.h:
* bindings/js/kjs_binding.h:
(KJS::DOMObject::DOMObject):
(KJS::cacheDOMObject):
(KJS::cacheSVGDOMObject):
* bindings/js/kjs_css.cpp:
(WebCore::JSRGBColor::JSRGBColor):
(WebCore::getJSRGBColor):
* bindings/js/kjs_css.h:
* bindings/js/kjs_events.cpp:
(WebCore::JSClipboard::JSClipboard):
(WebCore::toJS):
* bindings/js/kjs_events.h:
* bindings/js/kjs_html.cpp:
(WebCore::ImageConstructorImp::ImageConstructorImp):
* bindings/js/kjs_navigator.cpp:
(KJS::Navigator::Navigator):
(KJS::PluginBase::PluginBase):
* bindings/js/kjs_navigator.h:
* bindings/js/kjs_window.cpp:
(KJS::Window::Window):
(KJS::Window::location):
(KJS::Window::getValueProperty):
* bindings/js/kjs_window.h:
* bindings/scripts/CodeGeneratorJS.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 3 Jan 2008 21:40:40 +0000 (21:40 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10909
Hixie's XMLHttpRequest/018.html test fails
This was fixed earlier, just adding a test case.
* http/tests/xmlhttprequest/web-apps/018-expected.txt: Added.
* http/tests/xmlhttprequest/web-apps/018.html: Added.
* http/tests/xmlhttprequest/web-apps/resources: Added.
* http/tests/xmlhttprequest/web-apps/resources/018-test.xml: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Thu, 3 Jan 2008 21:21:48 +0000 (21:21 +0000)]
Reviewed by Darin.
This fixes pageup/down in iframes. test for this is fast/frames/iframe-scroll-page-up-down.html
* WebView/WebHTMLView.mm:
(-[WebHTMLView doCommandBySelector:]):
Have the editor handle all the commands it supports instead of just text commands.
If not handled by the editor, the webview will handle the command.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 3 Jan 2008 19:35:54 +0000 (19:35 +0000)]
Regression: backspace stopped working on text inputs
- Replaced the use of editor command "BackwardDelete" with "DeleteBackward" since it's no longer supported.
Reviewed by Adam.
* WebEditorClient.cpp:
(WebEditorClient::textWillBeDeletedInTextField):
* WebView.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 3 Jan 2008 19:00:17 +0000 (19:00 +0000)]
2008-01-03 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alp.
-This is from http://bugs.webkit.org/show_bug.cgi?id=16115
Change the Gtk ContextMenuItem code to generate the GtkMenuItem
or GtkCheckMenuItem on the fly. Currently we will create a
GtkCheckMenuItem if the ContextMenuItem has been checked. What needs
to be done is to change WebCore to tell the platform code if an item
is checkable or not.
* platform/ContextMenuItem.h:
(WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::appendItem):
* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::~ContextMenuItem):
(WebCore::ContextMenuItem::createNativeMenuItem):
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::type):
(WebCore::ContextMenuItem::setType):
(WebCore::ContextMenuItem::action):
(WebCore::ContextMenuItem::setAction):
(WebCore::ContextMenuItem::platformSubMenu):
(WebCore::ContextMenuItem::setSubMenu):
(WebCore::ContextMenuItem::setChecked):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Jan 2008 18:37:46 +0000 (18:37 +0000)]
Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
Rubberstamped by Mark.
* Scripts/update-webkit-auxiliary-libs:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 3 Jan 2008 18:28:29 +0000 (18:28 +0000)]
Rubber-stamped by Adam Roben.
- update the project hierarchy to match the on-disk organization of
the platform directory.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Jan 2008 18:19:15 +0000 (18:19 +0000)]
Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
http://bugs.webkit.org/show_bug.cgi?id=15663
Added a fuzz factor into the Last-Modified comparison for downloading
WebKitAuxiliaryLibrary.zip.
The zip file is served from a set of mirrors who give Last-Modified
times that are off by 1-3 seconds from each other. This was causing
the build bots to redownload WebKitAuxiliaryLibrary for every build,
which would then cause all of WebCore to rebuild each time.
Reviewed by Mark.
* Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
at least 30 seconds newer than the old one -- otherwise we assume that
the difference in time is due to the mirrors being slightly offset
from each other.
(sub lastModifiedToUnixTime): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Thu, 3 Jan 2008 17:15:14 +0000 (17:15 +0000)]
Reviewed by Darin.
Fixed: <rdar://problem/
5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched
to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 3 Jan 2008 15:34:34 +0000 (15:34 +0000)]
Fix a buffer overrun and a leak introduced in r29098
Reviewed by Mark.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl): Only allocate one buffer, and make
it be big enough to hold the string contents plus the null terminator.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 3 Jan 2008 14:40:18 +0000 (14:40 +0000)]
Windows build fix.
* DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Jan 2008 13:53:08 +0000 (13:53 +0000)]
Moved QWebPage::open to QWebFrame::load and added setHtml.
Signed-off-by: Lars
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Jan 2008 13:50:59 +0000 (13:50 +0000)]
Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
Signed-off-by: Lars
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 3 Jan 2008 13:40:46 +0000 (13:40 +0000)]
Fix compilation with gcc 4.3, include limits.h for INT_MAX
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 3 Jan 2008 12:02:07 +0000 (12:02 +0000)]
2008-01-03 Alp Toker <alp@atoker.com>
Suggested by Mark Rowe.
Fix indentation and remove trailing whitespace.
* platform/network/curl/ResourceHandleManager.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 3 Jan 2008 11:04:04 +0000 (11:04 +0000)]
2008-01-03 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Fix HTTP POST-based logins to sites like Facebook, GMail by ensuring
that the two POST methods don't conflict.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::setupPOST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 08:49:35 +0000 (08:49 +0000)]
* tests/mozilla/expected.html: The fix for bug 16696 also fixed a test
case, ecma_3/RegExp/perlstress-002.js, so updated results to expect
that test to succeed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 3 Jan 2008 07:50:46 +0000 (07:50 +0000)]
* Scripts/do-webcore-rename: Yet more renaming ideas.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 07:44:09 +0000 (07:44 +0000)]
- touched some files to try to get the Windows buildbot building again
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 07:37:41 +0000 (07:37 +0000)]
Oops, fix another.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 07:37:14 +0000 (07:37 +0000)]
Oops, fix one.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 07:36:11 +0000 (07:36 +0000)]
* Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 3 Jan 2008 06:47:37 +0000 (06:47 +0000)]
Reviewed by Sam Weinig.
- fix small caps rendering
Covered by an existing test,
* platform/graphics/win/FontDataWin.cpp:
(WebCore::FontData::smallCapsFontData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 06:39:50 +0000 (06:39 +0000)]
JavaScriptCore:
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=16696
JSCRE fails fails to match Acid3 regexp
Test: fast/regex/early-acid3-86.html
The problem was with the cutoff point between backreferences and octal
escape sequences. We need to determine the cutoff point by counting the
total number of capturing brackets, which requires an extra pass through
the expression when compiling it.
* pcre/pcre_compile.cpp:
(CompileData::CompileData): Added numCapturingBrackets. Removed some
unused fields.
(compileBranch): Use numCapturingBrackets when calling checkEscape.
(calculateCompiledPatternLength): Use numCapturingBrackets when calling
checkEscape, and also store the bracket count at the end of the compile.
(jsRegExpCompile): Call calculateCompiledPatternLength twice -- once to
count the number of brackets and then a second time to calculate the length.
LayoutTests:
Reviewed by Geoff.
- test for http://bugs.webkit.org/show_bug.cgi?id=16696
JSCRE fails fails to match Acid3 regexp
* fast/regex/early-acid3-86-expected.txt: Added.
* fast/regex/early-acid3-86.html: Added.
* fast/regex/resources/early-acid3-86.js: Added.
* fast/regex/test1-expected.txt: Updated for a few cases where we now fail.
But these "failures" represent us replacing PCRE behavior with semantics
that are correct for JavaScript regular expressions.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 06:11:10 +0000 (06:11 +0000)]
Reviewed and landed by Darin.
* kjs/nodes.cpp:
(KJS::DoWhileNode::execute): Added a missing return.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 3 Jan 2008 03:56:40 +0000 (03:56 +0000)]
Reviewed by Oliver.
Calculate video position and size within the renderer box in WebCore. This
way the aspect ratio calculation is not needed in each MediaPlayer implementation.
This fixes video aspect ratio on Windows.
Covered by an existing pixel test.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::createQTMovieView):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::videoBox):
(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::updatePlayer):
* rendering/RenderVideo.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 3 Jan 2008 02:33:11 +0000 (02:33 +0000)]
Fix windows build.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Thu, 3 Jan 2008 02:09:58 +0000 (02:09 +0000)]
Reviewed by Dan Bernstein
- fixed <rdar://problem/
5579010> REGRESSION: Safari inserts newlines in tab names when U+2028 is present
* loader/DocumentLoader.cpp:
(WebCore::canonicalizedTitle):
in the code that replaces control characters with white space, also replace the unicode line separator
and paragraph separator characters
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 3 Jan 2008 02:07:28 +0000 (02:07 +0000)]
2008-01-02 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber stamped by Alp.
Remove GDK_MULTIHEAD_SAFE and GTK_MULTIHEAD_SAFE because they break
the build. At least people doing a debug build on Ubuntu Hardy will see
the breakage. I was asked to leave the flags inside the files to ease future
debugging.
* GNUmakefile.am:
* WebKit.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 3 Jan 2008 02:05:01 +0000 (02:05 +0000)]
2008-01-02 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber stamped by Darin.
Coding Style fix. Do not use an else because we use a return in the
if branch.
* WebView/webkitwebview.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 02:00:26 +0000 (02:00 +0000)]
- fix buffer overruns seen on buildbot
* platform/text/StringImpl.cpp:
(WebCore::countCharacter): Added this.
(WebCore::StringImpl::toCoordsArray): Use countCharacter instead of incorrect find expression.
(WebCore::StringImpl::toLengthArray): Ditto.
(WebCore::StringImpl::replace): Added assertions.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Thu, 3 Jan 2008 01:29:06 +0000 (01:29 +0000)]
* platform/win/Skipped: removing a fixed test
this was fixed with r28836 but was left behind on the skipped list
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 01:25:51 +0000 (01:25 +0000)]
WebCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=16657
Acid3 failure since table.caption and table.thead do not work for nodes added by appendChild
- fix http://bugs.webkit.org/show_bug.cgi?id=16659
Acid3 expects HTMLTableElement.rows to include a <tr> element that is an immediate child of the <table>
Tests: dom/html/level2/html/HTMLCollection07.html
dom/html/level2/html/HTMLCollection08.html
dom/html/level2/xhtml/HTMLCollection07.xhtml
dom/html/level2/xhtml/HTMLCollection08.xhtml
fast/dom/HTMLTableElement/early-acid3-65-excerpt.html
fast/dom/HTMLTableElement/early-acid3-66-excerpt.html
* GNUmakefile.am: Added HTMLTableRowsCollection.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* WebCoreSources.bkl: Ditto.
* dom/XMLTokenizer.cpp: Took out stray include.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::itemAfter): Removed all the table rows code, since we now use
a separate class for that collection. Also got rid of the distinct types for custom collections
that don't need them (use Other for both).
* html/HTMLCollection.h: Also made firstItem non-virtual because it doesn't need to be virtual.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection): Use Other instead of FormElements
for the HTMLCollection type.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::HTMLTableElement): Eliminated m_head, m_foot, m_firstBody, and m_caption.
(WebCore::HTMLTableElement::caption): Added non-inline version. Finds the caption rather than
keeping a pointer to it.
(WebCore::HTMLTableElement::setCaption): Rewrote.
(WebCore::HTMLTableElement::tHead): Ditto.
(WebCore::HTMLTableElement::setTHead): Ditto.
(WebCore::HTMLTableElement::tFoot): Ditto.
(WebCore::HTMLTableElement::setTFoot): Ditto.
(WebCore::HTMLTableElement::createTHead): Ditto.
(WebCore::HTMLTableElement::deleteTHead): Ditto.
(WebCore::HTMLTableElement::createTFoot): Ditto.
(WebCore::HTMLTableElement::deleteTFoot): Ditto.
(WebCore::HTMLTableElement::createCaption): Ditto.
(WebCore::HTMLTableElement::deleteCaption): Ditto.
(WebCore::HTMLTableElement::lastBody): Added.
(WebCore::HTMLTableElement::insertRow): Rewrote to use a loop based on code in HTMLTableRowsCollection.
This is different from the old code mainly in how it handles rows outside any section.
(WebCore::HTMLTableElement::deleteRow): Ditto.
(WebCore::HTMLTableElement::addChild): Removed code to set the various members. Keeping pointers to
these was a possible source of serious bugs too, including crashes with stale pointers, although I
didn't write any test cases to prove those bugs existed.
(WebCore::HTMLTableElement::parseMappedAttribute): Changed the rules code to visit all cells, not
just the cells of the first body. I believe this fixed rendering on some table tests. I think the code
visits too many cells and also the use of recursion is overkill, but I didn't try to fix that.
(WebCore::HTMLTableElement::rows): Changed to use the new HTMLTableRowsCollection.
* html/HTMLTableElement.h: Changed functions to return PassRefPtr, which can be important if strange
things like DOM mutation events take things ot of the tree before they are safely referenced by
JavaScript wrappers. Also changed functions to take PassRefPtr and added exceptions. Removed unneeded
firstTBody and setTBody functions and childrenChanged function override, as well as unused Rules and
Frame enums. Removed m_head, m_foot, m_firstBody, and m_caption, and added lastBody function. Removed
unneeded friend declaration for HTMLTableCellElement.
* html/HTMLTableElement.idl: Allow the setteres for caption, tHead, and tFoot to raise exceptions.
* html/HTMLTableRowsCollection.cpp: Added. Implements the HTML 5 rule for which rows are in the
collection in which order.
* html/HTMLTableRowsCollection.h: Added.
* loader/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryTokenizer::appendEntry): Use the standard insertRow function instead of
coming up with our own way of inserting a row. Simplifies things -- we can remove the code to
create a tbody element.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=16657
Acid3 failure since table.caption and table.thead do not work for nodes added by appendChild
- test for http://bugs.webkit.org/show_bug.cgi?id=16659
Acid3 expects HTMLTableElement.rows to include a <tr> element that is an immediate child of the <table>
* fast/dom/HTMLTableElement/early-acid3-65-excerpt-expected.txt: Added.
* fast/dom/HTMLTableElement/early-acid3-65-excerpt.html: Added.
* fast/dom/HTMLTableElement/early-acid3-66-excerpt-expected.txt: Added.
* fast/dom/HTMLTableElement/early-acid3-66-excerpt.html: Added.
* fast/dom/HTMLTableElement/resources/early-acid3-65-excerpt.js: Added.
* fast/dom/HTMLTableElement/resources/early-acid3-66-excerpt.js: Added.
* dom/html/level2/html/HTMLCollection07-expected.txt: Updated to reflect success.
* dom/html/level2/html/HTMLCollection08-expected.txt: Updated to reflect success.
* dom/xhtml/level2/html/HTMLCollection07-expected.txt: Updated to reflect success.
* dom/xhtml/level2/html/HTMLCollection08-expected.txt: Updated to reflect success.
* fast/dom/HTMLTableElement/resources/rows.js: Changed to expect HTML 5 behavior for rows outside
table sections.
* fast/dom/HTMLTableElement/rows-expected.txt: Updated.
* platform/mac/tables/mozilla/bugs/bug30418-expected.checksum: Updated to reflect better results.
* platform/mac/tables/mozilla/bugs/bug30418-expected.png: Ditto.
* platform/mac/tables/mozilla/bugs/bug30418-expected.txt: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 01:11:10 +0000 (01:11 +0000)]
- try to fix Qt build
* wtf/unicode/qt4/UnicodeQt4.h:
(WTF::Unicode::foldCase): Add some missing const.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 00:58:41 +0000 (00:58 +0000)]
Reviewed by Alice and Tim.
- try to fix GTK and Qt builds
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::scroll): Improve logic slightly for the case of
vertical scrolling when there's no vertical scroll bar.
* platform/gtk/ScrollViewGtk.cpp:
(WebCore::ScrollView::scroll): Copy the code from Windows. Maybe this
should be factored differently.
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::scroll): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 3 Jan 2008 00:32:19 +0000 (00:32 +0000)]
Reviewed by Anders.
- http://bugs.webkit.org/show_bug.cgi?id=16712
change StringImpl to take and return PassRefPtr instead of raw pointers
Also eliminated use of const StringImpl. Since StringImpl is immutable there
is no distinction between a const and non-const one at the moment.
* WebCore.base.exp: Updated.
* css/CSSHelper.cpp:
(WebCore::parseURL): Make String directly, not by making a StringImpl.
* dom/Attr.cpp:
(WebCore::Attr::createTextChild): Convert AtomicString to String with domString,
not via StringImpl.
(WebCore::Attr::setValue): Remove unneed call to impl() when passing a String
to a function that takes a String.
* dom/CDATASection.cpp: Removed unused constructor.
(WebCore::CDATASection::cloneNode): Added a now-needed .get().
(WebCore::CDATASection::createNew): Changed function to take a PassRefPtr.
* dom/CDATASection.h:
* dom/CharacterData.cpp:
(WebCore::CharacterData::CharacterData): Removed unneeded initialization and
ref() now that the string is a RefPtr. Also updated to not call "new StringImpl".
(WebCore::CharacterData::~CharacterData): Removed unneeded deref() since it's
a RefPtr.
(WebCore::CharacterData::setData): More of that.
(WebCore::CharacterData::substringData): Ditto.
(WebCore::CharacterData::appendData): Ditto.
(WebCore::CharacterData::insertData): Ditto.
(WebCore::CharacterData::deleteData): Ditto.
(WebCore::CharacterData::replaceData): Ditto.
(WebCore::CharacterData::nodeValue): Ditto.
(WebCore::CharacterData::dispatchModifiedEvent): Ditto.
(WebCore::CharacterData::dump): Ditto.
* dom/CharacterData.h: Changed to use a RefPtr. I could have used a String
instead, but since String adds extra branches to handle 0, I figured it was
more conservative to just use RefPtr. Later it would be good to figure out
which is preferred style and be more consistent. Maybe we'll phase out
StringImpl, or maybe we'll go the other way and use it more since it can be
more efficient.
* dom/DOMImplementation.cpp:
(WebCore::addString): Changed set to use String rather than StringImpl.
(WebCore::isSVG10Feature): Ditto.
(WebCore::isSVG11Feature): Ditto.
(WebCore::DOMImplementation::createDocument): Replaced custom code to
find a colon with a call to String::find.
* dom/Range.cpp:
(WebCore::Range::insertNode): Updated since the result of splitText is now
a PassRefPtr.
* dom/Text.cpp:
(WebCore::Text::splitText): Updated since str is now a RefPtr. Also made the
result of this function be a PassRefPtr.
(WebCore::Text::createRenderer): Ditto.
(WebCore::Text::createNew): Made the parameter and result both be PassRefPtr.
* dom/Text.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::nodeName): Use String::upper.
* html/HTMLInputElement.cpp:
(WebCore::numGraphemeClusters): Remove now-unneeded const.
(WebCore::numCharactersInGraphemeClusters): Ditto.
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::processToken): Updated for function name change.
* platform/text/AtomicString.cpp:
(WebCore::CStringTranslator::translate): Updated since there is no longer
a constructor that takes a string.
* platform/text/PlatformString.h: Added new constructors that take
PassRefPtr and RefPtr. Removed misleading comment.
* platform/text/String.cpp:
(WebCore::String::String): Changed to use StringImpl::create, which handles
the empty string automatically.
(WebCore::String::append): Ditto.
(WebCore::String::charactersWithNullTermination): Similar.
(WebCore::String::format): Ditto.
* platform/text/StringHash.h: Took out unneeded const.
* platform/text/StringImpl.cpp:
(WebCore::deleteUCharVector): Changed to take a const pointer since the
buffers are now const UChar buffers.
(WebCore::StringImpl::StringImpl): Removed some constructors. Got rid of the
separate init functions. The constructors are now private and used only in
the create functions and one or two other places.
(WebCore::StringImpl::containsOnlyWhitespace): Removed now-meaningless const.
(WebCore::StringImpl::substring): Ditto. Also changed return value to be a
PassRefPtr.
(WebCore::StringImpl::characterStartingAt): Ditto.
(WebCore::StringImpl::toLength): Ditto.
(WebCore::StringImpl::toCoordsArray): Ditto.
(WebCore::StringImpl::toLengthArray): Ditto.
(WebCore::StringImpl::isLower): Ditto.
(WebCore::StringImpl::lower): Ditto. Changed to use Vector and adopt so we
don't have to use new directly here. Makes empty string handling more consistent.
(WebCore::StringImpl::upper): Ditto.
(WebCore::StringImpl::secure): Ditto.
(WebCore::StringImpl::foldCase): Ditto.
(WebCore::StringImpl::stripWhiteSpace): Ditto.
(WebCore::StringImpl::simplifyWhiteSpace): Ditto.
(WebCore::StringImpl::capitalize): Ditto.
(WebCore::StringImpl::toInt): Removed now-meaningless const.
(WebCore::StringImpl::toInt64): Ditto.
(WebCore::StringImpl::toUInt64): Ditto.
(WebCore::StringImpl::toDouble): Ditto.
(WebCore::StringImpl::toFloat): Ditto.
(WebCore::StringImpl::find): Ditto.
(WebCore::StringImpl::reverseFind): Ditto.
(WebCore::StringImpl::endsWith): Ditto.
(WebCore::StringImpl::replace): Ditto.
(WebCore::equal): Ditto.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::StringImpl::ascii): Ditto.
(WebCore::StringImpl::defaultWritingDirection): Ditto.
(WebCore::StringImpl::createStrippingNullCharacters): Ditto.
(WebCore::StringImpl::adopt): Added special case so this uses the shared
empty string like other functions. Also optimized the common case where the
vector happens to already have the right size so we don't do a fastRealloc
at all in those cases.
(WebCore::StringImpl::create): Added. These are now the public functions for
creating new StringImpl objects. They all implement the shared empty string.
(WebCore::StringImpl::createWithTerminatingNullCharacter):
* platform/text/StringImpl.h:
* platform/text/cf/StringCF.cpp:
(WebCore::String::String): Use StringImpl::create instead of new StringImpl.
* platform/text/cf/StringImplCF.cpp:
(WebCore::StringImpl::createCFString): Removed now-obsolete const.
* platform/text/mac/StringImplMac.mm:
(WebCore::StringImpl::operator NSString *): Ditto.
* platform/text/mac/StringMac.mm:
(WebCore::String::String): Use StringImpl::create instead of new StringImpl.
* platform/text/qt/StringQt.cpp:
(WebCore::String::String): Ditto.
* platform/text/wx/StringWx.cpp:
(WebCore::String::String): Ditto.
* rendering/RenderBR.cpp:
(WebCore::RenderBR::RenderBR): Ditto.
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::RenderSVGInlineText): Use PassRefPtr.
* rendering/RenderSVGInlineText.h:
* rendering/RenderText.cpp:
(WebCore::charactersAreAllASCII): Removed now-unneeded const.
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::originalText): Use RefPtr.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 3 Jan 2008 00:07:38 +0000 (00:07 +0000)]
Reviewed by Oliver Hunt.
<rdar://problem/
5618086> WebInspector does not expand the DOM tree after being closed
Closing the Web Inspector causes the DOM tree outline to be torn down, clearing the
internal element lookup tables. The represented DOM node object still holds the identifier
it was assigned, and a later call to findTreeElement will use that original identifier
against a cleared lookup table. In that case we need to fallback on DOM ancestor lookup.
* page/inspector/treeoutline.js:
(TreeOutline.prototype.findTreeElement): If the DOM node already had a __treeElementIdentifier,
but the TreeOutline no longer has the element in the _knownTreeElements list do an ancestor lookup
instead of an early return.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Wed, 2 Jan 2008 23:53:46 +0000 (23:53 +0000)]
JavaScriptCore:
Reviewed by Sam Weinig.
need to export ASCIICType.h for use in DRT
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* wtf/ASCIICType.h:
(WTF::isASCIIUpper):
WebKitTools:
Reviewed by Sam Weinig.
fixing assertion hit with editing/selection/move-begin-end.html
* DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback):
using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc