WebKit.git
9 years ago[Qt][WK2]REGRESSION(r93784): It made many tests crash
alexis.menard@openbossa.org [Fri, 26 Aug 2011 18:24:48 +0000 (18:24 +0000)]
[Qt][WK2]REGRESSION(r93784): It made many tests crash
https://bugs.webkit.org/show_bug.cgi?id=66958

Reviewed by Anders Carlsson.

Don't try to make sure the WebContext is deleted, for now the leak
is intended and when multiple processes per context will be supported
this leak should be fixed. This was the cause of DRT crashing on the bot,
the context was deleted after the first test, letting other tests with nothing
but a bad context.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::~QtWebPageProxy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImport the last set of GTK+ CSS3 selector results.
mrobinson@webkit.org [Fri, 26 Aug 2011 18:23:32 +0000 (18:23 +0000)]
Import the last set of GTK+ CSS3 selector results.

* platform/gtk/css3/selectors3/xml: Import the last set of results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoContinue importing GTK+ CSS3 selector test results.
mrobinson@webkit.org [Fri, 26 Aug 2011 18:15:44 +0000 (18:15 +0000)]
Continue importing GTK+ CSS3 selector test results.

* platform/gtk/css3/selectors3/xml: Import the next set of results.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBegin importing the last directory of CSS3 selector results for GTK+.
mrobinson@webkit.org [Fri, 26 Aug 2011 18:08:53 +0000 (18:08 +0000)]
Begin importing the last directory of CSS3 selector results for GTK+.

* platform/gtk/css3/selectors3/xml: Import the first set of files in this directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebViewImpl::selectionRange should return range in the right order.
commit-queue@webkit.org [Fri, 26 Aug 2011 18:07:39 +0000 (18:07 +0000)]
WebViewImpl::selectionRange should return range in the right order.
https://bugs.webkit.org/show_bug.cgi?id=66973

Patch by Varun Jain <varunjain@google.com> on 2011-08-26
Reviewed by Darin Fisher.

*  Source/WebKit/chromium/public/WebWidget.h:
*  Source/WebKit/chromium/src/WebViewImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Update searchableIndexIntroduction() to match GTK+'s.
commit-queue@webkit.org [Fri, 26 Aug 2011 18:04:46 +0000 (18:04 +0000)]
[EFL] Update searchableIndexIntroduction() to match GTK+'s.
https://bugs.webkit.org/show_bug.cgi?id=66885

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Using this new string allows us to share the test expectations with
other ports, and thus makes
fast/replaced/table-percent-height-text-controls.html pass.

No new tests, as this is covered by an existing one.

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::searchableIndexIntroduction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; adding files missing from r93885.
vrk@chromium.org [Fri, 26 Aug 2011 17:59:38 +0000 (17:59 +0000)]
Unreviewed; adding files missing from r93885.

* media/track/captions-webvtt/tc000-empty.vtt: Added.
* media/track/captions-webvtt/tc001-iso2022jp3.vtt: Added.
* media/track/captions-webvtt/tc001-utf8.vtt: Added.
* media/track/captions-webvtt/tc002-bom.vtt: Added.
* media/track/captions-webvtt/tc003-newlines.vtt: Added.
* media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Added.
* media/track/captions-webvtt/tc004-no-webvtt.vtt: Added.
* media/track/captions-webvtt/tc004-webvtt-file.vtt: Added.
* media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Added.
* media/track/captions-webvtt/tc005-default-styles.vtt: Added.
* media/track/captions-webvtt/tc005-metadata-area.vtt: Added.
* media/track/captions-webvtt/tc006-cue-id-error.vtt: Added.
* media/track/captions-webvtt/tc006-cue-id.vtt: Added.
* media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Added.
* media/track/captions-webvtt/tc007-cue-no-id.vtt: Added.
* media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Added.
* media/track/captions-webvtt/tc008-timings-no-hour.vtt: Added.
* media/track/captions-webvtt/tc009-timings-hour-error.vtt: Added.
* media/track/captions-webvtt/tc009-timings-hour.vtt: Added.
* media/track/captions-webvtt/tc010-no-timings.vtt: Added.
* media/track/captions-webvtt/tc011-cues-no-separation.vtt: Added.
* media/track/captions-webvtt/tc011-cues.vtt: Added.
* media/track/captions-webvtt/tc012-out-of-order.vtt: Added.
* media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Added.
* media/track/captions-webvtt/tc013-settings.vtt: Added.
* media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
* media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
* media/track/captions-webvtt/tc014-alignment.vtt: Added.
* media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
* media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
* media/track/captions-webvtt/tc015-positioning.vtt: Added.
* media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
* media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
* media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
* media/track/captions-webvtt/tc017-line-position.vtt: Added.
* media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
* media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
* media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
* media/track/captions-webvtt/tc019-cue-size.vtt: Added.
* media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
* media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
* media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
* media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
* media/track/captions-webvtt/tc021-valign.vtt: Added.
* media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
* media/track/captions-webvtt/tc022-entities.vtt: Added.
* media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
* media/track/captions-webvtt/tc023-markup.vtt: Added.
* media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
* media/track/captions-webvtt/tc024-timestamp.vtt: Added.
* media/track/captions-webvtt/tc025-class-bad.vtt: Added.
* media/track/captions-webvtt/tc025-class.vtt: Added.
* media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
* media/track/captions-webvtt/tc026-voice.vtt: Added.
* media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
* media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
* media/track/track-webvtt-tc004-magic-header-expected.txt: Added.
* media/track/track-webvtt-tc004-magic-header.html: Added.
* media/track/track-webvtt-tc005-header-comment-expected.txt: Added.
* media/track/track-webvtt-tc005-header-comment.html: Added.
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Added.
* media/track/track-webvtt-tc006-cue-identifiers.html: Added.
* media/track/track-webvtt-tc007-cue-no-id-expected.txt: Added.
* media/track/track-webvtt-tc007-cue-no-id.html: Added.
* media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Added.
* media/track/track-webvtt-tc008-timings-no-hours.html: Added.
* media/track/track-webvtt-tc009-timings-hour-expected.txt: Added.
* media/track/track-webvtt-tc009-timings-hour.html: Added.
* media/track/track-webvtt-tc010-no-timings-expected.txt: Added.
* media/track/track-webvtt-tc010-no-timings.html: Added.
* media/track/track-webvtt-tc011-blank-lines-expected.txt: Added.
* media/track/track-webvtt-tc011-blank-lines.html: Added.
* media/track/track-webvtt-tc012-out-of-order-expected.txt: Added.
* media/track/track-webvtt-tc012-out-of-order.html: Added.
* media/track/track-webvtt-tc014-alignment-expected.txt: Added.
* media/track/track-webvtt-tc014-alignment.html: Added.
* media/track/track-webvtt-tc015-positioning-expected.txt: Added.
* media/track/track-webvtt-tc015-positioning.html: Added.
* media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
* media/track/track-webvtt-tc016-align-positioning.html: Added.
* media/track/track-webvtt-tc017-line-position-expected.txt: Added.
* media/track/track-webvtt-tc017-line-position.html: Added.
* media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
* media/track/track-webvtt-tc018-align-text-line-position.html: Added.
* media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
* media/track/track-webvtt-tc019-cue-size.html: Added.
* media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
* media/track/track-webvtt-tc020-cue-size-align.html: Added.
* media/track/track-webvtt-tc021-valign-expected.txt: Added.
* media/track/track-webvtt-tc021-valign.html: Added.
* media/track/track-webvtt-tc022-entities-expected.txt: Added.
* media/track/track-webvtt-tc022-entities.html: Added.
* media/track/track-webvtt-tc023-markup-expected.txt: Added.
* media/track/track-webvtt-tc023-markup.html: Added.
* media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
* media/track/track-webvtt-tc024-timestamp.html: Added.
* media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
* media/track/track-webvtt-tc025-class-markup.html: Added.
* media/track/track-webvtt-tc026-voice-expected.txt: Added.
* media/track/track-webvtt-tc026-voice.html: Added.
* media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
* media/track/track-webvtt-tc027-empty-cue.html: Added.
* media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
* media/track/track-webvtt-tc028-unsupported-markup.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Do not log an error if a fallback cursor cannot be found.
commit-queue@webkit.org [Fri, 26 Aug 2011 17:59:29 +0000 (17:59 +0000)]
[EFL] Do not log an error if a fallback cursor cannot be found.
https://bugs.webkit.org/show_bug.cgi?id=67037

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-26
Reviewed by Gustavo Noronha Silva.

Ecore_X does not necessarily have to be used (DumpRenderTree does not
use it, for example), so showing an error message here is bogus.

No new tests, as it just removes erroneous error messages from
when running DRT with existing tests.

* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::applyFallbackCursor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoContinue importing GTK+ CSS3 selector results.
mrobinson@webkit.org [Fri, 26 Aug 2011 17:53:18 +0000 (17:53 +0000)]
Continue importing GTK+ CSS3 selector results.

* platform/gtk/css3/selectors3/xhtml: Import this directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBegin importing CSS3 selector test results for GTK+.
mrobinson@webkit.org [Fri, 26 Aug 2011 17:48:24 +0000 (17:48 +0000)]
Begin importing CSS3 selector test results for GTK+.

* platform/gtk/css3/selectors3/html: Import this directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix handling of keyup events in the new Cocoa text input model
andersca@apple.com [Fri, 26 Aug 2011 17:45:49 +0000 (17:45 +0000)]
Fix handling of keyup events in the new Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67045

Reviewed by Sam Weinig.

Use a counter instead of a boolean for deciding when to ignore keyup events, because
if multiple keys are pressed simultaneously then we need to ignore more than one keyup event in a row.

Also if a keyboard event is an autorepeating event we won't get a keyup event so don't increment the counter
in that case.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Change a bunch of nondescript bools to
japhet@chromium.org [Fri, 26 Aug 2011 17:41:25 +0000 (17:41 +0000)]
Source/WebCore: Change a bunch of nondescript bools to
descriptive enums in ResourceLoaderOptions and
ThreadableLoaderOptions.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

No new tests, no functionality change intended.

* WebCore.exp.in:
* fileapi/FileReaderLoader.cpp:
* html/MediaDocument.cpp:
* html/PluginDocument.cpp:
* loader/CrossOriginAccessControl.cpp:
* loader/CrossOriginAccessControl.h:
* loader/CrossOriginPreflightResultCache.cpp:
* loader/CrossOriginPreflightResultCache.h:
* loader/DocumentThreadableLoader.cpp:
* loader/FrameLoader.h:
* loader/ImageLoader.cpp:
* loader/MainResourceLoader.cpp:
* loader/NetscapePlugInStreamLoader.cpp:
* loader/ResourceLoadScheduler.h:
* loader/ResourceLoader.cpp:
* loader/ResourceLoader.h:
* loader/ResourceLoaderOptions.h:
* loader/ThreadableLoader.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResourceRequest.cpp:
* loader/cf/ResourceLoaderCFNet.cpp:
* loader/mac/ResourceLoaderMac.mm:
* page/EventSource.cpp:
* platform/network/ResourceHandle.h:
* workers/WorkerScriptLoader.cpp:
* xml/XMLHttpRequest.cpp:

Source/WebKit/chromium: Use enums instead of bools for ThreadableLoaderOptions
variables.
https://bugs.webkit.org/show_bug.cgi?id=66984

Reviewed by David Levin.

* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::loadAsynchronously):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTests for validating a new WebVTT parser and tokenizer for TextTrackCue content.
vrk@chromium.org [Fri, 26 Aug 2011 17:21:37 +0000 (17:21 +0000)]
Tests for validating a new WebVTT parser and tokenizer for TextTrackCue content.
https://bugs.webkit.org/show_bug.cgi?id=65884

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-25
Reviewed by Eric Carlson.

* media/track/captions-webvtt/tc000-empty.vtt: Renamed from media/track/captions/tc000_empty.vtt.
* media/track/captions-webvtt/tc001-iso2022jp3.vtt: Renamed from media/track/captions/tc001_iso2022jp3.vtt.
* media/track/captions-webvtt/tc001-utf8.vtt: Renamed from media/track/captions/tc001_utf8.vtt.
* media/track/captions-webvtt/tc002-bom.vtt: Renamed from media/track/captions/tc002_bom.vtt.
* media/track/captions-webvtt/tc003-newlines.vtt: Renamed from media/track/captions/tc003_newlines.vtt
* media/track/captions-webvtt/tc003-no-newline-at-eof.vtt: Renamed from media/track/captions/tc003_nonewlineateof.vtt
* media/track/captions-webvtt/tc004-no-webvtt.vtt: Renamed from media/track/captions/tc004_nowebvtt.vtt.
* media/track/captions-webvtt/tc004-webvtt-file.vtt: Renamed from media/track/captions/tc004_webvttfile.vtt.
* media/track/captions-webvtt/tc004-webvtt-rubbish.vtt: Renamed from media/track/captions/tc004_webvttrubbish.vtt.
* media/track/captions-webvtt/tc005-default-styles.vtt: Renamed from media/track/captions/tc005_defaultstyles.vtt.
* media/track/captions-webvtt/tc005-metadata-area.vtt: Renamed from media/track/captions/tc005_metadataarea.vtt.
* media/track/captions-webvtt/tc006-cue-id-error.vtt: Renamed from media/track/captions/tc006_cueiderror.vtt.
* media/track/captions-webvtt/tc006-cue-id.vtt: Renamed from media/track/captions/tc006_cueid.vtt.
* media/track/captions-webvtt/tc007-cue-no-id-error.vtt: Renamed from media/track/captions/tc007_cuenoid.vtt.
* media/track/captions-webvtt/tc007-cue-no-id.vtt: Renamed from media/track/captions/tc007_cuenoiderror.vtt.
* media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt: Renamed from media/track/captions/tc008_timingsnohourerrors.vtt.
* media/track/captions-webvtt/tc008-timings-no-hour.vtt: Renamed from media/track/captions/tc008_timingsnohour.vtt.
* media/track/captions-webvtt/tc009-timings-hour-error.vtt: Renamed from media/track/captions/tc009_timingshourerror.vtt.
* media/track/captions-webvtt/tc009-timings-hour.vtt: Renamed from media/track/captions/tc009_timingshour.vtt.
* media/track/captions-webvtt/tc010-no-timings.vtt: Renamed from media/track/captions/tc010_notimings.vtt.
* media/track/captions-webvtt/tc011-cues-no-separation.vtt: Copied from media/track/captions/tc011_cuesnosep.vtt.
* media/track/captions-webvtt/tc011-cues.vtt: Renamed from media/track/captions/tc011_cues.vtt.
* media/track/captions-webvtt/tc012-out-of-order.vtt: Renamed from media/track/captions/tc012_outoforder.vtt.
* media/track/captions-webvtt/tc013-settings-bad-separation.vtt: Renamed from media/track/captions/tc013_settingsbadsep.vtt.
* media/track/captions-webvtt/tc013-settings.vtt: Renamed from media/track/captions/tc013_settings.vtt.
* media/track/captions-webvtt/tc014-alignment-bad.vtt: Added.
* media/track/captions-webvtt/tc014-alignment-ltr.vtt: Added.
* media/track/captions-webvtt/tc014-alignment.vtt: Added.
* media/track/captions-webvtt/tc015-positioning-bad.vtt: Added.
* media/track/captions-webvtt/tc015-positioning-ltr.vtt: Added.
* media/track/captions-webvtt/tc015-positioning.vtt: Added.
* media/track/captions-webvtt/tc016-align-positioning-bad.vtt: Added.
* media/track/captions-webvtt/tc016-align-positioning.vtt: Added.
* media/track/captions-webvtt/tc017-line-position-bad.vtt: Added.
* media/track/captions-webvtt/tc017-line-position.vtt: Added.
* media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt: Added.
* media/track/captions-webvtt/tc018-align-text-line-position.vtt: Added.
* media/track/captions-webvtt/tc019-cue-size-bad.vtt: Added.
* media/track/captions-webvtt/tc019-cue-size.vtt: Added.
* media/track/captions-webvtt/tc020-cue-size-align-bad.vtt: Added.
* media/track/captions-webvtt/tc020-cue-size-align.vtt: Added.
* media/track/captions-webvtt/tc021-valign-bad.vtt: Added.
* media/track/captions-webvtt/tc021-valign-ltr.vtt: Added.
* media/track/captions-webvtt/tc021-valign.vtt: Added.
* media/track/captions-webvtt/tc022-entities-wrong.vtt: Added.
* media/track/captions-webvtt/tc022-entities.vtt: Added.
* media/track/captions-webvtt/tc023-markup-bad.vtt: Added.
* media/track/captions-webvtt/tc023-markup.vtt: Added.
* media/track/captions-webvtt/tc024-timestamp-bad.vtt: Added.
* media/track/captions-webvtt/tc024-timestamp.vtt: Added.
* media/track/captions-webvtt/tc025-class-bad.vtt: Added.
* media/track/captions-webvtt/tc025-class.vtt: Added.
* media/track/captions-webvtt/tc026-voice-bad.vtt: Added.
* media/track/captions-webvtt/tc026-voice.vtt: Added.
* media/track/captions-webvtt/tc027-empty-cue.vtt: Added.
* media/track/captions-webvtt/tc028-unsupported-markup.vtt: Added.
* media/track/track-webvtt-tc000-empty.html:
* media/track/track-webvtt-tc001-utf8-expected.txt:
* media/track/track-webvtt-tc001-utf8.html:
* media/track/track-webvtt-tc002-bom-expected.txt:
* media/track/track-webvtt-tc002-bom.html:
* media/track/track-webvtt-tc003-newlines-expected.txt:
* media/track/track-webvtt-tc003-newlines.html:
* media/track/track-webvtt-tc004-magic-header-expected.txt: Renamed from media/track/track-webvtt-tc004-magicheader-expected.txt.
* media/track/track-webvtt-tc004-magic-header.html: Renamed from media/track/track-webvtt-tc004-magicheader.html.
* media/track/track-webvtt-tc005-header-comment-expected.txt: Renamed from media/track/track-webvtt-tc005-headercomment-expected.txt.
* media/track/track-webvtt-tc005-header-comment.html: Renamed from media/track/track-webvtt-tc005-headercomment.html.
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt: Renamed from media/track/track-webvtt-tc006-cueidentifiers-expected.txt.
* media/track/track-webvtt-tc006-cue-identifiers.html: Renamed from media/track/track-webvtt-tc006-cueidentifiers.html.
* media/track/track-webvtt-tc007-cue-no-id-expected.txt: Renamed from media/track/track-webvtt-tc007-cuenoid-expected.txt.
* media/track/track-webvtt-tc007-cue-no-id.html: Renamed media/track/track-webvtt-tc007-cuenoid.html.
* media/track/track-webvtt-tc008-timings-no-hours-expected.txt: Renamed from media/track/track-webvtt-tc008-timingsnohours-expected.txt.
* media/track/track-webvtt-tc008-timings-no-hours.html: Renamed from media/track/track-webvtt-tc008-timingsnohours.html.
* media/track/track-webvtt-tc009-timings-hour-expected.txt: Renamed from media/track/track-webvtt-tc009-timingshour-expected.txt.
* media/track/track-webvtt-tc009-timings-hour.html: Renamed from media/track/track-webvtt-tc009-timingshour.html.
* media/track/track-webvtt-tc010-no-timings-expected.txt: Copied from media/track/track-webvtt-tc010-notimings-expected.txt.
* media/track/track-webvtt-tc010-no-timings.html: Renamed from media/track/track-webvtt-tc012-outoforder.html.
* media/track/track-webvtt-tc011-blank-lines-expected.txt: Renamed from media/track/track-webvtt-tc011-blanklines-expected.txt.
* media/track/track-webvtt-tc011-blank-lines.html: Renamed from media/track/track-webvtt-tc011-blanklines.html.
* media/track/track-webvtt-tc012-out-of-order-expected.txt: Renamed from media/track/track-webvtt-tc012-outoforder-expected.txt.
* media/track/track-webvtt-tc012-out-of-order.html: Copied from media/track/track-webvtt-tc000-empty.html.
* media/track/track-webvtt-tc013-settings-expected.txt:
* media/track/track-webvtt-tc013-settings.html:
* media/track/track-webvtt-tc014-alignment-expected.txt: Added.
* media/track/track-webvtt-tc014-alignment.html: Added.
* media/track/track-webvtt-tc015-positioning-expected.txt: Added.
* media/track/track-webvtt-tc015-positioning.html: Added.
* media/track/track-webvtt-tc016-align-positioning-expected.txt: Added.
* media/track/track-webvtt-tc016-align-positioning.html: Added.
* media/track/track-webvtt-tc017-line-position-expected.txt: Added.
* media/track/track-webvtt-tc017-line-position.html: Added.
* media/track/track-webvtt-tc018-align-text-line-position-expected.txt: Added.
* media/track/track-webvtt-tc018-align-text-line-position.html: Added.
* media/track/track-webvtt-tc019-cue-size-expected.txt: Added.
* media/track/track-webvtt-tc019-cue-size.html: Added.
* media/track/track-webvtt-tc020-cue-size-align-expected.txt: Added.
* media/track/track-webvtt-tc020-cue-size-align.html: Added.
* media/track/track-webvtt-tc021-valign-expected.txt: Added.
* media/track/track-webvtt-tc021-valign.html: Added.
* media/track/track-webvtt-tc022-entities-expected.txt: Added.
* media/track/track-webvtt-tc022-entities.html: Added.
* media/track/track-webvtt-tc023-markup-expected.txt: Added.
* media/track/track-webvtt-tc023-markup.html: Added.
* media/track/track-webvtt-tc024-timestamp-expected.txt: Added.
* media/track/track-webvtt-tc024-timestamp.html: Added.
* media/track/track-webvtt-tc025-class-markup-expected.txt: Added.
* media/track/track-webvtt-tc025-class-markup.html: Added.
* media/track/track-webvtt-tc026-voice-expected.txt: Added.
* media/track/track-webvtt-tc026-voice.html: Added.
* media/track/track-webvtt-tc027-empty-cue-expected.txt: Added.
* media/track/track-webvtt-tc027-empty-cue.html: Added.
* media/track/track-webvtt-tc028-unsupported-markup-expected.txt: Added.
* media/track/track-webvtt-tc028-unsupported-markup.html: Added.
* media/video-test.js:
(testCues):
(allTestsEnded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
andreas.kling@nokia.com [Fri, 26 Aug 2011 17:19:11 +0000 (17:19 +0000)]
HTMLMetaElement: Don't cache "http-equiv" and "content" attributes.
https://bugs.webkit.org/show_bug.cgi?id=67040

Reviewed by Darin Adler.

* html/HTMLMetaElement.h: Remove m_equiv and m_content members,
shrinking HTMLMetaElement by 16 bytes (on 64-bit.)
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::parseMappedAttribute):
(WebCore::HTMLMetaElement::process): Implemented using fastGetAttribute().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [REGRESSION] No way to expand hovered objects while debugging.
pfeldman@chromium.org [Fri, 26 Aug 2011 16:57:31 +0000 (16:57 +0000)]
Web Inspector: [REGRESSION] No way to expand hovered objects while debugging.
https://bugs.webkit.org/show_bug.cgi?id=67039

Reviewed by Yury Semikhatsky.

* inspector/front-end/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype.show):
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._hidePopover):
(WebInspector.PopoverHelper.prototype._mouseHover):
(WebInspector.PopoverHelper.prototype._killHidePopoverTimer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r93870.
podivilov@chromium.org [Fri, 26 Aug 2011 16:26:04 +0000 (16:26 +0000)]
Unreviewed, rolling out r93870.
http://trac.webkit.org/changeset/93870
https://bugs.webkit.org/show_bug.cgi?id=65203

Broke i18n chromium tests

Source/WebCore:

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::windowsCanHandleDrawTextShadow):
(WebCore::windowsCanHandleTextDrawing):
(WebCore::windowsCanHandleTextDrawingWithoutShadow):
* platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGut WKPageCreateSnapshotOfVisibleContent so that it can be removed later.
commit-queue@webkit.org [Fri, 26 Aug 2011 16:15:25 +0000 (16:15 +0000)]
Gut WKPageCreateSnapshotOfVisibleContent so that it can be removed later.
https://bugs.webkit.org/show_bug.cgi?id=66979.

Removing the function altogether would break the nightlies.
This patch removes the code behind it so that it is clear that
WKPageCreateSnapshotOfVisibleContent should not be used, and so that the code isn't just
left rotting in the tree.

Patch by Jessie Berlin <jberlin@apple.com> on 2011-08-26
Reviewed by Brian Weinstein.

* UIProcess/API/C/WKPage.cpp:
(WKPageCreateSnapshotOfVisibleContent):
Return 0.
* UIProcess/API/C/WKPagePrivate.h:
Update the comment and add a link to the bug.

* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:

* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium Mac: Use a custom pattern image for rubber banding overhang area
commit-queue@webkit.org [Fri, 26 Aug 2011 15:29:03 +0000 (15:29 +0000)]
Chromium Mac: Use a custom pattern image for rubber banding overhang area
https://bugs.webkit.org/show_bug.cgi?id=66707

Also roll Chromium revision to 98101, to include dependency: http://codereview.chromium.org/7714036/

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-26
Reviewed by Dimitri Glazkov.

No new tests since its just changing the Chromium-specific overhang pattern.

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<video> playlist can not advance when playing in background tab
eric.carlson@apple.com [Fri, 26 Aug 2011 15:14:03 +0000 (15:14 +0000)]
<video> playlist can not advance when playing in background tab
https://bugs.webkit.org/show_bug.cgi?id=66978

Reviewed by Darin Adler.

No new tests added because it isn't possible to simulate a background tab in DRT.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Set RequirePageConsentToLoadMedia restriction.
(WebCore::HTMLMediaElement::loadInternal): Don't consider page->canStartMedia if it has ever
    allowed a file to load.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::requirePageConsentToLoadMedia): New.
(WebCore::HTMLMediaElement::removeBehaviorRestriction): New.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoving some tests from the GTK+ skipped lists that have results now
mrobinson@webkit.org [Fri, 26 Aug 2011 15:06:42 +0000 (15:06 +0000)]
Removing some tests from the GTK+ skipped lists that have results now
or no longer exist.

* platform/gtk/Skipped: Clean up.
* platform/gtk/test_expectations.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline Qt (4.7) after r93873.
andreas.kling@nokia.com [Fri, 26 Aug 2011 14:57:10 +0000 (14:57 +0000)]
Rebaseline Qt (4.7) after r93873.

* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
* platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* platform/qt/svg/batik/text/textOnPath-expected.txt:
* platform/qt/svg/batik/text/textOnPath2-expected.txt:
* platform/qt/svg/batik/text/textOnPath3-expected.txt:
* platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/qt/svg/text/text-path-01-b-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-26 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 26 Aug 2011 14:06:04 +0000 (14:06 +0000)]
2011-08-26  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix error in chromium test_expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK baselines for new tests.
philn@webkit.org [Fri, 26 Aug 2011 14:02:33 +0000 (14:02 +0000)]
    Unreviewed, GTK baselines for new tests.

        * platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
        * platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
        * platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
        * platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
        * platform/gtk/fast/table/table-before-child-in-table-expected.txt: Added.
        * platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt: Added.
        * platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt: Added.
        * platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt: Added.
        * platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt: Added.
        * platform/gtk/fast/table/table-row-after-child-in-block-expected.txt: Added.
        * platform/gtk/fast/table/table-row-after-child-in-table-expected.txt: Added.
        * platform/gtk/fast/table/table-row-before-child-in-block-expected.txt: Added.
        * platform/gtk/fast/table/table-row-before-child-in-table-expected.txt: Added.
        * platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
        * platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
        * platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
        * platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
        * platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Path::boundingRect() is unnecessarily slow.
andreas.kling@nokia.com [Fri, 26 Aug 2011 13:35:09 +0000 (13:35 +0000)]
[Qt] Path::boundingRect() is unnecessarily slow.
https://bugs.webkit.org/show_bug.cgi?id=66854

Reviewed by Benjamin Poulain.

Source/WebCore:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke): Remove Qt-specific optimization
since calling Path::boundingRect() will now do exactly the same thing.
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::boundingRect): Return QPainterPath::controlPointRect() since
that is much faster than computing the (precise) QPainterPath::boundingRect()
and Path::boundingRect() is not expected to be 100% precise anyway.

LayoutTests:

Rebaseline SVG tests after Path::boundingRect() change.
This brings Qt quite a bit closer to CG and Skia metrics.

* platform/qt-4.8/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
* platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
* platform/qt-4.8/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
* platform/qt-4.8/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
* platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
* platform/qt-4.8/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
* platform/qt-4.8/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
* platform/qt-4.8/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
* platform/qt-4.8/svg/batik/text/textOnPath-expected.txt:
* platform/qt-4.8/svg/batik/text/textOnPath2-expected.txt:
* platform/qt-4.8/svg/batik/text/textOnPath3-expected.txt:
* platform/qt-4.8/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/qt-4.8/svg/text/text-path-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
* platform/qt/svg/custom/animate-path-morphing-expected.txt:
* platform/qt/svg/custom/broken-internal-references-expected.txt:
* platform/qt/svg/custom/control-points-for-S-and-T-expected.txt:
* platform/qt/svg/custom/path-textPath-simulation-expected.txt:
* platform/qt/svg/custom/second-inline-text-expected.txt:
* platform/qt/svg/custom/use-nested-transform-expected.txt:
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt:
* platform/qt/svg/hixie/perf/001-expected.txt:
* platform/qt/svg/hixie/perf/002-expected.txt:
* platform/qt/svg/hixie/shapes/path/001-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, another rebaseline after switch to GTK+3.x.
philn@webkit.org [Fri, 26 Aug 2011 13:22:50 +0000 (13:22 +0000)]
    Unreviewed, another rebaseline after switch to GTK+3.x.

        * platform/gtk/editing/selection/caret-rtl-2-expected.txt:
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
        * platform/gtk/editing/selection/caret-rtl-expected.txt:
        * platform/gtk/editing/selection/caret-rtl-right-expected.txt:
        * platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt:
        * platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
        * platform/gtk/fast/borders/bidi-012-expected.txt:
        * platform/gtk/fast/borders/rtl-border-04-expected.txt:
        * platform/gtk/fast/css/rtl-ordering-expected.txt:
        * platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
        * platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
        * platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
        * platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
        * platform/gtk/fast/forms/search-rtl-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
        * platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
        * platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
        * platform/gtk/fast/text/drawBidiText-expected.txt:
        * platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
        * platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
        * platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
        * platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
        * platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
        * platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
        * platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
        * platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
        * platform/gtk/fast/text/international/bidi-innertext-expected.txt:
        * platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
        * platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
        * platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
        * platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
        * platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
        * platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
        * platform/gtk/fast/text/international/bidi-override-expected.txt:
        * platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
        * platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
        * platform/gtk/fast/text/international/rtl-caret-expected.txt:
        * platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
        * platform/gtk/fast/text/trailing-white-space-2-expected.txt:
        * platform/gtk/fast/text/trailing-white-space-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
        * platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
        * platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
        * platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
        * platform/gtk/svg/text/text-tselect-02-f-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd a state enumeration to track down cause of null CachedScript execution
gavinp@chromium.org [Fri, 26 Aug 2011 13:15:00 +0000 (13:15 +0000)]
add a state enumeration to track down cause of null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=66939

Reviewed by Alexey Proskuryakov.

Over in http://code.google.com/p/chromium/issues/detail?id=75604 I
have a bug I cannot reproduce.  I added an earlier crash in
https://bugs.webkit.org/show_bug.cgi?id=65563 , and we've since
gotten many good stacks, all coming in through a failed request that
eventually calls notifyFinished() on a ScriptElement with a NULL
m_cachedScript.

I'd like to know how this got NULL.  This enumeration should let
me find that in stack dumps from reproductions.

No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[skia] never draw with GDI, so that all text can be gpu-accelerated
reed@google.com [Fri, 26 Aug 2011 13:12:48 +0000 (13:12 +0000)]
[skia] never draw with GDI, so that all text can be gpu-accelerated
https://bugs.webkit.org/show_bug.cgi?id=65203

Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
(WebCore::drawGlyphsWin):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
* platform/graphics/skia/PlatformContextSkia.cpp:
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/skia/SkiaFontWin.cpp:
* platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-26 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 26 Aug 2011 12:50:07 +0000 (12:50 +0000)]
2011-08-26  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, rebaseline chromium fast/borders/* tests.

        * fast/borders/borderRadiusArcs01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusArcs01-expected.txt.
        * fast/borders/borderRadiusDashed02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed02-expected.txt.
        * fast/borders/borderRadiusDashed03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDashed03-expected.txt.
        * fast/borders/borderRadiusDotted01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDotted01-expected.txt.
        * fast/borders/borderRadiusDouble01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble01-expected.txt.
        * fast/borders/borderRadiusDouble02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble02-expected.txt.
        * fast/borders/borderRadiusDouble03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusDouble03-expected.txt.
        * fast/borders/borderRadiusGroove01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove01-expected.txt.
        * fast/borders/borderRadiusGroove02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusGroove02-expected.txt.
        * fast/borders/borderRadiusInset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusInset01-expected.txt.
        * fast/borders/borderRadiusOutset01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusOutset01-expected.txt.
        * fast/borders/borderRadiusRidge01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusRidge01-expected.txt.
        * fast/borders/borderRadiusSolid01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid01-expected.txt.
        * fast/borders/borderRadiusSolid02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid02-expected.txt.
        * fast/borders/borderRadiusSolid03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid03-expected.txt.
        * fast/borders/borderRadiusSolid04-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/borderRadiusSolid04-expected.txt.
        * fast/borders/fieldsetBorderRadius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt.
        * platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Removed.
        * platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Removed.
        * platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Removed.
        * platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-inline-flow-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
        * platform/chromium-linux/fast/borders/different-color-borders-expected.png:
        * platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
        * platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
        * platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
        * platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
        * platform/chromium-linux/fast/borders/rtl-border-04-expected.png:
        * platform/chromium-linux/fast/borders/rtl-border-05-expected.png:
        * platform/chromium-win/fast/borders/border-antialiasing-expected.png:
        * platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
        * platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-win/fast/borders/border-radius-inline-flow-expected.png:
        * platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
        * platform/chromium-win/fast/borders/different-color-borders-expected.png:
        * platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
        * platform/chromium-win/fast/borders/rtl-border-01-expected.png:
        * platform/chromium-win/fast/borders/rtl-border-02-expected.png:
        * platform/chromium-win/fast/borders/rtl-border-03-expected.png:
        * platform/chromium-win/fast/borders/rtl-border-04-expected.png:
        * platform/chromium-win/fast/borders/rtl-border-05-expected.png:
        * platform/chromium-win/fast/borders/table-borders-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
        * platform/qt/fast/borders/borderRadiusDashed02-expected.txt: Removed.
        * platform/qt/fast/borders/borderRadiusDashed03-expected.txt: Removed.
        * platform/qt/fast/borders/borderRadiusDotted01-expected.txt: Removed.
        * platform/qt/fast/borders/fieldsetBorderRadius-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: in some cases Popover code is failing to calculate popover box position.
loislo@chromium.org [Fri, 26 Aug 2011 12:32:46 +0000 (12:32 +0000)]
Web Inspector: in some cases Popover code is failing to calculate popover box position.
https://bugs.webkit.org/show_bug.cgi?id=67029

Reviewed by Yury Semikhatsky.

* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._positionElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMinor style fix in the sample code for WebKitWebFrame.
kov@webkit.org [Fri, 26 Aug 2011 12:28:23 +0000 (12:28 +0000)]
Minor style fix in the sample code for WebKitWebFrame.

* webkit/webkitwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK rebaseline of some svg tests after switch to
philn@webkit.org [Fri, 26 Aug 2011 11:31:17 +0000 (11:31 +0000)]
    Unreviewed, GTK rebaseline of some svg tests after switch to
        GTK+-3.x.

        * platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
        * platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
        * platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
        * platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
        * platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
        * platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
        * platform/gtk/svg/text/text-tselect-02-f-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK rebaseline of some fast/ tests after switch to
philn@webkit.org [Fri, 26 Aug 2011 11:24:47 +0000 (11:24 +0000)]
    Unreviewed, GTK rebaseline of some fast/ tests after switch to
        GTK+-3.x.

        * platform/gtk/fast/borders/bidi-012-expected.txt:
        * platform/gtk/fast/borders/rtl-border-04-expected.txt:
        * platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
        * platform/gtk/fast/css/rtl-ordering-expected.txt:
        * platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
        * platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
        * platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
        * platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt:
        * platform/gtk/fast/forms/isindex-placeholder-expected.txt:
        * platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
        * platform/gtk/fast/forms/password-placeholder-expected.txt:
        * platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
        * platform/gtk/fast/forms/placeholder-position-expected.txt:
        * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/gtk/fast/forms/search-rtl-expected.txt:
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
        * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
        * platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
        * platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
        * platform/gtk/fast/text/drawBidiText-expected.txt:
        * platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
        * platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
        * platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
        * platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
        * platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
        * platform/gtk/fast/text/international/bidi-european-terminators-expected.txt:
        * platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
        * platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
        * platform/gtk/fast/text/international/bidi-innertext-expected.txt:
        * platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
        * platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
        * platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
        * platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
        * platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
        * platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
        * platform/gtk/fast/text/international/bidi-override-expected.txt:
        * platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
        * platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
        * platform/gtk/fast/text/international/rtl-caret-expected.txt:
        * platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
        * platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
        * platform/gtk/fast/text/trailing-white-space-2-expected.txt:
        * platform/gtk/fast/text/trailing-white-space-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 26 Aug 2011 11:19:40 +0000 (11:19 +0000)]
2011-08-26  Nikolas Zimmermann  <nzimmermann@rim.com>

        [Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
        https://bugs.webkit.org/show_bug.cgi?id=65969

        Not reviewed. Unskip this test on Qt, it's fixed now.

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK rebaseline of some editing tests after switch to
philn@webkit.org [Fri, 26 Aug 2011 11:10:21 +0000 (11:10 +0000)]
    Unreviewed, GTK rebaseline of some editing tests after switch to
        GTK+-3.x.

        * platform/gtk/editing/pasteboard/4641033-expected.txt:
        * platform/gtk/editing/selection/caret-rtl-2-expected.txt:
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
        * platform/gtk/editing/selection/caret-rtl-expected.txt:
        * platform/gtk/editing/selection/caret-rtl-right-expected.txt:
        * platform/gtk/editing/selection/move-by-word-visually-multi-line-expected.txt: Added.
        * platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
        * platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-26 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 26 Aug 2011 10:02:48 +0000 (10:02 +0000)]
2011-08-26  Nikolas Zimmermann  <nzimmermann@rim.com>

        [Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently
        https://bugs.webkit.org/show_bug.cgi?id=65969

        Reviewed by Zoltan Herczeg.

        Fix intrinsic size negotiation flakiness, most visible on the Qt port.

        The http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm testcase triggered
        an assertion on a Qt debug build indicating that the HashSet updateLayoutAndStyleIfNeededRecursive()
        operates on is mutated while its iterated, leading to an assertion/crash. Due the new forceLayoutParentViewIfNeeded()
        logic it's no longer safe to directly use the children() HashSet in that method - we have to make a copy first.

        The second part of the fix is to stop entering forceLayoutParentViewIfNeeded(), if the origin of that call
        is forceLayoutParentViewIfNeeded() itself. Set m_inLayoutParentView to true before calling FrameView::layout()
        on our parent frame view - this is only an optimization to avoid doing layout() twice.

        The third part of the fix is to call updateWidgetPositions() on the parent FrameView, _before_ calling layout()
        on the parent view itself, as the SVG document needs to report the correct intrinsic size (which can depend
        on the host object/embed/iframe) when we're running RenderReplaced::layout() on the host renderer.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::collectFrameViewChildren):
        (WebCore::FrameView::forceLayoutParentViewIfNeeded):
        (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
        * page/FrameView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn...
mnaganov@chromium.org [Fri, 26 Aug 2011 09:56:17 +0000 (09:56 +0000)]
Web Inspector: [Chromium] Double clicking on numbers in Count & size columns doesn't toggle between values and percents in the Heap Snapshot.
https://bugs.webkit.org/show_bug.cgi?id=66988

Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._mouseClickInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r93853.
koz@chromium.org [Fri, 26 Aug 2011 09:06:56 +0000 (09:06 +0000)]
Unreviewed, rolling out r93853.
http://trac.webkit.org/changeset/93853
https://bugs.webkit.org/show_bug.cgi?id=67016

Turns bots red

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Add Qt specific expected results for new tests introduced...
ossy@webkit.org [Fri, 26 Aug 2011 09:05:07 +0000 (09:05 +0000)]
[Qt] Unreviewed gardening. Add Qt specific expected results for new tests introduced in r93794.

* platform/qt/Skipped:
* platform/qt/fast/table/table-after-child-in-table-expected.png: Added.
* platform/qt/fast/table/table-after-child-in-table-expected.txt: Added.
* platform/qt/fast/table/table-before-child-in-table-expected.png: Added.
* platform/qt/fast/table/table-before-child-in-table-expected.txt: Added.
* platform/qt/fast/table/table-cell-after-child-in-block-expected.png: Added.
* platform/qt/fast/table/table-cell-after-child-in-block-expected.txt: Added.
* platform/qt/fast/table/table-cell-after-child-in-table-expected.png: Added.
* platform/qt/fast/table/table-cell-after-child-in-table-expected.txt: Added.
* platform/qt/fast/table/table-cell-before-child-in-block-expected.png: Added.
* platform/qt/fast/table/table-cell-before-child-in-block-expected.txt: Added.
* platform/qt/fast/table/table-cell-before-child-in-table-expected.png: Added.
* platform/qt/fast/table/table-cell-before-child-in-table-expected.txt: Added.
* platform/qt/fast/table/table-row-after-child-in-block-expected.png: Added.
* platform/qt/fast/table/table-row-after-child-in-block-expected.txt: Added.
* platform/qt/fast/table/table-row-after-child-in-table-expected.png: Added.
* platform/qt/fast/table/table-row-after-child-in-table-expected.txt: Added.
* platform/qt/fast/table/table-row-before-child-in-block-expected.png: Added.
* platform/qt/fast/table/table-row-before-child-in-block-expected.txt: Added.
* platform/qt/fast/table/table-row-before-child-in-table-expected.png: Added.
* platform/qt/fast/table/table-row-before-child-in-table-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r93390): Empty or invalid maxlength of an input tag should be ignored.
commit-queue@webkit.org [Fri, 26 Aug 2011 08:59:01 +0000 (08:59 +0000)]
REGRESSION(r93390): Empty or invalid maxlength of an input tag should be ignored.
https://bugs.webkit.org/show_bug.cgi?id=67015

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-08-26
Reviewed by Kent Tamura.

Source/WebCore:

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMaxLengthAttribute):
  Checks the validity of maxlength attribute when converting it to integer.

LayoutTests:

* fast/forms/input-text-paste-maxlength-expected.txt:
   Added maxlength="" and maxlength="invalid" tests.
* fast/forms/input-text-paste-maxlength.html: ditto.
* fast/forms/script-tests/textarea-maxlength.js: ditto.
* fast/forms/textarea-maxlength-expected.txt: ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake show-pretty-diff work on linux
noel.gordon@gmail.com [Fri, 26 Aug 2011 08:52:16 +0000 (08:52 +0000)]
Make show-pretty-diff work on linux
https://bugs.webkit.org/show_bug.cgi?id=67017

Reviewed by Adam Barth.

* Scripts/show-pretty-diff:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Fix indentation of WebSocket header files
yutak@chromium.org [Fri, 26 Aug 2011 06:48:34 +0000 (06:48 +0000)]
WebSocket: Fix indentation of WebSocket header files
https://bugs.webkit.org/show_bug.cgi?id=67018

Reviewed by Kent Tamura.

No new tests. Style fix only.

* websockets/WebSocket.h:
(WebCore::WebSocket::create):
(WebCore::WebSocket::toWebSocket):
(WebCore::WebSocket::refEventTarget):
(WebCore::WebSocket::derefEventTarget):
* websockets/WebSocketChannel.h:
Removed formal parameter name of resumeTimerFired().
(WebCore::WebSocketChannel::create):
(WebCore::WebSocketChannel::refThreadableWebSocketChannel):
(WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
(WebCore::WebSocketChannel::isNonControlOpCode):
(WebCore::WebSocketChannel::isControlOpCode):
(WebCore::WebSocketChannel::isReservedOpCode):
* websockets/WebSocketHandshake.h:
Removed formal parameter name of setClientProtocol().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expectations to remove conflict
koz@chromium.org [Fri, 26 Aug 2011 06:44:14 +0000 (06:44 +0000)]
Update expectations to remove conflict
https://bugs.webkit.org/show_bug.cgi?id=67020

Unreviewed, expectations update.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTouch GtkVersioning.c so that the release bot rebuilds it. This
mrobinson@webkit.org [Fri, 26 Aug 2011 06:41:47 +0000 (06:41 +0000)]
Touch GtkVersioning.c so that the release bot rebuilds it. This
is necessary because of the switch to GTK+ 3.x.

* platform/gtk/GtkVersioning.c: Touch this file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=67016
commit-queue@webkit.org [Fri, 26 Aug 2011 06:23:24 +0000 (06:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67016

Unreviewed, test expectations update.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-25

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Xan Lopez.
mrobinson@webkit.org [Fri, 26 Aug 2011 05:35:10 +0000 (05:35 +0000)]
Reviewed by Xan Lopez.

.:

[GTK] Switch to GTK+ 3.x by default
https://bugs.webkit.org/show_bug.cgi?id=63047

* configure.ac: Modify the default value of the --with-gtk option to be 3.0.

LayoutTests:

Update GTK+ result that depend on the GTK+ version.

* platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
* platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
* platform/gtk/editing/pasteboard/4641033-expected.png:
* platform/gtk/editing/pasteboard/4641033-expected.txt:
* platform/gtk/editing/pasteboard/4944770-1-expected.png:
* platform/gtk/editing/pasteboard/4944770-1-expected.txt:
* platform/gtk/editing/pasteboard/4944770-2-expected.png:
* platform/gtk/editing/pasteboard/4944770-2-expected.txt:
* platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
* platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
* platform/gtk/editing/selection/caret-before-select-expected.png:
* platform/gtk/editing/selection/caret-before-select-expected.txt:
* platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
* platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
* platform/gtk/editing/selection/select-box-expected.png:
* platform/gtk/editing/selection/select-box-expected.txt:
* platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
* platform/gtk/fast/block/basic/011-expected.png:
* platform/gtk/fast/block/basic/011-expected.txt:
* platform/gtk/fast/block/float/float-avoidance-expected.png:
* platform/gtk/fast/block/float/float-avoidance-expected.txt:
* platform/gtk/fast/block/margin-collapse/103-expected.png:
* platform/gtk/fast/block/margin-collapse/103-expected.txt:
* platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
* platform/gtk/fast/forms/001-expected.png:
* platform/gtk/fast/forms/001-expected.txt:
* platform/gtk/fast/forms/003-expected.png:
* platform/gtk/fast/forms/003-expected.txt:
* platform/gtk/fast/forms/004-expected.png:
* platform/gtk/fast/forms/004-expected.txt:
* platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
* platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
* platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
* platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
* platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
* platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
* platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
* platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
* platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
* platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
* platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
* platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
* platform/gtk/fast/forms/basic-inputs-expected.png:
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/basic-selects-expected.png:
* platform/gtk/fast/forms/basic-selects-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.png:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/checkbox-radio-onchange-expected.png:
* platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
* platform/gtk/fast/forms/control-clip-overflow-expected.png:
* platform/gtk/fast/forms/control-clip-overflow-expected.txt:
* platform/gtk/fast/forms/control-restrict-line-height-expected.png:
* platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
* platform/gtk/fast/forms/disabled-select-change-index-expected.png:
* platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
* platform/gtk/fast/forms/file-input-disabled-expected.png:
* platform/gtk/fast/forms/file-input-disabled-expected.txt:
* platform/gtk/fast/forms/form-element-geometry-expected.png:
* platform/gtk/fast/forms/form-element-geometry-expected.txt:
* platform/gtk/fast/forms/formmove-expected.png:
* platform/gtk/fast/forms/formmove-expected.txt:
* platform/gtk/fast/forms/formmove2-expected.png:
* platform/gtk/fast/forms/formmove2-expected.txt:
* platform/gtk/fast/forms/indeterminate-expected.png:
* platform/gtk/fast/forms/indeterminate-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.png:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-number-rtl-expected.png:
* platform/gtk/fast/forms/input-appearance-number-rtl-expected.txt:
* platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.png:
* platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png:
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
* platform/gtk/fast/forms/input-value-expected.png:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/forms/menulist-clip-expected.png:
* platform/gtk/fast/forms/menulist-clip-expected.txt:
* platform/gtk/fast/forms/menulist-deselect-update-expected.png:
* platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
* platform/gtk/fast/forms/menulist-narrow-width-expected.png:
* platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
* platform/gtk/fast/forms/menulist-no-overflow-expected.png:
* platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
* platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
* platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
* platform/gtk/fast/forms/menulist-separator-painting-expected.png:
* platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
* platform/gtk/fast/forms/menulist-style-color-expected.png:
* platform/gtk/fast/forms/menulist-style-color-expected.txt:
* platform/gtk/fast/forms/menulist-width-change-expected.png:
* platform/gtk/fast/forms/menulist-width-change-expected.txt:
* platform/gtk/fast/forms/option-script-expected.png:
* platform/gtk/fast/forms/option-script-expected.txt:
* platform/gtk/fast/forms/option-strip-whitespace-expected.png:
* platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
* platform/gtk/fast/forms/option-text-clip-expected.png:
* platform/gtk/fast/forms/option-text-clip-expected.txt:
* platform/gtk/fast/forms/radio-attr-order-expected.png:
* platform/gtk/fast/forms/radio-attr-order-expected.txt:
* platform/gtk/fast/forms/radio-nested-labels-expected.png:
* platform/gtk/fast/forms/radio-nested-labels-expected.txt:
* platform/gtk/fast/forms/radio_checked-expected.png:
* platform/gtk/fast/forms/radio_checked-expected.txt:
* platform/gtk/fast/forms/radio_checked_dynamic-expected.png:
* platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:
* platform/gtk/fast/forms/select-align-expected.png:
* platform/gtk/fast/forms/select-align-expected.txt:
* platform/gtk/fast/forms/select-background-none-expected.png:
* platform/gtk/fast/forms/select-background-none-expected.txt:
* platform/gtk/fast/forms/select-baseline-expected.png:
* platform/gtk/fast/forms/select-baseline-expected.txt:
* platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
* platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
* platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
* platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
* platform/gtk/fast/forms/select-disabled-appearance-expected.png:
* platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
* platform/gtk/fast/forms/select-empty-option-height-expected.png:
* platform/gtk/fast/forms/select-empty-option-height-expected.txt:
* platform/gtk/fast/forms/select-initial-position-expected.png:
* platform/gtk/fast/forms/select-initial-position-expected.txt:
* platform/gtk/fast/forms/select-selected-expected.png:
* platform/gtk/fast/forms/select-selected-expected.txt:
* platform/gtk/fast/forms/select-size-expected.png:
* platform/gtk/fast/forms/select-size-expected.txt:
* platform/gtk/fast/forms/select-style-expected.png:
* platform/gtk/fast/forms/select-style-expected.txt:
* platform/gtk/fast/forms/select-visual-hebrew-expected.png:
* platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
* platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
* platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
* platform/gtk/fast/forms/selectlist-minsize-expected.png:
* platform/gtk/fast/forms/selectlist-minsize-expected.txt:
* platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
* platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
* platform/gtk/fast/inline/positionedLifetime-expected.png:
* platform/gtk/fast/inline/positionedLifetime-expected.txt:
* platform/gtk/fast/invalid/014-expected.png:
* platform/gtk/fast/invalid/014-expected.txt:
* platform/gtk/fast/invalid/residual-style-expected.png:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/gtk/fast/parser/bad-xml-slash-expected.png:
* platform/gtk/fast/parser/bad-xml-slash-expected.txt:
* platform/gtk/fast/parser/document-write-option-expected.png:
* platform/gtk/fast/parser/document-write-option-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-expected.png:
* platform/gtk/fast/replaced/replaced-breaking-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/gtk/fast/replaced/table-percent-height-expected.txt:
* platform/gtk/fast/replaced/three-selects-break-expected.png:
* platform/gtk/fast/replaced/three-selects-break-expected.txt:
* platform/gtk/fast/replaced/width100percent-checkbox-expected.png:
* platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
* platform/gtk/fast/replaced/width100percent-menulist-expected.png:
* platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
* platform/gtk/fast/replaced/width100percent-radio-expected.png:
* platform/gtk/fast/replaced/width100percent-radio-expected.txt:
* platform/gtk/fast/text/international/bidi-menulist-expected.png:
* platform/gtk/fast/text/international/bidi-menulist-expected.txt:
* platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
* platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
* platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
* platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
* platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
* platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png:
* platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
* platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
* platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
* platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
* platform/gtk/tables/mozilla/core/margins-expected.png:
* platform/gtk/tables/mozilla/core/margins-expected.txt:
* platform/gtk/tables/mozilla/dom/tableDom-expected.png:
* platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/gtk/transforms/2d/zoom-menulist-expected.png:
* platform/gtk/transforms/2d/zoom-menulist-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable fullscreen API in Chromium by default.
commit-queue@webkit.org [Fri, 26 Aug 2011 04:59:54 +0000 (04:59 +0000)]
Enable fullscreen API in Chromium by default.
https://bugs.webkit.org/show_bug.cgi?id=66993

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-08-25
Reviewed by Adam Barth.

* features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse PATH_BASED_BORDER_RADIUS_DRAWING for skia
commit-queue@webkit.org [Fri, 26 Aug 2011 04:27:02 +0000 (04:27 +0000)]
Use PATH_BASED_BORDER_RADIUS_DRAWING for skia
https://bugs.webkit.org/show_bug.cgi?id=65583

Source/WebCore:

This change brings in the new border rendering for Skia. To support this without aliasing the skia
graphics context has been updated to support anti-aliased clipping around convex polygons and also
anti-aliased clipping outside a path.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::clipPathAntiAliased):
* rendering/RenderObject.h:

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-25
Reviewed by James Robinson.

Update expectations: added failures for baselines to come. removed some
failure expectations for tests that now pass and moved some expectations
into the group of tests to be rebaselined.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip some tests on GTK+ that are missing DRT functionality. Also
mrobinson@webkit.org [Fri, 26 Aug 2011 02:54:09 +0000 (02:54 +0000)]
Skip some tests on GTK+ that are missing DRT functionality. Also
reorganize some failures on the skipped list.

* platform/gtk/Skipped: Update the skipped list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement animation and transition properties in CSSStyleApplyProperty.
macpherson@chromium.org [Fri, 26 Aug 2011 01:32:18 +0000 (01:32 +0000)]
Implement animation and transition properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66126

Reviewed by Dean Jackson.

No new tests. This is essentially a refactoring of the HANDLE_ANIMATION* and HANDLE_TRANSITION* macros in CSSStyleSelector.cpp.
The only functional change is to iterate correctly over the lists instead of setting only the first element. See bug 66118 for details on that.

* css/CSSStyleApplyProperty.cpp:
Added new class ApplyPropertyAnimation to handle animation and transition properties.
(WebCore::ApplyPropertyAnimation::ApplyPropertyAnimation):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
Removed animation and transition macros (celebrate!)
(WebCore::CSSStyleSelector::applyProperty):
Removed old implementations of animation and transition properties.
* platform/animation/Animation.h:
Changed return types of initial values to match the setters and getters.
(WebCore::Animation::initialAnimationDelay):
(WebCore::Animation::initialAnimationName):
(WebCore::Animation::initialAnimationTimingFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReorganize garden-o-matic CSS files to match JS-built views.
dglazkov@chromium.org [Fri, 26 Aug 2011 01:06:14 +0000 (01:06 +0000)]
Reorganize garden-o-matic CSS files to match JS-built views.
https://bugs.webkit.org/show_bug.cgi?id=66998

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTemporarily mark some tests as crashing (assertion failure) after r93794.
pkasting@chromium.org [Fri, 26 Aug 2011 01:05:30 +0000 (01:05 +0000)]
Temporarily mark some tests as crashing (assertion failure) after r93794.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agokNPEventStartIME doesn't work correctly for NPAPI
andersca@apple.com [Fri, 26 Aug 2011 01:02:25 +0000 (01:02 +0000)]
kNPEventStartIME doesn't work correctly for NPAPI
https://bugs.webkit.org/show_bug.cgi?id=65264
<rdar://problem/9996476>

Reviewed by Sam Weinig.

In order to remain compatible with older plug-ins, the updated input model won't
be turned on unless a plug-in explicitly asks whether we support it. The plug-in must do
this before any keyboard events have been processed.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::setComplexTextInputState):
Add the CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply flag to this message since we want
the web process to handle it while it's waiting for a reply to the PluginControllerProxy::HandleMouseEvent
synchronous message.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Implement the logic for when to turn off the legacy Cocoa text input model support.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_ignoreNextKeyUpEvent to false.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add m_ignoreNextKeyUpEvent member variable.

(WebKit::NetscapePlugin::hasHandledAKeyDownEvent):
Add a getter.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Don't send keydown and keyup events when complex text input is enabled in the updated model.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrectly handle events in the updated Cocoa text input model
andersca@apple.com [Fri, 26 Aug 2011 00:54:43 +0000 (00:54 +0000)]
Correctly handle events in the updated Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67005

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
When using the updated model, always return a string even for 'simple' characters.

* UIProcess/API/mac/WKView.mm:
(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Only let the input method have a crack at the event in the legacy model.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove Windows-specific WebPageProxy code to WebPageProxyWin.cpp
jeffm@apple.com [Fri, 26 Aug 2011 00:51:06 +0000 (00:51 +0000)]
Move Windows-specific WebPageProxy code to WebPageProxyWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=67002

Reviewed by Brian Weinstein.

* UIProcess/WebPageProxy.cpp: Moved Windows-only functions to WebPageProxyWin.cpp.

* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::getSelectedText): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureWillBegin): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidScroll): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::gestureDidEnd): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setGestureReachedScrollingLimit): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::startDragDrop): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::didChangeCompositionSelection): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::confirmComposition): Moved from WebPageProxy.cpp.
(WebKit::WebPageProxy::setComposition): Moved from WebPageProxy.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Some tests are apparently slow on Mac debug too.
pkasting@chromium.org [Fri, 26 Aug 2011 00:41:09 +0000 (00:41 +0000)]
[chromium] Some tests are apparently slow on Mac debug too.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing broken build due to unused variables in release mode
jchaffraix@webkit.org [Fri, 26 Aug 2011 00:41:03 +0000 (00:41 +0000)]
Fixing broken build due to unused variables in release mode
https://bugs.webkit.org/show_bug.cgi?id=67004

Unreviewed, release build fix.

Fixing broken build due to unused variables in ASSERTs in release build.

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-25

* runtime/JSObject.h:
(JSC::JSObject::finishCreation):
* runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::finishCreation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should be able to roll out patches
abarth@webkit.org [Fri, 26 Aug 2011 00:36:13 +0000 (00:36 +0000)]
garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=66982

Reviewed by Dimitri Glazkov.

This patch just wires the rollout event through the controller to the
local server, which is already set up to perform rollouts.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle key-down events in the updated Cocoa text input model
andersca@apple.com [Fri, 26 Aug 2011 00:34:10 +0000 (00:34 +0000)]
Handle key-down events in the updated Cocoa text input model
https://bugs.webkit.org/show_bug.cgi?id=67001

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _disableComplexTextInputIfNecessary]):
If the plug-in is using the updated Cocoa text input model specification, disable text input
if the text input window has been dismissed for whatever reason.

(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):
Call _disableComplexTextInputIfNecessary so that we'll inform the plug-in that complex text
input has been disabled.

(-[WKView _tryPostProcessPluginComplexTextInputKeyDown:]):
If the plug-in is using the updated Cocoa text input model specification, let the input methods
have a go at the keyboard event.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Actually set m_isComplexTextInputEnabled to the right value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFactor code to send a key-down event to the plug-in out into a new function
andersca@apple.com [Fri, 26 Aug 2011 00:06:52 +0000 (00:06 +0000)]
Factor code to send a key-down event to the plug-in out into a new function
https://bugs.webkit.org/show_bug.cgi?id=66999

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView _handlePluginComplexTextInputKeyDown:]):
(-[WKView _tryHandlePluginComplexTextInputKeyDown:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConcentrate RenderLayer repaint rects updates
jchaffraix@webkit.org [Thu, 25 Aug 2011 23:39:57 +0000 (23:39 +0000)]
Concentrate RenderLayer repaint rects updates
https://bugs.webkit.org/show_bug.cgi?id=64993

Reviewed by David Hyatt.

The change moves the update of the repaint rects to 2 methods
(computeRepaintRects and clearRepaintRects) to better track
those changes.

No new test, refactoring covered by the existing test cases.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Reverse the logic and
calculate the new bounds upfront. This should have no impact as none
of the methods rely on the internal value.

(WebCore::RenderLayer::computeRepaintRects): Added the cachedOffset parameter
to avoid breaking the performance optimization in updateLayerPositions. Added
some ASSERTS.

(WebCore::RenderLayer::clearRepaintRects): Added some ASSERTs here.
(WebCore::RenderLayer::updateRepaintRectsAfterScroll): Added a FIXME as this
method could use the cachedOffset trick too.

(WebCore::RenderLayer::setHasVisibleContent): Changed the code to use
computeRepaintRects.

* rendering/RenderLayer.h: Updated the signature of computeRepaintRects and moved
those 2 methods into the private section of the class.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Test expectation updates.
pkasting@chromium.org [Thu, 25 Aug 2011 23:33:10 +0000 (23:33 +0000)]
[chromium] Test expectation updates.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnzip initialization lists and constructors in JSCell hierarchy (1/7)
commit-queue@webkit.org [Thu, 25 Aug 2011 23:30:14 +0000 (23:30 +0000)]
Unzip initialization lists and constructors in JSCell hierarchy (1/7)
https://bugs.webkit.org/show_bug.cgi?id=66827

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-08-25
Reviewed by Geoffrey Garen.

Added finishCreation() methods to all immediately subclasses of JSCell with
non-empty constructors.  Part of a larger refactoring to "unzip" initialization
lists and constructor bodies.  Also renamed JSCell's constructorBody() method
to finishCreation().

* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::constructorBody):
* runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::constructorBody):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::constructorBody):
* runtime/JSObject.h:
(JSC::JSObject::constructorBody):
(JSC::JSObject::JSObject):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::constructorBody):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::constructorBody):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::constructorBody):
* runtime/RegExp.h:
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::constructorBody):
* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::constructorBody):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove use of magic number -1 in WebCore/editing/visible_units.cpp
commit-queue@webkit.org [Thu, 25 Aug 2011 23:19:26 +0000 (23:19 +0000)]
Remove use of magic number -1 in WebCore/editing/visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=66980

Patch by Van Lam <vanlam@google.com> on 2011-08-25
Reviewed by Ryosuke Niwa.

Replaced use of magic number -1 with constant offsetNotFound.

* editing/visible_units.cpp:
(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add API to allow scripts to close windows automatically via JavaScript.
commit-queue@webkit.org [Thu, 25 Aug 2011 23:08:34 +0000 (23:08 +0000)]
[EFL] Add API to allow scripts to close windows automatically via JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=66777

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

Make it possible to allow or prevent scripts from closing windows
automatically (via window.close, for example).

Besides being useful in general, this is required by DRT.

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_close_windows_get):
(ewk_view_setting_scripts_can_close_windows_set):
* ewk/ewk_view.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
loki@webkit.org [Thu, 25 Aug 2011 23:08:11 +0000 (23:08 +0000)]
REGRESSION(r93755): It made 14 jsc test and ~500 layout test fail on Qt-ARM bot
https://bugs.webkit.org/show_bug.cgi?id=66956

Rebaseline constants for patching GetByIdSlowCaseCall on ARM.

Reviewed by Oliver Hunt.

* jit/JIT.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
commit-queue@webkit.org [Thu, 25 Aug 2011 23:06:47 +0000 (23:06 +0000)]
[Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
https://bugs.webkit.org/show_bug.cgi?id=66951

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-08-25
Reviewed by Andreas Kling.

Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
width and height one by one and setWidth cause geometryChange event in QTouchWebView.

* MiniBrowser/qt/BrowserView.cpp:
(BrowserView::resizeEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic summary view should provide information on builders still in flight.
dglazkov@chromium.org [Thu, 25 Aug 2011 23:02:55 +0000 (23:02 +0000)]
garden-o-matic summary view should provide information on builders still in flight.
https://bugs.webkit.org/show_bug.cgi?id=66992

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit-patch rebaseline-expectations don't work when run outside the root
abarth@webkit.org [Thu, 25 Aug 2011 22:58:28 +0000 (22:58 +0000)]
webkit-patch rebaseline-expectations don't work when run outside the root
https://bugs.webkit.org/show_bug.cgi?id=66966

Reviewed by Eric Seidel.

Turns out tool.path() used to be relative, which caused problems when
running webkit-patch outside the root directory.  This patch makes it
absolute.  I checked all callers, and they all appear to want this
behavior.

It was unclear to me how to test this change because we only really
have a testing strategy for webkitpy, not for the main script.

* Scripts/webkit-patch:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWKView should keep track of the plug-in complex text input state
andersca@apple.com [Thu, 25 Aug 2011 22:54:47 +0000 (22:54 +0000)]
WKView should keep track of the plug-in complex text input state
https://bugs.webkit.org/show_bug.cgi?id=66990

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKView.mm:
Add a _pluginComplexTextInputState ivar to WKViewData.

(-[WKView _setPluginComplexTextInputState:]):
Set the _pluginComplexTextInputState variable. If text input is being disabled, send back an empty string to the plug-in.

(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):
Call -[WKView _setPluginComplexTextInputState:].

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Apparently, expectations without WONTFIX or BUGxxx are ignored.
pkasting@chromium.org [Thu, 25 Aug 2011 22:34:36 +0000 (22:34 +0000)]
[chromium] Apparently, expectations without WONTFIX or BUGxxx are ignored.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove file internal methods to a class continuation in WKView
andersca@apple.com [Thu, 25 Aug 2011 22:33:12 +0000 (22:33 +0000)]
Move file internal methods to a class continuation in WKView
https://bugs.webkit.org/show_bug.cgi?id=66983

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKView.mm:
(-[WKView _deviceScaleFactor]):
(-[WKView _setDrawingAreaSize:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore work on the updated Cocoa text input specification
andersca@apple.com [Thu, 25 Aug 2011 21:20:49 +0000 (21:20 +0000)]
More work on the updated Cocoa text input specification
https://bugs.webkit.org/show_bug.cgi?id=66977

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add m_pluginWantsLegacyCocoaTextInput and m_hasHandledAKeyDownEvent.

(WebKit::NetscapePlugin::setPluginWantsLegacyCocoaTextInput):
Add setter. Not called yet.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Set m_hasHandledAKeyDownEvent to true if we get a KeyDown event.

(WebKit::NetscapePlugin::sendComplexTextInput):
If the plug-in is using the updated Cocoa text input spec, we can disable text input here.

(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):
If the plug-in is using the updated Cocoa text input spec, text input is not enabled when
the plug-in is focused.

(WebKit::NetscapePlugin::setComplexTextInputEnabled):
Set the right text input state based on whether the plug-in is using the updated spec or not.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic summary needs a mock view that could be used for working on styling
dglazkov@chromium.org [Thu, 25 Aug 2011 21:09:45 +0000 (21:09 +0000)]
garden-o-matic summary needs a mock view that could be used for working on styling
https://bugs.webkit.org/show_bug.cgi?id=66971

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Test expectation updates.
pkasting@chromium.org [Thu, 25 Aug 2011 21:00:11 +0000 (21:00 +0000)]
[chromium] Test expectation updates.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded myself to committers.
gavinp@chromium.org [Thu, 25 Aug 2011 20:58:15 +0000 (20:58 +0000)]
Added myself to committers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-25 Igor Oliveira <igor.oliveira@openbossa.org>
igor.oliveira@openbossa.org [Thu, 25 Aug 2011 20:56:55 +0000 (20:56 +0000)]
2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
(WebCore::RenderBox::hasControlClip):
(WebCore::RenderBox::controlClipRect):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Rollout r93799: Caused bad clipping on the bottom of tall glyphs inside a button label

* fast/css/button-overflow-ellipsis.html: Removed.
* platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Enable password echo on Symbian builds
ademar.reis@openbossa.org [Thu, 25 Aug 2011 20:29:30 +0000 (20:29 +0000)]
[Qt] Enable password echo on Symbian builds
https://bugs.webkit.org/show_bug.cgi?id=66954

Reviewed by Chang Shu.

No tests, as this is just a build change.

* config.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-25 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 25 Aug 2011 20:27:57 +0000 (20:27 +0000)]
2011-08-25  Nate Chapin  <japhet@chromium.org>

        Windows build fix after r93811.

        * loader/cf/ResourceLoaderCFNet.cpp:
        (WebCore::ResourceLoader::shouldCacheResponse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReturn the correct value for NPNVsupportsCarbonBool
andersca@apple.com [Thu, 25 Aug 2011 20:26:39 +0000 (20:26 +0000)]
Return the correct value for NPNVsupportsCarbonBool
https://bugs.webkit.org/show_bug.cgi?id=66964

Source/WebKit2:

Reviewed by Adam Roben.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Remove a FIXME and set the value to true.

Tools:

Add a test.

Reviewed by Adam Roben.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
(SupportsCarbonEventModel::SupportsCarbonEventModel):
(SupportsCarbonEventModel::testConvert):
(SupportsCarbonEventModel::runTest):
(SupportsCarbonEventModel::NPP_New):

LayoutTests:

Reviewed by Adam Roben.

Add test.

* platform/mac/plugins/supports-carbon-event-model-expected.txt: Added.
* platform/mac/plugins/supports-carbon-event-model.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
commit-queue@webkit.org [Thu, 25 Aug 2011 20:21:40 +0000 (20:21 +0000)]
[EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
https://bugs.webkit.org/show_bug.cgi?id=66690

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-25
Reviewed by Antonio Gomes.

The implementation is mostly based on the GTK+ port's, as we just need
to transfer the ownership of the frame to a new view and adjust the
smart object part accordingly.

This should help make fast/frames/iframe-reparenting-adopt-node.html
pass.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
* ewk/ewk_frame.cpp:
(ewk_frame_view_set):
(ewk_frame_view_create_for_view):
* ewk/ewk_private.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Further attempts to clean up the test expectations by being
pkasting@chromium.org [Thu, 25 Aug 2011 19:57:23 +0000 (19:57 +0000)]
[chromium] Further attempts to clean up the test expectations by being
more consistent about handling SKIPped and WONTFIXed tests.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit some of the variables out of ThreadableLoaderOptions
japhet@chromium.org [Thu, 25 Aug 2011 19:55:06 +0000 (19:55 +0000)]
Split some of the variables out of ThreadableLoaderOptions
into a superclass, ResourceLoaderOptions. Use ResourceLoaderOptions
all the way down to ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=63301

Reviewed by David Levin.

No new tests, refractor only.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentThreadableLoader.cpp:
* loader/MainResourceLoader.cpp:
* loader/NetscapePlugInStreamLoader.cpp:
* loader/ResourceLoadScheduler.cpp:
* loader/ResourceLoadScheduler.h:
* loader/ResourceLoader.cpp:
* loader/ResourceLoader.h:
* loader/ResourceLoaderOptions.h: Added.
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
* loader/ThreadableLoader.h:
* loader/cache/CachedResourceRequest.cpp:
* loader/mac/ResourceLoaderMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agouse strict in CodeGeneratorJS and CodeGeneratorV8
adamk@chromium.org [Thu, 25 Aug 2011 19:44:06 +0000 (19:44 +0000)]
use strict in CodeGeneratorJS and CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=66915

Reviewed by Darin Adler.

Making these files "use strict" makes changing them less
time-consuming and error-prone, and helps avoid accidentally
adding dead code (added a FIXME for one such case).

No expected change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
(GenerateImplementationFunctionCall):
(NativeToJSValue):
(GenerateHashValue):
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateNormalAttrSetter):
(GetFunctionTemplateCallbackName):
(GenerateNewFunctionTemplate):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
():

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable incremental linking for component build on Chromium
commit-queue@webkit.org [Thu, 25 Aug 2011 19:21:41 +0000 (19:21 +0000)]
Enable incremental linking for component build on Chromium
https://bugs.webkit.org/show_bug.cgi?id=66950

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-25
Reviewed by Darin Fisher.

Turns on Use Library Dependency Inputs for webkit.vcproj on Windows
build, when incremental_chrome_dll gyp flag is set. This is to get
faster incremental links on Windows builds.

* WebKit.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=21586
dino@apple.com [Thu, 25 Aug 2011 19:17:51 +0000 (19:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=21586
Apply CSS animations and transitions to SVG properties

Reviewed by Simon Fraser.

Expose the applicable SVG properties from SVGRenderStyle to
RenderStyle and add them to the list of animatable
properties. There aren't many SVG properties that are
animatable directly. SVGPaint (used in "fill" and "stroke")
is supported only when both ends of the animation are
a Color. Also updated SVGLength to have some methods
for converting to and from user space units.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic summary view should not be broken.
dglazkov@chromium.org [Thu, 25 Aug 2011 19:09:12 +0000 (19:09 +0000)]
garden-o-matic summary view should not be broken.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
(table.comparison): Added more specificity.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThis command has been broken for a while. This patch updates the
abarth@webkit.org [Thu, 25 Aug 2011 19:06:00 +0000 (19:06 +0000)]
This command has been broken for a while.  This patch updates the
callsite to the new API.

* Scripts/webkitpy/tool/commands/rebaseline.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed, rebaseline for bug 53438.
igor.oliveira@openbossa.org [Thu, 25 Aug 2011 19:02:01 +0000 (19:02 +0000)]
[Qt] Unreviewed, rebaseline for bug 53438.

 * platform/qt/fast/css/button-overflow-ellipsis-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Chromium rebaselines for r93794.
inferno@chromium.org [Thu, 25 Aug 2011 18:48:03 +0000 (18:48 +0000)]
Unreviewed. Chromium rebaselines for r93794.

* platform/chromium-cg-mac-leopard/fast/table/table-after-child-in-table-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-before-child-in-table-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-block-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-cell-after-child-in-table-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-block-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-cell-before-child-in-table-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-block-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-row-after-child-in-table-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-block-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/table-row-before-child-in-table-expected.png: Added.
* platform/chromium-linux/fast/table/table-after-child-in-table-expected.png: Added.
* platform/chromium-linux/fast/table/table-before-child-in-table-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-after-child-in-block-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-after-child-in-table-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-before-child-in-block-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-before-child-in-table-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.png: Added.
* platform/chromium-win-vista/fast/table: Removed.
* platform/chromium-win/fast/table/table-after-child-in-table-expected.png: Added.
* platform/chromium-win/fast/table/table-after-child-in-table-expected.txt: Added.
* platform/chromium-win/fast/table/table-before-child-in-table-expected.png: Added.
* platform/chromium-win/fast/table/table-before-child-in-table-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-after-child-in-block-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-before-child-in-block-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-after-child-in-block-expected.png: Added.
* platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-after-child-in-table-expected.png: Added.
* platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-before-child-in-block-expected.png: Added.
* platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-before-child-in-table-expected.png: Added.
* platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r90971): Fix an assertion failure with textarea placeholder.
inferno@chromium.org [Thu, 25 Aug 2011 18:09:18 +0000 (18:09 +0000)]
REGRESSION(r90971): Fix an assertion failure with textarea placeholder.
https://bugs.webkit.org/show_bug.cgi?id=66164

Source/WebCore:

Patch by Kent Tamura <tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

Minor patch nits addressed by inferno@chromium.org, on Hyatt's
review.

Test: fast/forms/textarea-placeholder-relayout-assertion.html

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
Pass 'false' to the 'markParents' argument of setChildNeedsLayout().
We don't need to propagate needsLayout for ancestors because
layoutSpecialExcludedChild() is called from layout() of the
parent.

LayoutTests:

Patch by Kent Tamura <tkent@chromium.org> on 2011-08-25
Reviewed by Dave Hyatt.

* fast/forms/textarea-placeholder-relayout-assertion-expected.txt: Added.
* fast/forms/textarea-placeholder-relayout-assertion.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic needs a way to report where and how tests are failing in the summary...
dglazkov@chromium.org [Thu, 25 Aug 2011 18:07:02 +0000 (18:07 +0000)]
garden-o-matic needs a way to report where and how tests are failing in the summary view.
https://bugs.webkit.org/show_bug.cgi?id=66955

Introduce FailureGrid, your one-stop failure-indicating destination.

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 25 Aug 2011 18:05:40 +0000 (18:05 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip new tests until check them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-25 Igor Oliveira <igor.oliveira@openbossa.org>
igor.oliveira@openbossa.org [Thu, 25 Aug 2011 18:04:17 +0000 (18:04 +0000)]
2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>

Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Fix text-overflow for button elements. Make the element inside
the button inherit the button controlClip.

Reviewed by David Hyatt.

Test: fast/css/button-overflow-ellipsis.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::controlClipRect):
* rendering/RenderBox.h:
(WebCore::RenderBox::hasControlClip):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::setupInnerStyle):

LayoutTests:

Text-overflow is broken for button elements
https://bugs.webkit.org/show_bug.cgi?id=53438

Add button text-overflow test.

Reviewed by David Hyatt.

* fast/css/button-overflow-ellipsis.html: Added.
* platform/qt/fast/css/button-overflow-ellipsis-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Fix build when GCC 4.2 is not installed.
ap@apple.com [Thu, 25 Aug 2011 17:56:50 +0000 (17:56 +0000)]
    Fix build when GCC 4.2 is not installed.

        * gtest/xcode/Config/CompilerVersion.xcconfig: Copied from Source/WebCore/Configurations/CompilerVersion.xcconfig.
        * gtest/xcode/Config/General.xcconfig:
        Use the same compiler version as other projects do.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Several test expectation updates.
pkasting@chromium.org [Thu, 25 Aug 2011 17:27:10 +0000 (17:27 +0000)]
[chromium] Several test expectation updates.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update VideoLayerChromium to not access GC3D on the main thread
enne@google.com [Thu, 25 Aug 2011 17:24:06 +0000 (17:24 +0000)]
[chromium] Update VideoLayerChromium to not access GC3D on the main thread
https://bugs.webkit.org/show_bug.cgi?id=66434

Reviewed by James Robinson.

Covered by existing tests.

This change allows the main thread VideoLayerChromium to not depend on
compositor thread resources (GC3D, LayerRendererChromium). The texture
allocation in VideoLayerChromium was changed to use ManagedTexture so
that textures can now be evicted when there is texture memory pressure
and so that destruction can be automatically deferred until a GC3D is
available.

* platform/graphics/chromium/LayerRendererChromium.cpp:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ManagedTexture.h:
(WebCore::ManagedTexture::size):
(WebCore::ManagedTexture::format):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::pushPropertiesTo):
(WebCore::VideoLayerChromium::setLayerTreeHost):
(WebCore::VideoLayerChromium::determineTextureFormat):
(WebCore::VideoLayerChromium::reserveTextures):
(WebCore::VideoLayerChromium::updateTexture):
(WebCore::VideoLayerChromium::releaseCurrentFrame):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::contentsTextureManager):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::setTexture):
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-25 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 25 Aug 2011 17:13:59 +0000 (17:13 +0000)]
2011-08-25  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix chromium devtools tests.

        * src/js/Tests.js:
        (.TestSuite.prototype.evaluateInConsole_):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect layout of :before and :after content, with display
inferno@chromium.org [Thu, 25 Aug 2011 16:58:38 +0000 (16:58 +0000)]
Incorrect layout of :before and :after content, with display
table, table-row and table-cell.
https://bugs.webkit.org/show_bug.cgi?id=66699

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-after-child-in-table.html
       fast/table/table-before-child-in-table.html
       fast/table/table-cell-after-child-in-block.html
       fast/table/table-cell-after-child-in-table.html
       fast/table/table-cell-before-child-in-block.html
       fast/table/table-cell-before-child-in-table.html
       fast/table/table-row-after-child-in-block.html
       fast/table/table-row-after-child-in-table.html
       fast/table/table-row-before-child-in-block.html
       fast/table/table-row-before-child-in-table.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
Fix the looping condition to detect :after child correctly.
isAnonymousBlock() does not apply to tables, instead
using isAnonymous().
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): Don't add the new child
in the generatedContainer with :before, :after content.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): Don't add the new child
in the generatedContainer with :before, :after content.

LayoutTests:

* fast/table/table-after-child-in-table.html: Added.
* fast/table/table-before-child-in-table.html: Added.
* fast/table/table-cell-after-child-in-block.html: Added.
* fast/table/table-cell-after-child-in-table.html: Added.
* fast/table/table-cell-before-child-in-block.html: Added.
* fast/table/table-cell-before-child-in-table.html: Added.
* fast/table/table-row-after-child-in-block.html: Added.
* fast/table/table-row-after-child-in-table.html: Added.
* fast/table/table-row-before-child-in-block.html: Added.
* fast/table/table-row-before-child-in-table.html: Added.
* platform/mac/fast/table/table-after-child-in-table-expected.png: Added.
* platform/mac/fast/table/table-after-child-in-table-expected.txt: Added.
* platform/mac/fast/table/table-before-child-in-table-expected.png: Added.
* platform/mac/fast/table/table-before-child-in-table-expected.txt: Added.
* platform/mac/fast/table/table-cell-after-child-in-block-expected.png: Added.
* platform/mac/fast/table/table-cell-after-child-in-block-expected.txt: Added.
* platform/mac/fast/table/table-cell-after-child-in-table-expected.png: Added.
* platform/mac/fast/table/table-cell-after-child-in-table-expected.txt: Added.
* platform/mac/fast/table/table-cell-before-child-in-block-expected.png: Added.
* platform/mac/fast/table/table-cell-before-child-in-block-expected.txt: Added.
* platform/mac/fast/table/table-cell-before-child-in-table-expected.png: Added.
* platform/mac/fast/table/table-cell-before-child-in-table-expected.txt: Added.
* platform/mac/fast/table/table-row-after-child-in-block-expected.png: Added.
* platform/mac/fast/table/table-row-after-child-in-block-expected.txt: Added.
* platform/mac/fast/table/table-row-after-child-in-table-expected.png: Added.
* platform/mac/fast/table/table-row-after-child-in-table-expected.txt: Added.
* platform/mac/fast/table/table-row-before-child-in-block-expected.png: Added.
* platform/mac/fast/table/table-row-before-child-in-block-expected.txt: Added.
* platform/mac/fast/table/table-row-before-child-in-table-expected.png: Added.
* platform/mac/fast/table/table-row-before-child-in-table-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSHTMLImageElement (and associated Node) is abandoned when image load is canceled...
weinig@apple.com [Thu, 25 Aug 2011 16:50:35 +0000 (16:50 +0000)]
JSHTMLImageElement (and associated Node) is abandoned when image load is canceled via beforeload
<rdar://problem/9925630>
https://bugs.webkit.org/show_bug.cgi?id=66906

Reviewed by Darin Adler.

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
Very similar fix to the one in r93717 except this patches the case where the image load was
canceled via beforeload.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Leaking SkBitmaps for background images
commit-queue@webkit.org [Thu, 25 Aug 2011 16:42:15 +0000 (16:42 +0000)]
[chromium] Leaking SkBitmaps for background images
https://bugs.webkit.org/show_bug.cgi?id=66488

Patch by John Bates <jbates@google.com> on 2011-08-25
Reviewed by Stephen White.

This patch simply changes NativeImageSkia to have a SkBitmap instead of
deriving from SkBitmap. All dependent code updated to access the member
instead of calling SkBitmap methods on NativeImageSkia objects. This
may or may not fix the memory leak, but it's definitely a bug that could
cause memory leaks.

Source/WebCore:

* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::createDragImageFromImage):
* platform/graphics/chromium/PlatformImage.cpp:
(WebCore::PlatformImage::updateFromImage):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::size):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::checkForSolidColor):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::decodedSize):
(WebCore::NativeImageSkia::resizedBitmap):
* platform/graphics/skia/NativeImageSkia.h:
(WebCore::NativeImageSkia::bitmap):
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::getAddr):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/chromium:

* src/PlatformBridge.cpp:
(WebCore::PlatformBridge::clipboardWriteImage):
* src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
* src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::operator=):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93792 268f45cc-cd09-0410-ab3c-d52691b4dbfc