dpranke@chromium.org [Tue, 23 Nov 2010 00:56:52 +0000 (00:56 +0000)]
2010-11-22 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Fix some spacing issues with log messages with
new-run-webkit-tests --verbose.
https://bugs.webkit.org/show_bug.cgi?id=49936
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 23 Nov 2010 00:56:08 +0000 (00:56 +0000)]
2010-11-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
update scm to work with different remote branches
https://bugs.webkit.org/show_bug.cgi?id=49949
This works if there are multiple svn tracking branches
and/or if the tracking branch is refs/remots/origin/master
instead of refs/remotes/trunk which is the direction we're trying
to head since that makes fetches faster.
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 23 Nov 2010 00:55:59 +0000 (00:55 +0000)]
2010-11-22 Patrick Gansterer <paroga@webkit.org>
Reviewed by Sam Weinig.
Add WTF::FixedArray::size()
https://bugs.webkit.org/show_bug.cgi?id=49891
Add a method to get the size of a FixedArray.
* wtf/FixedArray.h:
(WTF::FixedArray::size):
2010-11-22 Patrick Gansterer <paroga@webkit.org>
Reviewed by Sam Weinig.
Use WTF::FixedArray::size()
https://bugs.webkit.org/show_bug.cgi?id=49891
* dom/Document.cpp:
(WebCore::Document::~Document):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 23 Nov 2010 00:25:10 +0000 (00:25 +0000)]
2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813
Changed the return value of SelectionController::typingStyle() to EditingStyle*.
Also added SelectionController::copyTypingStyle() to copy the typing style
as an instance of CSSMutableStyleDeclaration.
No tests are added since this is no behavioral change.
* WebView/WebFrame.mm:
(-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813
Changed the return type of SelectionController::typingStyle to EditingStyle*.
Extracted textDirection from Editor::textDirectionForSelection to hide the underlying
CSSMutableStyleDeclaration.
Also extracted the code to preserve unicode-bidi and direction CSS properties in
InsertTextCommand::input, and moved into EditingStyle::prepareToApplyAt. ShouldPreserveWritingDirection,
which is added to the argument list of EditingStyle::prepareToApplyAt, decides whether or not
these two properties are preserved.
Also added SelectionController::copyTypingStyle() to copy the typing style as an instance of
CSSMutableStyleDeclaration.
No new tests are added since this is a refactoring.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirection): Extracted from Editor::textDirectionForSelection.
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added a missing null check.
(WebCore::EditingStyle::prepareToApplyAt): See above.
(WebCore::editingStyleIncludingTypingStyle): Calls SelectionController::typingStyle.
* editing/EditingStyle.h: Moved WritingDirection from Editor.h
* editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection): Calls EditingStyle::textDirection.
(WebCore::Editor::computeAndSetTypingStyle): Calls SelectionController::typingStyle.
(WebCore::Editor::selectionComputedStyle): Ditto.
(WebCore::Editor::styleForSelectionStart): Ditto.
* editing/Editor.h:
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply): Ditto.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input): Calls EditingStyle::prepareToApplyAt with PreserveWritingDirection.
* editing/SelectionController.h:
(WebCore::SelectionController::typingStyle): Returns EditingStyle* rather than CSSMutableStyleDeclaration*.
(WebCore::SelectionController::copyTypingStyle): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 23 Nov 2010 00:18:47 +0000 (00:18 +0000)]
2010-11-22 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WINCE] Set correct preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=49887
* wtf/Platform.h:
2010-11-22 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WINCE] Set correct preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=49887
* config.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 23:57:47 +0000 (23:57 +0000)]
Update Windows 7 results for two tests
Windows 7 uses different fonts from Windows XP on these tests (and even
has a font that can render the inverted nun in bidi-mirror-he-ar.html).
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/win/fast/text/international/bold-bengali-expected.checksum: Added.
* platform/win/fast/text/international/bold-bengali-expected.png: Added.
* platform/win/fast/text/international/bold-bengali-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 23:38:58 +0000 (23:38 +0000)]
Update Windows 7 results for fast/text/international/complex-character-based-fallback.html
* platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
* platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
* platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 23:27:06 +0000 (23:27 +0000)]
Update Windows XP results for fast/text/international/complex-character-based-fallback.html after r72173
The existing pixel results were XP-specific so I moved them into
LayoutTests/platform/win-xp.
* platform/win-xp/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
* platform/win-xp/fast/text/international/complex-character-based-fallback-expected.png: Added.
* platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
* platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
* platform/win/fast/text/international/complex-character-based-fallback-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 23:21:09 +0000 (23:21 +0000)]
Update Windows results after r72552
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Mon, 22 Nov 2010 23:04:10 +0000 (23:04 +0000)]
2010-11-22 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] font-size:0 text runs should have zero width
https://bugs.webkit.org/show_bug.cgi?id=49871
Expands test to check width in addition to height.
* fast/text/font-size-zero-expected.txt:
* fast/text/font-size-zero.html:
* fast/text/script-tests/font-size-zero.js:
2010-11-22 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] font-size:0 text runs should have zero width
https://bugs.webkit.org/show_bug.cgi?id=49871
Returns 0 from platformWidthForGlyph if the specified font size is 0.
Test: fast/text/font-size-zero.html
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Nov 2010 23:01:28 +0000 (23:01 +0000)]
2010-11-22 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809
Test that we update content state when leaving a form in a subframe.
* fast/history/saves-state-after-frame-nav.html:
* fast/history/saves-state-after-frame-nav-expected.txt:
* fast/history/resources/subframe-with-form.html:
2010-11-22 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809
Ensures that history's previousItem is non-null when clients try to
update content state (e.g., Chromium's UpdateSessionHistory). We now
track load completions with a boolean field rather than by clearing
previousItem.
Test: fast/history/saves-state-after-frame-nav.html
* loader/HistoryController.cpp:
* loader/HistoryController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Mon, 22 Nov 2010 22:59:10 +0000 (22:59 +0000)]
Unreviewed. Add flaky crash expectation for fast/files/revoke-blob-url.html on mac debug.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 22 Nov 2010 22:52:30 +0000 (22:52 +0000)]
2010-11-22 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
Ignore reference files which will be used by reftests when collecting
test cases.
https://bugs.webkit.org/show_bug.cgi?id=49835
* Scripts/webkitpy/layout_tests/port/test_files.py:
* Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 22:45:22 +0000 (22:45 +0000)]
Update Windows results for transforms/2d/hindi-rotated.html after r72173
The existing pixel results were XP-specific so I moved them to
LayoutTests/platform/win-xp.
* platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Added.
* platform/win-xp/transforms/2d/hindi-rotated-expected.png: Added.
* platform/win-xp/transforms/2d/hindi-rotated-expected.txt:
* platform/win/transforms/2d/hindi-rotated-expected.checksum:
* platform/win/transforms/2d/hindi-rotated-expected.png:
* platform/win/transforms/2d/hindi-rotated-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 22 Nov 2010 22:40:48 +0000 (22:40 +0000)]
2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed rebaseline for Chromium.
Removed the erroneous expected result for editing/deleting/
5168598.html on chromium linux.
* platform/chromium-linux/editing/deleting/
5168598-expected.txt: Removed.
* platform/chromium/test_expectations.txt: Removed editing/deleting/
5168598.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 22 Nov 2010 22:24:37 +0000 (22:24 +0000)]
Unreviewed. Update GTK and Mac specific expected results after r72552.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 22 Nov 2010 22:15:08 +0000 (22:15 +0000)]
2010-11-22 Tony Chang <tony@chromium.org>
Unreviewed, roll Chromium DEPS to r67004.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 22 Nov 2010 22:05:13 +0000 (22:05 +0000)]
Update WebKit2 skipped list.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Mon, 22 Nov 2010 22:01:01 +0000 (22:01 +0000)]
2010-11-22 Luiz Agostini <luiz.agostini@openbossa.org>
Unreviewed, Windows build fix.
Adding JSMediaQueryList to DerivedSources.cpp.
* DerivedSources.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 22 Nov 2010 21:53:51 +0000 (21:53 +0000)]
Unreviewed. Update Qt specific expected results after r72552.
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 21:21:16 +0000 (21:21 +0000)]
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Apple's Windows build allows placing header files and import libraries for WebKit's
dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
$WebKitLibrariesDir environment variable. This is both required for production builds and
convenient for Apple-internal developer builds. Apple's production builds also require that
WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
builds, the files are copied into that directory tree by the
WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
copying is done by
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
This .vsprops copying is problematic in one very important case: when a developer updates
their source tree and then tries to build. Visual Studio only reads .vsprops files when a
project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
$WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
will proceed with out-of-date .vsprops files, which will likely result in a build failure.
To fix this, we now use normal relative paths to access the .vsprops files in the source
tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
unset, so the normal relative paths are used to read the .vsprops files out of the source
tree directly. In production builds, this environment variable is set to a fake directory
that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
is resolved.
For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
$(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
"$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
FeatureDefines.vsprops becomes:
$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
which resolves to:
$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
(We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
actually exist since they are matched by an equal number of ".." path components.)
Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
updated
Reviewed by Dave Hyatt.
JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore.make: Set $WebKitVSPropsRedirectionDir so that
production builds can find the .vsprops files.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stopy copying the
.vsprops files. It isn't needed anymore.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.
WebCore:
* WebCore.vcproj/WebCore.make: Set $WebKitVSPropsRedirectionDir so that
production builds can find the .vsprops files.
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCore.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.
WebKit/win:
* WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
find the .vsprops files.
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.
WebKit2:
* win/WebKit2.make: Set $WebKitVSPropsRedirectionDir so that production builds can
find the .vsprops files.
* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.
WebKitLibraries:
* win/tools/WinTools.make: Copy the shared .vsprops files into a directory tree beneath
AppleInternal\tools\vsprops that matches the source directory tree. This allows production
builds to redirect the relative paths used to find the shared .vsprops files into
AppleInternal by setting $WebKitVSPropsRedirectionDir to the appropriate value.
WebKitTools:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* FindSafari/FindSafari.vcproj:
* MiniBrowser/MiniBrowser.vcproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
* WebKitAPITest/WebKitAPITest.vcproj:
* WebKitLauncherWin/WebKitLauncherWin.vcproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
* WinLauncher/WinLauncher.vcproj:
* record-memory-win/record-memory-win.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 21:17:23 +0000 (21:17 +0000)]
Make it possible to run tests on Windows without Visual Studio or VC++ Express installed
webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
are not installed. But this function doesn't need to be called when we
already have a build available and are just trying to run the tests.
Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
because Visual Studio/VC++ Express aren't installed
Reviewed by Dave Hyatt.
* Scripts/webkitdirs.pm:
(determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
it is not needed by this function. Also added a FIXME.
(usingVisualStudioExpress): Call setupCygwinEnv directly rather than
relying on determineConfigurationForVisualStudio doing it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 22 Nov 2010 21:16:44 +0000 (21:16 +0000)]
2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed update of Windows's skipped list and Chromium's test expectation.
fast/text/international/thai-cursor-position.html erroneously had an expected result
on Windows even though textInputController hasn't been implemented on Windows (the bug 32021).
Removed the expected result and added the tests to Windows platform's skipped list.
* platform/chromium/test_expectations.txt: Removed fast/text/international/thai-cursor-position.html.
* platform/win/Skipped: Added fast/text/international/thai-cursor-position.html.
* platform/win/fast/text/international/thai-cursor-position-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Mon, 22 Nov 2010 21:02:27 +0000 (21:02 +0000)]
2010-10-21 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Adler.
Implement CSSOM View matchMedia interface
https://bugs.webkit.org/show_bug.cgi?id=37205
New property matchMedia was added to window.
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
window.matchMedia and MediaQueryList tests.
* fast/media/media-query-list-01-expected.txt: Added.
* fast/media/media-query-list-01.html: Added.
The following tests depend on LayoutTestController::setViewModeMediaFeature() to work.
As it is only implemented by Qt and Gtk the tests needed to be skipped in all other platforms.
* fast/media/media-query-list-02-expected.txt: Added.
* fast/media/media-query-list-02.html: Added.
* fast/media/media-query-list-03-expected.txt: Added.
* fast/media/media-query-list-03.html: Added.
* fast/media/media-query-list-04-expected.txt: Added.
* fast/media/media-query-list-04.html: Added.
* fast/media/media-query-list-05-expected.txt: Added.
* fast/media/media-query-list-05.html: Added.
* fast/media/media-query-list-06-expected.txt: Added.
* fast/media/media-query-list-06.html: Added.
* fast/media/media-query-list-07-expected.txt: Added.
* fast/media/media-query-list-07.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped:
* platform/win/Skipped:
2010-10-21 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Adler.
Implement CSSOM View matchMedia interface
https://bugs.webkit.org/show_bug.cgi?id=37205
New interfaces may be used to evaluate media queries and to associate listeners
to media queries. Those listeners are called whenever the associated query changes.
Specification may be found at http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface
operator== added to JS version of ScriptValue.
Method isFunction added to JS and V8 versions of ScriptValue.
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::isFunction):
* bindings/js/ScriptValue.h:
(WebCore::ScriptValue::operator==):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::isFunction):
Some changes were needed to the code generators to handle type MediaQueryListListener.
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
Some changes to the bindings test results that were previously added.
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::TestMediaQueryListListenerInternal::methodCallback):
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
New interfaces:
* css/MediaQueryList.cpp: Added.
* css/MediaQueryList.h: Added.
* css/MediaQueryList.idl: Added.
* css/MediaQueryListListener.cpp: Added.
* css/MediaQueryListListener.h: Added.
* css/MediaQueryListListener.idl: Added.
To avoid adding code to classes DOMWindow and Document a new class MediaQueryMatcher was created.
* css/MediaQueryMatcher.cpp: Added.
* css/MediaQueryMatcher.h: Added.
Document and DOMWindow have changed to support new features. DOMWindow is the class that
publishes methods matchMedia but for page cache to work properly the reference to the
MediaQueryMatcher must be in Document.
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::mediaQueryMatcher):
(WebCore::Document::styleSelectorChanged):
* dom/Document.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::matchMedia):
* page/DOMWindow.h:
* page/DOMWindow.idl:
Build systems
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
Tests: fast/media/media-query-list-01.html
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 22 Nov 2010 21:00:41 +0000 (21:00 +0000)]
2010-11-19 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
Simplify Driver.run_test() so that it takes only one parameter, TestInput.
https://bugs.webkit.org/show_bug.cgi?id=49812
* Scripts/webkitpy/layout_tests/driver_test.py:
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 22 Nov 2010 20:13:21 +0000 (20:13 +0000)]
2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed update of Windows Skipped list.
editing/selection/
5825350-1.html and
5825350-2.html erroneously
had expectations with console error message even though textInputController
hasn't been implemented on Windows (the bug 32021),
Removed these expectations and added the tests to the skipped list.
* platform/win/Skipped:
* platform/win/editing/selection/
5825350-1-expected.txt: Removed.
* platform/win/editing/selection/
5825350-2-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 20:08:06 +0000 (20:08 +0000)]
Add Windows-specific results for fast/ruby/nested-ruby.html
* platform/win/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/win/fast/ruby/nested-ruby-expected.png: Added.
* platform/win/fast/ruby/nested-ruby-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 20:07:17 +0000 (20:07 +0000)]
Update Windows XP results for fast/text/international/bidi-control-chars-treated-as-ZWS.html
The render tree dump on XP now matches Mac. I updated the pixel results
to match the current rendering (the two test lines have moved down
slightly).
* platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
* platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
* platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 22 Nov 2010 19:58:29 +0000 (19:58 +0000)]
2010-11-22 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
[NRWT] Retry a few times in reading a png image to avoid a race condition.
https://bugs.webkit.org/show_bug.cgi?id=49924
* Scripts/webkitpy/layout_tests/port/chromium.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 19:09:00 +0000 (19:09 +0000)]
Remove obsolete Windows-specific results for svg/dom/path-parser.html
r72381 made these unnecessary.
* platform/win/svg/dom/path-parser-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 19:08:22 +0000 (19:08 +0000)]
Update Windows results for fast/dom/prototype-inheritance-2.html
This is the Windows equivalent of r72353.
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 22 Nov 2010 18:55:37 +0000 (18:55 +0000)]
2010-11-22 Andreas Kling <kling@webkit.org>
Unreviewed, rebaseline GTK+ after r72527.
* platform/gtk/css1/box_properties/margin_right-expected.txt:
* platform/gtk/css1/box_properties/padding_right-expected.txt:
* platform/gtk/fast/lists/001-vertical-expected.txt:
* platform/gtk/fast/lists/002-vertical-expected.txt:
* platform/gtk/fast/lists/003-vertical-expected.txt:
* platform/gtk/fast/lists/007-vertical-expected.txt:
* platform/gtk/fast/lists/008-vertical-expected.txt:
* platform/gtk/fast/lists/outSideListMarkers-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 22 Nov 2010 18:50:40 +0000 (18:50 +0000)]
Add Windows-specific results for editing/selection/extend-selection-home-end.html
These results are identical to the cross-platform results, but are
needed to override the Mac-specific results in platform/mac.
Fixes <http://webkit.org/b/49874>.
* platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 18:44:11 +0000 (18:44 +0000)]
Not reviewed. Test expectations arrangements and rebaselinings.
* platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
* platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 18:30:33 +0000 (18:30 +0000)]
Not reviewed. Fallback font rebaselines.
* platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
* platform/chromium-linux/fast/text/international/hebrew-vowels-expected.checksum: Added.
* platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum:
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
* platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Added.
* platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Added.
* platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
* platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Added.
* platform/chromium-mac/fast/text/international/001-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/001-expected.png: Added.
* platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
* platform/chromium-win/fast/text/international/hebrew-vowels-expected.checksum: Added.
* platform/chromium-win/fast/text/international/hebrew-vowels-expected.png: Added.
* platform/chromium-win/fast/text/international/hebrew-vowels-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 22 Nov 2010 18:26:59 +0000 (18:26 +0000)]
2010-11-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Contents of rules inside @media not displayed/editable
https://bugs.webkit.org/show_bug.cgi?id=49804
WebCore:
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::setStyleSheetText2):
* inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::setText):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::ruleForId):
(WebCore::InspectorStyleSheet::ruleIndexByStyle):
(WebCore::InspectorStyleSheet::ensureText):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheet::ensureFlatRules):
(WebCore::InspectorStyleSheet::revalidateStyle):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges):
(WebCore::InspectorStyleSheet::collectFlatRules):
* inspector/InspectorStyleSheet.h:
LayoutTests:
* inspector/resources/styles-new-API-1.css: Added.
(@page):
(@page :first):
(#absent-id):
(body):
* inspector/resources/styles-new-API.css:
* inspector/styles-new-API-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 17:53:46 +0000 (17:53 +0000)]
Not reviewed. Amending expectations for Chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 17:50:12 +0000 (17:50 +0000)]
Not reviewed. Another portion of Chromium rebaselines for SVG.
* platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
* platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 17:39:37 +0000 (17:39 +0000)]
Not reviewed. Another portion of Chromium rebaselines.
* platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
* platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
* platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
* platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
* platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
* platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
* platform/chromium-win/svg/carto.net/selectionlist-expected.png:
* platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
* platform/chromium-win/svg/custom/image-small-width-height-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 22 Nov 2010 17:36:53 +0000 (17:36 +0000)]
2010-11-22 Tony Chang <tony@chromium.org>
Unreviewed, update Chromium Win plugin test expectations.
* platform/chromium/drt_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 17:33:43 +0000 (17:33 +0000)]
Not reviewed. Chromium rebaselines after trac.webkit.org/changeset/72518
* platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.checksum:
* platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPointList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGStringList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
* platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGLengthList-basics-expected.checksum:
* platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-win/svg/dom/SVGNumberList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPointList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGStringList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 17:23:59 +0000 (17:23 +0000)]
Not reviewed. Reorganizing suppressions.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 17:16:18 +0000 (17:16 +0000)]
Unreviewed. Tons of Chromium rebaselines after trac.webkit.org/changeset/72527
* platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-linux/css1/box_properties/margin_right-expected.png:
* platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-linux/css1/box_properties/padding_right-expected.png:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
* platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
* platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
* platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
* platform/chromium-linux/fast/doctypes/002-expected.checksum:
* platform/chromium-linux/fast/doctypes/002-expected.png:
* platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/001-vertical-expected.png:
* platform/chromium-linux/fast/lists/001-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/002-expected.checksum:
* platform/chromium-linux/fast/lists/002-expected.png:
* platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/002-vertical-expected.png:
* platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/003-expected.checksum:
* platform/chromium-linux/fast/lists/003-expected.png:
* platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/003-vertical-expected.png:
* platform/chromium-linux/fast/lists/003-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/007-vertical-expected.png:
* platform/chromium-linux/fast/lists/007-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/008-vertical-expected.png:
* platform/chromium-linux/fast/lists/008-vertical-expected.txt: Removed.
* platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
* platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
* platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Added.
* platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-mac/css1/box_properties/margin_right-expected.png:
* platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-mac/css1/box_properties/padding_right-expected.png:
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
* platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
* platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed.
* platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Removed.
* platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
* platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
* platform/chromium-mac/fast/lists/008-vertical-expected.png:
* platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Added.
* platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Added.
* platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-win/css1/box_properties/margin_right-expected.png:
* platform/chromium-win/css1/box_properties/margin_right-expected.txt:
* platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-win/css1/box_properties/padding_right-expected.png:
* platform/chromium-win/css1/box_properties/padding_right-expected.txt:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/chromium-win/fast/doctypes/002-expected.checksum:
* platform/chromium-win/fast/doctypes/002-expected.png:
* platform/chromium-win/fast/doctypes/002-expected.txt:
* platform/chromium-win/fast/lists/001-vertical-expected.checksum:
* platform/chromium-win/fast/lists/001-vertical-expected.png:
* platform/chromium-win/fast/lists/001-vertical-expected.txt:
* platform/chromium-win/fast/lists/002-expected.checksum:
* platform/chromium-win/fast/lists/002-expected.png:
* platform/chromium-win/fast/lists/002-expected.txt:
* platform/chromium-win/fast/lists/002-vertical-expected.checksum:
* platform/chromium-win/fast/lists/002-vertical-expected.png:
* platform/chromium-win/fast/lists/002-vertical-expected.txt:
* platform/chromium-win/fast/lists/003-expected.checksum:
* platform/chromium-win/fast/lists/003-expected.png:
* platform/chromium-win/fast/lists/003-expected.txt:
* platform/chromium-win/fast/lists/003-vertical-expected.checksum:
* platform/chromium-win/fast/lists/003-vertical-expected.png:
* platform/chromium-win/fast/lists/003-vertical-expected.txt:
* platform/chromium-win/fast/lists/007-vertical-expected.checksum:
* platform/chromium-win/fast/lists/007-vertical-expected.png:
* platform/chromium-win/fast/lists/007-vertical-expected.txt:
* platform/chromium-win/fast/lists/008-vertical-expected.checksum:
* platform/chromium-win/fast/lists/008-vertical-expected.png:
* platform/chromium-win/fast/lists/008-vertical-expected.txt:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
* platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Added.
* platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 22 Nov 2010 16:57:45 +0000 (16:57 +0000)]
Make WebKit2 compile with ENABLE_JAVASCRIPT_DEBUGGER=0
Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.
* WebProcess/WebPage/WebInspector.cpp: Add missing ENABLE(JAVASCRIPT_DEBUGGER) guards.
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 22 Nov 2010 16:46:45 +0000 (16:46 +0000)]
2010-11-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: dump inspector protocol messages into console.
Sometimes I need to dump inspector messages into console.
It'd be much simple to have this code in repository and
enable protocol dumping just by a flag.
https://bugs.webkit.org/show_bug.cgi?id=49905
* inspector/CodeGeneratorInspector.pm:
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.reset):
* inspector/front-end/inspector.js:
(WebInspector_syncDispatch):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 22 Nov 2010 16:43:08 +0000 (16:43 +0000)]
Unreviewed. Update Qt specific expected results after r72527.
* platform/qt/css1/box_properties/margin_right-expected.checksum: Added.
* platform/qt/css1/box_properties/margin_right-expected.png: Added.
* platform/qt/css1/box_properties/margin_right-expected.txt:
* platform/qt/css1/box_properties/padding_right-expected.checksum: Added.
* platform/qt/css1/box_properties/padding_right-expected.png: Added.
* platform/qt/css1/box_properties/padding_right-expected.txt:
* platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Added.
* platform/qt/editing/pasteboard/merge-end-list-expected.png: Added.
* platform/qt/editing/pasteboard/merge-end-list-expected.txt:
* platform/qt/fast/doctypes/002-expected.checksum: Added.
* platform/qt/fast/doctypes/002-expected.png: Added.
* platform/qt/fast/doctypes/002-expected.txt:
* platform/qt/fast/lists/001-vertical-expected.checksum:
* platform/qt/fast/lists/001-vertical-expected.png:
* platform/qt/fast/lists/001-vertical-expected.txt:
* platform/qt/fast/lists/002-vertical-expected.checksum:
* platform/qt/fast/lists/002-vertical-expected.png:
* platform/qt/fast/lists/002-vertical-expected.txt:
* platform/qt/fast/lists/003-vertical-expected.checksum:
* platform/qt/fast/lists/003-vertical-expected.png:
* platform/qt/fast/lists/003-vertical-expected.txt:
* platform/qt/fast/lists/007-vertical-expected.checksum:
* platform/qt/fast/lists/007-vertical-expected.png:
* platform/qt/fast/lists/007-vertical-expected.txt:
* platform/qt/fast/lists/008-vertical-expected.checksum:
* platform/qt/fast/lists/008-vertical-expected.png:
* platform/qt/fast/lists/008-vertical-expected.txt:
* platform/qt/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/qt/fast/lists/outSideListMarkers-expected.png: Added.
* platform/qt/fast/lists/outSideListMarkers-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 22 Nov 2010 16:18:52 +0000 (16:18 +0000)]
2010-11-22 Andreas Kling <kling@webkit.org>
Unreviewed, 2 missing rebaselines after r72527.
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/mac/fast/lists/marker-before-empty-inline-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 22 Nov 2010 15:52:38 +0000 (15:52 +0000)]
2010-11-22 Andreas Kling <kling@webkit.org>
Reviewed by Nikolas Zimmermann.
GraphicsContext: Make drawFocusRing() take a Path instead of a Vector<Path>
https://bugs.webkit.org/show_bug.cgi?id=49840
This avoid copying a Path object when drawing focus rings.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* rendering/RenderImage.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paint):
(WebCore::RenderImage::paintFocusRing):
Renamed from paintFocusRings since it only paints one ring.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Mon, 22 Nov 2010 15:13:52 +0000 (15:13 +0000)]
Outside list bullets ignore text-align style.
https://bugs.webkit.org/show-bug.cgi?id=15713
Patch by Renata Hodovan <reni@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.
WebCore:
Fix the position of outside markers by setting its logicalLeft member. Embedded markers need special treatment.
First, the total width of markers should be calculated. Subtracting it from logicalLeft we get the outermost bullet's
position. As for the others, this sum should be decremented with the previous marker's width.
In case of vertical markers the padding is unneeded.
Test: fast/lists/outSideListMarkers.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
LayoutTests:
Add new test for checking outside marker's position and update the related expecteds of tests.
* fast/lists/outSideListMarkers-expected.txt: Added.
* fast/lists/outSideListMarkers.html: Added.
* platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/margin_right-expected.png:
* platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/padding_right-expected.png:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/doctypes/002-expected.checksum:
* platform/mac-leopard/fast/doctypes/002-expected.png:
* platform/mac-leopard/fast/lists/001-expected.checksum:
* platform/mac-leopard/fast/lists/001-expected.png:
* platform/mac-leopard/fast/lists/002-expected.checksum:
* platform/mac-leopard/fast/lists/002-expected.png:
* platform/mac-leopard/fast/lists/003-expected.checksum:
* platform/mac-leopard/fast/lists/003-expected.png:
* platform/mac/css1/box_properties/margin_right-expected.txt:
* platform/mac/css1/box_properties/padding_right-expected.txt:
* platform/mac/editing/pasteboard/merge-end-list-expected.txt:
* platform/mac/editing/selection/extend-by-word-002-expected.checksum:
* platform/mac/editing/selection/extend-by-word-002-expected.png:
* platform/mac/editing/selection/extend-by-word-002-expected.txt:
* platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/mac/fast/css/empty-pseudo-class-expected.txt:
* platform/mac/fast/css/first-child-pseudo-class-expected.txt:
* platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/last-child-pseudo-class-expected.txt:
* platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/only-child-pseudo-class-expected.txt:
* platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/mac/fast/doctypes/002-expected.txt:
* platform/mac/fast/lists/001-expected.txt:
* platform/mac/fast/lists/001-vertical-expected.checksum:
* platform/mac/fast/lists/001-vertical-expected.png:
* platform/mac/fast/lists/001-vertical-expected.txt:
* platform/mac/fast/lists/002-expected.txt:
* platform/mac/fast/lists/002-vertical-expected.checksum:
* platform/mac/fast/lists/002-vertical-expected.png:
* platform/mac/fast/lists/002-vertical-expected.txt:
* platform/mac/fast/lists/003-expected.txt:
* platform/mac/fast/lists/003-vertical-expected.checksum:
* platform/mac/fast/lists/003-vertical-expected.png:
* platform/mac/fast/lists/003-vertical-expected.txt:
* platform/mac/fast/lists/007-vertical-expected.checksum:
* platform/mac/fast/lists/007-vertical-expected.png:
* platform/mac/fast/lists/007-vertical-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.checksum:
* platform/mac/fast/lists/008-vertical-expected.png:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/lists/outSideListMarkers-expected.checksum: Added.
* platform/mac/fast/lists/outSideListMarkers-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Mon, 22 Nov 2010 14:57:15 +0000 (14:57 +0000)]
2010-11-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antonio Gomes.
Spatial Navigation: Additional tests.
https://bugs.webkit.org/show_bug.cgi?id=49604
* fast/events/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt: Added.
* fast/events/spatial-navigation/snav-div-overflow-scrol-hidden.html: Added.
* fast/events/spatial-navigation/snav-z-index-expected.txt: Added.
* fast/events/spatial-navigation/snav-z-index.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 14:40:45 +0000 (14:40 +0000)]
Not reviewed. Rebaselining various Win/Linux only deviations.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/chromium-linux/svg/custom/baseval-animval-equality-expected.checksum:
* platform/chromium-linux/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
* platform/chromium-linux/svg/dom/path-parser-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.checksum:
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
* platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
* platform/chromium-win/svg/dom/path-parser-expected.txt: Added.
* platform/chromium-win/svg/filters/filter-rounding-issues-expected.checksum: Added.
* platform/chromium-win/svg/filters/filter-rounding-issues-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 22 Nov 2010 14:37:28 +0000 (14:37 +0000)]
Unreviewed.
[Qt] fast/workers/storage/interrupt-database-sync.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=49906
* platform/qt/Skipped: fast/workers/storage/interrupt-database-sync.html added until fix.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 22 Nov 2010 14:12:52 +0000 (14:12 +0000)]
Unreviewed.
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.
* platform/qt/fast/css/negative-leading-expected.checksum: Added.
* platform/qt/fast/css/negative-leading-expected.png: Added.
* platform/qt/fast/css/negative-leading-expected.txt: Added. (introduced in r72141)
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
* platform/qt/fast/images/imagemap-focus-ring-zoom-expected.txt: Added. (introduced in r72402)
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added. (introduced in r72381)
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added. (introduced in r72518)
* platform/qt/svg/custom/image-rescale-expected.checksum: Added.
* platform/qt/svg/custom/image-rescale-expected.png: Added.
* platform/qt/svg/custom/image-rescale-expected.txt: Added. (introduced in r72470)
* platform/qt/svg/custom/image-rescale-scroll-expected.checksum: Added.
* platform/qt/svg/custom/image-rescale-scroll-expected.png: Added.
* platform/qt/svg/custom/image-rescale-scroll-expected.txt: Added. (introduced in r72470)
* platform/qt/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
* platform/qt/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/qt/svg/dom/SVGPathSegList-cloning-expected.txt: Added. (introduced in r72381)
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added. (introduced in r72381)
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
* platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added. (introduced in r72381)
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Mon, 22 Nov 2010 13:49:09 +0000 (13:49 +0000)]
Spatial Navigation: issues with the node selection algorithm.
https://bugs.webkit.org/show_bug.cgi?id=49382
Patch by Yael Aharon <yael.aharon@nokia.com>, Chang Shu <chang.shu@nokia.com> on 2010-11-22
Reviewed by Antonio Gomes.
WebCore:
Modify the Spatial Navigation algorithm, to better handle initial focus and
navigation between frames.
The new algorithm takes the rect of the focused node as the startingRect,
instead of the node itself. That allows us to construct a virtual rect if
there is no focused node, or if it is off the screen.
The virtual rect is the edge of the container in the direction of the navigation.
With this patch, scrollable containers and frames will scroll regardless of weather
they have focusable content. Users will be able to use arrow keys to view all the
content of such a container. The only exception is if the container has style overflow:hidden.
We will not scroll in that case.
With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
we do a hit test and only the node on top can get focus.
hasOffScreenRect() was modified so that it can check if a node will be off-screen even after we scrolled
its parent container. We do not add the scrolling conditions for containers that have overflow:hidden
and cannot scroll.
calculateScrollbarModesForLayout is used to decide if a frame can scroll or not. We cannot rely on
the exsistance of the scrollbar, because it could be removed via the API, while the frame is still
allowed to scroll.
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
* page/FocusController.h:
* page/FrameView.h:
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::distanceDataForNode):
(WebCore::alignmentForRects):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isScrollableContainerNode):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):
* page/SpatialNavigation.h:
LayoutTests:
Replaced text in tests with images with fixed size to make them more cross platform and modified
test results to reflect that we can scroll container that do not include focusable content.
* fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
* fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
* fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
* fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
* fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
* fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
* fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
* fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
* fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
* fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 13:29:14 +0000 (13:29 +0000)]
Amending suppressions from previous commit.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 13:25:59 +0000 (13:25 +0000)]
Not reviewed. Adding new suppressions after trac.webkit.org/changeset/72518
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 12:53:55 +0000 (12:53 +0000)]
Not reviewed. Next batch of SVG rebaselines.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
* platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
* platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
* platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Nov 2010 12:32:31 +0000 (12:32 +0000)]
2010-11-22 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Fix various problems with the SVG*List code
https://bugs.webkit.org/show_bug.cgi?id=49880
Add tests for all SVG*List types, that were missing.
Add SVG 1.1 2nd edition testcase, types-dom-07-f.svg, testing that all animVal values are readonly.
* platform/mac-leopard/svg/custom/baseval-animval-equality-expected.checksum:
* platform/mac-leopard/svg/custom/baseval-animval-equality-expected.png:
* platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.checksum:
* platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
* platform/mac/svg/custom/baseval-animval-equality-expected.txt:
* platform/mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
* platform/mac/svg/dom/SVGNumberList-basics-expected.png: Added.
* platform/mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
* platform/mac/svg/dom/SVGPointList-basics-expected.png: Added.
* platform/mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
* platform/mac/svg/dom/SVGStringList-basics-expected.png: Added.
* platform/mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
* platform/mac/svg/dom/SVGTransformList-basics-expected.png: Added.
* svg/W3C-SVG-1.1-SE/types-dom-07-f.svg: Added.
* svg/custom/baseval-animval-equality.svg: Fix wrong test.
* svg/custom/polyline-points-crash-expected.txt:
* svg/dom/SVGLengthList-basics-expected.txt:
* svg/dom/SVGLengthList-basics.xhtml: Extended test, synchronized with the other SVG*List tests.
* svg/dom/SVGNumberList-basics-expected.txt: Added.
* svg/dom/SVGNumberList-basics.xhtml: Added.
* svg/dom/SVGPointList-basics-expected.txt: Added.
* svg/dom/SVGPointList-basics.xhtml: Added.
* svg/dom/SVGStringList-basics-expected.txt: Added.
* svg/dom/SVGStringList-basics.xhtml: Added.
* svg/dom/SVGTransformList-basics-expected.txt: Added.
* svg/dom/SVGTransformList-basics.xhtml: Added.
* svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
2010-11-22 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Fix various problems with the SVG*List code
https://bugs.webkit.org/show_bug.cgi?id=49880
Write tests for SVGNumberList/SVGPointList/SVGStringList/SVGTransformList and extend SVGLengthList tests.
SVG DOM <-> XML DOM synchronization is now tested for all these types, and works great. Unify the string format produced
by the various valueAsString() functions for maximum compatibility with Firefox / Opera.
* Build a real transform string for SVGTransformList, instead of dumping the elements of the concatted matrix.
* Add SVGStringList XML dom synchronization, only affects SVGTests requiredFeatures/requiredExtensions/systemLanguage.
* Make all animVal properties readonly, tested by types-dom-07-f.svg (from SVG 1.1 2nd edition).
* Enable StrictTypeChecking/RequiresAllArguments=Raise for all SVGList types.
Tests: svg/W3C-SVG-1.1-SE/types-dom-07-f.svg
svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGStringList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml
* bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::setValue): Throw NO_MODIFICATION_ALLOWED_ERR when the SVGPropertyTearOffs role is AnimValRole.
(WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.
* bindings/scripts/CodeGeneratorJS.pm: Ditto.
* bindings/scripts/CodeGeneratorObjC.pm: Ditto.
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorSetter): Ditto.
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): Ditto.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::synchronizeProperty): Ditto.
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::synchronizeProperty): Ditto.
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::synchronizeProperty): Ditto.
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::synchronizeProperty): Ditto.
* svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::synchronizeProperty): Ditto.
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::synchronizeProperty): Ditto.
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::synchronizeProperty): Ditto.
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::synchronizeProperty): Ditto.
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::synchronizeProperty): Ditto.
* svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::valueAsString): Use ' ' instead of ',' as seperator.
* svg/SVGLengthList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::synchronizeProperty): Ditto.
* svg/SVGNumberList.cpp:
(WebCore::SVGNumberList::valueAsString): Use ' ' instead of ',' as seperator.
* svg/SVGNumberList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::synchronizeProperty): Ditto.
* svg/SVGPointList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::synchronizeProperty): Ditto.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::synchronizeProperty): Ditto.
* svg/SVGStringList.cpp:
(WebCore::SVGStringList::valueAsString): Add valueAsString() implementation, necessary for SVG DOM <-> XML DOM synchronization.
* svg/SVGStringList.h:
* svg/SVGStringList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
* svg/SVGTests.cpp: Rewrite, similar to SVGPolyElement, to synchronize the requiredFeatures/requiredExtension/systemLanguage SVGStringLists with their XML DOM attributes.
(WebCore::SVGTests::SVGTests):
(WebCore::SVGTests::isValid):
(WebCore::SVGTests::parseMappedAttribute):
(WebCore::SVGTests::isKnownAttribute):
(WebCore::SVGTests::handleAttributeChange):
(WebCore::SVGTests::synchronizeProperties): To be called by all classes inheriting from SVGTests, in their synchronizeProperty() methods.
(WebCore::SVGTests::synchronizeRequiredFeatures):
(WebCore::SVGTests::synchronizeRequiredExtensions):
(WebCore::SVGTests::synchronizeSystemLanguage):
(WebCore::SVGTests::requiredFeatures):
(WebCore::SVGTests::requiredExtensions):
(WebCore::SVGTests::systemLanguage):
* svg/SVGTests.h:
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
* svg/SVGTransform.cpp:
(WebCore::SVGTransform::valueAsString): Added a proper way to serialize a SVGTransform into a String.
* svg/SVGTransform.h:
* svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::valueAsString): Rewrite, to build a real transform list string, instead of dumping the concatted matrix.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
* svg/properties/SVGListProperty.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox.
(WebCore::SVGListProperty::initializeValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(WebCore::SVGListProperty::removeItemValuesAndWrappers): Handle corner case, the item passed to removeItem() was the only on in the list, list is empty now, nothing to replace.
(WebCore::SVGListProperty::appendItemValuesAndWrappers):
(WebCore::SVGListProperty::role): Expose the role of this list property.
* svg/properties/SVGPathSegListPropertyTearOff.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox.
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::appendItem):
* svg/properties/SVGProperty.h: Add new virtual SVGPropertyRole role() accessor.
* svg/properties/SVGPropertyTearOff.h:
(WebCore::SVGPropertyTearOff::create): Store the passed in SVGProperyRole, instead of ignoring it.
(WebCore::SVGPropertyTearOff::role):
(WebCore::SVGPropertyTearOff::SVGPropertyTearOff):
* svg/properties/SVGStaticPropertyTearOff.h:
(WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Pass UndefinedRole as default role to SVGPropertyTearOff.
* svg/properties/SVGStaticPropertyWithParentTearOff.h: Ditto.
(WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 12:11:40 +0000 (12:11 +0000)]
Not reviewed. Rebaselining fast/images/imagemap-focus-ring-zoom.html for Chromium on Win and Linux.
* platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
* platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 12:02:22 +0000 (12:02 +0000)]
Not reviewed. Rebaselining svg/custom/image-rescale.svg for Chromium on Mac.
* platform/chromium-mac/svg/custom/image-rescale-expected.checksum: Added.
* platform/chromium-mac/svg/custom/image-rescale-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 11:57:12 +0000 (11:57 +0000)]
Not reviewed, removing suppression for now passing editing/selection/
5354455-1.html (on Win)
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 10:53:28 +0000 (10:53 +0000)]
Not reviewed, proper platform for international test.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 10:51:21 +0000 (10:51 +0000)]
Not reviewed, Chromium suppressions for a bunch of SVG tests and one international.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 10:26:26 +0000 (10:26 +0000)]
Not reviewed, temporary suppressing fast/css/font-face-data-uri.html for Chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 22 Nov 2010 10:22:42 +0000 (10:22 +0000)]
2010-11-22 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Partially roll out r72282.
It should not have modified devtools files.
* src/js/devTools.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Nov 2010 09:59:44 +0000 (09:59 +0000)]
2010-11-22 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QWebElement::appendInside() doesn't work on head elements
https://bugs.webkit.org/show_bug.cgi?id=49166
Make QWebElement::appendInside() call
Element::deprecatedCreateContextualFragment(), bypassing the check for
the HEAD tag in the HTMLElement implementation of this function.
* Api/qwebelement.cpp:
(QWebElement::appendInside):
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::addElementToHead):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 09:58:12 +0000 (09:58 +0000)]
Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium-gpu.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 09:53:24 +0000 (09:53 +0000)]
Not reviewed, remove duplicate suppression.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 09:30:07 +0000 (09:30 +0000)]
Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 22 Nov 2010 09:27:03 +0000 (09:27 +0000)]
2010-11-22 João Paulo Rechi Vita <jprvita@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Fix EWebLauncher zoom discretization
https://bugs.webkit.org/show_bug.cgi?id=49810
* EWebLauncher/main.c:
(nearest_zoom_level_get):
(zoom_level_set):
(on_load_finished):
(on_key_down):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 22 Nov 2010 09:26:06 +0000 (09:26 +0000)]
Not reviewed. Rebaselining fast/js/regexp-overflow.html expectations
for Chromium after http://trac.webkit.org/changeset/72489
* platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Added.
* platform/chromium-win/fast/js/regexp-overflow-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 22 Nov 2010 08:41:57 +0000 (08:41 +0000)]
2010-11-22 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
https://bugs.webkit.org/show_bug.cgi?id=49374
* fast/css/font-face-data-uri-expected.txt: Added.
* fast/css/font-face-data-uri.html: Added.
2010-11-22 Yuzo Fujishima <yuzo@google.com>
Reviewed by Dan Bernstein.
Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
https://bugs.webkit.org/show_bug.cgi?id=49374
Test: fast/css/font-face-data-uri.html
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSupportedFormat): Do not check "file
extension" for data URI. For other URI, check against ".eot" rather
than "eot".
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 22 Nov 2010 03:03:54 +0000 (03:03 +0000)]
Update WebKit2 skipped list.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 22 Nov 2010 02:16:24 +0000 (02:16 +0000)]
Fix ~300 WebKit2 tests by enabling developer extras preference.
Rubber-stamped by Dan Bernstein.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 22 Nov 2010 02:08:50 +0000 (02:08 +0000)]
Textareas should be resizable by default
https://bugs.webkit.org/show_bug.cgi?id=49892
Reviewed by Dan Bernstein.
WebKit2:
Test: WebKit2/WKPreferences
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
Add textAreasAreResizable bit.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetJavaEnabled):
(WKPreferencesGetJavaEnabled):
Fix typo, WKPRe... -> WKPre...
(WKPreferencesSetMinimumFontSize):
(WKPreferencesGetMinimumFontSize):
Fix comment to correctly reflect that the default minimumFontSize is 0, not 1.
(WKPreferencesSetTextAreasAreResizable):
(WKPreferencesGetTextAreasAreResizable):
* UIProcess/API/C/WKPreferences.h:
Add API.
* UIProcess/API/C/WKPreferencesPrivate.h:
Don't use PLATFORM in API headers.
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setTextAreasAreResizable):
(WebKit::WebPreferences::textAreasAreResizable):
* UIProcess/WebPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe bit through to the WebProcess and onto WebCore::Settings.
WebKitTools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Add preferences test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 22 Nov 2010 00:10:38 +0000 (00:10 +0000)]
2010-11-21 Patrick Gansterer <paroga@webkit.org>
Reviewed by Csaba Osztrogonác.
Use WTF_ARRAY_LENGTH in WebCore directory
https://bugs.webkit.org/show_bug.cgi?id=49882
* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* css/CSSComputedStyleDeclaration.cpp:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::getPropertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
* css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap):
* dom/ExceptionCode.cpp:
(WebCore::getExceptionCodeDescription):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
* editing/EditingStyle.cpp:
* editing/Editor.cpp:
(WebCore::triStateOfStyle):
* editing/EditorCommand.cpp:
(WebCore::createCommandMap):
* editing/MarkupAccumulator.cpp:
(WebCore::appendCharactersReplacingEntities):
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):
* loader/FTPDirectoryParser.cpp:
(WebCore::parseOneFTPLine):
* mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hasValidAvgCharWidth):
* rendering/break_lines.cpp:
* svg/SVGTransformable.cpp:
(WebCore::parseAndSkipType):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
* svg/SVGZoomAndPan.cpp:
(WebCore::SVGZoomAndPan::parseZoomAndPan):
* xml/XPathFunctions.cpp:
(WebCore::XPath::createFunctionMap):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Sun, 21 Nov 2010 23:03:30 +0000 (23:03 +0000)]
2010-11-21 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Implement ROLE_COMBO_BOX
https://bugs.webkit.org/show_bug.cgi?id=25678
Implement the remaining bits for combo boxes.
This patch finishes the implementation, from the point of view of
the Atk library, of those objects exposed to ATK as combo boxes,
and their related elements (menus and menu items). It therefore
implements the proper interfaces for each type of object related
to combo boxes (AtkSelection for the combo box, AtkText for every
menu item and AtkAction for the combo box, the menu and the menu
items), takes care of emitting the proper signals when focus or a
given a selection changes and adds a new unit test to check all
this new stuff.
Make possible to ask an AccessibleMenuListOption for a sensible
string representation, so far only available through the private
and MSAA related method nameForMSAA. Just moved the implementation
of that method to an overriden version of stringValue(), which is
platform independent, and called that from nameForMSAA().
* accessibility/AccessibilityMenuListOption.h:
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to
stringValue(), which holds from now on that used to be here.
(WebCore::AccessibilityMenuListOption::stringValue): New, override
of AccessibilityObject::stringValue() to return a proper string.
Emit the missing signals when a selection is made.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Emit the usual
'focus' signals when a selection is made over the combo box.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED
Atk states are added to the state set when needed.
(listObjectForSelection): New, returns the proper list object (the
one holding the list of available options as its children) for an
specific AtkObject implementing AtkSelection. This is needed
because sometimes the selectable options are not directly children
of the AtkSelection object (i.e. a combo box has a 'menu' object
as its only child of it, holding the list of options as children).
(optionFromList): Use listObjectForSelection() to get the actual
object holding the list of children as the available options.
(optionFromSelection): Add support for combo boxes.
(webkit_accessible_selection_add_selection): Ditto.
(webkit_accessible_selection_clear_selection): Ditto.
(webkit_accessible_selection_get_selection_count): Ditto.
(webkit_accessible_selection_is_child_selected): Ditto.
(webkit_accessible_selection_remove_selection): Ditto.
(webkit_accessible_text_get_text): Makes sure stringValue() is
considered to get the result substring when it was already
considered when checking the maximum text length for the object.
(getInterfaceMaskFromObject): Make sure the AtkSelection interface
is implemented for the combo boxes, that the AtkText is
implemented for the menu items and that the AtkAction interface is
now implemented for every object (WebCore will decide what to do).
Avoid a segfault crash when using this from unit tests.
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow
before calling gdk_window_get_origin() over it.
2010-11-21 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Implement ROLE_COMBO_BOX
https://bugs.webkit.org/show_bug.cgi?id=25678
New test to check the implementation of the combo boxes.
* tests/testatk.c:
(testWebkitAtkComboBox): New test, checking that the roles and the
implemented interfaces for a combo box and its descendants work.
(main): Added the new unit test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 21 Nov 2010 17:09:31 +0000 (17:09 +0000)]
2010-11-21 Patrick Gansterer <paroga@webkit.org>
Reviewed by Csaba Osztrogonác.
Use WTF_ARRAY_LENGTH in WebCore/platform directory
https://bugs.webkit.org/show_bug.cgi?id=49881
* platform/KURL.cpp:
(WebCore::portAllowed):
* platform/KURLGoogle.cpp:
(WebCore::portAllowed):
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedJavaScriptMIMETypes):
(WebCore::initializeSupportedNonImageMimeTypes):
* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
* platform/graphics/GraphicsTypes.cpp:
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCodepage::if):
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::disableComponentsOnce):
* platform/graphics/mac/SimpleFontDataATSUI.mm:
(WebCore::SimpleFontData::checkShapesArabic):
* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawLineForTextChecking):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::disableComponentsOnce):
* platform/graphics/win/QTMovie.cpp:
(QTMovie::load):
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::createStreams):
* platform/text/TextEncodingRegistry.cpp:
(WebCore::pruneBlacklistedCodecs):
* platform/text/transcoder/FontTranscoder.cpp:
(WebCore::FontTranscoder::FontTranscoder):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 21 Nov 2010 13:11:02 +0000 (13:11 +0000)]
2010-11-21 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Add test for unicode plane 1 characters
https://bugs.webkit.org/show_bug.cgi?id=49581
* fast/encoding/xml-utf-8-default-expected.txt:
* fast/encoding/xml-utf-8-default.xml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 21 Nov 2010 07:20:24 +0000 (07:20 +0000)]
2010-11-20 Andreas Kling <kling@webkit.org>
Rubber-stamped by Antonio Gomes.
[Qt] Fix spelling error (isEmtpyValue -> isEmptyValue)
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::isEmptyValue):
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 21 Nov 2010 06:44:29 +0000 (06:44 +0000)]
2010-11-20 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Limit the size of image preview "cursor" when dragging
https://bugs.webkit.org/show_bug.cgi?id=49872
Respect DragController::maxDragImageSize() (currently 400x400.)
* platform/qt/DragImageQt.cpp:
(WebCore::dragImageSize):
(WebCore::scaleDragImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 21 Nov 2010 06:36:37 +0000 (06:36 +0000)]
2010-11-20 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
https://bugs.webkit.org/show_bug.cgi?id=49870
* WebCoreSupport/DragClientQt.cpp:
(WebCore::DragClientQt::startDrag): Pass the DragImage to QDrag::setPixmap()
2010-11-20 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
https://bugs.webkit.org/show_bug.cgi?id=49870
Implement Frame::dragImageForSelection() and the necessary DragImage helpers for Qt.
* page/qt/FrameQt.cpp:
(WebCore::Frame::dragImageForSelection):
* platform/qt/DragImageQt.cpp:
(WebCore::deleteDragImage):
(WebCore::createDragImageFromImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sun, 21 Nov 2010 06:22:14 +0000 (06:22 +0000)]
2010-11-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Remove leftover code in unit test.
* GNUmakefile.am: remove unneeded utils file in dependency list.
* tests/testdomdocument.c:
(main): do not change to the directory of a non existing resource
list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Sun, 21 Nov 2010 06:11:57 +0000 (06:11 +0000)]
WebCore:
2010-11-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Memory managament for DOM GObject wrappers
https://bugs.webkit.org/show_bug.cgi?id=40302
Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).
* GNUmakefile.am:
* bindings/gobject/DOMObjectCache.cpp: Added.
* bindings/gobject/DOMObjectCache.h: Copied from WebCore/bindings/gobject/WebKitDOMBinding.h.
* bindings/gobject/WebKitDOMBinding.cpp: Remove the old cache code.
* bindings/gobject/WebKitDOMBinding.h: ditto.
* bindings/scripts/CodeGeneratorGObject.pm: include the new DOMObjectCache header.
WebKit/gtk:
2010-11-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Memory managament for DOM GObject wrappers
https://bugs.webkit.org/show_bug.cgi?id=40302
Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).
* GNUmakefile.am: add testutils file to testdomdocument.c
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::setMainFrameDocumentReady): collect
DOM objects on document transition.
* tests/testdomdocument.c:
(dom_document_fixture_teardown): only destroy the view if it's not
already destroyed, since the new test detroys it on its own.
(test_dom_document_get_elements_by_tag_name): manually unref node list.
(test_dom_document_get_elements_by_class_name): ditto.
(test_dom_document_get_links): ditto.
(test_dom_document_garbage_collection): test all possible
scenarios for DOM object "garbage collection".
(main): add new test.
* tests/testdomnode.c:
(test_dom_node_hierarchy_navigation): manually unref node list.
(test_dom_node_insertion): ditto.
* webkit/webkithittestresult.cpp:
(webkit_hit_test_result_dispose): unref the inner node on dispose
now that the memory management model is clarified.
(webkit_hit_test_result_class_init): hook dispose.
* webkit/webkitwebframe.cpp:
(webkit_web_frame_core_frame_gone): clear DOM objects attached to this frame.
(webkit_web_frame_finalize): ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 21 Nov 2010 06:03:08 +0000 (06:03 +0000)]
2010-11-20 Sam Magnuson <smagnuso@gmail.com>
Reviewed by Andreas Kling.
[Qt] crash when attempting to add a JS object
https://bugs.webkit.org/show_bug.cgi?id=49287
* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject):
Test: LayoutTests/fast/frames/sandboxed-iframe-plugins.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 21 Nov 2010 04:19:55 +0000 (04:19 +0000)]
2010-11-20 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] Path stroke lacks blur shadow support
https://bugs.webkit.org/show_bug.cgi?id=49490
Add new test for checking path stroke blur shadow.
* fast/canvas/canvas-strokePath-shadow-expected.txt: Added.
* fast/canvas/canvas-strokePath-shadow.html: Added.
* fast/canvas/script-tests/canvas-strokePath-shadow.js: Added.
2010-11-20 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] Path stroke lacks blur shadow support
https://bugs.webkit.org/show_bug.cgi?id=49490
Add blur shadow support to strokePath().
Test: fast/canvas/canvas-strokePath-shadow.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokePath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sun, 21 Nov 2010 02:48:09 +0000 (02:48 +0000)]
YARR JIT should fallback to YARR Interpreter instead of PCRE.
https://bugs.webkit.org/show_bug.cgi?id=46719
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-19
Reviewed by Gavin Barraclough.
Remove the ENABLE_YARR macro and the option of matching regular
expressions with PCRE from JavaScriptCore.
JavaScriptCore:
* runtime/JSGlobalData.h:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::match):
* tests/mozilla/expected.html:
* wtf/Platform.h:
* yarr/RegexCompiler.cpp:
* yarr/RegexCompiler.h:
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::byteCompileRegex):
* yarr/RegexInterpreter.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::jitCompileRegex):
* yarr/RegexJIT.h:
(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::isFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):
* yarr/RegexParser.h:
* yarr/RegexPattern.h:
LayoutTests:
* fast/js/regexp-look-ahead-empty-expected.txt:
* fast/js/regexp-overflow-expected.txt:
* fast/js/script-tests/regexp-overflow.js:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 21 Nov 2010 01:05:23 +0000 (01:05 +0000)]
2010-11-20 Ryosuke Niwa <rniwa@webkit.org>
Another unreviewed rebaseline for r72482.
* editing/selection/extend-selection-home-end-expected.txt:
* platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 21 Nov 2010 00:27:23 +0000 (00:27 +0000)]
2010-11-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Kilzer.
[BREWMP] Replace HTONL, HTONS, NTOHL and NTOHS with byte order conversion functions from AEEstd.h
https://bugs.webkit.org/show_bug.cgi?id=49518
HTONL, HTONS, NTOHL and NTOHS macros are prohibited in Mod1. Use byte order conversion functions provided by AEEstd.h.
* platform/graphics/WOFFFileFormat.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 21 Nov 2010 00:16:38 +0000 (00:16 +0000)]
2010-11-20 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed rebaselines for r72482.
Since Home/End behavior is different on Mac and GTK, move the expected result added by r72482
to platform/mac and platform/gtk, and add new expected result for other platforms.
See also: http://trac.webkit.org/changeset/54980 and https://webkit.org/b/35066.
* editing/selection/extend-selection-home-end-expected.txt:
* platform/chromium-win/editing/selection/extend-selection-expected.txt: Removed.
* platform/chromium/test_expectations.txt: Removed extend-selection.html.
* platform/gtk/Skipped: Ditto.
* platform/gtk/editing/selection/extend-selection-expected.txt: Removed.
* platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Added.
* platform/mac/editing/selection/extend-selection-home-end-expected.txt: Added.
* platform/qt/Skipped: Removed extend-selection.html.
* platform/win/editing/selection/extend-selection-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 20 Nov 2010 23:34:43 +0000 (23:34 +0000)]
2010-11-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Kilzer.
[BREWMP] Use std_wstrlen instead of WSTRLEN
https://bugs.webkit.org/show_bug.cgi?id=49516
WSTRLEN is prohibited in Mod1. Use std_wstrlen from AEEstd.h instead.
* platform/text/brew/StringBrew.cpp:
(WTF::String::String):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 20 Nov 2010 23:32:01 +0000 (23:32 +0000)]
2010-11-20 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Kilzer.
[BREWMP] Replace DBGPRINTF and DBGPRINTF_FATAL with dbg_Message
https://bugs.webkit.org/show_bug.cgi?id=49520
DBGPRINTF and DBGPRINTF_FATAL macros are prohibited in Mod1. Use dbg_Message instead.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 20 Nov 2010 23:18:51 +0000 (23:18 +0000)]
2010-11-20 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
[WINCE] Implement textBreakLast and textBreakPrevious
https://bugs.webkit.org/show_bug.cgi?id=49552
This allows us to use TextBoundaries.cpp and remove TextBoundariesWinCE.cpp.
Also unify the different TextBreakIterator::first() implementations.
* platform/text/wince/TextBoundariesWinCE.cpp: Removed.
* platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::TextBreakIterator::first):
(WebCore::TextBreakIterator::last):
(WebCore::textBreakLast):
(WebCore::textBreakPrevious):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 20 Nov 2010 22:51:50 +0000 (22:51 +0000)]
2010-11-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Antonio Gomes.
/editing/selection/extend-selection.html should be split into smaller tests
https://bugs.webkit.org/show_bug.cgi?id=49849
Divided the test into 4 pieces.
* editing/selection/extend-selection-character-expected.txt: Added.
* editing/selection/extend-selection-character.html: Added.
* editing/selection/extend-selection-enclosing-block-expected.txt: Added.
* editing/selection/extend-selection-enclosing-block.html: Added.
* editing/selection/extend-selection-expected.txt: Removed.
* editing/selection/extend-selection-home-end-expected.txt: Added.
* editing/selection/extend-selection-home-end.html: Added.
* editing/selection/extend-selection-word-expected.txt: Added.
* editing/selection/extend-selection-word.html: Added.
* editing/selection/extend-selection.html: Removed.
* editing/selection/resources/extend-selection.css: Added.
(div.test):
(div.test:before):
(div.test span):
(div.test img):
(div.test img + img):
(div.test div):
* editing/selection/resources/extend-selection.js: Added.
(log):
(positionsExtendingInDirectionForEnclosingBlock):
(positionsExtendingInDirection):
(fold):
(logPositions):
(checkReverseOrder):
(checkSameOrder):
(extendingSelection):
(testExtendingSelection):
(createTestNodes.window.onload):
(createTestNodes):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Sat, 20 Nov 2010 22:02:36 +0000 (22:02 +0000)]
2010-11-20 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Support JIT_OPTIMIZE_MOD on Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=49432
Rewrite the soft modulo operation into macroassembler form, and move it
to JSValue32_64 section.
Add support for soft modulo on Thumb-2 JIT also.
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::clz):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::countLeadingZeros32):
(JSC::MacroAssemblerARM::relativeTableJump):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::countLeadingZeros32):
(JSC::MacroAssemblerARMv7::relativeTableJump):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::softModulo):
* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Sat, 20 Nov 2010 21:25:19 +0000 (21:25 +0000)]
Unreviewed. Adding failing expectation for Win + Linux for new
fast/canvas/canvas-fillPath-shadow test.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sat, 20 Nov 2010 20:54:24 +0000 (20:54 +0000)]
2010-11-20 Andreas Kling <kling@webkit.org>
Reviewed by David Kilzer.
Path: Remove unused method swap()
https://bugs.webkit.org/show_bug.cgi?id=49853
* platform/graphics/Path.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 20 Nov 2010 20:12:14 +0000 (20:12 +0000)]
<webkit.org/b/49867> MediaPlayerPrivateQTKit::setPreservesPitch(bool) leaks an NSDictionary
Reviewed by Dan Bernstein.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): Use
RetainPtr<NSDictionary> for movieAttributes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 20 Nov 2010 18:54:43 +0000 (18:54 +0000)]
<webkit.org/b/49848> Make it possible to display the last character of a secure text field unobscured
Reviewed by Darin Adler.
* JavaScriptCore.exp:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::secure): Added argument that controls whether
the last character is obscured or not. Implemented behavior.
* wtf/text/StringImpl.h:
(WTF::StringImpl::LastCharacterBehavior): Added enum.
(WTF::StringImpl::secure): Updated method signature.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 20 Nov 2010 17:40:10 +0000 (17:40 +0000)]
2010-11-20 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45488
* dom/XMLDocumentParser.cpp:
(WebCore::toString):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc