2011-01-21  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        Update chromium/linux baselines after drawing code moved into
        WebThemeEngine.
        https://bugs.webkit.org/show_bug.cgi?id=52826

        * platform/chromium-linux/css1/box_properties/acid_test-expected.checksum:
        * platform/chromium-linux/css1/box_properties/acid_test-expected.png:
        * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
        * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
        * platform/chromium-linux/fast/block/basic/011-expected.checksum:
        * platform/chromium-linux/fast/block/basic/011-expected.png:
        * platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
        * platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
        * platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.checksum:
        * platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
        * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
        * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
        * platform/chromium-linux/fast/forms/basic-inputs-expected.checksum:
        * platform/chromium-linux/fast/forms/basic-inputs-expected.png:
        * platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
        * platform/chromium-linux/fast/forms/basic-selects-expected.png:
        * platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
        * platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
        * platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.checksum:
        * platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png:
        * platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
        * platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
        * platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
        * platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
        * platform/chromium-linux/fast/forms/formmove-expected.checksum:
        * platform/chromium-linux/fast/forms/formmove-expected.png:
        * platform/chromium-linux/fast/forms/formmove2-expected.checksum:
        * platform/chromium-linux/fast/forms/formmove2-expected.png:
        * platform/chromium-linux/fast/forms/indeterminate-expected.checksum:
        * platform/chromium-linux/fast/forms/indeterminate-expected.png:
        * platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
        * platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
        * platform/chromium-linux/fast/forms/input-value-expected.checksum:
        * platform/chromium-linux/fast/forms/input-value-expected.png:
        * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
        * platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
        * platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
        * platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
        * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
        * platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added property svn:mime-type.
        * platform/chromium-linux/fast/forms/radio-attr-order-expected.checksum:
        * platform/chromium-linux/fast/forms/radio-attr-order-expected.png:
        * platform/chromium-linux/fast/forms/radio-nested-labels-expected.checksum:
        * platform/chromium-linux/fast/forms/radio-nested-labels-expected.png:
        * platform/chromium-linux/fast/forms/radio_checked-expected.checksum:
        * platform/chromium-linux/fast/forms/radio_checked-expected.png:
        * platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.checksum:
        * platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png:
        * platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
        * platform/chromium-linux/fast/forms/select-baseline-expected.png:
        * platform/chromium-linux/fast/inline/positionedLifetime-expected.checksum:
        * platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
        * platform/chromium-linux/fast/parser/bad-xml-slash-expected.checksum:
        * platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
        * platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
        * platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
        * platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.checksum:
        * platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
        * platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
        * platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
        * platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
        * platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added property svn:mime-type.
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
2011-01-21  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
        https://bugs.webkit.org/show_bug.cgi?id=52826

        * platform/chromium/ChromiumBridge.h:
        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::getWebThemeState):
        (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
        (WebCore::RenderThemeChromiumLinux::paintCheckbox):
        (WebCore::RenderThemeChromiumLinux::setCheckboxSize):
        (WebCore::RenderThemeChromiumLinux::paintRadio):
        (WebCore::RenderThemeChromiumLinux::setRadioSize):
        (WebCore::RenderThemeChromiumLinux::paintButton):
        (WebCore::RenderThemeChromiumLinux::paintTextField):
        (WebCore::RenderThemeChromiumLinux::paintMenuList):
        (WebCore::RenderThemeChromiumLinux::paintSliderTrack):
        (WebCore::RenderThemeChromiumLinux::paintSliderThumb):
        (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
        (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
        (WebCore::RenderThemeChromiumLinux::paintProgressBar):
        * rendering/RenderThemeChromiumLinux.h:
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::setCheckboxSize):
        (WebCore::RenderThemeChromiumSkia::setSizeIfAuto):
        (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
        * rendering/RenderThemeChromiumSkia.h:
2011-01-21  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
        https://bugs.webkit.org/show_bug.cgi?id=52826

        * WebKit.gyp:
        * src/ChromiumBridge.cpp:
        (WebCore::WebThemePart):
        (WebCore::GetWebThemeExtraParams):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Anders Carlsson.

Rename ScrollbarClient -> ScrollableArea.

Source/WebCore:

- Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea
  since that was its only use case.

* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* page/FrameView.h:
* platform/PopupMenuClient.h:
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::notityPositionChanged):
* platform/ScrollAnimator.h:
* platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):
* platform/ScrollAnimatorWin.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::~ScrollableArea):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
* platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::isWindowActive):
(WebCore::Scrollbar::invalidateRect):
(WebCore::Scrollbar::convertToContainingView):
(WebCore::Scrollbar::convertFromContainingView):
* platform/Scrollbar.h:
(WebCore::Scrollbar::disconnectFromScrollableArea):
(WebCore::Scrollbar::scrollableArea):
* platform/ScrollbarClient.cpp: Removed.
* platform/ScrollbarClient.h: Removed.
* platform/ScrollbarThemeComposite.cpp:
* platform/chromium/FramelessScrollView.h:
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* platform/efl/ScrollbarEfl.cpp:
(Scrollbar::createNativeScrollbar):
(ScrollbarEfl::ScrollbarEfl):
(scrollbarEflEdjeMessage):
* platform/efl/ScrollbarEfl.h:
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::create):
(MainFrameScrollbarGtk::MainFrameScrollbarGtk):
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/gtk/MainFrameScrollbarGtk.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h:
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
* platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::paint):
* rendering/RenderDataGrid.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::scroll):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::destroyScrollbar):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createScrollbar):
* rendering/RenderMenuList.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):
* rendering/RenderScrollbar.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createScrollbar):
* rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

* src/AutoFillPopupMenuClient.cpp:
(WebKit::AutoFillPopupMenuClient::createScrollbar):
* src/AutoFillPopupMenuClient.h:
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
* src/WebScrollbarImpl.h:
* tests/PopupMenuTest.cpp:
(WebKit::TestPopupMenuClient::createScrollbar):

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

Source/WebKit/win:

* WebScrollBar.cpp:
(WebScrollBar::scroll):
* WebScrollBar.h:

Source/WebKit2:

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
* UIProcess/win/WebPopupMenuProxyWin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Ryosuke Niwa.

        [chromium] Notify WebFrameClient when spellcheck state changes
        https://bugs.webkit.org/show_bug.cgi?id=52680

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
        * src/WebFrameImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Peter Gal  <galpeter@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        REGRESSION(r76177): All JavaScriptCore tests fail on ARM
        https://bugs.webkit.org/show_bug.cgi?id=52814

        Get the approximateByteSize value before releasing the OwnPtr.

        * parser/JSParser.cpp:
        (JSC::JSParser::parseFunctionInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix Leopard build.

* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        GraphicsLayer should be non-copyable
        https://bugs.webkit.org/show_bug.cgi?id=52909

        Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
        on that and KeyframeValueList.

        * platform/graphics/GraphicsLayer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
        https://bugs.webkit.org/show_bug.cgi?id=52901

        * fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added.
        * fast/dom/htmlcollection-conversion-throws-exception.html: Added.
2011-01-21  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
        https://bugs.webkit.org/show_bug.cgi?id=52901

        Test: fast/dom/htmlcollection-conversion-throws-exception.html

        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        (WebCore::getItem):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Separate flushing layer changes from rendering in CACFLayerTreeHost

Old model:
  1) A change is made to a GraphicsLayer.
  2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the
     render timer.
  3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the
     flush and then renders.

New model:
  1) A change is made to a GraphicsLayer.
  2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new
     LayerChangesFlusher singleton that this host has changes that need to be flushed.
  3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration
     of the message loop.
  4) LayerChangesFlusher's hook is called, which calls through to
     CACFLayerTreeHost::flushPendingLayerChangesNow.
  5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes
     that were just flushed to the context will be rendered.

When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
(e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
scheduling the flush.

This change has three advantages:
  1) Whenever we flush layer changes, we first update layout. This can cause the page to
     leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
     to be dropped. By separating flushing (and thus updating layout) from rendering, we no
     longer have to worry about this happen during rendering.
  2) The new model is much more similar to how things work on the Mac, so will hopefully
     reduce the number of platform-specific bugs.
  3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a
     layout was pending, is no longer needed. It actually hasn't been needed since at least
     r75987, but removing it before now would have resulted in a crash whenever a page came
     out of compositing mode due to (1).

Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing
 #includes.
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
finished.
(WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
fixed a bug where we'd fail to clear the context's layer.
(WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
is no longer needed. Moved code to flush layer changes from here to
flushPendingLayerChangesNow, which is called via the above-described mechanism.
(WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
code to schedule a render, which now happens after we've flushed.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
schedule a render so that the changes will be rendered to the screen.

* platform/graphics/ca/win/CACFLayerTreeHost.h: Removed
CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
m_isFlushingLayerChanges.

* platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared):
(WebCore::LayerChangesFlusher::LayerChangesFlusher):
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookCallback):
(WebCore::LayerChangesFlusher::hookFired):
(WebCore::LayerChangesFlusher::setHook):
(WebCore::LayerChangesFlusher::removeHook):

* platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
(WebCore::LayerChangesFlusher::shared): Returns the singleton.
(WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
hosts with changes that need to be flushed, and set up our hook if we haven't already.
(WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
we're currently in the process of calling out to our hosts, in which case we'll take care of
the hook once we're done calling out.
(WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
our hook fires. Just calls through to hookFired on the singleton.
(WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
flushed that it's time to flush. If no hosts re-added themselves to our set during this
process, remove our hook.
(WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
(WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.

* platform/graphics/ca/win/LayerChangesFlusher.h: Added.

Source/WebKit/win:

Update for CACFLayerTreeHost changes

* WebView.cpp:
(WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
to our own flushing function if needed.

* WebView.h: Removed shouldRender, which is no longer used or needed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Report the sized used by canvases and types arrays
        https://bugs.webkit.org/show_bug.cgi?id=52856

        Report the memory cost associated with canvas elements,
        and typed arrays to JavaScript as extraCost, so that it
        can figure this into its GC behavior.

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::toJSArrayBufferView): New templatized function, similar
        to getDOMObjectWrapper() but calls reportExtraMemoryCost() with
        the byteLength of the array.

        * bindings/js/JSFloat32ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSInt16ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSInt32ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSInt8ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSUint16ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSUint32ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.
        * bindings/js/JSUint8ArrayCustom.cpp:
        (WebCore::toJS): Use toJSArrayBufferView.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost()
        with the size of the canvas backing store.

        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::byteLength): byteLength needs to
        be public.

        * platform/graphics/ImageBuffer.h: Add dataSize() method.

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/haiku/ImageBufferHaiku.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/wince/ImageBufferWinCE.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().
        * platform/graphics/wx/ImageBufferWx.cpp:
        (WebCore::ImageBuffer::dataSize): Implement dataSize().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]

Also renamed a few functions and data members to match.

Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.

* WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include
path.

* WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
* platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.

* platform/graphics/ca/win/PlatformCALayerWin.cpp:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Updated for renames.

Source/WebKit/win:

Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename

Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.

* WebPreferences.cpp:
* WebView.cpp:
(WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
host before we get rid of the layer tree host itself.
* WebView.h:

Source/WebKit2:

Update for WKCACFLayerRenderer -> CACFLayerView rename

* WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary
 #includes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Remove unnecessary <stdio.h> include
        https://bugs.webkit.org/show_bug.cgi?id=52884

        * jit/JIT.cpp: remove unnecessary include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Patrick Gansterer  <paroga@paroga.com>

        Original patch from François Sausset  <sausset@gmail.com>

        Reviewed by Darin Adler.

        Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52201

        Replace unneeded doubles by floats and remove unneeded casts.

        * rendering/mathml/RenderMathMLFraction.cpp:
        (WebCore::RenderMathMLFraction::paint):
        * rendering/mathml/RenderMathMLFraction.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Proposal: Require cross-organizational seconds for reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=47597

Reviewed by Darin Adler.

This changes the committer/reviewer policy to require an additional
reviewer supporting a reviewer nomination to work for a different
company and different project affiliation from the nominee.

This means reviewer nominations would require four supporting reviewers,
one of which knows the reviewer through the community (irc, email, bugs)
ensuring that the nominee has the open-source collaboration skills
we so highly value here in WebKit.

* coding/commit-review-policy.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r73618): Clicking on a search input causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=52905

        * fast/dom/search-shadow-host-crash-expected.txt: Added.
        * fast/dom/search-shadow-host-crash.html: Added.
2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r73618): Clicking on a search input causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=52905

        The problem is caused by TextControlInnerElement being used both as
        shadow root and an element in a shadow subtree. The code assumed it is
        only used as a shadow root.

        Since this code is all just workaround for in-progress conversion to
        new shadow DOM, I am just adding a check. This code will disappear
        completely once bug 52788 is fixed.

        Test: fast/dom/search-shadow-host-crash.html

        * dom/Node.cpp:
        (WebCore::Node::setShadowHost): Added an ASSERT for early detection
            of attempting to stomp on the parentNode.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::detach): Added a check to only
            clear shadow host if we have one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated slider expectations after r76147.

        * platform/chromium/test_expectations.txt: Removed test that will start passing.
        * platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.

        Rebaseline for leopard after r76319.

        * platform/mac-leopard/fast/dom/52776-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Tony Chang  <tony@chromium.org>

        Unreviewed, updating chromium DEPS so we can pull in linux theme changes.

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

   Fix Mac build.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit2: Implement showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=52855

Reviewed by Dan Bernstein.

Source/WebKit2:

* Shared/WebPageCreationParameters.h: Added canRunModal.

* UIProcess/API/C/WKPage.h: Added a runModal function pointer to
WKPageUIClient. Also removed a lot of redundant typedefs and added
a new one, WKPageCallback, for callbacks without arguments or return
values.

* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage): Added a runModal function pointer of 0.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters): Set canRunModal
based on return value of WebUIClient::canRunModal.

* UIProcess/WebPageProxy.h: Added runModal.
Calls WebUIClient::runModal.

* UIProcess/WebPageProxy.messages.in: Added RunModal message.
Also removed the periods from the phrases in the comments
as Maciej requested a while back.

* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canRunModal): Added. Returns true or false
based on whether a runModal function was supplied in the
WKPageUIClient structure.
(WebKit::WebUIClient::runModal): Added. Calls the runModal
function from the WKPageUIClient structure.
* UIProcess/WebUIClient.h: Declared the above functions.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::canRunModal): Call through to WebPage.
(WebKit::WebChromeClient::runModal): Ditto.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
creation parameters. Initialize m_isRunningModal to false.
(WebKit::WebPage::close): Stop the nested run loop if we are running modal.
(WebKit::WebPage::runModal): Send a message to ask the UI process to run
modal and then start a nested run loop. It gets stopped when the page is closed.
* WebProcess/WebPage/WebPage.h: Defined the canRunModal function
and declared the runModal function.

Tools:

This fixes WebKitTestRunner to compile, but more work is probably
needed to get it to pass the tests.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runModal): Added. Calls through to the
platform-specific version of runModal.
(WTR::TestController::createOtherPage): Changed to be a private
static member function so it can refer to runModal, which is
a private static member function.
(WTR::TestController::initialize): Pass 0 for the runModal
function since we don't need to run the main window modal.
I suspect this is wrong and will need to change.
* WebKitTestRunner/TestController.h: Added declarations for
the functions added above.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::runModal): Added. Untested implementation.
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::runModal): Added.
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::runModal): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by David Levin.

        remove non-flaky tests from test expectation file
        https://bugs.webkit.org/show_bug.cgi?id=52746

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"

This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.

Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing

Reviewed by Simon Fraser.

Source/WebCore:

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
Updated for renames.

(WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
syncCompositingStateSoon, and updated for other renames.

* platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
* m_shouldFlushPendingGraphicsLayerChanges.
(WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
syncCompositingState.

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.

* WebView.cpp:
(WebView::paint): Updated for rename.
(WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
(WebView::notifySyncRequired): Updated for rename.
(WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.

* WebView.h: Did the renames.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Clean up PlatformCAAnimationWin

Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient

Reviewed by Simon Fraser.

* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFFillModeType):
(fromCACFFillModeType):
(toCACFValueFunctionType):
(fromCACFValueFunctionType):
Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
so we can later convert back to CFStringRef.

(toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
results of CACFTimingFunctionCreate.
(PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().

(PlatformCAAnimation::setFillMode):
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setValueFunction):
(PlatformCAAnimation::setTimingFunctions):
Updated for changes to the above conversion functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
        https://bugs.webkit.org/show_bug.cgi?id=48812

        Test that we avoid updating back/forward list on a canceled navigation
        if a new navigation is already in process.  Also update forward-and-cancel
        to go forward, ensuring back/forward state is reset if user clicks stop.

        * http/tests/navigation/back-twice-without-commit-expected.txt: Added.
        * http/tests/navigation/back-twice-without-commit.html: Added.
        * http/tests/navigation/forward-and-cancel-expected.txt:
        * http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
        * http/tests/navigation/resources/back-twice-page-2.html: Added.
        * http/tests/navigation/resources/back-twice-page-3.html: Added.
        * http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.
2011-01-21  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Fisher.

        FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
        https://bugs.webkit.org/show_bug.cgi?id=48812

        Most calls to stopAllLoaders now clear the history's provisional item(s).
        We can now avoid resetting the back/forward state if a new navigation
        is in progress.

        Test: http/tests/navigation/back-twice-without-commit.html
        Test: http/tests/navigation/forward-and-cancel.html

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/FrameLoaderTypes.h:
        * WebCore.exp.in: Update stopAllLoaders signature.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
        https://bugs.webkit.org/show_bug.cgi?id=52860

        The test hasn't had a timeout in a while, remove that expectation so
        that we can more easily see if this re-occurs.

        Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
        like chromium-gpu-win and -linux, for some reason the mac expectation
        has it as 17,128,4).

        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
        * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
        * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Reverted the last change to the text expectation.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines for 76319.

        * platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
        * platform/chromium-linux/fast/dom/52776-expected.png: Added.
        * platform/chromium-linux/fast/dom/52776-expected.txt: Added.
        * platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
        * platform/chromium-mac/fast/dom/52776-expected.png: Added.
        * platform/chromium-mac/fast/dom/52776-expected.txt: Added.
        * platform/chromium-win/fast/dom/52776-expected.checksum: Added.
        * platform/chromium-win/fast/dom/52776-expected.png: Added.
        * platform/chromium-win/fast/dom/52776-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Tony Chang  <tony@chromium.org>

        Unreviewed, these tests were fixed in r76330.  Still one unknown
        failure.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Show caps lock indicator in password fields
        https://bugs.webkit.org/show_bug.cgi?id=52878

        Test: manual-tests/password-caps-lock.html

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement
        currentCapsLockState() using GDK API.
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon
        in the password field when the caps lock modifier is locked.
        * platform/gtk/RenderThemeGtk.h:
2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Show caps lock indicator in password fields
        https://bugs.webkit.org/show_bug.cgi?id=52878

        Test: manual-tests/password-caps-lock.html

        * webkit/webkitwebview.cpp:
        (webkit_web_view_key_release_event): Call
        capsLockStateMayHaveChanged() when caps lock key is pressed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modify the Windows-specific results after trac.webkit.org/changeset/76208 in order to
get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52557

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776

* platform/win/fast/dom/52776-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
        https://bugs.webkit.org/show_bug.cgi?id=52874

        This is the first step of debugger api refactoring (see bug 52879).
        JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
        The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.

        * inspector/Inspector.idl:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
        (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebugger):
        (WebCore::InspectorController::resume):
        (WebCore::InspectorController::inspectedURL):
        * inspector/InspectorController.h:
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager):
        (WebInspector.BreakpointManager.prototype._saveBreakpoints):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Turn off uninitialized errors for ARM linux build.
        https://bugs.webkit.org/show_bug.cgi?id=52893

        Fix ARM compiler breakage.

        * WebCore.gyp/WebCore.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Add layout test for the CPU profiler.

        This test replaces DevToolsSanityTest.TestProfilerTab from
        Chromium's interactive_ui_tests.

        https://bugs.webkit.org/show_bug.cgi?id=52634

        * inspector/cpu-profiler-profiling-expected.txt: Added.
        * inspector/cpu-profiler-profiling.html: Added.

[Relanding, this time the test should work in Chromium]

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] REGRESSION: Using the "Back" button
        while profiling causes renderer crash.

        https://bugs.webkit.org/show_bug.cgi?id=52808

        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
        (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

        There are some places in WebCore where we still using direct InspectorController calls.
        The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
        Inspector facade for WebCore.

        https://bugs.webkit.org/show_bug.cgi?id=52869

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addProfileImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addProfile):
        (WebCore::InspectorInstrumentation::profilerEnabled):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.

[Qt] editing/selection/rtl-move-selection-right-left.html fails
https://bugs.webkit.org/show_bug.cgi?id=52883

* platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        [GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
        https://bugs.webkit.org/show_bug.cgi?id=52882

        Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: breakpoints are restored incorrectly when reverting live edit.
        https://bugs.webkit.org/show_bug.cgi?id=52300

        Fix breakpoints restoring when reverting to old revision by using text diff.
        Move live edit logic from ScriptsPanel to DebuggerModel.
        Eliminate unnecessary editLine delegate in TextViewer.

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.reset):
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._updateScriptSource):
        (WebInspector.DebuggerModel.prototype.get callFrames):
        (WebInspector.DebuggerModel.prototype.pausedScript):
        (WebInspector.DebuggerModel.prototype.resumedScript):
        * inspector/front-end/Script.js:
        (WebInspector.Script.prototype.get source):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
        (WebInspector.SourceFrame.prototype._doubleClick.didEditLine):
        (WebInspector.SourceFrame.prototype._doubleClick):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype._handleKeyDown):
        (WebInspector.TextViewer.prototype.editLine.finishEditing):
        (WebInspector.TextViewer.prototype.editLine):
        (WebInspector.TextChunk.prototype._createRow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Adam Klein  <adamk@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Rename ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52471

        No tests added as this is a rename; no change in behavior.

        * WebCore.gypi:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::reportFatalErrorInV8):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::isLinkVisited):
        * platform/android/PlatformBridge.h:
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::createBusFromInMemoryAudioFile):
        * platform/chromium/ChromiumBridge.h: Removed.
        * platform/chromium/ChromiumDataObjectLegacy.cpp:
        (WebCore::ChromiumDataObjectLegacy::getData):
        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
        * platform/chromium/FileSystemChromium.cpp:
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::revealFolderInOS):
        (WebCore::directoryName):
        (WebCore::pathByAppendingComponent):
        (WebCore::makeAllDirectories):
        (WebCore::fileExists):
        (WebCore::openFile):
        (WebCore::closeFile):
        (WebCore::seekFile):
        (WebCore::truncateFile):
        (WebCore::readFromFile):
        (WebCore::writeToFile):
        * platform/chromium/LanguageChromium.cpp:
        (WebCore::platformDefaultLanguage):
        * platform/chromium/LinkHashChromium.cpp:
        (WebCore::visitedLinkHash):
        * platform/chromium/MIMETypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PlatformBridge.h:
        * platform/chromium/PlatformScreenChromium.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/chromium/ReadableDataObject.cpp:
        (WebCore::ReadableDataObject::getData):
        (WebCore::ReadableDataObject::urlTitle):
        (WebCore::ReadableDataObject::htmlBaseUrl):
        (WebCore::ReadableDataObject::filenames):
        (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
        * platform/chromium/SSLKeyGeneratorChromium.cpp:
        (WebCore::signedPublicKeyAndChallengeString):
        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
        (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumWin::paintButton):
        (WebCore::ScrollbarThemeChromiumWin::paintThumb):
        (WebCore::ScrollbarThemeChromiumWin::buttonSize):
        * platform/chromium/SharedTimerChromium.cpp:
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):
        * platform/chromium/SuddenTerminationChromium.cpp:
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):
        * platform/chromium/SystemTimeChromium.cpp:
        (WebCore::currentTime):
        * platform/chromium/WritableDataObject.cpp:
        (WebCore::WritableDataObject::setData):
        * platform/graphics/chromium/CrossProcessFontLoading.mm:
        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::fontContainsCharacter):
        (WebCore::FillLogFont):
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::scriptFontProperties):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::querySystemForRenderStyle):
        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillBMPGlyphs):
        * platform/graphics/chromium/ImageChromium.cpp:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/ImageChromiumMac.mm:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
        (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        * platform/network/chromium/DNSChromium.cpp:
        (WebCore::prefetchDNS):
        * platform/qt/PlatformBridge.h:
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
        (WebCore::SQLiteFileSystem::deleteDatabaseFile):
        (WebCore::SQLiteFileSystem::getDatabaseFileSize):
        * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
        (chromiumOpen):
        (chromiumDelete):
        (chromiumAccess):
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
        * plugins/chromium/PluginDataChromium.cpp:
        (WebCore::PluginCache::plugins):
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumWin::systemColor):
        (WebCore::RenderThemeChromiumWin::paintButton):
        (WebCore::RenderThemeChromiumWin::paintSliderTrack):
        (WebCore::menuListButtonWidth):
        (WebCore::RenderThemeChromiumWin::paintMenuList):
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
        (WebCore::IDBFactoryBackendInterface::create):
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBKeyPathBackendImpl.cpp:
        (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2011-01-21  Adam Klein  <adamk@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Rename ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52471

        * WebKit.gyp:
        * src/AssertMatchingEnums.cpp:
        * src/PlatformBridge.cpp:
        (WebCore::toChromeClientImpl):
        (WebCore::toWebWidgetClient):
        (WebCore::getCookieJar):
        (WebCore::PlatformBridge::cacheMetadata):
        (WebCore::PlatformBridge::clipboardIsFormatAvailable):
        (WebCore::PlatformBridge::clipboardReadPlainText):
        (WebCore::PlatformBridge::clipboardReadHTML):
        (WebCore::PlatformBridge::clipboardWriteSelection):
        (WebCore::PlatformBridge::clipboardWritePlainText):
        (WebCore::PlatformBridge::clipboardWriteURL):
        (WebCore::PlatformBridge::clipboardWriteImage):
        (WebCore::PlatformBridge::clipboardWriteData):
        (WebCore::PlatformBridge::clipboardReadAvailableTypes):
        (WebCore::PlatformBridge::clipboardReadData):
        (WebCore::PlatformBridge::clipboardReadFilenames):
        (WebCore::PlatformBridge::setCookies):
        (WebCore::PlatformBridge::cookies):
        (WebCore::PlatformBridge::cookieRequestHeaderFieldValue):
        (WebCore::PlatformBridge::rawCookies):
        (WebCore::PlatformBridge::deleteCookie):
        (WebCore::PlatformBridge::cookiesEnabled):
        (WebCore::PlatformBridge::prefetchDNS):
        (WebCore::PlatformBridge::fileExists):
        (WebCore::PlatformBridge::deleteFile):
        (WebCore::PlatformBridge::deleteEmptyDirectory):
        (WebCore::PlatformBridge::getFileSize):
        (WebCore::PlatformBridge::revealFolderInOS):
        (WebCore::PlatformBridge::getFileModificationTime):
        (WebCore::PlatformBridge::directoryName):
        (WebCore::PlatformBridge::pathByAppendingComponent):
        (WebCore::PlatformBridge::makeAllDirectories):
        (WebCore::PlatformBridge::getAbsolutePath):
        (WebCore::PlatformBridge::isDirectory):
        (WebCore::PlatformBridge::filePathToURL):
        (WebCore::PlatformBridge::openFile):
        (WebCore::PlatformBridge::closeFile):
        (WebCore::PlatformBridge::seekFile):
        (WebCore::PlatformBridge::truncateFile):
        (WebCore::PlatformBridge::readFromFile):
        (WebCore::PlatformBridge::writeToFile):
        (WebCore::PlatformBridge::ensureFontLoaded):
        (WebCore::PlatformBridge::getFontFamilyForCharacters):
        (WebCore::PlatformBridge::getRenderStyleForStrike):
        (WebCore::PlatformBridge::loadFont):
        (WebCore::PlatformBridge::databaseOpenFile):
        (WebCore::PlatformBridge::databaseDeleteFile):
        (WebCore::PlatformBridge::databaseGetFileAttributes):
        (WebCore::PlatformBridge::databaseGetFileSize):
        (WebCore::PlatformBridge::idbFactory):
        (WebCore::PlatformBridge::idbShutdown):
        (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
        (WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
        (WebCore::PlatformBridge::computedDefaultLanguage):
        (WebCore::PlatformBridge::layoutTestMode):
        (WebCore::PlatformBridge::isSupportedImageMIMEType):
        (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
        (WebCore::PlatformBridge::isSupportedNonImageMIMEType):
        (WebCore::PlatformBridge::mimeTypeForExtension):
        (WebCore::PlatformBridge::mimeTypeFromFile):
        (WebCore::PlatformBridge::preferredExtensionForMIMEType):
        (WebCore::PlatformBridge::plugins):
        (WebCore::PlatformBridge::pluginScriptableObject):
        (WebCore::PlatformBridge::loadPlatformImageResource):
        (WebCore::PlatformBridge::loadPlatformAudioResource):
        (WebCore::PlatformBridge::decodeAudioFileData):
        (WebCore::PlatformBridge::sandboxEnabled):
        (WebCore::PlatformBridge::setSharedTimerFiredFunction):
        (WebCore::PlatformBridge::setSharedTimerFireTime):
        (WebCore::PlatformBridge::stopSharedTimer):
        (WebCore::PlatformBridge::decrementStatsCounter):
        (WebCore::PlatformBridge::incrementStatsCounter):
        (WebCore::PlatformBridge::histogramCustomCounts):
        (WebCore::PlatformBridge::histogramEnumeration):
        (WebCore::PlatformBridge::suddenTerminationChanged):
        (WebCore::PlatformBridge::currentTime):
        (WebCore::PlatformBridge::paintButton):
        (WebCore::PlatformBridge::paintMenuList):
        (WebCore::PlatformBridge::paintScrollbarArrow):
        (WebCore::PlatformBridge::paintScrollbarThumb):
        (WebCore::PlatformBridge::paintScrollbarTrack):
        (WebCore::PlatformBridge::paintSpinButton):
        (WebCore::PlatformBridge::paintTextField):
        (WebCore::PlatformBridge::paintTrackbar):
        (WebCore::PlatformBridge::paintProgressBar):
        (WebCore::WebThemePart):
        (WebCore::WebThemeState):
        (WebCore::GetWebThemeExtraParams):
        (WebCore::PlatformBridge::getThemePartSize):
        (WebCore::PlatformBridge::paintThemePart):
        (WebCore::PlatformBridge::traceEventBegin):
        (WebCore::PlatformBridge::traceEventEnd):
        (WebCore::PlatformBridge::visitedLinkHash):
        (WebCore::PlatformBridge::isLinkVisited):
        (WebCore::PlatformBridge::notifyJSOutOfMemory):
        (WebCore::PlatformBridge::memoryUsageMB):
        (WebCore::PlatformBridge::actualMemoryUsageMB):
        (WebCore::PlatformBridge::screenDepth):
        (WebCore::PlatformBridge::screenDepthPerComponent):
        (WebCore::PlatformBridge::screenIsMonochrome):
        (WebCore::PlatformBridge::screenRect):
        (WebCore::PlatformBridge::screenAvailableRect):
        (WebCore::PlatformBridge::popupsAllowed):
        (WebCore::WorkerContextProxy::create):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandle::cacheMetadata):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::WebFrameImpl):
        (WebKit::WebFrameImpl::~WebFrameImpl):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Split Host object off from WebKitPatch for easier re-use
        https://bugs.webkit.org/show_bug.cgi?id=52284

        new-run-webkit-tests and other tools are eventually going to want one of these.
        Basically you need to inherit from this class if you want to pretend to be a
        self.tool object for Steps/Commands.

        * Scripts/webkitpy/common/host.py: Added.
        * Scripts/webkitpy/tool/main.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] svg/css/text-gradient-shadow.svg needs expected results
        https://bugs.webkit.org/show_bug.cgi?id=52724

        * platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
        * platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76335.
        http://trac.webkit.org/changeset/76335
        https://bugs.webkit.org/show_bug.cgi?id=52875

        profiler tests were broken (Requested by loislo on #webkit).

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
        (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
        https://bugs.webkit.org/show_bug.cgi?id=52870

        Call setTimeout from "load" event listener to make sure exception in the setTimeout
        callback happens after the one in the listener.

        * platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
        * platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
        * userscripts/window-onerror-for-isolated-world-1-expected.txt:
        * userscripts/window-onerror-for-isolated-world-1.html:
        * userscripts/window-onerror-for-isolated-world-2-expected.txt:
        * userscripts/window-onerror-for-isolated-world-2.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

        There are some places in WebCore where we still using direct InspectorController calls.
        The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
        Inspector facade for WebCore.

        https://bugs.webkit.org/show_bug.cgi?id=52869

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addProfileImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addProfile):
        (WebCore::InspectorInstrumentation::profilerEnabled):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Maciej Stachowiak.

        Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.

        * wtf/OwnArrayPtr.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Skip a few more tests that are failing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=52865

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Oliver Hunt.

        [WINCE] Remove obsolete JSVALUE32 code
        https://bugs.webkit.org/show_bug.cgi?id=52450

        Remove the "offset hack" in create_jit_stubs, since we
        only support JSVALUE32_64 in the meantime.

        * create_jit_stubs: Removed offset argument
        * jit/JITStubs.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        When marking conservatively, guard against reviving dead objects.
        https://bugs.webkit.org/show_bug.cgi?id=52840

        SunSpider and v8 say no change.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.

        * runtime/Heap.cpp:
        (JSC::Heap::recordExtraCost): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        (JSC::Heap::markConservatively):
        (JSC::Heap::markProtectedObjects):
        (JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
        marking function. We want to establish a separation of concerns between
        visiting roots and draining the mark stack.

        (JSC::Heap::markRoots): Gather the set of conservative references before
        clearning mark bits, because conservative marking now uses the mark bits
        to determine if a reference is valid, and avoid reviving dead objects.

        (JSC::Heap::collectAllGarbage): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        * runtime/Heap.h: Updated to use the ConservativeSet API.

        * runtime/MachineStackMarker.cpp:
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markCurrentThreadConservatively):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        (JSC::MachineStackMarker::markMachineStackConservatively):
        * runtime/MachineStackMarker.h: Ditto.

        * runtime/MarkStack.h:
        (JSC::ConservativeSet::add):
        (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the
        set of conservative references. This is different from MarkStack, since
        we don't mark the set until it is completely gathered.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::freeBlock):
        (JSC::MarkedSpace::resizeBlocks):
        (JSC::MarkedSpace::markConservatively):
        * runtime/MarkedSpace.h: When marking conservatively, guard against
        reviving dead objects.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix failing tests from r76291.

Reviewed by Gavin Barraclough.

* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::updateScrollbars):
Take the scroll origin into account in more places.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Kent Tamura  <tkent@chromium.org>

        Unreviewed, sorting an Xcode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Fix the review tool for image diffs. We would get a javascript error
        because image diffs don't have line numbers.

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Not reviewed, add a bug number to disabled test.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Disable the tests that start and stop the http server and web
        server, so that we don't have to worry about port collisions on
        the bots.

        https://bugs.webkit.org/show_bug.cgi?id=52861

        * Scripts/webkitpy/layout_tests/port/port_testcase.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Skip some tests that are failing on the WebKit2 bot
        https://bugs.webkit.org/show_bug.cgi?id=52858

        * platform/mac-wk2/Skipped: skip or re-skip some tests that fail
        on the bot for various reasons.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ben Vanik  <ben.vanik@gmail.com>

        Reviewed by Kenneth Russell.

        Implementation of the OES_standard_derivatives WebGL extension.
        https://bugs.webkit.org/show_bug.cgi?id=51678

        Changes are modeled off of the existing OESTextureFloat extension. New files,
        extension retrieval, etc all match the existing code.

        Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader compiler
        options. This supports the enabling of the standard derivatives flag when the
        extension is enabled. Refactored the cleanup code to make the destruction of the
        compilers (if they had been created) cleaner.

        Tested with the WebGL conformance test:
        https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-standard-derivatives.html
        Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::toV8Object):
        * html/canvas/OESStandardDerivatives.cpp: Added.
        (WebCore::OESStandardDerivatives::OESStandardDerivatives):
        (WebCore::OESStandardDerivatives::~OESStandardDerivatives):
        (WebCore::OESStandardDerivatives::getName):
        (WebCore::OESStandardDerivatives::create):
        * html/canvas/OESStandardDerivatives.h: Added.
        * html/canvas/OESStandardDerivatives.idl: Added.
        * html/canvas/WebGLExtension.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getExtension): Enable and return the new extension.
        (WebCore::WebGLRenderingContext::getParameter): Support extension enum when enabled.
        (WebCore::WebGLRenderingContext::getSupportedExtensions):
        (WebCore::WebGLRenderingContext::hint): Validate extension enum when enabled.
        (WebCore::WebGLRenderingContext::getNumberOfExtensions):
        (WebCore::WebGLRenderingContext::getExtensionNumber):
        * html/canvas/WebGLRenderingContext.h:
        * platform/graphics/ANGLEWebKitBridge.cpp:
        (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Cleaned up compiler cleanup.
        (WebCore::ANGLEWebKitBridge::cleanupCompilers): Destruct compilers.
        (WebCore::ANGLEWebKitBridge::setResources): Cleanup existing compilers when changing
        ANGLE settings.
        (WebCore::ANGLEWebKitBridge::validateShaderSource): Cleaned up compiler cleanup on error.
        * platform/graphics/ANGLEWebKitBridge.h:
        (WebCore::ANGLEWebKitBridge::getResources):
        * platform/graphics/Extensions3D.h: Added enumeration for the extension.
        * platform/graphics/GraphicsContext3D.h: lumbing for GraphicsContext3D.
        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
        (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Plumbed through a pointer to the
        GraphicsContext3D to handle resetting the shader compilers.
        (WebCore::Extensions3DOpenGL::supports): Desktop GL always supports this extension,
        so always return true.
        (WebCore::Extensions3DOpenGL::ensureEnabled): Reset shader compilers as required.
        * platform/graphics/opengl/Extensions3DOpenGL.h: Plumbing for GraphicsContext3D.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::getExtensions): Plumbing for GraphicsContext3D to
        Extensions3DOpenGL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        nrwt: rewrite google_chrome_unittest to use mock filesystem.

        https://bugs.webkit.org/show_bug.cgi?id=52772

        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Siedel.

        nrwt: clean up almost all remaining port references, remove
        unnecessary import clauses. The only remaining references are
        in places where a mock filesystem makes no sense or can't be
        used, and in one routine in port/google_chrome_unittest that
        I'll rewrite in a separate patch.

        https://bugs.webkit.org/show_bug.cgi?id=52771

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests

        https://bugs.webkit.org/show_bug.cgi?id=52762

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed Qt Skipped list update.

Skip the test added in r76296 for platform/qt/.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix regression(r71566): PDF in RTL block might messes up text directionality.
        https://bugs.webkit.org/show_bug.cgi?id=52776

        Test: fast/dom/52776.html

        * platform/text/BidiResolver.h:
        (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
        (WebCore::::lowerExplicitEmbeddingLevel):
        (WebCore::::raiseExplicitEmbeddingLevel):
        (WebCore::::createBidiRunsForLine):
2011-01-20  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix regression(r71566): PDF in RTL block might messes up text directionality.
        https://bugs.webkit.org/show_bug.cgi?id=52776

        * fast/dom/52776.html: Added.
        * platform/mac/fast/dom/52776-expected.checksum: Added.
        * platform/mac/fast/dom/52776-expected.png: Added.
        * platform/mac/fast/dom/52776-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Follow-on for <rdar://problem/8890255>

Reviewed by Anders Carlsson.

This fixes a painting error with ScrollbarPainter scrollers
and the new drawing area code path.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Updating test expectations after fixing the bug:
https://bugs.webkit.org/show_bug.cgi?id=52062

Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-20
Reviewed by Dmitry Titov.

* platform/chromium/test_expectations.txt:
iframe-reparenting-plugins.html is now passing on Windows.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, rebaseline a test added in
        http://trac.webkit.org/changeset/76274

        * platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
        * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
        * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
        * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Levi Weintraub  <leviw@chromium.org>

        Unreviewed.

        Fixing build breakage.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::willBeModified):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] fix the paths used for the rebaseline tool
        https://bugs.webkit.org/show_bug.cgi?id=52857

        Some of the bots were renamed so the path to grab the results zip
        file has changed.

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Smaller debug symbol size when using RVCT 4.x
        https://bugs.webkit.org/show_bug.cgi?id=52835

        * WebKit.pri: Use --remove_unneeded_entities for RVCT 4.x compilers

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
        https://bugs.webkit.org/show_bug.cgi?id=49511

        Test: editing/selection/rtl-move-selection-right-left.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::willBeModified):
        Respecting the direction of the containing block when switching selection base and extent in
        RTL content.

        (WebCore::SelectionController::modifyMovingRight):
        (WebCore::SelectionController::modifyMovingLeft):
        Using directionOfEnclosingBlock when deciding to use the selection start or end to do the
        correct thing for RTL.
2011-01-20  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
        https://bugs.webkit.org/show_bug.cgi?id=49511

        * editing/editing.js:
        (execMoveSelectionLeftByCharacterCommand):
        (moveSelectionLeftByCharacterCommand):
        (execMoveSelectionRightByCharacterCommand):
        (moveSelectionRightByCharacterCommand):
        (execExtendSelectionLeftByCharacterCommand):
        (extendSelectionLeftByCharacterCommand):
        (execExtendSelectionRightByCharacterCommand):
        (extendSelectionRightByCharacterCommand):
        Adding some left/right selection convenience methods for use with RTL tests.

        * editing/selection/rtl-move-selection-right-left-expected.txt: Added.
        * editing/selection/rtl-move-selection-right-left.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        Fix bug introduced in r72688 / bug 52768 that broke the
        generation of the output filename links in the results.html
        output. Apparently none of the unit tests actually checked to
        make sure the generated links were correct :(

        https://bugs.webkit.org/show_bug.cgi?id=52854

        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Oliver Hunt.

        Could review tool include style failure info?
        https://bugs.webkit.org/show_bug.cgi?id=49049

        This does not handle patches that have old paths (e.g. without the Source prefix).
        Although that would be fairly straightforward to workaround.

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, mark some rtl scrolling tests as failing to green the chromium bots.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=52849
        Make window.print work with WebKit2

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::printFrame):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::printFrame):
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::print):
        Just pass through deelagte call to a WebKit2 client.

        * UIProcess/API/C/WKPage.h: Also added "Callback" suffix to other printing related function
        types.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Keep track of the latest update timestamp in the backing store
        https://bugs.webkit.org/show_bug.cgi?id=52848

        * Shared/UpdateInfo.h:
        (WebKit::UpdateInfo::UpdateInfo):
        Initialize timestamp to 0.

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::BackingStore):
        Initialize m_latestUpdateTimestamp to 0.

        (WebKit::BackingStore::incorporateUpdate):
        If the update is too old, discard it. Otherwise, create a bitmap
        and pass it to platformIncorporateUpdate. Finally update the timestamp.

        * UIProcess/BackingStore.h:
        Add m_latestUpdateTimestamp.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::platformIncorporateUpdate):
        Update now that we are already given the shareable bitmap.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, chromium test expectation updates.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Test for https://bugs.webkit.org/show_bug.cgi?id=52769.

        * fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
        * fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
        * fast/dom/Window/Location/set-location-after-close.html: Added.
2011-01-20  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Null-check m_frame in DOMWindow::setLocation(), since it's
        possible to reach this point without it having been checked
        already.
        https://bugs.webkit.org/show_bug.cgi?id=52769

        Test: fast/dom/Window/Location/set-location-after-close.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setLocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        handle cases where PrettyPatch.rb doesn't linkify filenames
        https://bugs.webkit.org/show_bug.cgi?id=52834

        * code-review.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        setContentEditable with invalid string should throw exception.
        https://bugs.webkit.org/show_bug.cgi?id=52057

        Updated expected results after the fix. Also corrected test cases.

        * editing/editability/set-invalid-value-expected.txt:
        * editing/editability/set-invalid-value.html: 1. Fixed the getAttribute expectation as "abc" was failed to set. 2. Added additional check for setting empty string.
        * editing/editability/set-value-caseinsensitive-expected.txt:
        * editing/editability/set-value-caseinsensitive.html: Fixed the getAttribute expectations as all strings should be converted to lower cases.
        * fast/dom/element-attribute-js-null-expected.txt:
        * fast/dom/element-attribute-js-null.html: Fixed this existing test as the expectation for setting with null should throw exception instead of "false". Also added handling code when exception was thrown.
2011-01-20  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        setContentEditable with invalid string should throw exception.
        https://bugs.webkit.org/show_bug.cgi?id=52057

        Implemented exception throwing for setContentEditable according to the following spec:
        http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
        Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
        string 'inherit' then the content attribute must be removed, if the new value is an ASCII
        case-insensitive match for the string 'true' then the content attribute must be set to the
        string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
        then the content attribute must be set to the string 'false', and otherwise the attribute
        setter must raise a SYNTAX_ERR exception."

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
        * html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
        * html/HTMLElement.idl: Add exception throwing support for contentEditable setter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Shift-tab doesn't cycle through fields in http authentication panel
https://bugs.webkit.org/show_bug.cgi?id=52850

Reviewed by Mark Rowe.

* Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
* Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
Re-wired the key loop so that there aren't two views with the same nextKeyView.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Add a test for a render surface that the uses alpha channel.
        https://bugs.webkit.org/show_bug.cgi?id=52766

        * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.checksum: Added.
        * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
        * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
        * platform/chromium/compositing/render-surface-alpha-blending.html: Added.
2011-01-19  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Composited render surfaces should allow writes to alpha channel.
        https://bugs.webkit.org/show_bug.cgi?id=52766

        Test: LayoutTests/platform/chromium/compositing

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Geoffrey Garen.

        [Symbian] Fix StackBounds::initialize()
        https://bugs.webkit.org/show_bug.cgi?id=52842

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-14  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION (r71842): Compass video is not playing in Safari welcome page
        https://bugs.webkit.org/show_bug.cgi?id=52506

        Test that a delay between loading and playing video does not break playback.

        * media/video-currentTime-delay-expected.txt: Added.
        * media/video-currentTime-delay.html: Added.
2011-01-14  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION (r71842): Compass video is not playing in Safari welcome page
        https://bugs.webkit.org/show_bug.cgi?id=52506

        New test: LayoutTests/media/video-currentTime-delay.html

        Call invalidateCachedTime() every time one of the cached property dependencies changes,
        i.e. m_paused and m_playbackRate.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::prepareForLoad):
        (WebCore::HTMLMediaElement::setReadyState):
        (WebCore::HTMLMediaElement::setPlaybackRate):
        (WebCore::HTMLMediaElement::mediaPlayerRateChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix build.

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Adam Klein  <adamk@chromium.org>

        Reviewed by Andreas Kling.

        [chromium] Remove deprecated WebKit::nameOfInputElement function
        https://bugs.webkit.org/show_bug.cgi?id=52824

        * src/DOMUtilitiesPrivate.cpp:
        * src/DOMUtilitiesPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix build.

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix for <rdar://problem/8890255>

Reviewed by Geoffrey Garen.

Source/WebCore:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.
* WebCore.exp.in:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Cleanup Scrollbar/ScrollbarClient relationship
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Dave Hyatt.

Source/WebCore:

Pipe all scrolling through the ScrollbarClient/ScrollAnimator
rather than through the Scrollbar. The Scrollbar now is just
a "view" on the scroll position of the scrollable area it is
attached to.

There are now two ways to scroll a scrollable area:
- ScrollbarClient::scroll()
- ScrollbarClient::scrollToOffsetWithoutAnimation()

Both of these go through the ScrollAnimator (updating its state
or starting an animation). The ScrollAnimator, in turn, now calls
ScrollbarClient::setScrollOffsetFromAnimation, which tells the
Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
and tells the class that derives from ScrollbarClient to scroll
its contents (via ScrollbarClient::setScrollOffset).

* WebCore.xcodeproj/project.pbxproj:
Move Scrollbar.cpp to the right place.

* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
Initiate the scroll through the scrollbar client, rather than the
scrollbar itself.

* page/FrameView.cpp:
(WebCore::FrameView::scrollTo):
* page/FrameView.h:
Condense the two valueChanged overrides to a single override of the
scrollTo function.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::currentPosition):
(WebCore::ScrollAnimator::notityPositionChanged):
* platform/ScrollAnimator.h:
* platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):
* platform/ScrollAnimatorWin.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
and bottleneck all client notification of changed position through a new
notityPositionChanged() function.

* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

* platform/Scrollbar.cpp:
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
* platform/Scrollbar.h:
(WebCore::Scrollbar::setPressedPos):
Change the scrollbar to only updates its offset in response to
an offsetDidChange call.

* platform/ScrollbarClient.cpp:
(WebCore::ScrollbarClient::scroll):
(WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollbarClient::setScrollOffsetFromAnimation):
* platform/ScrollbarClient.h:
(WebCore::ScrollbarClient::horizontalScrollbar):
(WebCore::ScrollbarClient::verticalScrollbar):
Make the increasingly misnamed ScrollbarClient responsible for
scrolling.

* platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
Update to move scrolling through the client.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollPosition):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollTo):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h:
(WebCore::PopupMenuWin::verticalScrollbar):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setScrollOffset):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::scroll):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::scrollTo):
(WebCore::RenderListBox::setScrollTop):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
Simplify initial paint to just do an immediate scroll to the position.

Source/WebKit/chromium:

* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseDown):
(WebKit::WebScrollbarImpl::onMouseMove):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
(WebKit::WebScrollbarImpl::scrollPosition):
(WebKit::WebScrollbarImpl::setScrollOffset):
* src/WebScrollbarImpl.h:

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

Source/WebKit/win:

* WebScrollBar.cpp:
(WebScrollBar::WebScrollBar):
(WebScrollBar::setValue):
(WebScrollBar::value):
(WebScrollBar::scroll):
(WebScrollBar::scrollPosition):
(WebScrollBar::setScrollOffset):
* WebScrollBar.h:

Source/WebKit2:

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::scrollPosition):
(WebKit::WebPopupMenuProxyWin::setScrollOffset):
(WebKit::WebPopupMenuProxyWin::scrollTo):
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
* UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::verticalScrollbar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectations fix.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, another attempt at making the chromium gpu tests go green.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff

        https://bugs.webkit.org/show_bug.cgi?id=52756

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  James Robinson  <jamesr@chromium.org>

        Update expectations for tests that need chromium-side changes.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>

        Reviewed by Antonio Gomes.

        QtTestBrowser should have a seperate menu for Settings
        https://bugs.webkit.org/show_bug.cgi?id=52817

        Added a new menu item named "Settings"
        and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add a timestamp to UpdateInfo
        https://bugs.webkit.org/show_bug.cgi?id=52844

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        * Shared/UpdateInfo.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setSize):
        (WebKit::DrawingAreaImpl::display):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update.

        Merged test_expectations.txt in the Chromium tree and
        added slow to fast/text/large-text-composed-char-dos.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, updating gpu expectations.
        These two tests were added to the regular chromiumg test_expectations.txt
        in r76228.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r76170.

        * platform/graphics/wince/FontWinCE.cpp: Added a missing include.
        * platform/graphics/wince/ImageBufferData.h: Added a missing include and fixed style.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Update update-webkit-localizable-strings with new path to WebKit.

Reviewed by John Sullivan.

* Scripts/update-webkit-localizable-strings:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Beth Dakin.

        Add Connection::waitForAndDispatchImmediately
        https://bugs.webkit.org/show_bug.cgi?id=52841

        * Platform/CoreIPC/Connection.h:
        (CoreIPC::Connection::waitForAndDispatchImmediately):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Another Chromium rebaseline for r76236.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        Tests for window.webkitRequestAnimationFrame().  The new tests
        are in the Skipped lists for platforms that do not set
        ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.

        * fast/animation/request-animation-frame-cancel-expected.txt: Added.
        * fast/animation/request-animation-frame-cancel.html: Added.
            Tests cancelling a callback within a webkitRequestAnimationFrame() callback.
        * fast/animation/request-animation-frame-cancel2-expected.txt: Added.
        * fast/animation/request-animation-frame-cancel2.html: Added.
            Tests interactions between multiple webkitRequestAnimationFrame() callbacks.
        * fast/animation/request-animation-frame-display-expected.txt: Added.
        * fast/animation/request-animation-frame-display.html: Added.
            Tests changing the display: property of an element within a callback.
        * fast/animation/request-animation-frame-expected.txt: Added.
        * fast/animation/request-animation-frame.html: Added.
            Tests the basic use of window.webkitRequestAnimationFrame().
        * fast/animation/request-animation-frame-within-callback-expected.txt: Added.
        * fast/animation/request-animation-frame-within-callback.html: Added.
            Tests setting one webkit.webkitRequestAnimationFrame() callback within another.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        This implements mozilla's proposed requestAnimationFrame API.  The idea with this API is that
        an author driving an animation from script could use window.requestAnimationFrame(callback)
        instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
        decide when to update the animations.  This avoids doing unnecessary work when the page content
        is offscreen or is being displayed at a different framerate than what the page author expects.

        Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
        This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
        following changes:
        *) Only the callback syntax is supported, there is no before paint event
        *) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate
            what content they intend to animate.  That way if the page is being displayed but the element
            in question is offscreen, we can avoid invoking the callback.
        *) No timestamp is provided to the caller and there is no window.animationStartTime property
            (see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)
        *) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback
            using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().

        The implementation depends on the embedder scheduling the callbacks since the callback invocation
        depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
        to WebCore.  The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
        called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
        Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
        embedder has to rate limit callbacks and may not be able to tie the callback directly to the
        rendering loop.

        Tests: fast/animation/request-animation-frame-cancel.html
               fast/animation/request-animation-frame-cancel2.html
               fast/animation/request-animation-frame-display.html
               fast/animation/request-animation-frame-within-callback.html
               fast/animation/request-animation-frame.html

        * WebCore.gypi:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::webkitRequestAnimationFrame):
        (WebCore::Document::webkitCancelRequestAnimationFrame):
        (WebCore::Document::serviceScriptedAnimations):
        * dom/Document.h:
        * dom/RequestAnimationFrameCallback.h: Added.
        (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
        * dom/RequestAnimationFrameCallback.idl: Added.
        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::scheduleAnimation):
        * page/Chrome.cpp:
        (WebCore::Chrome::scheduleAnimation):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitRequestAnimationFrame):
        (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleAnimation):
        (WebCore::FrameView::serviceScriptedAnimations):
        * page/FrameView.h:
        * platform/HostWindow.h:
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        Chromium WebKit API support for window.webkitRequestAnimationFrame()

        * features.gypi:
        * public/WebWidget.h:
        * public/WebWidgetClient.h:
        (WebKit::WebWidgetClient::scheduleAnimation):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::scheduleAnimation):
        * src/ChromeClientImpl.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::animate):
        (WebKit::WebPopupMenuImpl::scheduleAnimation):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::animate):
        * src/WebViewImpl.h:
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (invokeScheduleComposite):
        (WebViewHost::scheduleAnimation):
        (WebViewHost::paintInvalidatedRegion):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Nate Chapin.

        [v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters
        https://bugs.webkit.org/show_bug.cgi?id=52837

        When generating code to invoke a callback with no parameters CodeGeneratorV8.pm was generating the following:
        v8::Handle<v8::Value> argv[] = {}; which does not compile in visual studio.  Instead, if the argument count
        is 0, we can just pass a NULL pointer for the argv parameter.

        Test added to bindings/scripts/test/TestCallback.idl and covered by run-bindings-tests.  This
        patch also includes some spurious changes to the bindings tests golden files (mostly GObject)
        because the old golden files were out of date.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
        (WebDOMTestCallback::callbackWithNoParam):
        * bindings/scripts/test/CPP/WebDOMTestCallback.h:
        * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
        (webkit_dom_test_callback_callback_with_no_param):
        * bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
        * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        * bindings/scripts/test/JS/JSTestCallback.cpp:
        (WebCore::JSTestCallback::callbackWithNoParam):
        * bindings/scripts/test/JS/JSTestCallback.h:
        * bindings/scripts/test/JS/JSTestInterface.cpp:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        * bindings/scripts/test/ObjC/DOMTestCallback.h:
        * bindings/scripts/test/ObjC/DOMTestCallback.mm:
        (-[DOMTestCallback callbackWithNoParam]):
        * bindings/scripts/test/TestCallback.idl:
        * bindings/scripts/test/V8/V8TestCallback.cpp:
        (WebCore::V8TestCallback::callbackWithNoParam):
        * bindings/scripts/test/V8/V8TestCallback.h:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::reflectedUnsignedIntegralAttrAttrGetter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76277 268f45cc-cd09-0410-ab3c-d52691b4dbfc