WebKit.git
8 years agofont shorthand with inherit keyword incorrectly parsed and rendered
alexis.menard@openbossa.org [Tue, 14 Feb 2012 21:00:24 +0000 (21:00 +0000)]
font shorthand with inherit keyword incorrectly parsed and rendered
https://bugs.webkit.org/show_bug.cgi?id=20181

Reviewed by Tony Chang.

Source/WebCore:

As stated in http://www.w3.org/TR/CSS21/changes.html#q142
if the inherit (and also by extension initial) is encountered in the
middle of the shorthand then the property becomes invalid.

Test: fast/css/font-shorthand-mix-inherit.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):

LayoutTests:

* fast/css/font-shorthand-mix-inherit-expected.txt: Added.
* fast/css/font-shorthand-mix-inherit.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash due to incorrect firing of mutation event during class attribute parsing.
inferno@chromium.org [Tue, 14 Feb 2012 20:45:20 +0000 (20:45 +0000)]
Crash due to incorrect firing of mutation event during class attribute parsing.
https://bugs.webkit.org/show_bug.cgi?id=78537

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/class-attr-change-double-mutation-fire.html

* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):

LayoutTests:

* fast/dom/class-attr-change-double-mutation-fire-expected.txt: Added.
* fast/dom/class-attr-change-double-mutation-fire.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFinish implementing start_helper for ChromiumAndroidPort
abarth@webkit.org [Tue, 14 Feb 2012 20:29:14 +0000 (20:29 +0000)]
Finish implementing start_helper for ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78582

Reviewed by Eric Seidel.

This patch contains the remaining odds and ends for the start_helper function.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._synchronize_datetime):
(ChromiumAndroidPort):
(ChromiumAndroidPort._check_version):
(ChromiumAndroidPort._run_adb_command):
(ChromiumAndroidPort._copy_device_file):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS3 calc: add isZero implementations to catch divide by zero
mikelawther@chromium.org [Tue, 14 Feb 2012 20:22:03 +0000 (20:22 +0000)]
CSS3 calc: add isZero implementations to catch divide by zero
https://bugs.webkit.org/show_bug.cgi?id=78603

Reviewed by Ojan Vafai.

Source/WebCore:

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::isZero):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcBinaryOperation::isZero):
(CSSCalcBinaryOperation):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):

LayoutTests:

* css3/calc/calc-errors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, marking a perf test as slow in debug and two
tony@chromium.org [Tue, 14 Feb 2012 20:15:43 +0000 (20:15 +0000)]
[chromium] Unreviewed, marking a perf test as slow in debug and two
gpu tests as failing in debug (different scrollbar rendering).

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Expose perTilePainting setting through WebLayerTreeView::Settings interface.
commit-queue@webkit.org [Tue, 14 Feb 2012 20:13:14 +0000 (20:13 +0000)]
[Chromium] Expose perTilePainting setting through WebLayerTreeView::Settings interface.
https://bugs.webkit.org/show_bug.cgi?id=76937

Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Add perTilePainting to WebLayerTreeView::Settings.

* public/platform/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Layout Test media/media-document-audio-repaint.html is flaky
fischman@chromium.org [Tue, 14 Feb 2012 20:11:52 +0000 (20:11 +0000)]
[chromium] Layout Test media/media-document-audio-repaint.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76580

Reviewed by James Robinson.

Make sure to call layoutTestController.display() at a stable point
(namely when the media element is paused) so that any subsequent GPU
disabling doesn't cause a complete redraw (and the test to be
flaky).

* media/media-document-audio-repaint.html:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove inspector/protocol/page-agent.html since it is inherently flaky.
timothy@apple.com [Tue, 14 Feb 2012 19:42:05 +0000 (19:42 +0000)]
Remove inspector/protocol/page-agent.html since it is inherently flaky.

Filed https://webkit.org/b/78621 about devising a non-flaky test.

Unreviewed.

* inspector/protocol/page-agent-expected.txt: Removed.
* inspector/protocol/page-agent.html: Removed.
* inspector/protocol/resources/dummy-iframe.html: Removed.
* inspector/protocol/resources/empty.png: Removed.
* inspector/protocol/resources/font1.ttf: Removed.
* inspector/protocol/resources/font2.ttf: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Dragging a selection handle outside of the content bounding box does...
commit-queue@webkit.org [Tue, 14 Feb 2012 19:39:58 +0000 (19:39 +0000)]
[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608

Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not applying padding to
a direction that would cause the selection to shrink when performing
the handle direction detection.

Patch by Ed Baker <edbaker@rim.com> on 2012-02-14
Reviewed by Rob Buis.

* blackberry/WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):
* blackberry/WebKitSupport/SelectionHandler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: create ports in Workers, not in manager_worker_broker
dpranke@chromium.org [Tue, 14 Feb 2012 19:25:31 +0000 (19:25 +0000)]
webkitpy: create ports in Workers, not in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78565

Reviewed by Tony Chang.

We will now create the Port object (if necessary) in the Worker
directly, so that the manager_worker_broker module doesn't need
all of this layout_test-specific logic. Part of the fixes for
bug 78171.

These changes are all well-tested by the existing tests in
run_webkit_tests_integrationtest.py.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_Process.run):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(main): Fix a minor bug where running the 'mock-test' port didn't work right.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, mark some form tests as flaky.
tony@chromium.org [Tue, 14 Feb 2012 19:18:59 +0000 (19:18 +0000)]
[chromium] Unreviewed, mark some form tests as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream backing store related classes
rwlbuis@webkit.org [Tue, 14 Feb 2012 19:13:44 +0000 (19:13 +0000)]
[BlackBerry] Upstream backing store related classes
https://bugs.webkit.org/show_bug.cgi?id=78517

Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* blackberry/WebKitSupport/BackingStoreClient.cpp: Added.
* blackberry/WebKitSupport/BackingStoreClient.h: Added.
* blackberry/WebKitSupport/BackingStoreCompositingSurface.cpp: Added.
* blackberry/WebKitSupport/BackingStoreCompositingSurface.h: Added.
* blackberry/WebKitSupport/BackingStoreTile.cpp: Added.
* blackberry/WebKitSupport/BackingStoreTile.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Don't include CachedResources that haven't downloaded when populating...
timothy@apple.com [Tue, 14 Feb 2012 18:44:58 +0000 (18:44 +0000)]
Source/WebCore: Don't include CachedResources that haven't downloaded when populating the Web Inspector on load.

https://webkit.org/b/78447
rdar://problem/10843542

Reviewed by Brian Weinstein.

Test: inspector/protocol/page-agent.html

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourcesForFrame): Skip CachedFonts and CachedImages that
return true for stillNeedsLoad.
* loader/cache/CachedFont.h:
(WebCore::CachedFont::stillNeedsLoad): Added.

LayoutTests: Updated test results to exclude CachedResources that haven't downloaded.

https://webkit.org/b/78447
rdar://problem/10843542

Reviewed by Brian Weinstein.

* inspector/protocol/page-agent-expected.txt: Updated. There is now only one font list
in the resources, when there was incorrectly two being listed. Only the font being used
is the one that downloaded and is listed now.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Web Inspector: include failed and canceled in FrameResourceTree.
timothy@apple.com [Tue, 14 Feb 2012 18:44:47 +0000 (18:44 +0000)]
Source/WebCore: Web Inspector: include failed and canceled in FrameResourceTree.

https://webkit.org/b/78445

Reviewed by Pavel Feldman.

Test: inspector/protocol/page-agent.html

* WebCore.xcodeproj/project.pbxproj: Added Inspector.json, Inspector-0.1.json and Inspector-1.0.json
for quick access and easy editing.
* inspector/Inspector.json: Added failed and canceled as optional properties to the object for resources in FrameResourceTree.
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrameTree): Set those properties.

LayoutTests: Test for Web Inspector: include failed and canceled in FrameResourceTree.

https://webkit.org/b/78445

Reviewed by Pavel Feldman.

* inspector/protocol/page-agent-expected.txt: Added.
* inspector/protocol/page-agent.html: Added.
* inspector/protocol/resources/dummy-iframe.html: Added.
* inspector/protocol/resources/empty.png: Added.
* inspector/protocol/resources/font1.ttf: Added.
* inspector/protocol/resources/font2.ttf: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] fast/forms/implicit-submission.html fails
commit-queue@webkit.org [Tue, 14 Feb 2012 17:39:58 +0000 (17:39 +0000)]
[GTK] fast/forms/implicit-submission.html fails
https://bugs.webkit.org/show_bug.cgi?id=76632

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-14
Reviewed by Martin Robinson.

[Gtk] Rebaseline implicit-submission test expectations after r105253.

* platform/gtk/Skipped:
* platform/gtk/fast/forms/implicit-submission-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r107688 and skipping some new
philn@webkit.org [Tue, 14 Feb 2012 16:12:24 +0000 (16:12 +0000)]
Unreviewed, GTK rebaseline after r107688 and skipping some new
test failures.

* platform/gtk/Skipped:
* platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypo fix after r107707.
ossy@webkit.org [Tue, 14 Feb 2012 14:28:41 +0000 (14:28 +0000)]
Typo fix after r107707.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::updateBackingStore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel
caseq@chromium.org [Tue, 14 Feb 2012 14:24:59 +0000 (14:24 +0000)]
Web Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel
https://bugs.webkit.org/show_bug.cgi?id=78599

Reviewed by Pavel Feldman.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowResizeDragging):
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowMaximum):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelinePanel.WindowSelector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Make ScriptsNavigator default file selector.
vsevik@chromium.org [Tue, 14 Feb 2012 12:55:56 +0000 (12:55 +0000)]
Web Inspector: Make ScriptsNavigator default file selector.
https://bugs.webkit.org/show_bug.cgi?id=78349

Reviewed by Pavel Feldman.

Source/WebCore:

Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.

Tests: inspector/debugger/scripts-combobox-file-selector-history.html
       inspector/debugger/scripts-file-selector.html

* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):

Source/WebKit/chromium:

* src/js/Tests.js:
(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
(.TestSuite.prototype._scriptsAreParsed):
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
(initialize_DebuggerTest.):
* inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
* inspector/debugger/scripts-combobox-file-selector-history.html: Added.
* inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
* inspector/debugger/scripts-file-selector.html: Added.
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Texmap] Refactor backing-store code in TextureMapper
noam.rosenthal@nokia.com [Tue, 14 Feb 2012 12:53:30 +0000 (12:53 +0000)]
[Qt][Texmap] Refactor backing-store code in TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=78305

Source/WebCore:

Instead of dealing with tiling inside of TextureMapperNode, we now deal with that in a new
TextureMapperBackingStore class. Since the class is abstract, WebKit2 can overload it to
support remotely-managed tiles.
The backing-store for directly composited images is handled separately, in a new class
TextureMapperCompositedImage. The TextureMapper implementation decides the dimension of
the tiles, for example 2000 in the case of OpenGL.
Also, directly composited content is now handled correctly, by painting it after the regular
content and not as part of the same texture.

To make this work, the functions in TextureMapperPlatformLayers had to become non-const,
thus the changes to that file and GraphicsContext3DQt.

Reviewed by Kenneth Rohde Christiansen.

No new functionality, no new tests.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/opengl/TextureMapperGL.h:
(WebCore::TextureMapperGL::maxTextureDimension):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::getContentsLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::platformLayer):
(WebCore::GraphicsLayerTextureMapper::needsDisplay):
(WebCore::GraphicsLayerTextureMapper::needsDisplayRect):
* platform/graphics/texmap/TextureMapper.cpp:
* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::maxTextureDimension):
(TextureMapper):
* platform/graphics/texmap/TextureMapperBackingStore.cpp: Added.
* platform/graphics/texmap/TextureMapperBackingStore.h: Added.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::backingStore):
(WebCore::TextureMapperNode::updateBackingStore):
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::intermediateSurfaceRect):
(WebCore::TextureMapperNode::paintRecursive):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(WebCore::TextureMapperNode::TextureMapperNode):
(TextureMapperNode):
(WebCore::TextureMapperNode::setBackingStore):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::layerRect):
(WebCore::TextureMapperNode::createBackingStore):
(State):
(WebCore::TextureMapperNode::State::State):
* platform/graphics/texmap/TextureMapperPlatformLayer.h:
(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::swapBuffers):

Source/WebKit2:

Move the backing-store code to LayerTreeBackingStore, implementing the virtual functions
in TextureMapperBackingStore.
We save the double-buffered tile in the backing-store, and then convert them to regular
tiles in updateContents, based on the order of painting.
Use TextureMapperCompositedImage for images instead of saving our own composited image
registry.

Reviewed by Kenneth Rohde Christiansen.

* Target.pri:
* UIProcess/LayerTreeHostProxy.h:
(WebKit):
(LayerTreeHostProxy):
* UIProcess/qt/LayerBackingStore.cpp: Added.
* UIProcess/qt/LayerBackingStore.h: Added.
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::createTile):
(WebKit::LayerTreeHostProxy::removeTile):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::assignImageToLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
* WebProcess.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse youngestShadowRoot and oldestShadowRoot instead of Element::shadowRoot().
commit-queue@webkit.org [Tue, 14 Feb 2012 12:48:24 +0000 (12:48 +0000)]
Use youngestShadowRoot and oldestShadowRoot instead of Element::shadowRoot().
https://bugs.webkit.org/show_bug.cgi?id=78455

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-14
Reviewed by Hajime Morita.

.:

Exports necessary symbols.

* Source/autotools/symbols.filter:

Source/WebCore:

Element::shadowRoot() was used for these 3 purposes.
1. checks a shadow root exists.
2. gets author shadow root.
3. gets user agent shadow root.

We have to distinguish them when implementing multiple shadow subtrees.

Calling for (1), (2), and (3) are convered to hasShadowRoot(),
ShadowRootList()->youngestShadowRoot(), and ShadowRootList()->oldestShadowRoot() respectively.

No new tests, no change in behavior.

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
* dom/Element.cpp:
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
(WebCore::Element::focus):
* dom/Element.h:
(Element):
* dom/EventDispatcher.cpp:
(WebCore::isShadowHost):
* dom/Node.cpp:
(WebCore::shadowRoot):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::insertedIntoDocument):
(WebCore):
(WebCore::ShadowRootList::removedFromDocument):
(WebCore::ShadowRootList::insertedIntoTree):
(WebCore::ShadowRootList::removedFromTree):
(WebCore::ShadowRootList::hostChildrenChanged):
(WebCore::ShadowRootList::attach):
(WebCore::ShadowRootList::detach):
* dom/ShadowRootList.h:
(ShadowRootList):
* dom/TreeScopeAdopter.cpp:
(WebCore::shadowRootFor):
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::deleteBubbleTree):
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):
* page/FocusController.cpp:
(WebCore::shadowRoot):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
* testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
(WebCore):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

Exports necesarry symbols.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElements panel needs to be able to preview images
apavlov@chromium.org [Tue, 14 Feb 2012 12:45:59 +0000 (12:45 +0000)]
Elements panel needs to be able to preview images
https://bugs.webkit.org/show_bug.cgi?id=21570

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.willHide):
(WebInspector.ElementsPanel.prototype._getPopoverAnchor):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode.dimensions):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode):
(WebInspector.ElementsPanel.prototype._showPopover.dimensionsCallback):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover.buildPopoverContents):
(WebInspector.ElementsPanel.prototype._showPopover):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._onmousemove):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.get g):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):
* inspector/front-end/elementsPanel.css:
(.image-preview-container):
(.image-preview-container img):

LayoutTests:

* inspector/elements/elements-img-tooltip-expected.txt:
* inspector/elements/elements-img-tooltip.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] check that we're not running multiple modal dialogs at the same time
jochen@chromium.org [Tue, 14 Feb 2012 12:36:08 +0000 (12:36 +0000)]
[chromium] check that we're not running multiple modal dialogs at the same time
https://bugs.webkit.org/show_bug.cgi?id=78486

Reviewed by Kent Tamura.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: List expansion arrows is pointing down even
pfeldman@chromium.org [Tue, 14 Feb 2012 12:01:14 +0000 (12:01 +0000)]
Web Inspector: List expansion arrows is pointing down even
when the list of eventListeners are hidden in the Elements tab
https://bugs.webkit.org/show_bug.cgi?id=78360

Reviewed by Timothy Hatcher.

* inspector/front-end/elementsPanel.css:
(.section .event-bar .header):
(.section .event-bars .event-bar .header .title):
(.section .event-bar .header .subtitle):
(.section .event-bar .header::before):
(.section .event-bar.expanded .header::before):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Tue, 14 Feb 2012 11:42:06 +0000 (11:42 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Typo fix, skip a new failing test.
* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Updated after r107688.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Tue, 14 Feb 2012 11:37:49 +0000 (11:37 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #7 of N.

* platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Removed.
* platform/chromium-win/fast/replaced/width100percent-image-expected.png:
* platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
hayato@chromium.org [Tue, 14 Feb 2012 11:32:12 +0000 (11:32 +0000)]
Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
https://bugs.webkit.org/show_bug.cgi?id=77514

Reviewed by Dimitri Glazkov.

NodeType.SHADOW_ROOT_NODE type is finally gone.

Source/WebCore:

* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/objc/DOM.mm:
(kitClass):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
* dom/Node.h:
* dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
* dom/ShadowRoot.cpp:
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::toShadowRoot):
* editing/FrameSelection.cpp:
(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
* html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

* fast/dom/shadow/nodetype-expected.txt:
* fast/dom/shadow/nodetype.html:
* resources/dump-as-markup.js:
(Markup._get):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStylePropertySet: Try to find a CSSValuePool for identifier values.
kling@webkit.org [Tue, 14 Feb 2012 11:01:30 +0000 (11:01 +0000)]
StylePropertySet: Try to find a CSSValuePool for identifier values.
<http://webkit.org/b/78590>

Reviewed by Antti Koivisto.

For StylePropertySets with a parent element (inline and attribute style),
grab at the parentElement()->document() to locate a CSSValuePool.
This code will change soon in the CSSOM refactoring and moreso once we
figure out how to have a global CSSValuePool, but I'm hoping it will buy
us some perf back in the meantime.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosvg/hixie/perf has different repaint region in debug vs release
zimmermann@webkit.org [Tue, 14 Feb 2012 10:54:15 +0000 (10:54 +0000)]
svg/hixie/perf has different repaint region in debug vs release
https://bugs.webkit.org/show_bug.cgi?id=78516

Reviewed by Hajime Morita.

Based on patch by Tony Chang <tony@chromium.org>.

The problem is the progress text in the lower right.  It says,
"Test in progress... X of 10".  Depending on how fast the test runs,
this text is never painted and the repaint region changes.  Disable
painting of the intermediate text and only include the final text.

Extended Tonys original patch to cover all svg/hixie/perf tests that
suffered from this issue - also avoid using setTimeout between the
individual steps, as we're only interessted in the final repaint
region, not the intermediate ones.

* platform/mac/svg/hixie/perf/001-expected.png:
* platform/mac/svg/hixie/perf/002-expected.png:
* platform/mac/svg/hixie/perf/003-expected.png:
* svg/hixie/perf/001.xml:
* svg/hixie/perf/002.xml:
* svg/hixie/perf/003.xml:
* svg/hixie/perf/004.xml:
* svg/hixie/perf/005.xml:
* svg/hixie/perf/006.xml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable the GPU codepath in the chromium-android port
abarth@webkit.org [Tue, 14 Feb 2012 10:41:03 +0000 (10:41 +0000)]
Enable the GPU codepath in the chromium-android port
https://bugs.webkit.org/show_bug.cgi?id=78580

Reviewed by James Robinson.

Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
Android always uses the GPU codepath, so we set the GPU flags on the
main chromium-android port instead.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNRWT should expose --adb-args flag for Android
abarth@webkit.org [Tue, 14 Feb 2012 10:38:54 +0000 (10:38 +0000)]
NRWT should expose --adb-args flag for Android
https://bugs.webkit.org/show_bug.cgi?id=78579

Reviewed by Eric Seidel.

This flag is already wired up to the ChromiumAndroidPort.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Inconsistent initialization of CCSettings in WebLayerTreeView.
commit-queue@webkit.org [Tue, 14 Feb 2012 10:35:58 +0000 (10:35 +0000)]
[Chromium] Inconsistent initialization of CCSettings in WebLayerTreeView.
https://bugs.webkit.org/show_bug.cgi?id=76927

Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.

Remove unnecessary initialization and include maxPartialTextureUpdates
in FIXME comment.

* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-02-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 14 Feb 2012 10:21:20 +0000 (10:21 +0000)]
2012-02-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add mixing Lion pixel test result for a svg/carto.net test.

        * platform/mac/svg/carto.net/scrollbar-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert svg/animations to use SMIL methods for driving the timeline
zimmermann@webkit.org [Tue, 14 Feb 2012 10:19:08 +0000 (10:19 +0000)]
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422

Reviewed by Hajime Morita.

Fix last-minute typo in clearTimesWithDynamicOrigins, leading to assertions browsing the W3C SVG animation tests.
Covered by existing tests in svg/animations.

* svg/SVGAnimationElement.cpp: Remove unused endedActiveInterval.
* svg/SVGAnimationElement.h: Ditto.
* svg/animation/SVGSMILElement.cpp:
(WebCore::clearTimesWithDynamicOrigins): Fix order of walking the times list.
(WebCore::SVGSMILElement::reset): Move calls to clearTimesWithDynamicOrigins into endedActiveInterval.
(WebCore::SVGSMILElement::endedActiveInterval):
* svg/animation/SVGSMILElement.h:
(SVGSMILElement): Devirtualize endedActiveInterval.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Tue, 14 Feb 2012 10:04:12 +0000 (10:04 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r107661.
commit-queue@webkit.org [Tue, 14 Feb 2012 09:55:28 +0000 (09:55 +0000)]
Unreviewed, rolling out r107661.
http://trac.webkit.org/changeset/107661
https://bugs.webkit.org/show_bug.cgi?id=78591

crash on lion/qt bots (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14

Source/WebCore:

* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/objc/DOM.mm:
(kitClass):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
* dom/Node.h:
* dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::nodeType):
(WebCore):
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::toShadowRoot):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::textWillBeReplaced):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
* html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

* fast/dom/shadow/nodetype-expected.txt:
* fast/dom/shadow/nodetype.html:
* resources/dump-as-markup.js:
(Markup._get):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo. HTMLContentSeleciton -> HTMLContentSelection.
hayato@chromium.org [Tue, 14 Feb 2012 09:52:47 +0000 (09:52 +0000)]
Fix typo. HTMLContentSeleciton -> HTMLContentSelection.
https://bugs.webkit.org/show_bug.cgi?id=78571

Reviewed by Hajime Morita.

No tests. No change in behavior.

* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::insertionPointFor):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
* html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelection::append):
(WebCore::HTMLContentSelection::unlink):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):
* html/shadow/HTMLContentSelector.h:
(HTMLContentSelection):
(WebCore::HTMLContentSelection::next):
(WebCore::HTMLContentSelection::previous):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
ap@apple.com [Tue, 14 Feb 2012 09:50:41 +0000 (09:50 +0000)]
[Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
https://bugs.webkit.org/show_bug.cgi?id=78541
<rdar://problem/10036695>

Reviewed by Kent Tamura.

Source/WebKit/mac:

* WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the
preference.

Source/WebKit/win:

* WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default value of
the preference

Source/WebKit2:

* Shared/WebPreferencesStore.h: (WebKit): Changed default value of the preference.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
After each test, reset to using new protocol.

LayoutTests:

* http/tests/websocket/tests/hixie76/alert-in-event-handler.html:
* http/tests/websocket/tests/hixie76/bad-handshake-crash.html:
* http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars.html:
* http/tests/websocket/tests/hixie76/bad-sub-protocol-empty.html:
* http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii.html:
* http/tests/websocket/tests/hixie76/bufferedAmount-after-close.html:
* http/tests/websocket/tests/hixie76/client-close.html:
* http/tests/websocket/tests/hixie76/close-before-open.html:
* http/tests/websocket/tests/hixie76/close-event.html:
* http/tests/websocket/tests/hixie76/close-on-navigate-new-location.html:
* http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
* http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent.html:
* http/tests/websocket/tests/hixie76/close-on-unload.html:
* http/tests/websocket/tests/hixie76/close-unref-websocket.html:
* http/tests/websocket/tests/hixie76/cross-origin.html:
* http/tests/websocket/tests/hixie76/error-detect.html:
* http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer.html:
* http/tests/websocket/tests/hixie76/frame-length-overflow.html:
* http/tests/websocket/tests/hixie76/frame-length-skip.html:
* http/tests/websocket/tests/hixie76/frame-lengths.html:
* http/tests/websocket/tests/hixie76/handshake-challenge-randomness.html:
* http/tests/websocket/tests/hixie76/handshake-error.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch.html:
* http/tests/websocket/tests/hixie76/long-invalid-header.html:
* http/tests/websocket/tests/hixie76/multiple-connections.html:
* http/tests/websocket/tests/hixie76/null-character.html:
* http/tests/websocket/tests/hixie76/reload-crash.html:
* http/tests/websocket/tests/hixie76/send-after-close-on-unload.html:
* http/tests/websocket/tests/hixie76/send-empty.html:
* http/tests/websocket/tests/hixie76/send-object.html:
* http/tests/websocket/tests/hixie76/send-throw.html:
* http/tests/websocket/tests/hixie76/send.html:
* http/tests/websocket/tests/hixie76/server-close.html:
* http/tests/websocket/tests/hixie76/simple-stress.html:
* http/tests/websocket/tests/hixie76/simple.html:
* http/tests/websocket/tests/hixie76/split-binary-frame-header.html:
* http/tests/websocket/tests/hixie76/sub-protocol-with-space.html:
* http/tests/websocket/tests/hixie76/sub-protocol.html:
* http/tests/websocket/tests/hixie76/undefined-attributes.html:
* http/tests/websocket/tests/hixie76/unicode.html:
* http/tests/websocket/tests/hixie76/url-attribute.html:
* http/tests/websocket/tests/hixie76/url-no-trailing-slash.html:
* http/tests/websocket/tests/hixie76/url-parsing.html:
* http/tests/websocket/tests/hixie76/url-with-credential.html:
* http/tests/websocket/tests/hixie76/url-with-empty-query.html:
* http/tests/websocket/tests/hixie76/url-with-query-for-no-query.html:
* http/tests/websocket/tests/hixie76/url-with-query.html:
* http/tests/websocket/tests/hixie76/websocket-event-target.html:
* http/tests/websocket/tests/hixie76/websocket-pending-activity.html:
* http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html:
* http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html:
* http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html:
* http/tests/websocket/tests/hixie76/workers/close-in-worker.html:
* http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html:
* http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html:
* http/tests/websocket/tests/hixie76/workers/worker-simple.html:
Added overridePreference calls, so that the tests don't depend on platform or DRT default.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS3 calc: embed calc expressions in CSSPrimitiveValue
mikelawther@chromium.org [Tue, 14 Feb 2012 09:46:48 +0000 (09:46 +0000)]
CSS3 calc: embed calc expressions in CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=78446

Source/WebCore:

Reviewed by Ojan Vafai.

Adds calc expressions to CSSPrimitiveValue. This enables simple (ie no mixing of
percents with numbers/lengths) expressions to be evaluated on most properties.

Tests: css3/calc/block-mask-overlay-image-outset-expected.html
       css3/calc/css3-radial-gradients-expected.html
       css3/calc/gradient-color-stops-expected.html

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(CSSCalcValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::init):
(WebCore):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::customCssText):
* css/CSSPrimitiveValue.h:
(WebCore):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isPx):
(WebCore::CSSPrimitiveValue::isCalculated):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageNumber):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageLength):
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::getValue):
(WebCore::CSSPrimitiveValue::cssCalcValue):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):

LayoutTests:

Reviewed by Ojan Vafai.

* css3/calc/block-mask-overlay-image-outset-expected.html: Renamed from LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html.
* css3/calc/border-expected.txt:
* css3/calc/calc-errors-expected.txt:
* css3/calc/css3-radial-gradients-expected.html: Renamed from LayoutTests/css3/calc/css3-radial-gradients-expected-mismatch.html.
* css3/calc/font-expected.txt:
* css3/calc/font-monospace-expected.txt:
* css3/calc/font-size-expected.txt:
* css3/calc/font-size-fractional-expected.txt:
* css3/calc/getComputedStyle-margin-percentage-expected.txt:
* css3/calc/gradient-color-stops-expected.html: Renamed from LayoutTests/css3/calc/gradient-color-stops-expected-mismatch.html.
* css3/calc/line-height-expected.txt:
* css3/calc/margin-expected.txt:
* css3/calc/padding-expected.txt:
* css3/calc/simple-calcs-expected.txt:
* css3/calc/table-border-spacing-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: follow up to r107683: protect inspector sidebar from updating
pfeldman@chromium.org [Tue, 14 Feb 2012 09:24:30 +0000 (09:24 +0000)]
Not reviewed: follow up to r107683: protect inspector sidebar from updating
while inserting new rule.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r107662.
philn@webkit.org [Tue, 14 Feb 2012 09:22:14 +0000 (09:22 +0000)]
Unreviewed, GTK rebaseline after r107662.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExtend Chromium V8 tracing to cover more cases
commit-queue@webkit.org [Tue, 14 Feb 2012 09:13:07 +0000 (09:13 +0000)]
Extend Chromium V8 tracing to cover more cases
https://bugs.webkit.org/show_bug.cgi?id=78507

Patch by Rick Byers <rbyers@.com> on 2012-02-14
Reviewed by Eric Seidel.

No tests modified because this affects only chrome tracing which we
currently don't try to validate with automated tests.

* bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::callListenerFunction):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::instrumentedCallFunction):
(WebCore::V8Proxy::newInstance):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Pepper plugins don't receive mouse movement information in
commit-queue@webkit.org [Tue, 14 Feb 2012 08:55:38 +0000 (08:55 +0000)]
[chromium] Pepper plugins don't receive mouse movement information in
non-mouse-lock mode.
https://bugs.webkit.org/show_bug.cgi?id=78014

This change makes WebMouseEventBuilder pass along mouse movement
information properly.

There isn't test for this change because:
- the movement information added is only used by pepper, and there
  isn't any test for pepper at the WebKit side. (WebKit doesn't know
  about pepper.)
- this change is trivial. It just copies two newly-added data fields
  from MouseEvent to WebMouseEventBuilder during conversion.

Patch by Yuzhu Shen <yzshen@chromium.com> on 2012-02-14
Reviewed by Tony Chang.

* src/WebInputEventConversion.cpp:
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fire stylesheet changed event upon CSS modifications.
pfeldman@chromium.org [Tue, 14 Feb 2012 08:50:19 +0000 (08:50 +0000)]
Web Inspector: fire stylesheet changed event upon CSS modifications.
https://bugs.webkit.org/show_bug.cgi?id=78500

Patch by Pavel Feldman <pfeldman@google.com> on 2012-02-14
Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::mergeId):
(InspectorCSSAgent::SetStyleSheetTextAction):
(WebCore::InspectorCSSAgent::SetStyleSheetTextAction::merge):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::styleSheetChanged):
(WebCore):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::setPropertyText):
(WebCore::InspectorStyleSheet::toggleProperty):
(WebCore::InspectorStyleSheet::fireStyleSheetChanged):
(WebCore):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
* inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyleSheet::Listener::~Listener):
(Listener):
(InspectorStyleSheet):
(InspectorStyleSheetForInlineStyle):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._fireStyleSheetChanged):
(WebInspector.CSSStyleModel.prototype.setStyleSheetText):
(WebInspector.CSSStyleModel.prototype._undoRequested):
(WebInspector.CSSStyleModel.prototype._undoCompleted):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
(WebInspector.CSSDispatcher.prototype.mediaQueryResultChanged):
(WebInspector.CSSDispatcher.prototype.styleSheetChanged):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged):
(WebInspector.DOMAgent.prototype.get undo):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.generateUndoTest):
* inspector/elements/set-outer-html-test.js:
(initialize_SetOuterHTMLTest.InspectorTest.recordEvent):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo.bringBack):
(initialize_SetOuterHTMLTest.InspectorTest.setOuterHTMLUseUndo):
* inspector/styles/styles-history.html:
* inspector/styles/undo-add-new-rule.html:
* inspector/styles/undo-add-property.html:
* inspector/styles/undo-change-property.html:
* inspector/styles/undo-property-toggle.html:
* inspector/styles/undo-set-selector-text.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert svg/animations to use SMIL methods for driving the timeline
zimmermann@webkit.org [Tue, 14 Feb 2012 08:41:30 +0000 (08:41 +0000)]
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422

Reviewed by Dirk Schulze.

Source/WebCore:

Switch the svg/animations tests to use SVGSVGElement.setCurrentTime to drive the animation timeline.
This should fix all flakiness we previously had with these tests - and as nice side-effect we're now
using the standard SVG methods to drive the timeline, and thus have more coverage for these methods.
It already exposed several SMIL bugs, that had to be fixed, before this worked:

- beginElement()/endElement() modify the begin/end times of a SVGSMILElement. When beginElement() is
  called a new begin time is added to the list - and the same happens for endElement() with the end list.
  Unfortunately the begin/end times never get removed again, leading to incorrect instance time resolving
  when begin/endElement is called repeatedly, combined with moving the timeline through setCurrentTime.

  SMIL3 specifically demands that all 'dynamic' times in the begin/endTimes list, such that got inserted
  via beginElement/endElement - get removed if the begin/endTimes list is updated. Why?
  When calling beginElement, then endElement, then beginElement again, the begin/endTimes lists should be
  identical, w/o leftovers from any previous begin/endElement call.

  To keep track of that introduce SMILTimeWithOrigin, which holds a SMILTime and an Origin enum,
  which determines whether this SMILTime was created by the parser or dynamically created via
  beginElement/endElement.

- SMILTimeContainer::setElapsed() (called by SVGSVGElement::setCurrentTime) forgot to update the
  animation state, when it was not paused.

- document.getElementsByTagName('animateMotion')[0], always returned 'object SVGElement', instead of
  SVGAnimateMotion element making it impossible to query the animation start time, as the interfaces
  from SVGAnimationElement were not available. Fix that by removing the last hacks from svgtags.in,
  now that all IDLs are available.

Now that we use SVGSVGElement::setCurrentTime to drive the animation testing, we can remove
the DRT specific sampleSVGAnimationAtTime functionality, and its code springled all over WebCore.

Covered by all existing tests in svg/animations.

* WebCore.exp.in: Remove sampleAnimationAtTime() symbols.
* WebCore.order: Ditto.
* svg/SVGAnimationElement.cpp: Add a flag to begin/endElement, SMILTimeWithOrigin::ScriptOrigin, to indicate that these are dynamic SMILTimes, added by a script.
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
* svg/SVGDocumentExtensions.cpp: Remove sampleAnimationAtTime.
* svg/SVGDocumentExtensions.h: Ditto.
* svg/animation/SMILTime.h: Add SMILTimeWithOrigin helper.
(SMILTimeWithOrigin): Needs a SMILTime and an Origin enum entry.
(WebCore::SMILTimeWithOrigin::SMILTimeWithOrigin):
(WebCore::SMILTimeWithOrigin::time): Returns the SMILTime.
(WebCore::SMILTimeWithOrigin::originIsScript): Determines if this SMILTime got added by a script.
(WebCore::operator<): Used by std::sort.
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed): Always call updateAnimations, even if the animation is not paused. Use the right elpased time value, to seek precisely to the desired position.
(WebCore::SMILTimeContainer::timerFired): Cleanup code, no need for a local variable 'elapsed'.
(WebCore::SMILTimeContainer::updateAnimations): Remove DRT specific sampling code, which is no longer needed.
* svg/animation/SMILTimeContainer.h: Remove sampleAnimationAtTime.
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::SVGSMILElement): Only call resolveFirstInterval, not reset, from the constructor - it wastes unnecessary time, as everything is already initialized.
(WebCore::clearTimesWithDynamicOrigins): Helper function to clear all SMILTimes from the begin/endTimes list, that are dynamic.
(WebCore::SVGSMILElement::reset): Clear begin/endTimes lists, on any reset() call (when driving the animation timeline through setElapsed).
(WebCore::SVGSMILElement::insertedIntoDocument): m_beginTimes now stores SMILTimeWithOrigins, adapt the code.
(WebCore::sortTimeList): Ditto.
(WebCore::SVGSMILElement::parseBeginOrEnd): Ditto.
(WebCore::SVGSMILElement::addBeginTime): Ditto.
(WebCore::SVGSMILElement::addEndTime): Ditto.
(WebCore::extractTimeFromVector): Ditto.
(WebCore::SVGSMILElement::findInstanceTime): Ditto.
* svg/animation/SVGSMILElement.h:
* svg/svgtags.in: Enable animateMotion/hkern/mpath JS interfaces, which were not enabled, despite their IDLs existed.

Source/WebKit/chromium:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):

Source/WebKit/efl:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

* WebKit.order:
* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:

Source/WebKit/qt:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
* WebFrame.h:

Tools:

Remove no longer needed SVG specific animation sampling functionality from DRT.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Switch the svg/animations tests to use SVGSVGElement.setCurrentTime to drive the animation timeline.
This should fix all flakiness we previously had with these tests - and as nice side-effect we're now
using the standard SVG methods to drive the timeline, and thus have more coverage for these methods.
It already exposed several SMIL bugs, that had to be fixed, before this worked.

This also unifies & cleans up the tests, to use the same formatting and the same shouldBeCloseEnough helpers.

* svg/animations/animVal-basics-expected.txt:
* svg/animations/animVal-basics.html:
* svg/animations/animate-calcMode-spline-by-expected.txt:
* svg/animations/animate-calcMode-spline-by.html:
* svg/animations/animate-calcMode-spline-from-by-expected.txt:
* svg/animations/animate-calcMode-spline-from-by.html:
* svg/animations/animate-calcMode-spline-from-to-expected.txt:
* svg/animations/animate-calcMode-spline-from-to.html:
* svg/animations/animate-calcMode-spline-to-expected.txt:
* svg/animations/animate-calcMode-spline-to.html:
* svg/animations/animate-calcMode-spline-values-expected.txt:
* svg/animations/animate-calcMode-spline-values.html:
* svg/animations/animate-color-calcMode-discrete.html:
* svg/animations/animate-color-fill-currentColor.html:
* svg/animations/animate-color-fill-from-by.html:
* svg/animations/animate-color-rgba-calcMode-discrete.html:
* svg/animations/animate-color-transparent.html:
* svg/animations/animate-currentColor.html:
* svg/animations/animate-dynamic-update-attributeName.html:
* svg/animations/animate-end-attribute-expected.txt:
* svg/animations/animate-end-attribute.html:
* svg/animations/animate-endElement-beginElement.html:
* svg/animations/animate-from-to-keyTimes.html:
* svg/animations/animate-gradient-transform.html:
* svg/animations/animate-inherit-css-property.html:
* svg/animations/animate-insert-begin.html:
* svg/animations/animate-insert-no-begin.html:
* svg/animations/animate-keySplines.html:
* svg/animations/animate-mpath-insert.html:
* svg/animations/animate-number-calcMode-discrete-expected.txt:
* svg/animations/animate-number-calcMode-discrete-keyTimes.html:
* svg/animations/animate-number-calcMode-discrete.html:
* svg/animations/animate-path-animation-Cc-Ss-expected.txt:
* svg/animations/animate-path-animation-Cc-Ss.html:
* svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt:
* svg/animations/animate-path-animation-Ll-Vv-Hh.html:
* svg/animations/animate-path-animation-Qq-Tt.html:
* svg/animations/animate-path-animation-cC-sS-inverse-expected.txt:
* svg/animations/animate-path-animation-cC-sS-inverse.html:
* svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt:
* svg/animations/animate-path-animation-lL-vV-hH-inverse.html:
* svg/animations/animate-path-animation-qQ-tT-inverse.html:
* svg/animations/animate-path-nested-transforms-expected.txt:
* svg/animations/animate-path-nested-transforms.html:
* svg/animations/animate-path-to-animation-expected.txt:
* svg/animations/animate-path-to-animation.html:
* svg/animations/animate-text-nested-transforms-expected.txt:
* svg/animations/animate-text-nested-transforms.html:
* svg/animations/animateTransform-pattern-transform.html:
* svg/animations/resources/SVGAnimationTestCase.js:
(isCloseEnough):
(shouldBeCloseEnough):
(moveAnimationTimelineAndSample):
(sampleAnimation):
(runSMILTest):
(runAnimationTest):
* svg/animations/script-tests/TEMPLATE.html: Removed.
* svg/animations/script-tests/animVal-basics.js:
(sample3):
(executeTest):
* svg/animations/script-tests/animate-calcMode-spline-by.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-calcMode-spline-from-by.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-calcMode-spline-from-to.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-calcMode-spline-to.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-calcMode-spline-values.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-color-calcMode-discrete.js:
(executeTest):
* svg/animations/script-tests/animate-color-fill-currentColor.js:
(executeTest):
* svg/animations/script-tests/animate-color-fill-from-by.js:
(executeTest):
* svg/animations/script-tests/animate-color-rgba-calcMode-discrete.js:
(executeTest):
* svg/animations/script-tests/animate-color-transparent.js:
(executeTest):
* svg/animations/script-tests/animate-currentColor.js:
(executeTest):
* svg/animations/script-tests/animate-dynamic-update-attributeName.js:
(executeTest):
* svg/animations/script-tests/animate-end-attribute.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-endElement-beginElement.js:
(executeTest):
(end):
(begin):
* svg/animations/script-tests/animate-from-to-keyTimes.js:
(executeTest):
* svg/animations/script-tests/animate-gradient-transform.js:
(executeTest):
* svg/animations/script-tests/animate-inherit-css-property.js:
(executeTest):
* svg/animations/script-tests/animate-insert-begin.js:
(executeTest):
* svg/animations/script-tests/animate-insert-no-begin.js:
(executeTest):
* svg/animations/script-tests/animate-keySplines.js:
(executeTest):
* svg/animations/script-tests/animate-mpath-insert.js:
(executeTest):
* svg/animations/script-tests/animate-number-calcMode-discrete-keyTimes.js:
(executeTest):
* svg/animations/script-tests/animate-number-calcMode-discrete.js:
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/animate-path-animation-Cc-Ss.js:
(sample4):
(executeTest):
* svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js:
(sample4):
(executeTest):
* svg/animations/script-tests/animate-path-animation-Qq-Tt.js:
(executeTest):
* svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js:
(sample4):
(executeTest):
* svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js:
(sample4):
(executeTest):
* svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:
(executeTest):
* svg/animations/script-tests/animate-path-nested-transforms.js:
(g.setAttribute.rect.createSVGElement.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.rect.setAttribute.g.appendChild.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.g.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):
* svg/animations/script-tests/animate-path-to-animation.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-text-nested-transforms.js:
(rootSVGElement.setAttribute.text.createSVGElement.text.setAttribute.text.textContent.string_appeared_here.text.setAttribute.animateMotion.createSVGElement.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.animateMotion.setAttribute.text.appendChild.rootSVGElement.appendChild.startSample):
(endSample):
(executeTest):
* svg/animations/script-tests/animateTransform-pattern-transform.js:
(executeTest):
* svg/animations/script-tests/svgPreserveAspectRatio-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgboolean-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svginteger-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-LengthModeHeight.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-LengthModeOther.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-LengthModeWidth.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-invalid-value-1.js:
(executeTest):
* svg/animations/script-tests/svglength-animation-invalid-value-2.js:
(executeTest):
* svg/animations/script-tests/svglength-animation-invalid-value-3.js:
(executeTest):
* svg/animations/script-tests/svglength-animation-number-to-number.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-cm.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-ems.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-exs.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-in.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-number.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-pc.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-percentage.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-pt.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-px-to-px.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglength-animation-unitType.js:
(executeTest):
* svg/animations/script-tests/svglength-animation-values.js:
(sample5):
(executeTest):
* svg/animations/script-tests/svglengthlist-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svglengthlist-animation-2.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svglengthlist-animation-3.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svglengthlist-animation-4.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svglengthlist-animation-5.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumber-animation-1.js:
(executeTest):
* svg/animations/script-tests/svgnumber-animation-2.js:
(executeTest):
* svg/animations/script-tests/svgnumber-animation-3.js:
(executeTest):
* svg/animations/script-tests/svgnumberlist-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumberlist-animation-2.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgpath-animation-1.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svgpointlist-animation-1.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svgpointlist-animation-2.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svgrect-animation-1.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svgrect-animation-2.js:
(sample3):
(executeTest):
* svg/animations/script-tests/svgstring-animation-fallback-to-discrete.js:
(executeTest):
* svg/animations/script-tests/svgtransform-animation-1.js:
(executeTest):
* svg/animations/script-tests/svgtransform-animation-discrete.js:
(executeTest):
* svg/animations/smil-element-not-removed-crash.html:
* svg/animations/svgPreserveAspectRatio-animation-1.html:
* svg/animations/svgangle-animation-deg-to-grad-expected.txt:
* svg/animations/svgangle-animation-deg-to-grad.html:
* svg/animations/svgangle-animation-deg-to-rad-expected.txt:
* svg/animations/svgangle-animation-deg-to-rad.html:
* svg/animations/svgangle-animation-grad-to-deg-expected.txt:
* svg/animations/svgangle-animation-grad-to-deg.html:
* svg/animations/svgangle-animation-grad-to-rad-expected.txt:
* svg/animations/svgangle-animation-grad-to-rad.html:
* svg/animations/svgangle-animation-rad-to-deg-expected.txt:
* svg/animations/svgangle-animation-rad-to-deg.html:
* svg/animations/svgangle-animation-rad-to-grad-expected.txt:
* svg/animations/svgangle-animation-rad-to-grad.html:
* svg/animations/svgboolean-animation-1.html:
* svg/animations/svginteger-animation-1.html:
* svg/animations/svglength-animation-LengthModeHeight-expected.txt:
* svg/animations/svglength-animation-LengthModeHeight.html:
* svg/animations/svglength-animation-LengthModeOther-expected.txt:
* svg/animations/svglength-animation-LengthModeOther.html:
* svg/animations/svglength-animation-LengthModeWidth-expected.txt:
* svg/animations/svglength-animation-LengthModeWidth.html:
* svg/animations/svglength-animation-invalid-value-1.html:
* svg/animations/svglength-animation-invalid-value-2.html:
* svg/animations/svglength-animation-invalid-value-3.html:
* svg/animations/svglength-animation-number-to-number-expected.txt:
* svg/animations/svglength-animation-number-to-number.html:
* svg/animations/svglength-animation-px-to-cm-expected.txt:
* svg/animations/svglength-animation-px-to-cm.html:
* svg/animations/svglength-animation-px-to-ems-expected.txt:
* svg/animations/svglength-animation-px-to-ems.html:
* svg/animations/svglength-animation-px-to-exs-expected.txt:
* svg/animations/svglength-animation-px-to-exs.html:
* svg/animations/svglength-animation-px-to-in-expected.txt:
* svg/animations/svglength-animation-px-to-in.html:
* svg/animations/svglength-animation-px-to-number-expected.txt:
* svg/animations/svglength-animation-px-to-number.html:
* svg/animations/svglength-animation-px-to-pc-expected.txt:
* svg/animations/svglength-animation-px-to-pc.html:
* svg/animations/svglength-animation-px-to-percentage-expected.txt:
* svg/animations/svglength-animation-px-to-percentage.html:
* svg/animations/svglength-animation-px-to-pt-expected.txt:
* svg/animations/svglength-animation-px-to-pt.html:
* svg/animations/svglength-animation-px-to-px-expected.txt:
* svg/animations/svglength-animation-px-to-px.html:
* svg/animations/svglength-animation-unitType.html:
* svg/animations/svglength-animation-values-expected.txt:
* svg/animations/svglength-animation-values.html:
* svg/animations/svglengthlist-animation-1.html:
* svg/animations/svglengthlist-animation-2-expected.txt:
* svg/animations/svglengthlist-animation-2.html:
* svg/animations/svglengthlist-animation-3.html:
* svg/animations/svglengthlist-animation-4.html:
* svg/animations/svglengthlist-animation-5.html:
* svg/animations/svgnumber-animation-1.html:
* svg/animations/svgnumber-animation-2.html:
* svg/animations/svgnumber-animation-3.html:
* svg/animations/svgnumberlist-animation-1-expected.txt:
* svg/animations/svgnumberlist-animation-1.html:
* svg/animations/svgnumberlist-animation-2-expected.txt:
* svg/animations/svgnumberlist-animation-2.html:
* svg/animations/svgnumberoptionalnumber-animation-1.html:
* svg/animations/svgnumberoptionalnumber-animation-2.html:
* svg/animations/svgnumberoptionalnumber-animation-3.html:
* svg/animations/svgnumberoptionalnumber-animation-4.html:
* svg/animations/svgpath-animation-1-expected.txt:
* svg/animations/svgpath-animation-1.html:
* svg/animations/svgpointlist-animation-1-expected.txt:
* svg/animations/svgpointlist-animation-1.html:
* svg/animations/svgpointlist-animation-2-expected.txt:
* svg/animations/svgpointlist-animation-2.html:
* svg/animations/svgrect-animation-1-expected.txt:
* svg/animations/svgrect-animation-1.html:
* svg/animations/svgrect-animation-2-expected.txt:
* svg/animations/svgrect-animation-2.html:
* svg/animations/svgstring-animation-fallback-to-discrete-expected.txt:
* svg/animations/svgstring-animation-fallback-to-discrete.html:
* svg/animations/svgtransform-animation-1.html:
* svg/animations/svgtransform-animation-discrete-expected.txt:
* svg/animations/svgtransform-animation-discrete.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [REGRESSION] Copy Stack Trace is broken
pfeldman@chromium.org [Tue, 14 Feb 2012 08:24:05 +0000 (08:24 +0000)]
Web Inspector: [REGRESSION] Copy Stack Trace is broken
https://bugs.webkit.org/show_bug.cgi?id=78583

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/copy-stack-trace.html

* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype._copyStackTrace):

LayoutTests:

* inspector/debugger/copy-stack-trace-expected.txt: Added.
* inspector/debugger/copy-stack-trace.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Tue, 14 Feb 2012 08:17:53 +0000 (08:17 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #6 of N (visually re-inspecting as I go along, lest skia bite me).

* fast/replaced/image-tag-expected.txt: Renamed from LayoutTests/platform/gtk/fast/replaced/image-tag-expected.txt.
* platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-linux/fast/replaced/image-onload-expected.png:
* platform/chromium-linux/fast/replaced/image-sizing-expected.png:
* platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png:
* platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png: Removed.
* platform/chromium-mac/fast/replaced/image-onload-expected.png: Removed.
* platform/chromium-mac/fast/replaced/image-sizing-expected.png: Removed.
* platform/chromium-mac/fast/replaced/image-tag-expected.png: Removed.
* platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-win/fast/replaced/image-onload-expected.png:
* platform/chromium-win/fast/replaced/image-sizing-expected.png:
* platform/chromium-win/fast/replaced/image-tag-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/fast/replaced/image-tag-expected.txt: Removed.
* platform/qt/fast/replaced/image-tag-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
eric@webkit.org [Tue, 14 Feb 2012 08:16:36 +0000 (08:16 +0000)]
Upstream Android's support for SK_B32_SHIFT to JPEGImageEncoder
https://bugs.webkit.org/show_bug.cgi?id=78540

Reviewed by Adam Barth.

* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::encodePixels):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpstream Android's additions to Platform.h
eric@webkit.org [Tue, 14 Feb 2012 08:05:50 +0000 (08:05 +0000)]
Upstream Android's additions to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=78536

Reviewed by Adam Barth.

* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove BoundObject
mihaip@chromium.org [Tue, 14 Feb 2012 07:54:48 +0000 (07:54 +0000)]
[Chromium] Remove BoundObject
https://bugs.webkit.org/show_bug.cgi?id=78531

Reviewed by Pavel Feldman.

Remove the BoundObject class, references to it were removed in r56999.

* WebKit.gyp:
* src/BoundObject.cpp: Removed.
* src/BoundObject.h: Removed.
* src/WebDevToolsFrontendImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] inspector/styles/undo-add-new-rule.html crashes
pfeldman@chromium.org [Tue, 14 Feb 2012 07:48:45 +0000 (07:48 +0000)]
[Qt] inspector/styles/undo-add-new-rule.html crashes
https://bugs.webkit.org/show_bug.cgi?id=78502

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::deleteRule):

LayoutTests:

* platform/chromium/test_expectations.txt:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Tue, 14 Feb 2012 07:38:50 +0000 (07:38 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #5 of N

* platform/chromium-linux/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
* platform/chromium-mac-snowleopard/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/images/image-css3-content-data-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
* platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
* platform/chromium-win/fast/images/image-css3-content-data-expected.png: Renamed from LayoutTests/platform/chromium/fast/images/image-css3-content-data-expected.png.
* platform/chromium-win/fast/images/ycbcr-with-cmyk-color-profile-expected.png:
* platform/chromium/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInitial upstreaming of selection handling code for BlackBerry port
commit-queue@webkit.org [Tue, 14 Feb 2012 07:31:20 +0000 (07:31 +0000)]
Initial upstreaming of selection handling code for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78136

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-13
Reviewed by Rob Buis.

Initial upstreaming, no new tests.

* blackberry/WebKitSupport/SelectionHandler.cpp: Added.
* blackberry/WebKitSupport/SelectionHandler.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Tue, 14 Feb 2012 07:22:33 +0000 (07:22 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #4 of N

* platform/chromium-linux/fast/block/float/014-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-leopard/fast/block/float/014-expected.png:
* platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/014-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac/fast/block/float/014-expected.png: Removed.
* platform/chromium-win/fast/block/float/014-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Reuse CachedRawResources (e.g., XHRs) that are stored
japhet@chromium.org [Tue, 14 Feb 2012 06:45:41 +0000 (06:45 +0000)]
Source/WebCore: Reuse CachedRawResources (e.g., XHRs) that are stored
in the MemoryCache when appropriate.
https://bugs.webkit.org/show_bug.cgi?id=76564

Reviewed by Antti Koivisto.

No new tests, expected behavior covered by existing tests.

* html/DOMURL.cpp:
(WebCore::DOMURL::revokeObjectURL): Objects shouldn't remain in the
    MemoryCache if revokeObjectURL is called on them.
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent): Add CachedRawResource support.
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setCacheDisabled): Immediately
    evict resources, rather than waiting for navigation, since XHRs
    should hit the cache if it has been disabled.
* loader/cache/CachedRawResource.cpp:
(CachedRawResourceCallback): Encapsulates the async callback for
    a cache hit for CachedRawResources.
(WebCore::CachedRawResource::sendCallbacks): Do the work defered in didAddClient.
(WebCore::CachedRawResource::didAddClient): Scheduled a CachedRawResourceCallback if
    we already have a response, since async XHRs may not play nicely with receiving
    their data synchronously.
(WebCore::CachedRawResource::removeClient): Ensure we cancel a callback to a client if
    it removes itself.
(WebCore::CachedRawResource::canReuse): Provide some basic rules for when a
    CachedRawResource can be reused.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Don't automatically reload
    CachedRawResources, and add a check for whether this request has already been
    made conditional.
* xml/XMLHttpRequest.cpp:

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=76564.

Use sync XHRs instead of async in network-content-replacement-xhr.html,
since the inspector pulls async XHR data off of its CachedResource, instead
of a buffer it controls.

Reviewed by Antti Koivisto.

* http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
* http/tests/inspector/network/network-content-replacement-xhr.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Tue, 14 Feb 2012 06:41:53 +0000 (06:41 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #3 of N

* fast/backgrounds/size/backgroundSize21-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize21-expected.txt.
* fast/backgrounds/size/backgroundSize22-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize22-expected.txt.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize21-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize22-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
* platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
* platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
* platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Tue, 14 Feb 2012 06:25:58 +0000 (06:25 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #2 of N

* fast/backgrounds/size/backgroundSize17-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize17-expected.txt.
* fast/backgrounds/size/backgroundSize18-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize18-expected.txt.
* fast/backgrounds/size/backgroundSize19-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize19-expected.txt.
* fast/backgrounds/size/backgroundSize20-expected.txt: Renamed from LayoutTests/platform/gtk/fast/backgrounds/size/backgroundSize20-expected.txt.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize17-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize18-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize19-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize20-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png: Removed.
* platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png: Removed.
* platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png: Removed.
* platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
* platform/qt/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
* platform/qt/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
* platform/qt/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
* platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Set opaque flag on SkBitmap in per-tile layer updater
commit-queue@webkit.org [Tue, 14 Feb 2012 05:57:26 +0000 (05:57 +0000)]
[chromium] Set opaque flag on SkBitmap in per-tile layer updater
https://bugs.webkit.org/show_bug.cgi?id=78498

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-13
Reviewed by Stephen White.

No new tests.

* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
(SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::layerIsOpaque):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline JPEG image results after r107389
noel.gordon@gmail.com [Tue, 14 Feb 2012 05:28:40 +0000 (05:28 +0000)]
Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #1 of N

* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
* platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
* platform/chromium/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Linux ChromiumOS test results to flakiness dashboard.
commit-queue@webkit.org [Tue, 14 Feb 2012 05:19:23 +0000 (05:19 +0000)]
Add Linux ChromiumOS test results to flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=78495

Patch by Rob Flack <flackr@chromium.org> on 2012-02-13
Reviewed by Ojan Vafai.

* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/dashboard_base.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, remove svg/custom/grayscale-gradient-mask.svg CRASH expectation
noel.gordon@gmail.com [Tue, 14 Feb 2012 05:05:46 +0000 (05:05 +0000)]
[chromium] Unreviewed, remove svg/custom/grayscale-gradient-mask.svg CRASH expectation
https://bugs.webkit.org/show_bug.cgi?id=78556

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove obsolete zoom animation pathway.
wjmaclean@chromium.org [Tue, 14 Feb 2012 04:41:55 +0000 (04:41 +0000)]
[chromium] Remove obsolete zoom animation pathway.
https://bugs.webkit.org/show_bug.cgi?id=78359

Reviewed by James Robinson.

Source/WebCore:

Tests for existing pathways should not be broken. Tests for removed pathway removed previously.

This patch removes dead code from the previous incarnation of zoom animation for chromium.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* page/FrameView.cpp:
* page/FrameView.h:
(FrameView):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::ScrollAnimator):
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/ScrollAnimatorNone.h:
(ScrollAnimatorNone):
* platform/ScrollableArea.cpp:
* platform/ScrollableArea.h:
* testing/InternalSettings.cpp:
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:
* testing/Internals.cpp:

Source/WebKit/chromium:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

* src/WebViewImpl.cpp:

Source/WebKit2:

This patch removes dead code from the previous incarnation of zoom animation for chromium.

WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/text/atsui-multiple-renderers.html and related report IMAGE failure on commit...
noel.gordon@gmail.com [Tue, 14 Feb 2012 04:38:05 +0000 (04:38 +0000)]
fast/text/atsui-multiple-renderers.html and related report IMAGE failure on commit queue
https://bugs.webkit.org/show_bug.cgi?id=78544

Unreviewed. Test expectations update: PASS locally on linux but IMAGE on the queue.

* platform/chromium/test_expectations.txt:
  fast/text/atsui-multiple-renderers.html
  fast/text/international/danda-space.html
  fast/text/international/thai-baht-space.html
  fast/text/international/thai-line-breaks.html
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Regression] r107650 broke the windows build.
shinyak@chromium.org [Tue, 14 Feb 2012 04:19:34 +0000 (04:19 +0000)]
[Regression] r107650 broke the windows build.
https://bugs.webkit.org/show_bug.cgi?id=78569

Build fix, Unreviewed.

The variable defined in switch statement should not escape from the switch statement.

* dom/Element.cpp:
(WebCore::Element::webkitRegionOverflow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Mutation Observers build is broken
commit-queue@webkit.org [Tue, 14 Feb 2012 04:03:49 +0000 (04:03 +0000)]
[GTK] Mutation Observers build is broken
https://bugs.webkit.org/show_bug.cgi?id=78433

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-13
Reviewed by Martin Robinson.

Source/WebCore:

Added some files missed.

No new tests since no new feature.

* GNUmakefile.list.am:

Tools:

Enabled mutation observers as a default feature for GTK port, too.

* Scripts/build-webkit:

LayoutTests:

Removed fast/mutation, but added following 3 tests which are needed more time to pass.

GTK port DRT doesn't support some APIs like scheduleAsynchronousKeyDown.
I opened a new bug to deal with it. http://webkit.org/b/78481
And also see http://webkit.org/b/78290
fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html

Needed to enable FileSystem API at the same time.
fast/mutation/filesystem-callback-delivery.html

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
hayato@chromium.org [Tue, 14 Feb 2012 03:15:16 +0000 (03:15 +0000)]
Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
https://bugs.webkit.org/show_bug.cgi?id=77514

Reviewed by Dimitri Glazkov.

NodeType.SHADOW_ROOT_NODE type is finally gone.

Source/WebCore:

* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/objc/DOM.mm:
(kitClass):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
* dom/Node.h:
* dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
* dom/ShadowRoot.cpp:
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::toShadowRoot):
* editing/FrameSelection.cpp:
(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
* html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):

Source/WebKit/chromium:

* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::buildContentForNode):

LayoutTests:

* fast/dom/shadow/nodetype-expected.txt:
* fast/dom/shadow/nodetype.html:
* resources/dump-as-markup.js:
(Markup._get):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening. Small cleanup after r107638.
tony@chromium.org [Tue, 14 Feb 2012 02:50:18 +0000 (02:50 +0000)]
[chromium] Unreviewed gardening.  Small cleanup after r107638.

* platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/filter-empty-element-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/JavaScriptCore: Replace old strtod with new strtod
ojan@chromium.org [Tue, 14 Feb 2012 02:40:45 +0000 (02:40 +0000)]
Source/JavaScriptCore: Replace old strtod with new strtod
https://bugs.webkit.org/show_bug.cgi?id=68044

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2012-02-12
Reviewed by Geoffrey Garen.

* parser/Lexer.cpp: Added template argument. This version allows junk after numbers.
(JSC::::lex):
* runtime/JSGlobalObjectFunctions.cpp: Ditto.
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
* runtime/LiteralParser.cpp: Ditto.
(JSC::::Lexer::lexNumber):
* wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.
It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):
* wtf/dtoa.h:
(WTF):
* wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.
(WTF::toDoubleType):

Source/WebCore: rtl + flex-direction:column is positioning elements incorrectly
https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

Do the y-axis flipping after we have adjusted the y-position for
flex-align instead of before.

Tests: css3/flexbox/flex-align-baseline.html
       css3/flexbox/flex-align-end.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildren):
The amount we adjust by also needs to be flipped for rtl+column,
so the flipping needs to be done after we align the flex items.

LayoutTests: rtl + flex-direction:column is positioning elements incorrectly
https://bugs.webkit.org/show_bug.cgi?id=78555

Reviewed by Tony Chang.

* css3/flexbox/flex-align-baseline-expected.txt: Added.
* css3/flexbox/flex-align-baseline.html: Added.
* css3/flexbox/flex-align-end-expected.txt: Added.
* css3/flexbox/flex-align-end.html: Added.
* css3/flexbox/true-centering-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test expectations update.
bashi@chromium.org [Tue, 14 Feb 2012 02:39:24 +0000 (02:39 +0000)]
Unreviewed test expectations update.
Rebaselining font-face-synthetic-bold-italic.html and font-face-weight-matching.html.

* platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
* platform/chromium-linux/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
* platform/chromium-linux/fast/css/font-face-weight-matching-expected.png: Added.
* platform/chromium-linux/fast/css/font-face-weight-matching-expected.txt: Added.
* platform/chromium-mac-leopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/font-face-weight-matching-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/font-face-weight-matching-expected.txt: Added.
* platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
* platform/chromium-win/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
* platform/chromium-win/fast/css/font-face-weight-matching-expected.png: Added.
* platform/chromium-win/fast/css/font-face-weight-matching-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe tile cache layer should have its background set to the page background
andersca@apple.com [Tue, 14 Feb 2012 02:36:00 +0000 (02:36 +0000)]
The tile cache layer should have its background set to the page background
https://bugs.webkit.org/show_bug.cgi?id=78560
<rdar://problem/10857472>

Reviewed by Sam Weinig.

* page/FrameView.cpp:
(WebCore::FrameView::recalculateScrollbarOverlayStyle):
Inform the RenderLayerCompositor that the background color has changed.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateLayerBackgroundColor):
For tile cache layers we don't need a separate contents layer for the background color so
just set the background color on the layer directly.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::documentBackgroundColorDidChange):
If the root render layer is using a tile cache layer, update its background color.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow to configure ENABLE_FTPDIR in build-webkit
commit-queue@webkit.org [Tue, 14 Feb 2012 02:24:12 +0000 (02:24 +0000)]
Allow to configure ENABLE_FTPDIR in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=65098

Patch by Loïc Yhuel <loic.yhuel_ext@softathome.com> on 2012-02-13
Reviewed by Eric Seidel.

Allow to disable ENABLE_FTPDIR by command line.
Remove ENABLE_FTPDIR from --minimal build

* Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
* qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
as, for Qt platform, build-webkit does not add on command line what it thinks to be default values

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd shinyak as committer
shinyak@chromium.org [Tue, 14 Feb 2012 02:21:35 +0000 (02:21 +0000)]
Add shinyak as committer

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement start/stop_helper for ChromiumAndroidPort
abarth@webkit.org [Tue, 14 Feb 2012 02:10:17 +0000 (02:10 +0000)]
Implement start/stop_helper for ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78558

Reviewed by Dirk Pranke.

These functions (and their dependencies) set up the Android device for
testing.

This patch also includes a few tweaks on the previous patch recommended
by dpranke.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort._shut_down_http_server):
(ChromiumAndroidPort):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):
(ChromiumAndroidPort._restore_system_font):
(ChromiumAndroidPort._push_test_resources):
(ChromiumAndroidPort._push_to_device):
(ChromiumAndroidPort._pull_from_device):
(ChromiumAndroidPort._kill_device_process):
(ChromiumAndroidPort._setup_performance):
(ChromiumAndroidPort._teardown_performance):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Element.webkitRegionOverflow
benjamin@webkit.org [Tue, 14 Feb 2012 01:40:57 +0000 (01:40 +0000)]
Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html
       fast/regions/element-region-overflow-state.html

* dom/Element.cpp:
(WebCore::Element::webkitRegionOverflow):
(WebCore):
* dom/Element.h:
* dom/Element.idl:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
* rendering/RenderRegion.h:
(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore windows build fixing
mhahnenberg@apple.com [Tue, 14 Feb 2012 01:37:01 +0000 (01:37 +0000)]
More windows build fixing

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Element.webkitRegionOverflow
commit-queue@webkit.org [Tue, 14 Feb 2012 01:34:31 +0000 (01:34 +0000)]
Implement Element.webkitRegionOverflow

[CSSRegions][CSSOM] Implement Element.regionOverflow
https://bugs.webkit.org/show_bug.cgi?id=77863

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-13
Reviewed by David Hyatt.

Source/WebCore:

On each layout, compute the overflowState for each region belonging to the flow thread

Tests: fast/regions/element-region-overflow-state-vertical-rl.html
       fast/regions/element-region-overflow-state.html

* dom/Element.cpp:
(WebCore::Element::webkitRegionOverflow):
(WebCore):
* dom/Element.h:
* dom/Element.idl:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
* rendering/RenderRegion.h:
(RenderRegion):
(WebCore::RenderRegion::regionState):
(WebCore::RenderRegion::setRegionState):

LayoutTests:

* fast/regions/element-region-overflow-state-expected.txt: Added.
* fast/regions/element-region-overflow-state-vertical-rl-expected.txt: Added.
* fast/regions/element-region-overflow-state-vertical-rl.html: Added.
* fast/regions/element-region-overflow-state.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago File API IDLs are incorrect in Xcode project
ap@apple.com [Tue, 14 Feb 2012 01:32:25 +0000 (01:32 +0000)]
    File API IDLs are incorrect in Xcode project
        https://bugs.webkit.org/show_bug.cgi?id=78551

        Rubber-stamped by Dan Bernstein.

        * WebCore.xcodeproj/project.pbxproj: Corrected paths, and added missing files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSharedBuffer::getSomeData() must support m_dataArray if NETWORK_CFDATA_ARRAY_CALLBACK...
benjamin@webkit.org [Tue, 14 Feb 2012 01:27:21 +0000 (01:27 +0000)]
SharedBuffer::getSomeData() must support m_dataArray if NETWORK_CFDATA_ARRAY_CALLBACK is defined
https://bugs.webkit.org/show_bug.cgi?id=77718

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-02-13
Reviewed by David Kilzer.

Previously, the last part of SharedBuffer::getSomeData() was systematically accessing
the data from the segments. When NETWORK_CFDATA_ARRAY_CALLBACK is defined, there can
be data in m_dataArray past the segment.

The previous code was making invalid memory access pass the segment vector. This patch
adds support for getting the data out of m_dataArray to make SharedBuffer::getSomeData()
works with NETWORK_CFDATA_ARRAY_CALLBACK.

This is covered by existing tests when NETWORK_CFDATA_ARRAY_CALLBACK is defined.
The test 'fast/events/constructors/track-event-constructor.html' is a reliable test
for this.

* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::getSomeData):
* platform/SharedBuffer.h:
(SharedBuffer):
* platform/cf/SharedBufferCF.cpp:
(WebCore):
(WebCore::SharedBuffer::copySomeDataFromDataArray):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExecuting out of bounds in JSC::Yarr::YarrCodeBlock::execute / JSC::RegExp::match
oliver@apple.com [Tue, 14 Feb 2012 01:10:09 +0000 (01:10 +0000)]
Executing out of bounds in JSC::Yarr::YarrCodeBlock::execute / JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=76315

Reviewed by Gavin Barraclough.

Perform a 3 byte compare using two comparisons, rather than trying to perform the
operation with a four byte load.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoForce slow-scrolling mode when there are position:fixed elements on a page
andersca@apple.com [Tue, 14 Feb 2012 01:07:59 +0000 (01:07 +0000)]
Force slow-scrolling mode when there are position:fixed elements on a page
https://bugs.webkit.org/show_bug.cgi?id=78553
<rdar://problem/10247934>

Reviewed by Dan Bernstein.

Eventually, the scrolling tree will know about fixed positioning layers so their position can be updated
when the scroll layer position is updated. For now we'll take the simple route however.

* page/FrameView.cpp:
(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
Inform the scrolling coordinator when the number of fixed objects changes between 0 and 1.

* page/FrameView.h:
(WebCore::FrameView::hasFixedObjects):
Make this public.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::frameViewHasFixedObjectsDidChange):
Call updateShouldUpdateScrollLayerPositionOnMainThread.

(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
Make sure to update compositing layers here. Normally, they will be updated by layout but doing a layout
here is too intrusive since it could potentially change the size of the page.

(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
If we have fixed objects or slow repaint objects we need to update the scroll layer position on the main thread.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
enne@google.com [Tue, 14 Feb 2012 01:07:14 +0000 (01:07 +0000)]
[chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
https://bugs.webkit.org/show_bug.cgi?id=74154

Reviewed by James Robinson.

Covered by the compositing/ layout tests.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::create):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::createTile):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):
* platform/graphics/chromium/cc/CCLayerTilingData.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::DrawableTile::create):
(WebCore::DrawableTile::DrawableTile):
(WebCore::CCTiledLayerImpl::createTile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, removing some tests that have been passing
tony@chromium.org [Tue, 14 Feb 2012 00:57:05 +0000 (00:57 +0000)]
[chromium] Unreviewed, removing some tests that have been passing
as far back as the flakiness dashboard's history goes.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix
mhahnenberg@apple.com [Tue, 14 Feb 2012 00:56:29 +0000 (00:56 +0000)]
Windows build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] New baselines for css3/filters tests (unreviewed).
senorblanco@chromium.org [Tue, 14 Feb 2012 00:48:50 +0000 (00:48 +0000)]
[chromium] New baselines for css3/filters tests (unreviewed).

* platform/chromium-linux/css3/filters: Added.
* platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-brightness-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png: Added.
* platform/chromium-linux/css3/filters/filter-with-transform-expected.png: Added.
* platform/chromium-linux/css3/filters/nested-filter-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters: Added.
* platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-combined-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-custom-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-custom-parameters-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-grayscale-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters: Added.
* platform/chromium-mac-snowleopard/css3/filters/add-filter-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/crash-filter-change-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-blur-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-blur-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-brightness-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-combined-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-contrast-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-contrast-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-custom-combined-missing-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-drop-shadow-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-grayscale-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-hue-rotate-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-invert-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-opacity-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/filter-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/filter-with-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/filtered-compositing-descendant-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/filtered-inline-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/nested-filter-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/nested-filters-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/regions-expanding-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/filters/simple-filter-rendering-expected.png: Added.
* platform/chromium-win/css3/filters: Added.
* platform/chromium-win/css3/filters/add-filter-rendering-expected.png: Added.
* platform/chromium-win/css3/filters/crash-filter-change-expected.png: Added.
* platform/chromium-win/css3/filters/effect-blur-expected.png: Added.
* platform/chromium-win/css3/filters/effect-blur-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-blur-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-blur-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-brightness-expected.png: Added.
* platform/chromium-win/css3/filters/effect-brightness-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-brightness-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-brightness-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-combined-expected.png: Added.
* platform/chromium-win/css3/filters/effect-combined-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-combined-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-combined-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-contrast-expected.png: Added.
* platform/chromium-win/css3/filters/effect-contrast-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-contrast-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-contrast-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-custom-combined-missing-expected.png: Added.
* platform/chromium-win/css3/filters/effect-custom-expected.png: Added.
* platform/chromium-win/css3/filters/effect-custom-parameters-expected.png: Added.
* platform/chromium-win/css3/filters/effect-drop-shadow-expected.png: Added.
* platform/chromium-win/css3/filters/effect-drop-shadow-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-grayscale-expected.png: Added.
* platform/chromium-win/css3/filters/effect-grayscale-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-grayscale-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-hue-rotate-expected.png: Added.
* platform/chromium-win/css3/filters/effect-hue-rotate-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-invert-expected.png: Added.
* platform/chromium-win/css3/filters/effect-invert-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-invert-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-invert-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-opacity-expected.png: Added.
* platform/chromium-win/css3/filters/effect-opacity-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-opacity-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-opacity-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-saturate-expected.png: Added.
* platform/chromium-win/css3/filters/effect-saturate-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-saturate-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-saturate-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-sepia-expected.png: Added.
* platform/chromium-win/css3/filters/effect-sepia-expected.txt: Added.
* platform/chromium-win/css3/filters/effect-sepia-hw-expected.png: Added.
* platform/chromium-win/css3/filters/effect-sepia-hw-expected.txt: Added.
* platform/chromium-win/css3/filters/filter-region-expected.png: Added.
* platform/chromium-win/css3/filters/filter-repaint-expected.png: Added.
* platform/chromium-win/css3/filters/filter-with-transform-expected.png: Added.
* platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.png: Added.
* platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Added.
* platform/chromium-win/css3/filters/filtered-inline-expected.png: Added.
* platform/chromium-win/css3/filters/nested-filter-expected.png: Added.
* platform/chromium-win/css3/filters/nested-filters-expected.png: Added.
* platform/chromium-win/css3/filters/regions-expanding-expected.png: Added.
* platform/chromium-win/css3/filters/regions-expanding-expected.txt: Added.
* platform/chromium-win/css3/filters/simple-filter-rendering-expected.png: Added.
* platform/chromium/css3/filters: Added.
* platform/chromium/css3/filters/effect-custom-combined-missing-expected.txt: Added.
* platform/chromium/css3/filters/effect-custom-disabled-expected.txt: Added.
* platform/chromium/css3/filters/effect-custom-expected.txt: Added.
* platform/chromium/css3/filters/effect-custom-parameters-expected.txt: Added.
* platform/chromium/css3/filters/filter-property-computed-style-expected.txt: Added.
* platform/chromium/css3/filters/filter-property-parsing-expected.txt: Added.
* platform/chromium/css3/filters/filter-repaint-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/qt/css3/filters/add-filter-rendering-expected.txt: Removed.
* platform/qt/css3/filters/crash-filter-change-expected.txt: Removed.
* platform/qt/css3/filters/filter-region-expected.txt: Removed.
* platform/qt/css3/filters/filter-with-transform-expected.txt: Removed.
* platform/qt/css3/filters/filtered-inline-expected.txt: Removed.
* platform/qt/css3/filters/nested-filter-expected.txt: Removed.
* platform/qt/css3/filters/nested-filters-expected.txt: Removed.
* platform/qt/css3/filters/simple-filter-rendering-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
abarth@webkit.org [Tue, 14 Feb 2012 00:48:15 +0000 (00:48 +0000)]
Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
https://bugs.webkit.org/show_bug.cgi?id=78550

Reviewed by Eric Seidel.

Much of this code just forwards to the "host" port, which seems like a
reasonable thing to do.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort.stop_helper):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_apache):
(ChromiumAndroidPort._path_to_apache_config_file):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_helper):
(ChromiumAndroidPort._path_to_image_diff):
(ChromiumAndroidPort._path_to_lighttpd):
(ChromiumAndroidPort._path_to_lighttpd_modules):
(ChromiumAndroidPort._path_to_lighttpd_php):
(ChromiumAndroidPort._path_to_wdiff):
(ChromiumAndroidPort._shut_down_http_server):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase):
(PortTestCase.make_port):
(PortTestCase.test_default_worker_model):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd [CustomToJSObject] to interfaces which have custom toJS() and toV8()
haraken@chromium.org [Tue, 14 Feb 2012 00:42:58 +0000 (00:42 +0000)]
Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
https://bugs.webkit.org/show_bug.cgi?id=78489

Reviewed by Adam Barth.

This is the final step to remove hard-coding from HasCustomToV8Implementation()
in CodeGeneratorV8.pm. This patch replaces [JSCustomToJS] with [CustomToJSObject]
for interfaces which have custom toJS() and custom toV8().

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):

* bindings/scripts/test/TestTypedArray.idl:
* css/CSSRule.idl:
* css/CSSValue.idl:
* css/StyleSheet.idl:
* dom/Document.idl:
* dom/Event.idl:
* dom/Node.idl:
* fileapi/Blob.idl:
* fileapi/Entry.idl:
* fileapi/EntrySync.idl:
* html/HTMLCollection.idl:
* html/ImageData.idl:
* html/canvas/ArrayBufferView.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* storage/IDBAny.idl:
* storage/IDBKey.idl:
* svg/SVGPathSeg.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agochromium_android.py should implement "virtual" methods from ChromiumPort
abarth@webkit.org [Tue, 14 Feb 2012 00:16:13 +0000 (00:16 +0000)]
chromium_android.py should implement "virtual" methods from ChromiumPort
https://bugs.webkit.org/show_bug.cgi?id=78545

Reviewed by Dirk Pranke.

This patch adds basic implementations that specialize a bunch of
functions from ChromiumPort.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort):
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort.default_child_processes):
(ChromiumAndroidPort.baseline_search_path):
(ChromiumAndroidPort.check_build):
(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.default_worker_model):
(ChromiumAndroidPort.test_expectations):
(ChromiumAndroidPort.start_http_server):
(ChromiumAndroidPort.stop_http_server):
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort.stop_helper):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening. Rebaselining post skia change (from a long time...
fischman@chromium.org [Tue, 14 Feb 2012 00:09:17 +0000 (00:09 +0000)]
[chromium] Unreviewed gardening.  Rebaselining post skia change (from a long time ago).
http://code.google.com/p/chromium/issues/detail?id=105305

* platform/chromium-gpu-linux/media/audio-repaint-expected.png: Removed.
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-mac-leopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChrome crashes when attempting to add cue to track element
commit-queue@webkit.org [Tue, 14 Feb 2012 00:06:25 +0000 (00:06 +0000)]
Chrome crashes when attempting to add cue to track element
https://bugs.webkit.org/show_bug.cgi?id=77951

Patch by Arun Patole <bmf834@motorola.com> on 2012-02-13
Reviewed by Eric Carlson.

Source/WebCore:

Allocate text track's text track list of cues before using it.

* html/TextTrack.cpp:
(WebCore::TextTrack::cues):
(WebCore::TextTrack::addCue):
(WebCore::TextTrack::removeCue): return if text track list of cues is not allocated.
(WebCore::TextTrack::ensureTextTrackCueList):Added.
* html/TextTrack.h:
(TextTrack):

LayoutTests:

Updated add-remove-cue.html to handle adding a new cue to the text track created with addTextTrack.
* media/track/track-add-remove-cue-expected.txt:
* media/track/track-add-remove-cue.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix font-face-weight-matching.html and font-face-synthetic-bold-italic.html
bashi@chromium.org [Mon, 13 Feb 2012 23:55:56 +0000 (23:55 +0000)]
Fix font-face-weight-matching.html and font-face-synthetic-bold-italic.html
https://bugs.webkit.org/show_bug.cgi?id=78492

Fix the URL of Ahem.ttf.

Reviewed by Eric Seidel.

* fast/css/font-face-synthetic-bold-italic.html:
* fast/css/font-face-weight-matching.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the Windows build.
aestes@apple.com [Mon, 13 Feb 2012 23:54:05 +0000 (23:54 +0000)]
Fix the Windows build.

* platform/PlatformPasteboard.h:
(PlatformPasteboard):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash with button in multi-column layout.
inferno@chromium.org [Mon, 13 Feb 2012 23:46:46 +0000 (23:46 +0000)]
Crash with button in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78378

Reviewed by David Hyatt.

Source/WebCore:

Button creates an anonymous wrapper and expects that new children
be added to its m_inner anonymous block. However, splitBlock code
incorrectly creates column blocks directly under the button.

Test: fast/multicol/span/split-flow-anonymous-wrapper-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

* fast/multicol/span/split-flow-anonymous-wrapper-crash-expected.txt: Added.
* fast/multicol/span/split-flow-anonymous-wrapper-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the Windows build.
aestes@apple.com [Mon, 13 Feb 2012 23:39:28 +0000 (23:39 +0000)]
Fix the Windows build.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createPasteboardStrategy):
* WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace old strtod with new strtod
mhahnenberg@apple.com [Mon, 13 Feb 2012 23:38:44 +0000 (23:38 +0000)]
Replace old strtod with new strtod
https://bugs.webkit.org/show_bug.cgi?id=68044

Reviewed by Geoffrey Garen.

* parser/Lexer.cpp: Added template argument. This version allows junk after numbers.
(JSC::::lex):
* runtime/JSGlobalObjectFunctions.cpp: Ditto.
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
* runtime/LiteralParser.cpp: Ditto.
(JSC::::Lexer::lexNumber):
* wtf/dtoa.cpp: Replaced old strtod with a new version that uses the new StringToDoubleConverter.
It takes a template argument to allow clients to determine statically whether it should allow
junk after the numbers or not.
(WTF):
(WTF::strtod):
* wtf/dtoa.h:
(WTF):
* wtf/text/WTFString.cpp: Added template argument. This version does not allow junk after numbers.
(WTF::toDoubleType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonesting horizontal flexboxes is broken
ojan@chromium.org [Mon, 13 Feb 2012 23:37:55 +0000 (23:37 +0000)]
nesting horizontal flexboxes is broken
https://bugs.webkit.org/show_bug.cgi?id=76867

Reviewed by David Hyatt.

Source/WebCore:

This is copied from RenderDeprecatedFlexibleBox and updated
for RenderFlexibleBox and to handle vertical writing mode.

Tests: css3/flexbox/preferred-widths-orthogonal.html
       css3/flexbox/preferred-widths.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.cpp:
(WebCore::marginWidthForChild):
(WebCore):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/floated-flexbox-expected.txt:
* css3/flexbox/line-wrapping.html:
The old results here were wrong because they wrapped the contents of each flex item.

* css3/flexbox/preferred-widths-expected.txt: Added.
* css3/flexbox/preferred-widths-orthogonal-expected.txt: Added.
* css3/flexbox/preferred-widths-orthogonal.html: Added.
* css3/flexbox/preferred-widths.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in RenderFlowThread::setRegionBoxesRegionStyle
mihnea@adobe.com [Mon, 13 Feb 2012 23:28:30 +0000 (23:28 +0000)]
Crash in RenderFlowThread::setRegionBoxesRegionStyle
https://bugs.webkit.org/show_bug.cgi?id=78298

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/set-box-style-in-region-crash.html

We have to make sure that anonymous block objects get their information in RenderFlowThread
removed properly.

* dom/Node.cpp:
(WebCore::Node::diff):
Correct a comment.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseAnonymousBoxChild):
Remove the information for anonymous block from render flow thread.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore):
(WebCore::RenderFlowThread::setRegionRangeForBox):
Do not set region range if the flow thread does not have regions.
* rendering/RenderFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
Add an assert to make sure that after we remove an object, there is no remaining info
in any render flow thread.

LayoutTests:

* fast/regions/set-box-style-in-region-crash-expected.txt: Added.
* fast/regions/set-box-style-in-region-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html
tony@chromium.org [Mon, 13 Feb 2012 23:22:10 +0000 (23:22 +0000)]
[chromium] Unreviewed, skip http/tests/navigation/https-in-page-cache.html
because we don't enable the page cache in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a skeleton ChromiumAndroid port to webkitpy
abarth@webkit.org [Mon, 13 Feb 2012 23:17:29 +0000 (23:17 +0000)]
Add a skeleton ChromiumAndroid port to webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78543

Reviewed by Eric Seidel.

This patch just adds an empty ChromiumAndroid port object to webkitpy
and wires it up to the factory objects.  An actual implementation will
follow.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
(ChromiumAndroidPort):
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed, r107611 enabled layout tests in css3/filters,
tony@chromium.org [Mon, 13 Feb 2012 23:13:14 +0000 (23:13 +0000)]
[chromium] Unreviewed, r107611 enabled layout tests in css3/filters,
but some are missing results.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
thakis@chromium.org [Mon, 13 Feb 2012 23:10:37 +0000 (23:10 +0000)]
[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
https://bugs.webkit.org/show_bug.cgi?id=78246

This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/),
and helps with the component build on mac (InitWebCoreSystemInterface is not an
exported function, and it shouldn't be).

Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
called twice, so it's safe to land this change, and remove the calls in client
code in a later CL.

Reviewed by Darin Fisher.

* src/WebKit.cpp:
(WebKit::initializeWithoutV8):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107618 268f45cc-cd09-0410-ab3c-d52691b4dbfc