WebKit.git
10 years agoBUILD FIX: REALLY remove the last vestiges of JSVALUE32!
ddkilzer@apple.com [Fri, 4 Feb 2011 21:09:44 +0000 (21:09 +0000)]
BUILD FIX: REALLY remove the last vestiges of JSVALUE32!

<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>

* DerivedSources.make: Removed dependency on
JavaScriptCore.JSVALUE32.exp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 4 Feb 2011 21:04:36 +0000 (21:04 +0000)]
2011-02-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        Mac WebKit2 should use the new drawing area
        https://bugs.webkit.org/show_bug.cgi?id=53802
        <rdar://problem/7881419>
        <rdar://problem/7881447>
        <rdar://problem/8252632>
        <rdar://problem/8479422>
        <rdar://problem/8633813>
        <rdar://problem/8734512>
        <rdar://problem/8787660>

        * UIProcess/API/mac/WKView.mm:
        (useNewDrawingArea):
        Return true. Eventually this function should be removed, but let's keep it for now so
        we can go back to the old drawing area if necessary.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 4 Feb 2011 20:49:24 +0000 (20:49 +0000)]
2011-02-04  Robert Hogan  <robert@webkit.org>

        Reviewed by Darin Fisher.

        Move chromium iframe shim code to cross-platform file.
        https://bugs.webkit.org/show_bug.cgi?id=52594

        * platform/qt/Skipped: Unskip plugins/iframe-shims.html
2011-02-04  Robert Hogan  <robert@webkit.org>

        Reviewed by Darin Fisher.

        Move chromium iframe shim code to cross-platform file
        https://bugs.webkit.org/show_bug.cgi?id=52594

        Move Chromium code for identifying and cutting out
        iframe shims from plugins to cross-platform utility file
        IFrameShimSupport.cpp.
        Amend PluginViewQt to use this code to handle shims correctly.

        * WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
        * WebCore.pro: Add Qt support for IFrameShimSupport.cpp
        * plugins/IFrameShimSupport.cpp: Added.
        (WebCore::getObjectStack):
        (WebCore::iframeIsAbovePlugin):
        (WebCore::getPluginOcclusions):
        * plugins/IFframeShimSupport.h: Added.
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):
2011-02-04  Robert Hogan  <robert@webkit.org>

        Reviewed by Darin Fisher.

        Move chromium iframe shim code to cross-platform file
        https://bugs.webkit.org/show_bug.cgi?id=52594

        * src/WebPluginContainerImpl.cpp: Move code to WebCore/plugin/IFrameShimSupport.cpp

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 4 Feb 2011 20:47:07 +0000 (20:47 +0000)]
2011-02-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        WebKit2: Crash in WebPageProxy::setPendingAPIRequestURL after web process crashed
        https://bugs.webkit.org/show_bug.cgi?id=53799
        <rdar://problem/8943956>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::reload):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 4 Feb 2011 20:45:19 +0000 (20:45 +0000)]
2011-02-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Fix a shared memory leak
        https://bugs.webkit.org/show_bug.cgi?id=53800

        Move the send right representing the shared memory.

        * Platform/mac/SharedMemoryMac.cpp:
        (WebKit::SharedMemory::Handle::encode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8636239> and https://bugs.webkit.org/show_bug.cgi?id=53785
beidson@apple.com [Fri, 4 Feb 2011 20:38:44 +0000 (20:38 +0000)]
<rdar://problem/8636239> and https://bugs.webkit.org/show_bug.cgi?id=53785
WebKit2: Pages with dynamically inserted iframes can add extraneous back/forward items.

Reviewed by Anders Carlsson.

Source/WebKit2:

WebCore doesn't gracefully handle the case where the decidePolicyForNavigationAction callback
does not occur synchronously. Let's make it synchronous.

Change WebPageProxy to handle this message reply synchronously:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Make the navigation policy action message be synchronous.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Add a 6-argument varient

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the message synchronously.

LayoutTests:

* fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt: Added.
* fast/loader/dynamic-iframe-extra-back-forward-item.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
sfalken@apple.com [Fri, 4 Feb 2011 20:35:42 +0000 (20:35 +0000)]
Windows build fix.
Correct prebuild build-stopping rule to allow project only rebuilds.

* win/WebKit2WebProcessPreBuild.cmd:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion failure in WebInspectorProxy::platformClose closing main window when inspec...
bweinstein@apple.com [Fri, 4 Feb 2011 20:33:01 +0000 (20:33 +0000)]
Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup
window, or when running regression tests.
https://bugs.webkit.org/show_bug.cgi?id=53798
<rdar://problem/8814364>

Reviewed by Adam Roben.

Only assert about the state of m_inspectorWindow and m_inspectorView if the inspector is visible.
Also, only call ::DestroyWindow if the HWND is non-null, just to be safe.

* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformClose):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 4 Feb 2011 20:30:20 +0000 (20:30 +0000)]
2011-02-04  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Levin.

        Implement "<option> should implement the dir attribute" for chromium port after r76983.
        https://bugs.webkit.org/show_bug.cgi?id=50969

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Override as true.
        * src/WebViewImpl.cpp: Remove directionality hint from autofill drop-down setting.
2011-02-04  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Levin.

        Implement "<option> should implement the dir attribute" for chromium port after r76983.
        https://bugs.webkit.org/show_bug.cgi?id=50969

        Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
        added in r76983.

        * platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from
        <select> drop-down setting.
        (WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint
        items in drop-down and pass-in bidi override flag when creating text run.
        * platform/chromium/PopupMenuChromium.h: Remove directionalityHint from
        PopupContainerSettings.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 20:23:04 +0000 (20:23 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        Add platform/mac-leopard baselines for tests added in r77639. The text rendering is
        different enough for them to be different from mac-snowleopard.

        * platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
        * platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
        * platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
        * platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Added.
        * platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
        * platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
        * platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
        * platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
        * platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
        * platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 4 Feb 2011 20:10:25 +0000 (20:10 +0000)]
2011-02-04  Jeremy Orlow  <jorlow@chromium.org>

        Build fix from merge mistake.

        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::ensureEventTargetData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 4 Feb 2011 19:57:41 +0000 (19:57 +0000)]
2011-02-04  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Remove unneeded function declarations in comments in EditorClient.h
        https://bugs.webkit.org/show_bug.cgi?id=53745

        Removing unused commented out function declarations. No tests since this is just cleanup.

        * page/EditorClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 4 Feb 2011 19:50:24 +0000 (19:50 +0000)]
2011-02-03  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Refactor IDBRequest and IDBTransaction a bit
        https://bugs.webkit.org/show_bug.cgi?id=53565

        There were a lot of subtle issues with the way IDBTransaction
        and IDBRequest used to be written. This cleans a lot of them up
        and largely simplifies the logic. Using EventQueue rather than
        timers is one example of the simplification.

        * bindings/scripts/CodeGeneratorV8.pm:
        * dom/EventQueue.cpp:
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::dispatchEvent):
        * storage/IDBCursor.cpp:
        (WebCore::IDBCursor::continueFunction):
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::create):
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::resetReadyState):
        (WebCore::IDBRequest::onError):
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::dispatchEvent):
        (WebCore::IDBRequest::enqueueEvent):
        (WebCore::IDBRequest::eventTargetData):
        (WebCore::IDBRequest::ensureEventTargetData):
        * storage/IDBRequest.h:
        (WebCore::IDBRequest::dispatchEvent):
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::create):
        (WebCore::IDBTransaction::IDBTransaction):
        (WebCore::IDBTransaction::objectStore):
        (WebCore::IDBTransaction::abort):
        (WebCore::IDBTransaction::onAbort):
        (WebCore::IDBTransaction::onComplete):
        (WebCore::IDBTransaction::onTimeout):
        (WebCore::IDBTransaction::canSuspend):
        (WebCore::IDBTransaction::stop):
        (WebCore::IDBTransaction::enqueueEvent):
        (WebCore::IDBTransaction::eventTargetData):
        (WebCore::IDBTransaction::ensureEventTargetData):
        * storage/IDBTransaction.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 19:38:01 +0000 (19:38 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Add baselines for tests, added in r77644.

        * platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.png: Added.
        * platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
        * platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.png: Added.
        * platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 19:31:52 +0000 (19:31 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Temporarily add tests added in r77639 as failing, because
        we can't see the baselines for these tests (they are in platform/mac-snowleopard).

        * platform/chromium/test_expectations.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 4 Feb 2011 19:22:50 +0000 (19:22 +0000)]
2011-02-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Remove the timeout event from IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=53521

        * storage/indexeddb/tutorial.html:
2011-02-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Remove the timeout event from IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=53521

        Remove timeout and ontimeout from IDBTransaction per the spec.

        * WebCore.gypi:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::transaction):
        * storage/IDBDatabase.h:
        (WebCore::IDBDatabase::transaction):
        * storage/IDBDatabase.idl:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::setVersion):
        (WebCore::IDBDatabaseBackendImpl::transaction):
        * storage/IDBDatabaseBackendImpl.h:
        * storage/IDBDatabaseBackendInterface.h:
        * storage/IDBTimeoutEvent.cpp: Removed.
        * storage/IDBTimeoutEvent.h: Removed.
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::IDBTransaction):
        (WebCore::IDBTransaction::onAbort):
        (WebCore::IDBTransaction::onComplete):
        * storage/IDBTransaction.h:
        * storage/IDBTransaction.idl:
        * storage/IDBTransactionBackendImpl.cpp:
        (WebCore::IDBTransactionBackendImpl::create):
        (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
        * storage/IDBTransactionBackendImpl.h:
        * storage/IDBTransactionCallbacks.h:
2011-02-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Remove the timeout event from IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=53521

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::transaction):
        * public/WebIDBTransactionCallbacks.h:
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::transaction):
        * src/IDBDatabaseProxy.h:
        * src/IDBTransactionCallbacksProxy.cpp:
        * src/IDBTransactionCallbacksProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::transaction):
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBTransactionCallbacksImpl.cpp:
        * src/WebIDBTransactionCallbacksImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 19:16:05 +0000 (19:16 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Add baselines for tests, added in r77639.

        * platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png: Added.
        * platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Added.
        * platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png: Added.
        * platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
        * platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png: Added.
        * platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
        * platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
        * platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
        * platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
        * platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
        * platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
        * platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: Can't set accessibility overridden attributes on web objects
cfleizach@apple.com [Fri, 4 Feb 2011 18:47:41 +0000 (18:47 +0000)]
AX: Can't set accessibility overridden attributes on web objects
https://bugs.webkit.org/show_bug.cgi?id=53725

Reviewed by Darin Adler.

accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 18:42:30 +0000 (18:42 +0000)]
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
        https://bugs.webkit.org/show_bug.cgi?id=53691

        * fast/repaint/slider-thumb-drag-release.html: Added.
        * platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
        * platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
        * platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
2011-02-03  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
        https://bugs.webkit.org/show_bug.cgi?id=53691

        Test: fast/repaint/slider-thumb-drag-release.html

        * html/shadow/SliderThumbElement.cpp:
        (WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
            that the thumb is repainted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 4 Feb 2011 18:32:41 +0000 (18:32 +0000)]
2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Add "show more" data grid node and waiting message UI components.
        https://bugs.webkit.org/show_bug.cgi?id=53763

        - "show more" data grid node is used for on-demand population of
        data grid contents (similar to DOM tree capability for limiting
        displayed nodes count);

        - waiting message is used for informing user about long lasting
        operations (with a possibility to cancel them).

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/PleaseWaitMessage.js: Added.
        (WebInspector.PleaseWaitMessage):
        * inspector/front-end/ShowMoreDataGridNode.js: Added.
        (WebInspector.ShowMoreDataGridNode):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.data-grid button):
        (.please-wait-msg):
        * inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 18:32:20 +0000 (18:32 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        Update mac baselines. They pixel-rotted.

        * platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png:
        * platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
        * platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
        * platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
        * platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png:
        * platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.checksum:
        * platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png:
        * platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
        * platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
        * platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
        * platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
        * platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
        * platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
        * platform/mac/fast/backgrounds/svg-as-background-4-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 4 Feb 2011 18:27:06 +0000 (18:27 +0000)]
2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
        https://bugs.webkit.org/show_bug.cgi?id=53781

        * Scripts/check-inspector-strings:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 4 Feb 2011 18:25:28 +0000 (18:25 +0000)]
2011-02-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Go out of accelerated compositing mode when the drawing area is destroyed
        https://bugs.webkit.org/show_bug.cgi?id=53788

        This fixes a crash in the UI process if a web process crashes while in accelerated compositing mode.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=53740
adele@apple.com [Fri, 4 Feb 2011 18:18:30 +0000 (18:18 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused

Reviewed by Dan Bernstein.

Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html

* html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Add a check for shouldShowPlaceholderWhenFocused.
* html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):
Whenever the value is updated, we should also update placeholder visibility.
* rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):
Make the default the same as the existing behavior.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
Show placeholder when appropriate.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8957409> Remove last vestiges of JSVALUE32
ddkilzer@apple.com [Fri, 4 Feb 2011 18:13:02 +0000 (18:13 +0000)]
<rdar://problem/8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>

Reviewed by Darin Adler.

Support for JSVALUE32 was originaly removed in r70111.

* Configurations/JavaScriptCore.xcconfig: Changed armv6 to use
JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.
* DerivedSources.make: Removed rule for
JavaScriptCore.JSVALUE32.exp.
* JavaScriptCore.JSVALUE32only.exp: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed references
to JavaScriptCore.JSVALUE32only.exp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 18:02:54 +0000 (18:02 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Tweak expectations for passing tests.

        * platform/chromium/test_expectations.txt: More tweakage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInclude the crashing function in the link to a crash log on Mac
aroben@apple.com [Fri, 4 Feb 2011 18:01:25 +0000 (18:01 +0000)]
Include the crashing function in the link to a crash log on Mac

Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
function that crashed on Mac

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(crashLocation): Moved all the Windows code inside an if instead of using an early return,
but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
the crash log.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse static_cast and other style cleanup in YarrInterpreter.cpp
ddkilzer@apple.com [Fri, 4 Feb 2011 17:31:35 +0000 (17:31 +0000)]
Use static_cast and other style cleanup in YarrInterpreter.cpp
<http://webkit.org/b/53772>

Reviewed by John Sullivan.

* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 17:20:10 +0000 (17:20 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Remove more passing tests.

        * platform/chromium/test_expectations.txt: Even more passages removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLink to Mac crash logs from results.html
aroben@apple.com [Fri, 4 Feb 2011 17:07:47 +0000 (17:07 +0000)]
Link to Mac crash logs from results.html

Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 4 Feb 2011 17:05:57 +0000 (17:05 +0000)]
2011-02-04  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Removed passing tests.

        * platform/chromium/test_expectations.txt: Passages removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 4 Feb 2011 16:38:34 +0000 (16:38 +0000)]
2011-02-04  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: evaluate on hover does not work on a breakpoint.
        https://bugs.webkit.org/show_bug.cgi?id=53768

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._mouseHover):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Fri, 4 Feb 2011 16:28:13 +0000 (16:28 +0000)]
2011-02-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77625 and r77626.
        http://trac.webkit.org/changeset/77625
        http://trac.webkit.org/changeset/77626
        https://bugs.webkit.org/show_bug.cgi?id=53765

        It broke Windows builds (Requested by Ossy_ on #webkit).

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * ForwardingHeaders/pcre/pcre.h: Added.
        * ForwardingHeaders/yarr/Yarr.h: Removed.
        * ForwardingHeaders/yarr/YarrInterpreter.h: Removed.
        * ForwardingHeaders/yarr/YarrPattern.h: Removed.
        * WebCore.gyp/WebCore.gyp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/copyForwardingHeaders.cmd:
        * platform/text/RegularExpression.cpp:
        (WebCore::RegularExpression::Private::regexp):
        (WebCore::RegularExpression::Private::compile):
        (WebCore::RegularExpression::Private::Private):
        (WebCore::RegularExpression::Private::create):
        (WebCore::RegularExpression::Private::~Private):
        (WebCore::RegularExpression::match):

2011-02-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77625 and r77626.
        http://trac.webkit.org/changeset/77625
        http://trac.webkit.org/changeset/77626
        https://bugs.webkit.org/show_bug.cgi?id=53765

        It broke Windows builds (Requested by Ossy_ on #webkit).

        * JavaScriptCore.exp:
        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * create_regex_tables:
        * runtime/RegExp.cpp:
        * wtf/Platform.h:
        * yarr/Yarr.h:
        * yarr/YarrJIT.cpp:
        * yarr/YarrJIT.h:
        * yarr/YarrParser.h:
        * yarr/YarrPattern.h:
        * yarr/YarrSyntaxChecker.h:
        * yarr/yarr.pri: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix. Unreviewed.
jberlin@webkit.org [Fri, 4 Feb 2011 15:51:28 +0000 (15:51 +0000)]
Windows build fix. Unreviewed.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows 7 Release Tests] transitions/transition-end-event-multiple-04.html flakey
jberlin@webkit.org [Fri, 4 Feb 2011 15:21:32 +0000 (15:21 +0000)]
[Windows 7 Release Tests] transitions/transition-end-event-multiple-04.html flakey
https://bugs.webkit.org/show_bug.cgi?id=53332

Unreviewed, attempt to get the Windows 7 Release bots uniformly green.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Fri, 4 Feb 2011 14:54:39 +0000 (14:54 +0000)]
2011-02-04  Peter Varga  <pvarga@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        Replace PCRE with Yarr in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=53496

        Speculative windows build fix.

        No new tests needed.

        * platform/text/RegularExpression.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Fri, 4 Feb 2011 14:29:10 +0000 (14:29 +0000)]
2011-02-04  Peter Varga  <pvarga@webkit.org>

        Reviewed by Gavin Barraclough.

        Replace PCRE with Yarr in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=53496

        * JavaScriptCore.exp:
        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * create_regex_tables:
        * runtime/RegExp.cpp:
        * wtf/Platform.h:
        * yarr/Yarr.h:
        * yarr/YarrJIT.cpp:
        * yarr/YarrJIT.h:
        * yarr/YarrParser.h:
        * yarr/YarrPattern.h:
        * yarr/YarrSyntaxChecker.h:
        * yarr/yarr.pri: Added.
2011-02-04  Peter Varga  <pvarga@webkit.org>

        Reviewed by Gavin Barraclough.

        Replace PCRE with Yarr in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=53496

        No new tests needed.

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * ForwardingHeaders/pcre/pcre.h: Removed.
        * ForwardingHeaders/yarr/Yarr.h: Added.
        * ForwardingHeaders/yarr/YarrInterpreter.h: Added.
        * ForwardingHeaders/yarr/YarrPattern.h: Added.
        * WebCore.gyp/WebCore.gyp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/copyForwardingHeaders.cmd:
        * platform/text/RegularExpression.cpp:
        (WebCore::RegularExpression::Private::create):
        (WebCore::RegularExpression::Private::Private):
        (WebCore::RegularExpression::Private::compile):
        (WebCore::RegularExpression::match):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 4 Feb 2011 14:27:57 +0000 (14:27 +0000)]
2011-02-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        Rebaseline. The problem was introduced at r77601.

        * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 4 Feb 2011 14:22:05 +0000 (14:22 +0000)]
2011-02-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Network panel filtering is broken.
        https://bugs.webkit.org/show_bug.cgi?id=53764

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._sortItems):
        (WebInspector.NetworkPanel.prototype._sortByTimeline):
        (WebInspector.NetworkPanel.prototype._filter):
        (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
        (WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
        (WebInspector.NetworkDataGridNode.prototype.get selectable):
        (WebInspector.NetworkTotalGridNode.prototype.isFilteredOut):
        (WebInspector.NetworkTotalGridNode.prototype.get selectable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 4 Feb 2011 13:47:26 +0000 (13:47 +0000)]
2011-02-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        Rebaseline image for fast/box-shadow/shadow-tiling-artifact.html
        The problem was introduced at r77601.

        * platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
        * platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
        * platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.checksum: Added.
        * platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 4 Feb 2011 13:32:56 +0000 (13:32 +0000)]
2011-02-04  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        New test expectations.

        * platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Added.
        * platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
        * platform/gtk/svg/text/font-size-below-point-five-2-expected.txt: Added.
        * platform/gtk/svg/text/font-size-below-point-five-expected.txt: Added.
        * platform/gtk/svg/text/scaled-font-expected.txt: Added.
        * platform/gtk/svg/text/small-fonts-2-expected.txt: Added.
        * platform/gtk/svg/text/small-fonts-3-expected.txt: Added.
        * platform/gtk/svg/text/small-fonts-expected.txt: Added.
        * platform/gtk/svg/text/small-fonts-in-html5-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 4 Feb 2011 13:25:42 +0000 (13:25 +0000)]
2011-02-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: support overriding user agent strings
        https://bugs.webkit.org/show_bug.cgi?id=51485

        Test: http/tests/inspector/extensions-useragent.html

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::setUserAgentOverride):
        (WebCore::InspectorController::userAgentOverride):
        * inspector/InspectorController.h:
        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.reload):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onReload):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::userAgent):
        (WebCore::FrameLoader::applyUserAgent):

2011-02-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: support overriding user agent strings
        https://bugs.webkit.org/show_bug.cgi?id=51485

        * http/tests/inspector/extensions-useragent-expected.txt: Added.
        * http/tests/inspector/extensions-useragent.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 4 Feb 2011 13:03:21 +0000 (13:03 +0000)]
2011-02-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rollout two patches r77614 and r77612.

        REGRESSION: Snow Leopard Intell Release anumber of failing tests.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::reset):
        * runtime/Heap.h:
        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::sweep):
        (JSC::MarkedSpace::reset):
        * runtime/MarkedSpace.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 4 Feb 2011 12:40:49 +0000 (12:40 +0000)]
2011-02-04  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: scripts panel displays wrong file name after reload.
        https://bugs.webkit.org/show_bug.cgi?id=53761

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 4 Feb 2011 11:34:05 +0000 (11:34 +0000)]
2011-02-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove settings related methods from InspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=53686

        * WebCore.exp.in:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorClient.h:
        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
        (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
        (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
        * inspector/InspectorFrontendClientLocal.h: ports that provide in-process implementation of the inspector front-end can
        provide platform-specific settings accessor.
        (WebCore::InspectorFrontendClientLocal::Settings::Settings):
        (WebCore::InspectorFrontendClientLocal::Settings::~Settings):
        (WebCore::InspectorFrontendClientLocal::Settings::inspectorAttachedHeight):
        (WebCore::InspectorFrontendClientLocal::Settings::storeInspectorAttachedHeight):
        * loader/EmptyClients.h:
2011-02-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove settings related methods from InspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=53686

        * WebCoreSupport/WebInspectorClientCF.cpp:
        (populateSetting):
        (storeSetting):
        (WebInspectorClient::createFrontendSettings):
2011-02-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove settings related methods from InspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=53686

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorFrontendClient::InspectorFrontendClient):
        * WebCoreSupport/InspectorClientGtk.h:
2011-02-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove settings related methods from InspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=53686

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::openInspectorFrontend):
        (WebInspectorFrontendClient::WebInspectorFrontendClient):
2011-02-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove settings related methods from InspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=53686

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
        * WebCoreSupport/InspectorClientQt.h:
2011-02-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove settings related methods from InspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=53686

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::openInspectorFrontend):
        (WebInspectorFrontendClient::WebInspectorFrontendClient):
        * WebCoreSupport/WebInspectorClient.h:
2011-02-03  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove settings related methods from InspectorClient
        https://bugs.webkit.org/show_bug.cgi?id=53686

        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
        (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 4 Feb 2011 10:32:29 +0000 (10:32 +0000)]
2011-02-04  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Skipping fast/events/pagehide-timeout.html that is failing on GTK
        bots. See https://bugs.webkit.org/show_bug.cgi?id=53733

        * platform/gtk/Skipped: skip fast/events/pagehide-timeout.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 4 Feb 2011 08:49:32 +0000 (08:49 +0000)]
2011-02-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed.

        Roll chromium to 73764.

        * DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix 32bit build.
ggaren@apple.com [Fri, 4 Feb 2011 08:12:42 +0000 (08:12 +0000)]
Try to fix 32bit build.

* runtime/Heap.cpp:
(JSC::Heap::reset): Use an explicit cast to avoid shortening warnings,
since 1.5 is double (64bit), and the result is size_t (32bit).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Fri, 4 Feb 2011 07:50:53 +0000 (07:50 +0000)]
2011-02-03  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] frame several more JS code invocations into v8::TryCatch
        https://bugs.webkit.org/show_bug.cgi?id=53594

        This patch is preemptive and adjusts v8 bindings code to forthcoming small change
        in v8::ThrowException---currently sometimes exceptions thrown by this method
        do not reach surrounding v8::TryCatch handler (see
        http://code.google.com/p/v8/issues/detail?id=1072 and
        http://codereview.chromium.org/6397011/).  Therefore the goal of this patch
        is to make forthcoming v8 roll as smooth as possible (alas, we'll still need
        one rebaseline as of now.)

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::runScript): Do not rely on empty handle as a signal of exception, wrap into v8::TryCatch instead
        * bindings/v8/V8WindowErrorHandler.cpp:
        (WebCore::V8WindowErrorHandler::callListenerFunction): Ditto

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 4 Feb 2011 07:41:33 +0000 (07:41 +0000)]
2011-02-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Changed MarkedSpace to delegate grow/shrink decisions to Heap
        https://bugs.webkit.org/show_bug.cgi?id=53759

        SunSpider reports no change.

        * runtime/Heap.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::reset):
        * runtime/Heap.h: Reorganized a few data members for better cache locality.
        Added a grow policy.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocate):
        (JSC::MarkedSpace::sweep):
        (JSC::MarkedSpace::reset): Don't shrink automatically. Instead, wait for
        the heap to make an explicit sweep call.

        * runtime/MarkedSpace.h:
        (JSC::MarkedSpace::highWaterMark):
        (JSC::MarkedSpace::setHighWaterMark): Use a watermark to determine how
        many bytes to allocate before failing and giving the heap an opportunity
        to collect garbage. This also means that we allocate blocks on demand,
        instead of ahead of time.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 4 Feb 2011 07:27:37 +0000 (07:27 +0000)]
2011-02-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
        https://bugs.webkit.org/show_bug.cgi?id=52897
        <rdar://problem/8898294>

        * WebCore.exp.in: Add export now needed by WebKit2
2011-02-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
        https://bugs.webkit.org/show_bug.cgi?id=52897
        <rdar://problem/8898294>

        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toAPI):
        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
        (WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
2011-02-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
        https://bugs.webkit.org/show_bug.cgi?id=52897
        <rdar://problem/8898294>

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage):
        (WTR::InjectedBundlePage::willSendRequestForFrame):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Ivan Krstić <ike@apple.com>
ike@apple.com [Fri, 4 Feb 2011 07:00:58 +0000 (07:00 +0000)]
2011-02-03  Ivan Krstić  <ike@apple.com>

        Reviewed by Maciej Stachowiak.

        Make WebProcess pass explicit homedir parameter to the sandbox
        <rdar://problem/8405760>
        <https://webkit.org/b/53558>

        * WebProcess/com.apple.WebProcess.sb:
        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::initializeSandbox):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Ivan Krstić <ike@apple.com>
ike@apple.com [Fri, 4 Feb 2011 06:54:53 +0000 (06:54 +0000)]
2011-02-03  Ivan Krstić  <ike@apple.com>

        Unreviewed.

        Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Victoria Kirst <vrk@google.com>
commit-queue@webkit.org [Fri, 4 Feb 2011 06:46:41 +0000 (06:46 +0000)]
2011-02-03  Victoria Kirst  <vrk@google.com>

        Reviewed by James Robinson.

        Replaces float literals with uniform values in shader code
        so that buggy drivers unable to parse float values in different
        locales will not produce a pink video.

        [chromium] Fix pink video bug with gpu-acceleration enabled
        https://bugs.webkit.org/show_bug.cgi?id=53568

        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::SharedValues::SharedValues):
        (WebCore::VideoLayerChromium::drawYUV):
        * platform/graphics/chromium/VideoLayerChromium.h:
        (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd navigator.registerProtocolHandler behind a flag.
levin@chromium.org [Fri, 4 Feb 2011 06:31:21 +0000 (06:31 +0000)]
Add navigator.registerProtocolHandler behind a flag.
https://bugs.webkit.org/show_bug.cgi?id=52609

Patch by James Kozianski <koz@chromium.org> on 2011-02-03
Reviewed by Dimitri Glazkov.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This method is described in the HTML5 specification here,
http://dev.w3.org/html5/spec/Overview.html#dom-navigator-registerprotocolhandler

This change is largely cribbed from B. Green's 29651 patches. It is
behind a flag so as not to break JS feature detection.

New layout test fast/dom/registerProtocolHandler.html.

* Configurations/FeatureDefines.xcconfig:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::registerProtocolHandler):
* page/Chrome.cpp:
(WebCore::Chrome::registerProtocolHandler):
* page/Chrome.h:
* page/ChromeClient.h:
* page/Navigator.cpp:
(WebCore::verifyCustomHandlerURL):
(WebCore::verifyProtocolHandlerScheme):
(WebCore::Navigator::registerProtocolHandler):
* page/Navigator.h:
* page/Navigator.idl:

Source/WebKit/chromium:

* features.gypi:
* public/WebViewClient.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::registerProtocolHandler):
* src/ChromeClientImpl.h:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

* fast/dom/register-protocol-handler-expected.txt: Added.
* fast/dom/register-protocol-handler.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Fri, 4 Feb 2011 06:26:26 +0000 (06:26 +0000)]
2011-02-03  Hayato Ito  <hayato@chromium.org>

        Reviewed by Eric Seidel.

        [NRWT] Remove TestArgs class, which is wrongly used.

        https://bugs.webkit.org/show_bug.cgi?id=53063

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Andrew Wason <rectalogic@rectalogic.com>
commit-queue@webkit.org [Fri, 4 Feb 2011 05:45:44 +0000 (05:45 +0000)]
2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>

        Reviewed by Kenneth Russell.

        Change ENABLE_3D_CANVAS to ENABLE_WEBGL
        https://bugs.webkit.org/show_bug.cgi?id=53714

        * Scripts/build-webkit: change --3d-canvas build option
          to set ENABLE_WEBGL

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Brian Ryner <bryner@chromium.org>
commit-queue@webkit.org [Fri, 4 Feb 2011 05:38:21 +0000 (05:38 +0000)]
2011-02-03  Brian Ryner  <bryner@chromium.org>

        Reviewed by Darin Fisher.

        Add a field to the ResourceResponse for tracking the socket address
        of the host that the resource was fetched from.  Patch was originally
        by Paul Marks.
        https://bugs.webkit.org/show_bug.cgi?id=53699

        * platform/network/chromium/ResourceResponse.cpp:
        (WebCore::ResourceResponse::doPlatformCopyData):
        (WebCore::ResourceResponse::doPlatformAdopt):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::socketAddress):
        (WebCore::ResourceResponse::setSocketAddress):
2011-02-03  Brian Ryner  <bryner@chromium.org>

        Reviewed by Darin Fisher.

        Add a field to the ResourceResponse for tracking the socket address
        of the host that the resource was fetched from.  Patch was originally
        by Paul Marks.
        https://bugs.webkit.org/show_bug.cgi?id=53699

        * public/WebURLResponse.h:
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::socketAddress):
        (WebKit::WebURLResponse::setSocketAddress):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Fri, 4 Feb 2011 05:36:15 +0000 (05:36 +0000)]
2011-02-03  Hayato Ito  <hayato@chromium.org>

        Reviewed by Tony Chang.

        [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
        move _run_single_test() and _process_output() functions from
        dump_render_tree_thread.py to a single_test_runner.py as an individual module.

        This is clean up and acts as a preparation for elimination of test_types/*
        classes. These classes will move to the single_test_runner module introduced
        in this patch.

        https://bugs.webkit.org/show_bug.cgi?id=53004

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Langley <agl@chromium.org>
agl@chromium.org [Fri, 4 Feb 2011 05:30:08 +0000 (05:30 +0000)]
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::didRunInsecureContent):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkIfRunInsecureContent):
        * loader/FrameLoaderClient.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::didRunInsecureContent):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::didRunInsecureContent):
        * src/FrameLoaderClientImpl.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::didRunInsecureContent):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::didRunInsecureContent):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::didRunInsecureContent):
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::didRunInsecureContent):
        * WebCoreSupport/FrameLoaderClientQt.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::didRunInsecureContent):
        * WebCoreSupport/WebFrameLoaderClient.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::didRunInsecureContent):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::didRunInsecureContent):
        * WebKitSupport/FrameLoaderClientWx.h:
2011-02-03  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Plumb mixed script URL to FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=52384

        Regressions covered by http/tests/security/mixedContent/*

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::didRunInsecureContent):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 4 Feb 2011 05:28:30 +0000 (05:28 +0000)]
2011-02-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION: Artifacts on box-shadow corners in some cases
        https://bugs.webkit.org/show_bug.cgi?id=53731

        Fix overdrawing artifacts in ShadowBlur's tiling code path,
        which show up in shadows using a color with alpha.

        Test: fast/box-shadow/shadow-tiling-artifact.html

        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::drawRectShadowWithTiling): Ensure
        that the inner rect that gets filled does not overlap with any
        of the eight tiled areas by having the corner and side dimensions
        be the same for contiguous areas.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 4 Feb 2011 05:26:57 +0000 (05:26 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        XSS Auditor is spinning inside decodeURLEscapeSequences() if there are
        percent signs in large posted data
        https://bugs.webkit.org/show_bug.cgi?id=53405

        If the input string contains many non-% characters followed by a %
        character that is not a valid URL escape sequence, then the old
        algorithm would only advance the initial search by one character
        (instead of jumping to just after the % character).  That would cause
        the algorithm to take N^2 time (in the number of characters before the
        first % character).  This patch just advances the search past the first
        % character so we can start looking for next % character sooner.

        * platform/KURL.cpp:
        (WebCore::decodeURLEscapeSequences):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Victoria Kirst <vrk@google.com>
commit-queue@webkit.org [Fri, 4 Feb 2011 05:20:04 +0000 (05:20 +0000)]
2011-02-03  Victoria Kirst  <vrk@google.com>

        Reviewed by James Robinson.

        [chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
        https://bugs.webkit.org/show_bug.cgi?id=52868

        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::WebMediaPlayerClientImpl::paint):
        (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
        (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
        * src/WebMediaPlayerClientImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 4 Feb 2011 05:08:03 +0000 (05:08 +0000)]
2011-02-03  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: click on a breakpoint highlights wrong line in source frame.
        https://bugs.webkit.org/show_bug.cgi?id=53692

        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Fri, 4 Feb 2011 05:04:15 +0000 (05:04 +0000)]
2011-02-03  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Bail out if to string conversion returned empty handle
        https://bugs.webkit.org/show_bug.cgi?id=53687

        This a temporary measure: actually one probably should never get empty handle
        if there was no exception.  The root cause is under investigation.
        The bailout though allows Chromium not to crash---attempt to convert an empty
        v8 hande into WebCore string crashes with invalid memory access.

        See http://code.google.com/p/chromium/issues/detail?id=71544

        There is no known reduction expressible as a layout test so far.  The crash found with automated testing tools.

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
        * bindings/v8/V8Binding.h:
        (WebCore::V8ParameterBase::prepareBase): Ditto

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Fri, 4 Feb 2011 05:03:08 +0000 (05:03 +0000)]
2011-02-03  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [Gtk] No need to set text encoding in the provisional phase
        https://bugs.webkit.org/show_bug.cgi?id=53487

        According to changeset 67253, setEncoding could be called multiple times from
        committedLoad, finishedLoading, dispatchDidFailLoading, and setMainDocumentError
        in FrameLoaderClient. To fix this, the relevant code was removed from
        FrameLoaderClient and moved to DocumentLoader::commitData. However, that
        code was not removed from FrameLoaderClient::finishedLoading in WebKitGtk+.

        Due to this reason, after loading a html document, other ports initialize the
        text encoding from FrameLoaderClient::finishedLoading, but WebKitGtk+ sets
        the same encoding again, even tries to set encoding in the provisional phase.
        This causes unnecessary encoding setting.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::FrameLoaderClient): Set m_hasRepresentation to false.
        (WebKit::FrameLoaderClient::makeRepresentation): Set m_hasRepresentation to true.
        (WebKit::FrameLoaderClient::revertToProvisionalState): Set m_hasRepresentation to true.
        (WebKit::FrameLoaderClient::finishedLoading): Skip the encoding setting when
        m_hasRepresentation is false.
        * WebCoreSupport/FrameLoaderClientGtk.h: Added m_hasRepresentation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 04:53:55 +0000 (04:53 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Delete a line that was accidentally missed in r77586; without it
        there is still a race between the two threads.

        https://bugs.webkit.org/show_bug.cgi?id=51572

        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoworker-importScriptsOnError needs to allow for the console error to
levin@chromium.org [Fri, 4 Feb 2011 04:32:24 +0000 (04:32 +0000)]
worker-importScriptsOnError needs to allow for the console error to
flush out before calling notifyDone.

Reviewed by Adam Barth.

* http/tests/workers/worker-importScriptsOnError-expected.txt:
* http/tests/workers/worker-importScriptsOnError.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 4 Feb 2011 04:24:29 +0000 (04:24 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        Add another XSSFilter PerformanceTest
        https://bugs.webkit.org/show_bug.cgi?id=53750

        This PerformanceTest tests the case that was slow in
        https://bugs.webkit.org/show_bug.cgi?id=49845

        * XSSFilter/large-post-many-inline-scripts-and-events.html: Added.
        * XSSFilter/resources: Added.
        * XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 04:07:12 +0000 (04:07 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt: handle "broken pipe" notifications from DRT more cleanly.

        https://bugs.webkit.org/show_bug.cgi?id=52927

        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 4 Feb 2011 04:05:49 +0000 (04:05 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Attempt to fix Chromium build.

        * html/parser/XSSFilter.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 4 Feb 2011 04:02:02 +0000 (04:02 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add PerformanceTest for XSSFilter
        https://bugs.webkit.org/show_bug.cgi?id=53741

        This performance tests covers the case of a large POST data and many
        small event handlers.

        * XSSFilter: Added.
        * XSSFilter/large-post-many-events.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 03:59:26 +0000 (03:59 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, rolling out r77562.
        http://trac.webkit.org/changeset/77562
        https://bugs.webkit.org/show_bug.cgi?id=53630

        broke chromium mac build

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gyp/mac/check_objc_rename.sh: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 4 Feb 2011 03:56:40 +0000 (03:56 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        XSS Auditor severely affects loading performance after submitting a large form
        https://bugs.webkit.org/show_bug.cgi?id=49845

        The XSSFilter catches some more cases and has different console
        messages than the XSSAuditor.  We might want to improve these messages
        in the future.

        * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-expected.txt:
        * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
        * http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/full-block-base-href-expected.txt:
        * http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
        * http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-tag-expected.txt:
        * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
        * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Daniel Bates.

        XSS Auditor severely affects loading performance after submitting a large form
        https://bugs.webkit.org/show_bug.cgi?id=49845

        Switch over from the XSSAuditor to the XSSFilter, improving performance
        on this example.

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::filterToken):
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::isEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 03:30:26 +0000 (03:30 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, rolling out r77567.
        http://trac.webkit.org/changeset/77567
        https://bugs.webkit.org/show_bug.cgi?id=53468

        broke chromium linux svg, canvas tests, possibly win also?

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::getImageData):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::putImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 4 Feb 2011 03:12:36 +0000 (03:12 +0000)]
2011-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kenneth Russell.

        Update, resubmit change to bug 51572. I think the race that was
        fixed in r76703 caused the hang that caused us to roll this
        patch out before, so I'd like to try again.

        https://bugs.webkit.org/show_bug.cgi?id=51572

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDownload bundles should be moved to their final destination when they
jhoneycutt@apple.com [Fri, 4 Feb 2011 02:59:20 +0000 (02:59 +0000)]
Download bundles should be moved to their final destination when they
finish.

https://bugs.webkit.org/show_bug.cgi?id=53668

Reviewed by Adam Roben.

* WebProcess/Downloads/Download.cpp:
(WebKit::Download::Download):
Initialize m_allowOverwrite.
(WebKit::Download::retrieveDestinationWithSuggestedFilename):
Return the result of requesting the destination filename from the UI
process.
(WebKit::Download::decideDestinationWithSuggestedFilename):
Call retrieveDestinationWithSuggestedFilename().
(WebKit::Download::didFinish):
Call platformDidFinish().

* WebProcess/Downloads/Download.h:
Declare retrieveDestinationWithSuggestedFilename() and
platformDidFinish(). Add a member variable to store whether the UI
process would like us to overwrite existing files.

* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::willResumeWithResponseCallback):
Remove some trailing whitespace.

* WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::platformDidFinish):
Stubbed.

* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::platformDidFinish):
Stubbed.

* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::platformDidFinish):
Stubbed.

* WebProcess/Downloads/cf/win/DownloadCFNetWin.cpp:
(WebKit::Download::didDecideDestination):
Store whether the UI process would like us to overwrite existing files.
(WebKit::Download::platformDidFinish):
Try to move the bundle to the final destination. If that fails, ask the
UI process for a new destination. If we receive one, try again to move
the bundle. Call didCreateDestination() to report the updated path of
file whether it's the bundle that we failed to move, or the new final
destination.

This is similar to what is done by WebKit 1's CFNetwork port.

* win/WebKit2.vcproj:
Add DownloadWin.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSmall clean-up in DownloadCFNet.cpp.
jhoneycutt@apple.com [Fri, 4 Feb 2011 02:57:36 +0000 (02:57 +0000)]
Small clean-up in DownloadCFNet.cpp.

Rubber-stamped by Mark Rowe.

* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::didDecideDestination):
Moved out of the section labeled "CFURLDownload callbacks" and up near
the other member functions.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 4 Feb 2011 02:56:19 +0000 (02:56 +0000)]
2011-02-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Daniel Bates.

        Skip a test for WebKit2 that uses missing DRT API
        https://bugs.webkit.org/show_bug.cgi?id=53748

        * platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 4 Feb 2011 01:56:50 +0000 (01:56 +0000)]
2011-02-03  Abhishek Arya  <inferno@chromium.org>

        Unreviewed, simple qt test baseline.

        * platform/qt/fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-02 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 4 Feb 2011 01:45:55 +0000 (01:45 +0000)]
2011-02-02  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Refactoring: <progress> should not use ShadowElement
        https://bugs.webkit.org/show_bug.cgi?id=53583

        Updated to catch the change on -webkit-progress-bar-value interpretation.

        * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
2011-02-02  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Refactoring: <progress> should not use ShadowElement
        https://bugs.webkit.org/show_bug.cgi?id=53583

        - Introduced RenderIndicatorPart and RenderProgressBarValuePart
          to be responsible for bar-part layout,
          which adopted layout logic from ShadowBlockElement.
        - ProgressBarValueElement is no longer a subclass of ShadowBlockElement.
        - Remove dependency from RenderProgress to HTMLProgressElement and
          ShadowBlockElement.
        - The shadow tree is no longer removed on detach(). It becomes persistent.
          This is now possible because the ShadowBlockElement dependency is gone.
        - ::-webkit-appearance for -webkit-progress-bar-value is no longer referred.
          That didn't make sense.

        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
        * html/HTMLProgressElement.h:
        * html/shadow/ProgressBarValueElement.h: Added.
        (WebCore::ProgressBarValueElement::ProgressBarValueElement):
        (WebCore::ProgressBarValueElement::shadowPseudoId):
        (WebCore::ProgressBarValueElement::createRenderer):
        (WebCore::ProgressBarValueElement::create):
        * rendering/RenderIndicator.cpp:
        (WebCore::RenderIndicatorPart::RenderIndicatorPart):
        (WebCore::RenderIndicatorPart::~RenderIndicatorPart):
        (WebCore::RenderIndicatorPart::layout):
        (WebCore::RenderIndicatorPart::styleDidChange):
        * rendering/RenderIndicator.h: Added RenderIndicatorPart class
        (WebCore::RenderIndicatorPart::originalVisibility):
        (WebCore::RenderIndicatorPart::requiresForcedStyleRecalcPropagation):
        (WebCore::RenderIndicatorPart::canHaveChildren):
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgressBarValuePart::preferredFrameRect):
        (WebCore::RenderProgressBarValuePart::shouldBeHidden):
        (WebCore::RenderProgress::updateFromElement):
        (WebCore::RenderProgress::layoutParts):
        (WebCore::RenderProgress::shouldHaveParts):
        * rendering/RenderProgress.h:
        (WebCore::RenderProgressBarValuePart::RenderProgressBarValuePart):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReversion should not be marked as misspelled.
mitz@apple.com [Fri, 4 Feb 2011 01:40:37 +0000 (01:40 +0000)]
Reversion should not be marked as misspelled.
https://bugs.webkit.org/show_bug.cgi?id=53255

Source/WebCore:

Patch by Jia Pu <jpu@apple.com> on 2011-02-03
This patch includes fix for reported bug, and also some housekeeping changes.

To implement desired behavior, we need:
1. Add a new marker type, SpellCheckingExemption, since now we distingusish between text
   that shouldn't be spellchecked and text shouldn't be autocorrected.
2. Make sure that there is no pending correction panel when we enter markAllMisspellingsAndBadGrammarInRanges().
   Otherwise the spell checking code in that function may interfere with autocorrection. This
   is achieved by explicitly applying pending correction when user types space, line break or
   paragraph break.

Housekeeping code changes include:
1. Change manual-tests that were broken by relocated WebCore directory.
2. Use TextIterator in various DocumentMarkerController functions instead of using
   Node::traverseNextNode() directly.
3. Allow passing multiple marker types into DocumentMarkerController::removeMarkers() and
   DocumentMarkerController::hasMarkers() to improve clarity and efficiency.
4. Fixes of minor bugs that were exposed previously.

* WebCore.exp.in: Change signature of DocumentMarkerController::removeMarkers().

* dom/DocumentMarker.h: Added new marker type SpellCheckingExemption.

* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::removeMarkers): Use TextIterator to scan the range to be
   consistent with addMarker() function. Allow passing in multiple marker types in one call.
   Added a boolean argument to specify the behavior when removing markers that partially
   overlap the specified range.
(WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair): Allow passing in
   multiple marker types in one call.
(WebCore::DocumentMarkerController::hasMarkers): Use TextIterator to scan the range to be
   consistent with addMarker() function. Allow passing in multiple marker types in one call.

* dom/DocumentMarkerController.h: Allow passing in multiple marker types to removeMarkers()
   and hasMarkers(). Added a boolean argument to removeMarkers() to specify the behavior when
   removing markers that partially overlap the specified range.

* editing/Editor.cpp:
(WebCore::markerTypesForAutocorrection): Add SpellCheckingExemption marker when apply correction.
(WebCore::markerTypesForReplacement): Ditto.
(WebCore::Editor::respondToChangedSelection): Reordered call to dismissCorrectionPanel() and
   setSelection() to make sure there is no pending correction when entering
   markAllMisspellingsAndBadGrammarInRanges().
(WebCore::Editor::appliedEditing): Only remove CorrectionIndicator markers when the command
   is a top level command to improve efficiency.
(WebCore::Editor::insertTextWithoutSendingTextEvent): Added code to applying pending correction.
(WebCore::Editor::insertLineBreak): Ditto.
(WebCore::Editor::insertParagraphSeparator): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Don't mark mispelling if the
   text carries SpellCheckingExemption marker.
(WebCore::Editor::correctionPanelTimerFired): Reset correction panel if the returned suggestion
   from spellchecker is an empty string.
(WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
   Use new DocumentMarkerController::removeMarkers() to replace custom implemenation to improve
   efficiency and readability.
(WebCore::Editor::applyCorrectionPanelInfo): Remove the code that set caret position after
   applying correction, since it's unnecessary. Also, store pre-correction string together with
   the marker for reversion panel to use.
(WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate): Apply pending correction.
(WebCore::Editor::changeSelectionAfterCommand): Moved marker removal code to Editor::appliedEditing()
   where we have access to EditCommand object.

* editing/Editor.h: Added new function applyAutocorrectionAfterTypingIfAppropriate().

* manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Change manual-tests that
   were broken by relocated WebCore directory.

* manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Ditto.

* manual-tests/autocorrection/autocorrection-contraction.html: Ditto.

* manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Ditto.

* manual-tests/autocorrection/delete-to-dismiss-reversion.html: Ditto.

* manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Ditto.

* manual-tests/autocorrection/dismiss-multiple-guesses.html: Ditto.

* manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Ditto.

* manual-tests/autocorrection/select-from-multiple-guesses.html: Ditto.

* manual-tests/autocorrection/spell-checking-after-reversion.html: Added.

* manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Change manual-tests that
   were broken by relocated WebCore directory.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarkers): Code clean-up to be more concise.

LayoutTests:

Patch by Jia Pu <jpu@apple.com> on 2011-02-03
Rebaselined tests broken by https://bugs.webkit.org/show_bug.cgi?id=51389

* platform/mac/editing/spelling/autocorrection-contraction-expected.png:
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
* platform/mac/editing/spelling/autocorrection-delete-expected.png:
* platform/mac/editing/spelling/autocorrection-delete-expected.txt:
* platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png:
* platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
* platform/mac/editing/spelling/autocorrection-removing-underline-expected.png:
* platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
* platform/mac/editing/spelling/autocorrection-simple-expected.checksum:
* platform/mac/editing/spelling/autocorrection-simple-expected.png:
* platform/mac/editing/spelling/autocorrection-simple-expected.txt:
* platform/mac/editing/spelling/autocorrection-simple.html:
* platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png:
* platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 4 Feb 2011 01:29:50 +0000 (01:29 +0000)]
2011-02-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Paint non-composited contents in a layer
        https://bugs.webkit.org/show_bug.cgi?id=53742

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setNeedsDisplay):
        Call LayerTreeHost::setNonCompositedContentsNeedDisplayInRect.

        (WebKit::DrawingAreaImpl::scroll):
        Call LayerTreeHost::scrollNonCompositedContents.

        (WebKit::DrawingAreaImpl::setSize):
        Call LayerTreeHost::sizeDidChange.

        * WebProcess/WebPage/LayerTreeHost.h:
        Add new pure virtual member functions.

        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        Create the non-composited content layer.

        (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
        Call setNeedsDisplay on the GraphicsLayer.

        (WebKit::LayerTreeHostMac::scrollNonCompositedContents):
        Just call setNonCompositedContentsNeedDisplayInRect.

        (WebKit::LayerTreeHostMac::sizeDidChange):
        Resize the layers and flush any changes.

        (WebKit::LayerTreeHostMac::paintContents):
        Call WebPage::drawRect.

        (WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
        Lay out the web page.

        (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
        Call syncCompositingStateForThisLayerOnly on the non-composited content layer.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
dcheng@chromium.org [Fri, 4 Feb 2011 01:26:17 +0000 (01:26 +0000)]
Unreviewed.

Adding myself to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 4 Feb 2011 01:25:06 +0000 (01:25 +0000)]
2011-02-03  Abhishek Arya  <inferno@chromium.org>

        Unreviewed, qt build fix.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeFloatingObject):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 4 Feb 2011 01:19:05 +0000 (01:19 +0000)]
2011-02-03  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Don't clear the callbacks ref in the proxy layer for IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=53535

        Clearing the callbacks doesn't actually solve any problems and makes
        this code behave subtly differently than how it would in Safari and
        other single process environments. Let's remove the difference.

        * src/IDBCallbacksProxy.cpp:
        (WebCore::IDBCallbacksProxy::onError):
        (WebCore::IDBCallbacksProxy::onSuccess):
        * src/IDBTransactionCallbacksProxy.cpp:
        (WebCore::IDBTransactionCallbacksProxy::onAbort):
        (WebCore::IDBTransactionCallbacksProxy::onComplete):
        (WebCore::IDBTransactionCallbacksProxy::onTimeout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInclude the crashing function in the link to a crash log
aroben@apple.com [Fri, 4 Feb 2011 01:17:57 +0000 (01:17 +0000)]
Include the crashing function in the link to a crash log

Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
function that crashed

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests:
(crashLocation): Added. Returns the location of the crash.
(linksForErrorTest): Include the crash location in the link text for the crash log, if one
could be determined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Fri, 4 Feb 2011 01:05:44 +0000 (01:05 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 4 Feb 2011 00:53:51 +0000 (00:53 +0000)]
2011-02-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        When in accelerated compositing mode, wait for DidSetSize messages
        https://bugs.webkit.org/show_bug.cgi?id=53736

        Normally we wait for DidSetSize messages from ::paint, but that's never called in
        accelerated compositing mode so we just do it right after sending the SetSize message.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::paint):
        Call waitForAndDispatchDidSetSize.

        (WebKit::DrawingAreaProxyImpl::sendSetSize):
        Call waitForAndDispatchDidSetSize when in accelerated compositing mode.

        (WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize):
        New utility function which waits for and dispatches a DidSetSize message.

        * UIProcess/DrawingAreaProxyImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Brian Salomon <bsalomon@google.com>
commit-queue@webkit.org [Fri, 4 Feb 2011 00:52:25 +0000 (00:52 +0000)]
2011-02-03  Brian Salomon  <bsalomon@google.com>

        Reviewed by James Robinson.

        NHandle non-raster backed images in getUnmultipliedImageData()
        https://bugs.webkit.org/show_bug.cgi?id=53468

        No new tests. Existing canvas tests sufficient
        LayoutTests/canvas/philip/...

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::getImageData):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::putImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Fri, 4 Feb 2011 00:51:19 +0000 (00:51 +0000)]
2011-02-03  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        Chromium: Remove deprecated WebIDBObjectStore::put() function
        https://bugs.webkit.org/show_bug.cgi?id=53669

        Remove deprecated put() function. Chromium side code now overrides
        the new version.

        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::put):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 4 Feb 2011 00:51:12 +0000 (00:51 +0000)]
2011-02-03  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        Tests that we do not crash when overflowing the height of a root
        inline box.
        https://bugs.webkit.org/show_bug.cgi?id=53729

        * fast/overflow/overflow-height-float-not-removed-crash-expected.txt: Added.
        * fast/overflow/overflow-height-float-not-removed-crash.html: Added.
2011-02-03  Abhishek Arya  <inferno@chromium.org>

        Reviewed by James Robinson.

        Enforce more limits on root inline boxes height calculations.
        https://bugs.webkit.org/show_bug.cgi?id=53729

        Test: fast/overflow/overflow-height-float-not-removed-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeFloatingObject): prevent logicalBottom to
        become negative when logicalTop is INT_MAX.
        (WebCore::RenderBlock::markLinesDirtyInBlockRange): when logicalBottom
        is INT_MAX, we should dirty everything. So, we bail out to make
        afterLowest equal to the lastRootBox() or lowestDirstLine.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge PerformanceTests/Parser/ChangeLog and
abarth@webkit.org [Fri, 4 Feb 2011 00:49:03 +0000 (00:49 +0000)]
Merge PerformanceTests/Parser/ChangeLog and
PerformanceTests/PageLoad/ChangeLog into PerformanceTests/ChangeLog.

Rubber-stamped by Eric Seidel.

It's silly to have ChangeLogs for each of these directories separately.
I've left SunSpider with its own ChangeLog because it's more of an
independent entity.

* ChangeLog: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWorker.importScript() should clean errors for cross origin imports.
levin@chromium.org [Fri, 4 Feb 2011 00:48:28 +0000 (00:48 +0000)]
Worker.importScript() should clean errors for cross origin imports.
https://bugs.webkit.org/show_bug.cgi?id=52871

Reviewed by Adam Barth and Oliver Hunt.

Source/WebCore:

Test: http/tests/workers/worker-importScriptsOnError.html

* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate): Use sanitizeScriptError
to determine when to create a clean exception.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::evaluate): Ditto.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::sanitizeScriptError): Figure out
if the error needs to be cleaned up.
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Extracted
sanitizeScriptError for use by other places.
* dom/ScriptExecutionContext.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts): Use the reponse url when
telling the evaluate where the script came fro.
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::responseURL): Expose the url that
the script was loaded from (which may be different from url() due
to redirects).
(WebCore::WorkerScriptLoader::didReceiveResponse): Capture the reponse url.
* workers/WorkerScriptLoader.h:

LayoutTests:

* http/tests/workers/resources/worker-importScripts-error.js: Added.
* http/tests/workers/resources/worker-importScripts-throw.js: Added.
* http/tests/workers/worker-importScriptsOnError.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Mark Mentovai <mark@chromium.org>
commit-queue@webkit.org [Fri, 4 Feb 2011 00:46:32 +0000 (00:46 +0000)]
2011-02-03  Mark Mentovai  <mark@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium GYP build fix.

        When various settings were moved to webcore_prerequisites in r66364,
        things that should have been direct_dependent_settings were not marked
        as such. GYP 'defines', for example, make no sense on a 'none'-type
        target such as webcore_prerequisites. It appears that it was intended
        for these settings to be pushed to direct dependents, which would make
        direct_dependent_settings correct.

        Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
        http://crbug.com/71537, which at best causes Mac console log spew, and
        at worst may result in Chromium's copy of WebCore using system
        definitions of certain Objective-C classes at runtime, or vice-versa.

        The build now includes a postbuild step to prevent
        http://crbug.com/71537 from regressing again. The build will fail upon
        regression.

        https://bugs.webkit.org/show_bug.cgi?id=53630

        * WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into
          direct_dependent_settings as needed, add the check_objc_rename
          postbuild step.
        * WebCore.gyp/mac/check_objc_rename.sh: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 4 Feb 2011 00:42:47 +0000 (00:42 +0000)]
2011-02-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Pass along an UpdateInfo object to the ExitAcceleratedCompositingMode message
        https://bugs.webkit.org/show_bug.cgi?id=53734

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
        Add an UpdateInfo parameter.

        * UIProcess/DrawingAreaProxy.messages.in:
        Add an UpdateInfo parameter to the ExitAcceleratedCompositingMode message.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
        Incorporate the passed in update.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        Create a new UpdateInfo object, paint into it and pass it along as a parameter
        to the ExitAcceleratedCompositingMode message.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 4 Feb 2011 00:41:58 +0000 (00:41 +0000)]
2011-02-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make XSSFilter go fast by adding a SuffixTree
        https://bugs.webkit.org/show_bug.cgi?id=53665

        The SuffixTree lets us quickly reject snippets if the POST data is
        large (because we can avoid a linear scan over the POST data).

        * html/parser/XSSFilter.cpp:
        (WebCore::XSSFilter::init):
        (WebCore::XSSFilter::isContainedInRequest):
        * html/parser/XSSFilter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 4 Feb 2011 00:40:23 +0000 (00:40 +0000)]
2011-02-03  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r77355): Page cache layout tests crash
        https://bugs.webkit.org/show_bug.cgi?id=53648

        Add test that calls setTimeout during a pagehide event handler (the
        timeout should not fire while the document is in the page cache).

        Skipped for Chromium since it doesn't use the page cache.

        * fast/events/pagehide-timeout-expected.txt: Added.
        * fast/events/pagehide-timeout.html: Added.
        * fast/events/resources/pagehide-timeout-go-back.html: Added.
        * platform/chromium/test_expectations.txt:
2011-02-03  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r77355): Page cache layout tests crash
        https://bugs.webkit.org/show_bug.cgi?id=53648

        Test: fast/events/pagehide-timeout.html

        Suspend active DOM objects after all pagehide event handlers have run,
        otherwise it's possible for them to create more objects that weren't
        getting suspended.

        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::CachedFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 4 Feb 2011 00:37:11 +0000 (00:37 +0000)]
2011-02-03  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        SerializedScriptValue should not require v8 to create undefined and null values
        https://bugs.webkit.org/show_bug.cgi?id=53730

        Instead of creating a v8 type and passing that into the constructor, just use
        the writer class directly. While I was at it, I cleaned up the code a bit too
        by getting rid of the WireData/StringValue enum as I found that personally
        confusing.

        This is necessary because these methods are called by IndexedDB in the browser
        process where v8 is not spun up.

        No functionality changed and not possible to test.

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::createFromWire):
        (WebCore::SerializedScriptValue::create):
        (WebCore::SerializedScriptValue::nullValue):
        (WebCore::SerializedScriptValue::undefinedValue):
        (WebCore::SerializedScriptValue::release):
        (WebCore::SerializedScriptValue::SerializedScriptValue):
        * bindings/v8/SerializedScriptValue.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 4 Feb 2011 00:27:37 +0000 (00:27 +0000)]
2011-02-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Not all blocks are freed when the heap is freed (counting is hard!)
        https://bugs.webkit.org/show_bug.cgi?id=53732

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::destroy): Freeing a block compacts the list, so just
        keep freeing block 0 until there are no blocks left.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77557 268f45cc-cd09-0410-ab3c-d52691b4dbfc