WebKit.git
9 years agoAdd Peter Beverloo's feed to Planet WebKit
rik@webkit.org [Sun, 30 Oct 2011 22:06:03 +0000 (22:06 +0000)]
Add Peter Beverloo's feed to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=70316

Reviewed by Andreas Kling.

* config.ini:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove crash expectations from tests that have not been crashing on Chromium.
rniwa@webkit.org [Sun, 30 Oct 2011 19:34:32 +0000 (19:34 +0000)]
Remove crash expectations from tests that have not been crashing on Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Switch to a backing store approach for painting WebKitWebView
mrobinson@webkit.org [Sun, 30 Oct 2011 16:29:33 +0000 (16:29 +0000)]
[GTK] Switch to a backing store approach for painting WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70213

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. The changes to WebCore should not change
behavior. The changes in WebKit are covered by existing
tests.

* platform/cairo/WidgetBackingStore.h:
(WebCore::WidgetBackingStore::size): Added this getter for the size.
* platform/cairo/WidgetBackingStoreCairo.cpp:
(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
(WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.
* platform/graphics/cairo/CairoUtilities.h:
* platform/gtk/GtkWidgetBackingStoreX11.cpp:
(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.

Source/WebKit/gtk:

Paint the WebView into a backing store. This prevents expose events from
triggering a layout, making scrolling and resizing much smoother.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::ChromeClient): Initialize new members.
(WebKit::repaintEverythingSoonTimeout): Added this helper which repaints
the WebView more quickly during resize events.
(WebKit::clipOutOldWidgetArea): Clips out the old widget area, so that we
can clear out invalid pixels when growing the widget into a pre-existing
backing store.
(WebKit::clearEverywhereInBackingStore): Clear out the entire backing store.
(WebKit::ChromeClient::widgetSizeChanged): Handle widget size changes by
intelligently resizing or reusing the existing backing store.
(WebKit::coalesceRectsIfPossible): Moved this method from webkitwebview.cpp.
(WebKit::paintWebView): Moved this method from webkitwebview.cpp.
(WebKit::ChromeClient::performAllPendingScrolls): If there are any pending
scrolling operations, perform them by scrolling the backing store.
(WebKit::ChromeClient::paint): Added this timer callback, which paints the
WebView after a short timeout.
(WebKit::ChromeClient::invalidateWindow): No need to do anything here any longer.
(WebKit::ChromeClient::invalidateContentsAndWindow): Now unite the rect with
the existing dirty region and queue the paint timeout.
(WebKit::ChromeClient::scroll): Now just queue a scroll event in the repaint timeout.
Intelligently calculate the area to move and the dirty area using code derived
from WebKit2.
* WebCoreSupport/ChromeClientGtk.h: Added new method definitions and also use
the WebCore namespace to avoid lots of uses of "WebCore::".
* webkit/webkitwebview.cpp:
(webkit_web_view_draw): Now just blit the backing store into the widget.
(webkit_web_view_expose): Ditto.
(webkit_web_view_size_allocate): Let the ChromeClient know the widget size changed.
(webkit_web_view_init): Turn off GDK double buffering as we have our own double
buffer.
* webkit/webkitwebviewprivate.h: Add the backing store member.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98803.
commit-queue@webkit.org [Sun, 30 Oct 2011 16:03:52 +0000 (16:03 +0000)]
Unreviewed, rolling out r98803.
http://trac.webkit.org/changeset/98803
https://bugs.webkit.org/show_bug.cgi?id=71186

Causing test and assertion failures on some platforms
(Requested by anttik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sun, 30 Oct 2011 07:57:04 +0000 (07:57 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.  I would have preferred to have this reviewed,
but relevant reviewers are asleep and bots are broken.

This was a regression from moving to a clean environment.
ChromiumWin (and possibly other ports), need the "PATH"
environment copied over.  This wasn't caught in my testing
because although we had unittests to cover this, they
weren't being run on anything but windows.  The vast majority
of this change is just fixing the unittests to use our
modern MockFileSystem/MockUser/MockExecutive so they can
be run on any system (and removing the platform checks from
the unittests so they are run everywhere).

The actual fix is the single line "PATH" string added to base.py.
The rest of this change is just fixing the Chromium port unittests
to run on all systems (including changing the Chromium port to
use FileSystem.path_to_module instead of __file__).

* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mrowe@apple.com [Sun, 30 Oct 2011 05:36:14 +0000 (05:36 +0000)]
Build fix.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sun, 30 Oct 2011 03:06:10 +0000 (03:06 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

Fix the Qt port and unittest the function so we don't break it again.

* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mrowe@apple.com [Sun, 30 Oct 2011 00:45:50 +0000 (00:45 +0000)]
Build fix.

* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename DataTransferItems to DataTransferItemList
dcheng@chromium.org [Sat, 29 Oct 2011 23:27:38 +0000 (23:27 +0000)]
Rename DataTransferItems to DataTransferItemList
https://bugs.webkit.org/show_bug.cgi?id=71151

Per feedback that Items and Item are hard to distinguish between, the HTML5 spec renamed
DataTransferItems to DataTransferItemList:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransferitemlist-interface

Reviewed by Tony Chang.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Clipboard.h:
* dom/Clipboard.idl:
* dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTransferItems.cpp.
(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::length):
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::deleteItem):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::add):
* dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransferItems.h.
(WebCore::DataTransferItemList::~DataTransferItemList):
* dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTransferItems.idl.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::items):
* platform/chromium/ClipboardChromium.h:
* platform/chromium/DataTransferItemListChromium.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::addPasteboardItem):
* platform/chromium/DataTransferItemListChromium.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.h.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::items):
* platform/qt/ClipboardQt.h:
* platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.cpp.
(WebCore::DataTransferItemListQt::create):
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::addPasteboardItem):
* platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd track-text-track-destructor-crash.html to Skipped files for mac and win
annacc@chromium.org [Sat, 29 Oct 2011 22:55:54 +0000 (22:55 +0000)]
Add track-text-track-destructor-crash.html to Skipped files for mac and win
https://bugs.webkit.org/show_bug.cgi?id=71182

Reviewed by Ryosuke Niwa.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sat, 29 Oct 2011 22:06:50 +0000 (22:06 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment just like ORWT did.
I've manually validated that NRWT now copies over
the same environment variables that ORWT did.
This new code is exercised by existing setup_environ_for_server tests.

* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/efl.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac rebaseline after r98813.
rniwa@webkit.org [Sat, 29 Oct 2011 22:04:11 +0000 (22:04 +0000)]
Mac rebaseline after r98813.

* platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/mac/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
rniwa@webkit.org [Sat, 29 Oct 2011 21:34:30 +0000 (21:34 +0000)]
Add flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
The failure is tracked by the bug 71181.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK+ and Qt rebaselines after r98794.
rniwa@webkit.org [Sat, 29 Oct 2011 21:20:17 +0000 (21:20 +0000)]
GTK+ and Qt rebaselines after r98794.

* platform/gtk/editing/pasteboard/5134759-expected.txt:
* platform/qt/editing/pasteboard/5134759-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSecond attempt to add results for tests introduced in http://trac.webkit.org/changese...
robert@webkit.org [Sat, 29 Oct 2011 20:35:10 +0000 (20:35 +0000)]
Second attempt to add results for tests introduced in trac.webkit.org/changeset/98812

* platform/chromium-linux/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png.
* platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt and Gtk Results for tests updated by http://trac.webkit.org/changeset/98812
robert@webkit.org [Sat, 29 Oct 2011 20:14:40 +0000 (20:14 +0000)]
Qt and Gtk Results for tests updated by  trac.webkit.org/changeset/98812

Unreviewed, platform-specific results.

* platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd results for tests introduced in http://trac.webkit.org/changeset/98812.
robert@webkit.org [Sat, 29 Oct 2011 20:06:48 +0000 (20:06 +0000)]
Add results for tests introduced in trac.webkit.org/changeset/98812.

Unreviewed, platform-specific results.

* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png.
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: block-non-replaced-width-008.htm
robert@webkit.org [Sat, 29 Oct 2011 19:15:51 +0000 (19:15 +0000)]
CSS 2.1 failure: block-non-replaced-width-008.htm
https://bugs.webkit.org/show_bug.cgi?id=69278

Reviewed by Simon Fraser.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthUsing):
  Include the margins in the calculation of logical width even when the containing block's
  width is zero. This is required by section '10.3.3 Block-level, non-replaced elements in
  normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-008.htm in the CSS
  test suite.

LayoutTests:

* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  The pixel result is preserved, but the width of the containing block in the render
  tree now accurately reflects the rendered size of the cells.
* platform/chromium/test_expectations.txt:
* platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.png:
* platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd results for tests introduced in http://trac.webkit.org/changeset/98805.
abarth@webkit.org [Sat, 29 Oct 2011 18:58:42 +0000 (18:58 +0000)]
Add results for tests introduced in trac.webkit.org/changeset/98805.

* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Removed.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-win-vista/css2.1: Removed.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-004-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate results after http://trac.webkit.org/changeset/98794 to remove
abarth@webkit.org [Sat, 29 Oct 2011 18:29:31 +0000 (18:29 +0000)]
Update results after trac.webkit.org/changeset/98794 to remove
0x0 DIV from the render tree.

* platform/chromium-win/editing/pasteboard/5134759-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate line number in baseline.
abarth@webkit.org [Sat, 29 Oct 2011 18:26:04 +0000 (18:26 +0000)]
Update line number in baseline.

* platform/chromium-linux-x86/fast/dom: Removed.
* platform/chromium/fast/dom/nested-script-exceptions-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlatform-specific results for r98805
robert@webkit.org [Sat, 29 Oct 2011 17:28:01 +0000 (17:28 +0000)]
Platform-specific results for r98805

Unreviewed, add new results.

* platform/gtk/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/gtk/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake sure TextTracks are destructed if HTMLMediaElement goes away.
annacc@chromium.org [Sat, 29 Oct 2011 16:52:23 +0000 (16:52 +0000)]
Make sure TextTracks are destructed if HTMLMediaElement goes away.
https://bugs.webkit.org/show_bug.cgi?id=71148

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-text-track-destructor-crash.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
    Destroy the client (this) on TextTracks.
(WebCore::HTMLMediaElement::loadTextTracks):
    Move TextTrack creation to loadNextTextTrack.
(WebCore::HTMLMediaElement::loadNextTextTrack):
    Keep track of new TextTrack in a list.
(WebCore::HTMLMediaElement::addTrack):
    Keep track of new TextTrack in a list.
* html/HTMLMediaElement.h:
    Add m_textTracks and loadNextTextTrack().

LayoutTests:

* media/track/track-text-track-destructor-crash-expected.txt: Added.
* media/track/track-text-track-destructor-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement IDBFactory.deleteDatabase
jochen@chromium.org [Sat, 29 Oct 2011 16:18:44 +0000 (16:18 +0000)]
Implement IDBFactory.deleteDatabase
https://bugs.webkit.org/show_bug.cgi?id=62622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/factory-deletedatabase-interactions.html
       storage/indexeddb/factory-deletedatabase.html

* storage/IDBBackingStore.h:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::deleteDatabase):
* storage/IDBFactory.h:
* storage/IDBFactory.idl:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
* storage/IDBLevelDBBackingStore.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):

Source/WebKit/chromium:

* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::deleteDatabase):
* src/IDBFactoryBackendProxy.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
(WebKit::WebIDBFactoryImpl::deleteDatabase):
* src/WebIDBFactoryImpl.h:

LayoutTests:

* storage/indexeddb/factory-basics-expected.txt: Updated.
* storage/indexeddb/factory-basics.html: Updated.
* storage/indexeddb/factory-deletedatabase-expected.txt: Added.
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Added.
* storage/indexeddb/factory-deletedatabase-interactions.html: Added.
* storage/indexeddb/factory-deletedatabase.html: Added.
* storage/indexeddb/open-close-version-expected.txt: Updated.
* storage/indexeddb/open-close-version.html: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: dynamic-top-change-001 to 004 fail
robert@webkit.org [Sat, 29 Oct 2011 14:52:05 +0000 (14:52 +0000)]
CSS 2.1 failure: dynamic-top-change-001 to 004 fail
https://bugs.webkit.org/show_bug.cgi?id=68149

Reviewed by David Hyatt.

Source/WebCore:

In these tests a child inherits its top value from its parent and the parent's top value
is later updated by an onload event. The updated value is expected to cascade to the child.

The tests were failing because updating the value did not cascade immediately to the child inheriting it, though
it could be forced eventually with a full recalculation of the RenderStyle by changing the zoom factor
or opening the inspector.

The fix is to let the parent RenderStyle know that a child inherits a property explicitly and
recalculate children's style if the parent ever changes. This only happens if the property is inherited
explicitly, it does not apply to cases where the property is inherited by default.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setHasExplicitlyInheritedProperties):
(WebCore::InheritedFlags::hasExplicitlyInheritedProperties):

LayoutTests:

* css2.1/20110323/dynamic-top-change-001.htm: Added.
* css2.1/20110323/dynamic-top-change-002.htm: Added.
* css2.1/20110323/dynamic-top-change-003.htm: Added.
* css2.1/20110323/dynamic-top-change-004.htm: Added.
* fast/table/border-collapsing/cached-change-tbody-border-color-expected.png:
  See https://bugs.webkit.org/show_bug.cgi?id=68149#c15
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
kbalazs@webkit.org [Sat, 29 Oct 2011 14:45:23 +0000 (14:45 +0000)]
new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Patch by Eric Seidel <eric@webkit.org> on 2011-10-29
Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTighten font change conditions in matched declaration cache
antti@apple.com [Sat, 29 Oct 2011 09:36:12 +0000 (09:36 +0000)]
Tighten font change conditions in matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=71026

Reviewed by Darin Adler.

We currently test if font description has changed to see if all properties need to be applied. However
only a few size related metrics can actually affect other properties. We can just test those, making
the cache somewhat more effective while also making the equality test faster.

* css/CSSStyleSelector.cpp:
(WebCore::fontDifferenceAffectsNonInherited):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

    Test for text computedSize, xHeight and orientation only. Other text properties don't affect computed
    values of non-text CSS properties.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDOMURL should keep its own state rather than storing it on ScriptExecutionContext
abarth@webkit.org [Sat, 29 Oct 2011 09:10:31 +0000 (09:10 +0000)]
DOMURL should keep its own state rather than storing it on ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=71169

Reviewed by Eric Seidel.

This patch untwists this code.  I think this code was originally
twisted because these APIs moved onto DOMURL after they were first
implemented.

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* fileapi/FileWriter.h:
* html/DOMURL.cpp:
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):
* html/DOMURL.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98780.
commit-queue@webkit.org [Sat, 29 Oct 2011 08:21:28 +0000 (08:21 +0000)]
Unreviewed, rolling out r98780.
http://trac.webkit.org/changeset/98780
https://bugs.webkit.org/show_bug.cgi?id=71173

Broke Qt bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-29

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
antti@apple.com [Sat, 29 Oct 2011 07:58:04 +0000 (07:58 +0000)]
REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Ryosuke Niwa.

In an effort to gain Hyatt points, add a less obscure test for this case.

* fast/css/inherited-properties-explicit-expected.txt: Added.
* fast/css/inherited-properties-explicit.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98795.
commit-queue@webkit.org [Sat, 29 Oct 2011 07:19:26 +0000 (07:19 +0000)]
Unreviewed, rolling out r98795.
http://trac.webkit.org/changeset/98795
https://bugs.webkit.org/show_bug.cgi?id=71171

Causes worker tests to crash (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-29

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::contextDestroyed):
* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):
* dom/MessagePort.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac rebaseline after r98617.
rniwa@webkit.org [Sat, 29 Oct 2011 07:04:15 +0000 (07:04 +0000)]
Mac rebaseline after r98617.

* platform/mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline after r98775.
rniwa@webkit.org [Sat, 29 Oct 2011 06:41:28 +0000 (06:41 +0000)]
Rebaseline after r98775.

* fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPotential crash in ReplaceNodeWithSpanCommand
rniwa@webkit.org [Sat, 29 Oct 2011 06:31:16 +0000 (06:31 +0000)]
Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMessagePort should be a ContextDestructionObserver
abarth@webkit.org [Sat, 29 Oct 2011 05:51:51 +0000 (05:51 +0000)]
MessagePort should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=71167

Reviewed by Eric Seidel.

I couldn't quite get rid of all the uses of the
ScriptExecutionContext::m_messagePorts in this patch.  I hope to get
rid of them in the future as the "extra data" design for
ScriptExecutionContext emerges.

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::contextDestroyed):
* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):
* dom/MessagePort.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe copy and paste result in nested scrollbars on http://dojotoolkit.org/widgets
rniwa@webkit.org [Sat, 29 Oct 2011 05:27:07 +0000 (05:27 +0000)]
The copy and paste result in nested scrollbars on dojotoolkit.org/widgets
https://bugs.webkit.org/show_bug.cgi?id=70799

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit's treating a fully selected root with background property as a special common ancestor.
A variant of this bug was caused by treating any element with text-decoration property as a presentational element.

Fixed the above two bugs by not serializing the said nodes. The effective background color was already serialized
by wrappingStyleForSerialization, there was nothing to be done besides stop including it in highestAncestorToWrapMarkup.

For text-decoration property, added the logic to compute the effective value in EditingStyle::init. Also treat it
as a non-inheritable editing property so that the rest of EditingStyle just works.

Test: editing/pasteboard/avoid-copying-body-with-background.html

* editing/EditingStyle.cpp: Added CSSPropertyTextDecoration to the list of editing properties.
(WebCore::copyEditingProperties):
(WebCore::EditingStyle::init): Compute the effective text decoration when propertiesToInclude is
EditingPropertiesInEffect.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
* editing/EditingStyle.h: Renamed EditingInheritablePropertiesAndBackgroundColorInEffect to
EditingPropertiesInEffect.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Removed an assertion that's no longer valid.
(WebCore::isElementPresentational): Don't consider an element with text-decoration as a presentational element.
(WebCore::highestAncestorToWrapMarkup): Don't consider fully selected root as a special common ancestor ever.
Background color is computed property when we compute the wrapping style.
(WebCore::createMarkup):

LayoutTests:

Added a test to copy contents inside a body with background and text-decoration properties.

WebKit should not copy body element.

* editing/deleting/delete-line-break-before-underlined-content-expected.txt: an erroneous inline div
is replaced by a span.
* editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: two style spans are
merged into one.
* editing/pasteboard/19644-2-expected.txt: div is replaced by span. This is okay because it's the only
content in the body. Even though we now only put the gray background under text as inline style as
opposed to apply at the block level, that's what execCommand('BackColor'...) does and what user expects.
* editing/pasteboard/avoid-copying-body-with-background-expected.txt: Added.
* editing/pasteboard/avoid-copying-body-with-background.html: Added.
* editing/pasteboard/preserve-underline-color-expected.txt:
* platform/mac/editing/pasteboard/5134759-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename ExceptionCodeDescription.in to DOMExceptions.in
abarth@webkit.org [Sat, 29 Oct 2011 01:56:13 +0000 (01:56 +0000)]
Rename ExceptionCodeDescription.in to DOMExceptions.in
https://bugs.webkit.org/show_bug.cgi?id=71157

Reviewed by Eric Seidel.

.:

* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

This file is now used for more than just the descriptions of the exceptions.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
* dom/DOMExceptions.in: Copied from Source/WebCore/dom/ExceptionCodeDescription.in.
* dom/ExceptionCodeDescription.in: Removed.
* dom/make_dom_exceptions.pl: Copied from Source/WebCore/dom/make_exception_code_description.pl.
* dom/make_exception_code_description.pl: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSincResampler must be able to resample progressively
crogers@google.com [Sat, 29 Oct 2011 01:47:50 +0000 (01:47 +0000)]
SincResampler must be able to resample progressively
https://bugs.webkit.org/show_bug.cgi?id=71131

Reviewed by Kenneth Russell.

No new tests.  There is not yet an implementation using progressive resampling to test.

* platform/audio/SincResampler.cpp:
(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::consumeSource):
(WebCore::SincResampler::process):
* platform/audio/SincResampler.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] Support attributeOldValue for attribute mutations
adamk@chromium.org [Sat, 29 Oct 2011 01:31:04 +0000 (01:31 +0000)]
[MutationObservers] Support attributeOldValue for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70861

Reviewed by Ryosuke Niwa.

Source/WebCore:

Respect 'attributeOldValue' when passed to WebKitMutationObserver.observe().

If multiple observers have different attributeOldValue settings in
their registrations, two different MutationRecords are created (one is
a wrapper around the other).

If a single observer has multiple registrations that apply to a single
mutation, and those registrations have different values for
attributeOldValue, the observer is passed the oldValue.

* dom/Element.cpp:
(WebCore::hasOldValue):
(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):
* dom/MutationRecord.cpp:
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createWithNullOldValue):
* dom/MutationRecord.h:
(WebCore::MutationRecord::oldValue):

LayoutTests:

Added test cases for attributeOldValue to existing tests.

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDelete ExceptionCode.cpp, which is empty
abarth@webkit.org [Sat, 29 Oct 2011 01:14:41 +0000 (01:14 +0000)]
Delete ExceptionCode.cpp, which is empty
https://bugs.webkit.org/show_bug.cgi?id=71159

Reviewed by Eric Seidel.

This file has been stripped down to nothing and can be removed.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/ExceptionCode.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98776.
commit-queue@webkit.org [Sat, 29 Oct 2011 00:51:37 +0000 (00:51 +0000)]
Unreviewed, rolling out r98776.
http://trac.webkit.org/changeset/98776
https://bugs.webkit.org/show_bug.cgi?id=71164

caused lots of test crashes (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateVisibilityStatus):
(WebCore::RenderLayer::dirtyZOrderLists):
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode):

LayoutTests:

* animations/resources/animation-test-helpers.js:
(checkExpectedValue):
* compositing/visibility/animation-visibility-expected.png: Removed.
* compositing/visibility/animation-visibility-expected.txt: Removed.
* compositing/visibility/animation-visibility.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprovement to the fix for:
sullivan@apple.com [Sat, 29 Oct 2011 00:32:36 +0000 (00:32 +0000)]
Improvement to the fix for:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Dan Bernstein.

* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
Do the frame->settings() check after the !page check, since
a null page means null settings.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake DOMURL a ContextDestructionObserver
abarth@webkit.org [Sat, 29 Oct 2011 00:30:00 +0000 (00:30 +0000)]
Make DOMURL a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=71162

Reviewed by Eric Seidel.

This removes a bunch of hand-rolled ifdefed code.

* dom/ActiveDOMObject.h:
    - One-argument constructors should be explicit.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):
* html/DOMURL.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove this horribly outdated file. It was showing up in
dino@apple.com [Sat, 29 Oct 2011 00:10:11 +0000 (00:10 +0000)]
Remove this horribly outdated file. It was showing up in
Google searches and shouldn't be used as official
documentation.

Rubber-stamped by Simon Fraser.

* specs/MediaQueriesExtensions.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit.py gdb visualizer is broken after change to StringImpl
commit-queue@webkit.org [Sat, 29 Oct 2011 00:03:46 +0000 (00:03 +0000)]
webkit.py gdb visualizer is broken after change to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=71154

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

r98624 changed StringImpl m_data to m_data32. This changes updates
webkit.py to match.

* gdb/webkit.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFactor ContextDestructionObserver out of ActiveDOMObject
abarth@webkit.org [Fri, 28 Oct 2011 23:57:21 +0000 (23:57 +0000)]
Factor ContextDestructionObserver out of ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=71153

Reviewed by Sam Weinig.

This patch paves the way to make more objects observe the destruction
of ScriptExecutioContext without needing to add ifdefs to
ScriptExecutionContext.h/cpp.  (As an example, see DOMURL.)

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* dom/ActiveDOMObject.h:
(WebCore::ContextDestructionObserver::scriptExecutionContext):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
(WebCore::didCreateDestructionObserver):
(WebCore::willDestroyDestructionObserver):
* dom/ScriptExecutionContext.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names
joepeck@webkit.org [Fri, 28 Oct 2011 23:51:12 +0000 (23:51 +0000)]
<webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names

Reviewed by Dan Bernstein.

* Scripts/check-for-inappropriate-objc-class-names:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for sending scroll-update events from EventSender.
commit-queue@webkit.org [Fri, 28 Oct 2011 23:44:30 +0000 (23:44 +0000)]
Add support for sending scroll-update events from EventSender.
https://bugs.webkit.org/show_bug.cgi?id=66272

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-10-28
Reviewed by Adam Barth.

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::reset):
(EventSender::gestureScrollUpdate):
(EventSender::gestureEvent):
* DumpRenderTree/chromium/EventSender.h:

LayoutTests:

* fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
* fast/events/touch/gesture/gesture-scroll.html: Added.
* platform/chromium/fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
jeffm@apple.com [Fri, 28 Oct 2011 23:35:08 +0000 (23:35 +0000)]
More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=71156

Don't include PDF and PostScript types in the set of MIME types with custom representations
when initializing the web process if WebKitOmitPDFSupport is set.

I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
shown inline when this preference was set, but to be complete we should exclude the MIME
types here as well.

Reviewed by Alexey Proskuryakov.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonew-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
eric@webkit.org [Fri, 28 Oct 2011 23:31:41 +0000 (23:31 +0000)]
new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOne more unreviewed build fix due to r98775.
timothy_horton@apple.com [Fri, 28 Oct 2011 23:31:11 +0000 (23:31 +0000)]
One more unreviewed build fix due to r98775.

No new tests.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Track wheel event handler registration and pass to input filter
jamesr@google.com [Fri, 28 Oct 2011 23:30:07 +0000 (23:30 +0000)]
[chromium] Track wheel event handler registration and pass to input filter
https://bugs.webkit.org/show_bug.cgi?id=71078

Reviewed by Kenneth Russell.

Source/WebCore:

This propagates mouse wheel registration notifications to the compositor input filter. If there are any handlers
registered, which includes JS handlers and scrollable areas other than the main view, the input filter will pass
mouse wheel events to the widget. Otherwise when threaded compositing is enabled the input filter translates
wheel events into root layer scrolling.

Only changes behavior with an off-by-default flag enabled, so no tests.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setHaveWheelEventHandlers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers):
* platform/graphics/chromium/cc/CCScrollController.h:

Source/WebKit/chromium:

Pushes mouse wheel event handler notifications to CCLayerTreeHost when compositing.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix due to r98775.
timothy_horton@apple.com [Fri, 28 Oct 2011 23:27:32 +0000 (23:27 +0000)]
Unreviewed build fix due to r98775.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIf visibility changes while an accelerated animation is running, element jumps around
simon.fraser@apple.com [Fri, 28 Oct 2011 23:18:08 +0000 (23:18 +0000)]
If visibility changes while an accelerated animation is running, element jumps around
https://bugs.webkit.org/show_bug.cgi?id=29984

Source/WebCore:

Reviewed by Chris Marrin.

Compositing now affects whether RenderLayers for visibility:hidden elements
are included in z-order lists. So we have to dirty those lists when we enter
compopsiting mode.

Test: compositing/visibility/animation-visibility.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitespace.
(WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal(), which doesn't have
to ping the compositor.
(WebCore::RenderLayer::dirtyZOrderListsInternal):
(WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursively dirty z-order
lists.
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode): When going into compositing mode,
dirty all z-order lists.

LayoutTests:

Reviewed by Chris Marrin.

Add testcase for visibility changing in the middle of an accelerated animation.

* animations/resources/animation-test-helpers.js: Add some constants for readability.
(checkExpectedValue): Add support for testing 'visibility'.
* compositing/visibility/animation-visibility-expected.png: Added.
* compositing/visibility/animation-visibility-expected.txt: Added.
* compositing/visibility/animation-visibility.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement CSS3 Images cross-fade() image function
timothy_horton@apple.com [Fri, 28 Oct 2011 23:08:51 +0000 (23:08 +0000)]
Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Parse -webkit-cross-fade according to the CSS3 Images Values specification.

Also, adjust other CSS parsing functions to support nested functions, by using a specific CSS value list
instead of the global one. This allows - for example - cross-fade to pass each of its arguments back into
parseFillImage and to successfully parse image functions in this fashion.

Test: fast/css/getComputedStyle/computed-style-cross-fade.html

* WebCore.xcodeproj/project.pbxproj:
* css/CSSCrossfadeValue.cpp: Added.
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::cssText):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):
* css/CSSCrossfadeValue.h: Added.
(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isFixedSize):
(WebCore::CSSCrossfadeValue::setFromImage):
(WebCore::CSSCrossfadeValue::setToImage):
(WebCore::CSSCrossfadeValue::setPercentage):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCanvas):
* css/CSSParser.h:

Add tests to ensure that -webkit-cross-fade is parsed correctly.

* fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-cross-fade.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempted build fix after r98765.
mitz@apple.com [Fri, 28 Oct 2011 23:06:00 +0000 (23:06 +0000)]
Attempted build fix after r98765.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS grammar doesn't support functions with no parameters
cmarrin@apple.com [Fri, 28 Oct 2011 22:55:37 +0000 (22:55 +0000)]
CSS grammar doesn't support functions with no parameters
https://bugs.webkit.org/show_bug.cgi?id=69110

Reviewed by Dean Jackson.

Source/WebCore:

Add rule to grammar to accept functions with 0 args and return
this case with a CSSParserValueList with 0 values. Also fixed
filter creation function to properly handle filters with 0
arguments.

* css/CSSGrammar.y:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):

LayoutTests:

Updated tests to include tests for allowing 0 argument functions and for
disallowing functions with trailing commas (to pickup a couple of theses
cases not in the current tests). Also fixed one typo.

* css3/filters/filter-property-computed-style-expected.txt:
* css3/filters/filter-property-parsing-expected.txt:
* css3/filters/filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/filter-property-computed-style.js:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:
(testFilterRule):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98757.
johnnyg@google.com [Fri, 28 Oct 2011 22:34:42 +0000 (22:34 +0000)]
Unreviewed, rolling out r98757.
http://trac.webkit.org/changeset/98757
https://bugs.webkit.org/show_bug.cgi?id=71150

crashes webkit_unit_tests on chromium windows (Requested by
johnny_g on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber-stamped by Eric Seidel.
abarth@webkit.org [Fri, 28 Oct 2011 22:21:49 +0000 (22:21 +0000)]
Rubber-stamped by Eric Seidel.

Fix namespace indent in ScriptExecutionContext.h.

* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isDocument):
(WebCore::ScriptExecutionContext::isWorkerContext):
(WebCore::ScriptExecutionContext::setHasOpenDatabases):
(WebCore::ScriptExecutionContext::hasOpenDatabases):
(WebCore::ScriptExecutionContext::url):
(WebCore::ScriptExecutionContext::completeURL):
(WebCore::ScriptExecutionContext::securityOrigin):
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
(WebCore::ScriptExecutionContext::activeDOMObjects):
(WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::messagePorts):
(WebCore::ScriptExecutionContext::domUrls):
(WebCore::ScriptExecutionContext::ref):
(WebCore::ScriptExecutionContext::deref):
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: WebCore part of:
sullivan@apple.com [Fri, 28 Oct 2011 22:07:16 +0000 (22:07 +0000)]
Source/WebCore: WebCore part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
Bail out if backspace navigation is not enabled.

* page/Settings.cpp:
(WebCore::Settings::Settings):
Initialize m_backspaceKeyNavigationEnabled to true to match current behavior.

* page/Settings.h:
Declared m_backspaceKeyNavigationEnabled.
(WebCore::Settings::setBackspaceKeyNavigationEnabled):
New function, simple setter.
(WebCore::Settings::backspaceKeyNavigationEnabled):
New function, simple getter.

Source/WebKit/mac: WebKit part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* WebView/WebFrameView.mm:
(-[WebFrameView keyDown:]):
Honor the new preference.

* WebView/WebPreferenceKeysPrivate.h:
Added #define for WebKitBackspaceKeyNavigationEnabledKey

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Initialize new pref to YES, to match current behavior.
(-[WebPreferences setBackspaceKeyNavigationEnabled:]):
New method, standard prefs setter.
(-[WebPreferences backspaceKeyNavigationEnabled]):
New method, standard prefs getter.

* WebView/WebPreferencesPrivate.h:
Declared new methods.

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* Shared/WebPreferencesStore.h:
Declared backspaceKeyNavigationEnabled property using macro. This initializes
it to true, to match current behavior.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBackspaceKeyNavigationEnabled):
New function, pass value to impl.
(WKPreferencesGetBackspaceKeyNavigationEnabled):
New function, returns result from impl.

* UIProcess/API/C/WKPreferences.h:
Declared API functions for new preference.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Updates WebCore settings from WebKit2 prefs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
johnnyg@google.com [Fri, 28 Oct 2011 21:55:59 +0000 (21:55 +0000)]
Unreviewed gardening.

* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/dom: Removed.
* platform/chromium-cg-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium-cg-mac/svg/hixie/perf: Removed.
* platform/chromium-cg-mac/svg/hixie/perf/001-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/visibility: Added.
* platform/chromium-gpu-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-gpu-win/compositing/visibility: Added.
* platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
* platform/chromium-linux/svg/hixie/perf/001-expected.png:
* platform/chromium-mac-snowleopard/fast/dom: Removed.
* platform/chromium-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium-mac/svg/hixie/perf/001-expected.png: Removed.
* platform/chromium-mac/svg/hixie/perf/001-expected.txt: Removed.
* platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Removed.
* platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOverridden clippedOverflowRectForRepaint() still uses IntRects
eae@chromium.org [Fri, 28 Oct 2011 21:55:11 +0000 (21:55 +0000)]
Overridden clippedOverflowRectForRepaint() still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71046

Reviewed by Simon Fraser.

Change all virtual clippedOverflowRectForRepaint functions to use the
same signature.

No new tests.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
* rendering/RenderText.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused parsers for 'exception' and 'alias' IDL keywords
adamk@chromium.org [Fri, 28 Oct 2011 21:46:17 +0000 (21:46 +0000)]
Remove unused parsers for 'exception' and 'alias' IDL keywords
https://bugs.webkit.org/show_bug.cgi?id=71140

Reviewed by Adam Barth.

* bindings/scripts/IDLParser.pm:
(ParseInterface):
(DetermineParseMode):
(ProcessSection):
* bindings/scripts/IDLStructure.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10288006> Emoji characters are too close to each other in small font...
mitz@apple.com [Fri, 28 Oct 2011 21:41:43 +0000 (21:41 +0000)]
<rdar://problem/10288006> Emoji characters are too close to each other in small font size

Reviewed by Sam Weinig.

Source/WebCore:

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color bitmap font, use
-[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances().

LayoutTests:

* platform/mac/fast/css/font-family-pictograph-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused default constructor
abarth@webkit.org [Fri, 28 Oct 2011 21:30:44 +0000 (21:30 +0000)]
Remove unused default constructor
https://bugs.webkit.org/show_bug.cgi?id=71136

Reviewed by Eric Seidel.

No one is calling this constructor anymore now that we've fixed the
callers.

* dom/make_exception_code_description.pl:
(generateHeader):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when splitting inline flows with generated floats
commit-queue@webkit.org [Fri, 28 Oct 2011 21:28:39 +0000 (21:28 +0000)]
Crash when splitting inline flows with generated floats
https://bugs.webkit.org/show_bug.cgi?id=70458

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-28
Reviewed by David Hyatt.

Source/WebCore:

When lineBoxes on a RenderBlock are being deleted, we now check the floating object list to
ensure references to them are being cleared.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox when deleting them

LayoutTests:

Added test for crash condition when splitting inline flows on an object with generated floats.

* fast/css-generated-content/inline-splitting-with-after-float-crash.html: Added
* fast/css-generated-content/inline-splitting-with-after-float-crash-expected.txt: Added

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Leopard-only code from GraphicsLayerCA
simon.fraser@apple.com [Fri, 28 Oct 2011 21:26:57 +0000 (21:26 +0000)]
Remove Leopard-only code from GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=71141

Reviewed by Chris Marrin.

Remove !HAVE_MODERN_QUARTZCORE code, which was only
used on Leopard. updateContentsTransform() became a no-op,
so could be removed.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::defaultContentsOrientation):
(WebCore::GraphicsLayerCA::updateOpacityOnLayer):
* platform/graphics/ca/GraphicsLayerCA.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport using a different front-end for the Web Inspector in WebKit2.
timothy@apple.com [Fri, 28 Oct 2011 20:51:52 +0000 (20:51 +0000)]
Support using a different front-end for the Web Inspector in WebKit2.

rdar://problem/10318665
https://webkit.org/b/71089

Reviewed by Sam Weinig.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Added webInspectorBasePath and webInspectorLocalizedStringsPath.
(WebKit::WebProcessCreationParameters::decode): Ditto.
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetOverrideWebInspectorBaseDirectory): Added. Calls through to WebContext.
(WKContextSetOverrideWebInspectorPagePath): Ditto.
(WKContextSetOverrideWebInspectorLocalizedStringsPath): Ditto.
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess): Set webInspectorBasePath and webInspectorLocalizedStringsPath.
* UIProcess/WebContext.h:
(WebKit::WebContext::overrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::setOverrideWebInspectorBaseDirectory): Added.
(WebKit::WebContext::overrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorPagePath): Added.
(WebKit::WebContext::setOverrideWebInspectorLocalizedStringsPath): Added.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectorPageURL): Use WebContext::overrideWebInspectorPagePath if set.
(WebKit::WebInspectorProxy::inspectorBaseURL): Use WebContext::overrideWebInspectorBaseDirectory if set.
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::globalInspectorLocalizedStringsURL): Added. Static storage for the setting.
(WebKit::WebInspector::setLocalizedStringsPath): Added. Set globalInspectorLocalizedStringsURL.
(WebKit::WebInspector::localizedStringsURL): Return globalInspectorLocalizedStringsURL.
* WebProcess/com.apple.WebProcess.sb: Added read-only subpath for WEBKIT_WEB_INSPECTOR_DIR.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::appendReadonlySandboxDirectory): Check path for empty to prevent an exception when
calling through to fileSystemRepresentation.
(WebKit::initializeSandbox): Added WEBKIT_WEB_INSPECTOR_DIR parameter.
(WebKit::WebProcess::platformInitializeWebProcess): Call WebInspector::setLocalizedStringsPath.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT crashes when parsing leaks output due to UTF-8 decoding error
eric@webkit.org [Fri, 28 Oct 2011 20:46:29 +0000 (20:46 +0000)]
NRWT crashes when parsing leaks output due to UTF-8 decoding error
https://bugs.webkit.org/show_bug.cgi?id=71112

Reviewed by Adam Barth.

Use read_binary_file instead of read_text_file and add a test
case with some non-utf8 data to make sure we don't break this in the future.

* Scripts/webkitpy/layout_tests/port/leakdetector.py:
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Implicitly skip render surfaces that won't be drawn
enne@google.com [Fri, 28 Oct 2011 20:44:58 +0000 (20:44 +0000)]
[chromium] Implicitly skip render surfaces that won't be drawn
https://bugs.webkit.org/show_bug.cgi?id=71038

Rather than having redundant checks in three places for how to walk
through a render surface list, instead don't add render surfaces that
don't need to get rendered to the render surface list.

Reviewed by James Robinson.

Covered by existing layout tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up BuiltInPDFView a little
ap@apple.com [Fri, 28 Oct 2011 20:27:44 +0000 (20:27 +0000)]
Clean up BuiltInPDFView a little
https://bugs.webkit.org/show_bug.cgi?id=71133

Reviewed by Daniel Bates.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::createScrollbar):
Removed an incorrect FIXME. Custom scrollbars specified in a document don't apply
to subframes, and thus shouldn't apply to PDFs.

* WebProcess/Plugins/PDF/BuiltInPDFView.h: (WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):
Moved to a correct location. This is not a Plugin method, but a ScrollView one.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAutogenerate Exception-downcast code in bindings
abarth@webkit.org [Fri, 28 Oct 2011 20:20:50 +0000 (20:20 +0000)]
Autogenerate Exception-downcast code in bindings
https://bugs.webkit.org/show_bug.cgi?id=71108

Reviewed by Eric Seidel.

This patch uses the same generated code style as we're using for Events
to generate the downcasts for the Exception types in the bindings.
This cause me to refactor more code from make_event_factory.pl into
InFilesCompiler.pm.

After this patch, some of these files and scripts are misnamed.  I'll
rename them in a followup patch.

* DerivedSources.make:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/objc/ExceptionHandlers.mm:
(WebCore::raiseDOMException):
* bindings/scripts/InFilesCompiler.pm:
(initializeFromCommandLine):
(compile):
(interfaceForItem):
(toMacroStyle):
(generateInterfacesHeader):
(generateHeadersHeader):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::setDOMException):
* dom/ExceptionCodeDescription.in:
* dom/make_event_factory.pl:
(generateCode):
(generateImplementation):
* dom/make_exception_code_description.pl:
(defaultItemFactory):
(generateCode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowatchlist should not CC the bug reporter
levin@chromium.org [Fri, 28 Oct 2011 19:58:04 +0000 (19:58 +0000)]
watchlist should not CC the bug reporter
https://bugs.webkit.org/show_bug.cgi?id=71079

Reviewed by Adam Barth.

Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.

* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
* Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
* Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix builds which have ACCELERATED_COMPOSITING disabled.
simon.fraser@apple.com [Fri, 28 Oct 2011 19:42:43 +0000 (19:42 +0000)]
Fix builds which have ACCELERATED_COMPOSITING disabled.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateZOrderLists):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
johnnyg@google.com [Fri, 28 Oct 2011 19:36:50 +0000 (19:36 +0000)]
Unreviewed gardening.

* platform/chromium-cg-mac-leopard/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/chromium-cg-mac-leopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/svg/hixie: Added.
* platform/chromium-cg-mac-snowleopard/svg/hixie/perf: Added.
* platform/chromium-cg-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-cg-mac/svg/hixie/perf/002-expected.png: Removed.
* platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
* platform/chromium-linux/svg/hixie/perf/002-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/borderRadiusDashed06-expected.png:
* platform/chromium-mac-snowleopard/fast/text/emphasis-overlap-expected.png:
* platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Removed.
* platform/chromium-mac-snowleopard/fullscreen/parent-flow-inline-with-block-child-expected.png: Removed.
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPath-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-mac/svg/batik/text/textOnPath-expected.png: Removed.
* platform/chromium-mac/svg/hixie/perf/002-expected.png: Removed.
* platform/chromium-mac/svg/hixie/perf/002-expected.txt: Removed.
* platform/chromium-win-vista/svg/batik/text: Removed.
* platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Added.
* platform/chromium-win/svg/batik/text/textOnPath-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
* platform/chromium/fast/js/array-prototype-properties-expected.txt: Replaced.
* platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Removed.
* platform/chromium/fast/js/kde/RegExp-expected.txt: Removed.
* platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from inspector IDLs
arv@chromium.org [Fri, 28 Oct 2011 19:29:00 +0000 (19:29 +0000)]
Remove LegacyDefaultOptionalArguments flag from inspector IDLs
https://bugs.webkit.org/show_bug.cgi?id=65748

Reviewed by Adam Barth.

Covered by existing tests.

* inspector/InjectedScriptHost.idl:
* inspector/InspectorFrontendHost.idl:
* inspector/JavaScriptCallFrame.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Database metadata changes should be tied to transaction
commit-queue@webkit.org [Fri, 28 Oct 2011 19:22:27 +0000 (19:22 +0000)]
IndexedDB: Database metadata changes should be tied to transaction
https://bugs.webkit.org/show_bug.cgi?id=70974

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

Source/WebCore:

Database metadata (that is, the version string) was rolled back
on abort by an abort task. If the abort task didn't run e.g.
due to a crash, the metadata would not be reverted. All of the
other store/index/data changes were written into the transaction
itself, so the metadata now is too. Refactored the metadata
get/create/update methods for clarity as well.

Note that the new tests don't actually verify that the code handles
this case; that will need to be done with persistence tests
that span multiple runs of the browser and induce crashes.
The new tests do verify that these changes don't cause regressions
not caught by other tests.

Tests: storage/indexeddb/open-during-transaction.html
       storage/indexeddb/version-change-abort.html

* storage/IDBBackingStore.h:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
* storage/IDBLevelDBBackingStore.h:

LayoutTests:

* storage/indexeddb/open-during-transaction-expected.txt: Added.
* storage/indexeddb/open-during-transaction.html: Added.
* storage/indexeddb/version-change-abort-expected.txt: Added.
* storage/indexeddb/version-change-abort.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse enum instead of bool to represent -webkit-column-span property.
macpherson@chromium.org [Fri, 28 Oct 2011 19:15:26 +0000 (19:15 +0000)]
Use enum instead of bool to represent -webkit-column-span property.
https://bugs.webkit.org/show_bug.cgi?id=70867

Reviewed by Darin Adler.

Covered by existing tests.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createAnonymousColumnSpanBlock):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::columnSpan):
(WebCore::InheritedFlags::setColumnSpan):
(WebCore::InheritedFlags::initialColumnSpan):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleMultiColData.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstan...
mhahnenberg@apple.com [Fri, 28 Oct 2011 19:08:24 +0000 (19:08 +0000)]
De-virtualize isGlobalObject, isVariableObject, isActivationObject, and isErrorInstance in JSObject
https://bugs.webkit.org/show_bug.cgi?id=70968

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* API/JSCallbackObject.cpp: Added two specializations for createStructure that use different JSTypes in their
TypeInfo.  Had to also create a specialization for JSNonFinalObject, even JSGlobalObject was the only that
needed it because Windows wouldn't build without it.
(JSC::::createStructure):
* API/JSCallbackObject.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ErrorInstance.h: Removed virtual function and changed JSType provided to TypeInfo in createStructure.
(JSC::ErrorInstance::createStructure):
* runtime/ErrorPrototype.h: Ditto
(JSC::ErrorPrototype::createStructure):
* runtime/JSActivation.h: Ditto
(JSC::JSActivation::createStructure):
* runtime/JSGlobalObject.h: Ditto
(JSC::JSGlobalObject::createStructure):
* runtime/JSObject.h: De-virtualized functions.  They now check the JSType of the object for the corresponding type.
(JSC::JSObject::isGlobalObject):
(JSC::JSObject::isVariableObject):
(JSC::JSObject::isActivationObject):
(JSC::JSObject::isErrorInstance):
* runtime/JSType.h: Added new types for GlobalObject, VariableObject, ActivationObject, and ErrorInstance.
* runtime/JSVariableObject.cpp: Removed virtual function.
* runtime/JSVariableObject.h: Changed JSType provided to TypeInfo in createStructure.
(JSC::JSVariableObject::createStructure):

Source/WebCore:

No new tests.

* bindings/js/JSDOMGlobalObject.h: Changed JSType provided to TypeInfo in createStructure since this
class inherits from JSGlobalObject.
(WebCore::JSDOMGlobalObject::createStructure):
* bindings/js/JSDOMWindowBase.h: Ditto
(WebCore::JSDOMWindowBase::createStructure):
* bindings/js/JSWorkerContextBase.h: Ditto
(WebCore::JSWorkerContextBase::createStructure):
* bindings/scripts/CodeGeneratorJS.pm: Added extra check to make sure subclasses of JSGlobalObject,
namely JSDOMWindow and JSWorkerContext, get their special JSType in their createStructure function.
(GenerateHeader):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded some missing results for compositing visibilty tests.
simon.fraser@apple.com [Fri, 28 Oct 2011 18:57:35 +0000 (18:57 +0000)]
Added some missing results for compositing visibilty tests.

* platform/mac/compositing/visibility/visibility-composited-expected.txt: Added.
* platform/mac/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
* platform/mac/compositing/visibility/visibility-image-layers-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98736.
commit-queue@webkit.org [Fri, 28 Oct 2011 18:43:36 +0000 (18:43 +0000)]
Unreviewed, rolling out r98736.
http://trac.webkit.org/changeset/98736
https://bugs.webkit.org/show_bug.cgi?id=71125

This patch broke perf/array-binary-search.html test (Requested
by annacc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::addTrack):
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
* html/HTMLTrackElement.h:
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

* media/track/track-load-error-readyState-expected.txt: Removed.
* media/track/track-load-error-readyState.html: Removed.
* media/track/track-load-from-element-readyState-expected.txt: Removed.
* media/track/track-load-from-element-readyState.html: Removed.
* media/track/track-load-from-src-readyState-expected.txt: Removed.
* media/track/track-load-from-src-readyState.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTesting allowed identifier chars which are greater than 126
zherczeg@webkit.org [Fri, 28 Oct 2011 18:40:14 +0000 (18:40 +0000)]
Testing allowed identifier chars which are greater than 126
https://bugs.webkit.org/show_bug.cgi?id=71097

Reviewed by Darin Adler.

* fast/css/parsing-css-nonascii-expected.txt: Added.
* fast/css/parsing-css-nonascii.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderTableSection::recalcCells should not free its grid
jchaffraix@webkit.org [Fri, 28 Oct 2011 18:04:14 +0000 (18:04 +0000)]
RenderTableSection::recalcCells should not free its grid
https://bugs.webkit.org/show_bug.cgi?id=71056

Reviewed by Darin Adler.

Refactoring only, no change in behavior.

r98614 had the bad side effect of clearing the row vector (m_grid) on
the RenderTableSection when doing a recalcCells. This change removes the
unneeded free and inline the |row| field into the RowStruct as it made
no sense to have it as a pointer.

* rendering/RenderTableSection.cpp:
(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative):
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
Mechanical changes now that |row| is a member of RowStruct.

(WebCore::RenderTableSection::~RenderTableSection): Clear our row vector.

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::recalcCells):
Those 2 functions were refactored to use fillRowsWithDefaultStartingAtPosition.

(WebCore::RenderTableSection::fillRowsWithDefaultStartingAtPosition):
Factored the code to fill the RowStruct structure with default values.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
More mechanical change after the |row| field change.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnskip tables/mozilla_expected_failures/bugs/bug14007-2.html
rniwa@webkit.org [Fri, 28 Oct 2011 18:00:36 +0000 (18:00 +0000)]
Unskip tables/mozilla_expected_failures/bugs/bug14007-2.html
since the test was rebaselined in r98691.

Also enable platform/mac/editing/deleting/backward-delete.html on Chromium Mac
and skip it again on Chromium Windows and Linux.

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement load notification and events for <track>.
annacc@chromium.org [Fri, 28 Oct 2011 17:54:32 +0000 (17:54 +0000)]
Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html
       media/track/track-load-from-element-readyState.html
       media/track/track-load-from-src-readyState.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTextTracks):
(WebCore::HTMLMediaElement::loadNextTextTrack):
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):
* html/HTMLTrackElement.h:
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

* media/track/track-load-error-readyState-expected.txt: Added.
* media/track/track-load-error-readyState.html: Added.
* media/track/track-load-from-element-readyState-expected.txt: Added.
* media/track/track-load-from-element-readyState.html: Added.
* media/track/track-load-from-src-readyState-expected.txt: Added.
* media/track/track-load-from-src-readyState.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden...
simon.fraser@apple.com [Fri, 28 Oct 2011 17:46:38 +0000 (17:46 +0000)]
Source/WebCore: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Reviewed by James Robinson.

Make compositing and CSS visibility play nicely together.

The main issue was that an old optimization (see bug 4377) caused
visibility:hidden layers to not appear in the z-order lists, but those
layers could still become composited, but would remain detached. In addition,
composited layers which were visibility:hidden would become visible sometimes.

With this fix, the z-order lists always contain all layers when the page
is in compositing mode. GraphicsLayer is changed to ensure that visibility:hidden
layers show no content, and visible descendants of hidden layers work correctly.

Tests: compositing/visibility/visibility-composited-transforms.html
       compositing/visibility/visibility-composited.html
       compositing/visibility/visibility-image-layers-dynamic.html
       compositing/visibility/visibility-image-layers.html

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer): Init m_contentsVisible to true.
(WebCore::GraphicsLayer::dumpProperties): Dump m_contentsVisible if not true.
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::contentsAreVisible): Getter for m_contentsVisible.
(WebCore::GraphicsLayer::setContentsVisible): Setter for m_contentsVisible.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsVisible): Override setContentsVisible.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): Handle ContentsVisibilityChanged
flag
(WebCore::GraphicsLayerCA::updateSublayerList): Only parent the m_contentsLayer if the layer
has visible contents.
(WebCore::GraphicsLayerCA::updateContentsVisibility): For bits painted into the layer itself,
we hide it by clearing the backing store.
* platform/graphics/ca/GraphicsLayerCA.h: Removed obsolete comment on the DrawsContentChanged flag,
added ContentsVisibilityChanged flag.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateZOrderLists): If we're in compositing mode, include all layers
in the z-order lists.
(WebCore::RenderLayer::collectLayers): New param to specify whether we need to collect all layers.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasVisibleDescendant): Add comment about the need for an assertion in hasVisibleContent()
, and assertion in hasVisibleDescendant().
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call setContentsVisible() on the GraphicsLayer.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): We can use simple container layers in cases
where visibility:hidden causes layer content to not be drawn.
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendants): Renamed from hasNonCompositingDescendants()
because it now also looks at visibility to decide when things are visible.
* rendering/RenderLayerBacking.h: hasNonCompositingDescendants() renamed to hasVisibleNonCompositingDescendants().

LayoutTests: The HTML5 video element in Safari does not respect "visibility:hidden" CSS property
https://bugs.webkit.org/show_bug.cgi?id=38829

Test various configurations of compositing layers and visibility.

Reviewed by James Robinson.

* compositing/visibility/visibility-composited-expected.png: Added.
* compositing/visibility/visibility-composited-transforms-expected.png: Added.
* compositing/visibility/visibility-composited-transforms.html: Added.
* compositing/visibility/visibility-composited.html: Added.
* compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* compositing/visibility/visibility-image-layers-dynamic.html: Added.
* compositing/visibility/visibility-image-layers-expected.png: Added.
* compositing/visibility/visibility-image-layers.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Test Harness: Remove js-test-post-function.js
arv@chromium.org [Fri, 28 Oct 2011 17:35:50 +0000 (17:35 +0000)]
JS Test Harness: Remove js-test-post-function.js
https://bugs.webkit.org/show_bug.cgi?id=70959

Reviewed by Ojan Vafai.

This moves isSuccessfullyParsed to js-test-pre.js and removes js-test-post-function.js and all references to it.

* fast/js/resources/js-test-post-function.js: Removed.
* fast/js/resources/js-test-pre.js:
(isSuccessfullyParsed): Moved here from js-test-post-function.js

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoempty-urls.html needs to stop being flaky.
japhet@chromium.org [Fri, 28 Oct 2011 16:58:33 +0000 (16:58 +0000)]
empty-urls.html needs to stop being flaky.
Because it was in http/tests/loading, it output
frame load callbacks, and it was unpredictable whether
the callback for onload or for the load completing would
be called first. Ergo, move the test to http/tests/misc,
and remove the logic which failed to enforce a frame load
callback ordering.
https://bugs.webkit.org/show_bug.cgi?id=67359

Reviewed by Adam Barth.

* http/tests/loading/empty-urls-expected.txt: Removed.
* http/tests/loading/empty-urls.html: Removed.
* http/tests/misc/empty-urls-expected.txt: Copied from LayoutTests/http/tests/loading/empty-urls-expected.txt.
* http/tests/misc/empty-urls.html: Copied from LayoutTests/http/tests/loading/empty-urls.html.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Build fixes for glib 2.31 (current master)
philn@webkit.org [Fri, 28 Oct 2011 16:47:14 +0000 (16:47 +0000)]
[GTK] Build fixes for glib 2.31 (current master)
https://bugs.webkit.org/show_bug.cgi?id=70679

Reviewed by Martin Robinson.

g_cond_new and g_mutex_new have been replaced by _init
functions. Same for _free, replaced by _clear.

* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_init):
(webkit_video_sink_dispose):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename a number of methods mentioning JavaScript to just Script instead
jochen@chromium.org [Fri, 28 Oct 2011 16:29:26 +0000 (16:29 +0000)]
Rename a number of methods mentioning JavaScript to just Script instead
https://bugs.webkit.org/show_bug.cgi?id=71105

Reviewed by Adam Barth.

Source/WebCore:

* WebCore.exp.in:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::handleOutOfMemory):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowScript):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setScriptEnabled):
* page/Settings.h:
(WebCore::Settings::isScriptEnabled):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowScript):
* src/FrameLoaderClientImpl.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::collectGarbage):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setJavaScriptEnabled):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_enable_scripts_set):

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld):
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit/wince:

* WebView.cpp:
(WebView::WebView):

Source/WebKit/wx:

* WebSettings.cpp:
(wxWebSettings::SetJavaScriptEnabled):
(wxWebSettings::IsJavaScriptEnabled):
* WebView.cpp:
(wxWebView::Create):

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Fri, 28 Oct 2011 16:22:18 +0000 (16:22 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
Remove fast/replaced/table-percent-height.html that has been passing for at least
a week. Also tighten some tests that have not been passing (but occasionally timing
out) on the flakyness dashboard for some time.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatti...
vsevik@chromium.org [Fri, 28 Oct 2011 14:57:53 +0000 (14:57 +0000)]
Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html.

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd watchlist for QtWebKit2 API and for WK2's Qt specific files.
zoltan@webkit.org [Fri, 28 Oct 2011 14:52:19 +0000 (14:52 +0000)]
Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
https://bugs.webkit.org/show_bug.cgi?id=71116

Reviewed by David Levin.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Fri, 28 Oct 2011 14:42:56 +0000 (14:42 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed gardening.
ossy@webkit.org [Fri, 28 Oct 2011 13:59:58 +0000 (13:59 +0000)]
[Qt][WK2] Unreviewed gardening.

REGRESSION: 5 editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=71117

* platform/qt-wk2/Skipped: Skip failing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReset line numbers for scripts generated with document.write.
pfeldman@chromium.org [Fri, 28 Oct 2011 13:27:32 +0000 (13:27 +0000)]
Reset line numbers for scripts generated with document.write.
https://bugs.webkit.org/show_bug.cgi?id=71099

Reviewed by Yury Semikhatsky.

Source/JavaScriptCore:

* wtf/text/TextPosition.h:
(WTF::OrdinalNumber::OrdinalNumber):

Source/WebCore:

Test: http/tests/inspector-enabled/document-write.html

* dom/Document.h:
(WebCore::Document::isInDocumentWrite):
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):

LayoutTests:

* http/tests/inspector-enabled/document-write-expected.txt: Added.
* http/tests/inspector-enabled/document-write.html: Added.
* platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-10-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 28 Oct 2011 13:10:36 +0000 (13:10 +0000)]
2011-10-28  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Unsupress css3/font-feature-settings-rendering.html as it should
        pass on Linux after r98716.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
ossy@webkit.org [Fri, 28 Oct 2011 13:06:52 +0000 (13:06 +0000)]
[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
https://bugs.webkit.org/show_bug.cgi?id=70494

One more buildfix. (unreviewed)

* UIProcess/API/qt/qtouchwebpage.cpp:
(computeEffectiveOpacity):
(QTouchWebPage::itemChange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
ossy@webkit.org [Fri, 28 Oct 2011 13:06:34 +0000 (13:06 +0000)]
[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
https://bugs.webkit.org/show_bug.cgi?id=70494

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2011-10-28
Reviewed by Kenneth Christiansen.

Use QQuick* instead of QSG* as well as QStandardPaths
instead of QDesktopLocation.

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):

Source/WebKit2:

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebView::QDesktopWebView):
(QDesktopWebView::geometryChanged):
(QDesktopWebView::event):
(QDesktopWebViewPrivate::engine):
* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::geometryChanged):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebView::QTouchWebView):
(QTouchWebView::geometryChanged):
(QTouchWebView::touchEvent):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/API/qt/tests/testwindow.h:
(TestWindow::TestWindow):
(TestWindow::resizeEvent):
* UIProcess/qt/QtDesktopWebPageProxy.cpp:
(QtDesktopWebPageProxy::createPopupMenuProxy):
* UIProcess/qt/QtSGUpdateQueue.cpp:
(WebKit::QtSGUpdateQueue::QtSGUpdateQueue):
* UIProcess/qt/QtSGUpdateQueue.h:
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::engine):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::contentRectInViewportCoordinates):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDataLocation):
* UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:
(WebKit::WebPopupMenuProxyQtDesktop::WebPopupMenuProxyQtDesktop):
* UIProcess/qt/WebPopupMenuProxyQtDesktop.h:
(WebKit::WebPopupMenuProxyQtDesktop::create):

Tools:

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::setDiskCache):
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac build fix after r98711
aroben@apple.com [Fri, 28 Oct 2011 12:37:55 +0000 (12:37 +0000)]
Mac build fix after r98711

* WebCore.xcodeproj/project.pbxproj: Mark ExceptionCodeDescription.h private so WebKit can
find it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98720 268f45cc-cd09-0410-ab3c-d52691b4dbfc