commit-queue@webkit.org [Wed, 24 Nov 2010 21:29:28 +0000 (21:29 +0000)]
2010-11-24 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Andreas Kling.
Fixed handling of QInputMethodEvents with nonzero replacementLength.
These types of events replace text that is already in the widget, but
WebKit did not check for replacementLength at all.
https://bugs.webkit.org/show_bug.cgi?id=49787
* Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 24 Nov 2010 20:20:54 +0000 (20:20 +0000)]
2010-11-24 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Just assign a bug for compositing/plugin tests.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 20:02:41 +0000 (20:02 +0000)]
2010-11-24 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] response.isNull() assert when using directory file URI
https://bugs.webkit.org/show_bug.cgi?id=49018
When using file:/// (or any directory), WebKitGTK use to abort on
assertion. This test ensure that loading a directory is possible.
* platform/gtk/fast/loader/crash-display-local-directory-expected.txt: Added.
* platform/gtk/fast/loader/crash-display-local-directory.html: Added.
* platform/gtk/fast/loader/resources/directory/keep-empty: Added.
2010-11-24 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] response.isNull() assert when using directory file URI
https://bugs.webkit.org/show_bug.cgi?id=49018
Do ensure that didReceiveResponse happens before any call to
didReceiveData. That was not true for file:// URIs pointing to
directories and thus was triggering an assertion.
Test: platform/gtk/fast/loader/crash-display-local-directory.html
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotHeadersCallback):
(WebCore::contentSniffedCallback):
(WebCore::parseDataUrl):
(WebCore::sendRequestCallback):
(WebCore::readCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 24 Nov 2010 19:45:50 +0000 (19:45 +0000)]
2010-11-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by David Levin.
DRT should not generate pixel output for text/plain tests
https://bugs.webkit.org/show_bug.cgi?id=50002
Modify Mac, Windows and GTK DRT implementations to disable pixel output
when encountering a text/plain response (the Chromium one already does
this, and none of the other ports special-case text/plain output in
the first place).
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dump):
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 24 Nov 2010 19:23:48 +0000 (19:23 +0000)]
2010-11-24 Andrey Kosyakov <caseq@chromium.org>
Unreviewed, update platform expectations following expectations change in r72683.
* platform/mac-leopard/inspector/extensions-resources-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 24 Nov 2010 19:23:27 +0000 (19:23 +0000)]
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
* bindings/gobject/WebKitDOMBinding.h: fix stlye nit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 24 Nov 2010 19:15:04 +0000 (19:15 +0000)]
WebCore:
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Make kit() methods return the proper type instead of gpointer
https://bugs.webkit.org/show_bug.cgi?id=50034
Change kit() methods to return proper type pointer.
* bindings/gobject/WebKitDOMBinding.cpp: change implementions of
kit methods.
* bindings/gobject/WebKitDOMBinding.h: change their declarations.
* bindings/scripts/CodeGeneratorGObject.pm: change the generated
kit() methods.
WebKit/gtk:
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Make kit() methods return the proper type instead of gpointer
https://bugs.webkit.org/show_bug.cgi?id=50034
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldDeleteRange): get rid of unneeded cast.
(WebKit::EditorClient::shouldShowDeleteInterface): ditto.
(WebKit::EditorClient::shouldBeginEditing): ditto.
(WebKit::EditorClient::shouldEndEditing): ditto.
(WebKit::EditorClient::shouldInsertText): ditto.
(WebKit::EditorClient::shouldChangeSelectedRange): ditto.
(WebKit::EditorClient::shouldApplyStyle): ditto.
(WebKit::EditorClient::shouldInsertNode): ditto.
* webkit/webkitprivate.cpp:
(WebKit::kit): ditto.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_dom_document): ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 24 Nov 2010 19:08:23 +0000 (19:08 +0000)]
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DerivedSources/WebCore/DocTypeStrings.cpp is generated for every build
https://bugs.webkit.org/show_bug.cgi?id=50032
Instead of listing two targets for rules that have two outputs, make
a dependency chain. This fixes the issue where some files are generated
unconditionally. Also remove all unnecessary semicolons from the file.
No new tests as this is just a build fix.
* GNUmakefile.am: Fix GNUmake dependency issue.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 19:01:24 +0000 (19:01 +0000)]
2010-11-24 Nico Weber <nicolasweber@gmx.de>
Reviewed by Adam Barth.
Chromium/Mac: Make scaled images un-ugly when using the webkit image decoders
https://bugs.webkit.org/show_bug.cgi?id=49965
Probably covered by existing tests whose expectations were overwritten
in http://trac.webkit.org/changeset/70858
* platform/image-decoders/cg/ImageDecoderCG.cpp:
(WebCore::RGBA32Buffer::asNewNativeImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Wed, 24 Nov 2010 18:54:50 +0000 (18:54 +0000)]
2010-11-24 Hayato Ito <hayato@chromium.org>
Reviewed by David Levin.
Add files which Chromium port generates to .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=49943
* .gitignore:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 24 Nov 2010 18:45:53 +0000 (18:45 +0000)]
2010-11-24 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Crash when inspecting http://alphaarnhem.nl/beta/
https://bugs.webkit.org/show_bug.cgi?id=50025
@font-face rules were improperly handled by source data extractor.
WebCore:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markPropertyStart):
(WebCore::CSSParser::markPropertyEnd):
* css/CSSParser.h:
LayoutTests:
* inspector/resources/styles-new-API-1.css:
(@font-face):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 24 Nov 2010 18:31:36 +0000 (18:31 +0000)]
2010-11-24 Xan Lopez <xlopez@igalia.com>
Update results for some leftover tests now that we have editing
delegates.
* platform/gtk/editing/selection/
5109817-expected.txt:
* platform/gtk/editing/selection/extend-by-character-002-expected.txt:
* platform/gtk/fast/forms/caret-rtl-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 24 Nov 2010 18:13:25 +0000 (18:13 +0000)]
2010-11-24 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Added check when parsing local fonts to ensure that a value's unit type is either string or ident.
https://bugs.webkit.org/show_bug.cgi?id=49883
Test: fast/css/local_font_invalid.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceSrc):
2010-11-24 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Test for crash with invalid local fonts.
https://bugs.webkit.org/show_bug.cgi?id=49883
* fast/css/local_font_invalid-expected.txt: Added.
* fast/css/local_font_invalid.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 24 Nov 2010 18:06:12 +0000 (18:06 +0000)]
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: place local modifications to under original
resource nodes in the resource panel.
https://bugs.webkit.org/show_bug.cgi?id=50029
* English.lproj/localizedStrings.js:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorController::scriptImported):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::setInitialContent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.prototype.setText):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.refreshResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.set content):
(WebInspector.Resource.prototype.get contentTimestamp):
(WebInspector.Resource.prototype.setInitialContent):
* inspector/front-end/ResourceManager.js:
(WebInspector.ResourceManager):
(WebInspector.ResourceManager.prototype.setInitialContent):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._innerShowView):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
(WebInspector.FrameResourceTreeElement.prototype._contentChanged.else.finished):
(WebInspector.FrameResourceTreeElement.prototype._contentChanged):
(WebInspector.ResourceRevisionTreeElement):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.get scrollTop):
(WebInspector.SourceFrame.prototype.set scrollTop):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.get scrollTop):
(WebInspector.SourceView.prototype.set scrollTop):
(WebInspector.SourceView.prototype._editLine):
(WebInspector.SourceView.prototype._editLineComplete):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 24 Nov 2010 18:03:41 +0000 (18:03 +0000)]
2010-11-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extension API cleanup
https://bugs.webkit.org/show_bug.cgi?id=50019
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
(WebInspector.ElementsPanel):
* inspector/front-end/ExtensionAPI.js: See bug for summary of extension API changes.
(WebInspector.injectedExtensionAPI.Resources.resourceDispatch):
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):
(WebInspector.injectedExtensionAPI.ResourceImpl.prototype.getContent):
(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.PanelImpl):
(WebInspector.injectedExtensionAPI.PanelWithSidebarImpl):
(WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
(WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createWatchExpressionSidebarPane):
(WebInspector.injectedExtensionAPI.ElementsPanel):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
(WebInspector.injectedExtensionAPI.Audits.prototype.addCategory):
(WebInspector.injectedExtensionAPI.AuditCategoryImpl.auditResultDispatch):
(WebInspector.injectedExtensionAPI.AuditCategoryImpl):
(WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.get Severity):
(WebInspector.injectedExtensionAPI.InspectedWindow):
(WebInspector.injectedExtensionAPI.InspectedWindow.prototype.eval):
* inspector/front-end/ExtensionCommon.js:
(WebInspector.commonExtensionSymbols):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.notifyObjectSelected):
(WebInspector.ExtensionServer.prototype.notifyResourceFinished):
(WebInspector.ExtensionServer.prototype.notifyPageLoaded):
(WebInspector.ExtensionServer.prototype.notifyPageDOMContentLoaded):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onReload):
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onAddAuditCategory):
(WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
* inspector/front-end/HAREntry.js:
(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._convertResource):
* inspector/front-end/inspector.js:
(WebInspector.domContentEventFired):
(WebInspector.loadEventFired):
(WebInspector.didCommitLoad):
2010-11-24 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extension API cleanup
Improve synchronization between different parts of the test to reduce flakiness.
https://bugs.webkit.org/show_bug.cgi?id=50019
* http/tests/inspector/inspector-test2.js: Clean inspected page test output before pushing output from front-end.
(initialize_InspectorTest.InspectorTest.completeTest): Delay test completion until page's onload is completed after reload.
(initialize_InspectorTest.InspectorTest.addResult.clearResults):
(initialize_InspectorTest.InspectorTest.reloadPageIfNeeded):
(output):
* inspector/extensions-api-expected.txt:
* inspector/extensions-audits-api-expected.txt:
* inspector/extensions-audits-expected.txt:
* inspector/extensions-audits-tests.js:
(extension_runAudits):
(initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone):
(initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits):
(initialize_ExtensionsAuditsTest):
(test):
* inspector/extensions-eval-expected.txt:
* inspector/extensions-eval.html:
* inspector/extensions-events-expected.txt:
* inspector/extensions-events.html:
* inspector/extensions-resources-expected.txt:
* inspector/extensions-resources.html:
* inspector/extensions-test.js:
(initialize_ExtensionsTest.InspectorTest.dispatchOnMessage):
(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
(initialize_ExtensionsTest.extensionOutput):
(initialize_ExtensionsTest.dumpSidebarContent):
(initialize_ExtensionsTest.reloadPage):
* inspector/extensions.html:
* inspector/resources/extension-main.html:
* inspector/resources/extension-main.js:
(fetchTests.callback):
(fetchTests):
(onTestsDone):
(dispatchOnFrontend):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Wed, 24 Nov 2010 17:57:30 +0000 (17:57 +0000)]
2010-11-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Fix minor errors in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=49970
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/constants.html:
* storage/indexeddb/createAndRemoveObjectStore-expected.txt: Added.
* storage/indexeddb/createAndRemoveObjectStore.html: Added.
2010-11-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Fix minor errors in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=49970
* Remove SNAPSHOT_READ per spec.
* Assert that the transaction that changes the db is a setVersion
transaction.
* When an objectStore already exists, throw a CONSTRAINT_ERR.
* When not in a setVersion transaction, throw a NOT_ALLOWED_ERR.
Test: storage/indexeddb/createAndRemoveObjectStore.html
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 24 Nov 2010 17:51:25 +0000 (17:51 +0000)]
2010-11-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Fix crashes in GTK+ bots. Use kit() instead of wrapFoo, otherwise
the DOM objects won't be in the cache and we'll ASSERT when
unreffing them.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldDeleteRange): use kit to get the
GObject wrapper for the DOM object.
(WebKit::EditorClient::shouldShowDeleteInterface): ditto.
(WebKit::EditorClient::shouldBeginEditing): ditto.
(WebKit::EditorClient::shouldEndEditing): ditto.
(WebKit::EditorClient::shouldInsertText): ditto.
(WebKit::EditorClient::shouldChangeSelectedRange): ditto.
(WebKit::EditorClient::shouldApplyStyle): ditto.
(WebKit::EditorClient::shouldInsertNode): ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 24 Nov 2010 17:49:19 +0000 (17:49 +0000)]
2010-11-24 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GStreamer] pause webkitvideosink during fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=48824
Added an identity element before the webkitvideosink so that when
fullscreen video is active the element can drop the incoming
buffers so that webkitvideosink appears paused.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 24 Nov 2010 17:45:15 +0000 (17:45 +0000)]
2010-11-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip mathml/presentation again, apparently the issue
is still happening in the bots.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 17:20:26 +0000 (17:20 +0000)]
2010-11-24 Avi Drissman <avi@google.com>
Reviewed by Antonio Gomes.
Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351
* editing/selection/context-menu-text-selection-expected.txt: Added.
* editing/selection/context-menu-text-selection.html: Added.
2010-11-24 Avi Drissman <avi@google.com>
Reviewed by Antonio Gomes.
Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351
Test: editing/selection/context-menu-text-selection.html
* editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 24 Nov 2010 17:18:52 +0000 (17:18 +0000)]
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Unreviewed.
Add my other email address to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 17:07:12 +0000 (17:07 +0000)]
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
Make build-webkit --minimal build with ENABLE_INSPECTOR=0.
https://bugs.webkit.org/show_bug.cgi?id=49975
No new tests needed.
* features.pri: Make the Qt buildsystem aware
that the inspector is enabled by default.
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
Make build-webkit --minimal build with ENABLE_INSPECTOR=0
https://bugs.webkit.org/show_bug.cgi?id=49975
* Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
to enable the script to define it 0 in case of a minimal build.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 24 Nov 2010 16:43:50 +0000 (16:43 +0000)]
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
Unskip passing editing tests.
* platform/gtk/Skipped:
* platform/gtk/Skipped.rej: Added.
* platform/gtk/editing/deleting/collapse-whitespace-
3587601-fix-expected.txt:
* platform/gtk/editing/deleting/delete-
3608430-fix-expected.txt:
* platform/gtk/editing/deleting/delete-
3608445-fix-expected.txt:
* platform/gtk/editing/deleting/delete-
3608462-fix-expected.txt:
* platform/gtk/editing/deleting/delete-
3775172-fix-expected.txt:
* platform/gtk/editing/deleting/delete-
3800834-fix-expected.txt:
* platform/gtk/editing/deleting/delete-
3959464-fix-expected.txt:
* platform/gtk/editing/deleting/delete-and-undo-expected.txt:
* platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
* platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
* platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
* platform/gtk/editing/deleting/delete-br-001-expected.txt:
* platform/gtk/editing/deleting/delete-br-002-expected.txt:
* platform/gtk/editing/deleting/delete-br-003-expected.txt:
* platform/gtk/editing/deleting/delete-br-004-expected.txt:
* platform/gtk/editing/deleting/delete-br-005-expected.txt:
* platform/gtk/editing/deleting/delete-br-006-expected.txt:
* platform/gtk/editing/deleting/delete-br-007-expected.txt:
* platform/gtk/editing/deleting/delete-br-010-expected.txt:
* platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
* platform/gtk/editing/deleting/delete-image-004-expected.txt:
* platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
* platform/gtk/editing/deleting/delete-line-001-expected.txt:
* platform/gtk/editing/deleting/delete-line-002-expected.txt:
* platform/gtk/editing/deleting/delete-line-005-expected.txt:
* platform/gtk/editing/deleting/delete-line-006-expected.txt:
* platform/gtk/editing/deleting/delete-line-007-expected.txt:
* platform/gtk/editing/deleting/delete-line-008-expected.txt:
* platform/gtk/editing/deleting/delete-line-009-expected.txt:
* platform/gtk/editing/deleting/delete-line-010-expected.txt:
* platform/gtk/editing/deleting/delete-line-011-expected.txt:
* platform/gtk/editing/deleting/delete-line-012-expected.txt:
* platform/gtk/editing/deleting/delete-line-013-expected.txt:
* platform/gtk/editing/deleting/delete-line-014-expected.txt:
* platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
* platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
* platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
* platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
* platform/gtk/editing/deleting/delete-select-all-002-expected.txt:
* platform/gtk/editing/deleting/delete-tab-002-expected.txt:
* platform/gtk/editing/deleting/delete-tab-004-expected.txt:
* platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
* platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
* platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
* platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
* platform/gtk/editing/deleting/forward-delete-expected.txt:
* platform/gtk/editing/deleting/smart-delete-003-expected.txt:
* platform/gtk/editing/deleting/smart-delete-004-expected.txt:
* platform/gtk/editing/execCommand/
4641880-1-expected.txt: Added.
* platform/gtk/editing/execCommand/
4641880-2-expected.txt: Added.
* platform/gtk/editing/execCommand/create-list-with-hr-expected.txt: Added.
* platform/gtk/editing/execCommand/find-after-replace-expected.txt: Added.
* platform/gtk/editing/execCommand/findString-2-expected.txt: Added.
* platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Added.
* platform/gtk/editing/execCommand/findString-expected.txt: Added.
* platform/gtk/editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
* platform/gtk/editing/execCommand/indent-empty-root-expected.txt: Added.
* platform/gtk/editing/execCommand/indent-list-item-expected.txt: Added.
* platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Removed.
* platform/gtk/editing/execCommand/indent-selection-expected.txt: Added.
* platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt: Added.
* platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt: Added.
* platform/gtk/editing/execCommand/insertImage-expected.txt: Added.
* platform/gtk/editing/execCommand/nsresponder-indent-expected.txt: Added.
* platform/gtk/editing/execCommand/nsresponder-outdent-expected.txt: Added.
* platform/gtk/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
* platform/gtk/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
* platform/gtk/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
* platform/gtk/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
* platform/gtk/editing/execCommand/outdent-selection-expected.txt: Added.
* platform/gtk/editing/execCommand/paste-1-expected.txt: Added.
* platform/gtk/editing/execCommand/paste-2-expected.txt: Added.
* platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
* platform/gtk/editing/execCommand/remove-list-item-1-expected.txt: Added.
* platform/gtk/editing/execCommand/selectAll-expected.txt: Added.
* platform/gtk/editing/inserting/insert-
3654864-fix-expected.txt:
* platform/gtk/editing/inserting/insert-
3775316-fix-expected.txt:
* platform/gtk/editing/inserting/insert-
3800346-fix-expected.txt:
* platform/gtk/editing/inserting/insert-
3851164-fix-expected.txt:
* platform/gtk/editing/inserting/insert-
3907422-fix-expected.txt:
* platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
* platform/gtk/editing/inserting/insert-br-005-expected.txt:
* platform/gtk/editing/inserting/insert-div-001-expected.txt:
* platform/gtk/editing/inserting/insert-div-002-expected.txt:
* platform/gtk/editing/inserting/insert-div-003-expected.txt:
* platform/gtk/editing/inserting/insert-div-004-expected.txt:
* platform/gtk/editing/inserting/insert-div-005-expected.txt:
* platform/gtk/editing/inserting/insert-div-009-expected.txt:
* platform/gtk/editing/inserting/insert-div-024-expected.txt:
* platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
* platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/gtk/editing/inserting/redo-expected.txt:
* platform/gtk/editing/inserting/typing-001-expected.txt:
* platform/gtk/editing/inserting/typing-002-expected.txt:
* platform/gtk/editing/inserting/typing-003-expected.txt:
* platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
* platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
* platform/gtk/editing/pasteboard/
4076267-2-expected.txt:
* platform/gtk/editing/pasteboard/
4076267-3-expected.txt:
* platform/gtk/editing/pasteboard/
4076267-expected.txt:
* platform/gtk/editing/pasteboard/
5368833-expected.txt: Added.
* platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
* platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
* platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
* platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
* platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-013-expected.txt: Added.
* platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/gtk/editing/selection/
4889598-expected.txt:
* platform/gtk/editing/selection/
4947387-expected.txt: Added.
* platform/gtk/editing/selection/
5195166-2-expected.txt: Added.
* platform/gtk/editing/selection/extend-by-character-002-expected.txt:
* platform/gtk/editing/selection/extend-by-character-003-expected.txt:
* platform/gtk/editing/selection/extend-by-character-004-expected.txt:
* platform/gtk/editing/selection/extend-by-character-005-expected.txt:
* platform/gtk/editing/selection/extend-selection-bidi-expected.txt: Added.
* platform/gtk/editing/selection/fake-drag-expected.txt:
* platform/gtk/editing/selection/iframe-expected.txt:
* platform/gtk/editing/selection/inline-table-expected.txt:
* platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
* platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
* platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
* platform/gtk/editing/selection/move-by-character-001-expected.txt:
* platform/gtk/editing/selection/move-by-character-002-expected.txt:
* platform/gtk/editing/selection/move-by-character-003-expected.txt:
* platform/gtk/editing/selection/move-by-character-004-expected.txt:
* platform/gtk/editing/selection/move-by-character-005-expected.txt:
* platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
* platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
* platform/gtk/editing/selection/select-box-expected.txt:
* platform/gtk/editing/selection/selection-actions-expected.txt:
* platform/gtk/editing/spelling/spelling-expected.txt:
* platform/gtk/editing/style/block-style-003-expected.txt:
* platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
* platform/gtk/editing/style/style-
3681552-fix-001-expected.txt:
* platform/gtk/editing/style/style-
3681552-fix-002-expected.txt:
* platform/gtk/editing/style/typing-style-001-expected.txt:
* platform/gtk/editing/style/typing-style-002-expected.txt:
* platform/gtk/editing/style/unbold-in-bold-expected.txt:
* platform/gtk/editing/undo/
4063751-expected.txt:
* platform/gtk/editing/undo/redo-typing-001-expected.txt:
* platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-combined-delete-expected.txt:
* platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-delete-expected.txt:
* platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/gtk/editing/undo/undo-forward-delete-expected.txt:
* platform/gtk/editing/undo/undo-misspellings-expected.txt:
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
* platform/gtk/GtkVersioning.c:
(g_signal_accumulator_first_wins): Add g_signal_accumulator_first_wins for versions of
GLib before 2.28.
* platform/gtk/GtkVersioning.h:
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
Add signals that encapsulate the functionality of the Mac EditingDelegate. These signals
are private for now, but DRT consumes them to produce proper output for editing tests.
After some time, these may be part of the public API.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldDeleteRange): Fire the appropriate editing signal.
(WebKit::EditorClient::shouldShowDeleteInterface): Ditto.
(WebKit::EditorClient::shouldBeginEditing): Ditto.
(WebKit::EditorClient::shouldEndEditing): Ditto.
(WebKit::kit): Added helper function.
(WebKit::EditorClient::shouldInsertText): Fire the appropriate editing signal.
(WebKit::EditorClient::shouldChangeSelectedRange): Ditto.
(WebKit::EditorClient::shouldApplyStyle): Ditto.
(WebKit::EditorClient::didBeginEditing): Ditto.
(WebKit::EditorClient::respondToChangedContents): Ditto.
(WebKit::EditorClient::respondToChangedSelection): Ditto.
(WebKit::EditorClient::didEndEditing): Ditto.
(WebKit::EditorClient::shouldInsertNode): Ditto.
* webkit/webkitwebview.cpp:
(webkit_web_view_real_should_allow_editing_action): Added this default signal
callback which explicitly allows cancellable editing actions.
(webkit_web_view_class_init): Add new editing signal declarations to the view.
* webkit/webkitwebview.h:
* webkitmarshal.list: Added some new marshaling definitions.
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
https://bugs.webkit.org/show_bug.cgi?id=49143
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(createWebView): Call the new connectEditingCallbacks function.
* DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
(dumpNodePath):
(dumpRange):
(insertActionString):
(selectionAffinityString):
(shouldBeginEditing):
(shouldEndEditing):
(shouldInsertNode):
(shouldInsertText):
(shouldDeleteRange):
(shouldShowDeleteInterfaceForElement):
(shouldChangeSelectedRange):
(shouldApplyStyle):
(editingBegan):
(userChangedContents):
(editingEnded):
(selectionChanged):
(connectEditingCallbacks):
* DumpRenderTree/gtk/EditingCallbacks.h: Added.
* GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 24 Nov 2010 16:21:51 +0000 (16:21 +0000)]
2010-11-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, rebaselined mathml/presentation using bots results.
* platform/gtk/mathml/presentation/attributes-expected.txt:
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/fenced-mi-expected.txt:
* platform/gtk/mathml/presentation/fractions-expected.txt:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/gtk/mathml/presentation/mo-expected.txt:
* platform/gtk/mathml/presentation/over-expected.txt:
* platform/gtk/mathml/presentation/roots-expected.txt:
* platform/gtk/mathml/presentation/row-alignment-expected.txt:
* platform/gtk/mathml/presentation/row-expected.txt:
* platform/gtk/mathml/presentation/style-expected.txt:
* platform/gtk/mathml/presentation/sub-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.txt:
* platform/gtk/mathml/presentation/sup-expected.txt:
* platform/gtk/mathml/presentation/tables-expected.txt:
* platform/gtk/mathml/presentation/tokenElements-expected.txt:
* platform/gtk/mathml/presentation/under-expected.txt:
* platform/gtk/mathml/presentation/underover-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 15:56:49 +0000 (15:56 +0000)]
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72499.
http://trac.webkit.org/changeset/72499
https://bugs.webkit.org/show_bug.cgi?id=50022
This change is causing crashes on the bots. (Requested by
mrobinson on #webkit).
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::nameForMSAA):
* accessibility/AccessibilityMenuListOption.h:
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
(optionFromList):
(optionFromSelection):
(webkit_accessible_selection_add_selection):
(webkit_accessible_selection_clear_selection):
(webkit_accessible_selection_get_selection_count):
(webkit_accessible_selection_is_child_selected):
(webkit_accessible_selection_remove_selection):
(webkit_accessible_text_get_text):
(getInterfaceMaskFromObject):
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show):
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72499.
http://trac.webkit.org/changeset/72499
https://bugs.webkit.org/show_bug.cgi?id=50022
This change is causing crashes on the bots. (Requested by
mrobinson on #webkit).
* tests/testatk.c:
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 24 Nov 2010 15:51:54 +0000 (15:51 +0000)]
2010-11-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Csaba Osztrogonác.
Simplify makeprop.pl
https://bugs.webkit.org/show_bug.cgi?id=49925
Don't generate CSSPropertyNamesHash.h.
Instead generate CSSPropertyNames directly.
* GNUmakefile.am: Removed rule for CSSPropertyNamesHash.h.
* css/makeprop.pl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 15:49:03 +0000 (15:49 +0000)]
2010-11-24 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt] Make QtTestBrowser remember the selected user agent
https://bugs.webkit.org/show_bug.cgi?id=50021
Set user agent for a new page by using the old page's
* QtTestBrowser/mainwindow.cpp:
(MainWindow::setPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 24 Nov 2010 15:38:29 +0000 (15:38 +0000)]
2010-11-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, unskipped and rebaselined mathml/presentation tests
after r72413
* platform/gtk/Skipped:
* platform/gtk/mathml/presentation/attributes-expected.checksum:
* platform/gtk/mathml/presentation/attributes-expected.png:
* platform/gtk/mathml/presentation/attributes-expected.txt:
* platform/gtk/mathml/presentation/fenced-expected.checksum:
* platform/gtk/mathml/presentation/fenced-expected.png:
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/fenced-mi-expected.checksum:
* platform/gtk/mathml/presentation/fenced-mi-expected.png:
* platform/gtk/mathml/presentation/fenced-mi-expected.txt:
* platform/gtk/mathml/presentation/fractions-expected.checksum:
* platform/gtk/mathml/presentation/fractions-expected.png:
* platform/gtk/mathml/presentation/fractions-expected.txt:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/gtk/mathml/presentation/mo-expected.checksum:
* platform/gtk/mathml/presentation/mo-expected.png:
* platform/gtk/mathml/presentation/mo-expected.txt:
* platform/gtk/mathml/presentation/over-expected.checksum:
* platform/gtk/mathml/presentation/over-expected.png:
* platform/gtk/mathml/presentation/over-expected.txt:
* platform/gtk/mathml/presentation/roots-expected.checksum:
* platform/gtk/mathml/presentation/roots-expected.png:
* platform/gtk/mathml/presentation/roots-expected.txt:
* platform/gtk/mathml/presentation/row-alignment-expected.checksum:
* platform/gtk/mathml/presentation/row-alignment-expected.png:
* platform/gtk/mathml/presentation/row-alignment-expected.txt:
* platform/gtk/mathml/presentation/row-expected.checksum:
* platform/gtk/mathml/presentation/row-expected.png:
* platform/gtk/mathml/presentation/row-expected.txt:
* platform/gtk/mathml/presentation/style-expected.checksum:
* platform/gtk/mathml/presentation/style-expected.png:
* platform/gtk/mathml/presentation/style-expected.txt:
* platform/gtk/mathml/presentation/sub-expected.checksum:
* platform/gtk/mathml/presentation/sub-expected.png:
* platform/gtk/mathml/presentation/sub-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.checksum:
* platform/gtk/mathml/presentation/subsup-expected.png:
* platform/gtk/mathml/presentation/subsup-expected.txt:
* platform/gtk/mathml/presentation/sup-expected.checksum:
* platform/gtk/mathml/presentation/sup-expected.png:
* platform/gtk/mathml/presentation/sup-expected.txt:
* platform/gtk/mathml/presentation/tables-expected.checksum:
* platform/gtk/mathml/presentation/tables-expected.png:
* platform/gtk/mathml/presentation/tables-expected.txt:
* platform/gtk/mathml/presentation/tokenElements-expected.checksum:
* platform/gtk/mathml/presentation/tokenElements-expected.png:
* platform/gtk/mathml/presentation/tokenElements-expected.txt:
* platform/gtk/mathml/presentation/under-expected.checksum:
* platform/gtk/mathml/presentation/under-expected.png:
* platform/gtk/mathml/presentation/under-expected.txt:
* platform/gtk/mathml/presentation/underover-expected.checksum:
* platform/gtk/mathml/presentation/underover-expected.png:
* platform/gtk/mathml/presentation/underover-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 24 Nov 2010 15:35:55 +0000 (15:35 +0000)]
2010-11-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove Bakefile build system files
https://bugs.webkit.org/show_bug.cgi?id=49983
r53757 only removed the content, but not the files.
This patch removes that empty files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Wed, 24 Nov 2010 15:21:31 +0000 (15:21 +0000)]
[Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions
https://bugs.webkit.org/show_bug.cgi?id=49919
Reviewed by Andreas Kling.
Add ASSERT_NOT_REACHED() if the given WebCore type doesn't have an equivalent type in Qt.
Also change the return value of toQtLineJoin() from Qt::MiterJoin to the default Qt::SvgMiterJoin,
because the previous one doesn't work currently.
No new test is needed.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::toQtCompositionMode):
(WebCore::toQtLineCap):
(WebCore::toQtLineJoin):
(WebCore::toQPenStyle):
(WebCore::toQtFillRule):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 24 Nov 2010 14:51:14 +0000 (14:51 +0000)]
2010-11-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Csaba Osztrogonác.
Simplify makevalues.pl
https://bugs.webkit.org/show_bug.cgi?id=49926
Don't generate CSSValueKeywordsHash.h.
Instead generate CSSValueKeywords.cpp directly.
* GNUmakefile.am: Removed rule for CSSValueKeywordsHash.h.
* css/makevalues.pl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 24 Nov 2010 14:38:47 +0000 (14:38 +0000)]
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Make WebKit2 compile with !ENABLE(INSPECTOR).
https://bugs.webkit.org/show_bug.cgi?id=49973
No new tests needed.
* bindings/js/ScriptHeapSnapshot.h:
* bindings/js/ScriptProfile.cpp:
* bindings/js/ScriptProfile.h:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/ScriptBreakpoint.h:
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Make WebKit2 compile with !ENABLE(INSPECTOR).
https://bugs.webkit.org/show_bug.cgi?id=49973
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled):
2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
Make WebKit2 compile with !ENABLE(INSPECTOR).
https://bugs.webkit.org/show_bug.cgi?id=49973
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKInspector.cpp:
* UIProcess/API/C/WKInspector.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
* UIProcess/qt/WebInspectorProxyQt.cpp:
* UIProcess/win/WebInspectorProxyWin.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
* WebProcess/WebPage/WebInspector.cpp:
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/WebInspector.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::windowIsFocused):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/qt/WebInspectorQt.cpp:
* WebProcess/WebPage/win/WebInspectorWin.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 24 Nov 2010 13:47:57 +0000 (13:47 +0000)]
2010-11-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Make deep copies of tile images
We need the tile images we get from UpdateChunk::createImage() to persist,
so we should take a copy() of them.
* UIProcess/qt/TiledDrawingAreaTileQt.cpp:
(WebKit::TiledDrawingAreaTile::updateFromChunk):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 24 Nov 2010 13:26:59 +0000 (13:26 +0000)]
2010-11-24 Patrick Gansterer <paroga@webkit.org>
Reviewed by Csaba Osztrogonác.
Simplify make-hash-tools.pl
https://bugs.webkit.org/show_bug.cgi?id=49922
HashTools.h does not need to be generated, because it only contains static code.
* html/DocTypeStrings.gperf: Include findDoctypeEntry function.
* make-hash-tools.pl: Do not generate HashTools.h.
* platform/ColorData.gperf: Include findColor function.
* platform/HashTools.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loki@webkit.org [Wed, 24 Nov 2010 13:04:35 +0000 (13:04 +0000)]
2010-11-24 Gabor Loki <loki@webkit.org>
Reviewed by Csaba Osztrogonác.
Merge the usage of jumps and calls at ARM-JIT
https://bugs.webkit.org/show_bug.cgi?id=50008
Those JmpSrc objects which represent jumps (not calls) should point to
after the jump instruction.
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::getAbsoluteJumpAddress):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::relinkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::relinkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::call):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 12:51:02 +0000 (12:51 +0000)]
2010-11-24 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Optimize foldCase, toLower and toUpper methods in glib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=48625
GLib methods use UTF-8 strings, so we have to convert from UTF-16 to
UTF-8 to perform the case operations and then convert back the result to
UTF-16. GLib conversion methods return a new allocated string, so we
have to memcpy the result into the destination buffer too. Using our
own methods to convert between UTF-8 and UTF-16 from wtf/unicode/UTF8.h
we don't need such memcpy, since they take an already allocated buffer
rather than returning a new one. There's another optimization for the
case when the destination buffer is not large enough. In that case,
methods should return the expected destination buffer size and are
called again with a new buffer. We can avoid the conversion to UTF-16 by
pre-calculating the required size for the destination buffer.
* wtf/unicode/glib/UnicodeGLib.cpp:
(WTF::Unicode::getUTF16LengthFromUTF8):
(WTF::Unicode::convertCase):
(WTF::Unicode::foldCase):
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Wed, 24 Nov 2010 12:29:25 +0000 (12:29 +0000)]
2010-11-24 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Re-enabled layout tests which were disabled during an API migration.
https://bugs.webkit.org/show_bug.cgi?id=50013
* platform/chromium/test_expectations.txt:
2010-11-24 Satish Sampath <satish@chromium.org>
Reviewed by Steve Block.
Remove API migration code which is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=50013
* public/WebSpeechInputControllerMock.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 24 Nov 2010 12:04:41 +0000 (12:04 +0000)]
2010-11-24 Andreas Kling <kling@webkit.org>
Reviewed by Simon Hausmann.
[Qt] Pass Qt::TextBypassShaping flag when calculating shadow layer rects
Without this, we could end up with a slightly too small shadow layer
for some string/font combinations.
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 24 Nov 2010 12:00:08 +0000 (12:00 +0000)]
2010-11-24 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. chromium expectation fix.
BUG49967 MAC : font-size-zero.html = TEXT
was restored.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 24 Nov 2010 11:42:20 +0000 (11:42 +0000)]
2010-11-24 Steve block <steveblock@google.com>
Reviewed by Jeremy Orlow.
LayoutTest fast/dom/DeviceOrientation/event-after-navigation.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=49384
This is an asynchronous script test which navigates the main page but
relies on js-test-post.js calling LayoutTestController.waitUntilDone().
It's possible for the main page to be navigated and hence the load of
js-test-post.js to be cancelled before
LayoutTestController.waitUntilDone() is called, which causes the test to
fail.
* fast/dom/DeviceOrientation/script-tests/event-after-navigation.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 24 Nov 2010 11:04:22 +0000 (11:04 +0000)]
2010-11-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add timing tab to the network item view.
https://bugs.webkit.org/show_bug.cgi?id=49920
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._showPopover):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.set timing):
* inspector/front-end/ResourceTimingView.js: Added.
(WebInspector.ResourceTimingView):
(WebInspector.ResourceTimingView.prototype.show):
(WebInspector.ResourceTimingView.prototype._refresh):
(WebInspector.ResourceTimingView.createTimingTable):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/networkPanel.css:
(#network-views .network-item-view .tabbed-pane-header):
(.resource-timing-view):
(.resource-timing-view table):
(.resource-timing-view .network-timing-bar):
(.resource-timing-view .network-timing-bar.proxy):
(.resource-timing-view .network-timing-bar.dns):
(.resource-timing-view .network-timing-bar.connecting):
(.resource-timing-view .network-timing-bar.ssl):
(.resource-timing-view .network-timing-bar.sending):
(.resource-timing-view .network-timing-bar.waiting):
(.resource-timing-view .network-timing-bar.receiving):
(.resource-timing-view.visible):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 24 Nov 2010 10:59:12 +0000 (10:59 +0000)]
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r72652 (style id change in inspector).
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 24 Nov 2010 10:36:12 +0000 (10:36 +0000)]
2010-11-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: refactor ResourceView hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=49864
This refactoring splits ResourceView.js into:
NetworkItemView.js (tabbed pane)
ResourceHeadersView.js (header tab)
ResourceCookiesView.js (cookies tab)
ResourceView.js (base class for content tab).
CookiesTable was extracted from CookieItemsView and
brushed up. headersVisible flag has been removed.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype.get statusBarItems):
(WebInspector.CookieItemsView.prototype.hide):
(WebInspector.CookieItemsView.prototype.resize):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
(WebInspector.CookieItemsView.prototype._deleteCookie):
(WebInspector.CookieItemsView.prototype._deleteButtonClicked):
(WebInspector.CookieItemsView.prototype._refreshButtonClicked):
(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):
(WebInspector.SimpleCookiesTable.prototype.resize):
* inspector/front-end/CookiesTable.js: Added.
(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype.updateWidths):
(WebInspector.CookiesTable.prototype.setCookies):
(WebInspector.CookiesTable.prototype.addCookiesFolder):
(WebInspector.CookiesTable.prototype.get selectedCookie):
(WebInspector.CookiesTable.prototype._rebuildTable):
(WebInspector.CookiesTable.prototype.reset):
(WebInspector.CookiesTable.prototype._populateNode):
(WebInspector.CookiesTable.prototype._totalSize):
(WebInspector.CookiesTable.prototype._sortCookies.localeCompare):
(WebInspector.CookiesTable.prototype._sortCookies.numberCompare):
(WebInspector.CookiesTable.prototype._sortCookies.expiresCompare):
(WebInspector.CookiesTable.prototype._sortCookies):
(WebInspector.CookiesTable.prototype._createGridNode):
(WebInspector.CookiesTable.prototype._onDeleteFromGrid):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.prototype._selectFileSystemTab):
(WebInspector.FileSystemView.prototype.selectTemporaryFileSystemTab):
* inspector/front-end/FontView.js:
(WebInspector.FontView.prototype.hasContent):
(WebInspector.FontView.prototype._createContentIfNeeded):
(WebInspector.FontView.prototype.show):
(WebInspector.FontView.prototype.updateFontPreviewSize):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype.hasContent):
(WebInspector.ImageView.prototype.show):
* inspector/front-end/NetworkItemView.js: Added.
(WebInspector.NetworkItemView):
(WebInspector.NetworkItemView.prototype.show):
(WebInspector.NetworkItemView.prototype._selectTab):
(WebInspector.NetworkItemView.prototype._tabSelected):
(WebInspector.NetworkItemView.prototype.resize):
(WebInspector.NetworkItemView.prototype.selectContentTab):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.show):
(WebInspector.NetworkPanel.prototype.refreshResource):
(WebInspector.NetworkPanel.prototype._showResource):
(WebInspector.NetworkPanel.prototype._closeVisibleResource):
* inspector/front-end/ResourceCookiesView.js: Added.
(WebInspector.ResourceCookiesView):
(WebInspector.ResourceCookiesView.prototype.show):
* inspector/front-end/ResourceHeadersView.js: Added.
(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshURL):
(WebInspector.ResourceHeadersView.prototype._refreshQueryString):
(WebInspector.ResourceHeadersView.prototype._refreshFormData):
(WebInspector.ResourceHeadersView.prototype._refreshRequestPayload):
(WebInspector.ResourceHeadersView.prototype._refreshParms):
(WebInspector.ResourceHeadersView.prototype._toggleURLdecoding):
(WebInspector.ResourceHeadersView.prototype._getHeaderValue):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
(WebInspector.ResourceHeadersView.prototype._refreshHeaders):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView):
(WebInspector.ResourceView.prototype.hasContent):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
(WebInspector.ResourcesPanel.prototype.showResource):
(WebInspector.ResourcesPanel.prototype._showResourceView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView):
(WebInspector.SourceView.prototype.show):
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.resize):
(WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
(WebInspector.SourceView.prototype.hasContent):
(WebInspector.SourceView.prototype.updateLocalContent):
(WebInspector.SourceView.prototype.selectLocalContentTab):
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.selectTab):
(WebInspector.TabbedPane.prototype._showTab):
(WebInspector.TabbedPane.prototype._hideTab):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.webkit-line-gutter-backdrop):
(.resource-view):
(.resource-view.visible):
(.resource-view.font):
(.resource-view.image > .image):
(.resource-view.image > .info):
(.storage-view):
(.storage-view .data-grid):
(.storage-empty-view, .storage-view .storage-table-error):
(.storage-view .storage-table-error):
* inspector/front-end/inspector.html:
* inspector/front-end/networkPanel.css:
(.network-cell-subtitle):
(.network-header-subtitle):
(#network-views .network-item-view .tabbed-pane-header):
(#network-views.small .network-item-view .tabbed-pane-header):
(.network-item-view):
(.network-item-view.visible):
(.network-item-view .tabbed-pane-header):
(.network-item-view .scope-bar li):
(.resource-headers-view):
(.resource-headers-view.visible):
(.resource-headers-view .outline-disclosure .parent):
(.resource-headers-view .outline-disclosure .children li):
(.resource-headers-view .outline-disclosure li.expanded .header-count):
(.resource-headers-view .outline-disclosure .header-name):
(.resource-headers-view .outline-disclosure .header-value):
(.resource-headers-view .outline-disclosure .raw-form-data):
(.resource-cookies-view):
(.resource-cookies-view.visible):
(.resource-cookies-view .data-grid):
(.resource-cookies-view .data-grid .row-group):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 24 Nov 2010 10:28:27 +0000 (10:28 +0000)]
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add "Locally modified" group into the resource panel.
https://bugs.webkit.org/show_bug.cgi?id=50005
* English.lproj/localizedStrings.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype.addLocallyModifiedRevision):
(WebInspector.ResourcesPanel.prototype._innerShowView):
(WebInspector.BaseStorageTreeElement.prototype.set titleText):
(WebInspector.LocallyModifiedResourceTreeElement):
(WebInspector.LocallyModifiedResourceTreeElement.prototype.onselect):
(WebInspector.LocallyModifiedResourceTreeElement.prototype.gcRevisions):
(WebInspector.LocallyModifiedRevisionTreeElement):
(WebInspector.LocallyModifiedRevisionTreeElement.prototype.onattach):
(WebInspector.LocallyModifiedRevisionTreeElement.prototype.onselect):
(WebInspector.LocallyModifiedRevisionTreeElement.prototype._ondragstart):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 10:24:02 +0000 (10:24 +0000)]
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72650.
http://trac.webkit.org/changeset/72650
https://bugs.webkit.org/show_bug.cgi?id=50010
breaks focus in scenes focus item other than graphicswebiview
(Requested by tronical_ on #webkit).
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::itemChange):
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 24 Nov 2010 10:11:39 +0000 (10:11 +0000)]
2010-11-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: pass style id to front-end as Object, not string.
https://bugs.webkit.org/show_bug.cgi?id=49971
* inspector/Inspector.idl:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode2):
(WebCore::InspectorCSSAgent::getStyleSheetText2):
(WebCore::InspectorCSSAgent::setPropertyText2):
(WebCore::InspectorCSSAgent::toggleProperty2):
(WebCore::InspectorCSSAgent::setRuleSelector2):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyleSheet::finalURL):
(WebCore::InspectorStyleSheet::ruleForId):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::text):
(WebCore::InspectorStyleSheet::ruleOrStyleId):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
(WebCore::InspectorStyleSheetForInlineStyle::text):
* inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::InspectorCSSId):
(WebCore::InspectorCSSId::isEmpty):
(WebCore::InspectorCSSId::styleSheetId):
(WebCore::InspectorCSSId::ordinal):
(WebCore::InspectorCSSId::asInspectorValue):
(WebCore::InspectorStyleSheet::id):
(WebCore::InspectorStyleSheetForInlineStyle::styleForId):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._styleSheetChanged):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setDisabled.callback):
(WebInspector.CSSProperty.prototype.setDisabled):
(WebInspector.CSSStyleSheet.createForId):
(WebInspector.CSSStyleSheet.prototype.setText):
2010-11-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: pass style id to front-end as Object, not string.
https://bugs.webkit.org/show_bug.cgi?id=49971
* inspector/styles-new-API.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 24 Nov 2010 09:47:17 +0000 (09:47 +0000)]
2010-11-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix uninitialized variable in QGraphicsWKViewPrivate
Always initialize QGWKVP::m_isChangingScale in the constructor.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 09:34:56 +0000 (09:34 +0000)]
2010-11-24 Jan Erik Hanssen <jhanssen@sencha.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Html autofocus not working with QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=43169
QGraphicsScene does not propagate Qt::ActivateWindowFocusReason focus
events when there are no active items.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::eventFilter):
(QGraphicsWebView::itemChange):
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(FocusPage::FocusPage):
(FocusPage::event):
(FocusPage::gotFocus):
(tst_QGraphicsWebView::receivesFocusInOnShow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 24 Nov 2010 09:25:30 +0000 (09:25 +0000)]
2010-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72647.
http://trac.webkit.org/changeset/72647
https://bugs.webkit.org/show_bug.cgi?id=50009
breaks the http layout tests (Requested by philn-tp on
#webkit).
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
(WebCore::startHttp):
(WebCore::ResourceHandle::platformSetDefersLoading):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 24 Nov 2010 08:32:21 +0000 (08:32 +0000)]
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Fix for chromium expectations.
composited-plugin.html is crashing on MAC.
small-to-large-composited-plugin.html is crashing on MAC.
font-size-zero.html is passing.
* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 24 Nov 2010 08:24:26 +0000 (08:24 +0000)]
2010-11-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[soup] implement ResourceHandle::platformSetDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=44158
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::platformSetDefersLoading): Implemented
using the soup_session_{,un}pause_message APIs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 24 Nov 2010 06:35:38 +0000 (06:35 +0000)]
2010-11-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Levin.
Add WebKit2 VisualStudio files to .gitattributes
https://bugs.webkit.org/show_bug.cgi?id=49969
* .gitattributes:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 24 Nov 2010 04:44:44 +0000 (04:44 +0000)]
2010-11-23 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Drag and drop not working properly. Skipping just like other similar drag
and drop tests. E.g. similar test drag-image-in-about-blank-frame.html.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 24 Nov 2010 04:14:40 +0000 (04:14 +0000)]
2010-11-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
r71925 broke the chrome new tab page. r71925 blocked drag and drop
of same security origin objects onto themselves if their origin is
marked unique. We need to allow drag and drop in that scenario.
https://bugs.webkit.org/show_bug.cgi?id=49098
Test: http/tests/security/drag-drop-same-unique-origin.html
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canReceiveDragData):
2010-11-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Tests that drag and drop is allowed across the same security origin object,
even if they are marked unique.
* http/tests/security/drag-drop-same-unique-origin-expected.txt: Added.
* http/tests/security/drag-drop-same-unique-origin.html: Added.
* http/tests/security/resources/drag-drop-allowed.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 24 Nov 2010 00:22:32 +0000 (00:22 +0000)]
2010-11-23 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed update of GTK's skipped list.
Disabled editing/deleting/delete-by-word-001.html and editing/deleting/delete-by-word-002.html
because they require editing delegates dump which haven't been implemented in GTK.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 24 Nov 2010 00:19:53 +0000 (00:19 +0000)]
2010-11-23 Tony Chang <tony@chromium.org>
Unreviewed, [chromium] merge the plugin failures in test_expectations
https://bugs.webkit.org/show_bug.cgi?id=49993
* platform/chromium/drt_expectations.txt: Remove plugin failures
* platform/chromium/test_expectations.txt: Move them into this file
with expectations that are valid for either plugin.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 24 Nov 2010 00:15:16 +0000 (00:15 +0000)]
2010-11-23 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
This patch cleans up the logic used to shard tests into groups a
bit and adds the --worker-model flag to NRWT. The flag is only
used at the moment to control whether to run single-threaded or
not, but eventually will also allow toggling between threads and
processes.
Also add a minor cleanup with _test_is_slow(), which just
eliminates some repetition and gives slightly better encapsulation.
https://bugs.webkit.org/show_bug.cgi?id=49773
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 24 Nov 2010 00:12:39 +0000 (00:12 +0000)]
2010-11-23 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Rebaseline server: list current baselines and platforms
https://bugs.webkit.org/show_bug.cgi?id=49991
List existing baselines (with Trac links) for tests.
Add dropdowns for choosing with platform baselines to target (and what
to do with existing ones).
Also fix MockFileSystem.join to behave more like os.path.join (unit
test was ending up with two consecutive slashes in a layout test
path).
* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
* Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 24 Nov 2010 00:12:00 +0000 (00:12 +0000)]
2010-11-23 Cris Neckar <cdn@chromium.org>
Reviewed by Dimitri Glazkov.
Removed unneeded conversions to RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=49896
Test: fast/css/input-search-table-column-crash.html
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
2010-11-23 Cris Neckar <cdn@chromium.org>
Reviewed by Dimitri Glazkov.
Test for crash with input type search and table column style.
https://bugs.webkit.org/show_bug.cgi?id=49896
* fast/css/input-search-table-column-crash-expected.txt: Added.
* fast/css/input-search-table-column-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 23 Nov 2010 23:59:46 +0000 (23:59 +0000)]
2010-11-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag
https://bugs.webkit.org/show_bug.cgi?id=49701
Fixed the bug by calling ScriptElement's executeScript, which sets isEvaluated flag to true.
Test: fast/dom/script-clone-rerun-src.xhtml
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::notifyFinished):
2010-11-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag
https://bugs.webkit.org/show_bug.cgi?id=49701
Added a test to ensure WebKit doesn't run the script twice when a script element with an external script file
is cloned in a XML document.
* fast/dom/resources/script-clone-rerun-src.js: Added.
* fast/dom/script-clone-rerun-src.xhtml: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 23 Nov 2010 23:39:43 +0000 (23:39 +0000)]
2010-11-23 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
dumpAsText conversion: editing/deleting/delete-by-word-001.html and delete-by-word-002.html
https://bugs.webkit.org/show_bug.cgi?id=48130
Converted editing/deleting/delete-by-word-001.html and delete-by-word-002.html to dumpAsText tests
by replacing calls to runEditingTest by runDumpAsTextEditingTest.
* editing/deleting/delete-by-word-001-expected.txt: Added.
* editing/deleting/delete-by-word-001.html:
* editing/deleting/delete-by-word-002-expected.txt: Added.
* editing/deleting/delete-by-word-002.html:
* platform/chromium-linux/editing/deleting/delete-by-word-001-expected.checksum: Removed.
* platform/chromium-linux/editing/deleting/delete-by-word-001-expected.png: Removed.
* platform/chromium-linux/editing/deleting/delete-by-word-002-expected.checksum: Removed.
* platform/chromium-linux/editing/deleting/delete-by-word-002-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-by-word-001-expected.checksum: Removed.
* platform/chromium-win/editing/deleting/delete-by-word-001-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-by-word-001-expected.txt: Removed.
* platform/chromium-win/editing/deleting/delete-by-word-002-expected.checksum: Removed.
* platform/chromium-win/editing/deleting/delete-by-word-002-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-by-word-002-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Removed.
* platform/mac/editing/deleting/delete-by-word-001-expected.checksum: Removed.
* platform/mac/editing/deleting/delete-by-word-001-expected.png: Removed.
* platform/mac/editing/deleting/delete-by-word-001-expected.txt: Removed.
* platform/mac/editing/deleting/delete-by-word-002-expected.checksum: Removed.
* platform/mac/editing/deleting/delete-by-word-002-expected.png: Removed.
* platform/mac/editing/deleting/delete-by-word-002-expected.txt: Removed.
* platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Removed.
* platform/qt/editing/deleting/delete-by-word-001-expected.png: Removed.
* platform/qt/editing/deleting/delete-by-word-001-expected.txt: Removed.
* platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Removed.
* platform/qt/editing/deleting/delete-by-word-002-expected.png: Removed.
* platform/qt/editing/deleting/delete-by-word-002-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 23 Nov 2010 23:39:29 +0000 (23:39 +0000)]
2010-11-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
remove timeout argument to urlopen
https://bugs.webkit.org/show_bug.cgi?id=49995
Apparently the version of python we have on the bots doesn't accept a timeout argument.
* Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 23:36:38 +0000 (23:36 +0000)]
2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994
This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).
* accessibility/iframe-has-document-expected.txt: Removed.
* accessibility/iframe-has-document.html: Removed.
* platform/win/Skipped:
2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994
This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994
This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::parentObject):
2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994
This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::parentElementCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/chromium/CppBoundClass.cpp:
* DumpRenderTree/chromium/CppBoundClass.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Tue, 23 Nov 2010 23:15:06 +0000 (23:15 +0000)]
WebCore:
2010-11-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix IFrame DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=49980
Fix IFrame API naming. It needs special casing because of the two
consecutive capital letters.
* bindings/scripts/CodeGeneratorGObject.pm:
WebKit/gtk:
2010-11-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix IFrame DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=49980
* tests/testdomdocument.c:
(test_dom_document_garbage_collection): change to use the fixed
IFrame APIs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 23 Nov 2010 22:59:58 +0000 (22:59 +0000)]
2010-11-22 Ojan Vafai <ojan@chromium.org>
Reviewed by Tony Chang.
speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=49944
* Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Tue, 23 Nov 2010 22:55:54 +0000 (22:55 +0000)]
Unreviewed, fixing chromium gpu_test expectations.
Remove entries for tests that no longer exist, removed in r71822.
Remove duplicates introduced in r72613.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 22:54:45 +0000 (22:54 +0000)]
2010-11-23 Shimeng (Simon) Wang <swang@google.com>
Reviewed by Steve Block.
Use platform bridge to set scroll position.
https://bugs.webkit.org/show_bug.cgi?id=49550
Refactoring only. Existing tests shall suffice.
* platform/android/PlatformBridge.h:
* platform/android/ScrollViewAndroid.cpp:
(WebCore::ScrollView::platformSetScrollPosition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 22:51:43 +0000 (22:51 +0000)]
2010-11-23 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Selecting shadowed text causes rendering artifacts
https://bugs.webkit.org/show_bug.cgi?id=49990
When selecting text starting from the end of a word, we need to use
the X coordinate of the start of the substring when calculating the
bounding rect for a ContextShadow.
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 23 Nov 2010 22:43:30 +0000 (22:43 +0000)]
2010-11-23 Chris Rogers <crogers@google.com>
Unreviewed.
Disable new XMLHttpRequest layout tests for Qt and gtk since they require ArrayBuffer support
https://bugs.webkit.org/show_bug.cgi?id=49992
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 22:33:49 +0000 (22:33 +0000)]
2010-11-23 Chris Guillory <chris.guillory@google.com>
Reviewed by Dimitri Glazkov.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
* accessibility/iframe-has-document-expected.txt: Added.
* accessibility/iframe-has-document.html: Added.
* platform/win/Skipped:
2010-11-23 Chris Guillory <chris.guillory@google.com>
Reviewed by Dimitri Glazkov.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
Include render widget children in the accessibility tree for not mac webkit ports.
Test: accessibility/iframe-has-document.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::addChildren):
(WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
2010-11-23 Chris Guillory <chris.guillory@google.com>
Reviewed by Dimitri Glazkov.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::equals):
(WebKit::WebAccessibilityObject::parentObject):
2010-11-23 Chris Guillory <chris.guillory@google.com>
Reviewed by Dimitri Glazkov.
Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::parentElementCallback):
(AccessibilityUIElement::isEqualCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/chromium/CppBoundClass.cpp:
(CppBoundClass::getFromCppVariant):
* DumpRenderTree/chromium/CppBoundClass.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 23 Nov 2010 22:00:07 +0000 (22:00 +0000)]
2010-11-23 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] update plugin expectations
https://bugs.webkit.org/show_bug.cgi?id=49988
* platform/chromium/drt_expectations.txt: These tests are passing on the bot
* platform/chromium/test_expectations.txt: Group and sort alphabetically
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 23 Nov 2010 21:51:00 +0000 (21:51 +0000)]
2010-11-23 Chris Rogers <crogers@google.com>
Reviewed by Alexey Proskuryakov.
Add .responseType and .response to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=49633
Tests: fast/xmlhttprequest/xmlhttprequest-responsetype-abort.html
fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
fast/xmlhttprequest/xmlhttprequest-responsetype-document.html
fast/xmlhttprequest/xmlhttprequest-responsetype-text.html
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::response):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::responseText):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::responseBlob):
(WebCore::XMLHttpRequest::responseArrayBuffer):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::responseType):
(WebCore::XMLHttpRequest::setAsBlob):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::asBlob):
(WebCore::XMLHttpRequest::optionalResponseXML):
(WebCore::XMLHttpRequest::optionalResponseBlob):
(WebCore::XMLHttpRequest::responseTypeCode):
(WebCore::XMLHttpRequest::optionalResponseArrayBuffer):
* xml/XMLHttpRequest.idl:
2010-11-23 Chris Rogers <crogers@google.com>
Reviewed by Alexey Proskuryakov.
Add .responseType and .response to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=49633
* fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-abort.html: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-document-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-document.html: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-text-expected.txt: Added.
* fast/xmlhttprequest/xmlhttprequest-responsetype-text.html: Added.
* http/tests/resources/balls-of-the-orient.aif: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 23 Nov 2010 21:34:29 +0000 (21:34 +0000)]
2010-11-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
dispatchEvent call in EventSource endRequest can lead to calling endRequest
again which frees up the pending activity. Make sure we have request in flight
to prevent that from happening.
https://bugs.webkit.org/show_bug.cgi?id=49448
Test: http/tests/eventsource/eventsource-status-error-iframe-crash.html
* page/EventSource.cpp:
(WebCore::EventSource::endRequest):
(WebCore::EventSource::close):
2010-11-23 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Tests that we do not crash on EventSource status errors inside an iframe.
https://bugs.webkit.org/show_bug.cgi?id=49448
* http/tests/eventsource/eventsource-status-error-iframe-crash-expected.txt: Added.
* http/tests/eventsource/eventsource-status-error-iframe-crash.html: Added.
* http/tests/eventsource/resources/request-status-error.htm: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 21:30:41 +0000 (21:30 +0000)]
2010-11-23 John Knottenbelt <jknotten@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Introduce wrapper types for WebCore::GeolocationError, WebCore::GeolocationPosition.
https://bugs.webkit.org/show_bug.cgi?id=49735
Introduce WebKit API types so that the browser implementation can feed
position and error updates to the WebCore::GeolocationController.
* WebKit.gyp:
* public/WebGeolocationError.h: Added.
(WebKit::WebGeolocationError::WebGeolocationError):
(WebKit::WebGeolocationError::~WebGeolocationError):
* public/WebGeolocationPosition.h: Added.
(WebKit::WebGeolocationPosition::WebGeolocationPosition):
(WebKit::WebGeolocationPosition::~WebGeolocationPosition):
* src/WebGeolocationError.cpp: Added.
(WebKit::WebGeolocationError::assign):
(WebKit::WebGeolocationError::reset):
(WebKit::WebGeolocationError::WebGeolocationError):
(WebKit::WebGeolocationError::operator=):
(WebKit::WebGeolocationError::operator WTF::PassRefPtr<WebCore::GeolocationError>):
* src/WebGeolocationPosition.cpp: Added.
(WebKit::WebGeolocationPosition::assign):
(WebKit::WebGeolocationPosition::reset):
(WebKit::WebGeolocationPosition::operator=):
(WebKit::WebGeolocationPosition::operator PassRefPtr<WebCore::GeolocationPosition>):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 21:07:11 +0000 (21:07 +0000)]
2010-11-23 Jonathan Backer <backer@chromium.org>
Reviewed by Kenneth Russell.
Renderer is resizing IOSurfaces when accelerated compositing is disabled.
https://bugs.webkit.org/show_bug.cgi?id=49827
- IOSurfaces are only presented when accelerated compositing is enabled.
- Slight performance increase (and clean-up for using this path for Linux and Windows).
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Tue, 23 Nov 2010 20:50:02 +0000 (20:50 +0000)]
2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72618.
http://trac.webkit.org/changeset/72618
https://bugs.webkit.org/show_bug.cgi?id=49987
"Newly added test is failing on Chromium-linux, patch author
said to rollout" (Requested by jparent on #webkit).
* editing/EditingBehavior.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72618.
http://trac.webkit.org/changeset/72618
https://bugs.webkit.org/show_bug.cgi?id=49987
"Newly added test is failing on Chromium-linux, patch author
said to rollout" (Requested by jparent on #webkit).
* editing/selection/context-menu-text-selection-expected.txt: Removed.
* editing/selection/context-menu-text-selection.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 23 Nov 2010 20:40:34 +0000 (20:40 +0000)]
2010-11-23 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
focus issue with links that have tooltips
https://bugs.webkit.org/show_bug.cgi?id=49498
Set the area of the widget where the tooltip should be shown when
a new tooltip is set. Since the widget is the same (the view), if
the tooltip area is not set and a new tooltip is triggered while
the previous one is still visible, the text of the tooltip is
updated but its position doesn't change.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::mouseDidMoveOverElement):
* webkit/webkitprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_query_tooltip):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 20:33:07 +0000 (20:33 +0000)]
2010-11-23 Grace Kloba <klobag@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Accumulated scroll damage rect should be in the content space
https://bugs.webkit.org/show_bug.cgi?id=49842
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollRootLayerRect): Adjust the previous scroll damage with the scroll delta before union it with the new damage rect.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Tue, 23 Nov 2010 20:14:37 +0000 (20:14 +0000)]
Unreviewed, fixing chromium baselines.
Adding back baselines that were removed in r72542 due to r72527, because
r72527 was rolled ou in r72582.
* platform/chromium-mac/fast/lists/001-vertical-expected.checksum:
* platform/chromium-mac/fast/lists/001-vertical-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 19:33:57 +0000 (19:33 +0000)]
2010-11-23 Avi Drissman <avi@google.com>
Reviewed by Antonio Gomes.
Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351
* editing/selection/context-menu-text-selection-expected.txt: Added.
* editing/selection/context-menu-text-selection.html: Added.
2010-11-23 Avi Drissman <avi@google.com>
Reviewed by Antonio Gomes.
Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351
Test: editing/selection/context-menu-text-selection.html
* editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 19:02:28 +0000 (19:02 +0000)]
2010-11-23 Alex Grilo <abgrilo@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Add tiled backing store to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=45777
Allow EWebLauncher to choose between single and tiled backing store
* EWebLauncher/main.c:
(on_key_down):
(browserCreate):
(main):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Tue, 23 Nov 2010 18:35:28 +0000 (18:35 +0000)]
2010-11-18 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
Add a mechanism for creating a WebURLLoader that is associated with a
particular WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=49764
This will be used by code that calls webKitClient()->createURLLoader()
from within the Chromium source tree.
An associated WebURLLoader should be treated like a subresource of the
WebFrame's document.
* WebKit.gyp:
* public/WebFrame.h:
* src/AssociatedURLLoader.cpp: Added.
(WebKit::AssociatedURLLoader::AssociatedURLLoader):
(WebKit::AssociatedURLLoader::~AssociatedURLLoader):
(WebKit::AssociatedURLLoader::loadSynchronously):
(WebKit::AssociatedURLLoader::loadAsynchronously):
(WebKit::AssociatedURLLoader::cancel):
(WebKit::AssociatedURLLoader::setDefersLoading):
(WebKit::AssociatedURLLoader::PrepareRequest):
* src/AssociatedURLLoader.h: Added.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createAssociatedURLLoader):
* src/WebFrameImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 23 Nov 2010 18:31:05 +0000 (18:31 +0000)]
2010-11-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [STYLES] invalid color values are not marked as such.
https://bugs.webkit.org/show_bug.cgi?id=49960
Properties having a valid structure but invalid values will also
be marked as non-parsedOk in the Styles pane.
WebCore:
* css/CSSGrammar.y:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateObjectWithStyleProperties):
LayoutTests:
* inspector/resources/styles-new-API.css:
(body):
* inspector/styles-new-API-expected.txt:
* inspector/styles-source-offsets-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 23 Nov 2010 17:29:20 +0000 (17:29 +0000)]
2010-11-23 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Martin Robinson.
[GTK] Building with Blob support fails
https://bugs.webkit.org/show_bug.cgi?id=49724
Build fix.
* GNUmakefile.am:
* platform/gtk/FileSystemGtk.cpp:
(WebCore::seekFile): Not implemented.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 23 Nov 2010 17:18:56 +0000 (17:18 +0000)]
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Updated chromium expectations.
Plugin tests were disabled.
MAC : compositing/plugins/1x1-composited-plugin.html = CRASH
MAC : compositing/plugins/composited-plugin.html = CRASH
MAC : compositing/plugins/large-to-small-composited-plugin.html = CRASH
MAC : compositing/plugins/small-to-large-composited-plugin.html = CRASH
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 23 Nov 2010 16:58:46 +0000 (16:58 +0000)]
2010-11-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Adapt to setShouldDelegateScrolling not being a real setting anymore.
We now similarily to setUseFixedLayout and setPaintEntireContents
set it on the FrameView wen transitioning to a new page.
* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::updateResizesToContentsForPage):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2010-11-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Make setShouldDelegateScrolling not a real setting, so that it works
similar to the related setUseFixedLayout and setPaintEntireContents
options which are all in ScrollView.
* page/FrameView.cpp:
* page/FrameView.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::setDelegatesScrolling):
* platform/ScrollView.h:
(WebCore::ScrollView::delegatesScrolling):
2010-11-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Adapt to setShouldDelegateScrolling not being a real setting anymore.
We now similarily to setUseFixedLayout and setPaintEntireContents
set it on the FrameView wen transitioning to a new page, etc.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 23 Nov 2010 16:54:18 +0000 (16:54 +0000)]
Don't rely on DocumentLoader outliving the load/unload events
DocumentLoader::m_documentLoadTiming is used to record how long firing
the load event took. But the DocumentLoader was being destroyed while
the event was being dispatched (due to a call to document.open), which
meant that when we tried to record the time when the load event
finished, we were writing into freed memory. We now protect the
DocumentLoader using a RefPtr. (I initially made a change where we
would only access the DocumentLoader after the event has finished
firing, but it seemed possible that a different DocumentLoader could
have come into existence by then, which would cause us to record the
times on the wrong DocumentLoadTiming struct.)
I only saw a crash when firing the load event, but the code for timing
the unload event seemed like it was vulnerable to the same issue, so I
made the same fix for it.
Fixes <http://webkit.org/b/49972> REGRESSION (r72415?): Crash in
DOMWindow::dispatchTimedEvent when running fast/dom/onload-open.html
Reviewed by Darin Fisher.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
Protect the DocumentLoader (and thus its DocumentLoadTiming) with a
RefPtr.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 23 Nov 2010 16:51:12 +0000 (16:51 +0000)]
2010-11-17 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
https://bugs.webkit.org/show_bug.cgi?id=49673
Test: fast/canvas/webgl/read-pixels-test.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):
2010-11-17 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
https://bugs.webkit.org/show_bug.cgi?id=49673
* fast/canvas/webgl/read-pixels-test-expected.txt: Added.
* fast/canvas/webgl/read-pixels-test.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 23 Nov 2010 16:19:30 +0000 (16:19 +0000)]
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Expectations for chromium were fixed.
* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 23 Nov 2010 15:47:47 +0000 (15:47 +0000)]
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Just fixing tipo in test_expectations.txt
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 23 Nov 2010 15:34:50 +0000 (15:34 +0000)]
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Updating test expectations for chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 23 Nov 2010 15:33:21 +0000 (15:33 +0000)]
2010-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix compilation with !ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=49942
Add ENABLE(INSPECTOR) to the Qt specific files following r71981.
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::inspectorDestroyed):
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::sendMessageToFrontend):
* WebCoreSupport/InspectorServerQt.cpp:
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 23 Nov 2010 15:01:35 +0000 (15:01 +0000)]
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Adjusting expectations for chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 23 Nov 2010 14:52:22 +0000 (14:52 +0000)]
[Qt] Restore binary compatibility with the QtWebKit 2.1 branch
Reviewed by Andreas Kling.
Re-order the enums by adding new enum entries to the end.
* Api/qwebsettings.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 23 Nov 2010 14:24:06 +0000 (14:24 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810
Reviewed by Tor Arne Vestbø.
Renamed requestPermissionFromUser to featurePermissionRequested
and cancelRequestsForPermission to featurePermissionRequestCanceled.
WebKit/qt:
* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
WebKitTools:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::featurePermissionRequestCanceled):
* QtTestBrowser/webpage.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 23 Nov 2010 14:23:46 +0000 (14:23 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810
Reviewed by Tor Arne Vestbø.
Rename setUserPermission to setFeaturePermission
WebKit/qt:
* Api/qwebpage.cpp:
(QWebPage::setFeaturePermission):
* Api/qwebpage.h:
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):
WebKitTools:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::requestPermission):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 23 Nov 2010 14:23:24 +0000 (14:23 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810
Reviewed by Tor Arne Vestbø.
Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
and GeolocationPermissionDomain to Geolocation.
WebKit/qt:
* Api/qwebpage.cpp:
(QWebPage::setUserPermission):
* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):
(tst_QWebPage::geolocationRequestJS):
WebKitTools:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::cancelPermission):
(WebCore::WebPage::permissionSet):
(WebCore::DumpRenderTree::geolocationPermissionSet):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::requestPermission):
(WebPage::cancelRequestsForPermission):
* QtTestBrowser/webpage.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 23 Nov 2010 14:22:59 +0000 (14:22 +0000)]
[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810
Reviewed by Tor Arne Vestbø.
Add a ByUser suffix to PermissionGranted/Denied. In the future
we can add PermissionGrantedByDefault.
WebKit/qt:
* Api/qwebpage.cpp:
(QWebPage::setUserPermission):
* Api/qwebpage.h:
* WebCoreSupport/GeolocationPermissionClientQt.cpp:
(WebCore::GeolocationPermissionClientQt::setPermission):
* tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::requestPermission):
WebKitTools:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
* QtTestBrowser/webpage.cpp:
(WebPage::requestPermission):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 23 Nov 2010 13:25:25 +0000 (13:25 +0000)]
2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed rollout r72534 and r72533 because r72544, r72530 and r72527 were reverted.
* platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
* platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/chromium-linux/fast/doctypes/002-expected.checksum:
* platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/001-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/001-vertical-expected.txt.
* platform/chromium-linux/fast/lists/002-expected.checksum:
* platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/002-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/002-vertical-expected.txt.
* platform/chromium-linux/fast/lists/003-expected.checksum:
* platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/003-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/003-vertical-expected.txt.
* platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/007-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/007-vertical-expected.txt.
* platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
* platform/chromium-linux/fast/lists/008-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/008-vertical-expected.txt.
* platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
* platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Removed.
* platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Added.
* platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Added.
* platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Added.
* platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
* platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Removed.
* platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
* platform/chromium-win/css1/box_properties/margin_right-expected.txt:
* platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
* platform/chromium-win/css1/box_properties/padding_right-expected.txt:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
* platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/chromium-win/fast/doctypes/002-expected.checksum:
* platform/chromium-win/fast/doctypes/002-expected.txt:
* platform/chromium-win/fast/lists/001-vertical-expected.checksum:
* platform/chromium-win/fast/lists/001-vertical-expected.txt:
* platform/chromium-win/fast/lists/002-expected.checksum:
* platform/chromium-win/fast/lists/002-expected.txt:
* platform/chromium-win/fast/lists/002-vertical-expected.checksum:
* platform/chromium-win/fast/lists/002-vertical-expected.txt:
* platform/chromium-win/fast/lists/003-expected.checksum:
* platform/chromium-win/fast/lists/003-expected.txt:
* platform/chromium-win/fast/lists/003-vertical-expected.checksum:
* platform/chromium-win/fast/lists/003-vertical-expected.txt:
* platform/chromium-win/fast/lists/007-vertical-expected.checksum:
* platform/chromium-win/fast/lists/007-vertical-expected.txt:
* platform/chromium-win/fast/lists/008-vertical-expected.checksum:
* platform/chromium-win/fast/lists/008-vertical-expected.txt:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
* platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
* platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Removed.
* platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 23 Nov 2010 13:19:22 +0000 (13:19 +0000)]
2010-11-23 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [STYLES] Use strike through as an 'overridden' marker.
https://bugs.webkit.org/show_bug.cgi?id=49961
"line-through" is used for inactive properties overridden within the same style.
* inspector/front-end/inspector.css:
(.styles-section .properties .overloaded, .styles-section .properties .inactive, .styles-section .properties .disabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit.git / log