14 years agoFixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog
mjs@apple.com [Wed, 26 Mar 2008 10:18:45 +0000 (10:18 +0000)]
Fixed reviewer in WebCore/ChangeLog and LayoutTests/ChangeLog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs@apple.com [Wed, 26 Mar 2008 10:10:08 +0000 (10:10 +0000)]

2008-03-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Maciej.

        - fixed "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"

        * platform/graphics/Font.cpp:
        (WebCore::Font::floatWidth): Allow expressing a run that has extra "context" characters beyond the end,
        and reporting of how many characters were actually consumed, to support multichar glyphs in SVG fonts.
        * platform/graphics/Font.h:
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphWidth): Pass along extra chars in argument and chars consumed out
        (WebCore::SVGInlineTextBox::calculateGlyphHeight): Pass along extra chars in argument.
        (WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Add boilerplate; may not handle multichar glyphs
        right but I don't know what effects this would have.
        * rendering/SVGInlineTextBox.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::cummulatedWidthOrHeightOfTextChunk): Add boilerplate; may not handle multichar glyphs right
        but again I am not sure what effect this would have.
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox): Account for multichar glyphs - let glyph
        selection consider extra chars, and account for the fact that a glyph may have consumed multiple chars.
        * rendering/SVGRootInlineBox.h:
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk): This is the place where glyph selection happens, so this is where
        we accout for multichar glyphs (both looking at extra chars past the end of the run, and reporting how
        many chars were consumed).
        (WebCore::floatWidthOfSubStringUsingSVGFont): Pass aforementioned info through the layers.
        (WebCore::Font::floatWidthUsingSVGFont): ditto
        (WebCore::Font::drawTextUsingSVGFont): ditto
        (WebCore::Font::selectionRectForTextUsingSVGFont): ditto
        * svg/SVGTextContentElement.cpp:
        (WebCore::cummulatedCharacterRangeLength): ditto
        (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): ditto


2008-03-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Maciej.

        - test case and new results for "SVGTextElement.getStartPositionOfChar does not correctly account for multichar glyphs"

        * svg/text/multichar-glyph.svg: Added. New test case for both rendering and getStartPositionOfChar
        access of multichar glyphs.
        * platform/mac/svg/text/multichar-glyph-expected.txt: Added.

        The following test results changed, all appear to be improvements.

        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
        * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/text/text-text-06-t-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin@apple.com [Wed, 26 Mar 2008 06:46:54 +0000 (06:46 +0000)]

2008-03-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Oliver.

        Fix for <rdar://problem/5811826> CSSValueList::item() does not
        range-check index

        Check bounds before accessing the item to avoid a crash.
        itemWithoutBoundsCheck() is still inlined and not bounds-checked to
        avoid slowing down our internal callers of item().
        * css/CSSValueList.cpp:
        * css/CSSValueList.h:

        Call itemWithoutBoundsCheck() to avoid slowing down these internal
        * css/CSSFontSelector.cpp:
        * css/CSSMutableStyleDeclaration.cpp:
        * css/CSSStyleSelector.cpp:
        * css/MediaQueryEvaluator.cpp:
        * svg/SVGFontFaceElement.cpp:
        * svg/graphics/SVGPaintServer.cpp:


2008-03-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Oliver.

        Test for <rdar://problem/5811826> CSSValueList::item() does not
        range-check index

        * fast/css/resources/bikes.bmp: Added.
        * fast/css/value-list-out-of-bounds-crash.html: Added.
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
        * platform/mac/fast/css/value-list-out-of-bounds-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben@apple.com [Wed, 26 Mar 2008 04:24:05 +0000 (04:24 +0000)]
    Windows build fix

        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        Add $(WebKitLibrariesDir)\include to the include path so we can find
        stdint.h there.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Antti Koivisto <antti@apple.com>
antti@apple.com [Wed, 26 Mar 2008 03:41:56 +0000 (03:41 +0000)]
2008-03-25  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Fix http://bugs.webkit.org/show_bug.cgi?id=18082
        REGRESSION (r31287): GMail does not work if user stylesheet is set

        Oops, my cache refactoring patch was missing these rather essential lines for
        user stylesheets. They would get reloaded repeatedly.

        * loader/Cache.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Attempted build fix
aroben@apple.com [Wed, 26 Mar 2008 02:14:55 +0000 (02:14 +0000)]
    Attempted build fix

        * WebKit.vcproj/WebKit.sln: Make testapi build after most other

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrect ChangeLog.
pewtermoose@webkit.org [Wed, 26 Mar 2008 01:35:53 +0000 (01:35 +0000)]
Correct ChangeLog.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Wed, 26 Mar 2008 01:32:44 +0000 (01:32 +0000)]
2008-03-25  Matt Lilek  <webkit@mattlilek.com>

        Rubber stamped by Adam

        Roll out r30300 since it causes assertion failures on page load.
        See http://bugs.webkit.org/show_bug.cgi?id=18093

        * page/InspectorController.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Wed, 26 Mar 2008 01:07:58 +0000 (01:07 +0000)]

2008-03-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17252
          Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2)

        Test: traversal/acid3-test-2.html

        * bindings/js/JSNodeIteratorCustom.cpp:
        (WebCore::JSNodeIterator::nextNode): Update since result is PassRefPtr.
        (WebCore::JSNodeIterator::previousNode): Ditto.
        * dom/NodeIterator.cpp:
        (WebCore::NodeIterator::nextNode): Changed result to PassRefPtr. Added code to
        track both the current candidate (which needs to move along to the next node
        if current node is deleted) and the current provisional result (passed to acceptNode,
        and needs to be returned even if it's deleted).
        (WebCore::NodeIterator::previousNode): Ditto.
        (WebCore::NodeIterator::nodeWillBeRemoved): Call updateForNodeRemoval for
        m_candidateNode as well as m_referenceNode.
        * dom/NodeIterator.h: Use PassRefPtr for return values.


2008-03-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17252
          Acid3 test removing Nodes during NodeIterator walk fails (affects Acid3 test 2)

        * traversal/acid3-test-2-expected.txt: Added.
        * traversal/acid3-test-2.html: Added.
        * traversal/resources/acid3-test-2.js: Added.
        * traversal/resources/exception-forwarding.js: Removed bogus extra line of code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 26 Mar 2008 00:29:30 +0000 (00:29 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Add the ability to transform a CString into a SharedBuffer to avoid copying data
        This is valuable to avoid copying a block of data for an upcoming patch

        * platform/SharedBuffer.cpp:
        * platform/SharedBuffer.h:

        * platform/text/CString.cpp:
        * platform/text/CString.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 23:46:27 +0000 (23:46 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Attempt to fix .bkl build systems after recent archive additions

        * webcore-base.bkl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 25 Mar 2008 23:43:29 +0000 (23:43 +0000)]
2008-03-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        - Cleaned up the needless use of RefPtrs, which we may someday no longer use for

        * page/InspectorController.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 25 Mar 2008 23:40:38 +0000 (23:40 +0000)]
2008-03-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        - Added a null check

        * xml/XMLHttpRequest.cpp: Null check

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 25 Mar 2008 23:32:01 +0000 (23:32 +0000)]
2008-03-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
        -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
        -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
        - XMLHttpRequestResources now identify themselves to the inspector which caches the data related to
        the request since no one else caches it.  However this is just the plumbing and the Inspector's UI
        has not been changed to show XHR resources yet.

        * page/InspectorController.cpp: Add ability to set XHR data on an InspectorResource.
        (WebCore::InspectorResource::): Add new type.
        (WebCore::InspectorResource::~InspectorResource): No longer virtual since we are not using inheritance.
        (WebCore::InspectorResource::type): Ditto.
        * page/InspectorController.h: Add accessor for setting the XHR data.
        * page/inspector/Resource.js: Keep the XHR resource types in sync with the Inspector Controller.
        * xml/XMLHttpRequest.cpp: Give the InspectorController the XHR information to cache.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Bug 18077: Integrate testapi.c into the Windows build
aroben@apple.com [Tue, 25 Mar 2008 23:23:45 +0000 (23:23 +0000)]
Fix Bug 18077: Integrate testapi.c into the Windows build


        Fix Bug 18077: Integrate testapi.c into the Windows build


        Reviewed by Steve Falkenburg.

        * JavaScriptCore.vcproj/testapi/testapi.vcproj: Added.


        Add an UnusedParam.h forwarding header for use by testapi

        Reviewed by Steve Falkenburg.

        * ForwardingHeaders/wtf/UnusedParam.h: Added.


        Fix Bug 18077: Integrate testapi.c into the Windows build


        Reviewed by Steve Falkenburg.

        * WebKit.vcproj/WebKit.sln: Added testapi.vcproj to the solution.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make testapi.c compile under MSVC
aroben@apple.com [Tue, 25 Mar 2008 23:23:31 +0000 (23:23 +0000)]
     Make testapi.c compile under MSVC

         Currently you must compile testapi.c as C++ code since MSVC does not
         support many C features that GCC does.

         Reviewed by Steve Falkenburg.

         * API/testapi.c:
         (nan): Added an implementation of this for MSVC.
         (assertEqualsAsUTF8String): Use malloc instead of dynamically-sized
         stack arrays.
         (assertEqualsAsCharactersPtr): Ditto.
         (print_callAsFunction): Ditto.
         (main): Ditto, and explicitly cast from UniChar* to JSChar*.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Stop using JavaScriptCore's custom stdbool.h and stdint.h on Windows
aroben@apple.com [Tue, 25 Mar 2008 23:23:17 +0000 (23:23 +0000)]
     Stop using JavaScriptCore's custom stdbool.h and stdint.h on Windows

         We can't remove the os-win32 directory yet because other ports (at
         least wx) are still relying on it.

         Reviewed by Steve Falkenburg.

         * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
           - Made all the include paths match the one for the Debug
             configuration (these got out of sync in r30797)
           - Removed os-win32 from the include path
           - Removed os-win32 from the directories we copy to $WebKitOutputDir.
           - Removed stdint.h from the project
         * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
         Delete the files that we may have previously copied from the os-win32

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 23:00:44 +0000 (23:00 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Beth Dakin

        Remove entirely unused internal method

        * WebView/WebArchiver.h:
        * WebView/WebArchiver.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson@apple.com [Tue, 25 Mar 2008 22:37:14 +0000 (22:37 +0000)]

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        <rdar://problem/5819308> - View Source is empty when view webarchives

        * WebCore.base.exp:
        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
          in the DocumentLoader


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        <rdar://problem/5819308> - View Source is empty when view webarchives

        * WebCore.base.exp:
        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
          in the DocumentLoader

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Tue, 25 Mar 2008 22:17:45 +0000 (22:17 +0000)]
    Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17933
          Reopen All Windows From Last Session causes crash

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 21:57:00 +0000 (21:57 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Jon Honeycutt's rubberstamp

        Fix a leak with the new WebArchive setup

        * WebView/WebArchive.mm:
        (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
eric@webkit.org [Tue, 25 Mar 2008 21:28:56 +0000 (21:28 +0000)]
    Reviewed by Oliver.

        Speculative crash fix for Acid3 crasher.
        I couldn't figure out how to make a test case for this?
        Suggestions welcome.

        * css/CSSFontSelector.cpp: null check document->renderer()

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix.
ap@webkit.org [Tue, 25 Mar 2008 20:29:30 +0000 (20:29 +0000)]
    Windows build fix.

        * kjs/dtoa.cpp: Include stdint.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Darin.
ap@webkit.org [Tue, 25 Mar 2008 19:43:15 +0000 (19:43 +0000)]
    Rubber-stamped by Darin.

        Cleanup dtoa.cpp style.

        * kjs/dtoa.cpp:
        * kjs/dtoa.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Antti Koivisto <antti@apple.com>
antti@apple.com [Tue, 25 Mar 2008 19:21:00 +0000 (19:21 +0000)]
2008-03-25  Antti Koivisto  <antti@apple.com>

        Reviewed by Geoff Garen.

        Some memory cache cleanups:
        - Separate CachedResource loading from construction, initiate load using a separate load() method.
        - Add special case function to Cache for loading user stylesheets. This allows removal
          of a bunch of parameters from several methods and CachedResource constructors.
        - Construct CachedResources with m_inCache set to false which is quite a bit more logical as they
          are not yet in the cache at that point.
        - Pass encoding around as const String& instead of const String*.

        * css/CSSImageValue.cpp:
        * html/HTMLImageLoader.cpp:
        * loader/Cache.cpp:
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedFont.cpp:
        * loader/CachedFont.h:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        * loader/CachedScript.cpp:
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 19:12:33 +0000 (19:12 +0000)]
2008-03-25  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - avoid converting UString to String and then later to AtomicString

        1% speedup on Acid3 test 26

        This is inefficient for the case where there's already an AtomicString.
        By first creating and destroying a String we waste time.

        * bindings/scripts/CodeGeneratorJS.pm: Use const UString& for string
        arguments rather than using String; this uses the object as it's produced
        from toString rather than creating a new temporary object that might not
        be of the right type. The type conversion happens at the callsite instead.
        Also eliminate the ability to use the type AtomicString from IDL.

        * dom/KeyboardEvent.idl: AtomicString -> DOMString.
        * dom/MouseEvent.idl: Ditto.
        * dom/MutationEvent.idl: Ditto.
        * dom/UIEvent.idl: Ditto.
        * svg/SVGStyleElement.idl: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 18:05:19 +0000 (18:05 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Build fix for non-CoreFoundation platforms

        * loader/archive/ArchiveFactory.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 18:00:51 +0000 (18:00 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Removed the concept of "pending archive resources" and the "archive resources delivery timer"
        from WebFrameLoaderClient, as those concepts have been pushed into WebCore

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson@apple.com [Tue, 25 Mar 2008 17:44:39 +0000 (17:44 +0000)]

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * loader/FrameLoaderClient.h:
        * svg/graphics/SVGImageEmptyClients.h:


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.h:


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.h:


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebFrame.cpp:
        * WebFrame.h:


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Remove newly obsolete FrameLoaderClient methods

        * WebKitSupport/FrameLoaderClientWx.cpp:
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 17:29:25 +0000 (17:29 +0000)]
2008-03-25  Brady Eidson  <beidson@apple.com>

        Release build fix

        * WebView/WebArchive.mm:
        (-[WebArchive subresources]):
        (-[WebArchive subframeArchives]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson@apple.com [Tue, 25 Mar 2008 17:11:16 +0000 (17:11 +0000)]

2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/4516169> - Support WebArchives on Windows
        And pave the way for many future WebArchive bug fixes and enhancements

        This patch accomplishes two main goals:
        1 - Consolidates much of the spread out WebKitMac archive code into one place in WebCore.  This allows for cleaner refactoring
            in the future as well as adding more archive formats with ease.
        2 - Hooks up WebArchive support on Windows.  Safari-style .webarchive files are nothing more than property lists readable by
            CoreFoundation.  While there are still some outstanding issues, including an NSKeyedArchiver chunk of data for the
            ResourceResponse for each resource, this patch manually parses through the property list on CoreFoundation platforms and
            gets many archives loading on Windows

        My goal for this first cut was zero behavior change.  As such, I went for a direct port of the WebKitMac code.  There will be
        opportunities for redesign and refactoring as followups.

        * WebCore.base.exp:

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ported from WebKitMac, WebDataSource
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp: Moved WebFrameLoaderClient and WebFrame code down into their more appropriate FrameLoader home
        * loader/FrameLoader.h:

        * loader/ResourceLoader.cpp:

        * loader/archive/Archive.h: Generic "Archive of web resources" class that is only useful when subclassed.
            Contains a MainResource, subresources, and Archives for subframes

        * loader/archive/ArchiveFactory.cpp: A class that will take raw archive data and the MIMEtype, and create the
            appropriate Archive class for it.  Additionally it handles registering the known MIMEtypes for all known archive formats
        * loader/archive/ArchiveFactory.h:

        * loader/archive/ArchiveResource.cpp: Analog to "WebResource" in WebKitMac.  Contains the data and other important
            attributes of an archived resource
        * loader/archive/ArchiveResource.h:

        * loader/archive/ArchiveResourceCollection.cpp: Analog of "WebUnarchivingState" in WebKitMac.  Contains a hash of
            all the resources for every frame in an archive, and contains the archives for each subframe needed to load a multi-frame archive
        * loader/archive/ArchiveResourceCollection.h:

        * loader/archive/cf/LegacyWebArchive.cpp: Subclass of Archive specifically for Webkit's Objective-C based ".webarchive" format.
            Mostly a collection of static methods involved in parsing and serializing a WebKit-style .webarchive.  Is mostly supported
            for any CF platform.
        * loader/archive/cf/LegacyWebArchive.h:
        * loader/archive/cf/LegacyWebArchiveMac.mm:

        * platform/network/mac/ResourceRequest.h:
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::applyWebArchiveHackForMail): Tweak the resource request for Mac clients when loading WebArchives


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/4516169> - Support WebArchives on Windows

        * WebKit.xcodeproj/project.pbxproj:


2008-03-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/4516169> - Support WebArchives on Windows
        And paves the way for many future WebArchive bug fixes and enhancements

        This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains
        1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
         * WebArchive <-> LegacyWebArchive
         * WebResource <-> ArchiveResource
         * WebUnarchivingState <-> ArchiveResourceCollection

        The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
        and now exist in WebCore

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch

        * WebView/WebArchive.mm:
        (+[WebArchivePrivate initialize]):
        (-[WebArchivePrivate init]):
        (-[WebArchivePrivate initWithCoreArchive:]):
        (-[WebArchivePrivate coreArchive]):
        (-[WebArchivePrivate setCoreArchive:]):
        (-[WebArchivePrivate dealloc]):
        (-[WebArchivePrivate finalize]):
        (-[WebArchive init]):
        (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
        (-[WebArchive initWithData:]):
        (-[WebArchive initWithCoder:]):
        (-[WebArchive encodeWithCoder:]):
        (-[WebArchive mainResource]):
        (-[WebArchive subresources]):
        (-[WebArchive subframeArchives]):
        (-[WebArchive data]):
        (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
        (-[WebArchive WebCore::]):
        * WebView/WebArchiveInternal.h: Added.

        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _addSubframeArchives:]):
        (-[WebDataSource _documentFragmentWithArchive:]):
        (-[WebDataSource subresourceForURL:]):
        (-[WebDataSource addSubresource:]):
        * WebView/WebDataSourceInternal.h:

        * WebView/WebFrame.mm:
        (-[WebFrame loadArchive:]):
        * WebView/WebFrameInternal.h:

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

        * WebView/WebResource.mm:
        (+[WebResourcePrivate initialize]):
        (-[WebResourcePrivate init]):
        (-[WebResourcePrivate initWithCoreResource:]):
        (-[WebResourcePrivate dealloc]):
        (-[WebResourcePrivate finalize]):
        (-[WebResource initWithCoder:]):
        (-[WebResource encodeWithCoder:]):
        (-[WebResource data]):
        (-[WebResource URL]):
        (-[WebResource MIMEType]):
        (-[WebResource textEncodingName]):
        (-[WebResource frameName]):
        (-[WebResource _initWithCoreResource:WebCore::]):
        (-[WebResource WebCore::]):
        (-[WebResource _ignoreWhenUnarchiving]):
        (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
        (-[WebResource _fileWrapperRepresentation]):
        (-[WebResource _response]):
        (-[WebResource _stringValue]):
        * WebView/WebResourceInternal.h: Added.
        * WebView/WebResourcePrivate.h:

        * WebView/WebUnarchivingState.h: Removed.
        * WebView/WebUnarchivingState.m: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 16:09:45 +0000 (16:09 +0000)]
2008-03-25  Darin Adler  <darin@apple.com>

        Suggested by Adam.

        * Interfaces/WebKit.idl: Touch this file to make the Interface project rebuild.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-25 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 25 Mar 2008 07:33:34 +0000 (07:33 +0000)]
2008-03-25  David Hyatt  <hyatt@apple.com>

        Cut and paste error in the zoom code.  A width() should have been a height().  Regression tests caught this.

        * page/DOMWindow.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark.
eric@webkit.org [Tue, 25 Mar 2008 06:56:56 +0000 (06:56 +0000)]
    Reviewed by Mark.

        Clean up SVG features message to be less confusing.

        * Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 05:02:24 +0000 (05:02 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        - try to fix broken Wx build

        * platform/wx/TemporaryLinkStubs.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 18030: REGRESSION(r31236): Space bar fails to scroll down page
oliver@apple.com [Tue, 25 Mar 2008 04:35:30 +0000 (04:35 +0000)]
Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page

Reviewed by Mark Rowe

Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
tracked by Bug 18057: keyDown incorrectly propagates up the frame tree

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 04:30:00 +0000 (04:30 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - use AtomicString more consistently for attribute values

        1% speedup on Acid3 test 26

        * dom/Element.cpp:
        (WebCore::Element::setAttribute): Changed value argument to AtomicString.
        Also fixed call to lower() to only be done if the name isn't already lowercase.
        Also took out one unneeded condition in a cascade of if statements.
        (WebCore::Element::createAttribute): Ditto.
        (WebCore::Element::setAttributeNS): Ditto.
        * dom/Element.h: Ditto.
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::createAttribute): Ditto.
        * dom/StyledElement.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 04:28:37 +0000 (04:28 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - get rid of extra level of function call in toJS functions for Node

        0.6% speedup on Acid3 test 26

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::toJS): Take a raw pointer, not a PassRefPtr, like other toJS functions.

        * bindings/scripts/CodeGeneratorJS.pm: Add an inlined toJS for EventTargetNode*
        to avoid ambiguity that otherwise exists between the toJS for EventTarget* and
        for Node*.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 25 Mar 2008 03:43:57 +0000 (03:43 +0000)]
2008-03-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt.

        Add EventSender.zoomPageIn/zoomPageOut support to DRT.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/EventSendingController.mm:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (-[EventSendingController zoomPageIn]):
        (-[EventSendingController zoomPageOut]):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/EventSender.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 03:39:56 +0000 (03:39 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - convert a JavaScript immediate number to a string more efficiently

        2% speedup of Acid3 test 26

        * kjs/JSImmediate.cpp:
        (KJS::JSImmediate::toString): Take advantage of the fact that all immediate
        numbers are integers, and use the faster UString function for formatting integers
        instead of the slower one that works for floating point. I think this is a leftover
        from when immediate numbers were floating point.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 25 Mar 2008 03:26:02 +0000 (03:26 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Hyatt.

        - add fast path to isValidName that does not use advanced Unicode functions

        2% speedup on Acid3 test 26

        * dom/Document.cpp:
        (WebCore::isValidNameNonASCII): Added. Contains the old isValidName function.
        (WebCore::isValidNameASCII): Added. Contains a simpler function that returns
        true for most valid names that are also all ASCII.
        (WebCore::Document::isValidName): Changed to call both of the above functions.
        The common case is that isValidNameASCII returns true so isValidNameNonASCII
        is never called.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 25 Mar 2008 02:39:31 +0000 (02:39 +0000)]
2008-03-24  David Hyatt  <hyatt@apple.com>

        Fix for bug 18052, window properties need to respect zoom factor.

        Reviewed by Beth

        * page/DOMWindow.cpp:
        * page/FrameView.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig@apple.com [Tue, 25 Mar 2008 02:26:24 +0000 (02:26 +0000)]

2008-03-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=18048
        The "thisObject" parameter to JSEvaluateScript is not used properly

        Making passing a thisObject to JSEvaluateScript actually set the thisObject of the created

        * API/testapi.c:
        (main): Add tests for setting the thisObject when calling JSEvaluateScript.

        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState): Assign the thisObject to m_thisValue and remove the comment.


2008-03-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Fix http://bugs.webkit.org/show_bug.cgi?id=18048
        The "thisObject" parameter to JSEvaluateScript is not used properly

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::evaluate): No need to pass a thisObject since we want the global object to be used.
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::eval): To avoid any change to this function, don't pass a thisObject to keep the same

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 25 Mar 2008 01:19:00 +0000 (01:19 +0000)]
2008-03-24  Brady Eidson  <beidson@apple.com>

        Made new layout test files executable, as needed for the tests to not fail!

        * http/tests/navigation/resources/reload-subframe-content.pl: Added.
        * http/tests/navigation/resources/reload-subframe.pl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit/mac:
beidson@apple.com [Tue, 25 Mar 2008 00:37:58 +0000 (00:37 +0000)]

2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej, landed by Brady

        Bug 3580: iFrames Appear to be Cached

        Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs

        Bug 15554: Reload causes <object> to use old data

        If a page is reloaded, a child frame's URL can not be taken from a history item.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):


2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej, landed by Brady

        Tests for the following bugs:

        Bug 3580: iFrames Appear to be Cached

        Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs

        Bug 15554: Reload causes <object> to use old data

        * http/tests/navigation/reload-subframe-frame-expected.txt: Added.
        * http/tests/navigation/reload-subframe-frame.html: Added.
        * http/tests/navigation/reload-subframe-iframe-expected.txt: Added.
        * http/tests/navigation/reload-subframe-iframe.html: Added.
        * http/tests/navigation/reload-subframe-object-expected.txt: Added.
        * http/tests/navigation/reload-subframe-object.html: Added.
        * http/tests/navigation/resources/reload-subframe-content.pl: Added.
        * http/tests/navigation/resources/reload-subframe.pl: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 24 Mar 2008 23:19:42 +0000 (23:19 +0000)]
2008-03-24  Darin Adler  <darin@apple.com>

        Reviewed by Beth.

        - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
        * WebView/WebDataSource.mm:
        (-[WebDataSource _URL]): Ditto.
        (-[WebDataSource unreachableURL]): Ditto.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.

        * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
        * History/WebHistory.mm:
        * Misc/WebElementDictionary.mm:
        * Misc/WebNSAttributedStringExtras.mm:
        Remove unneeded imports of KURL.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson@apple.com [Mon, 24 Mar 2008 22:59:20 +0000 (22:59 +0000)]

2008-03-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin's rubberstamp

        Land a load of empty files for upcoming work to make sure I'm not breaking any platform's build

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * loader/archive: Added.
        * loader/archive/Archive.h: Added.
        * loader/archive/ArchiveFactory.cpp: Added.
        * loader/archive/ArchiveFactory.h: Added.
        * loader/archive/ArchiveResource.cpp: Added.
        * loader/archive/ArchiveResource.h: Added.
        * loader/archive/ArchiveResourceCollection.cpp: Added.
        * loader/archive/ArchiveResourceCollection.h: Added.
        * loader/archive/cf: Added.
        * loader/archive/cf/LegacyWebArchive.cpp: Added.
        * loader/archive/cf/LegacyWebArchive.h: Added.
        * loader/archive/cf/LegacyWebArchiveMac.mm: Added.


2008-03-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin's rubberstamp

        Rename a .m to .mm

        * WebKit.xcodeproj/project.pbxproj:


2008-03-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin's rubberstamp

        Rename this file for upcoming work.

        * WebView/WebArchive.m: Removed.
        * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 24 Mar 2008 22:51:26 +0000 (22:51 +0000)]
2008-03-24  David Hyatt  <hyatt@apple.com>

        Fix for bug 18009. Make sure the IE offset/client/scroll*** extensions respect full page zoom.

        Reviewed by Beth

        * dom/Element.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
mitz@apple.com [Mon, 24 Mar 2008 21:53:32 +0000 (21:53 +0000)]
    Reviewed by Mark Rowe.

        - update bisect-builds for Safari 3.1

        * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
        revision, r29711.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 24 Mar 2008 20:43:13 +0000 (20:43 +0000)]
2008-03-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Some style cleanup and add a logging channel for upcoming work

        * platform/Logging.cpp:
        * platform/Logging.h:

        * platform/MIMETypeRegistry.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 24 Mar 2008 20:31:02 +0000 (20:31 +0000)]

        Reviewed by Sam Weinig.

        - fix <rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47

        Test: fast/repaint/renderer-destruction-by-invalidateSelection-crash.html

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::reset): Removed repaintRects code.
        (WebCore::FrameView::layout): Ditto.
        (WebCore::FrameView::addRepaintInfo): Removed.

        * page/FrameView.h: Removed addRepaintInfo().

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock): Changed to call repaintRectangle
        instead of FrameView::addRepaintInfo().
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): Ditto.


        Reviewed by Sam Weinig.

        - test for <rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47

        * fast/repaint/renderer-destruction-by-invalidateSelection-crash.html: Added.
        * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
        * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
        * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 24 Mar 2008 19:26:01 +0000 (19:26 +0000)]
2008-03-24  Alp Toker  <alp@atoker.com>

        GTK+/soup http backend build fix for breakage introduced in r31141.
        Fix suggested by Xan.

        * platform/network/ResourceHandle.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig.
mitz@apple.com [Mon, 24 Mar 2008 17:55:58 +0000 (17:55 +0000)]
    Reviewed by Sam Weinig.

        - fix <rdar://problem/5792582> CSS opacity does not work with GDI text
        - fix <rdar://problem/5792619> non-opaque CSS colors do not work with GDI text (RGBA, HSLA)
        - fix <rdar://problem/5792624> GDI text can't be stroked/filled independently
        - make text-shadow work with GDI text
        - make -webkit-background-clip: text work with GDI text

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setShadow): Made this a shared method that
        updates the state and calls the platform-specific method.
        (WebCore::GraphicsContext::clearShadow): Ditto.
        (WebCore::GraphicsContext::getShadow): Added.

        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContext::WindowsBitmap): Added this class that
        represents a bitmap with a Windows device context that GDI can draw into.

        * platform/graphics/GraphicsContextPrivate.h:
        (WebCore::GraphicsContextState::GraphicsContextState): Added the shadow
        parameters to the graphics state.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform-
        specific implementation to this.
        (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform-
        specific implementation to this.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform-
        specific implementation to this.
        (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform-
        specific implementation to this.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform-
        specific implementation to this.
        (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform-
        specific implementation to this.

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::toCGFloat): Added. Converts a Windows FIXED.
        (WebCore::createPathForGlyph): Added. Retrieves a glyph's hinted
        outline from GDI and creates a CGPath containing it.
        (WebCore::Font::drawGlyphs): Added two code paths in the GDI case.
        The existing code path, which uses GDI to draw text directly to the
        graphics context, is used for opaque-colored, non-transformed,
        non-stroked, non-shadowed text in a GDI-backed graphics context that is
        not in a transparency layer.
        An additional code path is used for non-stroked text in all other cases.
        It uses GDI to draw black text into an all-white Windows bitmap, then
        uses the green channel as a mask to create a bitmap with the desired
        fill color and alpha. The bitmap is then drawn into the graphics
        context, at which time transparency layers, transforms and shadows are
        handled properly.
        A third code path is used for stroked text. It constructs a path from
        hinted glyph outlines retrieved from GDI and strokes (and optionally
        fills) it.

        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::GraphicsContext::getWindowsContext): Added a mayCreateBitmap
        parameter. When false, prevents this method from creating a Windows
        device context if the graphics context does not already have one.
        (WebCore::GraphicsContext::releaseWindowsContext): Added a
        mayCreateBitmap parameter to match getWindowsContext().
        (WebCore::GraphicsContext::createWindowsBitmap): Added.
        (WebCore::GraphicsContext::drawWindowsBitmap): Added. Draws the bitmap
        as a non-alpha-premultiplied image.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 24 Mar 2008 17:45:43 +0000 (17:45 +0000)]
2008-03-24  Kevin McCullough <kmccullough@apple.com>

          - Fixed Changelog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-24 Marco Barisione <marco.barisione@collabora.co.uk>
alp@webkit.org [Mon, 24 Mar 2008 17:16:57 +0000 (17:16 +0000)]
2008-03-24  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        [GTK] combo box menu displayed in the wrong position

        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::show): Change the popup menu vertical position so
        that the active item is over the combo box.
        (WebCore::PopupMenu::menuPositionFunction): use the "push in" style
        like native GTK+ combo boxes to handle menus that don't fit in the

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebCore.vcproj/WebCore.vcproj: Add files from WebCore/page/inspector to...
aroben@apple.com [Mon, 24 Mar 2008 12:00:02 +0000 (12:00 +0000)]
    * WebCore.vcproj/WebCore.vcproj: Add files from WebCore/page/inspector to the project.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
ap@webkit.org [Mon, 24 Mar 2008 08:15:31 +0000 (08:15 +0000)]
    Build fix.

        * WebCore/WebCore.xcodeproj/project.pbxproj: Added DOMSVGAltGlyphElement.h and
        DOMSVGAltGlyphElementInternal.h to Copy Generated Headers phase.
        * WebKit/MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix, no review.
eric@webkit.org [Mon, 24 Mar 2008 07:24:43 +0000 (07:24 +0000)]
    Build fix, no review.

        Fix project paths to be group relative instead of project relative

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs@apple.com [Mon, 24 Mar 2008 05:36:30 +0000 (05:36 +0000)]

2008-03-23  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric.

        - fixed "SVGTextElement.getNumberOfChars is broken for altGlyph (affects Acid3 test 79)"

        * svg/SVGAltGlyphElement.cpp: Added. Implementation for new element.
        (WebCore::SVGAltGlyphElement::createRenderer): For now, this just renders as a tspan,
        which is right for everything besides the alternate glyph substitution itself.
        * svg/SVGAltGlyphElement.h: Added. Header for new element.
        * svg/SVGAltGlyphElement.idl: Added. Interface for new element.
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::childShouldCreateRenderer): Allow altGlyph to render here.
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::childShouldCreateRenderer): ditto
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::childShouldCreateRenderer): ditto
        * svg/svgtags.in: Add altGlyph
        * DerivedSources.make: Add new files
        * GNUmakefile.am: ditto
        * WebCore.SVG.exp: Add new ObjC DOM class
        * WebCore.pro: Add new files
        * WebCore.vcproj/WebCore.vcproj: ditto
        * WebCore.xcodeproj/project.pbxproj: ditto
        * bindings/js/JSSVGElementWrapperFactory.cpp: Handle altGlyph
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap): ditto
        * bindings/objc/DOMInternal.h: Include altGlyph header
        * bindings/objc/DOMSVG.h: Include altGlyph header


2008-03-23  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric.

        - updated test results for "SVGTextElement.getNumberOfChars is broken for altGlyph (affects Acid3 test 79)"

        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
        * svg/dom/altGlyph-dom-expected.txt: Added.
        * svg/dom/altGlyph-dom.xhtml: Added.
        * svg/dom/resources/altGlyph-dom.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-23 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 24 Mar 2008 01:21:33 +0000 (01:21 +0000)]
2008-03-23  Antti Koivisto  <antti@apple.com>

        * blog-files/wsj-vs.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eseidel. Landed by eseidel.
eric@webkit.org [Sun, 23 Mar 2008 21:08:40 +0000 (21:08 +0000)]
    Reviewed by eseidel.  Landed by eseidel.

        Bug 17685: [~=] attribute selector failing to match empty string

        Test: fast/css/attribute-selector-empty-value.html

        * css/CSSStyleSelector.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
eric@webkit.org [Sun, 23 Mar 2008 21:03:11 +0000 (21:03 +0000)]
    Reviewed by Sam.

        Make our SVG status document slightly less inaccurate.

        * projects/svg/status.xml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 17670: Key events may improperly propagate from iframe to parent frame
oliver@apple.com [Sun, 23 Mar 2008 10:48:18 +0000 (10:48 +0000)]
Bug 17670: Key events may improperly propagate from iframe to parent frame
Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus

Reviewed by Maciej

Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
as that results in us dispatching the key events for each frame going up the frame

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-22 Marco Barisione <marco.barisione@collabora.co.uk>
mrowe@apple.com [Sat, 22 Mar 2008 22:21:05 +0000 (22:21 +0000)]
2008-03-22  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Darin Adler.

        Frame scrollbar positions are not updated on page scroll

        Widget::geometryChanged() was called instead of
        ScrollViewScrollbar::geometryChanged() because of a missing const.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollViewScrollbar::geometryChanged): add the missing

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-22 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Sat, 22 Mar 2008 22:01:55 +0000 (22:01 +0000)]
2008-03-22  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Mark Rowe.

        Bug 17974: REGRESSION: npfunctions.h should not import npruntime_internal.h

        Include npapi.h and npruntime.h directly in npfunctions.h.
        Add npfunctions.h and npapi.h to npruntime_internal.h.
        Replace includes of npfunctions.h with npruntime_internal.h.

        * bridge/npruntime_internal.h:
        * plugins/PluginPackage.h:
        * plugins/PluginStream.h:
        * plugins/npapi.cpp:
        * plugins/npfunctions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt build.
mrowe@apple.com [Sat, 22 Mar 2008 21:04:07 +0000 (21:04 +0000)]
Fix the Qt build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update a (passing) result I missed in my last checkin. No review.
eric@webkit.org [Sat, 22 Mar 2008 10:31:11 +0000 (10:31 +0000)]
    Update a (passing) result I missed in my last checkin.  No review.

        * dom/xhtml/level3/core/documentgetdoctype01-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by mjs.
eric@webkit.org [Sat, 22 Mar 2008 09:50:54 +0000 (09:50 +0000)]
    Reviewed by mjs.

        Unify handling of NAMESPACE_ERR and fix Acid3 test 25

        Test: fast/dom/DOMImplementation/createDocumentType-err.html

        * dom/DOMImplementation.cpp:
        * dom/DOMImplementation.idl:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/Element.cpp:
        * editing/FormatBlockCommand.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by mjs.
eric@webkit.org [Sat, 22 Mar 2008 09:49:58 +0000 (09:49 +0000)]
    Reviewed by mjs.

        Fix createElementNS to throw exceptions for invalid qualified names
        Fixes Acid3 sub-test 23

        Tests: fast/dom/Document/createAttributeNS-namespace-err.html

        * dom/Document.cpp:
        * dom/Document.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig. Landed by eseidel.
eric@webkit.org [Sat, 22 Mar 2008 09:14:58 +0000 (09:14 +0000)]
    Reviewed by Sam Weinig.  Landed by eseidel.

        Make testkjs flush stdout after printing.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/testkjs.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>
oliver@apple.com [Sat, 22 Mar 2008 07:14:40 +0000 (07:14 +0000)]
2008-03-21  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

Bug 13693: REGRESSION (r13615): Acid2 Test Eyes render improperly after a page refresh

Reviewed by Oliver Hunt

Do not create bogus history items for unloaded <object> elements, because they
cause fallback content to be ignored on reload.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Sat, 22 Mar 2008 06:57:28 +0000 (06:57 +0000)]

        Reviewed by Oliver Hunt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17988
          REGRESSION (r31114-31132): Crash in InlineBox::isDirty() opening chowhound.com

        Test: fast/css-generated-content/empty-content-with-float-crash.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Added a null check for
        the case where the block contains no in-flow elements but still lays
        out as a line flow, which can happen as a result of empty generated


        Reviewed by Oliver Hunt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17988
          REGRESSION (r31114-31132): Crash in InlineBox::isDirty() opening chowhound.com

        * fast/css-generated-content/empty-content-with-float-crash-expected.txt: Added.
        * fast/css-generated-content/empty-content-with-float-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoOptimise lookup of Math, undefined, NaN and Infinity
oliver@apple.com [Sat, 22 Mar 2008 04:59:20 +0000 (04:59 +0000)]
Optimise lookup of Math, undefined, NaN and Infinity

Reviewed by Maciej

Added a method to JSVariableObject to allow us to inject DontDelete properties
into the symbol table and localStorage.  This results in a 0.4% progression in
SunSpider, with a 8% gain in math-partial-sums.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGlobal properties that use LocalStorage are not correctly listed as enumerable.
oliver@apple.com [Sat, 22 Mar 2008 02:36:34 +0000 (02:36 +0000)]
Global properties that use LocalStorage are not correctly listed as enumerable.

Reviewed by Geoff Garen

The problem was caused by JSObject::getPropertyAttributes not being aware
of the JSVariableObject SymbolTable.  The fix is to make getPropertyAttributes
virtual and override in JSVariableObject.  This does not produce any performance

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Sat, 22 Mar 2008 00:39:07 +0000 (00:39 +0000)]

2008-03-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix <rdar://problem/5788451>
        toDataURL not implemented for Windows (need mapping of MIME type to UTI)

        Hard code support for just PNG's on windows, the minimum the spec requires.

        * platform/MIMETypeRegistry.cpp:
        * platform/graphics/cg/ImageBufferCG.cpp:


2008-03-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Enable tests for <rdar://problem/5788451>
        toDataURL not implemented for Windows (need mapping of MIME type to UTI)

        * platform/win/Skipped:
        * platform/win/fast/canvas: Added.
        * platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-21 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Fri, 21 Mar 2008 23:58:09 +0000 (23:58 +0000)]
2008-03-21  Matt Lilek  <webkit@mattlilek.com>

        Not reviewed, Mac build fix.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
        * bridge/jni/jni_utility.cpp:
        * bridge/objc/objc_runtime.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-21 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 21 Mar 2008 23:31:33 +0000 (23:31 +0000)]
2008-03-21  Antti Koivisto  <antti@apple.com>

        Add some images for a blog post.

        * blog-files/wsj-nopreload.png: Added.
        * blog-files/wsj-preload.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Attempt to fix the Mac build
aroben@apple.com [Fri, 21 Mar 2008 23:30:19 +0000 (23:30 +0000)]
    Attempt to fix the Mac build

        * bindings/objc/DOMUtility.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename static info members to s_info
aroben@apple.com [Fri, 21 Mar 2008 22:09:29 +0000 (22:09 +0000)]
    Rename static info members to s_info

        This avoids conflicts with custom "info" methods, such as the one that
        will soon be added to Console.

        Reviewed by Ada Chan and Sam Weinig.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-21 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 21 Mar 2008 22:00:56 +0000 (22:00 +0000)]
2008-03-21  David Hyatt  <hyatt@apple.com>

        <rdar://problem/5808863> Zooming should not let non-zero border width become zero

        Make sure zoomed values that begin >= 1 are not allowed to fall below 1.

        Reviewed by adele

        * css/CSSPrimitiveValue.cpp:
        * loader/CachedImage.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-21 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 21 Mar 2008 21:05:50 +0000 (21:05 +0000)]
2008-03-21  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam.

        -<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
        -<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
        -<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)
        - Instrument the InspectorController to cache XHR resrouces since they are not cached by WebCore.
        The resources will be kept in the same map as all other resources so they will have the exact
        same lifecycle.

        * ChangeLog:
        * page/InspectorController.cpp:
        * xml/XMLHttpRequest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd missing ChangeLog entry for r31214.
zecke@webkit.org [Fri, 21 Mar 2008 20:40:41 +0000 (20:40 +0000)]
Add missing ChangeLog entry for r31214.

2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Holger.

        Remove the JSCore include path options from global_cppflags.
        Place JSCore include path options in javascriptcore_cppflags.
        Add javascriptcore_cppflags to libWebCore_la_CPPFLAGS.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-21 Arkadiusz Miskiewicz <arekm@maven.pl>
ddkilzer@apple.com [Fri, 21 Mar 2008 19:26:06 +0000 (19:26 +0000)]
2008-03-21  Arkadiusz Miskiewicz  <arekm@maven.pl>

        Webkit does not build on linux powerpc


        Reviewed by David Kilzer.

        * wtf/TCSpinLock.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
ap@webkit.org [Fri, 21 Mar 2008 18:48:09 +0000 (18:48 +0000)]
    Reviewed by Geoff.

        * sunspider: Pause update daemon on Darwin to make results reliable
        again (workaround for <rdar://problem/5811127>).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore/ChangeLog:
zecke@webkit.org [Fri, 21 Mar 2008 18:21:25 +0000 (18:21 +0000)]
2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Holger.


        Add javascriptcore_cppflags to Programs_minidom_CPPFLAGS.

        * GNUmakefile.am:

2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Holger.


        Remove WebCore/ForwardingHeaders from cppflags as it is not needed,
        and causes build problems with GTK+.

        * GNUmakefile.am:

2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Holger.


        Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 21 Mar 2008 17:17:01 +0000 (17:17 +0000)]

        Reviewed by Adele Peterson.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17966
          REGRESSION (r31114-r31132): Clearing via br behaves unpredictably

        Test: fast/block/float/br-with-clear.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Fixed the logic for the
        very special case of an all-lines-clean block that ends with a float-
        clearing <br> by looking for the <br> at the end of the line rather
        than at its beginning.


        Reviewed by Adele Peterson.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17966
          REGRESSION (r31114-r31132): Clearing via br behaves unpredictably

        * fast/block/float/br-with-clear.html: Added.
        * platform/mac/fast/block/float/br-with-clear-expected.checksum: Added.
        * platform/mac/fast/block/float/br-with-clear-expected.png: Added.
        * platform/mac/fast/block/float/br-with-clear-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5810324> visitCount not updated in History.plist
adachan@apple.com [Fri, 21 Mar 2008 16:36:22 +0000 (16:36 +0000)]
    <rdar://problem/5810324> visitCount not updated in History.plist
        Call WebCore::HistoryItem::mergeAutoCompleteHints() in WebHistoryItem::mergeAutoCompleteHints().

        Reviewed by Steve.

        * WebHistoryItem.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove a non-working mirror from cygwin-downloader and add the ruby package
aroben@apple.com [Fri, 21 Mar 2008 16:29:09 +0000 (16:29 +0000)]
    Remove a non-working mirror from cygwin-downloader and add the ruby package

        * CygwinDownloader/cygwin-downloader.py:
        * CygwinDownloader/cygwin-downloader.zip: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Don't allow any newly-scheduled plugin requests to be serviced when JS is...
aroben@apple.com [Fri, 21 Mar 2008 16:27:55 +0000 (16:27 +0000)]
    Don't allow any newly-scheduled plugin requests to be serviced when JS is paused

        This is a followup to r31199.

        Reviewed by Tim Hatcher.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::requestTimerFired): Added an assertion that JS
        is not paused.
        (WebCore::PluginView::scheduleRequest): Don't start the request timer
        if JS is paused. This is the bug fix.
        (WebCore::PluginView::setJavaScriptPaused): Replaced the use of
        m_requestTimerWasActive with a check to see if we have any pending
        requests. m_requestTimerWasActive would not be accurate if a new
        request had been scheduled while JS was paused.
        (WebCore::PluginView::PluginView): Removed initialization of
        * plugins/PluginView.h: Removed m_requestTimerWasActive.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBug 17980: Regression: Inspector highlighting of webpage not cleared when going to...
timothy@apple.com [Fri, 21 Mar 2008 16:00:41 +0000 (16:00 +0000)]
Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL

Reviewed by Adam.

The new highlight drawing was not honoring the fade value, so it was
always drawing at full opacity. The animation code didn't match Windows
and the new highlight anyway, so it has been removed. The highlight
how just detaches when it is hidden.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
(-[WebInspectorWindowController close]): Ditto.
(-[WebInspectorWindowController highlightNode:]): Call attach.
(-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
* WebInspector/WebNodeHighlight.h:
* WebInspector/WebNodeHighlight.m:
(-[WebNodeHighlight initWithTargetView:inspectorController:]):
(-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
(-[WebNodeHighlight attach]): Renamed from attachHighlight.
(-[WebNodeHighlight detach]): Renamed from detachHighlight.
(-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
* WebInspector/WebNodeHighlightView.h:
* WebInspector/WebNodeHighlightView.m:
(-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
ap@webkit.org [Fri, 21 Mar 2008 11:14:49 +0000 (11:14 +0000)]
    Reviewed by Oliver Hunt.

        Consolidate static identifier initializers within CommonIdentifiers.

        No reliably measurable change on SunSpider; maybe a tiny improvement (within 0.2%).

        * kjs/CommonIdentifiers.h: Added static identifiers that were lazily initialized
        throughout the code.

        * kjs/date_object.cpp:
        * kjs/function_object.cpp:
        * kjs/object_object.cpp:
        * kjs/regexp_object.cpp:
        Use the values from CommonIdentifiers.

        * kjs/lookup.h: Caching the identifier in a static wasn't a win on SunSpider, removed it.

        * kjs/value.h:
        (KJS::jsNaN): We already have a shared NaN value, no need for a duplicate here.

        * wtf/MathExtras.h:
        (wtf_atan2): Having local variables for numeric_limits constants is good for readability,
        but there is no reason to keep them static.

        * JavaScriptCore.exp: Don't needlessly export JSGlobalObject::s_head.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - update results for the 'zoom' property added in
mitz@apple.com [Fri, 21 Mar 2008 07:07:28 +0000 (07:07 +0000)]
    - update results for the 'zoom' property added in

        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 21 Mar 2008 05:30:19 +0000 (05:30 +0000)]

2008-03-20  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        - fix an assertion failure due to a line being marked dirty during
          computeVerticalPositionsForLine() due to temporary box destruction

        Test: fast/inline/clean-after-removing-temp-boxes.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::setTextWithOffset): Added code to dirty lines
        when this method is called on an empty text node, which has no line
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeVerticalPositionsForLine): Mark the line
        clean in the end.


2008-03-20  Dan Bernstein  <mitz@apple.com>

        Reviewed by Anders Carlsson.

        - test for an assertion failure due to a line being marked dirty during
          computeVerticalPositionsForLine() due to temporary box destruction

        * fast/inline/clean-after-removing-temp-boxes-expected.txt: Added.
        * fast/inline/clean-after-removing-temp-boxes.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix for leak introduced by inline ScopeChainNode use
oliver@apple.com [Fri, 21 Mar 2008 05:00:16 +0000 (05:00 +0000)]
Fix for leak introduced by inline ScopeChainNode use

Reviewed by Maciej

To avoid any extra branches when managing an inline ScopeChainNode
in the ScopeChain the inline node gets inserted with a refcount of
2.  This meant than when the ScopeChain was destroyed the ScopeChainNodes
above the inline node would be leaked.

We resolve this by manually popping the inline node in the
FunctionExecState destructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 21 Mar 2008 01:32:01 +0000 (01:32 +0000)]
2008-03-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        Make some member variables private.

        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 21 Mar 2008 01:18:20 +0000 (01:18 +0000)]
2008-03-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        Get rid of m_originalURL in ResourceLoader.

        * loader/ResourceLoader.cpp:
        Don't store m_originalURL.

        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        Use the url of the current request instead of the original URL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 21 Mar 2008 01:07:22 +0000 (01:07 +0000)]
2008-03-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej.

        Small loader cleanups.

        * loader/MainResourceLoader.cpp:
        No need to call setRequest here, ResourceLoader::willSendRequest takes care of that.
        Also, there is no need to check that newRequest is null here, because we assert earlier that it is not.

        * loader/ResourceLoader.h:
        Get rid of setRequest, it is no longer needed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 21 Mar 2008 01:00:58 +0000 (01:00 +0000)]
2008-03-20  Anders Carlsson  <andersca@apple.com>

        Get rid of a couple of unnecessary class declarations.

        * loader/SubresourceLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-20 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 21 Mar 2008 00:30:08 +0000 (00:30 +0000)]
2008-03-20  David Hyatt  <hyatt@apple.com>

        Add a new value to background-clip, "text", that allows backgrounds to be clipped to foreground text (and
        associated text decorations like shadows and underlines).

        Reviewed by Beth

        * css/CSSParser.cpp:
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::operator EBackgroundBox):
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * rendering/InlineBox.cpp:
        * rendering/InlineFlowBox.cpp:
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderFieldset.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderStyle.h:
        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Allow pausing/blocking of JS execution by plugins
aroben@apple.com [Fri, 21 Mar 2008 00:14:58 +0000 (00:14 +0000)]
    Allow pausing/blocking of JS execution by plugins

        Part of Bug 17133: Should support pausing JavaScript execution without
        hanging the process


        This patch doesn't affect Mac, which doesn't use the shared PluginView

        Note that this patch doesn't prevent plugins from executing JS via an
        NPObject they've already gotten hold of. It just blocks obtaining new
        NPObjects and pauses any requests to evaluate javascript: URIs. This
        is probably good enough for now because most plugins seem to always
        obtain the Window object each time they want to execute JS.

        Reviewed by Tim Hatcher.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::getValue): Return an error if JS is paused.
        (WebCore::PluginView::setJavaScriptPaused): Stop the request timer if
        we're pausing, and resume it if we're unpausing.
        (WebCore::PluginView::PluginView): Initialize new members.
        * plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31199 268f45cc-cd09-0410-ab3c-d52691b4dbfc