mjs@apple.com [Wed, 30 Mar 2011 07:36:38 +0000 (07:36 +0000)]
2011-03-30 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
https://bugs.webkit.org/show_bug.cgi?id=57429
* Scripts/webkitpy/common/checkout/scm.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 07:16:02 +0000 (07:16 +0000)]
2011-03-30 Adam Barth <abarth@webkit.org>
Reviewed by Dan Bernstein.
Update Mac Leopard baselines after r82056
https://bugs.webkit.org/show_bug.cgi?id=57428
These expected results differ from old ones just by a pixel or two.
I suspect they're caused by text metrics differences, but I haven't
confirmed visually.
* platform/mac-leopard/fast/ruby/base-shorter-than-text-expected.txt:
* platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt:
* platform/mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 30 Mar 2011 07:00:25 +0000 (07:00 +0000)]
2011-03-30 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
H1 element should have different default style if it is in HTML5 sectioning elements.
https://bugs.webkit.org/show_bug.cgi?id=52693
* fast/css/h1-in-section-elements.html: Added.
* platform/mac/fast/css/h1-in-section-elements-expected.checksum: Added.
* platform/mac/fast/css/h1-in-section-elements-expected.png: Added.
* platform/mac/fast/css/h1-in-section-elements-expected.txt: Added.
2011-03-30 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
H1 element should have different default style if it is in HTML5 sectioning elements.
https://bugs.webkit.org/show_bug.cgi?id=52693
Test: fast/css/h1-in-section-elements.html
* css/html.css: Add font-size and margin declarations to follow HTML5 specification.
(:-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 30 Mar 2011 06:51:53 +0000 (06:51 +0000)]
2011-03-29 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
[Snow Leopard WebKit2 Release Tests] fast/images/move-image-to-new-document.html timing out since r82087
https://bugs.webkit.org/show_bug.cgi?id=57347
* fast/images/script-tests/move-image-to-new-document.js: Disable
plug-ins so that the embed portion of the test gets the expected image
loading behavior on bots with QuickTime installed.
* platform/mac-wk2/Skipped: Skip the test in WebKit2 since it doesn't
implement setPluginsEnabled().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Wed, 30 Mar 2011 06:42:32 +0000 (06:42 +0000)]
Source/WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/
8665411>
Reviewed by Maciej Stachowiak.
* platform/mac/PlatformScreenMac.mm:
(WebCore::windowScaleFactor):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):
Source/WebKit/mac: Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/
8665411>
Reviewed by Maciej Stachowiak.
* Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]):
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::scaleFactor):
* WebView/WebHTMLView.mm:
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView attachRootLayer:]):
Source/WebKit2: Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
-and corresponding-
<rdar://problem/
8665411>
Reviewed by Maciej Stachowiak.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::userSpaceScaleFactor):
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::userSpaceScaleFactor):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* UIProcess/gtk/WebView.h:
(WebKit::WebView::userSpaceScaleFactor):
* UIProcess/win/WebView.h:
(WebKit::WebView::userSpaceScaleFactor):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scaleFactor):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userSpaceScaleFactor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 06:39:59 +0000 (06:39 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Remove a bunch of IMAGE only Snow Leopard Chromium failures from the
expectations file. This will trigger our rebaselining machinery to
make it possible to rebaseline these tests efficiently and accurately,
which I intend to do shortly.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 06:27:57 +0000 (06:27 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Re-land these expected results in the correct directory.
* platform/chromium-mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/
4845371-expected.checksum: Added.
* platform/chromium-mac-snowleopard/editing/deleting/
4845371-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/
5126166-expected.checksum: Added.
* platform/chromium-mac-snowleopard/editing/deleting/
5126166-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/
5483370-expected.checksum: Added.
* platform/chromium-mac-snowleopard/editing/deleting/
5483370-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.checksum: Added.
* platform/chromium-mac-snowleopard/editing/deleting/table-cells-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/inserting/
4875189-2-expected.checksum: Added.
* platform/chromium-mac-snowleopard/editing/inserting/
4875189-2-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/
5387578-expected.checksum: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/
5387578-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.checksum: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float: Added.
* platform/chromium-mac-snowleopard/fast/block/float/014-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/block/float/014-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-radius-inline-flow-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-radius-inline-flow-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-zoom-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-zoom-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-align-image-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-align-image-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-type-change-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-type-change-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/images: Added.
* platform/chromium-mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/inline-block: Added.
* platform/chromium-mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/inline/inline-focus-ring-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/margin-collapse-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/multicol/margin-collapse-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/max-height-columns-block-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/multicol/max-height-columns-block-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/positioned-split-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/multicol/positioned-split-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/single-line-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/multicol/single-line-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/table-margin-collapse-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/multicol/table-margin-collapse-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/basic: Added.
* platform/chromium-mac-snowleopard/fast/text/basic/002-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/text/basic/002-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/word-break-soft-hyphen-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/text/word-break-soft-hyphen-expected.png: Added.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/scrollbars: Added.
* platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
* platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
* platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
* platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters: Added.
* platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text: Added.
* platform/chromium-mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
* platform/chromium-mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 30 Mar 2011 06:24:26 +0000 (06:24 +0000)]
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Rename BidiResolver::eor and sor to m_eor and m_sor to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57369
I considered renaming these to m_endOfRun and m_startOfRun but decided
that was too verbose for now (given how often they're used). I suspect
with a bit more refactoring we'll find they're not used very often and can be renamed
if so desired.
* platform/text/BidiResolver.h:
(WebCore::::appendRun):
(WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
(WebCore::::lowerExplicitEmbeddingLevel):
(WebCore::::raiseExplicitEmbeddingLevel):
(WebCore::::createBidiRunsForLine):
* rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 06:20:25 +0000 (06:20 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Revert previous change. These should have gone into the Chromium Snow
Leopard folder. (Thanks to mrowe for pointing out my error.)
* platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Removed.
* platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Removed.
* platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Removed.
* platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Removed.
* platform/mac-snowleopard/editing/deleting/
4845371-expected.checksum: Removed.
* platform/mac-snowleopard/editing/deleting/
4845371-expected.png: Removed.
* platform/mac-snowleopard/editing/deleting/
5126166-expected.checksum: Removed.
* platform/mac-snowleopard/editing/deleting/
5126166-expected.png: Removed.
* platform/mac-snowleopard/editing/deleting/
5483370-expected.checksum: Removed.
* platform/mac-snowleopard/editing/deleting/
5483370-expected.png: Removed.
* platform/mac-snowleopard/editing/deleting/table-cells-expected.checksum: Removed.
* platform/mac-snowleopard/editing/deleting/table-cells-expected.png: Removed.
* platform/mac-snowleopard/editing/inserting/
4875189-2-expected.checksum: Removed.
* platform/mac-snowleopard/editing/inserting/
4875189-2-expected.png: Removed.
* platform/mac-snowleopard/editing/pasteboard/
5387578-expected.checksum: Removed.
* platform/mac-snowleopard/editing/pasteboard/
5387578-expected.png: Removed.
* platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.checksum: Removed.
* platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Removed.
* platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Removed.
* platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Removed.
* platform/mac-snowleopard/fast/block/float/014-expected.checksum: Removed.
* platform/mac-snowleopard/fast/block/float/014-expected.png: Removed.
* platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Removed.
* platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Removed.
* platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.checksum: Removed.
* platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.png: Removed.
* platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.checksum: Removed.
* platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.png: Removed.
* platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.checksum: Removed.
* platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png: Removed.
* platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Removed.
* platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Removed.
* platform/mac-snowleopard/fast/forms/input-align-image-expected.checksum: Removed.
* platform/mac-snowleopard/fast/forms/input-align-image-expected.png: Removed.
* platform/mac-snowleopard/fast/forms/input-type-change-expected.checksum: Removed.
* platform/mac-snowleopard/fast/forms/input-type-change-expected.png: Removed.
* platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Removed.
* platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Removed.
* platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.checksum: Removed.
* platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Removed.
* platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Removed.
* platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Removed.
* platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.checksum: Removed.
* platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
* platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.checksum: Removed.
* platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.png: Removed.
* platform/mac-snowleopard/fast/multicol/margin-collapse-expected.checksum: Removed.
* platform/mac-snowleopard/fast/multicol/margin-collapse-expected.png: Removed.
* platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.checksum: Removed.
* platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.png: Removed.
* platform/mac-snowleopard/fast/multicol/positioned-split-expected.checksum: Removed.
* platform/mac-snowleopard/fast/multicol/positioned-split-expected.png: Removed.
* platform/mac-snowleopard/fast/multicol/single-line-expected.checksum: Removed.
* platform/mac-snowleopard/fast/multicol/single-line-expected.png: Removed.
* platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.checksum: Removed.
* platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.png: Removed.
* platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.checksum: Removed.
* platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.png: Removed.
* platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.checksum: Removed.
* platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Removed.
* platform/mac-snowleopard/fast/replaced/image-onload-expected.checksum: Removed.
* platform/mac-snowleopard/fast/replaced/image-onload-expected.png: Removed.
* platform/mac-snowleopard/fast/replaced/image-sizing-expected.checksum: Removed.
* platform/mac-snowleopard/fast/replaced/image-sizing-expected.png: Removed.
* platform/mac-snowleopard/fast/text/basic/002-expected.checksum: Removed.
* platform/mac-snowleopard/fast/text/basic/002-expected.png: Removed.
* platform/mac-snowleopard/fast/text/drawBidiText-expected.checksum: Removed.
* platform/mac-snowleopard/fast/text/drawBidiText-expected.png: Removed.
* platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.checksum: Removed.
* platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.png: Removed.
* platform/mac-snowleopard/media/video-transformed-expected.checksum: Removed.
* platform/mac-snowleopard/media/video-transformed-expected.png: Removed.
* platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Removed.
* platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
* platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Removed.
* platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Removed.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
* platform/mac-snowleopard/svg/custom/focus-ring-expected.checksum: Removed.
* platform/mac-snowleopard/svg/custom/focus-ring-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Removed.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Removed.
* platform/mac-snowleopard/svg/filters/filterRes-expected.checksum: Removed.
* platform/mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
* platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Removed.
* platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Removed.
* platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Removed.
* platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
* platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Removed.
* platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 30 Mar 2011 06:19:23 +0000 (06:19 +0000)]
2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57351
* bindings/js/ScriptHeapSnapshot.h:
* bindings/v8/ScriptHeapSnapshot.cpp:
* bindings/v8/ScriptHeapSnapshot.h:
* inspector/Inspector.json:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 05:59:25 +0000 (05:59 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Update Snow Leopard baselines.
* platform/mac-snowleopard/css2.1: Added.
* platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
* platform/mac-snowleopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
* platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
* platform/mac-snowleopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Added.
* platform/mac-snowleopard/editing: Added.
* platform/mac-snowleopard/editing/deleting: Added.
* platform/mac-snowleopard/editing/deleting/
4845371-expected.checksum: Added.
* platform/mac-snowleopard/editing/deleting/
4845371-expected.png: Added.
* platform/mac-snowleopard/editing/deleting/
5126166-expected.checksum: Added.
* platform/mac-snowleopard/editing/deleting/
5126166-expected.png: Added.
* platform/mac-snowleopard/editing/deleting/
5483370-expected.checksum: Added.
* platform/mac-snowleopard/editing/deleting/
5483370-expected.png: Added.
* platform/mac-snowleopard/editing/deleting/table-cells-expected.checksum: Added.
* platform/mac-snowleopard/editing/deleting/table-cells-expected.png: Added.
* platform/mac-snowleopard/editing/inserting: Added.
* platform/mac-snowleopard/editing/inserting/
4875189-2-expected.checksum: Added.
* platform/mac-snowleopard/editing/inserting/
4875189-2-expected.png: Added.
* platform/mac-snowleopard/editing/pasteboard: Added.
* platform/mac-snowleopard/editing/pasteboard/
5387578-expected.checksum: Added.
* platform/mac-snowleopard/editing/pasteboard/
5387578-expected.png: Added.
* platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.checksum: Added.
* platform/mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Added.
* platform/mac-snowleopard/fast/backgrounds: Added.
* platform/mac-snowleopard/fast/backgrounds/repeat: Added.
* platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
* platform/mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
* platform/mac-snowleopard/fast/block: Added.
* platform/mac-snowleopard/fast/block/float: Added.
* platform/mac-snowleopard/fast/block/float/014-expected.checksum: Added.
* platform/mac-snowleopard/fast/block/float/014-expected.png: Added.
* platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
* platform/mac-snowleopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
* platform/mac-snowleopard/fast/borders: Added.
* platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.checksum: Added.
* platform/mac-snowleopard/fast/borders/border-radius-inline-flow-expected.png: Added.
* platform/mac-snowleopard/fast/canvas: Added.
* platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.checksum: Added.
* platform/mac-snowleopard/fast/canvas/canvas-zoom-expected.png: Added.
* platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.checksum: Added.
* platform/mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/mac-snowleopard/fast/dom: Added.
* platform/mac-snowleopard/fast/dom/HTMLMeterElement: Added.
* platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
* platform/mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
* platform/mac-snowleopard/fast/forms/input-align-image-expected.checksum: Added.
* platform/mac-snowleopard/fast/forms/input-align-image-expected.png: Added.
* platform/mac-snowleopard/fast/forms/input-type-change-expected.checksum: Added.
* platform/mac-snowleopard/fast/forms/input-type-change-expected.png: Added.
* platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Added.
* platform/mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
* platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/mac-snowleopard/fast/images: Added.
* platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
* platform/mac-snowleopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
* platform/mac-snowleopard/fast/inline: Added.
* platform/mac-snowleopard/fast/inline-block: Added.
* platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
* platform/mac-snowleopard/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
* platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/mac-snowleopard/fast/inline/inline-focus-ring-expected.png: Added.
* platform/mac-snowleopard/fast/multicol: Added.
* platform/mac-snowleopard/fast/multicol/margin-collapse-expected.checksum: Added.
* platform/mac-snowleopard/fast/multicol/margin-collapse-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.checksum: Added.
* platform/mac-snowleopard/fast/multicol/max-height-columns-block-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/positioned-split-expected.checksum: Added.
* platform/mac-snowleopard/fast/multicol/positioned-split-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/single-line-expected.checksum: Added.
* platform/mac-snowleopard/fast/multicol/single-line-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.checksum: Added.
* platform/mac-snowleopard/fast/multicol/table-margin-collapse-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
* platform/mac-snowleopard/fast/multicol/unsplittable-inline-block-expected.png: Added.
* platform/mac-snowleopard/fast/replaced: Added.
* platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.checksum: Added.
* platform/mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png: Added.
* platform/mac-snowleopard/fast/replaced/image-onload-expected.checksum: Added.
* platform/mac-snowleopard/fast/replaced/image-onload-expected.png: Added.
* platform/mac-snowleopard/fast/replaced/image-sizing-expected.checksum: Added.
* platform/mac-snowleopard/fast/replaced/image-sizing-expected.png: Added.
* platform/mac-snowleopard/fast/text/basic: Added.
* platform/mac-snowleopard/fast/text/basic/002-expected.checksum: Added.
* platform/mac-snowleopard/fast/text/basic/002-expected.png: Added.
* platform/mac-snowleopard/fast/text/drawBidiText-expected.checksum: Added.
* platform/mac-snowleopard/fast/text/drawBidiText-expected.png: Added.
* platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.checksum: Added.
* platform/mac-snowleopard/fast/text/word-break-soft-hyphen-expected.png: Added.
* platform/mac-snowleopard/media: Added.
* platform/mac-snowleopard/media/video-transformed-expected.checksum: Added.
* platform/mac-snowleopard/media/video-transformed-expected.png: Added.
* platform/mac-snowleopard/scrollbars: Added.
* platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
* platform/mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
* platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
* platform/mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
* platform/mac-snowleopard/svg/custom: Added.
* platform/mac-snowleopard/svg/custom/focus-ring-expected.checksum: Added.
* platform/mac-snowleopard/svg/custom/focus-ring-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
* platform/mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
* platform/mac-snowleopard/svg/filters: Added.
* platform/mac-snowleopard/svg/filters/filterRes-expected.checksum: Added.
* platform/mac-snowleopard/svg/filters/filterRes-expected.png: Added.
* platform/mac-snowleopard/svg/text: Added.
* platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
* platform/mac-snowleopard/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
* platform/mac-snowleopard/tables: Added.
* platform/mac-snowleopard/tables/mozilla: Added.
* platform/mac-snowleopard/tables/mozilla/core: Added.
* platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Added.
* platform/mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
* platform/mac-snowleopard/tables/mozilla_expected_failures: Added.
* platform/mac-snowleopard/tables/mozilla_expected_failures/bugs: Added.
* platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Added.
* platform/mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 30 Mar 2011 05:39:08 +0000 (05:39 +0000)]
2011-03-29 Kent Tamura <tkent@chromium.org>
[Chromium] Add expectations for a test added in r82386.
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.checksum: Added.
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png: Added.
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt: Added.
* platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png: Added.
* platform/chromium-win/fast/forms/validation-message-appearance-expected.checksum: Added.
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png: Added.
* platform/chromium-win/fast/forms/validation-message-appearance-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 30 Mar 2011 05:14:19 +0000 (05:14 +0000)]
Unreviewed build change to activate MathML for WinCairo.
* win/tools/vsprops/FeatureDefinesCairo.vsprops: Enable MathML.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 30 Mar 2011 04:55:31 +0000 (04:55 +0000)]
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split more logic out from createBidiRunsForLine for readability
https://bugs.webkit.org/show_bug.cgi?id=57341
I marked reorderRunsFromLevels inline, but it probably doesn't actually need to (or want to) be.
This lops another large hunk off of reorderRunsFromLevels further reducing the size and complexity.
* platform/text/BidiResolver.h:
(WebCore::::reorderRunsFromLevels):
(WebCore::::createBidiRunsForLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Wed, 30 Mar 2011 04:38:07 +0000 (04:38 +0000)]
Unreviewed WinCairo build fix.
Bring DownloadCurl implementation stubs in line with current
CFNetwork API.
* WebProcess/Downloads/curl/DownloadCurl.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 30 Mar 2011 04:17:50 +0000 (04:17 +0000)]
2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82383.
http://trac.webkit.org/changeset/82383
https://bugs.webkit.org/show_bug.cgi?id=57417
"nrwt isn't shutting down cleanly" (Requested by dpranke on
#webkit).
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 30 Mar 2011 04:14:46 +0000 (04:14 +0000)]
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290
Add a new test for validation message bubble, and skip it on non-Mac platforms.
* fast/forms/validation-message-appearance.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/fast/forms/validation-message-appearance-expected.checksum: Added.
* platform/mac/fast/forms/validation-message-appearance-expected.png: Added.
* platform/mac/fast/forms/validation-message-appearance-expected.txt: Added.
* platform/qt/Skipped:
* platform/win/Skipped:
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290
Introduce a setting for validation message timer so that we can configure
how long we show a validation message bubble.
Test: fast/forms/validation-message-appearance.html
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Don't set a timer if the timer magnification value is 0 or negative.
Otherwise, hides the bubble length * magnification / 1000 seconds.
* page/Settings.cpp:
(WebCore::Settings::Settings): Initialize the timer magnification value.
* page/Settings.h:
(WebCore::Settings::setValidationMessageTimerMagnification): Added.
(WebCore::Settings::validationMessageTimerMaginification): Added.
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Copy the private value of
the timer magnification to WebCore::Settings.
(-[WebView validationMessageTimerMagnification]): Added.
(-[WebView setValidationMessageTimerMagnification:]): Added.
* WebView/WebViewData.h: Declare a member for the timer magnification.
* WebView/WebViewData.mm:
(-[WebViewPrivate init]): Initialize the timer magnification.
* WebView/WebViewPrivate.h:
Declare a setter and a getter for the timer magnification.
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Make validation message bubble testable
https://bugs.webkit.org/show_bug.cgi?id=57290
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow): Change a setting so that validation
bubbles isn't hidden automatically.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 30 Mar 2011 02:52:47 +0000 (02:52 +0000)]
2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
Remove the extraneous declaration I accidentally added in r82376.
* dom/MouseEvent.h: Removed createSimulated decl.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82385
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 02:22:51 +0000 (02:22 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Document that we're now passing these tests.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82384
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 30 Mar 2011 02:17:19 +0000 (02:17 +0000)]
2011-03-29 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
It's a bit unclear whether multiple threads or multiple
processes will be a better model on windows. This change will
test threads for now while we're still working out the bugs in
multiple-processes.
https://bugs.webkit.org/show_bug.cgi?id=57410
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82383
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Wed, 30 Mar 2011 02:00:49 +0000 (02:00 +0000)]
2011-03-29 David Levin <levin@chromium.org>
Reviewed by Shinichiro Hamaji.
check-webkit-style confused by two ChangeLog entries in a row from same user
https://bugs.webkit.org/show_bug.cgi?id=57250
* Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
* Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
* Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
It basically assumes only one ChangeLog entry is being processed because that is the standard case and
checking more than that would be very messey.
* Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
* Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82382
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 30 Mar 2011 02:00:37 +0000 (02:00 +0000)]
2011-03-29 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Compositor crash with show-layer-borders flag
https://bugs.webkit.org/show_bug.cgi?id=57292
Synchronize the debug border color/width with other properties to ensure the appropriate
CCLayerImpl exists. Code is only exercised with a debugging command line flag so no layout
test.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setBorderColor):
(WebCore::LayerChromium::setBorderWidth):
* platform/graphics/chromium/LayerChromium.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82381
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 01:48:01 +0000 (01:48 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Add missing PNGs. These PNGs match the checksums.
* platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82380
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Wed, 30 Mar 2011 01:35:53 +0000 (01:35 +0000)]
2011-03-29 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Teach the preload scanner about <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=57404
* fast/preloader/input-expected.txt: Added.
* fast/preloader/input.html: Added.
2011-03-29 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Teach the preload scanner about <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=57404
I did a very rough sample of the top 50 web pages to see how many of each
HTML resource type they include:
img src: 1,359
script src: 276
link href: 256
iframe src: 104
input src: 50
embed src: 37
@import: 13
object data: 11
Based on this, it seems worthwhile to preload inputs and iframes (possibly embed).
This patch only does inputs.
Test: fast/preloader/input.html
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLNames::PreloadTask::PreloadTask):
(WebCore::HTMLNames::PreloadTask::processAttributes):
(WebCore::HTMLNames::PreloadTask::inputTypeAttributeIsImage):
(WebCore::HTMLNames::PreloadTask::preload):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 30 Mar 2011 01:26:35 +0000 (01:26 +0000)]
2011-03-29 Luke Macpherson <macpherson@chromium.org>
Reviewed by David Levin.
Improve the massive switch statement in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=56288
No new tests are needed because no new functionality exposed.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Asserted that cases implemented in the CSSStyleApplyProperty lookup table are unreachable.
Updated comment.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 30 Mar 2011 01:22:25 +0000 (01:22 +0000)]
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Mac] Enable interactive-validation tests on Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=57308
* fast/forms/interactive-validation-prevented-expected.txt: Fix a wrong expectation.
* platform/chromium/test_expectations.txt:
Update expectation of interactive-validation-prevented.html.
* platform/mac/Skipped: Unskip interactive-validation except
interactive-validation-lost-focusable.html, which doesn't pass for now.
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Mac] Enable interactive-validation tests on Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=57308
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):
Convey a WebView flag for interactive validation to WebCore::Settings.
(-[WebView interactiveFormValidationEnabled]): Added.
(-[WebView setInteractiveFormValidationEnabled:]): Added.
* WebView/WebViewData.h: Add interactiveFormValidationEnabled.
* WebView/WebViewData.mm:
(-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
* WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
2011-03-29 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Mac] Enable interactive-validation tests on Mac DRT
https://bugs.webkit.org/show_bug.cgi?id=57308
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Wed, 30 Mar 2011 01:07:22 +0000 (01:07 +0000)]
2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Introduce SimulatedMouseEvent and teach EventDispatcher how to use it.
https://bugs.webkit.org/show_bug.cgi?id=57402
No functional changes, covered by existing tests.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick): Changed to use SimulatedMouseEvent.
(WebCore::EventDispatcher::dispatchMouseEvent): Combined two dispatchMouseEvent methods
into one, now that simulated-click events don't need one.
* dom/EventDispatcher.h: Updated decls.
* dom/MouseEvent.cpp:
(WebCore::SimulatedMouseEvent::create): Added.
(WebCore::SimulatedMouseEvent::~SimulatedMouseEvent): Added.
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent): Added.
* dom/MouseEvent.h: Made constructor protected.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82376
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 30 Mar 2011 01:02:50 +0000 (01:02 +0000)]
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Remove unused GEN_DOMObject files
https://bugs.webkit.org/show_bug.cgi?id=57370
* GEN_DOMObject.cpp: Removed.
* GEN_DOMObject.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 30 Mar 2011 01:02:43 +0000 (01:02 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Update the last set of GTK+ results after r82343.
* platform/gtk: Update the last set of GTK+ results.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 00:55:49 +0000 (00:55 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Revert previous change now that the roll is in.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 30 Mar 2011 00:54:34 +0000 (00:54 +0000)]
AX: WK2: When creating the window remote token, use what's returned from accessibility
https://bugs.webkit.org/show_bug.cgi?id=57398
Reviewed by Darin Adler.
This will allow a specific WKView to override what's used for the window attribute of the
HTML elements.
* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 00:51:33 +0000 (00:51 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
These tests are actually fine, I just can't figure out how to make the
bot happy. I'm going to try rolling and then continue beating my head
against the bot.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Wed, 30 Mar 2011 00:40:11 +0000 (00:40 +0000)]
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Sam Weinig.
Make Windows-only InjectedBundle functions platform-specific
https://bugs.webkit.org/show_bug.cgi?id=57385
Added files for Windows-specific WKBundle functions.
Removed stub wrappers for InjectedBundle::setHostAllowsAnyHTTPSCertificate() and InjectedBundle::setClientCertificate() from non-Windows platforms.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp: Moved WKBundleSetHostAllowsAnyHTTPSCertificate() and WKBundleSetClientCertificate() to WKBundlePrivateWin.cpp.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Moved WKBundleSetHostAllowsAnyHTTPSCertificate() and WKBundleSetClientCertificate() to WKBundlePrivateWin.h.
* WebProcess/InjectedBundle/API/c/win: Added.
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp: Added.
(WKBundleSetHostAllowsAnyHTTPSCertificate): Moved from WKBundle.cpp.
(WKBundleSetClientCertificate): Moved from WKBundle.cpp.
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Added.
* WebProcess/InjectedBundle/InjectedBundle.h: setHostAllowsAnyHTTPSCertificate() and setClientCertificate() are Windows-only.
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
* WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed setHostAllowsAnyHTTPSCertificate() and setClientCertificate().
* win/WebKit2.vcproj: Added WKBundlePrivateWin.cpp and WKBundlePrivateWin.h.
* win/WebKit2Generated.make: Copy WKBundlePrivateWin.h.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 30 Mar 2011 00:29:23 +0000 (00:29 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Attempt to fix Chromium Mac Canary. It's unclear whether removing
these files will help, but it's worth a try.
* platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Removed.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Removed.
* platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Removed.
* platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Removed.
* platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Removed.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Removed.
* platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Removed.
* platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 30 Mar 2011 00:14:23 +0000 (00:14 +0000)]
Fix Windows build.
* WebProcess/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 30 Mar 2011 00:13:16 +0000 (00:13 +0000)]
Fix build.
* WebCore.exp.in:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 30 Mar 2011 00:06:19 +0000 (00:06 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Update the GTK+ results in the tables directory after r82343.
* platform/gtk/tables: Update the results in this directory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 30 Mar 2011 00:02:44 +0000 (00:02 +0000)]
2011-03-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Downloads: Authentication support
https://bugs.webkit.org/show_bug.cgi?id=57403
<rdar://problem/
8691166>
* UIProcess/API/C/WKContext.h:
Add didReceiveAuthenticationChallenge callback.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
Call the download client.
* UIProcess/Downloads/DownloadProxy.messages.in:
Add DidReceiveAuthenticationChallenge message.
* UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::didReceiveAuthenticationChallenge):
Call the client callback function.
* UIProcess/WebDownloadClient.h:
* WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
Send the DidReceiveAuthenticationChallenge message to the download proxy.
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
If the authentication client is null, call the static download member functions.
* WebProcess/Authentication/AuthenticationManager.h:
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didReceiveAuthenticationChallenge):
Call the authentication manager.
* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
Call the right sender methods.
(-[WKDownloadAsDelegate download:didReceiveAuthenticationChallenge:]):
(-[WKDownloadAsDelegate downloadShouldUseCredentialStorage:]):
Call the right Download member functions.
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::receivedCredential):
(WebKit::Download::receivedRequestToContinueWithoutCredential):
(WebKit::Download::receivedCancellation):
Add stubs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 29 Mar 2011 23:55:28 +0000 (23:55 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Update CSS and editing GTK+ results after r82343.
* platform/gtk/css1:
* platform/gtk/css2.1:
* platform/gtk/editing:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Tue, 29 Mar 2011 23:46:41 +0000 (23:46 +0000)]
2011-03-29 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
JavaInstance should not use jvalue in its API
https://bugs.webkit.org/show_bug.cgi?id=57019
This change updates JavaInstance for V8 to use JavaValue, rather than
jvalue, in its API. This will allow us to create an API for
JavaInstance that is independent of JNI, to allow it to be
implemented on platforms that do not use JNI directly.
Refactoring only, no new tests.
* bridge/jni/v8/JavaInstanceV8.cpp:
(JavaInstance::invokeMethod):
(JavaInstance::getField):
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectGetProperty):
* bridge/jni/v8/JavaValueV8.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82361
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 29 Mar 2011 23:43:51 +0000 (23:43 +0000)]
2011-03-29 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
AuthenticationChallengeProxy objects should be associated with processes, not pages
https://bugs.webkit.org/show_bug.cgi?id=57401
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::useCredential):
(WebKit::AuthenticationChallengeProxy::cancel):
* UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::create):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82359
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 29 Mar 2011 23:42:30 +0000 (23:42 +0000)]
Use LocalizedStrings.h as a bottleneck for localized strings instead of
using UI_STRING.
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]):
Call existing localization functions instead of using UI_STRING.
(-[WKView _getTextInputState:selectionEnd:underlines:]):
Remove unnecessary WebCore:: prefix.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82358
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 23:41:32 +0000 (23:41 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Remove more-specific instances of a general rule.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82357
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 29 Mar 2011 23:37:20 +0000 (23:37 +0000)]
2011-03-29 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=42692
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
(WebKit::WebPreferencesStore::overrideAllowUniversalAccessFromFileURLsForTestRunner):
* Shared/WebPreferencesStore.h:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleOverrideAllowUniversalAccessFromFileURLsForTestRunner):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideAllowUniversalAccessFromFileURLsForTestRunner):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-03-29 Chang Shu <cshu@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=42692
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82356
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 29 Mar 2011 23:33:58 +0000 (23:33 +0000)]
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Rename BidiResolver::last to m_last to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57367
* platform/text/BidiResolver.h:
(WebCore::::lowerExplicitEmbeddingLevel):
(WebCore::::raiseExplicitEmbeddingLevel):
(WebCore::::createBidiRunsForLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82354
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 29 Mar 2011 23:30:26 +0000 (23:30 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Update the GTK+ results in the svg directory after r82343.
* platform/gtk/svg: Update the results in this directory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82353
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 29 Mar 2011 23:30:15 +0000 (23:30 +0000)]
Fix the Qt, WinCE and Chromium builds.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82352
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Tue, 29 Mar 2011 23:20:16 +0000 (23:20 +0000)]
2011-03-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Maciej Stachowiak.
SVGComponentTransferFunctionElement should validate type
https://bugs.webkit.org/show_bug.cgi?id=56960
* svg/filters/feComponentTransfer-style-crash-expected.txt: Added.
* svg/filters/feComponentTransfer-style-crash.xhtml: Added.
2011-03-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Maciej Stachowiak.
SVGComponentTransferFunctionElement should validate type
https://bugs.webkit.org/show_bug.cgi?id=56960
Test: svg/filters/feComponentTransfer-style-crash.xhtml
* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged):
* svg/SVGComponentTransferFunctionElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 29 Mar 2011 23:16:31 +0000 (23:16 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Update the last set of fast GTK+ results after r82343.
* platform/gtk/fast: Update the last set of results in this directory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 29 Mar 2011 23:12:31 +0000 (23:12 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Update more GTK+ results after r82343.
* platform/gtk/fast: Update many more results in this directory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 29 Mar 2011 23:06:54 +0000 (23:06 +0000)]
More build fix.
* WebCoreSupport/WebPlatformStrategies.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 29 Mar 2011 23:05:39 +0000 (23:05 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Update GTK+ results after r82343.
* platform/gtk/fast: Update many results in this directory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 29 Mar 2011 22:59:41 +0000 (22:59 +0000)]
[Qt] Add new failing tests to the Skipped list until tomorrow.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 29 Mar 2011 22:57:11 +0000 (22:57 +0000)]
Build fix.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 29 Mar 2011 22:56:33 +0000 (22:56 +0000)]
2011-03-29 Thomas Klausner <tk@giga.or.at>
Reviewed by David Levin.
png-1.5 fixes
https://bugs.webkit.org/show_bug.cgi?id=54406
Fix compilation with png-1.5: struct members were hidden, and
a new API to terminate data processing was added (especially for
WebKit).
Compilation fixes, so no new tests.
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 29 Mar 2011 22:55:37 +0000 (22:55 +0000)]
2011-03-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
https://bugs.webkit.org/show_bug.cgi?id=57067
Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
update DRT and pixel results as hundreds of results will need to be updated.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
by overriding the theme RC/CSS files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 29 Mar 2011 22:53:03 +0000 (22:53 +0000)]
2011-03-29 Gavin Peters <gavinp@chromium.org>
Reviewed by Tony Gentilcore.
Add beforeload to icon and prefetch link rel types
https://bugs.webkit.org/show_bug.cgi?id=56424
Unfortunately, there's lots of skipped tests, and a chrome failure
expectation here, in a strange disjoint set. On the chromium
port, favicon loads don't occur in DRT, so the favicon changes are
expected to fail. On the ports without prefetching, we expect the
prefetching test to fail.
* fast/dom/HTMLLinkElement/prefetch-beforeload-expected.txt: Added.
* fast/dom/HTMLLinkElement/prefetch-beforeload.html: Added.
* http/tests/misc/link-rel-icon-beforeload-expected.txt: Added.
* http/tests/misc/link-rel-icon-beforeload.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* webarchive/test-link-rel-icon-beforeload-expected.webarchive: Added.
* webarchive/test-link-rel-icon-beforeload.html: Added.
2011-03-29 Gavin Peters <gavinp@chromium.org>
Reviewed by Tony Gentilcore.
Add beforeload to icon and prefetch link rel types
https://bugs.webkit.org/show_bug.cgi?id=56424
Over in https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html , a webkit-dev
thread, I've discussed my hopes for the link element, and adding the link header. This
change helps improve the link header by making it participate in the beforeload event in
two more important cases.
Tests: fast/dom/HTMLLinkElement/prefetch-beforeload.html
http/tests/misc/link-rel-icon-beforeload.html
webarchive/test-link-rel-icon-beforeload.html
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::checkBeforeLoadEvent):
(WebCore::HTMLLinkElement::process):
* html/HTMLLinkElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 29 Mar 2011 22:50:37 +0000 (22:50 +0000)]
2011-03-29 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
Rename BidiResolver::current to BidiResolver::m_current to match modern style
https://bugs.webkit.org/show_bug.cgi?id=57363
I was very confused by current until I realized it was a member variable.
I also did m_reachedEndOfLine since that was small.
* platform/text/BidiResolver.h:
(WebCore::BidiResolver::position):
(WebCore::BidiResolver::setPosition):
(WebCore::BidiResolver::increment):
(WebCore::::createBidiRunsForLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 29 Mar 2011 22:46:53 +0000 (22:46 +0000)]
2011-03-29 Geoff Pike <gpike@chromium.org>
Reviewed by Dimitri Glazkov.
In HitTestResult objects, initialize the ListHashSet<RefPtr<Node> >
lazily. In my informal testing it seems to be used hardly at all, so
it's wasteful to create it eagerly. Initializing a ListHashSet
is expensive because a ListHashSet initially has space for 256
elements, and that space is memset to 0.
This change should improve performance but have no impact on
correctness. On x86-64, for example, the change cuts the
cost of HitTestResult(IntPoint()) in EventHandler::mouseMoved()
from ~1700 cycles to ~300 cycles.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0
(WebCore::HitTestResult::operator=): copy *m_rectBasedTestResult if m_rectBasedTestResult isn't 0
(WebCore::HitTestResult::addNodeToRectBasedTestResult): use mutableRectBasedTestResult() rather than m_rectBasedTestResult
(WebCore::HitTestResult::append): append *(other.m_rectBasedTestResult) if other.m_rectBasedTestResult isn't 0
* rendering/HitTestResult.h:
(WebCore::HitTestResult::rectBasedTestResult): Add a typedef for ListHashSet<RefPtr<Node> > to ease readability. Change m_rectBasedTestResult from ListHashSet<RefPtr<Node> > to an OwnPtr of same. Modify rectBasedTestResult() and add mutableRectBasedTestResult().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 29 Mar 2011 22:45:58 +0000 (22:45 +0000)]
2011-03-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57394
Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
* DumpRenderTree/win/ImageDiff.vcproj:
* DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
* DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
* DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
* DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
* DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
* DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
* FindSafari/FindSafari.vcproj:
* FindSafari/FindSafariDebug.vsprops: Added.
* FindSafari/FindSafariDebugAll.vsprops: Added.
* FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
* FindSafari/FindSafariRelease.vsprops: Added.
* FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
* FindSafari/FindSafariReleaseLTCG.vsprops: Added.
* FindSafari/FindSafariReleasePGO.vsprops: Added.
* MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
* MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
* MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
* MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
* MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
* MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
* MiniBrowser/MiniBrowser.vcproj:
* WebKitAPITest/WebKitAPITest.vcproj:
* WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
* WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
* WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
* WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
* WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
* WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
* WebKitLauncherWin/WebKitLauncherWin.vcproj:
* WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
* WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
* WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
* WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
* WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
* WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
* WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
* WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
* WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
* WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
* WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
* WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
* WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
* WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
* WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
* WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
* WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
* WinLauncher/WinLauncher.vcproj:
* WinLauncher/WinLauncherDebug.vsprops: Added.
* WinLauncher/WinLauncherDebugAll.vsprops: Added.
* WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
* WinLauncher/WinLauncherRelease.vsprops: Added.
* WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
* WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
* record-memory-win/record-memory-win.vcproj:
* record-memory-win/record-memory-winDebug.vsprops: Added.
* record-memory-win/record-memory-winDebugAll.vsprops: Added.
* record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
* record-memory-win/record-memory-winRelease.vsprops: Added.
* record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
* record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 22:44:42 +0000 (22:44 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Moar pixel expectations.
* platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
* platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
* platform/chromium-mac/editing/deleting/
4845371-expected.checksum: Added.
* platform/chromium-mac/editing/deleting/
4845371-expected.png: Added.
* platform/chromium-mac/editing/deleting/
5126166-expected.checksum: Added.
* platform/chromium-mac/editing/deleting/
5126166-expected.png: Added.
* platform/chromium-mac/editing/deleting/
5483370-expected.checksum: Added.
* platform/chromium-mac/editing/deleting/
5483370-expected.png: Added.
* platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
* platform/chromium-mac/editing/deleting/table-cells-expected.png: Added.
* platform/chromium-mac/editing/inserting/
4875189-2-expected.checksum: Added.
* platform/chromium-mac/editing/inserting/
4875189-2-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/
5387578-expected.checksum: Added.
* platform/chromium-mac/editing/pasteboard/
5387578-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
* platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum:
* platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
* platform/chromium-mac/fast/block/float/014-expected.checksum:
* platform/chromium-mac/fast/block/float/014-expected.png:
* platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Added.
* platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Added.
* platform/chromium-mac/fast/blockflow/background-vertical-rl-expected.png: Added.
* platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Added.
* platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png: Added.
* platform/chromium-mac/fast/canvas/canvas-zoom-expected.checksum: Added.
* platform/chromium-mac/fast/canvas/canvas-zoom-expected.png: Added.
* platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum:
* platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
* platform/chromium-mac/fast/forms/input-align-image-expected.png: Added.
* platform/chromium-mac/fast/forms/input-type-change-expected.png: Added.
* platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
* platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png: Added.
* platform/chromium-mac/fast/images/icon-decoding-expected.png: Added.
* platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
* platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png:
* platform/chromium-mac/fast/inline-block: Added.
* platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
* platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
* platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Added.
* platform/chromium-mac/fast/inline/inline-focus-ring-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 29 Mar 2011 22:40:26 +0000 (22:40 +0000)]
Update the order of the context menu to better match AppKit on Mac.
<rdar://problem/
9054893>
Reviewed by John Sullivan.
Source/WebCore:
* English.lproj/Localizable.strings: Updated.
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate): Update the order of items on Mac.
* platform/LocalizationStrategy.h:
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
* platform/LocalizedStrings.h:
* platform/android/LocalizedStringsAndroid.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/brew/LocalizedStringsBrew.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/haiku/LocalizedStringsHaiku.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
* platform/wx/LocalizedStringsWx.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary): Ditto.
Source/WebKit/mac:
* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
Source/WebKit2:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 29 Mar 2011 22:30:06 +0000 (22:30 +0000)]
Fix formatting of WebKit2.vcproj after r82283.
* win/WebKit2.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 29 Mar 2011 22:23:58 +0000 (22:23 +0000)]
2011-03-29 Dean Jackson <dino@apple.com>
Reviewed by Chris Marrin and Ken Russell.
https://bugs.webkit.org/show_bug.cgi?id=57248
Occlusion issues with WebGL in Safari
The depth buffer on Safari ports was being set up with a
maximum of 16 bits. Now we use a combined 24/8 depth/stencil
buffer on Mac ports.
No new tests as this is the setting for a particular port. Other
ports may use different defaults.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
- use Extensions3D to test for depth and multisample extensions
rather than querying OpenGL directly.
(WebCore::GraphicsContext3D::reshape):
- use a 24bit depth buffer when the extension is enabled.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 29 Mar 2011 22:15:19 +0000 (22:15 +0000)]
2011-03-29 Dimitri Glazkov <dglazkov@chromium.org>
Sorted XCode project. It's gotten quite out of sorts.
* WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 22:12:05 +0000 (22:12 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Previously, I forgot to update the rendertree expectations.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Tue, 29 Mar 2011 22:10:11 +0000 (22:10 +0000)]
2011-03-29 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
DatasetDOMStringMap::item and ::contains copies attribute name string
https://bugs.webkit.org/show_bug.cgi?id=55645
* fast/dom/script-tests/dataset-expected.txt:
* fast/dom/script-tests/dataset.js:
Added extra test cases for getting fields by property name.
2011-03-29 Emil A Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
DatasetDOMStringMap::item and ::contains copies attribute name string
https://bugs.webkit.org/show_bug.cgi?id=55645
Change propertyNameMatchesAttributeName to match without creating a copy
of the string.
* dom/DatasetDOMStringMap.cpp:
(WebCore::propertyNameMatchesAttributeName):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 22:02:10 +0000 (22:02 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Update expected results now that we don't have a scrollbar to worry about.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.checksum:
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 29 Mar 2011 22:00:21 +0000 (22:00 +0000)]
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Try to fix Windows build.
* DOMEventsClasses.cpp: Added initguid.h again.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 22:00:20 +0000 (22:00 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
test_runner2.py can crash due to undefined variable
https://bugs.webkit.org/show_bug.cgi?id=57356
Replace reference to undefined variable with a variable that's actually
defined. AFAICT, there's no way to test this code.
* Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 21:57:50 +0000 (21:57 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Update expectations.
* platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/margin-collapse-expected.png: Added.
* platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/max-height-columns-block-expected.png: Added.
* platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/positioned-split-expected.png: Added.
* platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/single-line-expected.png: Added.
* platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/table-margin-collapse-expected.png: Added.
* platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
* platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum:
* platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
* platform/chromium-mac/fast/replaced/image-onload-expected.checksum:
* platform/chromium-mac/fast/replaced/image-onload-expected.png:
* platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
* platform/chromium-mac/fast/replaced/image-sizing-expected.png:
* platform/chromium-mac/fast/replaced/image-tag-expected.png: Added.
* platform/chromium-mac/fast/text/basic/002-expected.checksum: Added.
* platform/chromium-mac/fast/text/basic/002-expected.png: Added.
* platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
* platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.png: Added.
* platform/chromium-mac/media/video-transformed-expected.checksum: Added.
* platform/chromium-mac/media/video-transformed-expected.png: Added.
* platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
* platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
* platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
* platform/chromium-mac/svg/custom/focus-ring-expected.png:
* platform/chromium-mac/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
* platform/chromium-mac/svg/custom/use-in-symbol-with-offset-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
* platform/chromium-mac/svg/filters/filterRes-expected.checksum: Added.
* platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
* platform/chromium-mac/svg/filters/filteredImage-expected.png: Added.
* platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
* platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.png: Added.
* platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 29 Mar 2011 21:50:52 +0000 (21:50 +0000)]
2011-03-29 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
~25% regression on v8-splay in the SunSpider harness
https://bugs.webkit.org/show_bug.cgi?id=56128
I'm not sure if this is the root cause of the regression Stephanie
measured, but it seems to get us back to previous v8-splay times.
SunSpider reports no change. v8-splay says 41% faster.
* runtime/Heap.cpp:
(JSC::Heap::reset): Make marking proportional to 1X the size of the heap,
not .5X the size of the heap. When the heap is large, this makes a big
difference. (Our old heap growth policy matched this. You can see by
looking at resizeBlocks in revisions prior to r77699.)
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 29 Mar 2011 21:46:03 +0000 (21:46 +0000)]
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Cleanup includes in WebKit files
https://bugs.webkit.org/show_bug.cgi?id=57381
Add missing includes to fix build without precompiled header.
Also fix paths in #include statements (e.g. WTF -> wtf).
* AccessibleBase.h:
* AccessibleDocument.h: Replace using statement with a qualified name.
* CFDictionaryPropertyBag.h:
* DOMEventsClasses.cpp:
* DOMHTMLClasses.h:
* DefaultDownloadDelegate.cpp:
* DefaultDownloadDelegate.h:
* DefaultPolicyDelegate.cpp:
* DefaultPolicyDelegate.h:
* WebCoreSupport/EmbeddedWidget.h:
* WebCoreSupport/WebInspectorDelegate.h:
* WebDataSource.h:
* WebDatabaseManager.h:
* WebElementPropertyBag.h:
* WebFramePolicyListener.h:
* WebGeolocationPolicyListener.h:
* WebHistory.h:
* WebKitClassFactory.h:
* WebScriptWorld.h:
* WebSerializedJSValue.h:
* WebUserContentURLPattern.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 21:33:18 +0000 (21:33 +0000)]
2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82293.
http://trac.webkit.org/changeset/82293
https://bugs.webkit.org/show_bug.cgi?id=57390
Breaks RetrieveCSSResources (Requested by abarth|gardener on
#webkit).
* WebKit.gyp:
* src/WebPageSerializer.cpp:
(WebCore::getSubResourceURLFromElement):
(WebCore::retrieveResourcesForElement):
(WebCore::retrieveResourcesForFrame):
(WebKit::WebPageSerializer::retrieveAllResources):
* tests/WebPageSerializerTest.cpp:
* tests/data/pageserialization/css_test_page.html: Removed.
* tests/data/pageserialization/import_style_from_link.css: Removed.
* tests/data/pageserialization/import_styles.css: Removed.
* tests/data/pageserialization/link_styles.css: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 21:29:59 +0000 (21:29 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Green means pass, AFAICT.
* platform/chromium-mac/fast/media/media-query-invalid-value-expected.png: Added.
* platform/chromium-win/fast/media/media-query-invalid-value-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 21:24:56 +0000 (21:24 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Update image result due to different text metrics.
* platform/chromium-win/printing/return-from-printing-mode-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 29 Mar 2011 21:21:00 +0000 (21:21 +0000)]
2011-03-29 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
cleanup rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=57375
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Split _extract_and_add_new_baselines into 3 functions
- Reduce the amount of line wrapping (the file already has lines
over 80 col, so may as well try to make the file consistent)
- Remove unnecessary ()s
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 21:17:07 +0000 (21:17 +0000)]
2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82317.
http://trac.webkit.org/changeset/82317
https://bugs.webkit.org/show_bug.cgi?id=57387
We do not need these baselines anymore (Requested by
abarth|gardener on #webkit).
* platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.checksum: Removed.
* platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 29 Mar 2011 21:12:38 +0000 (21:12 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=57379
Clean up WK1 key event handling logic
No bugs knowingly fixed, but this makes the code more consistent.
* WebView/WebHTMLView.mm:
(struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
(-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
from other functions. We need to execute saved commands when an input method asks for current
state, because providing stale state could confuse it.
(-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
changes.
(-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
the answer would be stale.
(-[WebHTMLView firstRectForCharacterRange:]): Ditto.
(-[WebHTMLView selectedRange]): Ditto.
(-[WebHTMLView markedRange]): Ditto.
(-[WebHTMLView attributedSubstringFromRange:]): Ditto.
(-[WebHTMLView hasMarkedText]): Ditto.
(-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
operating on stale data. Also, updated for eventWasHandled renaming.
(-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
(-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
could have a noop: as one of its commands, although that's hardly practical).
Added the same "from input method" logic that we have in insertText: - I don't know of any
IMs that call this method, but we clearly need to execute it as part of IM processing when
there is marked text.
(-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
if current selection isn't editable. This is different from doCommandBySelector:, where we
need to give super class a chance to handle the event if our processing fails.
Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
return value of _interpretKeyEvent is computed differently.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 21:10:30 +0000 (21:10 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Set overflow: hidden so we don't need to have scrollbars in the
results. I've tested that this still shows what looks like the
intended behavior difference before and after the test.
* fast/block/float/float-forced-below-other-floats.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 29 Mar 2011 21:05:11 +0000 (21:05 +0000)]
2011-03-29 Martin Robinson <mrobinson@igalia.com>
[GTK] Build failed with ‘GDK_KEY_KP_Space’ was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=55314
Build fix for older versions of GTK+. Use the deprecated names for GDK key
defines and include GtkVersioning.h to allow building on newer versions
of GTK+.
* Shared/gtk/WebEventFactory.cpp:
(WebKit::isGdkKeyCodeFromKeyPad): Update key defines.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 21:04:11 +0000 (21:04 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Scrollbars are different on different platforms. Including scrollbars
in tests that don't need them is sadness.
* platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
* platform/chromium-linux/fast/block/float/float-forced-below-other-floats-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 29 Mar 2011 20:55:47 +0000 (20:55 +0000)]
Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57383
Reviewed by Darin Adler.
Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.
Source/WebKit/win:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesDebug.vsprops: Added.
* WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
* WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/InterfacesRelease.vsprops: Added.
* WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
* WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
* WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
* WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
* WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
* WebKit.vcproj/WebKitLibDebug.vsprops: Added.
* WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
* WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitLibRelease.vsprops: Added.
* WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.
Source/WebKit2:
* win/WebKit2.vcproj:
* win/WebKit2Debug.vsprops: Added.
* win/WebKit2DebugAll.vsprops: Added.
* win/WebKit2DebugCairoCFLite.vsprops: Added.
* win/WebKit2Release.vsprops: Added.
* win/WebKit2ReleaseCairoCFLite.vsprops: Added.
* win/WebKit2ReleaseLTCG.vsprops: Added.
* win/WebKit2WebProcess.vcproj:
* win/WebKit2WebProcessDebug.vsprops: Added.
* win/WebKit2WebProcessDebugAll.vsprops: Added.
* win/WebKit2WebProcessDebugCairoCFLite.vsprops: Added.
* win/WebKit2WebProcessRelease.vsprops: Added.
* win/WebKit2WebProcessReleaseCairoCFLite.vsprops: Added.
* win/WebKit2WebProcessReleaseLTCG.vsprops: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 29 Mar 2011 20:55:27 +0000 (20:55 +0000)]
Unreviewed rollout r82282, part of r82288, r82298.
Source/WebCore:
* css/CSSParser.cpp:
(WebCore::parseColorInt):
(WebCore::isValidDouble):
(WebCore::parseAlphaValue):
(WebCore::CSSParser::parseColor):
LayoutTests:
* fast/canvas/rgba-parsing-expected.txt:
* fast/canvas/script-tests/rgba-parsing.js:
* platform/chromium-mac/fast/canvas/rgba-parsing-expected.txt: Removed.
* platform/chromium-win/fast/canvas/rgba-parsing-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 29 Mar 2011 20:54:15 +0000 (20:54 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55981
Second round of clean-ups, aimed at supporting GTK with the
same unified FontPlatformData header. This version removes
some unneeded WinCairo code, and aligns the WinCairo and
GTK ports to reduce code duplication.
Reviewed by Dave Hyatt.
* WebCore.vcproj/WebCore.vcproj: Get rid of a dangling reference
to an old WinCairo file.
* platform/graphics/FontPlatformData.h: Remove unneeded member
for m_fontFace, which is a member of m_scaledFont. Switch to
standard Cairo hashing.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::FontPlatformData::hashTableDeletedFontValue):
* platform/graphics/win/FontCacheWin.cpp: Update to no longer use
the unnecessary fontFace() accessor.
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
* platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 29 Mar 2011 20:53:32 +0000 (20:53 +0000)]
Make WinCairo a core builder.
https://bugs.webkit.org/show_bug.cgi?id=57373
Reviewed by Adam Roben.
* Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 29 Mar 2011 20:45:20 +0000 (20:45 +0000)]
WebKit2: The WebProcess should be relaunched if necessary when WebKit2 is asked for
information about Cookies, Databases, Local Storage, etc.
https://bugs.webkit.org/show_bug.cgi?id=57374
Reviewed by Anders Carlsson.
Instead of bailing when the WebProcess is not valid, call relaunchProcessIfNecessary().
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 29 Mar 2011 20:37:52 +0000 (20:37 +0000)]
Inline worker powered by blob URL does not work with files URL even if
allowFileAccessFromFileURLs is enabled
https://bugs.webkit.org/show_bug.cgi?id=56063
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/files/workers/inline-worker-via-blob-url.html
* fileapi/BlobURL.cpp: Removed unneeded getOrigin() method.
* fileapi/BlobURL.h: Removed unneeded getOrigin() method.
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin): Extended the logic to handle
filesystem URL also to blob URL. Also fixed the problem that m_isUnique
is incorrectly set for blob and filesystem URLs.
(WebCore::SecurityOrigin::create): Removed the special logic for blob URL
since we use the same logic in SecurityOrigin constructor as filesystem
URL.
(WebCore::SecurityOrigin::canRequest): Removed the special logic for blob
URL since it is not needed with the fix in SecurityOrigin constructor.
LayoutTests:
* fast/files/workers/inline-worker-via-blob-url-expected.txt: Added.
* fast/files/workers/inline-worker-via-blob-url.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 29 Mar 2011 20:27:12 +0000 (20:27 +0000)]
2011-03-29 Tony Chang <tony@chromium.org>
Roll chromium version to r79710 to pick up libpng changes.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 29 Mar 2011 20:25:55 +0000 (20:25 +0000)]
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
WebKit2: Support setting the client certificate on Windows
https://bugs.webkit.org/show_bug.cgi?id=57368
Allow setting the client certificate for a host via the injected bundle.
This requires the ability for Webkit2 Windows clients to create a WKCertificateInfo from a PCCERT_CONTEXT so they can send it to the web process.
* Shared/API/c/win/WKCertificateInfoWin.cpp:
(WKCertificateInfoCreateWithCertificate): Added.
* Shared/API/c/win/WKCertificateInfoWin.h: Added WKCertificateInfoCreateWithCertificate().
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetClientCertificate): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetClientCertificate().
* WebProcess/InjectedBundle/InjectedBundle.h: Added setClientCertificate().
* WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
* WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added, should never be called.
* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setClientCertificate): Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 29 Mar 2011 20:24:59 +0000 (20:24 +0000)]
Make WebCore and WebKit2 work with update-webkit-localizable-strings.
Source/WebCore: Update WebCore Localizable.strings to contain WebCore, WebKit/mac and WebKit2 strings.
https://webkit.org/b/57354
Reviewed by Sam Weinig.
* English.lproj/Localizable.strings: Updated.
* StringsNotToBeLocalized.txt: Removed. To hard to maintain in WebCore.
* platform/network/cf/LoaderRunLoopCF.h: Remove a single quote in an #error so
extract-localizable-strings does not complain about unbalanced single quotes.
Source/WebKit: Update WebKit Localizable.strings to only contain WebKit/win strings.
https://webkit.org/b/57354
Reviewed by Sam Weinig.
* English.lproj/Localizable.strings: Updated.
Source/WebKit2: Make WebKit2 work with update-webkit-localizable-strings.
https://webkit.org/b/57354
Reviewed by Sam Weinig.
* PluginProcess/mac/PluginProcessMac.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
* Shared/WebLocalizableStrings.h: Added.
* UIProcess/API/mac/WKView.mm: Remove UI_STRING macro. Use WebLocalizableStrings.h.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Use UI_STRING. Remove FIXME.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Remove UI_STRING macros.
Use WebLocalizableStrings.h.
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(registerErrors): Remove UI_STRING macro. Use WebLocalizableStrings.h.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Use UI_STRING. Remove FIXME.
* GNUmakefile.am: Added Shared/WebLocalizableStrings.h.
* WebKit2.pro: Ditto.
* WebKit2.xcodeproj/project.pbxproj: Ditto.
* win/WebKit2.vcproj: Ditto.
Tools: Update update-webkit-localizable-strings to understand that WebKit and
WebKit2 strings go in WebCore.
Also make extract-localizable-strings optionally use an exclude file. No individual
warnings are produced about unlocalized strings when there is no exclude file. This
is needed for WebCore, since there are too many bare strings.
https://webkit.org/b/57354
Reviewed by Sam Weinig.
* Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
* Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 20:18:53 +0000 (20:18 +0000)]
2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82295 and r82300.
http://trac.webkit.org/changeset/82295
http://trac.webkit.org/changeset/82300
https://bugs.webkit.org/show_bug.cgi?id=57380
This patch breaks compile on Chromium (Requested by
abarth|gardener on #webkit).
* platform/gtk/accessibility/aria-roles-unignored-expected.txt: Removed.
* platform/gtk/accessibility/aria-roles-unignored.html: Removed.
2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82295 and r82300.
http://trac.webkit.org/changeset/82295
http://trac.webkit.org/changeset/82300
https://bugs.webkit.org/show_bug.cgi?id=57380
This patch breaks compile on Chromium (Requested by
abarth|gardener on #webkit).
* public/WebAccessibilityRole.h:
* src/AssertMatchingEnums.cpp:
2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82295 and r82300.
http://trac.webkit.org/changeset/82295
http://trac.webkit.org/changeset/82300
https://bugs.webkit.org/show_bug.cgi?id=57380
This patch breaks compile on Chromium (Requested by
abarth|gardener on #webkit).
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole):
(webkit_accessible_get_role):
* accessibility/mac/AccessibilityObjectWrapper.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 29 Mar 2011 20:10:56 +0000 (20:10 +0000)]
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
CoreIPC::decodeResourceError() leaks a CFDataRef
https://bugs.webkit.org/show_bug.cgi?id=57366
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::decodeResourceError): Don't leak the result of WebCore::copyCertificateToData(), since the ResourceError will retain it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 29 Mar 2011 20:10:28 +0000 (20:10 +0000)]
Fix clang build.
* platform/text/BidiResolver.h:
(WebCore::::createBidiRunsForLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 29 Mar 2011 20:07:15 +0000 (20:07 +0000)]
Use per-configuration vsprops in WebCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57378
Reviewed by Adam Roben.
Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/QTMovieWinDebug.vsprops: Added.
* WebCore.vcproj/QTMovieWinDebugAll.vsprops: Added.
* WebCore.vcproj/QTMovieWinDebugCairoCFLite.vsprops: Added.
* WebCore.vcproj/QTMovieWinRelease.vsprops: Added.
* WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops: Added.
* WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Added.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreDebug.vsprops: Added.
* WebCore.vcproj/WebCoreDebugAll.vsprops: Added.
* WebCore.vcproj/WebCoreDebugCairoCFLite.vsprops: Added.
* WebCore.vcproj/WebCoreRelease.vsprops: Added.
* WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops: Added.
* WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 29 Mar 2011 19:47:35 +0000 (19:47 +0000)]
<rdar://problem/
9194927> REGRESSION (r81691): Page at mondaynote.com lays out incorrectly
Reviewed by Simon Fraser.
Back out the optimization that stopped when it hit the first float. This was an incorrect optimization
and can't be done without more work.
Source/WebCore:
Added fast/block/float/float-forced-below-other-floats.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
LayoutTests:
Added fast/block/float/float-below-other-floats.html
* fast/block/float/float-forced-below-other-floats.html: Added.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.checksum: Added.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.png: Added.
* platform/mac/fast/block/float/float-forced-below-other-floats-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 29 Mar 2011 19:43:22 +0000 (19:43 +0000)]
WebKit2 bundle page needs to offer generated file hooks
https://bugs.webkit.org/show_bug.cgi?id=57279
Patch by Darin Adler <darin@apple.com> on 2011-03-29
Reviewed by Adam Roben.
(Land missing part of the original patch after r82289.)
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 29 Mar 2011 19:43:15 +0000 (19:43 +0000)]
Add passing results for a test that passes in WebKit2 but not WebKit1
The WebKit1 failure is tracked by <http://webkit.org/b/57334>.
* platform/win-wk2/http/tests/uri/username-with-no-hostname-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 29 Mar 2011 19:38:47 +0000 (19:38 +0000)]
2011-03-29 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Adam Barth.
REGRESSION(r82295): This patch does not compile on Chromium (Requested by abarth|gardener on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57377
Fix build errors on Chromium bots.
* public/WebAccessibilityRole.h: Update to reflect newly added roles in WebCore.
* src/AssertMatchingEnums.cpp: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 29 Mar 2011 19:09:06 +0000 (19:09 +0000)]
2011-03-29 Adam Barth <abarth@webkit.org>
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=57361
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc