14 years agowx build fix. Make sure we link png/jpeg libraries before wx libraries to get the...
kevino@webkit.org [Mon, 17 Mar 2008 03:59:25 +0000 (03:59 +0000)]
wx build fix. Make sure we link png/jpeg libraries before wx libraries to get the right symbols.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mjs@apple.com [Mon, 17 Mar 2008 03:50:33 +0000 (03:50 +0000)]

2008-03-16  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - fixed "Acid3 expects different exceptions for surroundContents calls involving comment nodes (affects Acid3 test 11)"

        This gets us to 92/100

        * dom/Range.cpp:
        (WebCore::Range::surroundContents): Check for
        expects exceptional conditions to be tested in the order that the
        spec lists them. Also, adjust the HIERARCHY_REQUEST_ERR check. If
        the start point of the range is in a comment node, the node that
        would be the parent of a partial replacement is actually the
        comment node's parent (since comment nodes have character
        indices), so we should do the HIERARCHY_REQUEST_ERR check based on
        the parent of the comment node, as for text nodes, even though it
        will fail later with a different exception because it is not
        allowed to surround a partially selected non-text node.


2008-03-16  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - test for "Acid3 expects different exceptions for surroundContents calls involving comment nodes (affects Acid3 test 11)"

        * fast/dom/Range/acid3-surround-contents-expected.txt: Added.
        * fast/dom/Range/acid3-surround-contents.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Mon, 17 Mar 2008 03:47:03 +0000 (03:47 +0000)]

2008-03-16  Marvin Decker  <marv.decker@gmail.com>

        Reviewed by Darin.

        Fix bug 15119: URL query characters that are unencodable in the
        request's character set should be converted to XML entities with
        non-alphanumeric characters escaped.

        Test: http/tests/uri/escaped-entity.html

        * html/FormDataList.cpp:
        * html/HTMLFormElement.cpp:
        * platform/KURL.cpp:
        * platform/text/String.cpp:
        * platform/text/TextCodec.cpp:
        * platform/text/TextCodec.h:
        * platform/text/TextCodecICU.cpp:
        * platform/text/TextCodecICU.h:
        * platform/text/TextCodecLatin1.cpp:
        * platform/text/TextCodecLatin1.h:
        * platform/text/TextCodecUTF16.cpp:
        * platform/text/TextCodecUTF16.h:
        * platform/text/TextCodecUserDefined.cpp:
        * platform/text/TextCodecUserDefined.h:
        * platform/text/TextEncoding.cpp:
        * platform/text/TextEncoding.h:
        * platform/text/mac/TextCodecMac.cpp:
        * platform/text/mac/TextCodecMac.h:
        * xml/XMLHttpRequest.cpp:


2008-03-16  Marvin Decker  <marv.decker@gmail.com>

        Reviewed by Darin.

        Fix bug 15119, unencodable characters in URLs should be entity-escaped.

        * http/tests/uri/escaped-entity-expected.txt: Added.
        * http/tests/uri/escaped-entity.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago 2008-03-16 weihongzeng <weihong.zeng@hotmail.com>
darin@apple.com [Mon, 17 Mar 2008 03:26:42 +0000 (03:26 +0000)]
 2008-03-16  weihongzeng  <weihong.zeng@hotmail.com>

         Reviewed by Darin Adler.

         Add support for mixed-endian processors

         * kjs/dtoa.cpp: Add IEEE_ARM, triggered by PLATFORM(MIDDLE_ENDIAN).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRubber stamped by Darin.
kevino@webkit.org [Mon, 17 Mar 2008 01:29:36 +0000 (01:29 +0000)]
Rubber stamped by Darin.

Add set-webkit-configuration support for wx port, and centralize build dir location setting.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 16 Mar 2008 22:21:34 +0000 (22:21 +0000)]

2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        - http://bugs.webkit.org/show_bug.cgi?id=17881
          a little cleanup for HTMLTextAreaElement

        Tests: fast/forms/textarea-default-value-leading-newline.html

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Tweaked names/
        (WebCore::HTMLTextAreaElement::selectionStart): Ditto, also use early return
        and check for < 0 rather than -1 specifically.
        (WebCore::HTMLTextAreaElement::selectionEnd): Ditto.
        (WebCore::HTMLTextAreaElement::setSelectionStart): Early return.
        (WebCore::HTMLTextAreaElement::setSelectionEnd): Ditto.
        (WebCore::HTMLTextAreaElement::select): Ditto.
        (WebCore::HTMLTextAreaElement::setSelectionRange): Ditto.
        (WebCore::HTMLTextAreaElement::parseMappedAttribute): Changed value parsing
        to treat unknown values as meaning "default" rather than "leave value as-is".
        Only call setNeedsLayoutAndPrefWidthsRecalc when mode changed.
        (WebCore::HTMLTextAreaElement::createRenderer): Removed name of unused argument.
        (WebCore::HTMLTextAreaElement::appendFormData): Updated for name changes.
        (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Got rid of unnneeded explicit
        class name in isFocusable call.
        (WebCore::HTMLTextAreaElement::isMouseFocusable): Ditto.
        (WebCore::HTMLTextAreaElement::updateFocusAppearance): Tweaked formatting.
        (WebCore::HTMLTextAreaElement::defaultEventHandler): Ditto.
        (WebCore::HTMLTextAreaElement::updateValue): Early return.
        (WebCore::HTMLTextAreaElement::setValue): Got rid of intermediate value to
        eliminate on small refcount churn.
        (WebCore::HTMLTextAreaElement::defaultValue): Got rid of unneeded redundant
        string length checks, since String already checks all indexing and returns 0.
        (WebCore::HTMLTextAreaElement::setDefaultValue): Added code to normalize
        line endings and add a leading line ending to fix cases where the first
        character is a newline.
        (WebCore::HTMLTextAreaElement::accessKeyAction): Removed name of unused arg.
        (WebCore::HTMLTextAreaElement::accessKey): Changed return value to avoid
        refcount churn.
        (WebCore::HTMLTextAreaElement::selection): Updated names and use < 0 instead
        of -1 specifically.

        * html/HTMLTextAreaElement.h: Replaced wrap function with more-specific
        shouldWrapText one. Changed return value of accessKey. Made WrapMethod enum
        provate and renamed the values. Renamed cachedSelStart and cachedSelEnd to
        m_cachedSelectionStart and m_cachedSelectionEnd.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createInnerTextStyle): Updated for change to
        HTMLTextAreaElement wrap function.


2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        - test for bug fixes in http://bugs.webkit.org/show_bug.cgi?id=17881
          a little cleanup for HTMLTextAreaElement

        * fast/forms/textarea-default-value-leading-newline-expected.txt: Added.
        * fast/forms/textarea-default-value-leading-newline.html: Copied from fast/forms/textarea-crlf.html.

        * fast/forms/textarea-hard-linewrap-expected.txt: Updated.
        * fast/forms/textarea-hard-linewrap.html: Cleaned up a bit.

        * fast/forms/textarea-linewrap-dynamic-expected.txt: Added.
        * fast/forms/textarea-linewrap-dynamic.html: Copied from fast/forms/textarea-hard-linewrap.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
antti@apple.com [Sun, 16 Mar 2008 21:47:50 +0000 (21:47 +0000)]
    Reviewed by Mitz.

        Fix http/tests/security/frame-loading-via-document-write.html
        which was broken by the preload patch.

        Don't print error message when preload fails local file security check.
        Some minor refactoring.

        * html/PreloadScanner.cpp:
        * loader/Cache.cpp:
        * loader/Cache.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti@apple.com [Sun, 16 Mar 2008 20:53:39 +0000 (20:53 +0000)]

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=17862
        REGRESSION (r31038): Reproducible crash under DocLoader::checkForReload() at marware.com

        This was a memory smasher introduced by the preloading patch.
        If a script resource was marked uncacheable, early deletion of the
        Request object would cause deletion of the CachedResource too if
        it was referred more than once in a single document.

        Test: http/tests/misc/uncacheable-script-repeated.html

        * loader/loader.cpp:


        Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=17862
        REGRESSION (r31038): Reproducible crash under DocLoader::checkForReload() at marware.com

        * http/tests/misc/resources/uncacheable-script.cgi: Added.
        * http/tests/misc/uncacheable-script-repeated-expected.txt: Added.
        * http/tests/misc/uncacheable-script-repeated.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 16 Mar 2008 20:35:31 +0000 (20:35 +0000)]

2008-03-16  Yuzhu Shen  <yuzhu.shen@gmail.com>

        Reviewed by Darin.

        Fix bug http://bugs.webkit.org/show_bug.cgi?id=17714
        <img href="#"> should go to top of the page.

        Test: fast/html/empty-fragment-id-goto-top.html

        * loader/FrameLoader.cpp:


2008-03-16  Yuzhu Shen  <yuzhu.shen@gmail.com>

        Reviewed by Darin.

        Bug: http://bugs.webkit.org/show_bug.cgi?id=17714
        Test whether clicking <img href="#"> goes to top of the page.

        * fast/html/empty-fragment-id-goto-top-expected.txt: Added.
        * fast/html/empty-fragment-id-goto-top.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 16 Mar 2008 20:25:40 +0000 (20:25 +0000)]

2008-03-16  Thiago Macieira  <thiago.macieira@trolltech.com>

        Reviewed by Darin.

        Don't use RefPtr in classes you haven't seen the implementation of.

        Forward-declaration and declaration of RefPtr<Foo> is ok. But you
        cannot *use* said objects until Foo is defined. This is true even for
        initialisation with a 0.

        Seems the HP aCC compiler is more strict here than gcc.

        * editing/SplitTextNodeCommand.h:
        * page/FrameTree.h:
        * xml/XPathExpressionNode.h:


2008-03-16  Thiago Macieira  <thiago.macieira@trolltech.com>

        Reviewed by Simon.

        Don't use RefPtr in classes you haven't seen the implementation of.

        Forward-declaration and declaration of RefPtr<Foo> is ok. But you
        cannot *use* said objects until Foo is defined. This is true even for
        initialisation with a 0.

        Seems the HP aCC compiler is more strict here than gcc.

        * Api/qwebframe_p.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sun, 16 Mar 2008 20:17:54 +0000 (20:17 +0000)]

2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14941
          <rdar://problem/5404093> textarea value from JavaScript includes extra newline

        Test: fast/forms/textarea-trailing-newline.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::finishText): Added code to strip the trailing
        newline. It's possible there are some obscure cases where this is not wanted,
        but I couldn't find any. If someone finds a case where this is bad, we can
        make the code conditional.


2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14941
          <rdar://problem/5404093> textarea value from JavaScript includes extra newline

        * fast/forms/textarea-paste-newline.html: Updated test to expect correct behavior instead
        of expecting the bug.

        * fast/forms/textarea-trailing-newline-expected.txt: Added.
        * fast/forms/textarea-trailing-newline.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-16 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 16 Mar 2008 20:15:41 +0000 (20:15 +0000)]
2008-03-16  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17876
          Attempting to visit Ofcom page causes crash

        This is causing intermittent crashes on some existing test cases on the buildbot
        too; I don't have a 100% test case right now, but it should be easy to add one later
        and this does fix a crash in a test we already have.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::CharacterData): Initialize m_data to the empty string,
        not the null string. The class assumes the string can never being null.
        (WebCore::CharacterData::setData): If asked to set the data to the null string,
        set it to the empty string instead. This matches what the (non-empty) constructor
        has always done.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
timothy@apple.com [Sun, 16 Mar 2008 06:34:10 +0000 (06:34 +0000)]
    Reviewed by Adam Roben.

        Bug 17870: Web Inspector console should feel more like a terminal

        Bug 14390: Console input area should be more noticeable

        Adds tab completion, auto completion and a blended input prompt.
        The prompt is also focused when the console is shown.
           Implements a new look, that will be part of the UI refresh.

        * page/inspector/ConsolePanel.js:
        (WebInspector.ConsolePanel): Renamed a few properties.
        (WebInspector.ConsolePanel.get/set promptText): Property to set
        and get the current prompt text. Does not affect command history.
        (WebInspector.ConsolePanel.show): Make the prompt focus on show.
        (WebInspector.ConsolePanel.acceptAutoComplete): Accepts any
        pending auto complete text.
        (WebInspector.ConsolePanel.clearAutoComplete): Cancels any pending
        auto complete text.
        (WebInspector.ConsolePanel.autoCompleteSoon): Sets a timeout to auto
        complete in 250 ms, only if there isn't a pending auto complete.
        (WebInspector.ConsolePanel.completions): Generate a list of possible
        completions based on the prefix and the previous expression ranges.
        (WebInspector.ConsolePanel._backwardsRange): Helper to scan backwards
        from a node and offset to find a start node and offset of the first
        character found in the characters string.
        (WebInspector.ConsolePanel._evalInInspectedWindow): Helper to eval in the
        inspected window.
        (WebInspector.ConsolePanel._caretInsidePrompt): Returns true if the selection
        is collapsed and is inside the prompt element.
        (WebInspector.ConsolePanel._moveCaretToEndOfPrompt): Moves the selection
        to the end of the prompt.
        (WebInspector.ConsolePanel._onTabPressed): Calls complete on
        tab press.
        (WebInspector.ConsolePanel._onEnterPressed): Call clearAutoComplete so the
        autocompletion text is not evaluated.

        * page/inspector/Images/errorIcon.png: New image.
        * page/inspector/Images/userInputIcon.png: Added.
        * page/inspector/Images/userInputPreviousIcon.png: Added.
        * page/inspector/Images/warningIcon.png: New image.
        * page/inspector/inspector.css: New refreshed UI.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-15 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sat, 15 Mar 2008 19:12:45 +0000 (19:12 +0000)]
2008-03-15  Matt Lilek  <webkit@mattlilek.com>

        Rubber-stamped by Mitz.

        Update crash log page with instructions for Leopard.

        * quality/crashlogs.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-15 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 15 Mar 2008 17:49:29 +0000 (17:49 +0000)]
2008-03-15  Darin Adler  <darin@apple.com>

        * Scripts/commit-log-editor: Include the name line of the change log entry.
        A long time ago I designed this script to not include the name because I
        thought it was redundant (same as the name of the person checking in), but
        nowadays it's more common for someone to check something in done by someone

        * Scripts/do-webcore-rename: Added some more planned renames and removed
        some that were already done "by hand".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-15 Mark Mentovai <mark@moxienet.com>
darin@apple.com [Sat, 15 Mar 2008 17:37:22 +0000 (17:37 +0000)]
2008-03-15  Mark Mentovai  <mark@moxienet.com>

        Reviewed and landed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=17833
          use file extensions instead of explicit file types in WebCore's Xcode project

        * WebCore.xcodeproj/project.pbxproj: Remove unnecessary
          uses of explicitFileType, preferring lastKnownFileType ("File Type:
          Default for File" in Xcode's File Info's General tab).  Files below
          that relied on an explicit file type setting other than what would
          be implied by their extensions have been renamed to have correct
        * bridge/jni/jni_jsobject.cpp: Removed.
        * bridge/jni/jni_jsobject.mm: Copied from bridge/jni/jni_jsobject.cpp.
        * loader/mac/LoaderNSURLExtras.m: Removed.
        * loader/mac/LoaderNSURLExtras.mm: Copied from loader/mac/LoaderNSURLExtras.m.
        * platform/mac/SharedTimerMac.cpp: Removed.
        * platform/mac/SharedTimerMac.mm: Copied from platform/mac/SharedTimerMac.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sat, 15 Mar 2008 17:26:28 +0000 (17:26 +0000)]

        Reviewed by Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11997
          Ranges are not fixed after mutation (affects Acid3 test 13)

        Test: fast/dom/Range/mutation.html

        * WebCore.xcodeproj/project.pbxproj: Added NodeWithIndex.h, NodeWithIndexAfter.h,
        and NodeWithIndexBefore.h.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Replaced call to Document::removeMarkers
        with call to Document::textRemoved.
        (WebCore::CharacterData::insertData): Replaced call to Document::shiftMarkers
        with call to Document::textInserted.
        (WebCore::CharacterData::deleteData): Replaced call to Document::removeMarkers
        and Document::shiftMarkers with call to Document::textRemoved.
        (WebCore::CharacterData::replaceData): Replaced call to Document::removeMarkers
        and Document::shiftMarkers with call to Document::textRemoved and
        (WebCore::CharacterData::containsOnlyWhitespace): Tweaked a bit.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::childrenChanged): Added a call to
        Document::nodeChildrenChanged when the nmber of children was changed (and not
        by the parser).
        (WebCore::dispatchChildRemovalEvents): Updated for name change.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Assert that all ranges are gone.
        (WebCore::Document::nodeChildrenChanged): Added. Calls nodeChildrenChanged on
        all ranges.
        (WebCore::Document::nodeWillBeRemoved): Renamed from notifyBeforeNodeRemoval.
        Added code to call nodeWillBeRemoved on all ranges.
        (WebCore::Document::textInserted): Added. Calls textInserted on all ranges and
        also calls shiftMarkers.
        (WebCore::Document::textRemoved): Added. Calls textRemoved on all ranges and also
        calls removeMarkers and shiftMarkers.
        (WebCore::Document::textNodesMerged): Added. Calls textNodesMerged on all ranges.
        (WebCore::Document::textNodeSplit): Added. Calls textNodeSplit on all ranges.
        (WebCore::Document::attachRange): Added. Adds range to the HashSet of all ranges
        for this document.
        (WebCore::Document::detachRange): Added. Removes range from the HashSet.
        * dom/Document.h: Added the new functions and the data member.

        * dom/Element.cpp:
        (WebCore::Element::normalizeAttributes): Added. Contains the part of the
        normalize function that's specific to Element. Better encapsulation to have it
        here rather than in Node::normalize.
        * dom/Element.h: Added the new function.

        * dom/Node.cpp:
        (WebCore::Node::normalize): Rewrote so it's no longer recursive. Also added
        a call to textNodesMerged after each pair of nodes is merged but before the
        second node is removed.
        (WebCore::Node::traverseNextNodePostOrder): Added. Helper function used by
        normalize, but also useful elsewhere.
        * dom/Node.h: Added the new function.

        * dom/NodeIterator.cpp:
        (WebCore::NodeIterator::nodeWillBeRemoved): Renamed from notifyBeforeNodeRemoval.
        * dom/NodeIterator.h: Ditto.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::setData): Call textRemoved.

        * dom/Range.cpp:
        (WebCore::NodeWithIndex::index): Added. Computes and stores index.
        (WebCore::NodeWithIndexBefore::indexBefore): Added. Computes and stores index.
        (WebCore::NodeWithIndexAfter::indexAfter): Added. Computes and stores index.
        (WebCore::Range::Range): Call attachRange.
        (WebCore::Range::~Range): Call detachRange unless the range is already detached.
        (WebCore::Range::commonAncestorContainer): Removed check for WRONG_DOCUMENT_ERR.
        It's no longer possible to create a range where the two containers are non-zero
        and have no common ancestor.
        (WebCore::Range::isPointInRange): Rewrote expression to be more readable.
        (WebCore::Range::compareNode): Changed local variable to use int for consistency.
        (WebCore::Range::compareBoundaryPoints): Replaced ASSERT with ASSERT_NOT_REACHED.
        (WebCore::Range::deleteContents): Removed check for INVALID_STATE_ERR and
        initialization of ec to 0; both are now inside checkDeleteExtract.
        (WebCore::Range::intersectsNode): Changed local variable to use int for consistency.
        Also changed comparison to use < 0 and >= 0 rather than checking explicitly for 1
        and -1.
        (WebCore::Range::processContents): Changed code to not get the nodeType multiple
        times on the same node, and tweaked formatting. Removed code to update the range
        on deletion, because the normal delete logic will take care of that now.
        (WebCore::Range::extractContents): Removed check for INVALID_STATE_ERR and
        initialization of ec to 0; both are now inside checkDeleteExtract.
        (WebCore::Range::insertNode): Changed local variable to use int for consistency.
        (WebCore::Range::toString): Changed variable name to pastLast.
        (WebCore::Range::detach): Call detachRange.
        (WebCore::Range::checkDeleteExtract): Added check for detached range and code to
        set ec to 0; moved here from the two callers. Also changed variable name to pastLast.
        (WebCore::endpointNodeChildrenChanged): Added.
        (WebCore::Range::nodeChildrenChanged): Added.
        (WebCore::endpointNodeWillBeRemoved): Added.
        (WebCore::Range::nodeWillBeRemoved): Added.
        (WebCore::endpointTextInserted): Added.
        (WebCore::Range::textInserted): Added.
        (WebCore::endpointTextRemoved): Added.
        (WebCore::Range::textRemoved): Added.
        (WebCore::endpointTextNodesMerged): Added.
        (WebCore::Range::textNodesMerged): Added.
        (WebCore::endpointTextNodesSplit): Added.
        (WebCore::Range::textNodeSplit): Added.

        * dom/Range.h: Added new member functions.

        * dom/NodeWithIndex.h: Added. Makes it so we won't find the index for the same
        node more than once.
        * dom/NodeWithIndexAfter.h: Added. Similar to NodeWithIndex but gives the index after a
        node and treats a node pointer of 0 as meaning "before first node in parent container".
        * dom/NodeWithIndexBefore.h: Added.  Similar to NodeWithIndex but treats a node pointer of 0
        as meaning "after last node in parent container".

        * dom/Text.cpp:
        (WebCore::Text::splitText): Call textNodeSplit.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyInlineStyle): Changed variable name to pastLast.


        Reviewed by Sam.

        - test changes for http://bugs.webkit.org/show_bug.cgi?id=11997
          Ranges are not fixed after mutation (affects Acid3 test 13)

        * fast/dom/Range/mutation-expected.txt: Added.
        * fast/dom/Range/mutation.html: Added.
        * fast/dom/Range/resources/mutation.js: Added.

        * editing/execCommand/4920742-2-expected.txt: Updated.
        * editing/execCommand/4920742-2.html: Updated this test. It was testing for a crash in a
        case that's no longer possible -- you can't make a range where one endpoint is in the
        document and the other is not.

        * platform/mac/editing/execCommand/4920488-expected.txt: Removed WRONG_DOCUMENT_ERR.
        The fact that a test was getting this exception was a bug, similar to the case above.
        * platform/qt/editing/execCommand/4920488-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
zecke@webkit.org [Sat, 15 Mar 2008 14:15:50 +0000 (14:15 +0000)]
2008-03-15  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Holger.

        [CURL] Crash below ResourceHandleManager::setupPOST when job->request().httpBody() is NULL

        Add null checks for httpBody() to match other ports.

        Test: http/tests/xmlhttprequest/xmlhttprequest-post-crash.html

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): Add null check.
        (WebCore::ResourceHandleManager::setupPOST): Ditto.

2008-03-15  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Holger.

        [CURL] Crash below ResourceHandleManager::setupPOST when job->request().httpBody() is NULL

        * http/tests/xmlhttprequest/xmlhttprequest-post-crash-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-post-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
sfalken@apple.com [Sat, 15 Mar 2008 06:06:11 +0000 (06:06 +0000)]

        PGO build fixes.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:


        PGO build fixes.

        * WebCore.vcproj/WebCore.vcproj:


        PGO build fixes.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd logic to track whether a function uses a locally scoped eval or requires a closure
oliver@apple.com [Sat, 15 Mar 2008 01:05:55 +0000 (01:05 +0000)]
Add logic to track whether a function uses a locally scoped eval or requires a closure

Reviewed by Maciej

Now that we limit eval we can track those uses of eval that operate
in the local scope and functions that require a closure.  We track
this information during initial parsing to avoid yet another tree

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Sat, 15 Mar 2008 00:21:03 +0000 (00:21 +0000)]

        Reviewed by Sam.

        REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work

        Pass the frame loader that should be used for looking up the frame name to FrameLoader::createWindow
        so that somewindow.open calls where the active window and 'somewindow' differ return the correct frame.

        * bindings/js/JSDOMWindowBase.cpp:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:


        Reviewed by Sam.

        REGRESSION (Safari 3.0.4-3.1): Ordering tickets from Sweden's biggest train operator doesn't work

        Add tests.

        * fast/dom/Window/window-open-self-from-other-frame-expected.txt: Added.
        * fast/dom/Window/window-open-self-from-other-frame.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix ChangeLog
mitz@apple.com [Fri, 14 Mar 2008 22:57:36 +0000 (22:57 +0000)]
Fix ChangeLog

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
mitz@apple.com [Fri, 14 Mar 2008 22:54:08 +0000 (22:54 +0000)]
    Reviewed by Mark Rowe.

        - fix <rdar://problem/5797836> shadow offsets are smaller than specified

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setShadow): Made the workaround for
        <rdar://problem/5643663> unconditional.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix it right this time
aroben@apple.com [Fri, 14 Mar 2008 21:06:20 +0000 (21:06 +0000)]
    Fix it right this time

        * platform/MainThread.cpp: Cast to unsigned so we can use %u in the
        format string.
        * platform/mac/MainThreadMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brian Dash's rubberstamp
beidson@apple.com [Fri, 14 Mar 2008 20:57:40 +0000 (20:57 +0000)]
    Reviewed by Brian Dash's rubberstamp

        Remove a class declaration for a class that has never existed

        * WebView/WebResource.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Mac build fix
aroben@apple.com [Fri, 14 Mar 2008 20:47:34 +0000 (20:47 +0000)]
    Mac build fix

        * platform/mac/MainThreadMac.mm: Corrected a typo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Fri, 14 Mar 2008 20:34:01 +0000 (20:34 +0000)]

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17834
          REGRESSION: floated first-letter does not work when included in table

        Test: fast/css/first-letter-float.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Changed the search for the
        first text node to stop at a float if that float is an existing first-


        Reviewed by Darin Adler.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17834
          REGRESSION: floated first-letter does not work when included in table

        * fast/css/first-letter-float.html: Added.
        * platform/mac-leopard/fast/css/first-letter-float-expected.checksum: Added.
        * platform/mac-leopard/fast/css/first-letter-float-expected.png: Added.
        * platform/mac/fast/css/first-letter-float-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Mac build
weinig@apple.com [Fri, 14 Mar 2008 20:15:04 +0000 (20:15 +0000)]
    Fix Mac build

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make most of callOnMainThread's implementation be cross-platform
aroben@apple.com [Fri, 14 Mar 2008 19:53:37 +0000 (19:53 +0000)]
    Make most of callOnMainThread's implementation be cross-platform

        I took the non-platform-specific parts of MainThreadWin.cpp and moved
        them to a new MainThread.cpp. Each platform is now responsible for
        implementing one function, scheduleDispatchFunctionsOnMainThread,
        which is supposed to set things up so that
        dispatchFunctionsFromMainThread gets called from the main thread in
        the near future.

        Reviewed by Alexey.

        * GNUmakefile.am: Added MainThread.cpp to the project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * platform/MainThread.cpp:
          - Copied from WebCore/platform/win/MainThreadWin.cpp.
          - Removed the Windows-specific parts.
        (WebCore::callOnMainThread): Changed to call
        scheduleDispatchFunctionsOnMainThread instead of PostMessage.
        * platform/gtk/MainThreadGtk.cpp:
        (WebCore::timeoutFired): Renamed from callFunctionOnMainThread. Now
        just calls dispatchFunctionsFromMainThread.
        (WebCore::scheduleDispatchFunctionsOnMainThread): Added. Calls through
        to g_timeout_add.
        * platform/mac/MainThreadMac.mm: Renamed WebCoreFunctionWrapper to
        (-[WebCoreMainThreadCaller call]): Calls through to
        (WebCore::scheduleDispatchFunctionsOnMainThread): Makes a new
        WebCoreMainThreadCaller and calls performSelectorOnMainThread on it.
        * platform/qt/MainThreadQt.cpp: Removed PerformFunctionEvent.
        (WebCore::MainThreadInvoker::event): Chagned to call through to
        (WebCore::scheduleDispatchFunctionsOnMainThread): Sends an empty event
        to the MainThreadInvoker.
        * platform/win/MainThreadWin.cpp:
          - Removed the non-Windows-specific parts.
          - Removed some unnecessary initialization of static variables to 0.
        (WebCore::ThreadingWindowWndProc): Changed to call
        (WebCore::scheduleDispatchFunctionsOnMainThread): Calls through to
        * platform/wx/MainThreadWx.cpp:
        (WebCore::scheduleDispatchFunctionsOnMainThread): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth Dakin.
ggaren@apple.com [Fri, 14 Mar 2008 19:28:57 +0000 (19:28 +0000)]
    Reviewed by Beth Dakin.

        Fixed another problem with Vector::shrinkCapacity.

        moveOverlapping isn't good enough for the case where the buffer hasn't
        changed, because it still destroys the contents of the buffer.

        * wtf/Vector.h:
        (WTF::::shrinkCapacity): Changed to explicitly check whether the call
        to allocateBuffer produced a new buffer. If it didn't, there's no need
        to move.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth Dakin.
ggaren@apple.com [Fri, 14 Mar 2008 19:05:28 +0000 (19:05 +0000)]
    Reviewed by Beth Dakin.

        Fixed a few problems with Vector::shrinkCapacity that I noticed in testing.

        * wtf/Vector.h:
        (WTF::VectorBufferBase::deallocateBuffer): Clear our m_buffer pointer
        when we deallocate m_buffer, in case we're not asked to reallocate a new
        buffer. (Otherwise, we would use a stale m_buffer if we were asked to
        perform any operations after shrinkCapacity was called.)

        (WTF::VectorBuffer::allocateBuffer): Made VectorBuffer with inline
        capacity aware that calls to allocateBuffer might be shrinks, rather
        than grows, so we shouldn't allocate a new buffer on the heap unless
        our inline buffer is too small.

        (WTF::::shrinkCapacity): Call resize() instead of just setting m_size,
        so destructors run. Call resize before reallocating the buffer to make
        sure that we still have access to the objects we need to destroy. Call
        moveOverlapping instead of move, since a call to allocateBuffer on an
        inline buffer may produce identical storage.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
bdakin@apple.com [Fri, 14 Mar 2008 18:28:51 +0000 (18:28 +0000)]
    Reviewed by Geoff.

        Fix for <rdar://problem/5728171> Potential PLT speedup: don't
        realloc every time inside NamedAttrMap::addAttribute

        The speed-up for this turned out to be so small that it is mostly
        imperceptible. It is likely that it is a tiny boost, though, and
        the new code is much cleaner.

        * dom/Element.cpp:
        (WebCore::Element::setAttributeMap): attrs is now called
        * dom/NamedAttrMap.cpp: The array attrs is now the Vector of
        RefPtrs called m_attributes, and there is no longer any need for
        the len member variable.
        * dom/NamedAttrMap.h: Same.
        * html/HTMLTokenizer.cpp: One of the benefits of the old array was
        that it never took up more memory than it needed to. So the
        tokenizer utilizes new member functions on NamedAttrMap
        (shrinkToLength and reserveCapacity) to try to keep memory usage at
        a minimum.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix typos.
ddkilzer@apple.com [Fri, 14 Mar 2008 15:21:10 +0000 (15:21 +0000)]
Fix typos.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago BUILD FIX when ENABLE(MAC_JAVA_BINDINGS) set to 0.
ddkilzer@apple.com [Fri, 14 Mar 2008 15:19:52 +0000 (15:19 +0000)]

        * page/mac/FrameMac.mm: Move up #if ENABLE(MAC_JAVA_BINDINGS) guard
        to comment out unused code.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Fri, 14 Mar 2008 14:59:38 +0000 (14:59 +0000)]
    Reviewed by Darin.

        Get rid of a localime() call on platforms that have better alternatives.

        * kjs/DateMath.h: Added getLocalTime();

        * kjs/DateMath.cpp:
        Implementation moved from getDSTOffsetSimple().

        * kjs/date_object.cpp:
        (KJS::DateObjectImp::callAsFunction): Switched to getLocalTime().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ddkilzer@apple.com [Fri, 14 Mar 2008 14:34:31 +0000 (14:34 +0000)]

        Unify concept of enabling the Mac Java bridge.

        Reviewed by Darin and Anders.

        * wtf/Platform.h: Define ENABLE_MAC_JAVA_BRIDGE here.


        Unify concept of enabling the Mac Java bridge.

        Reviewed by Darin and Anders.

        No test cases added since there is no change in functionality.

        * DerivedSources.make: Added check for ENABLE_MAC_JAVA_BRIDGE macro.
        If defined as "1", add WebCore.JNI.exp to WEBCORE_EXPORT_DEPENDENCIES.
        * WebCore.JNI.exp: Added.
        * WebCore.base.exp: Moved exported JNI methods to WebCore.JNI.exp.

        * bridge/jni/jni_class.cpp: Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
        * bridge/jni/jni_class.h: Ditto.
        * bridge/jni/jni_instance.cpp: Ditto.
        * bridge/jni/jni_instance.h: Ditto.
        * bridge/jni/jni_jsobject.cpp: Ditto.
        * bridge/jni/jni_jsobject.h: Ditto.
        * bridge/jni/jni_objc.mm: Ditto.
        * bridge/jni/jni_runtime.cpp: Ditto.
        * bridge/jni/jni_runtime.h: Ditto.
        * bridge/jni/jni_utility.cpp: Ditto.
        * bridge/jni/jni_utility.h: Ditto.

        * bridge/runtime.cpp: Removed unused #include statements.
        * bridge/runtime.h:
        (KJS::Bindings::Instance::BindingLanguage): Added #if ENABLE(MAC_JAVA_BRIDGE)
        guard for JavaLanguage enum.  Also added #if PLATFORM(MAC) guard for
        ObjectiveCLanguage enum to match corresponding code in runtime.cpp.

        * config.h: Removed definition of HAVE_JNI.

        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
        * page/Frame.cpp:
        (WebCore::Frame::Frame): Ditto.
        * page/Frame.h:
        (WebCore::Frame::initJavaJSBindings): Ditto.
        * page/mac/FrameMac.mm:
        (WebCore::Frame::createScriptInstanceForWidget): Ditto.
        (WebCore::Frame::initJavaJSBindings): Ditto.


        Unify concept of enabling the Mac Java bridge.

        Reviewed by Darin and Anders.

        * Plugins/WebPluginJava.h: Removed unused file.
        * WebCoreSupport/WebFrameLoaderClient.h:
        (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
        * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
        (WebFrameLoaderClient::javaApplet): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt build.
hausmann@webkit.org [Fri, 14 Mar 2008 08:09:09 +0000 (08:09 +0000)]
Fix the Qt build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * html/PreloadScanner.h: Corrected license.
darin@apple.com [Fri, 14 Mar 2008 07:13:28 +0000 (07:13 +0000)]
    * html/PreloadScanner.h: Corrected license.
        * html/PreloadScanner.cpp: Corrected license.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-13 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Fri, 14 Mar 2008 04:40:07 +0000 (04:40 +0000)]
2008-03-13  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Darin.

        Correct paths to vsprops files so they use the environment
        variable, rather than hard-coded path.

        * WinLauncher/WinLauncher.vcproj:  Correct paths to vsprops.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by darin. Landed by eseidel.
eric@webkit.org [Fri, 14 Mar 2008 04:19:24 +0000 (04:19 +0000)]
    Reviewed by darin.  Landed by eseidel.

        * platform/FloatConversion.h: Include a header to get CoreGraphics
        types when using CoreGraphics types.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eseidel. Landed by eseidel.
eric@webkit.org [Fri, 14 Mar 2008 04:19:03 +0000 (04:19 +0000)]
    Reviewed by eseidel.  Landed by eseidel.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSParser.cpp:
        * css/makeprop.pl:
Move CSSPropertyNames.c to CSSPropertyNames.cpp

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eseidel. Landed by eseidel.
eric@webkit.org [Fri, 14 Mar 2008 03:47:15 +0000 (03:47 +0000)]
    Reviewed by eseidel.  Landed by eseidel.

        * platform/Arena.h: Use statement1;statement2 instead of
        (statement1,statement2) in CLEAR_UNUSED.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eseidel. Landed by eseidel.
eric@webkit.org [Fri, 14 Mar 2008 03:44:10 +0000 (03:44 +0000)]
    Reviewed by eseidel.  Landed by eseidel.

        * wtf/FastMalloc.cpp: #include <wtf/HashSet.h> outside of any

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eseidel. Landed by eseidel
eric@webkit.org [Fri, 14 Mar 2008 03:43:55 +0000 (03:43 +0000)]
    Reviewed by eseidel.  Landed by eseidel

        * pcre/pcre_exec.cpp: Fix misnamed variable, allowing -DDEBUG build
        to succeed.
        * wtf/ThreadingPthreads.cpp: #include <sys/time.h> for gettimeofday
        in non-pch build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
antti@apple.com [Fri, 14 Mar 2008 03:07:17 +0000 (03:07 +0000)]
    Reviewed by Mitz.

        Update test results for the preload patch. Load order for some resources changed,
        this does not affect the substance of these tests.

        * platform/mac-leopard/security/block-test-expected.txt:
        * security/block-test-expected.txt:
        * webarchive/loading/cache-expired-subresource-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-13 Tommi Komulainen <tommi.komulainen@iki.fi>
alp@webkit.org [Fri, 14 Mar 2008 02:47:45 +0000 (02:47 +0000)]
2008-03-13  Tommi Komulainen  <tommi.komulainen@iki.fi>

        Reviewed by Alp Toker.

        [SOUP] POST requests are empty

        Send the HTTP request body as well.

        * platform/network/soup/ResourceHandleSoup.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the build.
timothy@apple.com [Thu, 13 Mar 2008 23:16:27 +0000 (23:16 +0000)]
Fix the build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Thu, 13 Mar 2008 22:14:15 +0000 (22:14 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17819
          Border-collapse: collapse later cell wins on PC, earlier cell on Mac

        Test: fast/table/border-collapsing/equal-precedence-resolution.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::collapsedLeftBorder): When calling
        compareBorders() with borders that may have the same precedence, made
        sure to pass the border belonging to the earlier (in document order)
        element first, since compareBorders() prefers the first argument when
        there is a tie.
        (WebCore::RenderTableCell::collapsedRightBorder): Ditto.
        (WebCore::RenderTableCell::collapsedTopBorder): Ditto.


        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17819
          Border-collapse: collapse later cell wins on PC, earlier cell on Mac

        * fast/table/border-collapsing/equal-precedence-resolution.html: Added.
        * platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Added.
        * platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Added.
        * platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Another Windows build fix after r31034
aroben@apple.com [Thu, 13 Mar 2008 22:07:23 +0000 (22:07 +0000)]
    Another Windows build fix after r31034

        * WebKitDLL.cpp:
        (loadResourceIntoBuffer): Use SharedBuffer::create.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fixes after r31034
aroben@apple.com [Thu, 13 Mar 2008 21:40:43 +0000 (21:40 +0000)]
Build fixes after r31034


        wx build fix and Windows leak fix after r31034

        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::Image::loadPlatformResource): Use SharedBuffer::create.
        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile): Ditto (we were
        leaking the SharedBuffer here before).


        Windows build fix after r31034

        * WebFrame.cpp:
        (WebFrame::loadData): Use SharedBuffer::create.
        (WebFrame::loadHTMLString): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
antti@apple.com [Thu, 13 Mar 2008 21:31:14 +0000 (21:31 +0000)]
    Reviewed by Eric.

        Correct a few issues spotted by Mike Belshe.

        * html/PreloadScanner.cpp:
        * loader/loader.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix GTK+ build for SharedBuffer changes.
aroben@apple.com [Thu, 13 Mar 2008 21:26:55 +0000 (21:26 +0000)]
Fix GTK+ build for SharedBuffer changes.


2008-03-13  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix GTK+ build for SharedBuffer changes.

        * platform/graphics/gtk/ImageGtk.cpp:


2008-03-13  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix GTK+ build for SharedBuffer changes.

        * webkit/webkitwebview.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
sfalken@apple.com [Thu, 13 Mar 2008 21:24:01 +0000 (21:24 +0000)]

        More PGO build fixes.

        * WebCorePrefix.cpp:


        More PGO build fixes.

        * WebKit.vcproj/WebKit.pgd: Removed.
        * WebKit.vcproj/WebKit.vcproj:
        * WebKitPrefix.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti@apple.com [Thu, 13 Mar 2008 21:20:31 +0000 (21:20 +0000)]

        Reviewed by Darin.

        Make page loads go fast.


        - Implement speculative preloading. When a script load blocks the main parser, use a side
          parser to pick up more resources.
        - Implement per-host load queues, prioritize scripts and stylesheets over images.

        Depending on content and network latency this may speed things up quite a bit.

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        Clear the preloads after laoding completes.

        * html/HTMLLinkElement.cpp:
        * html/HTMLLinkElement.h:
        Make tokenizeRelAttribute() public static so it can be used from elsewhere.
        Eliminate a pointless bitfield so I can get references.

        * html/HTMLTokenizer.cpp:
        * html/HTMLTokenizer.h:
        Spin up the preload scanner whenever a script load blocks the parser. One scanner tracks the end of
        the document while temporary ones are created as needed to scan document.write() output.

        * html/PreloadScanner.cpp: Added.
        * html/PreloadScanner.h: Added.
        HTML5 tokenization plus some glue code. Fake CSS parsing thrown in just for fun.

        * loader/Cache.cpp:
        Preloads have zero refcount, avoid kicking them out too early.

        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        Keep track which resources are preloads. Avoid deleting them. Track
        at which point of the loading preloads get utilized to enable some interesting

        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        Ensure we utilize preloaded resources during reloads.
        Keep a list of all preloads in the document. Clear the preloads after
        parsing is complete. Some debug statistics.

        * loader/DocumentLoader.cpp:
        Avoid signaling that loading is complete too early.

        * loader/loader.cpp:
        * loader/loader.h:
        Distribute load requests to per-host priority queues. Limit the number of loads issued to the
        networking layer so we have better changes of getting important requests through first.
        Prioritize scripts > stylesheets > images.


        Reviewed by Darin.

        * ForwardingHeaders/wtf/Deque.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago This patch makes full page zoom work pretty well. It fixes repainting so...
hyatt@apple.com [Thu, 13 Mar 2008 21:01:04 +0000 (21:01 +0000)]
    This patch makes full page zoom work pretty well. It fixes repainting so that it works when transforms
        are set on the RenderView. It also implements the "smart layout" behavior that other browsers support when
        zooming. The page will still try to constrain to the viewport size even when zoomed.

        Reviewed by john

        * dom/Document.cpp:
        Make sure to test for transform changes even when there is no zoom.  This fixes repainting issues
        caused by jumping from a zoomed state back to the standard size.

        * page/FrameView.cpp:
        Adjust for the zoom factor (the render tree is in unzoomed coordinates, but the scrollbars of the view
        need to handle zoomed coordinates).

        * rendering/RenderBox.cpp:
        Fix the body-sizing-to-the-view-height quirk so that it takes the zoom factor into account when
        stretching to fill the viewport.

        * rendering/RenderLayer.cpp:
        Remove the FIXMEs now that absoluteClippedOverflowRect works with transforms on the RenderView.

        * rendering/RenderView.cpp:
        Make sure the calculated width/height take the zoom factor into account in order to get the "smart layout"

        When deciding whether children have to get a relayout, we need to check the zoomed width/height and not just
        the viewport size.

        Patched to take into account transforms set on the RenderView.

        Patched to just always use m_width and m_height initially, since those have already been adjusted for
        the zoom factor.

        * rendering/RenderView.h:
        New helper methods for obtaining the adjusted width/height of the viewport taking into account the
        zoom factor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
andersca@apple.com [Thu, 13 Mar 2008 20:02:54 +0000 (20:02 +0000)]
    Build fix.

        * WebCore.base.exp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Thu, 13 Mar 2008 19:08:06 +0000 (19:08 +0000)]

        Reviewed by Adam.

        Get rid of actualRequest, it is not used anymore. Also, get rid of
        initialRequest and replace all uses with originalRequest because those are
        the same thing.

        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:


        Reviewed by Adam.

        Call originalRequest, not initialRequest.

        * WebView/WebDataSource.mm:
        (-[WebDataSource initialRequest]):


        Reviewed by Adam.

        Call originalRequest instead of initialRequest.

        * WebDataSource.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders
beidson@apple.com [Thu, 13 Mar 2008 19:00:55 +0000 (19:00 +0000)]
    Reviewed by Anders

        Convert SharedBuffer to start with a refCount of 1

        * loader/ImageDocument.cpp:

        * loader/ResourceLoader.cpp:

        * loader/icon/IconDatabase.cpp:

        * loader/loader.cpp:

        * platform/SharedBuffer.h:
        (WebCore::SharedBuffer::create): Make all constructors private, add ::create() calls
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1
        * platform/mac/SharedBufferMac.mm:
        (WebCore::SharedBuffer::SharedBuffer): Revert to default RefCounted constructor to start with a ref count of 1

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
sfalken@apple.com [Thu, 13 Mar 2008 18:37:23 +0000 (18:37 +0000)]

        PGO build fixes.

        Disable PGO for normal release builds.
        Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:


        PGO build fixes.

        Disable PGO for normal release builds.
        Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

        * WebCore.vcproj/WebCore.vcproj:


        PGO build fixes.

        Disable PGO for normal release builds.
        Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
bdakin@apple.com [Thu, 13 Mar 2008 18:32:07 +0000 (18:32 +0000)]
    Reviewed by Geoff.

        Adding new functionality to Vector. Currently all of the shrink and
        resize functions on Vector only shrink the size of the Vector, not
        the capacity. For the Vector to take up as little memory as
        possible, though, it is necessary to be able to shrink the capacity
        as well. So this patch adds that functionality.

        I need this for a speed up I am working on, and Geoff wants to use
        it in a speed up he is working on also, so he asked me to commit it

        * wtf/Vector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca@apple.com [Thu, 13 Mar 2008 18:18:19 +0000 (18:18 +0000)]
    Reviewed by Darin.

        Make a bunch of DocumentLoader setters/getters inline.

        * loader/DocumentLoader.cpp:
        * loader/DocumentLoader.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAttempt at fixing the Qt/Windows build bot. Quote using double-quotes
hausmann@webkit.org [Thu, 13 Mar 2008 16:17:13 +0000 (16:17 +0000)]
Attempt at fixing the Qt/Windows build bot. Quote using double-quotes
instead of single quotes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>
aroben@apple.com [Thu, 13 Mar 2008 15:19:45 +0000 (15:19 +0000)]
2008-03-13  Rodney Dawes  <dobey@wayofthemonkey.com>

        Fix builds without SVG enabled.

        * page/Frame.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin@apple.com [Thu, 13 Mar 2008 14:49:06 +0000 (14:49 +0000)]
    Reviewed by John Sullivan.

        - cleanup after removing the bridge

        * DOM/WebDOMOperations.mm:
        (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.

        * Misc/WebCoreStatistics.mm:
        (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
        _frameLoader method.
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
        method. Without this we could leave a stale frame pointer around.
        (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
        caller of the _isMainFrame method.
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
        _frameLoader method.
        (WebFrameLoaderClient::createFrame): Moved code here from _addChild.

        * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
        turned out to be unused.
        (core): Added overload for DocumentFragment.
        (kit): Ditto.
        (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
        to FrameLoader with _private->coreFrame->loader().
        (-[WebFrame _attachScriptDebugger]): Ditto.
        (-[WebFrame _clearCoreFrame]): Added.
        (-[WebFrame _updateBackground]): More of the same.
        (-[WebFrame _unmarkAllBadGrammar]): Ditto.
        (-[WebFrame _unmarkAllMisspellings]): Ditto.
        (-[WebFrame _hasSelection]): Ditto.
        (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
        (-[WebFrame _findFrameWithSelection]): Ditto.
        (-[WebFrame _dataSource]): Ditto.
        (-[WebFrame _addData:]): Streamlined code a bit.
        (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
        (-[WebFrame _receivedData:textEncodingName:]): Ditto.
        (-[WebFrame _isDescendantOfFrame:]): Ditto.
        (-[WebFrame _bodyBackgroundColor]): Ditto.
        (-[WebFrame _isFrameSet]): Ditto.
        (-[WebFrame _firstLayoutDone]): Ditto.
        (-[WebFrame _loadType]): Ditto.
        (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
        (-[WebFrame name]): Ditto.
        (-[WebFrame DOMDocument]): Ditto.
        (-[WebFrame frameElement]): Ditto.
        (-[WebFrame provisionalDataSource]): Ditto.
        (-[WebFrame dataSource]): Ditto.
        (-[WebFrame loadRequest:]): Ditto.
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
        (-[WebFrame loadArchive:]): Ditto.
        (-[WebFrame stopLoading]): Ditto.
        (-[WebFrame reload]): Ditto.
        (-[WebFrame findFrameNamed:]): Ditto.
        (-[WebFrame parentFrame]): Ditto.
        (-[WebFrame childFrames]): Ditto.
        (-[WebFrame windowObject]): Ditto.
        (-[WebFrame globalContext]): Ditto.

        * WebView/WebFrameInternal.h: Added overloads of core and kit.
        Removed method declarations.

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
        (formElementFromDOMElement): Ditto.
        (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
        (inputElementFromDOMElement): Ditto.
        (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
        (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
        (-[WebHTMLRepresentation formForElement:]): Ditto.
        (-[WebHTMLRepresentation currentForm]): Ditto.
        (-[WebHTMLRepresentation controlsInForm:]): Ditto.
        (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
        (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
        Call createFragmentFromText directly instead of via WebFrame.
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        Moved layout calls here from WebFrame.
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
        (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
        (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
        (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
        (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        Moved code here from WebFrame.
        (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
        (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
        (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
        (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
        (-[WebHTMLView unmarkAllTextMatches]): Ditto.
        (-[WebHTMLView rectsForTextMatches]): Ditto.

        * WebView/WebHTMLViewInternal.h: Removed unused method declarations.

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
        _frameLoader method.

        * WebView/WebRenderNode.mm:
        (copyRenderNode): Moved code here from WebFrame.
        (-[WebRenderNode initWithWebFrameView:]): Ditto.

        * WebView/WebResource.mm:
        (-[WebResource _stringValue]): Moved code here from WebFrame.

        * WebView/WebView.mm:
        (-[WebView _close]): Use core function intsead of _frameLoader method.
        (-[WebView setCustomTextEncodingName:]): Ditto.
        (-[WebView setHostWindow:]): Moved code here from WebFrame.
        (aeDescFromJSValue): Moved this here from WebFrame.
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Qt build.
hausmann@webkit.org [Thu, 13 Mar 2008 12:17:15 +0000 (12:17 +0000)]
Fix the Qt build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
weinig@apple.com [Thu, 13 Mar 2008 07:11:26 +0000 (07:11 +0000)]
    Reviewed by Darin Adler.

        Fix <rdar://problem/5784773>
        Crash loading QT movies @ apple.com/ipodtouch/features.html with a PAC file (WebKitThreadingException)

        Make bridged RuntimeObjects get collected on the main thread only. This is necessary
        because clients of the bridged objects are unlikely to prepared for a collection on
        non-main thread, which can happen with a PAC file.

        * bridge/runtime_object.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Bug 17815: Inspector's DOM tree should descend into subframes
aroben@apple.com [Thu, 13 Mar 2008 06:13:32 +0000 (06:13 +0000)]
    Fix Bug 17815: Inspector's DOM tree should descend into subframes


        Reviewed by Tim.

        * page/inspector/DocumentPanel.js:
        (WebInspector.DocumentPanel.revealNode): Changed to provide
        _isAncestorIncludingParentFramesWithinPanel and
        _parentNodeOrFrameElementWithinPanel for the isAncestor and getParent
        parameters to findTreeElement so that parent frames will be searched.
          - Changed while loop to for loop
          - Use _parentNodeOrFrameElementWithinPanel instead of
            Node.parentNode to move to the next node
          - The loop now ends when we reach the DocumentPanel's document node
          - Traversal past other Document nodes is now allowed
          - We add the "start" class to the final crumb after the loop exits
        (WebInspector.DocumentPanel._getDocumentForNode): Added. Simple helper
        that returns the node itself if the node is a Document node, or the
        node's ownerDocument otherwise.
        Added. Returns the node's parent node or, in the case of a Document
        node, the node's window's owning frame element, but will not return a
        node that is in a parent frame of the DocumentPanel's Document.
        Added. Returns true if a is an ancestor of b if a is an ancestor of a
        frame element whose subframe(s) contain b.
        (WebInspector.DOMNodeTreeElement): We now consider ourselves to have
        children if we have a contentDocument.
        (WebInspector.DOMNodeTreeElement.onpopulate): Moved the appendChild
        loop into a function so that we can add both children of our
        contentDocument and children of our node to the tree.
        (WebInspector.DOMNodeTreeElement.ondblclick): Changed so that we get
        the rootDOMNode by traversing the tree outline hierarchy instead of
        the DOM hierarchy so that we can easily jump up to a parent frame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update the styles/metrics panes and breadcrumb after editing DOM attributes
aroben@apple.com [Thu, 13 Mar 2008 06:13:02 +0000 (06:13 +0000)]
     Update the styles/metrics panes and breadcrumb after editing DOM attributes

         Reviewed by Tim.

         * page/inspector/DocumentPanel.js:
         (WebInspector.DocumentPanel.set focusedDOMNode): Moved code to update
         the parts of the DocumentPanel other than the DOM tree into a new
         function, _focusedNodeChanged.
         (WebInspector.DocumentPanel._focusedNodeChanged): Added. The
         forceUpdate parameter specifies whether the update should occur even
         if the focused node hasn't changed since the last update.
         (WebInspector.DocumentPanel.updateBreadcrumb): Added a forceUpdate
         parameter. If forceUpdate is true, we always rebuild the breadcrumbs.
         (WebInspector.DocumentPanel.updateStyles): Added a forceUpdate
         parameter. If forceUpdate is true, we always rebuild the styles pane.
         (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added a
         call to DocumentPanel._focusedNodeChanged. We have to force the update
         because we haven't changed the focused node (the attributes of the
         node have changed).
         * page/inspector/StylesSidebarPane.js:
         (WebInspector.StylesSidebarPane.update): Added a forceUpdate
         parameter. If forceUpdate is true we always rebuild the styles.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix build.
sfalken@apple.com [Thu, 13 Mar 2008 06:05:32 +0000 (06:05 +0000)]
    Fix build.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago New version of WebKitSystemInterface.lib with
sfalken@apple.com [Thu, 13 Mar 2008 05:49:03 +0000 (05:49 +0000)]
    New version of WebKitSystemInterface.lib with
        more compiler warnings suppressed.

        * win/lib/WebKitSystemInterface.lib:
        * win/tools/vsprops/common.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFurther Gtk and Qt build fixes.
mrowe@apple.com [Thu, 13 Mar 2008 05:40:12 +0000 (05:40 +0000)]
Further Gtk and Qt build fixes.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTouch file to build WebKit.
sfalken@apple.com [Thu, 13 Mar 2008 05:39:17 +0000 (05:39 +0000)]
Touch file to build WebKit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Gtk and Qt builds.
mrowe@apple.com [Thu, 13 Mar 2008 05:30:41 +0000 (05:30 +0000)]
Fix Gtk and Qt builds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMac build fix.
mrowe@apple.com [Thu, 13 Mar 2008 05:26:54 +0000 (05:26 +0000)]
Mac build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
sfalken@apple.com [Thu, 13 Mar 2008 05:02:50 +0000 (05:02 +0000)]
    Build fix.

        * page/win/FrameWin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
sfalken@apple.com [Thu, 13 Mar 2008 04:20:06 +0000 (04:20 +0000)]
    Build fix.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5795843>
adachan@apple.com [Thu, 13 Mar 2008 03:50:40 +0000 (03:50 +0000)]
        CFURLDownload needs to be cancelled if we don't have a destination path
        to save resume information.

        Reviewed by Brady.

        * WebDownload.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Thu, 13 Mar 2008 03:48:28 +0000 (03:48 +0000)]

        Reviewed by Anders.

        - http://bugs.webkit.org/show_bug.cgi?id=17640
          eliminate WebCoreFrameBridge

        * WebCore.base.exp: Added more exports, needed by code moved from WebCoreFrameBridge
        to WebFrame in WebKit.
        * WebCore.xcodeproj/project.pbxproj: Added more headers, same reason. Also deleted
        WebCoreFrameBridge.h and WebCoreFrameBridge.mm.

        * page/Frame.cpp:
        (WebCore::Frame::Frame): Added call to initJavaJSBindings(), formerly handled by
        the WebCoreFrameBridge.
        * page/Frame.h: Added initJavaJSBindings function.

        * page/mac/FrameMac.mm:
        (WebCore::updateRenderingForBindings): Moved here from WebCoreFrameBridge.
        (WebCore::Frame::initJavaJSBindings): Ditto; code was in the init function.

        * page/mac/WebCoreFrameBridge.h: Removed.
        * page/mac/WebCoreFrameBridge.mm: Removed.


        Reviewed by Anders.

        - http://bugs.webkit.org/show_bug.cgi?id=17640
          eliminate WebCoreFrameBridge

        * StringsNotToBeLocalized.txt: Updated for recent changes.
        * WebKit.xcodeproj/project.pbxproj: Removed WebFrameBridge.h and WebFrameBridge.mm.


        Reviewed by Anders.

        - http://bugs.webkit.org/show_bug.cgi?id=17640
          eliminate WebCoreFrameBridge

        Moved all the code from the bridge into WebFrame. This need not be the final
        home of these methods -- they can be moved closer to their callers and improved
        further -- but it eliminates the bridge without requiring a rewrite of the code.
        It's a fairly mechanical process (just adding underscores to method names really).

        There's even a chance that some of the methods are unused. Those we can remove
        after checking if that's so.

        * DOM/WebDOMOperations.mm:
        (-[DOMNode markupString]): Use WebFrame rather than bridge.
        (-[DOMDocument webFrame]): Changed to use the core and kit functions
        instead of using the bridge.
        (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
        (-[DOMRange markupString]): Ditto.
        * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.

        * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
        * History/WebHistoryItem.mm: Ditto.

        * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
        * Misc/WebCoreStatistics.mm:
        (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.

        * Misc/WebElementDictionary.mm: Removed unneeded import.

        * Misc/WebKitStatistics.m:
        (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
        * Misc/WebKitStatisticsPrivate.h: Ditto.

        * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
        * Misc/WebNSPasteboardExtras.mm: Ditto.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
        rather than bridge.

        * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
        * Plugins/WebNetscapePluginStream.mm: Ditto.

        * Plugins/WebPluginContainerCheck.mm:
        (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
        bridge to get to the WebCore::Frame.

        * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
        * Plugins/WebPluginController.mm:
        (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
        rather than bridge.

        * WebCoreSupport/WebEditorClient.mm:
        (selectorForKeyEvent): Tweaked comment.

        * WebCoreSupport/WebFrameBridge.h: Removed.
        * WebCoreSupport/WebFrameBridge.mm: Removed.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
        (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
        I could remove this function entirely, but it looks like the Qt port is using it.

        * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.

        * WebView/WebArchiver.mm:
        (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
        (+[WebArchiver archiveNode:]): Ditto.
        (+[WebArchiver archiveSelectionInFrame:]): Ditto.

        * WebView/WebDataSource.mm:
        (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
        (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
        (-[WebDataSource subresources]): Ditto.
        (-[WebDataSource subresourceForURL:]): Ditto.

        * WebView/WebDataSourceInternal.h: Removed _bridge method.

        * WebView/WebFrame.mm:
        (-[WebFramePrivate dealloc]): Removed code to release the bridge.
        (core): Go directly to the core frame, not via the bridge.
        (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
        Remove the code to deal with the bridge.
        (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
        shouldCreateRenderers flag, formerly on the bridge.
        (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
        (aeDescFromJSValue): Moved here from bridge.
        (-[WebFrame _domain]): Ditto.
        (-[WebFrame _addData:]): Ditto.
        (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
        (-[WebFrame _nodesFromList:]): Ditto.
        (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
        (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
        (-[WebFrame _selectedString]): Ditto.
        (-[WebFrame _stringForRange:]): Ditto.
        (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
        (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
        (-[WebFrame _sendScrollEvent]): Ditto.
        (-[WebFrame _drawRect:]): Ditto.
        (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
        (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
        (-[WebFrame _copyRenderNode:copier:]): Ditto.
        (-[WebFrame _copyRenderTree:]): Ditto.
        (inputElementFromDOMElement): Ditto.
        (formElementFromDOMElement): Ditto.
        (-[WebFrame _elementWithName:inForm:]): Ditto.
        (-[WebFrame _elementDoesAutoComplete:]): Ditto.
        (-[WebFrame _elementIsPassword:]): Ditto.
        (-[WebFrame _formForElement:]): Ditto.
        (-[WebFrame _currentForm]): Ditto.
        (-[WebFrame _controlsInForm:]): Ditto.
        (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
        (-[WebFrame _matchLabels:againstElement:]): Ditto.
        (-[WebFrame _URLWithAttributeString:]): Ditto.
        (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
        (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
        (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
        (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
        (-[WebFrame _unmarkAllTextMatches]): Ditto.
        (-[WebFrame _rectsForTextMatches]): Ditto.
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
        (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
        (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
        (-[WebFrame _firstRectForDOMRange:]): Ditto.
        (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
        (-[WebFrame _baseURL]): Ditto.
        (-[WebFrame _stringWithData:]): Ditto.
        (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
        (-[WebFrame _needsLayout]): Ditto.
        (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
        (-[WebFrame _accessibilityTree]): Ditto.
        (-[WebFrame _setBaseBackgroundColor:]): Ditto.
        (-[WebFrame _setDrawsBackground:]): Ditto.
        (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
        (-[WebFrame _selectionGranularity]): Ditto.
        (-[WebFrame _convertToNSRange:]): Ditto.
        (-[WebFrame _convertToDOMRange:]): Ditto.
        (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
        (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
        (-[WebFrame _markDOMRange]): Ditto.
        (-[WebFrame _markedTextNSRange]): Ditto.
        (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
        (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
        (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
        (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
        (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
        (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
        (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
        (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
        (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
        (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
        (-[WebFrame _visiblePositionForPoint:]): Ditto.
        (-[WebFrame _characterRangeAtPoint:]): Ditto.
        (-[WebFrame _typingStyle]): Ditto.
        (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
        (-[WebFrame _fontForSelection:]): Ditto.
        (-[WebFrame _dragSourceMovedTo:]): Ditto.
        (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
        (-[WebFrame _getData:andResponse:forURL:]): Ditto.
        (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
        (-[WebFrame _canProvideDocumentSource]): Ditto.
        (-[WebFrame _canSaveAsWebArchive]): Ditto.
        (-[WebFrame _receivedData:textEncodingName:]): Ditto.
        (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
        function. Couldn't just keep the bridge method because this was already here with the same name.
        (-[WebFrame _selectedNSRange]): Ditto.
        (-[WebFrame _selectNSRange:]): Ditto.
        (-[WebFrame dealloc]): Remove bridge-related code.
        (-[WebFrame finalize]): Ditto.

        * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
        Removed the bridge parameter from the init method. Removed the #if blocks that
        tried to make this header work in non-C++ ObjC files -- they were broken and unused.
        Removed the _bridge method.

        * WebView/WebFrameView.mm: Removed the _bridge method.

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
        (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
        (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
        (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
        (-[WebHTMLRepresentation documentSource]): Ditto.
        (-[WebHTMLRepresentation DOMDocument]): Ditto.
        (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
        (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
        (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
        (-[WebHTMLRepresentation formForElement:]): Ditto.
        (-[WebHTMLRepresentation currentForm]): Ditto.
        (-[WebHTMLRepresentation controlsInForm:]): Ditto.
        (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
        (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.

        * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
        (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
        (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
        (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
        (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
        (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
        (-[WebHTMLView drawSingleRect:]): Ditto.
        (-[WebHTMLView draggedImage:movedTo:]): Ditto.
        (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
        (-[WebHTMLView knowsPageRange:]): Ditto.
        (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
        (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
        (-[WebHTMLView accessibilityHitTest:]): Ditto.
        (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
        (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
        (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
        (-[WebHTMLView _changeSpellingToWord:]): Ditto.
        (-[WebHTMLView startSpeaking:]): Ditto.
        (-[WebHTMLView _updateFontPanel]): Ditto.
        (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
        (-[WebHTMLView _layoutIfNeeded]): Ditto.
        (-[WebHTMLView characterIndexForPoint:]): Ditto.
        (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
        (-[WebHTMLView selectedRange]): Ditto.
        (-[WebHTMLView markedRange]): Ditto.
        (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
        (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
        (-[WebHTMLView insertText:]): Ditto.
        (-[WebTextCompleteController _insertMatch:]): Ditto.
        (-[WebTextCompleteController doCompletion]): Ditto.
        (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
        (-[WebHTMLView string]): Ditto.
        (-[WebHTMLView selectedString]): Ditto.
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
        (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
        (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
        (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
        (-[WebHTMLView unmarkAllTextMatches]): Ditto.
        (-[WebHTMLView rectsForTextMatches]): Ditto.
        * WebView/WebRenderNode.mm:
        (-[WebRenderNode initWithWebFrameView:]): Ditto.
        * WebView/WebResource.mm:
        (-[WebResource _stringValue]): Ditto.

        * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.

        * WebView/WebView.mm:
        (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
        (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
        (-[WebView _setInViewSourceMode:]): Ditto.
        (-[WebView _inViewSourceMode]): Ditto.
        (-[WebView _executeCoreCommandByName:value:]): Ditto.
        (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
        (-[WebView scrollDOMRangeToVisible:]): Ditto.
        (-[WebView setSelectedDOMRange:affinity:]): Ditto.
        (-[WebView setEditable:]): Ditto.
        (-[WebView setTypingStyle:]): Ditto.
        (-[WebView typingStyle]): Ditto.
        (-[WebView replaceSelectionWithNode:]): Ditto.
        (-[WebView replaceSelectionWithText:]): Ditto.
        (-[WebView replaceSelectionWithMarkupString:]): Ditto.
        (-[WebView replaceSelectionWithArchive:]): Ditto.
        (-[WebView _insertNewlineInQuotedContent]): Ditto.
        (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
weinig@apple.com [Thu, 13 Mar 2008 03:40:47 +0000 (03:40 +0000)]
    Reviewed by Anders Carlsson.

        Don't go through the Document just to get the frame Element.

        * page/DOMWindow.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff and Sam.
andersca@apple.com [Thu, 13 Mar 2008 03:18:33 +0000 (03:18 +0000)]
    Reviewed by Geoff and Sam.

        More Instance cleanup:

        * Make Instance inherit from RefCounted instead of doing its own refcounting.
        * Make all Instance subclasses private, add static create methods.
        * Have Instance start out with a refcount of 1.
        * Get rid of Instance::createBindingForLanguageInstance and call the individual
          instance constructor methods instead.
        * Fix many methods to take and return PassRefPtr<Instance> to ensure that the
          refcounting is done correctly.

        * bridge/c/c_instance.h:
        * bridge/c/c_utility.cpp:
        * bridge/jni/jni_instance.cpp:
        * bridge/jni/jni_instance.h:
        * bridge/jni/jni_jsobject.cpp:
        * bridge/jni/jni_runtime.cpp:
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_utility.mm:
        * bridge/qt/qt_instance.cpp:
        * bridge/qt/qt_instance.h:
        * bridge/runtime.cpp:
        * bridge/runtime.h:
        * bridge/runtime_object.cpp:
        * bridge/runtime_object.h:
        * page/Frame.h:
        * page/mac/FrameMac.mm:
        * page/win/FrameWin.cpp:
        * plugins/PluginView.h:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Darin Adler. Reviewed by Dave Hyatt.
mitz@apple.com [Thu, 13 Mar 2008 00:25:55 +0000 (00:25 +0000)]
    Suggested by Darin Adler. Reviewed by Dave Hyatt.

        - speed up BidiIterator::direction()

        * rendering/bidi.cpp:
        (WebCore::BidiIterator::current): Made inline and corrected the
        out-of-bounds condition to work with 0-length text and offsets beyond
        the end of the text.
        (WebCore::BidiIterator::direction): Changed to call current() and not
        call the virtual method isListMarker() most of the time.
        (WebCore::addMidpoint): Removed unnecessary null-check of smidpoints.
        (WebCore::appendRunsForObject): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make URLs not be underlined while editing them in the DOM view
aroben@apple.com [Wed, 12 Mar 2008 23:00:34 +0000 (23:00 +0000)]
    Make URLs not be underlined while editing them in the DOM view

        Reviewed by Tim.

        * page/inspector/inspector.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Part of Bug 17224: DOM nodes/attributes should be editable
aroben@apple.com [Wed, 12 Mar 2008 23:00:00 +0000 (23:00 +0000)]
    Part of Bug 17224: DOM nodes/attributes should be editable


        We now start editing if the user single-clicks on an attribute,
        attribute value, or text node while the parent element is selected.
        Previously, we started editing on double-click regardless of the
        selection state of the element.

        URLs in the DOM tree are now followed on Alt/Option-click, rather than
        on just click.

        Reviewed by Tim.

        * English.lproj/InspectorLocalizedStrings.js: Added four new localized
        * page/inspector/DocumentPanel.js:
        (WebInspector.DOMNodeTreeElement.onattach): Call new
        Added. Changes the tooltip of each link in this element to indicate
        that Alt/Option-click will follow the URL, and sets the
        followOnAltClick property on each link.
        (WebInspector.DOMNodeTreeElement.onselect): Mark that we're being
        (WebInspector.DOMNodeTreeElement.onmousedown): If we're not currently
        being selected, start editing.
        (WebInspector.DOMNodeTreeElement.ondblclick): We no longer start
        editing here. We block re-rooting of the tree if we're currently
          - Don't do anything if we're not focused
          - Pass the event down to _startEditingAttribute.
        (WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't do
        anything if the event target is a URL and the Alt/Option key is
        pressed -- in this case we want to follow the link.
        (WebInspector.DOMNodeTreeElement._updateTitle): Call
        _makeURLsActivateOnClick again since the anchor elements have all been
        * page/inspector/inspector.js:
        (WebInspector.documentClick): If the anchor as a followOnAltClick
        property and the Alt/Option key is not pressed, do nothing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fixed the initial value of zoom factor.
adachan@apple.com [Wed, 12 Mar 2008 22:23:15 +0000 (22:23 +0000)]
    Fixed the initial value of zoom factor.

        Reviewed by Adam.

        * page/Frame.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make full page zoom vaguely work. This patch uses the CSS transform system...
hyatt@apple.com [Wed, 12 Mar 2008 21:41:12 +0000 (21:41 +0000)]
    Make full page zoom vaguely work.  This patch uses the CSS transform system to turn on full page zoom at the
        document level.  There are many many bugs that I'm going to file to track all the issues (most of the issues
        are just bugs with transforms themselves).

        Reviewed by Adam Roben

        * css/CSSStyleSelector.cpp:
        * dom/Document.cpp:
        * page/Frame.cpp:
        * page/Frame.h:
        * rendering/RenderLayer.cpp:
        * rendering/RenderLayer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTouch file to force WebKit rebuild
sfalken@apple.com [Wed, 12 Mar 2008 21:33:57 +0000 (21:33 +0000)]
Touch file to force WebKit rebuild

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
sfalken@apple.com [Wed, 12 Mar 2008 20:57:13 +0000 (20:57 +0000)]
    Build fix.

        * JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-12 Tommi Komulainen <tommi.komulainen@iki.fi>
alp@webkit.org [Wed, 12 Mar 2008 19:40:15 +0000 (19:40 +0000)]
2008-03-12  Tommi Komulainen  <tommi.komulainen@iki.fi>

        Reviewed by Alp Toker.

        WebView signals should use more specific types

        * webkit/webkitwebview.cpp: Use WEBKIT_TYPE_WEB_FRAME argument
        type in "script-alert", "script-confirm", "script-script-prompt"
        signals so that it gets more clearly documented rather than just
        plain GObject.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
hyatt@apple.com [Wed, 12 Mar 2008 19:14:44 +0000 (19:14 +0000)]

        Make the zoom factor a float and not a percent.

        Reviewed by antti

        * WebCore.base.exp:
        * css/CSSStyleSelector.cpp:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FramePrivate.h:
        * svg/SVGSVGElement.cpp:


        Make the zoom factor a float and not a percent.

        Reviewed by antti

        * WebView/WebView.mm:
        (-[WebView _setZoomMultiplier:isTextOnly:]):


        Make the zoom factor a float and not a percent.

        Reviewed by antti

        * WebFrame.cpp:


        Make the zoom factor a float and not a percent.

        Reviewed by antti

        * WebView.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
sfalken@apple.com [Wed, 12 Mar 2008 19:10:19 +0000 (19:10 +0000)]
    Build fix.

        * WebKit.vcproj/WebKit.pgd:
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSpeculative fix for build bustage. Will be another 20-30 mins before I can get compi...
hyatt@apple.com [Wed, 12 Mar 2008 18:50:32 +0000 (18:50 +0000)]
Speculative fix for build bustage.  Will be another 20-30 mins before I can get compiled enough to know for sure.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago VSExpress build fix
sfalken@apple.com [Wed, 12 Mar 2008 18:50:18 +0000 (18:50 +0000)]
    VSExpress build fix

        * WinLauncher/WinLauncher.vcproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
hyatt@apple.com [Wed, 12 Mar 2008 18:33:37 +0000 (18:33 +0000)]

        Eliminate setTextMultiplier from the bridge.  Make Webkit just call setZoomFactor on the frame directly.

        Reviewed by Tim H.

        * WebCore.base.exp:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:


        This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
        New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
        can zoom the page in, out or reset it to the standard size.

        In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
        and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always

        Reviewed by Tim H.

        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
        * WebView/WebDocumentInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView viewDidMoveToSuperview]):
        * WebView/WebPDFView.h:
        * WebView/WebPDFView.mm:
        (-[WebPDFView _zoomOut:]):
        (-[WebPDFView _zoomIn:]):
        (-[WebPDFView _resetZoom:]):
        (-[WebPDFView _canZoomOut]):
        (-[WebPDFView _canZoomIn]):
        (-[WebPDFView _canResetZoom]):
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView setTextSizeMultiplier:]):
        (-[WebView textSizeMultiplier]):
        (-[WebView _setZoomMultiplier:isTextOnly:]):
        (-[WebView _zoomMultiplier:]):
        (-[WebView _realZoomMultiplier]):
        (-[WebView _realZoomMultiplierIsTextOnly]):
        (-[WebView _canZoomOut:]):
        (-[WebView _canZoomIn:]):
        (-[WebView _zoomOut:isTextOnly:]):
        (-[WebView _zoomIn:isTextOnly:]):
        (-[WebView _canResetZoom:]):
        (-[WebView _resetZoom:isTextOnly:]):
        (-[WebView canMakeTextSmaller]):
        (-[WebView makeTextSmaller:]):
        (-[WebView canMakeTextLarger]):
        (-[WebView makeTextLarger:]):
        (-[WebView canMakeTextStandardSize]):
        (-[WebView makeTextStandardSize:]):
        (-[WebView setPageSizeMultiplier:]):
        (-[WebView pageSizeMultiplier]):
        (-[WebView canZoomPageIn]):
        (-[WebView zoomPageIn:]):
        (-[WebView canZoomPageOut]):
        (-[WebView zoomPageOut:]):
        (-[WebView canResetPageZoom]):
        (-[WebView resetPageZoom:]):
        (-[WebView _searchWithSpotlightFromMenu:]):
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 12 Mar 2008 18:31:25 +0000 (18:31 +0000)]

        Reviewed by Darin Adler and Sam Weinig.

        - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard

        Use CTFontCopyGraphicsFont and CTFontGetPlatformFont on Leopard instead
        of wkGetCGFontFromNSFont and wkGetNSFontATSUFontId, relying on NSFont
        and CTFontRef being toll-free bridged.

        * WebCore.Tiger.exp:
        * WebCore.base.exp:
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs): Changed to use the cgFont() accessor.
        * platform/graphics/mac/FontPlatformData.h:
        Made m_cgFont a RetainPtr on Leopard.
        (WebCore::toCTFontRef): Added a function that encapsulates the
        toll-free bridging.
        (WebCore::FontPlatformData::cgFont): Added this accessor method.
        * platform/graphics/mac/FontPlatformDataMac.mm:
        (WebCore::FontPlatformData::FontPlatformData): Changed to use
        CoreText API on Leopard.
        (WebCore::FontPlatformData::setFont): Ditto.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        * platform/mac/WebCoreSystemInterface.mm:


        Reviewed by Darin Adler and Sam Weinig.

        - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
        WKGetNSFontATSUFontId Tiger-only.


        Reviewed by Darin Adler and Sam Weinig.

        - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-12 Holger Hans Peter Freyther <zecke@selfish.org>
alp@webkit.org [Wed, 12 Mar 2008 18:06:54 +0000 (18:06 +0000)]
2008-03-12  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Alp Toker.

        Run testkjs in the correct productsDir in the GTK+ port.

        * Scripts/run-javascriptcore-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Re-enabled PGO.
sfalken@apple.com [Wed, 12 Mar 2008 17:56:13 +0000 (17:56 +0000)]
    Re-enabled PGO.

        Rubber stamped by Mark Rowe.

        * WebKit.vcproj/WebKit.pgd:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKitPrefix.cpp: touched this file to force a re-build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-12 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 12 Mar 2008 17:20:23 +0000 (17:20 +0000)]
2008-03-12  Alp Toker  <alp@atoker.com>

        Another autotools testkjs build fix attempt.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix http://bugs.webkit.org/show_bug.cgi?id=17794
darin@apple.com [Wed, 12 Mar 2008 16:38:25 +0000 (16:38 +0000)]
    - fix bugs.webkit.org/show_bug.cgi?id=17794
          REGRESSION (r30980): 23 tests hanging on the Mac buildbot

        * WebView/WebFrame.mm:
        (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
        up pointer from the bridge to the frame. (My next check-in removes the bridge
        entirely, but we need this until then.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison@apple.com [Wed, 12 Mar 2008 16:16:40 +0000 (16:16 +0000)]
    Reviewed by Darin.

        <rdar://problem/5607382> CrashTracer: [REGRESSION] 2290 crashes in Safari at com.apple.WebCore: -[WebCoreAXObject isWebArea] + 8

        The problem was that we lost track of the AX cache for a subframe when Frame::disconnectOwnerElement() was
        called, so we were unable to locate the AXObjects to de-register from AppKit's accessibility registry.
        Also saw that cache clearing was missing from Document::detach(), and fixed that.

        Also added a debug-only check that AXObjectCache::remove() not finding the AXObject is expected.

        Lastly, RenderWidget::destroy() now skips trying to remove the AXObject if accessibility has never been enabled.

        * dom/Document.cpp:
        Assert that there is no AX cache (since there is no renderer).

        Destroy the AX cache installed on this document.

        New. Destroy the AX cache associated with this document.

        Added some comments.

        * dom/Document.h:
        Declare clearAXObjectCache().

        * page/Frame.cpp:
        Destroy the AX cache associated with this frame's document.

        * page/mac/AXObjectCacheMac.mm:
        * page/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject initWithRenderer:]):
        (-[WebCoreAXObject detach]):
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        Add debug-only check that AXObjectCache::remove() not finding the AXObject is expected.

        * rendering/RenderWidget.cpp:
        Skip call to remove the AXObject if accessibility has never been enabled. A simple speed optimization in the
        very common case that the accessibility APIs are not being used. Same as in RenderObject::destroy().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-03-12 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 12 Mar 2008 16:12:46 +0000 (16:12 +0000)]
2008-03-12  Alp Toker  <alp@atoker.com>

        Attempt to fix the autotools testkjs build on systems with
        non-standard include paths.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30991 268f45cc-cd09-0410-ab3c-d52691b4dbfc