WebKit.git
10 years agoTeach resolve-ChangeLogs to act as a merge-driver for Git
vestbo@webkit.org [Thu, 18 Feb 2010 15:51:35 +0000 (15:51 +0000)]
Teach resolve-ChangeLogs to act as a merge-driver for Git

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28721

To enable automatic merging of ChangeLog files, use the following command:

git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"

The driver always works in "downstream" merge mode, meaning
it will always put the user's changelog entries on top.

* Scripts/resolve-ChangeLogs:
* .gitattributes: Add instruction to use merge-driver for ChangeLogs

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Thu, 18 Feb 2010 14:27:17 +0000 (14:27 +0000)]
2010-02-18  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] WebKitDownload documentation is incomplete
        https://bugs.webkit.org/show_bug.cgi?id=35018

        Concretely the error signal was undocumented. Also two relevant enums
        were not included.

        * docs/webkitgtk-sections.txt:
        * docs/webkitgtk.types:
        * webkit/webkitdownload.cpp:
        (webkit_download_class_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Ben Murdoch <benm@google.com>
benm@google.com [Thu, 18 Feb 2010 14:22:53 +0000 (14:22 +0000)]
2010-02-18  Ben Murdoch  <benm@google.com>

        Reviewed by Jeremy Orlow.

        [v8] Complete upstreaming of V8 Touch Event bindings
        https://bugs.webkit.org/show_bug.cgi?id=35094

        No new tests required.

        * bindings/v8/V8Index.cpp: Add generated touch event headers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Steve Block <steveblock@google.com>
steveblock@google.com [Thu, 18 Feb 2010 14:12:37 +0000 (14:12 +0000)]
2010-02-18  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Updates Android V8 build to use DerivedSourcesAllInOne.cpp
        https://bugs.webkit.org/show_bug.cgi?id=35083

        No new tests, build fix only.

        * Android.derived.v8bindings.mk:
        * Android.v8bindings.mk:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-12-05 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Thu, 18 Feb 2010 13:32:19 +0000 (13:32 +0000)]
2009-12-05  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Eric Seidel.

        Enable running of GTK+ API tests.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * Scripts/run-gtk-tests: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 18 Feb 2010 13:27:22 +0000 (13:27 +0000)]
2010-02-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        fast/frames/iframe-reparenting.html crashing on GTK Debug bots
        https://bugs.webkit.org/show_bug.cgi?id=35081

        Check that the client is alive after every call to it, since any
        of them could cause the load to be cancelled, and the client to go
        away.

        This is much better than protecting a specific subclass of
        ResourceHandleClient (ResourceLoader), which makes us fail when
        any other client is used.

        Test: fast/frames/iframe-reparenting.html

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::parseDataUrl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
ossy@webkit.org [Thu, 18 Feb 2010 12:00:28 +0000 (12:00 +0000)]
[Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
https://bugs.webkit.org/show_bug.cgi?id=35086

fast/xmlhttprequest/xmlhttprequest-no-file-access.html cause
this fail indirectly, but both of them pass in separated DRT.

* platform/qt/Skipped: fast/xmlhttprequest/xmlhttprequest-no-file-access.html
skipped until fix to make buildbot happy.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 18 Feb 2010 11:46:57 +0000 (11:46 +0000)]
2010-02-18  Philippe Normand  <pnormand@igalia.com>

        Not reviewed, adding a GTK layout test result for a new test
        added in r54926.

        * platform/gtk/fast/css/first-letter-first-line-hover-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 18 Feb 2010 11:37:29 +0000 (11:37 +0000)]
2010-02-18  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Xan Lopez.

        plugins/iframe-shims.html crashing on GTK Debug bots
        https://bugs.webkit.org/show_bug.cgi?id=35085

        * platform/gtk/Skipped: Skip crashing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 18 Feb 2010 10:29:35 +0000 (10:29 +0000)]
2010-02-18  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Xan Lopez.

        fast/frames/iframe-reparenting.html crashing on GTK Debug bots
        https://bugs.webkit.org/show_bug.cgi?id=35081

        * platform/gtk/Skipped: Skip crashing test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[v8] [Android] V8 bindings for touch events are missing.
benm@google.com [Thu, 18 Feb 2010 10:21:25 +0000 (10:21 +0000)]
[v8] [Android] V8 bindings for touch events are missing.
https://bugs.webkit.org/show_bug.cgi?id=33795

Reviewed by Nate Chapin.

No new tests as this just enables touch events in V8. Existing touch tests suffice.

* WebCore.gypi: Add Touch idl files.
* bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map.
* bindings/v8/DOMObjectsInclude.h: Add touch headers.
* bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings.
* bindings/v8/V8Index.h: Add touch DOM object types.
* bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event.
* Android.derived.jscbindings.mk: Add the touch derived sources to the makefile.
* Android.derived.v8bindings.mk: Add the touch derived sources to the makefile.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 18 Feb 2010 10:07:28 +0000 (10:07 +0000)]
2010-02-18  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Xan Lopez.

        fast/css/font-face-opentype.html crashing on GTK bots
        https://bugs.webkit.org/show_bug.cgi?id=35080

        * platform/gtk/Skipped: Skip crashing test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Jay Campan <jcampan@google.com>
eric@webkit.org [Thu, 18 Feb 2010 09:27:03 +0000 (09:27 +0000)]
2010-02-18  Jay Campan  <jcampan@google.com>

        Reviewed by Adam Barth.

        Exposing the title in WebDocument.

        https://bugs.webkit.org/show_bug.cgi?id=35058

        * public/WebDocument.h:
        * src/WebDocument.cpp:
        (WebKit::WebDocument::title):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 18 Feb 2010 09:17:37 +0000 (09:17 +0000)]
2010-02-18  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adam Barth.

        debug-safari doesn't pass --debug option to gdb-safari on MacOSX
        https://bugs.webkit.org/show_bug.cgi?id=34411

        * Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 William Chan <willchan@chromium.org>
eric@webkit.org [Thu, 18 Feb 2010 09:10:54 +0000 (09:10 +0000)]
2010-02-18  William Chan  <willchan@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=35071
        Disable loader limiting of requests per host for the chromium port.

        No tests because we're only changing a constant.

        * platform/network/chromium/ResourceRequest.cpp:
        (WebCore::initializeMaximumHTTPConnectionCountPerHost):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 18 Feb 2010 08:54:47 +0000 (08:54 +0000)]
2010-02-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
        https://bugs.webkit.org/show_bug.cgi?id=35053

        * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
        * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
        * Scripts/webkitpy/layout_tests/port/mac.py:
         - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
         - Call build-dumprendertree (and make sure it succeeds) before running the tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Chris Evans <cevans@chromium.org>
eric@webkit.org [Thu, 18 Feb 2010 08:38:32 +0000 (08:38 +0000)]
2010-02-18  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Add the promised test for the unique file:// origins support.
        See https://bugs.webkit.org/show_bug.cgi?id=34778 for more details.

        * fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Added.
        * fast/xmlhttprequest/resources/xmlhttprequest-no-file-access-real.html: Added.
        * fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
sfalken@apple.com [Thu, 18 Feb 2010 08:36:39 +0000 (08:36 +0000)]
WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
https://bugs.webkit.org/show_bug.cgi?id=35076

Reviewed by Dan Bernstein.

WebKit/win:

* WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
* WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
* WebKitGraphics.cpp:
(WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.
* WebKitGraphics.h: Added WebKitSystemParameterChanged.

WebKitLibraries:

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib: Updated to add wkSystemFontSmoothingChanged.
* win/lib/WebKitSystemInterface_debug.lib: Updated to add wkSystemFontSmoothingChanged.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Chris Jerdonek <cjerdonek@webkit.org>
hamaji@chromium.org [Thu, 18 Feb 2010 08:17:39 +0000 (08:17 +0000)]
2010-02-16  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Refactored check-webkit-style's ProcessorOptions class into two
        classes. This revision contains no new functionality.

        https://bugs.webkit.org/show_bug.cgi?id=34674

        Divided the ProcessorOptions class into a CommandOptionValues
        class (the result of parsing the command-line options) and
        a StyleCheckerConfiguration class (which configures the main
        StyleChecker).

        * Scripts/check-webkit-style:
          - Updated main() to convert the parsed command option values
            to a StyleCheckConfiguration instance prior to constructing
            a StyleChecker.

        * Scripts/webkitpy/style/checker.py:
          - Added check_webkit_style_configuration() to convert a
            CommandOptionValues instance into a StyleCheckerConfiguration
            instance.
          - Renamed the ProcessorOptions class to CommandOptionValues.
          - In the CommandOptionValues class--
            - Replaced the filter_configuration attribute with the
              simpler filter_rules attribute.
            - Removed the max_reports_per_error attribute.
            - Moved the is_reportable() method to the new
              StyleCheckerConfiguration class.
          - Removed the base_filter_rules attribute from the
            DefaultCommandOptionValues class.
          - In the ArgumentParser class--
            - Added base_filter_rules to the constructor.
            - Changed the parse() method to return a CommandOptionValues
              instance instead of a ProcessorOptions instance.
          - Created a StyleCheckerConfiguration class.
            - Added the data attributes max_reports_per_category,
              stderr_write, and verbosity.
            - Added is_reportable() (moved from the ProcessorOptions
              class) and write_style_error() (moved from the
              DefaultStyleErrorHandler class).
          - In the StyleChecker class--
            - Replaced the ProcessorOptions options attribute with the
              StyleCheckerConfiguration _configuration attribute.
            - Removed the _stderr_write attribute.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Updated the existing unit test classes as necessary.
          - Added a StyleCheckerConfigurationTest class.

        * Scripts/webkitpy/style/error_handlers.py:
          - Updated the DefaultStyleErrorHandler class to accept a
            StyleCheckerConfiguration instance instead of a ProcessorOptions
            instance and an stderr_write method.

        * Scripts/webkitpy/style/error_handlers_unittest.py:
          - Updated the unit test classes as necessary.

        * Scripts/webkitpy/style/filter.py:
          - Addressed the FIXME in the FilterConfiguration class to change
            the user_rules attribute to _user_rules (since it is now
            accessed only internally).

        * Scripts/webkitpy/style/filter_unittest.py:
          - Updated to reflect the change from user_rules to _user_rules.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 18 Feb 2010 08:17:27 +0000 (08:17 +0000)]
2010-02-18  Tony Chang  <tony@chromium.org>

        Not reviewed, adding a QT layout test result for a new test
        added in r54932.

        * platform/qt/editing/pasteboard/page-zoom-expected.txt: Copied from LayoutTests/platform/gtk/editing/pasteboard/page-zoom-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-18 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 18 Feb 2010 08:06:03 +0000 (08:06 +0000)]
2010-02-18  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        The NP Version supported by WebKit is at the moment hardcoded in
        PluginPackage.cpp (to 24), but not all backends actually implement
        the methods needed to claim this. Introduce a new method to be
        implemented by each backend where the maximum supported version
        can be specified, and set the GTK+ port NPVersion to 19. This
        fixes an instantaneous crasher in the Sun Java NPAPI plugin.

        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::initializeBrowserFuncs):
        * plugins/PluginPackage.h:
        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::NPVersion):
        * plugins/mac/PluginPackageMac.cpp:
        (WebCore::PluginPackage::NPVersion):
        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::PluginPackage::NPVersion):
        * plugins/symbian/PluginPackageSymbian.cpp:
        (WebCore::PluginPackage::NPVersion):
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::NPVersion):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] editing/pasteboard/page-zoom.html fails
ossy@webkit.org [Thu, 18 Feb 2010 08:04:55 +0000 (08:04 +0000)]
[Qt] editing/pasteboard/page-zoom.html fails
https://bugs.webkit.org/show_bug.cgi?id=35077

* platform/qt/Skipped: editing/pasteboard/page-zoom.html skipped until fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen a live iframe element is moved between pages, it still depends on the old page.
dimich@chromium.org [Thu, 18 Feb 2010 07:55:06 +0000 (07:55 +0000)]
When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Reviewed by David Levin, Darin Fisher, Simon Hausmann.

WebCore:

Test: fast/frames/iframe-reparenting-new-page.html

* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateOnReparenting):
Called on the frame that was just re-parented and inserted into another Document.
Simply invoke Frame::transferChildFrameToNewDocument(...);

(WebCore::HTMLFrameElementBase::insertedIntoDocument):
* html/HTMLFrameElementBase.h:
* html/HTMLFrameOwnerElement.h:
(WebCore::HTMLFrameOwnerElement::setName):
Make this a virtual function, to be able to reach it via Frame::m_ownerElement.

* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::adoptFrame):
* loader/FrameLoaderClient.h:
Add a new method, didTransferChildFrameToNewDocument().
It compliments createFrame() in that a frame which was re-parented
in DOM and potentially changes Page, should notify the WebKit
implementation about potential ownership change.
Many embedders assume that Page owns all the Frames, or at least
all Frames are destroyed before 'their' Page is destroyed. Obviously, if Frame
can be transferred to another Page, the embedders should be notified.

* page/Frame.cpp:
(WebCore::Frame::transferChildFrameToNewDocument):
Added, makes actual adjustments for Frame - resets the Page,
updates the frame tree and frame name, calls to FrameLoaderClient
to update external objects and recurses into children.
Can only be used on child frames.

* page/Frame.h:

WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::detachedFromParent3):
(WebKit::FrameLoaderClientImpl::didTransferChildFrameToNewDocument):
Since Chromium's WebFrameClient is destroyed once a window is closed,
if Frame moves between Pages, the client of corresponding WebFrame
should be replaced as well.

* src/FrameLoaderClientImpl.h:
* src/WebFrameImpl.h:
(WebKit::WebFrameImpl::setClient):

WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.

* WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.

* WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
Added empty implementation of a new virtual method.

(WebFrameLoaderClient::didTransferChildFrameToNewDocument):

WebKit/qt:

* Api/qwebframe_p.h:
(QWebFramePrivate::setPage): Added.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didTransferChildFrameToNewDocument):
The QWebFrame caches a QWebPage which should be replaced when Frame is re-parented.
Also, the QWebFrame is a child (in QT terms) of QWebPage - so update that relationship as well.
Emit a signal that QWebFrame moved to a different QWebPage.

* WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.

* WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.

* WebKitSupport/FrameLoaderClientWx.h:

LayoutTests:

* fast/frames/iframe-reparenting-new-page-expected.txt: Added.
* fast/frames/iframe-reparenting-new-page.html: Added.
* fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
* fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
* fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
* fast/frames/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/canvas/script-tests/TEMPLATE.html.
* fast/frames/script-tests/iframe-reparenting-new-page.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [Qt] DRT: Get total number of pages to be printed
ossy@webkit.org [Thu, 18 Feb 2010 07:49:15 +0000 (07:49 +0000)]
 [Qt] DRT: Get total number of pages to be printed
 https://bugs.webkit.org/show_bug.cgi?id=34955

 Fix landed in r54902, so we can unskip the test.

* platform/qt/Skipped: printing/numberOfPages.html unskipped.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fails glyph reordering test fast/text/glyph-reordering.html
ossy@webkit.org [Thu, 18 Feb 2010 07:41:32 +0000 (07:41 +0000)]
[Qt] Fails glyph reordering test fast/text/glyph-reordering.html
https://bugs.webkit.org/show_bug.cgi?id=34918

Fix landed in r54912, so we can unskip the test.

* platform/qt/Skipped: fast/text/glyph-reordering.html unskipped.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 18 Feb 2010 07:30:19 +0000 (07:30 +0000)]
2010-02-17  Tony Chang  <tony@chromium.org>

        Not reviewed, adding a GTK+ layout test result for a new test
        added in r54932.

        https://bugs.webkit.org/show_bug.cgi?id=34914

        * platform/gtk/editing/pasteboard/page-zoom-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactored check-webkit-style's ProcessorOptions class into two
cjerdonek@webkit.org [Thu, 18 Feb 2010 07:29:12 +0000 (07:29 +0000)]
Refactored check-webkit-style's ProcessorOptions class into two
classes. This revision contains no new functionality.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34674

Divided the ProcessorOptions class into a CommandOptionValues
class (the result of parsing the command-line options) and
a StyleCheckerConfiguration class (which configures the main
StyleChecker).

* Scripts/check-webkit-style:
  - Updated main() to convert the parsed command option values
    to a StyleCheckConfiguration instance prior to constructing
    a StyleChecker.

* Scripts/webkitpy/style/checker.py:
  - Added check_webkit_style_configuration() to convert a
    CommandOptionValues instance into a StyleCheckerConfiguration
    instance.
  - Renamed the ProcessorOptions class to CommandOptionValues.
  - In the CommandOptionValues class--
    - Replaced the filter_configuration attribute with the
      simpler filter_rules attribute.
    - Removed the max_reports_per_error attribute.
    - Moved the is_reportable() method to the new
      StyleCheckerConfiguration class.
  - Removed the base_filter_rules attribute from the
    DefaultCommandOptionValues class.
  - In the ArgumentParser class--
    - Added base_filter_rules to the constructor.
    - Changed the parse() method to return a CommandOptionValues
      instance instead of a ProcessorOptions instance.
  - Created a StyleCheckerConfiguration class.
    - Added the data attributes max_reports_per_category,
      stderr_write, and verbosity.
    - Added is_reportable() (moved from the ProcessorOptions
      class) and write_style_error() (moved from the
      DefaultStyleErrorHandler class).
  - In the StyleChecker class--
    - Replaced the ProcessorOptions options attribute with the
      StyleCheckerConfiguration _configuration attribute.
    - Removed the _stderr_write attribute.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated the existing unit test classes as necessary.
  - Added a StyleCheckerConfigurationTest class.

* Scripts/webkitpy/style/error_handlers.py:
  - Updated the DefaultStyleErrorHandler class to accept a
    StyleCheckerConfiguration instance instead of a ProcessorOptions
    instance and an stderr_write method.

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Updated the unit test classes as necessary.

* Scripts/webkitpy/style/filter.py:
  - Addressed the FIXME in the FilterConfiguration class to change
    the user_rules attribute to _user_rules (since it is now
    accessed only internally).

* Scripts/webkitpy/style/filter_unittest.py:
  - Updated to reflect the change from user_rules to _user_rules.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 18 Feb 2010 07:12:13 +0000 (07:12 +0000)]
2010-02-17  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26937
        No longer allow span styles to surround block elements like
        divs when pasting (see paste-text-012 and 5065605 which had divs in
        spans).  This also causes a few cases of empty spans to be removed
        (see 19089 and 5245519).

        * editing/execCommand/19089-expected.txt:
        * editing/pasteboard/5245519-expected.txt:
        * editing/pasteboard/5245519.html:
        * platform/mac/editing/pasteboard/5065605-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-011-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
2010-02-17  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Copying and pasting into a contenteditable area can create <div>s surrounded by <span>s
        https://bugs.webkit.org/show_bug.cgi?id=26937

        This happens because of a span added when we copy that is used to
        preserve styles.  To avoid this, when we paste, make sure to apply
        the styles to the span's children and then remove the style span.

        This change is covered by existing layout tests.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::handleStyleSpans):
        (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
        * editing/ReplaceSelectionCommand.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Tony Chang <tony@chromium.org>
eric@webkit.org [Thu, 18 Feb 2010 06:44:48 +0000 (06:44 +0000)]
2010-02-17  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=34914
        When pasting absolute font sizes into a content editable area with
        page zoom, adjust the font sizes to be the same after page zoom is
        applied.

        * editing/pasteboard/page-zoom-expected.txt: Added.
        * editing/pasteboard/page-zoom.html: Added.
2010-02-17  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=34914
        When pasting absolute font sizes into a content editable area with
        page zoom, adjust the font sizes to be the same after page zoom is
        applied.

        Test: editing/pasteboard/page-zoom.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Tony Chang <tony@chromium.org>
eric@webkit.org [Thu, 18 Feb 2010 06:28:30 +0000 (06:28 +0000)]
2010-02-17  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=34737
        Test to verify that pasting styled list items works
        the same as pasting unstyle list items.

        * editing/pasteboard/paste-list-003-expected.txt: Added.
        * editing/pasteboard/paste-list-003.html: Added.
2010-02-17  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=34737
        Copying styled list items then pasting into a list
        should work the same as copying unstyle list items:
        it shouldn't indent an extra level, but styles should
        be copied.

        Small cleanups to insertAsListItems to make variable names
        more descriptive.

        Test: editing/pasteboard/paste-list-003.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::insertAsListItems):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 18 Feb 2010 06:12:07 +0000 (06:12 +0000)]
2010-02-17  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port PlatformKeyboardEvent
        https://bugs.webkit.org/show_bug.cgi?id=34794

        Retrieve the type, key code, text and modifiers from BREW's keyboard event.

        * platform/PlatformKeyboardEvent.h:
        * platform/brew/PlatformKeyboardEventBrew.cpp: Added.
        (WebCore::keyIdentifierForBrewKeyCode):
        (WebCore::windowsKeyCodeForKeyEvent):
        (WebCore::singleCharacterString):
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
        (WebCore::PlatformKeyboardEvent::currentCapsLockState):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Hayato Ito <hayato@chromium.org>
eric@webkit.org [Thu, 18 Feb 2010 05:55:17 +0000 (05:55 +0000)]
2010-02-17  Hayato Ito  <hayato@chromium.org>

        Reviewed by Eric Seidel.

        Support CSS page-break-inside with a value of 'avoid'.

        https://bugs.webkit.org/show_bug.cgi?id=34080

        * printing/page-break-inside-expected.txt: Added.
        * printing/page-break-inside.html: Added.
        * printing/script-tests/page-break-inside.js: Added.
        (createParagraph):
        (pageNumber):
2010-02-17  Hayato Ito  <hayato@chromium.org>

        Reviewed by Eric Seidel.

        Support CSS page-break-inside with a value of 'avoid'.

        https://bugs.webkit.org/show_bug.cgi?id=34080

        Test: printing/page-break-inside.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Evan Martin <evan@chromium.org>
eric@webkit.org [Thu, 18 Feb 2010 05:38:26 +0000 (05:38 +0000)]
2010-02-17  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] expose cache-bypass flag in reload() API
        https://bugs.webkit.org/show_bug.cgi?id=34969

        This flag is used to force a reload to ignore caches.
        (Aka "shift-reload".)

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::reload):
        * src/WebFrameImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 18 Feb 2010 05:32:05 +0000 (05:32 +0000)]
2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket bufferedAmount should not be 0 when send after close.
        https://bugs.webkit.org/show_bug.cgi?id=34633

        * websocket/tests/bufferedAmount-after-close-expected.txt: Added.
        * websocket/tests/bufferedAmount-after-close.html: Added.
        * websocket/tests/script-tests/bufferedAmount-after-close.js: Added.
2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket bufferedAmount should not be 0 when send after close.
        https://bugs.webkit.org/show_bug.cgi?id=34633

        Fixed bug in webkit r54694.  check m_client after it calls user
        callback, because user callback may call close(), which would
        call onclose event handler.

        Test: websocket/tests/bufferedAmount-after-close.html

        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::WebSocket):
        (WebCore::WebSocket::send):
        (WebCore::WebSocket::close):
        (WebCore::WebSocket::bufferedAmount):
        (WebCore::WebSocket::didConnect):
        (WebCore::WebSocket::didClose):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::send):
        (WebCore::WebSocketChannel::bufferedAmount):
        (WebCore::WebSocketChannel::didClose):
        (WebCore::WebSocketChannel::didReceiveData):
        * websockets/WebSocketChannel.h:
        * websockets/WebSocketChannelClient.h:
        (WebCore::WebSocketChannelClient::didClose):
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::workerContextDidClose):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
        * websockets/WorkerThreadableWebSocketChannel.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Thu, 18 Feb 2010 05:14:59 +0000 (05:14 +0000)]
2010-02-17  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        In diffing render styles, consider all pseudo style changes.
        Without this patch, only :before and :after are considered. This is the cause of the following bug.
        https://bugs.webkit.org/show_bug.cgi?id=32187

        * fast/css/first-letter-first-line-hover.html: Added.
        * platform/mac/fast/css/first-letter-first-line-hover-expected.checksum: Added.
        * platform/mac/fast/css/first-letter-first-line-hover-expected.png: Added.
        * platform/mac/fast/css/first-letter-first-line-hover-expected.txt: Added.
2010-02-17  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        In diffing render styles, consider all pseudo style changes.
        Without this patch, only :before and :after are considered. This is the cause of the following bug.
        https://bugs.webkit.org/show_bug.cgi?id=32187

        Test: fast/css/first-letter-first-line-hover.html

        * dom/Node.cpp:
        (WebCore::Node::diff):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::hasAnyPublicPseudoStyles):
        * rendering/style/RenderStyle.h:
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=35070
barraclough@apple.com [Thu, 18 Feb 2010 05:07:41 +0000 (05:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=35070
Addition of 2 strings of length 2^31 may result in a string of length 0.

Reviewed by Oliver Hunt.

Check for overflow when creating a new JSString as a result of an addition
or concatenation, throw an out of memory exception.

* runtime/JSString.h:
(JSC::):
* runtime/Operations.h:
(JSC::jsString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 18 Feb 2010 04:55:12 +0000 (04:55 +0000)]
2010-02-17  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add WebCore::prefetchDNS
        https://bugs.webkit.org/show_bug.cgi?id=34873

        DNS prefetching is not implemented because the maximum number
        of UDP sockets is quite small in most BREW devices.

        * platform/network/brew/DNSBrew.cpp: Added.
        (WebCore::prefetchDNS):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 18 Feb 2010 04:36:36 +0000 (04:36 +0000)]
2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        It's hard for Chromium port to load an icon inside
        Icon::createIconForFiles() because of sanbox and multi-process
        architecture. So this change adds a method to request an icon to
        Chrome class, and makes FileChooser receives an Icon instance
        asynchronously.  Synchronous loading also works with the new interface.

        Because all ports don't have implementations of Chrome::iconForFiles()
        yet, FileChooser tries to load an Icon synchronously with
        Icon::createIconForFiles(), then tries to load an Icon asynchronously
        with Chrome::iconForFiles() if Icon::createIconForFiles() returns 0.

        The existing Icon::createIconForFiles() implementations should be
        moved to Chrome::iconForFiles(). We're going to remove
        Icon::createIconForFiles().

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::iconForFiles): Add an empty implementation.
        * page/Chrome.cpp:
        (WebCore::Chrome::iconForFiles): Delegate to ChromeClient::iconForFiles().
        * page/Chrome.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::iconForFiles): Add a declaration as a pure virtual method.
        * platform/FileChooser.cpp:
        (WebCore::FileChooser::FileChooser): Use loadIcon().
        (WebCore::FileChooser::chooseFiles): ditto.
        (WebCore::FileChooser::loadIcon): Added.
        (WebCore::FileChooser::iconLoaded): Added.
        * platform/FileChooser.h: Add two methods to FileChooserClient; repaint() and iconForFiles().
        * platform/graphics/Icon.h: Add a FIXME comment.
        * platform/graphics/gtk/IconGtk.cpp: ditto.
        * platform/graphics/mac/IconMac.mm: ditto.
        * platform/graphics/qt/IconQt.cpp: ditto.
        * platform/graphics/win/IconWin.cpp: ditto.
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::iconForFiles): Delegate to Chrome::iconForFiles().
        (WebCore::RenderFileUploadControl::click): Use chrome().
        (WebCore::RenderFileUploadControl::chrome):
        * rendering/RenderFileUploadControl.h:
        (WebCore::RenderFileUploadControl::repaint):

2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        Add an empty implementation of ChromeClient::iconForFiles().

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::iconForFiles):
        * src/ChromeClientImpl.h:

2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        Add an empty implementation of ChromeClient::iconForFiles().

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::iconForFiles):
        * WebCoreSupport/ChromeClientGtk.h:

2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        Add an empty implementation of ChromeClient::iconForFiles().

        * WebCoreSupport/ChromeClientHaiku.cpp:
        (WebCore::ChromeClientHaiku::iconForFiles):
        * WebCoreSupport/ChromeClientHaiku.h:

2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        Add an empty implementation of ChromeClient::iconForFiles().

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::iconForFiles):

2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        Add an empty implementation of ChromeClient::iconForFiles().

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::iconForFiles):
        * WebCoreSupport/ChromeClientQt.h:

2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        Add an empty implementation of ChromeClient::iconForFiles().

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::iconForFiles):
        * WebCoreSupport/WebChromeClient.h:

2010-02-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces new Icon loading interface in order to support
        asynchronous loading.
        https://bugs.webkit.org/show_bug.cgi?id=32054

        Add an empty implementation of ChromeClient::iconForFiles().

        * WebKitSupport/ChromeClientWx.cpp:
        (WebCore::ChromeClientWx::iconForFiles):
        * WebKitSupport/ChromeClientWx.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 18 Feb 2010 04:19:03 +0000 (04:19 +0000)]
2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed. Touch WebKit.idl to fix the build.

        [Win] Implement test functions for printing
        https://bugs.webkit.org/show_bug.cgi?id=34570

        * Interfaces/WebKit.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 18 Feb 2010 02:42:00 +0000 (02:42 +0000)]
2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [Win] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34570

        * platform/win/Skipped:
2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [Win] Implement test functions for printing
        https://bugs.webkit.org/show_bug.cgi?id=34570

        * Interfaces/IWebFramePrivate.idl:
        * WebFrame.cpp:
        (WebFrame::pageNumberForElementById):
        (WebFrame::numberOfPages):
        * WebFrame.h:
2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [Win] Implement test functions for printing
        https://bugs.webkit.org/show_bug.cgi?id=34570

        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::pageNumberForElementById):
        (LayoutTestController::numberOfPages):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 18 Feb 2010 02:19:37 +0000 (02:19 +0000)]
2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=35001

        * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 35065: Delay between page loading and animated GIF playing
mrowe@apple.com [Thu, 18 Feb 2010 02:19:30 +0000 (02:19 +0000)]
Bug 35065: Delay between page loading and animated GIF playing
<http://webkit.org/b/35065> / <rdar://problem/7109548>

Reviewed by Darin Adler.

BitmapImage::startAnimation was adding the current frame duration to the desired start time
of the frame for every time it was called.  If the function then bailed out due to not having
sufficient data to render the frame, this would lead to the desired start time of the frame
being pushed out multiple times.  On an animated GIF that took mulitple seconds to load this
could happen many times for a single frame, resulting in the start time of the second frame
of the animation being pushed out by as much as five seconds.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation): Change the order of the code slightly so that the
desired start time is only updated after determining that we have sufficient data to handle
the next frame.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 18 Feb 2010 02:13:03 +0000 (02:13 +0000)]
2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style: Misses variables that contain underscores.
        https://bugs.webkit.org/show_bug.cgi?id=33724

        - Check identifiers whose types are unsigned.
        - Check bitfields properly.

        * Scripts/webkitpy/style/processors/cpp.py:
        * Scripts/webkitpy/style/processors/cpp_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 18 Feb 2010 02:00:10 +0000 (02:00 +0000)]
2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style should report the number of files checked
        https://bugs.webkit.org/show_bug.cgi?id=34971

        * Scripts/check-webkit-style:
        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Thu, 18 Feb 2010 01:35:26 +0000 (01:35 +0000)]
2010-02-17  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by Eric Seidel.

        Implemented homeDirectoryPath() and listDirectory() on the Haiku platform.
        https://bugs.webkit.org/show_bug.cgi?id=34687

        Covered by existing tests.

        * platform/haiku/FileSystemHaiku.cpp:
        (WebCore::homeDirectoryPath): Implemented
        (WebCore::listDirectory): Implemented

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 18 Feb 2010 01:19:10 +0000 (01:19 +0000)]
2010-02-17  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port userIdleTime
        https://bugs.webkit.org/show_bug.cgi?id=34259

        Return an arbitrarily high userIdleTime so that releasing pages from the page
        cache isn't postponed.

        * platform/brew/SystemTimeBrew.cpp: Added.
        (WebCore::userIdleTime):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoActually land the changes to the Skipped list
bweinstein@apple.com [Thu, 18 Feb 2010 00:51:22 +0000 (00:51 +0000)]
Actually land the changes to the Skipped list

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Dan Bernstein.
bweinstein@apple.com [Thu, 18 Feb 2010 00:50:44 +0000 (00:50 +0000)]
Rubber-stamped by Dan Bernstein.

Unskip glyph-reordering, because now it passes on Windows.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html
mitz@apple.com [Thu, 18 Feb 2010 00:28:18 +0000 (00:28 +0000)]
[GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html
https://bugs.webkit.org/show_bug.cgi?id=34918

Reviewed by Eric Seidel.

Made the test less dependent on the complex text implementation.

* fast/text/glyph-reordering-expected.txt:
* fast/text/glyph-reordering.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 17 Feb 2010 23:10:57 +0000 (23:10 +0000)]
2010-02-17  Dirk Schulze  <krit@webkit.org>

        Rolling out r54909. Breaks SL and Win.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix Chromium's bindings for Database.transaction(): a 'null'
dumi@chromium.org [Wed, 17 Feb 2010 22:29:41 +0000 (22:29 +0000)]
WebCore: Fix Chromium's bindings for Database.transaction(): a 'null'
callback should be treated as no callback.

Reviewed by Dimitri Glazkov.

Test: storage/null-callbacks.html

https://bugs.webkit.org/show_bug.cgi?id=35047

* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::createTransaction):

LayoutTests: Add a test that verifies that null transaction callbacks are
accepted and treated as no callbacks.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=35047

* storage/null-callbacks-expected.txt: Added.
* storage/null-callbacks.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 17 Feb 2010 22:12:55 +0000 (22:12 +0000)]
2010-02-17  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Move SVGResources to Renderers, starting with Masker
        https://bugs.webkit.org/show_bug.cgi?id=35020

        We have rendering specific code in WebCore/svg/graphics. The goal is to move
        this code into suitable Renderers. This helps us to clean up the code and makes
        maintenance easier. It also makes it possible to remove rendering specific code
        from SVG*Elements into this renderers. So the Renderer contains everything that
        is needed to use the resource.
        RenderSVGResource will be the base class for all new resource render classes like
        RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.

        This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
        Another benefit is the much more useful result in DRT on using masker.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
        * rendering/RenderPath.cpp:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
        * rendering/RenderSVGImage.h: Some code clean up according to the webkit style.
        (WebCore::RenderSVGImage::toSVGRenderBase):
        (WebCore::RenderSVGImage::renderName):
        (WebCore::RenderSVGImage::isSVGImage):
        (WebCore::RenderSVGImage::localToParentTransform):
        (WebCore::RenderSVGImage::strokeBoundingBox):
        (WebCore::RenderSVGImage::requiresLayer):
        (WebCore::RenderSVGImage::localTransform):
        * rendering/RenderSVGInlineText.h:
        (WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGResource.h: Added.
        (WebCore::): Base class for all Resource renderers like masker, clipper and others.
        (WebCore::RenderSVGResource::RenderSVGResource):
        (WebCore::RenderSVGResource::cast):
        (WebCore::RenderSVGResource::toRenderSVGResource):
        (WebCore::RenderSVGResource::isSVGResource):
        (WebCore::RenderSVGResource::drawsContents):
        (WebCore::getRenderSVGResourceById):
        * rendering/RenderSVGResourceMasker.cpp: Added.
        (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
        (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
        (WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients.
        (WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client.
        (WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object.
        (WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object.
        (WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
        * rendering/RenderSVGResourceMasker.h: Added.
        (WebCore::MaskerData::MaskerData):
        (WebCore::RenderSVGResourceMasker::renderName):
        (WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT.
        (WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT.
        (WebCore::RenderSVGResourceMasker::resourceType):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::destroy): dito.
        * rendering/RenderSVGText.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
        (WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
        * rendering/SVGRenderSupport.h:
        (WebCore::SVGRenderBase::toSVGRenderBase):
        (WebCore::SVGRenderBase::strokeBoundingBox):
        (WebCore::SVGRenderBase::markerBoundingBox):
        * rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly.
        (WebCore::operator<<):
        (WebCore::writeSVGResource):
        (WebCore::writeSVGContainer):
        (WebCore::writeSVGText):
        (WebCore::writeSVGInlineText):
        (WebCore::writeSVGImage):
        (WebCore::write):
        (WebCore::writeResourcesToObject):
        * rendering/SVGRenderTreeAsText.h:
        * svg/SVGMaskElement.cpp: Update Masker to use the new renderer.
        (WebCore::SVGMaskElement::svgAttributeChanged):
        (WebCore::SVGMaskElement::childrenChanged):
        (WebCore::SVGMaskElement::maskBoundingBox):
        (WebCore::SVGMaskElement::createRenderer):
        * svg/SVGMaskElement.h:
        * svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed.
        (WebCore::SVGStyledElement::invalidateResources):
        (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
        * svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType.
        (WebCore::toUnitType):
        * svg/graphics/SVGResource.h:
        (WebCore::):
        (WebCore::SVGResource::isMarker):
        * svg/graphics/SVGResourceMasker.cpp: Removed.
        * svg/graphics/SVGResourceMasker.h: Removed.

2010-02-17  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Move SVGResources to Renderers, starting with Masker
        https://bugs.webkit.org/show_bug.cgi?id=35020

        With the move from SVGResourceMasker to RenderSVGResourceMasker, I changed
        the way DRT dumps resources. DRT is now able to dump multi-access
        of resources.
        Also the size of a Mask resource (depending of the object) and the access of
        the resource (togeter with the resource name) is pointed out as an insertion
        under the object.

        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/mac/svg/batik/masking/maskRegions-expected.txt:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/mac/svg/css/mask-with-shadow-expected.txt:
        * platform/mac/svg/custom/empty-mask-expected.txt:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
        * platform/mac/svg/custom/js-late-mask-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-mask-creation-expected.txt:
        * platform/mac/svg/custom/mask-changes-expected.txt:
        * platform/mac/svg/custom/mask-child-changes-expected.txt:
        * platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
        * platform/mac/svg/custom/mask-inside-defs-expected.txt:
        * platform/mac/svg/custom/mask-invalidation-expected.txt:
        * platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
        * platform/mac/svg/custom/mask-with-all-units-expected.txt:
        * platform/mac/svg/custom/mask-with-default-value-expected.txt:
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
        * platform/mac/svg/custom/visibility-override-mask-expected.txt:
        * platform/mac/svg/filters/filter-clip-expected.txt:
        * svg/custom/transformedMaskFails-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a way for WebView and its dependancies to be selectively included
timothy@apple.com [Wed, 17 Feb 2010 21:45:14 +0000 (21:45 +0000)]
Add a way for WebView and its dependancies to be selectively included
in WebKitStatistics leak tracking. By default WebView is not included and
you need to subclass WebView and implement +isIncludedInWebKitStatistics
to be included.

rdar://problem/7567677&7572900
https://webkit.org/b/35045

Reviewed by Adam Roben.

* WebView/WebDataSource.mm:
(-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics.
(-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES.
(-[WebDataSource finalize]): Ditto.
* WebView/WebFrame.mm:
(-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics.
(-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics.
(-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES.
(-[WebFrame finalize]): Ditto.
* WebView/WebFrameInternal.h:
* WebView/WebFrameView.mm:
(-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics.
(-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't
know what WebFrame we belong to yet.
(-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES.
(-[WebFrameView finalize]): Ditto.
* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't
know what WebFrame we belong to yet.
(-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES.
(-[WebHTMLRepresentation finalize]): Ditto.
(-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is
included in statistics.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView dealloc]):
(+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included.
Subclasses that care can return YES to be included.
* WebView/WebViewInternal.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Kenneth Russell <kbr@google.com>
eric@webkit.org [Wed, 17 Feb 2010 21:05:40 +0000 (21:05 +0000)]
2010-02-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Refactor texImage2D and texSubImage2D taking Image to use common code
        https://bugs.webkit.org/show_bug.cgi?id=34458

        Merged the Safari and Chromium code which extracts the data from
        Image objects into common entry points on GraphicsContext3D. This
        immediately fixes the following three problems:
          - Chromium not implementing texSubImage2D taking Image.
          - Safari not obeying the flipY parameter to texImage2D or
            texSubImage2D taking Image.
          - Safari not obeying the premultipyAlpha parameter to texImage2D
            or texSubImage2D taking Image.
        Added new test verifying the behavior of texImage2D and
        texSubImage2D and the flipY parameter. The premultiplyAlpha
        parameter can not be tested yet as the implementation is not yet
        spec compliant. This will be fixed in a follow-on bug.

        Ran all WebGL demos in demo repository on Safari and Chromium;
        textures are now the right way up in both browsers, and
        transparent textures in Particles demo now look correct in Safari.

        * fast/canvas/webgl/resources/red-green.png: Added.
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Added.
2010-02-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Refactor texImage2D and texSubImage2D taking Image to use common code
        https://bugs.webkit.org/show_bug.cgi?id=34458

        Merged the Safari and Chromium code which extracts the data from
        Image objects into common entry points on GraphicsContext3D. This
        immediately fixes the following three problems:
          - Chromium not implementing texSubImage2D taking Image.
          - Safari not obeying the flipY parameter to texImage2D or
            texSubImage2D taking Image.
          - Safari not obeying the premultipyAlpha parameter to texImage2D
            or texSubImage2D taking Image.
        Added new test verifying the behavior of texImage2D and
        texSubImage2D and the flipY parameter. The premultiplyAlpha
        parameter can not be tested yet as the implementation is not yet
        spec compliant. This will be fixed in a follow-on bug.

        Ran all WebGL demos in demo repository on Safari and Chromium;
        textures are now the right way up in both browsers, and
        transparent textures in Particles demo now look correct in Safari.

        Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext3D.cpp: Added.
        (WebCore::GraphicsContext3D::extractImageData):
        (WebCore::GraphicsContext3D::processImageData):
        (WebCore::GraphicsContext3D::premultiplyAlpha):
        (WebCore::GraphicsContext3D::unmultiplyAlpha):
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
        * platform/graphics/cg/GraphicsContext3DCG.cpp: Added.
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp: Added.
        (WebCore::GraphicsContext3D::getImageData):
2010-02-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Refactor texImage2D and texSubImage2D taking Image to use common code
        https://bugs.webkit.org/show_bug.cgi?id=34458

        Merged the Safari and Chromium code which extracts the data from
        Image objects into common entry points on GraphicsContext3D. This
        immediately fixes the following three problems:
          - Chromium not implementing texSubImage2D taking Image.
          - Safari not obeying the flipY parameter to texImage2D or
            texSubImage2D taking Image.
          - Safari not obeying the premultipyAlpha parameter to texImage2D
            or texSubImage2D taking Image.
        Added new test verifying the behavior of texImage2D and
        texSubImage2D and the flipY parameter. The premultiplyAlpha
        parameter can not be tested yet as the implementation is not yet
        spec compliant. This will be fixed in a follow-on bug.

        Ran all WebGL demos in demo repository on Safari and Chromium;
        textures are now the right way up in both browsers, and
        transparent textures in Particles demo now look correct in Safari.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Wed, 17 Feb 2010 20:08:08 +0000 (20:08 +0000)]
2010-02-17  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsLayer: support perspective and 3D transforms
        https://bugs.webkit.org/show_bug.cgi?id=34960

        * WebKit.pri: added appropriate define: ENABLED_3D_RENDERING
2010-02-17  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsLayer: support perspective and 3D transforms
        https://bugs.webkit.org/show_bug.cgi?id=34960

        New tests: http://webkit.org/blog-files/3d-transforms/perspective-by-example.html

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::updateTransform):
        (WebCore::GraphicsLayerQtImpl::setBaseTransform):
        (WebCore::GraphicsLayerQtImpl::computeTransform):
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        (WebCore::TransformAnimationQt::~TransformAnimationQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, build fix.
pkasting@chromium.org [Wed, 17 Feb 2010 19:51:24 +0000 (19:51 +0000)]
Unreviewed, build fix.

Fix crashes due to an omitted line in r54839.

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::decodingFailed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Alok Priyadarshi <alokp@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 19:28:06 +0000 (19:28 +0000)]
2010-02-17  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by Ariya Hidayat.

        Bug 34900: Implement accelerated compositing for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=34900

        Do not exclude files needed for accelerated compositing. In fact there is no need to exclude these files.
        These files are already guarded with WTF_USE_ACCELERATED_COMPOSITING flag.

        * WebCore.gyp/WebCore.gyp: Removed GraphicsLayer.cpp, RenderLayerBacking.cpp,
        and RenderLayerCompositor.cpp from excluded list.
2010-02-17  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by Ariya Hidayat.

        Bug 34900: Implement accelerated compositing for chromium.
        https://bugs.webkit.org/show_bug.cgi?id=34900

        * features.gypi: Added WTF_USE_ACCELERATED_COMPOSITING flag.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove the obsolete chromium interface for handling DownloadURL.
jianli@chromium.org [Wed, 17 Feb 2010 19:08:09 +0000 (19:08 +0000)]
[chromium] Remove the obsolete chromium interface for handling DownloadURL.
https://bugs.webkit.org/show_bug.cgi?id=34982

Reviewed by Darin Fisher.

WebCore:

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::setData):

WebKit/chromium:

* public/WebDragData.h:
* src/WebDragData.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Wed, 17 Feb 2010 19:06:22 +0000 (19:06 +0000)]
2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Ariya Hidayat.

        Make possible Qt DRT to get total number of pages to be printed

        LayoutTests:
            printing/numberOfPages.html

        [Qt] DRT: Get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34955

        * Api/qwebframe.cpp:
        (qt_drt_numberOfPages):
        (qt_drt_evaluateScriptInIsolatedWorld):
2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Ariya Hidayat.

        Make possible Qt DRT to get total number of pages to be printed

        LayoutTests:
            printing/numberOfPages.html

        [Qt] DRT: Get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34955

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::numberOfPages):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for blocks that...
mitz@apple.com [Wed, 17 Feb 2010 19:02:39 +0000 (19:02 +0000)]
<rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for blocks that span multiple columns

Reviewed by Darin Adler.

* manual-tests/match-marker-rects.html: Added.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintTextMatchMarker): Use the text renderer rather
than its ancestor block for the local-to-absolute transformation.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit/gtk:
xan@webkit.org [Wed, 17 Feb 2010 18:33:02 +0000 (18:33 +0000)]
WebKit/gtk:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Rename 'enable-java' setting to 'enable-java-applet', since it
        only controls whether <applet> is supported or not instead of
        whether all Java content is supported or not.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_update_settings):
        (DNDContentsRequest::webkit_web_view_settings_notify):

WebKitTools:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update to use new property name.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Julien Chaffraix <jchaffraix@webkit.org>
eric@webkit.org [Wed, 17 Feb 2010 17:49:46 +0000 (17:49 +0000)]
2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Ariya Hidayat.

        Remove some warnings seen when building Qt
        https://bugs.webkit.org/show_bug.cgi?id=35017

        Using a machine without the needed tools to build WebKit leads to
        several errors and warnings.

        * Scripts/webkitdirs.pm: Refactored the code testing the command's
        presence into a commandExists routine. While doing so removed, stderr
        output as it usually does not give anything more than our message. Also
        added a Qt check for qmake that was missing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 15:47:27 +0000 (15:47 +0000)]
2010-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to turn windows slaves again, by skipping two websocket tests that fail reliable.

        * platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTypo in test name
kov@webkit.org [Wed, 17 Feb 2010 15:17:36 +0000 (15:17 +0000)]
Typo in test name

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Tor Arne Vestbø.
ossy@webkit.org [Wed, 17 Feb 2010 15:14:38 +0000 (15:14 +0000)]
Rubber-stamped by Tor Arne Vestbø.

[Qt] Add platform specific expected files for new tests pass in fast/css.

Rendertree results compared to Mac expected files with --ignore-metrics,
pixel results compared to Mac png files.

fast/css/font-face-opentype.html introduced in r54855.
fast/css/inline-element-line-break.html introduced in r54544.
fast/css/pseudo-element-line-break.html introduced in r54544.

* platform/qt/fast/css/font-face-opentype-expected.txt: Added.
* platform/qt/fast/css/inline-element-line-break-expected.txt: Added.
* platform/qt/fast/css/pseudo-element-line-break-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 15:09:58 +0000 (15:09 +0000)]
2010-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to turn SnowLeopard slave green again. Skipping media/video-load-networkState.html - already filed a bug last year.

        * platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 15:05:37 +0000 (15:05 +0000)]
2010-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Try to turn Tiger slave green again. Skipping media/video-display-aspect-ratio.html - already skipped on the other mac variants & win.

        * platform/mac-tiger/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkipping new test that does not pass on Qt.
kov@webkit.org [Wed, 17 Feb 2010 14:48:50 +0000 (14:48 +0000)]
Skipping new test that does not pass on Qt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 17 Feb 2010 14:30:11 +0000 (14:30 +0000)]
2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Does not send an Accept header for subresources, causing some sites to break
        https://bugs.webkit.org/show_bug.cgi?id=33242

        Set */* as the Accept header when downloading resources
        that did not set an Accept header. This behaviour is similar to
        the one adopted by Chromium.

        Test: http/tests/misc/image-checks-for-accept.html

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a mistake I just committed to the change log.
jorlow@chromium.org [Wed, 17 Feb 2010 14:24:09 +0000 (14:24 +0000)]
Fix a mistake I just committed to the change log.

Note that the last svn commit message should have read like this:

2010-02-17  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Fixes initialization order of members for GeolocationServiceChromium.
        https://bugs.webkit.org/show_bug.cgi?id=35034

        * platform/chromium/GeolocationServiceChromium.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2
jorlow@chromium.org [Wed, 17 Feb 2010 14:20:45 +0000 (14:20 +0000)]
2

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 14:08:49 +0000 (14:08 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Gustavo Noronha.

        Disable Java by default in DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 13:46:17 +0000 (13:46 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Implement FrameLoaderClient::createJavaAppletWidget.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createJavaAppletWidget):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
xan@webkit.org [Wed, 17 Feb 2010 13:46:05 +0000 (13:46 +0000)]
WebCore:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Resolve symlinks before trying to load plugins as modules, since
        GModule won't do it.

        Based on original work by Gustavo Noronha.

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::load):

JavaScriptCore:

2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Add support for GFile to GOwnPtr.

        Based on original work by Gustavo Noronha.

        * wtf/gtk/GOwnPtr.cpp:
        (WTF::GFile):
        * wtf/gtk/GOwnPtr.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 13:41:47 +0000 (13:41 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [Linux] Webkit incompatible with Java plugins
        https://bugs.webkit.org/show_bug.cgi?id=24912

        Add a WebKitWebSetting to enable/disable the Java plugin support.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 17 Feb 2010 13:39:12 +0000 (13:39 +0000)]
2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by NOBODY (OOPS!).

        Protect the resource loader object from disappearing during
        parseDataUrl.

        Tested by testdownload API test.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::parseDataUrl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a number of new tests
kov@webkit.org [Wed, 17 Feb 2010 13:12:29 +0000 (13:12 +0000)]
Skip a number of new tests

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 12:00:15 +0000 (12:00 +0000)]
2010-02-17  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Implements GeolocationServices for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=32068

        This is part of implementing Geolocation framework for Chromium. Existing layout tests should pass.

        * WebCore.gypi:
        * page/Geolocation.h:
        * platform/GeolocationService.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 17 Feb 2010 10:49:08 +0000 (10:49 +0000)]
2010-02-17  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        Missing property warning after r54873
        https://bugs.webkit.org/show_bug.cgi?id=35023

        Add a new WebKitWebSettings setting, 'enable-file-access-from-file-uris', set to
        FALSE by default, that when enabled will assign each file:// URI
        their own security domain.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 17 Feb 2010 10:21:27 +0000 (10:21 +0000)]
2010-02-17  Steve Block  <steveblock@google.com>

        Reviewed by Ariya Hidayat.

        Adds missing platform and feature guards to V8 bindings
        https://bugs.webkit.org/show_bug.cgi?id=34987

        No new tests, build fix only.

        * bindings/v8/V8Proxy.cpp: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
        * bindings/v8/V8Proxy.h: Modified. Adds CHROMIUM guards and uses PlatformBridge in place of ChromiumBridge
        * bindings/v8/custom/V8DocumentCustom.cpp: Modified. Adds XPATH guards

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 17 Feb 2010 10:04:58 +0000 (10:04 +0000)]
2010-02-17  Steve Block  <steveblock@google.com>

        Reviewed by Ariya Hidayat.

        Include WebCore's npruntime.h for Android in V8 bindings
        https://bugs.webkit.org/show_bug.cgi?id=35002

        Currently, the V8 bindings include bindings/npruntime.h, which is a
        Chromium-specific file outside of the WebKit tree.

        No new tests, build fix only.

        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/NPV8Object.h:
        * bindings/v8/V8NPObject.h:
        * bindings/v8/V8NPUtils.h:
        * bindings/v8/npruntime_impl.h:
        * bindings/v8/npruntime_priv.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed - demo.
mjs@apple.com [Wed, 17 Feb 2010 08:38:14 +0000 (08:38 +0000)]
Not reviewed - demo.

Made some examples of using <details> for table descriptions.

* demos/hover-summary: Added.
* demos/hover-summary/details.css: Added.
* demos/hover-summary/details.js: Added.
(summaryClickListener):
():
(window.onload):
* demos/hover-summary/example1.html: Added.
* demos/hover-summary/example2.html: Added.
* demos/hover-summary/horizontal-triangle.png: Added.
* demos/hover-summary/vertical-triangle.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-15 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 17 Feb 2010 08:37:38 +0000 (08:37 +0000)]
2010-02-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should handle BUFFERING messages
        https://bugs.webkit.org/show_bug.cgi?id=30004

        * configure.ac: Bump gstreamer -core/-plugins-base requirements to
        0.10.25 which is the minimum required version for on-disk buffering.

2010-01-07  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should handle BUFFERING messages
        https://bugs.webkit.org/show_bug.cgi?id=30004

        Draw the buffering status in the media controls. The timebar is
        now 2 pixels shorter so dragging it at same absolute position than
        before produces a seek at a new position in the media, this
        explains the rebaselining of the controls-drag-timebar test.

        * platform/gtk/media/controls-after-reload-expected.txt:
        * platform/gtk/media/controls-drag-timebar-expected.txt:
        * platform/gtk/media/controls-strict-expected.txt:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-controls-rendering-expected.txt:
        Re-baselined due to 1px left/right border added in controls timeline.

2010-01-07  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] Should handle BUFFERING messages
        https://bugs.webkit.org/show_bug.cgi?id=30004

        Initial support for on-disk buffering of videos. This works only
        for Quicktime and flv though.

        * css/mediaControlsGtk.css:
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintMediaSliderTrack): Draw the
        buffering status in the media controls.
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback): Defer buffering
        messages handling to processBufferingStats().
        (WebCore::bufferingTimeoutCallback): Closure called periodically
        during the on-disk buffering process.
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): New instance
        variables and create playbin2 here instead of doing it in load().
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): New instance
        variables.
        (WebCore::MediaPlayerPrivate::load): Simply set uri on playbin2
        instead of creating the pipeline and setting uri all together.
        (WebCore::MediaPlayerPrivate::processBufferingStats): Start a new
        timeout source if the player is starting on-disk buffering.
        (WebCore::MediaPlayerPrivate::queryBufferingStats): Method called
        200ms during on-disk buffering to update the maxTimeLoaded and few
        other private variables.
        (WebCore::MediaPlayerPrivate::maxTimeSeekable):
        (WebCore::MediaPlayerPrivate::maxTimeLoaded):
        (WebCore::MediaPlayerPrivate::bytesLoaded): Fixed implementations
        regarding buffering.
        (WebCore::MediaPlayerPrivate::totalBytes): Improved logging.
        (WebCore::MediaPlayerPrivate::updateStates): Start playback if it
        was internally paused at beginning of on-disk buffering and set
        ready/network states depending on the state of the on-disk
        buffering process.
        (WebCore::MediaPlayerPrivate::didEnd): Emit durationChanged.
        (WebCore::MediaPlayerPrivate::setAutobuffer): Edit playbin2 flags
        property depending on autoBuffer value.
        (WebCore::MediaPlayerPrivate::createGSTPlayBin): Don't set uri
        there, it is now done in load().
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: New methods
        and instance variables.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix by adding a return statement.
bweinstein@apple.com [Wed, 17 Feb 2010 08:17:22 +0000 (08:17 +0000)]
Build fix by adding a return statement.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 17 Feb 2010 08:04:00 +0000 (08:04 +0000)]
2010-02-17  Xan Lopez  <xlopez@igalia.com>

        Skip tests requiring new results.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to fix the build
bweinstein@apple.com [Wed, 17 Feb 2010 07:56:24 +0000 (07:56 +0000)]
Touch WebKit.idl to fix the build

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome minor check-webkit-style code clean-ups. This revision
cjerdonek@webkit.org [Wed, 17 Feb 2010 07:38:43 +0000 (07:38 +0000)]
Some minor check-webkit-style code clean-ups.  This revision
contains no new functionality.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34932

* Scripts/check-webkit-style:
  - Replaced the call to webkit_argument_defaults() with a
    default parameter in the ArgumentParser constructor.

* Scripts/webkitpy/style/checker.py:
  - Removed the WEBKIT prefix from the default global variables.
  - Prefixed several of the global variables with an underscore
    to reflect that they are used internally.
  - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
  - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
    configuration from list-tuple pairs to list-list pairs.
  - Renamed style_categories() to _all_categories().
  - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
  - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
  - In the ArgumentParser class--
    - Renamed the doc_print attribute to stderr_write.
    - Other minor updates.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated the import statements and unit test classes as necessary.
  - Added assertions to test _PATH_RULES_SPECIFIER more fully.

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Updated the unit test classes as necessary.
  - Changed StyleErrorHandlerTestBase to store a list of error
    messages rather than just the last one.

* Scripts/webkitpy/style/filter.py:
  - Altered FilterConfiguration._path_rules_from_path()
    to convert the path_rules list to a tuple.

* Scripts/webkitpy/style/filter_unittest.py:
  - Updated the unit tests to reflect the change from tuples to
    lists in the _PATH_RULES_SPECIFIER configuration variable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Chris Evans <cevans@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 07:32:30 +0000 (07:32 +0000)]
2010-02-16  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Add a new setting which gives the option of assigning every file:///
        to its own unique domain.

        https://bugs.webkit.org/show_bug.cgi?id=34778

        Test: Pending in forthcoming separate change due to non-trivial
        dependencies.

        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext): Place file:/// URI documents
        into their own unique domains if the new setting requires it.
        * page/Settings.h:
        * page/Settings.cpp:
        (WebCore::Settings::setAllowFileAccessFromFileURLs): Simple setter.
        * page/SecurityOrigin.h:
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::makeUnique): Add simple ability to force an
        origin to be considered unique.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 07:12:23 +0000 (07:12 +0000)]
2010-02-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: drosera/demo.js not syntax highlighted correctly.

        https://bugs.webkit.org/show_bug.cgi?id=35008

        * inspector/front-end/SourceTokenizer.js:
        (WebInspector.SourceTokenizer.Registry):
        (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 06:56:19 +0000 (06:56 +0000)]
2010-02-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: prefer smooth scrolling to instant highlight.

        https://bugs.webkit.org/show_bug.cgi?id=34978

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer):
        (WebInspector.TextViewer.prototype._scroll):
        (WebInspector.TextChunk):
        (WebInspector.TextChunk.prototype._createRow):
        * inspector/front-end/textViewer.css:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a handful of other leaks seen on the buildbot.
mrowe@apple.com [Wed, 17 Feb 2010 05:57:24 +0000 (05:57 +0000)]
Fix a handful of other leaks seen on the buildbot.

Patch by Gavin Barraclough <barraclough@apple.com> on 2010-02-16
Reviewed by Mark Rowe.

* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Delegate through to the subclass version of deref to ensure that
the correct cleanup takes place.  This function previously featured some code that attempted to
skip deletion of static UStringImpl's.  Closer inspection revealed that it was in fact equivalent
to "if (false)", meaning that UStringImpl's which had their final deref performed via this function
were leaked.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForgot a .get() because this is an OwnPtr
bweinstein@apple.com [Wed, 17 Feb 2010 05:26:01 +0000 (05:26 +0000)]
Forgot a .get() because this is an OwnPtr

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry using m_qtVideoLayer instead of platformLayer() to fix the build
bweinstein@apple.com [Wed, 17 Feb 2010 04:55:21 +0000 (04:55 +0000)]
Try using m_qtVideoLayer instead of platformLayer() to fix the build

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix when Accelerated Compositing is on
bweinstein@apple.com [Wed, 17 Feb 2010 04:21:00 +0000 (04:21 +0000)]
Build fix when Accelerated Compositing is on

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a handful of leaks seen on the buildbot.
mrowe@apple.com [Wed, 17 Feb 2010 04:06:48 +0000 (04:06 +0000)]
Fix a handful of leaks seen on the buildbot.

Reviewed by Gavin Barraclough.

* runtime/UStringImpl.h:
(JSC::UStringOrRopeImpl::deref): Call URopeImpl::destructNonRecursive rather than delete
to ensure that the rope's fibers are also destroyed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Wed, 17 Feb 2010 03:54:23 +0000 (03:54 +0000)]
2010-02-16  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Nikolas Zimmermann.

        SVG not rendered as background-image from data URI
        https://bugs.webkit.org/show_bug.cgi?id=33630

        * platform/mac/svg/css/background-image-svg-expected.checksum: Added.
        * platform/mac/svg/css/background-image-svg-expected.png: Added.
        * platform/qt/svg/css/background-image-svg-expected.checksum: Added.
        * platform/qt/svg/css/background-image-svg-expected.png: Added.
        * svg/css/background-image-svg.html: Added.
        * svg/css/background-image-svg-expected.txt: Added.
2010-02-16  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Nikolas Zimmermann.

        SVG not rendered as background-image from data URI
        https://bugs.webkit.org/show_bug.cgi?id=33630

        When the background image is an SVG image, and it is smaller than the area
        it is supposed to fill, we were using renderSubTreeToImage to draw it.
        That call was not going through all the drawing phases, and so the SVG itself
        would not be drawn.

        Test: svg/css/background-image-svg.html

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::nativeImageForCurrentFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Bryan Yeung <bryeung@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 03:37:58 +0000 (03:37 +0000)]
2010-02-16  Bryan Yeung  <bryeung@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Remove the bounds on stroke width and miter for the skia platform.
        https://bugs.webkit.org/show_bug.cgi?id=34954

        Test: svg/custom/stroke-width-large.svg

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::setupPaintForStroking):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 17 Feb 2010 03:27:46 +0000 (03:27 +0000)]
2010-02-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Correct typo in test name in Skipped list. Should turn SL slave green again.

        * platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a missing semicolon
bweinstein@apple.com [Wed, 17 Feb 2010 03:25:54 +0000 (03:25 +0000)]
Add a missing semicolon

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-16 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Wed, 17 Feb 2010 03:21:48 +0000 (03:21 +0000)]
2010-02-16  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
        classes.  releaseRef releases the original pointer without decreasing
        the reference count, and the base class constructor increases the
        reference count, leading to a leak.

        https://bugs.webkit.org/show_bug.cgi?id=35000

        * src/WebDocument.cpp:
        (WebKit::WebDocument::WebDocument):
        * src/WebElement.cpp:
        (WebKit::WebElement::WebElement):
        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::WebFormElement):
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::WebInputElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54861 268f45cc-cd09-0410-ab3c-d52691b4dbfc