WebKit.git
2 years agoExpand font-weight and font-stretch to take any number
mmaxfield@apple.com [Mon, 6 Mar 2017 21:40:31 +0000 (21:40 +0000)]
Expand font-weight and font-stretch to take any number
https://bugs.webkit.org/show_bug.cgi?id=168889

Reviewed by Simon Fraser.

Source/WebCore:

This patch expands parsing support for font-weight and font-stretch so that they can accept
numbers in addition to the keyword values they accepted previously. Eventually, these numbers
will be used as inputs to select variation fonts; however, in this patch, the values are just
parsed and held in our internal data model. This means that this patch doesn't actually change
the general behavior of WebKit; instead, it parses new values, outputs them (via
getComputedStyle() and similar functions), and provides them as input to our preexisting font
selection algorithm.

This patch doesn't actually modify anything algorithmically, and therefore, it doesn't include
any additional tests for the font selection algorithm. Instead, it tests the parsing of the
newly accepted values (both input and output).

Because our internal data model needs to hold numbers now, this patch also completely eliminates
the FontWidth, FontItalic, and FontTraitsMask enum values in favor of FontSelectionValues (which
can hold numbers instead of individual enum values). Therefore, every place which we were using
these enum values is migrated in this patch to using FontSelectionValues instead.

Tests: fast/text/font-selection-font-face-parse.html
       fast/text/font-selection-font-loading-api-parse.html
       fast/text/font-style-parse.html
       fast/text/font-weight-parse.html

* accessibility/AccessibilityRenderObject.cpp: Migrate off of old enum types.
(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp: Ditto.
(getAttributeSetForAccessibilityObject):
* css/CSSComputedStyleDeclaration.cpp: Output newly parsed values.
(WebCore::fontWeightFromStyle):
(WebCore::fontStretchFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontShorthandValueForSelectionProperties):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSFontFace.cpp: Migrate off old enum types.
(WebCore::calculateWeightRange):
(WebCore::CSSFontFace::setWeight):
(WebCore::calculateStretchRange):
(WebCore::CSSFontFace::setStretch):
(WebCore::calculateStyleRange):
(WebCore::CSSFontFace::setStyle):
(WebCore::CSSFontFace::calculateStyleMask): Deleted.
(WebCore::CSSFontFace::calculateWeightMask): Deleted.
(WebCore::CSSFontFace::calculateStretch): Deleted.
* css/CSSFontFace.h:
* css/CSSFontFaceSet.cpp: Migrate off old enum types.
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::calculateWeightValue):
(WebCore::calculateStretchValue):
(WebCore::calculateStyleValue):
(WebCore::computeFontSelectionRequest):
(WebCore::CSSFontFaceSet::matchingFaces):
(WebCore::CSSFontFaceSet::fontFace):
(WebCore::computeFontTraitsMask): Deleted.
(WebCore::computeFontStretch): Deleted.
* css/CSSFontFaceSet.h:
* css/CSSFontSelector.cpp: Migrate off old enum types.
(WebCore::CSSFontSelector::fontRangesForFamily):
* css/CSSPrimitiveValueMappings.h: font-weight and font-style are no longer
keyword properties.
(WebCore::CSSPrimitiveValue::operator FontWeight): Deleted.
(WebCore::CSSPrimitiveValue::operator FontItalic): Deleted.
* css/CSSProperties.json: Use the same infrastructure for all three of the
font selection properties.
* css/CSSSegmentedFontFace.cpp: Migrate off old enum types.
(WebCore::CSSSegmentedFontFace::fontRanges):
* css/CSSValueKeywords.in: The 100-based font-weight values are now represented
as real numbers.
* css/FontFace.cpp: Update the string output functions for the new values.
(WebCore::rangeIsSingleValue):
(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):
* css/StyleBuilderConverter.h: Use CSSValue conversion functions to convert
to our new data model.
(WebCore::StyleBuilderConverter::convertFontWeight):
(WebCore::StyleBuilderConverter::convertFontStretch):
(WebCore::StyleBuilderConverter::convertFontStyle):
* css/StyleBuilderCustom.h: font-weight is no longer a completely custom
property.
(WebCore::StyleBuilderCustom::applyInitialFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyValueFontWeight): Deleted.
* css/parser/CSSParserFastPaths.cpp: font-style is no longer a keyword property.
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* css/parser/CSSPropertyParser.cpp: Parse the new values in the font selection
properties.
(WebCore::consumeFontWeightKeywordValue):
(WebCore::consumeFontWeightCSS21):
(WebCore::consumeFontWeight):
(WebCore::consumeFontStyleKeywordValue):
(WebCore::consumeFontStyle):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeSystemFont):
(WebCore::CSSPropertyParser::consumeFont):
* editing/EditingStyle.cpp: Migrate off old enum types.
(WebCore::fontWeightIsBold):
* editing/mac/EditorMac.mm: Ditto.
(WebCore::Editor::applyFontStyles):
* platform/graphics/FontCache.h: Unify our font selection values into
their enclosing struct, FontSelectionCapabilities. Also, clean up utility
functions.
* platform/graphics/FontCascade.cpp: Migrate off old enum types.
(WebCore::FontCascade::FontCascade):
* platform/graphics/FontCascade.h: Ditto.
(WebCore::FontCascade::italic):
(WebCore::FontCascade::weight):
* platform/graphics/FontDescription.cpp: Ditto.
(WebCore::FontDescription::FontDescription):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontDescription::traitsMask): Deleted.
* platform/graphics/FontDescription.h: Migrate off old enum types.
(WebCore::FontDescription::italic):
(WebCore::FontDescription::stretch):
(WebCore::FontDescription::weight):
(WebCore::FontDescription::fontSelectionRequest):
(WebCore::FontDescription::computedPixelSize):
(WebCore::FontDescription::setItalic):
(WebCore::FontDescription::setStretch):
(WebCore::FontDescription::setIsItalic):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontCascadeDescription::initialItalic):
(WebCore::FontCascadeDescription::initialWeight):
(WebCore::FontCascadeDescription::initialStretch):
* platform/graphics/FontSelectionAlgorithm.cpp: Delete code which was only
present to convert from the old enum types to the new FontSelectionRequest
type.
(WebCore::fontSelectionRequestForTraitsMask): Deleted.
(WebCore::initialFontSelectionCapabilitiesForTraitsMask): Deleted.
(WebCore::fontSelectionCapabilitiesForTraitsMask): Deleted.
* platform/graphics/FontSelectionAlgorithm.h: Migrate to new named functions
for special values.
(WebCore::isItalic):
(WebCore::boldWeightValue):
(WebCore::normalWeightValue):
(WebCore::isFontWeightBold):
(WebCore::normalStretchValue):
(WebCore::FontSelectionRequest::FontSelectionRequest):
* platform/graphics/cocoa/FontCacheCoreText.cpp: Migrate all platforms which
compile this file to know about FontDatabase. This simplifies the interaction
between @font-face fonts and installed fonts. Also, migrate off old enum types.
(WebCore::stretchFromCoreTextTraits):
(WebCore::fontWeightFromCoreText):
(WebCore::capabilitiesForFontDescriptor):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::platformFontLookupWithFamily):
(WebCore::invalidateFontCache):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::lookupFallbackFont):
(WebCore::toTraitsMask): Deleted.
(WebCore::isFontWeightBold): Deleted.
(WebCore::toCoreTextFontWeight): Deleted.
(): Deleted.
(WebCore::FontDatabase::capabilitiesForFontDescriptor): Deleted.
(WebCore::calculateFontSelectionRequest): Deleted.
* platform/graphics/freetype/FontCacheFreeType.cpp: Migrate off old enum types.
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::fontWeightToFontconfigWeight):
(): Deleted.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp: Ditto.
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/ios/FontCacheIOS.mm: Ditto.
(WebCore::baseSystemFontDescriptor):
(WebCore::systemFontModificationAttributes):
(WebCore::systemFontDescriptor):
(WebCore::platformFontWithFamilySpecialCase):
(WebCore::FontCache::weightOfCTFont): Deleted.
* platform/graphics/mac/FontCacheMac.mm: Ditto.
(WebCore::toNSFontWeight):
(WebCore::platformFontWithFamilySpecialCase):
* platform/graphics/win/FontCacheWin.cpp: Ditto.
(WebCore::toGDIFontWeight):
(WebCore::traitsInFamilyEnumProc):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(): Deleted.
* platform/mock/MockRealtimeVideoSource.cpp: Ditto.
(WebCore::MockRealtimeVideoSource::applySize):
* platform/text/TextFlags.h: Delete old enum types.
* platform/win/DragImageWin.cpp: Migrate off old enum types.
(WebCore::dragLabelFont):
* rendering/RenderEmbeddedObject.cpp: Ditto.
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
* rendering/RenderThemeGtk.cpp: Ditto.
(WebCore::RenderThemeGtk::updateCachedSystemFontDescription):
* rendering/RenderThemeIOS.mm: Ditto.
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):
* rendering/RenderThemeMac.mm: Ditto.
(WebCore::toFontWeight):
* rendering/RenderThemeWin.cpp: Ditto.
(WebCore::fillFontDescription):

Source/WebKit/mac:

Migrate off old enum types.

* WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):
* WebView/WebHTMLView.mm:
(fontNameForDescription):
* WebView/WebView.mm:
(-[WebView updateTextTouchBar]):

Source/WebKit/win:

Migrate off old enum types.

* WebKitGraphics.cpp:
(makeFont):

Source/WebKit2:

Migrate off old enum types.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):

Tools:

Migrate off old enum types.

* TestWebKitAPI/Tests/WebCore/FontCache.cpp:
(TestWebKitAPI::createPlatformFont):
(TestWebKitAPI::compareFonts):
(TestWebKitAPI::TEST_F):

LayoutTests:

* fast/text/font-selection-font-face-parse-expected.txt: Added.
* fast/text/font-selection-font-face-parse.html: Added.
* fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
* fast/text/font-selection-font-loading-api-parse.html: Added.
* fast/text/font-stretch-parse-expected.txt:
* fast/text/font-stretch-parse.html:
* fast/text/font-style-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
* fast/text/font-style-parse.html: Added.
* fast/text/font-weight-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
* fast/text/font-weight-parse.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRefined the ARES-6 experience
jond@apple.com [Mon, 6 Mar 2017 21:14:31 +0000 (21:14 +0000)]
Refined the ARES-6 experience
https://bugs.webkit.org/show_bug.cgi?id=169205

Reviewed by Saam Barati.

* ARES-6/about.html: Copied from PerformanceTests/ARES-6/index.html.
* ARES-6/driver.js:
(Driver.prototype.start):
(Driver.prototype._updateIterations):
(Driver):
* ARES-6/index.html:
* ARES-6/stats.js:
(Stats.prototype.toString.span.span):
* ARES-6/styles.css:
(body):
(.swoop):
(p):
(.logo):
(.start):
(.test):
(.test:nth-child(odd)):
(.overall):
(.about h2):
(.button):
(.button:hover):
(.button.return:before):
(@keyframes fade-in):
(@keyframes scale-in):
(@keyframes flicker-in):
(@keyframes wipe-in):
(.flip): Deleted.
(.testing, .about): Deleted.
(.testing): Deleted.
(.about): Deleted.
(#about:target): Deleted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Mark fast/parser/adoption-agency-unload-iframe-4.html as timing out on platform...
clopez@igalia.com [Mon, 6 Mar 2017 21:13:43 +0000 (21:13 +0000)]
[GTK] Mark fast/parser/adoption-agency-unload-iframe-4.html as timing out on platform GTK.

Unreviewed test gardening.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoStandardCanPlayThrough.html does not work on iOS.
commit-queue@webkit.org [Mon, 6 Mar 2017 20:27:21 +0000 (20:27 +0000)]
StandardCanPlayThrough.html does not work on iOS.
https://bugs.webkit.org/show_bug.cgi?id=169207

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-03-06
Reviewed by Jer Noble.

On iOS only, add muted=true and autoplay=allowed. The loading policy on iOS requires these attributes to load enough
data to trigger canPlayThrough.

* Media/StandardCanPlayThrough.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS] Disable autoplay of silent videos in low power mode
cdumez@apple.com [Mon, 6 Mar 2017 19:43:27 +0000 (19:43 +0000)]
[iOS] Disable autoplay of silent videos in low power mode
https://bugs.webkit.org/show_bug.cgi?id=168985
<rdar://problem/30739051>

Reviewed by Jer Noble.

Source/WebCore:

Disable autoplay of silent videos in low power mode on iOS to save battery.
We force the display of the start button when denying autoplay in low power
mode to allow the user to start playback.

Test: media/modern-media-controls/start-support/start-support-lowPowerMode.html

* Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::shouldForceControlsDisplay):
* Modules/mediacontrols/MediaControlsHost.h:
* Modules/mediacontrols/MediaControlsHost.idl:
Add shouldForceControlsDisplay property on MediaControlsHost. This property
is set to true when we want to force the display for media controls. Currently,
this only returns true for autoplay videos, while in low power mode.

* Modules/modern-media-controls/media/controls-visibility-support.js:
(ControlsVisibilitySupport.prototype._updateControls):
Take into consideration MediaControlsHost.shouldForceControlsDisplay when
initializing shouldShowControls variable.

* Modules/modern-media-controls/media/start-support.js:
(StartSupport.prototype._shouldShowStartButton):
Show the start button when MediaControlsHost.shouldForceControlsDisplay
returns true.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode restriction
to the session when low power mode is enabled so we know we need to force a
gesture to start playback of autoplay videos.

(WebCore::HTMLMediaElement::shouldForceControlsDisplay):
Add convenience function to decide if we should force display of media controls.
This returns true if the media element is a video with autoplay attribute and
its session has the MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction (i.e. we are in low power mode).

(WebCore::HTMLMediaElement::configureMediaControls):
Force requireControls variable to true if shouldForceControlsDisplay() returns
true. We do this here instead of inside HTMLMediaElement::controls() because
we do not want to change the value of media.controls exposed to JavaScript.

(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode to the list
of restrictions that get removed on user gesture.

* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackPermitted):
Deny playback for videos that have the RequireUserGestureForVideoDueToLowPowerMode
restriction unless there is a user gesture.

* html/MediaElementSession.h:
Add new MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction.

LayoutTests:

Add layout test coverage.

* media/modern-media-controls/start-support/start-support-lowPowerMode-expected.txt: Added.
* media/modern-media-controls/start-support/start-support-lowPowerMode.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark media/modern-media-controls/icon-button/icon-button-active-state.html as flaky.
ryanhaddad@apple.com [Mon, 6 Mar 2017 19:24:48 +0000 (19:24 +0000)]
Mark media/modern-media-controls/icon-button/icon-button-active-state.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167752

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayoutTest fast/dom/timer-throttling-hidden-page.html is a flaky failure
cdumez@apple.com [Mon, 6 Mar 2017 19:14:21 +0000 (19:14 +0000)]
LayoutTest fast/dom/timer-throttling-hidden-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168927

Reviewed by Simon Fraser.

Source/WebCore:

Update internals.isTimerThrottled() to return true for any kind of throttling.
It used to only account only for specific timers that do not cause changes
inside the viewport. It now accounts for all kind of throttling, such as
timer alignment due to the page being hidden.

* page/DOMTimer.h:
* testing/Internals.cpp:
(WebCore::Internals::isTimerThrottled):

LayoutTests:

* fast/dom/nested-timer-visible-element-throttling.html:
* fast/dom/repeating-timer-element-overflow-throttling.html:
* fast/dom/repeating-timer-element-overflowing-child-own-layer-throttling.html:
* fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html:
* fast/dom/repeating-timer-visible-element-throttling.html:
* fast/dom/timer-height-change-no-throttling.html:
* fast/frames/flattening/resources/iframe-to-resize.html:
Use 10 milliseconds interval for tests relying on internals.isTimerThrottled().
Using 0 is problematic because we always internally cap to 1ms and 4ms after
reaching the max nesting level. Therefore, a 0 delay timer is always considered
to be throttled.

* fast/dom/timer-throttling-hidden-page-expected.txt:
* fast/dom/timer-throttling-hidden-page-non-nested-expected.txt:
* fast/dom/timer-throttling-hidden-page-non-nested.html:
* fast/dom/timer-throttling-hidden-page.html:
Rewrite tests to stop measuring timer intervals as this is inherently
flaky and rely on internals.isTimerThrottled() instead.

* platform/mac/TestExpectations:
Unskip test that used to be flaky.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[css-grid] Import W3C Test Suite
rego@igalia.com [Mon, 6 Mar 2017 19:09:41 +0000 (19:09 +0000)]
[css-grid] Import W3C Test Suite
https://bugs.webkit.org/show_bug.cgi?id=169196

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

This patch imports the CSS Grid Layout test suite from csswg-test repository:
https://github.com/w3c/csswg-test/tree/master/css-grid-1

* csswg-test/css-grid-1/OWNERS: Added.
* csswg-test/css-grid-1/README.md: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage.html: Added.
* csswg-test/css-grid-1/grid-definition/fr-unit.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-basic-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-basic.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation-expected.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation.html: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-repeat-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-support-repeat-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.xht: Added.
* csswg-test/css-grid-1/grid-definition/support/testing-utils.js: Added.
(checkGridTemplateRows):
(testGridTemplateColumnsRows):
(testGridTemplateAreas):
(TestingUtils):
* csswg-test/css-grid-1/grid-definition/support/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-definition/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-001.html: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-002.html: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-003.html: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-item-containing-block-004.html: Added.
* csswg-test/css-grid-1/grid-items/grid-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-a-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-a.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-b-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-layout-z-order-b.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009-expected.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017.html: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018.html: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-order-property-painting-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.xht: Added.
* csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.xht: Added.
* csswg-test/css-grid-1/grid-items/ref-filled-green-100px-square-image.html: Added.
* csswg-test/css-grid-1/grid-items/support/100x100-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/100x50-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/200x200-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/50x100-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/50x50-green.png: Added.
* csswg-test/css-grid-1/grid-items/support/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-items/w3c-import.log: Added.
* csswg-test/css-grid-1/grid-layout-properties-expected.txt: Added.
* csswg-test/css-grid-1/grid-layout-properties.html: Added.
* csswg-test/css-grid-1/grid-model/display-grid-expected.html: Added.
* csswg-test/css-grid-1/grid-model/display-grid.html: Added.
* csswg-test/css-grid-1/grid-model/display-inline-grid-expected.html: Added.
* csswg-test/css-grid-1/grid-model/display-inline-grid.html: Added.
* csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-grid-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-grid-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-letter-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-first-line-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-float-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-float-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-002-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-002.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-003-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-first-line-003.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-float-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-float-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-multicol-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-multicol-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-multicol-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-multicol-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-support-display-001-expected.txt: Added.
* csswg-test/css-grid-1/grid-model/grid-support-display-001.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-vertical-align-001-expected.xht: Added.
* csswg-test/css-grid-1/grid-model/grid-vertical-align-001.xht: Added.
* csswg-test/css-grid-1/grid-model/w3c-import.log: Added.
* csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001-expected.html: Added.
* csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001.html: Added.
* csswg-test/css-grid-1/implicit-grids/w3c-import.log: Added.
* csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit-expected.html: Added.
* csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit.html: Added.
* csswg-test/css-grid-1/layout-algorithm/w3c-import.log: Added.
* csswg-test/css-grid-1/placement/grid-layout-grid-span-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-grid-span.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines-shorthands-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines-shorthands.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-lines.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-placement-shorthands-expected.html: Added.
* csswg-test/css-grid-1/placement/grid-layout-placement-shorthands.html: Added.
* csswg-test/css-grid-1/placement/w3c-import.log: Added.
* csswg-test/css-grid-1/test-plan/index.html: Added.
* csswg-test/css-grid-1/test-plan/w3c-import.log: Added.
* csswg-test/css-grid-1/w3c-import.log: Added.
* resources/import-expectations.json:
* resources/resource-files.json:

LayoutTests:

A few tests are not passing yet, so the TextExpectations file
has been updated accordingly linking the different bugs.

* TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] [Linux] Test stress/spread-forward-call-varargs-stack-overflow.js fails
clopez@igalia.com [Mon, 6 Mar 2017 19:01:41 +0000 (19:01 +0000)]
[JSC] [Linux] Test stress/spread-forward-call-varargs-stack-overflow.js fails
https://bugs.webkit.org/show_bug.cgi?id=169206

Unreviewed test gardening.

* stress/spread-forward-call-varargs-stack-overflow.js: Skip on Linux platforms.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEnable fieldsets to be flexboxes, grids and multicolumn.
hyatt@apple.com [Mon, 6 Mar 2017 18:00:35 +0000 (18:00 +0000)]
Enable fieldsets to be flexboxes, grids and multicolumn.
https://bugs.webkit.org/show_bug.cgi?id=169082

Source/WebCore:

Reviewed by Simon Fraser .

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
Remove RenderFieldset from the project.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::createElementRenderer):
* html/HTMLFieldSetElement.h:
The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

* rendering/OrderIterator.cpp:
(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):
* rendering/OrderIterator.h:
Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):
* rendering/RenderBlock.h:
This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

* rendering/RenderBlockFlow.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

* rendering/RenderBox.h:
(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
* rendering/RenderElement.h:
Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

* rendering/RenderFieldset.cpp: Removed.
* rendering/RenderFieldset.h: Removed.
Remove RenderFieldset files from the tree.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

* rendering/RenderObject.h:
(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.
* rendering/RenderRubyRun.h:
Rename layoutSpecialExcludedChild to layoutExcludedChildren.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.
* rendering/RenderTable.h:
Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.
* rendering/RenderTextControlMultiLine.h:
Renamed the methods for doing the excluded child layout.

* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

Reviewed by Simon Fraser.

* fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
* fast/forms/fieldset/abs-pos-child-sizing.html: Added.
* fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
* fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
* fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
* fast/forms/fieldset/fieldset-flexbox.html: Added.
* fast/forms/fieldset/fieldset-grid-expected.html: Added.
* fast/forms/fieldset/fieldset-grid.html: Added.
* fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
* fast/forms/fieldset/fieldset-multicolumn.html: Added.
* fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
* fast/forms/fieldset/fieldset-overflow-auto.html: Added.
* fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
* fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
* fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
* fast/forms/fieldset/fieldset-positioned-children.html: Added.
* fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
* fast/forms/fieldset/fieldset-positioned-legend.html: Added.
* fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
* fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
* fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
* fast/forms/fieldset/fieldset-writing-modes.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Modern Media Controls] Tracks panel should clip and scroll content when numerous...
commit-queue@webkit.org [Mon, 6 Mar 2017 17:49:50 +0000 (17:49 +0000)]
[Modern Media Controls] Tracks panel should clip and scroll content when numerous tracks are available
https://bugs.webkit.org/show_bug.cgi?id=169201
<rdar://problem/30867979>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-06
Reviewed by Eric Carlson.

Source/WebCore:

We now position and size the tracks panel dynamically and ensure a max-height is applied
to the panel so that it allows a margin of 10px above it within the media controls. We also
apply that same max-height to a new intermediary scrollable container for the track lists,
so that it scrolls independently of the container and the background tint.

Test: media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html

* Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls.prototype.showTracksPanel): Deleted.
* Modules/modern-media-controls/controls/macos-inline-media-controls.css:
(.media-controls.mac.inline .volume.slider):
(.media-controls.mac.inline .tracks-panel): Deleted.
* Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls.prototype.showTracksPanel): Deleted.
* Modules/modern-media-controls/controls/macos-media-controls.js:
(MacOSMediaControls.prototype.showTracksPanel):
* Modules/modern-media-controls/controls/tracks-panel.css:
(.tracks-panel > .background-tint > div,):
(.tracks-panel > .scrollable-container):
(.tracks-panel section):
(.tracks-panel section:first-of-type):
(.tracks-panel section > h3):
(.tracks-panel section > ul):
(.tracks-panel section > ul > li):
(.tracks-panel section > ul > li:focus):
(.tracks-panel section > ul > li.selected:before):
(.tracks-panel section > ul > li.animated):
(.tracks-panel > .background-tint > div): Deleted.
(.tracks-panel > section): Deleted.
(.tracks-panel > section:first-of-type): Deleted.
(.tracks-panel > section > h3): Deleted.
(.tracks-panel > section > ul): Deleted.
(.tracks-panel > section > ul > li): Deleted.
(.tracks-panel > section > ul > li:focus): Deleted.
(.tracks-panel > section > ul > li.selected:before): Deleted.
(.tracks-panel > section > ul > li.animated): Deleted.
* Modules/modern-media-controls/controls/tracks-panel.js:
(TracksPanel.prototype.presentInParent):
(TracksPanel.prototype.get maxHeight):
(TracksPanel.prototype.set maxHeight):
(TracksPanel.prototype.commitProperty):
(TracksPanel.prototype._childrenFromDataSource):

LayoutTests:

Rebaseline a couple of existing tests to account for the DOM structure change in
the tracks panel and the fact that positioning is now dependent on the bounds of
the tracks button.

We also add a new test that checks that the tracks panel is positioned and sized
correctly to ensure that it can be scrolled when it has too many tracks to fit.

* media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt:
* media/modern-media-controls/tracks-panel/tracks-panel-population.html:
* media/modern-media-controls/tracks-panel/tracks-panel-position-and-size-expected.txt: Added.
* media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html: Added.
* media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse-expected.txt:
* media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Allow indexed module namespace object fields
utatane.tea@gmail.com [Mon, 6 Mar 2017 17:26:35 +0000 (17:26 +0000)]
[JSC] Allow indexed module namespace object fields
https://bugs.webkit.org/show_bug.cgi?id=168870

Reviewed by Saam Barati.

JSTests:

* wasm/spec-tests/names.wast.js:

Source/JavaScriptCore:

While JS modules cannot expose any indexed bindings,
Wasm modules can expose them. However, module namespace
object currently does not support indexed properties.
This patch allows module namespace objects to offer
indexed binding accesses.

* runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::getOwnPropertySlot):
(JSC::JSModuleNamespaceObject::getOwnPropertySlotByIndex):
* runtime/JSModuleNamespaceObject.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoNull pointer crash when loading module with unresolved import also as a script file
utatane.tea@gmail.com [Mon, 6 Mar 2017 16:57:11 +0000 (16:57 +0000)]
Null pointer crash when loading module with unresolved import also as a script file
https://bugs.webkit.org/show_bug.cgi?id=168971

Reviewed by Saam Barati.

JSTests:

* stress/re-execute-error-module.js: Added.
(shouldBe):
(async):
* stress/resources/error-module.js: Added.

Source/JavaScriptCore:

If linking throws an error, this error should be re-thrown
when requesting the same module.

* builtins/ModuleLoaderPrototype.js:
(globalPrivate.newRegistryEntry):
* runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::link):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, fix AppleWin build
utatane.tea@gmail.com [Mon, 6 Mar 2017 16:02:51 +0000 (16:02 +0000)]
Unreviewed, fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=164032

* Source/cmake/WebKitFeatures.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK][JSCOnly] Enable WebAssembly on Linux environment
utatane.tea@gmail.com [Mon, 6 Mar 2017 15:43:30 +0000 (15:43 +0000)]
[GTK][JSCOnly] Enable WebAssembly on Linux environment
https://bugs.webkit.org/show_bug.cgi?id=164032

Reviewed by Michael Catanzaro.

.:

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

This patch enables WebAssembly on JSCOnly and GTK ports.
Basically, almost all the WASM code is portable to Linux.
One platform-dependent part is faster memory load using SIGBUS
signal handler. This patch ports this part to Linux.

* CMakeLists.txt:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* wasm/WasmFaultSignalHandler.cpp:
(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

Tools:

* Scripts/run-jsc-stress-tests:
Enable WASM tests.

* Scripts/webkitperl/FeatureList.pm:
Enable WebAssembly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[css-grid] Stretch should grow and shrink items to fit its grid area
rego@igalia.com [Mon, 6 Mar 2017 15:30:34 +0000 (15:30 +0000)]
[css-grid] Stretch should grow and shrink items to fit its grid area
https://bugs.webkit.org/show_bug.cgi?id=163200

Reviewed by Darin Adler.

Source/WebCore:

After some discussions the CSS WG agreed that stretch should not only
grow items, but also shrink them to fit its grid area.
That way the "min-width|height: auto" is somehow ignored for grid items.
More info at: https://github.com/w3c/csswg-drafts/issues/283

The good part is that this allows us to remove some ugly code we've
in RenderBox that was only used by Grid Layout.

For images, we'll be stretching on both axis right now, so the aspect
ratio won't be preserved. The default behavior might change in those
cases, but that should be implemented in a different patch.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):

LayoutTests:

The tests have been updated according to the new expected behavior.

* fast/css-grid-layout/grid-container-percentage-columns.html:
* fast/css-grid-layout/min-width-height-auto-and-margins.html:
* fast/css-grid-layout/min-width-height-auto.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned...
magomez@igalia.com [Mon, 6 Mar 2017 14:19:40 +0000 (14:19 +0000)]
[GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned char const*, unsigned long) at Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:303
https://bugs.webkit.org/show_bug.cgi?id=167304

Reviewed by Carlos Garcia Campos.

Add a lock to ensure that the GIFImageReader that we are using for decoding is not deleted while
the decoding thread is using it.

No new tests.

* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::clearFrameBufferCache):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCurrency digits calculation in Intl.NumberFormat should call out to ICU
commit-queue@webkit.org [Mon, 6 Mar 2017 14:06:18 +0000 (14:06 +0000)]
Currency digits calculation in Intl.NumberFormat should call out to ICU
https://bugs.webkit.org/show_bug.cgi?id=169182

Patch by Daniel Ehrenberg <littledan@igalia.com> on 2017-03-06
Reviewed by Yusuke Suzuki.

* runtime/IntlNumberFormat.cpp:
(JSC::computeCurrencyDigits):
(JSC::computeCurrencySortKey): Deleted.
(JSC::extractCurrencySortKey): Deleted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAllow render tree building before loading stylesheet elements
antti@apple.com [Mon, 6 Mar 2017 12:19:43 +0000 (12:19 +0000)]
Allow render tree building before loading stylesheet elements
https://bugs.webkit.org/show_bug.cgi?id=169079
Source/WebCore:

<rdar://problem/30865709>

Reviewed by Andreas Kling.

Currently we don't resolve style or construct renderers if there are any pending
stylesheet loads. This patch enables style and renderer constuction up to the
first encountered loading style element.

This is a step toward allowing incremental rendering for in-body stylesheets.

* dom/Document.cpp:
(WebCore::Document::needsStyleRecalc):

    Ensure scrolling to anchor eventually happens.

* dom/Document.h:
(WebCore::Document::isIgnoringPendingStylesheets):
* dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::removedFrom):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
* style/StyleScope.cpp:
(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):

    Track pending sheet nodes in a map so we can test if a given node has a pending sheet.
    This is also more robust in general.

(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet):
(WebCore::Style::Scope::updateActiveStyleSheets):
* style/StyleScope.h:
(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheets):
(WebCore::Style::Scope::addPendingSheet): Deleted.
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::styleForElement):

    Instead of global test for placeholder construction check the status of the pending sheet flag.

(WebCore::Style::hasLoadingStylesheet):
(WebCore::Style::TreeResolver::resolveComposedTree):

    Set a flag when encountering a pending top level sheet during DOM traversal.

(WebCore::Style::TreeResolver::resolve):
* style/StyleTreeResolver.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

    Ensure SVG images have layout before getting the size.

LayoutTests:

Reviewed by Andreas Kling.

Ensure that style is synchronized after adding a stylesheet dynamically by doing an additional test.
Otherwise the class/attr invalidation test may as we don't know about the new stylesheet yet.
This is functionally fine (future synchronization would invalidate the style) but messes up the test
trying to verify class/attr change invalidation specifically.

* fast/css/style-invalidation-attribute-change-descendants-expected.txt:
* fast/css/style-invalidation-attribute-change-descendants.html:
* fast/css/style-invalidation-class-change-descendants-expected.txt:
* fast/css/style-invalidation-class-change-descendants.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer] Adopt nullptr
commit-queue@webkit.org [Mon, 6 Mar 2017 10:32:57 +0000 (10:32 +0000)]
[GStreamer] Adopt nullptr
https://bugs.webkit.org/show_bug.cgi?id=123438

Patch by Vanessa Chipirrás Navalón <vchipirras@igalia.com> on 2017-03-06
Reviewed by Xabier Rodriguez-Calvar.

To adapt the code to the C++11 standard, all NULL or 0 pointers have been changed to nullptr.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
* platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::configureAudioBin):
(WebCore::AudioSourceProviderGStreamer::setClient):
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::setEnabled):
* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
(WebCore::initializeGStreamerAndRegisterWebKitElements):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed the unused second argument on processTableOfContentsEntry function.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
Removed the unused second argument on this function.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Removed the unused second argument on processTableOfContentsEntry function.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):
* platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webkit_text_combiner_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerRequestNewPad):
(webkitTextCombinerNew):
* platform/graphics/gstreamer/TextSinkGStreamer.cpp:
(webkitTextSinkNew):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_init):
(webkitVideoSinkProposeAllocation):
(webkitVideoSinkNew):
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::setSelected):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcSetProperty):
(webKitWebSrcStop):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetProtocols):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):
* platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcGetProtocols):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS] Report domains crashing under memory pressure via enhanced privacy logging.
akling@apple.com [Mon, 6 Mar 2017 10:02:09 +0000 (10:02 +0000)]
[iOS] Report domains crashing under memory pressure via enhanced privacy logging.
<https://webkit.org/b/169133>
<rdar://problem/29964017>

Reviewed by Antti Koivisto.

Source/WebCore:

* page/DiagnosticLoggingKeys.h:

Source/WebKit2:

Notify the UI process when the memory pressure status changes.
If a web process crashes while under memory pressure, log the domain of the last open page
using enhanced privacy logging.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::memoryPressureStatusChanged):
(WebKit::WebProcessProxy::isUnderMemoryPressure):
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Source/WTF:

Add a mechanism for getting a callback when the memory pressure status changes.

* wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::measurementTimerFired):
(WTF::MemoryPressureHandler::beginSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::endSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::setUnderMemoryPressure):
(WTF::MemoryPressureHandler::memoryPressureStatusChanged):
* wtf/MemoryPressureHandler.h:
(WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback):
(WTF::MemoryPressureHandler::setUnderMemoryPressure): Deleted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Rebaseline fast/css/css2-system-fonts.html after r213267.
carlosgc@webkit.org [Mon, 6 Mar 2017 07:38:24 +0000 (07:38 +0000)]
Unreviewed GTK+ gardening. Rebaseline fast/css/css2-system-fonts.html after r213267.

* platform/gtk/fast/css/css2-system-fonts-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove new files accidentally added in r213441
beidson@apple.com [Mon, 6 Mar 2017 05:51:57 +0000 (05:51 +0000)]
Remove new files accidentally added in r213441

Unreviewed.

* UIProcess/WebLoadingProviderProxy.cpp: Removed.
* UIProcess/WebLoadingProviderProxy.h: Removed.
* UIProcess/WebLoadingProviderProxy.messages.in: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename CustomProtocolFoo to LegacyCustomProtocolFoo.
beidson@apple.com [Mon, 6 Mar 2017 02:53:31 +0000 (02:53 +0000)]
Rename CustomProtocolFoo to LegacyCustomProtocolFoo.
https://bugs.webkit.org/show_bug.cgi?id=169188

Reviewed by Andy Estes.

* CMakeLists.txt:
* DerivedSources.make:

* NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm.
(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(+[WKCustomProtocol requestIsCacheEquivalent:toRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol initializationRunLoop]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::LegacyCustomProtocolManager::registerProtocolClass):
(WebKit::LegacyCustomProtocolManager::registerScheme):
(WebKit::LegacyCustomProtocolManager::unregisterScheme):
(WebKit::LegacyCustomProtocolManager::supportsScheme):
(WebKit::dispatchOnInitializationRunLoop):
(WebKit::LegacyCustomProtocolManager::didFailWithError):
(WebKit::LegacyCustomProtocolManager::didLoadData):
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
(WebKit::LegacyCustomProtocolManager::didFinishLoading):
(WebKit::LegacyCustomProtocolManager::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManager::protocolForID):

* NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.cpp.
(WebKit::generateCustomProtocolID):
(WebKit::LegacyCustomProtocolManager::supplementName):
(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::initialize):
(WebKit::LegacyCustomProtocolManager::addCustomProtocol):
(WebKit::LegacyCustomProtocolManager::removeCustomProtocol):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):
* NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.h.
* NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.messages.in.

* NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp.
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::registerProtocolClass):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::wasRedirectedToRequest):

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):

* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::create):
* NetworkProcess/NetworkSession.h:

* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::globalLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::setLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::defaultSession):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::globalCustomProtocolManager): Deleted.
(WebKit::NetworkSessionCocoa::setCustomProtocolManager): Deleted.

* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

* UIProcess/API/APICustomProtocolManagerClient.h:
(API::LegacyCustomProtocolManagerClient::~LegacyCustomProtocolManagerClient):
(API::LegacyCustomProtocolManagerClient::startLoading):
(API::LegacyCustomProtocolManagerClient::stopLoading):
(API::LegacyCustomProtocolManagerClient::invalidate):
(API::CustomProtocolManagerClient::~CustomProtocolManagerClient): Deleted.
(API::CustomProtocolManagerClient::startLoading): Deleted.
(API::CustomProtocolManagerClient::stopLoading): Deleted.
(API::CustomProtocolManagerClient::invalidate): Deleted.

* UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h.
* UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm.
(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader customProtocolManagerProxyDestroyed]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:willCacheResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):
(WebKit::LegacyCustomProtocolManagerClient::stopLoading):
(WebKit::LegacyCustomProtocolManagerClient::invalidate):

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):

* UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp: Removed.
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp: Added.
(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h.
* UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in.

* UIProcess/Network/NetworkProcessProxy.cpp:
* UIProcess/Network/NetworkProcessProxy.h:

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient):
(WebKit::WebProcessPool::registerSchemeForCustomProtocol):
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol):
(WebKit::WebProcessPool::setCustomProtocolManagerClient): Deleted.
* UIProcess/WebProcessPool.h:

* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/cocoa/WebProcessCocoa.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAvoid backing store for layers with empty text nodes in a few more cases
simon.fraser@apple.com [Mon, 6 Mar 2017 02:48:20 +0000 (02:48 +0000)]
Avoid backing store for layers with empty text nodes in a few more cases
https://bugs.webkit.org/show_bug.cgi?id=169185

Reviewed by Dan Bernstein.

Source/WebCore:

In hasPaintingNonLayerDescendants() we can check whether the RenderText's linesBoundingBox()
is empty to avoid backing store in a few more cases. Also use containsOnlyWhitespace() rather
than isAllCollapsibleWhitespace(), because there's no need for backing store for non-selectable
whitespace text.

Covered by existing tests.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

inline-block-no-backing.html enhanced to have a layer with non-collapsible whitespace (an &nbsp;).

Rebaselined other tests.

* compositing/backing/inline-block-no-backing-expected.txt:
* compositing/backing/inline-block-no-backing.html:
* compositing/iframes/page-cache-layer-tree-expected.txt:
* css3/blending/blend-mode-clip-accelerated-blending-canvas-expected.txt:
* platform/ios-simulator-wk2/compositing/backing/inline-block-no-backing-expected.txt:
* platform/ios-simulator-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDrop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename()
cdumez@apple.com [Mon, 6 Mar 2017 01:37:53 +0000 (01:37 +0000)]
Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename()
https://bugs.webkit.org/show_bug.cgi?id=169066

Reviewed by Sam Weinig.

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename().

* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUsing <form> in <template> causes following <form> to get swallowed
cdumez@apple.com [Mon, 6 Mar 2017 01:36:30 +0000 (01:36 +0000)]
Using <form> in <template> causes following <form> to get swallowed
https://bugs.webkit.org/show_bug.cgi?id=163552

Reviewed by Sam Weinig.

Source/WebCore:

As per the HTML specification [1], when finding a "form" tag in the "in body"
insertion mode, we should insert an HTML element for the token, and, if there
is no template element on the stack of open elements, set the form element
pointer to point to the element created.

We were missing the "if there is no template element on the stack of open
elements" check and setting the form element pointer unconditionally.
This patch fixes the issue.

[1] https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody:form-element-pointer-2

Test: fast/parser/form-after-template.html

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLFormElement):

LayoutTests:

Add layout test coverage.

* fast/parser/form-after-template-expected.html: Added.
* fast/parser/form-after-template.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd support for canvas.toBlob
aestes@apple.com [Sun, 5 Mar 2017 20:31:06 +0000 (20:31 +0000)]
Add support for canvas.toBlob
https://bugs.webkit.org/show_bug.cgi?id=148878

Reviewed by Tim Horton.

Address additional review feedback received after r213412 landed.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toBlob): Passed null to the blob callback if blob conversion
fails for any reason.
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::cgImage): Removed an unnecessary local variable.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate CSSFontSelector's matching algorithm to understand ranges
mmaxfield@apple.com [Sun, 5 Mar 2017 20:14:02 +0000 (20:14 +0000)]
Update CSSFontSelector's matching algorithm to understand ranges
https://bugs.webkit.org/show_bug.cgi?id=168892

Reviewed by Jon Lee.

Source/WebCore:

This patch migrates the font selection algorithm out of FontCacheCoreText and into its own file which can be shared
among all ports. It then migrates our web font selection algorithm to use it.

This patch doesn't actually change the parsing rules; it just changes the internal machinery for how fonts get
selected. Therefore, this patch simply makes zero-length ranges from the discrete values the parser emits, and passes
those zero-length ranges to the range-based font selection routine. This means that this patch doesn't actually
change the results of the font selection algorithm.

One of the inputs to the new font selection algorithm is font-stretch, which previously was not parsed inside
@font-face blocks or the CSS Font Loading API. This patch therefore adds parsing support and modifies the existing
tests for these pieces to expect parsing to work. Because the font selection algorithm itself is shared between
installed fonts and webfonts, this patch doesn't add any additional tests for it (because it is already covered under
existing tests).

No new tests because there is no behavior change.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj: Add new file for the font selection algorithm.
* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::calculateStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFace::setStretch): Fill out the previously stubbed function.
* css/CSSFontFace.h: Add the range member variable to CSSFontFaces.
* css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered): Now that we care about font-stretch, we need to
look it up for local fonts too. This current approach of an extra FontSelectionValue hanging around with a
FontTraitsMask is very ugly and will be removed soon (https://bugs.webkit.org/show_bug.cgi?id=168889 and
https://bugs.webkit.org/show_bug.cgi?id=168890).
(WebCore::computeFontStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFaceSet::matchingFaces): Educate about font-stretch.
(WebCore::CSSFontFaceSet::fontFace): Migrate to the new font-selection algorithm.
(WebCore::fontFaceComparator): Deleted.
* css/CSSFontFaceSet.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Educate about font-stretch.
(WebCore::CSSFontSelector::fontRangesForFamily): Ditto.
* css/FontFace.cpp:
(WebCore::FontFace::setStretch): Ditto.
(WebCore::FontFace::stretch): Ditto.
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseFontFaceDescriptor): Ditto.
* platform/graphics/FontCache.h: Ditto.
* platform/graphics/FontDescription.h:
* platform/graphics/FontSelectionAlgorithm.cpp: Added.
(WebCore::FontSelectionAlgorithm::filterCapability):
(WebCore::FontSelectionAlgorithm::indexOfBestCapabilities):
(WebCore::fontSelectionRequestForTraitsMask):
(WebCore::initialFontSelectionCapabilitiesForTraitsMask):
(WebCore::fontSelectionCapabilitiesForTraitsMask):
* platform/graphics/FontSelectionAlgorithm.h: Added. Taken from FontCacheCoreText.cpp.
(WebCore::FontSelectionValue::FontSelectionValue):
(WebCore::FontSelectionValue::operator float):
(WebCore::FontSelectionValue::rawValue):
(WebCore::FontSelectionValue::maximumValue):
(WebCore::FontSelectionValue::minimumValue):
(WebCore::FontSelectionValue::operator+):
(WebCore::FontSelectionValue::operator-):
(WebCore::FontSelectionValue::operator*):
(WebCore::FontSelectionValue::operator/):
(WebCore::FontSelectionValue::operator==):
(WebCore::FontSelectionValue::operator!=):
(WebCore::FontSelectionValue::operator<):
(WebCore::FontSelectionValue::operator<=):
(WebCore::FontSelectionValue::operator>):
(WebCore::FontSelectionValue::operator>=):
(WebCore::FontSelectionRange::isValid):
(WebCore::FontSelectionRange::expand):
(WebCore::FontSelectionRange::includes):
(WebCore::FontSelectionRequest::operator==):
(WebCore::FontSelectionRequest::operator!=):
(WebCore::FontSelectionRequestKey::FontSelectionRequestKey):
(WebCore::FontSelectionRequestKey::isHashTableDeletedValue):
(WebCore::FontSelectionRequestKey::operator==):
(WebCore::FontSelectionRequestKeyHash::hash):
(WebCore::FontSelectionRequestKeyHash::equal):
(WebCore::FontSelectionCapabilities::expand):
(WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilitiesWithReturn):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilities):
* platform/graphics/cocoa/FontCacheCoreText.cpp: Moved to FontSelectionAlgorithm.
(WebCore::stretchFromCoreTextTraits):
(WebCore::FontDatabase::capabilitiesForFontDescriptor):
(WebCore::findClosestFont):
(WebCore::calculateFontSelectionRequest):
(WebCore::platformFontLookupWithFamily):
(WebCore::FontCache::getTraitsInFamily): Deleted.
(WebCore::iterateActiveFontsWithReturn): Deleted.
(WebCore::iterateActiveFonts): Deleted.
(WebCore::findClosestStretch): Deleted.
(WebCore::filterStretch): Deleted.
(WebCore::findClosestStyle): Deleted.
(WebCore::filterStyle): Deleted.
(WebCore::findClosestWeight): Deleted.
(WebCore::filterWeight): Deleted.
(WebCore::computeTargetWeight): Deleted.
* platform/text/TextFlags.h: Moved to FontSelectionAlgorithm.
(WebCore::FontSelectionValue::FontSelectionValue): Deleted.
(WebCore::FontSelectionValue::operator float): Deleted.
(WebCore::FontSelectionValue::operator+): Deleted.
(WebCore::FontSelectionValue::operator-): Deleted.
(WebCore::FontSelectionValue::operator*): Deleted.
(WebCore::FontSelectionValue::operator/): Deleted.
(WebCore::FontSelectionValue::operator==): Deleted.
(WebCore::FontSelectionValue::operator!=): Deleted.
(WebCore::FontSelectionValue::operator<): Deleted.
(WebCore::FontSelectionValue::operator<=): Deleted.
(WebCore::FontSelectionValue::operator>): Deleted.
(WebCore::FontSelectionValue::operator>=): Deleted.
(WebCore::FontSelectionValue::rawValue): Deleted.
(WebCore::FontSelectionValue::maximumValue): Deleted.
(WebCore::FontSelectionValue::minimumValue): Deleted.
(WebCore::FontSelectionRange::isValid): Deleted.
(WebCore::FontSelectionRange::expand): Deleted.
(WebCore::FontSelectionRange::includes): Deleted.
(WebCore::FontSelectionCapabilities::expand): Deleted.

LayoutTests:

Update CSS Font Loading API test to accept font-stretch values.

* fast/text/font-face-javascript-expected.txt:
* fast/text/font-face-javascript.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake some RenderLayer tree traversal in RenderLayerBacking more generic
simon.fraser@apple.com [Sun, 5 Mar 2017 19:14:12 +0000 (19:14 +0000)]
Make some RenderLayer tree traversal in RenderLayerBacking more generic
https://bugs.webkit.org/show_bug.cgi?id=169177

Reviewed by Zalan Bujtas.

The real goal of this patch is reduce the number of callers of
RenderLayerBacking::isPaintDestinationForDescendantLayers() to one. To achieve that,
have the setContentsVisible() logic (which is really just about the CSS 'visibility' property)
do its own tree traversal which just consults layer.hasVisibleContent(). So
make descendantLayerPaintsIntoAncestor() a generic traversal function which walks
descendant layers which may paint into the target layer. The "Visible" in the name
reflects the fact that it can bypass a subtree for a layer with !hasVisibleDescendant().

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::traverseVisibleNonCompositedDescendantLayers):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::descendantLayerPaintsIntoAncestor): Deleted.
* rendering/RenderLayerBacking.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Two file reset tests are failing in the bots since they were added in r213042
commit-queue@webkit.org [Sun, 5 Mar 2017 11:10:10 +0000 (11:10 +0000)]
[GTK] Two file reset tests are failing in the bots since they were added in r213042
https://bugs.webkit.org/show_bug.cgi?id=169126

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-03-05
Reviewed by Michael Catanzaro.

They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change
event. In one case this causes that the reset button is not clicked, and in the other one the file input is not
unfocused. This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores
mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by
using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the
mouse up.

* fast/forms/file/file-input-reset-using-open-panel.html:
* fast/forms/file/file-reset-in-change-using-open-panel.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSCOnly][GTK] Suppress warnings on return type in B3 and WASM
utatane.tea@gmail.com [Sun, 5 Mar 2017 08:37:34 +0000 (08:37 +0000)]
[JSCOnly][GTK] Suppress warnings on return type in B3 and WASM
https://bugs.webkit.org/show_bug.cgi?id=168869

Reviewed by Keith Miller.

* b3/B3Width.h:
* wasm/WasmSections.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0
mitz@apple.com [Sun, 5 Mar 2017 07:41:25 +0000 (07:41 +0000)]
[Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0
https://bugs.webkit.org/show_bug.cgi?id=169170

Reviewed by Alex Christensen.

* Configurations/Version.xcconfig: Copied from Source/JavaScriptCore/Configurations/Version.xcconfig.
  This defines DYLIB_CURRENT_VERSION.
* Configurations/libwebrtc.xcconfig: Include Version.xcconfig.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline W3C test after r213412.
cdumez@apple.com [Sun, 5 Mar 2017 01:06:10 +0000 (01:06 +0000)]
Rebaseline W3C test after r213412.

* web-platform-tests/html/dom/interfaces-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS] The web process should inherit application state from UI process
eric.carlson@apple.com [Sat, 4 Mar 2017 22:39:47 +0000 (22:39 +0000)]
[iOS] The web process should inherit application state from UI process
https://bugs.webkit.org/show_bug.cgi?id=169156
<rdar://problem/30845473>

Reviewed by Alexey Proskuryakov.

* Platform/spi/ios/CelestialSPI.h: Added.

* WebKit2.xcodeproj/project.pbxproj: Include CelestialSPI.h.

* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Add entitlement.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformInitialize): Set up PID proxying.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoClarify some terminology in RenderLayerBacking
simon.fraser@apple.com [Sat, 4 Mar 2017 21:49:30 +0000 (21:49 +0000)]
Clarify some terminology in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=169174

Reviewed by Zalan Bujtas.

Rename some functions related to directly-composited background images and
box decorations for clarify.

Only behavior change is for canDirectlyCompositeBackgroundBackgroundImage() to check
GraphicsLayer::supportsContentsTiling(), which means that RenderLayerBacking::contentChanged()
will no longer trigger a updateGeometry() when it gets BackgroundImageChanged on non-
CoordinateGraphics platforms.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::canDirectlyCompositeBackgroundBackgroundImage):
(WebCore::hasPaintedBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents): Deleted.
(WebCore::canCreateTiledImage): Deleted.
(WebCore::hasVisibleBoxDecorationsOrBackgroundImage): Deleted.
(WebCore::supportsDirectBoxDecorationsComposition): Deleted.
* rendering/RenderLayerBacking.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd symbols required by TAPI from Shared/API/Cocoa/WebKit.m in a header file
aakash_jain@apple.com [Sat, 4 Mar 2017 21:05:31 +0000 (21:05 +0000)]
Add symbols required by TAPI from Shared/API/Cocoa/WebKit.m in a header file
https://bugs.webkit.org/show_bug.cgi?id=169162

Reviewed by Alexey Proskuryakov.

The symbols from binary and headers should match precisely, otherwise TAPI would
complain. There are few symbols which are not actually needed in header file, but
we still need to add them in a header file to make TAPI happy.

* Platform/ExtraPublicSymbolsForTAPI.h: Added.
* WebKit2.xcodeproj/project.pbxproj: Added ExtraPublicSymbolsForTAPI.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd symbols required by TAPI in a header file
aakash_jain@apple.com [Sat, 4 Mar 2017 19:53:01 +0000 (19:53 +0000)]
Add symbols required by TAPI in a header file
https://bugs.webkit.org/show_bug.cgi?id=169113
<rdar://problem/30772033>

Reviewed by Alexey Proskuryakov.

The symbols from binary and headers should match precisely, otherwise TAPI would
complain. There are few symbols which are not actually needed in header file, but
we still need to add them in a header file to make TAPI happy.

* Platform/ExtraPrivateSymbolsForTAPI.h: Added.
* WebKit2.xcodeproj/project.pbxproj: Added Platform/ExtraPrivateSymbolsForTAPI.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, remove stray period from readme
mcatanzaro@igalia.com [Sat, 4 Mar 2017 19:32:04 +0000 (19:32 +0000)]
Unreviewed, remove stray period from readme

* ReadMe.md:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[ARM] Unreviewed buildfix after r213376.
ossy@webkit.org [Sat, 4 Mar 2017 18:07:18 +0000 (18:07 +0000)]
[ARM] Unreviewed buildfix after r213376.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::isBkpt): Typo fixed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCleanup after r213418
commit-queue@webkit.org [Sat, 4 Mar 2017 17:31:06 +0000 (17:31 +0000)]
Cleanup after r213418
https://bugs.webkit.org/show_bug.cgi?id=169165

Patch by Alex Christensen <achristensen@webkit.org> on 2017-03-04
Reviewed by Youenn Fablet.

Source/ThirdParty/libwebrtc:

* WebKit/patch-libwebrtc:
I made another change after the last patch I uploaded to stop crashing.
This should be reflected in our patch.

Source/WebCore:

* platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:
(WebCore::RealtimeIncomingAudioSource::OnData):
Restore the assertion I removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r213379.
commit-queue@webkit.org [Sat, 4 Mar 2017 17:15:40 +0000 (17:15 +0000)]
Unreviewed, rolling out r213379.
https://bugs.webkit.org/show_bug.cgi?id=169169

broke GTK+ and Windows builds (Requested by mcatanzaro on
#webkit).

Reverted changeset:

"Enable fieldsets to be flexboxes, grids and multicolumn."
https://bugs.webkit.org/show_bug.cgi?id=169082
http://trac.webkit.org/changeset/213379

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoTest commit against svn.webkit.org after SHA-1 cleanup.
lforschler@apple.com [Sat, 4 Mar 2017 14:52:20 +0000 (14:52 +0000)]
Test commit against svn.webkit.org after SHA-1 cleanup.

Unreviewed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Show Web Socket connections in Network tab
nvasilyev@apple.com [Sat, 4 Mar 2017 08:57:56 +0000 (08:57 +0000)]
Web Inspector: Show Web Socket connections in Network tab
https://bugs.webkit.org/show_bug.cgi?id=167520

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Show Web Socket connections in Network and Resources tabs. Display HTTP headers
of Web Socket handshake request in the details sidebar.

* UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.initialize):
(WebInspector.FrameResourceManager.prototype.webSocketCreated):
(WebInspector.FrameResourceManager.prototype.webSocketWillSendHandshakeRequest):
webSocketWillSendHandshakeRequest doesn't receive a request URL as one of its parameters.
Store URLs received from webSocketCreated method in _webSocketIdentifierToURL map.

(WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameSent):
(WebInspector.FrameResourceManager.prototype.webSocketClosed):
Mark resource as finished when Web Socket handshake is complete or Web Socket is closed.
This may change in the future.

(WebInspector.FrameResourceManager.prototype._webSocketFrameReceivedOrSent):
* UserInterface/Main.html:

* UserInterface/Models/WebSocketResource.js: Added.
(WebInspector.WebSocketResource):
(WebInspector.WebSocketResource.prototype.set readyState):
(WebInspector.WebSocketResource.prototype.get readyState):
(WebInspector.WebSocketResource.prototype.get frames):
(WebInspector.WebSocketResource.prototype.addFrame):
Introduce WebSocketResource model to store WebSocket frames (incoming and outgoing messages)
and readyState.

* UserInterface/Protocol/NetworkObserver.js:
(WebInspector.NetworkObserver.prototype.webSocketCreated):
(WebInspector.NetworkObserver.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkObserver.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkObserver.prototype.webSocketClosed):
(WebInspector.NetworkObserver.prototype.webSocketFrameReceived):
(WebInspector.NetworkObserver.prototype.webSocketFrameError):
(WebInspector.NetworkObserver.prototype.webSocketFrameSent):
(WebInspector.NetworkObserver):
Add corresponding methods for the newly added FrameResourceManager methods.

* UserInterface/Test.html:
* UserInterface/Views/NetworkSidebarPanel.js:
(WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):
Don't show the go to arrow for WebSocket items since WebSocketContentView isn't implemented
yet.

* UserInterface/Views/ResourceClusterContentView.js:
(WebInspector.ResourceClusterContentView.prototype.get responseContentView):
Don't show any content views for WebSocket items.

* UserInterface/Views/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype.ondblclick):
Don't open WebSocket URL in a new browser tab.

LayoutTests:

* http/tests/websocket/tests/hybi/inspector/client-close-expected.txt: Added.
* http/tests/websocket/tests/hybi/inspector/client-close.html: Added.
* http/tests/websocket/tests/hybi/inspector/client-close_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/inspector/server-close-expected.txt: Added.
* http/tests/websocket/tests/hybi/inspector/server-close.html: Added.
* http/tests/websocket/tests/hybi/inspector/server-close_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
* platform/ios-simulator/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove duplicate initialization guard in WebKit2 logging initialization
commit-queue@webkit.org [Sat, 4 Mar 2017 08:38:06 +0000 (08:38 +0000)]
Remove duplicate initialization guard in WebKit2 logging initialization
https://bugs.webkit.org/show_bug.cgi?id=169164

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-04
Reviewed by Dan Bernstein.

* Platform/Logging.cpp:
(WebKit::initializeLogChannelsIfNecessary):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win64] '__int128_t': undeclared identifier in MediaTime.cpp
achristensen@apple.com [Sat, 4 Mar 2017 08:20:27 +0000 (08:20 +0000)]
[Win64] '__int128_t': undeclared identifier in MediaTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=169123

Patch by Jer Noble <jer.noble@apple.com> on 2017-03-03
Reviewed by Alex Christensen.

Don't perform the 128-bit optimized path on Windows, where the __int128_t intrinsic isn't available.

* wtf/MediaTime.cpp:
(WTF::MediaTime::setTimeScale):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebRTC] Update libwebrtc source code
achristensen@apple.com [Sat, 4 Mar 2017 07:57:50 +0000 (07:57 +0000)]
[WebRTC] Update libwebrtc source code
https://bugs.webkit.org/show_bug.cgi?id=168599

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-03
Reviewed by Alex Christensen.

Source/ThirdParty/libwebrtc:

Very long list of file changes omitted.

We updated to git commit 716e726ef0b322e8317b749613691da043bfc61c
of https://chromium.googlesource.com/external/webrtc and applied
the changes that are now in WebKit/patch-libwebrtc

Source/WebCore:

* Modules/mediastream/RTCStatsReport.h:
* Modules/mediastream/RTCStatsReport.idl:
Update to match the latest spec, which matches the new structures in libwebrtc.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCRTPStreamStats):
(WebCore::fillOutboundRTPStreamStats):
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
* platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:
(WebCore::RealtimeIncomingAudioSource::OnData):
Comment out an assertion that was failing.  We should revisit this.
* testing/MockLibWebRTCPeerConnection.h:

Source/WebKit2:

* WebProcess/Network/webrtc/LibWebRTCProvider.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r213400.
commit-queue@webkit.org [Sat, 4 Mar 2017 05:49:03 +0000 (05:49 +0000)]
Unreviewed, rolling out r213400.
https://bugs.webkit.org/show_bug.cgi?id=169163

Caused frequent assertion failures (Requested by ap on
#webkit).

Reverted changeset:

"[Modern Media Controls] Improve media documents across macOS,
iPhone and iPad"
https://bugs.webkit.org/show_bug.cgi?id=169145
http://trac.webkit.org/changeset/213400

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] build fix after r213399
clopez@igalia.com [Sat, 4 Mar 2017 05:01:43 +0000 (05:01 +0000)]
[JSC] build fix after r213399
https://bugs.webkit.org/show_bug.cgi?id=169154

Unreviewed.

* runtime/ConfigFile.cpp: Include unistd.h since its where getcwd() is defined.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd support for canvas.toBlob
aestes@apple.com [Sat, 4 Mar 2017 02:16:58 +0000 (02:16 +0000)]
Add support for canvas.toBlob
https://bugs.webkit.org/show_bug.cgi?id=148878
<rdar://problem/22590406>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:

Source/WebCore:

These tests now pass:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/BlobCallback.cpp: Added.
(WebCore::BlobCallback::scheduleCallback):
* fileapi/BlobCallback.h: Added.
(WebCore::BlobCallback::~BlobCallback):
* fileapi/BlobCallback.idl: Added.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toBlob):
* html/HTMLCanvasElement.h:
* html/HTMLCanvasElement.idl:
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::data):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
(WebCore::ImageBuffer::toCGImage):
(WebCore::cgImage):
(WebCore::dataURL):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
* platform/graphics/win/ImageBufferDirect2D.cpp:
(WebCore::ImageBuffer::toData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd WebGPU compile flag and experimental feature flag
dino@apple.com [Sat, 4 Mar 2017 02:08:13 +0000 (02:08 +0000)]
Add WebGPU compile flag and experimental feature flag
https://bugs.webkit.org/show_bug.cgi?id=169161
<rdar://problem/30846689>

Reviewed by Tim Horton.

Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
and an InternalSetting.

.:

* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebGPUEnabled):
(WebCore::RuntimeEnabledFeatures::webGPUEnabled):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setWebGPUEnabled):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences webGPUEnabled]):
(-[WebPreferences setWebGPUEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferencesDefinitions.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setWebGL2Enabled):
(WTR::TestRunner::setWebGPUEnabled):
* WebKitTestRunner/InjectedBundle/TestRunner.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoClean up some RenderLayerBacking code
simon.fraser@apple.com [Sat, 4 Mar 2017 01:45:42 +0000 (01:45 +0000)]
Clean up some RenderLayerBacking code
https://bugs.webkit.org/show_bug.cgi?id=169160

Reviewed by Dean Jackson.

Modern loops in descendantLayerPaintsIntoAncestor().

Rename RenderLayerBacking::paintsChildren() to RenderLayerBacking::paintsChildRenderers() to clarify that
it refers to renderers, not RenderLayers.

Rename RenderLayerBacking::paintsNonDirectCompositedBoxDecoration() to RenderLayerBacking::paintsBoxDecorations().
"Paints" already implies non-composited.

No behavior change.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildRenderers):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::paintsNonDirectCompositedBoxDecoration): Deleted.
(WebCore::RenderLayerBacking::paintsChildren): Deleted.
* rendering/RenderLayerBacking.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoClean up RenderImage and a RenderImageResource function
simon.fraser@apple.com [Sat, 4 Mar 2017 01:45:39 +0000 (01:45 +0000)]
Clean up RenderImage and a RenderImageResource function
https://bugs.webkit.org/show_bug.cgi?id=169153

Reviewed by Zalan Bujtas.

Change all calls to imageResource().cachedImage() in RenderImage to use the inline
cachedImage() function.

In RenderImage::paintReplaced(), early return after the broken image block (and no need
to test imageResource().hasImage() again in the second condition). Convert height/width to size,
which also forces us to be explicit about using flooredIntSize() when fetching the image
(perhaps this should be a roundedIntSize, but I didn't want to change behavior).

Change RenderImageResource::image() to take an IntSize, rather than int height and width.

No behavior change.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore::RenderImage::embeddedContentBox):
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::image):
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::image):
* rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::image):
* rendering/RenderImageResourceStyleImage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
commit-queue@webkit.org [Sat, 4 Mar 2017 01:12:40 +0000 (01:12 +0000)]
[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
https://bugs.webkit.org/show_bug.cgi?id=169145
<rdar://problem/17048858>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-03
Reviewed by Dean Jackson.

Source/WebCore:

There were a variety of issues with media documents, some longstanding, and some specifically
about modern media controls.

One issue was that fullscreen and picture-in-picture buttons would show for audio media documents,
due to using a <video> element to load the audio file. We now have additional logic in MediaController
to identify if the loaded media is really an audio file, and using this information to hide the
fullscreen and picture-in-picture buttons.

Another issue was that we would inject style in MediaDocument.cpp that was specific to modern media
controls when we could have the modern-media-controls module injected CSS handle this styling. We now
use the injected style in the shadow root to size media documents based on the device characteristics
and ensuring that page styles are overridden.

We also simplify how MediaDocument.cpp sets the source of the media element to simply use the "src"
attribute and not a <source> element.

Finally, we introduce a MediaDocumentController class that is instantiated when we're dealing with
a media document to hide the controls while we determine the type of media we're loading (audio vs.
video) in order to apply the appropriate styling without flashes.

As a result of the new styles applied by the modern-media-controls module, media documents have a
similar behavior on macOS and iPad, where we only enforce a min-width for video allowing them
to play at their natural size otherwise, and enforcing a fixed width for audio. On iPhone however,
we want to always play the media at full width, with some padding in the case of audio.

Tests: media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html
       media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html
       media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html
       media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html
       media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html
       media/modern-media-controls/media-documents/media-document-video-ios-sizing.html
       media/modern-media-controls/media-documents/media-document-video-mac-sizing.html
       media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html

* Modules/modern-media-controls/controls/ios-inline-media-controls.css:
(:host(audio) .media-controls.ios.inline > .controls-bar:before,):
(:host(audio) .media-controls.ios.inline > .controls-bar:before): Deleted.
* Modules/modern-media-controls/controls/macos-media-controls.css:
(:host(audio) .media-controls.mac.inline > .controls-bar,):
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint,):
(:host(audio) .media-controls.mac.inline > .controls-bar): Deleted.
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint): Deleted.
* Modules/modern-media-controls/controls/media-document.css: Added.
(:host(.media-document)):
(:host(.media-document.ready)):
(:host(.media-document.audio.mac)):
(:host(.media-document.audio.ipad)):
(:host(.media-document.audio.iphone)):
(:host(.media-document.video.mac)):
(:host(.media-document.video.ipad)):
(:host(.media-document.video.iphone)):
* Modules/modern-media-controls/js-files:
* Modules/modern-media-controls/media/fullscreen-support.js:
(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):
* Modules/modern-media-controls/media/media-controller.js:
(MediaController):
(MediaController.prototype.get isAudio):
* Modules/modern-media-controls/media/media-document-controller.js: Added.
(MediaDocumentController):
(MediaDocumentController.prototype.handleEvent):
(MediaDocumentController.prototype._mediaDocumentHasMetadata):
(MediaDocumentController.prototype._mediaDocumentHasSize):
* Modules/modern-media-controls/media/pip-support.js:
(PiPSupport.prototype.syncControl):
(PiPSupport):
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

We add new tests for media documents and related features that cover the following cases:

    - checking <video> with only audio tracks does not show the fullscreen button
    - checking <video> with only audio tracks does not show the picture-in-picture button
    - checking the size used in media documents for audio and video across macOS, iPhone and iPad

* media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
* media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html: Added.
* media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing-expected.txt: Added.
* media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html: Added.
* media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing-expected.txt: Added.
* media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html: Added.
* media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
* media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
* media/modern-media-controls/media-documents/media-document-audio-mac-sizing-expected.txt: Added.
* media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html: Added.
* media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
* media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
* media/modern-media-controls/media-documents/media-document-video-mac-sizing-expected.txt: Added.
* media/modern-media-controls/media-documents/media-document-video-mac-sizing.html: Added.
* media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
* media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html: Added.
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd support for relative pathnames to JSC config files
msaboff@apple.com [Sat, 4 Mar 2017 01:10:55 +0000 (01:10 +0000)]
Add support for relative pathnames to JSC config files
https://bugs.webkit.org/show_bug.cgi?id=169154

Reviewed by Saam Barati.

If the config file is a relative path, prepend the current working directory.
After canonicalizing the config file path, we extract its directory path and
use that for the directory for a relative log pathname.

* runtime/ConfigFile.cpp:
(JSC::ConfigFile::ConfigFile):
(JSC::ConfigFile::parse):
(JSC::ConfigFile::canonicalizePaths):
* runtime/ConfigFile.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMove Input Events and Gamepad from experimental features into main preferences
dino@apple.com [Sat, 4 Mar 2017 01:03:49 +0000 (01:03 +0000)]
Move Input Events and Gamepad from experimental features into main preferences
https://bugs.webkit.org/show_bug.cgi?id=169157
<rdar://problems/30845587>

Reviewed by Myles C. Maxfield.

These are no longer experimental on trunk.

* Shared/WebPreferencesDefinitions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd load / store exclusive instruction group to ARM64 disassembler
msaboff@apple.com [Sat, 4 Mar 2017 00:55:45 +0000 (00:55 +0000)]
Add load / store exclusive instruction group to ARM64 disassembler
https://bugs.webkit.org/show_bug.cgi?id=169152

Reviewed by Filip Pizlo.

* disassembler/ARM64/A64DOpcode.cpp:
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::format):
* disassembler/ARM64/A64DOpcode.h:
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::opName):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::rs):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::rt2):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o0):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o1):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o2):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::loadBit):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::opNumber):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::isPairOp):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd a script to synchronize FeatureDefines.xcconfig files
dino@apple.com [Sat, 4 Mar 2017 00:48:35 +0000 (00:48 +0000)]
Add a script to synchronize FeatureDefines.xcconfig files
https://bugs.webkit.org/show_bug.cgi?id=169151
<rdar://problem/30841856>

Reviewed by Simon Fraser.

I got sick of manually copying the FeatureDefines.xcconfig
files, so I added a script to do it. As long as you
run this after you've edited one, it will take the most
recently updated and copy it to all the others.

* Scripts/sync-feature-defines: Added.
* Scripts/webkitpy/style/checkers/featuredefines.py:
(FeatureDefinesChecker.check): Export the list of files,
and give a suggestion to use the sync script.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[MediaStream iOS] REGRESSION(r212883): Missing function definition breaks sandbox
bfulgham@apple.com [Sat, 4 Mar 2017 00:34:46 +0000 (00:34 +0000)]
[MediaStream iOS] REGRESSION(r212883): Missing function definition breaks sandbox
https://bugs.webkit.org/show_bug.cgi?id=169148
<rdar://problem/30825728>

Reviewed by Alex Christensen.

The changes in r212883 added a call to 'shared-preferences-read', which is not defined
for iOS. In fact, it's not needed since 'user-preference-read' does everything we need on iOS.
Switch to the correct preference rule.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add missing function

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS] Throttle SVG SMIL animations to 30fps in low power mode
cdumez@apple.com [Fri, 3 Mar 2017 23:54:48 +0000 (23:54 +0000)]
[iOS] Throttle SVG SMIL animations to 30fps in low power mode
https://bugs.webkit.org/show_bug.cgi?id=169137
<rdar://problem/30833754>

Reviewed by Simon Fraser.

Source/WebCore:

Throttle SVG SMIL animations to 30fps in low power mode on iOS to save
battery.

Test: svg/animations/animations-lowPowerMode-throttling.html

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
* svg/SVGSVGElement.idl:
* svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::animationFrameDelay):
(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
(WebCore::SMILTimeContainer::updateAnimations):
* svg/animation/SMILTimeContainer.h:
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateNextProgressTime):
* testing/Internals.cpp:
(WebCore::Internals::svgAnimationsInterval):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Add layout test coverage.

* svg/animations/animations-lowPowerMode-throttling-expected.txt: Added.
* svg/animations/animations-lowPowerMode-throttling.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac] WebCore.framework is missing a symlink from Frameworks to Versions/Current...
joepeck@webkit.org [Fri, 3 Mar 2017 23:03:18 +0000 (23:03 +0000)]
[Mac] WebCore.framework is missing a symlink from Frameworks to Versions/Current/Frameworks when the latter exists
https://bugs.webkit.org/show_bug.cgi?id=169067

Reviewed by Dan Bernstein.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove empty build directories.
achristensen@apple.com [Fri, 3 Mar 2017 22:38:11 +0000 (22:38 +0000)]
Remove empty build directories.

* build: Removed.
* build/Debug: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWASM should support faster loads.
keith_miller@apple.com [Fri, 3 Mar 2017 22:24:21 +0000 (22:24 +0000)]
WASM should support faster loads.
https://bugs.webkit.org/show_bug.cgi?id=162693

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch adds support for WebAssembly using a 32-bit address
space for memory (along with some extra space for offset
overflow). With a 32-bit address space (we call them
Signaling/fast memories), we reserve the virtual address space for
2^32 + offset bytes of memory and only mark the usable section as
read/write. If wasm code would read/write out of bounds we use a
custom signal handler to catch the SIGBUS. The signal handler then
checks if the faulting instruction is wasm code and tells the
thread to resume executing from the wasm exception
handler. Otherwise, the signal handler crashes the process, as
usual.

All of the allocations of these memories are managed by the
Wasm::Memory class. In order to avoid TLB churn in the OS we cache
old Signaling memories that are no longer in use. Since getting
the wrong memory can cause recompiles, we try to reserve a memory
for modules that do not import a memory. If a module does import a
memory, we try to guess the type of memory we are going to get
based on the last one allocated.

This patch also changes how the wasm JS-api manages objects. Since
we can compile different versions of code, this patch adds a new
JSWebAssemblyCodeBlock class that holds all the information
specific to running a module in a particular bounds checking
mode. Additionally, the Wasm::Memory object is now a reference
counted class that is shared between the JSWebAssemblyMemory
object and the ArrayBuffer that also views it.

* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITThunks.cpp:
(JSC::JITThunks::existingCTIStub):
* jit/JITThunks.h:
* jsc.cpp:
(jscmain):
* runtime/Options.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
* wasm/JSWebAssemblyCodeBlock.h: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h.
(JSC::JSWebAssemblyCodeBlock::create):
(JSC::JSWebAssemblyCodeBlock::createStructure):
(JSC::JSWebAssemblyCodeBlock::functionImportCount):
(JSC::JSWebAssemblyCodeBlock::mode):
(JSC::JSWebAssemblyCodeBlock::module):
(JSC::JSWebAssemblyCodeBlock::jsEntrypointCalleeFromFunctionIndexSpace):
(JSC::JSWebAssemblyCodeBlock::wasmEntrypointCalleeFromFunctionIndexSpace):
(JSC::JSWebAssemblyCodeBlock::setJSEntrypointCallee):
(JSC::JSWebAssemblyCodeBlock::setWasmEntrypointCallee):
(JSC::JSWebAssemblyCodeBlock::callees):
(JSC::JSWebAssemblyCodeBlock::offsetOfCallees):
(JSC::JSWebAssemblyCodeBlock::allocationSize):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::getMemoryBaseAndSize):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::emitLoadOp):
(JSC::Wasm::B3IRGenerator::emitStoreOp):
* wasm/WasmCallingConvention.h:
* wasm/WasmFaultSignalHandler.cpp: Added.
(JSC::Wasm::trapHandler):
(JSC::Wasm::registerCode):
(JSC::Wasm::unregisterCode):
(JSC::Wasm::fastMemoryEnabled):
(JSC::Wasm::enableFastMemory):
* wasm/WasmFaultSignalHandler.h: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyCallee.cpp.
* wasm/WasmFormat.h:
(JSC::Wasm::ModuleInformation::importFunctionCount):
(JSC::Wasm::ModuleInformation::hasMemory): Deleted.
* wasm/WasmMemory.cpp:
(JSC::Wasm::mmapBytes):
(JSC::Wasm::Memory::lastAllocatedMode):
(JSC::Wasm::availableFastMemories):
(JSC::Wasm::tryGetFastMemory):
(JSC::Wasm::releaseFastMemory):
(JSC::Wasm::Memory::Memory):
(JSC::Wasm::Memory::createImpl):
(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::~Memory):
(JSC::Wasm::Memory::grow):
(JSC::Wasm::Memory::dump):
(JSC::Wasm::Memory::makeString):
* wasm/WasmMemory.h:
(JSC::Wasm::Memory::operator bool):
(JSC::Wasm::Memory::size):
(JSC::Wasm::Memory::check):
(JSC::Wasm::Memory::Memory): Deleted.
(JSC::Wasm::Memory::offsetOfMemory): Deleted.
(JSC::Wasm::Memory::offsetOfSize): Deleted.
* wasm/WasmMemoryInformation.cpp:
(JSC::Wasm::MemoryInformation::MemoryInformation):
* wasm/WasmMemoryInformation.h:
(JSC::Wasm::MemoryInformation::hasReservedMemory):
(JSC::Wasm::MemoryInformation::takeReservedMemory):
(JSC::Wasm::MemoryInformation::mode):
* wasm/WasmModuleParser.cpp:
* wasm/WasmModuleParser.h:
(JSC::Wasm::ModuleParser::ModuleParser):
* wasm/WasmPlan.cpp:
(JSC::Wasm::Plan::parseAndValidateModule):
(JSC::Wasm::Plan::run):
* wasm/WasmPlan.h:
(JSC::Wasm::Plan::mode):
* wasm/js/JSWebAssemblyCallee.cpp:
(JSC::JSWebAssemblyCallee::finishCreation):
(JSC::JSWebAssemblyCallee::destroy):
* wasm/js/JSWebAssemblyCodeBlock.cpp: Added.
(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):
(JSC::JSWebAssemblyCodeBlock::destroy):
(JSC::JSWebAssemblyCodeBlock::isSafeToRun):
(JSC::JSWebAssemblyCodeBlock::visitChildren):
(JSC::JSWebAssemblyCodeBlock::UnconditionalFinalizer::finalizeUnconditionally):
* wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::setMemory):
(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):
* wasm/js/JSWebAssemblyInstance.h:
(JSC::JSWebAssemblyInstance::module):
(JSC::JSWebAssemblyInstance::codeBlock):
(JSC::JSWebAssemblyInstance::memoryMode):
(JSC::JSWebAssemblyInstance::setMemory): Deleted.
* wasm/js/JSWebAssemblyMemory.cpp:
(JSC::JSWebAssemblyMemory::create):
(JSC::JSWebAssemblyMemory::JSWebAssemblyMemory):
(JSC::JSWebAssemblyMemory::buffer):
(JSC::JSWebAssemblyMemory::grow):
(JSC::JSWebAssemblyMemory::destroy):
* wasm/js/JSWebAssemblyMemory.h:
(JSC::JSWebAssemblyMemory::memory):
(JSC::JSWebAssemblyMemory::offsetOfMemory):
(JSC::JSWebAssemblyMemory::offsetOfSize):
* wasm/js/JSWebAssemblyModule.cpp:
(JSC::JSWebAssemblyModule::buildCodeBlock):
(JSC::JSWebAssemblyModule::create):
(JSC::JSWebAssemblyModule::JSWebAssemblyModule):
(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::finishCreation):
(JSC::JSWebAssemblyModule::visitChildren):
(JSC::JSWebAssemblyModule::UnconditionalFinalizer::finalizeUnconditionally): Deleted.
* wasm/js/JSWebAssemblyModule.h:
(JSC::JSWebAssemblyModule::takeReservedMemory):
(JSC::JSWebAssemblyModule::signatureIndexFromFunctionIndexSpace):
(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::functionImportCount): Deleted.
(JSC::JSWebAssemblyModule::jsEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyModule::wasmEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyModule::setJSEntrypointCallee): Deleted.
(JSC::JSWebAssemblyModule::setWasmEntrypointCallee): Deleted.
(JSC::JSWebAssemblyModule::callees): Deleted.
(JSC::JSWebAssemblyModule::offsetOfCallees): Deleted.
(JSC::JSWebAssemblyModule::allocationSize): Deleted.
* wasm/js/WebAssemblyFunction.cpp:
(JSC::callWebAssemblyFunction):
* wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
* wasm/js/WebAssemblyMemoryConstructor.cpp:
(JSC::constructJSWebAssemblyMemory):
* wasm/js/WebAssemblyModuleConstructor.cpp:
(JSC::WebAssemblyModuleConstructor::createModule):
* wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):

Source/WTF:

Add new forms of dataLog that take a boolean which describes if the log should happen. This makes cases where we have a static const bool for printing nicer since you can do:

dataLogIf(verbose, things, to, print);

instead of:

if (verbose)
    dataLog(things, to, print);

Also, add a operator! to Ref that has the same semantics as C++ refs.

* wtf/DataLog.h:
(WTF::dataLogLn):
(WTF::dataLogIf):
(WTF::dataLogLnIf):
* wtf/Ref.h:
(WTF::Ref::operator!):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION (r209760): Apple Pay doesn't work on casper.com, shopspring.com, maybe...
weinig@apple.com [Fri, 3 Mar 2017 22:19:06 +0000 (22:19 +0000)]
REGRESSION (r209760): Apple Pay doesn't work on casper.com, shopspring.com, maybe other sites
<rdar://problem/30313445>
https://bugs.webkit.org/show_bug.cgi?id=169149

Reviewed by Simon Fraser.

Source/WebCore:

Relax restriction that the ApplePayShippingMethod sequence must not be empty. This
was incorrect.

* Modules/applepay/ApplePaySession.cpp:
(WebCore::convertAndValidate):

LayoutTests:

* http/tests/ssl/applepay/ApplePaySession-expected.txt:
* http/tests/ssl/applepay/ApplePaySession.html:
Update test for relaxed ApplePayShippingMethod sequence requirements.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[URLParser] Fix file: as a relative file URL
achristensen@apple.com [Fri, 3 Mar 2017 21:50:07 +0000 (21:50 +0000)]
[URLParser] Fix file: as a relative file URL
https://bugs.webkit.org/show_bug.cgi?id=169122

Reviewed by Tim Horton.

Source/WebCore:

This is clearly defined in https://url.spec.whatwg.org/#file-state with the EOF code point.
I got it wrong and didn't test it.  It's been added to the web platform tests since we last updated.

* platform/URLParser.cpp:
(WebCore::URLParser::parse):

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

LayoutTests:

* TestExpectations:
We don't need to skip url-setters.html any more.  It used to assert before the new URLParser was enabled.
* fast/loader/url-parse-1-expected.txt:
* fast/url/file-expected.txt:
We used to add a strange and unnecessary :/// at the end of the URL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMove declaration of _WKSetCrashReportApplicationSpecificInformation to header file
aakash_jain@apple.com [Fri, 3 Mar 2017 21:38:39 +0000 (21:38 +0000)]
Move declaration of _WKSetCrashReportApplicationSpecificInformation to header file
https://bugs.webkit.org/show_bug.cgi?id=169043

Reviewed by Alex Christensen.

* WebKit2.xcodeproj/project.pbxproj: Added WebProcessCocoa.h
* WebProcess/cocoa/WebProcessCocoa.h: Added.
* WebProcess/cocoa/WebProcessCocoa.mm: Imported WebProcessCocoa.h
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd Debug flag to TestExpectation for webrtc/audio-peer-connection-webaudio.html.
ryanhaddad@apple.com [Fri, 3 Mar 2017 21:37:51 +0000 (21:37 +0000)]
Add Debug flag to TestExpectation for webrtc/audio-peer-connection-webaudio.html.

Unreviewed test gardening.

* TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoGardening: fix broken ARM64 build.
mark.lam@apple.com [Fri, 3 Mar 2017 21:37:11 +0000 (21:37 +0000)]
Gardening: fix broken ARM64 build.
https://bugs.webkit.org/show_bug.cgi?id=169139

Not reviewed.

* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::excepnGenerationImmMask):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark performance-api/performance-observer-periodic.html as flaky.
ryanhaddad@apple.com [Fri, 3 Mar 2017 21:29:02 +0000 (21:29 +0000)]
Mark performance-api/performance-observer-periodic.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168136

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEnable fieldsets to be flexboxes, grids and multicolumn.
hyatt@apple.com [Fri, 3 Mar 2017 21:16:46 +0000 (21:16 +0000)]
Enable fieldsets to be flexboxes, grids and multicolumn.
https://bugs.webkit.org/show_bug.cgi?id=169082

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
Remove RenderFieldset from the project.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::createElementRenderer):
* html/HTMLFieldSetElement.h:
The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

* rendering/OrderIterator.cpp:
(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):
* rendering/OrderIterator.h:
Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):
* rendering/RenderBlock.h:
This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

* rendering/RenderBlockFlow.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

* rendering/RenderBox.h:
(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
* rendering/RenderElement.h:
Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

* rendering/RenderFieldset.cpp: Removed.
* rendering/RenderFieldset.h: Removed.
Remove RenderFieldset files from the tree.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

* rendering/RenderObject.h:
(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.
* rendering/RenderRubyRun.h:
Rename layoutSpecialExcludedChild to layoutExcludedChildren.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.
* rendering/RenderTable.h:
Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.
* rendering/RenderTextControlMultiLine.h:
Renamed the methods for doing the excluded child layout.

* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

* fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
* fast/forms/fieldset/abs-pos-child-sizing.html: Added.
* fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
* fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
* fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
* fast/forms/fieldset/fieldset-flexbox.html: Added.
* fast/forms/fieldset/fieldset-grid-expected.html: Added.
* fast/forms/fieldset/fieldset-grid.html: Added.
* fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
* fast/forms/fieldset/fieldset-multicolumn.html: Added.
* fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
* fast/forms/fieldset/fieldset-overflow-auto.html: Added.
* fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
* fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
* fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
* fast/forms/fieldset/fieldset-positioned-children.html: Added.
* fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
* fast/forms/fieldset/fieldset-positioned-legend.html: Added.
* fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
* fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
* fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
* fast/forms/fieldset/fieldset-writing-modes.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r213344.
ryanhaddad@apple.com [Fri, 3 Mar 2017 21:15:28 +0000 (21:15 +0000)]
Unreviewed, rolling out r213344.

This changed caused LayoutTest crashes under GuardMalloc.

Reverted changeset:

"Add support for canvas.toBlob"
https://bugs.webkit.org/show_bug.cgi?id=148878
http://trac.webkit.org/changeset/213344

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm as flaky on...
ryanhaddad@apple.com [Fri, 3 Mar 2017 21:14:03 +0000 (21:14 +0000)]
Mark imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm as flaky on El Capitan Release builds.
https://bugs.webkit.org/show_bug.cgi?id=164870

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd MacroAssembler::isBreakpoint() query function.
mark.lam@apple.com [Fri, 3 Mar 2017 21:05:55 +0000 (21:05 +0000)]
Add MacroAssembler::isBreakpoint() query function.
https://bugs.webkit.org/show_bug.cgi?id=169139

Reviewed by Michael Saboff.

This will be needed soon when we use breakpoint instructions to implement
non-polling VM traps, and need to discern between a VM trap signal and a genuine
assertion breakpoint.

* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::isBrk):
(JSC::ARM64Assembler::excepnGenerationImmMask):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::isBkpt):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::isBkpt):
* assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::isBkpt):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::isBreakpoint):
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::isBreakpoint):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::isBreakpoint):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::isBreakpoint):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::isBreakpoint):
* assembler/X86Assembler.h:
(JSC::X86Assembler::isInt3):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed typo fix
annulen@yandex.ru [Fri, 3 Mar 2017 19:38:37 +0000 (19:38 +0000)]
Unreviewed typo fix

* features.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild fix
ap@apple.com [Fri, 3 Mar 2017 18:59:51 +0000 (18:59 +0000)]
Build fix
rdar://problem/30825660

Suggested by Dan Bernstein.

* Configurations/WebKitLegacy.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[MediaStream] Remove #if USE(VIDEOTOOLBOX) from AVVideoCaptureSource
eric.carlson@apple.com [Fri, 3 Mar 2017 18:20:08 +0000 (18:20 +0000)]
[MediaStream] Remove #if USE(VIDEOTOOLBOX) from AVVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=169131

Reviewed by Youenn Fablet.

* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::currentFrameCGImage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd assertion in Frame::setView() to make sure associated document has no living...
cdumez@apple.com [Fri, 3 Mar 2017 17:51:23 +0000 (17:51 +0000)]
Add assertion in Frame::setView() to make sure associated document has no living render tree
https://bugs.webkit.org/show_bug.cgi?id=169134

Reviewed by Brent Fulgham.

Add assertion in Frame::setView() to make sure associated document has no living render tree.
This is not supposed to happen and r213311 fixed one case where this could happen. We need
to find out if it can still happen.

* page/Frame.cpp:
(WebCore::Frame::setView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWe should only check for traps that we're able to handle.
mark.lam@apple.com [Fri, 3 Mar 2017 17:48:42 +0000 (17:48 +0000)]
We should only check for traps that we're able to handle.
https://bugs.webkit.org/show_bug.cgi?id=169136

Reviewed by Michael Saboff.

The execute methods in interpreter were checking for the existence of any traps
(without masking) and only handling a subset of those via a mask.  This can
result in a failed assertion on debug builds.

This patch fixes this by applying the same mask for both the needTrapHandling()
check and the handleTraps() call.  Also added a few assertions.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):
* jit/JITOperations.cpp:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Ensure WebKitWebView always have a user content manager
commit-queue@webkit.org [Fri, 3 Mar 2017 17:24:13 +0000 (17:24 +0000)]
[GTK] Ensure WebKitWebView always have a user content manager
https://bugs.webkit.org/show_bug.cgi?id=169130

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-03-03
Reviewed by Michael Catanzaro.

User content manager is a construct only property, so if not set by the user the web view doesn't have any. We
can create a default one, like we do for settings, when user didn't provide one.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Unreviewed test gardening
jfernandez@igalia.com [Fri, 3 Mar 2017 14:16:10 +0000 (14:16 +0000)]
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169127

Unreviewed GTK+ gardening. Removed duplicated TestExpectations entry.

* platform/gtk/TestExpectations:
- editing/selection/extend-by-character-007.html fails in GTK as well, so using the general TestExpectations entry.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after...
commit-queue@webkit.org [Fri, 3 Mar 2017 13:07:45 +0000 (13:07 +0000)]
LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=167275
<rdar://problem/30824290>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-03
Reviewed by Dean Jackson.

Ensure that we have metrics for buttons before attempting to click on them and let dragging interaction
apply changes to CSS on the next rAF before trying to pursue the next step.

* media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
* media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, minor updates on CSS Grid Layout examples.
rego@igalia.com [Fri, 3 Mar 2017 13:02:49 +0000 (13:02 +0000)]
Unreviewed, minor updates on CSS Grid Layout examples.

* demos/css-grid/index.html:
* demos/css-grid/responsive-grid.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayoutTest performance-api/performance-observer-basic.html is a flaky timeout
commit-queue@webkit.org [Fri, 3 Mar 2017 11:38:58 +0000 (11:38 +0000)]
LayoutTest performance-api/performance-observer-basic.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=169097

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-03
Reviewed by Ryosuke Niwa.

* performance-api/performance-now-api.html:
* performance-api/performance-observer-basic.html:
Reorder the scripts so that testWorker is guarenteed
to be defined before code that uses it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Another reftest failing with 2 pixels in image diff.
carlosgc@webkit.org [Fri, 3 Mar 2017 10:06:59 +0000 (10:06 +0000)]
Unreviewed GTK+ gardening. Another reftest failing with 2 pixels in image diff.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Mark RAF throttling tests as failing.
carlosgc@webkit.org [Fri, 3 Mar 2017 09:58:57 +0000 (09:58 +0000)]
Unreviewed GTK+ gardening. Mark RAF throttling tests as failing.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Rebaseline fast/dom/HTMLAnchorElement/anchor-file-blob...
carlosgc@webkit.org [Fri, 3 Mar 2017 09:52:20 +0000 (09:52 +0000)]
Unreviewed GTK+ gardening. Rebaseline fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html after r213284.

* platform/gtk/fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Skip tests that require FILE_REPLACEMENT.
carlosgc@webkit.org [Fri, 3 Mar 2017 09:44:54 +0000 (09:44 +0000)]
Unreviewed GTK+ gardening. Skip tests that require FILE_REPLACEMENT.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Mark several WebCryptoAPI tests as failing.
carlosgc@webkit.org [Fri, 3 Mar 2017 08:32:26 +0000 (08:32 +0000)]
Unreviewed GTK+ gardening. Mark several WebCryptoAPI tests as failing.

* platform/gtk/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
commit-queue@webkit.org [Fri, 3 Mar 2017 06:49:54 +0000 (06:49 +0000)]
Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
https://bugs.webkit.org/show_bug.cgi?id=169074

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-03-02
Reviewed by Joseph Pecoraro.

They are not actually cocoa specific.

* inspector/remote/RemoteInspector.cpp:
(Inspector::RemoteInspector::updateTargetListing):
* inspector/remote/RemoteInspector.h:
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename htmlediting.h/cpp to Editing.h/cpp
commit-queue@webkit.org [Fri, 3 Mar 2017 06:35:25 +0000 (06:35 +0000)]
Rename htmlediting.h/cpp to Editing.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=169103

Patch by Sam Weinig <sam@webkit.org> on 2017-03-02
Reviewed by Alex Christensen.

Source/WebCore:

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AXObjectCache.cpp:
* accessibility/AccessibilityNodeObject.cpp:
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/atk/WebKitAccessibleHyperlink.cpp:
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* dom/Document.cpp:
* dom/Element.cpp:
* dom/Node.h:
* dom/Position.cpp:
* dom/PositionIterator.cpp:
* dom/Range.cpp:
* editing/AlternativeTextController.cpp:
* editing/AppendNodeCommand.cpp:
* editing/ApplyBlockElementCommand.cpp:
* editing/ApplyStyleCommand.cpp:
* editing/BreakBlockquoteCommand.cpp:
* editing/CompositeEditCommand.cpp:
* editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::CreateLinkCommand):
* editing/DeleteFromTextNodeCommand.cpp:
* editing/DeleteSelectionCommand.cpp:
* editing/EditCommand.cpp:
* editing/Editing.cpp: Copied from Source/WebCore/editing/htmlediting.cpp.
* editing/Editing.h: Copied from Source/WebCore/editing/htmlediting.h.
* editing/EditingAllInOne.cpp:
* editing/EditingStyle.cpp:
* editing/Editor.cpp:
* editing/EditorCommand.cpp:
* editing/FormatBlockCommand.cpp:
* editing/FrameSelection.cpp:
* editing/HTMLInterchange.cpp:
* editing/IndentOutdentCommand.cpp:
* editing/InsertLineBreakCommand.cpp:
* editing/InsertListCommand.cpp:
* editing/InsertNodeBeforeCommand.cpp:
* editing/InsertParagraphSeparatorCommand.cpp:
* editing/InsertTextCommand.cpp:
* editing/ModifySelectionListLevel.cpp:
* editing/RemoveNodeCommand.cpp:
* editing/ReplaceNodeWithSpanCommand.cpp:
* editing/ReplaceSelectionCommand.cpp:
* editing/SpellChecker.cpp:
* editing/TextIterator.cpp:
* editing/TypingCommand.cpp:
* editing/VisiblePosition.cpp:
* editing/VisibleSelection.cpp:
* editing/VisibleUnits.cpp:
* editing/cocoa/DataDetection.mm:
* editing/cocoa/EditorCocoa.mm:
* editing/htmlediting.cpp: Removed.
* editing/htmlediting.h: Removed.
* editing/ios/EditorIOS.mm:
* editing/mac/DictionaryLookup.mm:
* editing/mac/EditorMac.mm:
* editing/markup.cpp:
* html/HTMLTextFormControlElement.cpp:
* inspector/InspectorDOMAgent.cpp:
* page/DOMSelection.cpp:
* page/DragController.cpp:
* page/EventHandler.cpp:
* page/FocusController.cpp:
* page/Frame.cpp:
* platform/ios/PasteboardIOS.mm:
* platform/mac/PasteboardMac.mm:
* rendering/RenderBox.cpp:
* rendering/RenderObject.cpp:

Source/WebKit/ios:

* WebCoreSupport/WebFrameIOS.mm:
* WebCoreSupport/WebVisiblePosition.mm:

Source/WebKit/mac:

* DOM/DOMUIKitExtensions.mm:
* WebView/WebFrame.mm:
* WebView/WebView.mm:

Source/WebKit/win:

* AccessibleTextImpl.cpp:

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/ios/WebPageIOS.mm:
* WebProcess/WebPage/mac/WebPageMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac] Set the NSURLSessionTask priority to match the request's priority
commit-queue@webkit.org [Fri, 3 Mar 2017 06:10:27 +0000 (06:10 +0000)]
[Mac] Set the NSURLSessionTask priority to match the request's priority
https://bugs.webkit.org/show_bug.cgi?id=169115
<rdar://problem/28881392>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-02
Reviewed by Alex Christensen.

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::toNSURLSessionTaskPriority):
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
Set the priority on the task based on the ResourceRequest's priority.
This is used for HTTP/2 request prioritization.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Should be able to push nodes in an iframe subtree to the frontend
mattbaker@apple.com [Fri, 3 Mar 2017 05:53:34 +0000 (05:53 +0000)]
Web Inspector: Should be able to push nodes in an iframe subtree to the frontend
https://bugs.webkit.org/show_bug.cgi?id=169086

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/dom/push-node-by-path-to-frontend.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeForPath):
During top-down document traversal, descend into content document nodes
when visiting an HTMLFrameOwnerElement.

Source/WebInspectorUI:

* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype._selectedNodeDidChange):
Use the URL of the main frame instead of the content frame URL.

LayoutTests:

Added test coverage for DOMTreeManager.prototype.pushNodeByPathToFrontend,
which now supports pushing iframe document nodes (#document) and their descendants.

* inspector/dom/push-node-by-path-to-frontend-expected.txt: Added.
* inspector/dom/push-node-by-path-to-frontend.html: Added.
* inspector/dom/resources/frameset-frame.html: Added.
* inspector/dom/resources/frameset-iframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoVersioning.
jmarcell@apple.com [Fri, 3 Mar 2017 05:40:00 +0000 (05:40 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track...
commit-queue@webkit.org [Fri, 3 Mar 2017 05:33:00 +0000 (05:33 +0000)]
LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=169109
<rdar://problem/30824252>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-02
Reviewed by Simon Fraser.

Ensure the tracks button is sized before pressing it to make the track panel appear.

* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r213274.
ryanhaddad@apple.com [Fri, 3 Mar 2017 05:22:28 +0000 (05:22 +0000)]
Unreviewed, rolling out r213274.

This change caused flakiness with LayoutTest memory/memory-
pressure-simulation.html

Reverted changeset:

"Don't keep dead resources in MemoryCache while under memory
pressure."
https://bugs.webkit.org/show_bug.cgi?id=169070
http://trac.webkit.org/changeset/213274

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove references to tests that no longer exist and remove a duplicate test.
graouts@webkit.org [Fri, 3 Mar 2017 05:21:51 +0000 (05:21 +0000)]
Remove references to tests that no longer exist and remove a duplicate test.

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support...
commit-queue@webkit.org [Fri, 3 Mar 2017 04:47:31 +0000 (04:47 +0000)]
[ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168668
<rdar://problem/30823677>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-02
Reviewed by Simon Fraser.

This test would sometime fail for the first assertion because we may need more than just metadata
to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
fullscreen button and then force it to error to disable it.

* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
* platform/ios-simulator/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-contr...
commit-queue@webkit.org [Fri, 3 Mar 2017 04:27:42 +0000 (04:27 +0000)]
[iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168343
<rdar://problem/30823389>

Patch by Antoine Quint <graouts@apple.com> on 2017-03-02
Reviewed by Simon Fraser.

Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.

* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
* platform/ios-simulator/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebCrypto API support for AES-GCM
jiewen_tan@apple.com [Fri, 3 Mar 2017 04:24:14 +0000 (04:24 +0000)]
WebCrypto API support for AES-GCM
https://bugs.webkit.org/show_bug.cgi?id=157175
<rdar://problem/27311691>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

* web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker-expected.txt:
* web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt:
* web-platform-tests/WebCryptoAPI/generateKey/failures_AES-GCM.worker-expected.txt:
* web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.worker-expected.txt:
* web-platform-tests/WebCryptoAPI/generateKey/test_failures_AES-GCM-expected.txt:
* web-platform-tests/WebCryptoAPI/generateKey/test_successes_AES-GCM-expected.txt:
* web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker-expected.txt:
* web-platform-tests/WebCryptoAPI/import_export/test_symmetric_importKey-expected.txt:

Source/WebCore:

This patch adds support for AES-GCM. Operations of AES-GCM include: encrypt, decrypt, generateKey,
importKey, exportKey, wrapKey, and unwrapKey. https://www.w3.org/TR/WebCryptoAPI/#aes-gcm

Tests: crypto/subtle/aes-gcm-decrypt-malformed-parameters.html
       crypto/subtle/aes-gcm-encrypt-malformed-parameters.html
       crypto/subtle/aes-gcm-generate-export-key-jwk-length-128.html
       crypto/subtle/aes-gcm-generate-export-key-jwk-length-192.html
       crypto/subtle/aes-gcm-generate-export-key-jwk-length-256.html
       crypto/subtle/aes-gcm-generate-export-raw-key.html
       crypto/subtle/aes-gcm-generate-key-encrypt-decrypt.html
       crypto/subtle/aes-gcm-generate-key.html
       crypto/subtle/aes-gcm-import-jwk-key-length-128.html
       crypto/subtle/aes-gcm-import-jwk-key-length-192.html
       crypto/subtle/aes-gcm-import-jwk-key-length-256.html
       crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32.html
       crypto/subtle/aes-gcm-import-key-decrypt-additional-data.html
       crypto/subtle/aes-gcm-import-key-decrypt-tagLengths.html
       crypto/subtle/aes-gcm-import-key-decrypt.html
       crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32.html
       crypto/subtle/aes-gcm-import-key-encrypt-additional-data.html
       crypto/subtle/aes-gcm-import-key-encrypt-tagLengths.html
       crypto/subtle/aes-gcm-import-key-encrypt.html
       crypto/subtle/aes-gcm-import-key-unwrap-jwk-key.html
       crypto/subtle/aes-gcm-import-key-unwrap-raw-key.html
       crypto/subtle/aes-gcm-import-key-wrap-jwk-key.html
       crypto/subtle/aes-gcm-import-key-wrap-raw-key.html
       crypto/subtle/aes-gcm-import-raw-key.html
       crypto/workers/subtle/aes-gcm-import-key-decrypt.html
       crypto/workers/subtle/aes-gcm-import-key-encrypt.html
       crypto/workers/subtle/aes-gcm-import-key-unwrap-key.html
       crypto/workers/subtle/aes-gcm-import-key-wrap-key.html

* CMakeLists.txt:
* DerivedSources.make:
* PlatformGTK.cmake:
* PlatformMac.cmake:
Add CryptoAlgorithmAES_CFBMac.cpp as well.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::normalizeCryptoAlgorithmParameters):
Add support for AES-GCM.
* crypto/CommonCryptoUtilities.h:
Include SPI header for AES-GCM support. We have a mismatch SPI between different OS version.
Therefore, a guardian is placed.
* crypto/CryptoAlgorithmParameters.h:
* crypto/algorithms/CryptoAlgorithmAES_GCM.cpp: Added.
(WebCore::usagesAreInvalidForCryptoAlgorithmAES_GCM):
(WebCore::tagLengthIsValid):
(WebCore::CryptoAlgorithmAES_GCM::create):
(WebCore::CryptoAlgorithmAES_GCM::identifier):
(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
(WebCore::CryptoAlgorithmAES_GCM::generateKey):
(WebCore::CryptoAlgorithmAES_GCM::importKey):
(WebCore::CryptoAlgorithmAES_GCM::exportKey):
* crypto/algorithms/CryptoAlgorithmAES_GCM.h: Added.
* crypto/gnutls/CryptoAlgorithmAES_GCMGnuTLS.cpp: Added.
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
* crypto/mac/CryptoAlgorithmAES_GCMMac.cpp: Added.
(WebCore::encryptAES_GCM):
(WebCore::decyptAES_GCM):
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
* crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* crypto/parameters/AesGcmParams.idl: Added.
* crypto/parameters/CryptoAlgorithmAesGcmParams.h: Added.

LayoutTests:

This patch also adds some tests for AES-CFB.

* crypto/subtle/aes-export-key-malformed-parameters-expected.txt:
* crypto/subtle/aes-export-key-malformed-parameters.html:
* crypto/subtle/aes-gcm-decrypt-malformed-parameters-expected.txt: Added.
* crypto/subtle/aes-gcm-decrypt-malformed-parameters.html: Added.
* crypto/subtle/aes-gcm-encrypt-malformed-parameters-expected.txt: Added.
* crypto/subtle/aes-gcm-encrypt-malformed-parameters.html: Added.
* crypto/subtle/aes-gcm-generate-export-key-jwk-length-128-expected.txt: Added.
* crypto/subtle/aes-gcm-generate-export-key-jwk-length-128.html: Added.
* crypto/subtle/aes-gcm-generate-export-key-jwk-length-192-expected.txt: Added.
* crypto/subtle/aes-gcm-generate-export-key-jwk-length-192.html: Added.
* crypto/subtle/aes-gcm-generate-export-key-jwk-length-256-expected.txt: Added.
* crypto/subtle/aes-gcm-generate-export-key-jwk-length-256.html: Added.
* crypto/subtle/aes-gcm-generate-export-raw-key-expected.txt: Added.
* crypto/subtle/aes-gcm-generate-export-raw-key.html: Added.
* crypto/subtle/aes-gcm-generate-key-encrypt-decrypt-expected.txt: Added.
* crypto/subtle/aes-gcm-generate-key-encrypt-decrypt.html: Added.
* crypto/subtle/aes-gcm-generate-key-expected.txt: Added.
* crypto/subtle/aes-gcm-generate-key.html: Added.
* crypto/subtle/aes-gcm-import-jwk-key-length-128-expected.txt: Added.
* crypto/subtle/aes-gcm-import-jwk-key-length-128.html: Added.
* crypto/subtle/aes-gcm-import-jwk-key-length-192-expected.txt: Added.
* crypto/subtle/aes-gcm-import-jwk-key-length-192.html: Added.
* crypto/subtle/aes-gcm-import-jwk-key-length-256-expected.txt: Added.
* crypto/subtle/aes-gcm-import-jwk-key-length-256.html: Added.
* crypto/subtle/aes-gcm-import-key-decrypt-additional-data-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-decrypt-additional-data-tag-length-32.html: Added.
* crypto/subtle/aes-gcm-import-key-decrypt-additional-data.html: Added.
* crypto/subtle/aes-gcm-import-key-decrypt-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-decrypt-tagLengths-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-decrypt-tagLengths.html: Added.
* crypto/subtle/aes-gcm-import-key-decrypt.html: Added.
* crypto/subtle/aes-gcm-import-key-encrypt-additional-data-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-encrypt-additional-data-tag-length-32.html: Added.
* crypto/subtle/aes-gcm-import-key-encrypt-additional-data.html: Added.
* crypto/subtle/aes-gcm-import-key-encrypt-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-encrypt-tagLengths-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-encrypt-tagLengths.html: Added.
* crypto/subtle/aes-gcm-import-key-encrypt.html: Added.
* crypto/subtle/aes-gcm-import-key-unwrap-jwk-key-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-unwrap-jwk-key.html: Added.
* crypto/subtle/aes-gcm-import-key-unwrap-raw-key-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-unwrap-raw-key.html: Added.
* crypto/subtle/aes-gcm-import-key-wrap-jwk-key-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-wrap-jwk-key.html: Added.
* crypto/subtle/aes-gcm-import-key-wrap-raw-key-expected.txt: Added.
* crypto/subtle/aes-gcm-import-key-wrap-raw-key.html: Added.
* crypto/subtle/aes-gcm-import-raw-key-expected.txt: Added.
* crypto/subtle/aes-gcm-import-raw-key.html: Added.
* crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
* crypto/subtle/aes-generate-key-malformed-parameters.html:
* crypto/subtle/aes-import-key-malformed-parameters-expected.txt:
* crypto/subtle/aes-import-key-malformed-parameters.html:
* crypto/workers/subtle/aes-gcm-import-key-decrypt-expected.txt: Added.
* crypto/workers/subtle/aes-gcm-import-key-decrypt.html: Added.
* crypto/workers/subtle/aes-gcm-import-key-encrypt-expected.txt: Added.
* crypto/workers/subtle/aes-gcm-import-key-encrypt.html: Added.
* crypto/workers/subtle/aes-gcm-import-key-unwrap-key-expected.txt: Added.
* crypto/workers/subtle/aes-gcm-import-key-unwrap-key.html: Added.
* crypto/workers/subtle/aes-gcm-import-key-wrap-key-expected.txt: Added.
* crypto/workers/subtle/aes-gcm-import-key-wrap-key.html: Added.
* crypto/workers/subtle/resources/aes-gcm-import-key-decrypt.js: Added.
* crypto/workers/subtle/resources/aes-gcm-import-key-encrypt.js: Added.
* crypto/workers/subtle/resources/aes-gcm-import-key-unwrap-key.js: Added.
* crypto/workers/subtle/resources/aes-gcm-import-key-wrap-key.js: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd support for canvas.toBlob
aestes@apple.com [Fri, 3 Mar 2017 04:12:15 +0000 (04:12 +0000)]
Add support for canvas.toBlob
https://bugs.webkit.org/show_bug.cgi?id=148878
<rdar://problem/22590406>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:

Source/WebCore:

These tests now pass:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/BlobCallback.cpp: Added.
(WebCore::BlobCallback::scheduleCallback):
* fileapi/BlobCallback.h: Added.
(WebCore::BlobCallback::~BlobCallback):
* fileapi/BlobCallback.idl: Added.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toBlob):
* html/HTMLCanvasElement.h:
* html/HTMLCanvasElement.idl:
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::data):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
(WebCore::ImageBuffer::toCGImage):
(WebCore::cgImage):
(WebCore::dataURL):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
* platform/graphics/win/ImageBufferDirect2D.cpp:
(WebCore::ImageBuffer::toData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@213344 268f45cc-cd09-0410-ab3c-d52691b4dbfc