WebKit.git
10 years ago2011-02-24 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 24 Feb 2011 22:38:09 +0000 (22:38 +0000)]
2011-02-24  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79598.
        http://trac.webkit.org/changeset/79598
        https://bugs.webkit.org/show_bug.cgi?id=55089

        Appears to be causing trouble with httpd on windows

        * http/tests/media/media-file.js: Renamed from LayoutTests/media/media-file.js.
        ():
        (mimeTypeForExtension):
        (setSrcByTagName):
        (setSrcById):
        (stripExtension):
        * http/tests/media/pdf-served-as-pdf.html:
        * http/tests/media/reload-after-dialog.html:
        * http/tests/media/remove-while-loading.html:
        * http/tests/media/text-served-as-text.html:
        * http/tests/media/video-buffered.html:
        * http/tests/media/video-cancel-load.html:
        * http/tests/media/video-cookie.html:
        * http/tests/media/video-error-abort.html:
        * http/tests/media/video-load-twice.html:
        * http/tests/media/video-play-stall-seek.html:
        * http/tests/media/video-play-stall.html:
        * http/tests/media/video-play-suspend.html:
        * http/tests/media/video-referer.html:
        * http/tests/media/video-seekable-stall.html:
        * http/tests/media/video-served-as-text.html:
        * http/tests/media/video-test.js: Renamed from LayoutTests/media/video-test.js.
        (disableFullTestDetailsPrinting):
        (enableFullTestDetailsPrinting):
        (logConsole):
        (findMediaElement):
        (testAndEnd):
        (test):
        (testExpected):
        (reportExpected):
        (runSilently):
        (run):
        (waitForEventAndEnd):
        (waitForEvent._eventCallback):
        (waitForEvent):
        (waitForEventTestAndEnd):
        (waitForEventAndFail):
        (waitForEventAndTest._eventCallback):
        (waitForEventAndTest):
        (testException):
        (endTest):
        (endTestLater):
        (failTestIn):
        (failTest):
        (logResult):
        (consoleWrite):
        (relativeURL):
        (isInTimeRanges):
        * media/adopt-node-crash.html:
        * media/audio-constructor-preload.html:
        * media/audio-constructor-src.html:
        * media/audio-constructor.html:
        * media/audio-controls-rendering.html:
        * media/audio-data-url.html:
        * media/audio-delete-while-slider-thumb-clicked.html:
        * media/audio-delete-while-step-button-clicked.html:
        * media/audio-mpeg-supported.html:
        * media/audio-mpeg4-supported.html:
        * media/audio-play-event.html:
        * media/before-load-member-access.html:
        * media/broken-video.html:
        * media/constructors.html:
        * media/context-menu-actions.html:
        * media/controls-after-reload.html:
        * media/controls-css-overload.html:
        * media/controls-drag-timebar.html:
        * media/controls-right-click-on-timebar.html:
        * media/controls-strict.html:
        * media/controls-styling.html:
        * media/controls-without-preload.html:
        * media/event-attributes.html:
        * media/invalid-media-url-crash.html:
        * media/media-can-play-mpeg-audio.html:
        * media/media-can-play-mpeg4-video.html:
        * media/media-can-play-octet-stream.html:
        * media/media-can-play-ogg.html:
        * media/media-can-play-wav-audio.html:
        * media/media-captions.html:
        * media/media-constants.html:
        * media/media-fullscreen-inline.html:
        * media/media-fullscreen-not-in-document.html:
        * media/media-load-event.html:
        * media/media-startTime.html:
        * media/remove-from-document-no-load.html:
        * media/remove-from-document.html:
        * media/restore-from-page-cache.html:
        * media/unsupported-rtsp.html:
        * media/unsupported-tracks.html:
        * media/video-append-source.html:
        * media/video-aspect-ratio.html:
        * media/video-autoplay.html:
        * media/video-buffered.html:
        * media/video-can-play-type.html:
        * media/video-canvas-alpha.html:
        * media/video-canvas-source.html:
        * media/video-click-dblckick-standalone.html:
        * media/video-controls-in-media-document.html:
        * media/video-controls-rendering.html:
        * media/video-controls-transformed.html:
        * media/video-controls-visible-audio-only.html:
        * media/video-controls-zoomed.html:
        * media/video-controls.html:
        * media/video-currentTime-delay.html:
        * media/video-currentTime-set.html:
        * media/video-currentTime-set2.html:
        * media/video-currentTime.html:
        * media/video-delay-load-event.html:
        * media/video-display-aspect-ratio.html:
        * media/video-display-none-crash.html:
        * media/video-display-toggle.html:
        * media/video-does-not-loop.html:
        * media/video-dom-autoplay.html:
        * media/video-dom-preload.html:
        * media/video-dom-src.html:
        * media/video-duration-known-after-eos.html:
        * media/video-error-does-not-exist.html:
        * media/video-frame-accurate-seek.html:
        * media/video-layer-crash.html:
        * media/video-load-networkState.html:
        * media/video-load-readyState.html:
        * media/video-loop.html:
        * media/video-muted.html:
        * media/video-no-audio.html:
        * media/video-no-autoplay.html:
        * media/video-pause-empty-events.html:
        * media/video-pause-immediately.html:
        * media/video-play-empty-events.html:
        * media/video-play-pause-events.html:
        * media/video-play-pause-exception.html:
        * media/video-played-collapse.html:
        * media/video-played-ranges-1.html:
        * media/video-played-reset.html:
        * media/video-plays-past-end-of-test.html:
        * media/video-poster-delayed.html:
        * media/video-poster-scale.html:
        * media/video-poster.html:
        * media/video-preload.html:
        * media/video-replaces-poster.html:
        * media/video-reverse-play-duration.html:
        * media/video-seek-by-small-increment.html:
        * media/video-seek-no-src-exception.html:
        * media/video-seek-past-end-paused.html:
        * media/video-seek-past-end-playing.html:
        * media/video-seekable.html:
        * media/video-seeking.html:
        * media/video-size-intrinsic-scale.html:
        * media/video-size.html:
        * media/video-source-error-no-candidate.html:
        * media/video-source-error.html:
        * media/video-source-inserted.html:
        * media/video-source-media.html:
        * media/video-source-moved.html:
        * media/video-source-none-supported.html:
        * media/video-source-removed.html:
        * media/video-source-type-params.html:
        * media/video-source-type.html:
        * media/video-source.html:
        * media/video-src-change.html:
        * media/video-src-invalid-remove.html:
        * media/video-src-none.html:
        * media/video-src-plus-source.html:
        * media/video-src-remove.html:
        * media/video-src-set.html:
        * media/video-src-source.html:
        * media/video-src.html:
        * media/video-timeupdate-during-playback.html:
        * media/video-timeupdate-reverse-play.html:
        * media/video-transformed.html:
        * media/video-volume-slider.html:
        * media/video-volume.html:
        * media/video-width-height.html:
        * media/video-zoom-controls.html:
        * media/video-zoom.html:
2011-02-24  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79598.
        http://trac.webkit.org/changeset/79598
        https://bugs.webkit.org/show_bug.cgi?id=55089

        Appears to be causing trouble with httpd on windows

        * Scripts/webkitperl/httpd.pm:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 24 Feb 2011 22:30:29 +0000 (22:30 +0000)]
2011-02-24  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium Snow Leopard expectations update.

        * platform/chromium-mac/editing/deleting/delete-tab-003-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Added.
        * platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Added.
        * platform/chromium-mac/editing/inserting/insert-tab-003-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Added.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.checksum:
        * platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png: Added.
        * platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png: Added.
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd null check for containing block to stop reflections crash.
hyatt@apple.com [Thu, 24 Feb 2011 22:27:04 +0000 (22:27 +0000)]
Add null check for containing block to stop reflections crash.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 24 Feb 2011 22:15:45 +0000 (22:15 +0000)]
2011-02-24  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79604.
        http://trac.webkit.org/changeset/79604
        https://bugs.webkit.org/show_bug.cgi?id=55017

        Causes assertions to fail on some SVG tests

        * svg/misc/SVGImage-leak-ResourceLoader-expected.txt: Removed.
        * svg/misc/SVGImage-leak-ResourceLoader.html: Removed.
        * svg/misc/resources/load-script.html: Removed.
        * svg/misc/resources/small.png: Removed.
2011-02-24  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79604.
        http://trac.webkit.org/changeset/79604
        https://bugs.webkit.org/show_bug.cgi?id=55017

        Causes assertions to fail on some SVG tests

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
oliver@apple.com [Thu, 24 Feb 2011 22:14:46 +0000 (22:14 +0000)]
Build fix

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Thu, 24 Feb 2011 22:08:55 +0000 (22:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.

Reviewed by Simon Fraser.

Rework the logical height computation for positioned elements to work in terms of before and after.  That way the offset is determined from
the correct container side in flipped block writing modes (e.g., vertical-rl).

Patch locationOffsetIncludingFlipping to use the containing block to flip so that it will behave correctly with absolute/fixed positioned
elements.

Patch offsetFromContainer to use the flipped location offset for absolute/fixed positioned elements so that localToAbsolute works properly.

Added twelve tests in fast/block/positioning/vertical-rl and fast/block/positioning/vertical-lr.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::locationOffsetIncludingFlipping):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::logicalTop):
(WebCore::InheritedFlags::logicalBottom):

LayoutTests:

* fast/block/positioning/vertical-lr: Added.
* fast/block/positioning/vertical-lr/001.html: Added.
* fast/block/positioning/vertical-lr/002.html: Added.
* fast/block/positioning/vertical-lr/003.html: Added.
* fast/block/positioning/vertical-lr/004.html: Added.
* fast/block/positioning/vertical-lr/005.html: Added.
* fast/block/positioning/vertical-lr/006.html: Added.
* fast/block/positioning/vertical-rl: Added.
* fast/block/positioning/vertical-rl/001.html: Added.
* fast/block/positioning/vertical-rl/002.html: Added.
* fast/block/positioning/vertical-rl/003.html: Added.
* fast/block/positioning/vertical-rl/004.html: Added.
* fast/block/positioning/vertical-rl/005.html: Added.
* fast/block/positioning/vertical-rl/006.html: Added.
* platform/mac/fast/block/positioning/vertical-lr: Added.
* platform/mac/fast/block/positioning/vertical-lr/001-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-lr/001-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-lr/001-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-lr/002-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-lr/002-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-lr/002-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-lr/003-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-lr/003-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-lr/003-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-lr/004-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-lr/004-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-lr/004-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-lr/005-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-lr/005-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-lr/005-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-lr/006-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-lr/006-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-lr/006-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-rl: Added.
* platform/mac/fast/block/positioning/vertical-rl/001-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-rl/001-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-rl/001-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-rl/002-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-rl/002-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-rl/002-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-rl/003-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-rl/003-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-rl/003-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-rl/004-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-rl/004-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-rl/004-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-rl/005-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-rl/005-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-rl/005-expected.txt: Added.
* platform/mac/fast/block/positioning/vertical-rl/006-expected.checksum: Added.
* platform/mac/fast/block/positioning/vertical-rl/006-expected.png: Added.
* platform/mac/fast/block/positioning/vertical-rl/006-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 24 Feb 2011 22:04:07 +0000 (22:04 +0000)]
2011-02-24  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Layout test fast/dom/timer-increase-then-decrease-min-interval.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=55176

        Wait twice as long (1 second instead of 0.5 seconds) for results
        from these two tests. They were on the verge of passing when
        failures occurred previously, so this increase should push them
        well over the passing threshold.

        * fast/dom/timer-increase-then-decrease-min-interval-repeating.html:
        * fast/dom/timer-increase-then-decrease-min-interval.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-23 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 24 Feb 2011 21:59:57 +0000 (21:59 +0000)]
2011-02-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make WeakGCMap use new handle infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=55100

        Remove old WeakGCMap implementation and move over to new handle
        based logic.

        This has a number of benefits, most notably it makes a WeakGCMap
        always reflect the true state of the world by as all entries are
        removed at the first gc cycle that makes them dead.  This allows
        us to get rid of code in a wide variety of objects where the only
        purpose was to remove themselves from maps.

        It also means that we no longer need to have special "unchecked"
        versions of any functions on WeakGCMap.  Alas in order to maintain
        compatibility with the JSWeakObjectMapClear API it is still
        necessary to have an api that resembles uncheckedRemove, this is
        now deprecatedRemove and will be dealt with in a later patch.

        In order to get correct semantics in WeakGCMap we need more
        contextual information in the finalizer, so we've added an
        abstract class based finaliser and a context parameter to the
        calls.

        The new an improved WeakGCMap also results in sigificantly more
        churn in the weak handle lists so exposed some potential problems
        during the post mark phase which have been rectified as well.

        * API/JSWeakObjectMapRefPrivate.cpp:
        * API/JSWeakObjectMapRefPrivate.h:
        * runtime/Heap.cpp:
        (JSC::Heap::globalObjectCount):
        (JSC::Heap::protectedGlobalObjectCount):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::~JSGlobalObject):
        (JSC::JSGlobalObject::init):
        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::iterator::iterator):
        (JSC::WeakGCMap::iterator::get):
        (JSC::WeakGCMap::iterator::getSlot):
        (JSC::WeakGCMap::iterator::operator++):
        (JSC::WeakGCMap::iterator::operator==):
        (JSC::WeakGCMap::iterator::operator!=):
        (JSC::WeakGCMap::WeakGCMap):
        (JSC::WeakGCMap::isEmpty):
        (JSC::WeakGCMap::clear):
        (JSC::WeakGCMap::get):
        (JSC::WeakGCMap::getSlot):
        (JSC::WeakGCMap::set):
        (JSC::WeakGCMap::take):
        (JSC::WeakGCMap::size):
        (JSC::WeakGCMap::deprecatedRemove):
        (JSC::WeakGCMap::begin):
        (JSC::WeakGCMap::end):
        (JSC::WeakGCMap::~WeakGCMap):
        (JSC::WeakGCMap::finalize):
        * runtime/WeakGCPtr.h:
        (JSC::WeakGCPtr::WeakGCPtr):
        (JSC::WeakGCPtr::set):
2011-02-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make WeakGCMap use new handle infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=55100

        Update to new WeakGCMap APIs, this requires threading global
        data to a few functions that did not need it in the past, but
        also gets rid of a large number of destructors, as well as the
        forgetDOMNode, etc APIs.

        We can also drop the JSDebugWrapperSet as its only purpose was
        to ensure that we retained correct semantics in the old WeakGCMap,
        but happilly these semantics are now guaranteed by the map itself.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::hasCachedDOMObjectWrapperUnchecked):
        (WebCore::cacheDOMObjectWrapper):
        (WebCore::hasCachedDOMNodeWrapperUnchecked):
        (WebCore::cacheDOMNodeWrapper):
        (WebCore::isObservableThroughDOM):
        (WebCore::markDOMNodesForDocument):
        (WebCore::takeWrappers):
        (WebCore::updateDOMNodeDocument):
        (WebCore::markDOMObjectWrapper):
        (WebCore::markDOMNodeWrapper):
        (WebCore::stringWrapperDestroyed):
        (WebCore::jsStringSlowCase):
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWrapper.cpp:
        (WebCore::DOMObject::~DOMObject):
        * bindings/js/JSDebugWrapperSet.cpp: Removed.
        * bindings/js/JSDebugWrapperSet.h: Removed.
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/jsc/BridgeJSC.cpp:
        (JSC::Bindings::Instance::createRuntimeObject):
        * bridge/jsc/BridgeJSC.h:
        * bridge/runtime_object.cpp:
        (JSC::Bindings::RuntimeObject::~RuntimeObject):
        * bridge/runtime_root.cpp:
        (JSC::Bindings::RootObject::invalidate):
        (JSC::Bindings::RootObject::addRuntimeObject):
        (JSC::Bindings::RootObject::removeRuntimeObject):
        * bridge/runtime_root.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang build.
andersca@apple.com [Thu, 24 Feb 2011 21:56:19 +0000 (21:56 +0000)]
Fix clang build.

* WebCoreSupport/WebKeyGenerator.m:
(toWebCertificateParseResult):
(-[WebKeyGenerator addCertificatesToKeychainFromData:]):
* WebView/WebTextCompletionController.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 24 Feb 2011 21:54:16 +0000 (21:54 +0000)]
2011-02-24  James Robinson  <jamesr@chromium.org>

        Fix chromium compile.

        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::V8Location::toStringCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 24 Feb 2011 21:45:18 +0000 (21:45 +0000)]
2011-02-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r79607.
        http://trac.webkit.org/changeset/79607
        https://bugs.webkit.org/show_bug.cgi?id=55157

        Broke Chromium layout tests.

        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::updateVolumeSliderContainer):
        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
        * rendering/RenderMediaControls.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
        * rendering/RenderThemeWin.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd basic pixel testing support to WebKitTestRunner
weinig@apple.com [Thu, 24 Feb 2011 21:37:49 +0000 (21:37 +0000)]
Add basic pixel testing support to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=55161

Reviewed by Darin Adler.

* Scripts/old-run-webkit-tests:
Don't print color space information when using WebKitTestRunner since
we don't need to change the screen.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
Add call to initializePlatformDefaults.

(WTR::InjectedBundle::done):
Return a dictionary on completion with both the text output and pixel dump override.

* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
Add declaration for initializePlatformDefaults.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
(WTR::LayoutTestController::dumpAsText):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::shouldDumpPixels):
Make setting dumpAsText override the dump pixels preference.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
(WTR::InjectedBundle::initializePlatformDefaults):
Set platform defaults matching DumpRenderTree.

* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
(WTR::InjectedBundle::initializePlatformDefaults):
* WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
(WTR::InjectedBundle::initializePlatformDefaults):
Add stubs for initializePlatformDefaults.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest):
(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):
Parse expected pixel results out of stdin and setup the invocation with it.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
Initialize new members.

(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
(WTR::sizeWebViewForCurrentTest):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.

* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.

* WebKitTestRunner/mac/TestInvocationMac.mm: Added.
(WTR::createCGContextFromPlatformView):
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::forceRepaintFunction):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
Add mac specific pixel dumping support. Right now, we always pull pixels
from the window server.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/WebKitTestRunner.pro:
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
Add new files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the clang -Woverloaded-virtual build.
andersca@apple.com [Thu, 24 Feb 2011 21:31:43 +0000 (21:31 +0000)]
Fix the clang -Woverloaded-virtual build.

Reviewed by Sam Weinig.

JSLocation has a toString function which conflicts with the virtual JSObject::toString  member function.
Fix this by renaming the implementation function from JSLocation::toString to JSLocation::toStringFunction.

* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::toStringFunction):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::toStringFunctionCallback):
* page/Location.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Chang Shu <cshu@webkit.org>
chang.shu@nokia.com [Thu, 24 Feb 2011 21:31:07 +0000 (21:31 +0000)]
2011-02-24  Chang Shu  <cshu@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Launch MiniBrowser if the test run is WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=55145

        * Scripts/old-run-webkit-tests:
        * Scripts/run-launcher:
        * Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang build.
andersca@apple.com [Thu, 24 Feb 2011 21:24:45 +0000 (21:24 +0000)]
Fix clang build.

* bindings/objc/WebScriptObject.mm:
(-[WebUndefined release]):
Release should be "oneway void".

(-[WebUndefined retainCount]):
Return NSUIntegerMax instead of UINT_MAX.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 24 Feb 2011 21:23:53 +0000 (21:23 +0000)]
2011-02-24  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Leopard baseline update for some text tests after r78846
        (Snow Leopard baselines were updated with r78862). chromium-mac (the
        Leopard bot) should be passing with the mac-leopard baselines.

        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/mac-leopard/editing/selection/move-past-trailing-space-expected.png:
        * platform/mac-leopard/fast/text/trailing-white-space-2-expected.checksum:
        * platform/mac-leopard/fast/text/trailing-white-space-2-expected.png:
        * platform/mac-leopard/fast/text/trailing-white-space-expected.checksum:
        * platform/mac-leopard/fast/text/trailing-white-space-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 24 Feb 2011 21:10:03 +0000 (21:10 +0000)]
2011-02-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code.
        https://bugs.webkit.org/show_bug.cgi?id=55157

        Refactoring, no functional changes. Covered by existing tests.

        RenderTheme::volumeSliderOffsetFromMuteButton has the same duplicated
        logic for all platforms. This patch:
        a) moves the common logic of determining absolute positioning to a
           platform-agnostic place;
        b) simplifies the method to return constant offset.

        * html/shadow/MediaControls.cpp:
        (WebCore::volumeSliderOffset): Added new helper function,
            capturing common logic of finding the absolute position of the volume slider.
        (WebCore::MediaControls::updateVolumeSliderContainer): Changed to use the
            new helper.
        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::volumeSliderOffsetRelativeToMuteButton): Simplified.
        * rendering/RenderMediaControls.h: Ditto.
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::volumeSliderOffsetRelativeToMuteButton): Ditto.
        * rendering/RenderTheme.h: Ditto.
        * rendering/RenderThemeChromiumMac.h: Ditto.
        * rendering/RenderThemeChromiumMac.mm: Ditto.
        (WebCore::RenderThemeChromiumMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
        * rendering/RenderThemeMac.h: Ditto.
        * rendering/RenderThemeMac.mm: Ditto.
        (WebCore::RenderThemeMac::volumeSliderOffsetRelativeToMuteButton): Ditto.
        * rendering/RenderThemeWin.cpp: Ditto.
        (WebCore::RenderThemeWin::volumeSliderOffsetRelativeToMuteButton): Ditto.
        * rendering/RenderThemeWin.h: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Tom Sepez <tsepez@chromium.org>
jschuh@chromium.org [Thu, 24 Feb 2011 21:06:10 +0000 (21:06 +0000)]
2011-02-24  Tom Sepez  <tsepez@chromium.org>

        Reviewed by Darin Fisher.

        Add test for frame removal during resize event handler.  Update
        other tests to account for async onresize event disptach.
        https://bugs.webkit.org/show_bug.cgi?id=54467

        * fast/dynamic/paused-event-dispatch.html:
        * fast/events/resize-subframe.html:
        * fast/replaced/frame-removed-during-resize-smaller-expected.txt: Added.
        * fast/replaced/frame-removed-during-resize-smaller.html: Added.
2011-02-24  Tom Sepez  <tsepez@chromium.org>

        Reviewed by Darin Fisher.

        Make frameview resized event dispatch async so that it occurs
        after layout has completed.

        https://bugs.webkit.org/show_bug.cgi?id=54467
        Test: fast/replaced/frame-removed-during-resize-smaller.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendResizeEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Xianzhu Wang <wangxianzhu@google.com>
commit-queue@webkit.org [Thu, 24 Feb 2011 20:57:44 +0000 (20:57 +0000)]
2011-02-24  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by Adam Barth.

        Add a test to ensure SVGImage won't cause ResourceLoader leaks.
        https://bugs.webkit.org/show_bug.cgi?id=55017

        * svg/misc: Added.
        * svg/misc/SVGImage-leak-ResourceLoader-expected.txt: Added.
        * svg/misc/SVGImage-leak-ResourceLoader.html: Added.
        * svg/misc/resources: Added.
        * svg/misc/resources/load-script.html: Added.
        * svg/misc/resources/small.png: Added.
2011-02-24  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by Adam Barth.

        Use loader->init() instead of loader->load() to avoid complex fake
        request loading and cleanup logic, and also avoid ResourceLoader leaks.

        https://bugs.webkit.org/show_bug.cgi?id=55017

        Test: svg/misc/SVGImage-leak-ResourceLoader.html

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Anna Cavender <annacc@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 20:45:03 +0000 (20:45 +0000)]
2011-02-24  Anna Cavender  <annacc@chromium.org>

        Reviewed by Mihai Parparita.

        Rebaselines for media tests under snowleopard.
        https://bugs.webkit.org/show_bug.cgi?id=54994

        * platform/chromium-mac-leopard/media/audio-repaint-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/audio-repaint-expected.checksum.
        * platform/chromium-mac-leopard/media/audio-repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/media/audio-repaint-expected.png.
        * platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Added.
        * platform/chromium-mac-leopard/media/video-aspect-ratio-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-aspect-ratio-expected.checksum.
        * platform/chromium-mac-leopard/media/video-aspect-ratio-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-aspect-ratio-expected.png.
        * platform/chromium-mac-leopard/media/video-zoom-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-zoom-expected.checksum.
        * platform/chromium-mac-leopard/media/video-zoom-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-zoom-expected.png.
        * platform/chromium-mac/media/audio-controls-rendering-expected.txt:
        * platform/chromium-mac/media/audio-repaint-expected.checksum:
        * platform/chromium-mac/media/audio-repaint-expected.png:
        * platform/chromium-mac/media/controls-after-reload-expected.checksum:
        * platform/chromium-mac/media/controls-after-reload-expected.png:
        * platform/chromium-mac/media/controls-after-reload-expected.txt:
        * platform/chromium-mac/media/controls-strict-expected.checksum:
        * platform/chromium-mac/media/controls-strict-expected.png:
        * platform/chromium-mac/media/controls-strict-expected.txt:
        * platform/chromium-mac/media/controls-styling-expected.checksum:
        * platform/chromium-mac/media/controls-styling-expected.png:
        * platform/chromium-mac/media/controls-styling-expected.txt:
        * platform/chromium-mac/media/controls-without-preload-expected.checksum:
        * platform/chromium-mac/media/controls-without-preload-expected.png:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.checksum:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
        * platform/chromium-mac/media/video-aspect-ratio-expected.png:
        * platform/chromium-mac/media/video-empty-source-expected.txt:
        * platform/chromium-mac/media/video-no-audio-expected.txt:
        * platform/chromium-mac/media/video-volume-slider-expected.txt:
        * platform/chromium-mac/media/video-zoom-controls-expected.checksum:
        * platform/chromium-mac/media/video-zoom-controls-expected.png:
        * platform/chromium-mac/media/video-zoom-expected.checksum:
        * platform/chromium-mac/media/video-zoom-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 24 Feb 2011 20:30:14 +0000 (20:30 +0000)]
2011-02-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Chromium Mac build fix after r79591.

        * WebCore.gypi: Added RenderMediaControls to WebCore.gypi.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 24 Feb 2011 20:09:29 +0000 (20:09 +0000)]
2011-02-24  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make weaklist processing deal with weak handles being removed during the iteration
        https://bugs.webkit.org/show_bug.cgi?id=55105

        It is possible for the handle heap to end up in a broken state if
        a handle's finalizer removes either the current or next handle
        to be visited during the post-gc cleanup.  This patch removes that
        problem by allowing the deallocate(Node*) routine to update the
        iterator if it is called during finalization.

        * collector/handles/HandleHeap.cpp:
        (JSC::HandleHeap::HandleHeap):
        (JSC::HandleHeap::updateAfterMark):
        (JSC::HandleHeap::clearWeakPointers):
        (JSC::HandleHeap::writeBarrier):
        (JSC::HandleHeap::protectedGlobalObjectCount):
        * collector/handles/HandleHeap.h:
        (JSC::Finalizer::~Finalizer):
        (JSC::HandleHeap::getFinalizer):
        (JSC::HandleHeap::deallocate):
        (JSC::HandleHeap::makeWeak):
        (JSC::HandleHeap::makeSelfDestroying):
        (JSC::HandleHeap::Node::Node):
        (JSC::HandleHeap::Node::setFinalizer):
        (JSC::HandleHeap::Node::finalizer):
        (JSC::HandleHeap::Node::finalizerContext):
        * interpreter/RegisterFile.cpp:
        (JSC::RegisterFile::setGlobalObject):
        (JSC::GlobalObjectNotifier::finalize):
        (JSC::RegisterFile::globalObjectCollectedNotifier):
        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        * runtime/Heap.cpp:
        (JSC::Heap::destroy):
        * runtime/WeakGCPtr.h:
        (JSC::WeakGCPtr::WeakGCPtr):
        (JSC::WeakGCPtr::set):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 James Kozianski <koz@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 19:54:47 +0000 (19:54 +0000)]
2011-02-24  James Kozianski  <koz@chromium.org>

        Reviewed by Ojan Vafai.

        Add missing plumbing for registerProtocolHandler in ChromeClientImpl.
        https://bugs.webkit.org/show_bug.cgi?id=55112

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::registerProtocolHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 24 Feb 2011 19:46:33 +0000 (19:46 +0000)]
2011-02-24  James Robinson  <jamesr@chromium.org>

        Update chromium test expectations.

        * platform/chromium-linux/media/video-display-toggle-expected.checksum:
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/transitions/default-timing-function-expected.checksum: Added.
        * platform/chromium-linux/transitions/default-timing-function-expected.png: Added.
        * platform/chromium-win/media/video-display-toggle-expected.checksum:
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/transitions/default-timing-function-expected.checksum: Added.
        * platform/chromium-win/transitions/default-timing-function-expected.png: Added.
        * platform/chromium-win/transitions/default-timing-function-expected.txt: Added.
        * platform/chromium/inspector/debugger/dom-breakpoints-expected.txt: Added.
        * platform/mac-leopard/transitions/default-timing-function-expected.checksum: Added.
        * platform/mac-leopard/transitions/default-timing-function-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Victoria Kirst <vrk@google.com>
mihaip@chromium.org [Thu, 24 Feb 2011 19:42:54 +0000 (19:42 +0000)]
2011-02-24  Victoria Kirst  <vrk@google.com>

        Reviewed by Mihai Parparita.

        [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
        https://bugs.webkit.org/show_bug.cgi?id=55089

        Media's UILayoutTests rely on video-test.js and media-file.js to be in
        the media/ folder.

        * http/tests/media/pdf-served-as-pdf.html:
        * http/tests/media/reload-after-dialog.html:
        * http/tests/media/remove-while-loading.html:
        * http/tests/media/text-served-as-text.html:
        * http/tests/media/video-buffered.html:
        * http/tests/media/video-cancel-load.html:
        * http/tests/media/video-cookie.html:
        * http/tests/media/video-error-abort.html:
        * http/tests/media/video-load-twice.html:
        * http/tests/media/video-play-stall-seek.html:
        * http/tests/media/video-play-stall.html:
        * http/tests/media/video-play-suspend.html:
        * http/tests/media/video-referer.html:
        * http/tests/media/video-seekable-stall.html:
        * http/tests/media/video-served-as-text.html:
        * media/adopt-node-crash.html:
        * media/audio-constructor-preload.html:
        * media/audio-constructor-src.html:
        * media/audio-constructor.html:
        * media/audio-controls-rendering.html:
        * media/audio-data-url.html:
        * media/audio-delete-while-slider-thumb-clicked.html:
        * media/audio-delete-while-step-button-clicked.html:
        * media/audio-mpeg-supported.html:
        * media/audio-mpeg4-supported.html:
        * media/audio-play-event.html:
        * media/before-load-member-access.html:
        * media/broken-video.html:
        * media/constructors.html:
        * media/context-menu-actions.html:
        * media/controls-after-reload.html:
        * media/controls-css-overload.html:
        * media/controls-drag-timebar.html:
        * media/controls-right-click-on-timebar.html:
        * media/controls-strict.html:
        * media/controls-styling.html:
        * media/controls-without-preload.html:
        * media/event-attributes.html:
        * media/invalid-media-url-crash.html:
        * media/media-can-play-mpeg-audio.html:
        * media/media-can-play-mpeg4-video.html:
        * media/media-can-play-octet-stream.html:
        * media/media-can-play-ogg.html:
        * media/media-can-play-wav-audio.html:
        * media/media-captions.html:
        * media/media-constants.html:
        * media/media-file.js: Renamed from LayoutTests/http/tests/media/media-file.js.
        * media/media-fullscreen-inline.html:
        * media/media-fullscreen-not-in-document.html:
        * media/media-load-event.html:
        * media/media-startTime.html:
        * media/remove-from-document-no-load.html:
        * media/remove-from-document.html:
        * media/restore-from-page-cache.html:
        * media/unsupported-rtsp.html:
        * media/unsupported-tracks.html:
        * media/video-append-source.html:
        * media/video-aspect-ratio.html:
        * media/video-autoplay.html:
        * media/video-buffered.html:
        * media/video-can-play-type.html:
        * media/video-canvas-alpha.html:
        * media/video-canvas-source.html:
        * media/video-click-dblckick-standalone.html:
        * media/video-controls-rendering.html:
        * media/video-controls-transformed.html:
        * media/video-controls-visible-audio-only.html:
        * media/video-controls-zoomed.html:
        * media/video-controls.html:
        * media/video-currentTime-delay.html:
        * media/video-currentTime-set.html:
        * media/video-currentTime-set2.html:
        * media/video-currentTime.html:
        * media/video-delay-load-event.html:
        * media/video-display-aspect-ratio.html:
        * media/video-display-none-crash.html:
        * media/video-display-toggle.html:
        * media/video-does-not-loop.html:
        * media/video-dom-autoplay.html:
        * media/video-dom-preload.html:
        * media/video-dom-src.html:
        * media/video-duration-known-after-eos.html:
        * media/video-error-does-not-exist.html:
        * media/video-frame-accurate-seek.html:
        * media/video-layer-crash.html:
        * media/video-load-networkState.html:
        * media/video-load-readyState.html:
        * media/video-loop.html:
        * media/video-muted.html:
        * media/video-no-audio.html:
        * media/video-no-autoplay.html:
        * media/video-pause-empty-events.html:
        * media/video-pause-immediately.html:
        * media/video-play-empty-events.html:
        * media/video-play-pause-events.html:
        * media/video-play-pause-exception.html:
        * media/video-played-collapse.html:
        * media/video-played-ranges-1.html:
        * media/video-played-reset.html:
        * media/video-poster-delayed.html:
        * media/video-poster-scale.html:
        * media/video-poster.html:
        * media/video-preload.html:
        * media/video-replaces-poster.html:
        * media/video-reverse-play-duration.html:
        * media/video-seek-by-small-increment.html:
        * media/video-seek-no-src-exception.html:
        * media/video-seek-past-end-paused.html:
        * media/video-seek-past-end-playing.html:
        * media/video-seekable.html:
        * media/video-seeking.html:
        * media/video-size-intrinsic-scale.html:
        * media/video-size.html:
        * media/video-source-error-no-candidate.html:
        * media/video-source-error.html:
        * media/video-source-inserted.html:
        * media/video-source-media.html:
        * media/video-source-moved.html:
        * media/video-source-none-supported.html:
        * media/video-source-removed.html:
        * media/video-source-type-params.html:
        * media/video-source-type.html:
        * media/video-source.html:
        * media/video-src-change.html:
        * media/video-src-invalid-remove.html:
        * media/video-src-none.html:
        * media/video-src-plus-source.html:
        * media/video-src-remove.html:
        * media/video-src-set.html:
        * media/video-src-source.html:
        * media/video-src.html:
        * media/video-test.js: Renamed from LayoutTests/http/tests/media/video-test.js.
        * media/video-timeupdate-during-playback.html:
        * media/video-timeupdate-reverse-play.html:
        * media/video-transformed.html:
        * media/video-volume-slider.html:
        * media/video-volume.html:
        * media/video-width-height.html:
        * media/video-zoom-controls.html:
        * media/video-zoom.html:
2011-02-24  Victoria Kirst  <vrk@google.com>

        Reviewed by Mihai Parparita.

        [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
        https://bugs.webkit.org/show_bug.cgi?id=55089

        This adds an alias into the media/ directory so that http/tests/media
        tests can access the media resources when running in an httpd process.

        * Scripts/webkitperl/httpd.pm:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Anna Cavender <annacc@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 19:40:24 +0000 (19:40 +0000)]
2011-02-24  Anna Cavender  <annacc@chromium.org>

        Reviewed by Ojan Vafai.

        rebaseline for media/video-controls-rendering.html on mac
        https://bugs.webkit.org/show_bug.cgi?id=55108

        * platform/chromium-mac/media/video-controls-rendering-expected.checksum:
        * platform/chromium-mac/media/video-controls-rendering-expected.png:
        * platform/chromium-mac/media/video-controls-rendering-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=55165
beidson@apple.com [Thu, 24 Feb 2011 19:35:03 +0000 (19:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55165
Can call CF API with a null CFArray in WebResourceCacheManager

Reviewed by Adam Roben and looked at by Brian Weinstein.

* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): cfURLCacheHostNames() can return a null CFArrayRef,
  so the call to CFArrayGetCount must be null checked.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Misha Tyutyunik <michael.tyutyunik@nokia.com>
commit-queue@webkit.org [Thu, 24 Feb 2011 19:31:59 +0000 (19:31 +0000)]
2011-02-24  Misha Tyutyunik  <michael.tyutyunik@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Dont use QPixmapCache if QPixmapCache::cacheLimit() is too small
        (2048Kb for now).
        https://bugs.webkit.org/show_bug.cgi?id=54887

        No new tests required.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::allowAcceleratedCompositingCache):
        (WebCore::GraphicsLayerQtImpl::drawLayerContent):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 24 Feb 2011 19:25:27 +0000 (19:25 +0000)]
2011-02-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        PatternAlternative leaked in YarrPatternConstructor::atomParenthesesEnd()
        https://bugs.webkit.org/show_bug.cgi?id=55156

        Added code to delete unneeded PatternAlternative after it is removed
        from m_alternatives Vector.

        * yarr/YarrPattern.cpp:
        (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 24 Feb 2011 19:25:22 +0000 (19:25 +0000)]
2011-02-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        ASSERTION FAILED: !isInAcceleratedCompositingMode() when entering accelerated compositing early
        https://bugs.webkit.org/show_bug.cgi?id=55162
        <rdar://problem/9048523>

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::updateState):
        Call setShouldNotifyAfterNextScheduledLayerFlush(false) so the web process process won't send an
        EnterAcceleratedCompositingMode message.

        (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
        setShouldNotifyAfterNextScheduledLayerFlush now takes a boolean.

        * WebProcess/WebPage/LayerTreeHost.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
        Make this take a boolean.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 24 Feb 2011 19:00:37 +0000 (19:00 +0000)]
2011-02-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Nikolas Zimmermann.

        [CAIRO] Support ImageBuffers clip operation on all Cairo ports
        https://bugs.webkit.org/show_bug.cgi?id=23526

        Update results for tests which are now passing and unskip them.

        * platform/gtk/Skipped: Unskip tests which are now passing.
        * platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
        * platform/gtk/fast/backgrounds/animated-svg-as-mask-expected.txt: Added.
        * platform/gtk/fast/backgrounds/svg-as-mask-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/svg-as-mask-expected.png: Added.
        * platform/gtk/fast/backgrounds/svg-as-mask-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
        * platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
        * platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
        * platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
        * platform/gtk/svg/batik/masking/maskRegions-expected.checksum:
        * platform/gtk/svg/batik/masking/maskRegions-expected.png:
        * platform/gtk/svg/batik/text/textEffect2-expected.checksum:
        * platform/gtk/svg/batik/text/textEffect2-expected.png:
        * platform/gtk/svg/clip-path/clip-in-mask-expected.checksum:
        * platform/gtk/svg/clip-path/clip-in-mask-expected.png:
        * platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum:
        * platform/gtk/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
        * platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum:
        * platform/gtk/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
        * platform/gtk/svg/clip-path/clip-path-child-clipped-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-child-clipped-expected.png:
        * platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.png:
        * platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
        * platform/gtk/svg/clip-path/clip-path-clipped-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-clipped-expected.png:
        * platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png:
        * platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.png:
        * platform/gtk/svg/clip-path/clip-path-evenodd-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-evenodd-expected.png:
        * platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.png:
        * platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.png:
        * platform/gtk/svg/clip-path/clip-path-nonzero-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-nonzero-expected.png:
        * platform/gtk/svg/clip-path/clip-path-pixelation-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-pixelation-expected.png:
        * platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.png:
        * platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.png:
        * platform/gtk/svg/clip-path/clip-path-text-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-text-expected.png:
        * platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png:
        * platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png:
        * platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png:
        * platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png:
        * platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png:
        * platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.checksum:
        * platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.png:
        * platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.checksum:
        * platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
        * platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.checksum:
        * platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.png:
        * platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.checksum:
        * platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
        * platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum:
        * platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
        * platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum:
        * platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
        * platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum:
        * platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
        * platform/gtk/svg/css/circle-in-mask-with-shadow-expected.checksum: Added.
        * platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Added.
        * platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
        * platform/gtk/svg/css/clippath-with-shadow-expected.checksum: Added.
        * platform/gtk/svg/css/clippath-with-shadow-expected.png: Added.
        * platform/gtk/svg/css/clippath-with-shadow-expected.txt: Added.
        * platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
        * platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
        * platform/gtk/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
        * platform/gtk/svg/custom/circular-marker-reference-2-expected.txt:
        * platform/gtk/svg/custom/js-late-mask-and-object-creation-expected.checksum:
        * platform/gtk/svg/custom/js-late-mask-and-object-creation-expected.png:
        * platform/gtk/svg/custom/js-late-mask-creation-expected.checksum:
        * platform/gtk/svg/custom/js-late-mask-creation-expected.png:
        * platform/gtk/svg/custom/marker-child-changes-css-expected.checksum: Added.
        * platform/gtk/svg/custom/marker-child-changes-css-expected.png: Copied from LayoutTests/platform/gtk/svg/custom/mask-changes-expected.png.
        * platform/gtk/svg/custom/marker-child-changes-css-expected.txt: Added.
        * platform/gtk/svg/custom/mask-changes-expected.checksum:
        * platform/gtk/svg/custom/mask-changes-expected.png:
        * platform/gtk/svg/custom/mask-child-changes-expected.checksum:
        * platform/gtk/svg/custom/mask-child-changes-expected.png:
        * platform/gtk/svg/custom/mask-colorspace-expected.checksum: Added.
        * platform/gtk/svg/custom/mask-colorspace-expected.png: Added.
        * platform/gtk/svg/custom/mask-colorspace-expected.txt: Added.
        * platform/gtk/svg/custom/mask-inside-defs-expected.checksum:
        * platform/gtk/svg/custom/mask-inside-defs-expected.png:
        * platform/gtk/svg/custom/mask-on-multiple-objects-expected.checksum: Added.
        * platform/gtk/svg/custom/mask-on-multiple-objects-expected.png: Added.
        * platform/gtk/svg/custom/mask-on-multiple-objects-expected.txt: Added.
        * platform/gtk/svg/custom/mask-with-all-units-expected.checksum:
        * platform/gtk/svg/custom/mask-with-all-units-expected.png:
        * platform/gtk/svg/custom/non-circular-marker-reference-expected.txt:
        * platform/gtk/svg/custom/recursive-mask-expected.checksum: Added.
        * platform/gtk/svg/custom/recursive-mask-expected.png: Added.
        * platform/gtk/svg/custom/recursive-mask-expected.txt:
        * platform/gtk/svg/custom/visibility-override-mask-expected.checksum:
        * platform/gtk/svg/custom/visibility-override-mask-expected.png:
        * platform/gtk/svg/filters/feGaussianBlur-expected.checksum: Added.
        * platform/gtk/svg/filters/feGaussianBlur-expected.png: Added.
        * platform/gtk/svg/filters/feGaussianBlur-expected.txt: Added.
        * platform/gtk/svg/filters/filter-clip-expected.checksum: Added.
        * platform/gtk/svg/filters/filter-clip-expected.png: Added.
        * platform/gtk/svg/filters/filter-clip-expected.txt: Added.
        * platform/gtk/svg/filters/shadow-on-filter-expected.checksum: Added.
        * platform/gtk/svg/filters/shadow-on-filter-expected.png: Added.
        * platform/gtk/svg/filters/shadow-on-filter-expected.txt: Added.
        * platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.checksum: Added.
        * platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
        * platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.txt: Added.
        * platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
        * platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
        * platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
        * platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
        * platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
        * platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
2011-02-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Nikolas Zimmermann.

        [CAIRO] Support ImageBuffers clip operation on all Cairo ports
        https://bugs.webkit.org/show_bug.cgi?id=23526

        Add support for ImageBuffer clipping on Cairo by emulating them with image
        masks. Since masking is immediate on Cairo, we must store the mask surfaces
        on a stack and apply them during restorePlatformState.

        * platform/graphics/GraphicsContext.h: Add pushImageMask.
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::savePlatformState): Push an empty mask onto the
        stack, so we can keep track of when to actually apply the image mask.
        (WebCore::GraphicsContext::restorePlatformState): When we are ready to apply
        an image mask, use cairo_mask_surface to mask the group that we pushed onto
        our surface.
        (WebCore::GraphicsContext::pushImageMask): Added. This method will push a surface
        onto the image mask stack and push a group onto the Cairo state, so that the masking
        only affects what we paint after this point.
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Added a class to keep
        track of image masking information after calls to pushImageMask.
        (WebCore::ImageMaskInformation::update): Added
        (WebCore::ImageMaskInformation::valid): Added
        (WebCore::ImageMaskInformation::maskSurface): Added
        (WebCore::ImageMaskInformation::maskRect): Added
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::clip): Call GraphicsContext::pushImageMask.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 24 Feb 2011 18:54:07 +0000 (18:54 +0000)]
2011-02-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Add RenderMediaControls to Mac build, unduplicate one method.
        https://bugs.webkit.org/show_bug.cgi?id=55152

        Refactoring, no functional changes.

        * WebCore.xcodeproj/project.pbxproj: Added RenderMediaControls to project,
            ran sort-XCode-project-file.
        * rendering/RenderMediaControls.cpp: Moved ENABLE(VIDEO) and PLATFORM(WIN)
            defines to allow building on Mac.
        * rendering/RenderMediaControls.h: Ditto.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Replaced guts
            with a call to RenderMediaControls function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 24 Feb 2011 18:44:24 +0000 (18:44 +0000)]
2011-02-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Anders Carlsson.

        VectorBuffer should not call malloc(0)
        https://bugs.webkit.org/show_bug.cgi?id=55091

        Turns out the malloc() call which was so hot in:
        https://bugs.webkit.org/show_bug.cgi?id=55005
        was actually just malloc(0).

        We shouldn't be calling malloc(0) anyway, since there is no need to
        and it might actually do work on some systems.
        I believe on Mac it ends up taking the standard spinlocks (expensive)
        and the code on Brew actually does a malloc(1) instead.  Neither is desirable.

        * wtf/Vector.h:
        (WTF::VectorBufferBase::allocateBuffer):
        (WTF::VectorBufferBase::tryAllocateBuffer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Peter Kasting <pkasting@google.com>
commit-queue@webkit.org [Thu, 24 Feb 2011 18:42:28 +0000 (18:42 +0000)]
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * http/tests/navigation/useragent-expected.txt:
        * http/tests/navigation/useragent.php:
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * StringsNotToBeLocalized.txt:
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::composeUserAgent):
        * ewk/ewk_settings.cpp:
        (ewk_settings_default_user_agent_get):
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * webkit/webkitwebsettings.cpp:
        (webkitUserAgent):
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * WebView/WebView.mm:
        (+[WebView _standardUserAgentWithApplicationName:]):
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * WebView.cpp:
        (WebView::standardUserAgentWithApplicationName):
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::userAgent):
2011-02-24  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        Drop the "U; " encryption level from the User Agent string.
        https://bugs.webkit.org/show_bug.cgi?id=54566

        * UIProcess/gtk/WebPageProxyGtk.cpp:
        (WebKit::WebPageProxy::standardUserAgent):
        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::standardUserAgent):
        * UIProcess/qt/WebPageProxyQt.cpp:
        (WebKit::WebPageProxy::standardUserAgent):
        * UIProcess/win/WebPageProxyWin.cpp:
        (WebKit::WebPageProxy::standardUserAgent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 24 Feb 2011 18:37:57 +0000 (18:37 +0000)]
2011-02-24  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79584.
        http://trac.webkit.org/changeset/79584
        https://bugs.webkit.org/show_bug.cgi?id=44797

        [chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
        not set

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
2011-02-24  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r79584.
        http://trac.webkit.org/changeset/79584
        https://bugs.webkit.org/show_bug.cgi?id=44797

        [chromium] Patch does not compile if ENABLE_FULLSCREEN_API is
        not set

        * features.gypi:
        * public/WebSettings.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:
        * src/WebSettingsImpl.cpp:
        * src/WebSettingsImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 24 Feb 2011 18:11:34 +0000 (18:11 +0000)]
2011-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        Do not cache the default cairo font options using a static
        variable. It fixes a memory leak reported by valgrind.

        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
        (WebCore::getDefaultFontOptions):
        (WebCore::FontPlatformData::initializeWithFontFace):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Thu, 24 Feb 2011 18:07:54 +0000 (18:07 +0000)]
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * WebCore.exp.in:
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        * src/WebFrameImpl.h:
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * WebView/WebFrame.mm:
        * WebView/WebFramePrivate.h:
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        * WebFrame.h:
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-24  Andrew Wilson  <atwilson@chromium.org>

        Unreviewed, rolling out r79570.
        http://trac.webkit.org/changeset/79570
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Breaks chromium build because glue/mocks/mock_web_frame.h/cc
        was not updated

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of WebKit2: Need a way to manage cookies from the web process
bweinstein@apple.com [Thu, 24 Feb 2011 18:02:44 +0000 (18:02 +0000)]
Part of WebKit2: Need a way to manage cookies from the web process
https://bugs.webkit.org/show_bug.cgi?id=55086

Reviewed by Adam Roben and looked over by Jessie Berlin.

This patch adds the plumbing and classes that are needed to manage cookies from the web process.
The functions that the API calls are currently stubs, but will be implemented in a follow-up patch.

Project file changes.
* DerivedSources.make:
* DerivedSources.pro:
* GNUmakefile.am:
* WebKit2.pri:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Common.vsprops:
* win/WebKit2Generated.make:

Add some needed plumbing for WebCookieManager{Proxy}.
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* UIProcess/API/C/WKAPICast.h:

* UIProcess/API/C/WKContext.cpp:
(WKContextGetCookieManager): Gets the cookie manager proxy.
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKCookieManager.cpp: Added.
(WKCookieManagerGetTypeID):
(WKCookieManagerGetHostnamesWithCookies): Calls through to WebCookieManagerProxy.
(WKCookieManagerDeleteCookiesForHostname): Ditto.
(WKCookieManagerDeleteAllCookies): Ditto.
* UIProcess/API/C/WKCookieManager.h: Added.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage): Add a case for the cookie manager.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize the cookie manager.
(WebKit::WebContext::~WebContext): Invalidate the cookie manager.
(WebKit::WebContext::disconnectProcess): Ditto.
(WebKit::WebContext::didReceiveMessage): Add a case for the cookie manager.
* UIProcess/WebContext.h:
(WebKit::WebContext::cookieManagerProxy): Returns the cookie manager.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage): Add a case for the cookie manager.

* UIProcess/WebCookieManagerProxy.cpp: Added.
(WebKit::WebCookieManagerProxy::create):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::invalidate):
(WebKit::WebCookieManagerProxy::didReceiveMessage):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Call through to the web process to get hostnames with cookies.
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies): Call the callback we were passed in getHostnamesWithCookies.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Call through to the web process to delete cookies
    for the origin.
(WebKit::WebCookieManagerProxy::deleteAllCookies): Call through to the web process to delete all cookies.
* UIProcess/WebCookieManagerProxy.h: Added.
(WebKit::WebCookieManagerProxy::clearContext):
(WebKit::WebCookieManagerProxy::type):
* UIProcess/WebCookieManagerProxy.messages.in: Added.

* WebProcess/Cookies: Added.
* WebProcess/Cookies/WebCookieManager.cpp: Added.
(WebKit::WebCookieManager::shared):
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::didReceiveMessage): Call through to didReceiveWebCookieManagerMessage.
(WebKit::WebCookieManager::getHostnamesWithCookies): Build an array from a HashSet (that isn't filled yet), and
    convert that HashSet to a Vector to send to the UI process.
(WebKit::WebCookieManager::deleteCookiesForHostname): Added a stub.
(WebKit::WebCookieManager::deleteAllCookies): Ditto.
* WebProcess/Cookies/WebCookieManager.h: Added.
* WebProcess/Cookies/WebCookieManager.messages.in: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 David Dorwin <ddorwin@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 18:00:07 +0000 (18:00 +0000)]
2011-02-24  David Dorwin  <ddorwin@chromium.org>

        Reviewed by Eric Seidel.

        Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

        fullscreen javascript bindings not implemented for v8
        https://bugs.webkit.org/show_bug.cgi?id=44797

        Tested by the existing fullscreen Layout Tests.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
2011-02-24  David Dorwin  <ddorwin@chromium.org>

        Reviewed by Eric Seidel.

        Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

        fullscreen javascript bindings not implemented for v8
        https://bugs.webkit.org/show_bug.cgi?id=44797

        * features.gypi:
        * public/WebSettings.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullScreenForElement):
        (WebKit::ChromeClientImpl::enterFullScreenForElement):
        (WebKit::ChromeClientImpl::exitFullScreenForElement):
        (WebKit::ChromeClientImpl::fullScreenRendererChanged):
        * src/ChromeClientImpl.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setFullScreenEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Feb 2011 17:53:56 +0000 (17:53 +0000)]
2011-02-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
        https://bugs.webkit.org/show_bug.cgi?id=55131

        * http/tests/inspector/inspector-test.js:
        * inspector/elements/dom-agent-query-selector-expected.txt: Added.
        * inspector/elements/dom-agent-query-selector.html: Added.
2011-02-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs.
        https://bugs.webkit.org/show_bug.cgi?id=55131

        Test: inspector/elements/dom-agent-query-selector.html

        * inspector/Inspector.idl:
        * inspector/InspectorCSSAgent.cpp:
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::nodeToSelectOn):
        (WebCore::InspectorDOMAgent::querySelector):
        (WebCore::InspectorDOMAgent::querySelectorAll):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
        (WebInspector.CSSStyleModel.prototype.setRuleSelector):
        (WebInspector.CSSStyleModel.prototype.addRule.callback):
        (WebInspector.CSSStyleModel.prototype.addRule):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 24 Feb 2011 17:50:08 +0000 (17:50 +0000)]
2011-02-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Remove obsolete PLATFORM(CI)
        https://bugs.webkit.org/show_bug.cgi?id=55082

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla...
alex@webkit.org [Thu, 24 Feb 2011 17:41:25 +0000 (17:41 +0000)]
2011-02-24   Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement WebEventFactory, WebErrors classes for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=48510

        Exported static functions for GTK, we need them to create events
        in WebKit2.

        * platform/PlatformKeyboardEvent.h:
        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode):
        (WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode):
        (WebCore::PlatformKeyboardEvent::singleCharacterString):

2011-02-24   Amruth Raj  <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement WebEventFactory, WebErrors classes for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=48510

        * GNUmakefile.am:
        * Shared/gtk/WebEventFactory.cpp: Added. implementation for
        WebMouseEvent, WebWheelEvent, WebKeyboardEvent.
        * Shared/gtk/WebEventFactory.h: Added.
        * WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: Added. Stubbed
        implementation for GTK port.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 24 Feb 2011 17:38:09 +0000 (17:38 +0000)]
2011-02-24  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Remove the GFile GOwnPtr specialization
        https://bugs.webkit.org/show_bug.cgi?id=55154

        Remove the GFile specialization of GOwnPtr. It's sufficient to use GRefPtr
        to track GFiles since they are just regular reference-counted GObjects.

        * wtf/gobject/GOwnPtr.cpp: Remove GFile specialization.
        * wtf/gobject/GOwnPtr.h: Ditto.
2011-02-24  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Remove the GFile GOwnPtr specialization
        https://bugs.webkit.org/show_bug.cgi?id=55154

        Convert uses of GOwnPtr<GFile> to GRefPtr<GFile>.

        No new tests. This should not change behavior.

        * plugins/gtk/PluginPackageGtk.cpp: Fix include order and remove unnecessary include.
        (WebCore::PluginPackage::load): Use GRefPtr for GFile instead of GOwnPtr.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows XP test results after r78846
aroben@apple.com [Thu, 24 Feb 2011 17:37:47 +0000 (17:37 +0000)]
Update Windows XP test results after r78846

* platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
* platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 24 Feb 2011 17:33:43 +0000 (17:33 +0000)]
2011-02-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(SKIA) to USE(SKIA)
        https://bugs.webkit.org/show_bug.cgi?id=55090

        * wtf/Platform.h:
2011-02-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(SKIA) to USE(SKIA)
        https://bugs.webkit.org/show_bug.cgi?id=55090

        * config.h: Removed second define of PLATFORM(SKIA).
        * html/HTMLCanvasElement.cpp:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/Gradient.cpp:
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.cpp:
        * platform/graphics/Pattern.h:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/GLES2Canvas.cpp:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        * platform/graphics/chromium/LayerChromium.cpp:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        * platform/graphics/chromium/ShaderChromium.h:
        * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
        * platform/graphics/transforms/AffineTransform.h:
        * platform/graphics/transforms/TransformationMatrix.h:
        * platform/image-decoders/ImageDecoder.cpp:
        * platform/image-decoders/ImageDecoder.h:
        * rendering/svg/RenderSVGResourceSolidColor.cpp:
2011-02-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Rename PLATFORM(SKIA) to USE(SKIA)
        https://bugs.webkit.org/show_bug.cgi?id=55090

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
        * src/GraphicsContext3DInternal.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::doPixelReadbackToCanvas):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 24 Feb 2011 17:33:24 +0000 (17:33 +0000)]
2011-02-24  Alejandro G. Castro  <alex@igalia.com>

        Rubber-stamped by Martin Robinson.

        Fixed compilation after r79537, added a bug to solve webkit2
        translations:
        https://bugs.webkit.org/show_bug.cgi?id=55153

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Feb 2011 17:29:46 +0000 (17:29 +0000)]
2011-02-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: follow up to 79566. USE_PARAM not declared
        https://bugs.webkit.org/show_bug.cgi?id=55155

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
commit-queue@webkit.org [Thu, 24 Feb 2011 17:20:40 +0000 (17:20 +0000)]
2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] add android 2.2 user agent to QtTestBrowser
        https://bugs.webkit.org/show_bug.cgi?id=55085

        Credit to Forrest Hodgkins to find right user-agent which works for youtube.
        * QtTestBrowser/useragentlist.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 24 Feb 2011 16:59:12 +0000 (16:59 +0000)]
2011-02-24  Emil A Eklund  <eae@chromium.org>

        Reviewed by Simon Fraser.

        Add support for missing properties to getComputedStyle
        https://bugs.webkit.org/show_bug.cgi?id=23668

        Test getComputedStyle for the content, counter and outline-offset
        properties.

        * fast/css/getComputedStyle/computed-style-properties-expected.txt: Added.
        * fast/css/getComputedStyle/computed-style-properties.html: Added.
2011-02-24  Emil A Eklund  <eae@chromium.org>

        Reviewed by Simon Fraser.

        Add support for missing properties to getComputedStyle
        https://bugs.webkit.org/show_bug.cgi?id=23668

        Implement getComputedStyle for the content, counter and outline-offset
        properties.

        Test: fast/css/getComputedStyle/computed-style-properties.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::contentToCSSValue):
        (WebCore::counterToCSSValue):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):
        * css/CSSPrimitiveValue.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange FrameLoadDelegate to support any number of delegates with delayed work to...
aroben@apple.com [Thu, 24 Feb 2011 16:56:56 +0000 (16:56 +0000)]
Change FrameLoadDelegate to support any number of delegates with delayed work to process

This makes our behavior match Mac more closely, and allows us to remove an incorrect
assertion that was firing during some tests. (The assertion was claiming that there was
never more than one delegate with delayed work to process, but that was not the case.)

Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
when running http/tests/navigation/back-twice-without-commit.html

Reviewed by Eric Carlson.

* DumpRenderTree/win/FrameLoadDelegate.cpp:
(delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
process. A single delegate may appear in this Vector more than once (just as, on Mac, a
single delegate may have multiple performSelector requests).
(processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
assertion that the timer firing is the shared process work timer. Instead of using the
single, global "delegate waiting for timer" delegate, give all delegates that have delayed
work to process a chance to process their work.
(FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
Vector so our processWork function will be called when the timer fires.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 24 Feb 2011 16:44:32 +0000 (16:44 +0000)]
2011-02-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        SegmentedString does not need an m_composite member
        https://bugs.webkit.org/show_bug.cgi?id=55083

        Storing m_composite as distinct from m_substrings.isEmpty()
        was just error prone and eventually going to get us in trouble.

        I also cleaned up some of the style in SegementedString.*
        since this file long predates check-webkit-style.

        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::SegmentedString):
        (WebCore::SegmentedString::operator=):
        (WebCore::SegmentedString::length):
        (WebCore::SegmentedString::setExcludeLineNumbers):
        (WebCore::SegmentedString::clear):
        (WebCore::SegmentedString::append):
        (WebCore::SegmentedString::prepend):
        (WebCore::SegmentedString::advanceSubstring):
        (WebCore::SegmentedString::toString):
        * platform/text/SegmentedString.h:
        (WebCore::SegmentedSubstring::SegmentedSubstring):
        (WebCore::SegmentedSubstring::appendTo):
        (WebCore::SegmentedString::SegmentedString):
        (WebCore::SegmentedString::isComposite):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBUILD FIX: Add missing include for UnusedParam.h
ddkilzer@apple.com [Thu, 24 Feb 2011 16:40:14 +0000 (16:40 +0000)]
BUILD FIX: Add missing include for UnusedParam.h

Not reviewed.

* platform/mac/FileSystemMac.mm: Add include.  It should have
originally been added with r76614.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 16:26:13 +0000 (16:26 +0000)]
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        No new tests. (no code affected, just exporting a method for DumpRenderTree use)

        * WebCore.exp.in:
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFrame.

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::clearOpener):
        * src/WebFrameImpl.h:
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportGTK.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFramePrivate.

        * WebView/WebFrame.mm:
        (-[WebFrame _clearOpener]):
        * WebView/WebFramePrivate.h:
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportQT.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to IWebFramePrivate.
        Touched WebKit.idl to trigger build scripts.

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        (WebFrame::clearOpener):
        * WebFrame.h:
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WKBundleWebFramePrivate.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameClearOpener):
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener() calls between tests.
        Some tests are using window.open() to change current window location.
        This changes window.opener property whose nullity is checked before
        showing xml viewer.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 24 Feb 2011 16:22:46 +0000 (16:22 +0000)]
2011-02-24  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        Removing a SVG animation target during animation crashes WebKit
        https://bugs.webkit.org/show_bug.cgi?id=12065

        SVGAnimations with IRI references via 'xlink:href' are slow
        https://bugs.webkit.org/show_bug.cgi?id=49437

        Test that WebKit does not crash, if the target element of a SVG animation gets removed, or if
        its id changed.

        * platform/mac/svg/custom/animate-target-id-changed-expected.checksum: Added.
        * platform/mac/svg/custom/animate-target-id-changed-expected.png: Added.
        * platform/mac/svg/custom/animate-target-id-changed-expected.txt: Added.
        * platform/mac/svg/custom/animate-target-removed-from-document-expected.checksum: Added.
        * platform/mac/svg/custom/animate-target-removed-from-document-expected.png: Added.
        * platform/mac/svg/custom/animate-target-removed-from-document-expected.txt: Added.
        * svg/custom/animate-target-id-changed.svg: Added.
        * svg/custom/animate-target-removed-from-document.svg: Added.
2011-02-24  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        Removing a SVG animation target during animation crashes WebKit
        https://bugs.webkit.org/show_bug.cgi?id=12065

        SVGAnimations with IRI references via 'xlink:href' are slow
        https://bugs.webkit.org/show_bug.cgi?id=49437

        Store reference to target element for SVG animation elements. This is important if the
        target gets referenced via 'xlink:href'. At the moment we would call getElementById() multiple
        times on every animation step. A very expensive operation. This will be avoided with this patch.
        On the other hand, we need to be sure that the target element is always valid. The reference is
        reset, if the target was removed from document or its destructor was called. A HashMap in
        SVGDocumentExtensions stores all mappings from target element to all current animation elements.

        Tests: svg/custom/animate-target-id-changed.svg
               svg/custom/animate-target-removed-from-document.svg

        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
        (WebCore::SVGDocumentExtensions::addAnimationElementToTarget): New animation gets applied to target.
        (WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget): Animation stoped, remove it from HashMap.
        (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget): Target no longer in document, reset all
        references in SVG animation elements.
        * svg/SVGDocumentExtensions.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::~SVGElement):
        (WebCore::SVGElement::removedFromDocument):
        (WebCore::SVGElement::attributeChanged):
        * svg/SVGElement.h:
        * svg/SVGHKernElement.cpp:
        (WebCore::SVGHKernElement::removedFromDocument):
        * svg/SVGVKernElement.cpp:
        (WebCore::SVGVKernElement::removedFromDocument):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::SVGSMILElement):
        (WebCore::SVGSMILElement::removedFromDocument):
        (WebCore::SVGSMILElement::eventBaseFor):
        (WebCore::SVGSMILElement::targetElement):
        * svg/animation/SVGSMILElement.h:
        (WebCore::SVGSMILElement::resetTargetElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 24 Feb 2011 16:12:07 +0000 (16:12 +0000)]
2011-02-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel.

        REGRESSION: Accelerated transitions are jumpy
        https://bugs.webkit.org/show_bug.cgi?id=55022

        When an accelerated transition used the default timing function,
        a typo in toCAMediaTimingFunction() resulting in the incorrect
        timing function being used.

        Test: transitions/default-timing-function.html

        * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
        (toCAMediaTimingFunction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 24 Feb 2011 16:09:18 +0000 (16:09 +0000)]
2011-02-24  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove bogus optimizations in TextBreakIteratorQt
        https://bugs.webkit.org/show_bug.cgi?id=55139

        Let QTextBoundaryFinder hold a deep copy of the string data it's
        operating on, and don't use the same working buffer for all iterators.

        * platform/text/qt/TextBreakIteratorQt.cpp:
        (WebCore::TextBreakIterator::TextBreakIterator):
        (WebCore::setUpIterator):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Thu, 24 Feb 2011 16:05:03 +0000 (16:05 +0000)]
2011-02-24  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Bug in the highlighter
        https://bugs.webkit.org/show_bug.cgi?id=54876

        Fixing two bugs: 1) When restoring the state from a successful updateHighlight() call, we should restore the old state only if it is greater (closer to the end) than the current one.
        2) When a long line is being highlighted in more than one chunk (timer tick), we wrongly deleted the result of the work done in the previous tick, rather than updating it with the new results.

        * inspector/editor/highlighter-long-line-expected.txt: Added.
        * inspector/editor/highlighter-long-line.html: Added.
        * inspector/editor/highlighter-paste-in-comment-expected.txt: Added.
        * inspector/editor/highlighter-paste-in-comment.html: Added.
        * inspector/editor/highlighter-test.js: Added.
        (initialize_HighlighterTests.InspectorTest.dumpTextModel):
        (initialize_HighlighterTests):
2011-02-24  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Bug in the highlighter
        https://bugs.webkit.org/show_bug.cgi?id=54876

        Tests: inspector/editor/highlighter-long-line.html
               inspector/editor/highlighter-paste-in-comment.html

        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        (WebInspector.TextEditorHighlighter.prototype.set highlightChunkLimit):
        (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
        (WebInspector.TextEditorHighlighter.prototype._highlightLines):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 24 Feb 2011 15:51:13 +0000 (15:51 +0000)]
2011-02-24  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
        https://bugs.webkit.org/show_bug.cgi?id=55068

        * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Expect navStart and unload to be zero.
        * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Expect navStart to be zero.
        * http/tests/misc/webtiming-origins-expected.txt:
2011-02-24  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect
        https://bugs.webkit.org/show_bug.cgi?id=55068

        Test: http/tests/misc/webtiming-origins.html

        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect.
        (WebCore::PerformanceTiming::unloadEventStart): Ditto.
        (WebCore::PerformanceTiming::unloadEventEnd): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 24 Feb 2011 15:49:31 +0000 (15:49 +0000)]
2011-02-24  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove pthreads dependecy for JSLock
        https://bugs.webkit.org/show_bug.cgi?id=54832

        JSLock is only needed to support an obsolete execution model where JavaScriptCore
        automatically protected against concurrent access from multiple threads.
        So it's safe to disable it on non-mac platforms where we don't have native pthreads.

        * runtime/JSLock.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 15:49:15 +0000 (15:49 +0000)]
2011-02-24  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
        https://bugs.webkit.org/show_bug.cgi?id=54516

        Give Chromium's NetworkStateNotifier the ability to change the value
        of m_isOnLine, rather than making it always true.

        No new tests, not sure how to test this. No other LayoutTests seem
        to exercise navigator.onLine.

        * WebCore.gypi:
        * platform/network/NetworkStateNotifier.cpp:
        (WebCore::NetworkStateNotifier::setOnLine): Moved and renamed from NetworkStateNotifierAndroid.
        * platform/network/NetworkStateNotifier.h:
        (WebCore::NetworkStateNotifier::networkStateChange): Forward to setOnLine.
        * platform/network/android/NetworkStateNotifierAndroid.cpp: Removed.
        * platform/network/chromium/NetworkStateNotifierChromium.cpp: Removed.
        * platform/network/chromium/NetworkStateNotifierPrivate.h: Removed.
2011-02-24  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier
        https://bugs.webkit.org/show_bug.cgi?id=54516

        Add a new WebNetworkStateNotifier class with a single static method,
        setOnLine(), which dispatches to WebCore's singleton NetworkStateNotifier.

        * WebKit.gyp:
        * public/WebNetworkStateNotifier.h: Added.
        * src/WebNetworkStateNotifier.cpp: Added.
        (WebKit::WebNetworkStateNotifier::setOnLine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Thu, 24 Feb 2011 15:21:50 +0000 (15:21 +0000)]
2011-02-24  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Eric Seidel.

        Support building WebKit with Python 3
        https://bugs.webkit.org/show_bug.cgi?id=55038

        Add support for Python 3 without breaking support for Python 2.

        Main issues:
        -print is a function in Python 3
        -list.sort() no longer have the cmp parameter
        -string.uppercase and string.lowercase have been removed

        * html/parser/create-html-entity-table:
2011-02-24  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Eric Seidel.

        Support building WebKit with Python 3
        https://bugs.webkit.org/show_bug.cgi?id=55038

        Update the generator scripts to support Python 3.

        * Scripts/generate-message-receiver.py: print is a function in Python 3, write the output to
        sys.stdout to be compatible with Python 2 and 3.
        * Scripts/generate-messages-header.py:
        * Scripts/webkit2/messages.py: dist.iteritems does not exist in Python 3, fallback
          to dict.items which is common to Python 2 and 3.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefi...
aroben@apple.com [Thu, 24 Feb 2011 15:15:59 +0000 (15:15 +0000)]
Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am

Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
but did

Reviewed by Anders Carlsson.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added some more tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 24 Feb 2011 15:12:35 +0000 (15:12 +0000)]
2011-02-24  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix bad expectation for new test added in r79555.

        * inspector/debugger/scripts-panel-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Thu, 24 Feb 2011 14:56:19 +0000 (14:56 +0000)]
2011-02-24  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Eric Seidel.

        AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
        https://bugs.webkit.org/show_bug.cgi?id=55049

        * platform/mac/accessibility/math-alttext-expected.txt: Added.
        * platform/mac/accessibility/math-alttext.html: Added.
2011-02-24  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Eric Seidel.

        AX: WebKit should expose MathML at least as well as it exposes ARIA role="math"
        https://bugs.webkit.org/show_bug.cgi?id=55049

        Make <math> elements behave as ARIA math roles and use MathML::alttext as a
        possible accessible label.

        Test: platform/mac/accessibility/math-alttext.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        * mathml/mathattrs.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 24 Feb 2011 14:51:52 +0000 (14:51 +0000)]
2011-02-24  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: adjust protocol message format according to spec.
        https://bugs.webkit.org/show_bug.cgi?id=55140

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows Production build fix
aroben@apple.com [Thu, 24 Feb 2011 14:48:47 +0000 (14:48 +0000)]
Windows Production build fix

* platform/network/cf/AuthenticationCF.cpp: Add an extra #include as a workaround for
<rdar://problem/9042114>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Feb 2011 14:43:25 +0000 (14:43 +0000)]
2011-02-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
        https://bugs.webkit.org/show_bug.cgi?id=55057

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.runTestSuite.runner):
        (initialize_InspectorTest.InspectorTest.runTestSuite):
        * inspector/console/command-line-api-inspect-expected.txt: Added.
        * inspector/console/command-line-api-inspect.html: Added.
2011-02-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor inspect() workflow so that it did not push dom nodes.
        https://bugs.webkit.org/show_bug.cgi?id=55057

        Test: inspector/console/command-line-api-inspect.html

        I am working on getting rid of DOM agent pushes - everything should happen upon
        front-end request. This patch changes the way we handle inspect() command line
        api: instead of pushing nodes, we are telling front-end that inspect(object) has
        been requested. It is then up to front-end to request dom nodes and focus them in
        the tree. I also made inspect() work in a generic manner, using same routines for
        nodes, databases, storages and potentially new elements.

        As a side-effect, we don't do console.log from within inspect() anymore, but dump
        inspected value as inspect's result.

        Also, I added individual object release method and made object groups optional.

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::scriptValueAsNode):
        (WebCore::InjectedScriptHost::nodeAsScriptValue):
        (WebCore::JSInjectedScriptHost::inspect):
        (WebCore::JSInjectedScriptHost::databaseId):
        (WebCore::JSInjectedScriptHost::storageId):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::scriptValueAsNode):
        (WebCore::InjectedScriptHost::nodeAsScriptValue):
        (WebCore::V8InjectedScriptHost::inspectCallback):
        (WebCore::V8InjectedScriptHost::databaseIdCallback):
        (WebCore::V8InjectedScriptHost::storageIdCallback):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::nodeForObjectId):
        (WebCore::InjectedScript::releaseObject):
        (WebCore::InjectedScript::wrapForConsole):
        (WebCore::InjectedScript::inspectNode):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::inspectImpl):
        (WebCore::InjectedScriptHost::databaseIdImpl):
        (WebCore::InjectedScriptHost::storageIdImpl):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::focusNode):
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::storageId):
        (WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
        * inspector/InspectorDOMStorageAgent.h:
        * inspector/InspectorDOMStorageResource.cpp:
        * inspector/InspectorDOMStorageResource.h:
        * inspector/InspectorDatabaseAgent.cpp:
        (WebCore::InspectorDatabaseAgent::databaseId):
        * inspector/InspectorDatabaseAgent.h:
        * inspector/InspectorDatabaseResource.cpp:
        * inspector/InspectorDatabaseResource.h:
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::releaseObject):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.evaluateInTargetWindow):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        * inspector/front-end/DOMStorage.js:
        * inspector/front-end/Database.js:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
        * inspector/front-end/inspector.js:
        (WebInspector.inspect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 24 Feb 2011 14:38:14 +0000 (14:38 +0000)]
2011-02-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: refactor "script or resource" mess in scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=54961

        - Use sourceName instead of scriptOrResource
        - Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are
          calling each other recursively with small one-purpose non-recursive functions

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        (initialize_DebuggerTest.InspectorTest._showScriptSource):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.assertEquals):
        (initialize_InspectorTest.InspectorTest.safeWrap):
        * inspector/debugger/resources/script1.js: Added.
        (f1):
        * inspector/debugger/resources/script2.js: Added.
        (f2):
        * inspector/debugger/resources/script3.js: Added.
        (f3):
        * inspector/debugger/scripts-panel-expected.txt: Added.
        * inspector/debugger/scripts-panel.html: Added.
2011-02-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: refactor "script or resource" mess in scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=54961

        - Use sourceName instead of scriptOrResource
        - Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are
          calling each other recursively with small one-purpose non-recursive functions

        Test: inspector/debugger/scripts-panel.html

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
        (WebInspector.ScriptsPanel.prototype._addScript):
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded):
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype.canShowSourceLine):
        (WebInspector.ScriptsPanel.prototype.showSourceLine):
        (WebInspector.ScriptsPanel.prototype._showSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
        (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
        (WebInspector.ScriptsPanel.prototype._addItemToBackForwardList):
        (WebInspector.ScriptsPanel.prototype._sourceNameForScript):
        (WebInspector.ScriptsPanel.prototype._scriptForSourceName):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.ScriptsPanel.prototype._filesSelectChanged):
        (WebInspector.ScriptsPanel.prototype._goBack):
        (WebInspector.ScriptsPanel.prototype._goForward):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.setExecutionLine):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 24 Feb 2011 14:34:08 +0000 (14:34 +0000)]
2011-02-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Fragment parsing does not need to use HTMLSourceTracker
        https://bugs.webkit.org/show_bug.cgi?id=55011

        Remove support of XSS-filtering innerHTML content.

        * http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
2011-02-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Fragment parsing does not need to use HTMLSourceTracker
        https://bugs.webkit.org/show_bug.cgi?id=55011

        Any performance gains from this patch are likely
        the result of working around:
        https://bugs.webkit.org/show_bug.cgi?id=55005
        (Which suggests that fixing bug 55005 will speed
        up normal HTML parsing substantially.)

        Assuming I ran the numbers correct, here is the
        change from PerformanceTests/Parser/tiny-innerHTML:
        Before patch:
        avg 5586.1
        median 5594
        stdev 41.295157101045135
        min 5425
        max 5633

        After Patch:
        avg 2603.9
        median 2609.5
        stdev 32.500615378789355
        min 2475
        max 2649

        Removing just the HTMLSourceTracker calls brought our
        score from 5500 to 5200, removing the XSSFilter as well
        brought it to 2600 on my machine.

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        * html/parser/HTMLDocumentParser.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Feb 2011 14:08:32 +0000 (14:08 +0000)]
2011-02-24  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: beautified inspector test suite output.

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.runTestSuite.runner):
        (initialize_InspectorTest.InspectorTest.runTestSuite):
        * inspector/debugger/source-frame-expected.txt:
        * inspector/elements/insert-node-collapsed-expected.txt:
        * inspector/elements/insert-node-expected.txt:
        * inspector/elements/modify-chardata-expected.txt:
        * inspector/elements/remove-node-expected.txt:
        * inspector/elements/set-attribute-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Alexis Menard <alexis.menard@openbossa.org>
andreas.kling@nokia.com [Thu, 24 Feb 2011 13:44:27 +0000 (13:44 +0000)]
2011-02-24  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebView::setPalette(activeFG) fails
        https://bugs.webkit.org/show_bug.cgi?id=55029

        This time it should be the proper fix. The window needs to be shown before we
        call activateWindow() otherwise there is no active windows for the application.

        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::setPalette):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Chao-ying Fu <fu@mips.com>
commit-queue@webkit.org [Thu, 24 Feb 2011 13:25:25 +0000 (13:25 +0000)]
2011-02-24  Chao-ying Fu  <fu@mips.com>

        Reviewed by Eric Seidel.

        Fix MIPS build with new patchOffsetPut/GetByIdPropertyMapOffset1/2 values
        https://bugs.webkit.org/show_bug.cgi?id=54997

        * jit/JIT.h:
        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 13:14:06 +0000 (13:14 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping crashing test on GTK

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 13:11:57 +0000 (13:11 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium Mac test expectations update.

        fast/text/shadow-no-blur.html has been passing for a while.
        http tests have been passing since r79279.
        media/video-display-toggle.html has been passing since r79415.
        svg/text/font-size-below-point-five.svg has been passing since r78844.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Thu, 24 Feb 2011 12:58:42 +0000 (12:58 +0000)]
2011-02-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] MinGW build fails to link
        https://bugs.webkit.org/show_bug.cgi?id=55050

        Prepend the libraries of subcomponents instead of appending them
        to fix the library order according to the dependency of the libraries

        * JavaScriptCore.pri: rename addJavaScriptCore to prependJavaScriptCore
        * jsc.pro: ditto
2011-02-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] MinGW build fails to link
        https://bugs.webkit.org/show_bug.cgi?id=55050

        Prepend the libraries of subcomponents instead of appending them
        to fix the library order according to the dependency of the libraries

        * api/QtScript.pro:
2011-02-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] MinGW build fails to link
        https://bugs.webkit.org/show_bug.cgi?id=55050

        Prepend the libraries of subcomponents instead of appending them
        to fix the library order according to the dependency of the libraries

        No new tests needed.

        * WebCore.pri:
2011-02-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] MinGW build fails to link
        https://bugs.webkit.org/show_bug.cgi?id=55050

        Prepend the libraries of subcomponents instead of appending them
        to fix the library order according to the dependency of the libraries

        * QtWebKit.pro: prepend libraries in the correct order
2011-02-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] MinGW build fails to link
        https://bugs.webkit.org/show_bug.cgi?id=55050

        Prepend the libraries of subcomponents instead of appending them
        to fix the library order according to the dependency of the libraries

        * WebKit2.pri:
2011-02-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Laszlo Gombos.

        [Qt] MinGW build fails to link
        https://bugs.webkit.org/show_bug.cgi?id=55050

        Prepend the libraries of subcomponents instead of appending them
        to fix the library order according to the dependency of the libraries

        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 24 Feb 2011 12:52:29 +0000 (12:52 +0000)]
2011-02-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP's script-src should block JavaScript URLs
        https://bugs.webkit.org/show_bug.cgi?id=54787

        Test how various CSP policies affect JavaScript URLs.  We could test
        more contexts in the future, but this is a start.

        * http/tests/security/contentSecurityPolicy/javascript-url-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/javascript-url.html: Added.
        * http/tests/security/contentSecurityPolicy/resources/javascript-url.pl: Added.
2011-02-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP's script-src should block JavaScript URLs
        https://bugs.webkit.org/show_bug.cgi?id=54787

        Blocking JavaScript URLs required some re-architecting of the lifetime
        of the ContentSecurityPolicy object.  We now manage the lifetime the
        same way we manage the lifetime of the SecurityOrigin object.  In
        particular, when SecurityOrigin inherits into an about:blank iframe, we
        inherit the CSP object as well.  (This is covered by the test added in
        this patch.) In the future, we might consider making
        ContentSecurityPolicy a component of SecurityOrigin instead of a
        component of Document.

        I noted the trickiness in
        http://www.w3.org/Security/wiki/Content_Security_Policies so that we'll
        make sure it gets defined properly in the spec.

        Test: http/tests/security/contentSecurityPolicy/javascript-url.html

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * dom/Document.h:
        (WebCore::Document::contentSecurityPolicy):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        * page/ContentSecurityPolicy.h:
        (WebCore::ContentSecurityPolicy::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 12:47:40 +0000 (12:47 +0000)]
2011-02-21  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] GRefPtr support for GstElement
        https://bugs.webkit.org/show_bug.cgi?id=54870

        * CMakeListsEfl.txt:
        * GNUmakefile.am:
        * platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Added.
        (WTF::GstElement):
        * platform/graphics/gstreamer/GRefPtrGStreamer.h: Added.
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webKitWebSrcQuery):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove ARMv5 Release buildbot.
ossy@webkit.org [Thu, 24 Feb 2011 12:39:51 +0000 (12:39 +0000)]
[Qt] Remove ARMv5 Release buildbot.

Patch by Gabor Loki <loki@webkit.org> on 2011-02-24
Reviewed by Csaba Osztrogon√°c.

Remove ARMv5 Release buildbot, because there is very little difference
between ARMv5 and ARMv7 Release bots, and there is also very little
interest in ARMv5 build slave (compared to ARMv7).

* BuildSlaveSupport/build.webkit.org-config/config.json:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Thu, 24 Feb 2011 12:33:14 +0000 (12:33 +0000)]
2011-02-24  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] REGRESSION(69304): WKNativeEvent.h forwarding header is always regenerated
        https://bugs.webkit.org/show_bug.cgi?id=47589

        In case of file name clashes only generate forwarding header for the current platform.

        * Scripts/generate-forwarding-headers.pl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 24 Feb 2011 12:31:15 +0000 (12:31 +0000)]
2011-02-24  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Share code between elementFromPoint and caretRangeFromPoint in Document.
        https://bugs.webkit.org/show_bug.cgi?id=54610

        Eliminate duplicate code by moving shared logic from elementFromPoint and
        caretRangeFromPoint into helper function.

        * dom/Document.cpp:
        (WebCore::nodeFromPoint):
        (WebCore::Document::elementFromPoint):
        (WebCore::Document::caretRangeFromPoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 24 Feb 2011 11:57:03 +0000 (11:57 +0000)]
2011-02-24  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix.

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::removeAttribute):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::cachedResources):
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::evaluate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Zan Dobersek <zandobersek@gmail.com>
commit-queue@webkit.org [Thu, 24 Feb 2011 11:51:36 +0000 (11:51 +0000)]
2011-02-24  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [gtk] Failing collinear arcTo canvas tests
        https://bugs.webkit.org/show_bug.cgi?id=54658

        Enable two more tests that pass after adding collinearity check
        when drawing arcTo in canvas.

        * platform/gtk/Skipped:
2011-02-24  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [gtk] Failing collinear arcTo canvas tests
        https://bugs.webkit.org/show_bug.cgi?id=54658

        Check for collinearity of the three points that affect how arcTo call
        results. This behavior is in accordance with the HTML standard.

        No new tests added as this is already covered by at least two tests.

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::areaOfTriangleFormedByPoints):
        (WebCore::Path::addArcTo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 11:50:28 +0000 (11:50 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectations update.
        Removed tests that have been passing since r79478.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 24 Feb 2011 11:43:39 +0000 (11:43 +0000)]
2011-02-24  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: There is a validator of the protocol message format.

        It has two parts. InspectorBackendStub.js is the frontend part.
        InspectorBackendDispatcher.cpp is the backend part.
        Both parts are checking protocol message format and report the error if
        the message has not enough fields or the types of fields do not match with
        Inspector.idl specification. These validators are generated automatically.

        In addition, we have a number of places at the backend where we check the
        function arguments and do nothing if the arguments are invalid
        from the business logic point of view.

        This patch bring us an ability to report a custom error from such function to the frontend.

        https://bugs.webkit.org/show_bug.cgi?id=54971

        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScriptHost.cpp:
        * inspector/InspectorAgent.cpp:
        * inspector/InspectorAgent.h:
        * inspector/InspectorApplicationCacheAgent.cpp:
        * inspector/InspectorApplicationCacheAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorConsoleAgent.cpp:
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMStorageAgent.cpp:
        * inspector/InspectorDOMStorageAgent.h:
        * inspector/InspectorDatabaseAgent.cpp:
        * inspector/InspectorDatabaseAgent.h:
        * inspector/InspectorDebuggerAgent.cpp:
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorProfilerAgent.cpp:
        * inspector/InspectorProfilerAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        * inspector/InspectorResourceAgent.h:
        * inspector/InspectorRuntimeAgent.cpp:
        * inspector/InspectorRuntimeAgent.h:
        * inspector/InspectorTimelineAgent.cpp:
        * inspector/InspectorTimelineAgent.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 24 Feb 2011 11:25:34 +0000 (11:25 +0000)]
2011-02-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Deque<T> should support inline capacity
        https://bugs.webkit.org/show_bug.cgi?id=55032

        The title says it all.  There are currently no places
        which use this code yet, however it's been tested in conjunction
        with code for bug 55005.

        This also adds an ASSERT that capacity is never 1.  If you were able
        to set the capacity equal to 1, the Deque would just get confused
        and happily append your item but still think it had size 0.

        * wtf/Deque.h:
        (WTF::DequeIterator::DequeIterator):
        (WTF::DequeConstIterator::DequeConstIterator):
        (WTF::DequeReverseIterator::DequeReverseIterator):
        (WTF::DequeConstReverseIterator::DequeConstReverseIterator):
        (WTF::::checkValidity):
        (WTF::::checkIndexValidity):
        (WTF::::invalidateIterators):
        (WTF::::Deque):
        (WTF::deleteAllValues):
        (WTF::::operator):
        (WTF::::destroyAll):
        (WTF::::~Deque):
        (WTF::::swap):
        (WTF::::clear):
        (WTF::::findIf):
        (WTF::::expandCapacityIfNeeded):
        (WTF::::expandCapacity):
        (WTF::::takeFirst):
        (WTF::::append):
        (WTF::::prepend):
        (WTF::::removeFirst):
        (WTF::::remove):
        (WTF::::addToIteratorsList):
        (WTF::::removeFromIteratorsList):
        (WTF::::DequeIteratorBase):
        (WTF::::~DequeIteratorBase):
        (WTF::::isEqual):
        (WTF::::increment):
        (WTF::::decrement):
        (WTF::::after):
        (WTF::::before):
        * wtf/Vector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] webkitgtk 1.3.7 build without translations
christian@webkit.org [Thu, 24 Feb 2011 11:22:00 +0000 (11:22 +0000)]
[GTK] webkitgtk 1.3.7 build without translations
https://bugs.webkit.org/show_bug.cgi?id=50612

Rubber-stamped by Eric Seidel.

* GNUmakefile.am: Require stamp-po target for all-local so
    that po files are built before they install.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 11:09:14 +0000 (11:09 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        Crash when deleting inside a blockquote with a large offset
        https://bugs.webkit.org/show_bug.cgi?id=55098

        The bug was caused by inconsistency in lineBreakExistsAtPosition and breakOutOfEmptyMailBlockquotedParagraph.
        While lineBreakExistsAtPosition was checking that a line break exists at the downstream of the given position,
        breakOutOfEmptyMailBlockquotedParagraph wasn't using the downstream for caretPos. Fixed the bug by using
        the downstream position to instantiate caretPos.

        Co-author: Abhishek Arya <inferno@chromium.org>.

        Test: editing/deleting/delete-blockquote-large-offsets.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        Crash when deleting inside a blockquote with a large offset
        https://bugs.webkit.org/show_bug.cgi?id=55098

        Added a test to ensure WebKit doesn't crash when deleting line inside a blockquote
        and the caret is programmatically set to have a large offset.

        Co-author: Abhishek Arya <inferno@chromium.org>.

        * editing/deleting/delete-blockquote-large-offsets-expected.txt: Added.
        * editing/deleting/delete-blockquote-large-offsets.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 24 Feb 2011 11:03:40 +0000 (11:03 +0000)]
2011-02-24  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectations.txt update

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Robert Kroeger <rjkroege@chromium.org>
commit-queue@webkit.org [Thu, 24 Feb 2011 10:57:28 +0000 (10:57 +0000)]
2011-02-24  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Darin Fisher.

        Added timestamps to PlatformTouchEvent etc.

        PlatformTouchEvent doesn't have a timestamp and so
        eventSender.leapForward cannot be used for touchevent based tests.
        This change adds a timestamp to PlatformTouchEvent and initializes
        it in a reasonable manner on Android and Qt platforms.

        [chromium] [WebCore] [android] Touch events are missing time stamps
        https://bugs.webkit.org/show_bug.cgi?id=53510

        * platform/PlatformTouchEvent.h:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
        (WebCore::PlatformTouchEvent::timestamp):
        * platform/android/PlatformTouchEventAndroid.cpp:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
        * platform/qt/PlatformTouchEventQt.cpp:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2011-02-24  Robert Kroeger <rjkroege@chromium.org>

        Reviewed by Darin Fisher.

        Added timestamps to PlatformTouchEvent etc.

        PlatformTouchEvent doesn't have a timestamp and so
        eventSender.leapForward cannot be used for touchevent based tests.
        This change constructs PlatformTouchEvents with timestamps
        provided from a WebTouchEvent on chromium. It also adds an enum
        to make code referring to specific WebTouchPoints easier to read.

        [chromium] [WebCore] [android] Touch events are missing time stamps
        https://bugs.webkit.org/show_bug.cgi?id=53510

        * public/WebTouchPoint.h:
        (WebKit::WebTouchPoint::WebTouchPoint):
        * src/WebInputEventConversion.cpp:
        (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 24 Feb 2011 10:49:22 +0000 (10:49 +0000)]
2011-02-24  Andreas Kling  <kling@webkit.org>

        Unreviewed Qt rebaseline.

        * platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 10:36:55 +0000 (10:36 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Mac rebaselines for r79490 and r79493.

        * fast/repaint/text-emphasis-h-expected.txt:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 10:24:26 +0000 (10:24 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskip 2 fixed SVG tests on GTK after r79530.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed GTK, Snow Leopard build fix for r79474.
reni@webkit.org [Thu, 24 Feb 2011 10:21:17 +0000 (10:21 +0000)]
Unreviewed GTK, Snow Leopard build fix for r79474.

* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::setKernelUnitLength):
* platform/graphics/filters/FEConvolveMatrix.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 24 Feb 2011 10:18:01 +0000 (10:18 +0000)]
2011-02-24 MORITA Hajime  <morrita@google.com>

        Unreviewed skipping failing tests. (r79517 removed too many.)

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 10:12:50 +0000 (10:12 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
        canvas/philip/tests/2d.imageData.object.wrap.html on GTK.

        They were passing before r79501.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 24 Feb 2011 10:00:14 +0000 (10:00 +0000)]
2011-02-24  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; skip canvas/philip/tests/2d.imageData.object.round.html and
        canvas/philip/tests/2d.imageData.object.wrap.html on Mac.

        It was removed from the skipped list in r64156 but it wasn't added back
        when r79501 reverted it.

        * platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 24 Feb 2011 09:34:15 +0000 (09:34 +0000)]
2011-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        Use IntRect instead of a pointer to a GtkAllocation struct to avoid
        unnecessary memory allocations.

        * plugins/PluginView.h:
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):
        (WebCore::PluginView::plugAddedCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 09:30:09 +0000 (09:30 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky media test on GTK.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 24 Feb 2011 09:05:39 +0000 (09:05 +0000)]
2011-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix the build with GTK+ 3.

        * plugins/PluginView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 24 Feb 2011 08:55:57 +0000 (08:55 +0000)]
2011-02-24  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping 2 GTK+ SVG crashing tests.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79523 268f45cc-cd09-0410-ab3c-d52691b4dbfc