WebKit.git
9 years agoReverted r81319.
mitz@apple.com [Fri, 29 Apr 2011 04:12:02 +0000 (04:12 +0000)]
Reverted r81319.

Rubber-stamped by Mark Rowe.

Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu

* page/NavigatorBase.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 29 Apr 2011 04:07:33 +0000 (04:07 +0000)]
2011-04-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dirk Schulze.

        1px box-shadow looks ugly
        https://bugs.webkit.org/show_bug.cgi?id=58100
        and
        ShadowBlur incorrectly handles zero-sized blur radius in one axis
        https://bugs.webkit.org/show_bug.cgi?id=59710

        blurLayerImage() has issues at the edges if the blur radius
        is one, so in that case bump the buffer size out by a pixel.
        This results in a correct, symmetrical blur.

        Also fix an issue noticed during testing where a zero
        height or width radius would still blur on that axis,
        because we clamp the kernel size to a minimum of two.

        Test: fast/box-shadow/single-pixel-shadow.html

        * platform/graphics/ShadowBlur.h:
        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::blurLayerImage):
        Skip horizontal or vertial passes if the radius on that axis is zero.
        Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
        clause to the end of the loop, since it only needs to execute once
        after the first pass.
        (WebCore::ShadowBlur::blurredEdgeSize):
        New method to compute the width of the blurred edge (radius + extra
        pixel when necessary).
        (WebCore::ShadowBlur::calculateLayerBoundingRect):
        (WebCore::ShadowBlur::templateSize):
        (WebCore::ShadowBlur::drawRectShadow):
        (WebCore::ShadowBlur::drawInsetShadow):
        (WebCore::ShadowBlur::drawInsetShadowWithTiling):
        (WebCore::ShadowBlur::drawRectShadowWithTiling):
        (WebCore::ShadowBlur::drawLayerPieces):
        Use the result of blurredEdgeSize() rather than recomputing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip all fast/dom/shadow tests on Mac
aroben@apple.com [Fri, 29 Apr 2011 04:04:08 +0000 (04:04 +0000)]
Skip all fast/dom/shadow tests on Mac

They seem to be causing later tests to crash. See <http://webkit.org/b/59571>.

* platform/mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 29 Apr 2011 03:43:55 +0000 (03:43 +0000)]
2011-04-28  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Roben.

        add Leopard NRWT bot to the scheduler
        https://bugs.webkit.org/show_bug.cgi?id=59766

        * BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Fri, 29 Apr 2011 03:36:08 +0000 (03:36 +0000)]
2011-04-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Beth Dakin.

        CSS sibling selector (~) does not work with :target pseudo class
        https://bugs.webkit.org/show_bug.cgi?id=26539

        * fast/css/pseudo-target-indirect-sibling-001-expected.txt: Added.
        * fast/css/pseudo-target-indirect-sibling-001.html: Added.
        * fast/css/pseudo-target-indirect-sibling-002-expected.txt: Added.
        * fast/css/pseudo-target-indirect-sibling-002.html: Added.
2011-04-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Beth Dakin.

        CSS sibling selector (~) does not work with :target pseudo class
        https://bugs.webkit.org/show_bug.cgi?id=26539

        Allow style recalculation of forward siblings of elements with
        forward positional rules.

        Tests: fast/css/pseudo-target-indirect-sibling-001.html
               fast/css/pseudo-target-indirect-sibling-002.html

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Kamil Blank <k.blank@samsung.com>
commit-queue@webkit.org [Fri, 29 Apr 2011 03:33:51 +0000 (03:33 +0000)]
2011-04-28  Kamil Blank  <k.blank@samsung.com>

        Reviewed by Antonio Gomes.

        New API for executing Editor Commands: InsertText, InsertImage.
        https://bugs.webkit.org/show_bug.cgi?id=54439

        * ewk/ewk_view.cpp:
        (_ewk_view_editor_command): Added value parameter.
        (ewk_view_execute_editor_command): Added.
        * ewk/ewk_view.h: New API added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix WebKitTestRunner build.
weinig@apple.com [Fri, 29 Apr 2011 03:32:57 +0000 (03:32 +0000)]
Fix WebKitTestRunner build.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
The Derived Sources target needs a product name.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 29 Apr 2011 03:24:05 +0000 (03:24 +0000)]
2011-04-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Install testapi.js along side testapi
        https://bugs.webkit.org/show_bug.cgi?id=59773

        * JavaScriptCore.xcodeproj/project.pbxproj:
        Add new build phase to copy testapi.js to install path of testapi
        on install.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Fri, 29 Apr 2011 03:19:33 +0000 (03:19 +0000)]
2011-04-28  Nat Duca  <nduca@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
        https://bugs.webkit.org/show_bug.cgi?id=59626

        * platform/graphics/chromium/Extensions3DChromium.h:
        (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
2011-04-28  Nat Duca  <nduca@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
        https://bugs.webkit.org/show_bug.cgi?id=59626

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersCompleteCallbackCHROMIUM::~WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
        (WebKit::WebGraphicsContext3D::setSwapBuffersCompleteCallbackCHROMIUM):
        * src/Extensions3DChromium.cpp:
        (WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::SwapBuffersCompleteCallbackAdapter::~SwapBuffersCompleteCallbackAdapter):
        (WebCore::SwapBuffersCompleteCallbackAdapter::SwapBuffersCompleteCallbackAdapter):
        (WebCore::SwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
        (WebCore::SwapBuffersCompleteCallbackAdapter::create):
        (WebCore::GraphicsContext3DInternal::setSwapBuffersCompleteCallbackCHROMIUM):
        * src/GraphicsContext3DInternal.h:
        * src/WebViewImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 29 Apr 2011 02:34:57 +0000 (02:34 +0000)]
2011-04-28  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. More flakiness.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Fri, 29 Apr 2011 02:28:07 +0000 (02:28 +0000)]
2011-04-28  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Change chromium media controls to use absolute positioning until bug 59644 is fixed.
        https://bugs.webkit.org/show_bug.cgi?id=59732

        * platform/chromium/test_expectations.txt: Add expectations for affected tests.
2011-04-28  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Change chromium media controls to use absolute positioning until bug 59644 is fixed.
        https://bugs.webkit.org/show_bug.cgi?id=59732

        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Fri, 29 Apr 2011 02:25:12 +0000 (02:25 +0000)]
2011-04-28  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Implement CSS border width and related properties in CSSStyleApplyProperty.
        https://bugs.webkit.org/show_bug.cgi?id=59414

        No new tests as no functionality added.

        * css/CSSStyleApplyProperty.cpp:
        Separated ApplyPropertyDefault into parent and child so that other classes could inherit
        the applyInheritValue and applyInitialValue methods only.
        This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().

        Added ApplyPropertyWidth class for handling width based CSS properties.
        * css/CSSStyleSelector.cpp:
        Removed no-longer-required code for handling width based CSS properties.
        * css/CSSStyleSelector.h:
        Added a getter for m_rootElementStyle.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Fri, 29 Apr 2011 02:24:23 +0000 (02:24 +0000)]
2011-04-28  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Darin Adler.

        CSS counters in :before pseudo-elements do not always update
        https://bugs.webkit.org/show_bug.cgi?id=38291

        The previous bug was solved so just landing the test case to ensure that
        we don't regress it.

        * fast/css/counters/counter-before-content-not-incremented-expected.txt: Added.
        * fast/css/counters/counter-before-content-not-incremented.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Fri, 29 Apr 2011 02:19:58 +0000 (02:19 +0000)]
2011-04-28  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Fix silly bug with WebPermissionClient
        https://bugs.webkit.org/show_bug.cgi?id=59769

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::allowJavaScript):
        (WebKit::FrameLoaderClientImpl::allowPlugins):
        (WebKit::FrameLoaderClientImpl::allowImages):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 29 Apr 2011 02:15:32 +0000 (02:15 +0000)]
2011-04-28  Kent Tamura  <tkent@chromium.org>

        Run sort-Xcode-project-file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 29 Apr 2011 01:58:47 +0000 (01:58 +0000)]
2011-04-28  Dirk Pranke  <dpranke@chromium.org>

        Suppress GPU failures - bug 59768, and
        some fast/repaint/shadow failures that are
        probably just rebaselines.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 29 Apr 2011 01:38:55 +0000 (01:38 +0000)]
2011-04-28  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a typo in the ChangeLog entry for my previous commit
mrobinson@webkit.org [Fri, 29 Apr 2011 01:00:58 +0000 (01:00 +0000)]
Fixed a typo in the ChangeLog entry for my previous commit

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 29 Apr 2011 00:57:22 +0000 (00:57 +0000)]
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [Cairo] Text underline is not shadowed when text-shadow is enabled
        https://bugs.webkit.org/show_bug.cgi?id=48074

        Updated pixel results for this test. They were previously incorrect
        because text underlines were not shadowed.

        * platform/gtk/fast/text/stroking-decorations-expected.png:
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [Cairo] Text underline is not shadowed when text-shadow is enabled
        https://bugs.webkit.org/show_bug.cgi?id=48074

        Use ShadowContext to enable shadows for text underlines. Also remove quite a bit
        of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
        originally copied from the CG GraphicsContext.

        * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
          can call it from a static helper function.
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
        (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
        call it multiple times when shadowing text underlines.
        (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
        (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
        (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Fri, 29 Apr 2011 00:56:35 +0000 (00:56 +0000)]
Versioning.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup WebCore.xcodeproj a bit.
weinig@apple.com [Fri, 29 Apr 2011 00:54:52 +0000 (00:54 +0000)]
Cleanup WebCore.xcodeproj a bit.

Rubber-stamped by Mark Rowe.

* WebCore.xcodeproj/project.pbxproj:
Added CompilerVersion.xcconfig and moved some JS bindings files into the
correct sub groups.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 29 Apr 2011 00:54:48 +0000 (00:54 +0000)]
2011-04-28  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd install support for WebKitTestRunner.
weinig@apple.com [Fri, 29 Apr 2011 00:48:54 +0000 (00:48 +0000)]
Add install support for WebKitTestRunner.
<rdar://problem/9349055>

Reviewed by Mark Rowe.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add missing CompilerVersion.xcconfig.

* WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Add install path and tell it not to skip installation.

Add missing CompilerVersion.xcconfig.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove IMAGE_RESIZER related code.
levin@chromium.org [Fri, 29 Apr 2011 00:41:47 +0000 (00:41 +0000)]
Remove IMAGE_RESIZER related code.
https://bugs.webkit.org/show_bug.cgi?id=59735

Reviewed by Adam Barth.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* features.pri:
* html/AsyncImageResizer.cpp: Removed.
* html/AsyncImageResizer.h: Removed.
* html/ImageResizerThread.cpp: Removed.
* html/ImageResizerThread.h: Removed.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 29 Apr 2011 00:36:22 +0000 (00:36 +0000)]
2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.

        * inspector/front-end/Settings.js:
        (WebInspector.Settings):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59763
barraclough@apple.com [Fri, 29 Apr 2011 00:30:34 +0000 (00:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59763
DFG JIT - Unify FPRReg & FPRegisterID

Reviewed by Oliver Hunt.

(Following on from GPRReg/RegisterID unification).

* dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::checkConsistency):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::flushRegisters):
(JSC::DFG::JITCodeGenerator::isFlushed):
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
(JSC::DFG::JITCodeGenerator::setupStubArguments):
(JSC::DFG::JITCodeGenerator::callOperation):
(JSC::DFG::GPRResult::lockedResult):
(JSC::DFG::FPRResult::lockedResult):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::iterator::regID):
(JSC::DFG::RegisterBank::iterator::debugName):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow remote accessibility API for WK2 to build on SnowLeopard.
cfleizach@apple.com [Fri, 29 Apr 2011 00:27:00 +0000 (00:27 +0000)]
Allow remote accessibility API for WK2 to build on SnowLeopard.
<rdar://problem/9324507>

Reviewed by Maciej Stachowiak.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRolling out revision 85258! I want to fix that bug a different way.
bdakin@apple.com [Fri, 29 Apr 2011 00:19:38 +0000 (00:19 +0000)]
Rolling out revision 85258! I want to fix that bug a different way.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):

Rubber-stamped by Sam Weinig.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOriginal patch by Austin Jennings.
weinig@apple.com [Fri, 29 Apr 2011 00:11:10 +0000 (00:11 +0000)]
Original patch by Austin Jennings.

Reviewed by Gavin Barraclough.

<rdar://problem/9350288>
Update sandbox profile for extension changes

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Fri, 29 Apr 2011 00:10:34 +0000 (00:10 +0000)]
2011-04-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Eric Seidel.

        isContentEditable is not working properly with document.designMode
        https://bugs.webkit.org/show_bug.cgi?id=53031

        1. Added test cases for checking isContentEditable with designMode.
        2. Added a new test case for setting contenteditable attribute to "inherit" as the
        original code will cause a crash.
        3. Ryosuke Niwa also helped to fix test cases under editing/style that cause infinite loop.

        * editing/style/iframe-onload-crash-mac.html:
        * editing/style/iframe-onload-crash-unix.html:
        * editing/style/iframe-onload-crash-win.html:
        * fast/dom/HTMLElement/attr-invalid-string-expected.txt:
        * fast/dom/HTMLElement/attr-invalid-string.html:
        * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-expected.txt: Added.
        * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe-expected.txt: Added.
        * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html: Added.
        * fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html: Added.
        * fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor-expected.txt: Added.
        * fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html: Added.
        * fast/dom/HTMLElement/iscontenteditable-designmodeon-expected.txt: Added.
        * fast/dom/HTMLElement/iscontenteditable-designmodeon.html: Added.
2011-04-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Eric Seidel.

        isContentEditable is not working properly with document.designMode
        https://bugs.webkit.org/show_bug.cgi?id=53031

        The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
        indicates that the element.isContentEditable relies on document.designMode if its
        and its ancestors' contenteditable attributes are set to inherit.

        1. Sync document render style after document.designMode is changed.
        2. Removed the code that does unnecessary and incorrect handling for contenteditable
        attribute with "inherit" value.
        3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.

        Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
               fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
               fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
               fast/dom/HTMLElement/iscontenteditable-designmodeon.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleForDocument):
        * dom/Document.cpp:
        (WebCore::Document::setDesignMode):
        * dom/Node.cpp:
        (WebCore::Node::rendererIsEditable):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setContentEditable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Fri, 29 Apr 2011 00:06:27 +0000 (00:06 +0000)]
2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85101.
        http://trac.webkit.org/changeset/85101
        https://bugs.webkit.org/show_bug.cgi?id=59757

         it'd be better to rollout the patch and do another one with
        another property name. Current one will bring us to a problem
        at first run after upgrade because it's type was changed from
        int to string. (Requested by loislo on #webkit).

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
        (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert "<http://webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every...
ddkilzer@apple.com [Fri, 29 Apr 2011 00:03:50 +0000 (00:03 +0000)]
Revert "<webkit.org/b/59705> WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called"

This reverts commit r85195.  It was crashing DumpRenderTree on Lion.

* wtf/mac/MainThreadMac.mm:
(WTF::postTimer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Mike Reed <reed@google.com>
commit-queue@webkit.org [Thu, 28 Apr 2011 23:59:47 +0000 (23:59 +0000)]
2011-04-28  Mike Reed  <reed@google.com>

        Reviewed by Eric Seidel.

        fix shadw behavior for both CSS and Canvas
        https://bugs.webkit.org/show_bug.cgi?id=59700

        * platform/chromium/test_expectations.txt:
2011-04-28  Mike Reed  <reed@google.com>

        Reviewed by Eric Seidel.

        fix shadw behavior for both CSS and Canvas -- skia only
        https://bugs.webkit.org/show_bug.cgi?id=59700

        Test:
        canvas/philip/tests/2d.shadow.alpha.3.html
        canvas/philip/tests/2d.shadow.alpha.4.html
        canvas/philip/tests/2d.shadow.alpha.5.html
        fast/canvas/canvas-fillPath-alpha-shadow.html
        fast/canvas/canvas-strokePath-alpha-shadow.html
        fast/canvas/canvas-strokeRect-alpha-shadow.html
        fast/css/text-input-with-webkit-border-radius.html
        fast/repaint/shadow-multiple-horizontal.html
        fast/repaint/shadow-multiple-strict-horizontal.html
        fast/repaint/shadow-multiple-strict-vertical.html
        fast/repaint/shadow-multiple-vertical.html
        fast/canvas/canvas-getImageData.html

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an Accessibil...
ddkilzer@apple.com [Thu, 28 Apr 2011 23:54:35 +0000 (23:54 +0000)]
<webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper

Reviewed by Chris Fleizach.

Previously, AXObjectCache::attachWrapper over-retained each
AccessibilityObjectWrapper it created, which is why
AXObjectCache::detachWrapper() contained an extra -release.

* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::detachWrapper): Removed extra -release.
(WebCore::AXObjectCache::attachWrapper): Because setWrapper()
assigns to a RetainPtr<> instance variable, it doesn't need a +1
retained object passed in.  Fix the leak by using a RetainPtr<>
for the AccessibilityObjectWrapper.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake reading skipped files from additional platform
weinig@apple.com [Thu, 28 Apr 2011 23:53:44 +0000 (23:53 +0000)]
Make reading skipped files from additional platform
directories work in WebKit2 mode.

Reviewed by Adam Roben.

* Scripts/old-run-webkit-tests:
(buildPlatformTestHierarchy): Simplify logic to always use the first
and last platforms in the build hierarchy as the test hierarchy, and to
insert the WebKit2 platform in the middle if it exists. Yum.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 23:49:55 +0000 (23:49 +0000)]
2011-04-28  Nat Duca  <nduca@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Compute compositor fps value and history using the frameBegin timestamp
        https://bugs.webkit.org/show_bug.cgi?id=59668

        This change switches the compositor FPS meter to use the timestamp
        of the beginning of the frame rather than the time we call
        swapBuffers. When scheduling is correctly tied to vsync, we can
        have highly variable times when we finish vsync and still have
        stable frame rates.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
        (WebCore::CCHeadsUpDisplay::drawFPSCounter):
        (WebCore::CCHeadsUpDisplay::onFrameBegin):
        (WebCore::CCHeadsUpDisplay::onPresent):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 23:46:50 +0000 (23:46 +0000)]
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        fast/harness/results.html failing in some configurations
        https://bugs.webkit.org/show_bug.cgi?id=59750

        * fast/harness/resources/results-test.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 28 Apr 2011 23:44:26 +0000 (23:44 +0000)]
2011-04-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Right-clicking on a Flash movie in an iframe shows the browser context menu
        https://bugs.webkit.org/show_bug.cgi?id=59760
        <rdar://problem/9340541>

        Move context menu event handling out into a separate function. Make sure to call
        EventHandler::sendContextMenuEvent on the event handler belonging to the frame of the
        node that was clicked, and not the main frame.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::handleContextMenuEvent):
        (WebKit::handleMouseEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59759
bdakin@apple.com [Thu, 28 Apr 2011 23:36:28 +0000 (23:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59759
Overflow:scroll regions with overlay scrollbars show full thumb instead of just a
track when there is nothing to scroll to
<rdar://problem/9282066>

Reviewed by Darin Adler.

Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is
nothing to scroll to. Just dividing them to get a knob proportion yields 1, which
is not right. Set the proportion to 0 in this case instead.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9291132> Add support for -epub-prefixed properties
mitz@apple.com [Thu, 28 Apr 2011 23:36:02 +0000 (23:36 +0000)]
<rdar://problem/9291132> Add support for -epub-prefixed properties

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/epub-properties.html

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
* css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
-webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
text-transform, text-transform, word-break, and -webkit-writing-mode.

LayoutTests:

* fast/css/epub-properties-expected.txt: Added.
* fast/css/epub-properties.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 28 Apr 2011 23:28:13 +0000 (23:28 +0000)]
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        Remove WML configuration option from the CMake build system.

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmake/OptionsWinCE.cmake:
        * Source/cmakeconfig.h.cmake:
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        Remove build system integration and test harness integration for WML.

        * Scripts/build-webkit:
        * Scripts/old-run-webkit-tests:
        * Scripts/webkitperl/features.pm:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        Remove WML tests.  These tests do not appear to be run on
        build.webkit.org because none of the bots on build.webkit.org enable
        WML.

        * fast/wml: Removed.
        * fast/wml/br-element-in-table.wml: Removed.
        * fast/wml/br-element-in-text.wml: Removed.
        * fast/wml/card-element.wml: Removed.
        * fast/wml/case-sensitivity.wml: Removed.
        * fast/wml/cdata-section.wml: Removed.
        * fast/wml/comment.wml: Removed.
        * fast/wml/do-element-optional-attr.wml: Removed.
        * fast/wml/do-shadow.wml: Removed.
        * fast/wml/do-template.wml: Removed.
        * fast/wml/entity.wml: Removed.
        * fast/wml/err-event-binding-conflict.wml: Removed.
        * fast/wml/err-invalid-location-for-varref.wml: Removed.
        * fast/wml/err-invalid-tablecolumn-number.wml: Removed.
        * fast/wml/err-invalid-variable-name.wml: Removed.
        * fast/wml/err-multi-access.wml: Removed.
        * fast/wml/err-multi-http-equiv-in-meta.wml: Removed.
        * fast/wml/err-multi-name-in-meta.wml: Removed.
        * fast/wml/err-multi-timer.wml: Removed.
        * fast/wml/err-samename-do.wml: Removed.
        * fast/wml/err-unallowed-task-in-anchor.wml: Removed.
        * fast/wml/fieldset.wml: Removed.
        * fast/wml/html-fieldset-crash.html: Removed.
        * fast/wml/img-localsrc.wml: Removed.
        * fast/wml/img-src-localsrc-alt.wml: Removed.
        * fast/wml/img-src.wml: Removed.
        * fast/wml/input.wml: Removed.
        * fast/wml/p-align.wml: Removed.
        * fast/wml/p-mode.wml: Removed.
        * fast/wml/resources: Removed.
        * fast/wml/resources/fail.png: Removed.
        * fast/wml/resources/pass.png: Removed.
        * fast/wml/select.wml: Removed.
        * fast/wml/show-first-card.wml: Removed.
        * fast/wml/table-element-align-attribute-invalid.wml: Removed.
        * fast/wml/table-element-columns-attribute-invalid-number.wml: Removed.
        * fast/wml/table-element-columns-attribute-invalid.wml: Removed.
        * fast/wml/table-element-columns-attribute-missing.wml: Removed.
        * fast/wml/table-element-columns-attribute.wml: Removed.
        * fast/wml/table-element.wml: Removed.
        * fast/wml/task-noop-in-do.wml: Removed.
        * fast/wml/test.wml: Removed.
        * fast/wml/text-emphasis.wml: Removed.
        * fast/wml/validate-dtd.wml: Removed.
        * http/tests/wml: Removed.
        * http/tests/wml/access-target-domain-deny-expected.txt: Removed.
        * http/tests/wml/access-target-domain-deny.html: Removed.
        * http/tests/wml/access-target-expected.txt: Removed.
        * http/tests/wml/access-target-path-deny-expected.txt: Removed.
        * http/tests/wml/access-target-path-deny.html: Removed.
        * http/tests/wml/access-target.html: Removed.
        * http/tests/wml/go-task-get-method-accept-charset-expected.txt: Removed.
        * http/tests/wml/go-task-get-method-accept-charset.html: Removed.
        * http/tests/wml/go-task-get-method-expected.txt: Removed.
        * http/tests/wml/go-task-get-method.html: Removed.
        * http/tests/wml/go-task-post-method-accept-charset-expected.txt: Removed.
        * http/tests/wml/go-task-post-method-accept-charset.html: Removed.
        * http/tests/wml/go-task-post-method-expected.txt: Removed.
        * http/tests/wml/go-task-post-method.html: Removed.
        * http/tests/wml/post-data-to-server-expected.txt: Removed.
        * http/tests/wml/post-data-to-server.html: Removed.
        * http/tests/wml/resources: Removed.
        * http/tests/wml/resources/access-target-domain-deny.wml: Removed.
        * http/tests/wml/resources/access-target-path-deny.wml: Removed.
        * http/tests/wml/resources/access-target.wml: Removed.
        * http/tests/wml/resources/answer-utf8.cgi: Removed.
        * http/tests/wml/resources/answer.cgi: Removed.
        * http/tests/wml/resources/dumpVariables.cgi: Removed.
        * http/tests/wml/resources/locked-deck.wml: Removed.
        * http/tests/wml/resources/unreachable-domain.wml: Removed.
        * http/tests/wml/resources/unreachable-path.wml: Removed.
        * http/tests/wml/script-tests: Removed.
        * http/tests/wml/script-tests/TEMPLATE.html: Removed.
        * http/tests/wml/script-tests/access-target-domain-deny.js: Removed.
        * http/tests/wml/script-tests/access-target-path-deny.js: Removed.
        * http/tests/wml/script-tests/access-target.js: Removed.
        * http/tests/wml/script-tests/go-task-get-method-accept-charset.js: Removed.
        * http/tests/wml/script-tests/go-task-get-method.js: Removed.
        * http/tests/wml/script-tests/go-task-post-method-accept-charset.js: Removed.
        * http/tests/wml/script-tests/go-task-post-method.js: Removed.
        * http/tests/wml/script-tests/post-data-to-server.js: Removed.
        * http/tests/xmlviewer/dumpAsText/wml-expected.txt: Removed.
        * http/tests/xmlviewer/dumpAsText/wml.xml: Removed.
        * platform/mac-leopard/fast/wml: Removed.
        * platform/mac-leopard/fast/wml/html-fieldset-crash-expected.png: Removed.
        * platform/mac/fast/wml: Removed.
        * platform/mac/fast/wml/br-element-in-table-expected.png: Removed.
        * platform/mac/fast/wml/br-element-in-table-expected.txt: Removed.
        * platform/mac/fast/wml/br-element-in-text-expected.png: Removed.
        * platform/mac/fast/wml/br-element-in-text-expected.txt: Removed.
        * platform/mac/fast/wml/card-element-expected.png: Removed.
        * platform/mac/fast/wml/card-element-expected.txt: Removed.
        * platform/mac/fast/wml/case-sensitivity-expected.png: Removed.
        * platform/mac/fast/wml/case-sensitivity-expected.txt: Removed.
        * platform/mac/fast/wml/cdata-section-expected.png: Removed.
        * platform/mac/fast/wml/cdata-section-expected.txt: Removed.
        * platform/mac/fast/wml/comment-expected.png: Removed.
        * platform/mac/fast/wml/comment-expected.txt: Removed.
        * platform/mac/fast/wml/do-element-optional-attr-expected.png: Removed.
        * platform/mac/fast/wml/do-element-optional-attr-expected.txt: Removed.
        * platform/mac/fast/wml/do-shadow-expected.png: Removed.
        * platform/mac/fast/wml/do-shadow-expected.txt: Removed.
        * platform/mac/fast/wml/do-template-expected.png: Removed.
        * platform/mac/fast/wml/do-template-expected.txt: Removed.
        * platform/mac/fast/wml/entity-expected.png: Removed.
        * platform/mac/fast/wml/entity-expected.txt: Removed.
        * platform/mac/fast/wml/err-event-binding-conflict-expected.png: Removed.
        * platform/mac/fast/wml/err-event-binding-conflict-expected.txt: Removed.
        * platform/mac/fast/wml/err-invalid-location-for-varref-expected.png: Removed.
        * platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt: Removed.
        * platform/mac/fast/wml/err-invalid-tablecolumn-number-expected.png: Removed.
        * platform/mac/fast/wml/err-invalid-tablecolumn-number-expected.txt: Removed.
        * platform/mac/fast/wml/err-invalid-variable-name-expected.png: Removed.
        * platform/mac/fast/wml/err-invalid-variable-name-expected.txt: Removed.
        * platform/mac/fast/wml/err-multi-access-expected.png: Removed.
        * platform/mac/fast/wml/err-multi-access-expected.txt: Removed.
        * platform/mac/fast/wml/err-multi-http-equiv-in-meta-expected.png: Removed.
        * platform/mac/fast/wml/err-multi-http-equiv-in-meta-expected.txt: Removed.
        * platform/mac/fast/wml/err-multi-name-in-meta-expected.png: Removed.
        * platform/mac/fast/wml/err-multi-name-in-meta-expected.txt: Removed.
        * platform/mac/fast/wml/err-multi-timer-expected.png: Removed.
        * platform/mac/fast/wml/err-multi-timer-expected.txt: Removed.
        * platform/mac/fast/wml/err-samename-do-expected.png: Removed.
        * platform/mac/fast/wml/err-samename-do-expected.txt: Removed.
        * platform/mac/fast/wml/err-unallowed-task-in-anchor-expected.png: Removed.
        * platform/mac/fast/wml/err-unallowed-task-in-anchor-expected.txt: Removed.
        * platform/mac/fast/wml/fieldset-expected.png: Removed.
        * platform/mac/fast/wml/fieldset-expected.txt: Removed.
        * platform/mac/fast/wml/html-fieldset-crash-expected.png: Removed.
        * platform/mac/fast/wml/html-fieldset-crash-expected.txt: Removed.
        * platform/mac/fast/wml/img-localsrc-expected.png: Removed.
        * platform/mac/fast/wml/img-localsrc-expected.txt: Removed.
        * platform/mac/fast/wml/img-src-expected.png: Removed.
        * platform/mac/fast/wml/img-src-expected.txt: Removed.
        * platform/mac/fast/wml/img-src-localsrc-alt-expected.png: Removed.
        * platform/mac/fast/wml/img-src-localsrc-alt-expected.txt: Removed.
        * platform/mac/fast/wml/input-expected.png: Removed.
        * platform/mac/fast/wml/input-expected.txt: Removed.
        * platform/mac/fast/wml/p-align-expected.png: Removed.
        * platform/mac/fast/wml/p-align-expected.txt: Removed.
        * platform/mac/fast/wml/p-mode-expected.png: Removed.
        * platform/mac/fast/wml/p-mode-expected.txt: Removed.
        * platform/mac/fast/wml/select-expected.png: Removed.
        * platform/mac/fast/wml/select-expected.txt: Removed.
        * platform/mac/fast/wml/show-first-card-expected.png: Removed.
        * platform/mac/fast/wml/show-first-card-expected.txt: Removed.
        * platform/mac/fast/wml/table-element-align-attribute-invalid-expected.png: Removed.
        * platform/mac/fast/wml/table-element-align-attribute-invalid-expected.txt: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-expected.png: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-expected.txt: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-invalid-expected.png: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-invalid-expected.txt: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-invalid-number-expected.png: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-invalid-number-expected.txt: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-missing-expected.png: Removed.
        * platform/mac/fast/wml/table-element-columns-attribute-missing-expected.txt: Removed.
        * platform/mac/fast/wml/table-element-expected.png: Removed.
        * platform/mac/fast/wml/table-element-expected.txt: Removed.
        * platform/mac/fast/wml/task-noop-in-do-expected.png: Removed.
        * platform/mac/fast/wml/task-noop-in-do-expected.txt: Removed.
        * platform/mac/fast/wml/test-expected.png: Removed.
        * platform/mac/fast/wml/test-expected.txt: Removed.
        * platform/mac/fast/wml/text-emphasis-expected.png: Removed.
        * platform/mac/fast/wml/text-emphasis-expected.txt: Removed.
        * platform/mac/fast/wml/validate-dtd-expected.png: Removed.
        * platform/mac/fast/wml/validate-dtd-expected.txt: Removed.
        * wml: Removed.
        * wml/access-target-deny-expected.txt: Removed.
        * wml/access-target-deny.html: Removed.
        * wml/access-target-expected.txt: Removed.
        * wml/access-target.html: Removed.
        * wml/enter-card-with-events-expected.txt: Removed.
        * wml/enter-card-with-events.html: Removed.
        * wml/enter-first-card-with-events-expected.txt: Removed.
        * wml/enter-first-card-with-events.html: Removed.
        * wml/go-task-get-method-external-deck-expected.txt: Removed.
        * wml/go-task-get-method-external-deck-with-href-expected.txt: Removed.
        * wml/go-task-get-method-external-deck-with-href.html: Removed.
        * wml/go-task-get-method-external-deck.html: Removed.
        * wml/go-task-get-method-same-deck-expected.txt: Removed.
        * wml/go-task-get-method-same-deck.html: Removed.
        * wml/input-format-expected.txt: Removed.
        * wml/input-format.html: Removed.
        * wml/newcontext-same-deck-expected.txt: Removed.
        * wml/newcontext-same-deck.html: Removed.
        * wml/onenterforward-event-expected.txt: Removed.
        * wml/onenterforward-event.html: Removed.
        * wml/onenterforward-inline-event-expected.txt: Removed.
        * wml/onenterforward-inline-event.html: Removed.
        * wml/ontimer-event-expected.txt: Removed.
        * wml/ontimer-event.html: Removed.
        * wml/ontimer-inline-event-expected.txt: Removed.
        * wml/ontimer-inline-event.html: Removed.
        * wml/option-element-onpick-expected.txt: Removed.
        * wml/option-element-onpick-recursion-expected.txt: Removed.
        * wml/option-element-onpick-recursion.html: Removed.
        * wml/option-element-onpick.html: Removed.
        * wml/resources: Removed.
        * wml/resources/WMLTestCase.js: Removed.
        * wml/resources/access-target-deny.wml: Removed.
        * wml/resources/access-target.wml: Removed.
        * wml/resources/enter-card-with-events.wml: Removed.
        * wml/resources/enter-first-card-with-events.wml: Removed.
        * wml/resources/external-deck.wml: Removed.
        * wml/resources/locked-deck.wml: Removed.
        * wml/resources/newcontext-same-deck.wml: Removed.
        * wml/resources/onenterforward-event.wml: Removed.
        * wml/resources/onenterforward-inline-event.wml: Removed.
        * wml/resources/ontimer-event.wml: Removed.
        * wml/resources/ontimer-inline-event.wml: Removed.
        * wml/resources/option-element-onpick-recursion.wml: Removed.
        * wml/resources/test-document.wml: Removed.
        * wml/script-tests: Removed.
        * wml/script-tests/TEMPLATE.html: Removed.
        * wml/script-tests/access-target-deny.js: Removed.
        * wml/script-tests/access-target.js: Removed.
        * wml/script-tests/enter-card-with-events.js: Removed.
        * wml/script-tests/enter-first-card-with-events.js: Removed.
        * wml/script-tests/go-task-get-method-external-deck-with-href.js: Removed.
        * wml/script-tests/go-task-get-method-external-deck.js: Removed.
        * wml/script-tests/go-task-get-method-same-deck.js: Removed.
        * wml/script-tests/input-format.js: Removed.
        * wml/script-tests/newcontext-same-deck.js: Removed.
        * wml/script-tests/onenterforward-event.js: Removed.
        * wml/script-tests/onenterforward-inline-event.js: Removed.
        * wml/script-tests/ontimer-event.js: Removed.
        * wml/script-tests/ontimer-inline-event.js: Removed.
        * wml/script-tests/option-element-onpick-recursion.js: Removed.
        * wml/script-tests/option-element-onpick.js: Removed.
        * wml/script-tests/select-element-variables.js: Removed.
        * wml/script-tests/variable-reference-invalid-character.js: Removed.
        * wml/script-tests/variable-reference-valid.js: Removed.
        * wml/select-element-variables-expected.txt: Removed.
        * wml/select-element-variables.html: Removed.
        * wml/variable-reference-invalid-character-expected.txt: Removed.
        * wml/variable-reference-invalid-character.html: Removed.
        * wml/variable-reference-valid-expected.txt: Removed.
        * wml/variable-reference-valid.html: Removed.
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        Remove the WML configuration option from the Mac build system.

        * Configurations/FeatureDefines.xcconfig:
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        Remove WML-related enumeration.

        * Interfaces/IWebFramePrivate.idl:
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        Remove WML-related configuration options and private APIs.

        * Configurations/FeatureDefines.xcconfig:
        * WebCoreSupport/WebChromeClient.mm:
        (stringForMessageSource):
        * WebView/WebFramePrivate.h:
        * WebView/WebUIDelegatePrivate.h:
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        This patch removes WML from WebCore.  After removing WML, there's a
        bunch of twisted code that could be untwisted, but this patch contains
        only the purely mechanical part of removing the feature.

        There's been a lot of discussion on webkit-dev about whether we should
        remove WML.  In addition to those threads, we've had an informal poll
        of the reviewers as well as an in-person discussion at the WebKit
        contributor's meeting.  Removing any feature is likely to make some
        folks unhappy, but, on balance, removing WML appears to be the right
        thing for the project to do at this time.

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::linkAttribute):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        * css/wml.css: Removed.
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::createElement):
        * dom/Document.h:
        (WebCore::Document::isMediaDocument):
        * dom/Document.idl:
        * dom/InputElement.h:
        * dom/Node.cpp:
        (WebCore::Node::toInputElement):
        * dom/Node.h:
        * dom/OptionElement.cpp:
        (WebCore::toOptionElement):
        (WebCore::isOptionElement):
        * dom/OptionElement.h:
        * dom/OptionGroupElement.cpp:
        (WebCore::toOptionGroupElement):
        (WebCore::isOptionGroupElement):
        * dom/SelectElement.cpp:
        (WebCore::toSelectElement):
        * dom/SelectElement.h:
        * dom/Text.cpp:
        (WebCore::Text::attach):
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::insertErrorMessageBlock):
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::internalSubset):
        (WebCore::getEntityHandler):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parse):
        (WebCore::XMLDocumentParser::parseDtd):
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing):
        * features.pri:
        * history/BackForwardList.h:
        * history/BackForwardListImpl.cpp:
        * history/BackForwardListImpl.h:
        * history/PageCache.cpp:
        (WebCore::PageCache::canCachePageContainingThisFrame):
        * html/HTMLAnchorElement.h:
        * inspector/ConsoleMessage.cpp:
        (WebCore::messageSourceValue):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage.prototype.toString):
        * loader/FrameLoader.cpp:
        (WebCore::isBackForwardLoadType):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::shouldReload):
        (WebCore::FrameLoader::loadDifferentDocumentItem):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoaderTypes.h:
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::restoreDocumentState):
        * manual-tests/wml: Removed.
        * manual-tests/wml/StartTests.wml: Removed.
        * manual-tests/wml/a-br-element.wml: Removed.
        * manual-tests/wml/a-element.wml: Removed.
        * manual-tests/wml/a-img-element.wml: Removed.
        * manual-tests/wml/access-target.wml: Removed.
        * manual-tests/wml/anchor-br-element.wml: Removed.
        * manual-tests/wml/anchor-element.wml: Removed.
        * manual-tests/wml/anchor-img-element.wml: Removed.
        * manual-tests/wml/card-newcontext-attr.wml: Removed.
        * manual-tests/wml/card-onenterbackward.wml: Removed.
        * manual-tests/wml/card-onenterforward.wml: Removed.
        * manual-tests/wml/card-ontimer.wml: Removed.
        * manual-tests/wml/deck-access-control.wml: Removed.
        * manual-tests/wml/input-format.wml: Removed.
        * manual-tests/wml/onevent-go.wml: Removed.
        * manual-tests/wml/onevent-noop.wml: Removed.
        * manual-tests/wml/onevent-prev.wml: Removed.
        * manual-tests/wml/onevent-refresh.wml: Removed.
        * manual-tests/wml/onevent-shadow.wml: Removed.
        * manual-tests/wml/resources: Removed.
        * manual-tests/wml/resources/smiley.png: Removed.
        * manual-tests/wml/select-element.wml: Removed.
        * manual-tests/wml/select-onpick-event-crash.wml: Removed.
        * manual-tests/wml/select-onpick-event.wml: Removed.
        * manual-tests/wml/setvar-element.wml: Removed.
        * manual-tests/wml/targetdeck.wml: Removed.
        * manual-tests/wml/task-go-in-anchor.wml: Removed.
        * manual-tests/wml/task-prev-in-anchor.wml: Removed.
        * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
        * manual-tests/wml/template-go.wml: Removed.
        * manual-tests/wml/template-ontimer.wml: Removed.
        * manual-tests/wml/timer.wml: Removed.
        * manual-tests/wml/variable-substitution.wml: Removed.
        * page/Console.cpp:
        (WebCore::printMessageSourceAndLevelPrefix):
        * page/Console.h:
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        * page/Page.cpp:
        * page/Page.h:
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedNonImageMimeTypes):
        * platform/network/FormDataBuilder.h:
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        * platform/wince/MIMETypeRegistryWinCE.cpp:
        (WebCore::initMIMETypeEntensionMap):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::altDisplayString):
        (WebCore::HitTestResult::absoluteImageURL):
        (WebCore::HitTestResult::absoluteLinkURL):
        (WebCore::HitTestResult::isLiveLink):
        * rendering/RenderBox.cpp:
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::updateFromElement):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::findLegend):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::updateAltText):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::isLegend):
        (WebCore::RenderObject::offsetParent):
        * wml: Removed.
        * wml/WMLAElement.cpp: Removed.
        * wml/WMLAElement.h: Removed.
        * wml/WMLAccessElement.cpp: Removed.
        * wml/WMLAccessElement.h: Removed.
        * wml/WMLAnchorElement.cpp: Removed.
        * wml/WMLAnchorElement.h: Removed.
        * wml/WMLAttributeNames.in: Removed.
        * wml/WMLBRElement.cpp: Removed.
        * wml/WMLBRElement.h: Removed.
        * wml/WMLCardElement.cpp: Removed.
        * wml/WMLCardElement.h: Removed.
        * wml/WMLDoElement.cpp: Removed.
        * wml/WMLDoElement.h: Removed.
        * wml/WMLDocument.cpp: Removed.
        * wml/WMLDocument.h: Removed.
        * wml/WMLElement.cpp: Removed.
        * wml/WMLElement.h: Removed.
        * wml/WMLErrorHandling.cpp: Removed.
        * wml/WMLErrorHandling.h: Removed.
        * wml/WMLEventHandlingElement.cpp: Removed.
        * wml/WMLEventHandlingElement.h: Removed.
        * wml/WMLFieldSetElement.cpp: Removed.
        * wml/WMLFieldSetElement.h: Removed.
        * wml/WMLFormControlElement.cpp: Removed.
        * wml/WMLFormControlElement.h: Removed.
        * wml/WMLGoElement.cpp: Removed.
        * wml/WMLGoElement.h: Removed.
        * wml/WMLImageElement.cpp: Removed.
        * wml/WMLImageElement.h: Removed.
        * wml/WMLImageLoader.cpp: Removed.
        * wml/WMLImageLoader.h: Removed.
        * wml/WMLInputElement.cpp: Removed.
        * wml/WMLInputElement.h: Removed.
        * wml/WMLInsertedLegendElement.cpp: Removed.
        * wml/WMLInsertedLegendElement.h: Removed.
        * wml/WMLIntrinsicEvent.cpp: Removed.
        * wml/WMLIntrinsicEvent.h: Removed.
        * wml/WMLIntrinsicEventHandler.cpp: Removed.
        * wml/WMLIntrinsicEventHandler.h: Removed.
        * wml/WMLMetaElement.cpp: Removed.
        * wml/WMLMetaElement.h: Removed.
        * wml/WMLNoopElement.cpp: Removed.
        * wml/WMLNoopElement.h: Removed.
        * wml/WMLOnEventElement.cpp: Removed.
        * wml/WMLOnEventElement.h: Removed.
        * wml/WMLOptGroupElement.cpp: Removed.
        * wml/WMLOptGroupElement.h: Removed.
        * wml/WMLOptionElement.cpp: Removed.
        * wml/WMLOptionElement.h: Removed.
        * wml/WMLPElement.cpp: Removed.
        * wml/WMLPElement.h: Removed.
        * wml/WMLPageState.cpp: Removed.
        * wml/WMLPageState.h: Removed.
        * wml/WMLPostfieldElement.cpp: Removed.
        * wml/WMLPostfieldElement.h: Removed.
        * wml/WMLPrevElement.cpp: Removed.
        * wml/WMLPrevElement.h: Removed.
        * wml/WMLRefreshElement.cpp: Removed.
        * wml/WMLRefreshElement.h: Removed.
        * wml/WMLSelectElement.cpp: Removed.
        * wml/WMLSelectElement.h: Removed.
        * wml/WMLSetvarElement.cpp: Removed.
        * wml/WMLSetvarElement.h: Removed.
        * wml/WMLTableElement.cpp: Removed.
        * wml/WMLTableElement.h: Removed.
        * wml/WMLTagNames.in: Removed.
        * wml/WMLTaskElement.cpp: Removed.
        * wml/WMLTaskElement.h: Removed.
        * wml/WMLTemplateElement.cpp: Removed.
        * wml/WMLTemplateElement.h: Removed.
        * wml/WMLTimerElement.cpp: Removed.
        * wml/WMLTimerElement.h: Removed.
        * wml/WMLVariables.cpp: Removed.
        * wml/WMLVariables.h: Removed.
2011-04-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WML
        https://bugs.webkit.org/show_bug.cgi?id=59678

        Remove WML-related code in WebKit2.

        * Configurations/FeatureDefines.xcconfig:
        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        * WebProcess/WebPage/WebBackForwardListProxy.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 23:14:13 +0000 (23:14 +0000)]
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        use a hierarchical data structure to store results json
        https://bugs.webkit.org/show_bug.cgi?id=59736

        Instead of a map from test name to results dict, we now store a hierarchical
        data structure.

        Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
        New:
        { foo: {
            bar: {
              baz.html: results_dict,
              baz2.html: results_dict } } }

        This cut ~52% of the size of times_ms.json. I expect it will cut
        30-40% of full_results.json and unexpected_results.json.

        * Scripts/webkitpy/common/net/resultsjsonparser.py:
        * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        Using os.sep was just wrong since relative_test_filename canonicalizes separators.
        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        Instead of plumbing through the change to all of the rebaselineserver
        python and JS, just convert to the old format after reading in the json.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 23:12:28 +0000 (23:12 +0000)]
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        use a hierarchical data structure to store results json
        https://bugs.webkit.org/show_bug.cgi?id=59736

        * fast/harness/resources/results-test.js:
        * fast/harness/results.html:
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        use a hierarchical data structure to store results json
        https://bugs.webkit.org/show_bug.cgi?id=59736

        Instead of a map from test name to results dict, we now store a hierarchical
        data structure.

        Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
        New:
        { foo: {
            bar: {
              baz.html: results_dict,
              baz2.html: results_dict } } }

        This cut ~52% of the size of times_ms.json. I expect it will cut
        30-40% of full_results.json and unexpected_results.json.

        * Scripts/webkitpy/common/net/resultsjsonparser.py:
        * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        Using os.sep was just wrong since relative_test_filename canonicalizes separators.
        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        Instead of plumbing through the change to all of the rebaselineserver
        python and JS, just convert to the old format after reading in the json.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
levin@chromium.org [Thu, 28 Apr 2011 23:04:45 +0000 (23:04 +0000)]
2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85233 and r85235.
        http://trac.webkit.org/changeset/85233
        http://trac.webkit.org/changeset/85235
        https://bugs.webkit.org/show_bug.cgi?id=59754

        Causes issues with jsc. (Requested by dave_levin on #webkit).

        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * jit/ExecutableAllocator.h:
        (JSC::ExecutablePool::ExecutablePool):
        * parser/SourceProvider.h:
        (JSC::SourceProvider::SourceProvider):
        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        * wtf/CMakeLists.txt:
        * wtf/RefCounted.h:
        (WTF::RefCountedBase::ref):
        (WTF::RefCountedBase::hasOneRef):
        (WTF::RefCountedBase::refCount):
        (WTF::RefCountedBase::derefBase):
        * wtf/SizeLimits.cpp:
        * wtf/ThreadRestrictionVerifier.h: Removed.
        * wtf/text/CString.h:
        (WTF::CStringBuffer::CStringBuffer):
2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85233 and r85235.
        http://trac.webkit.org/changeset/85233
        http://trac.webkit.org/changeset/85235
        https://bugs.webkit.org/show_bug.cgi?id=59754

        Causes issues with jsc. (Requested by dave_levin on #webkit).

        * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85233 and r85235.
        http://trac.webkit.org/changeset/85233
        http://trac.webkit.org/changeset/85235
        https://bugs.webkit.org/show_bug.cgi?id=59754

        Causes issues with jsc. (Requested by dave_levin on #webkit).

        * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::defaultIcon):
        (WebCore::IconDatabase::setIconDataForIconURL):
        (WebCore::IconDatabase::getOrCreateIconRecord):
        (WebCore::IconDatabase::readFromDatabase):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Anders Carlsson.
ap@apple.com [Thu, 28 Apr 2011 23:01:00 +0000 (23:01 +0000)]
    Reviewed by Anders Carlsson.

        WebKit2: Frequent crashes in acceptsFirstMouse
        https://bugs.webkit.org/show_bug.cgi?id=59746
        <rdar://problem/9281270>

        The crash occurred when connection was null (and it can become null at any time).

        Added checks for the proxy being valid in all sync calls that lacked such.
        WebPageProxy::isValid() is not the same as WebProcessProxy::isValid(), but existing checks
        looked at the former, so I used that.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::firstRectForCharacterInSelectedRange):
        (WebKit::WebPageProxy::getSelectedText):
        (WebKit::WebPageProxy::gestureWillBegin):
        (WebKit::WebPageProxy::createSnapshotOfVisibleContent):
        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::setComposition):
        (WebKit::WebPageProxy::confirmComposition):
        (WebKit::WebPageProxy::confirmCompositionWithoutDisturbingSelection):
        (WebKit::WebPageProxy::insertText):
        (WebKit::WebPageProxy::getMarkedRange):
        (WebKit::WebPageProxy::getSelectedRange):
        (WebKit::WebPageProxy::getAttributedSubstringFromRange):
        (WebKit::WebPageProxy::characterIndexForPoint):
        (WebKit::WebPageProxy::firstRectForCharacterRange):
        (WebKit::WebPageProxy::executeKeypressCommands):
        (WebKit::WebPageProxy::writeSelectionToPasteboard):
        (WebKit::WebPageProxy::readSelectionFromPasteboard):
        (WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
        (WebKit::WebPageProxy::acceptsFirstMouse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 28 Apr 2011 22:59:11 +0000 (22:59 +0000)]
2011-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        EWS bubbles should show "submit to ews" button if they've not been processed
        https://bugs.webkit.org/show_bug.cgi?id=59751

        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/handlers/submittoews.py:
        * QueueStatusServer/templates/statusbubble.html:
        * QueueStatusServer/templates/submittoews.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is...
bweinstein@apple.com [Thu, 28 Apr 2011 22:33:54 +0000 (22:33 +0000)]
Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
https://bugs.webkit.org/show_bug.cgi?id=59747

Reviewed by Timothy Hatcher.

Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWebInspector:]):
(-[WebInspectorWindowController showErrorConsole:]):
(-[WebInspectorWindowController toggleDebuggingJavaScript:]):
(-[WebInspectorWindowController toggleProfilingJavaScript:]):
(-[WebInspectorWindowController validateUserInterfaceItem:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59740 - DFG JIT - Unify GPRReg & RegisterID
barraclough@apple.com [Thu, 28 Apr 2011 22:31:32 +0000 (22:31 +0000)]
Bug 59740 - DFG JIT - Unify GPRReg & RegisterID

Reviewed by Oliver Hunt.

Currently we use a mix of enum values throughout the DFG JIT to  represent
gpr registers - the RegisterID provided by the MacroAssembler, and the
GPRReg enum giving the sequential register set over which the RegisterBank
allocates. Unify the two.

Patch to unify FPRReg in a similar fashion will follow.

* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGFPRInfo.h: Added.
(JSC::DFG::next):
(JSC::DFG::FPRBankInfo::toRegister):
(JSC::DFG::FPRBankInfo::toIndex):
* dfg/DFGGPRInfo.h: Added.
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::JITCodeGenerator::flushRegisters):
(JSC::DFG::JITCodeGenerator::isFlushed):
(JSC::DFG::JITCodeGenerator::bitOp):
(JSC::DFG::JITCodeGenerator::shiftOp):
(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):
(JSC::DFG::JITCodeGenerator::setupStubArguments):
(JSC::DFG::JITCodeGenerator::callOperation):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::DoubleOperand::gpr):
(JSC::DFG::GPRTemporary::gpr):
(JSC::DFG::FPRTemporary::gpr):
(JSC::DFG::GPRResult::lockedResult):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::preserveReturnAddressAfterCall):
(JSC::DFG::JITCompiler::restoreReturnAddressBeforeReturn):
(JSC::DFG::JITCompiler::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::JITCompiler::emitPutToCallFrameHeader):
(JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
(JSC::DFG::JITCompiler::addressForGlobalVar):
(JSC::DFG::JITCompiler::addressFor):
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::EntryLocation::EntryLocation):
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::numberToInt32):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
(JSC::DFG::NonSpeculativeJIT::silentSpillGPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillFPR):
(JSC::DFG::NonSpeculativeJIT::silentFillGPR):
(JSC::DFG::NonSpeculativeJIT::silentFillFPR):
(JSC::DFG::NonSpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::NonSpeculativeJIT::silentFillAllRegisters):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::allocate):
(JSC::DFG::RegisterBank::retain):
(JSC::DFG::RegisterBank::release):
(JSC::DFG::RegisterBank::lock):
(JSC::DFG::RegisterBank::unlock):
(JSC::DFG::RegisterBank::isLocked):
(JSC::DFG::RegisterBank::name):
(JSC::DFG::RegisterBank::iterator::name):
(JSC::DFG::RegisterBank::iterator::isLocked):
(JSC::DFG::RegisterBank::iterator::release):
(JSC::DFG::RegisterBank::iterator::gpr):
(JSC::DFG::RegisterBank::iterator::debugName):
(JSC::DFG::RegisterBank::iterator::operator++):
(JSC::DFG::RegisterBank::iterator::operator!=):
(JSC::DFG::RegisterBank::iterator::index):
(JSC::DFG::RegisterBank::iterator::iterator):
(JSC::DFG::RegisterBank::begin):
(JSC::DFG::RegisterBank::end):
(JSC::DFG::RegisterBank::isLockedAtIndex):
(JSC::DFG::RegisterBank::nameAtIndex):
(JSC::DFG::RegisterBank::releaseAtIndex):
(JSC::DFG::RegisterBank::allocateInternal):
(JSC::DFG::RegisterBank::MapEntry::MapEntry):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculationCheck::SpeculationCheck):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateIntegerOperand::gpr):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backi...
ddkilzer@apple.com [Thu, 28 Apr 2011 22:31:04 +0000 (22:31 +0000)]
<webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer

Reviewed by Dan Bernstein.

* WebView/WebFullScreenController.mm:
(-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
Use a RetainPtr to hold the CALayer and to fix the leak.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 28 Apr 2011 22:22:20 +0000 (22:22 +0000)]
2011-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        EWS Bubbles should show commit-queue position when patch is in the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=59744

        This was actually just a 2 line change to statusbubble.py.
        I also cleaned up statusbubble.html a little while I was there
        (the links are now actual <a> tags and have hover).

        * QueueStatusServer/handlers/statusbubble.py:
        * QueueStatusServer/templates/statusbubble.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 28 Apr 2011 22:18:56 +0000 (22:18 +0000)]
2011-04-28  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        add a mac leopard release NRWT bot
        https://bugs.webkit.org/show_bug.cgi?id=59733

        * BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac side of: WebKit2: Support docked mode for Web Inspector
bweinstein@apple.com [Thu, 28 Apr 2011 22:05:54 +0000 (22:05 +0000)]
Mac side of: WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>

Reviewed by Timothy Hatcher.

Implement docking of the Web Inspector on Mac. This matches the Windows (WK1 and WK2) closely,
where the inspector and the inspected view are siblings.

* UIProcess/API/C/mac: Added.
* UIProcess/API/C/mac/WKInspectorMac.h: Added.
* UIProcess/API/mac/PageClientImpl.h:
(WebKit::PageClientImpl::wkView): Returns the WKView.
* UIProcess/PageClient.h:
* UIProcess/WebInspectorProxy.h: The inspected view is now a WebInspectorWKView, so we can override tag.
* UIProcess/WebPageProxy.h: Added a getter for the WKView.

* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Calls through to WebInspectorProxy::inspectedViewFrameDidChange.
(-[WebInspectorWKView tag]): Returns a constant defined in WKInspectorMac.h.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WebInspectorWKView instead of a WKView.
(WebKit::WebInspectorProxy::platformClose): Removed a FIXME that isn't needed anymore (we always detach before closing).
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Place our inspector and the inspected view next to each other, assuming the
    bottom of the inspector is at the Y origin.
(WebKit::WebInspectorProxy::platformAttach): Listen for changes to the inspected view's frame, and move the inspectorView from the
    detached inspector window to the superview of the inspected view (to make the inspector and inspected view siblings).
(WebKit::WebInspectorProxy::platformDetach): Stop listening for changes to the inspected view's frame, and move the inspectorView
    back to the detached inspector window. We also resize the inspected view to take up the space the inspector took up before
    (assuming the bottom of the inspector was at the Y origin).
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Resize the inspector's view, and call inspectedViewFrameDidChange (which
    syncs the inspector and the inspected view), and call setNeedsDisplay on both views.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::wkView):

* WebKit2.xcodeproj/project.pbxproj: Add a new file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Jay Civelli <jcivelli@chromium.org>
abarth@webkit.org [Thu, 28 Apr 2011 22:03:09 +0000 (22:03 +0000)]
2011-04-28  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Introducing a new class that allows serialization of a page back
        to HTML/XML with all its sub-frames and also retrieves the page's
        resources.
        Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
        https://bugs.webkit.org/show_bug.cgi?id=58947

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * dom/Document.cpp:
        (WebCore::Document::suggestedMIMEType):
        * dom/Document.h:
        * editing/MarkupAccumulator.cpp:
        (WebCore::MarkupAccumulator::appendCustomAttributes):
        (WebCore::MarkupAccumulator::appendElement):
        * editing/MarkupAccumulator.h:
        * html/parser/HTMLMetaCharsetParser.cpp:
        (WebCore::HTMLMetaCharsetParser::processMeta):
        (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
        * html/parser/HTMLMetaCharsetParser.h:
        * page/PageSerializer.cpp: Added.
        * page/PageSerializer.h: Added.
2011-04-28  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Introducing a new API to serialize a WebView back to HTML.
        https://bugs.webkit.org/show_bug.cgi?id=58947

        * WebKit.gyp:
        * public/WebPageSerializer.h:
        * src/WebPageSerializer.cpp:
        (WebKit::WebPageSerializer::serialize):
        * tests/WebPageNewSerializerTest.cpp: Added.
        * tests/data/pageserializer: Added.
        * tests/data/pageserializer/blank_frames.html: Added.
        * tests/data/pageserializer/blue_background.png: Added.
        * tests/data/pageserializer/css_test_page.html: Added.
        * tests/data/pageserializer/green_background.png: Added.
        * tests/data/pageserializer/iframe.html: Added.
        * tests/data/pageserializer/iframe2.html: Added.
        * tests/data/pageserializer/import_style_from_link.css: Added.
        * tests/data/pageserializer/import_styles.css: Added.
        * tests/data/pageserializer/link_styles.css: Added.
        * tests/data/pageserializer/ol-dot.png: Added.
        * tests/data/pageserializer/orange_background.png: Added.
        * tests/data/pageserializer/purple_background.png: Added.
        * tests/data/pageserializer/red_background.png: Added.
        * tests/data/pageserializer/simple.xhtml: Added.
        * tests/data/pageserializer/top_frame.html: Added.
        * tests/data/pageserializer/ul-dot.png: Added.
        * tests/data/pageserializer/yellow_background.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash under WKPageCreateSnapshotOfVisibleContent if there is no response from the...
jberlin@webkit.org [Thu, 28 Apr 2011 22:01:48 +0000 (22:01 +0000)]
Crash under WKPageCreateSnapshotOfVisibleContent if there is no response from the Web Process
in the allotted time.
https://bugs.webkit.org/show_bug.cgi?id=59738

Reviewed by Darin Adler.

If the handle is null, don't try to create a ShareableBitmap and then a WebImage out of it.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createSnapshotOfVisibleContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 21:43:22 +0000 (21:43 +0000)]
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Avoid crashing when running new-run-webkit-tests outside of
        version control.

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Thu, 28 Apr 2011 21:40:56 +0000 (21:40 +0000)]
2011-04-28  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add a WebPermissionClient to be used for checking permissions of features
        https://bugs.webkit.org/show_bug.cgi?id=59720

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::allowPlugins):
        (WebKit::WebFrameClient::didNotAllowPlugins):
        (WebKit::WebFrameClient::allowImages):
        (WebKit::WebFrameClient::allowScript):
        (WebKit::WebFrameClient::allowDatabase):
        (WebKit::WebFrameClient::didNotAllowScript):
        * public/WebPermissionClient.h: Added.
        (WebKit::WebPermissionClient::allowDatabase):
        (WebKit::WebPermissionClient::allowImages):
        (WebKit::WebPermissionClient::allowPlugins):
        (WebKit::WebPermissionClient::allowScript):
        (WebKit::WebPermissionClient::allowScriptExtension):
        (WebKit::WebPermissionClient::allowReadFromClipboard):
        (WebKit::WebPermissionClient::allowWriteToClipboard):
        (WebKit::WebPermissionClient::didNotAllowPlugins):
        (WebKit::WebPermissionClient::didNotAllowScript):
        (WebKit::WebPermissionClient::~WebPermissionClient):
        * public/WebView.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::didEndEditing):
        * src/DatabaseObserver.cpp:
        (WebCore::DatabaseObserver::canEstablishDatabase):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
        (WebKit::EditorClientImpl::canCopyCut):
        (WebKit::EditorClientImpl::canPaste):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::allowScriptExtension):
        (WebKit::FrameLoaderClientImpl::allowJavaScript):
        (WebKit::FrameLoaderClientImpl::allowPlugins):
        (WebKit::FrameLoaderClientImpl::allowImages):
        (WebKit::FrameLoaderClientImpl::didNotAllowScript):
        (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::enableContinuousSpellChecking):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setAutoFillClient):
        (WebKit::WebViewImpl::setPermissionClient):
        (WebKit::WebViewImpl::WebViewImpl):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::permissionClient):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 28 Apr 2011 21:37:56 +0000 (21:37 +0000)]
2011-04-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Remove evil addressOfStructure() function
        https://bugs.webkit.org/show_bug.cgi?id=59739

        Remove the addressOfStructure function from JSCell, and update
        callsites to use the same logic as testPrototype()

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        * runtime/JSCell.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 28 Apr 2011 21:21:34 +0000 (21:21 +0000)]
2011-04-28  Kenneth Russell  <kbr@google.com>

        Unreviewed fix for Windows multi-DLL build.

        * WebKit.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 21:12:45 +0000 (21:12 +0000)]
2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB createIndex should fail if name arg is null
        https://bugs.webkit.org/show_bug.cgi?id=58365

        * storage/indexeddb/mozilla/create-index-null-name-expected.txt: Added.
        * storage/indexeddb/mozilla/create-index-null-name.html: Added.
2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB createIndex should fail if name arg is null
        https://bugs.webkit.org/show_bug.cgi?id=58365

        Test: storage/indexeddb/mozilla/create-index-null-name.html

        * storage/IDBObjectStore.idl:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::createIndex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFollow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuIt...
ddkilzer@apple.com [Thu, 28 Apr 2011 21:02:31 +0000 (21:02 +0000)]
Follow-up fix: <webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects

Addresses review comment from Darin Adler.

* WebView/WebPDFView.mm:
(-[WebPDFView menuForEvent:]): Use a local variable and -release
instead of -autorelease.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 28 Apr 2011 21:01:39 +0000 (21:01 +0000)]
2011-04-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Clean up testPrototype()
        https://bugs.webkit.org/show_bug.cgi?id=59734

        Remove direct pointer to the inside of a GC object and just do
        the indirect load manually.  Doesn't effect sunspider but does
        clean up the code quite a bit, and simplifies the handling of
        GC values.

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::testPrototype):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
levin@chromium.org [Thu, 28 Apr 2011 20:54:23 +0000 (20:54 +0000)]
Build fix.

* wtf/RefCounted.h: Fix inverted ifdef.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 20:49:52 +0000 (20:49 +0000)]
2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB put() should fail if second (key) parameter is null
        https://bugs.webkit.org/show_bug.cgi?id=58613

        Added one test and fixed another that relied on old (broken) behavior
        when passing null in second parameter.

        * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: Added.
        * storage/indexeddb/mozilla/key-requirements-put-null-key.html: Added.
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB put() should fail if second (key) parameter is null
        https://bugs.webkit.org/show_bug.cgi?id=58613

        If key arg is not specified, prpKey ends up as a null pointer in ::put().
        However, if the key arg is specified but is null, prpKey ends up as a
        valid IDBKey which has a null key type. As it happens, we need to be able
        to detect the difference between these cases (the key arg is optional but
        if specified must not be null).

        Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html

        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::put):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd asserts to RefCounted to make sure ref/deref happens on the right thread.
levin@chromium.org [Thu, 28 Apr 2011 20:46:22 +0000 (20:46 +0000)]
Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639

Reviewed by Darin Adler.

Source/JavaScriptCore:

* GNUmakefile.list.am: Added new files to the build.
* JavaScriptCore.gypi: Ditto.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
* JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
* jit/ExecutableAllocator.h:
(JSC::ExecutablePool::ExecutablePool): Turned off checks for this
due to not being able to figure out what was guarding it (bug 58091).
* parser/SourceProvider.h:
(JSC::SourceProvider::SourceProvider): Ditto.
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp): Ditto.
* wtf/CMakeLists.txt: Added new files to the build.
* wtf/ThreadRestrictionVerifier.h: Added.
Everything is done in the header to avoid the issue with exports
that are only useful in debug but still needing to export them.
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref): Added checks using the non thread safe verifier.
and filed bug 58171 about making it stricter.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::setMutexForVerifier): Expose a way to change the checks to be based
on a mutex. This is in the header to avoid adding more exports from JavaScriptCore.
(WTF::RefCountedBase::deprecatedTurnOffVerifier): Temporary way to turn off verification.
Filed bug 58174 to remove this method.
(WTF::RefCountedBase::derefBase):
* wtf/SizeLimits.cpp: Adjusted the debug size check for RefCounted.
* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Turned off checks for this while a fix is being
done in Chromium's test_shell (bug 58093).

Source/JavaScriptGlue:

* ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.

Source/WebCore:

No new functionality exposed so no new tests. (The change is basically adding
more testing.)

* ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
(WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
(WebCore::IconDatabase::setIconDataForIconURL): Ditto.
(WebCore::IconDatabase::readFromDatabase): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 28 Apr 2011 20:43:19 +0000 (20:43 +0000)]
2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Darin Fisher.

        Port Mozilla's IndexedDB tests: versionchange event
        https://bugs.webkit.org/show_bug.cgi?id=58738

        * storage/indexeddb/mozilla: Added.
        * storage/indexeddb/mozilla/versionchange-expected.txt: Added.
        * storage/indexeddb/mozilla/versionchange.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a thinko - separateRealmLabel is not an NSImageView.
andersca@apple.com [Thu, 28 Apr 2011 20:20:04 +0000 (20:20 +0000)]
Fix a thinko - separateRealmLabel is not an NSImageView.

* Panels/WebAuthenticationPanel.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
ddkilzer@apple.com [Thu, 28 Apr 2011 20:14:06 +0000 (20:14 +0000)]
<webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects

Reviewed by Dan Bernstein.

* WebView/WebPDFView.mm:
(-[WebPDFView menuForEvent:]): Call -autorelease after copying
each NSMenuItem.  Regressed in r9566 for Bug 3711.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 28 Apr 2011 20:00:09 +0000 (20:00 +0000)]
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix.

        * GNUmakefile.am:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 28 Apr 2011 19:54:24 +0000 (19:54 +0000)]
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed attempt to fix the build.

        * GNUmakefile.am: add -lpthread.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 28 Apr 2011 19:42:29 +0000 (19:42 +0000)]
2011-04-28  Kenneth Russell  <kbr@google.com>

        Unreviewed test expectations update. Marked flaky and crashing tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 28 Apr 2011 19:29:11 +0000 (19:29 +0000)]
2011-04-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Only need a single implementation of testPrototype
        https://bugs.webkit.org/show_bug.cgi?id=59724

        Remove excess copy of identical testPrototype() code

        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::testPrototype):
        * jit/JITPropertyAccess32_64.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 28 Apr 2011 19:18:31 +0000 (19:18 +0000)]
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Add a pkg-config file for JavaScriptCoreGTK+.

        * configure.ac: generate the final pkg-config file from our .in
        file.

Source/WebKit/gtk:

2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Add a pkg-config file for JavaScriptCoreGTK+.

        * GNUmakefile.am: take care of the pkg-config file.
        * javascriptcoregtk.pc.in: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 28 Apr 2011 19:14:18 +0000 (19:14 +0000)]
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Build JavaScriptCore as a libtool shared library instead of a
        private convenience library.

        * GNUmakefile.am: remove convenience library definition for jsc.

Source/JavaScriptCore:

2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Build JavaScriptCore as a libtool shared library instead of a
        private convenience library.

        * GNUmakefile.am: define new jsc library and adapt to new name for
        javascriptcore target.
        * GNUmakefile.list.am: ditto.

Source/WebKit/gtk:

2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Build JavaScriptCore as a libtool shared library instead of a
        private convenience library.

        * GNUmakefile.am: adapt to new name for javascriptcore target.

Source/WebKit2:

2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Split JSC and WebCore builds
        https://bugs.webkit.org/show_bug.cgi?id=19428

        Build JavaScriptCore as a libtool shared library instead of a
        private convenience library.

        * GNUmakefile.am: adapt to new name for javascriptcore target.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8773946> and https://bugs.webkit.org/show_bug.cgi?id=59614
beidson@apple.com [Thu, 28 Apr 2011 19:12:32 +0000 (19:12 +0000)]
<rdar://problem/8773946> and https://bugs.webkit.org/show_bug.cgi?id=59614
Client certificate authentication in WebKit2

Reviewed by Sam Weinig.

Project-file stuff:
* WebKit2.xcodeproj/project.pbxproj:

Allow WKCredentials to store certificates:
* UIProcess/Authentication/WebCredential.cpp:
(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::certificateInfo):
* UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create):
* UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreateWithCertificateInfo):
* UIProcess/API/C/WKCredential.h:

Pass the certificate info over the wire to the WebProcess:
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):

Change the WebProcess to prefer certificate info over basic credentials when responding to a challenge:
* WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge): Stub for platforms other than Mac,
  as only Mac can currently respond to challenges with certificates.
(WebKit::AuthenticationManager::useCredentialForChallenge):
* WebProcess/Authentication/AuthenticationManager.h:
* WebProcess/Authentication/AuthenticationManager.messages.in:
* WebProcess/Authentication/mac: Added.
* WebProcess/Authentication/mac/AuthenticationManager.mac.mm: Added.
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge): Recreate the identity and certificate
  chain and respond to the challenge with it.

Add a newly required #include:
* UIProcess/API/C/WKAuthenticationChallenge.cpp:
* UIProcess/Authentication/AuthenticationDecisionListener.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 19:11:06 +0000 (19:11 +0000)]
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        fix python printing test
        https://bugs.webkit.org/show_bug.cgi?id=59719

        Now that we run scm commands in summarize_results, --verbose prints
        debug logging to stderr.

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 ojab <ojab@ojab.ru>
mrobinson@webkit.org [Thu, 28 Apr 2011 19:10:14 +0000 (19:10 +0000)]
2011-04-28  ojab  <ojab@ojab.ru>

        Reviewed by Martin Robinson.

        Webkit-gtk build failure, no type/member 'Page' in namespace 'WebCore'
        https://bugs.webkit.org/show_bug.cgi?id=59585

        * webkit/webkitwebviewprivate.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 28 Apr 2011 19:03:47 +0000 (19:03 +0000)]
2011-04-28  Kenneth Russell  <kbr@google.com>

        Unreviewed build fix for Web Audio with strict OwnPtr.

        * platform/audio/HRTFDatabaseLoader.cpp:
        (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 28 Apr 2011 18:59:10 +0000 (18:59 +0000)]
2011-04-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove C++0x compat mode warnings for GCC >= 4.6.0
        https://bugs.webkit.org/show_bug.cgi?id=59718

        Hardcode -Wno-c++0x-compat for the default compiler (if version >=
        4.6.0) until our codebase is ready.

        * configure.ac: do that.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMomentum scroll tweak for WebKit.
enrica@apple.com [Thu, 28 Apr 2011 18:58:15 +0000 (18:58 +0000)]
Momentum scroll tweak for WebKit.
https://bugs.webkit.org/show_bug.cgi?id=59723
<rdar://problem/9259933>

Reviewed by Beth Dakin.

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 28 Apr 2011 18:48:12 +0000 (18:48 +0000)]
2011-04-28  Tony Chang  <tony@chromium.org>

        Fix description in recently added test results.

        * storage/indexeddb/mozilla/key-requirements-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dominic Cooney <dominicc@chromium.org>
dglazkov@chromium.org [Thu, 28 Apr 2011 18:43:54 +0000 (18:43 +0000)]
2011-04-28  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Geoffrey Garen.

        Walk shadow hosts as well as parent nodes when finding opaque roots.
        https://bugs.webkit.org/show_bug.cgi?id=59571

        Remove expectation of failure.

        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Removed.
2011-04-28  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Geoffrey Garen.

        Walk shadow hosts as well as parent nodes when finding opaque roots.
        https://bugs.webkit.org/show_bug.cgi?id=59571

        Test: fast/dom/shadow/gc-shadow.html

        * bindings/js/JSDOMBinding.h:
        (WebCore::root):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 28 Apr 2011 18:39:20 +0000 (18:39 +0000)]
2011-04-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Added the test results, missed in r85209.

        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 28 Apr 2011 18:37:33 +0000 (18:37 +0000)]
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Click counting logic should be shared between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59715

        Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
        into WebCore so that WebKit1 and WebKit2 can share the code.

        No new tests. This is covered by fast/events/click-count.html.

        * GNUmakefile.list.am: Added new files.
        * platform/gtk/GtkClickCounter.cpp: Added.
        (WebCore::GtkClickCounter::GtkClickCounter): Added.
        (WebCore::GtkClickCounter::reset): Added.
        (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
        (WebCore::getEventTime): Added.
        (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
        * platform/gtk/GtkClickCounter.h: Added.
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Click counting logic should be shared between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59715

        Switch WebKit1 to use the new GtkClickCounter for counting > 3 clicks in a row.
        This allows the code to be shared between WebKit1 and WebKit2.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Call GtkClickCounter::reset instead of fiddling
        the WebView private data directly.
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup): Ditto.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event): Call into GtkClickCounter now.
        (webkit_web_view_init): Remove private member intialization.
        * webkit/webkitwebviewprivate.h: Remove unneeded private members.
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Click counting logic should be shared between WebKit1 and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59715

        Use the GtkClickCounter instead of doing click counting manually. This means that
        the code will now be shared between WebKit1 and WebKit2.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkit_web_view_base_init): Remove private member initialization.
        (webViewButtonPressEvent): Call into GtkClickCounter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Thu, 28 Apr 2011 18:13:21 +0000 (18:13 +0000)]
Build fix.

* css/CSSParser.cpp:
(WebCore::cssPropertyID):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow specifying CSS property aliases in CSSPropertyNames.in files
mitz@apple.com [Thu, 28 Apr 2011 18:08:39 +0000 (18:08 +0000)]
Allow specifying CSS property aliases in CSSPropertyNames.in files
https://bugs.webkit.org/show_bug.cgi?id=59712

Reviewed by Simon Fraser.

* css/CSSParser.cpp:
(WebCore::cssPropertyID): Removed code to handle some aliases
* css/CSSPropertyNames.in: Added aliases no longer handled in code.
* css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
defining an alias, and add an appropriate entry to the gperf file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 28 Apr 2011 17:57:30 +0000 (17:57 +0000)]
2011-04-28  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Brian Weinstein.

        Push canvas tests' expected results down from platform/mac and into platform/mac-snowleopard
        https://bugs.webkit.org/show_bug.cgi?id=59654

        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt.
        * platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 28 Apr 2011 17:55:03 +0000 (17:55 +0000)]
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        link to tests at a specific revision in the results.html file
        https://bugs.webkit.org/show_bug.cgi?id=59711

        This matches old-run-webkit-tests.

        * fast/harness/resources/results-test.js:
        * fast/harness/results-expected.txt:
        * fast/harness/results.html:
2011-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        link to tests at a specific revision in the results.html file
        https://bugs.webkit.org/show_bug.cgi?id=59711

        * Scripts/webkitpy/common/checkout/scm.py:
        Add a method to get the head svn revision.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        Include the svn revision in the results json.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Dominic Cooney <dominicc@chromium.org>
dglazkov@chromium.org [Thu, 28 Apr 2011 17:52:15 +0000 (17:52 +0000)]
2011-04-28  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Unskip fast/dom/shadow/gc-shadow.html on Mac with expected failure
        https://bugs.webkit.org/show_bug.cgi?id=59647

        * fast/dom/shadow/gc-shadow.html: Actually GC the shadow roots now.
        * fast/dom/shadow/gc-shadow-expected.txt: Updated.
        * platform/mac/Skipped: Unskip gc-shadow.html.
        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 28 Apr 2011 17:49:31 +0000 (17:49 +0000)]
2011-04-28  Martin Robinson  <mrobinson@igalia.com>

        Build fix after r85197.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webViewExpose): Use cr.get() here.
        (webViewDraw): Small clean up.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Arno Renevier <arno@renevier.net>
commit-queue@webkit.org [Thu, 28 Apr 2011 17:49:20 +0000 (17:49 +0000)]
2011-04-28  Arno Renevier  <arno@renevier.net>

        Reviewed by Gustavo Noronha Silva.

        [Soup] does not load css stylesheets without content-type
        https://bugs.webkit.org/show_bug.cgi?id=59697

        * platform/gtk/Skipped: Enable now passing tests:
         - http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html
         - http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html
2011-04-28  Arno Renevier  <arno@renevier.net>

        Reviewed by Gustavo Noronha Silva.

        [Soup] does not load css stylesheets without content-type
        https://bugs.webkit.org/show_bug.cgi?id=59697

        When sniffing content type, do not replace http Content-Type header in
        soup message anymore, but keep sniffed content type in a separate
        variable.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::contentSniffedCallback):
        * platform/network/soup/ResourceResponse.h:
        (WebCore::ResourceResponse::sniffedContentType):
        (WebCore::ResourceResponse::setSniffedContentType):
        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::updateFromSoupMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Thu, 28 Apr 2011 17:40:10 +0000 (17:40 +0000)]
2011-04-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
        https://bugs.webkit.org/show_bug.cgi?id=59704

        No new tests, just code cleanup.

        * WebCore.pri:
2011-04-28  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
        https://bugs.webkit.org/show_bug.cgi?id=59704

        * WebCoreSupport/QtFallbackWebPopup.cpp:
        (WebCore::QtFallbackWebPopup::show):
        * WebCoreSupport/QtFallbackWebPopup.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate expected results for a hyphenation test
aroben@apple.com [Thu, 28 Apr 2011 17:31:13 +0000 (17:31 +0000)]
Update expected results for a hyphenation test

* platform/mac/fast/text/hyphenate-limit-before-after-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 28 Apr 2011 17:20:47 +0000 (17:20 +0000)]
2011-04-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove "Pretty print" source frame context menu item.
        https://bugs.webkit.org/show_bug.cgi?id=59709

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd failing test to Leopard skipped list.
weinig@apple.com [Thu, 28 Apr 2011 17:14:09 +0000 (17:14 +0000)]
Add failing test to Leopard skipped list.
Will track using https://bugs.webkit.org/show_bug.cgi?id=51807

* platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip another crashing shadow DOM test
aroben@apple.com [Thu, 28 Apr 2011 17:07:57 +0000 (17:07 +0000)]
Skip another crashing shadow DOM test

<http://webkit.org/b/59708> tracks the failure. Maybe it will eventually be duped to
<http://webkit.org/b/59571>.

* platform/mac/Skipped: Added fast/dom/shadow/nodetype.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Thu, 28 Apr 2011 17:01:31 +0000 (17:01 +0000)]
2011-04-28  Leon Scroggins  <scroggo@google.com>

        Reviewed by Steve Block.

        Rebaseline tests which look different due to a change in skia gradient calculations.
        https://bugs.webkit.org/show_bug.cgi?id=59132

        * platform/chromium-linux-x86_64/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-linux-x86_64/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
        * platform/chromium-linux/fast/gradients/background-clipped-expected.png:
        * platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.png:
        * platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
        * platform/chromium-linux/fast/gradients/radial-centered-expected.png:
        * platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
        * platform/chromium-win/fast/gradients/background-clipped-expected.png:
        * platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.png:
        * platform/chromium-win/fast/gradients/generated-gradients-expected.png:
        * platform/chromium-win/fast/gradients/radial-centered-expected.png:
        * platform/chromium-win/fast/gradients/simple-gradients-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:56:55 +0000 (16:56 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Sam Weinig.

        [GTK] Remove WKURLCreateWithURL()
        https://bugs.webkit.org/show_bug.cgi?id=59691

        The name is a bit confusing and there's already
        WKURLCreateWithUTF8CString() in the C API.

        * UIProcess/API/C/gtk/WKView.cpp:
        * UIProcess/API/C/gtk/WKView.h:
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Sam Weinig.

        [GTK] Remove WKURLCreateWithURL()
        https://bugs.webkit.org/show_bug.cgi?id=59691

        Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().

        * MiniBrowser/gtk/main.c:
        (activateUriEntryCallback):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:53:04 +0000 (16:53 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Make WebKitWebViewBase public in the API
        https://bugs.webkit.org/show_bug.cgi?id=59689

        Add WebKitWebViewBasePrivate.h and move WebKitWebViewBase inernal
        methods to it. Rename get_type() method, since it's part of the
        public API and should follow gtk coding style.

        * GNUmakefile.am: Add WebKitWebViewBasePrivate.h.
        * UIProcess/API/C/gtk/WKView.cpp: Use WebKitWebViewBasePrivate.h.
        * UIProcess/API/gtk/PageClientImpl.cpp: Ditto.
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseFinalize):
        (webkit_web_view_base_init):
        (webViewSizeAllocate):
        (webViewFocusInEvent):
        (webViewFocusOutEvent):
        (webViewKeyPressEvent):
        (webViewKeyReleaseEvent):
        (webkit_web_view_base_class_init):
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Copied from Source/WebKit2/UIProcess/API/C/gtk/WKView.cpp.
        * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp: Use WebKitWebViewBasePrivate.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:48:46 +0000 (16:48 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Move WebView to UIProcess/API/gtk
        https://bugs.webkit.org/show_bug.cgi?id=59686

        And rename it as PageClientImpl, since it's a page client
        implementation, not a web view.

        * GNUmakefile.am:
        * UIProcess/API/C/gtk/WKView.cpp:
        * UIProcess/API/gtk/PageClientImpl.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebView.cpp.
        (WebKit::backspaceCallback):
        (WebKit::selectAllCallback):
        (WebKit::cutClipboardCallback):
        (WebKit::copyClipboardCallback):
        (WebKit::pasteClipboardCallback):
        (WebKit::toggleOverwriteCallback):
        (WebKit::popupMenuCallback):
        (WebKit::showHelpCallback):
        (WebKit::deleteFromCursorCallback):
        (WebKit::moveCursorCallback):
        (WebKit::PageClientImpl::PageClientImpl):
        (WebKit::PageClientImpl::~PageClientImpl):
        (WebKit::PageClientImpl::getEditorCommandsForKeyEvent):
        (WebKit::PageClientImpl::createDrawingAreaProxy):
        (WebKit::PageClientImpl::setViewNeedsDisplay):
        (WebKit::PageClientImpl::displayView):
        (WebKit::PageClientImpl::scrollView):
        (WebKit::PageClientImpl::viewSize):
        (WebKit::PageClientImpl::isViewWindowActive):
        (WebKit::PageClientImpl::isViewFocused):
        (WebKit::PageClientImpl::isViewVisible):
        (WebKit::PageClientImpl::isViewInWindow):
        (WebKit::PageClientImpl::PageClientImpl::processDidCrash):
        (WebKit::PageClientImpl::didRelaunchProcess):
        (WebKit::PageClientImpl::takeFocus):
        (WebKit::PageClientImpl::toolTipChanged):
        (WebKit::PageClientImpl::setCursor):
        (WebKit::PageClientImpl::setViewportArguments):
        (WebKit::PageClientImpl::registerEditCommand):
        (WebKit::PageClientImpl::clearAllEditCommands):
        (WebKit::PageClientImpl::canUndoRedo):
        (WebKit::PageClientImpl::executeUndoRedo):
        (WebKit::PageClientImpl::convertToDeviceSpace):
        (WebKit::PageClientImpl::convertToUserSpace):
        (WebKit::PageClientImpl::windowToScreen):
        (WebKit::PageClientImpl::doneWithKeyEvent):
        (WebKit::PageClientImpl::didNotHandleKeyEvent):
        (WebKit::PageClientImpl::createPopupMenuProxy):
        (WebKit::PageClientImpl::createContextMenuProxy):
        (WebKit::PageClientImpl::setFindIndicator):
        (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing):
        (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):
        (WebKit::PageClientImpl::didCommitLoadForMainFrame):
        (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
        (WebKit::PageClientImpl::customRepresentationZoomFactor):
        (WebKit::PageClientImpl::setCustomRepresentationZoomFactor):
        (WebKit::PageClientImpl::pageClosed):
        (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
        (WebKit::PageClientImpl::flashBackingStoreUpdates):
        (WebKit::PageClientImpl::findStringInCustomRepresentation):
        (WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
        * UIProcess/API/gtk/PageClientImpl.h: Renamed from Source/WebKit2/UIProcess/gtk/WebView.h.
        (WebKit::PageClientImpl::create):
        (WebKit::PageClientImpl::addPendingEditorCommand):
        (WebKit::PageClientImpl::userSpaceScaleFactor):
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseInit):
        (webkitWebViewBaseCreate):
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/gtk/ChunkedUpdateDrawingAreaProxyGtk.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 28 Apr 2011 16:44:34 +0000 (16:44 +0000)]
2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use the WebPage object in WebKitWebViewBase
        https://bugs.webkit.org/show_bug.cgi?id=59683

        It simplifies the implementation of the event callbacks. Remove
        also all the methods from the page client that are no longer
        needed.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseInit):
        (webViewExpose):
        (webViewDraw):
        (webViewSizeAllocate):
        (webViewFocusInEvent):
        (webViewFocusOutEvent):
        (webViewKeyPressEvent):
        (webViewKeyReleaseEvent):
        (webViewButtonPressEvent):
        (webViewButtonReleaseEvent):
        (webViewScrollEvent):
        (webViewMotionNotifyEvent):
        * UIProcess/API/gtk/WebKitWebViewBase.h:
        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::WebView):
        (WebKit::WebView::createDrawingAreaProxy):
        * UIProcess/gtk/WebView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85197 268f45cc-cd09-0410-ab3c-d52691b4dbfc