WebKit.git
10 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 12:11:08 +0000 (12:11 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][Scratchbox] Use gold linker explicitly when available

        gold is faster at linking QtWebKit than binutils ld, but it cannot be
        enabled by default on a system that compiles other Qt projects.
        This is due to gold not supporting the --add-needed flag.

        Original patch by Kimmo Kinnunen.

        * common.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 12:06:18 +0000 (12:06 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Get proxy settings from environment (http[s]_proxy)

        If http_proxy and/or https_proxy are set in the environment,
        pass those in to QNetworkAccessManager.

        * WebProcess/qt/WebProcessMainQt.cpp:
        (WebKit::EnvHttpProxyFactory::EnvHttpProxyFactory):
        (WebKit::EnvHttpProxyFactory::initializeFromEnvironment):
        (WebKit::EnvHttpProxyFactory::queryProxy):
        (WebKit::initializeProxy):
        (WebKit::WebProcessMainQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 11:56:18 +0000 (11:56 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add 'valgrind' build mode

        Passing CONFIG+=valgrind to qmake will now build WebKit in a way
        suitable for debugging with Valgrind.

        Original patch by Christian Sejersen.

        * WebKit.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 11:53:48 +0000 (11:53 +0000)]
2010-11-16  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Emit windowCloseRequested signal on window.close()

        Original patch by Zalan Bujtas.

        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_close):
        * UIProcess/API/qt/qwkpage.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 11:50:02 +0000 (11:50 +0000)]
2010-11-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Kill the web process if the UI process dies

        Connect UI (parent) process death signal to SIGKILL of the web
        process (child). This ensures that there's no stale web processes
        after the UI process has crashed.

        Original patch by Kimmo Kinnunen.

        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
        (WebKit::QtWebProcess::QtWebProcess):
        (WebKit::QtWebProcess::setupChildProcess):
        (WebKit::ProcessLauncherHelper::launch):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 16 Nov 2010 11:45:57 +0000 (11:45 +0000)]
2010-11-16  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, chromium test expectation update.

        Update chromium baselines following r72063
        https://bugs.webkit.org/show_bug.cgi?id=49591

        * platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Added.
        * platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 16 Nov 2010 11:34:36 +0000 (11:34 +0000)]
2010-11-16  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, chromium test expectation update.

        Update chromium baselines following r72050
        https://bugs.webkit.org/show_bug.cgi?id=49590

        * platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
        * platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt:
        * platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
        * platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Trivial build fix for building WebKit2 inside Qt Creator
hausmann@webkit.org [Tue, 16 Nov 2010 11:31:44 +0000 (11:31 +0000)]
[Qt] Trivial build fix for building WebKit2 inside Qt Creator

Rubber-stamped by Andreas Kling.

Similar to WebCore.pro, define a fallback for OUTPUT_DIR.

* WebKit2.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Tue, 16 Nov 2010 11:10:55 +0000 (11:10 +0000)]
2010-11-16  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, chromium test expectation update.

        Update chromium baselines following r72052
        https://bugs.webkit.org/show_bug.cgi?id=49588

        * platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
        * platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
        * platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum:
        * platform/chromium-linux/fast/forms/placeholder-stripped-expected.png:
        * platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.checksum:
        * platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.png:
        * platform/chromium-linux/fast/forms/search-styled-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/search-styled-expected.png: Added.
        * platform/chromium-linux/fast/forms/search-styled-expected.txt: Added.
        * platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
        * platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
        * platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
        * platform/chromium-mac/fast/css/pseudo-cache-stale-expected.png: Added.
        * platform/chromium-mac/fast/forms/isindex-placeholder-expected.checksum:
        * platform/chromium-mac/fast/forms/isindex-placeholder-expected.png:
        * platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.png: Added.
        * platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
        * platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/placeholder-stripped-expected.png: Added.
        * platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.png: Added.
        * platform/chromium-mac/fast/forms/search-styled-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/search-styled-expected.png: Added.
        * platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
        * platform/chromium-win-xp/fast/forms/search-styled-expected.checksum: Removed.
        * platform/chromium-win-xp/fast/forms/search-styled-expected.png: Removed.
        * platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
        * platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
        * platform/chromium-win/fast/forms/isindex-placeholder-expected.txt:
        * platform/chromium-win/fast/forms/password-placeholder-expected.txt:
        * platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.checksum:
        * platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
        * platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt:
        * platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum:
        * platform/chromium-win/fast/forms/placeholder-stripped-expected.png:
        * platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
        * platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/chromium-win/fast/forms/search-styled-expected.checksum:
        * platform/chromium-win/fast/forms/search-styled-expected.png:
        * platform/chromium-win/fast/forms/search-styled-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/search-styled-expected.txt.
        * platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
        * platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.png:
        * platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
        * platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 16 Nov 2010 10:59:50 +0000 (10:59 +0000)]
2010-11-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extract HTML title setter in treeoutline.js.
        https://bugs.webkit.org/show_bug.cgi?id=49540

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        * inspector/front-end/treeoutline.js:
        (TreeElement.prototype.get titleHTML):
        (TreeElement.prototype.set titleHTML):
        (TreeElement.prototype._setListItemNodeContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Tue, 16 Nov 2010 10:54:20 +0000 (10:54 +0000)]
2010-11-16  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Assert that DeviceOrientationClientMock is used by only one controller.
        https://bugs.webkit.org/show_bug.cgi?id=48506

        This is a design constraint of the DeviceOrientationClientMock because the
        m_controller field can only store a pointer to a single instance of the
        corresponding DeviceOrientationController.

        * platform/mock/DeviceOrientationClientMock.cpp:
        (WebCore::DeviceOrientationClientMock::setController):
2010-11-16  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
        https://bugs.webkit.org/show_bug.cgi?id=48506

        This ensures that there is one mock per page WebView / WebViewHost. This is a
        design constraint of the DeviceOrientationClientMock because the m_controller
        field can only store a pointer to a single instance of the corresponding
        DeviceOrientationController.

        Test: fast/dom/DeviceOrientation/no-page-cache.html

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setMockDeviceOrientation):
        (LayoutTestController::deviceOrientationClientMock):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::deviceOrientationClientMock):
        (WebViewHost::deviceOrientationClient):
        (WebViewHost::reset):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update Qt specific expected results after r72052.
ossy@webkit.org [Tue, 16 Nov 2010 10:51:27 +0000 (10:51 +0000)]
Unreviewed. Update Qt specific expected results after r72052.

* platform/qt/fast/css/pseudo-cache-stale-expected.txt:
* platform/qt/fast/forms/isindex-placeholder-expected.txt:
* platform/qt/fast/forms/placeholder-stripped-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago.
ossy@webkit.org [Tue, 16 Nov 2010 10:29:16 +0000 (10:29 +0000)]
.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 16 Nov 2010 09:21:25 +0000 (09:21 +0000)]
2010-11-16  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, updated test expectations for GTK and skip tests using
        computedStyleIncludingVisitedInfo which is not currently supported
        in GTK.

        * platform/gtk/Skipped:
        * platform/gtk/fast/forms/isindex-placeholder-expected.txt:
        * platform/gtk/fast/forms/password-placeholder-expected.txt:
        * platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
        * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 16 Nov 2010 09:01:12 +0000 (09:01 +0000)]
2010-11-16  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Remove platform dependent include directories
        https://bugs.webkit.org/show_bug.cgi?id=49553

        * CMakeLists.txt:
2010-11-16  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Add platform dependent include directories
        https://bugs.webkit.org/show_bug.cgi?id=49553

        * CMakeListsEfl.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-16 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 16 Nov 2010 08:44:09 +0000 (08:44 +0000)]
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
        https://bugs.webkit.org/show_bug.cgi?id=48634

        Re-enable fast/images/size-failure.html now that it passes and doesn't
        affect subsequent tests.

        * platform/chromium/test_expectations.txt:
2010-11-16  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
        https://bugs.webkit.org/show_bug.cgi?id=48634

        Specify the capacity when calling CFDataCreateMutable, which can signal
        malloc failures (by returning NULL), unlike CFDataSetLength.

        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::RGBA32Buffer::setSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Tue, 16 Nov 2010 08:10:25 +0000 (08:10 +0000)]
2010-11-15  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dirk Schulze and Darin Adler.

        requiredFeatures does not adapt to SVGStringList changes
        https://bugs.webkit.org/show_bug.cgi?id=40887

        Centralize the const_cast handling and only do it if needed.
        Remove the const_cast in all svgAttributeChanged functions and move
        it to SVGTest::handleAttributeChange. Add an early return to
        handleAttributeChange to avoid unnecessary const_casts.

        No tests necessary as functionality has not changed.

        * svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::svgAttributeChanged):
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::svgAttributeChanged):
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::svgAttributeChanged):
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::svgAttributeChanged):
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::svgAttributeChanged):
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::svgAttributeChanged):
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::svgAttributeChanged):
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::svgAttributeChanged):
        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::svgAttributeChanged):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::svgAttributeChanged):
        * svg/SVGTests.cpp:
        (WebCore::SVGTests::handleAttributeChange):
        * svg/SVGTests.h:
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::svgAttributeChanged):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::svgAttributeChanged):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisabled a test that was failing intermittently due to https://bugs.webkit.org/show_b...
mitz@apple.com [Tue, 16 Nov 2010 07:16:54 +0000 (07:16 +0000)]
Disabled a test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579

Rubber-stamped by Mark Rowe.

* fast/block/float/015.html: Removed.
* fast/block/float/015.html-disabled: Copied from LayoutTests/fast/block/float/015.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 49577 - Function.prototype should be non-configurable
barraclough@apple.com [Tue, 16 Nov 2010 06:05:38 +0000 (06:05 +0000)]
Bug 49577 - Function.prototype should be non-configurable

Reviewed by Sam Weinig.

JavaScriptCore:

JSC lazily allocates the prototype property of Function objects.

We check the prototype exists on 'get', but not on 'put'.
If you 'put' without having first done a 'get' you can end up with a configurable
prototype (prototype should only ever be non-configurable).

This is visible in a couple of ways:
  * 'delete' on the property may succeed. (the next access will result in a new,
  reset prototype object).
  * the prototype may be set to a getter.

* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyNames):
    Reify the prototype property before allowing an enumerate including don't enum properties.
(JSC::JSFunction::put):
    Reify the prototype property before any put to it.

LayoutTests:

* fast/js/script-tests/Object-getOwnPropertyNames.js:
* fast/js/Object-getOwnPropertyNames-expected.txt:
    Object.getOwnPropertyNames should enumerate the 'prototype' property on Functions.

* fast/js/function-prototype-descriptor.html: Added.
* fast/js/function-prototype-descriptor-expected.txt: Added.
* fast/js/script-tests/function-prototype-descriptor.js: Added.
    Test the attributes of Functions' prototype properties.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 16 Nov 2010 05:35:34 +0000 (05:35 +0000)]
2010-11-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=49569

        * fast/events/remove-shadow-host-crash-expected.txt: Added.
        * fast/events/remove-shadow-host-crash.html: Added.
2010-11-15  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
        https://bugs.webkit.org/show_bug.cgi?id=49569

        Test: fast/events/remove-shadow-host-crash.html

        * rendering/TextControlInnerElements.h:
        (WebCore::TextControlInnerElement::isShadowNode):
        (WebCore::TextControlInnerElement::shadowParentNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix test broken by earlier patch.
barraclough@apple.com [Tue, 16 Nov 2010 05:26:40 +0000 (05:26 +0000)]
Fix test broken by earlier patch.

Reviewed by NOBODY build fix.

* tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 16 Nov 2010 05:23:34 +0000 (05:23 +0000)]
2010-11-12  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        ScriptElement rather than HTMLScriptElement and SVGScriptElement should have ScriptElementData
        https://bugs.webkit.org/show_bug.cgi?id=49469

        Moved m_data, scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript from
        HTMLScriptElement and SVGScriptElement to ScriptElementData.

        Also made insertedIntoDocument, removedFromDocument, childrenChanged, finishParsingChildren,
        and handleSourceAttribute of ScriptElement non-static.

        No new tests are added since this is a cleanup.

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::scriptCharset): Added.
        (WebCore::ScriptElement::scriptContent): Added.
        (WebCore::ScriptElement::shouldExecuteAsJavaScript): Added.
        (WebCore::ScriptElement::executeScript): Added.
        (WebCore::ScriptElement::insertedIntoDocument): Made non-static. Accesses m_data.
        (WebCore::ScriptElement::removedFromDocument): Ditto.
        (WebCore::ScriptElement::childrenChanged): Ditto.
        (WebCore::ScriptElement::finishParsingChildren): Ditto.
        (WebCore::ScriptElement::handleSourceAttribute): Ditto.
        * dom/ScriptElement.h: Moved the declaration of ScriptElement after that of ScriptElementData
        because ScriptElement has to instantiate ScriptElementData.
        (WebCore::ScriptElement::ScriptElement): Initializes m_data.
        * html/HTMLScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript.
        (WebCore::HTMLScriptElement::HTMLScriptElement): Initializes ScriptElement instead of ScriptElementData.
        (WebCore::HTMLScriptElement::childrenChanged): Calls ScriptElement::childrenChanged.
        (WebCore::HTMLScriptElement::parseMappedAttribute): Calls ScriptElement::handleSourceAttribute.
        (WebCore::HTMLScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren.
        (WebCore::HTMLScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument.
        (WebCore::HTMLScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument.
        * html/HTMLScriptElement.h:
        * svg/SVGScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript.
        (WebCore::SVGScriptElement::SVGScriptElement): Initializes ScriptElement instead of ScriptElementData.
        (WebCore::SVGScriptElement::svgAttributeChanged): Calls ScriptElement::handleSourceAttribute.
        (WebCore::SVGScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument.
        (WebCore::SVGScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument.
        (WebCore::SVGScriptElement::childrenChanged): Calls ScriptElement::childrenChanged.
        (WebCore::SVGScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren.
        * svg/SVGScriptElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor HTMLInputElement: Move a part of HTMLInputElement::
tkent@chromium.org [Tue, 16 Nov 2010 05:13:20 +0000 (05:13 +0000)]
Refactor HTMLInputElement: Move a part of HTMLInputElement::
defaultEventHandler() to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=48317

Reviewed by Darin Adler.

Move out the followings to InputTypes:
 - click event processing,
 - the first keydown event processing, and
 - DOMActivate event processing.

Move m_xPos and m_yPos from HTMLInputElement to ImageInputType as
m_clickLocation. It's ok to move them because they should be valid only
when HTMLInputElement::m_activeSubmit is true. For type=image,
m_activeSubmit is true only in DOMActivate event handling. So we reset
m_clickLocation in handleDOMActivateEvent() with Event::underlyingEvent().

No new tests because this is just a refactoring.

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):
* html/BaseDateAndTimeInputType.h:
* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLInputElement.h:
* html/ImageInputType.cpp:
(WebCore::ImageInputType::appendFormData):
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/ImageInputType.h:
* html/InputType.cpp:
(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):
* html/InputType.h:
* html/NumberInputType.cpp:
(WebCore::NumberInputType::handleKeydownEvent):
* html/NumberInputType.h:
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleClickEvent):
* html/RadioInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
* html/RangeInputType.h:
* html/ResetInputType.cpp:
(WebCore::ResetInputType::handleDOMActivateEvent):
* html/ResetInputType.h:
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent):
* html/SubmitInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton):
* html/TextFieldInputType.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Tue, 16 Nov 2010 05:12:42 +0000 (05:12 +0000)]
2010-11-15  Nat Duca  <nduca@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Make WebWidget actively notify client when compositing enables.
        https://bugs.webkit.org/show_bug.cgi?id=49396

        * public/WebWidgetClient.h:
        (WebKit::WebWidgetClient::didAcceleratedCompositingEnable):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::scrollRootLayerRect):
        (WebKit::WebViewImpl::invalidateRootLayerRect):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 16 Nov 2010 04:53:34 +0000 (04:53 +0000)]
2010-11-15  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add AudioNode custom bindings
        https://bugs.webkit.org/show_bug.cgi?id=49119

        No new tests since audio API is not yet implemented.

        * bindings/js/JSAudioNodeCustom.cpp: Added.
        (WebCore::JSAudioNode::connect):
        (WebCore::JSAudioNode::disconnect):
        * bindings/v8/custom/V8AudioNodeCustom.cpp: Added.
        (WebCore::V8AudioNode::connectCallback):
        (WebCore::V8AudioNode::disconnectCallback):
        * webaudio/AudioNode.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=49570
hyatt@apple.com [Tue, 16 Nov 2010 04:45:01 +0000 (04:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49570

Reviewed by Dan Bernstein.

Put italics specialization check back in CSSFontSelector.  I had to back it out, since it broke
a layout test, and the issue was that local font fallback fonts should not be considered by the
specialization check (since you never want to pick a fallback over an actual @font-face rule if
the @font-face rule can handle it).

* css/CSSFontFace.h:
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::isLocalFallback):
(WebCore::CSSFontFace::CSSFontFace):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::compareFontFaces):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Tue, 16 Nov 2010 04:13:42 +0000 (04:13 +0000)]
2010-11-15  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] ZoomTextOnly doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=49568

        Check QWebSettings::ZoomTextOnly attribute before applying zoom

        * Api/qwebframe.cpp:
        (QWebFrame::textSizeMultiplier):
        (QWebFrame::setZoomFactor):
        (QWebFrame::zoomFactor):
        * Api/qwebframe_p.h:
        (QWebFramePrivate::QWebFramePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 16 Nov 2010 03:37:22 +0000 (03:37 +0000)]
2010-11-15  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Add additional flags to cmakeconfig.h
        https://bugs.webkit.org/show_bug.cgi?id=49556

        * cmake/OptionsEfl.cmake:
        * cmakeconfig.h.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 16 Nov 2010 02:13:34 +0000 (02:13 +0000)]
2010-11-15  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/drt_expectations.txt:
         Fix duplicated entries added in r72045.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for: https://bugs.webkit.org/show_bug.cgi?id=49452
adele@apple.com [Tue, 16 Nov 2010 02:09:43 +0000 (02:09 +0000)]
WebCore: Fix for: https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

There's no need to swap the placeholder text in and out of the inner text element.  Instead, just paint the text.
This reduces complexity and makes it easier to make independent decisions about the placeholder text and the text control value.

* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):
Since updatePlaceholderVisibility checks the value, set the value before calling updatePlaceholderVisibility.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::updatePlaceholderVisibility): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControl::paintObject):  Paint the placeholder text during the background phase.
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::nodeAtPoint): Remove custom hit testing that tried to avoid hitting the placeholder text at the wrong time.
(WebCore::RenderTextControlMultiLine::updateFromElement):  Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlMultiLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlMultiLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlMultiLine::textBoxInsetRight): Added.
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlSingleLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlSingleLine::textBoxInsetRight): Added.
* rendering/RenderTextControlSingleLine.h:
* rendering/TextControlInnerElements.cpp: Removed custom hit testing that tried to avoid hitting the placeholder text at the wrong time.

LayoutTests: Test for: https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

The only visual change that occurred is in pseudo-cache-stale.html.  The placeholder text did not
use to paint over the spot where the cancel button will display.  Since the cancel button is not
present when the placeholder is drawn, now the placeholder text can draw to the edge of the field.

* platform/mac/fast/css/pseudo-cache-stale-expected.checksum:
* platform/mac/fast/css/pseudo-cache-stale-expected.png:
* platform/mac/fast/css/pseudo-cache-stale-expected.txt:
* platform/mac/fast/forms/isindex-placeholder-expected.txt:
* platform/mac/fast/forms/password-placeholder-expected.txt:
* platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
* platform/mac/fast/forms/placeholder-stripped-expected.txt:
* platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 49488 - Only add source specific information to exceptions in Interpreter::throwE...
barraclough@apple.com [Tue, 16 Nov 2010 01:30:25 +0000 (01:30 +0000)]
Bug 49488 - Only add source specific information to exceptions in Interpreter::throwException

Reviewed by Geoff Garen.

JavaScriptCore:

Three types of source location information are added to errors.

(1) Divot information.

This was added with the intention of using it to provide better source highlighting in the inspector.
We may still want to do so, but we probably should not be exposing these values in a manner visible to
user scripts – only through an internal C++ interface. The code adding divot properties to objects has
been removed.

(2) Line number information.

Line number information is presently sometimes added at the point the exception is created, and sometimes
added at the point the exception passes through throwException. Change this so that throwException has
the sole responsibility for adding line number and source file information.

(3) Source snippets in the message of certain type errors (e.g. 'doc' in `Result of expression 'doc' [undefined] is not an object.`).

These messages are currently created at the point the exceptions is raised. Instead reformat the message
such that the source snippet is located at the end (`Result of expression 'b1' [undefined] is not an object.`
becomes `'undefined' is not an object (evaluating 'b1.property')`), and append these to the message at
the in throw Exception. This presents a number of advantages:
  * we no longer need to have source location information to create these TypeErrors.
  * we can chose to append source location information in other error messages, including those where
    passing source location to the point of construction would be inconvenient.
  * we can chose in future to omit to append source location information when running in a non-debug mode.

This also cleans up some error output, e.g. removing double brackets ('[[]]') around objects in output,
removing double periods (..) at end of lines, and adding slightly more context to some errors.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::expressionRangeForBytecodeOffset):
    - Separated called to access line and range information.

* bytecode/CodeBlock.h:
    - Separated called to access line and range information.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::isInvalidParamForIn):
(JSC::isInvalidParamForInstanceOf):
    - Update parameters passed to error constructors.
(JSC::appendSourceToError):
    - Update message property to add location information (previously added in createErrorMessage, in ExceptionHelpers)
(JSC::Interpreter::throwException):
    - Updated to call appendSourceToError.
(JSC::Interpreter::privateExecute):
    - Update parameters passed to error constructors.

* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
    - Update parameters passed to error constructors.

* runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::hasErrorInfo):
    - Removed divot properties.

* runtime/Error.h:
    - Removed divot properties.

* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
    - Initialize new property.

* runtime/ErrorInstance.h:
(JSC::ErrorInstance::appendSourceToMessage):
(JSC::ErrorInstance::setAppendSourceToMessage):
(JSC::ErrorInstance::clearAppendSourceToMessage):
    - Added flag to check for errors needing location information appending.
(JSC::ErrorInstance::isErrorInstance):
    - Added virtual method to check for ErrorInstances.

* runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
    - Update parameters passed to error constructors, stopped adding line number information early, changed TypeError messages.

* runtime/ExceptionHelpers.h:
    - Updated function signatures.

* runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
    - Update parameters passed to error constructors.

* runtime/JSObject.h:
(JSC::JSObject::isErrorInstance):
    - Added virtual method to check for ErrorInstances.

LayoutTests:

Updated results to account for changes in TypeError messages.
(e.g. `Result of expression 'b1' [undefined] is not an object.` -> `'undefined' is not an object (evaluating 'b1.property')`).

* fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
* fast/css/resources/font-face-descriptor-multiple-values-parsing.js:
* fast/css/variables/color-hex-test-expected.txt:
* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/Range/getClientRects-expected.txt:
* fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
* fast/dom/SelectorAPI/dumpNodeList-expected.txt:
* fast/forms/select-namedItem-expected.txt:
* fast/js/basic-strict-mode-expected.txt:
* fast/js/date-toisostring-expected.txt:
* fast/js/delete-getters-setters-expected.txt:
* fast/js/exception-expression-offset-expected.txt:
* fast/js/exception-for-nonobject-expected.txt:
* fast/js/exception-thrown-from-new-expected.txt:
* fast/js/exception-thrown-from-new.html:
* fast/js/instance-of-immediates-expected.txt:
* fast/js/script-tests/exception-expression-offset.js:
(testException):
* fast/js/sputnik/Conformance/08_Types/8.6_The_Object_Type/8.6.2_Internal_Properties_and_Methods/S8.6.2_A7-expected.txt:
* fast/js/sputnik/Conformance/13_Function_Definition/S13_A17_T2-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T1-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T2-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.2_Object.prototype.toString/S15.2.4.2_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.3_Object.prototype.toLocaleString/S15.2.4.3_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.4_Object.prototype.valueOf/S15.2.4.4_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.5_Object.prototype.hasOwnProperty/S15.2.4.5_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.6_Object.prototype.isPrototypeOf/S15.2.4.6_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.7_Object.prototype.propertyIsEnumerable/S15.2.4.7_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A3-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A4-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/S15.3.4_A5-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7-expected.txt:
* fast/xsl/transform-xhr-doc-expected.txt:
* http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
* java/lc3/ArrayMethods/byte-001-expected.txt:
* java/lc3/CallStatic/object-001-expected.txt:
* java/lc3/ConvertBoolean/boolean-007-n-expected.txt:
* java/lc3/ConvertBoolean/boolean-008-n-expected.txt:
* java/lc3/ConvertBoolean/boolean-009-n-expected.txt:
* java/lc3/ConvertBoolean/boolean-010-n-expected.txt:
* java/lc3/ConvertBoolean/boolean-011-n-expected.txt:
* java/lc3/ConvertBoolean/boolean-012-n-expected.txt:
* java/lc3/ConvertBoolean/boolean-013-n-expected.txt:
* java/lc3/ConvertBoolean/boolean-014-expected.txt:
* java/lc3/ConvertNull/null-001-expected.txt:
* java/lc3/ConvertNumber/number-011-expected.txt:
* java/lc3/ConvertString/string-006-expected.txt:
* java/lc3/ConvertString/string-007-n-expected.txt:
* java/lc3/ConvertUndefined/undefined-002-expected.txt:
* java/lc3/ConvertUndefined/undefined-003-expected.txt:
* java/lc3/JSBoolean/boolean-005-n-expected.txt:
* java/lc3/JSNumber/ToDouble-002-expected.txt:
* java/lc3/JSObject/ToJSObject-001-expected.txt:
* java/lc3/JSObject/ToObject-001-expected.txt:
* java/lc3/JavaObject/JavaObjectFieldOrMethod-001-expected.txt:
* platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
* platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
* platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
* platform/mac/compositing/reflections/reflection-opacity-expected.txt:
* platform/mac/fast/css/variables/remove-variable-test-expected.txt:
* platform/mac/fast/css/variables/set-variable-test-expected.txt:
* platform/mac/fast/css/variables/variable-iteration-test-expected.txt:
* platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
* platform/mac/svg/custom/createelement-expected.txt:
* platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
* plugins/npruntime/object-from-destroyed-plugin-expected.txt:
* plugins/npruntime/plugin-scriptable-object-invoke-default-expected.txt:
* svg/custom/use-nested-missing-target-removed-expected.txt:
* svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 16 Nov 2010 01:23:38 +0000 (01:23 +0000)]
2010-11-15  Andreas Kling  <kling@webkit.org>

        Unreviewed buildfix (Qt WebKit2 minimal)

        * platform/qt/CookieJarQt.cpp: Add missing <QStringList> include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 16 Nov 2010 01:22:00 +0000 (01:22 +0000)]
2010-11-15  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
        https://bugs.webkit.org/show_bug.cgi?id=49357

        No new tests since audio API is not yet implemented.

        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * bindings/v8/custom/V8EventCustom.cpp:
        (WebCore::toV8):
        * dom/Event.cpp:
        (WebCore::Event::isAudioProcessingEvent):
        * dom/Event.h:
        * dom/EventNames.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toJavaScriptAudioNode):
        * dom/EventTarget.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 16 Nov 2010 01:05:13 +0000 (01:05 +0000)]
    Reviewed by Darin Adler.

        A minor style fix in StyledElement.cpp.

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::addCSSProperty):
        (WebCore::StyledElement::addCSSImageProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 16 Nov 2010 01:03:10 +0000 (01:03 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49565
        Remove Attr.style accessor

        * dom/Attr.idl: Only keep the accessor for Objective C API. Inspector doesn't seem to need
        it any more.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 16 Nov 2010 00:40:16 +0000 (00:40 +0000)]
2010-11-15  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/drt_expectations.txt:
          Update for the recent status of Chromium-Linux DRT.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnskip fast/forms/submit-form-attributes.html.
aestes@apple.com [Mon, 15 Nov 2010 23:30:50 +0000 (23:30 +0000)]
Unskip fast/forms/submit-form-attributes.html.

* platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=49555
bdakin@apple.com [Mon, 15 Nov 2010 22:59:29 +0000 (22:59 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=49555
Frame::scalePage() should treat the origin as an absolute
coordinate
-and corresponding-
<rdar://problem/8667138>

Reviewed by Darin Adler.

* page/Frame.cpp:
(WebCore::Frame::scalePage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed a weird typo
mitz@apple.com [Mon, 15 Nov 2010 22:30:44 +0000 (22:30 +0000)]
Fixed a weird typo

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8662770> Error image has incorrect size when a custom font is used
mitz@apple.com [Mon, 15 Nov 2010 22:27:06 +0000 (22:27 +0000)]
<rdar://problem/8662770> Error image has incorrect size when a custom font is used

Reviewed by Darin Adler.

WebCore:

Test: fast/images/style-access-during-imageChanged-crash.html

* rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage): Added initialization of m_needsToSetSizeForAltText.
(WebCore::RenderImage::imageSizeForError): Factored the non-alt-text dependent size computation
out of setImageSizeForAltText() into this function.
(WebCore::RenderImage::setImageSizeForAltText): Changed to use imageSizeForError().
(WebCore::RenderImage::styleDidChange): Added. If m_needsToSetSizeForAltText is true, sets the
intrinsic size and calls imageDimensionsChanged() as needed to cause layout or invalidation.
(WebCore::RenderImage::imageChanged): Moved som comed from here...
(WebCore::RenderImage::imageDimensionsChanged): ...to here.
* rendering/RenderImage.h:

LayoutTests:

* fast/images/style-access-during-imageChanged-crash-expected.txt: Added.
* fast/images/style-access-during-imageChanged-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 15 Nov 2010 22:16:54 +0000 (22:16 +0000)]
2010-11-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Make sure qwkpage.h and qwkpreferences.h are copied into includes/WebKit2

        * UIProcess/API/qt/WKView.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoASSERTION (r72003): Assertion failure when running layout tests
andersca@apple.com [Mon, 15 Nov 2010 22:08:31 +0000 (22:08 +0000)]
ASSERTION (r72003): Assertion failure when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=49561

Reviewed by Dimitri Glazkov.

r72003 added the 'formaction' URL attribute to HTMLButtonElement and HTMLInputElement,
but did not add the attribute to the isURLAttribute which lead to assertion failures
when running the layout tests with a debug build.

* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::isURLAttribute):
* html/HTMLButtonElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isURLAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 15 Nov 2010 22:07:13 +0000 (22:07 +0000)]
2010-11-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Use $${PYTHON} rather than "python" to execute Python scripts

        Fixes building with the old Python that currently ships with Scratchbox.

        * DerivedSources.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Mon, 15 Nov 2010 21:52:10 +0000 (21:52 +0000)]
2010-11-15  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49559
        DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString

        No observable change in behavior, so no tests.

        * page/DOMWindow.idl: Added ConvertUndefinedOrNullToNullString.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agor72003 caused fast/forms/submit-form-attributes.html to crash
aestes@apple.com [Mon, 15 Nov 2010 21:50:15 +0000 (21:50 +0000)]
r72003 caused fast/forms/submit-form-attributes.html to crash
DumpRenderTree on the Leopard Intel Debug (Tests) bot. Skip this test
until the failure is resolved.
https://bugs.webkit.org/show_bug.cgi?id=49562

* platform/mac-leopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 15 Nov 2010 21:46:36 +0000 (21:46 +0000)]
2010-11-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] Make WTF_USE_MEEGOTOUCH available for WebKit2 as well

        Move this into WebCore/features.pri which is used by both WebCore and WebKit2.

        * WebCore.pro:
        * features.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 15 Nov 2010 21:42:48 +0000 (21:42 +0000)]
2010-11-15  Martin Robinson  <mrobinson@igalia.com>

        Build fix for GTK+.

        * GNUmakefile.am: Add some missing generated files to the source list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 15 Nov 2010 21:38:22 +0000 (21:38 +0000)]
2010-11-15  Zhenyao Mo  <zmo@google.com>

        Ubreviewed, remove an empty line that causes the test to fail.

        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 15 Nov 2010 21:33:16 +0000 (21:33 +0000)]
2010-11-15  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Avoid polling in WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=49542

        Make the WK2 testing session about 10-15% faster and decrease random flakiness
        resulting from timing skew by removing the millisecond polling from TestControllerQt.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::didFinishLoadForFrame):
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
        * WebKitTestRunner/mac/TestControllerMac.mm:
        (WTR::TestController::notifyDone): Add method stub.
        * WebKitTestRunner/qt/TestControllerQt.cpp:
        (WTR::TestControllerRunLoop::instance):
        (WTR::TestControllerRunLoop::start):
        (WTR::TestControllerRunLoop::stop):
        (WTR::TestControllerRunLoop::TestControllerRunLoop):
        (WTR::TestControllerRunLoop::timerEvent):
        (WTR::TestController::notifyDone):
        (WTR::TestController::platformRunUntil):
        * WebKitTestRunner/win/TestControllerWin.cpp:
        (WTR::TestController::notifyDone): Add method stub.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 15 Nov 2010 21:29:00 +0000 (21:29 +0000)]
2010-11-15  Zhenyao Mo  <zmo@google.com>

        Unreviewed, update gpu test expectations.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* win/WebKit2Generated.make:
beidson@apple.com [Mon, 15 Nov 2010 21:27:27 +0000 (21:27 +0000)]
* win/WebKit2Generated.make:

Reviewed by a better attempt at a Windows build fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
darin@apple.com [Mon, 15 Nov 2010 21:20:03 +0000 (21:20 +0000)]
* Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* win/WebKit2Generated.make: Add new API headers here.
beidson@apple.com [Mon, 15 Nov 2010 21:17:52 +0000 (21:17 +0000)]
* win/WebKit2Generated.make: Add new API headers here.

Reviewed by my attempt to fix the Windows build

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 15 Nov 2010 21:17:03 +0000 (21:17 +0000)]
2010-11-15  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Avoid copying of SkBitmap in LayerRendererChromium
        https://bugs.webkit.org/show_bug.cgi?id=49560

        Ran CSS 3D content to test. No other new tests.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateRootLayerTextureRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 15 Nov 2010 21:04:42 +0000 (21:04 +0000)]
2010-11-15  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Remove assumption that GL functions are function pointers
        https://bugs.webkit.org/show_bug.cgi?id=49486

        Added appropriate extension queries and no longer assume that GL
        function names are function pointers which can be tested.

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
        (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
        (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap):
        (WebKit::WebGraphicsContext3DDefaultImpl::getString):
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFinish off <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=48720
beidson@apple.com [Mon, 15 Nov 2010 20:47:15 +0000 (20:47 +0000)]
Finish off <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=48720
Customizable context menu support in WebKit2.

Reviewed by Sam Weinig.

- Adds an API-level WKContextMenuItem.
- Round trips through both the InjectedBundle client and the new PageContextMenuClient before
  actually displaying the menu.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

* Shared/API/c/WKBase.h:
* Shared/API/c/WKContextMenuItem.cpp: Added.
(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
* Shared/API/c/WKContextMenuItem.h: Added.
* Shared/API/c/WKContextMenuItemTypes.h: Added.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):

* Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::separatorItem):
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
* Shared/WebContextMenuItem.h:

* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageLoaderClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):
* UIProcess/API/C/WKPage.h:

* UIProcess/WebPageContextMenuClient.cpp: Added.
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
* UIProcess/WebPageContextMenuClient.h: Added.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeContextMenuClient):
(WebKit::WebPageProxy::showContextMenu):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems):
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd shouldDecodeSourceDataOfMIMEType WKContextDownloadClient callback
andersca@apple.com [Mon, 15 Nov 2010 20:46:39 +0000 (20:46 +0000)]
Add shouldDecodeSourceDataOfMIMEType WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49558

Reviewed by Sam Weinig.

* UIProcess/API/C/WKContext.h:
Add shouldDecodeSourceDataOfMIMEType callback.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
Call WebDownloadClient::shouldDecodeSourceDataOfMIMEType.

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Downloads/DownloadProxy.messages.in:
Add ShouldDecodeSourceDataOfMIMEType message.

* UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::shouldDecodeSourceDataOfMIMEType):
Call the WKContextDownloadClient.

(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

* UIProcess/WebDownloadClient.h:
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::shouldDecodeSourceDataOfMIMEType):
Send the ShouldDecodeSourceDataOfMIMEType message.

(WebKit::Download::decideDestinationWithSuggestedFilename):
Add allowOverwrite reply parameter.

* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
Call Download::shouldDecodeSourceDataOfMIMEType.

(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
Add allowOverwrite parameter.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Mon, 15 Nov 2010 20:25:00 +0000 (20:25 +0000)]
2010-11-15  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Fixes layer opacity implementation of composited layers
        https://bugs.webkit.org/show_bug.cgi?id=49233

        This introduces a fairly drastic change in how LayerRendererChromium draws
        composited layers. Layers that have non-zero opacity as well as layers that
        clip their descendants (and have non-trivial transforms) are now first
        rendered onto off-screen surfaces (RenderSurfaceChromium's). The compositing
        operation now consists of two distinct phases: First a hierarchical traversal
        of the layer tree to compute the layer transforms, determine what the necessary
        RenderSurfaces are and sort layer that preserve-3d based on their z-value. A second
        pass goes through all the RenderSurfaces discovered by the first pass and updates
        their contents.
        Additional significant side-effects of this change are:
        1. Depth buffer and depth testing is no longer used. Drawing relies on a painter's
           algorithm to render layers with the preserves-3d property from back to front using
           the Z coordinate of their center. This will further be improved in the future with
           the intoduction of a BSP tree to properly deal with intersecting layers.
        2. Compositor no longer uses the stencil buffer to do clipping. Clipping is now performed
           by rendering layer subtrees into an offscreen buffer and setting the appropriate
           scissor and viewport transformation.

        Tests: abs-position-inside-opacity.html (for the opacity implementation)
               and the rest of the compositing layout tests to verify that
               everything still works.

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::cleanupResources):
        (WebCore::ContentLayerChromium::requiresClippedUpdateRect):
        (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
        (WebCore::ContentLayerChromium::updateContents):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::LayerChromium):
        (WebCore::LayerChromium::cleanupResources):
        (WebCore::LayerChromium::createRenderSurface):
        (WebCore::LayerChromium::descendantsDrawContent):
        (WebCore::LayerChromium::descendantsDrawContentRecursive):
        * platform/graphics/chromium/LayerChromium.h:
        (WebCore::LayerChromium::drawTransform):
        (WebCore::LayerChromium::layerRenderer):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::orthoMatrix):
        (WebCore::isScaleOrTranslation):
        (WebCore::LayerRendererChromium::compareLayerZ):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::prepareToDrawLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::updateLayersRecursive):
        (WebCore::LayerRendererChromium::useRenderSurface):
        (WebCore::LayerRendererChromium::drawLayer):
        (WebCore::LayerRendererChromium::setScissorToRect):
        (WebCore::LayerRendererChromium::setDrawViewportRect):
        (WebCore::LayerRendererChromium::initializeSharedObjects):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/RenderSurfaceChromium.cpp: Added.
        (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
        (WebCore::RenderSurfaceChromium::~RenderSurfaceChromium):
        (WebCore::RenderSurfaceChromium::cleanupResources):
        (WebCore::RenderSurfaceChromium::layerRenderer):
        (WebCore::RenderSurfaceChromium::prepareContentsTexture):
        * platform/graphics/chromium/RenderSurfaceChromium.h: Added.
        (WebCore::RenderSurfaceChromium::contentRectCenter):
        (WebCore::RenderSurfaceChromium::contentRect):
        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::cleanupResources):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 15 Nov 2010 20:16:54 +0000 (20:16 +0000)]
2010-11-15  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Andreas Kling.

        [GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds
        https://bugs.webkit.org/show_bug.cgi?id=49549

        No new tests. This can be verified by loading any existing vertical text test
        in GtkLauncher and noticing the lack of CRITICAL GLib exceptions. There's currently
        no automatic way of verifying custom cursors.

        * platform/gtk/GtkVersioning.c:
        (gdk_pixbuf_get_from_surface): Reverse a sanity check in this method to be correct.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 15 Nov 2010 19:59:57 +0000 (19:59 +0000)]
2010-11-15  Zhenyao Mo  <zmo@google.com>

        Unreviewed, skip failing WebGL test.

        * platform/mac-snowleopard/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd decideDestinationWithSuggestedFilename WKContextDownloadClient callback
andersca@apple.com [Mon, 15 Nov 2010 19:48:40 +0000 (19:48 +0000)]
Add decideDestinationWithSuggestedFilename WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49554

Reviewed by Sam Weinig.

* Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::sendSync):
Add sendSync capabilities to Messagesender.

* UIProcess/API/C/WKContext.h:
AdddecideDestinationWithSuggestedFilename callback.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Call WebDownloadClient::decideDestinationWithSuggestedFilename.

* UIProcess/Downloads/DownloadProxy.messages.in:
Add DecideDestinationWithSuggestedFilename.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveSyncMessage):
Process MessageClassDownloadProxy messages.

* UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Ask the WKContextDownloadClient for the destination.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
MessageClassDownloadProxy messages should go to the WebContext.

* WebProcess/Downloads/Download.cpp:
(WebKit::Download::decideDestinationWithSuggestedFilename):
Send the DecideDestinationWithSuggestedFilename message.

* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
call Download::decideDestinationWithSuggestedFilename and set the destination.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-12 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 15 Nov 2010 19:39:16 +0000 (19:39 +0000)]
2010-11-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Brady Eidson.

        Can't view HTML5 video when running Safari with an authenticated proxy server
        <rdar://problem/8351926>

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 15 Nov 2010 19:08:24 +0000 (19:08 +0000)]
2010-11-15  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [WK2][Qt] Add "page snapshot" functionality to tiled backing store

        Original patch by Antti Koivisto.

        Add a way to take a snapshot of a specific part of the page, at a specific scale.
        Only implemented for the tiled drawing area.

        * Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
        New message: TakeSnapshot.

        * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
        New message: SnapshotTaken.

        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::takeSnapshot):
        Expose the snapshot functionality.

        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::TiledDrawingAreaProxy::didReceiveMessage):
        (WebKit::TiledDrawingAreaProxy::takeSnapshot):
        * UIProcess/TiledDrawingAreaProxy.h:
        * UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
        (WebKit::TiledDrawingAreaProxy::snapshotTaken):
        * WebProcess/WebPage/TiledDrawingArea.cpp:
        (WebKit::TiledDrawingArea::didReceiveMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 15 Nov 2010 18:58:42 +0000 (18:58 +0000)]
2010-11-15  Martin Robinson  <mrobinson@igalia.com>

        [GTK] Navigation policy decision API needs to include the DOM node that the decision originated from
        https://bugs.webkit.org/show_bug.cgi?id=49551

        Add GTK+-specific results for these tests which do policy delegate dumps,
        until GTK+ can produce the "originating from" information.

        * platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
        * platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 15 Nov 2010 18:45:22 +0000 (18:45 +0000)]
2010-11-15  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 15 Nov 2010 18:37:05 +0000 (18:37 +0000)]
2010-11-14  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Event dispatch call can blow away the node's renderer initialized
        before the call in updateSelectionForMouseDrag function. We need
        to initialize it after the call.
        https://bugs.webkit.org/show_bug.cgi?id=49524

        * page/EventHandler.cpp:
        (WebCore::EventHandler::updateSelectionForMouseDrag):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-12 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 15 Nov 2010 17:42:45 +0000 (17:42 +0000)]
2010-11-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        [Chromium] fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html is a flaky crash
        https://bugs.webkit.org/show_bug.cgi?id=48142

        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html: Cleanup the test, hoping to stop flaky crashes on chromium bots.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 15 Nov 2010 17:35:50 +0000 (17:35 +0000)]
2010-11-15  Martin Robinson  <mrobinson@igalia.com>

        Add some baselines for new tests and skip a HTML5 meter test until
        GTK+ supports rendering the meter element.

        * platform/gtk/Skipped: Skip meter test.
        * platform/gtk/fast/block/basic/truncation-rtl-expected.txt: Added.
        * platform/gtk/fast/blockflow/background-horizontal-bt-expected.txt: Added.
        * platform/gtk/fast/blockflow/background-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/background-vertical-rl-expected.txt: Added.
        * platform/gtk/fast/blockflow/basic-vertical-line-expected.txt: Added.
        * platform/gtk/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
        * platform/gtk/fast/blockflow/body-direction-propagation-expected.txt: Added.
        * platform/gtk/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
        * platform/gtk/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-image-horizontal-bt-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-image-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-image-vertical-rl-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/border-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
        * platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
        * platform/gtk/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
        * platform/gtk/fast/blockflow/broken-ideographic-font-expected.txt: Added.
        * platform/gtk/fast/blockflow/english-bt-text-expected.txt: Added.
        * platform/gtk/fast/blockflow/english-lr-text-expected.txt: Added.
        * platform/gtk/fast/blockflow/english-rl-text-expected.txt: Added.
        * platform/gtk/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
        * platform/gtk/fast/blockflow/japanese-lr-selection-expected.txt: Added.
        * platform/gtk/fast/blockflow/japanese-lr-text-expected.txt: Added.
        * platform/gtk/fast/blockflow/japanese-rl-selection-expected.txt: Added.
        * platform/gtk/fast/blockflow/japanese-rl-text-expected.txt: Added.
        * platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
        * platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
        * platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
        * platform/gtk/fast/blockflow/vertical-font-fallback-expected.txt: Added.
        * platform/gtk/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
        * platform/gtk/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
        * platform/gtk/fast/borders/border-radius-inline-flow-expected.txt: Added.
        * platform/gtk/fast/images/gray-scale-png-with-color-profile-expected.txt: Added.
        * platform/gtk/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
        * platform/gtk/fast/lists/001-vertical-expected.txt: Added.
        * platform/gtk/fast/lists/002-vertical-expected.txt: Added.
        * platform/gtk/fast/lists/003-vertical-expected.txt: Added.
        * platform/gtk/fast/lists/005-vertical-expected.txt: Added.
        * platform/gtk/fast/lists/006-vertical-expected.txt: Added.
        * platform/gtk/fast/lists/007-vertical-expected.txt: Added.
        * platform/gtk/fast/lists/008-vertical-expected.txt: Added.
        * platform/gtk/fast/lists/009-vertical-expected.txt: Added.
        * platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
        * platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
        * platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
        * platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
        * platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
        * platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
        * platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
        * platform/gtk/fast/repaint/selection-rl-expected.txt: Added.
        * platform/gtk/fast/table/027-vertical-expected.txt: Added.
        * platform/gtk/fast/table/028-vertical-expected.txt: Added.
        * platform/gtk/fast/table/035-vertical-expected.txt: Added.
        * platform/gtk/fast/table/038-vertical-expected.txt: Added.
        * platform/gtk/fast/table/040-vertical-expected.txt: Added.
        * platform/gtk/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
        * platform/gtk/fast/table/border-collapsing/001-vertical-expected.txt: Added.
        * platform/gtk/fast/table/border-collapsing/002-vertical-expected.txt: Added.
        * platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt: Added.
        * platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt: Added.
        * platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
        * platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
        * platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
        * platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt: Added.
        * platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
        * platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
        * platform/gtk/fast/table/height-percent-test-vertical-expected.txt: Added.
        * platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
        * platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
        * platform/gtk/fast/table/table-display-types-vertical-expected.txt: Added.
        * platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
        * platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
        * platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
        * platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
        * platform/gtk/mathml/xHeight-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
        * platform/gtk/svg/custom/repaint-on-constant-size-change-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 15 Nov 2010 17:34:00 +0000 (17:34 +0000)]
2010-11-15  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [WK2][Qt] WebKit2 implementation of tiled backing store
        https://bugs.webkit.org/show_bug.cgi?id=49526

        Basic opt-in tiling implementation for WebKit2/Qt.

        Original patch by Antti Koivisto.

        * Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
        New messages: RequestTileUpdate and CancelTileUpdate.

        * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
        New messages: Invalidate, TileUpdated, AllTileUpdatesProcessed.

        * Shared/DrawingAreaBase.h:
        New area type: TiledDrawingAreaType.

        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::QGraphicsWKView):
        (QGraphicsWKView::setGeometry):
        (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
        (QGraphicsWKView::prepareScaleChange):
        (QGraphicsWKView::commitScaleChange):
        (QGraphicsWKViewPrivate::onScaleChanged):
        (QGraphicsWKViewPrivate::commitScale):
        Support for tiled backing store.

        * UIProcess/TiledDrawingAreaProxy.cpp: Added.
        (WebKit::TiledDrawingAreaProxy::create):
        (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
        (WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy):
        (WebKit::TiledDrawingAreaProxy::setSize):
        (WebKit::TiledDrawingAreaProxy::setPageIsVisible):
        (WebKit::TiledDrawingAreaProxy::didSetSize):
        (WebKit::TiledDrawingAreaProxy::didReceiveMessage):
        (WebKit::TiledDrawingAreaProxy::didReceiveSyncMessage):
        (WebKit::TiledDrawingAreaProxy::requestTileUpdate):
        (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
        (WebKit::TiledDrawingAreaProxy::createTile):
        (WebKit::TiledDrawingAreaProxy::setTileSize):
        (WebKit::TiledDrawingAreaProxy::setTileCreationDelay):
        (WebKit::TiledDrawingAreaProxy::setKeepAndCoverAreaMultipliers):
        (WebKit::TiledDrawingAreaProxy::invalidate):
        (WebKit::TiledDrawingAreaProxy::updateTileBuffers):
        (WebKit::TiledDrawingAreaProxy::tileBufferUpdateComplete):
        (WebKit::TiledDrawingAreaProxy::paint):
        (WebKit::TiledDrawingAreaProxy::adjustVisibleRect):
        (WebKit::TiledDrawingAreaProxy::setContentsScale):
        (WebKit::TiledDrawingAreaProxy::removeAllTiles):
        (WebKit::TiledDrawingAreaProxy::tileDistance):
        (WebKit::TiledDrawingAreaProxy::calculateKeepRect):
        (WebKit::TiledDrawingAreaProxy::calculateCoverRect):
        (WebKit::TiledDrawingAreaProxy::createTiles):
        (WebKit::TiledDrawingAreaProxy::resizeEdgeTiles):
        (WebKit::TiledDrawingAreaProxy::dropTilesOutsideRect):
        (WebKit::TiledDrawingAreaProxy::tileAt):
        (WebKit::TiledDrawingAreaProxy::setTile):
        (WebKit::TiledDrawingAreaProxy::removeTile):
        (WebKit::TiledDrawingAreaProxy::mapToContents):
        (WebKit::TiledDrawingAreaProxy::mapFromContents):
        (WebKit::TiledDrawingAreaProxy::contentsRect):
        (WebKit::TiledDrawingAreaProxy::tileRectForCoordinate):
        (WebKit::TiledDrawingAreaProxy::tileCoordinateForPoint):
        (WebKit::TiledDrawingAreaProxy::startTileBufferUpdateTimer):
        (WebKit::TiledDrawingAreaProxy::tileBufferUpdateTimerFired):
        (WebKit::TiledDrawingAreaProxy::startTileCreationTimer):
        (WebKit::TiledDrawingAreaProxy::tileCreationTimerFired):
        (WebKit::TiledDrawingAreaProxy::hasPendingUpdates):
        * UIProcess/TiledDrawingAreaProxy.h: Added.
        (WebKit::TiledDrawingAreaProxy::contentsScale):
        (WebKit::TiledDrawingAreaProxy::attachCompositingContext):
        (WebKit::TiledDrawingAreaProxy::detachCompositingContext):
        (WebKit::TiledDrawingAreaProxy::tileSize):
        (WebKit::TiledDrawingAreaProxy::tileCreationDelay):
        (WebKit::TiledDrawingAreaProxy::getKeepAndCoverAreaMultipliers):
        * UIProcess/TiledDrawingAreaTile.h: Added.
        (WebKit::TiledDrawingAreaTile::create):
        (WebKit::TiledDrawingAreaTile::hasBackBufferUpdatePending):
        (WebKit::TiledDrawingAreaTile::coordinate):
        (WebKit::TiledDrawingAreaTile::rect):
        (WebKit::TiledDrawingAreaTile::ID):
        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):
        * WebProcess/WebPage/TiledDrawingArea.cpp: Added.
        (WebKit::TiledDrawingArea::TiledDrawingArea):
        (WebKit::TiledDrawingArea::~TiledDrawingArea):
        (WebKit::TiledDrawingArea::invalidateWindow):
        (WebKit::TiledDrawingArea::invalidateContentsAndWindow):
        (WebKit::TiledDrawingArea::invalidateContentsForSlowScroll):
        (WebKit::TiledDrawingArea::scroll):
        (WebKit::TiledDrawingArea::setNeedsDisplay):
        (WebKit::TiledDrawingArea::display):
        (WebKit::TiledDrawingArea::scheduleDisplay):
        (WebKit::TiledDrawingArea::setSize):
        (WebKit::TiledDrawingArea::suspendPainting):
        (WebKit::TiledDrawingArea::resumePainting):
        (WebKit::TiledDrawingArea::didUpdate):
        (WebKit::TiledDrawingArea::updateTile):
        (WebKit::TiledDrawingArea::tileUpdateTimerFired):
        (WebKit::TiledDrawingArea::didReceiveMessage):
        * WebProcess/WebPage/TiledDrawingArea.h: Added.
        (WebKit::TiledDrawingArea::attachCompositingContext):
        (WebKit::TiledDrawingArea::detachCompositingContext):
        (WebKit::TiledDrawingArea::setRootCompositingLayer):
        (WebKit::TiledDrawingArea::scheduleCompositingLayerSync):
        (WebKit::TiledDrawingArea::syncCompositingLayers):
        * WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: Added.
        (WebKit::TiledDrawingArea::paintIntoUpdateChunk):
        * WebKit2.pro:
        * UIProcess/qt/TiledDrawingAreaTileQt.cpp: Added.
        (WebKit::checkeredPixmap):
        (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile):
        (WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile):
        (WebKit::TiledDrawingAreaTile::isDirty):
        (WebKit::TiledDrawingAreaTile::isReadyToPaint):
        (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer):
        (WebKit::TiledDrawingAreaTile::invalidate):
        (WebKit::TiledDrawingAreaTile::resize):
        (WebKit::TiledDrawingAreaTile::swapBackBufferToFront):
        (WebKit::TiledDrawingAreaTile::paint):
        (WebKit::TiledDrawingAreaTile::paintCheckerPattern):
        (WebKit::TiledDrawingAreaTile::updateFromChunk):
        (WebKit::TiledDrawingAreaTile::updateBackBuffer):
        * UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Added.
        (WebKit::TiledDrawingAreaProxy::updateWebView):
        (WebKit::TiledDrawingAreaProxy::webViewVisibleRect):
        (WebKit::TiledDrawingAreaProxy::page):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 15 Nov 2010 17:29:28 +0000 (17:29 +0000)]
2010-11-15  Marcus Bulach  <bulach@chromium.org>

        Not reviewed, Chromium test expectation update.

        Update chromium baselines for svg following r72006
        https://bugs.webkit.org/show_bug.cgi?id=49547

        * platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Mon, 15 Nov 2010 16:56:00 +0000 (16:56 +0000)]
2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
        https://bugs.webkit.org/show_bug.cgi?id=49544

        Add the shortcut to BrowserWindow.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::openLocation):
        * MiniBrowser/qt/BrowserWindow.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 15 Nov 2010 16:24:38 +0000 (16:24 +0000)]
2010-11-15  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Martin Robinson.

        Make ContextShadow compile on all platforms
        https://bugs.webkit.org/show_bug.cgi?id=49535

        Add a void* typedef for PlatformImage and PlatformContext for unsupported platforms
        and move them into the WebCore namespace like all other Platform* typedefs.

        * platform/graphics/ContextShadow.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: SVGFEImageElement doesn't support dynamic invalidation
reni@webkit.org [Mon, 15 Nov 2010 16:10:35 +0000 (16:10 +0000)]
WebCore: SVGFEImageElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html
       svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html

* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::svgAttributeChanged):
* svg/SVGFEImageElement.h:

LayoutTests: SVGFEImageElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

Adding layout tests for feImage dynamic changes.

* platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html: Added.
* svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFEImageElement-dom-preserveAspectRatio-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEImageElement-svgdom-preserveAspectRatio-prop.js: Added.
(executeTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Add Qt specific expected results after r72003.
ossy@webkit.org [Mon, 15 Nov 2010 14:49:56 +0000 (14:49 +0000)]
Unreviewed. Add Qt specific expected results after r72003.

[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538

* platform/qt/fast/forms/formaction-attribute-expected.txt: Copied from LayoutTests/fast/forms/formaction-attribute-expected.txt.
* platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formmethod-attribute-button-html-expected.txt.
* platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formtarget-attribute-button-html-expected.txt.
* platform/qt/fast/forms/mailto: Added.
* platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt.
* platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Mon, 15 Nov 2010 13:32:13 +0000 (13:32 +0000)]
2010-11-15  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Focus ring does not show on focused links.
        https://bugs.webkit.org/show_bug.cgi?id=49515

        * platform/qt/fast/inline/inline-focus-ring-expected.checksum: Added.
        * platform/qt/fast/inline/inline-focus-ring-expected.png: Added.
        * platform/qt/fast/inline/inline-focus-ring-expected.txt: Added.
2010-11-15  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Focus ring does not show on focused links.
        https://bugs.webkit.org/show_bug.cgi?id=49515

        After http://trac.webkit.org/changeset/69766 the focus ring on links is no longer
        visible in Qt.
        The reason is that Qt always returned true in RenderTheme::supportsFocusRing(),
        but until r69766, we did not check that for links. Qt draws its own focus ring
        for controls that it draws, but not for links.
        Change the return value to false if the style's appearance is not something that Qt
        draws by itself or does not support.
        Added a Qt specific test result for the new test added in r69766.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::supportsFocusRing):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Mon, 15 Nov 2010 12:43:05 +0000 (12:43 +0000)]
2010-11-15  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
        https://bugs.webkit.org/show_bug.cgi?id=49240

        * fast/forms/formaction-attribute-expected.txt: Added.
        * fast/forms/formaction-attribute.html: Added.
        * fast/forms/formmethod-attribute-button-html-expected.txt: Added.
        * fast/forms/formmethod-attribute-button-html.html: Added.
        * fast/forms/formmethod-attribute-input-html-expected.txt: Added.
        * fast/forms/formmethod-attribute-input-html.html: Added.
        * fast/forms/formtarget-attribute-button-html-expected.txt: Added.
        * fast/forms/formtarget-attribute-button-html.html: Added.
        * fast/forms/formtarget-attribute-input-html-expected.txt: Added.
        * fast/forms/formtarget-attribute-input-html.html: Added.
        * fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
        * fast/forms/mailto/formenctype-attribute-button-html.html: Added.
        * fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
        * fast/forms/mailto/formenctype-attribute-input-html.html: Added.
        * fast/forms/script-tests/submit-form-attributes.js: Added.
        * fast/forms/submit-form-attributes-expected.txt: Added.
        * fast/forms/submit-form-attributes.html: Added.
2010-11-15  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
        https://bugs.webkit.org/show_bug.cgi?id=49240

        Tests: fast/forms/formaction-attribute.html
               fast/forms/formmethod-attribute-button-html.html
               fast/forms/formmethod-attribute-input-html.html
               fast/forms/formtarget-attribute-button-html.html
               fast/forms/formtarget-attribute-input-html.html
               fast/forms/mailto/formenctype-attribute-button-html.html
               fast/forms/mailto/formenctype-attribute-input-html.html
               fast/forms/submit-form-attributes.html

        * html/HTMLAttributeNames.in: Added formaction, formmethod, formtarget and formenctype attributes
        * html/HTMLButtonElement.idl:
        * html/HTMLInputElement.idl:
        * loader/FormSubmission.cpp: Modified to check the pressed button and its attributes
        (WebCore::FormSubmission::Attributes::copyFrom):
        (WebCore::FormSubmission::create):
        * loader/FormSubmission.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 15 Nov 2010 12:09:45 +0000 (12:09 +0000)]
2010-11-15  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Do not hide default Ctrl+A behavior on non-Mac.
        https://bugs.webkit.org/show_bug.cgi?id=49527

        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt.prototype._onKeyDown):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Mon, 15 Nov 2010 11:37:21 +0000 (11:37 +0000)]
2010-11-15  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Add capability for displaying warnings to autofill popup
        Warnings are displayed in dark gray italic.
        https://bugs.webkit.org/show_bug.cgi?id=49291
        http://code.google.com/p/chromium/issues/detail?id=58509

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::getRowFont):
          Use item-specific font, not just the generic menu font.
        (WebCore::PopupListBox::selectIndex):
          Updated to clear the selection when hovering over a non-selectable item.
        * platform/chromium/PopupMenuChromium.h: Minor cleanup
2010-11-15  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Add capability for displaying warnings to autofill popup
        Warnings are displayed in dark gray italic.
        https://bugs.webkit.org/show_bug.cgi?id=49291
        http://code.google.com/p/chromium/issues/detail?id=58509

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::canRemoveSuggestionAtIndex):
          Updated logic -- can only remove Autocomplete suggestions, which have unique ID 0.
        (WebKit::AutoFillPopupMenuClient::itemIsEnabled): False for warnings.
        (WebKit::AutoFillPopupMenuClient::itemStyle): Dark gray italic for warnings.
        (WebKit::AutoFillPopupMenuClient::menuStyle): Variable name changed.
        (WebKit::AutoFillPopupMenuClient::itemIsWarning): True for unique ID < 0.
        (WebKit::AutoFillPopupMenuClient::initialize): Updated cached styles (see above).
        * src/AutoFillPopupMenuClient.h: Added itemIsEnabled(), variable to cache warning style.
        * src/WebViewImpl.cpp: Minor cleanup.
        (WebKit::WebViewImpl::applyAutoFillSuggestions):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-15 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 15 Nov 2010 10:39:09 +0000 (10:39 +0000)]
2010-11-15  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed.

        Skipping SVG failing tests for GTK+ until we find the issue,
        opened a bug:
        [gtk] SVGLineElement-dom-requiredFeatures.html and
        SVGLineElement-svgdom-requiredFeatures.html failing in the bots
        https://bugs.webkit.org/show_bug.cgi?id=49529

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 15 Nov 2010 07:46:25 +0000 (07:46 +0000)]
2010-11-14  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/gtk/Skipped: Skip fast/forms/form-attribute.html, which needs <meter> support.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 15 Nov 2010 06:38:17 +0000 (06:38 +0000)]
2010-11-14  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Add tests that fail under the DRT.

        * platform/chromium/drt_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBack out the italics portion of the previous patch until I can figure out why it
hyatt@apple.com [Mon, 15 Nov 2010 06:03:54 +0000 (06:03 +0000)]
Back out the italics portion of the previous patch until I can figure out why it
doesn't work.

* css/CSSFontSelector.cpp:
(WebCore::compareFontFaces):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 15 Nov 2010 05:40:02 +0000 (05:40 +0000)]
2010-11-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Improve API for form validation message strings
        https://bugs.webkit.org/show_bug.cgi?id=34945

        This change introduces three new functions;
        validationMessageTypeMismatchFor*Text(). The implementation for each
        platform is just a call to validationMessageTypeMismatchText().

        Some validationMessage*() functions have new parameters.  The parameters
        are ignored in all platforms for now.

        This change doesn't change any behavior. However a platform can add
        additional information to validation messages.  e.g. Changing "type
        mismatch" to "Please specify an e-mail address" for <input type=email>.

        * html/EmailInputType.cpp:
        (WebCore::EmailInputType::typeMismatchText): Call validationMessageTypeMismatchForEmailText()
          or validationMessageTypeMismatchForMultipleEmailText().
        * html/EmailInputType.h:
        * html/HTMLFormControlElement.h: Add maxLength() and value() to access them from ValidityState.
        * html/HTMLInputElement.cpp: Add the following functions to pass extra
          information to validation message string functions.
        (WebCore::HTMLInputElement::minimumString):
        (WebCore::HTMLInputElement::maximumString):
        (WebCore::HTMLInputElement::stepBaseString):
        (WebCore::HTMLInputElement::stepString):
        (WebCore::HTMLInputElement::typeMismatchText):
        * html/HTMLInputElement.h:
        * html/HTMLTextAreaElement.h:
        * html/InputType.cpp:
        (WebCore::InputType::typeMismatchText): Call validationMessageTypeMismatchText().
        * html/InputType.h:
        * html/URLInputType.cpp:
        (WebCore::URLInputType::typeMismatchText): Call validationMessageTypeMismatchForURLText().
        * html/URLInputType.h:
        * html/ValidityState.cpp:
        (WebCore::ValidityState::validationMessage):
        * platform/LocalizedStrings.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):
        * platform/LocalizedStrings.h:
          - Add validationMessageTypeMismatchForEmailText(),
            validationMessageTypeMismatchForMultipleEmailText() and
            validationMessageTypeMismatchForURLText()
          - Add length parameters to validationMessageTooLongText().
          - Add the minimum value parameter to validationMessageRangeUnderflowText()
          - Add the maximum value parameter to validationMessageRangeOverflowText()
          - Add parameters of the base value and the step value to validationMessageStepMismatchText()
        * platform/android/LocalizedStringsAndroid.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):
        * platform/brew/LocalizedStringsBrew.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):
        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageStepMismatchText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):
        * platform/haiku/LocalizedStringsHaiku.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):
        * platform/wx/LocalizedStringsWx.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):
2010-11-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Improve API for form validation message strings
        https://bugs.webkit.org/show_bug.cgi?id=34945

        * public/WebLocalizedString.h:
        * src/LocalizedStrings.cpp:
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoKeyboardEvent::keyIdentifier() should return "const String&"
tkent@chromium.org [Mon, 15 Nov 2010 05:19:44 +0000 (05:19 +0000)]
KeyboardEvent::keyIdentifier() should return "const String&"
https://bugs.webkit.org/show_bug.cgi?id=49426

Reviewed by Andreas Kling.

WebCore:

No new tests. This shouldn't change the current behavior.

* dom/KeyboardEvent.h:
(WebCore::KeyboardEvent::keyIdentifier): Change the return type; String -> const String&
* dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler):
  Change the type of a variable to have keyIdentifier(); String -> const String&
(WebCore::SelectElement::listBoxDefaultEventHandler): ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): ditto.
(WebCore::HTMLInputElement::handleKeyEventForRange): ditto.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleKeyboardSelectionMovement): ditto.

WebKit/mac:

* WebCoreSupport/WebEditorClient.mm:
(selectorForKeyEvent):
  Change the type of a variable to have keyIdentifier(); String -> const String&

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Kenichi Ishibashi <bashi@google.com>
commit-queue@webkit.org [Mon, 15 Nov 2010 04:57:04 +0000 (04:57 +0000)]
2010-11-14  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        [HTML5] "form" attribute support for form control elements
        https://bugs.webkit.org/show_bug.cgi?id=47813

        Adds a test file for "form" attribute of form-associated elements.
        The test might need to be revised because <label> and <object> don't
        support "form" attribute for now, in spite of the HTML5 spec says that
        they should support.

        * fast/forms/form-attribute-elements-expected.txt: Added.
        * fast/forms/form-attribute-elements-order-expected.txt: Added.
        * fast/forms/form-attribute-elements-order.html: Added.
        * fast/forms/form-attribute-elements-order2-expected.txt: Added.
        * fast/forms/form-attribute-elements-order2.html: Added.
        * fast/forms/form-attribute-elements.html: Added.
        * fast/forms/form-attribute-expected.txt: Added.
        * fast/forms/form-attribute.html: Added.
        * fast/forms/script-tests/form-attribute-elements-order.js: Added.
        * fast/forms/script-tests/form-attribute-elements-order2.js: Added.
        * fast/forms/script-tests/form-attribute-elements.js: Added.
        * fast/forms/script-tests/form-attribute.js: Added.
2010-11-14  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        [HTML5] "form" attribute support for form control elements
        https://bugs.webkit.org/show_bug.cgi?id=47813

        Adds a list of form-associated elements with form attribute into
        the Document class to support form attribute.
        Adds a function to determine the right place to locate
        form-associated elements with form attribute into
        m_associatedElements of HTMLFormElement class.

        Tests: fast/forms/form-attribute-elements-order.html
               fast/forms/form-attribute-elements-order2.html
               fast/forms/form-attribute-elements.html
               fast/forms/form-attribute.html

        * dom/Document.cpp:
        (WebCore::Document::registerFormElementWithFormAttribute): Added.
        (WebCore::Document::unregisterFormElementWithFormAttribute): Added.
        (WebCore::Document::resetFormElementsOwner): Added.
        * dom/Document.h: Added the list for elements with form attribute.
        * html/HTMLAttributeNames.in: Added form attribute.
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::insertedIntoTree): Modified to handle
        form attribute.
        (WebCore::HTMLFormControlElement::removedFromTree): Ditto.
        (WebCore::HTMLFormControlElement::resetFormOwner): Added.
        (WebCore::HTMLFormControlElement::attributeChanged): Added.
        * html/HTMLFormControlElement.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::HTMLFormElement): Modified to initialize
        newly-added variables.
        (WebCore::HTMLFormElement::insertedIntoDocument): Modified to reset
        form owner of form-associated elements.
        (WebCore::HTMLFormElement::removedFromDocument): Ditto.
        (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Added.
        (WebCore::HTMLFormElement::formElementIndex): Modified to treat
        form-associated elements with form attribute separately.
        (WebCore::HTMLFormElement::removeFormElement): Modified to handle
        form-associated elements with form attribute.
        * html/HTMLFormElement.h: Added three variables to handle form attribute.
        * html/HTMLOutputElement.cpp: Removed "FIXME" comment.
        (WebCore::HTMLOutputElement::parseMappedAttribute):
        * html/HTMLOutputElement.h: Removed setForm().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=49521
hyatt@apple.com [Mon, 15 Nov 2010 04:53:16 +0000 (04:53 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49521

Reviewed by Dan Bernstein.

REGRESSION svg/W3C-SVG-1.1/fonts-desc-02-t.svg broken by r71979.

Refine the font selection function for @font-face to be smarter about what fonts it prefers.  If
a font is labeled as only supporting small-caps, then prefer it to one that claims to support both
normal and small-caps.  The specialized font is more likely to be true small-caps and to not rely
on synthesis.

Added the same logic for italic as well.  Prefer the font that is specifically restricted to
italic to one that claims it can support anything.

* css/CSSFontSelector.cpp:
(WebCore::compareFontFaces):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 15 Nov 2010 03:38:39 +0000 (03:38 +0000)]
2010-11-14  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Remove two tests that consistently pass on chromium-mac.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 15 Nov 2010 02:14:28 +0000 (02:14 +0000)]
2010-11-14  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline and expectations update.

        * platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 15 Nov 2010 01:56:27 +0000 (01:56 +0000)]
2010-11-14  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Correct some expectations added by r71988.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 David Levin <levin@chromium.org>
levin@chromium.org [Mon, 15 Nov 2010 01:17:36 +0000 (01:17 +0000)]
2010-11-14  David Levin  <levin@chromium.org>

        Reviewed by Daniel Bates.

        check-webkit-style should detect PassRefPtr usage in functions.
        https://bugs.webkit.org/show_bug.cgi?id=49513

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_for_function_lengths): Revert a comment change that I
         accidentally made in r71986.
        (check_pass_ptr_usage): Added the code to do the check.
        (process_line): Added the call to check_pass_ptr_usage.
        (CppChecker): Added the new error category.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
         testing purposes.
        (PassPtrTest::*): The class/functions to unit test the new
         functionality.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 15 Nov 2010 01:15:24 +0000 (01:15 +0000)]
2010-11-14  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium baseline and expectations update.

        - r71969 added a bunch of SVG tests without pixel baselines
        - r71969 also caused svg/W3C-SVG-1.1-SE/types-dom-06-f.svg to need a
          rebaseline for Linux and Windows (which now match the mac baseline,
          modulo font rendering)
        - r71970 added two tests that depend on vertical text support (which
          (doesn't work on Linux or Windows yet)
        - Similarly, r71979 added a test that depends on vertical text support
        - r71979 also caused a regression that should be fixed upstream
        - Add Chromium baselines for fast/repaint/
          repaint-across-writing-mode-boundary.html (added by r71980).

        Also rebaseline fast/table/colspanMinWidth-vertical.html for Linux and
        Windows, to mirror the mac rebaseline done in r71876.

        * platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
        * platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
        * platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
        * platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Sun, 14 Nov 2010 20:14:59 +0000 (20:14 +0000)]
2010-11-14  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [EFL] add pango support
        https://bugs.webkit.org/show_bug.cgi?id=46029

        Add FONT_BACKEND option to switch between pango and freetype.

        * cmake/OptionsEfl.cmake:
2010-11-14  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [EFL] add pango support
        https://bugs.webkit.org/show_bug.cgi?id=46029

        Include pango related files.
        No new tests; functionality is unchanged.

        * CMakeListsEfl.txt:
2010-11-14  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [EFL] add pango support
        https://bugs.webkit.org/show_bug.cgi?id=46029

        Add pango in include and libs.

        * CMakeListsEfl.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 David Levin <levin@chromium.org>
levin@chromium.org [Sun, 14 Nov 2010 19:59:42 +0000 (19:59 +0000)]
2010-11-14  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style function detection and the line count style checks should be separate.
        https://bugs.webkit.org/show_bug.cgi?id=49512

        * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
          call the detection function and fix line counts in two places now that
          the code really only counts the lines in the body of the function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 14 Nov 2010 19:39:47 +0000 (19:39 +0000)]
2010-11-14  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        http/tests/plugins tests print "Unhandled variable" to stderr under Qt
        https://bugs.webkit.org/show_bug.cgi?id=33438

        Stifle "Unhandled variable" warning to match what the other
        TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
        simply returns NPERR_GENERIC_ERROR for unhandled variables.)

        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_get_value):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-12 Tenghui Zhu <ztenghui@google.com>
andreas.kling@nokia.com [Sun, 14 Nov 2010 19:11:42 +0000 (19:11 +0000)]
2010-11-12  Tenghui Zhu  <ztenghui@google.com>

        Reviewed by Andreas Kling.

        [V8] Code generation script error in generating the SVGStaticListPropertyTearOff
        https://bugs.webkit.org/show_bug.cgi?id=49463

        * bindings/scripts/CodeGeneratorV8.pm: The svgNativeType is the one containing
        the SVGStaticListPropertyTearOff string, not the svgListPropertyType.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 14 Nov 2010 18:43:26 +0000 (18:43 +0000)]
2010-11-14  Andreas Kling  <kling@webkit.org>

        Reviewed by Antonio Gomes.

        REGRESSION(r71895): API test javaScriptWindowObjectCleared fails
        https://bugs.webkit.org/show_bug.cgi?id=49466

        As of r71895 empty inline scripts are no longer executed and so
        the javaScriptWindowObjectCleared() signal is no longer triggered
        by <script></script>.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-14 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 14 Nov 2010 17:18:54 +0000 (17:18 +0000)]
2010-11-14  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Sort CMakeLists.txt
        https://bugs.webkit.org/show_bug.cgi?id=49507

        * CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-11-13 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 14 Nov 2010 07:56:52 +0000 (07:56 +0000)]
2010-11-13  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Yury Semikhatsky.

        Buildfix for !ENABLE(INSPECTOR)
        https://bugs.webkit.org/show_bug.cgi?id=49500

        Also unify the position of the condition in the cpp files.

        * inspector/ConsoleMessage.cpp:
        * inspector/InspectorResourceAgent.cpp:
        * inspector/InspectorState.cpp:
        * inspector/ScriptCallFrame.cpp:
        * inspector/ScriptCallStack.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=49506
hyatt@apple.com [Sun, 14 Nov 2010 06:14:33 +0000 (06:14 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49506

Reviewed by Anders Carlsson.

Repaint is broken across writing mode boundaries.  It's not enough to add in flipped offsets.  You have
to flip the rect itself.

WebCore:

Added fast/repaint/repaint-across-writing-mode-boundary.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):

LayoutTests:

Added fast/repaint/repaint-across-writing-mode-boundary.html
* fast/repaint/repaint-across-writing-mode-boundary.html: Added.
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=49505
hyatt@apple.com [Sun, 14 Nov 2010 05:31:39 +0000 (05:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49505

Reviewed by Dan Bernstein.

REGRESSION: @font-face doesn't work with the small-caps variant.  This was broken by the addition of SVG fonts
support long ago.  This patch fixes the SVG code so that it doesn't break non-SVG fonts.

Added fast/blockflow/broken-ideograph-small-caps.html

WebCore:

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::hasSVGFontFaceSource):
* css/CSSFontFace.h:
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontFaceSource.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

LayoutTests:

* fast/blockflow/broken-ideograph-small-caps.html: Added.
* platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.checksum: Added.
* platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
* platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71979 268f45cc-cd09-0410-ab3c-d52691b4dbfc