commit-queue@webkit.org [Sat, 5 Feb 2011 08:02:23 +0000 (08:02 +0000)]
2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77725.
http://trac.webkit.org/changeset/77725
https://bugs.webkit.org/show_bug.cgi?id=53844
It broke Qt minimal build (Requested by Ossy_ on #webkit).
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 5 Feb 2011 07:35:54 +0000 (07:35 +0000)]
2011-02-04 Jer Noble <jer.noble@apple.com>
Adding test to Qt Skipped list.
[Qt] media/video-frame-accurate-seek.html fails
https://bugs.webkit.org/show_bug.cgi?id=53843
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joone.hur@collabora.co.uk [Sat, 5 Feb 2011 06:25:43 +0000 (06:25 +0000)]
2011-02-04 Joone Hur <joone.hur@collabora.co.uk>
Unreviewed, Fix compilation warning.
Constructor initialization list should follow the declaration order.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to
the last position in the initialization list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 5 Feb 2011 06:03:44 +0000 (06:03 +0000)]
Versioning.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 5 Feb 2011 05:17:30 +0000 (05:17 +0000)]
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837
Test that we can successfully execute a JavaScript URL when it isn't
blocked by the filter.
* http/tests/security/xssAuditor/non-block-javascript-url-frame-expected.txt: Added.
* http/tests/security/xssAuditor/non-block-javascript-url-frame.html: Added.
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Crash in WebCore::TextEncoding::decode below XSSFilter::init
https://bugs.webkit.org/show_bug.cgi?id=53837
Add missing null check.
Test: http/tests/security/xssAuditor/non-block-javascript-url-frame.html
* html/parser/XSSFilter.cpp:
(WebCore::XSSFilter::init):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sat, 5 Feb 2011 04:56:59 +0000 (04:56 +0000)]
2011-02-04 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Crashes in ShadowBlur via WebKit2 FindController
https://bugs.webkit.org/show_bug.cgi?id=53830
Fix a crash cause by re-entering ShadowBlur, and add assertions to
detect when it happens.
The re-entrancy occurred when drawRectShadowWithTiling() filled
the interior of the shadow with fillRect() on the context
which still had the shadow state set. This would make another ShadowBlur
on the stack and call into the code again, potentially blowing away
the image buffer.
Fix by turning off shadows in the destination context while we're
drawing the tiled shadow. The non-tiled code path already did this.
Not testable because CSS shadows clip out the inside of the rect
being shadowed, and SVG uses fillPath, even for rects.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::getScratchBuffer):
(WebCore::ScratchBuffer::scheduleScratchBufferPurge):
(WebCore::ShadowBlur::ShadowBlur):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Sat, 5 Feb 2011 04:54:17 +0000 (04:54 +0000)]
2011-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Skip a new test that uses EventSender
https://bugs.webkit.org/show_bug.cgi?id=53841
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 5 Feb 2011 04:17:32 +0000 (04:17 +0000)]
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833
* platform/gtk/Skipped: Unskip test which is now passing.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Barth.
[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833
Add the new "alert on load" functionality for the Unix version of the
test plugin. This functionality was originally introduced in r77706.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance): Add new plugin fuctionality.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 5 Feb 2011 03:37:22 +0000 (03:37 +0000)]
2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
Update expected results reflecting the change to search icon rendering.
* platform/gtk/fast/css/input-search-padding-expected.checksum:
* platform/gtk/fast/css/input-search-padding-expected.png:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.checksum:
* platform/gtk/fast/forms/search-styled-expected.png:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/search-vertical-alignment-expected.checksum:
* platform/gtk/fast/forms/search-vertical-alignment-expected.png:
* platform/gtk/fast/forms/search-zoomed-expected.checksum:
* platform/gtk/fast/forms/search-zoomed-expected.png:
* platform/gtk/fast/forms/search-zoomed-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.checksum:
* platform/gtk/fast/forms/searchfield-heights-expected.png:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
2011-02-04 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Don't use a fixed size for search field icons
https://bugs.webkit.org/show_bug.cgi?id=50624
Use the parent input content box to make sure the icon fits in the
search field, scaling it down when needed.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintGdkPixbuf):
(WebCore::getIconSizeForPixelSize):
(WebCore::adjustSearchFieldIconStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::centerRectVerticallyInParentInputElement):
(WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
(WebCore::RenderThemeGtk::paintCapsLockIndicator):
(WebCore::RenderThemeGtk::paintMediaButton):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 5 Feb 2011 03:11:50 +0000 (03:11 +0000)]
2011-02-04 Kundu Suchismita <suchi.kundu@nokia.com>
Reviewed by Andreas Kling.
Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::toggleLocalStorage):
(LauncherWindow::toggleOfflineStorageDatabase):
(LauncherWindow::toggleOfflineWebApplicationCache):
(LauncherWindow::setOfflineStorageDefaultQuota):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 5 Feb 2011 03:05:47 +0000 (03:05 +0000)]
2011-02-04 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250
This change adds a new script test that we can render a CMYK JPEG with a
color profile correctly, i.e. we can render it without color corruption.
* fast/images/cmyk-jpeg-with-color-profile-expected.txt: Added.
* fast/images/cmyk-jpeg-with-color-profile.html: Added.
* fast/images/resources/cmyk-jpeg.jpg: Added.
* fast/images/script-tests/cmyk-jpeg-with-color-profile.js: Added.
(image.onload):
2011-02-04 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Barth.
[chromium] JPEG corruption
https://bugs.webkit.org/show_bug.cgi?id=53250
Same as gray-scale JPEGs, we convert the colors of CMYK JPEGs with color
profiles from CMYK to RGB twice and it causes color corruption. This
change suppresses the color profiles for CMYK JPEGs same as gray-scale
ones.
Test: fast/images/cmyk-jpeg-with-color-profile.html
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 5 Feb 2011 02:57:30 +0000 (02:57 +0000)]
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Update pixel results for the fast/forms directory in preparation for landing
fixes to input type=search icon sizing. Also add some missing results. These
results are out of date because of changes to font hinting some time ago.
* platform/gtk/fast/forms/
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-2-expected.png: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 5 Feb 2011 02:55:21 +0000 (02:55 +0000)]
2011-02-04 Adam Barth <abarth@webkit.org>
[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since introduction in r77706
https://bugs.webkit.org/show_bug.cgi?id=53831
Stop dumping the child frames because that's not needed for this test
and cause extra output on Windows.
* plugins/plugin-document-back-forward.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 5 Feb 2011 02:50:37 +0000 (02:50 +0000)]
2011-02-04 Adam Barth <abarth@webkit.org>
[GTK] plugins/plugin-document-back-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=53833
Add plugins/plugin-document-back-forward.html to skipped list while we
investigate the issue.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Sat, 5 Feb 2011 02:39:01 +0000 (02:39 +0000)]
2011-02-04 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
get test-webkitpy running on win32 python
https://bugs.webkit.org/show_bug.cgi?id=53822
The test harness crashes with a WindowsError because it can't find
'svn' when using subprocess.Popen. This gets us past the error
so we can see the failing tests on the Chromium Win Release Tests
bot.
* Scripts/webkitpy/common/system/executive.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Sat, 5 Feb 2011 02:37:09 +0000 (02:37 +0000)]
2011-02-04 Matthew Delaney <mdelaney@apple.com>
Reviewed by Dan Bernstein.
Move canvas layout test expectations into more appropriate locations
https://bugs.webkit.org/show_bug.cgi?id=53145
* platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt: Removed.
* ...
* platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt: Removed.
* platform/mac/canvas: Added.
* platform/mac/canvas/philip: Added.
* platform/mac/canvas/philip/tests: Added.
* platform/mac/canvas/philip/tests/2d.drawImage.broken-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt.
* ...
* platform/mac/canvas/philip/tests/type.prototype-expected.txt: Copied from platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 5 Feb 2011 02:30:08 +0000 (02:30 +0000)]
[Windows 7 Release Tests] plugins/plugin-document-back-forward.html failing since
introduction in r77706.
https://bugs.webkit.org/show_bug.cgi?id=53831
Unreviewed. Add expected (failing?) results to get the Windows 7 Release Test bots green.
* platform/win/plugins/plugin-document-back-forward-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 5 Feb 2011 02:26:00 +0000 (02:26 +0000)]
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Unskip some tests which should now be passing.
* platform/gtk/Skipped: Unskip tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 5 Feb 2011 02:19:43 +0000 (02:19 +0000)]
2011-02-04 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Option text in select popup does not align with menulist button text
https://bugs.webkit.org/show_bug.cgi?id=53632
This makes clientPaddingLeft and clientPaddingRight return
the additional m_innerBlock's padding so that the popup item text
aligns with the menulist button text.
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::clientPaddingLeft):
(WebCore::RenderMenuList::clientPaddingRight):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 5 Feb 2011 02:18:39 +0000 (02:18 +0000)]
REGRESSION: Horizontal scrollbar thumbs leave artifacts over page content when scrolling vertically
<rdar://problem/
8962457>
Reviewed by Sam Weinig and Beth Dakin.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
Subtract scrollbars from the scroll view rect if overlay scrollers are enabled.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
Make sure to invalidate both scrollbars if overlay scrollers are enabled.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 5 Feb 2011 02:11:51 +0000 (02:11 +0000)]
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797
* platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
https://bugs.webkit.org/show_bug.cgi?id=53797
When the frame name changes between different calls to webkit_web_frame_get_name
on the same frame, return the new frame name instead of the one valid during the
previous call.
* webkit/webkitwebframe.cpp:
(webkit_web_frame_init): Initialize the frame name to 0.
(webkit_web_frame_get_name): Check the current frame name first before
returning the cached value.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 5 Feb 2011 02:04:58 +0000 (02:04 +0000)]
WebKit2: Crash when InjectedBundlePageLoaderClient::willSendRequestForFrame returns a null WKURLRequestRef
https://bugs.webkit.org/show_bug.cgi?id=53829
Reviewed by Maciej Stachowiak.
Store the result of m_client.willSendRequestForFrame in a RefPtr, and null check it before
calling resourceRequest() on it.
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willSendRequestForFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 5 Feb 2011 01:58:45 +0000 (01:58 +0000)]
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Rebaseline a few tests after r77665 and add a GTK-specific baseline
after r77690.
* platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
* platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
* platform/gtk/fast/ruby/nested-ruby-expected.txt:
* platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:
* platform/gtk/media/video-frame-accurate-seek-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 5 Feb 2011 01:45:11 +0000 (01:45 +0000)]
[Windows 7 Release Tests] 5 ruby tests failing on Windows after r77665
https://bugs.webkit.org/show_bug.cgi?id=53820
Unreviewed. Landing expected results that are probably correct (given that the change in
77665 was to make the default ruby text size smaller by default).
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
* platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
* platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
* platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
* platform/win/fast/ruby/nested-ruby-expected.checksum:
* platform/win/fast/ruby/nested-ruby-expected.png:
* platform/win/fast/ruby/nested-ruby-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 5 Feb 2011 01:41:05 +0000 (01:41 +0000)]
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771
* platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771
Add the document browser cache model. This model is optimized for viewing
a series of local files, while the document viewer is optimized for only
viewing one local file. Improve the documentation on the mapping of these
enum values to actual cache settings.
* webkit/webkitglobals.cpp:
(webkit_set_cache_model): Add support for the document browser cache model and
improve comments in this section better explaining where the magic numbers come from.
* webkit/webkitglobals.h: Added an enum value for the document browser cache model.
2011-02-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] fast/events/pagehide-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=53771
Add knowledge of the document browser cache model the DRT. When resetting
WebKit settings to consistent values between tests, default to the document
browser cache model.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Reset the cache model to the document browser
cache model between tests.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
document browser cache model.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 5 Feb 2011 01:33:44 +0000 (01:33 +0000)]
Fix build.
* WebProcess/mac/WebProcessMac.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 5 Feb 2011 01:32:36 +0000 (01:32 +0000)]
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Link opened in background tab fails to paint when activated if it completes loading before tab is selected
https://bugs.webkit.org/show_bug.cgi?id=53827
<rdar://problem/
8962355>
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::resumePainting):
Invalidate the entire page.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 5 Feb 2011 01:23:44 +0000 (01:23 +0000)]
Fix <rdar://problem/
8961227> WebKit2 does not work with symlinked home directories.
Reviewed by Sam Weinig.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
Don't adopt an autoreleased pointer, this would lead to a crash.
(WebKit::appendSandboxParameterPath):
(WebKit::appendSandboxParameterConfPath):
(WebKit::initializeSandbox):
Clean up the sandbox parameter code and make sure that realpath is called for all parameters.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 5 Feb 2011 00:50:04 +0000 (00:50 +0000)]
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Test that plugin loads when in a plugin document on back-forward.
* plugins/plugin-document-back-forward-expected.txt: Added.
* plugins/plugin-document-back-forward.html: Added.
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.
This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.
Test: plugins/plugin-document-back-forward.html
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes):
* page/FrameView.cpp:
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
* page/FrameView.h:
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Teach the test plugin how to call alert on load.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 5 Feb 2011 00:48:31 +0000 (00:48 +0000)]
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Tests that navigating back and forward between hash items works.
* fast/history/history-back-forward-within-subframe-hash.html: Added.
* fast/history/history-back-forward-within-subframe-hash-expected.txt: Added.
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Avoids deleting the current HistoryItem while it is still in use.
Ensures that provisional items are committed for same document navigations.
Ensures that error pages are committed on back/forward navigations.
Also removes unneeded sanity checks used for diagnosing the problem.
* loader/HistoryController.cpp:
* loader/HistoryController.h:
2011-02-04 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819
Removes unneeded sanity checks used for diagnosing a memory error.
* src/WebFrameImpl.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 5 Feb 2011 00:38:53 +0000 (00:38 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Add expectations for the test, added in r77690.
* platform/chromium-win/media/video-frame-accurate-seek-expected.checksum: Added.
* platform/chromium-win/media/video-frame-accurate-seek-expected.png: Added.
* platform/chromium-win/media/video-frame-accurate-seek-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 5 Feb 2011 00:30:19 +0000 (00:30 +0000)]
Sandbox violations when visiting a site using HTTP authentication
<rdar://problem/
8951079>
Reviewed by Mark Rowe.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carol.szabo@nokia.com [Sat, 5 Feb 2011 00:28:57 +0000 (00:28 +0000)]
2011-02-04 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Code Changes.
CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126
* fast/css/counters/content-021-expected.txt: Added.
* fast/css/counters/content-021.html: Added.
This is a copy of the test with the same name from the
official css test suite, adapted for DumpRenderTree.
2011-02-04 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Code Changes.
CSS 2.1 failure: content-*
https://bugs.webkit.org/show_bug.cgi?id=52126
Test: fast/css/counters/content-021.html
* rendering/CounterNode.cpp:
(showCounterTree):
Made parameter const because it is supposed to be so.
* rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::areRenderersElementsSiblings):
(WebCore::nextInPreOrder):
Added these local helper functions to help navigate the DOM tree
enriched with :before and :after pseudo elements.
(WebCore::planCounter):
Fixed bug that would create a repeat counter for second and
subsequent renderers associated with the same DOM element.
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
Changed to use the new tree navigation functions described above
instead of the Renderer Tree navigation functions.
(WebCore::RenderCounter::rendererSubtreeAttached):
(WebCore::RenderCounter::rendererStyleChanged):
Optimized to not bother about counters until the renderers are
finally attached.
(showRendererTree):
(showNodeTree):
Debug helper functions used to debug Counter bugs.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 5 Feb 2011 00:28:05 +0000 (00:28 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=53823
Print layout sometimes seen on screen
<rdar://problem/
8948742> REGRESSION (WebKit2) - When I print a page, I visually see it re-layout
<rdar://problem/
8899389> REGRESSION(WebKit2): Wrong content can appear when print dialog is up
* UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay): Removed a
branch that didn't do anything useful.
* UIProcess/API/mac/WKPrintingView.h:
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView _suspendAutodisplay]):
(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
(-[WKPrintingView _delayedResumeAutodisplay]):
(-[WKPrintingView knowsPageRange:]):
(-[WKPrintingView beginDocument]):
(-[WKPrintingView endDocument]):
When page setup changes, or when going from print preview to actual printing, AppKit calls
-endDocument just to begin it again. Delay resuming autodisplay until the next run loop
iteration.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsAndWindow):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
Tightened it up from other side - we should never send pixels to UI process while in
printing mode. This is not 100% reliable, because relayout doesn't happen immediately,
and we can still have print layout in screen mode - but it helps.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 5 Feb 2011 00:26:58 +0000 (00:26 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Removed Chromium-specific baselines that are no longer necessary.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sat, 5 Feb 2011 00:20:16 +0000 (00:20 +0000)]
2011-02-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Rolled back in r77612 with ASSERT/crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=53759
Don't shrink the heap to 0 unconditionally. Instead, shrink to 1 if
necessary. For now, the heap assumes that it always has at least one
block live.
* runtime/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reset):
* runtime/Heap.h:
* runtime/MarkedSpace.cpp:
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::shrinkBlocks):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::reset):
* runtime/MarkedSpace.h:
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 5 Feb 2011 00:18:32 +0000 (00:18 +0000)]
Typo fix.
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::containsJavaScriptURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 5 Feb 2011 00:17:34 +0000 (00:17 +0000)]
Make an infinite loop introduced in r77454 finite.
Reviewed by Anders Carlsson.
* html/parser/XSSFilter.cpp:
(WebCore::HTMLNames::containsJavaScriptURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 5 Feb 2011 00:16:40 +0000 (00:16 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Update Leopard pixel results for fast/box-shadow.
* platform/mac-leopard/fast/box-shadow/basic-shadows-expected.checksum:
* platform/mac-leopard/fast/box-shadow/basic-shadows-expected.png:
* platform/mac-leopard/fast/box-shadow/inset-expected.checksum:
* platform/mac-leopard/fast/box-shadow/inset-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 5 Feb 2011 00:11:46 +0000 (00:11 +0000)]
Fix for <rdar://problem/
8961580>.
Work around for <rdar://problem/
8957845>.
Reviewed by Mark Rowe.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 5 Feb 2011 00:11:01 +0000 (00:11 +0000)]
2011-02-04 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
WebKit2 doesn't hide mouse pointer on keypress
https://bugs.webkit.org/show_bug.cgi?id=53821
rdar://problem/
8630895
* UIProcess/PageClient.h: Renamed didNotHandleKeyEvent to
doneWithKeyEvent and added a bool wasEventHandled argument.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Changed code to call
doneWithKeyEvent and call even if event was handled.
* UIProcess/API/mac/PageClientImpl.h: Updated for above change.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithKeyEvent): Ditto. But also
call [NSCursor setHiddenUntilMouseMoves:YES] when a key down
event was handled. This matches what -[WebHTMLView keyDown:] does.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::doneWithKeyEvent): Ditto.
* UIProcess/API/qt/qwkpage_p.h: Ditto.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::doneWithKeyEvent): Ditto.
* UIProcess/win/WebView.h: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 4 Feb 2011 23:48:25 +0000 (23:48 +0000)]
2011-02-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697
New pixel test that seeks to specific currentTimes and records the rendered frame.
* media/content/test-25fps.mp4: Added.
* media/content/test-25fps.ogv: Added.
* media/video-frame-accurate-seek-expected.txt: Added.
* media/video-frame-accurate-seek.html: Added.
* platform/mac/media/video-frame-accurate-seek-expected.checksum: Added.
* platform/mac/media/video-frame-accurate-seek-expected.png: Added.
2011-02-04 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
Frame accurate seeking isn't always accurate
https://bugs.webkit.org/show_bug.cgi?id=52697
Test: media/video-frame-accurate-seek.html
Make seeking slightly more accurate by rounding instead of truncating
when converting from seconds-in-float to time/timeScale.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTTime):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue):
* platform/graphics/win/QTMovie.cpp:
(QTMovie::setCurrentTime):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 23:45:27 +0000 (23:45 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813
* storage/indexeddb/request-event-propagation-expected.txt: Added.
* storage/indexeddb/request-event-propagation.html: Added.
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Second IndexedDB events overhaul patch
https://bugs.webkit.org/show_bug.cgi?id=53813
If an IDBRequest has a IDBTransaction, it should propogate
events through it. In order to do this, IDBRequest needs to
hold a transaction frontend object rather than a backend one.
Test: storage/indexeddb/request-event-propagation.html
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::IDBCursor):
* storage/IDBCursor.h:
(WebCore::IDBCursor::create):
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setSetVersionTransaction):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* storage/IDBDatabase.h:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* storage/IDBIndex.h:
(WebCore::IDBIndex::create):
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::create):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::contextDestroyed):
(WebCore::IDBTransaction::enqueueEvent):
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 23:43:19 +0000 (23:43 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
* storage/indexeddb/error-causes-abort-by-default.html: Added.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
(WebCore::IDBEvent::dispatch):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore::IDBTransaction::backend):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Fri, 4 Feb 2011 23:36:37 +0000 (23:36 +0000)]
2011-02-04 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727
For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.
No new tests because no new functionality.
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createReadable):
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::create):
* platform/chromium/PlatformBridge.h:
* platform/chromium/ReadableDataObject.cpp:
(WebCore::ReadableDataObject::create):
(WebCore::ReadableDataObject::ReadableDataObject):
(WebCore::ReadableDataObject::getData):
(WebCore::ReadableDataObject::urlTitle):
(WebCore::ReadableDataObject::htmlBaseUrl):
(WebCore::ReadableDataObject::filenames):
(WebCore::ReadableDataObject::ensureTypeCacheInitialized):
* platform/chromium/ReadableDataObject.h:
2011-02-04 Daniel Cheng <dcheng@chromium.org>
Reviewed by Dmitry Titov.
Clone WebClipboard to be frame-specific.
https://bugs.webkit.org/show_bug.cgi?id=53727
For drop operations, Chrome currently snapshots the data and copies it
into the renderer process. As we add more supported drag data types, the
copy will become increasingly expensive. Instead, we'd like to snapshot
data in the browser to reduce the amount of data copied and to support
Blob in DataTransferItem. In order to allow this, we associated
WebClipboard with a frame so it can correctly route its IPCs to the
corresponding Chromium host.
* public/WebFrameClient.h:
(WebKit::WebFrameClient::clipboard):
* src/PlatformBridge.cpp:
(WebCore::getClipboard):
(WebCore::PlatformBridge::clipboardReadAvailableTypes):
(WebCore::PlatformBridge::clipboardReadData):
(WebCore::PlatformBridge::clipboardReadFilenames):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::fromFrame):
* src/WebFrameImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::dragTargetDragEnterNew):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 23:34:45 +0000 (23:34 +0000)]
[Chromium] Remove Chromium-specific baselines that we no longer need.
* platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/ruby/nested-ruby-expected.png: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 23:33:25 +0000 (23:33 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Revert https://bugs.webkit.org/show_bug.cgi?id=53795
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt: Removed.
* storage/indexeddb/error-causes-abort-by-default.html: Removed.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Revert https://bugs.webkit.org/show_bug.cgi?id=53795
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 23:19:11 +0000 (23:19 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Marked test, added in r77680 as failing due to lighttpd.
* platform/chromium/test_expectations.txt: Marked.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 23:08:55 +0000 (23:08 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Update Leopard baselines for fast/blockflow, this time correctly.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
* platform/mac-leopard/fast/blockflow/fieldsets-expected.png:
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Removed.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 22:54:52 +0000 (22:54 +0000)]
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Merge in some GPU expectations that got dropped in r77666, get lint to pass.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 22:49:13 +0000 (22:49 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Add Leopard-specific pixel results for fast/ruby.
* platform/mac-leopard/fast/ruby/nested-ruby-expected.checksum: Added.
* platform/mac-leopard/fast/ruby/nested-ruby-expected.png: Added.
* platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.checksum: Added.
* platform/mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-empty-rt-expected.png:
* platform/mac-leopard/fast/ruby/ruby-length-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-length-expected.png:
* platform/mac-leopard/fast/ruby/ruby-run-break-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-run-break-expected.png:
* platform/mac-leopard/fast/ruby/ruby-runs-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-runs-expected.png:
* platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-runs-spans-expected.png:
* platform/mac-leopard/fast/ruby/ruby-simple-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-simple-expected.png:
* platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-simple-rp-expected.png:
* platform/mac-leopard/fast/ruby/ruby-trailing-expected.checksum:
* platform/mac-leopard/fast/ruby/ruby-trailing-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.checksum:
* platform/mac-leopard/fast/ruby/rubyDOM-remove-text2-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 4 Feb 2011 22:41:55 +0000 (22:41 +0000)]
2011-02-04 Martin Galpin <martin@66laps.com>
Reviewed by David Levin.
CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773
* http/tests/xmlhttprequest/cross-origin-preflight-get-expected.txt: Added.
* http/tests/xmlhttprequest/cross-origin-preflight-get.html: Added.
* http/tests/xmlhttprequest/resources/cross-origin-preflight-get.php: Added.
2011-02-04 Martin Galpin <martin@66laps.com>
Reviewed by David Levin.
CORS origin header not set on GET when a preflight request is required.
https://bugs.webkit.org/show_bug.cgi?id=50773
Test: http/tests/xmlhttprequest/cross-origin-preflight-get.html
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::preflightSuccess):
Explicitly set the request origin after a preflight request succeeds.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 22:38:12 +0000 (22:38 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/duplicates-expected.txt:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt: Copied from LayoutTests/storage/indexeddb/cursor-index-delete-expected.txt.
* storage/indexeddb/error-causes-abort-by-default.html: Added.
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
First step towards event propogation within IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53795
This is the first step towards implementing
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11348
within IndexedDB. I've created a method that knows how
to capture and bubble (based on Node's dispatchGenericEvent).
I've then changed IDBRequest to use it.
The only functional change is that preventDefault now must
be called in error events to prevent the transaction from
being aborted. The tests reflect this change and there's one
specific test to look at this behavior.
Test: storage/indexeddb/error-causes-abort-by-default.html
* storage/IDBAbortEvent.cpp:
(WebCore::IDBAbortEvent::create):
(WebCore::IDBAbortEvent::IDBAbortEvent):
* storage/IDBAbortEvent.h:
* storage/IDBCompleteEvent.cpp:
(WebCore::IDBCompleteEvent::create):
(WebCore::IDBCompleteEvent::IDBCompleteEvent):
* storage/IDBCompleteEvent.h:
* storage/IDBErrorEvent.cpp:
(WebCore::IDBErrorEvent::IDBErrorEvent):
* storage/IDBEvent.cpp:
(WebCore::IDBEvent::IDBEvent):
(WebCore::IDBEvent::dispatch):
* storage/IDBEvent.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBRequest.h:
* storage/IDBSuccessEvent.cpp:
(WebCore::IDBSuccessEvent::IDBSuccessEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
(WebCore::IDBTransaction::backend):
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::taskTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 4 Feb 2011 22:37:06 +0000 (22:37 +0000)]
2011-02-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit2 clients fail to launch on Windows if client exe is in a different directory from WebKit
https://bugs.webkit.org/show_bug.cgi?id=53810
<rdar://problem/
8946085>
If WebKit2WebProcess.exe is in a different directory from the client process, and that
client process uses CreateProcess to launch WebKit2WebProcess, the DLL search path may
end up excluding the directory containing WebKit. To address this, we use SetDllDirectory
to explicitly include the WebKit directory in the DLL search path.
* win/MainWin.cpp:
(wWinMain): Use SetDllDirectory and LoadLibrary to load WebKit.dll from WebKit2WebProcess.exe
* win/WebKit2WebProcessCommon.vsprops: Don't link directly to WebKit. Link against shlwapi.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 4 Feb 2011 22:31:00 +0000 (22:31 +0000)]
2011-02-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Bump Windows minimum system requirement to XPSP2
https://bugs.webkit.org/show_bug.cgi?id=53807
* win/tools/vsprops/common.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 22:29:28 +0000 (22:29 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Updated Win and Linux baselines after r77665.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Fri, 4 Feb 2011 22:08:35 +0000 (22:08 +0000)]
2011-02-04 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline chromium after r77654.
text-align attribute in <select> is ignored both in button text and drop-down
items.
* platform/chromium-linux/fast/text/international/bidi-menulist-expected.checksum:
* platform/chromium-linux/fast/text/international/bidi-menulist-expected.png:
* platform/chromium-linux/fast/text/international/bidi-menulist-expected.txt:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.checksum:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 22:05:51 +0000 (22:05 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Add Leopard-specific pixel results for fast/blockflow.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
* platform/mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/block-level-images-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/block-level-images-expected.png: Added.
* platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/border-vertical-lr-expected.png: Added.
* platform/mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/english-lr-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/english-lr-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-lr-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-selection-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-rl-text-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
* platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
* platform/mac-leopard/fast/blockflow/vertical-font-fallback-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 21:53:36 +0000 (21:53 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Remove platform-specific baselines, since we match platform/mac here.
* platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 21:50:48 +0000 (21:50 +0000)]
Add a test case for encode/decode of FormData/FormDataElement
If the fix made in r77401 is broken, this new test will crash.
Fixes <http://webkit.org/b/53616> <rdar://problem/
8949883>.
Reviewed by Sam Weinig.
Tools:
* TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
* TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
(TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
(TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
form, an return the session state data.
(TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
and restore it into another WKPage.
* TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/copy-resources.cmd:
Added new files.
Source/WebKit2:
Allow passing a null filter callback to WKPageCopySessionState
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Check if the filter is null
before calling it.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 21:50:09 +0000 (21:50 +0000)]
Move code to run JavaScript tests into its own files
This will allow other tests to use this mechanism.
Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
world
Reviewed by Sam Weinig.
* TestWebKitAPI/JavaScriptTest.cpp: Added.
* TestWebKitAPI/JavaScriptTest.h: Added.
Moved code here...
* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Added the new files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 21:48:29 +0000 (21:48 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Update mac expectations.
* platform/chromium/test_expectations.txt: Updated.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 21:43:24 +0000 (21:43 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Csaba Osztrogonác.
[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674
* platform/qt/Skipped:
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Csaba Osztrogonác.
[Qt]REGRESSION(r76951): media/controls-without-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=53674
* css/mediaControlsQt.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 4 Feb 2011 21:27:35 +0000 (21:27 +0000)]
2011-02-04 Mihai Parparita <mihaip@chromium.org>
Unreviewed GTK expectations update.
Unskip fast/history/timed-refresh-in-cached-frame.html, it should pass
with http://trac.webkit.org/changeset/77559.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 4 Feb 2011 21:25:21 +0000 (21:25 +0000)]
WebKit2: DidInitiateLoadForResource needs to know if the resource is being loaded by a committed or provisional frame
https://bugs.webkit.org/show_bug.cgi?id=53794
Reviewed by John Sullivan.
When we navigate from one page to another, there can be multiple subresource requests between when
the new page has started its provisional load and when it has committed the load.
There can be:
- The main resource load of the provisional page
- Synchronous XHR from the unload event of the loaded page.
WebKit clients need to be able to differentiate between these loads.
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didInitiateLoadForResource): Pass whether or not the page is provisionally loading
to the client.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Add a new parameter to DidInitiateLoadForResource.
* UIProcess/WebResourceLoadClient.cpp:
(WebKit::WebResourceLoadClient::didInitiateLoadForResource): a new parameter to didInitiateLoadForResource.
* UIProcess/WebResourceLoadClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): Pass whether or not the page is currently
in a provisional load (checked by seeing if the DocumentLoader matches the FrameLoader's provisionalDocumentLoader)
to the UI Process.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 21:21:58 +0000 (21:21 +0000)]
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
merge test expectations for chromium, chromium-gpu. From
now on, we will track GPU-specific expectations with the
"GPU" modifier in the main file, rather than in a separate
file (and non-GPU-specific expectations with the "CPU"
modifier.
https://bugs.webkit.org/show_bug.cgi?id=53562
* platform/chromium-gpu/test_expectations.txt: Removed.
* platform/chromium/test_expectations.txt:
2011-02-04 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
merge test expectations for chromium, chromium-gpu. The
chromium-gpu port will no longer maintain its own
test expectations file.
Also add in a graphics_type() call on the port object to
determine what graphics type to use in the test configuration,
and log the configuration as a config setting.
https://bugs.webkit.org/show_bug.cgi?id=53562
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 4 Feb 2011 21:18:24 +0000 (21:18 +0000)]
<rdar://problem/
8902704> Make ruby text size 50% by default
https://bugs.webkit.org/show_bug.cgi?id=53723
Reviewed by Darin Adler and Dave Hyatt.
Source/WebCore:
* css/html.css:
(ruby > rt): Changed the font-size from 60% to 50%.
LayoutTests:
* fast/text/emphasis-avoid-ruby-expected.checksum:
* fast/text/emphasis-avoid-ruby-expected.png:
* fast/text/emphasis-avoid-ruby-expected.txt:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
* platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/ruby/nested-ruby-expected.checksum:
* platform/mac/fast/ruby/nested-ruby-expected.png:
* platform/mac/fast/ruby/nested-ruby-expected.txt:
* platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
* platform/mac/fast/ruby/ruby-beforeafter-expected.png:
* platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
* platform/mac/fast/ruby/ruby-empty-rt-expected.checksum:
* platform/mac/fast/ruby/ruby-empty-rt-expected.png:
* platform/mac/fast/ruby/ruby-empty-rt-expected.txt:
* platform/mac/fast/ruby/ruby-length-expected.checksum:
* platform/mac/fast/ruby/ruby-length-expected.png:
* platform/mac/fast/ruby/ruby-length-expected.txt:
* platform/mac/fast/ruby/ruby-run-break-expected.checksum:
* platform/mac/fast/ruby/ruby-run-break-expected.png:
* platform/mac/fast/ruby/ruby-run-break-expected.txt:
* platform/mac/fast/ruby/ruby-runs-expected.checksum:
* platform/mac/fast/ruby/ruby-runs-expected.png:
* platform/mac/fast/ruby/ruby-runs-expected.txt:
* platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
* platform/mac/fast/ruby/ruby-runs-spans-expected.png:
* platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
* platform/mac/fast/ruby/ruby-simple-expected.checksum:
* platform/mac/fast/ruby/ruby-simple-expected.png:
* platform/mac/fast/ruby/ruby-simple-expected.txt:
* platform/mac/fast/ruby/ruby-simple-rp-expected.checksum:
* platform/mac/fast/ruby/ruby-simple-rp-expected.png:
* platform/mac/fast/ruby/ruby-simple-rp-expected.txt:
* platform/mac/fast/ruby/ruby-trailing-expected.checksum:
* platform/mac/fast/ruby/ruby-trailing-expected.png:
* platform/mac/fast/ruby/ruby-trailing-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-text2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 4 Feb 2011 21:16:12 +0000 (21:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53610
Regression: adjacent sibling selector not working as expected
<rdar://problem/
8960033>
Reviewed by Dimitri Glazkov.
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/
8948643>
Test for additional conditions in parent style that prevent sharing.
Tests: fast/selectors/style-sharing-adjacent-selector.html
fast/selectors/style-sharing-last-child.html
* css/CSSStyleSelector.cpp:
(WebCore::parentStylePreventsSharing):
(WebCore::CSSStyleSelector::locateSharedStyle):
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=53574
REGRESSION (r76012): :last-child:after not working as expected
<rdar://problem/
8948643>
* fast/selectors/style-sharing-adjacent-selector-expected.txt: Added.
* fast/selectors/style-sharing-adjacent-selector.html: Added.
* fast/selectors/style-sharing-last-child-expected.txt: Added.
* fast/selectors/style-sharing-last-child.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 4 Feb 2011 21:11:39 +0000 (21:11 +0000)]
2011-02-04 Mark Mentovai <mark@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium GYP build fix.
When various settings were moved to webcore_prerequisites in r66364,
things that should have been direct_dependent_settings were not marked
as such. GYP 'defines', for example, make no sense on a 'none'-type
target such as webcore_prerequisites. It appears that it was intended
for these settings to be pushed to direct dependents, which would make
direct_dependent_settings correct.
Losing the ChromiumWebCoreObjC defines on the Mac, for example, caused
http://crbug.com/71537, which at best causes Mac console log spew, and
at worst may result in Chromium's copy of WebCore using system
definitions of certain Objective-C classes at runtime, or vice-versa.
The build now includes a postbuild step to prevent
http://crbug.com/71537 from regressing again. The build will fail upon
regression.
https://bugs.webkit.org/show_bug.cgi?id=53630
* WebCore.gyp/WebCore.gyp: Move things in webcore_prerequisites into
direct_dependent_settings as needed, add the check_objc_rename
postbuild step.
* WebCore.gyp/mac/check_objc_rename.sh: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 4 Feb 2011 21:09:44 +0000 (21:09 +0000)]
BUILD FIX: REALLY remove the last vestiges of JSVALUE32!
<rdar://problem/
8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>
* DerivedSources.make: Removed dependency on
JavaScriptCore.JSVALUE32.exp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 4 Feb 2011 21:04:36 +0000 (21:04 +0000)]
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Mark Rowe.
Mac WebKit2 should use the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53802
<rdar://problem/
7881419>
<rdar://problem/
7881447>
<rdar://problem/
8252632>
<rdar://problem/
8479422>
<rdar://problem/
8633813>
<rdar://problem/
8734512>
<rdar://problem/
8787660>
* UIProcess/API/mac/WKView.mm:
(useNewDrawingArea):
Return true. Eventually this function should be removed, but let's keep it for now so
we can go back to the old drawing area if necessary.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Fri, 4 Feb 2011 20:49:24 +0000 (20:49 +0000)]
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file.
https://bugs.webkit.org/show_bug.cgi?id=52594
* platform/qt/Skipped: Unskip plugins/iframe-shims.html
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594
Move Chromium code for identifying and cutting out
iframe shims from plugins to cross-platform utility file
IFrameShimSupport.cpp.
Amend PluginViewQt to use this code to handle shims correctly.
* WebCore.gypi: Add Chromium support for IFrameShimSupport.cpp
* WebCore.pro: Add Qt support for IFrameShimSupport.cpp
* plugins/IFrameShimSupport.cpp: Added.
(WebCore::getObjectStack):
(WebCore::iframeIsAbovePlugin):
(WebCore::getPluginOcclusions):
* plugins/IFframeShimSupport.h: Added.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::setNPWindowIfNeeded):
2011-02-04 Robert Hogan <robert@webkit.org>
Reviewed by Darin Fisher.
Move chromium iframe shim code to cross-platform file
https://bugs.webkit.org/show_bug.cgi?id=52594
* src/WebPluginContainerImpl.cpp: Move code to WebCore/plugin/IFrameShimSupport.cpp
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 4 Feb 2011 20:47:07 +0000 (20:47 +0000)]
2011-02-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
WebKit2: Crash in WebPageProxy::setPendingAPIRequestURL after web process crashed
https://bugs.webkit.org/show_bug.cgi?id=53799
<rdar://problem/
8943956>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reload):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 4 Feb 2011 20:45:19 +0000 (20:45 +0000)]
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Fix a shared memory leak
https://bugs.webkit.org/show_bug.cgi?id=53800
Move the send right representing the shared memory.
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::encode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 4 Feb 2011 20:38:44 +0000 (20:38 +0000)]
<rdar://problem/
8636239> and https://bugs.webkit.org/show_bug.cgi?id=53785
WebKit2: Pages with dynamically inserted iframes can add extraneous back/forward items.
Reviewed by Anders Carlsson.
Source/WebKit2:
WebCore doesn't gracefully handle the case where the decidePolicyForNavigationAction callback
does not occur synchronously. Let's make it synchronous.
Change WebPageProxy to handle this message reply synchronously:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Make the navigation policy action message be synchronous.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Add a 6-argument varient
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Send the message synchronously.
LayoutTests:
* fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt: Added.
* fast/loader/dynamic-iframe-extra-back-forward-item.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 4 Feb 2011 20:35:42 +0000 (20:35 +0000)]
Windows build fix.
Correct prebuild build-stopping rule to allow project only rebuilds.
* win/WebKit2WebProcessPreBuild.cmd:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 4 Feb 2011 20:33:01 +0000 (20:33 +0000)]
Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup
window, or when running regression tests.
https://bugs.webkit.org/show_bug.cgi?id=53798
<rdar://problem/
8814364>
Reviewed by Adam Roben.
Only assert about the state of m_inspectorWindow and m_inspectorView if the inspector is visible.
Also, only call ::DestroyWindow if the HWND is non-null, just to be safe.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformClose):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Fri, 4 Feb 2011 20:30:20 +0000 (20:30 +0000)]
2011-02-04 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Override as true.
* src/WebViewImpl.cpp: Remove directionality hint from autofill drop-down setting.
2011-02-04 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Implement "<option> should implement the dir attribute" for chromium port after r76983.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html
added in r76983.
* platform/chromium/PopupMenuChromium.cpp: Remove directionality hint from
<select> drop-down setting.
(WebCore::PopupListBox::paintRow): Use <option>'s directionality to paint
items in drop-down and pass-in bidi override flag when creating text run.
* platform/chromium/PopupMenuChromium.h: Remove directionalityHint from
PopupContainerSettings.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 20:23:04 +0000 (20:23 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Add platform/mac-leopard baselines for tests added in r77639. The text rendering is
different enough for them to be different from mac-snowleopard.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-2-expected.png: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
* platform/mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
* platform/mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 20:10:25 +0000 (20:10 +0000)]
2011-02-04 Jeremy Orlow <jorlow@chromium.org>
Build fix from merge mistake.
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::ensureEventTargetData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Fri, 4 Feb 2011 19:57:41 +0000 (19:57 +0000)]
2011-02-04 Levi Weintraub <leviw@chromium.org>
Reviewed by Darin Adler.
Remove unneeded function declarations in comments in EditorClient.h
https://bugs.webkit.org/show_bug.cgi?id=53745
Removing unused commented out function declarations. No tests since this is just cleanup.
* page/EditorClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 19:50:24 +0000 (19:50 +0000)]
2011-02-03 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Refactor IDBRequest and IDBTransaction a bit
https://bugs.webkit.org/show_bug.cgi?id=53565
There were a lot of subtle issues with the way IDBTransaction
and IDBRequest used to be written. This cleans a lot of them up
and largely simplifies the logic. Using EventQueue rather than
timers is one example of the simplification.
* bindings/scripts/CodeGeneratorV8.pm:
* dom/EventQueue.cpp:
(WebCore::EventQueue::enqueueEvent):
(WebCore::EventQueue::dispatchEvent):
* storage/IDBCursor.cpp:
(WebCore::IDBCursor::continueFunction):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::create):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::eventTargetData):
(WebCore::IDBRequest::ensureEventTargetData):
* storage/IDBRequest.h:
(WebCore::IDBRequest::dispatchEvent):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
(WebCore::IDBTransaction::onTimeout):
(WebCore::IDBTransaction::canSuspend):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::enqueueEvent):
(WebCore::IDBTransaction::eventTargetData):
(WebCore::IDBTransaction::ensureEventTargetData):
* storage/IDBTransaction.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 19:38:01 +0000 (19:38 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Add baselines for tests, added in r77644.
* platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 19:31:52 +0000 (19:31 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Temporarily add tests added in r77639 as failing, because
we can't see the baselines for these tests (they are in platform/mac-snowleopard).
* platform/chromium/test_expectations.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Fri, 4 Feb 2011 19:22:50 +0000 (19:22 +0000)]
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
* storage/indexeddb/tutorial.html:
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
Remove timeout and ontimeout from IDBTransaction per the spec.
* WebCore.gypi:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBDatabaseBackendInterface.h:
* storage/IDBTimeoutEvent.cpp: Removed.
* storage/IDBTimeoutEvent.h: Removed.
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
* storage/IDBTransactionBackendImpl.h:
* storage/IDBTransactionCallbacks.h:
2011-02-01 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Remove the timeout event from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=53521
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
* public/WebIDBTransactionCallbacks.h:
* src/IDBDatabaseProxy.cpp:
(WebCore::IDBDatabaseProxy::transaction):
* src/IDBDatabaseProxy.h:
* src/IDBTransactionCallbacksProxy.cpp:
* src/IDBTransactionCallbacksProxy.h:
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::transaction):
* src/WebIDBDatabaseImpl.h:
* src/WebIDBTransactionCallbacksImpl.cpp:
* src/WebIDBTransactionCallbacksImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 19:16:05 +0000 (19:16 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Add baselines for tests, added in r77639.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-2-expected.png: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-2-expected.txt: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.checksum: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.checksum: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.checksum: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Fri, 4 Feb 2011 18:47:41 +0000 (18:47 +0000)]
AX: Can't set accessibility overridden attributes on web objects
https://bugs.webkit.org/show_bug.cgi?id=53725
Reviewed by Darin Adler.
accessibilitySetOverriddenValue does not work on AX objects from WebCore because
the right method needed to be overridden (accessibilitySupportsOverriddenAttributes).
Unfortunately, there's no way to test this from DRT, since AppKit returns the overridden
attribute only when an AX client asks for it through the AX frameworks.
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 18:42:30 +0000 (18:42 +0000)]
2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
* fast/repaint/slider-thumb-drag-release.html: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.png: Added.
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
2011-02-03 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
REGRESSION(r76147): Slider thumb is not repainted when let go outside of the slider track.
https://bugs.webkit.org/show_bug.cgi?id=53691
Test: fast/repaint/slider-thumb-drag-release.html
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::stopDragging): Added dirtying the layout bit to ensure
that the thumb is repainted.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 4 Feb 2011 18:32:41 +0000 (18:32 +0000)]
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Add "show more" data grid node and waiting message UI components.
https://bugs.webkit.org/show_bug.cgi?id=53763
- "show more" data grid node is used for on-demand population of
data grid contents (similar to DOM tree capability for limiting
displayed nodes count);
- waiting message is used for informing user about long lasting
operations (with a possibility to cancel them).
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/PleaseWaitMessage.js: Added.
(WebInspector.PleaseWaitMessage):
* inspector/front-end/ShowMoreDataGridNode.js: Added.
(WebInspector.ShowMoreDataGridNode):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
(.data-grid button):
(.please-wait-msg):
* inspector/front-end/inspector.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 18:32:20 +0000 (18:32 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
Update mac baselines. They pixel-rotted.
* platform/mac-leopard/fast/backgrounds/background-clip-text-expected.png:
* platform/mac-leopard/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
* platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
* platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/mac-leopard/fast/backgrounds/size/backgroundSize15-expected.png:
* platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.checksum:
* platform/mac-leopard/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum:
* platform/mac/fast/backgrounds/animated-svg-as-background-expected.png:
* platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum:
* platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png:
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum:
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
* platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 4 Feb 2011 18:27:06 +0000 (18:27 +0000)]
2011-02-04 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
https://bugs.webkit.org/show_bug.cgi?id=53781
* Scripts/check-inspector-strings:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 4 Feb 2011 18:25:28 +0000 (18:25 +0000)]
2011-02-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Go out of accelerated compositing mode when the drawing area is destroyed
https://bugs.webkit.org/show_bug.cgi?id=53788
This fixes a crash in the UI process if a web process crashes while in accelerated compositing mode.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 4 Feb 2011 18:18:30 +0000 (18:18 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=53740
<rdar://problem/
8503629> Allow platforms to specify if the placeholder should be visible when text controls are focused
Reviewed by Dan Bernstein.
Tests:
fast/forms/textarea-placeholder-visibility-1.html
fast/forms/textarea-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-1.html
fast/forms/input-placeholder-visibility-2.html
fast/forms/input-placeholder-visibility-3.html
* html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Add a check for shouldShowPlaceholderWhenFocused.
* html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateValue):
Whenever the value is updated, we should also update placeholder visibility.
* rendering/RenderTheme.h: (WebCore::RenderTheme::shouldShowPlaceholderWhenFocused):
Make the default the same as the existing behavior.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
Show placeholder when appropriate.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 4 Feb 2011 18:13:02 +0000 (18:13 +0000)]
<rdar://problem/
8957409> Remove last vestiges of JSVALUE32
<http://webkit.org/b/53779>
Reviewed by Darin Adler.
Support for JSVALUE32 was originaly removed in r70111.
* Configurations/JavaScriptCore.xcconfig: Changed armv6 to use
JavaScriptCore.JSVALUE32_64.exp and ppc64 to use
JavaScriptCore.JSVALUE64.exp to match Platform.h.
* DerivedSources.make: Removed rule for
JavaScriptCore.JSVALUE32.exp.
* JavaScriptCore.JSVALUE32only.exp: Removed.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed references
to JavaScriptCore.JSVALUE32only.exp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 18:02:54 +0000 (18:02 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Tweak expectations for passing tests.
* platform/chromium/test_expectations.txt: More tweakage.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 18:01:25 +0000 (18:01 +0000)]
Include the crashing function in the link to a crash log on Mac
Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
function that crashed on Mac
Reviewed by David Kilzer.
* Scripts/old-run-webkit-tests:
(crashLocation): Moved all the Windows code inside an if instead of using an early return,
but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
the crash log.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Fri, 4 Feb 2011 17:31:35 +0000 (17:31 +0000)]
Use static_cast and other style cleanup in YarrInterpreter.cpp
<http://webkit.org/b/53772>
Reviewed by John Sullivan.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::readChecked): Use
static_cast.
(JSC::Yarr::Interpreter::InputStream::checkInput): Remove
unnecessary else block.
(JSC::Yarr::Interpreter::matchAssertionEOL): Ditto.
(JSC::Yarr::Interpreter::backtrackBackReference): Ditto.
(JSC::Yarr::ByteCompiler::emitDisjunction): Use static_cast.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 17:20:10 +0000 (17:20 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Remove more passing tests.
* platform/chromium/test_expectations.txt: Even more passages removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 4 Feb 2011 17:07:47 +0000 (17:07 +0000)]
Link to Mac crash logs from results.html
Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
results.html
Reviewed by David Kilzer.
* Scripts/old-run-webkit-tests:
(captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 4 Feb 2011 17:05:57 +0000 (17:05 +0000)]
2011-02-04 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Removed passing tests.
* platform/chromium/test_expectations.txt: Passages removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc