abarth@webkit.org [Sun, 2 Jan 2011 06:22:31 +0000 (06:22 +0000)]
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
Reviewed by Eric Seidel.
Update references to JavaScriptCore to point to the new location.
* Android.mk:
* CMakeLists.txt:
* DerivedSources.pro:
* GNUmakefile.am:
* Makefile:
* WebKit.pri:
* WebKit.pro:
* wscript:
Tools:
Update references to JavaScriptCore to point to the new location.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/ImageDiff.pro:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* DumpRenderTree/wscript:
* Scripts/build-jsc:
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/run-javascriptcore-tests:
* Scripts/update-javascriptcore-test-results:
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/common/config/build_unittest.py:
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/WebKitTestRunner.pro:
* wx/build/settings.py:
WebCore:
Update references to JavaScriptCore.
* Android.derived.jscbindings.mk:
* Android.v8bindings.mk:
* CMakeLists.txt:
* WebCore.gyp/WebCore.gyp:
* WebCore.pro:
- These changes are subtle and might not be 100% correct.
* move-js-headers.sh:
WebKit/chromium:
* WebKit.gyp:
- Point to JavaScriptCore in its new location.
WebKit/gtk:
* GNUmakefile.am:
* docs/GNUmakefile.am:
- Point to JavaScriptCore in its new location.
WebKit/qt:
* WebKit_pch.h:
* docs/qtwebkit.qdocconf:
- Point to JavaScriptCore in its new location.
WebKit/win:
* WebKit.vcproj/WebKit.sln:
- Point to JavaScriptCore in its new location.
WebKit/wx:
* bindings/python/wscript:
* wscript:
- Point to JavaScriptCore in its new location.
WebKit2:
* WebKit2.pro:
- Point to JavaScriptCore in its new location.
Websites/bugs.webkit.org:
* PrettyPatch/PrettyPatch.rb:
- Remove reference to JavaScriptCore as a source directory.
Websites/webkit.org:
* coding/assertion-guidelines.html:
- Update documentation to point to the new location of
JavaScriptCore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Jan 2011 04:33:03 +0000 (04:33 +0000)]
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340
We now pass the ScriptExecutionContext to window.close so it can find
the Frame and check whether navigation is allowed. This check will
almost always pass because you can only close top-level frames, but the
check will fail when the calling script is sandboxed.
Tests: fast/frames/sandboxed-iframe-close-top-noclose.html
fast/frames/sandboxed-iframe-close-top.html
* page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
* page/DOMWindow.h:
* page/DOMWindow.idl:
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340
Test the interaction between the HTML5 sandbox and window.close.
* fast/frames/resources/close-top.html: Added.
* fast/frames/resources/sandboxed-iframe-close-top-does-close.html: Added.
* fast/frames/resources/sandboxed-iframe-close-top-does-not-close.html: Added.
* fast/frames/sandboxed-iframe-close-top-expected.txt: Added.
* fast/frames/sandboxed-iframe-close-top-noclose-expected.txt: Added.
* fast/frames/sandboxed-iframe-close-top-noclose.html: Added.
* fast/frames/sandboxed-iframe-close-top.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Jan 2011 02:28:41 +0000 (02:28 +0000)]
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152
To enforce the sandbox restrictions on History, we need to pass the
ScriptExecutionContext to WebCore. This patch leaves the original
History methods in place because they are used directly by folks who
don't care about security checks.
Test: fast/frames/sandboxed-iframe-history-denied.html
* page/History.cpp:
(WebCore::History::back):
(WebCore::History::forward):
(WebCore::History::go):
* page/History.h:
* page/History.idl:
2011-01-01 Justin Schuh <jschuh@chromium.org>
Reviewed by Eric Seidel.
sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152
Test that sandboxed iframes cannot use history to navigate the top
frame. This test is less than ideal, as described in the test itself.
If I was really on top of things, I'd add a test for successful use of
the history API when allow-top-navigation is set, but that test would
be complicated and I'm lazy (enough to copy directly from abarth).
* fast/frames/sandboxed-iframe-history-denied-expected.txt: Added.
* fast/frames/sandboxed-iframe-history-denied.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Jan 2011 02:04:41 +0000 (02:04 +0000)]
Move Sources to Source
https://bugs.webkit.org/show_bug.cgi?id=51794
Reviewed by Eric Seidel.
Update build files to point to the new location.
* CMakeLists.txt:
* GNUmakefile.am:
* Makefile:
* autogen.sh:
* configure.ac:
Tools:
Update scripts to point to the new location.
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/webkitpy/common/config/build.py:
* Scripts/webkitpy/common/config/build_unittest.py:
Websites/bugs.webkit.org:
* PrettyPatch/PrettyPatch.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Jan 2011 01:50:25 +0000 (01:50 +0000)]
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty file.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/Entity.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Jan 2011 01:43:35 +0000 (01:43 +0000)]
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty file.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSPopStateEventCustom.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Jan 2011 01:37:05 +0000 (01:37 +0000)]
2011-01-01 Adam Barth <abarth@webkit.org>
Remove empty files.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/BindingFrame.h: Removed.
* bindings/generic/BindingLocation.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 2 Jan 2011 00:35:41 +0000 (00:35 +0000)]
Changed WebKit2.xcodeproj's svn:ignore property up to match other projects'
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 1 Jan 2011 18:00:04 +0000 (18:00 +0000)]
2011-01-01 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by Darin Adler.
Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=51789
* bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when
Inspector is enabled
* dom/Document.cpp: Include Inspector headers when
Inspector is enabled
(WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie
handling
* html/HTMLDocument.cpp: Include Inspector headers when
Inspector is enabled
* loader/FrameLoader.cpp: Include Inspector headers when
Inspector is enabled
* loader/ResourceLoadNotifier.cpp: Include Inspector headers when
Inspector is enabled
* page/Chrome.cpp: Include Inspector headers when
Inspector is enabled
* page/Console.cpp: Include Inspector headers when
Inspector is enabled
* page/ContextMenuController.cpp: Include Inspector headers when
Inspector is enabled
* page/DOMWindow.cpp: Include Inspector headers when
Inspector is enabled
(WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie
handling
* page/EventHandler.cpp: Include Inspector headers when
Inspector is enabled
* page/Page.cpp: Include Inspector headers when
Inspector is enabled
* storage/Database.cpp: Include Inspector headers when
Inspector is enabled
* workers/AbstractWorker.cpp: Include Inspector headers when
Inspector is enabled
* workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when
Inspector is enabled
* workers/SharedWorker.cpp: Include Inspector headers when
Inspector is enabled
* workers/Worker.cpp: Include Inspector headers when
Inspector is enabled
* workers/WorkerContext.cpp: Include Inspector headers when
Inspector is enabled
* workers/WorkerMessagingProxy.cpp: Include Inspector headers when
Inspector is enabled
* xml/XMLHttpRequest.cpp: Include Inspector headers when
Inspector is enabled
(WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled
InspectorInstrumentationCookie handling
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Sat, 1 Jan 2011 11:01:08 +0000 (11:01 +0000)]
2011-01-01 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
One more rebaseline for a spelling test, and remove passing tests from
test_expectations.txt.
* platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.checksum: Added.
* platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.png: Added.
* platform/chromium-win/editing/spelling/inline_spelling_markers-expected.checksum: Added.
* platform/chromium-win/editing/spelling/inline_spelling_markers-expected.png: Added.
* platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Sat, 1 Jan 2011 06:54:06 +0000 (06:54 +0000)]
Unreviewed, test expectation update.
r74844 enabled spell checker on Chromium Linux and Chromium
Windows. So we need to update all of images with misspelled words.
* platform/chromium-linux/editing/deleting/delete-
3928305-fix-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-
3928305-fix-expected.png:
* platform/chromium-linux/editing/deleting/delete-
3959464-fix-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-
3959464-fix-expected.png:
* platform/chromium-linux/editing/deleting/delete-and-undo-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-and-undo-expected.png:
* platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.png:
* platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.png:
* platform/chromium-linux/editing/deleting/delete-tab-002-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-tab-002-expected.png:
* platform/chromium-linux/editing/deleting/delete-tab-003-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-tab-003-expected.png:
* platform/chromium-linux/editing/deleting/delete-to-select-table-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-to-select-table-expected.png:
* platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
* platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.png:
* platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.checksum:
* platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.png:
* platform/chromium-linux/editing/execCommand/
5569741-expected.checksum:
* platform/chromium-linux/editing/execCommand/
5569741-expected.png:
* platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.checksum:
* platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.png:
* platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.checksum:
* platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-linux/editing/execCommand/outdent-selection-expected.checksum:
* platform/chromium-linux/editing/execCommand/outdent-selection-expected.png:
* platform/chromium-linux/editing/inserting/
5418891-expected.checksum:
* platform/chromium-linux/editing/inserting/
5418891-expected.png:
* platform/chromium-linux/editing/inserting/editing-empty-divs-expected.checksum:
* platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-linux/editing/inserting/insert-
3907422-fix-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-
3907422-fix-expected.png:
* platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
* platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
* platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-007-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-007-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-012-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-012-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-013-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-013-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-014-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-014-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-015-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-015-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-016-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-016-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-017-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-017-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-018-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-018-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-019-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-019-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-020-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-020-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-021-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-022-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-022-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-025-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-025-expected.png:
* platform/chromium-linux/editing/inserting/insert-div-027-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-div-027-expected.png:
* platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.png:
* platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.png:
* platform/chromium-linux/editing/inserting/insert-tab-002-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-tab-002-expected.png:
* platform/chromium-linux/editing/inserting/insert-tab-003-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-tab-003-expected.png:
* platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
* platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
* platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.checksum:
* platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.png:
* platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.checksum:
* platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.png:
* platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.checksum:
* platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.png:
* platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.checksum:
* platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.png:
* platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.checksum:
* platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.png:
* platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.checksum:
* platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.png:
* platform/chromium-linux/editing/inserting/typing-002-expected.checksum:
* platform/chromium-linux/editing/inserting/typing-002-expected.png:
* platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
* platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
* platform/chromium-linux/editing/pasteboard/
4242293-expected.checksum:
* platform/chromium-linux/editing/pasteboard/
4242293-expected.png:
* platform/chromium-linux/editing/pasteboard/
4944770-1-expected.checksum:
* platform/chromium-linux/editing/pasteboard/
4944770-1-expected.png:
* platform/chromium-linux/editing/pasteboard/8145-2-expected.checksum:
* platform/chromium-linux/editing/pasteboard/8145-2-expected.png:
* platform/chromium-linux/editing/pasteboard/cut-text-001-expected.checksum:
* platform/chromium-linux/editing/pasteboard/cut-text-001-expected.png:
* platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.checksum:
* platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-end-4-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
* platform/chromium-linux/editing/pasteboard/merge-end-table-expected.checksum:
* platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png:
* platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.checksum:
* platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png:
* platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum:
* platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png:
* platform/chromium-linux/editing/pasteboard/paste-text-012-expected.checksum:
* platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png:
* platform/chromium-linux/editing/pasteboard/paste-text-013-expected.checksum:
* platform/chromium-linux/editing/pasteboard/paste-text-013-expected.png:
* platform/chromium-linux/editing/pasteboard/paste-text-014-expected.checksum:
* platform/chromium-linux/editing/pasteboard/paste-text-014-expected.png:
* platform/chromium-linux/editing/pasteboard/paste-text-019-expected.checksum:
* platform/chromium-linux/editing/pasteboard/paste-text-019-expected.png:
* platform/chromium-linux/editing/pasteboard/paste-xml-expected.checksum:
* platform/chromium-linux/editing/pasteboard/paste-xml-expected.png:
* platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.checksum:
* platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-linux/editing/selection/13804-expected.checksum:
* platform/chromium-linux/editing/selection/13804-expected.png:
* platform/chromium-linux/editing/selection/
5234383-1-expected.checksum:
* platform/chromium-linux/editing/selection/
5234383-1-expected.png:
* platform/chromium-linux/editing/selection/
5234383-2-expected.checksum:
* platform/chromium-linux/editing/selection/
5234383-2-expected.png:
* platform/chromium-linux/editing/selection/extend-by-word-001-expected.checksum:
* platform/chromium-linux/editing/selection/extend-by-word-001-expected.png:
* platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
* platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
* platform/chromium-linux/editing/selection/move-by-character-001-expected.checksum:
* platform/chromium-linux/editing/selection/move-by-character-001-expected.png:
* platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
* platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
* platform/chromium-linux/editing/selection/move-by-word-001-expected.checksum:
* platform/chromium-linux/editing/selection/move-by-word-001-expected.png:
* platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.checksum:
* platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-linux/editing/selection/unrendered-002-expected.checksum:
* platform/chromium-linux/editing/selection/unrendered-002-expected.png:
* platform/chromium-linux/editing/spelling/spelling-expected.checksum:
* platform/chromium-linux/editing/spelling/spelling-expected.png:
* platform/chromium-linux/editing/style/
5046875-2-expected.checksum:
* platform/chromium-linux/editing/style/
5046875-2-expected.png:
* platform/chromium-linux/editing/style/block-styles-007-expected.checksum:
* platform/chromium-linux/editing/style/block-styles-007-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-002-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-002-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-003-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-003-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-004-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-004-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-006-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-008-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-008-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-009-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-009-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-011-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-012-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
* platform/chromium-linux/editing/style/create-block-for-style-013-expected.checksum:
* platform/chromium-linux/editing/style/create-block-for-style-013-expected.png:
* platform/chromium-linux/fast/dom/blur-contenteditable-expected.checksum:
* platform/chromium-linux/fast/dom/blur-contenteditable-expected.png:
* platform/chromium-win/editing/deleting/delete-
3928305-fix-expected.checksum:
* platform/chromium-win/editing/deleting/delete-
3928305-fix-expected.png:
* platform/chromium-win/editing/deleting/delete-
3959464-fix-expected.checksum:
* platform/chromium-win/editing/deleting/delete-
3959464-fix-expected.png:
* platform/chromium-win/editing/deleting/delete-and-undo-expected.checksum:
* platform/chromium-win/editing/deleting/delete-and-undo-expected.png:
* platform/chromium-win/editing/deleting/delete-block-contents-003-expected.checksum:
* platform/chromium-win/editing/deleting/delete-block-contents-003-expected.png:
* platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.checksum:
* platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.png:
* platform/chromium-win/editing/deleting/delete-tab-002-expected.checksum:
* platform/chromium-win/editing/deleting/delete-tab-002-expected.png:
* platform/chromium-win/editing/deleting/delete-tab-003-expected.checksum:
* platform/chromium-win/editing/deleting/delete-tab-003-expected.png:
* platform/chromium-win/editing/deleting/delete-to-select-table-expected.checksum:
* platform/chromium-win/editing/deleting/delete-to-select-table-expected.png:
* platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
* platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
* platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.checksum:
* platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.png:
* platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.checksum:
* platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.png:
* platform/chromium-win/editing/deleting/smart-delete-002-expected.checksum:
* platform/chromium-win/editing/deleting/smart-delete-002-expected.png:
* platform/chromium-win/editing/deleting/smart-delete-003-expected.checksum:
* platform/chromium-win/editing/deleting/smart-delete-003-expected.png:
* platform/chromium-win/editing/deleting/smart-delete-004-expected.checksum:
* platform/chromium-win/editing/deleting/smart-delete-004-expected.png:
* platform/chromium-win/editing/execCommand/
5569741-expected.checksum:
* platform/chromium-win/editing/execCommand/
5569741-expected.png:
* platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.checksum:
* platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.png:
* platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.checksum:
* platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-win/editing/execCommand/outdent-selection-expected.checksum:
* platform/chromium-win/editing/execCommand/outdent-selection-expected.png:
* platform/chromium-win/editing/inserting/
5418891-expected.checksum:
* platform/chromium-win/editing/inserting/
5418891-expected.png:
* platform/chromium-win/editing/inserting/editing-empty-divs-expected.checksum:
* platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-win/editing/inserting/insert-
3907422-fix-expected.checksum:
* platform/chromium-win/editing/inserting/insert-
3907422-fix-expected.png:
* platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
* platform/chromium-win/editing/inserting/insert-br-004-expected.png:
* platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
* platform/chromium-win/editing/inserting/insert-br-005-expected.png:
* platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
* platform/chromium-win/editing/inserting/insert-br-007-expected.png:
* platform/chromium-win/editing/inserting/insert-div-007-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-007-expected.png:
* platform/chromium-win/editing/inserting/insert-div-012-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-012-expected.png:
* platform/chromium-win/editing/inserting/insert-div-013-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-013-expected.png:
* platform/chromium-win/editing/inserting/insert-div-014-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-014-expected.png:
* platform/chromium-win/editing/inserting/insert-div-015-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-015-expected.png:
* platform/chromium-win/editing/inserting/insert-div-016-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-016-expected.png:
* platform/chromium-win/editing/inserting/insert-div-017-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-017-expected.png:
* platform/chromium-win/editing/inserting/insert-div-018-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-018-expected.png:
* platform/chromium-win/editing/inserting/insert-div-019-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-019-expected.png:
* platform/chromium-win/editing/inserting/insert-div-020-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-020-expected.png:
* platform/chromium-win/editing/inserting/insert-div-021-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-021-expected.png:
* platform/chromium-win/editing/inserting/insert-div-022-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-022-expected.png:
* platform/chromium-win/editing/inserting/insert-div-025-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-025-expected.png:
* platform/chromium-win/editing/inserting/insert-div-027-expected.checksum:
* platform/chromium-win/editing/inserting/insert-div-027-expected.png:
* platform/chromium-win/editing/inserting/insert-paragraph-02-expected.checksum:
* platform/chromium-win/editing/inserting/insert-paragraph-02-expected.png:
* platform/chromium-win/editing/inserting/insert-paragraph-03-expected.checksum:
* platform/chromium-win/editing/inserting/insert-paragraph-03-expected.png:
* platform/chromium-win/editing/inserting/insert-tab-002-expected.checksum:
* platform/chromium-win/editing/inserting/insert-tab-002-expected.png:
* platform/chromium-win/editing/inserting/insert-tab-003-expected.checksum:
* platform/chromium-win/editing/inserting/insert-tab-003-expected.png:
* platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
* platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
* platform/chromium-win/editing/inserting/paragraph-separator-01-expected.checksum:
* platform/chromium-win/editing/inserting/paragraph-separator-01-expected.png:
* platform/chromium-win/editing/inserting/paragraph-separator-02-expected.checksum:
* platform/chromium-win/editing/inserting/paragraph-separator-02-expected.png:
* platform/chromium-win/editing/inserting/paragraph-separator-03-expected.checksum:
* platform/chromium-win/editing/inserting/paragraph-separator-03-expected.png:
* platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.checksum:
* platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.png:
* platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.checksum:
* platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.png:
* platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.checksum:
* platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.png:
* platform/chromium-win/editing/inserting/typing-002-expected.checksum:
* platform/chromium-win/editing/inserting/typing-002-expected.png:
* platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
* platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
* platform/chromium-win/editing/pasteboard/
4242293-expected.checksum:
* platform/chromium-win/editing/pasteboard/
4242293-expected.png:
* platform/chromium-win/editing/pasteboard/
4944770-1-expected.checksum:
* platform/chromium-win/editing/pasteboard/
4944770-1-expected.png:
* platform/chromium-win/editing/pasteboard/8145-2-expected.checksum:
* platform/chromium-win/editing/pasteboard/8145-2-expected.png:
* platform/chromium-win/editing/pasteboard/cut-text-001-expected.checksum:
* platform/chromium-win/editing/pasteboard/cut-text-001-expected.png:
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.checksum:
* platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png:
* platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.png:
* platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.png:
* platform/chromium-win/editing/pasteboard/merge-after-delete-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-after-delete-expected.png:
* platform/chromium-win/editing/pasteboard/merge-end-4-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-end-4-expected.png:
* platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
* platform/chromium-win/editing/pasteboard/merge-end-table-expected.checksum:
* platform/chromium-win/editing/pasteboard/merge-end-table-expected.png:
* platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.checksum:
* platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png:
* platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum:
* platform/chromium-win/editing/pasteboard/paste-text-001-expected.png:
* platform/chromium-win/editing/pasteboard/paste-text-012-expected.checksum:
* platform/chromium-win/editing/pasteboard/paste-text-012-expected.png:
* platform/chromium-win/editing/pasteboard/paste-text-013-expected.checksum:
* platform/chromium-win/editing/pasteboard/paste-text-013-expected.png:
* platform/chromium-win/editing/pasteboard/paste-text-014-expected.checksum:
* platform/chromium-win/editing/pasteboard/paste-text-014-expected.png:
* platform/chromium-win/editing/pasteboard/paste-text-019-expected.checksum:
* platform/chromium-win/editing/pasteboard/paste-text-019-expected.png:
* platform/chromium-win/editing/pasteboard/paste-xml-expected.checksum:
* platform/chromium-win/editing/pasteboard/paste-xml-expected.png:
* platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.checksum:
* platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-win/editing/selection/13804-expected.checksum:
* platform/chromium-win/editing/selection/13804-expected.png:
* platform/chromium-win/editing/selection/
5234383-1-expected.checksum:
* platform/chromium-win/editing/selection/
5234383-1-expected.png:
* platform/chromium-win/editing/selection/
5234383-2-expected.checksum:
* platform/chromium-win/editing/selection/
5234383-2-expected.png:
* platform/chromium-win/editing/selection/extend-by-word-001-expected.checksum:
* platform/chromium-win/editing/selection/extend-by-word-001-expected.png:
* platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
* platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
* platform/chromium-win/editing/selection/move-by-character-001-expected.checksum:
* platform/chromium-win/editing/selection/move-by-character-001-expected.png:
* platform/chromium-win/editing/selection/move-by-line-001-expected.checksum:
* platform/chromium-win/editing/selection/move-by-line-001-expected.png:
* platform/chromium-win/editing/selection/move-by-word-001-expected.checksum:
* platform/chromium-win/editing/selection/move-by-word-001-expected.png:
* platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.checksum:
* platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-win/editing/selection/unrendered-002-expected.checksum:
* platform/chromium-win/editing/selection/unrendered-002-expected.png:
* platform/chromium-win/editing/spelling/spelling-expected.checksum:
* platform/chromium-win/editing/spelling/spelling-expected.png:
* platform/chromium-win/editing/style/
5046875-2-expected.checksum:
* platform/chromium-win/editing/style/
5046875-2-expected.png:
* platform/chromium-win/editing/style/block-styles-007-expected.checksum:
* platform/chromium-win/editing/style/block-styles-007-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-002-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-002-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-003-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-003-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-004-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-004-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-006-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-008-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-008-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-009-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-009-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-011-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-012-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
* platform/chromium-win/editing/style/create-block-for-style-013-expected.checksum:
* platform/chromium-win/editing/style/create-block-for-style-013-expected.png:
* platform/chromium-win/fast/dom/blur-contenteditable-expected.checksum:
* platform/chromium-win/fast/dom/blur-contenteditable-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Sat, 1 Jan 2011 06:06:17 +0000 (06:06 +0000)]
2010-12-31 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
[DRT/Chromium] Enable mock spell checker on non-OSX
https://bugs.webkit.org/show_bug.cgi?id=51401
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::spellCheck):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 1 Jan 2011 02:38:25 +0000 (02:38 +0000)]
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
fast/loader/about-blank-hash-change.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=51788
I'm unable to reproduce the failure locally, so this patch is slightly
speculative. We need to be slighly more careful how we compare the
fragment identifiers for Chromium because Chromium uses a URL parser
that is more agressive about canonicalization.
* page/Location.cpp:
(WebCore::Location::setHash):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 1 Jan 2011 02:17:26 +0000 (02:17 +0000)]
2010-12-31 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Use GLib/GIO API for FileSystemGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=51617
Complete implementation of FileSystem platform code for GLib. This
converts remaining API points using POSIX calls to platform-independent
GLib calls and fixes other compilation errors.
No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.
(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):
* platform/FileSystem.h: Added forward declarations for GLib types to
avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
* platform/gtk/FileSystemGtk.cpp:
(WebCore::openTemporaryFile): Reimplement using only GLib calls.
(WebCore::openFile): Ditto.
(WebCore::closeFile): Ditto.
(WebCore::seekFile): Added implementation.
(WebCore::writeToFile): Reimplement using only GLib calls.
(WebCore::readFromFile): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sat, 1 Jan 2011 00:58:22 +0000 (00:58 +0000)]
2010-12-31 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784
* bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove): Call new overload of remove
for option elements instead of putting the logic in the binding.
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes.
(WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to
"event" instead of "evt". Also updated for name changes.
(WebCore::HTMLButtonElement::isActivatedSubmit): Ditto.
(WebCore::HTMLButtonElement::setActivatedSubmit): Ditto.
(WebCore::HTMLButtonElement::appendFormData): Ditto.
* html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit
to match the getter function name. The name still doesn't seem great.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes.
(WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function
instead of m_autocomplete data member.
(WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member
instead of otherwise-unused isDemoted function.
(WebCore::HTMLFormElement::submitImplicitly): Updated for name changes.
(WebCore::HTMLFormElement::validateInteractively): Removed code to clear
m_insubmit. This is now handled by the caller, prepareForSubmission.
(WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for
name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission
here from validateInteractively. Removed unneeded check of m_doingsubmit
boolean before setting it.
(WebCore::HTMLFormElement::submit): Factored this function into two.
One for JavaScript and one for non-JavaScript. Neither function needs a frame
argument, because the question being asked, anyPageIsProcessingUserGesture,
is a question asked of an entire page group, not a specific frame or page,
so it's not important which is the active frame.
(WebCore::HTMLFormElement::submitFromJavaScript): Ditto.
(WebCore::HTMLFormElement::reset): Updated for name changes.
(WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse
acceptAttr and got rid of code to set m_autocomplete.
(WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw
pointer.
(WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer
and the vector find function. Added a FIXME about the comment.
(WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete
function instead of m_autocomplete data member.
(WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto.
(WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
(WebCore::HTMLFormElement::autoComplete): Ditto.
* html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete
function. Renamed prepareSubmit to prepareForSubmission. Got rid of the
frame argument from the submit function and added a new submitFromJavaScript
variant. Removed the unneeded isDemoted function. Changed the return type
of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed
m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to
m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed,
m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
* html/HTMLFormElement.idl: Use the function named submitFromJavaScript
instead of using CallWith=DynamicFrame because we don't need to know
what frame is calling. If we did, it's not clear that the "dynamic"
frame would be the right one anyway.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::remove): Added an overload that takes an option
element, since the JavaScript binding supports this.
* html/HTMLSelectElement.h: Ditto.
* html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
* html/ImageInputType.h: Ditto.
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 1 Jan 2011 00:48:20 +0000 (00:48 +0000)]
The correct temporary fix for media/video-element-other-namespace-crash.html timing out on
the Windows 7 Release Test bots is to add it to the Windows skipped list.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787
* platform/win/Skipped:
* platform/win/media/video-element-other-namespace-crash-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 1 Jan 2011 00:36:20 +0000 (00:36 +0000)]
2010-12-31 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Pass style for <area> instead of associated <img> when querying whether
the theme draws the focus ring for an <area>
https://bugs.webkit.org/show_bug.cgi?id=51632
Fixes an issue where the style for the associated <img> of an <area>
was passed when considering whether the theme should draw a focus ring
for the <area>. Instead, we should pass the theme the style for the <area>.
It's not possible to test this at this time since there are no themes
that override focus ring drawing for <area>s.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing()
such that it's called with respect to the focused <area>.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 22:46:46 +0000 (22:46 +0000)]
2010-12-31 Adam Barth <abarth@webkit.org>
Update SVN ignore property to hide two more external dependencies.
* chromium: Modified property svn:ignore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 31 Dec 2010 22:10:42 +0000 (22:10 +0000)]
Add Windows-specific (failing) expected results for
media/video-element-other-namespace-crash.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787
* platform/win/media/video-element-other-namespace-crash-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 31 Dec 2010 21:45:51 +0000 (21:45 +0000)]
Add Windows-specific (failing) expected results for
svg/dom/length-list-parser.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51786
* platform/win/svg/dom: Added.
* platform/win/svg/dom/length-list-parser-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 20:36:41 +0000 (20:36 +0000)]
2010-12-31 Adam Barth <abarth@webkit.org>
Remove custom Chromium expectation for invalid-protocol. Now that we
share more code with JavaScriptCore, we throw exactly the same
exception and therefore can share results.
* platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 31 Dec 2010 20:12:13 +0000 (20:12 +0000)]
* WebCore.xcodeproj/project.pbxproj: Added back the language.
Developers should be using Xcode 3.2.5 or newer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 19:56:29 +0000 (19:56 +0000)]
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move V8 to WebCore Location implementation
https://bugs.webkit.org/show_bug.cgi?id=51768
* bindings/generic/BindingFrame.h:
* bindings/generic/BindingLocation.h:
* bindings/v8/V8Binding.h:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setLocation):
* bindings/v8/V8Utilities.cpp:
* bindings/v8/V8Utilities.h:
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::hashAccessorSetter):
(WebCore::V8Location::hostAccessorSetter):
(WebCore::V8Location::hostnameAccessorSetter):
(WebCore::V8Location::hrefAccessorSetter):
(WebCore::V8Location::pathnameAccessorSetter):
(WebCore::V8Location::portAccessorSetter):
(WebCore::V8Location::protocolAccessorSetter):
(WebCore::V8Location::searchAccessorSetter):
(WebCore::V8Location::reloadCallback):
(WebCore::V8Location::replaceCallback):
(WebCore::V8Location::assignCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 31 Dec 2010 17:58:35 +0000 (17:58 +0000)]
2010-12-31 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
Make retrieving extraMediaControlsStyleSheet be page dependent.
https://bugs.webkit.org/show_bug.cgi?id=51752
Use themeForPage to retrieve extraMediaControlsStyleSheet for media
controls.
No new tests because no platform-specific theme implementation uses
the passed page pointer yet.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 16:11:05 +0000 (16:11 +0000)]
2010-12-31 Adam Barth <abarth@webkit.org>
Reviewed by Ariya Hidayat.
Remove Tools/Scripts/wkstyle
https://bugs.webkit.org/show_bug.cgi?id=51774
This script appears to not have been touched in a while and seems to
have been replaced by check-webkit-style.
* Scripts/wkstyle: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 31 Dec 2010 13:02:17 +0000 (13:02 +0000)]
2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.
https://bugs.webkit.org/show_bug.cgi?id=51709
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.canShowSourceLine):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 31 Dec 2010 12:43:34 +0000 (12:43 +0000)]
2010-12-31 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal
https://bugs.webkit.org/show_bug.cgi?id=50517
This change shows about 2% performance win on the xml-parser benchmark.
* wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::equal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 31 Dec 2010 11:59:08 +0000 (11:59 +0000)]
2010-12-31 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix after r74800.
* bindings/js/JSDOMWindowCustom.cpp: Add missing header.
* bindings/js/JSLocationCustom.cpp: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 31 Dec 2010 11:47:45 +0000 (11:47 +0000)]
2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Coding style fix.
* DumpRenderTree/chromium/TestShell.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 31 Dec 2010 11:41:52 +0000 (11:41 +0000)]
2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
It was a problem with Chromium DRT. DevToolsAgent object instance was
attached not only to the inspected page but to the DevTools window too.
As result all the inspector files were interpreted as a content of inspected page
and were transfered to the DevTools scripts panel for debugging etc.
https://bugs.webkit.org/show_bug.cgi?id=51735
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::bindJSObjectsToWindow):
(TestShell::createNewWindow):
* DumpRenderTree/chromium/TestShell.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 10:16:07 +0000 (10:16 +0000)]
Move HTML and XML parser benchmarks into PerformanceTests/Parser
https://bugs.webkit.org/show_bug.cgi?id=51772
Rubber-stamped by Eric Seidel.
Actually move the directory.
* PerformanceTests/Parser: Copied from WebCore/benchmarks/parser.
PerformanceTests/Parser:
Add a ChangeLog for tracking changes to the Parser PerformanceTest.
* ChangeLog: Added.
WebCore:
Remove the benchmarks folder now that it's empty. Future benchmarks
should go in the PerformanceTests directory.
* benchmarks: Removed.
* benchmarks/parser: Removed.
* benchmarks/parser/html-parser.html: Removed.
* benchmarks/parser/resources: Removed.
* benchmarks/parser/resources/html5.html: Removed.
* benchmarks/parser/resources/runner.js: Removed.
* benchmarks/parser/xml-parser.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 10:01:49 +0000 (10:01 +0000)]
2010-12-31 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612
Move the JavaScript code of html parser into a separate file to share it with xml parser.
* benchmarks/parser/html-parser.html:
* benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html.
(runFunction):
(run):
(start):
* benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 09:51:18 +0000 (09:51 +0000)]
Move PageLoadTests to PerformanceTests/PageLoad
https://bugs.webkit.org/show_bug.cgi?id=51771
Rubber-stamped by Eric Seidel.
Actually move the directory.
* PageLoadTests: Removed.
* PageLoadTests/svg: Removed.
* PageLoadTests/svg/LICENSES: Removed.
* PageLoadTests/svg/files: Removed.
* PageLoadTests/svg/files/33041-Samurai.svg: Removed.
* PageLoadTests/svg/files/42450-under the see.svg: Removed.
* PageLoadTests/svg/files/42470-flower_from_my_garden_v2.svg: Removed.
* PageLoadTests/svg/files/44057-drops on a blade.svg: Removed.
* PageLoadTests/svg/files/Harvey_Rayner.svg: Removed.
* PageLoadTests/svg/files/az-lizard_benji_park_01.svg: Removed.
* PageLoadTests/svg/files/bamboo_01.svg: Removed.
* PageLoadTests/svg/files/cacuts_01.svg: Removed.
* PageLoadTests/svg/files/cowboy.svg: Removed.
* PageLoadTests/svg/files/crawfish2_ganson.svg: Removed.
* PageLoadTests/svg/files/deb9frac1.svg: Removed.
* PageLoadTests/svg/files/food_leif_lodahl_01.svg: Removed.
* PageLoadTests/svg/files/france.svg: Removed.
* PageLoadTests/svg/files/francobollo_gnome_ezechi_02.svg: Removed.
* PageLoadTests/svg/files/gearflowers.svg: Removed.
* PageLoadTests/svg/files/hereGear4.svg: Removed.
* PageLoadTests/svg/files/mtsthelens.svg: Removed.
* PageLoadTests/svg/files/mtsthelens0.jpg: Removed.
* PageLoadTests/svg/files/world-iso.svg: Removed.
* PageLoadTests/svg/files/worldcup.svg: Removed.
* PageLoadTests/svg/svg.pltsuite: Removed.
* PerformanceTests/PageLoad: Copied from PageLoadTests.
* Sources/cmake/WebKitPackaging.cmake:
PerformanceTests/PageLoad:
Update URLs to point to the new directory name.
* svg/svg.pltsuite:
Tools:
Update references to PageLoadTests to point to the new location.
* Scripts/run-pageloadtest:
* Scripts/webkitpy/common/config/build.py:
Websites/bugs.webkit.org:
Update list of top-level open-source directories.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 31 Dec 2010 09:28:03 +0000 (09:28 +0000)]
Move SunSpider into PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=51769
Rubber-stamped by Eric Seidel.
Actually move the directory.
* PerformanceTests: Added.
* PerformanceTests/SunSpider: Copied from SunSpider.
* Sources/cmake/WebKitPackaging.cmake:
* SunSpider: Removed.
* SunSpider/SunSpider.make: Removed.
* SunSpider/TODO: Removed.
* SunSpider/UNCOVERED: Removed.
* SunSpider/hosted: Removed.
* SunSpider/hosted/json2.js: Removed.
* SunSpider/hosted/sunspider.css: Removed.
* SunSpider/hosted/sunspider.html: Removed.
* SunSpider/hosted/versions.html: Removed.
* SunSpider/make-hosted: Removed.
* SunSpider/resources: Removed.
* SunSpider/resources/TEMPLATE.html: Removed.
* SunSpider/resources/driver-TEMPLATE.html: Removed.
* SunSpider/resources/results-TEMPLATE.html: Removed.
* SunSpider/resources/sunspider-analyze-results.js: Removed.
* SunSpider/resources/sunspider-compare-results.js: Removed.
* SunSpider/resources/sunspider-standalone-compare.js: Removed.
* SunSpider/resources/sunspider-standalone-driver.js: Removed.
* SunSpider/sunspider: Removed.
* SunSpider/sunspider-compare-results: Removed.
* SunSpider/tests: Removed.
* SunSpider/tests/parse-only: Removed.
* SunSpider/tests/parse-only/LIST: Removed.
* SunSpider/tests/parse-only/concat-jquery-mootools-prototype.js: Removed.
* SunSpider/tests/parse-only/jquery-1.3.2.js: Removed.
* SunSpider/tests/parse-only/mootools-1.2.2-core-nc.js: Removed.
* SunSpider/tests/parse-only/prototype-1.6.0.3.js: Removed.
* SunSpider/tests/sunspider-0.9: Removed.
* SunSpider/tests/sunspider-0.9.1: Removed.
* SunSpider/tests/sunspider-0.9.1/3d-cube.js: Removed.
* SunSpider/tests/sunspider-0.9.1/3d-morph.js: Removed.
* SunSpider/tests/sunspider-0.9.1/3d-raytrace.js: Removed.
* SunSpider/tests/sunspider-0.9.1/LIST: Removed.
* SunSpider/tests/sunspider-0.9.1/access-binary-trees.js: Removed.
* SunSpider/tests/sunspider-0.9.1/access-fannkuch.js: Removed.
* SunSpider/tests/sunspider-0.9.1/access-nbody.js: Removed.
* SunSpider/tests/sunspider-0.9.1/access-nsieve.js: Removed.
* SunSpider/tests/sunspider-0.9.1/bitops-3bit-bits-in-byte.js: Removed.
* SunSpider/tests/sunspider-0.9.1/bitops-bits-in-byte.js: Removed.
* SunSpider/tests/sunspider-0.9.1/bitops-bitwise-and.js: Removed.
* SunSpider/tests/sunspider-0.9.1/bitops-nsieve-bits.js: Removed.
* SunSpider/tests/sunspider-0.9.1/controlflow-recursive.js: Removed.
* SunSpider/tests/sunspider-0.9.1/crypto-aes.js: Removed.
* SunSpider/tests/sunspider-0.9.1/crypto-md5.js: Removed.
* SunSpider/tests/sunspider-0.9.1/crypto-sha1.js: Removed.
* SunSpider/tests/sunspider-0.9.1/date-format-tofte.js: Removed.
* SunSpider/tests/sunspider-0.9.1/date-format-xparb.js: Removed.
* SunSpider/tests/sunspider-0.9.1/math-cordic.js: Removed.
* SunSpider/tests/sunspider-0.9.1/math-partial-sums.js: Removed.
* SunSpider/tests/sunspider-0.9.1/math-spectral-norm.js: Removed.
* SunSpider/tests/sunspider-0.9.1/regexp-dna.js: Removed.
* SunSpider/tests/sunspider-0.9.1/string-base64.js: Removed.
* SunSpider/tests/sunspider-0.9.1/string-fasta.js: Removed.
* SunSpider/tests/sunspider-0.9.1/string-tagcloud.js: Removed.
* SunSpider/tests/sunspider-0.9.1/string-unpack-code.js: Removed.
* SunSpider/tests/sunspider-0.9.1/string-validate-input.js: Removed.
* SunSpider/tests/sunspider-0.9/3d-cube.js: Removed.
* SunSpider/tests/sunspider-0.9/3d-morph.js: Removed.
* SunSpider/tests/sunspider-0.9/3d-raytrace.js: Removed.
* SunSpider/tests/sunspider-0.9/LIST: Removed.
* SunSpider/tests/sunspider-0.9/access-binary-trees.js: Removed.
* SunSpider/tests/sunspider-0.9/access-fannkuch.js: Removed.
* SunSpider/tests/sunspider-0.9/access-nbody.js: Removed.
* SunSpider/tests/sunspider-0.9/access-nsieve.js: Removed.
* SunSpider/tests/sunspider-0.9/bitops-3bit-bits-in-byte.js: Removed.
* SunSpider/tests/sunspider-0.9/bitops-bits-in-byte.js: Removed.
* SunSpider/tests/sunspider-0.9/bitops-bitwise-and.js: Removed.
* SunSpider/tests/sunspider-0.9/bitops-nsieve-bits.js: Removed.
* SunSpider/tests/sunspider-0.9/controlflow-recursive.js: Removed.
* SunSpider/tests/sunspider-0.9/crypto-aes.js: Removed.
* SunSpider/tests/sunspider-0.9/crypto-md5.js: Removed.
* SunSpider/tests/sunspider-0.9/crypto-sha1.js: Removed.
* SunSpider/tests/sunspider-0.9/date-format-tofte.js: Removed.
* SunSpider/tests/sunspider-0.9/date-format-xparb.js: Removed.
* SunSpider/tests/sunspider-0.9/math-cordic.js: Removed.
* SunSpider/tests/sunspider-0.9/math-partial-sums.js: Removed.
* SunSpider/tests/sunspider-0.9/math-spectral-norm.js: Removed.
* SunSpider/tests/sunspider-0.9/regexp-dna.js: Removed.
* SunSpider/tests/sunspider-0.9/string-base64.js: Removed.
* SunSpider/tests/sunspider-0.9/string-fasta.js: Removed.
* SunSpider/tests/sunspider-0.9/string-tagcloud.js: Removed.
* SunSpider/tests/sunspider-0.9/string-unpack-code.js: Removed.
* SunSpider/tests/sunspider-0.9/string-validate-input.js: Removed.
* SunSpider/tests/ubench: Removed.
* SunSpider/tests/ubench/LIST: Removed.
* SunSpider/tests/ubench/function-closure.js: Removed.
* SunSpider/tests/ubench/function-correct-args.js: Removed.
* SunSpider/tests/ubench/function-empty.js: Removed.
* SunSpider/tests/ubench/function-excess-args.js: Removed.
* SunSpider/tests/ubench/function-missing-args.js: Removed.
* SunSpider/tests/ubench/function-sum.js: Removed.
* SunSpider/tests/ubench/loop-empty-resolve.js: Removed.
* SunSpider/tests/ubench/loop-empty.js: Removed.
* SunSpider/tests/ubench/loop-sum.js: Removed.
* SunSpider/tests/v8-v4: Removed.
* SunSpider/tests/v8-v4/LIST: Removed.
* SunSpider/tests/v8-v4/v8-crypto.js: Removed.
* SunSpider/tests/v8-v4/v8-deltablue.js: Removed.
* SunSpider/tests/v8-v4/v8-earley-boyer.js: Removed.
* SunSpider/tests/v8-v4/v8-raytrace.js: Removed.
* SunSpider/tests/v8-v4/v8-regexp.js: Removed.
* SunSpider/tests/v8-v4/v8-richards.js: Removed.
* SunSpider/tests/v8-v4/v8-splay.js: Removed.
* SunSpider/tests/v8-v5: Removed.
* SunSpider/tests/v8-v5/LIST: Removed.
* SunSpider/tests/v8-v5/v8-crypto.js: Removed.
* SunSpider/tests/v8-v5/v8-deltablue.js: Removed.
* SunSpider/tests/v8-v5/v8-earley-boyer.js: Removed.
* SunSpider/tests/v8-v5/v8-raytrace.js: Removed.
* SunSpider/tests/v8-v5/v8-regexp.js: Removed.
* SunSpider/tests/v8-v5/v8-richards.js: Removed.
* SunSpider/tests/v8-v5/v8-splay.js: Removed.
* SunSpider/tests/v8-v6: Removed.
* SunSpider/tests/v8-v6/LIST: Removed.
* SunSpider/tests/v8-v6/v8-crypto.js: Removed.
* SunSpider/tests/v8-v6/v8-deltablue.js: Removed.
* SunSpider/tests/v8-v6/v8-earley-boyer.js: Removed.
* SunSpider/tests/v8-v6/v8-raytrace.js: Removed.
* SunSpider/tests/v8-v6/v8-regexp.js: Removed.
* SunSpider/tests/v8-v6/v8-richards.js: Removed.
* SunSpider/tests/v8-v6/v8-splay.js: Removed.
* SunSpider/xcopy.excludes: Removed.
Tools:
Update these scripts to point to the new location.
* Scripts/run-sunspider:
* Scripts/sunspider-compare-results:
Websites/bugs.webkit.org:
Update list of top-level open-source directories.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 31 Dec 2010 04:02:37 +0000 (04:02 +0000)]
2010-12-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728
Add implementation of the Mac WebThemeEngine that uses an NSScroller
to render top-level scrollbars. This makes them match the Mac port's
use of an NSScrollView, which means that we'll be able to share more
pixel baselines.
The new rendering code will not be activated until the
USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
ScrollbarThemeChromiumMac.
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
* DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
* DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2010-12-30 Mihai Parparita <mihaip@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728
Roll DEPS to pick up WebThemeEngine changes.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Fri, 31 Dec 2010 02:44:58 +0000 (02:44 +0000)]
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716
* fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
* fast/canvas/webgl/webgl-specific.html: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 31 Dec 2010 01:53:05 +0000 (01:53 +0000)]
2010-12-30 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Skipping media/video-element-other-namespace-crash.html for chromium
since it uses codecs that chromium does not support.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Fri, 31 Dec 2010 01:30:03 +0000 (01:30 +0000)]
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings.
(WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings.
(WebCore::WebGLRenderingContext::drawElements): Ditto.
(WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error.
(WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto.
(WebCore::WebGLRenderingContext::stencilMask): Ditto.
(WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto.
(WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
* html/canvas/WebGLRenderingContext.h: Declare stencil setting members.
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716
* fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
* fast/canvas/webgl/webgl-specific.html: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 31 Dec 2010 01:03:56 +0000 (01:03 +0000)]
2010-12-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51755
Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
step to landing support for the new GTK+ 3.x theming API.
No new tests. This should not change functionality.
* GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method.
(WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
(WebCore::RenderThemeGtk::paintMediaButton): Ditto.
(WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
* platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that
it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
* platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk
that will eventually be platform-dependent.
* platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 31 Dec 2010 00:50:59 +0000 (00:50 +0000)]
2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Reverting r74292 because it introduced a crash with ruby text.
https://bugs.webkit.org/show_bug.cgi?id=51637
Test: fast/css/counters/counter-ruby-text-cleared.html
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Check for crash when deleting ruby text with counters.
https://bugs.webkit.org/show_bug.cgi?id=51637
* fast/css/counters/counter-ruby-text-cleared-expected.txt: Added.
* fast/css/counters/counter-ruby-text-cleared.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 31 Dec 2010 00:39:13 +0000 (00:39 +0000)]
2010-12-30 Patrick Gansterer <paroga@webkit.org>
Reviewed by Ariya Hidayat.
[CMake] Add WTF_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=51741
Add the WTF headers to show them in Visual Studio.
* wtf/CMakeLists.txt:
* wtf/CMakeListsWinCE.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 31 Dec 2010 00:24:09 +0000 (00:24 +0000)]
2010-12-30 Darin Adler <darin@apple.com>
Reviewed by David Kilzer.
Remove unused JSBinding source files
https://bugs.webkit.org/show_bug.cgi?id=51762
* bindings/js/JSBinding.h: Removed.
* bindings/js/specialization: Removed.
* bindings/js/specialization/JSBindingState.cpp: Removed.
* bindings/js/specialization/JSBindingState.h: Removed.
* CMakeLists.txt: Removed references to files.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Dec 2010 23:47:48 +0000 (23:47 +0000)]
2010-12-30 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by David Kilzer.
[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672
* WebKit.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
2010-12-30 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by David Kilzer.
[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672
* wtf/wtf.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
2010-12-30 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by David Kilzer.
[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672
* DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
with USE_SYSTEM_MALLOC=1
* WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
with USE_SYSTEM_MALLOC=1
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 30 Dec 2010 23:41:56 +0000 (23:41 +0000)]
2010-12-30 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Adler.
Remove Document.h include from some headers where it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=51730
No new tests because no new functionality.
* editing/EditingStyle.cpp:
* editing/EditingStyle.h:
* editing/SelectionController.h:
* editing/visible_units.h:
* html/HTMLAudioElement.h:
* html/HTMLBodyElement.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.h:
* xml/DOMParser.cpp:
* xml/DOMParser.h:
(WebCore::DOMParser::create):
(WebCore::DOMParser::DOMParser):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Thu, 30 Dec 2010 23:30:31 +0000 (23:30 +0000)]
2010-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by David Kilzer.
[Qt] [Symbian] Fix build-webkit script for Symbian
https://bugs.webkit.org/show_bug.cgi?id=51509
Set the OUTPUT_DIR for Symbian to be the same as the source
directory.
* Scripts/webkitdirs.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 30 Dec 2010 21:55:51 +0000 (21:55 +0000)]
2010-12-30 Benjamin C Meyer <bmeyer@rim.com>
Reviewed by Darin Adler.
bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
which is required when NOTIFICATIONS is enabled.
https://bugs.webkit.org/show_bug.cgi?id=51761
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 30 Dec 2010 21:46:09 +0000 (21:46 +0000)]
2010-12-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Darin Adler.
check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
https://bugs.webkit.org/show_bug.cgi?id=51758
Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
* Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 30 Dec 2010 20:59:47 +0000 (20:59 +0000)]
Not reviewed.
Revert accidental project file change.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 30 Dec 2010 20:57:02 +0000 (20:57 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51134
Move loading related code from MemoryCache to CachedResourceLoader
Reviewed by Darin Adler.
- Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
- Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
- Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
- Add MemoryCache::add
- Refactor the decision on whether to reload, revalidate or use the existing resource to
a single function, CachedResourceLoader::determineRevalidationPolicy
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
if ever taken (since it passes null CachedResourceLoader pointer).
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
* loader/cache/CachedImage.cpp:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
(WebCore::CachedResource::setLoadPriority):
Check for Unresolved value before setting.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::setOwningCachedResourceLoader):
Rename to be bit less mysterious.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
This was moved from MemoryCache.
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
This was moved/merged from MemoryCache.
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
This combines MemoryCache::requestResource and the existing method.
(WebCore::CachedResourceLoader::revalidateResource):
This was moved from MemoryCache.
(WebCore::CachedResourceLoader::loadResource):
New method for initiating loading.
(WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
* loader/cache/CachedResourceLoader.h:
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::add):
* loader/cache/MemoryCache.h:
(WebCore::MemoryCache::remove):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Thu, 30 Dec 2010 20:53:31 +0000 (20:53 +0000)]
2010-12-30 Steve Block <steveblock@google.com>
Reviewed by Gavin Barraclough.
Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
https://bugs.webkit.org/show_bug.cgi?id=51740
This is a policy decision for Android.
No new tests, simply enabling existing, tested code on Android.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 20:29:55 +0000 (20:29 +0000)]
2010-12-30 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium baseline update.
[Chromium] svg/dom/length-list-parser.html fails on Chromium Linux after r74788 and r74803
https://bugs.webkit.org/show_bug.cgi?id=51759
r74803 added chromium-win baselines for svg/dom/length-list-parser.html
but chromium-linux shouldn't use them (despite having them in its
fallback path). Copy the base expectations into chromium-linux.
* platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 20:21:31 +0000 (20:21 +0000)]
2010-12-30 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Mark a few inspector tests as slow, they occasionally time out with
debug builds.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 30 Dec 2010 19:40:12 +0000 (19:40 +0000)]
2010-12-30 Justin Schuh <jschuh@chromium.org>
Unreviewed.
chromium test expectations after r74788 for svg/dom/length-list-parser.html
* platform/chromium-win/svg/dom/length-list-parser-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 30 Dec 2010 19:34:03 +0000 (19:34 +0000)]
2010-12-30 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Use OS(WINDOWS) instead of COMPILER(MSVC) in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=51743
Most of the ifdefs belong to windows and not to the MSVC compiler.
* wtf/FastMalloc.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Thu, 30 Dec 2010 19:31:00 +0000 (19:31 +0000)]
REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342
Reviewed by Adam Barth.
WebCore:
Do not reload the page when submitting a form, using "GET" method, and the
form action url matches the location url, except for the fragment.
Test: fast/forms/submit-change-fragment.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldScrollToAnchor):
* loader/FrameLoader.h:
LayoutTests:
* fast/forms/submit-change-fragment-expected.txt: Added.
* fast/forms/submit-change-fragment.html: Added.
* platform/mac/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 30 Dec 2010 19:27:28 +0000 (19:27 +0000)]
2010-12-30 Darin Adler <darin@apple.com>
Reviewed by Adam Barth.
Move security logic out of the JavaScript binding for location into the DOM class
https://bugs.webkit.org/show_bug.cgi?id=51714
* WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
and JSBinding.h. Later, we'll remove them from other project files and delete
the source files.
* bindings/js/JSBinding.h: Emptied out, marked for later deletion.
* bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
function, unused toLexicalFrame function, unused completeURL function, unused
getCachedDOMStructure and cacheDOMStructure overloads, and unused
getCachedDOMConstructor and cacheDOMConstruction functions.
(WebCore::activeDOMWindow): Added.
(WebCore::firstDOMWindow): Added.
(WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
JSBindingState, since the latter is an unneeded abstraction.
(WebCore::processingUserGesture): Changed to call ScriptController's function
rather than calling through JSBindingState, which is an unneeded abstraction
* bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
named allowsAccessFromFrame functions, which answer the question of whether
script is allowed access *to* a frame.
* bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
(WebCore::JSDOMWindow::setLocation): Streamlined by using the new
activeDOMWindow and firstDOMWindow functions.
(WebCore::JSDOMWindow::open): Ditto.
(WebCore::JSDOMWindow::showModalDialog): Ditto.
(WebCore::JSDOMWindow::postMessage): Ditto.
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setHref): Changed to pass the active and first windows through
to the Location::setHref function, with it doing the rest of the work. This moves
work out of the DOM binding that belongs in the DOM itself. Eventually such functions
could even be automatically generated by the bindings script.
(WebCore::JSLocation::setProtocol): Ditto.
(WebCore::JSLocation::setHost): Ditto.
(WebCore::JSLocation::setHostname): Ditto.
(WebCore::JSLocation::setPort): Ditto.
(WebCore::JSLocation::setPathname): Ditto.
(WebCore::JSLocation::setSearch): Ditto.
(WebCore::JSLocation::setHash): Ditto.
(WebCore::JSLocation::replace): Ditto.
(WebCore::JSLocation::reload): Ditto.
(WebCore::JSLocation::assign): Ditto.
* bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
* bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
to use this function for Location::replace, which is the same as setLocation except that
it locks both history and the back/forward list.
* page/DOMWindow.h: Ditto.
* page/Location.cpp:
(WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
logic there does not have to be repeated or even refactored.
(WebCore::Location::setProtocol): Ditto.
(WebCore::Location::setHost): Ditto.
(WebCore::Location::setHostname): Ditto.
(WebCore::Location::setPort): Ditto.
(WebCore::Location::setPathname): Ditto.
(WebCore::Location::setSearch): Ditto.
(WebCore::Location::setHash): Ditto.
(WebCore::Location::assign): Ditto.
(WebCore::Location::replace): Ditto.
(WebCore::Location::reload): Added. Security logic was refactored from the code in
JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
possibly unneeded.
* page/Location.h: Fixed indentation on the whole file. Added the new functions above.
(WebCore::Location::create):
(WebCore::Location::frame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 30 Dec 2010 17:26:30 +0000 (17:26 +0000)]
2010-12-30 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Pasting a style property with value should automatically split it into prop/value
https://bugs.webkit.org/show_bug.cgi?id=51581
The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
and the edit focus is transferred to the value field.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/inspector.js:
(WebInspector.completeURL): Drive-by: return full URLs as-is.
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing):
(WebInspector.startEditing.pasteEventListener):
(WebInspector.startEditing.keyDownEventListener):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 30 Dec 2010 15:32:58 +0000 (15:32 +0000)]
2010-12-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
https://bugs.webkit.org/show_bug.cgi?id=51745
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint.prototype.set enabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 30 Dec 2010 15:28:57 +0000 (15:28 +0000)]
2010-12-30 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
https://bugs.webkit.org/show_bug.cgi?id=51748
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
(WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
(WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 30 Dec 2010 13:11:02 +0000 (13:11 +0000)]
2010-12-30 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskip the test, it's running fine locally.
media/audio-delete-while-slider-thumb-clicked.html fails
https://bugs.webkit.org/show_bug.cgi?id=37546
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 30 Dec 2010 13:04:56 +0000 (13:04 +0000)]
2010-12-30 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).
https://bugs.webkit.org/show_bug.cgi?id=51713
* WebCore.gypi:
* WebCore.pro:
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::memoryAccessorGetter):
* bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp.
(WebCore::V8Performance::memoryAccessorGetter):
* page/Console.idl:
* page/Performance.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Thu, 30 Dec 2010 11:32:15 +0000 (11:32 +0000)]
2010-12-30 Steve Block <steveblock@google.com>
Reviewed by Sam Weinig.
Visiting macnn.com often causes SQL spew via geolocation database
https://bugs.webkit.org/show_bug.cgi?id=51557
If the Geolocation position cache database path has not been set, early-out
rather than using an empty path and thus failing to open the database.
This avoids SQL log spew.
Also, avoid starting the database thread until the path has been set, and
shorten the thread name to avoid warnings due to exceeding 30 characters.
No new tests, implementation clean-up only.
* page/GeolocationPositionCache.cpp:
(WebCore::GeolocationPositionCache::addUser):
(WebCore::GeolocationPositionCache::removeUser):
(WebCore::GeolocationPositionCache::setDatabasePath):
(WebCore::GeolocationPositionCache::startBackgroundThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 30 Dec 2010 11:02:58 +0000 (11:02 +0000)]
2010-12-30 Philippe Normand <pnormand@igalia.com>
Unreviewed, skipping another editing flacky test.
* platform/gtk/Skipped: skip editing/selection/extend-by-character-005.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 30 Dec 2010 10:17:07 +0000 (10:17 +0000)]
2010-12-29 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327
* configure.ac: Error out if SQLite3 wasn't found while at least
one of the features depending on it has been enabled.
WebCore:
Reviewed by Martin Robinson.
[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327
Guard the code calling sqlite3 with the ENABLE(DATABASE) check.
No new tests, build fix only.
* platform/sql/SQLiteAuthorizer.cpp:
* platform/sql/SQLiteDatabase.cpp:
* platform/sql/SQLiteFileSystem.cpp:
* platform/sql/SQLiteStatement.cpp:
* platform/sql/SQLiteTransaction.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Thu, 30 Dec 2010 09:29:34 +0000 (09:29 +0000)]
2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>
Chromium test expectation update for svg/dom/length-list-parser.html
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Thu, 30 Dec 2010 09:25:40 +0000 (09:25 +0000)]
2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>
Chromium test expectation update for media/video-element-other-namespace-crash.html
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 30 Dec 2010 08:29:04 +0000 (08:29 +0000)]
2010-12-30 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Skip media/video-element-other-namespace-crash.html, like other media tests on qt platform.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 30 Dec 2010 08:12:40 +0000 (08:12 +0000)]
2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
https://bugs.webkit.org/show_bug.cgi?id=51692
* svg/SVGLength.cpp:
(WebCore::stringToLengthType):
(WebCore::SVGLength::setValueAsString):
2010-12-30 Justin Schuh <jschuh@chromium.org>
Reviewed by Dirk Schulze.
Adding long float string to improve test coverage.
https://bugs.webkit.org/show_bug.cgi?id=51692
* svg/dom/length-list-parser.html:
* svg/dom/length-list-parser-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 30 Dec 2010 08:02:08 +0000 (08:02 +0000)]
2010-12-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
Create a helper function for finding descendent video elements for a node.
https://bugs.webkit.org/show_bug.cgi?id=51696
Test: media/video-element-other-namespace-crash.html
* html/MediaDocument.cpp:
(WebCore::descendentVideoElement): helper function.
(WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions.
(WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.
2010-12-30 Abhishek Arya <inferno@chromium.org>
Reviewed by Eric Seidel.
Tests that we do not crash when trying to find video elements in the media document.
https://bugs.webkit.org/show_bug.cgi?id=51696
* media/video-element-other-namespace-crash-expected.txt: Added.
* media/video-element-other-namespace-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 30 Dec 2010 07:55:26 +0000 (07:55 +0000)]
2010-12-29 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Add 'PASS' to layout test since test failing on chromium due to empty expectations.
Filed webkit bug 51734 to track gtk test failure and skipping test for now.
* fast/multicol/span/double-merge-anonymous-block-crash-expected.txt:
* fast/multicol/span/double-merge-anonymous-block-crash.html:
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 30 Dec 2010 07:41:53 +0000 (07:41 +0000)]
2010-12-29 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=51707
This change brushes up storage agents + removes redundant InspectorBackend class.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::databaseForId):
(WebCore::InjectedScriptHost::selectDatabase):
(WebCore::InjectedScriptHost::selectDOMStorage):
(WebCore::InjectedScriptHost::inspectorDOMAgent):
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp: Removed.
* inspector/InspectorBackend.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::~InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::releaseFrontendLifetimeAgents):
(WebCore::InspectorController::didUseDOMStorage):
(WebCore::InspectorController::setInjectedScriptSource):
(WebCore::InspectorController::dispatchOnInjectedScript):
(WebCore::InspectorController::releaseWrapperObjectGroup):
* inspector/InspectorController.h:
* inspector/InspectorDOMStorageAgent.cpp: Added.
(WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::selectDOMStorage):
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
* inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
(WebCore::InspectorDOMStorageAgent::create):
(WebCore::InspectorDOMStorageAgent::frontend):
* inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
(WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::databaseForId):
(WebCore::InspectorDatabaseAgent::selectDatabase):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
* inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
(WebCore::InspectorDatabaseAgent::create):
(WebCore::InspectorDatabaseAgent::frontend):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
(WebInspector.ScriptsPanel.prototype._toggleDebugging):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 30 Dec 2010 07:20:22 +0000 (07:20 +0000)]
2010-12-29 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE buildfix.
* WinCELauncher/main.cpp: Add missing include.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Thu, 30 Dec 2010 07:00:46 +0000 (07:00 +0000)]
2010-12-29 Dirk Schulze <krit@webkit.org>
Unreviewed fix of the misspelled email address in commit 74782.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Thu, 30 Dec 2010 06:49:44 +0000 (06:49 +0000)]
2010-12-29 Dirk Schulze <krit@wbekit.org>
Reviewed by Darin Adler.
Cleanup SVG code according to the webkit style rules 3
https://bugs.webkit.org/show_bug.cgi?id=51490
Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
Just one file can't be fixed for check-webkit-style.
* SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning
No changes of functionality, so no new tests.
* svg/SVGAllInOne.cpp:
* svg/SVGImage.cpp:
* svg/SVGLength.cpp:
(WebCore::SVGLength::setValue):
* svg/SVGPolygonElement.h:
* svg/SVGPolylineElement.h:
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
(WebCore::SVGPreserveAspectRatio::transformRect):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::viewport):
* svg/SVGSetElement.h:
* svg/SVGStylable.h:
(WebCore::SVGStylable::~SVGStylable):
* svg/SVGStyledLocatableElement.h:
(WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform):
(WebCore::SVGStyledLocatableElement::isStyledLocatable):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isKnownAttribute):
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
* svg/SVGTests.cpp:
(WebCore::SVGTests::parseMappedAttribute):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isKnownAttribute):
* svg/SVGTextPathElement.cpp:
* svg/SVGTextPathElement.h:
* svg/SVGTitleElement.h:
(WebCore::SVGTitleElement::rendererIsNeeded):
* svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addSVGTransform):
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::isZero):
* svg/SVGTransformList.cpp:
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::getTarget):
* svg/SVGVKernElement.h:
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
* svg/SVGZoomAndPan.h:
(WebCore::SVGZoomAndPan::SVGZoomAndPan):
(WebCore::SVGZoomAndPan::~SVGZoomAndPan):
(WebCore::SVGZoomAndPan::zoomAndPan):
* svg/SVGZoomEvent.h:
(WebCore::SVGZoomEvent::create):
* svg/animation/SMILTime.cpp:
(WebCore::operator*):
* svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
(WebCore::SMILTime::unresolved):
(WebCore::SMILTime::indefinite):
(WebCore::SMILTime::operator=):
(WebCore::SMILTime::value):
(WebCore::SMILTime::isFinite):
(WebCore::SMILTime::isIndefinite):
(WebCore::SMILTime::isUnresolved):
(WebCore::operator==):
(WebCore::operator!): new operator checks for 0 or infinite values.
(WebCore::operator!=):
(WebCore::operator>):
(WebCore::operator<):
(WebCore::operator>=):
(WebCore::operator<=):
* svg/animation/SMILTimeContainer.h:
(WebCore::SMILTimeContainer::create):
(WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
* svg/animation/SVGSMILElement.cpp:
(WebCore::ConditionEventListener::operator==):
(WebCore::SVGSMILElement::repeatingDuration):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
* svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::timeContainer):
(WebCore::SVGSMILElement::intervalBegin):
(WebCore::SVGSMILElement::intervalEnd):
(WebCore::SVGSMILElement::previousIntervalBegin):
(WebCore::SVGSMILElement::documentOrderIndex):
(WebCore::SVGSMILElement::setDocumentOrderIndex):
* svg/graphics/SVGImage.h:
(WebCore::SVGImage::create):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):
(WebCore::SVGImage::frameAtIndex):
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::create):
(WebCore::SVGFilterBuilder::lastEffect):
(WebCore::SVGFilterBuilder::getEffectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 30 Dec 2010 06:36:30 +0000 (06:36 +0000)]
2010-12-29 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
ASSERT(oldchild->parent() == owner) fails.
https://bugs.webkit.org/show_bug.cgi?id=50480
In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
assertion failure when removeChildNode executes on the child(equal to prev or next).
Fix a typo in canMergeContiguousAnonymousBlocks.
Test: fast/multicol/span/double-merge-anonymous-block-crash.html
* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next.
(WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.
2010-12-29 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that we do not crash when merging anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=50480
* fast/multicol/span/double-merge-anonymous-block-crash-expected.txt: Added.
* fast/multicol/span/double-merge-anonymous-block-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 30 Dec 2010 06:03:56 +0000 (06:03 +0000)]
2010-12-29 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
svn-apply updates date of wrong change log entry for a change log diff that
contains two consecutive entries with the same author and date
https://bugs.webkit.org/show_bug.cgi?id=46061
Fixes an issue where the date of the wrong change log entry may be modified.
Moreover, changes fixChangeLogPatch() to move entries inserted earlier
in a ChangeLog file to the top of the file.
Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
diff when it detects that the diff inserts a change log entry earlier in a
ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
change. With the advent of the commit-queue this functionality of bailing out
and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
Instead, we should always move the change log entry to the top of the ChangeLog file.
A side-effect of this change is that setChangeLogDateAndReviewer() now updates
the date line of the correct change log entry in a ChangeLog diff.
* Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
* Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
Updated the following unit tests now that we move entries inserted earlier to the top:
- "fixChangeLogPatch: New entry inserted in middle."
(formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
- "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
(formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
* Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 30 Dec 2010 05:43:31 +0000 (05:43 +0000)]
2010-12-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718
Test: svg/custom/scroll-to-anchor-in-symbol.svg
* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
2010-12-29 Justin Schuh <jschuh@chromium.org>
Reviewed by Darin Adler.
Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718
* svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
* svg/custom/scroll-to-anchor-in-symbol.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 30 Dec 2010 04:07:01 +0000 (04:07 +0000)]
2010-12-29 Anton Muhin <antonm@chromium.org>
Reviewed by Eric Seidel.
[v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
https://bugs.webkit.org/show_bug.cgi?id=51704
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWindowShell.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 30 Dec 2010 03:54:50 +0000 (03:54 +0000)]
2010-12-29 Zhenyao Mo <zmo@google.com>
Reviewed by Eric Seidel.
drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51726
* fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
* fast/canvas/webgl/draw-elements-out-of-bounds.html: Add test cases to verify the behavior.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Dec 2010 03:16:59 +0000 (03:16 +0000)]
2010-12-29 Konstantin Tokarev <annulen@yandex.ru>
Reviewed by Eric Seidel.
[Qt] Fixed compatibility with gold linker on X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=51700
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
Linked TestNetscapePlugin with libX11 on Unix platforms
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Dec 2010 03:16:05 +0000 (03:16 +0000)]
2010-12-29 Kenichi Ishibashi <bashi@google.com>
Reviewed by Darin Adler.
Use a HashMap for m_continuation to save memory
https://bugs.webkit.org/show_bug.cgi?id=43716
Saving memory consumption by applying a HashMap convention to
continuation pointers of RenderInline and RenderBlock classes.
* rendering/RenderBlock.cpp: Removed m_continuation.
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::inlineElementContinuation):
(WebCore::RenderBlock::blockElementContinuation):
* rendering/RenderBlock.h: Removed m_continuation.
* rendering/RenderBoxModelObject.cpp: Added a hash map for continuations.
(WebCore::RenderBoxModelObject::destroy): Added an assertion.
(WebCore::RenderBoxModelObject::continuation): Added.
(WebCore::RenderBoxModelObject::setContinuation): Added.
* rendering/RenderBoxModelObject.h:
* rendering/RenderInline.cpp: Removed m_continuation.
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::inlineElementContinuation):
* rendering/RenderInline.h: Removed m_continuation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 30 Dec 2010 02:08:39 +0000 (02:08 +0000)]
2010-12-29 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Darin Adler.
Circular dependency in webkitpy.common.checkout.changelog module
https://bugs.webkit.org/show_bug.cgi?id=50475
Remove automatic import of api.Checkout module when any checkout/
submodule is imported (e.g.: when checkout.scm.Git is imported).
* Scripts/webkitpy/common/checkout/__init__.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 01:16:51 +0000 (01:16 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Remove failing expectations for three Mac tests that no longer fail.
Remove failing expectations for two canvas tests that no longer crash
(r74561, which caused the failing assert, was rolled out with r74587).
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 01:05:53 +0000 (01:05 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
fast/js/numeric-escapes-in-string-literals.html fails because V8 does
not support ECMAScript strict mode.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 01:00:07 +0000 (01:00 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update. Mark two more inspector tests
as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 00:44:58 +0000 (00:44 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update. Mark a few more tests as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 00:14:49 +0000 (00:14 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
fast/canvas/shadow-offset-* are flaky when run in the GPU suite too.
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 30 Dec 2010 00:11:19 +0000 (00:11 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Make expectation for http/tests/media/reload-after-dialog.html not
trigger a duplication error for the debug Linux builder.
Remove expectation for platform/gtk/fast/text/emphasis-overlap.html, it
was removed in r74346.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 30 Dec 2010 00:00:24 +0000 (00:00 +0000)]
Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.
Reviewed by Sam Weinig.
JavaScriptCore:
* parser/Lexer.cpp:
(JSC::Lexer::parseString):
LayoutTests:
* fast/js/numeric-escapes-in-string-literals-expected.txt: Added.
* fast/js/numeric-escapes-in-string-literals.html: Added.
* fast/js/script-tests/numeric-escapes-in-string-literals.js: Added.
(test):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 29 Dec 2010 23:46:42 +0000 (23:46 +0000)]
2010-12-27 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] Enable building whatever already exists of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=37369
No new functionality added or deleted. Only makefile change. Hence, no tests added.
* GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and
added them to WebKit/gtk/GNUmakefile.am
* platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h>
and declare WEBKIT_API directly
2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] Enable building whatever already exists of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=37369
* GNUmakefile.am: Added.
* WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header
file for WebKit2 sources files.
* gtk: Added.
* gtk/webkit2.pc.in: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 29 Dec 2010 22:58:39 +0000 (22:58 +0000)]
2010-12-29 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+.
* webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 29 Dec 2010 22:57:28 +0000 (22:57 +0000)]
2010-12-29 Eric Seidel <eric@webkit.org>
Unreviewed.
Simplify make-hash-tools.pl
https://bugs.webkit.org/show_bug.cgi?id=49922
Added HashTools.h to the project file now that its not autogenerated.
I also sorted the project file using sort-xcode-project-file
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 29 Dec 2010 22:56:45 +0000 (22:56 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update. Mark another test as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 29 Dec 2010 22:34:37 +0000 (22:34 +0000)]
2010-12-29 Martin Robinson <mrobinson@igalia.com>
[GTK] GSettings warning is concealing real warnings on the build bots
https://bugs.webkit.org/show_bug.cgi?id=51691
Reviewed by Xan Lopez.
Do not print the GSettings warning message when running in DumpRenderTree.
* webkit/webkitwebinspector.cpp:
(inspectorGSettings): Do not print the GSettings warning if we are running
in DumpRenderTree. This should clean up the test results page a great deal.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 29 Dec 2010 22:22:10 +0000 (22:22 +0000)]
2010-12-29 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: revert r74755 and 74757.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 29 Dec 2010 22:20:51 +0000 (22:20 +0000)]
2010-12-29 Martin Robinson <mrobinson@igalia.com>
Reviewed by Sam Weinig.
JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
https://bugs.webkit.org/show_bug.cgi?id=51722
Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
methods the fastcall calling convention, which leads to runtime errors when they are
called from C++. Also remove a bit of unnecessary code duplication.
No new tests. This is covered by fast/canvas/webgl/data-view-test.html.
* bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember): Remove duplicated code.
(WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL.
(WebCore::JSDataView::getUint8): Ditto.
(WebCore::JSDataView::getFloat32): Ditto.
(WebCore::JSDataView::getFloat64): Ditto.
(WebCore::setDataViewMember): Remove duplicated code.
(WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL.
(WebCore::JSDataView::setUint8): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 29 Dec 2010 22:18:42 +0000 (22:18 +0000)]
A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681
Reviewed by Kenneth Russel.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
attach-type style recalc.
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
(WebCore::CanvasRenderingContext2D::accessFont): Added a call to
Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
and update the font if it is invalid.
* platform/graphics/Font.h:
(WebCore::Font::loadingCustomFonts): Made this private.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 29 Dec 2010 21:43:04 +0000 (21:43 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
fast/canvas/webgl/tex-image-with-format-and-type.html is flaky in
the GPU suite too.
* platform/chromium/test_expectations.txt:
* platform/chromium-gpu/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 29 Dec 2010 21:39:14 +0000 (21:39 +0000)]
2010-12-29 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Qt build fix.
* inspector/InspectorController.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 29 Dec 2010 21:38:32 +0000 (21:38 +0000)]
2010-12-29 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium expectations update.
Remove failure expectations for tests that no longer fail:
- fast/images/svg-as-background.html has not timed out for as long as
the flakiness dashboard has history
- svg/W3C-SVG-1.1/animate-elem-03-t.svg has not failed for as long as
the flakiness dashboard has history
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit.git / log